58b255bf26788bdbfaefc3090044160c57636d6a
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-05-20  Jer Noble  <jer.noble@apple.com>
2
3         Unreviewed build fix; WebActionMenuController.mm should directly include LocalizedStrings.h
4
5         * WebView/WebActionMenuController.mm:
6
7 2015-05-19  Jer Noble  <jer.noble@apple.com>
8
9         Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
10         https://bugs.webkit.org/show_bug.cgi?id=145193
11
12         Reviewed by Eric Carlson.
13
14         Use HTMLMediaElementEnums instead of HTMLMediaElement.
15
16         * WebCoreSupport/WebChromeClient.h:
17         * WebCoreSupport/WebChromeClient.mm:
18         (WebChromeClient::enterVideoFullscreenForVideoElement): HTMLMediaElement -> HTMLMediaElementEnums.
19         * WebView/WebView.mm:
20         (-[WebView _enterVideoFullscreenForVideoElement:mode:]): Ditto.
21         * WebView/WebViewInternal.h:
22
23 2015-05-19  Michael Saboff  <msaboff@apple.com>
24
25         REGRESSION(183787): JIT is enabled for all builds
26         https://bugs.webkit.org/show_bug.cgi?id=145179
27
28         Reviewed by Geoffrey Garen.
29
30         Eliminated the setting of ENABLE_JIT, as wtf/Platform.h has appropriate logic to
31         set it depending on OS and CPU type.
32
33         * Configurations/FeatureDefines.xcconfig:
34
35 2015-05-19  Brady Eidson  <beidson@apple.com>
36
37         X-Frame-Options headers not respected when loading from application cache.
38         <rdar://problem/14877623> and https://bugs.webkit.org/show_bug.cgi?id=131800
39
40         Reviewed by Alexey Proskuryakov.
41
42         * WebView/WebFrame.mm:
43         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
44
45 2015-05-18  Skachkov Alexandr  <gskachkov@gmail.com>
46
47         [ES6] Arrow function syntax. Feature flag for arrow function
48         https://bugs.webkit.org/show_bug.cgi?id=145108
49
50         Reviewed by Ryosuke Niwa.
51
52         Added feature flag ENABLE_ES6_ARROWFUNCTION_SYNTAX for arrow function
53
54         * Configurations/FeatureDefines.xcconfig:
55
56 2015-05-15  Jeremy Jones  <jeremyj@apple.com>
57
58         Limit alternate fullscreen with linked on or after.
59         https://bugs.webkit.org/show_bug.cgi?id=144894
60
61         Reviewed by Dean Jackson.
62
63         * WebView/WebView.mm:
64         (shouldAllowAlternateFullscreen): Added.
65         (-[WebView _preferencesChanged:]):
66
67 2015-05-12  Simon Fraser  <simon.fraser@apple.com>
68
69         Turn antialiased font dilation off by default
70         https://bugs.webkit.org/show_bug.cgi?id=144940
71         rdar://problem/20923031
72
73         Reviewed by Sam Weinig.
74         
75         Turn antialised font dilation off by default.
76
77         * WebView/WebPreferences.mm:
78         (+[WebPreferences initialize]):
79
80 2015-05-11  Daniel Bates  <dabates@apple.com>
81
82         [iOS] Close all open databases in expiration handler of process assertion
83         https://bugs.webkit.org/show_bug.cgi?id=144661
84         <rdar://problem/20845052>
85
86         Reviewed by Darin Adler.
87
88         For Legacy WebKit, close all open databases when the process assertion expiration
89         handler is called.
90
91         * Storage/WebDatabaseManager.mm:
92         (+[WebDatabaseManager startBackgroundTask]): Call DatabaseTracker::tracker().closeAllDatabases()
93         in the expiration handler to close all open databases. As a side effect of closing
94         a database all in-progress database transactions are interrupted.
95
96 2015-05-10  Sungmann Cho  <sungmann.cho@navercorp.com>
97
98         Get rid of the public item accessors in BackForwardClient
99         https://bugs.webkit.org/show_bug.cgi?id=144827
100
101         Reviewed by Darin Adler.
102
103         Remove backItem(), currentItem(), and forwardItem() from BackForwardClient.
104         We can still use these functionalities through BackForwardController.
105
106         No new tests, no behavior change.
107
108         * WebView/WebView.mm:
109         (-[WebView _loadBackForwardListFromOtherView:]):
110
111 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
112
113         Remove the PICTURE_SIZES build flag
114         https://bugs.webkit.org/show_bug.cgi?id=144679
115
116         Reviewed by Benjamin Poulain.
117
118         Removed the PICTURE_SIZES build time flag.
119
120         * Configurations/FeatureDefines.xcconfig:
121
122 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
123
124         Remove convenience constructors for TextRun
125         https://bugs.webkit.org/show_bug.cgi?id=144752
126
127         These convenience constructors are unnecessary. Moving the code that makes the StringView
128         back to the call site will also help us make things more elegant in future refactoring.
129
130         Reviewed by Darin Adler.
131
132         No new tests because there is no behavior change.
133
134         * Misc/WebKitNSStringExtras.mm:
135         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
136         (-[NSString _web_widthWithFont:]):
137
138 2015-05-08  Commit Queue  <commit-queue@webkit.org>
139
140         Unreviewed, rolling out r183996.
141         https://bugs.webkit.org/show_bug.cgi?id=144806
142
143         ASan detected use-after free (Requested by ap on #webkit).
144
145         Reverted changeset:
146
147         "Remove convenience constructors for TextRun"
148         https://bugs.webkit.org/show_bug.cgi?id=144752
149         http://trac.webkit.org/changeset/183996
150
151 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
152
153         Remove convenience constructors for TextRun
154         https://bugs.webkit.org/show_bug.cgi?id=144752
155
156         These convenience constructors are unnecessary. Moving the code that makes the StringView
157         back to the call site will also help us make things more elegant in future refactoring.
158
159         Reviewed by Darin Adler.
160
161         No new tests because there is no behavior change.
162
163         * Misc/WebKitNSStringExtras.mm:
164         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
165         (-[NSString _web_widthWithFont:]):
166
167 2015-05-07  Anders Carlsson  <andersca@apple.com>
168
169         Build fixes.
170
171         * Misc/WebNSPasteboardExtras.mm:
172         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
173         * WebView/WebHTMLView.mm:
174         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
175         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
176         * WebView/WebPDFView.mm:
177         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
178         Pass empty arrays and dictionaries instead of nil.
179
180         * WebView/WebView.mm:
181         (-[WebView _commonInitializationWithFrameName:groupName:]):
182         Use the regular init method.
183
184 2015-05-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
185
186         Fix iPhone 6 iOS simulator Build.
187         following http://trac.webkit.org/changeset/183954.
188
189         Reviewed by Daniel Bates.
190
191         * WebView/WebHTMLView.mm:
192         (-[WebHTMLView pressureChangeWithEvent:]):
193
194 2015-05-07  Timothy Horton  <timothy_horton@apple.com>
195
196         Occasional null deref in WebImmediateActionController
197         https://bugs.webkit.org/show_bug.cgi?id=144772
198         <rdar://problem/20811128>
199
200         Reviewed by Beth Dakin.
201
202         * WebView/WebImmediateActionController.mm:
203         (-[WebImmediateActionController _defaultAnimationController]):
204         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
205         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
206         Null-check TextIndicators before dereferencing.
207
208 2015-05-07  Beth Dakin  <bdakin@apple.com>
209
210         New force-related DOM events should fire in WK1 views
211         https://bugs.webkit.org/show_bug.cgi?id=144663
212         -and corresponding-
213         rdar://problem/20281886
214
215         Reviewed by Sam Weinig.
216
217         Pass the lastPressureEvent to WebCore.
218         * WebView/WebHTMLView.mm:
219         (-[WebHTMLView _updateMouseoverWithEvent:]):
220         (-[WebHTMLView rightMouseUp:]):
221         (-[WebHTMLView menuForEvent:]):
222         (-[WebHTMLView acceptsFirstMouse:]):
223         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
224         (-[WebHTMLView mouseDown:mouseDown:]):
225         (-[WebHTMLView mouseDragged:]):
226         (-[WebHTMLView mouseUp:mouseUp:]):
227
228         New NSRespnder method for pressure changes.
229         (-[WebHTMLView pressureChangeWithEvent:]):
230
231         New BOOL _contentPreventsDefault tracks whether the HitTestResult prevented the 
232         default action. Get rid of willHandleMouseDown; now that the gesture recognizer 
233         sets delaysPrimaryMouseButtonEvents to NO, we don’t need this.
234         * WebView/WebImmediateActionController.h:
235         * WebView/WebImmediateActionController.mm:
236         (-[WebImmediateActionController _clearImmediateActionState]):
237
238         Set all of the immediateActionStages on EventHandler. This is critical to keep 
239         link navigation happening at the right time now that 
240         delaysPrimaryMouseButtonEvents is set to NO.
241         (-[WebImmediateActionController performHitTestAtPoint:]):
242         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
243         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
244         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
245
246         Use a dummy animation controller if the content prevents default.
247         (-[WebImmediateActionController _defaultAnimationController]):
248         (-[WebImmediateActionController _updateImmediateActionItem]):
249         (-[WebImmediateActionController webView:willHandleMouseDown:]): Deleted.
250
251         Set delaysPrimaryMouseButtonEvents to NO so that we get existing mouse events when 
252         we expect to.
253         * WebView/WebView.mm:
254         (-[WebView _commonInitializationWithFrameName:groupName:]):
255
256         Cache the most recent pressure event so that we can send it to WebCore for all of 
257         the mouse events.
258         (-[WebView _pressureEvent]):
259         (-[WebView _setPressureEvent:]):
260         * WebView/WebViewData.h:
261         * WebView/WebViewData.mm:
262         (-[WebViewPrivate dealloc]):
263         * WebView/WebViewInternal.h:
264
265 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
266
267         Revert "Introducing the Platform Abstraction Layer (PAL)"
268         https://bugs.webkit.org/show_bug.cgi?id=144751
269
270         Unreviewed.
271
272         PAL should be a new target inside WebCore, rather than a top-level folder.
273
274         * Configurations/FeatureDefines.xcconfig: Updated
275
276 2015-05-07  Dan Bernstein  <mitz@apple.com>
277
278         <rdar://problem/19317140> [Xcode] Remove usage of AspenFamily.xcconfig in Source/
279         https://bugs.webkit.org/show_bug.cgi?id=144727
280
281         Reviewed by Darin Adler.
282
283         * Configurations/Base.xcconfig: Don’t include AspenFamily.xcconfig.
284         * Configurations/WebKitLegacy.xcconfig: Define INSTALL_PATH in terms of
285         INSTALL_PATH_PREFIX and INSTALL_PATH_ACTUAL, and define INSTALL_PATH_PREFIX for the iOS 8.x
286         Simulator.
287
288 2015-04-02  Myles C. Maxfield  <mmaxfield@apple.com>
289
290         Introducing the Platform Abstraction Layer (PAL)
291         https://bugs.webkit.org/show_bug.cgi?id=143358
292
293         Reviewed by Simon Fraser.
294
295         * Configurations/FeatureDefines.xcconfig: Updated
296
297 2015-05-06  Antti Koivisto  <antti@apple.com>
298
299         REGRESSION (r183467): Unable to start downloads in private browsing mode
300         https://bugs.webkit.org/show_bug.cgi?id=144533
301
302         Reviewed by Darin Adler.
303
304         * WebCoreSupport/WebFrameLoaderClient.mm:
305         (WebFrameLoaderClient::dispatchWillSendRequest):
306
307             Use updateFromDelegatePreservingOldProperties (like WK2) instead of doing the same thing manually.
308
309 2015-05-06  Ryosuke Niwa  <rniwa@webkit.org>
310
311         Toggling underline on font panel removes strike through
312         https://bugs.webkit.org/show_bug.cgi?id=144670
313         <rdar://problem/3790443>
314
315         Reviewed by Darin Adler.
316
317         Use setStrikeThroughChange and setUnderlineChange added in r183770 to toggle underline and strike through.
318
319         * WebView/WebHTMLView.mm:
320         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
321         (-[WebHTMLView _styleForAttributeChange:]):
322         (-[WebHTMLView changeAttributes:]):
323
324 2015-05-04  Ryosuke Niwa  <rniwa@webkit.org>
325
326         Toggling underline or strike through affects each other
327         https://bugs.webkit.org/show_bug.cgi?id=27818
328
329         Reviewed by Darin Adler.
330
331         * WebView/WebFrame.mm:
332         (-[WebFrame _setTypingStyle:withUndoAction:]):
333
334 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
335
336         USE(...) macro should expect unprefixed variables
337         https://bugs.webkit.org/show_bug.cgi?id=144454
338
339         Reviewed by Daniel Bates.
340
341         * Misc/WebDownload.h: Replace all occurrences WTF_USE with USE.
342
343 2015-05-01  Brady Eidson  <beidson@apple.com>
344
345         Add API to disable meta refreshes.
346         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
347
348         Reviewed by Alexey Proskuryakov.
349
350         Add a preference to enable/disable meta refreshes, enabled by default.
351
352         * WebView/WebPreferenceKeysPrivate.h:
353         * WebView/WebPreferences.mm:
354         (+[WebPreferences initialize]):
355         (-[WebPreferences setMetaRefreshEnabled:]):
356         (-[WebPreferences metaRefreshEnabled]):
357         * WebView/WebPreferencesPrivate.h:
358         * WebView/WebView.mm:
359         (-[WebView _preferencesChanged:]):
360
361 2015-04-30  Jon Davis  <jond@apple.com>
362
363         Web Inspector: console should show an icon for console.info() messages
364         https://bugs.webkit.org/show_bug.cgi?id=18530
365
366         Reviewed by Timothy Hatcher.
367
368         * WebCoreSupport/WebChromeClient.mm:
369         (stringForMessageLevel):
370         * WebView/WebUIDelegatePrivate.h:
371
372 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
373
374         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
375         https://bugs.webkit.org/show_bug.cgi?id=132159
376
377         Reviewed by Darin Adler.
378
379         Add SPI to set the font whitelist.
380
381         * WebView/WebView.mm:
382         (+[WebView _setFontWhitelist:]):
383         * WebView/WebViewPrivate.h:
384
385 2015-04-28  Timothy Horton  <timothy_horton@apple.com>
386
387         [TextIndicator] Yellow highlight takes too long to fade out on scroll
388         https://bugs.webkit.org/show_bug.cgi?id=144358
389         <rdar://problem/19451011>
390
391         Reviewed by Beth Dakin.
392
393         * WebView/WebActionMenuController.mm:
394         (-[WebActionMenuController _showTextIndicator]):
395         * WebView/WebHTMLView.mm:
396         (-[WebHTMLView quickLookWithEvent:]):
397         * WebView/WebImmediateActionController.mm:
398         (-[WebImmediateActionController _defaultAnimationController]):
399         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
400         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
401         Pull _clearTextIndicatorWithAnimation out, make it avoid using a dismissal animation
402         if we're called from didHandleScrollWheel.
403
404         * WebView/WebView.mm:
405         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
406         (-[WebView _setTextIndicator:]):
407         (-[WebView _setTextIndicator:withLifetime:]):
408         (-[WebView _clearTextIndicator]):
409         (-[WebView _showDictionaryLookupPopup:]):
410         (-[WebView _dictionaryLookupPopoverWillClose:]):
411         (-[WebView _setTextIndicator:fadeOut:]): Deleted.
412         * WebView/WebViewInternal.h:
413         Make _setTextIndicator take a reference.
414         Add a variant of _setTextIndicator that takes a Lifetime.
415         Make _clearTextIndicatorWithAnimation take a DismissalAnimation.
416
417 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
418
419         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
420         https://bugs.webkit.org/show_bug.cgi?id=144304
421
422         Reviewed by Geoffrey Garen.
423
424         Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
425
426         * Configurations/FeatureDefines.xcconfig:
427
428 2015-04-28  Commit Queue  <commit-queue@webkit.org>
429
430         Unreviewed, rolling out r183514.
431         https://bugs.webkit.org/show_bug.cgi?id=144359
432
433         It broke cloop test bots (Requested by mcatanzaro on #webkit).
434
435         Reverted changeset:
436
437         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
438         https://bugs.webkit.org/show_bug.cgi?id=144304
439         http://trac.webkit.org/changeset/183514
440
441 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
442
443         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
444         https://bugs.webkit.org/show_bug.cgi?id=144304
445
446         Reviewed by Geoffrey Garen.
447
448         Define ENABLE_JIT, enabled by default, instead of ENABLE_LLINT_C_LOOP, disabled by default.
449
450         * Configurations/FeatureDefines.xcconfig:
451
452 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
453
454         Fix common typo "targetting" => "targeting"
455         https://bugs.webkit.org/show_bug.cgi?id=144349
456
457         Reviewed by Daniel Bates.
458
459         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
460         (WebKit::NetscapePluginInstanceProxy::loadRequest):
461         * Plugins/WebNetscapePluginView.mm:
462         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
463         * WebView/WebPolicyDelegate.h:
464
465 2015-04-28  Brady Eidson  <beidson@apple.com>
466
467         Consolidate most "frame load" arguments into FrameLoadRequest.
468         https://bugs.webkit.org/show_bug.cgi?id=144276
469
470         Reviewed by Alexey Proskuryakov.
471
472         * WebView/WebPDFView.mm:
473         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
474
475 2015-04-27  Dan Bernstein  <mitz@apple.com>
476
477         <rdar://problem/20721931> REGRESSION (r178753): All legacy framework headers are missing availability annotations
478         https://bugs.webkit.org/show_bug.cgi?id=144311
479
480         Reviewed by Adele Peterson.
481
482         * postprocess-headers.sh: Changed “macsox” to “macosx”.
483
484 2015-04-27  Brady Eidson  <beidson@apple.com>
485
486         Make 'enum NavigationType' be an enum class
487         https://bugs.webkit.org/show_bug.cgi?id=144270
488
489         Reviewed by Alex Christensen.
490
491         * WebCoreSupport/WebFrameLoaderClient.mm:
492         (WebFrameLoaderClient::actionDictionary):
493
494 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
495
496         REGRESSION(r182879): Images and video can no longer be downloaded
497         https://bugs.webkit.org/show_bug.cgi?id=144267
498         <rdar://problem/20702844>
499
500         Reviewed by Simon Fraser.
501
502         * WebView/WebActionMenuController.mm:
503         (-[WebActionMenuController _createActionMenuItemForTag:]): Check for
504         "!WebCore::protocolIs(..., "file")" for image and media downloads.
505
506 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
507
508         [ES6] Implement ES6 template literals
509         https://bugs.webkit.org/show_bug.cgi?id=142691
510
511         Reviewed by Darin Adler.
512
513         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
514
515         * Configurations/FeatureDefines.xcconfig:
516
517 2015-04-26  Doug Russell  <d_russell@apple.com>
518
519         AX: richer text change notifications (142719)
520         https://bugs.webkit.org/show_bug.cgi?id=142719
521
522         Reviewed by Darin Adler.
523
524         Richer accessibility value change notifications. Introduce AXTextEditType,
525         postTextStateChangeNotification and postTextReplacementNotification to give assistive
526         tech apps more reliable context for responding to changes in web content. Also implement
527         a mechanism to post value changes in password form fields in coalesced ticks to thwart
528         analyzing the cadence of changes.
529
530         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
531         and an overload of postTextReplacementNotification to give assistive tech apps more
532         reliable context for responding to changes in web content selection. Also block posting
533         selection changes on password fields.
534
535         * WebCoreSupport/WebEditorClient.mm:
536         (undoNameForEditAction):
537
538 2015-04-24  Timothy Hatcher  <timothy@apple.com>
539
540         Web Inspector: Remove native window dock controls
541         https://bugs.webkit.org/show_bug.cgi?id=144184
542
543         Reviewed by Joseph Pecoraro.
544
545         * Resources/Dock.pdf: Removed.
546         * Resources/DockLegacy.pdf: Removed.
547         * WebCoreSupport/WebInspectorClient.mm:
548         (-[WebInspectorWindowController window]):
549         (-[WebInspectorWindowController setDockingUnavailable:]):
550
551 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
552
553         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
554         https://bugs.webkit.org/show_bug.cgi?id=144182
555
556         Reviewed by Simon Fraser.
557
558         * Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
559
560 2015-04-24  Commit Queue  <commit-queue@webkit.org>
561
562         Unreviewed, rolling out r183266.
563         https://bugs.webkit.org/show_bug.cgi?id=144164
564
565         Broke 32-bit build and a test. (Requested by ap on #webkit).
566
567         Reverted changeset:
568
569         "AX: richer text change notifications (142719)"
570         https://bugs.webkit.org/show_bug.cgi?id=142719
571         http://trac.webkit.org/changeset/183266
572
573 2015-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
574
575         [Cocoa] Start cleaning up FontPlatformData
576         https://bugs.webkit.org/show_bug.cgi?id=144133
577
578         Reviewed by Enrica Casucci.
579
580         Receive casts which have been hoisted from the deleted FontPlatformData constructor.
581
582         * Misc/WebKitNSStringExtras.mm:
583         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has
584         been hoisted from the deleted FontPlatformData constructor.
585         (-[NSString _web_widthWithFont:]): Ditto.
586         * Misc/WebStringTruncator.mm:
587         (fontFromNSFont): Ditto.
588
589 2015-04-24  Doug Russell  <d_russell@apple.com>
590
591         AX: richer text change notifications (142719)
592         https://bugs.webkit.org/show_bug.cgi?id=142719
593
594         Reviewed by Darin Adler.
595
596         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
597
598         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
599
600         * WebCoreSupport/WebEditorClient.mm:
601         (undoNameForEditAction):
602
603 2015-04-23  Jer Noble  <jer.noble@apple.com>
604
605         [Mac] Disable QTKit by default on future OS X.
606         https://bugs.webkit.org/show_bug.cgi?id=144082
607
608         Reviewed by Darin Adler.
609
610         Default WebKitQTKitEnabledPreferenceKey to NO.
611
612         * WebView/WebPreferences.mm:
613         (+[WebPreferences initialize]):
614
615 2015-04-23  Andreas Kling  <akling@apple.com>
616
617         There should only be one way to get the system memory size.
618         <https://webkit.org/b/144081>
619
620         Reviewed by Antti Koivisto.
621
622         * Misc/WebKitSystemBits.h:
623         * Misc/WebKitSystemBits.m:
624         (WebMemorySize): Deleted.
625         * WebView/WebView.mm:
626         (+[WebView _setCacheModel:]):
627         (roundUpToPowerOf2): Deleted.
628
629 2015-04-22  Darin Adler  <darin@apple.com>
630
631         Remove OwnPtr and PassOwnPtr use from WebKit/cf, WebKit/mac, and WebKit2
632         https://bugs.webkit.org/show_bug.cgi?id=143943
633
634         Reviewed by Anders Carlsson.
635
636         * Plugins/Hosted/ProxyInstance.h: Removed unneeded include.
637         * Plugins/WebBaseNetscapePluginView.h: Ditto.
638
639         * Plugins/WebNetscapePluginEventHandler.h: Use unique_ptr instead of
640         PassOwnPtr for the create function. Also tweaked formatting and removed
641         unneeded forward declaration of CGRect.
642         * Plugins/WebNetscapePluginEventHandler.mm:
643         (WebNetscapePluginEventHandler::create): Changed to use unique_ptr and
644         make_unique.
645
646         * Plugins/WebNetscapePluginView.h: Use unique_ptr instead of OwnPtr for
647         the _eventHandler field.
648         * Plugins/WebNetscapePluginView.mm:
649         (-[WebNetscapePluginView destroyPlugin]): Changed code to work with unique_ptr.
650
651         * WebCoreSupport/WebUserMediaClient.mm: Removed unneeded include.
652
653         * WebView/WebDeviceOrientationProviderMock.mm: Changed to use make_unique.
654         * WebView/WebDeviceOrientationProviderMockInternal.h: Changed to use unique_ptr.
655
656         * WebView/WebFrame.mm:
657         (vectorForDictationPhrasesArray): Changed to return Vector<Vector<String>> and
658         not a PassOwnPtr. Also rewrote to be much simpler, although there is still a
659         pre-existing problem here where this could put empty vectors into the result,
660         and I'm pretty sure the client never expects any of the Vector<String> to be empty.
661         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
662         Rewrote logic to involve WebCore types a bit less; old code was round tripping
663         things through WebCore::URL for no obvious reason.
664
665         * WebView/WebFrameInternal.h: Changed vectorForDictationPhrasesArray to return
666         a Vector<Vector<String>> and not a PassOwnPtr.
667
668         * WebView/WebFullScreenController.h: Removed unneeded include.
669
670         * WebView/WebViewData.h: Changed m_alternativeTextUIController to be a
671         m_alternativeTextUIController.
672         * WebView/WebViewData.mm:
673         (-[WebViewPrivate init]): Use make_unique to initialize m_alternativeTextUIController.
674
675 2015-04-22  Brent Fulgham  <bfulgham@apple.com>
676
677         VisibleSelection should only accept Range by reference
678         https://bugs.webkit.org/show_bug.cgi?id=144047
679
680         Reviewed by Tim Horton.
681
682         Update all uses of VisibleSelection to pass a Range reference instead
683         of a Range pointer.
684
685         * WebCoreSupport/WebContextMenuClient.mm:
686         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
687         * WebView/WebFrame.mm:
688         (-[WebFrame _selectNSRange:]):
689
690 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
691
692         [Mac] Device picker menu is positioned incorrectly in WK1
693         https://bugs.webkit.org/show_bug.cgi?id=144049
694         <rdar://problem/20493101>
695
696         Reviewed by Dean Jackson.
697
698         * WebView/WebView.mm:
699         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
700             window coordinates so don't call convertRect:toView:nil.
701
702 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
703
704         Extend action menus to support PDF
705         https://bugs.webkit.org/show_bug.cgi?id=143895
706         <rdar://problem/19003333>
707
708         Reviewed by Tim Horton.
709
710         Prevent a crash when someone attempts to invoke an action menu on a PDF hosted
711         in a WK1 view.
712
713         * WebView/WebActionMenuController.mm:
714         (-[WebActionMenuController performHitTestAtPoint:]): Handle WebPDFView as well as
715         the WebHTMLView case.
716         * WebView/WebDocument.h:
717         * WebView/WebHTMLView.h:
718         * WebView/WebHTMLView.mm:
719         (-[WebHTMLView _frame]):
720         * WebView/WebHTMLViewInternal.h:
721         * WebView/WebPDFView.h:
722         * WebView/WebPDFView.mm:
723         (-[WebPDFView _frame]): Added.
724
725 2015-04-22  Eric Carlson  <eric.carlson@apple.com>
726
727         Unreviewed post-review clean up after r183096.
728
729         * WebView/WebMediaPlaybackTargetPicker.h:
730
731 2015-04-21  Eric Carlson  <eric.carlson@apple.com>
732
733         [Mac] Use one playback target for all web processes
734         https://bugs.webkit.org/show_bug.cgi?id=144009
735
736         Reviewed by Tim Horton.
737
738         Update to use WebMediaSessionManager for playback target management.
739
740         * WebCoreSupport/WebChromeClient.h:
741         * WebCoreSupport/WebChromeClient.mm:
742         (WebChromeClient::addPlaybackTargetPickerClient):
743         (WebChromeClient::removePlaybackTargetPickerClient):
744         (WebChromeClient::showPlaybackTargetPicker):
745         (WebChromeClient::playbackTargetPickerClientStateDidChange):
746         (WebChromeClient::startingMonitoringPlaybackTargets): Deleted.
747         (WebChromeClient::stopMonitoringPlaybackTargets): Deleted.
748         * WebView/WebMediaPlaybackTargetPicker.h:
749         * WebView/WebMediaPlaybackTargetPicker.mm:
750         (WebMediaPlaybackTargetPicker::addPlaybackTargetPickerClient):
751         (WebMediaPlaybackTargetPicker::removePlaybackTargetPickerClient):
752         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
753         (WebMediaPlaybackTargetPicker::playbackTargetPickerClientStateDidChange):
754         (WebMediaPlaybackTargetPicker::setPlaybackTarget):
755         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange):
756         (WebMediaPlaybackTargetPicker::setShouldPlayToPlaybackTarget):
757         (WebMediaPlaybackTargetPicker::invalidate):
758         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): Deleted.
759         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): Deleted.
760         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Deleted.
761         (WebMediaPlaybackTargetPicker::targetPicker): Deleted.
762         * WebView/WebView.mm:
763         (-[WebView _addPlaybackTargetPickerClient:]):
764         (-[WebView _removePlaybackTargetPickerClient:]):
765         (-[WebView _showPlaybackTargetPicker:location:hasVideo:]):
766         (-[WebView _playbackTargetPickerClientStateDidChange:state:]):
767         (-[WebView _showPlaybackTargetPicker:hasVideo:]): Deleted.
768         (-[WebView _startingMonitoringPlaybackTargets]): Deleted.
769         (-[WebView _stopMonitoringPlaybackTargets]): Deleted.
770         * WebView/WebViewInternal.h:
771
772 2015-04-20  Alexey Proskuryakov  <ap@apple.com>
773
774         Disable mixed content blocking for existing WebKit1 clients
775         https://bugs.webkit.org/show_bug.cgi?id=143955
776         rdar://problem/20177186
777
778         Reviewed by Oliver Hunt.
779
780         * Misc/WebKitVersionChecks.h:
781         * WebView/WebView.mm:
782         (shouldAllowInsecureContent):
783         (-[WebView _preferencesChanged:]):
784
785 2015-04-20  Tim Horton  <timothy_horton@apple.com>
786
787         Implement immediate action support for tel: and mailto: URLs
788         https://bugs.webkit.org/show_bug.cgi?id=143916
789         <rdar://problem/19721711>
790
791         Reviewed by Darin Adler.
792
793         * WebView/WebImmediateActionController.mm:
794         (-[WebImmediateActionController _defaultAnimationController]):
795         (-[WebImmediateActionController _animationControllerForDataDetectedText]):
796         (-[WebImmediateActionController _animationControllerForDataDetectedLink]):
797         (-[WebImmediateActionController _menuItemForDataDetectedText]): Deleted.
798         * WebView/WebUIDelegatePrivate.h:
799         Add _animationControllerForDataDetectedLink and use it when
800         building immediate actions for tel: and mailto: links.
801
802 2015-04-17  Daniel Bates  <dabates@apple.com>
803
804         REGRESSION: SVG does not support link dragging
805         https://bugs.webkit.org/show_bug.cgi?id=141597
806
807         Reviewed by Darin Adler.
808
809         Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
810
811         * Misc/WebElementDictionary.mm:
812         (-[WebElementDictionary _isLiveLink]):
813
814 2015-04-16  Sam Weinig  <sam@webkit.org>
815
816         Expose JavaScriptMarkupEnabled preference for WebKit1
817         <rdar://problem/19939450>
818         https://bugs.webkit.org/show_bug.cgi?id=143855
819
820         Reviewed by Dan Bernstein.
821
822         * WebView/WebPreferenceKeysPrivate.h:
823         Add new key, WebKitJavaScriptMarkupEnabledPreferenceKey
824
825         * WebView/WebPreferences.mm:
826         (+[WebPreferences initialize]):
827         Initialize WebKitJavaScriptMarkupEnabledPreferenceKey to YES.
828
829         (-[WebPreferences isJavaScriptMarkupEnabled]):
830         (-[WebPreferences setJavaScriptMarkupEnabled:]):
831         Implement getter/setter.
832
833         * WebView/WebPreferencesPrivate.h:
834         Add new property, javaScriptMarkupEnabled.
835
836         * WebView/WebView.mm:
837         (-[WebView _preferencesChanged:]):
838         Map the new preference to WebCore's scriptMarkupEnabled setting.
839
840 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
841
842         [Mac] Disable "Save to Downloads" option for local files
843         https://bugs.webkit.org/show_bug.cgi?id=143794
844
845         Reviewed by Tim Horton.
846
847         Disable the Image and Media download options if the download
848         target is a local file. We can only download web resources;
849         anything else is actually a no-op.
850
851         * WebView/WebActionMenuController.mm:
852         (-[WebActionMenuController _defaultMenuItemsForImage]):
853         (-[WebActionMenuController _defaultMenuItemsForVideo]):
854
855 2015-04-15  Alex Christensen  <achristensen@webkit.org>
856
857         Progress towards CMake on Mac.
858         https://bugs.webkit.org/show_bug.cgi?id=143785
859
860         Reviewed by Csaba Osztrogonác.
861
862         * WebView/WebPDFDocumentExtras.mm:
863         * WebView/WebPDFView.mm:
864
865 2015-04-13  Jer Noble  <jer.noble@apple.com>
866
867         [Fullscreen] ChromeClient::exitVideoFullscreen() should take a pointer to a HTMLVideoElement.
868         https://bugs.webkit.org/show_bug.cgi?id=143674
869
870         Reviewed by Darin Adler.
871
872         * WebCoreSupport/WebChromeClient.h:
873         * WebCoreSupport/WebChromeClient.mm:
874         (WebChromeClient::enterVideoFullscreenForVideoElement): Takes a reference.
875         (WebChromeClient::exitVideoFullscreenForVideoElement): Renamed from exitVideoFullscreen().
876         (WebChromeClient::exitVideoFullscreen): Deleted.
877
878 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
879
880         Re-enable custom dilation for antialiased fonts
881         https://bugs.webkit.org/show_bug.cgi?id=143738
882
883         Reviewed by Tim Horton.
884         
885         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
886         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
887         a private WebKit pref. This pref defaults to YES, enabling the feature by default
888         in WK1 as we do for WK2.
889
890         * WebView/WebPreferenceKeysPrivate.h:
891         * WebView/WebPreferences.mm:
892         (+[WebPreferences initialize]):
893         (-[WebPreferences setAntialiasedFontDilationEnabled:]):
894         (-[WebPreferences antialiasedFontDilationEnabled]):
895         * WebView/WebPreferencesPrivate.h:
896         * WebView/WebView.mm:
897         (-[WebView _preferencesChanged:]):
898
899 2015-04-13  Brady Eidson  <beidson@apple.com>
900
901         Share sheets from Share menus appear outside the browser window.
902         <rdar://problem/20455592> and https://bugs.webkit.org/show_bug.cgi?id=143620
903
904         Reviewed by Darin Adler.
905
906         Refactor existing Sharing Service Picker code to also be used for the Share menu NSMenuItem.
907
908         * Misc/WebSharingServicePickerController.h:
909         (WebSharingServicePickerClient::webView):
910         * Misc/WebSharingServicePickerController.mm:
911         (WebSharingServicePickerClient::WebSharingServicePickerClient):
912         (WebSharingServicePickerClient::sharingServicePickerWillBeDestroyed):
913         (WebSharingServicePickerClient::pageForSharingServicePicker):
914         (WebSharingServicePickerClient::windowForSharingServicePicker):
915         (WebSharingServicePickerClient::screenRectForCurrentSharingServicePickerItem):
916         (WebSharingServicePickerClient::imageForCurrentSharingServicePickerItem):
917         (-[WebSharingServicePickerController initWithItems:includeEditorServices:client:style:]):
918         (-[WebSharingServicePickerController initWithSharingServicePicker:client:]):
919         (-[WebSharingServicePickerController sharingService:didShareItems:]):
920
921         * WebCoreSupport/WebContextMenuClient.h:
922         (WebContextMenuClient::webView): Deleted.
923         * WebCoreSupport/WebContextMenuClient.mm:
924         (WebContextMenuClient::WebContextMenuClient):
925         (WebContextMenuClient::pageForSharingServicePicker): Deleted.
926         (WebContextMenuClient::windowForSharingServicePicker): Deleted.
927
928         * WebCoreSupport/WebSelectionServiceController.h:
929         * WebCoreSupport/WebSelectionServiceController.mm:
930         (WebSelectionServiceController::WebSelectionServiceController):
931         (WebSelectionServiceController::handleSelectionServiceClick):
932         (WebSelectionServiceController::pageForSharingServicePicker): Deleted.
933         (WebSelectionServiceController::windowForSharingServicePicker): Deleted.
934         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem): Deleted.
935         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem): Deleted.
936
937         * WebView/WebHTMLView.mm:
938         (-[WebHTMLView menuForEvent:]):
939         * WebView/WebViewData.h:
940
941 2015-04-13  Beth Dakin  <bdakin@apple.com>
942
943         Add force property to MouseEvents
944         https://bugs.webkit.org/show_bug.cgi?id=143569
945         -and corresponding-
946         rdar://problem/20472954
947
948         Reviewed by Darin Adler.
949
950         PlatformMouseEvent and MouseEvent now take force parameters.
951         * WebView/WebFrame.mm:
952         (-[WebFrame _dragSourceEndedAt:operation:]):
953         * WebView/WebPDFView.mm:
954         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
955
956 2015-04-12  Darin Adler  <darin@apple.com>
957
958         [Cocoa] Localizable strings are inconsistent and need to be regenerated
959         https://bugs.webkit.org/show_bug.cgi?id=143661
960         rdar://problem/19634388
961
962         Reviewed by Dan Bernstein.
963
964         * Misc/WebLocalizableStrings.mm:
965         (LoadWebLocalizedStringsTimerCallback): Moved the comment, useful for programmers but
966         not for localization, into a C++ source code comment, and made the localizer comment
967         consistent with the place this localizable string is used for actual localization.
968         * WebCoreSupport/WebEditorClient.mm:
969         (undoNameForEditAction): Changed the localizer comments for Delete and Dictation
970         to match the ones in WebKit2; no need to specify that these are iOS only, and if we do
971         want to specify that, we should not be using the term PLATFORM(IOS) since there is no
972         reason for us to expect localizers to understand that terminology. Also added a comment
973         about the fact that we have two copies of all the localizable strings.
974
975 2015-04-11  Yusuke Suzuki  <utatane.tea@gmail.com>
976
977         [ES6] Enable Symbol in web pages
978         https://bugs.webkit.org/show_bug.cgi?id=143375
979
980         Reviewed by Ryosuke Niwa.
981
982         * WebView/WebPreferencesPrivate.h:
983
984 2015-04-08  Sam Weinig  <sam@webkit.org>
985
986         Allow LaunchServices to handle URLs on link navigations
987         <rdar://problem/19446826>
988         https://bugs.webkit.org/show_bug.cgi?id=143544
989
990         Reviewed by Anders Carlsson.
991
992         * Configurations/WebKitLegacy.xcconfig:
993         Link MobileCoreServices.
994
995         * WebCoreSupport/WebFrameLoaderClient.h:
996         * WebCoreSupport/WebFrameLoaderClient.mm:
997         (shouldTryAppLink):
998         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
999         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1000         (WebFrameLoaderClient::setUpPolicyListener):
1001         Only let LaunchServices have a crack at the URL if the navigation is:
1002             1) a main frame navigation
1003             2) a result of a user gesture
1004
1005 2015-04-10  Alexey Proskuryakov  <ap@apple.com>
1006
1007         Build fix.
1008
1009         * Misc/WebNSURLExtras.mm: (-[NSString _webkit_unescapedQueryValue]): Ignore a deprecation.
1010
1011 2015-04-10  Eric Carlson  <eric.carlson@apple.com>
1012
1013         [Mac] Refactor MediaPlaybackTarget
1014         https://bugs.webkit.org/show_bug.cgi?id=143571
1015
1016         Reviewed by Jer Noble.
1017
1018         * WebView/WebMediaPlaybackTargetPicker.h:
1019         * WebView/WebMediaPlaybackTargetPicker.mm:
1020         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): Take a Ref<MediaPlaybackTarget>&&.
1021
1022 2015-04-09  Andy Estes  <aestes@apple.com>
1023
1024         [Cocoa] Add a HAVE(AVKIT) and use it
1025         https://bugs.webkit.org/show_bug.cgi?id=143593
1026
1027         Reviewed by David Kilzer.
1028
1029         * WebView/WebPreferences.mm:
1030         (+[WebPreferences initialize]): Only set WebKitAVKitEnabled to YES if HAVE(AVKIT).
1031         (-[WebPreferences setAVKitEnabled:]): Only set value for WebKitAVKitEnabled if HAVE(AVKIT).
1032         * WebView/WebView.mm:
1033         (-[WebView _preferencesChanged:]): Only called Settings::setAVKitEnabled() if HAVE(AVKIT).
1034
1035 2015-04-09  Chris Dumez  <cdumez@apple.com>
1036
1037         [WK2][iOS] editorState() should not cause a synchronous layout
1038         https://bugs.webkit.org/show_bug.cgi?id=142536
1039         <rdar://problem/20041506>
1040
1041         Reviewed by Enrica Casucci.
1042
1043         Provide implementation for EditorClient::didChangeSelectionAndUpdateLayout().
1044
1045         * WebCoreSupport/WebEditorClient.h:
1046
1047 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1048
1049         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1050         https://bugs.webkit.org/show_bug.cgi?id=143452
1051         <rdar://problem/20437483>
1052
1053         Reviewed by Tim Horton.
1054
1055         We were improperly intercepting contextual menu clicks and passing them through
1056         the mouseDown handler, rather than processing via NSView's menu handling code.
1057
1058         * WebView/WebHTMLView.mm:
1059         (-[WebHTMLView otherMouseDown:]): Treat context menu events the same as the action
1060         menu case, and pass it to AppKit for normal menu processing. 
1061
1062 2015-04-08  Brady Eidson  <beidson@apple.com>
1063
1064         Expose the "Share" menu for links, images, and media.
1065         <rdar://problem/20435340> and https://bugs.webkit.org/show_bug.cgi?id=143502
1066
1067         Reviewed by Tim Horton.
1068
1069         * WebCoreSupport/WebContextMenuClient.h:
1070         * WebCoreSupport/WebContextMenuClient.mm:
1071         (WebContextMenuClient::shareMenuItem): 
1072
1073 2015-04-08  Anders Carlsson  <andersca@apple.com>
1074
1075         Move some ApplicationCache static member functions to ApplicationCacheStorage
1076         https://bugs.webkit.org/show_bug.cgi?id=143524
1077
1078         Reviewed by Antti Koivisto.
1079
1080         * WebCoreSupport/WebApplicationCache.mm:
1081         (+[WebApplicationCache diskUsageForOrigin:]):
1082         (+[WebApplicationCache deleteAllApplicationCaches]):
1083         (+[WebApplicationCache deleteCacheForOrigin:]):
1084
1085 2015-04-08  Chris Dumez  <cdumez@apple.com>
1086
1087         Rename ActiveDOMObject::canSuspend() to canSuspendForPageCache() for clarity
1088         https://bugs.webkit.org/show_bug.cgi?id=143513
1089
1090         Reviewed by Andreas Kling.
1091
1092         Update ScriptExecutionContext::canSuspendActiveDOMObjects() to
1093         canSuspendActiveDOMObjectsForPageCache() as the method was renamed.
1094
1095         * WebView/WebFrame.mm:
1096         (-[WebFrame _cacheabilityDictionary]):
1097
1098 2015-04-07  Anders Carlsson  <andersca@apple.com>
1099
1100         Get rid of uses of ApplicationCacheStorage::singleton() from WebKitLegacy
1101         https://bugs.webkit.org/show_bug.cgi?id=143504
1102
1103         Reviewed by Sam Weinig.
1104
1105         Add a webApplicationCacheStorage() function and use it throughout WebKitLegacy.
1106         In the future, webApplicationCacheStorage will return a custom singleton, but for now
1107         it just returns ApplicationCacheStorage::singleton().
1108
1109         * Misc/WebCache.mm:
1110         (+[WebCache empty]):
1111         * WebCoreSupport/WebApplicationCache.mm:
1112         (+[WebApplicationCache maximumSize]):
1113         (+[WebApplicationCache setMaximumSize:]):
1114         (+[WebApplicationCache defaultOriginQuota]):
1115         (+[WebApplicationCache setDefaultOriginQuota:]):
1116         (+[WebApplicationCache originsWithCache]):
1117         (webApplicationCacheStorage):
1118         * WebCoreSupport/WebApplicationCacheInternal.h: Added.
1119         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1120         (-[WebApplicationCacheQuotaManager usage]):
1121         (-[WebApplicationCacheQuotaManager quota]):
1122         (-[WebApplicationCacheQuotaManager setQuota:]):
1123         * WebView/WebView.mm:
1124         (WebKitInitializeApplicationCachePathIfNecessary):
1125
1126 2015-04-07  Brady Eidson  <beidson@apple.com>
1127
1128         ContextMenuItem refactoring
1129         https://bugs.webkit.org/show_bug.cgi?id=143485
1130
1131         Reviewed by Beth Dakin.
1132
1133         * WebCoreSupport/WebContextMenuClient.mm:
1134         (WebContextMenuClient::contextMenuItemSelected):
1135
1136 2015-04-06  Chris Dumez  <cdumez@apple.com>
1137
1138         Bing video search result pages are not PageCacheable
1139         https://bugs.webkit.org/show_bug.cgi?id=143463
1140         <rdar://problem/20440916>
1141
1142         Reviewed by Alexey Proskuryakov.
1143
1144         Fix the iOS / WK1 build by using MemoryCache::resourceForRequest()
1145         instead of resourceForUrl().
1146
1147         * Misc/WebCache.mm:
1148         (+[WebCache imageForURL:]):
1149
1150 2015-04-05  Simon Fraser  <simon.fraser@apple.com>
1151
1152         Remove "go ahead and" from comments
1153         https://bugs.webkit.org/show_bug.cgi?id=143421
1154
1155         Reviewed by Darin Adler, Benjamin Poulain.
1156
1157         Remove the phrase "go ahead and" from comments where it doesn't add
1158         anything (which is almost all of them).
1159
1160         * WebView/WebDynamicScrollBarsView.mm:
1161         (-[WebDynamicScrollBarsView updateScrollers]):
1162         * WebView/WebHTMLView.mm:
1163         (-[WebHTMLView insertText:]):
1164
1165 2015-04-02  Brady Eidson  <beidson@apple.com>
1166
1167         Unreviewed: Reland change after rollout.
1168
1169         Expose the "Share" menu for text selections on platforms where it's available.
1170         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
1171
1172         * WebView/WebImmediateActionController.mm: Update for required #include
1173
1174 2015-04-02  Commit Queue  <commit-queue@webkit.org>
1175
1176         Unreviewed, rolling out r182293.
1177         https://bugs.webkit.org/show_bug.cgi?id=143355
1178
1179         Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
1180
1181         Reverted changeset:
1182
1183         "Expose the "Share" menu for text selections on platforms
1184         where it's available."
1185         https://bugs.webkit.org/show_bug.cgi?id=143318
1186         http://trac.webkit.org/changeset/182293
1187
1188 2015-04-02  Brady Eidson  <beidson@apple.com>
1189
1190         Expose the "Share" menu for text selections on platforms where it's available.
1191         rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
1192
1193         Reviewed by Sam Weinig.
1194
1195         * WebView/WebImmediateActionController.mm: Update for required #include
1196
1197 2015-04-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1198
1199         Clean up EnumerationMode to easily extend
1200         https://bugs.webkit.org/show_bug.cgi?id=143276
1201
1202         Reviewed by Geoffrey Garen.
1203
1204         Use default EnumerationMode().
1205
1206         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1207         (WebKit::NetscapePluginInstanceProxy::enumerate):
1208
1209 2015-03-31  Simon Fraser  <simon.fraser@apple.com>
1210
1211         Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
1212         https://bugs.webkit.org/show_bug.cgi?id=143288
1213
1214         Reviewed by Beth Dakin.
1215
1216         Remove the wheel event counting that Document does, and passes into the scrolling tree.
1217         The ScrollingTree now just uses the non-fast scrollable region to determine when to
1218         fast scroll on pages with wheel event handlers.
1219
1220         * WebCoreSupport/WebChromeClient.h:
1221
1222 2015-03-31  Timothy Horton  <timothy_horton@apple.com>
1223
1224         TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
1225         https://bugs.webkit.org/show_bug.cgi?id=143287
1226         <rdar://problem/20318342>
1227
1228         Reviewed by Beth Dakin.
1229
1230         * WebView/WebImmediateActionController.mm:
1231         (-[WebImmediateActionController _defaultAnimationController]):
1232         Instead of just highlighting the hit element, highlight the whole
1233         element that the link URL comes from.
1234
1235 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1236
1237         Clean up Identifier factories to clarify the meaning of StringImpl*
1238         https://bugs.webkit.org/show_bug.cgi?id=143146
1239
1240         Reviewed by Filip Pizlo.
1241
1242         Just change to Identifier::fromString.
1243
1244         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1245         (identifierFromIdentifierRep):
1246         * Plugins/Hosted/ProxyInstance.mm:
1247         (WebKit::ProxyInstance::getPropertyNames):
1248
1249 2015-03-28  Anders Carlsson  <andersca@apple.com>
1250
1251         Remove an unused SPI method from WebKitLegacy
1252         https://bugs.webkit.org/show_bug.cgi?id=143185
1253
1254         Reviewed by Sam Weinig.
1255
1256         * WebView/WebDataSource.mm:
1257         (-[WebDataSource _transferApplicationCache:]): Deleted.
1258         * WebView/WebDataSourcePrivate.h:
1259
1260 2015-03-26  Alex Christensen  <achristensen@webkit.org>
1261
1262         Progress towards CMake on Mac.
1263         https://bugs.webkit.org/show_bug.cgi?id=143112
1264
1265         Reviewed by Chris Dumez.
1266
1267         * WebCoreSupport/WebFrameLoaderClient.h:
1268
1269 2015-03-26  Ryosuke Niwa  <rniwa@webkit.org>
1270
1271         Cursor doesn't change back to pointer when leaving Mail
1272         https://bugs.webkit.org/show_bug.cgi?id=132038
1273
1274         Reviewed by Anders Carlsson.
1275
1276         Fixed the bug by adding a cursor rect and making the primary tracking area update the cursor so that
1277         AppKit will reset the cursor as it leaves the WebView.
1278
1279         We use nil cursor here since we manually update the cursor by calling [NSCursor set].
1280
1281         * WebView/WebHTMLView.mm:
1282         (-[WebHTMLView setDataSource:]): Use NSTrackingCursorUpdate option in creating the primary tracking area.
1283
1284 2015-03-24  Anders Carlsson  <andersca@apple.com>
1285
1286         Fix designated initializer violations
1287         https://bugs.webkit.org/show_bug.cgi?id=143016
1288         rdar://problem/20268858
1289
1290         Reviewed by Dan Bernstein.
1291
1292         Move -[WebBackForwardList initWithBackForwardList:] to the implementation instead of a category since
1293         nobody calls it outside of WebBackForwardList.mm.
1294
1295         * History/WebBackForwardList.mm:
1296         * History/WebBackForwardListInternal.h:
1297
1298 2015-03-23  Alexey Proskuryakov  <ap@apple.com>
1299
1300         REGRESSION (Yosemite): WKView visibility notifications are messed up
1301         https://bugs.webkit.org/show_bug.cgi?id=142945
1302
1303         Reviewed by Tim Horton.
1304
1305         As these notifications cannot be used by NSView subclasses, create a separate
1306         object for observing them.
1307
1308         * WebView/WebView.mm:
1309         (-[WebView _commonInitializationWithFrameName:groupName:]):
1310         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1311         (-[WebView addWindowObserversForWindow:]):
1312         (-[WebView removeWindowObservers]):
1313         (-[WebView viewWillMoveToWindow:]): Make sure that observers are removed even
1314         if -[WebView close] is called manually.
1315         * WebView/WebViewData.h:
1316         * WebView/WebViewData.mm:
1317         (-[WebWindowVisibilityObserver initWithView:]):
1318         (-[WebWindowVisibilityObserver startObserving:]):
1319         (-[WebWindowVisibilityObserver stopObserving:]):
1320         (-[WebWindowVisibilityObserver _windowVisibilityChanged:]):
1321
1322 2015-03-23  Tim Horton  <timothy_horton@apple.com>
1323
1324         Add a share item to the link action menu
1325         https://bugs.webkit.org/show_bug.cgi?id=142961
1326         <rdar://problem/19198374>
1327
1328         Reviewed by Beth Dakin.
1329
1330         * WebView/WebActionMenuController.mm:
1331         (-[WebActionMenuController _defaultMenuItemsForImage]):
1332         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1333         (-[WebActionMenuController _createActionMenuItemForTag:]):
1334         (-[WebActionMenuController _createShareActionMenuItemForTag:withItems:]):
1335         Adopt -[NSMenuItem standardShareMenuItemWithItems].
1336         All of the null-checking is unnecessary as it's impossible to enter
1337         these functions with a null image/etc.
1338         Also, remove a duplicate isDownloadableMedia check for the 'save to downloads' item.
1339
1340         (-[WebActionMenuController _defaultMenuItemsForLink]):
1341         * WebView/WebUIDelegatePrivate.h:
1342         Add a 'Share' item to the link menu.
1343
1344 2015-03-22  Alexey Proskuryakov  <ap@apple.com>
1345
1346         Build fix.
1347
1348         * WebView/WebView.mm: (-[WebView _showPlaybackTargetPicker:hasVideo:]):
1349
1350 2015-03-22  Eric Carlson  <eric.carlson@apple.com>
1351
1352         [Mac] Enable WIRELESS_PLAYBACK_TARGET for WK1
1353         https://bugs.webkit.org/show_bug.cgi?id=142940
1354
1355         Reviewed by Sam Weinig.
1356
1357         * WebCoreSupport/WebChromeClient.h:
1358         * WebCoreSupport/WebChromeClient.mm:
1359         (WebChromeClient::showPlaybackTargetPicker): New.
1360         (WebChromeClient::startingMonitoringPlaybackTargets): New.
1361         (WebChromeClient::stopMonitoringPlaybackTargets): New.
1362
1363         * WebView/WebView.mm:
1364         (-[WebView _close]): Invalidate and free the target picker.
1365         (-[WebView _devicePicker]): New.
1366         (-[WebView _showPlaybackTargetPicker:hasVideo:]): New.
1367         (-[WebView _startingMonitoringPlaybackTargets]): New.
1368         (-[WebView _stopMonitoringPlaybackTargets]): New.
1369
1370         * WebView/WebMediaPlaybackTargetPicker.h:
1371         * WebView/WebMediaPlaybackTargetPicker.mm:
1372         (WebMediaPlaybackTargetPicker::create): New.
1373         (WebMediaPlaybackTargetPicker::WebMediaPlaybackTargetPicker): New.
1374         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): New.
1375         (WebMediaPlaybackTargetPicker::startingMonitoringPlaybackTargets): New.
1376         (WebMediaPlaybackTargetPicker::stopMonitoringPlaybackTargets): New.
1377         (WebMediaPlaybackTargetPicker::didChoosePlaybackTarget): New.
1378         (WebMediaPlaybackTargetPicker::externalOutputDeviceAvailableDidChange): New.
1379         (WebMediaPlaybackTargetPicker::invalidate): New.
1380         (WebMediaPlaybackTargetPicker::targetPicker): New.
1381
1382         * WebView/WebViewData.h:
1383         (WebMediaPlaybackTargetPicker::~WebMediaPlaybackTargetPicker):
1384         * WebView/WebViewData.mm:
1385         * WebView/WebViewInternal.h:
1386
1387 2015-03-19  Andy Estes  <aestes@apple.com>
1388
1389         [Content Filtering] Add tests for unblock requests
1390         https://bugs.webkit.org/show_bug.cgi?id=142900
1391
1392         Reviewed by Andreas Kling.
1393
1394         * WebCoreSupport/WebFrameLoaderClient.mm:
1395         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): This now happens in PolicyChecker.
1396         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1397         * WebView/WebFrame.mm:
1398         (-[WebFrame _contentFilterDidHandleNavigationAction:]): Deleted.
1399         * WebView/WebFrameInternal.h: Removed contentFilterUnblockHandler from WebFramePrivate.
1400
1401 2015-03-19  Enrica Casucci  <enrica@apple.com>
1402
1403         <attachment> should put URLs on the pasteboard so that Finder can accept drops.
1404         https://bugs.webkit.org/show_bug.cgi?id=142801
1405         rdar://problem/19982527
1406
1407         Reviewed by Tim Horton.
1408
1409         This patch adds all the necessary support to write attachment elements into
1410         the pasteboard, including the promised type in WK1.
1411
1412         * Misc/WebNSPasteboardExtras.mm:
1413         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1414         * WebCoreSupport/WebDragClient.h:
1415         * WebCoreSupport/WebDragClient.mm:
1416         (WebDragClient::declareAndWriteAttachment):
1417         * WebView/WebHTMLView.mm:
1418         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1419         * WebView/WebUIDelegate.h:
1420
1421 2015-03-19  Chris Dumez  <cdumez@apple.com>
1422
1423         Clean up DOMTimer related settings
1424         https://bugs.webkit.org/show_bug.cgi?id=142837
1425
1426         Reviewed by Darin Adler.
1427
1428         Stop setting the DOMTimers' default minimum interval to 4ms as this
1429         is now the default.
1430
1431         * WebView/WebView.mm:
1432         (-[WebView _commonInitializationWithFrameName:groupName:]):
1433
1434 2015-03-17  Conrad Shultz  <conrad_shultz@apple.com>
1435
1436         Ignore some deprecation warnings
1437         https://bugs.webkit.org/show_bug.cgi?id=142813
1438
1439         Reviewed by Mark Rowe.
1440
1441         Fixing the deprecations is tracked by: <rdar://problem/20201450>
1442
1443         * WebCoreSupport/PopupMenuMac.mm:
1444         (PopupMenuMac::populate):
1445
1446 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1447
1448         Cannot invoke action menus anymore
1449         https://bugs.webkit.org/show_bug.cgi?id=142797
1450         <rdar://problem/20032670>
1451
1452         * WebView/WebHTMLView.mm:
1453         (-[WebHTMLView otherMouseDown:]):
1454         Need a respondsToSelector check.
1455
1456 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1457
1458         Fix the iOS build
1459
1460         * WebView/WebHTMLView.mm:
1461
1462 2015-03-17  Tim Horton  <timothy_horton@apple.com>
1463
1464         Cannot invoke action menus anymore
1465         https://bugs.webkit.org/show_bug.cgi?id=142797
1466         <rdar://problem/20032670>
1467
1468         Reviewed by Beth Dakin.
1469
1470         * WebView/WebHTMLView.mm:
1471         (-[WebHTMLView otherMouseDown:]):
1472         Don't override otherMouseDown: if the event would make an action menu.
1473
1474 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
1475
1476         Enable ES6 classes by default
1477         https://bugs.webkit.org/show_bug.cgi?id=142774
1478
1479         Reviewed by Gavin Barraclough.
1480
1481         * Configurations/FeatureDefines.xcconfig:
1482
1483 2015-03-16  Brent Fulgham  <bfulgham@apple.com>
1484
1485         WebKit1 Clients Are Not Reliably Repainted
1486         https://bugs.webkit.org/show_bug.cgi?id=142750
1487         <rdar://problem/20042453>
1488
1489         Reviewed by Simon Fraser.
1490
1491         Check with the FrameView to see if we are in an immediately paintable state. If we are not,
1492         mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
1493         region will be painted properly.
1494
1495         * WebView/WebClipView.mm:
1496         (-[WebClipView _immediateScrollToPoint:]): 
1497
1498 2015-03-16  Conrad Shultz  <conrad_shultz@apple.com>
1499
1500         Allow clients to selectively disable plug-ins
1501         https://bugs.webkit.org/show_bug.cgi?id=142506
1502
1503         Reviewed by Anders Carlsson.
1504
1505         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1506         from the page). As part of this:
1507
1508         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1509            set of plug-ins.
1510
1511         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1512            down the stack.
1513
1514         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1515            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1516
1517         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1518
1519         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1520         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1521
1522         * Plugins/WebBasePluginPackage.mm:
1523         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1524         Set new members in PluginInfo.
1525
1526         * Plugins/WebNetscapePluginPackage.mm:
1527         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1528         Set new members in PluginInfo.
1529
1530         * WebCoreSupport/WebPlatformStrategies.h:
1531         * WebCoreSupport/WebPlatformStrategies.mm:
1532         (WebPlatformStrategies::getWebVisiblePluginInfo):
1533         Override to wrap getPluginInfo().
1534         (WebPlatformStrategies::setPluginLoadClientPolicy):
1535         Override to do nothing.
1536         (WebPlatformStrategies::clearPluginClientPolicies):
1537         Ditto.
1538
1539         * WebView/WebFrame.mm:
1540         (-[WebFrame _canProvideDocumentSource]):
1541         Update to reflect function rename.
1542
1543 2015-03-14  Dean Jackson  <dino@apple.com>
1544
1545         Feature flag for Animations Level 2
1546         https://bugs.webkit.org/show_bug.cgi?id=142699
1547         <rdar://problem/20165097>
1548
1549         Reviewed by Brent Fulgham.
1550
1551         Add ENABLE_CSS_ANIMATIONS_LEVEL_2 and a runtime flag animationTriggersEnabled.
1552
1553         * Configurations/FeatureDefines.xcconfig:
1554
1555 2015-03-13  Commit Queue  <commit-queue@webkit.org>
1556
1557         Unreviewed, rolling out r181483.
1558         https://bugs.webkit.org/show_bug.cgi?id=142688
1559
1560         Caused use-after-free on many tests (Requested by ap on
1561         #webkit).
1562
1563         Reverted changeset:
1564
1565         "Allow clients to selectively disable plug-ins"
1566         https://bugs.webkit.org/show_bug.cgi?id=142506
1567         http://trac.webkit.org/changeset/181483
1568
1569 2015-03-13  Eric Carlson  <eric.carlson@apple.com>
1570
1571         [Mac] Enable WIRELESS_PLAYBACK_TARGET
1572         https://bugs.webkit.org/show_bug.cgi?id=142635
1573
1574         Reviewed by Darin Adler.
1575
1576         * Configurations/FeatureDefines.xcconfig:
1577
1578 2015-03-10  Conrad Shultz  <conrad_shultz@apple.com>
1579
1580         Allow clients to selectively disable plug-ins
1581         https://bugs.webkit.org/show_bug.cgi?id=142506
1582
1583         Reviewed by Anders Carlsson.
1584
1585         Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
1586         from the page). As part of this:
1587
1588         1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying
1589            set of plug-ins.
1590
1591         2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper
1592            down the stack.
1593
1594         3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce
1595            a concrete implementation thereof in WebPlatformStrategies in WebKit2.
1596
1597         4) Add messaging infrastructure to allow clients to set and clear plug-in policies.
1598
1599         While currently only used in a very limited manner, the new declarative plug-in policies are written generically
1600         so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.
1601
1602         * Plugins/WebBasePluginPackage.mm:
1603         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1604         Set new members in PluginInfo.
1605
1606         * Plugins/WebNetscapePluginPackage.mm:
1607         (-[WebNetscapePluginPackage getPluginInfoFromResources]):
1608         Set new members in PluginInfo.
1609
1610         * WebCoreSupport/WebPlatformStrategies.h:
1611         * WebCoreSupport/WebPlatformStrategies.mm:
1612         (WebPlatformStrategies::getWebVisiblePluginInfo):
1613         Override to wrap getPluginInfo().
1614         (WebPlatformStrategies::setPluginLoadClientPolicy):
1615         Override to do nothing.
1616         (WebPlatformStrategies::clearPluginClientPolicies):
1617         Ditto.
1618
1619         * WebView/WebFrame.mm:
1620         (-[WebFrame _canProvideDocumentSource]):
1621         Update to reflect function rename.
1622
1623 2015-03-10  Sam Weinig  <sam@webkit.org>
1624
1625         Allow adding a button in input elements for auto fill related functionality
1626         <rdar://problem/19782066>
1627         https://bugs.webkit.org/show_bug.cgi?id=142564
1628
1629         Reviewed by Anders Carlsson.
1630
1631         * DOM/WebDOMOperations.mm:
1632         (-[DOMHTMLInputElement _setAutofilled:]):
1633         Update for consistent spelling of AutoFill.
1634
1635 2015-03-10  Timothy Horton  <timothy_horton@apple.com>
1636
1637         Fix the build
1638
1639         * History/WebHistory.mm:
1640         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1641         * WebCoreSupport/WebFrameLoaderClient.mm:
1642         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1643
1644 2015-03-10  Tim Horton  <timothy_horton@apple.com>
1645
1646         Fix the Mac build with a newer compiler
1647
1648         * Plugins/WebPluginController.mm:
1649         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1650         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1651
1652 2015-03-09  David Kilzer  <ddkilzer@apple.com>
1653
1654         [iOS] Fix build when compiling with dead code stripping disabled
1655         <http://webkit.org/b/142467>
1656
1657         Reviewed by Simon Fraser.
1658
1659         * Configurations/WebKitLegacy.xcconfig:
1660         (EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
1661         generation and compilation for out-of-process plugin support.
1662         This was never used on iOS.
1663
1664 2015-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
1665
1666         [iOS] SVG fonts are garbled
1667         https://bugs.webkit.org/show_bug.cgi?id=142377
1668
1669         Reviewed by Simon Fraser.
1670
1671         * Configurations/FeatureDefines.xcconfig:
1672
1673 2015-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1674
1675         Hide Promise with runtime flags under Cocoa JSContext API
1676         https://bugs.webkit.org/show_bug.cgi?id=141965
1677
1678         Reviewed by Filip Pizlo.
1679
1680         Add new JSC runtime flag, PromiseDisabled.
1681
1682         * WebView/WebPreferencesPrivate.h:
1683
1684 2015-03-03  Andy Estes  <aestes@apple.com>
1685
1686         [Content Filtering] Separate unblock handling into its own class
1687         https://bugs.webkit.org/show_bug.cgi?id=142251
1688
1689         Reviewed by Andreas Kling.
1690         
1691         Adopted ContentFilterUnblockHandler.
1692
1693         * WebCoreSupport/WebFrameLoaderClient.h:
1694         * WebCoreSupport/WebFrameLoaderClient.mm:
1695         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1696         * WebView/WebFrame.mm:
1697         (-[WebFrame _contentFilterDidHandleNavigationAction:]):
1698         * WebView/WebFrameInternal.h:
1699
1700 2015-03-03  Chris Dumez  <cdumez@apple.com>
1701
1702         Access ApplicationCacheStorage global instance via singleton() static member function
1703         https://bugs.webkit.org/show_bug.cgi?id=142239
1704
1705         Reviewed by Anders Carlsson.
1706
1707         Access ApplicationCacheStorage global instance via singleton() static
1708         member function as per WebKit coding style.
1709
1710 2015-03-02  Jer Noble  <jer.noble@apple.com>
1711
1712         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1713         https://bugs.webkit.org/show_bug.cgi?id=142121
1714
1715         Reviewed by Simon Fraser.
1716
1717         Fullscreening a page with a non-1 scale would result in that scale being applied to the
1718         fullscreen content, breaking fullscreen mode. Set the page scale to 1 when entering
1719         fullscreen and reset it to the original value when exiting fullscreen.
1720
1721         * WebView/WebFullScreenController.h:
1722         * WebView/WebFullScreenController.mm:
1723         (-[WebFullScreenController enterFullScreen:]): Set the page scale to 1.
1724         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Reset the page
1725                 scale to the original value.
1726         * WebView/WebView.mm:
1727         (-[WebView _supportsFullScreenForElement:withKeyboard:]): Drive-by fix. Check the
1728                 WebView's own preferences to see if fullscreen mode is enabled, rather than
1729                 the global object's.
1730
1731 2015-03-01  Chris Dumez  <cdumez@apple.com>
1732
1733         Make NotificationCenter / Notification suspendable
1734         https://bugs.webkit.org/show_bug.cgi?id=142117
1735         <rdar://problem/19923085>
1736
1737         Reviewed by Andreas Kling.
1738
1739         Provide implementation for NotificationClient::hasPendingPermissionRequests().
1740         The implementation is very simplistic. it will only return false if no
1741         request for permission for ever made. This is because there is currently no
1742         easy way to figure out if a permission request is pending or not.
1743
1744         * WebCoreSupport/WebNotificationClient.h:
1745         * WebCoreSupport/WebNotificationClient.mm:
1746         (WebNotificationClient::requestPermission):
1747         (WebNotificationClient::hasPendingPermissionRequests):
1748
1749 2015-02-28  Simon Fraser  <simon.fraser@apple.com>
1750
1751         Viewport units should not dirty style just before we do layout
1752         https://bugs.webkit.org/show_bug.cgi?id=141682
1753
1754         Reviewed by Zalan Bujtas.
1755
1756         * WebView/WebFrameView.mm:
1757         (-[WebFrameView _frameSizeChanged]):
1758
1759 2015-02-26  Chris Dumez  <cdumez@apple.com>
1760
1761         Rename DatabaseManager::manager() to DatabaseManager::singleton()
1762         https://bugs.webkit.org/show_bug.cgi?id=142054
1763
1764         Reviewed by Ryosuke Niwa.
1765
1766         Rename DatabaseManager::manager() to DatabaseManager::singleton() as
1767         per coding style and use WTF::NeverDestroyed.
1768
1769         * Storage/WebDatabaseManager.mm:
1770         (-[WebDatabaseManager init]):
1771         (-[WebDatabaseManager origins]):
1772         (-[WebDatabaseManager databasesWithOrigin:]):
1773         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1774         (-[WebDatabaseManager deleteAllDatabases]):
1775         (-[WebDatabaseManager deleteOrigin:]):
1776         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1777         * Storage/WebDatabaseQuotaManager.mm:
1778         (-[WebDatabaseQuotaManager usage]):
1779         (-[WebDatabaseQuotaManager quota]):
1780         (-[WebDatabaseQuotaManager setQuota:]):
1781         * WebCoreSupport/WebSecurityOrigin.mm:
1782         (-[WebSecurityOrigin usage]):
1783         (-[WebSecurityOrigin quota]):
1784         (-[WebSecurityOrigin setQuota:]):
1785         * WebView/WebFrame.mm:
1786         (-[WebFrame _cacheabilityDictionary]):
1787         * WebView/WebView.mm:
1788         (-[WebView _preferencesChanged:]):
1789
1790 2015-02-26  Myles C. Maxfield  <mmaxfield@apple.com>
1791
1792         [Mac] [iOS] Parsing support for -apple-trailing-word
1793         https://bugs.webkit.org/show_bug.cgi?id=141939
1794
1795         Reviewed by Andreas Kling.
1796
1797         * Configurations/FeatureDefines.xcconfig:
1798
1799 2015-02-24  Commit Queue  <commit-queue@webkit.org>
1800
1801         Unreviewed, rolling out r180599.
1802         https://bugs.webkit.org/show_bug.cgi?id=141998
1803
1804         Lots of new test failures (Requested by smfr on #webkit).
1805
1806         Reverted changeset:
1807
1808         "Parsing support for -webkit-trailing-word"
1809         https://bugs.webkit.org/show_bug.cgi?id=141939
1810         http://trac.webkit.org/changeset/180599
1811
1812 2015-02-24  Myles C. Maxfield  <mmaxfield@apple.com>
1813
1814         [Mac] [iOS] Parsing support for -apple-trailing-word
1815         https://bugs.webkit.org/show_bug.cgi?id=141939
1816
1817         Reviewed by Andreas Kling.
1818
1819         * Configurations/FeatureDefines.xcconfig:
1820
1821 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1822
1823         REGRESSION(r179429): Can't type comments in Facebook
1824         https://bugs.webkit.org/show_bug.cgi?id=141859
1825
1826         Reviewed by Brent Fulgham.
1827
1828         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1829         Private API, javaScriptExperimentsEnabled is dropped.
1830
1831         * Misc/WebNSDictionaryExtras.h:
1832         * Misc/WebNSDictionaryExtras.m:
1833         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1834         * WebKit.order:
1835         * WebView/WebPreferenceKeysPrivate.h:
1836         * WebView/WebPreferences.mm:
1837         (+[WebPreferences initialize]):
1838         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1839         (-[WebPreferences javaScriptRuntimeFlags]):
1840         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1841         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1842         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1843         * WebView/WebPreferencesPrivate.h:
1844         * WebView/WebView.mm:
1845         (-[WebView _preferencesChanged:]):
1846
1847 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1848
1849         Unreviewed, rolling out r180547 and r180550.
1850         https://bugs.webkit.org/show_bug.cgi?id=141957
1851
1852         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1853
1854         Reverted changesets:
1855
1856         "REGRESSION(r179429): Can't type comments in Facebook"
1857         https://bugs.webkit.org/show_bug.cgi?id=141859
1858         http://trac.webkit.org/changeset/180547
1859
1860         "Constructor returning null should construct an object instead
1861         of null"
1862         https://bugs.webkit.org/show_bug.cgi?id=141640
1863         http://trac.webkit.org/changeset/180550
1864
1865 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1866
1867         Disable font loading events until our implementation gets updated to match the latest spec
1868         https://bugs.webkit.org/show_bug.cgi?id=141938
1869
1870         Reviewed by Andreas Kling.
1871
1872         * Configurations/FeatureDefines.xcconfig:
1873
1874 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1875
1876         REGRESSION(r179429): Can't type comments in Facebook
1877         https://bugs.webkit.org/show_bug.cgi?id=141859
1878
1879         Reviewed by Geoffrey Garen.
1880
1881         Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
1882         Private API, javaScriptExperimentsEnabled is dropped.
1883
1884         * Misc/WebNSDictionaryExtras.h:
1885         * Misc/WebNSDictionaryExtras.m:
1886         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
1887         * WebKit.order:
1888         * WebView/WebPreferenceKeysPrivate.h:
1889         * WebView/WebPreferences.mm:
1890         (+[WebPreferences initialize]):
1891         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1892         (-[WebPreferences javaScriptRuntimeFlags]):
1893         (-[WebPreferences setJavaScriptRuntimeFlags:]):
1894         (-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
1895         (-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
1896         * WebView/WebPreferencesPrivate.h:
1897         * WebView/WebView.mm:
1898         (-[WebView _preferencesChanged:]):
1899
1900 2015-02-20  Eric Carlson  <eric.carlson@apple.com>
1901
1902         [iOS] cleanup AirPlay code
1903         https://bugs.webkit.org/show_bug.cgi?id=141811
1904
1905         Reviewed by Jer Noble.
1906
1907         * Configurations/FeatureDefines.xcconfig: IOS_AIRPLAY -> WIRELESS_PLAYBACK_TARGET.
1908
1909 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1910
1911         Adopt WebCore::IOSurface in ImageBuffer
1912         https://bugs.webkit.org/show_bug.cgi?id=141751
1913
1914         Reviewed by Simon Fraser.
1915
1916         * WebCoreSupport/WebSystemInterface.mm:
1917         (InitWebCoreSystemInterface):
1918         Remove old WKSI IOSurface-related functions.
1919
1920 2015-02-18  Commit Queue  <commit-queue@webkit.org>
1921
1922         Unreviewed, rolling out r180286.
1923         https://bugs.webkit.org/show_bug.cgi?id=141766
1924
1925         Caused >50 crashed LayoutTests (Requested by jernoble on
1926         #webkit).
1927
1928         Reverted changeset:
1929
1930         "Page::userContentController() should return a reference, not
1931         a pointer"
1932         https://bugs.webkit.org/show_bug.cgi?id=141764
1933         http://trac.webkit.org/changeset/180286
1934
1935 2015-02-18  Brady Eidson  <beidson@apple.com>
1936
1937         Page::userContentController() should return a reference, not a pointer
1938         https://bugs.webkit.org/show_bug.cgi?id=141764
1939
1940         Reviewed by Jer Noble.
1941
1942         * WebView/WebView.mm:
1943         (-[WebView setGroupName:]):
1944
1945 2015-02-18  Chris Dumez  <cdumez@apple.com>
1946
1947         Access FontCache global instance via singleton() static member function
1948         https://bugs.webkit.org/show_bug.cgi?id=141726
1949
1950         Reviewed by Daniel Bates.
1951
1952         Access FontCache global instance via singleton() static member function,
1953         as per coding style.
1954
1955 2015-02-17  Chris Dumez  <cdumez@apple.com>
1956
1957         Access MemoryPressureHandler global instance via a singleton() static member function
1958         https://bugs.webkit.org/show_bug.cgi?id=141691
1959
1960         Reviewed by Andreas Kling.
1961
1962         Access MemoryPressureHandler global instance via a singleton() static
1963         member function.
1964
1965         * WebView/WebView.mm:
1966         (-[WebView _commonInitializationWithFrameName:groupName:]):
1967         (+[WebView registerForMemoryNotifications]):
1968         (+[WebView _isUnderMemoryPressure]):
1969         (+[WebView _clearMemoryPressure]):
1970         (+[WebView _shouldWaitForMemoryClearMessage]):
1971         (WebInstallMemoryPressureHandler):
1972
1973 2015-02-15  Sam Weinig  <sam@webkit.org>
1974
1975         Add experimental <attachment> element support
1976         https://bugs.webkit.org/show_bug.cgi?id=141626
1977
1978         Reviewed by Tim Horton.
1979
1980         * Configurations/FeatureDefines.xcconfig:
1981
1982 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
1983
1984         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
1985         https://bugs.webkit.org/show_bug.cgi?id=141613
1986
1987         Reviewed by Tim Horton.
1988
1989         * WebCoreSupport/WebEditorClient.mm:
1990         (WebEditorClient::WebEditorClient):
1991         Avoid unnecessary retain/autorelease by adopting.
1992
1993         * WebView/WebActionMenuController.mm:
1994         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1995         Adopt the allocated object.
1996
1997 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
1998
1999         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
2000         https://bugs.webkit.org/show_bug.cgi?id=141372
2001
2002         Reviewed by Joseph Pecoraro.
2003
2004         * WebCoreSupport/WebInspectorClient.mm:
2005         (-[WebInspectorWindowController destroyInspectorView:]):
2006
2007 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
2008
2009         rel="noreferrer" should make window.opener null
2010         https://bugs.webkit.org/show_bug.cgi?id=141579
2011
2012         Reviewed by Darin Adler.
2013
2014         * WebView/WebPDFView.mm:
2015         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
2016         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
2017
2018 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
2019
2020         [Streams API] Implement a barebone ReadableStream interface
2021         https://bugs.webkit.org/show_bug.cgi?id=141045
2022
2023         Reviewed by Benjamin Poulain.
2024
2025         * Configurations/FeatureDefines.xcconfig:
2026
2027 2015-02-03  Enrica Casucci  <enrica@apple.com>
2028
2029         [iOS] Add support for deleteFromInputWithFlags.
2030         https://bugs.webkit.org/show_bug.cgi?id=141216
2031         rdar://problem/19130081
2032
2033         Reviewed by Benjamin Poulain.
2034
2035         Adopts the new method as soon as it is available.
2036         The patch also removes some obsolete code used for staging.
2037
2038         * WebView/WebHTMLView.mm:
2039         (-[WebHTMLView _handleEditingKeyEvent:]):
2040
2041 2015-02-02  Chris Dumez  <cdumez@apple.com>
2042
2043         Access MemoryCache singleton using MemoryCache::singleton()
2044         https://bugs.webkit.org/show_bug.cgi?id=141104
2045
2046         Reviewed by Andreas Kling.
2047
2048         Access MemoryCache singleton using MemoryCache::singleton() static
2049         member function, instead of a free function, as per the recent
2050         coding style discussion on WebKit-dev.
2051
2052 2015-02-01  Chris Dumez  <cdumez@apple.com>
2053
2054         Use more references in HistoryItem
2055         https://bugs.webkit.org/show_bug.cgi?id=141133
2056
2057         Reviewed by Andreas Kling.
2058
2059         Use more references in HistoryItem instead of pointers.
2060
2061 2015-01-31  Sam Weinig  <sam@webkit.org>
2062
2063         Remove even more Mountain Lion support
2064         https://bugs.webkit.org/show_bug.cgi?id=141124
2065
2066         Reviewed by Alexey Proskuryakov.
2067
2068         * Configurations/Base.xcconfig:
2069         * Configurations/DebugRelease.xcconfig:
2070         * Configurations/FeatureDefines.xcconfig:
2071         * Configurations/Version.xcconfig:
2072         * Configurations/WebKitLegacy.xcconfig:
2073
2074 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
2075
2076         Remove MediaPlayerProxy.h
2077         https://bugs.webkit.org/show_bug.cgi?id=141087
2078
2079         Reviewed by Sam Weinig.
2080
2081         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
2082         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
2083
2084 2015-01-30  Chris Dumez  <cdumez@apple.com>
2085
2086         Rename shared() static member functions to singleton() for singleton classes.
2087         https://bugs.webkit.org/show_bug.cgi?id=141088
2088
2089         Reviewed by Ryosuke Niwa and Benjamin Poulain.
2090
2091         Rename shared() static member functions to singleton() for singleton
2092         classes as per the recent coding style change.
2093
2094 2015-01-29  Beth Dakin  <bdakin@apple.com>
2095
2096         Remove more Mountain Lion code from WebKit
2097         https://bugs.webkit.org/show_bug.cgi?id=141050
2098
2099         Reviewed by Anders Carlsson.
2100
2101         * History/WebHistory.mm:
2102         (getDayBoundaries):
2103         * Panels/WebAuthenticationPanel.m:
2104         (-[WebAuthenticationPanel cancel:]):
2105         (-[WebAuthenticationPanel logIn:]):
2106         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
2107         * WebCoreSupport/WebSystemInterface.mm:
2108         (InitWebCoreSystemInterface):
2109         * WebView/WebFrameView.mm:
2110         * WebView/WebPreferences.mm:
2111         (+[WebPreferences initialize]):
2112         (needsScreenFontsEnabledQuirk):
2113         * WebView/WebView.mm:
2114         (+[WebView registerForMemoryNotifications]):
2115         (-[WebView _preferencesChanged:]):
2116         (+[WebView initialize]):
2117         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
2118         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
2119         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
2120
2121 2015-01-29  Sam Weinig  <sam@webkit.org>
2122
2123         Remove support for screen font substitution
2124         https://bugs.webkit.org/show_bug.cgi?id=141038
2125
2126         Reviewed by Tim Horton.
2127
2128         * Misc/WebKitNSStringExtras.mm:
2129         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2130         (-[NSString _web_widthWithFont:]):
2131         * Misc/WebStringTruncator.mm:
2132         (fontFromNSFont):
2133         Update for new signature of the FontPlatformData constructor, which no longer cares about
2134         whether to use printer fonts.
2135
2136         * WebView/WebPreferenceKeysPrivate.h:
2137         Remove the WebKitScreenFontSubstitutionEnabledKey key.
2138
2139         * WebView/WebPreferences.mm:
2140         (+[WebPreferences initialize]):
2141         Remove support for WebKitScreenFontSubstitutionEnabledKey.
2142
2143         (needsScreenFontsEnabledQuirk): Deleted.
2144         Remove support for the Mountain Lion era 1-Password quirk.
2145
2146         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
2147         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
2148         * WebView/WebPreferencesPrivate.h:
2149         * WebView/WebView.mm:
2150         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2151         (-[WebView _preferencesChanged:]):
2152         Remove support for the screen font substitution setting.
2153
2154 2015-01-29  Chris Dumez  <cdumez@apple.com>
2155
2156         Clean up / modernize PageCache class
2157         https://bugs.webkit.org/show_bug.cgi?id=141009
2158
2159         Reviewed by Darin Adler.
2160
2161         Clean up / modernize PageCache class.
2162
2163         * History/WebBackForwardList.mm:
2164         (-[WebBackForwardList pageCacheSize]):
2165         * WebView/WebView.mm:
2166         (-[WebView _loadBackForwardListFromOtherView:]):
2167         (-[WebView goToBackForwardItem:]):
2168         (+[WebView _setCacheModel:]):
2169
2170 2015-01-28  Beth Dakin  <bdakin@apple.com>
2171
2172         Remove Mountain Lion code from WebKit and WebKit2
2173         https://bugs.webkit.org/show_bug.cgi?id=141010
2174
2175         Reviewed by Sam Weinig.
2176
2177         * DOM/WebDOMOperations.mm:
2178         (toNSEventPhase):
2179         * WebView/WebHTMLView.mm:
2180         (isQuickLookEvent):
2181
2182 2015-01-28  Dana Burkart  <dburkart@apple.com>
2183
2184         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
2185         https://bugs.webkit.org/show_bug.cgi?id=136765
2186
2187         Reviewed by Alexey Proskuryakov.
2188
2189         * Configurations/Base.xcconfig:
2190         * Configurations/DebugRelease.xcconfig:
2191
2192 2015-01-28  Chris Dumez  <cdumez@apple.com>
2193
2194         Fix typo in markPagesForVistedLinkStyleRecalc()
2195         https://bugs.webkit.org/show_bug.cgi?id=140977
2196
2197         Reviewed by Darin Adler.
2198
2199         * WebCoreSupport/WebVisitedLinkStore.mm:
2200         (WebVisitedLinkStore::removeAllVisitedLinks):
2201         (WebVisitedLinkStore::removeVisitedLink):
2202         (WebVisitedLinkStore::addVisitedLinkHash):
2203
2204 2015-01-28  Chris Dumez  <cdumez@apple.com>
2205
2206         Rename pageCache() to PageCache::shared() and return a reference
2207         https://bugs.webkit.org/show_bug.cgi?id=140983
2208
2209         Reviewed by Andreas Kling.
2210
2211         Rename pageCache() to PageCache::shared() as this is a singleton class
2212         and have it return a reference instead of a pointer.
2213
2214         * History/WebBackForwardList.mm:
2215         (-[WebBackForwardList pageCacheSize]):
2216         * Misc/WebCoreStatistics.mm:
2217         (+[WebCoreStatistics cachedPageCount]):
2218         (+[WebCoreStatistics cachedFrameCount]):
2219         * WebCoreSupport/WebVisitedLinkStore.mm:
2220         (WebVisitedLinkStore::removeAllVisitedLinks):
2221         (WebVisitedLinkStore::removeVisitedLink):
2222         (WebVisitedLinkStore::addVisitedLinkHash):
2223         * WebView/WebView.mm:
2224         (+[WebView _setCacheModel:]):
2225
2226 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2227
2228         More build fixes for newer clang.
2229
2230         Rubber-stamped by Anders Carlsson.
2231
2232         Marked a deprecated accessibility method as such.
2233
2234         * WebView/WebFrame.mm:
2235         (-[WebFrame accessibilityRoot]):
2236
2237 2015-01-27  Beth Dakin  <bdakin@apple.com>
2238
2239         Immediate action gesture recognizer still doesn't work well with IB
2240         https://bugs.webkit.org/show_bug.cgi?id=140967
2241         -and corresponding-
2242         rdar://problem/19621509
2243
2244         Reviewed by Tim Horton.
2245
2246         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
2247         initWithFrame it too early and IB might mess with it.
2248         * WebView/WebImmediateActionController.h:
2249         * WebView/WebImmediateActionController.mm:
2250         (-[WebImmediateActionController immediateActionRecognizer]):
2251         * WebView/WebView.mm:
2252         (-[WebView _commonInitializationWithFrameName:groupName:]):
2253         (-[WebView viewDidMoveToWindow]):
2254
2255 2015-01-27  Dan Bernstein  <mitz@apple.com>
2256
2257         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
2258
2259         Rubber-stamped by Anders Carlsson.
2260
2261         * WebView/WebView.h: Added forward declarations of the protocols.
2262
2263 2015-01-26  Anders Carlsson  <andersca@apple.com>
2264
2265         Make it easy to test enabling formal delegate protocols
2266         https://bugs.webkit.org/show_bug.cgi?id=140892
2267
2268         Reviewed by Dan Bernstein.
2269
2270         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
2271
2272         * Misc/WebDownload.h:
2273         * WebView/WebFrameLoadDelegate.h:
2274         * WebView/WebPolicyDelegate.h:
2275         * WebView/WebResourceLoadDelegate.h:
2276         * WebView/WebUIDelegate.h:
2277         * WebView/WebView.h:
2278
2279 2015-01-26  Chris Dumez  <cdumez@apple.com>
2280
2281         Rename Document::body() to Document::bodyOrFrameset() for clarity
2282         https://bugs.webkit.org/show_bug.cgi?id=140902
2283
2284         Reviewed by Andreas Kling.
2285
2286         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
2287         method does not necessarily return an HTMLBodyElement, it can also
2288         return a frameset as per the specification:
2289         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
2290
2291         This method is often misused internally (the caller is only interested
2292         in the <body> element). I will fix these instances in a follow-up patch,
2293         this patch is only renaming mechanically.
2294
2295 2015-01-26  Chris Dumez  <cdumez@apple.com>
2296
2297         First argument to DOM traversal functions should be a reference
2298         https://bugs.webkit.org/show_bug.cgi?id=140895
2299
2300         Reviewed by Antti Koivisto.
2301
2302         First argument to DOM traversal functions should be a reference instead
2303         of a pointer as it is dereferenced without null-check.
2304
2305 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
2306
2307         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
2308         https://bugs.webkit.org/show_bug.cgi?id=140860
2309
2310         Reviewed by Darin Adler.
2311
2312         The fonts it makes are grotesque. (See what I did there? Typographic
2313         humor is the best humor.)
2314
2315         * Configurations/FeatureDefines.xcconfig:
2316
2317 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
2318
2319         QLPreviewMenuItem popovers don't close when the page scrolls
2320         https://bugs.webkit.org/show_bug.cgi?id=140806
2321         <rdar://problem/19555618>
2322
2323         Reviewed by Beth Dakin.
2324
2325         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
2326
2327         * WebView/WebHTMLView.mm:
2328         (-[WebHTMLView scrollWheel:scrollWheel:]):
2329         Send scrollWheel along to WebImmediateActionController.
2330
2331         * WebView/WebImmediateActionController.h:
2332         * WebView/WebImmediateActionController.mm:
2333         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
2334         (-[WebImmediateActionController _clearImmediateActionState]):
2335         (-[WebImmediateActionController _defaultAnimationController]):
2336         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
2337
2338 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
2339
2340         Infinite recursion in _clearImmediateActionState
2341         https://bugs.webkit.org/show_bug.cgi?id=140807
2342         <rdar://problem/19571601>
2343
2344         Reviewed by Anders Carlsson.
2345
2346         * WebView/WebImmediateActionController.mm:
2347         (-[WebImmediateActionController _clearImmediateActionState]):
2348         Use this opportunity to bring identical code to WebKit1, to avoid
2349         getting DataDetectors stuck when an immediate action is canceled.
2350
2351 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2352
2353         Add a build flag for ES6 class syntax
2354         https://bugs.webkit.org/show_bug.cgi?id=140760
2355
2356         Reviewed by Michael Saboff.
2357
2358         * Configurations/FeatureDefines.xcconfig:
2359
2360 2015-01-22  Beth Dakin  <bdakin@apple.com>
2361
2362         ibtoold crash below -[WebView close]
2363         https://bugs.webkit.org/show_bug.cgi?id=140782
2364         -and corresponding-
2365         rdar://problem/19558472
2366
2367         Reviewed by Tim Horton.
2368
2369         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
2370         it is because interface builder is messing with our views.
2371         * WebView/WebImmediateActionController.h:
2372         * WebView/WebImmediateActionController.mm:
2373         (-[WebImmediateActionController webViewClosed]):
2374         (-[WebImmediateActionController _cancelImmediateAction]):
2375         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2376         (-[WebImmediateActionController _updateImmediateActionItem]):
2377
2378 2015-01-21  Beth Dakin  <bdakin@apple.com>
2379
2380         Crash in QuickLook preview delegate method
2381         https://bugs.webkit.org/show_bug.cgi?id=140740
2382         -and corresponding-
2383         rdar://problem/19540806
2384
2385         Reviewed by Tim Horton.
2386
2387         Clear out the delegate.
2388         * WebView/WebImmediateActionController.mm:
2389         (-[WebImmediateActionController webViewClosed]):
2390
2391 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
2392
2393         Remove ENABLE(INSPECTOR) ifdef guards
2394         https://bugs.webkit.org/show_bug.cgi?id=140668
2395
2396         Reviewed by Darin Adler.
2397
2398         * Configurations/FeatureDefines.xcconfig:
2399         * WebCoreSupport/WebFrameLoaderClient.mm:
2400         (WebFrameLoaderClient::dispatchWillSendRequest):
2401
2402 2015-01-20  Anders Carlsson  <andersca@apple.com>
2403
2404         Remove USE(GLIB) code from WebKit1
2405         https://bugs.webkit.org/show_bug.cgi?id=140714
2406
2407         Reviewed by Andreas Kling.
2408
2409         * WebView/WebView.mm:
2410         (-[WebView _commonInitializationWithFrameName:groupName:]):
2411         (-[WebView _close]):
2412         (-[WebView _clearGlibLoopObserver]): Deleted.
2413         (glibContextIterationCallback): Deleted.
2414         (-[WebView _scheduleGlibContextIterations]): Deleted.
2415         * WebView/WebViewData.h:
2416         * WebView/WebViewInternal.h:
2417
2418 2015-01-20  David Kilzer  <ddkilzer@apple.com>
2419
2420         Switch to comparing PLATFORM_NAME in terms of macosx
2421         <http://webkit.org/b/139516>
2422
2423         Reviewed by Timothy Hatcher.
2424
2425         * MigrateHeaders.make:
2426         * postprocess-headers.sh:
2427
2428 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2429
2430         [SVG -> OTF Converter] Flip the switch on
2431         https://bugs.webkit.org/show_bug.cgi?id=140592
2432
2433         Reviewed by Antti Koivisto.
2434
2435         * Configurations/FeatureDefines.xcconfig:
2436
2437 2015-01-19  Beth Dakin  <bdakin@apple.com>
2438
2439         Speculative build fix.
2440
2441         * WebView/WebView.mm:
2442         (-[WebView _commonInitializationWithFrameName:groupName:]):
2443
2444 2015-01-19  Beth Dakin  <bdakin@apple.com>
2445
2446         Speculative build fix.
2447
2448         * WebView/WebView.mm:
2449         (-[WebView _convertRectFromRootView:]):
2450
2451 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
2452
2453         Adjust naming of action menu SPI
2454         https://bugs.webkit.org/show_bug.cgi?id=140644
2455         <rdar://problem/19448129>
2456
2457         Reviewed by Brian Weinstein.
2458
2459         * WebView/WebActionMenuController.mm:
2460         (-[WebActionMenuController prepareForMenu:withEvent:]):
2461         (-[WebActionMenuController willOpenMenu:withEvent:]):
2462         (-[WebActionMenuController didCloseMenu:withEvent:]):
2463         * WebView/WebView.mm:
2464         (-[WebView _commonInitializationWithFrameName:groupName:]):
2465         (-[WebView prepareForMenu:withEvent:]):
2466         (-[WebView willOpenMenu:withEvent:]):
2467         (-[WebView didCloseMenu:withEvent:]):
2468
2469 2015-01-19  Beth Dakin  <bdakin@apple.com>
2470
2471         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
2472         offset by flipped-ness
2473         https://bugs.webkit.org/show_bug.cgi?id=140643
2474         -and corresponding-
2475         rdar://problem/19489593
2476
2477         Reviewed by Tim Horton.
2478
2479         We universally flipped because we assumed that the root view was flipped and the 
2480         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
2481         fixes that assumption by checking the WebView’s flipped-ness.
2482         * WebView/WebView.mm:
2483         (-[WebView _convertRectFromRootView:]):
2484
2485 2015-01-19  Commit Queue  <commit-queue@webkit.org>
2486
2487         Unreviewed, rolling out r178653.
2488         https://bugs.webkit.org/show_bug.cgi?id=140634
2489
2490         Broke multiple SVG tests on Mountain Lion (Requested by ap on
2491         #webkit).
2492
2493         Reverted changeset:
2494
2495         "[SVG -> OTF Converter] Flip the switch on"
2496         https://bugs.webkit.org/show_bug.cgi?id=140592
2497         http://trac.webkit.org/changeset/178653
2498
2499 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2500
2501         [SVG -> OTF Converter] Flip the switch on
2502         https://bugs.webkit.org/show_bug.cgi?id=140592
2503
2504         Reviewed by Antti Koivisto.
2505
2506         * Configurations/FeatureDefines.xcconfig:
2507
2508 2015-01-18  Daniel Bates  <dabates@apple.com>
2509
2510         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
2511         (https://bugs.webkit.org/show_bug.cgi?id=129441)
2512
2513         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
2514         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
2515
2516         * WebInspector/WebNodeHighlightView.mm:
2517         (-[WebNodeHighlightView layoutSublayers:]):
2518
2519 2015-01-16  Beth Dakin  <bdakin@apple.com>
2520
2521         Make sure early cancellation of immediate action actually does that in WK1
2522         https://bugs.webkit.org/show_bug.cgi?id=140566
2523         -and corresponding-
2524         rdar://problem/19490114
2525
2526         Reviewed by Tim Horton.
2527
2528         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
2529         asynchronously.
2530         * WebView/WebImmediateActionController.mm:
2531         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2532
2533 2015-01-16  Daniel Bates  <dabates@apple.com>
2534
2535         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
2536         (https://bugs.webkit.org/show_bug.cgi?id=140360)
2537
2538         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
2539
2540         * Misc/WebDownload.h:
2541
2542 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
2543
2544         Remove ENABLE(SQL_DATABASE) guards
2545         https://bugs.webkit.org/show_bug.cgi?id=140434
2546
2547         Reviewed by Darin Adler.
2548
2549         * Configurations/FeatureDefines.xcconfig:
2550         * Storage/WebDatabaseManager.mm:
2551         (databasesDirectoryPath):
2552         * Storage/WebDatabaseManagerClient.h:
2553         * Storage/WebDatabaseManagerClient.mm:
2554         * Storage/WebDatabaseManagerInternal.h:
2555         * Storage/WebDatabaseManagerPrivate.h:
2556         * Storage/WebDatabaseQuotaManager.mm:
2557         (-[WebDatabaseQuotaManager usage]):
2558         (-[WebDatabaseQuotaManager quota]):
2559         (-[WebDatabaseQuotaManager setQuota:]):
2560         * WebCoreSupport/WebChromeClient.h:
2561         * WebCoreSupport/WebChromeClient.mm:
2562         * WebCoreSupport/WebSecurityOrigin.mm:
2563         (-[WebSecurityOrigin usage]):
2564         (-[WebSecurityOrigin quota]):
2565         (-[WebSecurityOrigin setQuota:]):
2566         * WebView/WebFrame.mm:
2567         (-[WebFrame _cacheabilityDictionary]):
2568         * WebView/WebView.mm:
2569         (-[WebView _commonInitializationWithFrameName:groupName:]):
2570         (-[WebView _preferencesChanged:]):
2571
2572 2015-01-14  Chris Dumez  <cdumez@apple.com>
2573
2574         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
2575         https://bugs.webkit.org/show_bug.cgi?id=140347
2576
2577         Reviewed by Darin Adler.
2578
2579         Call FontDescription::setIsItalic() instead of setItalic() as the
2580         call site passes a boolean.
2581
2582         * WebView/WebHTMLView.mm:
2583         (fontNameForDescription):
2584
2585 2015-01-13  Anders Carlsson  <andersca@apple.com>
2586
2587         Temporarily reintroduce the informal delegate protocols
2588         https://bugs.webkit.org/show_bug.cgi?id=140416
2589
2590         Reviewed by Dan Bernstein.
2591
2592         * WebView/WebEditingDelegate.h:
2593         * WebView/WebFrameLoadDelegate.h:
2594         * WebView/WebPolicyDelegate.h:
2595         * WebView/WebResourceLoadDelegate.h:
2596         * WebView/WebUIDelegate.h:
2597
2598 2015-01-13  Beth Dakin  <bdakin@apple.com>
2599
2600         Should disable immediate actions for iTunes
2601         https://bugs.webkit.org/show_bug.cgi?id=140405
2602         -and corresponding-
2603         rdar://problem/19461358
2604
2605         Reviewed by Tim Horton.
2606
2607         * WebView/WebImmediateActionController.mm:
2608         (-[WebImmediateActionController _updateImmediateActionItem]):
2609
2610 2015-01-11  Sam Weinig  <sam@webkit.org>
2611
2612         Remove support for SharedWorkers
2613         https://bugs.webkit.org/show_bug.cgi?id=140344
2614
2615         Reviewed by Anders Carlsson.
2616
2617         * Configurations/FeatureDefines.xcconfig:
2618         * WebCoreSupport/WebPlatformStrategies.h:
2619         * WebCoreSupport/WebPlatformStrategies.mm:
2620         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
2621
2622 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2623
2624         Get rid of unnecessary reimplementations of CGFloor/Ceiling
2625         https://bugs.webkit.org/show_bug.cgi?id=140375
2626
2627         Reviewed by Simon Fraser.
2628
2629         * Misc/WebKitNSStringExtras.mm:
2630         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2631         (webkit_CGCeiling): Deleted.
2632         Delete unnecessary code, use the real CGFloor/Ceiling instead.
2633
2634 2015-01-12  Anders Carlsson  <andersca@apple.com>
2635
2636         Make delegates conform to formal delegate protocols
2637         https://bugs.webkit.org/show_bug.cgi?id=140370
2638
2639         Reviewed by Dan Bernstein.
2640
2641         * DefaultDelegates/WebDefaultPolicyDelegate.h:
2642         * WebCoreSupport/WebInspectorClient.mm:
2643         Add protocols to the interface declarations.
2644
2645         * WebView/WebActionMenuController.mm:
2646         (-[WebActionMenuController prepareForMenu:withEvent:]):
2647         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2648         * WebView/WebImmediateActionController.mm:
2649         (-[WebImmediateActionController _updateImmediateActionItem]):
2650         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2651         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
2652
2653 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
2654
2655         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
2656         https://bugs.webkit.org/show_bug.cgi?id=136769
2657
2658         Reviewed by Antti Koivisto.
2659
2660         * Configurations/FeatureDefines.xcconfig:
2661
2662 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
2663
2664         Multi-rect TextIndicators are vertically flipped in WebKit1
2665         https://bugs.webkit.org/show_bug.cgi?id=140350
2666         <rdar://problem/19441243>
2667
2668         Reviewed by Beth Dakin.
2669
2670         * WebView/WebView.mm:
2671         (-[WebView _setTextIndicator:fadeOut:]):
2672         Convert the textBoundingRect from root view to screen coordinates.
2673
2674 2015-01-12  Anders Carlsson  <andersca@apple.com>
2675
2676         Make WebResourceDelegate a formal protocol as well
2677         https://bugs.webkit.org/show_bug.cgi?id=140364
2678
2679         Reviewed by Dan Bernstein.
2680
2681         * WebView/WebResourceLoadDelegate.h:
2682
2683 2015-01-12  Anders Carlsson  <andersca@apple.com>
2684
2685         Delegates should be formal protocols
2686         https://bugs.webkit.org/show_bug.cgi?id=140360
2687         rdar://problem/17380856
2688
2689         Reviewed by Dan Bernstein.
2690
2691         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
2692
2693         * DefaultDelegates/WebDefaultUIDelegate.h:
2694         * Misc/WebDownload.h:
2695         * WebView/WebEditingDelegate.h:
2696         * WebView/WebFrameLoadDelegate.h:
2697         * WebView/WebPolicyDelegate.h:
2698         * WebView/WebUIDelegate.h:
2699
2700 2015-01-09  Anders Carlsson  <andersca@apple.com>
2701
2702         Get rid of the database strategy
2703         https://bugs.webkit.org/show_bug.cgi?id=140322
2704
2705         Reviewed by Sam Weinig.
2706
2707         * WebCoreSupport/WebPlatformStrategies.h:
2708         * WebCoreSupport/WebPlatformStrategies.mm:
2709         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
2710
2711 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
2712
2713         Can't use DataDetectors after immediate action preparation
2714         https://bugs.webkit.org/show_bug.cgi?id=140263
2715         <rdar://problem/19412705>
2716
2717         Reviewed by Beth Dakin.
2718
2719         * WebView/WebImmediateActionController.mm:
2720         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
2721         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
2722         To match WebKit2, only call shouldUseActions if the animation is actually
2723         going to begin, not when preparing for it. This way, we're guaranteed
2724         to get a didCancel or didComplete.
2725
2726 2015-01-08  Dean Jackson  <dino@apple.com>
2727
2728         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
2729         https://bugs.webkit.org/show_bug.cgi?id=140232
2730         <rdar://problem/19371010>
2731
2732         Reviewed by Anders Carlsson.
2733
2734         Remove the applicationChromeMode setting, but leave stubs in to make
2735         sure existing binaries don't break.
2736
2737         * WebCoreSupport/WebInspectorClient.mm:
2738         (-[WebInspectorWindowController init]):
2739         * WebView/WebPreferenceKeysPrivate.h:
2740         * WebView/WebPreferences.mm:
2741         (+[WebPreferences initialize]):
2742         (-[WebPreferences applicationChromeModeEnabled]):
2743         (-[WebPreferences setApplicationChromeModeEnabled:]):
2744         * WebView/WebView.mm:
2745         (-[WebView _preferencesChanged:]):
2746
2747 2015-01-07  Daniel Bates  <dabates@apple.com>
2748
2749         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2750         https://bugs.webkit.org/show_bug.cgi?id=137371
2751
2752         Reviewed by David Kilzer.
2753
2754         Use SPI wrapper headers instead of directly references private SPI headers.
2755
2756         * Plugins/Hosted/NetscapePluginHostManager.mm:
2757
2758 2015-01-07  Commit Queue  <commit-queue@webkit.org>
2759
2760         Unreviewed, rolling out r178068.
2761         https://bugs.webkit.org/show_bug.cgi?id=140235
2762
2763         Breaks the iOS build (Requested by enrica on #webkit).
2764
2765         Reverted changeset:
2766
2767         "[iOS] Make WebKit2 build with public iOS SDK and more build
2768         fixes for DRT"
2769         https://bugs.webkit.org/show_bug.cgi?id=137371
2770         http://trac.webkit.org/changeset/178068
2771
2772 2015-01-07  Daniel Bates  <dabates@apple.com>
2773
2774         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
2775         https://bugs.webkit.org/show_bug.cgi?id=137371
2776
2777         Reviewed by David Kilzer.
2778
2779         Use SPI wrapper headers instead of directly references private SPI headers.
2780
2781         * Plugins/Hosted/NetscapePluginHostManager.mm:
2782
2783 2015-01-07  Beth Dakin  <bdakin@apple.com>
2784
2785         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
2786         link
2787         https://bugs.webkit.org/show_bug.cgi?id=140206
2788         -and corresponding-
2789         rdar://problem/19300492
2790
2791         Reviewed by Tim Horton.
2792
2793         Providing and item frame will ensure that the original link is not obscured.
2794         * WebView/WebImmediateActionController.mm:
2795         (elementBoundingBoxInWindowCoordinatesFromNode):
2796         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
2797
2798         For now use a max size that is smaller than the WebView, with the screen’s aspect 
2799         ratio, and scaled down.
2800         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
2801
2802 2015-01-07  Anders Carlsson  <andersca@apple.com>
2803
2804         Give simple HTML documents a database provider
2805         https://bugs.webkit.org/show_bug.cgi?id=140192
2806         rdar://problem/19398825
2807
2808         Reviewed by Tim Horton.
2809
2810         * WebView/WebView.mm:
2811         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2812
2813 2015-01-06  Anders Carlsson  <andersca@apple.com>
2814
2815         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
2816         https://bugs.webkit.org/show_bug.cgi?id=140140
2817
2818         Reviewed by Andreas Kling.
2819
2820         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
2821         out of WebCore since nobody else is using it.
2822
2823         * Plugins/WebNetscapePluginView.h:
2824         * Plugins/WebNetscapePluginView.mm:
2825         (-[WebNetscapePluginView _createPlugin]):
2826         (-[WebNetscapePluginView _destroyPlugin]):
2827         * Plugins/npapi.mm:
2828         (NPN_PluginThreadAsyncCall):
2829
2830 2015-01-06  Anders Carlsson  <andersca@apple.com>
2831
2832         Add a WebKit1 database provider
2833         https://bugs.webkit.org/show_bug.cgi?id=140126
2834
2835         Reviewed by Sam Weinig.
2836
2837         Set the database provider.
2838
2839         * WebView/WebView.mm:
2840         (-[WebView _commonInitializationWithFrameName:groupName:]):
2841
2842 2015-01-06  Commit Queue  <commit-queue@webkit.org>
2843
2844         Unreviewed, rolling out r177963.
2845         https://bugs.webkit.org/show_bug.cgi?id=140136
2846
2847         Caused lots of crashes (Requested by smfr on #webkit).
2848
2849         Reverted changeset:
2850
2851         "Add a WebKit1 database provider"
2852         https://bugs.webkit.org/show_bug.cgi?id=140126
2853         http://trac.webkit.org/changeset/177963
2854
2855 2015-01-06  Anders Carlsson  <andersca@apple.com>
2856
2857         Add a WebKit1 database provider
2858         https://bugs.webkit.org/show_bug.cgi?id=140126
2859
2860         Reviewed by Sam Weinig.
2861
2862         Set the database provider.
2863
2864         * WebView/WebView.mm:
2865         (-[WebView _commonInitializationWithFrameName:groupName:]):
2866
2867 2015-01-01  Jeff Miller  <jeffm@apple.com>
2868
2869         Update user-visible copyright strings to include 2015
2870         https://bugs.webkit.org/show_bug.cgi?id=139880
2871
2872         Reviewed by Darin Adler.
2873
2874         * Info.plist:
2875
2876 2014-12-30  Dan Bernstein  <mitz@apple.com>
2877
2878         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
2879         https://bugs.webkit.org/show_bug.cgi?id=140003
2880
2881         Reviewed by Darin Adler.
2882
2883         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
2884         that takes their "string" parameter as a "value" "parameter and has an attribute telling
2885         the compiler that if the "value" parameter is a format string then the function returns a
2886         modified version of it. The result is that if UI_STRING is used as a format string parameter
2887         to some function or method, the compiler will check the format specifiers in the string
2888         against the other parameters.
2889
2890 2014-12-29  Dan Bernstein  <mitz@apple.com>
2891
2892         Fixed the iOS build.
2893
2894         * Configurations/WebKitLegacy.xcconfig:
2895
2896 2014-12-29  Anders Carlsson  <andersca@apple.com>
2897
2898         Get rid of some PageGroup storage functions
2899         https://bugs.webkit.org/show_bug.cgi?id=139996
2900
2901         Reviewed by Sam Weinig.
2902
2903         Call WebStorageNamespaceProvider directly instead.
2904
2905         * Storage/WebStorageManager.mm:
2906         (-[WebStorageManager syncLocalStorage]):
2907         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2908         * WebView/WebView.mm:
2909         (+[WebView _applicationWillTerminate]):
2910
2911 2014-12-29  Anders Carlsson  <andersca@apple.com>
2912
2913         Move storage code from WebCore to WebKit
2914         https://bugs.webkit.org/show_bug.cgi?id=139558
2915
2916         Reviewed by Darin Adler.
2917
2918         * Storage/WebStorageManager.mm:
2919         * Storage/WebStorageTrackerClient.h:
2920         * WebView/WebView.mm:
2921
2922 2014-12-26  Dan Bernstein  <mitz@apple.com>
2923
2924         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
2925         https://bugs.webkit.org/show_bug.cgi?id=139950
2926
2927         Reviewed by David Kilzer.
2928
2929         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
2930         in a manner that works with Xcode 5.1.1.
2931
2932 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
2933
2934         Install a TextIndicator for link immediate actions
2935         https://bugs.webkit.org/show_bug.cgi?id=139897
2936         <rdar://problem/19333076>
2937
2938         Reviewed by Anders Carlsson.
2939
2940         * WebView/WebImmediateActionController.h:
2941         * WebView/WebImmediateActionController.mm:
2942         (-[WebImmediateActionController _clearImmediateActionState]):
2943         Tear down the TextIndicator, just like WebKit2.
2944
2945         (-[WebImmediateActionController _defaultAnimationController]):
2946         Install a TextIndicator for links.
2947
2948         (-[WebImmediateActionController menuItemDidClose:]):
2949         Tear down the TextIndicator when the QL preview closes.
2950
2951         (-[WebImmediateActionController _menuItemForDataDetectedText]):
2952         Directly install and uninstall the TextIndicator for DataDetectors.
2953
2954         (-[WebImmediateActionController _showTextIndicator]): Deleted.
2955         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
2956         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
2957
2958 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
2959
2960         [iOS] add optimized fullscreen API
2961         https://bugs.webkit.org/show_bug.cgi?id=139833
2962         <rdar://problem/18844486>
2963
2964         Reviewed by Simon Fraser.
2965
2966         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
2967
2968 2014-12-20  David Kilzer  <ddkilzer@apple.com>
2969
2970         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
2971         <http://webkit.org/b/139463>
2972
2973         Reviewed by Mark Rowe.
2974
2975         * Configurations/Base.xcconfig:
2976         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
2977           on OS X.
2978         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
2979         * Configurations/DebugRelease.xcconfig:
2980         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
2981         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
2982         * Configurations/Version.xcconfig:
2983         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
2984         * Configurations/WebKitLegacy.xcconfig:
2985         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
2986           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
2987           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
2988           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
2989           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
2990           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
2991           WEBCORE_PRIVATE_HEADERS_DIR_Production and
2992           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
2993           based on SDK.
2994         - Fix PRODUCTION_ROOT to actually be set properly.
2995         - Simplify EXPORTED_SYMBOLS_FILE_i386.
2996
2997         * migrate-headers.sh:
2998         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
2999         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
3000           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
3001           WebKitLegacy.xcconfig.
3002
3003 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
3004
3005         Fix pink background on CoreAnimation plug-ins in WebKit1
3006         https://bugs.webkit.org/show_bug.cgi?id=139845
3007         rdar://problem/19313075
3008
3009         Reviewed by Tim Horton.
3010         
3011         r154078 left in some debugging code that set a pink background on plug-in hosting
3012         layers. Remove it.
3013
3014         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3015         (-[WebHostedNetscapePluginView createPluginLayer]):
3016
3017 2014-12-19  Andreas Kling  <akling@apple.com>
3018
3019         Ref-ify TextIterator API.
3020         <https://webkit.org/b/139823>
3021
3022         Reviewed by Antti Koivisto.
3023
3024         * WebView/WebTextIterator.mm:
3025         (-[WebTextIterator currentRange]):
3026
3027 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
3028
3029         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
3030         https://bugs.webkit.org/show_bug.cgi?id=139797
3031
3032         Reviewed by Mark Lam.
3033
3034         * WebView/WebScriptDebugger.h:
3035         * WebView/WebScriptDebugger.mm:
3036         (WebScriptDebugger::handlePause):
3037         Standardize on passing JSGlobalObject parameter first.
3038
3039 2014-12-19  Commit Queue  <commit-queue@webkit.org>
3040
3041         Unreviewed, rolling out r177574.
3042         https://bugs.webkit.org/show_bug.cgi?id=139821
3043
3044         "Broke Production builds by installing
3045         libWebCoreTestSupport.dylib in the wrong directory" (Requested
3046         by ddkilzer on #webkit).
3047
3048         Reverted changeset:
3049
3050         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
3051         WebInspectorUI, WebKit, WebKit2"
3052         https://bugs.webkit.org/show_bug.cgi?id=139463
3053         http://trac.webkit.org/changeset/177574
3054
3055 2014-12-19  David Kilzer  <ddkilzer@apple.com>
3056
3057         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
3058         <http://webkit.org/b/139463>
3059
3060         Reviewed by Mark Rowe.
3061
3062         * Configurations/Base.xcconfig:
3063         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
3064           on OS X.
3065         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
3066         * Configurations/DebugRelease.xcconfig:
3067         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
3068         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
3069         * Configurations/Version.xcconfig:
3070         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
3071         * Configurations/WebKitLegacy.xcconfig:
3072         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
3073           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
3074           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
3075           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
3076           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
3077           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
3078           WEBCORE_PRIVATE_HEADERS_DIR_Production and
3079           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
3080           based on SDK.
3081         - Fix PRODUCTION_ROOT to actually be set properly.
3082         - Simplify EXPORTED_SYMBOLS_FILE_i386.
3083
3084         * migrate-headers.sh:
3085         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
3086         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
3087           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
3088           WebKitLegacy.xcconfig.
3089
3090 2014-12-18  Andreas Kling  <akling@apple.com>
3091
3092         Ref-ify various Document-related things.
3093         <https://webkit.org/b/139796>
3094
3095         Reviewed by Anders Carlsson.
3096
3097         * WebView/WebFrame.mm:
3098         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3099
3100 2014-12-18  Beth Dakin  <bdakin@apple.com>
3101
3102         Need to re-enable action menus
3103         https://bugs.webkit.org/show_bug.cgi?id=139795
3104         -and corresponding-
3105         rdar://problem/19299367
3106
3107         Reviewed by Tim Horton.
3108
3109         Re-enable the menus by un-commenting the code to create the menu and controller.
3110         * WebView/WebView.mm:
3111         (-[WebView _commonInitializationWithFrameName:groupName:]):
3112
3113 2014-12-16  Sam Weinig  <sam@webkit.org>
3114
3115         Unify the Mac and iOS implementations of FontPlatformData a bit
3116         https://bugs.webkit.org/show_bug.cgi?id=139721
3117
3118         Reviewed by Anders Carlsson.
3119
3120         * WebView/WebHTMLView.mm:
3121         (fontNameForDescription):
3122         Update for new function name.
3123
3124 2014-12-18  Antti Koivisto  <antti@apple.com>
3125
3126         Remove alwaysUseBaselineOfPrimaryFont setting
3127         https://bugs.webkit.org/show_bug.cgi?id=139770
3128
3129         Reviewed by Anders Carlsson.
3130
3131         * WebView/WebPreferenceKeysPrivate.h:
3132         * WebView/WebPreferences.mm:
3133         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
3134         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
3135         * WebView/WebPreferencesPrivate.h:
3136         * WebView/WebView.mm:
3137         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3138         (-[WebView _preferencesChanged:]):
3139
3140 2014-12-17  Andreas Kling  <akling@apple.com>
3141
3142         Ref-ify Range::create().
3143         <https://webkit.org/b/139755>
3144
3145         Reviewed by Anders Carlsson.
3146
3147         * WebView/WebHTMLRepresentation.mm:
3148         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3149         * WebView/WebHTMLView.mm:
3150         (-[WebHTMLView attributedString]):
3151
3152 2014-12-17  Anders Carlsson  <andersca@apple.com>
3153
3154         Unify -[WebResource description]
3155         https://bugs.webkit.org/show_bug.cgi?id=139762
3156
3157         Reviewed by Dan Bernstein.
3158
3159         * WebView/WebResource.mm:
3160         (-[WebResource description]):
3161
3162 2014-12-17  Anders Carlsson  <andersca@apple.com>
3163
3164         Get rid of an ugly #define hack in WebFrameLoaderClient
3165         https://bugs.webkit.org/show_bug.cgi?id=139761
3166
3167         Reviewed by Dan Bernstein.
3168
3169         Also replace @private with @package in all public headers, for consistency.
3170
3171         * History/WebBackForwardList.h:
3172         * History/WebHistory.h:
3173         * Misc/WebDownload.h:
3174         * WebCoreSupport/WebFrameLoaderClient.mm:
3175         * WebView/WebArchive.h:
3176         * WebView/WebDataSource.h:
3177         * WebView/WebFrame.h:
3178         * WebView/WebFrameView.h:
3179         * WebView/WebPreferences.h:
3180         * WebView/WebResource.h:
3181
3182 2014-12-17  Dan Bernstein  <mitz@apple.com>
3183
3184         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
3185         https://bugs.webkit.org/show_bug.cgi?id=139760
3186
3187         Reviewed by Anders Carlsson.
3188
3189         * Configurations/WebKitLegacy.xcconfig:
3190
3191 2014-12-17  Andreas Kling  <akling@apple.com>
3192
3193         Purge PassRefPtr from Frame.
3194         <https://webkit.org/b/139731>
3195
3196         Reviewed by Anders Carlsson.
3197
3198         * WebCoreSupport/WebFrameLoaderClient.mm:
3199         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3200         * WebView/WebFrame.mm:
3201         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3202         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
3203         * WebView/WebFrameInternal.h:
3204
3205 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
3206
3207         Implement and adopt two new TextIndicator presentation animations
3208         https://bugs.webkit.org/show_bug.cgi?id=139715
3209         <rdar://problem/19237945>
3210
3211         Reviewed by Anders Carlsson.
3212
3213         * WebView/WebActionMenuController.mm:
3214         (-[WebActionMenuController _showTextIndicator]):
3215         * WebView/WebHTMLView.mm:
3216         (-[WebHTMLView quickLookWithEvent:]):
3217         Remove the completionHandler from text indicator presentation.
3218
3219         * WebView/WebImmediateActionController.mm:
3220         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3221         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
3222         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3223         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3224         (-[WebImmediateActionController _menuItemForDataDetectedText]):
3225         (-[WebImmediateActionController _animationControllerForText]):
3226         (-[WebImmediateActionController _showTextIndicator]):
3227         Forward immediate action gesture recognizer animation progress
3228         to TextIndicator. Force us to keep the selection when immediate
3229         action popovers steal first responder status from the WebView.
3230         If the Lookup range is equal to the selection range, use a Crossfade
3231         animation; otherwise, use a FadeIn animation.
3232
3233         * WebView/WebView.mm:
3234         (-[WebView _setMaintainsInactiveSelection:]):
3235         (-[WebView maintainsInactiveSelection]):
3236         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3237         (-[WebView _setTextIndicator:fadeOut:]):
3238         (-[WebView _clearTextIndicator]):
3239         (-[WebView _setTextIndicatorAnimationProgress:]):
3240         (-[WebView _showDictionaryLookupPopup:]):
3241         (-[WebView _dictionaryLookupPopoverWillClose:]):
3242         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3243         Remove the completionHandler from text indicator presentation.
3244         Add a _setMaintainsInactiveSelection, which allows WebKit internals
3245         to change the return value of -maintainsInactiveSelection, allowing
3246         us to keep the selection alive when the WebView loses first responder status.
3247
3248         * WebView/WebViewData.h:
3249         * WebView/WebViewInternal.h:
3250
3251 2014-12-16  Andreas Kling  <akling@apple.com>
3252
3253         Use Ref for SecurityOrigin.
3254         <https://webkit.org/b/139710>
3255
3256         Reviewed by Anders Carlsson.
3257
3258         * Storage/WebStorageTrackerClient.mm:
3259         (WebStorageTrackerClient::dispatchDidModifyOrigin):
3260         * WebView/WebView.mm:
3261         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3262         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3263
3264 2014-12-16  Beth Dakin  <bdakin@apple.com>
3265
3266         Crash getting default animation controller for some text
3267         https://bugs.webkit.org/show_bug.cgi?id=139712
3268         -and corresponding-
3269         rdar://problem/19271707
3270
3271         Reviewed by Tim Horton.
3272
3273         Must null-check the range.
3274         * WebView/WebImmediateActionController.mm:
3275         (-[WebImmediateActionController _animationControllerForText]):
3276
3277 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
3278
3279         Immediate action popovers can get stuck open
3280         https://bugs.webkit.org/show_bug.cgi?id=139709
3281         <rdar://problem/19270279>
3282
3283         Reviewed by Beth Dakin.
3284
3285         * WebView/WebImmediateActionController.mm:
3286         (-[WebImmediateActionController _clearImmediateActionState]):
3287         Don't clear the animation controller; it breaks things and was unnecessary.
3288
3289 2014-12-16  Tim Horton  <timothy_horton@apple.com>
3290
3291         Disable TextIndication for Lookup immediate actions
3292         https://bugs.webkit.org/show_bug.cgi?id=139684
3293
3294         Reviewed by Anders Carlsson.
3295
3296         * WebView/WebView.mm:
3297         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3298
3299 2014-12-15  Beth Dakin  <bdakin@apple.com>
3300
3301         Build fix.
3302
3303         * WebView/WebImmediateActionController.mm:
3304
3305 2014-12-15  Beth Dakin  <bdakin@apple.com>
3306
3307         Speculative build fix.
3308
3309         * WebView/WebView.mm:
3310         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3311         * WebView/WebViewInternal.h:
3312
3313 2014-12-15  Beth Dakin  <bdakin@apple.com>
3314
3315         Make lookup an immediate action instead of an action menu item
3316         https://bugs.webkit.org/show_bug.cgi?id=139661
3317         -and corresponding-
3318         rdar://problem/19198414
3319
3320         Reviewed by Tim Horton.
3321
3322         Remove the lookup menu items and non-unused static function associated with 
3323         lookup.
3324         * WebView/WebActionMenuController.mm:
3325         (-[WebActionMenuController _defaultMenuItemsForText]):
3326         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
3327         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
3328         (-[WebActionMenuController _createActionMenuItemForTag:]):
3329         (-[WebActionMenuController _lookupText:]): Deleted.
3330         (performDictionaryLookupForSelection): Deleted.
3331         (performDictionaryLookupForRange): Deleted.
3332
3333         Set the defaultAnimationController to the lookup-provided animation controller 
3334         when appropriate.
3335         * WebView/WebImmediateActionController.mm:
3336         (-[WebImmediateActionController _defaultAnimationController]):
3337         (dictionaryPopupInfoForRange):
3338         (-[WebImmediateActionController _animationControllerForText]):
3339
3340         New type.
3341         * WebView/WebUIDelegatePrivate.h:
3342
3343         New function to get the lookup animation controller.
3344         * WebView/WebView.mm:
3345         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3346         * WebView/WebViewInternal.h:
3347
3348 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3349
3350         Implement Data Detectors immediate actions for Legacy WebKit
3351         https://bugs.webkit.org/show_bug.cgi?id=139619
3352         <rdar://problem/19198539>
3353
3354         Reviewed by Beth Dakin.
3355
3356         * WebView/WebImmediateActionController.mm:
3357         (-[WebImmediateActionController _menuItemForDataDetectedText]):
3358         Note that this action context is only for immediate actions.
3359
3360 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
3361
3362         Addressing post-review comments in r177035
3363         https://bugs.webkit.org/show_bug.cgi?id=139557
3364
3365         Reviewed by Darin Adler.
3366
3367         * WebView/WebActionMenuController.mm:
3368         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
3369
3370 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
3371
3372         Implement Data Detectors immediate actions for Legacy WebKit
3373         https://bugs.webkit.org/show_bug.cgi?id=139619
3374         <rdar://problem/19198539>
3375
3376         Reviewed by Eric Carlson.
3377
3378         * WebView/WebHTMLView.mm:
3379         (-[WebHTMLView mouseDown:mouseDown:]):
3380         Send mouseDown along to the WebImmediateActionController too.
3381
3382         * WebView/WebImmediateActionController.h:
3383         * WebView/WebImmediateActionController.mm:
3384         (-[WebImmediateActionController webViewClosed]):
3385         (-[WebImmediateActionController webView:willHandleMouseDown:]):
3386         (-[WebImmediateActionController _cancelImmediateAction]):
3387         (-[WebImmediateActionController _clearImmediateActionState]):
3388         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3389         (-[WebImmediateActionController _defaultAnimationController]):
3390         (-[WebImmediateActionController _updateImmediateActionItem]):
3391         (-[WebImmediateActionController _menuItemForDataDetectedText]):
3392         (-[WebImmediateActionController _showTextIndicator]):
3393         (-[WebImmediateActionController _hideTextIndicator]):
3394         Copy most of the DataDetectors implementation into WebImmediateActionController.
3395
3396         * WebView/WebUIDelegatePrivate.h:
3397         Add a new type.
3398
3399         * WebView/WebView.mm:
3400         (-[WebView _commonInitializationWithFrameName:groupName:]):
3401         Temporarily disable action menus.
3402
3403         (-[WebView _immediateActionController]):
3404         * WebView/WebViewInternal.h:
3405
3406 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
3407
3408         Delete Notation because we don't use it
3409         https://bugs.webkit.org/show_bug.cgi?id=139171
3410
3411         Reviewed by Kent Tamura.
3412
3413         * MigrateHeaders.make:
3414
3415 2014-12-14  Andreas Kling  <akling@apple.com>
3416
3417         Replace PassRef with Ref/Ref&& across the board.
3418         <https://webkit.org/b/139587>
3419
3420         Reviewed by Darin Adler.
3421
3422         * WebCoreSupport/WebEditorClient.mm:
3423         (WebEditorClient::shouldApplyStyle):
3424         * WebCoreSupport/WebVisitedLinkStore.h:
3425         * WebCoreSupport/WebVisitedLinkStore.mm:
3426         (WebVisitedLinkStore::create):
3427
3428 2014-12-11  Dan Bernstein  <mitz@apple.com>
3429
3430         Fix a leak introduced in r177199.
3431
3432         Reviewed by Anders Carlsson.
3433
3434         * WebView/WebImmediateActionController.mm:
3435         (-[WebImmediateActionController _updateImmediateActionItem]):
3436
3437 2014-12-11  Beth Dakin  <bdakin@apple.com>
3438
3439         WK1: Need new SPI for Webkit clients to override default immediate action
3440         https://bugs.webkit.org/show_bug.cgi?id=139568
3441         -and corresponding-
3442         rdar://problem/19225448
3443
3444         Reviewed by Dan Bernstein.
3445
3446         Call SPI giving clients a chance to override the default behavior.
3447         * WebView/WebImmediateActionController.mm:
3448         (-[WebImmediateActionController _updateImmediateActionItem]):
3449
3450         New SPI.
3451         * WebView/WebUIDelegatePrivate.h:
3452
3453 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
3454
3455         Move the preview popover to WebImmediateActionController
3456         https://bugs.webkit.org/show_bug.cgi?id=139563
3457         <rdar://problem/19208291>
3458
3459         Reviewed by Beth Dakin.
3460
3461         * WebView/WebActionMenuController.mm:
3462         (-[WebActionMenuController _defaultMenuItemsForLink]):
3463         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
3464         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
3465         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
3466         * WebView/WebImmediateActionController.h:
3467         * WebView/WebImmediateActionController.mm:
3468         (-[WebImmediateActionController webViewClosed]):
3469         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3470         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3471         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3472         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3473         (-[WebImmediateActionController _updateImmediateActionItem]):
3474         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
3475         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
3476         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
3477         Move page preview popover related code to WebImmediateActionController.
3478
3479         * WebView/WebUIDelegatePrivate.h:
3480         Add a link preview type.
3481
3482         * WebView/WebView.mm:
3483         (-[WebView _commonInitializationWithFrameName:groupName:]):
3484         Pass the gesture recognizer to the WebImmediateActionController.
3485
3486 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
3487
3488         Fix the build.
3489
3490         * WebView/WebImmediateActionController.h:
3491         * WebView/WebImmediateActionController.mm:
3492
3493 2014-12-11  Anders Carlsson  <andersca@apple.com>
3494
3495         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
3496         https://bugs.webkit.org/show_bug.cgi?id=139547
3497
3498         Reviewed by Sam Weinig.
3499
3500         * WebView/WebView.mm:
3501         (+[WebView _handleMemoryWarning]):
3502
3503 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
3504
3505         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
3506         https://bugs.webkit.org/show_bug.cgi?id=139504
3507         rdar://problem/19034674
3508
3509         Reviewed by Enrica Casucci.
3510
3511         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
3512
3513         * WebCoreSupport/WebEditorClient.h:
3514         * WebCoreSupport/WebEditorClient.mm:
3515         (WebEditorClient::discardedComposition):
3516
3517 2014-12-10  Anders Carlsson  <andersca@apple.com>
3518
3519         Get rid of the storage strategy
3520         https://bugs.webkit.org/show_bug.cgi?id=139519
3521
3522         Reviewed by Antti Koivisto.
3523
3524         * WebCoreSupport/WebPlatformStrategies.h:
3525         * WebCoreSupport/WebPlatformStrategies.mm:
3526         (WebPlatformStrategies::createStorageStrategy): Deleted.
3527
3528 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
3529
3530         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
3531         https://bugs.webkit.org/show_bug.cgi?id=139529
3532         <rdar://problem/19213620>
3533
3534         Reviewed by Beth Dakin.
3535
3536         * WebView/WebActionMenuController.mm:
3537         (-[WebActionMenuController _copySelection:]):
3538         (-[WebActionMenuController _paste:]):
3539         Use the copy: and paste: methods on WebView so that we traverse subviews
3540         when trying to respond, otherwise these actions don't work in subframes.
3541
3542 2014-12-10  Beth Dakin  <bdakin@apple.com>
3543
3544         WK1: Add initial support for immediate actions
3545         https://bugs.webkit.org/show_bug.cgi?id=139522
3546
3547         Reviewed by Dan Bernstein.
3548
3549         This basic implementation of the controller will use the delegate methods to 
3550         perform and cache a HitTest when relevant. Future patches will patch 
3551         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
3552         immediate action that should be taken.
3553         * WebView/WebImmediateActionController.h: Added.
3554         * WebView/WebImmediateActionController.mm: Added.
3555         (-[WebImmediateActionController webViewClosed]):
3556         (-[WebImmediateActionController _clearImmediateActionState]):
3557         (-[WebImmediateActionController performHitTestAtPoint:]):
3558         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
3559         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
3560         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
3561         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
3562         (-[WebImmediateActionController _updateImmediateActionItem]):
3563
3564         New enum for immediate action types.
3565         * WebView/WebUIDelegatePrivate.h:
3566
3567         Create an NSImmediateActionGestureRecognizer if possible and a controller.
3568         * WebView/WebView.mm:
3569         (-[WebView _commonInitializationWithFrameName:groupName:]):
3570         (-[WebView _close]):
3571         * WebView/WebViewData.h:
3572         * WebView/WebViewData.mm:
3573         (-[WebViewPrivate dealloc]):
3574
3575 2014-12-08  Anders Carlsson  <andersca@apple.com>
3576
3577         Use the new storage namespace provider in WebKit1
3578         https://bugs.webkit.org/show_bug.cgi?id=139425
3579
3580         Reviewed by Tim Horton.
3581
3582         * WebView/WebView.mm:
3583         (-[WebView _commonInitializationWithFrameName:groupName:]):
3584         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3585         Set the storage namespace provider from the web page group.
3586
3587 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
3588
3589         Should have copy and paste items in all text menus
3590         https://bugs.webkit.org/show_bug.cgi?id=139510
3591         <rdar://problem/19198388>
3592
3593         Reviewed by Beth Dakin.
3594
3595         * WebView/WebActionMenuController.mm:
3596         (-[WebActionMenuController _defaultMenuItemsForText]):
3597         Add a disabled paste menu item into the read-only text menu.
3598
3599         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
3600         Add a disabled copy menu item into the editable whitespace text menu.
3601
3602 2014-12-10  Anders Carlsson  <andersca@apple.com>
3603
3604         Add WebStorageNamespaceProvider::closeLocalStorage
3605         https://bugs.webkit.org/show_bug.cgi?id=139502
3606
3607         Reviewed by Tim Horton.
3608
3609         * WebView/WebView.mm:
3610         (+[WebView _applicationWillTerminate]):
3611         Call WebStorageNamespaceProvider::closeLocalStorage.
3612
3613 2014-12-09  Commit Queue  <commit-queue@webkit.org>
3614
3615         Unreviewed, rolling out r177037.
3616         https://bugs.webkit.org/show_bug.cgi?id=139464
3617
3618         broke ~50 API tests (Requested by thorton on #webkit).
3619
3620         Reverted changeset:
3621
3622         "Use the new storage namespace provider in WebKit1"
3623         https://bugs.webkit.org/show_bug.cgi?id=139425
3624         http://trac.webkit.org/changeset/177037
3625
3626 2014-12-08  Anders Carlsson  <andersca@apple.com>
3627
3628         Use the new storage namespace provider in WebKit1
3629         https://bugs.webkit.org/show_bug.cgi?id=139425
3630
3631         Reviewed by Tim Horton.
3632
3633         * WebView/WebView.mm:
3634         (-[WebView _commonInitializationWithFrameName:groupName:]):
3635         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3636         Set the storage namespace provider from the web page group.
3637
3638 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
3639
3640         Delete Node::boundingBox()
3641         https://bugs.webkit.org/show_bug.cgi?id=139333
3642
3643         Reviewed by Zalan Bujtas.
3644
3645         * WebView/WebActionMenuController.mm:
3646         (elementBoundingBoxInWindowCoordinatesFromNode): Use
3647         RenderObject::absoluteBoundingBoxRect().
3648
3649 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
3650
3651         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
3652         https://bugs.webkit.org/show_bug.cgi?id=138843
3653         rdar://problem/18793695
3654
3655         Reviewed by Dan Bernstein.
3656
3657         * Panels/WebAuthenticationPanel.m:
3658         (-[WebAuthenticationPanel cancel:]):
3659         (-[WebAuthenticationPanel logIn:]):
3660         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
3661         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
3662         that only when using an old NSWindow API.
3663
3664 2014-12-08  Beth Dakin  <bdakin@apple.com>
3665
3666         Copy and Lookup menu items should be disabled when something is not copyable
3667         https://bugs.webkit.org/show_bug.cgi?id=139423
3668
3669         Reviewed by Tim Horton.
3670
3671         Disable both lookup and copy when a HitTestResult does not allow copy.
3672         * WebView/WebActionMenuController.mm:
3673
3674         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
3675         disable state otherwise.
3676         * WebView/WebView.mm:
3677         (-[WebView _commonInitializationWithFrameName:groupName:]):
3678
3679 2014-12-08  Anders Carlsson  <andersca@apple.com>
3680
3681         Adding user content to a group should force that group to be created
3682         https://bugs.webkit.org/show_bug.cgi?id=139421
3683         rdar://problem/19180108
3684
3685         Reviewed by Sam Weinig.
3686
3687         * WebCoreSupport/WebViewGroup.h:
3688         Store the local storage database path in the group.
3689
3690         * WebCoreSupport/WebViewGroup.mm:
3691         (WebViewGroup::getOrCreate):
3692         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
3693         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
3694
3695         (WebViewGroup::WebViewGroup):
3696         Initialize the new member variable.
3697
3698         (WebViewGroup::storageNamespaceProvider):
3699         Create the namespace provider lazily.
3700
3701         * WebView/WebView.mm:
3702         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
3703         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
3704         Use getOrCreate instead of get.
3705
3706 2014-12-08  Anders Carlsson  <andersca@apple.com>
3707
3708         WebStorageNamespaceProvider should know about its local storage database path
3709         https://bugs.webkit.org/show_bug.cgi?id=139413
3710
3711         Reviewed by Andreas Kling.
3712
3713         * WebCoreSupport/WebViewGroup.h:
3714         * WebCoreSupport/WebViewGroup.mm:
3715         (WebViewGroup::getOrCreate):
3716         (WebViewGroup::WebViewGroup):
3717         * WebView/WebView.mm:
3718         (-[WebView _commonInitializationWithFrameName:groupName:]):
3719         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3720         (-[WebView setGroupName:]):
3721         (-[WebView groupName]): Deleted.
3722
3723 2014-12-08  Daniel Bates  <dabates@apple.com>
3724
3725         [iOS] Fix the WebKit build with the public SDK
3726
3727         Include header NSURLDownloadSPI.h.
3728
3729         * WebCoreSupport/WebFrameLoaderClient.mm:
3730
3731 2014-12-07  Dan Bernstein  <mitz@apple.com>
3732
3733         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
3734         https://bugs.webkit.org/show_bug.cgi?id=139348
3735
3736         Reviewed by Anders Carlsson.
3737
3738         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
3739         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
3740         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
3741         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
3742         avoiding the ambiguity.
3743
3744         * WebView/WebActionMenuController.mm:
3745         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3746
3747 2014-12-06  Anders Carlsson  <andersca@apple.com>
3748
3749         Add a stubbed out version of WebStorageNamespaceProvider
3750         https://bugs.webkit.org/show_bug.cgi?id=139213
3751
3752         Reviewed by Sam Weinig.
3753
3754         * WebCoreSupport/WebViewGroup.h:
3755         (WebViewGroup::storageNamespaceProvider):
3756         * WebCoreSupport/WebViewGroup.mm:
3757         (WebViewGroup::getOrCreate):
3758         (WebViewGroup::WebViewGroup):
3759         Give WebViewGroup a storage namespace provider.
3760
3761 2014-12-06  Anders Carlsson  <andersca@apple.com>
3762
3763         Fix build with newer versions of clang.
3764         rdar://problem/18978687
3765
3766         Add missing overrides and missing casts.
3767
3768         * Storage/WebDatabaseManagerClient.h:
3769         * Storage/WebStorageTrackerClient.h:
3770         * WebCoreSupport/WebChromeClient.h:
3771         * WebCoreSupport/WebFrameLoaderClient.h:
3772         * WebCoreSupport/WebInspectorClient.h:
3773         * WebView/WebDataSource.mm:
3774         (-[WebDataSource _makeRepresentation]):
3775         * WebView/WebFrameView.mm:
3776         (-[WebFrameView _makeDocumentViewForDataSource:]):
3777
3778 2014-12-05  Tim Horton  <timothy_horton@apple.com>
3779
3780         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
3781         https://bugs.webkit.org/show_bug.cgi?id=139306
3782         <rdar://problem/19157955>
3783
3784         Reviewed by Beth Dakin.
3785
3786         * WebView/WebView.mm:
3787         (-[WebView _commonInitializationWithFrameName:groupName:]):
3788         (-[WebView _initWithFrame:frameName:groupName:]):
3789         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
3790
3791 2014-12-05  David Kilzer  <ddkilzer@apple.com>
3792
3793         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
3794         <http://webkit.org/b/139286>
3795
3796         Reviewed by Daniel Bates.
3797
3798         * Configurations/FeatureDefines.xcconfig: Switch back to using
3799         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
3800
3801 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
3802
3803         Fix the 32-bit build.
3804
3805         * WebView/WebView.mm:
3806         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3807
3808 2014-12-04  Tim Horton  <timothy_horton@apple.com>
3809
3810         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
3811         https://bugs.webkit.org/show_bug.cgi?id=139252
3812         <rdar://problem/19140827>
3813
3814         Reviewed by Anders Carlsson.
3815
3816         * WebView/WebView.mm:
3817         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
3818         Adjust to the WebCore changes.
3819
3820 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3821
3822         Implement action menus for tel: URLs
3823         https://bugs.webkit.org/show_bug.cgi?id=139240
3824         <rdar://problem/19115662>
3825
3826         Reviewed by Anders Carlsson.
3827
3828         * WebView/WebActionMenuController.mm:
3829         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3830         Make sure to use the newly created currentActionContext... everywhere.
3831
3832 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
3833
3834         Implement action menus for tel: URLs
3835         https://bugs.webkit.org/show_bug.cgi?id=139240
3836         <rdar://problem/19115662>
3837
3838         Reviewed by Anders Carlsson.
3839
3840         * WebView/WebActionMenuController.mm:
3841         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3842         Make sure to use the newly created currentActionContext.
3843
3844 2014-12-03  Beth Dakin  <bdakin@apple.com>
3845
3846         <input> elements get whitespace action menu instead of editable text menu
3847         https://bugs.webkit.org/show_bug.cgi?id=139241
3848         -and corresponding-
3849         rdar://problem/19072083
3850
3851         Reviewed by Sam Weinig.
3852
3853         We should disallow shadow content in the hit test. This is the default and it is 
3854         how context menus behave. We originally wanted to text inside shadow content so 
3855         that we could find the text, but the new function I added to HitTestResult will 
3856         allow that.
3857         * WebView/WebActionMenuController.mm:
3858         (-[WebActionMenuController performHitTestAtPoint:]):
3859
3860         Adjust to the fact that we don’t hit test shadow content any more.
3861         (-[WebActionMenuController focusAndSelectHitTestResult]):
3862
3863         Offer the text menus for text inside form controls.
3864         (-[WebActionMenuController _defaultMenuItems]):
3865
3866 2014-12-03  Tim Horton  <timothy_horton@apple.com>
3867
3868         Implement action menus for tel: URLs
3869         https://bugs.webkit.org/show_bug.cgi?id=139240
3870         <rdar://problem/19115662>
3871
3872         Reviewed by Anders Carlsson.
3873
3874         * WebView/WebActionMenuController.mm:
3875         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
3876         Rename this function as it will work for both mailto and tel URLs.
3877         Adjust it to use contextForView:.
3878
3879         (-[WebActionMenuController webView:willHandleMouseDown:]):
3880         (-[WebActionMenuController prepareForMenu:withEvent:]):
3881         (-[WebActionMenuController didCloseMenu:withEvent:]):
3882         (-[WebActionMenuController _defaultMenuItems]):
3883         Don't check the menu type when going to interact with _currentActionContext.
3884         We'll only have a _currentActionContext if we have a data detected item,
3885         and there are multiple menu types that end up using DDActionContext.
3886
3887         * WebView/WebUIDelegatePrivate.h:
3888         Add a new type.
3889
3890 2014-12-03  Anders Carlsson  <andersca@apple.com>
3891
3892         Set a visited link store when creating a simple WebView
3893         https://bugs.webkit.org/show_bug.cgi?id=139234
3894         <rdar://problem/19132978>
3895
3896         Reviewed by Sam Weinig.
3897
3898         * WebView/WebView.mm:
3899         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3900
3901 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3902
3903         Fix the build.
3904
3905         * WebCoreSupport/WebFrameLoaderClient.mm:
3906
3907 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3908
3909         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3910         https://bugs.webkit.org/show_bug.cgi?id=139149
3911
3912         Reviewed by Anders Carlsson.
3913
3914         This changes API behavior. I think that it's OK, because existing behavior made no sense.
3915         We used to delete caches from disk, but they were still active in memory. Now we also
3916         obsolete them in memory, so documents that use a cache still work, but new ones don't
3917         pick one up.
3918
3919         * WebCoreSupport/WebApplicationCache.mm:
3920         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
3921         need to delete in-momry caches too. Keep existing behavior.
3922         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
3923         that properly deletes caches.
3924
3925 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3926
3927         Remove a SnowLeopard-era quirk for QuickLook
3928         https://bugs.webkit.org/show_bug.cgi?id=139208
3929         <rdar://problem/19121822>
3930
3931         Reviewed by Alexey Proskuryakov.
3932
3933         * WebCoreSupport/WebFrameLoaderClient.h:
3934         * WebCoreSupport/WebFrameLoaderClient.mm:
3935
3936 2014-12-02  Tim Horton  <timothy_horton@apple.com>
3937
3938         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
3939         https://bugs.webkit.org/show_bug.cgi?id=139204
3940
3941         Reviewed by Anders Carlsson.
3942
3943         * WebView/WebView.mm:
3944         (-[WebView _commonInitializationWithFrameName:groupName:]):
3945         (-[WebView _showDictionaryLookupPopup:]):
3946         * WebView/WebViewData.h:
3947         Work around this by delaying the softlinking (and setting up the notification
3948         observer) until we actually need it. There's still an underlying bug, but
3949         this will fix the test.
3950
3951 2014-12-02  Beth Dakin  <bdakin@apple.com>
3952
3953         Yet another build fix.
3954
3955         * WebView/WebActionMenuController.mm:
3956         (-[WebActionMenuController _defaultMenuItemsForLink]):
3957
3958 2014-12-02  Beth Dakin  <bdakin@apple.com>
3959
3960         Build fix.
3961
3962         * WebView/WebActionMenuController.mm:
3963         (-[WebActionMenuController _defaultMenuItemsForLink]):
3964
3965 2014-12-02  Beth Dakin  <bdakin@apple.com>
3966
3967         More build fixing.
3968
3969         * WebView/WebActionMenuController.mm:
3970         (-[WebActionMenuController _defaultMenuItemsForLink]):
3971
3972 2014-12-02  Beth Dakin  <bdakin@apple.com>
3973
3974         Should use standardQuickLookMenuItem for apps that don't implement customizations
3975         https://bugs.webkit.org/show_bug.cgi?id=139193
3976         -and corresponding-
3977         rdar://problem/18944696
3978
3979         Reviewed by Anders Carlsson.
3980
3981         Use [NSMenuItem standardQuickLookMenuItem].
3982         * WebView/WebActionMenuController.mm:
3983         (-[WebActionMenuController _defaultMenuItemsForLink]):
3984
3985         Delegate methods to set up the standardQuickLookMenuItem.
3986         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
3987         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
3988         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
3989
3990         Remove all of the old QLPreviewBubble code.
3991         (-[WebActionMenuController _createActionMenuItemForTag:]):
3992         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
3993
3994 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
3995
3996         Fix the build.
3997
3998         * WebView/WebViewData.h:
3999
4000 2014-12-02  Tim Horton  <timothy_horton@apple.com>
4001
4002         Implement Lookup transition from selection for Legacy WebKit
4003         https://bugs.webkit.org/show_bug.cgi?id=139180
4004         <rdar://problem/19067172>
4005
4006         Reviewed by Beth Dakin.
4007
4008         * WebView/DictionaryPopupInfo.h: Added.
4009         Split DictionaryPopupInfo out into its own file.
4010
4011         * WebView/WebActionMenuController.mm:
4012         (-[WebActionMenuController _lookupText:]):
4013         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
4014
4015         (performDictionaryLookupForSelection):
4016         (performDictionaryLookupForRange):
4017         Plumb the transition style through these helpers.
4018         Create a TextIndicator from the selection range.
4019
4020         * WebView/WebHTMLView.mm:
4021         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
4022         Make use of TextIndicator (and DictionaryPopupInfo, and the new
4023         _showDictionaryLookupPopup on WebView) to add a transition from blue
4024         when performing Lookup from the context menu.
4025
4026         (-[WebHTMLView quickLookWithEvent:]):
4027         Remove our TextIndicator whenever a normal three-finger-tap event
4028         comes through, as it will have its own indication.
4029
4030         * WebView/WebView.mm:
4031         (-[WebView _commonInitializationWithFrameName:groupName:]):
4032         (-[WebView _dictionaryLookupPopoverWillClose:]):
4033         Register for the LUNotificationPopoverWillClose notification and remove
4034         our TextIndicator when it is called, just like in WebKit2.
4035         Deregistration is already handled in _close.
4036
4037         (-[WebView _showDictionaryLookupPopup:]):
4038         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
4039         if the relevant API is available.
4040
4041         * WebView/WebViewInternal.h:
4042
4043 2014-12-02  Anders Carlsson  <andersca@apple.com>
4044
4045         Remove visited link handling from PageGroup
4046         https://bugs.webkit.org/show_bug.cgi?id=139185
4047
4048         Reviewed by Sam Weinig.
4049
4050         * History/WebHistory.mm:
4051         (-[WebHistoryPrivate removeItemForURLString:]):
4052         (-[WebHistoryPrivate removeAllItems]):
4053         (+[WebHistory setOptionalSharedHistory:]):
4054         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
4055         (+[WebHistory _removeAllVisitedLinks]):
4056         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
4057         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
4058         * History/WebHistoryInternal.h:
4059         * WebCoreSupport/WebChromeClient.h:
4060         * WebCoreSupport/WebChromeClient.mm:
4061         (WebChromeClient::populateVisitedLinks): Deleted.
4062         * WebView/WebView.mm:
4063         (-[WebView addVisitedLinks:]):
4064         (-[WebView removeVisitedLink:]):
4065
4066 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
4067
4068         Try to fix the Mac build.
4069
4070         * WebView/WebView.mm:
4071         (-[WebView _commonInitializationWithFrameName:groupName:]):
4072         (-[WebView _close]):
4073
4074 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
4075
4076         Fix the iOS build.
4077
4078         * WebView/WebActionMenuController.h:
4079         * WebView/WebActionMenuController.mm:
4080         * WebView/WebHTMLView.mm:
4081         (-[WebHTMLView scrollWheel:scrollWheel:]):
4082         (-[WebHTMLView mouseDown:mouseDown:]):
4083         * WebView/WebView.mm:
4084         * WebView/WebViewData.h:
4085         * WebView/WebViewData.mm:
4086         (-[WebViewPrivate dealloc]):
4087         * WebView/WebViewInternal.h:
4088
4089 2014-12-01  Tim Horton  <timothy_horton@apple.com>
4090
4091         Implement yellow highlight for WebKit1 data detectors
4092         https://bugs.webkit.org/show_bug.cgi?id=138956
4093         <rdar://problem/18992185>
4094
4095         Reviewed by Beth Dakin.
4096
4097         * WebView/WebActionMenuController.h:
4098         * WebView/WebActionMenuController.mm:
4099         (-[WebActionMenuController webView:willHandleMouseDown:]):
4100         (-[WebActionMenuController webView:didHandleScrollWheel:]):
4101         (-[WebActionMenuController prepareForMenu:withEvent:]):
4102         (-[WebActionMenuController didCloseMenu:withEvent:]):
4103         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
4104         (-[WebActionMenuController _showTextIndicator]):
4105         (-[WebActionMenuController _hideTextIndicator]):
4106         (-[WebActionMenuController _dismissActionMenuPopovers]):
4107         Copy the WebKit2 WKActionMenuController TextIndicator implementation
4108         into WebActionMenuController. The only significant difference is
4109         that we build the TextIndicator right at menu construction time
4110         instead of in the Web process.
4111
4112         * WebView/WebHTMLView.mm:
4113         (-[WebHTMLView scrollWheel:]):
4114         Let the WebActionMenuController know that we're handling a scroll.
4115
4116         (-[WebHTMLView mouseDown:]):
4117         Let the WebActionMenuController know that we're handling a mouseDown.
4118
4119         * WebView/WebView.mm:
4120         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
4121         (-[WebView _clearTextIndicator]):
4122         (-[WebView _actionMenuController]):
4123         (-[WebView _convertRectFromRootView:]): Deleted.
4124         * WebView/WebViewData.h:
4125         * WebView/WebViewData.mm:
4126         * WebView/WebViewInternal.h:
4127         Keep a TextIndicatorWindow on WebView, just like WKView does.
4128         Expose the WebActionMenuController on WebView (internally).
4129
4130 2014-12-01  Anders Carlsson  <andersca@apple.com>
4131
4132         Remove old site specific quirks code that was added in 2009
4133         https://bugs.webkit.org/show_bug.cgi?id=139141
4134
4135         Reviewed by Antti Koivisto.
4136
4137         * WebCoreSupport/WebFrameNetworkingContext.h:
4138         * WebCoreSupport/WebFrameNetworkingContext.mm:
4139         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
4140
4141 2014-11-30  Anders Carlsson  <andersca@apple.com>
4142
4143         Fix a test failure.
4144
4145         * History/WebHistory.mm:
4146         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
4147         Call through to the visited link store.
4148
4149         (+[WebHistory _removeAllVisitedLinks]):
4150         Ditto.
4151
4152         * WebCoreSupport/WebVisitedLinkStore.mm:
4153         (WebVisitedLinkStore::isLinkVisited):
4154         Make sure to populate visited links.
4155
4156 2014-11-30  Anders Carlsson  <andersca@apple.com>
4157
4158         Switch over to the visited link store from the WebViewGroup
4159         https://bugs.webkit.org/show_bug.cgi?id=139112
4160
4161         Reviewed by Sam Weinig.
4162
4163         * WebView/WebView.mm:
4164         (-[WebView _commonInitializationWithFrameName:groupName:]):
4165         (-[WebView setGroupName:]):
4166
4167 2014-11-30  Anders Carlsson  <andersca@apple.com>
4168
4169         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
4170         https://bugs.webkit.org/show_bug.cgi?id=139111
4171
4172         Reviewed by Sam Weinig.
4173
4174         * WebCoreSupport/WebVisitedLinkStore.h:
4175         * WebCoreSupport/WebVisitedLinkStore.mm:
4176         (WebVisitedLinkStore::removeVisitedLink):
4177         * WebView/WebView.mm:
4178         (-[WebView removeVisitedLink:]):
4179
4180 2014-11-29  Anders Carlsson  <andersca@apple.com>
4181
4182         Populate visited links
4183         https://bugs.webkit.org/show_bug.cgi?id=139101
4184
4185         Reviewed by Sam Weinig.
4186
4187         * History/WebHistory.mm:
4188         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
4189         Helper function that adds all visited link to the given store.
4190
4191         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
4192         Call the private method.
4193
4194         * History/WebHistoryInternal.h:
4195         * WebCoreSupport/WebVisitedLinkStore.h:
4196         Add new members.
4197
4198         * WebCoreSupport/WebVisitedLinkStore.mm:
4199         (WebVisitedLinkStore::addVisitedLink):
4200         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
4201
4202         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
4203         Implement this. First try the delegate, then try the shared history.
4204
4205         (WebVisitedLinkStore::addVisitedLinkHash):
4206         Factor code that adds the link to the hash table into a separate function.
4207
4208         * WebView/WebView.mm:
4209         (-[WebView addVisitedLinks:]):
4210         Add the visited links to the store.
4211
4212 2014-11-29  Anders Carlsson  <andersca@apple.com>