Unreviewed, rolling out r215608.
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Unreviewed, rolling out r215608.
4
5         Hundreds of test failures on GTK bot
6
7         Reverted changeset:
8
9         "Reduce copies and allocations in SharedBuffer::append"
10         https://bugs.webkit.org/show_bug.cgi?id=170956
11         http://trac.webkit.org/changeset/215608
12
13 2017-04-21  Alex Christensen  <achristensen@webkit.org>
14
15         Reduce copies and allocations in SharedBuffer::append
16         https://bugs.webkit.org/show_bug.cgi?id=170956
17
18         Reviewed by Andreas Kling.
19
20         * WebView/WebArchive.mm:
21         (-[WebArchive initWithData:]):
22         * WebView/WebFrame.mm:
23         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
24         * WebView/WebResource.mm:
25         (-[WebResource initWithCoder:]):
26         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
27
28 2017-04-20  Dewei Zhu  <dewei_zhu@apple.com>
29
30         Build fix to start using C++14.
31         https://bugs.webkit.org/show_bug.cgi?id=171038
32
33         Reviewed by Alex Christensen.
34
35         Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.
36
37         * Configurations/WebKitLegacy.xcconfig:
38
39 2017-04-19  Youenn Fablet  <youenn@apple.com>
40
41         [Mac] Allow customizing H264 encoder
42         https://bugs.webkit.org/show_bug.cgi?id=170829
43
44         Reviewed by Alex Christensen.
45
46         * Configurations/FeatureDefines.xcconfig:
47
48 2017-04-19  Anders Carlsson  <andersca@apple.com>
49
50         Stop using deprecated APIs, part 3
51         https://bugs.webkit.org/show_bug.cgi?id=171003
52         rdar://problem/31589635
53
54         Reviewed by Tim Horton.
55
56         * WebCoreSupport/WebPaymentCoordinatorClient.h:
57         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
58         (WebPaymentCoordinatorClient::cancelPaymentSession):
59         Update for WebCore changes.
60
61 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
62
63         [WK2] Support DataTransfer::files() when performing a DHTML data interaction
64         https://bugs.webkit.org/show_bug.cgi?id=170880
65         <rdar://problem/31314689>
66
67         Reviewed by Tim Horton.
68
69         Adjust for a change in PasteboardStrategy. See WebCore ChangeLog for more details.
70
71         * WebCoreSupport/WebPlatformStrategies.h:
72         * WebCoreSupport/WebPlatformStrategies.mm:
73         (WebPlatformStrategies::getFilenamesForDataInteraction):
74
75 2017-04-17  Youenn Fablet  <youenn@apple.com>
76
77         Disable outdated WritableStream API
78         https://bugs.webkit.org/show_bug.cgi?id=170749
79         <rdar://problem/31446233>
80
81         Reviewed by Alex Christensen.
82
83         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
84         - A STREAMS_API compilation flag.
85         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
86
87         * Configurations/FeatureDefines.xcconfig:
88         * WebView/WebPreferenceKeysPrivate.h:
89         * WebView/WebPreferences.mm:
90         (+[WebPreferences initialize]):
91         (-[WebPreferences readableByteStreamAPIEnabled]):
92         (-[WebPreferences setReadableByteStreamAPIEnabled:]):
93         (-[WebPreferences writableStreamAPIEnabled]):
94         (-[WebPreferences setWritableStreamAPIEnabled:]):
95         * WebView/WebPreferencesPrivate.h:
96         * WebView/WebView.mm:
97         (-[WebView _preferencesChanged:]):
98
99 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
100
101         [WK2] Support data interaction of files into file inputs
102         https://bugs.webkit.org/show_bug.cgi?id=170803
103         <rdar://problem/31286130>
104
105         Reviewed by Tim Horton.
106
107         Add boilerplate plumbing for fetching the number of files in the pasteboard.
108
109         * WebCoreSupport/WebPlatformStrategies.h:
110         * WebCoreSupport/WebPlatformStrategies.mm:
111         (WebPlatformStrategies::getNumberOfFiles):
112
113 2017-04-14  Mark Lam  <mark.lam@apple.com>
114
115         Update architectures in xcconfig files.
116         https://bugs.webkit.org/show_bug.cgi?id=170867
117         <rdar://problem/31628104>
118
119         Reviewed by Joseph Pecoraro.
120
121         * Configurations/FeatureDefines.xcconfig:
122
123 2017-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
124
125         [WK2] Support Icon creation from file URLs on iOS
126         https://bugs.webkit.org/show_bug.cgi?id=170809
127         <rdar://problem/31286130>
128
129         Reviewed by Tim Horton.
130
131         Adjust for changes in the ChromeClient in WebCore.
132
133         * WebCoreSupport/WebChromeClient.h:
134         * WebCoreSupport/WebChromeClient.mm:
135         (WebChromeClient::loadIconForFiles):
136         (WebChromeClient::createIconForFiles):
137
138 2017-04-12  Dan Bernstein  <mitz@apple.com>
139
140         [Mac] Future-proof .xcconfig files
141         https://bugs.webkit.org/show_bug.cgi?id=170802
142
143         Reviewed by Tim Horton.
144
145         * Configurations/Base.xcconfig:
146         * Configurations/DebugRelease.xcconfig:
147         * Configurations/FeatureDefines.xcconfig:
148         * Configurations/Version.xcconfig:
149
150 2017-04-12  Beth Dakin  <bdakin@apple.com>
151
152         Build fix.
153
154         * WebView/WebViewData.h:
155
156 2017-04-12  Brian Weinstein  <bweinstein@apple.com>
157
158         Should always override -[WebStorageManager init].
159         https://bugs.webkit.org/show_bug.cgi?id=170787
160         -and corresponding-
161         rdar://problem/31371835
162
163         Reviewed by Anders Carlsson.
164
165         * Storage/WebStorageManager.mm:
166         (-[WebStorageManager init]):
167
168 2017-04-12  Beth Dakin  <bdakin@apple.com>
169
170         Speculative build fix. 
171
172         * WebView/WebViewData.h:
173
174 2017-04-12  Beth Dakin  <bdakin@apple.com>
175
176         Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
177         https://bugs.webkit.org/show_bug.cgi?id=170693
178         -and corresponding-
179         rdar://problem/31230018
180
181         Reviewed by Sam Weinig.
182
183         Since the new names only apply to some versions of macOS, this patch uses typedefs 
184         for the older OS’s. SO:
185
186         AVFunctionBarScrubber is now AVTouchBarScrubber
187
188         AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider
189
190         AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption
191
192         And the protocol AVFunctionBarPlaybackControlsControlling is now 
193         AVTouchBarPlaybackControlsControlling
194
195         Soft links and allocations cannot use the typedefs.
196         * WebView/WebView.mm:
197         (-[WebView updateMediaTouchBar]):
198         * WebView/WebViewData.h:
199
200 2017-04-11  Dean Jackson  <dino@apple.com>
201
202         Disable outdated WritableStream API
203         https://bugs.webkit.org/show_bug.cgi?id=170749
204         <rdar://problem/31446233>
205
206         Reviewed by Tim Horton.
207
208         The API we implement is no longer accurate. Disable it until we
209         are compatible with the new specification
210
211         * Configurations/FeatureDefines.xcconfig:
212
213 2017-04-11  Dan Bernstein  <mitz@apple.com>
214
215         [iOS] Simple HTML documents should allow non-markup JavaScript
216         https://bugs.webkit.org/show_bug.cgi?id=170734
217
218         Reviewed by Sam Weinig.
219
220         * WebView/WebView.mm:
221         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting
222           but disabled scripting markup.
223
224 2017-04-10  Alex Christensen  <achristensen@webkit.org>
225
226         Revert r215217
227         https://bugs.webkit.org/show_bug.cgi?id=170703
228
229         * Configurations/FeatureDefines.xcconfig:
230
231 2017-04-10  Alex Christensen  <achristensen@webkit.org>
232
233         Continue enabling WebRTC
234         https://bugs.webkit.org/show_bug.cgi?id=170703
235
236         Reviewed by Youenn Fablet.
237
238         * Configurations/FeatureDefines.xcconfig:
239
240 2017-04-10  Anders Carlsson  <andersca@apple.com>
241
242         Remove call to WKShowKeyAndMain
243         https://bugs.webkit.org/show_bug.cgi?id=170691
244         rdar://problem/31050032
245
246         Reviewed by Beth Dakin.
247
248         * Carbon/CarbonWindowAdapter.mm:
249         (-[CarbonWindowAdapter makeKeyWindow]):
250
251 2017-04-10  Jeremy Jones  <jeremyj@apple.com>
252
253         Add CoreAudioCaptureSource.
254         https://bugs.webkit.org/show_bug.cgi?id=170112
255         rdar://problem/30293338
256
257         Reviewed by Eric Carlson.
258
259         Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.
260
261         * WebView/WebPreferenceKeysPrivate.h:
262         * WebView/WebPreferences.mm:
263         (+[WebPreferences initialize]):
264         (-[WebPreferences useAVFoundationAudioCapture]):
265         (-[WebPreferences setUseAVFoundationAudioCapture:]):
266         * WebView/WebPreferencesPrivate.h:
267         * WebView/WebView.mm:
268         (-[WebView _preferencesChanged:]):
269
270 2017-04-10  Chris Dumez  <cdumez@apple.com>
271
272         Drop Timer::startOneShot() overload taking a double
273         https://bugs.webkit.org/show_bug.cgi?id=170659
274
275         Reviewed by Yusuke Suzuki.
276
277         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
278
279         * Plugins/WebNetscapePluginView.mm:
280         (PluginTimer::start):
281         * Storage/WebStorageManager.mm:
282         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
283
284 2017-04-09  Chris Dumez  <cdumez@apple.com>
285
286         Drop Timer::startRepeating() overload taking a double
287         https://bugs.webkit.org/show_bug.cgi?id=170656
288
289         Reviewed by Yusuke Suzuki.
290
291         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
292
293         * Plugins/WebNetscapePluginView.mm:
294         (PluginTimer::start):
295
296 2017-04-09  Chris Dumez  <cdumez@apple.com>
297
298         Start dropping Timer API dealing with double
299         https://bugs.webkit.org/show_bug.cgi?id=170649
300
301         Reviewed by Yusuke Suzuki.
302
303         Start dropping Timer API dealing with double as people should use Seconds now.
304
305         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
306         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
307         (WebKit::NetscapePluginInstanceProxy::loadRequest):
308         * Plugins/WebNetscapePluginStream.mm:
309         (WebNetscapePluginStream::deliverData):
310
311 2017-04-08  Chris Dumez  <cdumez@apple.com>
312
313         Drop std::chrono support from Timer class
314         https://bugs.webkit.org/show_bug.cgi?id=170645
315
316         Reviewed by Sam Weinig.
317
318         Drop std::chrono support from Timer class now that we prefer using Seconds type.
319
320         * WebView/WebView.mm:
321         (+[WebView _setCacheModel:]):
322
323 2017-04-08  Youenn Fablet  <youenn@apple.com>
324
325         WebRTC tests gardening
326         https://bugs.webkit.org/show_bug.cgi?id=170508
327
328         Reviewed by Eric Carlson.
329
330         * Configurations/FeatureDefines.xcconfig:
331
332 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
333
334         Unreviewed, rolling out r215046.
335
336         This change broke internal builds.
337
338         Reverted changeset:
339
340         "WebRTC tests gardening"
341         https://bugs.webkit.org/show_bug.cgi?id=170508
342         http://trac.webkit.org/changeset/215046
343
344 2017-04-06  Tim Horton  <timothy_horton@apple.com>
345
346         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
347         https://bugs.webkit.org/show_bug.cgi?id=170566
348
349         Reviewed by Simon Fraser.
350
351         * DOM/DOMCSS.mm:
352         (kitClass):
353         Use the WebCore-side enum for this, since that's actually what we're switching over.
354         This allows us to handle values here without adding them to the API header.
355         All of the other kitClass() functions work the same way.
356         Also, unindent for style purposes.
357
358 2017-04-06  Youenn Fablet  <youenn@apple.com>
359
360         WebRTC tests gardening
361         https://bugs.webkit.org/show_bug.cgi?id=170508
362
363         Reviewed by Eric Carlson.
364
365         * Configurations/FeatureDefines.xcconfig:
366
367 2017-04-04  Megan Gardner  <megan_gardner@apple.com>
368
369         Fix leaks in WebUITextIndicatorData
370         https://bugs.webkit.org/show_bug.cgi?id=170480
371
372         Reviewed by Wenson Hsieh.
373
374         Removes extraneous retains.
375
376         * WebView/WebView.mm:
377         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
378
379 2017-04-04  Tim Horton  <timothy_horton@apple.com>
380
381         [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
382         https://bugs.webkit.org/show_bug.cgi?id=165801
383         <rdar://problem/29649535>
384
385         Reviewed by Wenson Hsieh.
386
387         * WebView/WebView.mm:
388         (incrementFrame):
389         Adjust to the new CanWrap enum.
390
391 2017-03-27  Joseph Pecoraro  <pecoraro@apple.com>
392
393         Web Inspector: Saving files should not suggest the top level directory
394         https://bugs.webkit.org/show_bug.cgi?id=170085
395         <rdar://problem/30197794>
396
397         Reviewed by Matt Baker.
398
399         * WebCoreSupport/WebInspectorClient.mm:
400         (WebInspectorFrontendClient::save):
401         Don't set panel.directoryURL unless we have a good suggestion.
402
403 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
404
405         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
406         https://bugs.webkit.org/show_bug.cgi?id=169168
407         <rdar://problem/30688374>
408
409         Reviewed by Tim Horton.
410
411         Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
412         WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
413         we need to import a C++ header for linkedOnOrAfter().
414
415         The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
416         application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
417         the new default value of everything but DragDestinationActionLoad.
418
419         * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
420         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
421         * Misc/WebKitVersionChecks.h:
422         * WebCoreSupport/WebDragClient.h:
423         * WebCoreSupport/WebDragClient.mm:
424         (WebDragClient::actionMaskForDrag): Deleted.
425         * WebView/WebView.mm:
426         (-[WebView draggingEntered:]):
427         (-[WebView draggingUpdated:]):
428
429 2017-03-21  Wenson Hsieh  <wenson_hsieh@apple.com>
430
431         Add support for showing the platform data interaction caret
432         https://bugs.webkit.org/show_bug.cgi?id=169898
433         <rdar://problem/31146295>
434
435         Reviewed by Beth Dakin.
436
437         Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
438
439         * WebView/WebView.mm:
440         (-[WebView _dataInteractionCaretRect]):
441         * WebView/WebViewPrivate.h:
442
443 2017-03-22  Dan Bernstein  <mitz@apple.com>
444
445         [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
446         https://bugs.webkit.org/show_bug.cgi?id=169967
447         <rdar://problem/30406898>
448
449         Reviewed by Anders Carlsson.
450
451         * WebView/WebView.mm:
452         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
453           Settings::downloadableBinaryFontsEnabled. The default is true.
454
455 2017-03-22  Andy Estes  <aestes@apple.com>
456
457         [QuickLook] Rename QuickLookHandle to PreviewLoader
458         https://bugs.webkit.org/show_bug.cgi?id=169961
459
460         Reviewed by Andreas Kling.
461
462         * WebCoreSupport/WebFrameLoaderClient.h:
463         * WebCoreSupport/WebFrameLoaderClient.mm:
464         (WebFrameLoaderClient::createPreviewLoaderClient):
465         (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
466
467 2017-03-21  Anders Carlsson  <andersca@apple.com>
468
469         Remove bogus availability annotations from DOM SPI headers.
470         rdar://problem/31015675
471
472         Rubber-stamped by Dan Bernstein.
473
474         * DOM/DOMHTMLMediaElement.h:
475         * DOM/DOMHTMLVideoElement.h:
476         * DOM/DOMMediaError.h:
477         * DOM/DOMTextEvent.h:
478         * DOM/DOMTimeRanges.h:
479         * DOM/DOMTokenList.h:
480
481 2017-03-19  Wenson Hsieh  <wenson_hsieh@apple.com>
482
483         Teach TextIndicator to estimate the background color of the given Range
484         https://bugs.webkit.org/show_bug.cgi?id=169869
485         <rdar://problem/31127272>
486
487         Reviewed by Anders Carlsson and Simon Fraser.
488
489         Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
490
491         * WebView/WebView.mm:
492         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
493         (-[WebUITextIndicatorData dealloc]):
494         * WebView/WebViewPrivate.h:
495
496 2017-03-20  Dan Bernstein  <mitz@apple.com>
497
498         [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
499         https://bugs.webkit.org/show_bug.cgi?id=169861
500
501         Reviewed by Sam Weinig.
502
503         * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
504         * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
505           timestamp file used by the Xcode project to determine whether to run the script.
506
507 2017-03-19  Alexey Proskuryakov  <ap@apple.com>
508
509         WebHTMLView is useless as WebResourceHandler
510         https://bugs.webkit.org/show_bug.cgi?id=169857
511
512         Reviewed by Dan Bernstein.
513
514         * WebView/WebHTMLView.mm:
515         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
516         WebHTMLView doesnt implement any of WebResourceHandler methods.
517
518 2017-03-17  Michael Saboff  <msaboff@apple.com>
519
520         Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
521         https://bugs.webkit.org/show_bug.cgi?id=169817
522
523         Reviewed by Filip Pizlo.
524
525         * Configurations/FeatureDefines.xcconfig:
526
527 2017-03-17  Antti Koivisto  <antti@apple.com>
528
529         Add a reload policy where only expired subresources are revalidated
530         https://bugs.webkit.org/show_bug.cgi?id=169756
531
532         Reviewed by Andreas Kling.
533
534         * WebView/WebFrame.mm:
535         (toWebFrameLoadType):
536         (-[WebFrame reload]):
537         (-[WebFrame reloadFromOrigin]):
538
539 2017-03-17  Wenson Hsieh  <wenson_hsieh@apple.com>
540
541         [WK1] Support animated transitions when performing a data interaction operation
542         https://bugs.webkit.org/show_bug.cgi?id=169805
543         <rdar://problem/31045767>
544
545         Reviewed by Beth Dakin and Megan Gardner.
546
547         Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
548         for more details.
549
550         * DOM/DOMElement.h:
551         * DOM/DOMElement.mm:
552         (-[DOMElement boundsInRootViewSpace]):
553
554         Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
555
556         * WebCoreSupport/WebDragClient.h:
557         (): Deleted.
558         * WebCoreSupport/WebDragClient.mm:
559         (WebDragClient::didConcludeEditDrag):
560
561         Add boilerplate plumbing.
562
563         * WebView/WebView.mm:
564         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
565
566         Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
567
568         (floatRectsForCGRectArray):
569         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
570
571         Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
572         image of some text, as well as clipping rects to apply to the image.
573
574         (-[WebView _dataOperationTextIndicator]):
575
576         Add SPI to fetch the text indicator used to drive animations for the current data operation.
577
578         (-[WebView _didConcludeEditDataInteraction]):
579         * WebView/WebViewData.h:
580         * WebView/WebViewInternal.h:
581         * WebView/WebViewPrivate.h:
582
583 2017-03-16  Simon Fraser  <simon.fraser@apple.com>
584
585         Improve the system tracing points
586         https://bugs.webkit.org/show_bug.cgi?id=169790
587
588         Reviewed by Zalan Bujtas.
589
590         Use a more cohesive set of system trace points that give a good overview of what
591         WebKit is doing. Added points for resource loading, render tree building, sync messages
592         to the web process, async image decode, WASM and fetching cookies.
593
594         * WebView/WebHTMLView.mm:
595         (-[WebHTMLView drawRect:]):
596
597 2017-03-16  Youenn Fablet  <youenn@apple.com>
598
599         Wrap legacy WebRTC API in runtime flag
600         https://bugs.webkit.org/show_bug.cgi?id=169646
601
602         Reviewed by Alex Christensen.
603
604         * WebView/WebPreferenceKeysPrivate.h:
605         * WebView/WebPreferences.mm:
606         (+[WebPreferences initialize]):
607         (-[WebPreferences webRTCLegacyAPIEnabled]):
608         (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
609         * WebView/WebPreferencesPrivate.h:
610         * WebView/WebView.mm:
611         (-[WebView _preferencesChanged:]):
612
613 2017-03-14  Megan Gardner  <megan_gardner@apple.com>
614
615         Correctly export WebItemProviderPasteboard
616         https://bugs.webkit.org/show_bug.cgi?id=169578
617
618         Reviewed by Tim Horton.
619
620         * MigrateHeaders.make:
621
622 2017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
623
624         [WK2] Data interaction tests occasionally hit assertions in debug builds
625         https://bugs.webkit.org/show_bug.cgi?id=169002
626         <rdar://problem/30994806>
627
628         Reviewed by Tim Horton.
629
630         Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
631
632         * WebView/WebHTMLView.mm:
633         (-[WebHTMLView _updateSelectionForInputManager]):
634         * WebView/WebView.mm:
635         (-[WebView updateTextTouchBar]):
636
637 2017-03-13  Anders Carlsson  <andersca@apple.com>
638
639         Fix build warnings.
640
641         * WebCoreSupport/WebInspectorClient.mm:
642         (WebInspectorFrontendClient::save):
643         (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
644
645 2017-03-11  Brady Eidson  <beidson@apple.com>
646
647         Cleanup "addCookie" and its sole user.
648         https://bugs.webkit.org/show_bug.cgi?id=169486
649
650         Reviewed by Brian Burg.
651
652         * WebCoreSupport/WebPlatformStrategies.h:
653         * WebCoreSupport/WebPlatformStrategies.mm:
654         (WebPlatformStrategies::addCookie): Deleted.
655
656 2017-03-10  Alex Christensen  <achristensen@webkit.org>
657
658         Fix watch and tv builds after r213294
659         https://bugs.webkit.org/show_bug.cgi?id=169508
660
661         Reviewed by Dan Bernstein.
662
663         * Configurations/FeatureDefines.xcconfig:
664
665 2017-03-10  Alex Christensen  <achristensen@webkit.org>
666
667         Fix CMake build.
668
669         * WebView/WebNotification.h:
670         Don't assume we have already included something that includes NSObject.h.
671
672 2017-03-09  Daniel Bates  <dabates@apple.com>
673
674         Guard Credential Management implementation behind a runtime enabled feature flag
675         https://bugs.webkit.org/show_bug.cgi?id=169364
676         <rdar://problem/30957425>
677
678         Reviewed by Brent Fulgham.
679
680         Add WebKit preference for Credential Management (disabled by default).
681
682         * WebView/WebPreferenceKeysPrivate.h:
683         * WebView/WebPreferences.mm:
684         (+[WebPreferences initialize]):
685         (-[WebPreferences credentialManagementEnabled]): Added.
686         (-[WebPreferences setCredentialManagementEnabled:]): Added.
687         * WebView/WebPreferencesPrivate.h:
688         * WebView/WebView.mm:
689         (-[WebView _preferencesChanged:]):
690
691 2017-03-09  Anders Carlsson  <andersca@apple.com>
692
693         Add delegate support to WebCore
694         https://bugs.webkit.org/show_bug.cgi?id=169427
695         Part of rdar://problem/28880714.
696
697         Reviewed by Geoffrey Garen.
698
699         * Configurations/FeatureDefines.xcconfig:
700         Add feature define.
701
702 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
703
704         Fix DataInteraction guards
705         https://bugs.webkit.org/show_bug.cgi?id=169404
706
707         Reviewed by Wenson Hsieh.
708
709         * WebCoreSupport/WebDragClient.mm:
710
711 2017-03-08  Wenson Hsieh  <wenson_hsieh@apple.com>
712
713         Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
714         https://bugs.webkit.org/show_bug.cgi?id=169392
715         <rdar://problem/30882974>
716
717         Reviewed by Tim Horton.
718
719         Add a stub implementation of WebDragClient::didConcludeEditDrag.
720
721         * WebCoreSupport/WebDragClient.h:
722
723 2017-03-08  Anders Carlsson  <andersca@apple.com>
724
725         Simplify the PaymentCoordinator interface
726         https://bugs.webkit.org/show_bug.cgi?id=169382
727         Part of rdar://problem/28880714.
728
729         Reviewed by Tim Horton.
730
731         Update for PaymentCoordinatorClient changes.
732
733         * WebCoreSupport/WebPaymentCoordinatorClient.h:
734         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
735         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
736         (WebPaymentCoordinatorClient::completeShippingContactSelection):
737         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
738         (WebPaymentCoordinatorClient::completePaymentSession):
739
740 2017-03-08  Megan Gardner  <megan_gardner@apple.com>
741
742         Fix for dependency fix
743         https://bugs.webkit.org/show_bug.cgi?id=169369
744
745         Reviewed by Beth Dakin.
746
747         * WebView/WebViewPrivate.h:
748
749 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
750
751         Fix Project Dependency
752         https://bugs.webkit.org/show_bug.cgi?id=169340
753
754         Unreviewed Dependency Fix.
755
756         * WebView/WebViewPrivate.h:
757
758 2017-03-07  Alexey Proskuryakov  <ap@apple.com>
759
760         WebKitLegacy should re-export symbols from WebCore on watchos and tvos
761         https://bugs.webkit.org/show_bug.cgi?id=169341
762         <rdar://problem/30913788>
763
764         Reviewed by Dan Bernstein.
765
766         * MigrateHeaders.make:
767
768 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
769
770         Have fixedPositionCreatesStackingContext be on by default everywhere
771         https://bugs.webkit.org/show_bug.cgi?id=169334
772
773         Reviewed by Zalan Bujtas.
774
775         It makes no sense to have web-exposed CSS functionality be different based on setting,
776         and other browser are now aligned with having position:fixed create stacking context.
777
778         So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
779         always force stacking context for position:fixed.
780
781         * WebView/WebView.mm:
782         (-[WebView _preferencesChanged:]):
783
784 2017-03-06  Simon Fraser  <simon.fraser@apple.com>
785
786         Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
787         https://bugs.webkit.org/show_bug.cgi?id=169230
788
789         Reviewed by Tim Horton.
790
791         * WebView/WebView.mm:
792         (-[WebView _preferencesChanged:]):
793
794 2017-03-07  Simon Fraser  <simon.fraser@apple.com>
795
796         Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
797         https://bugs.webkit.org/show_bug.cgi?id=169329
798
799         Reviewed by Tim Horton.
800
801         If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
802
803         * WebView/WebPreferences.mm:
804         (+[WebPreferences initialize]):
805
806 2017-03-07  Megan Gardner  <megan_gardner@apple.com>
807
808         Additional DataInteraction Support
809         https://bugs.webkit.org/show_bug.cgi?id=169316
810         <rdar://problem/30884234>
811
812         Reviewed by Wenson Hsieh.
813
814         Add stub implementations to WebView for methods that handle data interaction
815
816         * WebView/WebView.mm:
817         (-[WebView _enteredDataInteraction:client:global:operation:]):
818         (-[WebView _updatedDataInteraction:client:global:operation:]):
819         (-[WebView _exitedDataInteraction:client:global:operation:]):
820         (-[WebView _performDataInteraction:client:global:operation:]):
821         (-[WebView _endedDataInteraction:global:]):
822         * WebView/WebViewPrivate.h:
823
824 2017-03-07  Dean Jackson  <dino@apple.com>
825
826         Some platforms won't be able to create a GPUDevice
827         https://bugs.webkit.org/show_bug.cgi?id=169314
828         <rdar://problems/30907521>
829
830         Reviewed by Jon Lee.
831
832         Disable WEB_GPU on the iOS Simulator.
833
834         * Configurations/FeatureDefines.xcconfig:
835
836 2017-03-07  Maureen Daum  <mdaum@apple.com>
837
838         Correctly check for an empty database file.
839         <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
840         https://bugs.webkit.org/show_bug.cgi?id=169256
841
842         Reviewed by Brady Eidson.
843
844         Check if the folder for an origin's WebSQL databases is empty after trying to delete
845         all of its files. Currently we check if the deletedDatabaseFileCount matches the number
846         of files that were in the folder. However, when we delete the actual database file in
847         DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
848         the database file, but deletedDatabaseFileCount only gets incremented once.
849
850         * Storage/WebDatabaseManager.mm:
851         (+[WebDatabaseManager removeEmptyDatabaseFiles]):
852         Delete the folder if it is empty.
853
854 2017-03-06  Michael Saboff  <msaboff@apple.com>
855
856         Unreviewed build fix to add
857         -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
858         for objective C++ files.
859
860         * Configurations/WebKitLegacy.xcconfig:
861
862 2017-03-06  Michael Saboff  <msaboff@apple.com>
863
864         Take advantage of fast permissions switching of JIT memory for devices that support it
865         https://bugs.webkit.org/show_bug.cgi?id=169155
866
867         Reviewed by Saam Barati.
868
869         Updated the Xcode config files to match what is in the JavaScriptCore ones.
870
871         * Configurations/FeatureDefines.xcconfig:
872
873 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
874
875         Expand font-weight and font-stretch to take any number
876         https://bugs.webkit.org/show_bug.cgi?id=168889
877
878         Reviewed by Simon Fraser.
879
880         Migrate off old enum types.
881
882         * WebCoreSupport/PopupMenuMac.mm:
883         (PopupMenuMac::populate):
884         * WebView/WebHTMLView.mm:
885         (fontNameForDescription):
886         * WebView/WebView.mm:
887         (-[WebView updateTextTouchBar]):
888
889 2017-03-03  Dean Jackson  <dino@apple.com>
890
891         Add WebGPU compile flag and experimental feature flag
892         https://bugs.webkit.org/show_bug.cgi?id=169161
893         <rdar://problem/30846689>
894
895         Reviewed by Tim Horton.
896
897         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
898         and an InternalSetting.
899
900         * Configurations/FeatureDefines.xcconfig:
901         * WebView/WebPreferenceKeysPrivate.h:
902         * WebView/WebPreferences.mm:
903         (+[WebPreferences initialize]):
904         (-[WebPreferences webGPUEnabled]):
905         (-[WebPreferences setWebGPUEnabled:]):
906         * WebView/WebPreferencesPrivate.h:
907         * WebView/WebView.mm:
908         (-[WebView _preferencesChanged:]):
909
910 2017-03-03  Alexey Proskuryakov  <ap@apple.com>
911
912         Build fix
913         rdar://problem/30825660
914
915         Suggested by Dan Bernstein.
916
917         * Configurations/WebKitLegacy.xcconfig:
918
919 2017-03-02  Sam Weinig  <sam@webkit.org>
920
921         Rename htmlediting.h/cpp to Editing.h/cpp
922         https://bugs.webkit.org/show_bug.cgi?id=169103
923
924         Reviewed by Alex Christensen.
925
926         * DOM/DOMUIKitExtensions.mm:
927         * WebView/WebFrame.mm:
928         * WebView/WebView.mm:
929
930 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
931
932         Fix 32-bit
933         https://bugs.webkit.org/show_bug.cgi?id=169114
934
935         Reviewed by Alex Christensen.
936
937         * WebView/WebView.mm:
938
939 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
940
941         More guard fixing
942         https://bugs.webkit.org/show_bug.cgi?id=169112
943
944         Reviewed by Alex Christensen.
945
946         Fixed an internal build.
947
948         * WebView/WebView.mm:
949         * WebView/WebViewPrivate.h:
950
951 2017-03-02  Megan Gardner  <megan_gardner@apple.com>
952
953         Data Interaction build fixes
954         https://bugs.webkit.org/show_bug.cgi?id=169096
955
956         Reviewed by Tim Horton.
957
958         Guards weren't all correct, also missed a selector name change.
959
960         * WebView/WebView.mm:
961         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
962         * WebView/WebViewData.h:
963         * WebView/WebViewData.mm:
964         (-[WebViewPrivate dealloc]):
965
966 2017-03-02  Alex Christensen  <achristensen@webkit.org>
967
968         Continue enabling WebRTC
969         https://bugs.webkit.org/show_bug.cgi?id=169056
970
971         Reviewed by Jon Lee.
972
973         * Configurations/FeatureDefines.xcconfig:
974
975 2017-03-01  Megan Gardner  <megan_gardner@apple.com>
976
977         Data interaction support for WK1
978         https://bugs.webkit.org/show_bug.cgi?id=169062
979
980         Reviewed by Wenson Hsieh.
981
982         Support for data interaction in WebKit1
983
984         * WebCoreSupport/WebDragClient.mm:
985         * WebView/WebView.mm:
986         (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
987         (-[WebUITextIndicatorData initWithImage:scale:]):
988         (-[WebUITextIndicatorData dealloc]):
989         (-[WebView _requestStartDataInteraction:globalPosition:]):
990         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
991         (-[WebView _getDataInteractionData]):
992         * WebView/WebViewData.h:
993         * WebView/WebViewData.mm:
994         (-[WebViewPrivate dealloc]):
995         * WebView/WebViewInternal.h:
996         * WebView/WebViewPrivate.h:
997
998 2017-03-02  Youenn Fablet  <youenn@apple.com>
999
1000         [WebRTC] Activate ICE candidate privacy policy
1001         https://bugs.webkit.org/show_bug.cgi?id=168975
1002
1003         Reviewed by Alex Christensen.
1004
1005         * WebView/WebPreferenceKeysPrivate.h:
1006         * WebView/WebPreferences.mm:
1007         (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
1008         (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
1009         (-[WebPreferences iceCandidateFilteringEnabled]):
1010         (-[WebPreferences setIceCandidateFilteringEnabled:]):
1011         * WebView/WebPreferencesPrivate.h:
1012
1013 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1014
1015         Unreviewed, rolling out r213259.
1016
1017         Broke an internal build
1018
1019         Reverted changeset:
1020
1021         "Continue enabling WebRTC"
1022         https://bugs.webkit.org/show_bug.cgi?id=169056
1023         http://trac.webkit.org/changeset/213259
1024
1025 2017-03-01  Alex Christensen  <achristensen@webkit.org>
1026
1027         Continue enabling WebRTC
1028         https://bugs.webkit.org/show_bug.cgi?id=169056
1029
1030         Reviewed by Jon Lee.
1031
1032         * Configurations/FeatureDefines.xcconfig:
1033
1034 2017-02-27  Alex Christensen  <achristensen@webkit.org>
1035
1036         Begin enabling WebRTC on 64-bit
1037         https://bugs.webkit.org/show_bug.cgi?id=168915
1038
1039         Reviewed by Eric Carlson.
1040
1041         * Configurations/FeatureDefines.xcconfig:
1042
1043 2017-02-27  Aakash Jain  <aakash_jain@apple.com>
1044
1045         Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
1046         https://bugs.webkit.org/show_bug.cgi?id=168919
1047
1048         Reviewed by Tim Horton.
1049
1050         * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
1051         * migrate-headers.sh: Run the migrate-headers script for installapi phase.
1052
1053 2017-02-27  Alex Christensen  <achristensen@webkit.org>
1054
1055         [libwebrtc] Enable WebRTC in some Production Builds
1056         https://bugs.webkit.org/show_bug.cgi?id=168858
1057
1058         * Configurations/FeatureDefines.xcconfig:
1059
1060 2017-02-26  Alexey Proskuryakov  <ap@apple.com>
1061
1062         Don't import RetainPtr in WebNotification.h
1063         https://bugs.webkit.org/show_bug.cgi?id=168876
1064
1065         Reviewed by Dan Bernstein.
1066
1067         This is an Objective-C SPI header.
1068
1069         * WebView/WebNotification.h:
1070         * WebView/WebNotification.mm:
1071         (-[WebNotification initWithCoreNotification:notificationID:]):
1072         (-[WebNotification dealloc]):
1073
1074 2017-02-26  Aakash Jain  <aakash_jain@apple.com>
1075
1076         Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
1077         https://bugs.webkit.org/show_bug.cgi?id=168819
1078
1079         Reviewed by Dan Bernstein.
1080
1081         * Configurations/WebKitLegacy.xcconfig:
1082
1083 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1084
1085         Export Objective-C symbols for variables in Webkit SPI
1086         https://bugs.webkit.org/show_bug.cgi?id=168758
1087
1088         Reviewed by Alexey Proskuryakov.
1089
1090         * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
1091         * WebKit.exp: Added various Objective-C symbols.
1092
1093 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1094
1095         Move instance members from WKQuadObject to implementation file
1096         https://bugs.webkit.org/show_bug.cgi?id=168740
1097
1098         Reviewed by Tim Horton.
1099
1100         * DOM/DOM.mm: Moving instance member to implementation file.
1101         * DOM/DOMExtensions.h: Ditto.
1102
1103 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
1104
1105         Move iOS specific symbols to WebKit.ios.exp
1106         https://bugs.webkit.org/show_bug.cgi?id=168726
1107
1108         Reviewed by Alexey Proskuryakov.
1109
1110         * WebKit.exp:
1111
1112 2017-02-21  Youenn Fablet  <youenn@apple.com>
1113
1114         [WebRTC][Mac] Activate libwebrtc
1115         https://bugs.webkit.org/show_bug.cgi?id=167293
1116         <rdar://problem/30401864>
1117
1118         Reviewed by Alex Christensen.
1119
1120         * Configurations/FeatureDefines.xcconfig:
1121
1122 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1123
1124         Export various NSString symbols from WebFramePrivate.h
1125         https://bugs.webkit.org/show_bug.cgi?id=168702
1126
1127         Reviewed by Alexey Proskuryakov.
1128
1129         * WebKit.exp:
1130
1131 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1132
1133         Export various NSString symbols from WebPreferencesPrivate.h
1134         https://bugs.webkit.org/show_bug.cgi?id=168701
1135
1136         Reviewed by Alexey Proskuryakov.
1137
1138         * WebKit.exp:
1139
1140 2017-02-21  Joseph Pecoraro  <pecoraro@apple.com>
1141
1142         Add missing WebConsoleMessage string key
1143         https://bugs.webkit.org/show_bug.cgi?id=168690
1144
1145         Reviewed by Alexey Proskuryakov.
1146
1147         * WebKit.exp:
1148         * WebView/WebUIDelegatePrivate.h:
1149         This key has an implementation but was not extern / exported like the others.
1150
1151 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1152
1153         Export various NSString symbols from WebViewPrivate.h
1154         https://bugs.webkit.org/show_bug.cgi?id=168689
1155
1156         Reviewed by Alexey Proskuryakov.
1157
1158         * WebKit.exp:
1159
1160 2017-02-21  Commit Queue  <commit-queue@webkit.org>
1161
1162         Unreviewed, rolling out r212768.
1163         https://bugs.webkit.org/show_bug.cgi?id=168698
1164
1165         Rolling out since this would break other projects. (Requested
1166         by aakashjain on #webkit).
1167
1168         Reverted changeset:
1169
1170         "[iOS] Remove old WebKit1 MemoryMeasure helper."
1171         https://bugs.webkit.org/show_bug.cgi?id=168675
1172         http://trac.webkit.org/changeset/212768
1173
1174 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
1175
1176         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
1177         https://bugs.webkit.org/show_bug.cgi?id=168620
1178         <rdar://problem/30617772>
1179
1180         Reviewed by Tim Horton.
1181
1182         * WebView/WebPreferenceKeysPrivate.h:
1183         * WebView/WebPreferences.mm:
1184         (+[WebPreferences initialize]):
1185         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
1186         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
1187         * WebView/WebPreferencesPrivate.h:
1188
1189 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1190
1191         Export various NSString symbols from WebUIDelegatePrivate.h
1192         https://bugs.webkit.org/show_bug.cgi?id=168679
1193
1194         Reviewed by Joseph Pecoraro.
1195
1196         * WebKit.exp:
1197
1198 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
1199
1200         Export symbols for various classes present in webkit SPI
1201         https://bugs.webkit.org/show_bug.cgi?id=168674
1202
1203         Reviewed by Dan Bernstein.
1204
1205         * WebKit.exp:
1206
1207 2017-02-21  Andreas Kling  <akling@apple.com>
1208
1209         [iOS] Remove old WebKit1 MemoryMeasure helper.
1210         <https://webkit.org/b/168675>
1211
1212         Reviewed by Sam Weinig.
1213
1214         * Configurations/WebKitLegacy.xcconfig:
1215         * Misc/WebCache.mm:
1216         (+[WebCache emptyInMemoryResources]):
1217         * WebView/WebView.mm:
1218
1219 2017-02-21  Andreas Kling  <akling@apple.com>
1220
1221         [iOS] WebKit1 should use shared memory pressure handler code.
1222         <https://webkit.org/b/168653>
1223
1224         Reviewed by Antti Koivisto.
1225
1226         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
1227         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
1228         dead code since MobileSafari has been using WebKit2 for quite a while.
1229
1230         * WebView/WebView.h:
1231         * WebView/WebView.mm:
1232         (WebInstallMemoryPressureHandler):
1233         (+[WebView _handleMemoryWarning]): Deleted.
1234         (+[WebView registerForMemoryNotifications]): Deleted.
1235         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
1236         (+[WebView garbageCollectNow]): Deleted.
1237         (+[WebView purgeInactiveFontData]): Deleted.
1238         (+[WebView drainLayerPool]): Deleted.
1239         (+[WebView discardAllCompiledCode]): Deleted.
1240         (+[WebView _clearMemoryPressure]): Deleted.
1241         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
1242         * WebView/WebViewPrivate.h:
1243
1244 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1245
1246         Stop exporting interface WebCoreScrollView on iOS
1247         https://bugs.webkit.org/show_bug.cgi?id=168536
1248
1249         Reviewed by Dan Bernstein.
1250
1251         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
1252         * WebKit.mac.exp: Ditto.
1253         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
1254
1255 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1256
1257         Exclude various mac-specific header files from iOS build
1258         https://bugs.webkit.org/show_bug.cgi?id=168621
1259
1260         Reviewed by Dan Bernstein.
1261
1262         * Configurations/WebKitLegacy.xcconfig:
1263
1264 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1265
1266         Add plumbing to the UI process for TextIndicatorData when computing the drag image
1267         https://bugs.webkit.org/show_bug.cgi?id=168583
1268         Work towards <rdar://problem/30313681>
1269
1270         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
1271
1272         Reviewed by Tim Horton.
1273
1274         * WebView/WebHTMLView.mm:
1275         (-[WebHTMLView _selectionDraggingImage]):
1276         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1277
1278 2017-02-17  Anders Carlsson  <andersca@apple.com>
1279
1280         Add a new drag code path and use it for dragging plain text
1281         https://bugs.webkit.org/show_bug.cgi?id=168534
1282
1283         Reviewed by Geoffrey Garen.
1284
1285         * WebCoreSupport/WebDragClient.h:
1286         Add new members.
1287
1288         * WebCoreSupport/WebDragClient.mm:
1289         (WebDragClient::useLegacyDragClient):
1290         Return false here.
1291
1292         (WebDragClient::beginDrag):
1293         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
1294
1295         * WebView/WebHTMLView.mm:
1296         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
1297         Get the source operation mask from WebCore.
1298
1299         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
1300         Send a fake mouse up event.
1301
1302         * WebView/WebHTMLViewInternal.h:
1303         Declare that WebHTMLView conforms to NSDraggingSource.
1304
1305 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
1306
1307         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
1308         https://bugs.webkit.org/show_bug.cgi?id=168342
1309         rdar://problem/26182266
1310
1311         Reviewed by Tim Horton.
1312
1313         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
1314         symbols to re-export.
1315
1316 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1317
1318         Stop exporting DOMTokenList from WebKit
1319         https://bugs.webkit.org/show_bug.cgi?id=168544
1320
1321         Reviewed by Alexey Proskuryakov.
1322
1323         * WebKit.exp:
1324
1325 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
1326
1327         Clean up how WebKit exports _WebCreateFragment
1328         https://bugs.webkit.org/show_bug.cgi?id=168579
1329
1330         Reviewed by Dan Bernstein.
1331
1332         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
1333         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
1334
1335 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
1336
1337         Stop exporting DOMNodeFilter
1338         https://bugs.webkit.org/show_bug.cgi?id=168542
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * WebKit.exp:
1343
1344 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
1345
1346         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
1347         https://bugs.webkit.org/show_bug.cgi?id=167693
1348
1349         Reviewed by Sergio Villar Senin.
1350
1351         * Configurations/FeatureDefines.xcconfig:
1352         * WebView/WebPreferences.mm:
1353         (+[WebPreferences initialize]):
1354         * WebView/WebView.mm:
1355         (-[WebView _preferencesChanged:]):
1356
1357 2017-02-15  Brady Eidson  <beidson@apple.com>
1358
1359         Stop backing up localStorage databases to iCloud by default.
1360         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
1361
1362         Reviewed by Geoffrey Garen.
1363
1364         * Misc/WebKitVersionChecks.h:
1365         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
1366         (WebKitLinkedOnOrAfter):
1367         (setWebKitLinkTimeVersion):
1368         (WebKitLinkTimeVersion):
1369         (linkedOnOrAfter):
1370
1371         * Storage/WebStorageManager.mm:
1372         (WebKitInitializeStorageIfNecessary):
1373
1374 2017-02-16  Daniel Bates  <dabates@apple.com>
1375
1376         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
1377         https://bugs.webkit.org/show_bug.cgi?id=168417
1378         <rdar://problem/30541748>
1379
1380         Reviewed by Brent Fulgham.
1381
1382         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
1383         Widget* as it is always called with a valid Widget.
1384
1385         * WebCoreSupport/WebFrameLoaderClient.h:
1386         * WebCoreSupport/WebFrameLoaderClient.mm:
1387         (WebFrameLoaderClient::redirectDataToPlugin):
1388         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
1389         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
1390         r180570 (2 years ago) though Xcode still references this ordering file (why?).
1391
1392 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1393
1394         [JSC] Drop PassRefPtr in inspector/
1395         https://bugs.webkit.org/show_bug.cgi?id=168420
1396
1397         Reviewed by Alex Christensen.
1398
1399         * WebView/WebScriptDebugger.mm:
1400         (WebScriptDebugger::handlePause):
1401
1402 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
1403
1404         Clean up use of some CALayer-related SPI
1405         https://bugs.webkit.org/show_bug.cgi?id=168401
1406
1407         Reviewed by Tim Horton.
1408
1409         Include CALayer.h not CATiledLayer.h.
1410
1411         * WebInspector/WebNodeHighlight.h:
1412
1413 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1414
1415         Fix the build after r212379
1416
1417         Rubber-stamped by Anders Carlsson.
1418
1419         * WebCoreSupport/WebDragClient.mm:
1420         (WebDragClient::startDrag):
1421
1422 2017-02-15  Anders Carlsson  <andersca@apple.com>
1423
1424         Modernize DragClient::startDrag somewhat
1425         https://bugs.webkit.org/show_bug.cgi?id=168379
1426
1427         Reviewed by Tim Horton.
1428
1429         Update for WebCore changes.
1430
1431         * WebCoreSupport/WebDragClient.h:
1432         * WebCoreSupport/WebDragClient.mm:
1433         (WebDragClient::startDrag):
1434
1435 2017-02-14  Dean Jackson  <dino@apple.com>
1436
1437         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
1438         https://bugs.webkit.org/show_bug.cgi?id=168339
1439
1440         Reviewed by Simon Fraser.
1441
1442         Use a better name.
1443
1444         * WebView/WebPreferenceKeysPrivate.h:
1445         * WebView/WebPreferences.mm:
1446         (+[WebPreferences initialize]):
1447         (-[WebPreferences forceLowPowerGPUForWebGL]):
1448         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
1449         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
1450         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
1451         * WebView/WebPreferencesPrivate.h:
1452         * WebView/WebView.mm:
1453         (-[WebView _preferencesChanged:]):
1454
1455 2017-02-14  Chris Dumez  <cdumez@apple.com>
1456
1457         HTML Form Validation bubble should take minimum font size setting into consideration
1458         https://bugs.webkit.org/show_bug.cgi?id=168271
1459         <rdar://problem/29869869>
1460
1461         Reviewed by Simon Fraser.
1462
1463         * WebView/WebView.mm:
1464         (-[WebView _contentsOfUserInterfaceItem:]):
1465         Return font size used in the validation bubble.
1466
1467         (-[WebView showFormValidationMessage:withAnchorRect:]):
1468         Pass minimum font size setting when constructing the validation bubble.
1469
1470 2017-02-14  Anders Carlsson  <andersca@apple.com>
1471
1472         Remove an unused delegate method
1473         https://bugs.webkit.org/show_bug.cgi?id=168328
1474
1475         Reviewed by Wenson Hsieh.
1476
1477         * DefaultDelegates/WebDefaultUIDelegate.m:
1478         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
1479
1480 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
1481
1482         WebCore shouldn't export SystemMemory.h
1483         https://bugs.webkit.org/show_bug.cgi?id=168285
1484
1485         Reviewed by Alex Christensen.
1486
1487         * MigrateHeaders.make: And WebKit shouldn't re-export it.
1488
1489 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
1490
1491         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
1492         https://bugs.webkit.org/show_bug.cgi?id=168282
1493
1494         Reviewed by Dan Bernstein.
1495
1496         * MigrateHeaders.make:
1497
1498 2017-02-12  Dan Bernstein  <mitz@apple.com>
1499
1500         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
1501
1502         * WebView/WebHTMLView.mm:
1503         (createShareMenuItem): Use non-deprecated method.
1504
1505 2017-02-12  Dan Bernstein  <mitz@apple.com>
1506
1507         [Cocoa] Some -respondsToSelector: checks are unnecessary
1508         https://bugs.webkit.org/show_bug.cgi?id=168183
1509
1510         Reviewed by Tim Horton.
1511
1512         * WebView/WebFullScreenController.mm:
1513         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
1514           responds to -isOnActiveSpace.
1515         (-[WebFullScreenController exitFullScreen]): Ditto.
1516         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
1517           NSApplication responds to -setPresentationOptions.
1518
1519         * WebView/WebHTMLView.mm:
1520         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
1521         (-[WebHTMLView otherMouseDown:]): Ditto.
1522
1523         * WebView/WebImmediateActionController.mm:
1524         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
1525         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
1526
1527         * WebView/WebView.mm:
1528         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
1529         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
1530
1531 2017-02-10  Daniel Bates  <dabates@apple.com>
1532
1533         Detach frame from document when entering page cache
1534         https://bugs.webkit.org/show_bug.cgi?id=166774
1535         <rdar://problem/29904368>
1536
1537         Reviewed by Chris Dumez.
1538
1539         * WebView/WebPreferenceKeysPrivate.h:
1540         * WebView/WebPreferences.mm:
1541         (+[WebPreferences initialize]):
1542         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
1543         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
1544         * WebView/WebPreferencesPrivate.h:
1545         * WebView/WebView.mm:
1546         (-[WebView _preferencesChanged:]):
1547
1548 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1549
1550         [Resource Timing] Enable Resource Timing by default in Tests
1551         https://bugs.webkit.org/show_bug.cgi?id=168145
1552
1553         Reviewed by Ryosuke Niwa.
1554
1555         * WebView/WebPreferenceKeysPrivate.h:
1556         * WebView/WebPreferences.mm:
1557         (+[WebPreferences initialize]):
1558         (-[WebPreferences resourceTimingEnabled]):
1559         (-[WebPreferences setResourceTimingEnabled:]):
1560         * WebView/WebPreferencesPrivate.h:
1561         * WebView/WebView.mm:
1562         (-[WebView _preferencesChanged:]):
1563
1564 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
1565
1566         cleanup WebLocalizableStrings.
1567         https://bugs.webkit.org/show_bug.cgi?id=168078
1568
1569         Reviewed by Alexey Proskuryakov.
1570
1571         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
1572         as it's for each framework's own consumption, and never needs to be exported.
1573
1574 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
1575
1576         WebResourceLoadDelegatePrivate.h cannot be imported standalone
1577         https://bugs.webkit.org/show_bug.cgi?id=168096
1578
1579         Reviewed by Alexey Proskuryakov.
1580
1581         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
1582
1583 2017-02-09  Antti Koivisto  <antti@apple.com>
1584
1585         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
1586         https://bugs.webkit.org/show_bug.cgi?id=167990
1587
1588         Reviewed by Sam Weinig.
1589
1590         * Misc/WebCache.mm:
1591         (+[WebCache addImageToCache:forURL:forFrame:]):
1592         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1593         * WebCoreSupport/WebSystemInterface.mm:
1594         (InitWebCoreSystemInterface):
1595
1596 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
1597
1598         Don't migrate WebKit DOM headers in MigrateHeaders.make
1599         https://bugs.webkit.org/show_bug.cgi?id=167608
1600
1601         Reviewed by Darin Adler.
1602
1603         Stop migrating DOM headers that are now in WebKit.
1604
1605         * DOM/DOMDOMImplementation.h: Removed.
1606         * DOM/DOMDOMImplementation.mm: Removed.
1607         * DOM/DOMDOMImplementationInternal.h: Removed.
1608         * DOM/DOMDOMTokenList.h: Removed.
1609         * DOM/DOMDOMTokenList.mm: Removed.
1610         * DOM/DOMDOMTokenListInternal.h: Removed.
1611         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
1612         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
1613         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
1614         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
1615         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
1616         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
1617         As the files are not in WebCore any more, there is no need to differentiate from
1618         WebCore internal headers with the same name. This makes it possible to make these
1619         headers private using Xcode mechanisms, as opposed to copying with a shell script.
1620
1621         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
1622         files don't have it.
1623
1624         * DOM/DOMCore.h:
1625         * DOM/DOMDocument.mm:
1626         * DOM/DOMHTMLAnchorElement.mm:
1627         * DOM/DOMHTMLAreaElement.mm:
1628         * DOM/DOMHTMLLinkElement.mm:
1629         * DOM/DOMUtility.mm:
1630         No more "DOMDOM".
1631
1632         * WebKit.exp:
1633         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
1634         renaming it is likely to be safe.
1635
1636         * MigrateHeaders.make: Don't migrate WebKit headers.
1637
1638         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
1639         on macOS.
1640
1641 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
1642
1643         Don't re-export PluginData.h from WebKit
1644         https://bugs.webkit.org/show_bug.cgi?id=168020
1645
1646         Reviewed by Alexey Proskuryakov.
1647
1648         * MigrateHeaders.make: Removed PluginData.h
1649
1650 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
1651
1652         Don't re-export WKUtilities.h from WebKit
1653         https://bugs.webkit.org/show_bug.cgi?id=167977
1654
1655         Reviewed by Alexey Proskuryakov.
1656
1657         * MigrateHeaders.make: Removed WKUtilities.h
1658
1659 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1660
1661         credentials should be partitioned by main document domain
1662         https://bugs.webkit.org/show_bug.cgi?id=166998
1663         rdar://problem/22901123
1664
1665         Reviewed by Brady Eidson.
1666
1667         * Misc/WebDownload.mm:
1668         * Plugins/WebBaseNetscapePluginView.mm:
1669         (WebKit::getAuthenticationInfo):
1670         Don't use partitioned credentials for WebKit1 plugins or downloads.
1671         Downloads should be authenticated before becoming a download anyways.
1672
1673 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1674
1675         Rename AnimationController to CSSAnimationController
1676         https://bugs.webkit.org/show_bug.cgi?id=167829
1677
1678         Reviewed by Simon Fraser.
1679
1680         * WebView/WebFrame.mm:
1681         * WebView/WebView.mm:
1682
1683 2017-02-03  Chris Dumez  <cdumez@apple.com>
1684
1685         Dismiss HTML form validation popover when pressing Escape key
1686         https://bugs.webkit.org/show_bug.cgi?id=167716
1687         <rdar://problem/29872943>
1688
1689         Reviewed by Simon Fraser.
1690
1691         Override ValidationMessageClient::hideAnyValidationMessage().
1692
1693         * WebCoreSupport/WebValidationMessageClient.h:
1694         * WebCoreSupport/WebValidationMessageClient.mm:
1695         (WebValidationMessageClient::hideAnyValidationMessage):
1696
1697 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1698
1699         Drag images should be anchored to the mouse location
1700         https://bugs.webkit.org/show_bug.cgi?id=167690
1701         <rdar://problem/30295261>
1702
1703         Reviewed by Enrica Casucci.
1704
1705         Adds some plumbing for the anchor point in the WK1 client layer.
1706
1707         * WebCoreSupport/WebDragClient.h:
1708         * WebCoreSupport/WebDragClient.mm:
1709         (WebDragClient::startDrag):
1710
1711 2017-02-02  Chris Dumez  <cdumez@apple.com>
1712
1713         Rename Node::inDocument() to isConnected()
1714         https://bugs.webkit.org/show_bug.cgi?id=167743
1715
1716         Reviewed by Sam Weinig.
1717
1718         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
1719         - https://dom.spec.whatwg.org/#connected
1720
1721         * DOM/DOMNode.mm:
1722         (-[DOMNode isConnected]):
1723         * WebView/WebFrame.mm:
1724         (-[WebFrame selectNSRange:onElement:]):
1725
1726 2017-02-02  Chris Dumez  <cdumez@apple.com>
1727
1728         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
1729         https://bugs.webkit.org/show_bug.cgi?id=167738
1730         <rdar://problem/30229990>
1731
1732         Reviewed by Andreas Kling.
1733
1734         The BackForwardClient no longer needs to worry about removing HistoryItems
1735         from the PageCache now that WebCore takes care of it.
1736
1737         * History/BackForwardList.mm:
1738         (BackForwardList::close):
1739
1740 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1741
1742         In iOS, we should take background assertion when accessing localstorage databases.
1743         https://bugs.webkit.org/show_bug.cgi?id=165478
1744
1745         Move database transaction background task handling code from WebDatabaseManager to
1746         WebCore's WebSQLiteDatabaseTrackerClient.
1747
1748         Reviewed by Brady Eidson.
1749
1750         * Storage/WebDatabaseManager.mm:
1751         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
1752         * WebCoreSupport/WebApplicationCache.mm:
1753         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
1754         * WebView/WebView.mm:
1755         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
1756
1757 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1758
1759         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
1760         https://bugs.webkit.org/show_bug.cgi?id=167695
1761         <rdar://problem/30305390>
1762
1763         Reviewed by Sam Weinig.
1764
1765         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
1766         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
1767         is destroyed.
1768
1769         * WebView/WebView.mm:
1770         (-[WebView _commonInitializationWithFrameName:groupName:]):
1771
1772 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
1773
1774         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
1775         https://bugs.webkit.org/show_bug.cgi?id=167684
1776
1777         Reviewed by Dan Bernstein.
1778
1779         * DOM/DOMHTML.mm:
1780         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
1781         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
1782         Consolidate in the WebDOMOperationsPrivate category.
1783
1784         * DOM/DOMPrivate.h:
1785         Include WebDOMOperationsPrivate header to get other DOM Private categories.
1786
1787         * DOM/WebDOMOperations.mm:
1788         (-[DOMHTMLInputElement _isAutofilled]):
1789         * DOM/WebDOMOperationsPrivate.h:
1790         Include getter alongside the setter.
1791
1792 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
1793
1794         Build fix.
1795
1796         * Misc/WebNSPasteboardExtras.mm:
1797         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1798         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1799         * WebView/WebHTMLView.mm:
1800         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1801         (-[WebHTMLView copyFont:]):
1802
1803 2017-01-30  Andy Estes  <aestes@apple.com>
1804
1805         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
1806         https://bugs.webkit.org/show_bug.cgi?id=167625
1807
1808         Reviewed by Andreas Kling.
1809
1810         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
1811         * WebCoreSupport/WebFrameLoaderClient.mm:
1812         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
1813         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
1814
1815 2017-01-30  Chris Dumez  <cdumez@apple.com>
1816
1817         Drop legacy Attributes.isId attribute
1818         https://bugs.webkit.org/show_bug.cgi?id=167603
1819
1820         Reviewed by Ryosuke Niwa.
1821
1822         Keep Attr.isId in ObjC bindings.
1823
1824         * DOM/DOMAttr.mm:
1825         (-[DOMAttr isId]):
1826
1827 2017-01-30  Andreas Kling  <akling@apple.com>
1828
1829         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
1830         <https://webkit.org/b/167580>
1831
1832         Reviewed by Antti Koivisto.
1833
1834         Avoid the implicit strong capture of self by keeping it in a __block variable.
1835         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
1836         This fixes huge WebHTMLView leaks seen on the leaks bot.
1837
1838         * WebView/WebHTMLView.mm:
1839         (-[WebHTMLViewPrivate dealloc]):
1840         (-[WebHTMLView viewDidMoveToWindow]):
1841
1842 2017-01-29  Andy Estes  <aestes@apple.com>
1843
1844         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1845         https://bugs.webkit.org/show_bug.cgi?id=167563
1846         <rdar://problem/30253207>
1847
1848         Reviewed by Andreas Kling.
1849
1850         Instead of only saving QuickLook documents to a temporary file when the client is
1851         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
1852
1853         This also changes the SPI for accessing the temporary file path and UTI. Instead of
1854         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
1855         the frame that saved the QuickLook document, the content dictionary is now stored as a
1856         property of WebDataSource.
1857
1858         This also removes the manual lifetime management of the QLPreviewConverter from
1859         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
1860         which ensures it lives long enough to respond to subresource requests.
1861
1862         New API test: QuickLook.LegacyQuickLookContent
1863
1864         * WebCoreSupport/WebFrameLoaderClient.mm:
1865         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
1866         write a temporary file to here from the QuickLookDocumentWriter constructor.
1867         * WebView/WebDataSource.mm: Declared _quickLookContent.
1868         (-[WebDataSource _quickLookContent]):
1869         (-[WebDataSource _setQuickLookContent:]):
1870         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
1871         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
1872         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
1873         * WebView/WebPreferences.mm:
1874         (-[WebPreferences quickLookDocumentSavingEnabled]):
1875         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
1876         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
1877         * WebView/WebView.mm:
1878         (-[WebView quickLookContentForURL:]): Changed to always return nil.
1879         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
1880         -[WebDataSource _quickLookContent] instead.
1881
1882 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1883
1884         Add Link Preload as an off-by-default experimental feature menu item.
1885         https://bugs.webkit.org/show_bug.cgi?id=167201
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         * WebView/WebPreferenceKeysPrivate.h:
1890         * WebView/WebPreferences.mm:
1891         (-[WebPreferences linkPreloadEnabled]):
1892         (-[WebPreferences setLinkPreloadEnabled:]):
1893         * WebView/WebPreferencesPrivate.h:
1894         * WebView/WebView.mm:
1895         (-[WebView _preferencesChanged:]):
1896
1897 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1898
1899         Add User Timing Experimental Feature
1900         https://bugs.webkit.org/show_bug.cgi?id=167542
1901         <rdar://problem/22746307>
1902
1903         Reviewed by Ryosuke Niwa.
1904
1905         * WebView/WebPreferenceKeysPrivate.h:
1906         * WebView/WebPreferences.mm:
1907         (+[WebPreferences initialize]):
1908         (-[WebPreferences userTimingEnabled]):
1909         (-[WebPreferences setUserTimingEnabled:]):
1910         * WebView/WebPreferencesPrivate.h:
1911         * WebView/WebView.mm:
1912         (-[WebView _preferencesChanged:]):
1913         Add setting for User Timing runtime enabled feature.
1914
1915 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1916
1917         [WK1] Do not prevent the drag client from initializing on Mac
1918         https://bugs.webkit.org/show_bug.cgi?id=167541
1919
1920         Reviewed by Dan Bernstein.
1921
1922         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
1923         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
1924         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
1925
1926         * WebCoreSupport/WebDragClient.mm:
1927         (WebDragClient::WebDragClient):
1928         (WebDragClient::actionMaskForDrag):
1929         (WebDragClient::willPerformDragDestinationAction):
1930         (WebDragClient::dragSourceActionMaskForPoint):
1931         (WebDragClient::willPerformDragSourceAction):
1932         (WebDragClient::startDrag):
1933         (WebDragClient::declareAndWriteDragImage):
1934         (WebDragClient::declareAndWriteAttachment):
1935         * WebView/WebView.mm:
1936         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1937
1938 2017-01-26  Chris Dumez  <cdumez@apple.com>
1939
1940         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1941         https://bugs.webkit.org/show_bug.cgi?id=167421
1942         <rdar://problem/30188490>
1943
1944         Reviewed by Darin Adler.
1945
1946         Add a new setting allowing layout tests to enable PageCache in a window
1947         that has an opener, for convenience.
1948
1949         * WebView/WebPreferenceKeysPrivate.h:
1950         * WebView/WebPreferences.mm:
1951         (+[WebPreferences initialize]):
1952         (-[WebPreferences allowsPageCacheWithWindowOpener]):
1953         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
1954         * WebView/WebPreferencesPrivate.h:
1955         * WebView/WebView.mm:
1956         (-[WebView _preferencesChanged:]):
1957
1958 2017-01-26  Keith Miller  <keith_miller@apple.com>
1959
1960         classInfo should take a VM so it is not materialized from the object on each call
1961         https://bugs.webkit.org/show_bug.cgi?id=167424
1962
1963         Rubber Stamped by Michael Saboff.
1964
1965         Previously, classInfo() would get the VM from the target's
1966         MarkedBlock.  Most callers already have a VM on hand, so it is
1967         wasteful to compute the VM from the marked block every time. This
1968         patch refactors some of the most common callers of classInfo(),
1969         jsDynamicCast and inherits to take a VM as well.
1970
1971         * DOM/DOM.mm:
1972         (+[DOMNode _nodeFromJSWrapper:]):
1973         * DOM/DOMUtility.mm:
1974         (createDOMWrapper):
1975         * DOM/WebDOMOperations.mm:
1976         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1977         (WebKit::getObjectID):
1978         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1979         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1980         * Plugins/Hosted/ProxyInstance.mm:
1981         (WebKit::ProxyRuntimeMethod::finishCreation):
1982         (WebKit::ProxyInstance::invokeMethod):
1983         * Plugins/Hosted/ProxyRuntimeObject.mm:
1984         (WebKit::ProxyRuntimeObject::finishCreation):
1985         * WebView/WebFrame.mm:
1986         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1987         * WebView/WebView.mm:
1988         (+[WebView _reportException:inContext:]):
1989         (aeDescFromJSValue):
1990         (-[WebView _notificationIDForTesting:]):
1991
1992 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1993
1994         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
1995         https://bugs.webkit.org/show_bug.cgi?id=167472
1996         <rdar://problem/30149809>
1997
1998         Reviewed by Beth Dakin.
1999
2000         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
2001         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
2002         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
2003         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
2004         previous state, so we should just allow the touch bar to update instead.
2005
2006         * WebView/WebView.mm:
2007         (-[WebView updateTextTouchBar]):
2008
2009 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2010
2011         Crash when setting custom scale factor.
2012         https://bugs.webkit.org/show_bug.cgi?id=167369
2013
2014         Reviewed by Sam Weinig.
2015
2016         Add null pointer check.
2017
2018         * WebView/WebView.mm:
2019         (-[WebView _setCustomBackingScaleFactor:]):
2020
2021 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2022
2023         Refactor drag and drop implementation on Mac
2024         https://bugs.webkit.org/show_bug.cgi?id=167427
2025
2026         Reviewed by Enrica Casucci.
2027
2028         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
2029
2030         * Misc/WebNSPasteboardExtras.h:
2031         * WebCoreSupport/WebDragClient.mm:
2032         * WebView/WebFrame.mm:
2033         * WebView/WebFrameInternal.h:
2034         * WebView/WebHTMLView.mm:
2035         * WebView/WebView.mm:
2036         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2037
2038 2017-01-24  Youenn Fablet  <youennf@gmail.com>
2039
2040         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
2041         https://bugs.webkit.org/show_bug.cgi?id=167294
2042
2043         Reviewed by Alex Christensen.
2044
2045         * WebView/WebView.mm:
2046         (-[WebView _commonInitializationWithFrameName:groupName:]):
2047
2048 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2049
2050         Add support for named pasteboards, pasteboard strategies and platform pasteboards
2051         https://bugs.webkit.org/show_bug.cgi?id=167404
2052
2053         Reviewed by Enrica Casucci.
2054
2055         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
2056
2057         * WebCoreSupport/WebPlatformStrategies.h:
2058         * WebCoreSupport/WebPlatformStrategies.mm:
2059         (WebPlatformStrategies::writeToPasteboard):
2060         (WebPlatformStrategies::getPasteboardItemsCount):
2061         (WebPlatformStrategies::readBufferFromPasteboard):
2062         (WebPlatformStrategies::readURLFromPasteboard):
2063         (WebPlatformStrategies::readStringFromPasteboard):
2064
2065 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
2066
2067         LoadWebLocalizedStrings method should be moved in correct file
2068         https://bugs.webkit.org/show_bug.cgi?id=167393
2069
2070         Reviewed by Alexey Proskuryakov.
2071
2072         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
2073         * Misc/WebLocalizableStrings.mm:
2074         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
2075         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
2076
2077 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2078
2079         Add simple line layout toggle to MiniBrowser
2080         https://bugs.webkit.org/show_bug.cgi?id=167405
2081
2082         Reviewed by Andreas Kling.
2083
2084         * WebView/WebPreferenceKeysPrivate.h:
2085         * WebView/WebPreferences.mm:
2086         (+[WebPreferences initialize]):
2087         (-[WebPreferences simpleLineLayoutEnabled]):
2088         (-[WebPreferences setSimpleLineLayoutEnabled:]):
2089         * WebView/WebPreferencesPrivate.h:
2090         * WebView/WebView.mm:
2091         (-[WebView _preferencesChanged:]):
2092
2093 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2094
2095         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2096         https://bugs.webkit.org/show_bug.cgi?id=167394
2097
2098         Reviewed by Ryosuke Niwa.
2099
2100         * Configurations/FeatureDefines.xcconfig:
2101
2102 2017-01-23  Chris Dumez  <cdumez@apple.com>
2103
2104         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
2105         https://bugs.webkit.org/show_bug.cgi?id=167308
2106         <rdar://problem/30144964>
2107
2108         Unreviewed, do a partial revert of r211033 to fix assertion.
2109
2110         * WebCoreSupport/WebChromeClient.h:
2111         * WebCoreSupport/WebChromeClient.mm:
2112         (WebChromeClient::exitFullScreenForElement):
2113
2114 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
2115
2116         Remove allowWindowOpenWithoutUserGesture setting
2117         https://bugs.webkit.org/show_bug.cgi?id=167301
2118
2119         Reviewed by Darin Adler.
2120
2121         * WebView/WebView.mm:
2122         (-[WebView _preferencesChanged:]):
2123         Use the equivalent existing setting.
2124
2125 2017-01-20  Darin Adler  <darin@apple.com>
2126
2127         Remove PassRefPtr from "page" directory of WebCore, also deploy references
2128         https://bugs.webkit.org/show_bug.cgi?id=167224
2129
2130         Reviewed by Chris Dumez.
2131
2132         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
2133         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
2134
2135         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
2136         * WebCoreSupport/WebChromeClient.mm:
2137         (WebChromeClient::focusedElementChanged): Ditto.
2138         (WebChromeClient::createWindow): Ditto.
2139         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
2140         (WebChromeClient::runJavaScriptAlert): Ditto.
2141         (WebChromeClient::runJavaScriptConfirm): Ditto.
2142         (WebChromeClient::runJavaScriptPrompt): Ditto.
2143         (WebChromeClient::contentsSizeChanged): Ditto.
2144         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
2145         (WebChromeClient::print): Ditto.
2146         (WebChromeClient::exceededDatabaseQuota): Ditto.
2147         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
2148         (WebChromeClient::createColorChooser): Ditto.
2149         (WebChromeClient::elementDidFocus): Ditto.
2150         (WebChromeClient::elementDidBlur): Ditto.
2151         (WebChromeClient::createPopupMenu): Ditto.
2152         (WebChromeClient::createSearchPopupMenu): Ditto.
2153         (WebChromeClient::attachRootGraphicsLayer): Ditto.
2154         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
2155         (WebChromeClient::supportsFullScreenForElement): Ditto.
2156         (WebChromeClient::enterFullScreenForElement): Ditto.
2157         (WebChromeClient::exitFullScreenForElement): Ditto.
2158
2159         * WebView/WebFrame.mm:
2160         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
2161         Updated for change to the appendChild function.
2162
2163 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
2164
2165         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
2166         https://bugs.webkit.org/show_bug.cgi?id=167276
2167
2168         Reviewed by Alex Christensen.
2169         
2170         It was usurped by -deviceOrientationChanged in 2014.
2171
2172         * WebView/WebFrame.mm:
2173         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
2174         * WebView/WebFramePrivate.h:
2175
2176 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
2177
2178         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
2179         https://bugs.webkit.org/show_bug.cgi?id=167271
2180
2181         Reviewed by Alex Christensen.
2182         
2183         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
2184         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
2185
2186         * WebView/WebView.mm:
2187         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
2188         * WebView/WebViewPrivate.h:
2189
2190 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2191
2192         Remove never changing IndexedDB RuntimeEnabledFeature
2193         https://bugs.webkit.org/show_bug.cgi?id=167278
2194
2195         Reviewed by Darin Adler.
2196
2197         * WebView/WebView.mm:
2198         (-[WebView _preferencesChanged:]):
2199
2200 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2201
2202         Cleanup RuntimeEnabledFeatures
2203         https://bugs.webkit.org/show_bug.cgi?id=167228
2204
2205         Reviewed by Simon Fraser.
2206
2207         * WebView/WebView.mm:
2208         (-[WebView _preferencesChanged:]):
2209
2210 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2211
2212         Remove outdated ENABLE(CSP_NEXT) build flag
2213         https://bugs.webkit.org/show_bug.cgi?id=167252
2214
2215         Reviewed by Brent Fulgham.
2216
2217         * Configurations/FeatureDefines.xcconfig:
2218
2219 2017-01-20  Antoine Quint  <graouts@apple.com>
2220
2221         [Modern Media Controls] Turn modern media controls on by default
2222         https://bugs.webkit.org/show_bug.cgi?id=165668
2223
2224         Reviewed by Dean Jackson.
2225
2226         Enabled modern media controls by default in WK1.
2227
2228         * WebView/WebPreferences.mm:
2229         (+[WebPreferences initialize]):
2230
2231 2017-01-19  Chris Dumez  <cdumez@apple.com>
2232
2233         iterable<> should be enabled on WK1
2234         https://bugs.webkit.org/show_bug.cgi?id=167221
2235         <rdar://problem/30108531>
2236
2237         Reviewed by Youenn Fablet.
2238
2239         * WebView/WebPreferenceKeysPrivate.h:
2240         * WebView/WebPreferences.mm:
2241         (-[WebPreferences setCustomElementsEnabled:]):
2242         (-[WebPreferences DOMIteratorEnabled]): Deleted.
2243         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
2244         * WebView/WebPreferencesPrivate.h:
2245         * WebView/WebView.mm:
2246         (-[WebView _preferencesChanged:]):
2247
2248 2017-01-19  Chris Dumez  <cdumez@apple.com>
2249
2250         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
2251         https://bugs.webkit.org/show_bug.cgi?id=167215
2252         <rdar://problem/29885052>
2253
2254         Reviewed by Andreas Kling.
2255
2256         Make sure HTML validation bubble gets dismissed when its associated
2257         element's frame gets detached and that we do not crash.
2258
2259         * WebCoreSupport/WebValidationMessageClient.h:
2260         * WebCoreSupport/WebValidationMessageClient.mm:
2261         (WebValidationMessageClient::documentDetached):
2262
2263 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2264
2265         [Cocoa] Variation fonts are erroneously disabled on iOS
2266         https://bugs.webkit.org/show_bug.cgi?id=167172
2267
2268         Reviewed by Simon Fraser.
2269
2270         OpenSource builders don't seem to understand sdk=embedded*.
2271
2272         * Configurations/FeatureDefines.xcconfig:
2273
2274 2017-01-19  Andreas Kling  <akling@apple.com>
2275
2276         ScriptExecutionContext::topOrigin() should return a reference.
2277         <https://webkit.org/b/167190>
2278
2279         Reviewed by Sam Weinig.
2280
2281         * Misc/WebCache.mm:
2282         (+[WebCache addImageToCache:forURL:forFrame:]):
2283         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2284
2285 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2286
2287         Unreviewed fix for the macOS build.
2288
2289         * Carbon/CarbonWindowAdapter.mm:
2290         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2291
2292 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2293
2294         Unreviewed, rolling out r210848.
2295
2296         This change introduced media-related LayoutTest failures and
2297         crashes on macOS.
2298
2299         Reverted changeset:
2300
2301         "[Modern Media Controls] Turn modern media controls on by
2302         default"
2303         https://bugs.webkit.org/show_bug.cgi?id=165668
2304         http://trac.webkit.org/changeset/210848
2305
2306 2017-01-18  Andreas Kling  <akling@apple.com>
2307
2308         Document::securityOrigin() should return a reference.
2309         <https://webkit.org/b/167124>
2310
2311         Reviewed by Sam Weinig.
2312
2313         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2314         (WebKit::NetscapePluginInstanceProxy::loadRequest):
2315         * Plugins/WebNetscapePluginStream.mm:
2316         (WebNetscapePluginStream::WebNetscapePluginStream):
2317         * Plugins/WebNetscapePluginView.mm:
2318         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2319         * Plugins/WebPluginContainerCheck.mm:
2320         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2321         * WebCoreSupport/WebChromeClient.mm:
2322         (WebChromeClient::exceededDatabaseQuota):
2323         * WebCoreSupport/WebFrameLoaderClient.h:
2324         * WebCoreSupport/WebFrameLoaderClient.mm:
2325         (WebFrameLoaderClient::didRunInsecureContent):
2326         * WebCoreSupport/WebGeolocationClient.mm:
2327         (WebGeolocationClient::requestPermission):
2328         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
2329         * WebView/WebFrame.mm:
2330         (-[WebFrame _allowsFollowingLink:]):
2331
2332 2017-01-18  Antoine Quint  <graouts@apple.com>
2333
2334         [Modern Media Controls] Turn modern media controls on by default
2335         https://bugs.webkit.org/show_bug.cgi?id=165668
2336
2337         Reviewed by Dean Jackson.
2338
2339         Enabled modern media controls by default in WK1. 
2340
2341         * WebView/WebPreferences.mm:
2342         (+[WebPreferences initialize]):
2343
2344 2017-01-15  Darin Adler  <darin@apple.com>
2345
2346         Remove PassRefPtr from "loader" directory of WebCore
2347         https://bugs.webkit.org/show_bug.cgi?id=167055
2348
2349         Reviewed by Alex Christensen.
2350
2351         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
2352         Also made class final and most functions private and final.
2353         * WebCoreSupport/WebChromeClient.mm:
2354         (WebChromeClient::runOpenPanel): Updated to take references.
2355
2356         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
2357         * WebCoreSupport/WebEditorClient.mm:
2358         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
2359         (+[WebUndoStep stepWithUndoStep:]): Ditto.
2360         (-[WebUndoStep step]): Return reference instead of pointer.
2361         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
2362         (-[WebEditorUndoTarget redoEditing:]): Ditto.
2363         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
2364         PassRefPtr.
2365         (WebEditorClient::registerUndoStep): Ditto.
2366         (WebEditorClient::registerRedoStep): Ditto.
2367
2368         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
2369         FrameLoaderClient, marked functions final instead of override.
2370         * WebCoreSupport/WebFrameLoaderClient.mm:
2371         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
2372         pointer instead of PassRefPtr.
2373         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
2374         (makeFormFieldValuesDictionary): Take a reference.
2375         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
2376         of PassRefPtr.
2377         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
2378         of PassRefPtr.
2379         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
2380         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
2381         (WebFrameLoaderClient::createPlugin): Ditto.
2382         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
2383         (WebFrameLoaderClient::createNetworkingContext): Ditto.
2384         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
2385
2386         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
2387         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
2388
2389         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
2390         PassRefPtr. Use RefPtr for class field.
2391         * WebCoreSupport/WebOpenPanelResultListener.mm:
2392         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
2393         correctly without us declaring anything explicitly.
2394         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
2395         and let RefPtr do the work.
2396         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
2397         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
2398         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
2399         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
2400         and uncheckedAppend.
2401
2402         * WebView/WebArchive.mm:
2403         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2404         Updated for changes to LegacyWebArchive.
2405         (-[WebArchive mainResource]): Ditto.
2406         (-[WebArchive subresources]): Ditto.
2407         (-[WebArchive subframeArchives]): Ditto.
2408
2409         * WebView/WebDataSource.mm:
2410         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
2411         instead of NSEnumerator.
2412         (-[WebDataSource _fileWrapperForURL:]): Use auto.
2413         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
2414         (-[WebDataSource mainResource]): Ditto.
2415         (-[WebDataSource subresources]): Ditto.
2416         (-[WebDataSource subresourceForURL:]): Ditto.
2417         (-[WebDataSource addSubresource:]): Ditto.
2418
2419         * WebView/WebResource.mm:
2420         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
2421         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
2422         care of it
2423         (-[WebResource initWithCoder:]): Pass a reference.
2424         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
2425         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
2426         (-[WebResource _coreResource]): Return reference rather than pointer.
2427         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2428         Added code to handle the null case and pass a reference rather than a pointer.
2429         * WebView/WebResourceInternal.h: Updated for the above.
2430
2431 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2432
2433         Unreviewed, rolling out r210834
2434         https://bugs.webkit.org/show_bug.cgi?id=165668
2435
2436         It introduced dozens of test timeouts.
2437
2438         Reverted changeset:
2439         "[Modern Media Controls] Turn modern media controls on by default"
2440         https://bugs.webkit.org/show_bug.cgi?id=165668
2441         http://trac.webkit.org/changeset/210834
2442
2443 2017-01-17  Antoine Quint  <graouts@apple.com>
2444
2445         [Modern Media Controls] Turn modern media controls on by default
2446         https://bugs.webkit.org/show_bug.cgi?id=165668
2447
2448         Reviewed by Dean Jackson.
2449
2450         Enabled modern media controls by default in WK1. 
2451
2452         * WebView/WebPreferences.mm:
2453         (+[WebPreferences initialize]):
2454
2455 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2456
2457         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2458         https://bugs.webkit.org/show_bug.cgi?id=116551
2459         <rdar://problem/13949830>
2460
2461         Reviewed by Alex Christensen.
2462
2463         * Configurations/FeatureDefines.xcconfig:
2464
2465 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2466
2467         Crash when closing tab with debugger paused
2468         https://bugs.webkit.org/show_bug.cgi?id=161746
2469         <rdar://problem/15607819>
2470
2471         Reviewed by Brian Burg and Brent Fulgham.
2472
2473         * WebView/WebView.mm:
2474         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
2475         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
2476         (WebKit::DeferredPageDestructor::tryDestruction):
2477         (-[WebView _close]):
2478         Defer destruction of the Page if we are in a nested runloop.
2479
2480 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2481
2482         Remove the REQUEST_ANIMATION_FRAME flag
2483         https://bugs.webkit.org/show_bug.cgi?id=156980
2484         <rdar://problem/25906849>
2485
2486         Reviewed by Simon Fraser.
2487
2488         * Configurations/FeatureDefines.xcconfig:
2489
2490 2017-01-16  Andy Estes  <aestes@apple.com>
2491
2492         [QuickLook] Do some cleanup in QuickLookHandle
2493         https://bugs.webkit.org/show_bug.cgi?id=166864
2494
2495         Reviewed by Darin Adler.
2496
2497         * WebCoreSupport/WebFrameLoaderClient.mm:
2498         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
2499         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
2500
2501 2017-01-15  Tim Horton  <timothy_horton@apple.com>
2502
2503         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
2504         https://bugs.webkit.org/show_bug.cgi?id=167063
2505
2506         Reviewed by Dan Bernstein.
2507
2508         * WebView/WebHTMLView.mm:
2509         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2510         (-[WebHTMLView _updateFontPanel]):
2511         * WebView/WebView.mm:
2512         (-[WebView typingAttributes]):
2513         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
2514
2515 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2516
2517         Remove ENABLE(DETAILS_ELEMENT) guards
2518         https://bugs.webkit.org/show_bug.cgi?id=167042
2519
2520         Reviewed by Alex Christensen.
2521
2522         * Configurations/FeatureDefines.xcconfig:
2523
2524 2017-01-11  Darin Adler  <darin@apple.com>
2525
2526         Remove PassRefPtr from more of "platform"
2527         https://bugs.webkit.org/show_bug.cgi?id=166809
2528
2529         Reviewed by Sam Weinig.
2530
2531         * WebCoreSupport/WebFrameLoaderClient.mm:
2532         (NetscapePluginWidget::handleEvent): Pass a reference.
2533         * WebView/WebView.mm:
2534         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2535         Updated since the children set now contains Ref instead of RefPtr.
2536
2537 2017-01-13  Sam Weinig  <sam@webkit.org>
2538
2539         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
2540         https://bugs.webkit.org/show_bug.cgi?id=167006
2541
2542         Reviewed by Geoffrey Garen.
2543
2544         * WebView/WebDeviceOrientation.mm:
2545         (convert):
2546         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2547         Update for new use of std::optional.
2548
2549 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
2550
2551         Remove unnecessary includes of Page.h
2552         https://bugs.webkit.org/show_bug.cgi?id=166996
2553
2554         Reviewed by Yusuke Suzuki.
2555
2556         * DOM/DOMHTML.mm:
2557         * History/WebBackForwardList.mm:
2558         * Plugins/WebPluginController.mm:
2559         * WebCoreSupport/WebNotificationClient.mm:
2560         * WebCoreSupport/WebPlatformStrategies.mm:
2561         * WebCoreSupport/WebUserMediaClient.mm:
2562         * WebView/WebFullScreenController.mm:
2563
2564 2017-01-12  Chris Dumez  <cdumez@apple.com>
2565
2566         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2567         https://bugs.webkit.org/show_bug.cgi?id=166995
2568
2569         Reviewed by Jer Noble.
2570
2571         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2572         as some people are having trouble building without it.
2573
2574         * Configurations/FeatureDefines.xcconfig:
2575
2576 2017-01-12  Chris Dumez  <cdumez@apple.com>
2577
2578         HTML form validation popover sometimes does not go away
2579         https://bugs.webkit.org/show_bug.cgi?id=166990
2580         <rdar://problem/29985957>
2581
2582         Reviewed by Tim Horton.
2583
2584         Update code using ValidationBubble now that it is RefCounted.
2585
2586         * WebView/WebView.mm:
2587         (-[WebView showFormValidationMessage:withAnchorRect:]):
2588
2589 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2590
2591         Remove pointerLockElement from DOMDocumentPrivate.h
2592         https://bugs.webkit.org/show_bug.cgi?id=166882
2593
2594         Reviewed by Simon Fraser.
2595
2596         Removed pointerLockElement declaration that was supposed to be removed in r209637.
2597
2598         * DOM/DOMDocumentPrivate.h:
2599
2600 2017-01-06  Darin Adler  <darin@apple.com>
2601
2602         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
2603         https://bugs.webkit.org/show_bug.cgi?id=166797
2604
2605         Reviewed by Alex Christensen.
2606
2607         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
2608         * WebCoreSupport/WebEditorClient.mm:
2609         (WebEditorClient::requestCheckingOfString): Take a reference
2610         instead of a PassRefPtr.
2611
2612 2017-01-05  Chris Dumez  <cdumez@apple.com>
2613
2614         Turn preferLowPowerWebGLRendering setting on by default
2615         https://bugs.webkit.org/show_bug.cgi?id=166737
2616         <rdar://problem/29870033>
2617
2618         Reviewed by Dean Jackson.
2619
2620         Temporarily turn preferLowPowerWebGLRendering setting on by default until
2621         we deal better with WebGL content in background tabs.
2622
2623         * WebView/WebPreferences.mm:
2624         (+[WebPreferences initialize]):
2625
2626 2017-01-05  Enrica Casucci  <enrica@apple.com>
2627
2628         Support File Promise during drag for macOS.
2629         https://bugs.webkit.org/show_bug.cgi?id=165204
2630         rdar://problem/19595567
2631
2632         Reviewed by Tim Horton.
2633
2634         Adds support for dropping a File Promise in a WebView.
2635         The implementation uses new File Promise API available in Sierra.
2636
2637         * Misc/WebNSPasteboardExtras.mm:
2638         (+[NSPasteboard _web_dragTypesForURL]):
2639         * WebView/WebView.mm:
2640         (-[WebView performDragOperation:]):
2641
2642 2017-01-05  Andreas Kling  <akling@apple.com>
2643
2644         Remove ChromeClient::needTouchEvents().
2645         <https://webkit.org/b/166723>
2646
2647         Rubber-stamped by Antti Koivisto.
2648
2649         * WebCoreSupport/WebChromeClient.h:
2650
2651 2017-01-04  Darin Adler  <darin@apple.com>
2652
2653         Remove PassRefPtr use from the "html" directory, other improvements
2654         https://bugs.webkit.org/show_bug.cgi?id=166635
2655
2656         Reviewed by Alex Christensen.
2657
2658         * WebCoreSupport/WebChromeClient.h:
2659         * WebCoreSupport/WebChromeClient.mm:
2660         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
2661
2662 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
2663
2664         Unreviewed, rolling out r210287.
2665
2666         This change caused editing test failures on macOS.
2667
2668         Reverted changeset:
2669
2670         "Support File Promise during drag for macOS."
2671         https://bugs.webkit.org/show_bug.cgi?id=165204
2672         http://trac.webkit.org/changeset/210287
2673
2674 2017-01-04  Enrica Casucci  <enrica@apple.com>
2675
2676         Support File Promise during drag for macOS.
2677         https://bugs.webkit.org/show_bug.cgi?id=165204
2678         rdar://problem/19595567
2679
2680         Reviewed by Tim Horton.
2681
2682         Adds support for dropping a File Promise in a WebView.
2683         The implementation uses new File Promise API available in Sierra.
2684
2685         * Misc/WebNSPasteboardExtras.mm:
2686         (+[NSPasteboard _web_dragTypesForURL]):
2687         * WebView/WebView.mm:
2688         (-[WebView performDragOperation:]):
2689
2690 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2691
2692         Provide a setting for clients to always prefer low-power WebGL
2693         https://bugs.webkit.org/show_bug.cgi?id=166675
2694         <rdar://problem/29834093>
2695
2696         Reviewed by Dan Bernstein.
2697
2698         * WebView/WebPreferenceKeysPrivate.h:
2699         * WebView/WebPreferences.mm:
2700         (+[WebPreferences initialize]):
2701         (-[WebPreferences preferLowPowerWebGLRendering]):
2702         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
2703         * WebView/WebPreferencesPrivate.h:
2704         * WebView/WebView.mm:
2705         (-[WebView _preferencesChanged:]):
2706         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
2707
2708 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2709
2710         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2711         https://bugs.webkit.org/show_bug.cgi?id=166450
2712         <rdar://problem/29447824>
2713
2714         Reviewed by Darin Adler.
2715
2716         * WebCoreSupport/CorrectionPanel.h:
2717         * WebCoreSupport/CorrectionPanel.mm:
2718         (CorrectionPanel::recordAutocorrectionResponse):
2719         (CorrectionPanel::handleAcceptedReplacement):
2720         * WebCoreSupport/WebAlternativeTextClient.mm:
2721         (toCorrectionResponse):
2722         (WebAlternativeTextClient::recordAutocorrectionResponse):
2723         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2724         through recordAutocorrectionResponse, for debugging's sake.
2725         Drop the NSView parameter because we don't need it, just the tag.
2726         Convert the new AutocorrectionResponseType value to its corresponding
2727         NSCorrectionResponse value.
2728
2729 2017-01-01  Jeff Miller  <jeffm@apple.com>
2730
2731         Update user-visible copyright strings to include 2017
2732         https://bugs.webkit.org/show_bug.cgi?id=166278
2733
2734         Reviewed by Dan Bernstein.
2735
2736         * Info.plist:
2737
2738 2016-12-30  Darin Adler  <darin@apple.com>
2739
2740         Remove PassRefPtr use from the "dom" directory, related cleanup
2741         https://bugs.webkit.org/show_bug.cgi?id=166569
2742
2743         Reviewed by Alex Christensen.
2744
2745         * WebCoreSupport/WebFrameLoaderClient.mm:
2746         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
2747         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
2748         (WebFrameLoaderClient::setTitle): Ditto.
2749         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
2750         * WebView/WebFrame.mm:
2751         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
2752         Not needed now, but useful later if we ever can get rid of the explicit constructors.
2753         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
2754         * WebView/WebHTMLRepresentation.mm:
2755         (-[WebHTMLRepresentation title]): Updated to use struct.
2756
2757 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
2758
2759         Propagate the source origin as much as possible
2760         https://bugs.webkit.org/show_bug.cgi?id=166348
2761
2762         Reviewed by Darin Adler.
2763
2764         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2765         (WebKit::NetscapePluginInstanceProxy::evaluate):
2766
2767 2016-12-23  Andy Estes  <aestes@apple.com>
2768
2769         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
2770         https://bugs.webkit.org/show_bug.cgi?id=166471
2771
2772         Reviewed by Andreas Kling.
2773
2774         When DumpRenderTree starts up, it calls
2775         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
2776         builds, this triggers the ASSERT(isMainThread()) in
2777         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
2778         started, we are on the main thread, and we are not holding the Web thread lock. This is
2779         causing all layout tests to crash in the iOS WK1 Debug configuration.
2780
2781         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2782         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
2783
2784 2016-12-22  Andy Estes  <aestes@apple.com>
2785
2786         Make WebCore::EditorInsertAction an enum class
2787         https://bugs.webkit.org/show_bug.cgi?id=166424
2788
2789         Reviewed by Brent Fulgham.
2790
2791         * WebCoreSupport/WebEditorClient.mm:
2792         (kit):
2793
2794 2016-12-21  Beth Dakin  <bdakin@apple.com>
2795
2796         Holding down on candidates in the TouchBar should show panel on screen
2797         https://bugs.webkit.org/show_bug.cgi?id=166367
2798         -and corresponding-
2799         <rdar://problem/28479236>
2800
2801         Reviewed by Tim Horton.
2802
2803         Stray whitespace.
2804         * WebCoreSupport/WebEditorClient.mm:
2805         (WebEditorClient::handleRequestedCandidates):
2806
2807         Call the version of setCandidates: that takes a rect. We need to keep the helper 
2808         function in WK1 (unlike WK2) since we also use it for testing.
2809         * WebView/WebView.mm:
2810         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2811
2812 2016-12-20  Dean Jackson  <dino@apple.com>
2813
2814         Remove INDIE_UI
2815         https://bugs.webkit.org/show_bug.cgi?id=165881
2816         <rdar://problem/29672532>
2817
2818         Reviewed by Simon Fraser.
2819
2820         The Indie UI work has been discontinued.
2821
2822         * Configurations/FeatureDefines.xcconfig:
2823
2824 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2825
2826         [ES6] Enable ES6 Modules
2827         https://bugs.webkit.org/show_bug.cgi?id=165849
2828
2829         Reviewed by Geoffrey Garen.
2830
2831         * WebView/WebPreferenceKeysPrivate.h:
2832         * WebView/WebPreferences.mm:
2833         (+[WebPreferences initialize]):
2834         (-[WebPreferences es6ModulesEnabled]): Deleted.
2835         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
2836         * WebView/WebPreferencesPrivate.h:
2837         * WebView/WebView.mm:
2838         (-[WebView _preferencesChanged:]):
2839
2840 2016-12-16  Dave Hyatt  <hyatt@apple.com>
2841
2842         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
2843         https://bugs.webkit.org/show_bug.cgi?id=165968
2844
2845         Reviewed by Andreas Kling.
2846
2847         * DOM/DOMCSS.mm:
2848         (kitClass):
2849         * DOM/DOMCSSPrimitiveValue.mm:
2850         (-[DOMCSSPrimitiveValue getCounterValue]):
2851         (-[DOMCSSPrimitiveValue getRectValue]):
2852         (kit):
2853         * DOM/DOMCSSPrimitiveValueInternal.h:
2854         * DOM/DOMCSSStyleDeclaration.mm:
2855         * DOM/DOMCSSValue.mm:
2856         (kit):
2857         * DOM/DOMCSSValueInternal.h:
2858         * DOM/DOMCSSValueList.mm:
2859         * DOM/DOMCounter.mm:
2860         (kit):
2861         * DOM/DOMCounterInternal.h:
2862         * DOM/DOMRGBColor.mm:
2863         (kit):
2864         * DOM/DOMRGBColorInternal.h:
2865         * DOM/DOMRect.mm:
2866         (kit):
2867         * DOM/DOMRectInternal.h:
2868         * DOM/DOMUtility.mm:
2869         (createDOMWrapper):
2870
2871 2016-12-16  Chris Dumez  <cdumez@apple.com>
2872
2873         HTML form validation bubble should be dismissed on navigation
2874         https://bugs.webkit.org/show_bug.cgi?id=165960
2875         <rdar://problem/29668086>
2876
2877         Reviewed by Simon Fraser.
2878
2879         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
2880
2881         * WebView/WebView.mm:
2882         (-[WebView _didStartProvisionalLoadForFrame:]):
2883
2884 2016-12-15  Darin Adler  <darin@apple.com>
2885
2886         Use asString instead of toWTFString, toString, or getString when we already checked isString
2887         https://bugs.webkit.org/show_bug.cgi?id=165895
2888
2889         Reviewed by Yusuke Suzuki.
2890
2891         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2892         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
2893         toWTFString.
2894         * WebView/WebView.mm:
2895         (aeDescFromJSValue): Use asString/value instead of getString.
2896
2897 2016-12-15  Chris Dumez  <cdumez@apple.com>
2898
2899         Make sure HTML validation bubble's state is updated after layout
2900         https://bugs.webkit.org/show_bug.cgi?id=165922
2901         <rdar://problem/29694730>
2902
2903         Reviewed by Simon Fraser.
2904
2905         Make sure HTML validation bubble's state is updated after layout.
2906         In particular, if the validation bubble's associated element has
2907         moved or is no longer visible, we now hide the bubble.
2908
2909         * WebCoreSupport/WebValidationMessageClient.h:
2910         * WebCoreSupport/WebValidationMessageClient.mm:
2911         (WebValidationMessageClient::showValidationMessage):
2912         (WebValidationMessageClient::hideValidationMessage):
2913         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
2914
2915 2016-12-15  Chris Dumez  <cdumez@apple.com>
2916
2917         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
2918         https://bugs.webkit.org/show_bug.cgi?id=165904
2919
2920         Reviewed by Sam Weinig.
2921
2922         Update ObjC bindings so they keep building.
2923
2924         * DOM/DOMUIEvent.mm:
2925         (-[DOMUIEvent keyCode]):
2926         (-[DOMUIEvent charCode]):
2927
2928 2016-12-15  Andreas Kling  <akling@apple.com>
2929
2930         Always clear RenderLayer backing stores when going into page cache.
2931         <https://webkit.org/b/165901>
2932
2933         Reviewed by Simon Fraser.
2934
2935         * WebView/WebView.mm:
2936         (+[WebView _setCacheModel:]):
2937
2938 2016-12-12  Alex Christensen  <achristensen@webkit.org>
2939
2940         Remove unused workaround for Silverlight
2941         https://bugs.webkit.org/show_bug.cgi?id=165773
2942
2943         Reviewed by Dean Jackson.
2944
2945         * Plugins/WebNetscapePluginView.mm:
2946         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
2947         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
2948         Allowing 6 years for users to update Silverlight is more than enough.
2949         Safari doesn't even use WebKit1 for this any more.
2950         I need this to be removed because this is the only non-WebGL code that needs to link against
2951         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
2952
2953 2016-12-12  Chris Dumez  <cdumez@apple.com>
2954
2955         Document.visibilityState should use an IDL string enumeration
2956         https://bugs.webkit.org/show_bug.cgi?id=165774
2957
2958         Reviewed by Daniel Bates.
2959
2960         * DOM/DOMDocument.mm:
2961         (-[DOMDocument visibilityState]):
2962         * WebView/WebView.mm:
2963         (kit):
2964
2965 2016-12-12  Jer Noble  <jer.noble@apple.com>
2966
2967         Remove implementation of legacy Mozilla-based Fullscreen API.
2968         https://bugs.webkit.org/show_bug.cgi?id=165689
2969         <rdar://problem/29603053>
2970
2971         Reviewed by Eric Carlson.
2972
2973         * DOM/DOMElement.mm:
2974         (-[DOMElement webkitRequestFullScreen:]):
2975
2976 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
2977
2978         The DOM should have an advancing wavefront opaque root barrier
2979         https://bugs.webkit.org/show_bug.cgi?id=165712
2980
2981         Reviewed by Yusuke Suzuki.
2982         
2983         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
2984
2985         * Misc/WebCoreStatistics.mm:
2986         (+[WebCoreStatistics javaScriptObjectsCount]):
2987         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2988         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2989         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2990         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2991         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
2992         (+[WebCoreStatistics shouldPrintExceptions]):
2993         (+[WebCoreStatistics setShouldPrintExceptions:]):
2994         (+[WebCoreStatistics memoryStatistics]):
2995         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2996         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2997         (identifierFromIdentifierRep):
2998         * Plugins/Hosted/ProxyInstance.mm:
2999         (WebKit::ProxyInstance::getPropertyNames):
3000         * Plugins/WebNetscapePluginStream.mm:
3001         (WebNetscapePluginStream::wantsAllStreams):
3002         * Plugins/WebNetscapePluginView.mm:
3003         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3004         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
3005         (-[WebNetscapePluginView setWindowIfNecessary]):
3006         (-[WebNetscapePluginView createPluginScriptableObject]):
3007         (-[WebNetscapePluginView getFormValue:]):
3008         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
3009         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
3010         (-[WebNetscapePluginView loadPluginRequest:]):
3011         (-[WebNetscapePluginView _printedPluginBitmap]):
3012         * Plugins/WebPluginController.mm:
3013         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
3014         (-[WebPluginController stopOnePlugin:]):
3015         (-[WebPluginController stopOnePluginForPageCache:]):
3016         (-[WebPluginController destroyOnePlugin:]):
3017         (-[WebPluginController startAllPlugins]):
3018         (-[WebPluginController addPlugin:]):
3019
3020 2016-12-09  Dave Hyatt  <hyatt@apple.com>
3021
3022         [CSS Parser] Remove the old CSS Parser
3023         https://bugs.webkit.org/show_bug.cgi?id=165645
3024
3025         Reviewed by Daniel Bates.
3026
3027         * DOM/DOMCSS.mm:
3028         (kitClass):
3029         * DOM/DOMCSSRule.h:
3030
3031 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3032
3033         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3034         https://bugs.webkit.org/show_bug.cgi?id=165251
3035
3036         Reviewed by Dean Jackson.
3037
3038         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3039
3040         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
3041         * WebView/WebPreferences.mm:
3042         (+[WebPreferences initialize]):
3043         (-[WebPreferences mediaStreamEnabled]):
3044         (-[WebPreferences setMediaStreamEnabled:]):
3045         (-[WebPreferences peerConnectionEnabled]):
3046         (-[WebPreferences setPeerConnectionEnabled:]):
3047         * WebView/WebPreferencesPrivate.h:
3048         * WebView/WebView.mm:
3049         (-[WebView _preferencesChanged:]):
3050
3051 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
3052
3053         Don’t expose pointer lock in WebKit1 Objective-C API
3054         https://bugs.webkit.org/show_bug.cgi?id=165692
3055
3056         Reviewed by Simon Fraser.
3057
3058         * DOM/DOMDocument.mm:
3059         (-[DOMDocument pointerLockElement]): Deleted.
3060         (-[DOMDocument exitPointerLock]): Deleted.
3061         * DOM/DOMElement.mm:
3062         (-[DOMElement requestPointerLock]): Deleted.
3063         * DOM/DOMMouseEvent.mm:
3064         (-[DOMMouseEvent movementX]): Deleted.
3065         (-[DOMMouseEvent movementY]): Deleted.
3066
3067 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
3068
3069         document.webkitFullscreenElement leaks elements inside a shadow tree
3070         https://bugs.webkit.org/show_bug.cgi?id=158471
3071
3072         Reviewed by Chris Dumez.
3073
3074         Use the API for bindings to avoid exposing nodes inside a shadow tree.
3075
3076         * DOM/DOMDocument.mm:
3077         (-[DOMDocument webkitCurrentFullScreenElement]):
3078         (-[DOMDocument webkitFullscreenElement]):
3079
3080 2016-12-09  Beth Dakin  <bdakin@apple.com>
3081
3082         Password fields should not show the emoji button in TouchBar
3083         https://bugs.webkit.org/show_bug.cgi?id=165673
3084         -and corresponding-
3085         rdar://problem/29235739
3086
3087         Reviewed by Wenson Hsieh.
3088
3089         This patch adds a new ivar for the password touch bar and password 
3090         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
3091         of identifiers than the plain text TouchBar, it should just have its own variable.
3092
3093         The candidate list should be the only item for passwords.
3094         * WebView/WebView.mm:
3095         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
3096
3097         Account for _passwordTextTouchBar.
3098         (-[WebView didChangeAutomaticTextCompletion:]):
3099         (-[WebView setUpTextTouchBar:]):
3100         (-[WebView textTouchBar]):
3101
3102         The empty candidates array is not needed. We can just set @[ ] as the candidates 
3103         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
3104         other parts of the code to prevent us from requesting or setting other candidates 
3105         when in a password field. 
3106         (-[WebView updateTextTouchBar]):
3107
3108         Account for _passwordTextTouchBar.
3109         (-[WebView candidateList]):
3110         * WebView/WebViewData.h:
3111
3112 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3113
3114         Enable SharedArrayBuffer, remove the flag
3115         https://bugs.webkit.org/show_bug.cgi?id=165614
3116
3117         Rubber stamped by Geoffrey Garen.
3118
3119         * WebView/WebPreferencesPrivate.h:
3120
3121 2016-12-07  Dean Jackson  <dino@apple.com>
3122
3123         Remove runtime toggle for pointer-lock
3124         https://bugs.webkit.org/show_bug.cgi?id=165577
3125         <rdar://problems/29566996>
3126
3127         Reviewed by Jon Lee.
3128
3129         Remove any runtime calls to check if pointer-lock is enabled. It's
3130         either compiled in or out.
3131
3132         * WebView/WebPreferenceKeysPrivate.h:
3133         * WebView/WebPreferences.mm:
3134         (-[WebPreferences pointerLockEnabled]): Deleted.
3135         (-[WebPreferences setPointerLockEnabled:]): Deleted.
3136         * WebView/WebPreferencesPrivate.h:
3137         * WebView/WebView.mm:
3138         (-[WebView _preferencesChanged:]):
3139
3140 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3141
3142         Correct SDKROOT values in xcconfig files
3143         https://bugs.webkit.org/show_bug.cgi?id=165487
3144         rdar://problem/29539209
3145
3146         Reviewed by Dan Bernstein.
3147
3148         Fix suggested by Dan Bernstein.
3149
3150         * Configurations/DebugRelease.xcconfig:
3151
3152 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
3153
3154         Improve the behavior of scroll-into-view when the target is inside position:fixed
3155         https://bugs.webkit.org/show_bug.cgi?id=165354
3156
3157         Reviewed by Zalan Bujtas.
3158
3159         Plumb through 'insideFixed'. We don't get compute it, so behavior from
3160         these call sites won't change.
3161
3162         * WebView/WebFrame.mm:
3163         (-[WebFrame _scrollDOMRangeToVisible:]):
3164         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
3165
3166 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
3167
3168         Enable visual viewports by default on Mac, and iOS Wk2
3169         https://bugs.webkit.org/show_bug.cgi?id=165452
3170
3171         Reviewed by Zalan Bujtas.
3172
3173         Turn visual viewports on by default for WK1 on Mac.
3174
3175         * WebView/WebPreferences.mm:
3176         (+[WebPreferences initialize]):
3177
3178 2016-12-05  Dean Jackson  <dino@apple.com>
3179
3180         pointer lock needs to be feature detectable
3181         https://bugs.webkit.org/show_bug.cgi?id=165426
3182         <rdar://problem/29486715>
3183
3184         Reviewed by Antoine Quint.
3185
3186         Set the RuntimeEnabledFeature as preferences
3187         change.
3188
3189         * WebView/WebView.mm:
3190         (-[WebView _preferencesChanged:]):
3191
3192 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
3193
3194         Unreviewed, rolling out r209299.
3195
3196         This change appears to have caused LayoutTest failures on
3197         Sierra WK1.
3198
3199         Reverted changeset:
3200
3201         "Improve the behavior of scroll-into-view when the target is
3202         inside position:fixed"
3203         https://bugs.webkit.org/show_bug.cgi?id=165354
3204         http://trac.webkit.org/changeset/209299
3205
3206 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
3207
3208         Improve the behavior of scroll-into-view when the target is inside position:fixed
3209         https://bugs.webkit.org/show_bug.cgi?id=165354
3210
3211         Reviewed by Zalan Bujtas.
3212
3213         Plumb through 'insideFixed'. We don't get compute it, so behavior from
3214         these call sites won't change.
3215
3216         * WebView/WebFrame.mm:
3217         (-[WebFrame _scrollDOMRangeToVisible:]):
3218         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
3219
3220 2016-12-02  Andy Estes  <aestes@apple.com>
3221
3222         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
3223         https://bugs.webkit.org/show_bug.cgi?id=164492
3224
3225         Reviewed by Dan Bernstein.
3226
3227         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3228         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3229         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
3230         ${PRODUCT_BUNDLE_IDENTIFIER}.
3231
3232 2016-12-02  Chris Dumez  <cdumez@apple.com>
3233
3234         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
3235         https://bugs.webkit.org/show_bug.cgi?id=165328
3236
3237         Reviewed by Simon Fraser.
3238
3239         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
3240
3241         * WebView/WebViewData.mm:
3242         (-[WebViewPrivate init]):
3243
3244 2016-12-02  Chris Dumez  <cdumez@apple.com>
3245
3246         [Mac][WK1] Implement new HTML interactive form validation user interface
3247         https://bugs.webkit.org/show_bug.cgi?id=164483
3248
3249         Reviewed by Simon Fraser.
3250
3251         Implement new HTML interactive form validation user interface on Mac
3252         WK1 and enable it by default.
3253
3254         * WebCoreSupport/WebValidationMessageClient.h: Added.
3255         * WebCoreSupport/WebValidationMessageClient.mm: Added.
3256         (WebValidationMessageClient::WebValidationMessageClient):
3257         (WebValidationMessageClient::~WebValidationMessageClient):
3258         (WebValidationMessageClient::showValidationMessage):
3259         (WebValidationMessageClient::hideValidationMessage):
3260         (WebValidationMessageClient::isValidationMessageVisible):
3261         * WebView/WebHTMLView.mm:
3262         (-[WebHTMLView _frameOrBoundsChanged]):
3263         * WebView/WebView.mm:
3264         (-[WebView _commonInitializationWithFrameName:groupName:]):
3265         (-[WebView _willStartScrollingOrZooming]):
3266         (-[WebView _contentsOfUserInterfaceItem:]):
3267         (-[WebView _scaleWebView:atOrigin:]):
3268         (-[WebView _didScrollDocumentInFrameView:]):
3269         (-[WebView _setZoomMultiplier:isTextOnly:]):
3270         (-[WebView showFormValidationMessage:withAnchorRect:]):
3271         (-[WebView hideFormValidationMessage]):
3272         * WebView/WebViewData.h:
3273         * WebView/WebViewData.mm:
3274         (-[WebViewPrivate init]):
3275         * WebView/WebViewInternal.h:
3276         * WebView/WebViewPrivate.h:
3277
3278 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
3279
3280         Add a runtime flag for SubtleCrypto
3281         https://bugs.webkit.org/show_bug.cgi?id=164982
3282
3283         Reviewed by Brent Fulgham.
3284
3285         * WebView/WebPreferenceKeysPrivate.h:
3286         * WebView/WebPreferences.mm:
3287         (+[WebPreferences initialize]):
3288         (-[WebPreferences subtleCryptoEnabled]):
3289         (-[WebPreferences setSubtleCryptoEnabled:]):
3290         * WebView/WebPreferencesPrivate.h:
3291         * WebView/WebView.mm:
3292         (-[WebView _preferencesChanged:]):
3293
3294 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
3295
3296         Add separate settings and preferences to enable/disable async decoding for large images and animated images
3297         https://bugs.webkit.org/show_bug.cgi?id=165177
3298
3299         Reviewed by Simon Fraser.
3300         
3301         Hook up the async image decoding settings for WebKit1.
3302
3303         * WebView/WebPreferenceKeysPrivate.h:
3304         * WebView/WebPreferences.mm:
3305         (+[WebPreferences initialize]):
3306         (-[WebPreferences largeImageAsyncDecodingEnabled]):
3307         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
3308         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
3309         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
3310         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
3311         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
3312         * WebView/WebPreferencesPrivate.h:
3313         * WebView/WebView.mm:
3314         (-[WebView _preferencesChanged:]):
3315
3316 2016-11-29  Andy Estes  <aestes@apple.com>
3317
3318         [Cocoa] Enable two clang warnings recommended by Xcode
3319         https://bugs.webkit.org/show_bug.cgi?id=164498
3320
3321         Reviewed by Mark Lam.
3322
3323         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
3324
3325 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3326
3327         [WTF] Import std::optional reference implementation as WTF::Optional
3328         https://bugs.webkit.org/show_bug.cgi?id=164199
3329
3330         Reviewed by Saam Barati and Sam Weinig.
3331
3332         Use WTF::Optional::value_or.
3333
3334         * DOM/DOMHTMLOptionsCollection.mm:
3335         (-[DOMHTMLOptionsCollection add:index:]):
3336         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3337         (WebKit::NetscapePluginInstanceProxy::evaluate):
3338         * Plugins/WebNetscapePluginView.mm:
3339         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3340         * WebCoreSupport/WebFrameLoaderClient.h:
3341         * WebCoreSupport/WebFrameLoaderClient.mm:
3342         (WebFrameLoaderClient::dispatchDidCommitLoad):
3343         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3344         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3345         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
3346         (WebPaymentCoordinatorClient::completeShippingContactSelection):
3347         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
3348         * WebCoreSupport/WebSecurityOrigin.mm:
3349         (-[WebSecurityOrigin port]):
3350         * WebView/WebHTMLView.mm:
3351         (toAction):
3352         (toTag):
3353
3354 2016-11-26  Sam Weinig  <sam@webkit.org>
3355
3356         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
3357         https://bugs.webkit.org/show_bug.cgi?id=164965
3358
3359         Reviewed by Simon Fraser.
3360
3361         * WebView/WebPreferenceKeysPrivate.h:
3362         * WebView/WebPreferences.mm:
3363         (-[WebPreferences intersectionObserverEnabled]):
3364         (-[WebPreferences setIntersectionObserverEnabled:]):
3365         * WebView/WebPreferencesPrivate.h:
3366         * WebView/WebView.mm:
3367         (-[WebView _preferencesChanged:]):
3368         Add a preference, defaulting to off, for enabling IntersectionObserver.
3369
3370 2016-11-22  Dan Bernstein  <mitz@apple.com>
3371
3372         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
3373         https://bugs.webkit.org/show_bug.cgi?id=165036
3374         <rdar://problem/5708580>
3375
3376         Reviewed by Alexey Proskuryakov.
3377
3378         * WebView/WebHTMLView.mm:
3379         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
3380           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
3381
3382 2016-11-21  Alex Christensen  <achristensen@webkit.org>
3383
3384         Fix Sierra CMake build after r208452
3385         https://bugs.webkit.org/show_bug.cgi?id=164437
3386
3387         * WebView/WebView.mm:
3388         (-[WebView updateMediaTouchBar]):
3389         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
3390         It's needed for playbackSessionInterface to exist.
3391
3392 2016-11-18  Enrica Casucci  <enrica@apple.com>
3393
3394         Refactor drag and drop for WebKit2 to encode DragData message exchange.
3395         https://bugs.webkit.org/show_bug.cgi?id=164945
3396
3397         Reviewed by Tim Horton.
3398
3399         * WebCoreSupport/WebDragClient.h:
3400         * WebCoreSupport/WebDragClient.mm:
3401         (WebDragClient::actionMaskForDrag):
3402         (WebDragClient::willPerformDragDestinationAction):
3403
3404 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
3405
3406         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
3407         https://bugs.webkit.org/show_bug.cgi?id=163801
3408
3409         Reviewed by Simon Fraser.
3410
3411         Plumb through PointerLockEnabled setting.
3412
3413         * Configurations/FeatureDefines.xcconfig:
3414         * WebCoreSupport/WebChromeClient.mm:
3415         (WebChromeClient::requestPointerUnlock):
3416         * WebView/WebPreferenceKeysPrivate.h:
3417         * WebView/WebPreferences.mm:
3418         (-[WebPreferences pointerLockEnabled]):
3419         (-[WebPreferences setPointerLockEnabled:]):
3420         * WebView/WebPreferencesPrivate.h:
3421         * WebView/WebView.mm:
3422         (-[WebView _preferencesChanged:]):
3423
3424 2016-11-17  Dan Bernstein  <mitz@apple.com>
3425
3426         Try to fix some non-macOS builds.
3427
3428         * WebView/WebView.mm:
3429
3430 2016-11-16  Dave Hyatt  <hyatt@apple.com>
3431
3432         [CSS Parser] Add @supports, @keyframe and media query parsing options
3433         https://bugs.webkit.org/show_bug.cgi?id=164821
3434
3435         Reviewed by Sam Weinig and Zalan Bujtas.
3436
3437         Fix up the create call now that fallback descriptor syntax is gone.
3438
3439         * DOM/DOM.mm:
3440         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3441
3442 2016-11-17  Saam Barati  <sbarati@apple.com>
3443
3444         Remove async/await compile time flag and enable tests
3445         https://bugs.webkit.org/show_bug.cgi?id=164828
3446         <rdar://problem/28639334>
3447
3448         Reviewed by Yusuke Suzuki.
3449
3450         * Configurations/FeatureDefines.xcconfig:
3451
3452 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3453
3454         [JSC] WTF::TemporaryChange with WTF::SetForScope
3455         https://bugs.webkit.org/show_bug.cgi?id=164761
3456
3457         Reviewed by Saam Barati.
3458
3459         * WebView/WebView.mm:
3460         (-[WebView updateTextTouchBar]):
3461
3462 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3463
3464         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3465         https://bugs.webkit.org/show_bug.cgi?id=164827
3466
3467         Reviewed by Ryosuke Niwa.
3468
3469         * Configurations/FeatureDefines.xcconfig:
3470         * WebView/WebPreferenceKeysPrivate.h:
3471         * WebView/WebPreferences.mm:
3472         (+[WebPreferences initialize]):
3473         (-[WebPreferences es6ModulesEnabled]):
3474         (-[WebPreferences setES6ModulesEnabled:]):
3475         * WebView/WebPreferencesPrivate.h:
3476         * WebView/WebView.mm:
3477         (-[WebView _preferencesChanged:]):
3478
3479 2016-11-14  Alex Christensen  <achristensen@webkit.org>
3480
3481         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
3482         https://bugs.webkit.org/show_bug.cgi?id=164720
3483
3484         Reviewed by Brady Eidson.
3485
3486         * Storage/WebDatabaseManager.mm:
3487         (-[WebDatabaseManager origins]):
3488         (-[WebDatabaseManager databasesWithOrigin:]):
3489         (-[WebDatabaseManager deleteOrigin:]):
3490         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3491         * Storage/WebDatabaseManagerClient.h:
3492         * Storage/WebDatabaseManagerClient.mm:
3493         (DidModifyOriginData::dispatchToMainThread):
3494         (DidModifyOriginData::DidModifyOriginData):
3495         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
3496         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
3497         * Storage/WebDatabaseQuotaManager.mm:
3498         (-[WebDatabaseQuotaManager usage]):
3499         (-[WebDatabaseQuotaManager quota]):
3500         (-[WebDatabaseQuotaManager setQuota:]):
3501         * Storage/WebStorageManager.mm:
3502         (-[WebStorageManager origins]):
3503         (-[WebStorageManager deleteOrigin:]):
3504         * Storage/WebStorageTrackerClient.h:
3505         * Storage/WebStorageTrackerClient.mm:
3506         (WebStorageTrackerClient::dispatchDidModifyOrigin):
3507         * WebCoreSupport/WebSecurityOrigin.mm:
3508         (-[WebSecurityOrigin usage]):
3509         (-[WebSecurityOrigin quota]):
3510         (-[WebSecurityOrigin setQuota:]):
3511
3512 2016-11-13  Darin Adler  <darin@apple.com>
3513
3514         Fix exception handling in SQL database code, streamline and update code
3515         https://bugs.webkit.org/show_bug.cgi?id=164685
3516
3517         Reviewed by Sam Weinig.
3518
3519         * Storage/WebDatabaseManager.mm:
3520         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
3521         a reference.
3522         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
3523         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
3524         but continue to use DatabaseManager.
3525         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
3526         reference.
3527         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
3528
3529         * Storage/WebDatabaseManagerClient.h: Updated to take references.
3530         * Storage/WebDatabaseManagerClient.mm:
3531         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
3532         members in the class definition.
3533         (DidModifyOriginData::dispatchToMainThread): Take references.
3534         (DidModifyOriginData::DidModifyOriginData): Ditto.
3535         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
3536         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
3537         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
3538         DatabaseTracker::singleton instead of tracker.
3539
3540         * Storage/WebDatabaseQuotaManager.mm:
3541         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
3542         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
3543         (-[WebDatabaseQuotaManager quota]): Ditto.
3544         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
3545         * WebCoreSupport/WebSecurityOrigin.mm:
3546         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
3547         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
3548         (-[WebSecurityOrigin quota]): Ditto.
3549         (-[WebSecurityOrigin setQuota:]): Ditto.
3550         * WebView/WebFrame.mm:
3551         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
3552
3553 2016-11-12  Darin Adler  <darin@apple.com>
3554
3555         Remove a few assorted uses of ExceptionCode
3556         https://bugs.webkit.org/show_bug.cgi?id=164683
3557
3558         Reviewed by Chris Dumez.
3559
3560         * DOM/DOMDOMImplementation.mm:
3561         (-[DOMImplementation createDocumentType:publicId:systemId:]):
3562         Use raiseOnDOMError instead of much longer hand written equivalent.
3563         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
3564
3565         * DOM/DOMDocument.mm:
3566         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
3567         so we are not using a specific exception code.
3568
3569         * DOM/DOMHTMLOptionsCollection.mm:
3570         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
3571         much longer hand written equivalent.
3572         * DOM/DOMHTMLSelectElement.mm:
3573         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
3574         statement after calling a "no return" function.
3575
3576         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
3577         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
3578         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
3579         to raiseDOMErrorException; it is only used as the non-inline implementation
3580         part of the inline raiseOnDOMError function.
3581         * DOM/ExceptionHandlers.mm:
3582         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
3583         to this source file instead of in the header.
3584         (raiseTypeErrorException): Updated for name change.
3585         (raiseNotSupportedErrorException): Added.
3586
3587 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
3588
3589         Hovering over a slotted Text node clears hover state
3590         https://bugs.webkit.org/show_bug.cgi?id=164002
3591         <rdar://problem/29040471>
3592
3593         Reviewed by Simon Fraser.
3594
3595         * WebView/WebImmediateActionController.mm:
3596         (-[WebImmediateActionController performHitTestAtPoint:]):
3597
3598 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>