Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit...
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-12-19  David Kilzer  <ddkilzer@apple.com>
2
3         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
4         <http://webkit.org/b/139463>
5
6         Reviewed by Mark Rowe.
7
8         * Configurations/Base.xcconfig:
9         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
10           on OS X.
11         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
12         * Configurations/DebugRelease.xcconfig:
13         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
14         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
15         * Configurations/Version.xcconfig:
16         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
17         * Configurations/WebKitLegacy.xcconfig:
18         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
19           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
20           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
21           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
22           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
23           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
24           WEBCORE_PRIVATE_HEADERS_DIR_Production and
25           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
26           based on SDK.
27         - Fix PRODUCTION_ROOT to actually be set properly.
28         - Simplify EXPORTED_SYMBOLS_FILE_i386.
29
30         * migrate-headers.sh:
31         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
32         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
33           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
34           WebKitLegacy.xcconfig.
35
36 2014-12-18  Andreas Kling  <akling@apple.com>
37
38         Ref-ify various Document-related things.
39         <https://webkit.org/b/139796>
40
41         Reviewed by Anders Carlsson.
42
43         * WebView/WebFrame.mm:
44         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
45
46 2014-12-18  Beth Dakin  <bdakin@apple.com>
47
48         Need to re-enable action menus
49         https://bugs.webkit.org/show_bug.cgi?id=139795
50         -and corresponding-
51         rdar://problem/19299367
52
53         Reviewed by Tim Horton.
54
55         Re-enable the menus by un-commenting the code to create the menu and controller.
56         * WebView/WebView.mm:
57         (-[WebView _commonInitializationWithFrameName:groupName:]):
58
59 2014-12-16  Sam Weinig  <sam@webkit.org>
60
61         Unify the Mac and iOS implementations of FontPlatformData a bit
62         https://bugs.webkit.org/show_bug.cgi?id=139721
63
64         Reviewed by Anders Carlsson.
65
66         * WebView/WebHTMLView.mm:
67         (fontNameForDescription):
68         Update for new function name.
69
70 2014-12-18  Antti Koivisto  <antti@apple.com>
71
72         Remove alwaysUseBaselineOfPrimaryFont setting
73         https://bugs.webkit.org/show_bug.cgi?id=139770
74
75         Reviewed by Anders Carlsson.
76
77         * WebView/WebPreferenceKeysPrivate.h:
78         * WebView/WebPreferences.mm:
79         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
80         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
81         * WebView/WebPreferencesPrivate.h:
82         * WebView/WebView.mm:
83         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
84         (-[WebView _preferencesChanged:]):
85
86 2014-12-17  Andreas Kling  <akling@apple.com>
87
88         Ref-ify Range::create().
89         <https://webkit.org/b/139755>
90
91         Reviewed by Anders Carlsson.
92
93         * WebView/WebHTMLRepresentation.mm:
94         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
95         * WebView/WebHTMLView.mm:
96         (-[WebHTMLView attributedString]):
97
98 2014-12-17  Anders Carlsson  <andersca@apple.com>
99
100         Unify -[WebResource description]
101         https://bugs.webkit.org/show_bug.cgi?id=139762
102
103         Reviewed by Dan Bernstein.
104
105         * WebView/WebResource.mm:
106         (-[WebResource description]):
107
108 2014-12-17  Anders Carlsson  <andersca@apple.com>
109
110         Get rid of an ugly #define hack in WebFrameLoaderClient
111         https://bugs.webkit.org/show_bug.cgi?id=139761
112
113         Reviewed by Dan Bernstein.
114
115         Also replace @private with @package in all public headers, for consistency.
116
117         * History/WebBackForwardList.h:
118         * History/WebHistory.h:
119         * Misc/WebDownload.h:
120         * WebCoreSupport/WebFrameLoaderClient.mm:
121         * WebView/WebArchive.h:
122         * WebView/WebDataSource.h:
123         * WebView/WebFrame.h:
124         * WebView/WebFrameView.h:
125         * WebView/WebPreferences.h:
126         * WebView/WebResource.h:
127
128 2014-12-17  Dan Bernstein  <mitz@apple.com>
129
130         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
131         https://bugs.webkit.org/show_bug.cgi?id=139760
132
133         Reviewed by Anders Carlsson.
134
135         * Configurations/WebKitLegacy.xcconfig:
136
137 2014-12-17  Andreas Kling  <akling@apple.com>
138
139         Purge PassRefPtr from Frame.
140         <https://webkit.org/b/139731>
141
142         Reviewed by Anders Carlsson.
143
144         * WebCoreSupport/WebFrameLoaderClient.mm:
145         (WebFrameLoaderClient::transitionToCommittedForNewPage):
146         * WebView/WebFrame.mm:
147         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
148         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
149         * WebView/WebFrameInternal.h:
150
151 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
152
153         Implement and adopt two new TextIndicator presentation animations
154         https://bugs.webkit.org/show_bug.cgi?id=139715
155         <rdar://problem/19237945>
156
157         Reviewed by Anders Carlsson.
158
159         * WebView/WebActionMenuController.mm:
160         (-[WebActionMenuController _showTextIndicator]):
161         * WebView/WebHTMLView.mm:
162         (-[WebHTMLView quickLookWithEvent:]):
163         Remove the completionHandler from text indicator presentation.
164
165         * WebView/WebImmediateActionController.mm:
166         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
167         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
168         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
169         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
170         (-[WebImmediateActionController _menuItemForDataDetectedText]):
171         (-[WebImmediateActionController _animationControllerForText]):
172         (-[WebImmediateActionController _showTextIndicator]):
173         Forward immediate action gesture recognizer animation progress
174         to TextIndicator. Force us to keep the selection when immediate
175         action popovers steal first responder status from the WebView.
176         If the Lookup range is equal to the selection range, use a Crossfade
177         animation; otherwise, use a FadeIn animation.
178
179         * WebView/WebView.mm:
180         (-[WebView _setMaintainsInactiveSelection:]):
181         (-[WebView maintainsInactiveSelection]):
182         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
183         (-[WebView _setTextIndicator:fadeOut:]):
184         (-[WebView _clearTextIndicator]):
185         (-[WebView _setTextIndicatorAnimationProgress:]):
186         (-[WebView _showDictionaryLookupPopup:]):
187         (-[WebView _dictionaryLookupPopoverWillClose:]):
188         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
189         Remove the completionHandler from text indicator presentation.
190         Add a _setMaintainsInactiveSelection, which allows WebKit internals
191         to change the return value of -maintainsInactiveSelection, allowing
192         us to keep the selection alive when the WebView loses first responder status.
193
194         * WebView/WebViewData.h:
195         * WebView/WebViewInternal.h:
196
197 2014-12-16  Andreas Kling  <akling@apple.com>
198
199         Use Ref for SecurityOrigin.
200         <https://webkit.org/b/139710>
201
202         Reviewed by Anders Carlsson.
203
204         * Storage/WebStorageTrackerClient.mm:
205         (WebStorageTrackerClient::dispatchDidModifyOrigin):
206         * WebView/WebView.mm:
207         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
208         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
209
210 2014-12-16  Beth Dakin  <bdakin@apple.com>
211
212         Crash getting default animation controller for some text
213         https://bugs.webkit.org/show_bug.cgi?id=139712
214         -and corresponding-
215         rdar://problem/19271707
216
217         Reviewed by Tim Horton.
218
219         Must null-check the range.
220         * WebView/WebImmediateActionController.mm:
221         (-[WebImmediateActionController _animationControllerForText]):
222
223 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
224
225         Immediate action popovers can get stuck open
226         https://bugs.webkit.org/show_bug.cgi?id=139709
227         <rdar://problem/19270279>
228
229         Reviewed by Beth Dakin.
230
231         * WebView/WebImmediateActionController.mm:
232         (-[WebImmediateActionController _clearImmediateActionState]):
233         Don't clear the animation controller; it breaks things and was unnecessary.
234
235 2014-12-16  Tim Horton  <timothy_horton@apple.com>
236
237         Disable TextIndication for Lookup immediate actions
238         https://bugs.webkit.org/show_bug.cgi?id=139684
239
240         Reviewed by Anders Carlsson.
241
242         * WebView/WebView.mm:
243         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
244
245 2014-12-15  Beth Dakin  <bdakin@apple.com>
246
247         Build fix.
248
249         * WebView/WebImmediateActionController.mm:
250
251 2014-12-15  Beth Dakin  <bdakin@apple.com>
252
253         Speculative build fix.
254
255         * WebView/WebView.mm:
256         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
257         * WebView/WebViewInternal.h:
258
259 2014-12-15  Beth Dakin  <bdakin@apple.com>
260
261         Make lookup an immediate action instead of an action menu item
262         https://bugs.webkit.org/show_bug.cgi?id=139661
263         -and corresponding-
264         rdar://problem/19198414
265
266         Reviewed by Tim Horton.
267
268         Remove the lookup menu items and non-unused static function associated with 
269         lookup.
270         * WebView/WebActionMenuController.mm:
271         (-[WebActionMenuController _defaultMenuItemsForText]):
272         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
273         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
274         (-[WebActionMenuController _createActionMenuItemForTag:]):
275         (-[WebActionMenuController _lookupText:]): Deleted.
276         (performDictionaryLookupForSelection): Deleted.
277         (performDictionaryLookupForRange): Deleted.
278
279         Set the defaultAnimationController to the lookup-provided animation controller 
280         when appropriate.
281         * WebView/WebImmediateActionController.mm:
282         (-[WebImmediateActionController _defaultAnimationController]):
283         (dictionaryPopupInfoForRange):
284         (-[WebImmediateActionController _animationControllerForText]):
285
286         New type.
287         * WebView/WebUIDelegatePrivate.h:
288
289         New function to get the lookup animation controller.
290         * WebView/WebView.mm:
291         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
292         * WebView/WebViewInternal.h:
293
294 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
295
296         Implement Data Detectors immediate actions for Legacy WebKit
297         https://bugs.webkit.org/show_bug.cgi?id=139619
298         <rdar://problem/19198539>
299
300         Reviewed by Beth Dakin.
301
302         * WebView/WebImmediateActionController.mm:
303         (-[WebImmediateActionController _menuItemForDataDetectedText]):
304         Note that this action context is only for immediate actions.
305
306 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
307
308         Addressing post-review comments in r177035
309         https://bugs.webkit.org/show_bug.cgi?id=139557
310
311         Reviewed by Darin Adler.
312
313         * WebView/WebActionMenuController.mm:
314         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
315
316 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
317
318         Implement Data Detectors immediate actions for Legacy WebKit
319         https://bugs.webkit.org/show_bug.cgi?id=139619
320         <rdar://problem/19198539>
321
322         Reviewed by Eric Carlson.
323
324         * WebView/WebHTMLView.mm:
325         (-[WebHTMLView mouseDown:mouseDown:]):
326         Send mouseDown along to the WebImmediateActionController too.
327
328         * WebView/WebImmediateActionController.h:
329         * WebView/WebImmediateActionController.mm:
330         (-[WebImmediateActionController webViewClosed]):
331         (-[WebImmediateActionController webView:willHandleMouseDown:]):
332         (-[WebImmediateActionController _cancelImmediateAction]):
333         (-[WebImmediateActionController _clearImmediateActionState]):
334         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
335         (-[WebImmediateActionController _defaultAnimationController]):
336         (-[WebImmediateActionController _updateImmediateActionItem]):
337         (-[WebImmediateActionController _menuItemForDataDetectedText]):
338         (-[WebImmediateActionController _showTextIndicator]):
339         (-[WebImmediateActionController _hideTextIndicator]):
340         Copy most of the DataDetectors implementation into WebImmediateActionController.
341
342         * WebView/WebUIDelegatePrivate.h:
343         Add a new type.
344
345         * WebView/WebView.mm:
346         (-[WebView _commonInitializationWithFrameName:groupName:]):
347         Temporarily disable action menus.
348
349         (-[WebView _immediateActionController]):
350         * WebView/WebViewInternal.h:
351
352 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
353
354         Delete Notation because we don't use it
355         https://bugs.webkit.org/show_bug.cgi?id=139171
356
357         Reviewed by Kent Tamura.
358
359         * MigrateHeaders.make:
360
361 2014-12-14  Andreas Kling  <akling@apple.com>
362
363         Replace PassRef with Ref/Ref&& across the board.
364         <https://webkit.org/b/139587>
365
366         Reviewed by Darin Adler.
367
368         * WebCoreSupport/WebEditorClient.mm:
369         (WebEditorClient::shouldApplyStyle):
370         * WebCoreSupport/WebVisitedLinkStore.h:
371         * WebCoreSupport/WebVisitedLinkStore.mm:
372         (WebVisitedLinkStore::create):
373
374 2014-12-11  Dan Bernstein  <mitz@apple.com>
375
376         Fix a leak introduced in r177199.
377
378         Reviewed by Anders Carlsson.
379
380         * WebView/WebImmediateActionController.mm:
381         (-[WebImmediateActionController _updateImmediateActionItem]):
382
383 2014-12-11  Beth Dakin  <bdakin@apple.com>
384
385         WK1: Need new SPI for Webkit clients to override default immediate action
386         https://bugs.webkit.org/show_bug.cgi?id=139568
387         -and corresponding-
388         rdar://problem/19225448
389
390         Reviewed by Dan Bernstein.
391
392         Call SPI giving clients a chance to override the default behavior.
393         * WebView/WebImmediateActionController.mm:
394         (-[WebImmediateActionController _updateImmediateActionItem]):
395
396         New SPI.
397         * WebView/WebUIDelegatePrivate.h:
398
399 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
400
401         Move the preview popover to WebImmediateActionController
402         https://bugs.webkit.org/show_bug.cgi?id=139563
403         <rdar://problem/19208291>
404
405         Reviewed by Beth Dakin.
406
407         * WebView/WebActionMenuController.mm:
408         (-[WebActionMenuController _defaultMenuItemsForLink]):
409         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
410         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
411         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
412         * WebView/WebImmediateActionController.h:
413         * WebView/WebImmediateActionController.mm:
414         (-[WebImmediateActionController webViewClosed]):
415         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
416         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
417         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
418         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
419         (-[WebImmediateActionController _updateImmediateActionItem]):
420         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
421         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
422         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
423         Move page preview popover related code to WebImmediateActionController.
424
425         * WebView/WebUIDelegatePrivate.h:
426         Add a link preview type.
427
428         * WebView/WebView.mm:
429         (-[WebView _commonInitializationWithFrameName:groupName:]):
430         Pass the gesture recognizer to the WebImmediateActionController.
431
432 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
433
434         Fix the build.
435
436         * WebView/WebImmediateActionController.h:
437         * WebView/WebImmediateActionController.mm:
438
439 2014-12-11  Anders Carlsson  <andersca@apple.com>
440
441         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
442         https://bugs.webkit.org/show_bug.cgi?id=139547
443
444         Reviewed by Sam Weinig.
445
446         * WebView/WebView.mm:
447         (+[WebView _handleMemoryWarning]):
448
449 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
450
451         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
452         https://bugs.webkit.org/show_bug.cgi?id=139504
453         rdar://problem/19034674
454
455         Reviewed by Enrica Casucci.
456
457         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
458
459         * WebCoreSupport/WebEditorClient.h:
460         * WebCoreSupport/WebEditorClient.mm:
461         (WebEditorClient::discardedComposition):
462
463 2014-12-10  Anders Carlsson  <andersca@apple.com>
464
465         Get rid of the storage strategy
466         https://bugs.webkit.org/show_bug.cgi?id=139519
467
468         Reviewed by Antti Koivisto.
469
470         * WebCoreSupport/WebPlatformStrategies.h:
471         * WebCoreSupport/WebPlatformStrategies.mm:
472         (WebPlatformStrategies::createStorageStrategy): Deleted.
473
474 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
475
476         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
477         https://bugs.webkit.org/show_bug.cgi?id=139529
478         <rdar://problem/19213620>
479
480         Reviewed by Beth Dakin.
481
482         * WebView/WebActionMenuController.mm:
483         (-[WebActionMenuController _copySelection:]):
484         (-[WebActionMenuController _paste:]):
485         Use the copy: and paste: methods on WebView so that we traverse subviews
486         when trying to respond, otherwise these actions don't work in subframes.
487
488 2014-12-10  Beth Dakin  <bdakin@apple.com>
489
490         WK1: Add initial support for immediate actions
491         https://bugs.webkit.org/show_bug.cgi?id=139522
492
493         Reviewed by Dan Bernstein.
494
495         This basic implementation of the controller will use the delegate methods to 
496         perform and cache a HitTest when relevant. Future patches will patch 
497         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
498         immediate action that should be taken.
499         * WebView/WebImmediateActionController.h: Added.
500         * WebView/WebImmediateActionController.mm: Added.
501         (-[WebImmediateActionController webViewClosed]):
502         (-[WebImmediateActionController _clearImmediateActionState]):
503         (-[WebImmediateActionController performHitTestAtPoint:]):
504         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
505         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
506         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
507         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
508         (-[WebImmediateActionController _updateImmediateActionItem]):
509
510         New enum for immediate action types.
511         * WebView/WebUIDelegatePrivate.h:
512
513         Create an NSImmediateActionGestureRecognizer if possible and a controller.
514         * WebView/WebView.mm:
515         (-[WebView _commonInitializationWithFrameName:groupName:]):
516         (-[WebView _close]):
517         * WebView/WebViewData.h:
518         * WebView/WebViewData.mm:
519         (-[WebViewPrivate dealloc]):
520
521 2014-12-08  Anders Carlsson  <andersca@apple.com>
522
523         Use the new storage namespace provider in WebKit1
524         https://bugs.webkit.org/show_bug.cgi?id=139425
525
526         Reviewed by Tim Horton.
527
528         * WebView/WebView.mm:
529         (-[WebView _commonInitializationWithFrameName:groupName:]):
530         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
531         Set the storage namespace provider from the web page group.
532
533 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
534
535         Should have copy and paste items in all text menus
536         https://bugs.webkit.org/show_bug.cgi?id=139510
537         <rdar://problem/19198388>
538
539         Reviewed by Beth Dakin.
540
541         * WebView/WebActionMenuController.mm:
542         (-[WebActionMenuController _defaultMenuItemsForText]):
543         Add a disabled paste menu item into the read-only text menu.
544
545         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
546         Add a disabled copy menu item into the editable whitespace text menu.
547
548 2014-12-10  Anders Carlsson  <andersca@apple.com>
549
550         Add WebStorageNamespaceProvider::closeLocalStorage
551         https://bugs.webkit.org/show_bug.cgi?id=139502
552
553         Reviewed by Tim Horton.
554
555         * WebView/WebView.mm:
556         (+[WebView _applicationWillTerminate]):
557         Call WebStorageNamespaceProvider::closeLocalStorage.
558
559 2014-12-09  Commit Queue  <commit-queue@webkit.org>
560
561         Unreviewed, rolling out r177037.
562         https://bugs.webkit.org/show_bug.cgi?id=139464
563
564         broke ~50 API tests (Requested by thorton on #webkit).
565
566         Reverted changeset:
567
568         "Use the new storage namespace provider in WebKit1"
569         https://bugs.webkit.org/show_bug.cgi?id=139425
570         http://trac.webkit.org/changeset/177037
571
572 2014-12-08  Anders Carlsson  <andersca@apple.com>
573
574         Use the new storage namespace provider in WebKit1
575         https://bugs.webkit.org/show_bug.cgi?id=139425
576
577         Reviewed by Tim Horton.
578
579         * WebView/WebView.mm:
580         (-[WebView _commonInitializationWithFrameName:groupName:]):
581         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
582         Set the storage namespace provider from the web page group.
583
584 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
585
586         Delete Node::boundingBox()
587         https://bugs.webkit.org/show_bug.cgi?id=139333
588
589         Reviewed by Zalan Bujtas.
590
591         * WebView/WebActionMenuController.mm:
592         (elementBoundingBoxInWindowCoordinatesFromNode): Use
593         RenderObject::absoluteBoundingBoxRect().
594
595 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
596
597         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
598         https://bugs.webkit.org/show_bug.cgi?id=138843
599         rdar://problem/18793695
600
601         Reviewed by Dan Bernstein.
602
603         * Panels/WebAuthenticationPanel.m:
604         (-[WebAuthenticationPanel cancel:]):
605         (-[WebAuthenticationPanel logIn:]):
606         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
607         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
608         that only when using an old NSWindow API.
609
610 2014-12-08  Beth Dakin  <bdakin@apple.com>
611
612         Copy and Lookup menu items should be disabled when something is not copyable
613         https://bugs.webkit.org/show_bug.cgi?id=139423
614
615         Reviewed by Tim Horton.
616
617         Disable both lookup and copy when a HitTestResult does not allow copy.
618         * WebView/WebActionMenuController.mm:
619
620         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
621         disable state otherwise.
622         * WebView/WebView.mm:
623         (-[WebView _commonInitializationWithFrameName:groupName:]):
624
625 2014-12-08  Anders Carlsson  <andersca@apple.com>
626
627         Adding user content to a group should force that group to be created
628         https://bugs.webkit.org/show_bug.cgi?id=139421
629         rdar://problem/19180108
630
631         Reviewed by Sam Weinig.
632
633         * WebCoreSupport/WebViewGroup.h:
634         Store the local storage database path in the group.
635
636         * WebCoreSupport/WebViewGroup.mm:
637         (WebViewGroup::getOrCreate):
638         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
639         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
640
641         (WebViewGroup::WebViewGroup):
642         Initialize the new member variable.
643
644         (WebViewGroup::storageNamespaceProvider):
645         Create the namespace provider lazily.
646
647         * WebView/WebView.mm:
648         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
649         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
650         Use getOrCreate instead of get.
651
652 2014-12-08  Anders Carlsson  <andersca@apple.com>
653
654         WebStorageNamespaceProvider should know about its local storage database path
655         https://bugs.webkit.org/show_bug.cgi?id=139413
656
657         Reviewed by Andreas Kling.
658
659         * WebCoreSupport/WebViewGroup.h:
660         * WebCoreSupport/WebViewGroup.mm:
661         (WebViewGroup::getOrCreate):
662         (WebViewGroup::WebViewGroup):
663         * WebView/WebView.mm:
664         (-[WebView _commonInitializationWithFrameName:groupName:]):
665         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
666         (-[WebView setGroupName:]):
667         (-[WebView groupName]): Deleted.
668
669 2014-12-08  Daniel Bates  <dabates@apple.com>
670
671         [iOS] Fix the WebKit build with the public SDK
672
673         Include header NSURLDownloadSPI.h.
674
675         * WebCoreSupport/WebFrameLoaderClient.mm:
676
677 2014-12-07  Dan Bernstein  <mitz@apple.com>
678
679         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
680         https://bugs.webkit.org/show_bug.cgi?id=139348
681
682         Reviewed by Anders Carlsson.
683
684         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
685         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
686         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
687         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
688         avoiding the ambiguity.
689
690         * WebView/WebActionMenuController.mm:
691         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
692
693 2014-12-06  Anders Carlsson  <andersca@apple.com>
694
695         Add a stubbed out version of WebStorageNamespaceProvider
696         https://bugs.webkit.org/show_bug.cgi?id=139213
697
698         Reviewed by Sam Weinig.
699
700         * WebCoreSupport/WebViewGroup.h:
701         (WebViewGroup::storageNamespaceProvider):
702         * WebCoreSupport/WebViewGroup.mm:
703         (WebViewGroup::getOrCreate):
704         (WebViewGroup::WebViewGroup):
705         Give WebViewGroup a storage namespace provider.
706
707 2014-12-06  Anders Carlsson  <andersca@apple.com>
708
709         Fix build with newer versions of clang.
710         rdar://problem/18978687
711
712         Add missing overrides and missing casts.
713
714         * Storage/WebDatabaseManagerClient.h:
715         * Storage/WebStorageTrackerClient.h:
716         * WebCoreSupport/WebChromeClient.h:
717         * WebCoreSupport/WebFrameLoaderClient.h:
718         * WebCoreSupport/WebInspectorClient.h:
719         * WebView/WebDataSource.mm:
720         (-[WebDataSource _makeRepresentation]):
721         * WebView/WebFrameView.mm:
722         (-[WebFrameView _makeDocumentViewForDataSource:]):
723
724 2014-12-05  Tim Horton  <timothy_horton@apple.com>
725
726         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
727         https://bugs.webkit.org/show_bug.cgi?id=139306
728         <rdar://problem/19157955>
729
730         Reviewed by Beth Dakin.
731
732         * WebView/WebView.mm:
733         (-[WebView _commonInitializationWithFrameName:groupName:]):
734         (-[WebView _initWithFrame:frameName:groupName:]):
735         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
736
737 2014-12-05  David Kilzer  <ddkilzer@apple.com>
738
739         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
740         <http://webkit.org/b/139286>
741
742         Reviewed by Daniel Bates.
743
744         * Configurations/FeatureDefines.xcconfig: Switch back to using
745         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
746
747 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
748
749         Fix the 32-bit build.
750
751         * WebView/WebView.mm:
752         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
753
754 2014-12-04  Tim Horton  <timothy_horton@apple.com>
755
756         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
757         https://bugs.webkit.org/show_bug.cgi?id=139252
758         <rdar://problem/19140827>
759
760         Reviewed by Anders Carlsson.
761
762         * WebView/WebView.mm:
763         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
764         Adjust to the WebCore changes.
765
766 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
767
768         Implement action menus for tel: URLs
769         https://bugs.webkit.org/show_bug.cgi?id=139240
770         <rdar://problem/19115662>
771
772         Reviewed by Anders Carlsson.
773
774         * WebView/WebActionMenuController.mm:
775         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
776         Make sure to use the newly created currentActionContext... everywhere.
777
778 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
779
780         Implement action menus for tel: URLs
781         https://bugs.webkit.org/show_bug.cgi?id=139240
782         <rdar://problem/19115662>
783
784         Reviewed by Anders Carlsson.
785
786         * WebView/WebActionMenuController.mm:
787         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
788         Make sure to use the newly created currentActionContext.
789
790 2014-12-03  Beth Dakin  <bdakin@apple.com>
791
792         <input> elements get whitespace action menu instead of editable text menu
793         https://bugs.webkit.org/show_bug.cgi?id=139241
794         -and corresponding-
795         rdar://problem/19072083
796
797         Reviewed by Sam Weinig.
798
799         We should disallow shadow content in the hit test. This is the default and it is 
800         how context menus behave. We originally wanted to text inside shadow content so 
801         that we could find the text, but the new function I added to HitTestResult will 
802         allow that.
803         * WebView/WebActionMenuController.mm:
804         (-[WebActionMenuController performHitTestAtPoint:]):
805
806         Adjust to the fact that we don’t hit test shadow content any more.
807         (-[WebActionMenuController focusAndSelectHitTestResult]):
808
809         Offer the text menus for text inside form controls.
810         (-[WebActionMenuController _defaultMenuItems]):
811
812 2014-12-03  Tim Horton  <timothy_horton@apple.com>
813
814         Implement action menus for tel: URLs
815         https://bugs.webkit.org/show_bug.cgi?id=139240
816         <rdar://problem/19115662>
817
818         Reviewed by Anders Carlsson.
819
820         * WebView/WebActionMenuController.mm:
821         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
822         Rename this function as it will work for both mailto and tel URLs.
823         Adjust it to use contextForView:.
824
825         (-[WebActionMenuController webView:willHandleMouseDown:]):
826         (-[WebActionMenuController prepareForMenu:withEvent:]):
827         (-[WebActionMenuController didCloseMenu:withEvent:]):
828         (-[WebActionMenuController _defaultMenuItems]):
829         Don't check the menu type when going to interact with _currentActionContext.
830         We'll only have a _currentActionContext if we have a data detected item,
831         and there are multiple menu types that end up using DDActionContext.
832
833         * WebView/WebUIDelegatePrivate.h:
834         Add a new type.
835
836 2014-12-03  Anders Carlsson  <andersca@apple.com>
837
838         Set a visited link store when creating a simple WebView
839         https://bugs.webkit.org/show_bug.cgi?id=139234
840         <rdar://problem/19132978>
841
842         Reviewed by Sam Weinig.
843
844         * WebView/WebView.mm:
845         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
846
847 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
848
849         Fix the build.
850
851         * WebCoreSupport/WebFrameLoaderClient.mm:
852
853 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
854
855         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
856         https://bugs.webkit.org/show_bug.cgi?id=139149
857
858         Reviewed by Anders Carlsson.
859
860         This changes API behavior. I think that it's OK, because existing behavior made no sense.
861         We used to delete caches from disk, but they were still active in memory. Now we also
862         obsolete them in memory, so documents that use a cache still work, but new ones don't
863         pick one up.
864
865         * WebCoreSupport/WebApplicationCache.mm:
866         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
867         need to delete in-momry caches too. Keep existing behavior.
868         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
869         that properly deletes caches.
870
871 2014-12-02  Tim Horton  <timothy_horton@apple.com>
872
873         Remove a SnowLeopard-era quirk for QuickLook
874         https://bugs.webkit.org/show_bug.cgi?id=139208
875         <rdar://problem/19121822>
876
877         Reviewed by Alexey Proskuryakov.
878
879         * WebCoreSupport/WebFrameLoaderClient.h:
880         * WebCoreSupport/WebFrameLoaderClient.mm:
881
882 2014-12-02  Tim Horton  <timothy_horton@apple.com>
883
884         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
885         https://bugs.webkit.org/show_bug.cgi?id=139204
886
887         Reviewed by Anders Carlsson.
888
889         * WebView/WebView.mm:
890         (-[WebView _commonInitializationWithFrameName:groupName:]):
891         (-[WebView _showDictionaryLookupPopup:]):
892         * WebView/WebViewData.h:
893         Work around this by delaying the softlinking (and setting up the notification
894         observer) until we actually need it. There's still an underlying bug, but
895         this will fix the test.
896
897 2014-12-02  Beth Dakin  <bdakin@apple.com>
898
899         Yet another build fix.
900
901         * WebView/WebActionMenuController.mm:
902         (-[WebActionMenuController _defaultMenuItemsForLink]):
903
904 2014-12-02  Beth Dakin  <bdakin@apple.com>
905
906         Build fix.
907
908         * WebView/WebActionMenuController.mm:
909         (-[WebActionMenuController _defaultMenuItemsForLink]):
910
911 2014-12-02  Beth Dakin  <bdakin@apple.com>
912
913         More build fixing.
914
915         * WebView/WebActionMenuController.mm:
916         (-[WebActionMenuController _defaultMenuItemsForLink]):
917
918 2014-12-02  Beth Dakin  <bdakin@apple.com>
919
920         Should use standardQuickLookMenuItem for apps that don't implement customizations
921         https://bugs.webkit.org/show_bug.cgi?id=139193
922         -and corresponding-
923         rdar://problem/18944696
924
925         Reviewed by Anders Carlsson.
926
927         Use [NSMenuItem standardQuickLookMenuItem].
928         * WebView/WebActionMenuController.mm:
929         (-[WebActionMenuController _defaultMenuItemsForLink]):
930
931         Delegate methods to set up the standardQuickLookMenuItem.
932         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
933         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
934         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
935
936         Remove all of the old QLPreviewBubble code.
937         (-[WebActionMenuController _createActionMenuItemForTag:]):
938         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
939
940 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
941
942         Fix the build.
943
944         * WebView/WebViewData.h:
945
946 2014-12-02  Tim Horton  <timothy_horton@apple.com>
947
948         Implement Lookup transition from selection for Legacy WebKit
949         https://bugs.webkit.org/show_bug.cgi?id=139180
950         <rdar://problem/19067172>
951
952         Reviewed by Beth Dakin.
953
954         * WebView/DictionaryPopupInfo.h: Added.
955         Split DictionaryPopupInfo out into its own file.
956
957         * WebView/WebActionMenuController.mm:
958         (-[WebActionMenuController _lookupText:]):
959         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
960
961         (performDictionaryLookupForSelection):
962         (performDictionaryLookupForRange):
963         Plumb the transition style through these helpers.
964         Create a TextIndicator from the selection range.
965
966         * WebView/WebHTMLView.mm:
967         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
968         Make use of TextIndicator (and DictionaryPopupInfo, and the new
969         _showDictionaryLookupPopup on WebView) to add a transition from blue
970         when performing Lookup from the context menu.
971
972         (-[WebHTMLView quickLookWithEvent:]):
973         Remove our TextIndicator whenever a normal three-finger-tap event
974         comes through, as it will have its own indication.
975
976         * WebView/WebView.mm:
977         (-[WebView _commonInitializationWithFrameName:groupName:]):
978         (-[WebView _dictionaryLookupPopoverWillClose:]):
979         Register for the LUNotificationPopoverWillClose notification and remove
980         our TextIndicator when it is called, just like in WebKit2.
981         Deregistration is already handled in _close.
982
983         (-[WebView _showDictionaryLookupPopup:]):
984         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
985         if the relevant API is available.
986
987         * WebView/WebViewInternal.h:
988
989 2014-12-02  Anders Carlsson  <andersca@apple.com>
990
991         Remove visited link handling from PageGroup
992         https://bugs.webkit.org/show_bug.cgi?id=139185
993
994         Reviewed by Sam Weinig.
995
996         * History/WebHistory.mm:
997         (-[WebHistoryPrivate removeItemForURLString:]):
998         (-[WebHistoryPrivate removeAllItems]):
999         (+[WebHistory setOptionalSharedHistory:]):
1000         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1001         (+[WebHistory _removeAllVisitedLinks]):
1002         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1003         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1004         * History/WebHistoryInternal.h:
1005         * WebCoreSupport/WebChromeClient.h:
1006         * WebCoreSupport/WebChromeClient.mm:
1007         (WebChromeClient::populateVisitedLinks): Deleted.
1008         * WebView/WebView.mm:
1009         (-[WebView addVisitedLinks:]):
1010         (-[WebView removeVisitedLink:]):
1011
1012 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1013
1014         Try to fix the Mac build.
1015
1016         * WebView/WebView.mm:
1017         (-[WebView _commonInitializationWithFrameName:groupName:]):
1018         (-[WebView _close]):
1019
1020 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1021
1022         Fix the iOS build.
1023
1024         * WebView/WebActionMenuController.h:
1025         * WebView/WebActionMenuController.mm:
1026         * WebView/WebHTMLView.mm:
1027         (-[WebHTMLView scrollWheel:scrollWheel:]):
1028         (-[WebHTMLView mouseDown:mouseDown:]):
1029         * WebView/WebView.mm:
1030         * WebView/WebViewData.h:
1031         * WebView/WebViewData.mm:
1032         (-[WebViewPrivate dealloc]):
1033         * WebView/WebViewInternal.h:
1034
1035 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1036
1037         Implement yellow highlight for WebKit1 data detectors
1038         https://bugs.webkit.org/show_bug.cgi?id=138956
1039         <rdar://problem/18992185>
1040
1041         Reviewed by Beth Dakin.
1042
1043         * WebView/WebActionMenuController.h:
1044         * WebView/WebActionMenuController.mm:
1045         (-[WebActionMenuController webView:willHandleMouseDown:]):
1046         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1047         (-[WebActionMenuController prepareForMenu:withEvent:]):
1048         (-[WebActionMenuController didCloseMenu:withEvent:]):
1049         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1050         (-[WebActionMenuController _showTextIndicator]):
1051         (-[WebActionMenuController _hideTextIndicator]):
1052         (-[WebActionMenuController _dismissActionMenuPopovers]):
1053         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1054         into WebActionMenuController. The only significant difference is
1055         that we build the TextIndicator right at menu construction time
1056         instead of in the Web process.
1057
1058         * WebView/WebHTMLView.mm:
1059         (-[WebHTMLView scrollWheel:]):
1060         Let the WebActionMenuController know that we're handling a scroll.
1061
1062         (-[WebHTMLView mouseDown:]):
1063         Let the WebActionMenuController know that we're handling a mouseDown.
1064
1065         * WebView/WebView.mm:
1066         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1067         (-[WebView _clearTextIndicator]):
1068         (-[WebView _actionMenuController]):
1069         (-[WebView _convertRectFromRootView:]): Deleted.
1070         * WebView/WebViewData.h:
1071         * WebView/WebViewData.mm:
1072         * WebView/WebViewInternal.h:
1073         Keep a TextIndicatorWindow on WebView, just like WKView does.
1074         Expose the WebActionMenuController on WebView (internally).
1075
1076 2014-12-01  Anders Carlsson  <andersca@apple.com>
1077
1078         Remove old site specific quirks code that was added in 2009
1079         https://bugs.webkit.org/show_bug.cgi?id=139141
1080
1081         Reviewed by Antti Koivisto.
1082
1083         * WebCoreSupport/WebFrameNetworkingContext.h:
1084         * WebCoreSupport/WebFrameNetworkingContext.mm:
1085         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1086
1087 2014-11-30  Anders Carlsson  <andersca@apple.com>
1088
1089         Fix a test failure.
1090
1091         * History/WebHistory.mm:
1092         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1093         Call through to the visited link store.
1094
1095         (+[WebHistory _removeAllVisitedLinks]):
1096         Ditto.
1097
1098         * WebCoreSupport/WebVisitedLinkStore.mm:
1099         (WebVisitedLinkStore::isLinkVisited):
1100         Make sure to populate visited links.
1101
1102 2014-11-30  Anders Carlsson  <andersca@apple.com>
1103
1104         Switch over to the visited link store from the WebViewGroup
1105         https://bugs.webkit.org/show_bug.cgi?id=139112
1106
1107         Reviewed by Sam Weinig.
1108
1109         * WebView/WebView.mm:
1110         (-[WebView _commonInitializationWithFrameName:groupName:]):
1111         (-[WebView setGroupName:]):
1112
1113 2014-11-30  Anders Carlsson  <andersca@apple.com>
1114
1115         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1116         https://bugs.webkit.org/show_bug.cgi?id=139111
1117
1118         Reviewed by Sam Weinig.
1119
1120         * WebCoreSupport/WebVisitedLinkStore.h:
1121         * WebCoreSupport/WebVisitedLinkStore.mm:
1122         (WebVisitedLinkStore::removeVisitedLink):
1123         * WebView/WebView.mm:
1124         (-[WebView removeVisitedLink:]):
1125
1126 2014-11-29  Anders Carlsson  <andersca@apple.com>
1127
1128         Populate visited links
1129         https://bugs.webkit.org/show_bug.cgi?id=139101
1130
1131         Reviewed by Sam Weinig.
1132
1133         * History/WebHistory.mm:
1134         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1135         Helper function that adds all visited link to the given store.
1136
1137         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1138         Call the private method.
1139
1140         * History/WebHistoryInternal.h:
1141         * WebCoreSupport/WebVisitedLinkStore.h:
1142         Add new members.
1143
1144         * WebCoreSupport/WebVisitedLinkStore.mm:
1145         (WebVisitedLinkStore::addVisitedLink):
1146         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1147
1148         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1149         Implement this. First try the delegate, then try the shared history.
1150
1151         (WebVisitedLinkStore::addVisitedLinkHash):
1152         Factor code that adds the link to the hash table into a separate function.
1153
1154         * WebView/WebView.mm:
1155         (-[WebView addVisitedLinks:]):
1156         Add the visited links to the store.
1157
1158 2014-11-29  Anders Carlsson  <andersca@apple.com>
1159
1160         More work on the legacy WebKit visited link store
1161         https://bugs.webkit.org/show_bug.cgi?id=139100
1162
1163         Reviewed by Sam Weinig.
1164
1165         * History/WebHistory.mm:
1166         (+[WebHistory setOptionalSharedHistory:]):
1167         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1168
1169         * WebCoreSupport/WebVisitedLinkStore.h:
1170         * WebCoreSupport/WebVisitedLinkStore.mm:
1171         (visitedLinkStores):
1172         (WebVisitedLinkStore::WebVisitedLinkStore):
1173         (WebVisitedLinkStore::~WebVisitedLinkStore):
1174         Keep track of live visited link stores.
1175
1176         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1177         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1178
1179         (WebVisitedLinkStore::removeAllVisitedLinks):
1180         Iterate over all live link stores and remove their links.
1181
1182         (WebVisitedLinkStore::isLinkVisited):
1183         Populate visited links and check if our hash table contains the link.
1184
1185         (WebVisitedLinkStore::addVisitedLink):
1186         Add the link hash to the table.
1187
1188         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1189         Add stub.
1190
1191         (WebVisitedLinkStore::removeVisitedLinkHashes):
1192         Clear out the hash table.
1193
1194 2014-11-27  Anders Carlsson  <andersca@apple.com>
1195
1196         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1197         https://bugs.webkit.org/show_bug.cgi?id=139066
1198
1199         Reviewed by Antti Koivisto.
1200
1201         * WebCoreSupport/WebViewGroup.h:
1202         (WebViewGroup::visitedLinkStore):
1203         * WebCoreSupport/WebViewGroup.mm:
1204         (WebViewGroup::WebViewGroup):
1205         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1206         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1207         (WebVisitedLinkStore::create):
1208         (WebVisitedLinkStore::WebVisitedLinkStore):
1209         (WebVisitedLinkStore::~WebVisitedLinkStore):
1210         (WebVisitedLinkStore::isLinkVisited):
1211         (WebVisitedLinkStore::addVisitedLink):
1212
1213 2014-11-25  Anders Carlsson  <andersca@apple.com>
1214
1215         Remove user content handling from PageGroup
1216         https://bugs.webkit.org/show_bug.cgi?id=139051
1217
1218         Reviewed by Antti Koivisto.
1219
1220         Use the user content controller in the web view group.
1221
1222         * WebView/WebView.mm:
1223         (-[WebView _injectOutlookQuirksScript]):
1224
1225 2014-11-25  Anders Carlsson  <andersca@apple.com>
1226
1227         Add a user content controller to WebViewGroup and use it for user content
1228         https://bugs.webkit.org/show_bug.cgi?id=139043
1229
1230         Reviewed by Antti Koivisto.
1231
1232         This is another tiny step towards getting rid of user content handling inside PageGroup.
1233
1234         * WebCoreSupport/WebViewGroup.h:
1235         (WebViewGroup::userContentController):
1236         Add a UserContentController member and getter.
1237
1238         * WebCoreSupport/WebViewGroup.mm:
1239         (WebViewGroup::get):
1240         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1241
1242         (WebViewGroup::WebViewGroup):
1243         Create a user content controller.
1244
1245         * WebView/WebView.mm:
1246         (-[WebView _commonInitializationWithFrameName:groupName:]):
1247         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1248         set its user content controller in the PageConfiguration.
1249
1250         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1251         Ditto.
1252
1253         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1254         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1255         (+[WebView _removeUserScriptFromGroup:world:url:]):
1256         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1257         (+[WebView _removeUserScriptsFromGroup:world:]):
1258         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1259         (+[WebView _removeAllUserContentFromGroup:]):
1260         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1261
1262         (-[WebView setGroupName:]):
1263         Set the user content controller to the new WebViewGroup's user content controller.
1264
1265 2014-11-21  Jer Noble  <jer.noble@apple.com>
1266
1267         Support multiple signatures of diagnostic logging.
1268         https://bugs.webkit.org/show_bug.cgi?id=138690
1269
1270         Reviewed by Anders Carlsson.
1271
1272         Page::PageClients has been renamed PageConfiguration.
1273
1274         * WebView/WebView.mm:
1275         (-[WebView _commonInitializationWithFrameName:groupName:]):
1276         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1277
1278 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1279
1280         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1281         https://bugs.webkit.org/show_bug.cgi?id=138981
1282
1283         Reviewed by Simon Fraser.
1284
1285         * WebView/WebPreferenceKeysPrivate.h:
1286         * WebView/WebPreferences.mm:
1287         (+[WebPreferences initialize]):
1288         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1289         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1290         * WebView/WebPreferencesPrivate.h:
1291         * WebView/WebView.mm:
1292         (-[WebView _preferencesChanged:]):
1293
1294 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1295
1296         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1297         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1298         <rdar://problem/19056715>
1299
1300         Reviewed by Anders Carlsson.
1301
1302         * WebView/WebActionMenuController.mm:
1303         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1304         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1305         Use DataDetectors SPI instead of an explicit blacklist.
1306
1307 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1308
1309         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1310         https://bugs.webkit.org/show_bug.cgi?id=138960
1311         <rdar://problem/19056715>
1312
1313         Reviewed by Beth Dakin.
1314
1315         * WebView/WebActionMenuController.mm:
1316         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1317         Blacklist contact results, because they don't have useful menus. If we
1318         bail before setting up _currentActionContext, we'll still allow fallthrough
1319         to ordinary text actions, avoiding mysterious failure when a contact is detected.
1320
1321         This doesn't break the case that r176351 was intended to fix,
1322         because in that case we were detecting e.g. addresses.
1323
1324 2014-11-21  Anders Carlsson  <andersca@apple.com>
1325
1326         Remove the Timer parameters from timer callbacks
1327         https://bugs.webkit.org/show_bug.cgi?id=138974
1328
1329         Reviewed by Antti Koivisto.
1330
1331         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1332         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1333         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
1334         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
1335         * Plugins/WebNetscapePluginStream.h:
1336         * Plugins/WebNetscapePluginStream.mm:
1337         (WebNetscapePluginStream::WebNetscapePluginStream):
1338         (WebNetscapePluginStream::deliverDataTimerFired):
1339
1340 2014-11-21  Anders Carlsson  <andersca@apple.com>
1341
1342         Make memoryCache() return a reference
1343         https://bugs.webkit.org/show_bug.cgi?id=138939
1344
1345         Reviewed by Antti Koivisto.
1346
1347         * Misc/WebCache.mm:
1348         (+[WebCache statistics]):
1349         (+[WebCache emptyInMemoryResources]):
1350         (+[WebCache sizeOfDeadResources:]):
1351         (+[WebCache addImageToCache:forURL:forFrame:]):
1352         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1353         (+[WebCache imageForURL:]):
1354         (+[WebCache setDisabled:]):
1355         (+[WebCache isDisabled]):
1356         * WebView/WebView.mm:
1357         (+[WebView _setCacheModel:]):
1358
1359 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
1360
1361         Remove the remaining vestiges of minimal-ui
1362         https://bugs.webkit.org/show_bug.cgi?id=138890
1363
1364         Reviewed by Sam Weinig.
1365
1366         * History/WebHistoryItem.mm:
1367         * History/WebHistoryItemPrivate.h:
1368
1369 2014-11-20  Tim Horton  <timothy_horton@apple.com>
1370
1371         Cancel DataDetectors menu earlier if we know it can't be presented
1372         https://bugs.webkit.org/show_bug.cgi?id=138922
1373         <rdar://problem/18950441>
1374
1375         Reviewed by Beth Dakin.
1376
1377         * WebView/WebActionMenuController.mm:
1378         (-[WebActionMenuController prepareForMenu:withEvent:]):
1379         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
1380         and use a bigger hammer (removeAllItems).
1381
1382         (-[WebActionMenuController willOpenMenu:withEvent:]):
1383         If we end up with a menu with no items, don't change selection or anything.
1384
1385 2014-11-20  Beth Dakin  <bdakin@apple.com>
1386
1387         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
1388         https://bugs.webkit.org/show_bug.cgi?id=138568
1389         -and corresponding-
1390         rdar://problem/18904600
1391
1392         Reviewed by Tim Horton.
1393
1394         Skip images for lookup.
1395         * WebView/WebActionMenuController.mm:
1396         (performDictionaryLookupForRange):
1397
1398 2014-11-19  Beth Dakin  <bdakin@apple.com>
1399
1400         Invoking an action menu on a selection should result in the text menu
1401         https://bugs.webkit.org/show_bug.cgi?id=138892
1402         -and corresponding-
1403         rdar://problem/18996776
1404
1405         Reviewed by Tim Horton.
1406
1407         * WebView/WebActionMenuController.mm:
1408         (-[WebActionMenuController _defaultMenuItems]):
1409
1410 2014-11-19  Beth Dakin  <bdakin@apple.com>
1411
1412         Data detected results with no menu items should not fall through to regular text 
1413         action menus
1414         https://bugs.webkit.org/show_bug.cgi?id=138887
1415         -and corresponding-
1416         rdar://problem/18971616
1417
1418         Reviewed by Tim Horton.
1419
1420         * WebView/WebActionMenuController.mm:
1421         (-[WebActionMenuController _defaultMenuItems]):
1422
1423 2014-11-19  Daniel Bates  <dabates@apple.com>
1424
1425         [iOS] Make WebKit build with public iOS SDK
1426         https://bugs.webkit.org/show_bug.cgi?id=136863
1427
1428         Reviewed by David Kilzer.
1429
1430         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
1431         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
1432         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
1433         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
1434         may be used by Apple internal clients that do not include wtf/Platform.h.
1435         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
1436         private Foundation headers directly.
1437         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
1438         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
1439         instead of including private CFNetwork headers directly. Also fixed up style and
1440         ordering of header include directives.
1441         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
1442         CFNetwork headers directly. Also sort the #import directives.
1443         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
1444         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
1445
1446 2014-11-18  David Kilzer  <ddkilzer@apple.com>
1447
1448         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
1449         <http://webkit.org/b/138813>
1450
1451         Reviewed by Mark Rowe.
1452
1453         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
1454         selectors.
1455
1456 2014-11-18  Chris Dumez  <cdumez@apple.com>
1457
1458         Add a setting to toggle DOMTimer throttling support
1459         https://bugs.webkit.org/show_bug.cgi?id=138844
1460         <rdar://problem/19020874>
1461
1462         Reviewed by Andreas Kling.
1463
1464         Add a setting to disable DOM timers throttling, in order to help
1465         developers determine if a specific issue is caused by timer
1466         throttling.
1467
1468         * WebView/WebPreferenceKeysPrivate.h:
1469         * WebView/WebPreferences.mm:
1470         (+[WebPreferences initialize]):
1471         (-[WebPreferences domTimersThrottlingEnabled]):
1472         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
1473         * WebView/WebPreferencesPrivate.h:
1474         * WebView/WebView.mm:
1475         (-[WebView _preferencesChanged:]):
1476
1477 2014-11-18  Tim Horton  <timothy_horton@apple.com>
1478
1479         Avoid re-encoding action menu image data
1480         https://bugs.webkit.org/show_bug.cgi?id=138817
1481         <rdar://problem/18840382>
1482
1483         Reviewed by Anders Carlsson.
1484
1485         * WebView/WebActionMenuController.mm:
1486         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1487         (-[WebActionMenuController _addImageToPhotos:]):
1488         Build a temporary filename from a UUID and the image's desired extension.
1489         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
1490         Build an image menu only if we have an image, URL, data, and extension.
1491
1492 2014-11-18  Daniel Bates  <dabates@apple.com>
1493
1494         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1495         SPI are not available in public SDK
1496         https://bugs.webkit.org/show_bug.cgi?id=138802
1497
1498         Reviewed by David Kilzer.
1499
1500         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1501         libdispatch and MobileGestalt headers directly.
1502
1503         * WebView/WebView.mm:
1504
1505 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
1506
1507         Remove calls to deprecated NSMenu methods
1508         https://bugs.webkit.org/show_bug.cgi?id=138808.
1509
1510         Reviewed by Anders Carlsson.
1511
1512         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
1513
1514         * WebCoreSupport/PopupMenuMac.mm:
1515         (PopupMenuMac::populate):
1516
1517 2014-11-17  Daniel Bates  <dabates@apple.com>
1518
1519         Unreviewed, rolling out r176232.
1520
1521         Broke the Mac build. Will investigate offline.
1522
1523         Reverted changeset:
1524
1525         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1526         MobileGestalt"
1527         https://bugs.webkit.org/show_bug.cgi?id=138802
1528         http://trac.webkit.org/changeset/176232
1529
1530 2014-11-17  Daniel Bates  <dabates@apple.com>
1531
1532         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1533         SPI are not available in public SDK
1534         https://bugs.webkit.org/show_bug.cgi?id=138802
1535
1536         Reviewed by David Kilzer.
1537
1538         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
1539         libdispatch and MobileGestalt headers directly.
1540
1541         * WebView/WebView.mm:
1542
1543 2014-11-17  Beth Dakin  <bdakin@apple.com>
1544
1545         Whitespace action menus should focus the HitTestResult and create an insertion 
1546         point
1547         https://bugs.webkit.org/show_bug.cgi?id=138786
1548         -and corresponding-
1549         rdar://problem/18944893
1550
1551         Reviewed by Tim Horton.
1552
1553         Whitespace menus should cause the HitTestResult to be focused, and they should set 
1554         the selection based on the HitTest location.
1555
1556         * WebView/WebActionMenuController.mm:
1557         (-[WebActionMenuController isMenuForTextContent]):
1558         (-[WebActionMenuController focusAndSelectHitTestResult]):
1559         (-[WebActionMenuController willOpenMenu:withEvent:]):
1560
1561 2014-11-17  Daniel Bates  <dabates@apple.com>
1562
1563         [iOS] QuartzCore SPI not available in public SDK
1564         https://bugs.webkit.org/show_bug.cgi?id=138751
1565
1566         Reviewed by David Kilzer.
1567
1568         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
1569
1570         * WebInspector/WebNodeHighlight.mm:
1571         * WebView/WebIndicateLayer.mm:
1572
1573 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
1574
1575         [iOS] allow host application to opt-out of alternate fullscreen
1576         https://bugs.webkit.org/show_bug.cgi?id=138787
1577
1578         Reviewed by Darin Adler.
1579
1580         * WebView/WebPreferenceKeysPrivate.h:
1581         * WebView/WebPreferences.mm:
1582         (+[WebPreferences initialize]):
1583         (-[WebPreferences allowsAlternateFullscreen]):
1584         (-[WebPreferences setAllowsAlternateFullscreen:]):
1585         * WebView/WebPreferencesPrivate.h:
1586         * WebView/WebView.mm:
1587         (-[WebView _preferencesChanged:]):
1588
1589 2014-11-16  Tim Horton  <timothy_horton@apple.com>
1590
1591         Use TextIndicator instead of the built in Lookup highlight
1592         https://bugs.webkit.org/show_bug.cgi?id=138775
1593         <rdar://problem/18953982>
1594
1595         Reviewed by Anders Carlsson.
1596
1597         * WebCoreSupport/WebSystemInterface.mm:
1598         (InitWebCoreSystemInterface):
1599         Remove a WKSI import.
1600
1601         * WebView/WebActionMenuController.mm:
1602         (-[WebActionMenuController _lookupText:]):
1603         (-[WebActionMenuController _createActionMenuItemForTag:]):
1604         Make use of the new Lookup SPI header.
1605         Disable the Lookup item if lookup is not available.
1606
1607 2014-11-15  Tim Horton  <timothy_horton@apple.com>
1608
1609         Implement data detectors and mailto action menus for WebKit1
1610         https://bugs.webkit.org/show_bug.cgi?id=138765
1611         <rdar://problem/18877535>
1612
1613         Reviewed by Beth Dakin.
1614
1615         * WebView/WebActionMenuController.h:
1616         * WebView/WebActionMenuController.mm:
1617         (-[WebActionMenuController willOpenMenu:withEvent:]):
1618         Tell DataDetectors that the menu is going to open.
1619         Select the text (or not) based on the number of items in the menu, just like WebKit2.
1620
1621         (-[WebActionMenuController didCloseMenu:withEvent:]):
1622         Tell DataDetectors that the menu closed.
1623
1624         (-[WebActionMenuController _defaultMenuItemsForLink]):
1625         Move these checks out of _defaultMenuItemsForLink, because we expect this
1626         to always return a complete link menu.
1627
1628         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1629         Implement. More or less copied from WebKit2.
1630
1631         (-[WebActionMenuController _selectDataDetectedText]):
1632         Select the stashed range.
1633
1634         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1635         Implement. More or less copied from WebKit2.
1636         The yellow highlight isn't hooked up yet.
1637         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
1638
1639         (-[WebActionMenuController _selectLookupText]):
1640         Remove an unnecessary return.
1641
1642         (-[WebActionMenuController _defaultMenuItems]):
1643         Call into the two new menu types.
1644
1645         * WebView/WebUIDelegatePrivate.h:
1646
1647 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
1648
1649         Get rid of WebFontCache
1650         https://bugs.webkit.org/show_bug.cgi?id=134752
1651
1652         Reviewed by Dave Hyatt.
1653
1654         * WebView/WebHTMLView.mm:
1655
1656 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
1657
1658         Update some artwork for the legacy WebKit action menu
1659         https://bugs.webkit.org/show_bug.cgi?id=138758
1660         <rdar://problem/18989840>
1661
1662         * WebView/WebActionMenuController.mm:
1663         (webKitBundleImageNamed): Deleted.
1664         Fix the build.
1665
1666 2014-11-14  Tim Horton  <timothy_horton@apple.com>
1667
1668         Update some artwork for the legacy WebKit action menu
1669         https://bugs.webkit.org/show_bug.cgi?id=138758
1670         <rdar://problem/18989840>
1671
1672         Reviewed by Simon Fraser.
1673
1674         * WebView/WebActionMenuController.mm:
1675         (-[WebActionMenuController _createActionMenuItemForTag:]):
1676
1677 2014-11-14  Daniel Bates  <dabates@apple.com>
1678
1679         [iOS] NSFileManager and QuickLook SPI not available in public SDK
1680         https://bugs.webkit.org/show_bug.cgi?id=138742
1681
1682         Reviewed by Pratik Solanki.
1683
1684         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
1685
1686         * WebCoreSupport/WebFrameLoaderClient.mm:
1687
1688 2014-11-14  Beth Dakin  <bdakin@apple.com>
1689
1690         WK1: Webpage preview can come up in wrong location
1691         https://bugs.webkit.org/show_bug.cgi?id=138747
1692         -and corresponding-
1693         rdar://problem/18979004
1694
1695         Reviewed by Tim Horton.
1696
1697         Converting to window twice is bad.
1698         * WebView/WebActionMenuController.mm:
1699         (elementBoundingBoxInWindowCoordinatesFromNode):
1700         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1701         (elementBoundingBoxFromNode): Deleted.
1702
1703 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1704
1705         Move FontMac and FontCacheMac off of WKSI
1706         https://bugs.webkit.org/show_bug.cgi?id=138633
1707
1708         Reviewed by Simon Fraser.
1709
1710         * WebCoreSupport/WebSystemInterface.mm:
1711         (InitWebCoreSystemInterface):
1712         * WebKit.order:
1713
1714 2014-11-13  Beth Dakin  <bdakin@apple.com>
1715
1716         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
1717         https://bugs.webkit.org/show_bug.cgi?id=138716
1718         -and corresponding-
1719         rdar://problem/18977222
1720
1721         Reviewed by Tim Horton.
1722
1723         It’s not necessary to use the WebElementDictionary for so many things now that we 
1724         are caching the HitTestResult. We should just use the HitTestResult.
1725
1726         * WebView/WebActionMenuController.mm:
1727         (-[WebActionMenuController prepareForMenu:withEvent:]):
1728         (-[WebActionMenuController _openURLFromActionMenu:]):
1729         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
1730         (elementBoundingBoxFromNode):
1731         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
1732         (-[WebActionMenuController _defaultMenuItemsForLink]):
1733         (-[WebActionMenuController _defaultMenuItemsForImage]):
1734         (-[WebActionMenuController _defaultMenuItemsForVideo]):
1735         (-[WebActionMenuController _defaultMenuItemsForText]):
1736         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1737         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1738         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1739         (-[WebActionMenuController _createActionMenuItemForTag:]):
1740         (-[WebActionMenuController _defaultMenuItems]):
1741         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
1742         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
1743         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
1744         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
1745         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
1746         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
1747         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
1748         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
1749         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
1750         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
1751
1752 2014-11-13  Daniel Bates  <dabates@apple.com>
1753
1754         [iOS] NSGeometry data types are not available in the public SDK
1755         https://bugs.webkit.org/show_bug.cgi?id=137536
1756
1757         Reviewed by David Kilzer.
1758
1759         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
1760         private header.
1761
1762         * DOM/WebDOMOperationsPrivate.h:
1763
1764 2014-11-13  Beth Dakin  <bdakin@apple.com>
1765
1766         WK1: Support default actions for video
1767         https://bugs.webkit.org/show_bug.cgi?id=138713
1768         -and corresponding-
1769         rdar://problem/18877520
1770
1771         Reviewed by Tim Horton.
1772
1773         Call setToNonShadowAncestor() for media HitTestResults.
1774         * WebView/WebActionMenuController.mm:
1775         (-[WebActionMenuController performHitTestAtPoint:]):
1776
1777         Default items and actions.
1778         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
1779         (-[WebActionMenuController _copyVideoURL:]):
1780         (-[WebActionMenuController _saveVideoToDownloads:]):
1781         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1782         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1783         * WebView/WebUIDelegatePrivate.h:
1784
1785 2014-11-13  Tim Horton  <timothy_horton@apple.com>
1786
1787         WK1: Update icon for Add to Reading List
1788         https://bugs.webkit.org/show_bug.cgi?id=138710
1789         <rdar://problem/18975774>
1790
1791         Reviewed by Beth Dakin.
1792
1793         * WebView/WebActionMenuController.mm:
1794         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1795         Use the right icon, matching WebKit2.
1796
1797 2014-11-12  Beth Dakin  <bdakin@apple.com>
1798
1799         WK1: Support default actions for images
1800         https://bugs.webkit.org/show_bug.cgi?id=138668
1801         -and corresponding-
1802         rdar://problem/18785434
1803
1804         Reviewed by Tim Horton.
1805
1806         * WebView/WebActionMenuController.h:
1807         * WebView/WebActionMenuController.mm:
1808         (-[WebActionMenuController didCloseMenu:withEvent:]):
1809         (-[WebActionMenuController _defaultMenuItemsForImage:]):
1810         (-[WebActionMenuController _copyImage:]):
1811         (temporaryPhotosDirectoryPath):
1812         (pathToPhotoOnDisk):
1813         (-[WebActionMenuController _canAddMediaToPhotos]):
1814         (-[WebActionMenuController _addImageToPhotos:]):
1815         (-[WebActionMenuController _saveImageToDownloads:]):
1816         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1817         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
1818         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1819         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1820         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1821         * WebView/WebUIDelegatePrivate.h:
1822
1823 2014-11-11  Beth Dakin  <bdakin@apple.com>
1824
1825         Action menu hit testing is not working properly with all WK1 apps
1826         https://bugs.webkit.org/show_bug.cgi?id=138643
1827         -and corresponding-
1828         rdar://problem/18949376
1829
1830         Reviewed by Tim Horton.
1831
1832         * WebView/WebActionMenuController.mm:
1833         (-[WebActionMenuController prepareForMenu:withEvent:]):
1834         (-[WebActionMenuController _lookupText:]):
1835
1836 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1837
1838         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
1839         https://bugs.webkit.org/show_bug.cgi?id=138623
1840
1841         Reviewed by Geoff Garen.
1842
1843         * WebCoreSupport/WebSystemInterface.mm:
1844         (InitWebCoreSystemInterface):
1845         * WebKit.order:
1846
1847 2014-11-11  Tim Horton  <timothy_horton@apple.com>
1848
1849         Localize strings for action menus
1850         https://bugs.webkit.org/show_bug.cgi?id=138591
1851         <rdar://problem/18815343>
1852
1853         Reviewed by Dan Bates.
1854
1855         * WebView/WebActionMenuController.mm:
1856         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1857         Make use of the new strings.
1858
1859 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1860
1861         Cleanup from r175379
1862         https://bugs.webkit.org/show_bug.cgi?id=138616
1863
1864         Reviewed by Simon Fraser.
1865
1866         * WebCoreSupport/WebSystemInterface.mm:
1867         (InitWebCoreSystemInterface):
1868         * WebKit.order:
1869
1870 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
1871
1872         Move CTFontTransformGlyphs out from WKSI
1873         https://bugs.webkit.org/show_bug.cgi?id=138599
1874
1875         Reviewed by Simon Fraser.
1876
1877         * WebCoreSupport/WebSystemInterface.mm:
1878         (InitWebCoreSystemInterface):
1879         * WebKit.order:
1880
1881 2014-11-11  Dan Bernstein  <mitz@apple.com>
1882
1883         More iOS build fix.
1884
1885         * WebView/WebHTMLViewInternal.h:
1886
1887 2014-11-11  Dan Bernstein  <mitz@apple.com>
1888
1889         iOS build fix.
1890
1891         * WebView/WebHTMLView.mm:
1892
1893 2014-11-10  Beth Dakin  <bdakin@apple.com>
1894
1895         WK1: Support default actions for editable text with misspelled word
1896         https://bugs.webkit.org/show_bug.cgi?id=138590
1897         -and corresponding-
1898         rdar://problem/18877506
1899
1900         Reviewed by Tim Horton.
1901
1902         If there are misspelled word suggestions for editable text, create a new type of 
1903         menu with a spelling suggestion sub-menu.
1904
1905         * WebView/WebActionMenuController.mm:
1906         (-[WebActionMenuController isMenuForTextContent]):
1907         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
1908         (-[WebActionMenuController _changeSelectionToSuggestion:]):
1909         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1910         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1911         * WebView/WebHTMLView.mm:
1912         (-[WebHTMLView _changeSpellingToWord:]):
1913         * WebView/WebHTMLViewInternal.h:
1914         * WebView/WebUIDelegatePrivate.h:
1915
1916 2014-11-10  Beth Dakin  <bdakin@apple.com>
1917
1918         WK1: Support default actions for editable whitespace
1919         https://bugs.webkit.org/show_bug.cgi?id=138586
1920         -and corresponding-
1921         rdar://problem/18932048
1922
1923         Reviewed by Tim Horton.
1924
1925         New menu type. Just wants paste.
1926
1927         * WebView/WebActionMenuController.mm:
1928         (-[WebActionMenuController isMenuForTextContent]):
1929         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
1930         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1931         * WebView/WebUIDelegatePrivate.h:
1932
1933 2014-11-10  Beth Dakin  <bdakin@apple.com>
1934
1935         WK1: Support default actions for editable text
1936         https://bugs.webkit.org/show_bug.cgi?id=138580
1937         -and corresponding-
1938         rdar://problem/18877497
1939
1940         Reviewed by Tim Horton.
1941
1942         New menu type, and new action type for paste. 
1943
1944         * WebView/WebActionMenuController.mm:
1945         (-[WebActionMenuController isMenuForTextContent]):
1946         (-[WebActionMenuController willOpenMenu:withEvent:]):
1947         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
1948         (-[WebActionMenuController _paste:]):
1949         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
1950         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1951         * WebView/WebUIDelegatePrivate.h:
1952
1953 2014-11-10  Beth Dakin  <bdakin@apple.com>
1954
1955         WK1: Text is getting selected even when an action menu fails to invoke
1956         https://bugs.webkit.org/show_bug.cgi?id=138576
1957         -and corresponding-
1958         rdar://problem/18931330
1959
1960         Reviewed by Tim Horton.
1961
1962         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
1963         * WebView/WebActionMenuController.h:
1964         * WebView/WebActionMenuController.mm:
1965         (-[WebActionMenuController prepareForMenu:withEvent:]):
1966         (-[WebActionMenuController willOpenMenu:withEvent:]):
1967
1968         _selectLookupText no longer needs to return a BOOL indicating success or failure.
1969         (-[WebActionMenuController _selectLookupText]):
1970         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
1971
1972         Pass willOpenMenu: on to the controller.
1973         * WebView/WebView.mm:
1974         (-[WebView willOpenMenu:withEvent:]):
1975
1976 2014-11-10  Beth Dakin  <bdakin@apple.com>
1977
1978         Speculative build fix.
1979
1980         * WebView/WebActionMenuController.mm:
1981
1982 2014-11-10  Beth Dakin  <bdakin@apple.com>
1983
1984         Action menu initialization should be moved to _commonInitializationWithFrameName
1985         https://bugs.webkit.org/show_bug.cgi?id=138572
1986         -and corresponding-
1987         rdar://problem/18929733
1988
1989         Reviewed by Tim Horton.
1990
1991         * WebView/WebView.mm:
1992         (-[WebView _commonInitializationWithFrameName:groupName:]):
1993         (-[WebView _initWithFrame:frameName:groupName:]):
1994
1995 2014-11-10  Beth Dakin  <bdakin@apple.com>
1996
1997         WK1: Support default actions for read-only text
1998         https://bugs.webkit.org/show_bug.cgi?id=138552
1999         -and corresponding-
2000         rdar://problem/18877483
2001
2002         Reviewed by Tim Horton.
2003
2004         New WKSystemInterface functions that WebCore needs to use.
2005         * WebCoreSupport/WebSystemInterface.mm:
2006         (InitWebCoreSystemInterface):
2007
2008         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2009         makes a lot of things easier.
2010         * WebView/WebActionMenuController.h:
2011         * WebView/WebActionMenuController.mm:
2012
2013         Perform the hit test ourselves instead of calling into WebView so that we can more 
2014         easily save the WebCore::HitTestResult for ourselves.
2015         (-[WebActionMenuController performHitTestAtPoint:]):
2016
2017         Clear selection for non-text menus.
2018         (-[WebActionMenuController prepareForMenu:withEvent:]):
2019
2020         Re-set the _type here just to be safe.
2021         (-[WebActionMenuController didCloseMenu:withEvent:]):
2022
2023         Moving this method to be next to the link actions so they can be within a pragma 
2024         mark.
2025         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2026
2027         New method for default text actions — lookup and copy.
2028         (-[WebActionMenuController _defaultMenuItemsForText:]):
2029         (-[WebActionMenuController _copySelection:]):
2030         (-[WebActionMenuController _lookupText:]):
2031
2032         If there is not already a selection, invoking the action menu on text should 
2033         select the lookup text.
2034         (-[WebActionMenuController _selectLookupText]):
2035         (performDictionaryLookupForSelection):
2036         (performDictionaryLookupForRange):
2037
2038         Handle text now.
2039         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2040         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2041
2042         New enum values.
2043         * WebView/WebUIDelegatePrivate.h:
2044
2045         Pass didCloseMenu on to the controller.
2046         * WebView/WebView.mm:
2047         (-[WebView didCloseMenu:withEvent:]):
2048
2049 2014-11-09  Chris Dumez  <cdumez@apple.com>
2050
2051         Add a more correct way to compare floating point numbers and use it
2052         https://bugs.webkit.org/show_bug.cgi?id=138527
2053
2054         Reviewed by Darin Adler.
2055
2056         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2057         to compare floating-point numbers.
2058
2059         * WebView/WebHTMLView.mm:
2060         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2061
2062 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2063
2064         Delete cookies between tests
2065         https://bugs.webkit.org/show_bug.cgi?id=138528
2066
2067         Reviewed by Sam Weinig.
2068
2069         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2070         * WebView/WebPreferencesPrivate.h:
2071         Added an SPI for DumpRenderTree.
2072
2073 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2074
2075         [iOS] Update optimized fullscreen media controls
2076         https://bugs.webkit.org/show_bug.cgi?id=138493
2077
2078         Reviewed by Brent Fulgham.
2079
2080         * WebCoreSupport/WebSystemInterface.mm:
2081         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2082
2083 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2084
2085         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2086         https://bugs.webkit.org/show_bug.cgi?id=138443
2087
2088         Reviewed by Anders Carlsson.
2089
2090         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2091         complex tear-downs leading to the WebView itself being added to an autorelease
2092         pool that is not drained until after the instance has been dealloc'd.
2093  
2094         * WebView/WebView.mm:
2095         (-[WebView dealloc]):
2096
2097 2014-11-05  Jer Noble  <jer.noble@apple.com>
2098
2099         De-templatize Timer
2100         https://bugs.webkit.org/show_bug.cgi?id=138450
2101
2102         Reviewed by Anders Carlsson.
2103
2104         Remove template specifiers from Timer.
2105
2106         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2107         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2108         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2109         * Plugins/WebNetscapePluginStream.h:
2110         * Plugins/WebNetscapePluginStream.mm:
2111         (WebNetscapePluginStream::deliverDataTimerFired):
2112
2113 2014-11-05  Dan Bernstein  <mitz@apple.com>
2114
2115         Remove the unused deletion UI feature
2116         https://bugs.webkit.org/show_bug.cgi?id=138442
2117
2118         Rubber-stamped by Alexey Proskuryakov.
2119
2120         * DefaultDelegates/WebDefaultEditingDelegate.m:
2121         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2122         * WebCoreSupport/WebEditorClient.h:
2123         * WebCoreSupport/WebEditorClient.mm:
2124         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2125         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2126         -webView:shouldShowDeleteInterfaceForElement:.
2127
2128 2014-11-03  Dean Jackson  <dino@apple.com>
2129
2130         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2131         https://bugs.webkit.org/show_bug.cgi?id=138362
2132
2133         Reviewed by Tim Horton.
2134
2135         Add a new feature define for Level 2 of CSS Filters.
2136         http://dev.w3.org/fxtf/filters-2/
2137
2138         * Configurations/FeatureDefines.xcconfig:
2139
2140 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2141
2142         Add button and enable optimized fullscreen.
2143         https://bugs.webkit.org/show_bug.cgi?id=138351
2144
2145         Reviewed by Eric Carlson.
2146
2147         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2148
2149         * WebCoreSupport/WebSystemInterface.mm:
2150         (InitWebCoreSystemInterface): added
2151
2152 2014-11-04  Chris Dumez  <cdumez@apple.com>
2153
2154         Add ptr() method to Ref class
2155         https://bugs.webkit.org/show_bug.cgi?id=138361
2156
2157         Reviewed by Darin Adler.
2158
2159         Use the new Ref::ptr() method.
2160
2161         * WebView/WebFrame.mm:
2162         (-[WebFrame _setTypingStyle:withUndoAction:]):
2163         * WebView/WebHTMLView.mm:
2164         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2165         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2166         * WebView/WebView.mm:
2167         (-[WebView applyStyle:]):
2168
2169 2014-11-04  Darin Adler  <darin@apple.com>
2170
2171         Eliminate ResourceBuffer and use SharedBuffer directly instead
2172         https://bugs.webkit.org/show_bug.cgi?id=138174
2173
2174         Reviewed by Antti Koivisto.
2175
2176         * WebView/WebDataSource.mm:
2177         (-[WebDataSource data]): Use SharedBuffer directly.
2178         * WebView/WebHTMLView.mm:
2179         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2180
2181 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2182
2183         Unreviewed, rolling out r175406, r175413, and r175423.
2184         https://bugs.webkit.org/show_bug.cgi?id=138327
2185
2186         Multipart tests are still broken (Requested by ap on #webkit).
2187
2188         Reverted changesets:
2189
2190         "Eliminate ResourceBuffer and use SharedBuffer directly
2191         instead"
2192         https://bugs.webkit.org/show_bug.cgi?id=138174
2193         http://trac.webkit.org/changeset/175406
2194
2195         "Unreviewed, iOS build fix since 175406."
2196         http://trac.webkit.org/changeset/175413
2197
2198         "Fix assertion in CachedResource::addDataBuffer"
2199         http://trac.webkit.org/changeset/175423
2200
2201 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2202
2203         Use std::unique_ptr for TypeCountSet
2204         https://bugs.webkit.org/show_bug.cgi?id=138242
2205
2206         Reviewed by Andreas Kling.
2207
2208         * Misc/WebCoreStatistics.mm:
2209         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2210         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2211
2212 2014-10-31  Beth Dakin  <bdakin@apple.com>
2213
2214         Use system art for action menus when possible
2215         https://bugs.webkit.org/show_bug.cgi?id=138260
2216
2217         Reviewed by Tim Horton.
2218
2219         * WebView/WebActionMenuController.mm:
2220         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2221
2222 2014-10-30  Darin Adler  <darin@apple.com>
2223
2224         Eliminate ResourceBuffer and use SharedBuffer directly instead
2225         https://bugs.webkit.org/show_bug.cgi?id=138174
2226
2227         Reviewed by Antti Koivisto.
2228
2229         * WebView/WebDataSource.mm:
2230         (-[WebDataSource data]): Use SharedBuffer directly.
2231         * WebView/WebHTMLView.mm:
2232         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2233
2234 2014-10-30  Jer Noble  <jer.noble@apple.com>
2235
2236         [EME] Add Setting for accessing storage location for MediaKeys data
2237         https://bugs.webkit.org/show_bug.cgi?id=138147
2238
2239         Reviewed by Brady Eidson.
2240
2241         * WebView/WebPreferenceKeysPrivate.h:
2242         * WebView/WebPreferences.mm:
2243         (+[WebPreferences initialize]): Set default location.
2244         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2245         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2246         * WebView/WebPreferencesPrivate.h:
2247         * WebView/WebView.mm:
2248         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2249
2250 2014-10-30  Dana Burkart  <dburkart@apple.com>
2251
2252         <rdar://problem/18821260> Prepare for the mysterious future
2253
2254         Reviewed by Lucas Forschler.
2255
2256         * Configurations/Base.xcconfig:
2257         * Configurations/DebugRelease.xcconfig:
2258         * Configurations/FeatureDefines.xcconfig:
2259         * Configurations/Version.xcconfig:
2260
2261 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2262
2263         Add optimized fullscreen mode.
2264         https://bugs.webkit.org/show_bug.cgi?id=138044
2265
2266         Reviewed by Jer Noble.
2267
2268         Enable different types of fullscreen video behavior.
2269         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2270
2271         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2272         * WebCoreSupport/WebChromeClient.mm:
2273         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2274         * WebView/WebView.mm:
2275         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2276         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2277         * WebView/WebViewInternal.h: ditto
2278
2279 2014-10-27  Beth Dakin  <bdakin@apple.com>
2280
2281         Provide a way for WebKit1 clients to override default action menu items
2282         https://bugs.webkit.org/show_bug.cgi?id=138066
2283         -and corresponding-
2284         rdar://problem/18451638
2285
2286         Reviewed by Anders Carlsson.
2287
2288         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2289         send that along to clients customizing the menu.
2290         * WebView/WebActionMenuController.h:
2291         * WebView/WebActionMenuController.mm:
2292         (-[WebActionMenuController prepareForMenu:withEvent:]):
2293         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2294
2295         New enum and new SPI to customize menus.
2296         * WebView/WebUIDelegatePrivate.h:
2297
2298 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2299
2300         Fix the iOS build
2301
2302         * Configurations/WebKitLegacy.xcconfig:
2303         * WebView/WebView.mm:
2304
2305 2014-10-24  Beth Dakin  <bdakin@apple.com>
2306
2307         Build fix.
2308
2309         * WebView/WebActionMenuController.mm:
2310         (-[WebActionMenuController _openURLFromActionMenu:]):
2311         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2312         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2313
2314 2014-10-24  Beth Dakin  <bdakin@apple.com>
2315
2316         WebKit1 should support action menus
2317         https://bugs.webkit.org/show_bug.cgi?id=138032
2318
2319         Reviewed by Tim Horton.
2320
2321         This patch adds basic support for action menus and adds actions for links.
2322
2323         Helper class takes care of all of the action menu work. WebView will forward the 
2324         prepareForMenu: message, and then the helper class takes it from there.
2325         * WebView/WebActionMenuController.h: Added.
2326         * WebView/WebActionMenuController.mm: Added.
2327         (-[WebActionMenuController webViewClosed]):
2328         (-[WebActionMenuController prepareForMenu:withEvent:]):
2329
2330         Selectors for link actions.
2331         (-[WebActionMenuController _openURLFromActionMenu:]):
2332         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2333         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
2334         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2335         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2336         (webKitBundleImageNamed):
2337         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2338         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2339
2340         Tags for the action menu items.
2341         * WebView/WebUIDelegatePrivate.h:
2342         * WebView/WebView.mm:
2343
2344         Set the action menu if possible and create the controller.
2345         (-[WebView _initWithFrame:frameName:groupName:]):
2346         (-[WebView _close]):
2347         (-[WebView prepareForMenu:withEvent:]):
2348
2349         WebViewData stores the WebActionMenuHelper
2350         * WebView/WebViewData.h:
2351         * WebView/WebViewData.mm:
2352         (-[WebViewPrivate dealloc]):
2353
2354 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
2355
2356         Web Inspector: Provide a way to have alternate inspector agents
2357         https://bugs.webkit.org/show_bug.cgi?id=137901
2358
2359         Reviewed by Brian Burg.
2360
2361         * Configurations/FeatureDefines.xcconfig:
2362
2363 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2364
2365         Add some SPI headers for NSExtension and NSSharingService{Picker}
2366         https://bugs.webkit.org/show_bug.cgi?id=138027
2367
2368         Reviewed by Anders Carlsson.
2369
2370         * Misc/WebSharingServicePickerController.h:
2371         * Misc/WebSharingServicePickerController.mm:
2372         * WebCoreSupport/WebSelectionServiceController.mm:
2373         * WebCoreSupport/WebContextMenuClient.mm:
2374         Fix a sorting issue.
2375         Replace redefinitions with SPI header #imports.
2376
2377 2014-10-23  Tim Horton  <timothy_horton@apple.com>
2378
2379         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
2380         https://bugs.webkit.org/show_bug.cgi?id=138013
2381
2382         Reviewed by Dan Bernstein.
2383
2384         * WebCoreSupport/WebSelectionServiceController.mm:
2385         (WebSelectionServiceController::hasRelevantSelectionServices):
2386         Don't adopt this autoreleased object.
2387
2388 2014-10-22  Chris Dumez  <cdumez@apple.com>
2389
2390         [Mac][WK2] Fix applicationIsSafari() detection
2391         https://bugs.webkit.org/show_bug.cgi?id=137893
2392
2393         Reviewed by Alexey Proskuryakov.
2394
2395         Provide an implementation for FrameLoaderClient's new
2396         needsQuickLookResourceCachingQuirks() that returns
2397         a static flag initialized using
2398         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
2399
2400         * WebCoreSupport/WebFrameLoaderClient.h:
2401         * WebCoreSupport/WebFrameLoaderClient.mm:
2402
2403 2014-10-20  Chris Dumez  <cdumez@apple.com>
2404
2405         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
2406         https://bugs.webkit.org/show_bug.cgi?id=137797
2407
2408         Reviewed by Darin Adler.
2409
2410         Call ResourceRequest::setDomainForPartitionName() instead of
2411         setPartitionName() as the argument is a domain, not a valid
2412         partition name.
2413
2414         * Misc/WebCache.mm:
2415         (+[WebCache addImageToCache:forURL:forFrame:]):
2416         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2417
2418 2014-10-20  Andy Estes  <aestes@apple.com>
2419
2420         Fix the iOS build.
2421
2422         * WebView/WebFrame.mm:
2423         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2424         (-[WebFrame dictationResultMetadataForRange:]):
2425
2426 2014-10-19  Chris Dumez  <cdumez@apple.com>
2427
2428         Use is<>() / downcast<>() for all remaining RenderObject subclasses
2429         https://bugs.webkit.org/show_bug.cgi?id=137845
2430
2431         Reviewed by Darin Adler.
2432
2433         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
2434         clean up the surrounding code.
2435
2436         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2437         (-[WebHostedNetscapePluginView pluginHostDied]):
2438         * Plugins/WebBaseNetscapePluginView.mm:
2439         (-[WebBaseNetscapePluginView _windowClipRect]):
2440         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2441         * WebCoreSupport/WebFrameLoaderClient.mm:
2442         (WebFrameLoaderClient::createPlugin):
2443         (WebFrameLoaderClient::createJavaAppletWidget):
2444
2445 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2446
2447         Build fix for 32-bit Yosemite
2448
2449         * WebCoreSupport/WebContextMenuClient.mm:
2450         (WebContextMenuClient::contextMenuForEvent):
2451         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
2452
2453 2014-10-17  Chris Dumez  <cdumez@apple.com>
2454
2455         Use is<>() / downcast<>() for RenderBox
2456         https://bugs.webkit.org/show_bug.cgi?id=137804
2457
2458         Reviewed by Andreas Kling.
2459
2460         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
2461         code.
2462
2463         * WebCoreSupport/WebContextMenuClient.mm:
2464         (WebContextMenuClient::clientFloatRectForNode):
2465         * WebView/WebFrame.mm:
2466         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
2467
2468 2014-10-17  Tim Horton  <timothy_horton@apple.com>
2469
2470         Fix the build with the public SDK.
2471
2472         * WebCoreSupport/WebSelectionServiceController.mm:
2473         We should transition all this SPI to real SPI headers as soon as possible.
2474
2475 2014-10-16  Tim Horton  <timothy_horton@apple.com>
2476
2477         Implement selection services menu for Legacy WebKit
2478         https://bugs.webkit.org/show_bug.cgi?id=137582
2479         <rdar://problem/18604241>
2480
2481         Reviewed by Brady Eidson.
2482
2483         * Misc/WebSharingServicePickerController.h:
2484         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
2485         Add WebSharingServicePickerClient, which other classes can implement
2486         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
2487         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
2488
2489         * Misc/WebSharingServicePickerController.mm:
2490         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
2491
2492         (-[WebSharingServicePickerController clear]):
2493         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
2494         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2495         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
2496         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
2497         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2498         Make use of WebSharingServicePickerClient.
2499
2500         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2501         If we're returned a NSAttributedString, paste it on top of the current selection,
2502         similar to what the WebKit2 implementation currently does.
2503         
2504         * WebCoreSupport/WebChromeClient.h:
2505         * WebCoreSupport/WebChromeClient.mm:
2506         (WebChromeClient::handleTelephoneNumberClick):
2507         (WebChromeClient::handleSelectionServiceClick):
2508         (WebChromeClient::hasRelevantSelectionServices):
2509         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
2510
2511         * WebCoreSupport/WebContextMenuClient.h:
2512         * WebCoreSupport/WebContextMenuClient.mm:
2513         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
2514         (WebContextMenuClient::pageForSharingServicePicker):
2515         (WebContextMenuClient::windowForSharingServicePicker):
2516         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
2517         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2518         (WebContextMenuClient::contextMenuForEvent):
2519         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
2520         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
2521         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
2522         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
2523         having WebSharingServicePickerController tightly bound to it.
2524         Make an NSItemProvider array when instantiating WebSharingServicePickerController
2525         instead of handing it data directly.
2526
2527         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
2528         * WebCoreSupport/WebSelectionServiceController.mm: Added.
2529         (WebSelectionServiceController::WebSelectionServiceController):
2530         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
2531         for selection services.
2532
2533         (WebSelectionServiceController::handleSelectionServiceClick):
2534         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
2535
2536         (hasCompatibleServicesForItems):
2537         (WebSelectionServiceController::hasRelevantSelectionServices):
2538         Determine whether or not services are available.
2539
2540         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
2541         (WebSelectionServiceController::pageForSharingServicePicker):
2542         (WebSelectionServiceController::windowForSharingServicePicker):
2543         Implement the rest of the WebSharingServicePickerClient overrides.
2544
2545         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
2546         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
2547         These are only useful for image sharing services, so we don't need to
2548         implement them (WebContextMenuClient does, on the other hand).
2549
2550         * WebView/WebView.mm:
2551         (-[WebView _selectionServiceController]):
2552         * WebView/WebViewData.h:
2553         * WebView/WebViewData.mm:
2554         * WebView/WebViewInternal.h:
2555         Keep a WebSelectionServiceController.
2556
2557 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2558
2559         Improve debug description of WAKViews
2560         https://bugs.webkit.org/show_bug.cgi?id=137716
2561
2562         Reviewed by Simon Fraser.
2563
2564         * WebView/WebView.mm:
2565         (-[WebView _touchEventRegions]): Adding a comment.
2566
2567 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2568
2569         Addressing post-review comment.
2570         https://bugs.webkit.org/show_bug.cgi?id=137550
2571
2572         Unreviewed.
2573
2574         * WebView/WebHTMLView.mm:
2575         (fontNameForDescription):
2576         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2577
2578 2014-10-14  Chris Dumez  <cdumez@apple.com>
2579
2580         Use is<>() / downcast<>() for RenderImage
2581         https://bugs.webkit.org/show_bug.cgi?id=137683
2582
2583         Reviewed by Mihnea Ovidenie.
2584
2585         Use is<>() / downcast<>() for RenderImage.
2586
2587         * Misc/WebNSPasteboardExtras.mm:
2588         (imageFromElement):
2589         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2590
2591 2014-10-10  Daniel Bates  <dabates@apple.com>
2592
2593         Remove unused classes WebRender{Node, Layer}
2594         https://bugs.webkit.org/show_bug.cgi?id=137628
2595
2596         Reviewed by Simon Fraser.
2597
2598         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
2599         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
2600
2601         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
2602         of excluded source files when building for iOS.
2603         * WebKit.exp: Remove symbol for WebRenderLayer.
2604         * WebKit.mac.exp: Remove symbol for WebRenderNode.
2605         * WebView/WebRenderLayer.h: Removed.
2606         * WebView/WebRenderLayer.mm: Removed.
2607         * WebView/WebRenderNode.h: Removed.
2608         * WebView/WebRenderNode.mm: Removed.
2609
2610 2014-10-10  Chris Dumez  <cdumez@apple.com>
2611
2612         Use is<>() / downcast<>() for RenderBoxModelObject
2613         https://bugs.webkit.org/show_bug.cgi?id=137587
2614
2615         Reviewed by Mihnea Ovidenie.
2616
2617         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
2618         surrounding code.
2619
2620         * Plugins/WebBaseNetscapePluginView.mm:
2621         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
2622         * WebView/WebRenderLayer.mm:
2623         (-[WebRenderLayer initWithWebFrame:]):
2624
2625 2014-10-09  Dean Jackson  <dino@apple.com>
2626
2627         Remove ENABLE_CSS3_CONDITIONAL_RULES
2628         https://bugs.webkit.org/show_bug.cgi?id=137571
2629
2630         Reviewed by Simon Fraser.
2631
2632         * Configurations/FeatureDefines.xcconfig:
2633
2634 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2635
2636         Add a WebKit1 preference for selection services
2637         https://bugs.webkit.org/show_bug.cgi?id=137498
2638         <rdar://problem/18572699>
2639
2640         Reviewed by Simon Fraser.
2641
2642         * WebView/WebPreferenceKeysPrivate.h:
2643         * WebView/WebPreferences.mm:
2644         (+[WebPreferences initialize]):
2645         (-[WebPreferences serviceControlsEnabled]):
2646         (-[WebPreferences setServiceControlsEnabled:]):
2647         * WebView/WebPreferencesPrivate.h:
2648         * WebView/WebView.mm:
2649         (-[WebView _preferencesChanged:]):
2650         Add and plumb the preference.
2651
2652 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
2653
2654         Remove second-to-last client of WebFontCache
2655         https://bugs.webkit.org/show_bug.cgi?id=137550
2656
2657         Reviewed by Darin Adler.
2658
2659         Use FontCache::getCachedFontData() instead of WebFontCache.
2660
2661         * WebView/WebHTMLView.mm:
2662         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2663
2664 2014-10-09  Chris Dumez  <cdumez@apple.com>
2665
2666         Use is<>() / downcast<>() for Widget subclasses
2667         https://bugs.webkit.org/show_bug.cgi?id=137549
2668
2669         Reviewed by Darin Adler.
2670
2671         Use is<>() / downcast<>() for Widget subclasses and clean up the
2672         surrounding code.
2673
2674         * WebView/WebRenderNode.mm:
2675         (copyRenderNode):
2676         * WebView/WebView.mm:
2677         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2678
2679 2014-10-07  Christophe Dumez  <cdumez@apple.com>
2680
2681         Use is<>() / downcast<>() for RenderText / RenderTextFragment
2682         https://bugs.webkit.org/show_bug.cgi?id=137476
2683
2684         Reviewed by Darin Adler.
2685
2686         * WebView/WebRenderNode.mm:
2687         (copyRenderNode):
2688
2689 2014-10-06  Dan Bernstein  <mitz@apple.com>
2690
2691         Build fix.
2692
2693         * Misc/WebCache.mm:
2694         (+[WebCache imageForURL:]):
2695
2696 2014-10-06  Chris Dumez  <cdumez@apple.com>
2697
2698         Unreviewed build fix after r174333.
2699
2700         Forgot explicit WebCore:: namespace.
2701
2702         * Misc/WebCache.mm:
2703         (+[WebCache imageForURL:]):
2704
2705 2014-10-05  Christophe Dumez  <cdumez@apple.com>
2706
2707         Use is<>() / downcast<>() for CachedResource subclasses
2708         https://bugs.webkit.org/show_bug.cgi?id=137431
2709
2710         Reviewed by Benjamin Poulain.
2711
2712         Use is<>() / downcast<>() for CachedResource subclasses.
2713
2714         * Misc/WebCache.mm:
2715         (+[WebCache imageForURL:]):
2716
2717 2014-10-02  Daniel Bates  <dabates@apple.com>
2718
2719         Use version number 101000 instead of 10100 for OS X Yosemite
2720         https://bugs.webkit.org/show_bug.cgi?id=137372
2721
2722         Reviewed by Mark Rowe.
2723
2724         The version number for OS X Yosemite is 101000.
2725
2726         * WebView/WebView.mm:
2727         (-[WebView _preferencesChanged:]):
2728
2729 2014-10-02  Tim Horton  <timothy_horton@apple.com>
2730
2731         Move PageOverlay[Controller] to WebCore
2732         https://bugs.webkit.org/show_bug.cgi?id=137164
2733         <rdar://problem/18508258>
2734
2735         Reviewed by Anders Carlsson.
2736
2737         * WebCoreSupport/WebChromeClient.h:
2738         * WebCoreSupport/WebChromeClient.mm:
2739         (WebChromeClient::attachViewOverlayGraphicsLayer):
2740         Add an empty ChromeClient override.
2741
2742 2014-10-01  Christophe Dumez  <cdumez@apple.com>
2743
2744         Have is<>(T*) function do a null check on the pointer argument
2745         https://bugs.webkit.org/show_bug.cgi?id=137333
2746
2747         Reviewed by Gavin Barraclough.
2748
2749         Have is<>(T*) function do a null check on the argument instead of a
2750         simple assertion. This makes sense for 2 reasons:
2751         1. It is more consistent with downcast<>(T*), which will succeed even
2752            if the argument is a nullptr.
2753         2. It simplifies the code a bit as it gets rid of a lot of explicit
2754            null checks.
2755
2756         * WebCoreSupport/WebChromeClient.mm:
2757         (WebChromeClient::focusedElementChanged):
2758         * WebCoreSupport/WebEditorClient.mm:
2759         (WebEditorClient::textFieldDidBeginEditing):
2760         (WebEditorClient::textFieldDidEndEditing):
2761         (WebEditorClient::textDidChangeInTextField):
2762         (WebEditorClient::doTextFieldCommandFromEvent):
2763         (WebEditorClient::textWillBeDeletedInTextField):
2764         (WebEditorClient::textDidChangeInTextArea):
2765         * WebView/WebHTMLRepresentation.mm:
2766         (inputElementFromDOMElement):
2767         (searchForLabelsBeforeElement):
2768         * WebView/WebRenderLayer.mm:
2769         (+[WebRenderLayer nameForLayer:]):
2770
2771 2014-10-01  Mark Rowe  <mrowe@apple.com>
2772
2773         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2774
2775         Reviewed by Dan Bernstein.
2776
2777         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
2778
2779 2014-09-30  Chris Dumez  <cdumez@apple.com>
2780
2781         Use is<>() / downcast<>() for Element
2782         https://bugs.webkit.org/show_bug.cgi?id=137241
2783
2784         Reviewed by Andreas Kling.
2785
2786         Use is<>() / downcast<>() for Element instead of isElementNode() /
2787         toElement().
2788
2789         * WebView/WebRenderLayer.mm:
2790         (+[WebRenderLayer nameForLayer:]):
2791
2792 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2793
2794         Move ColorInputType class to std::unique_ptr
2795         https://bugs.webkit.org/show_bug.cgi?id=137173
2796
2797         Reviewed by Darin Adler.
2798
2799         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
2800         Child classes follow this change as well.
2801
2802         * WebCoreSupport/WebChromeClient.h:
2803         * WebCoreSupport/WebChromeClient.mm:
2804         (WebChromeClient::createColorChooser):
2805
2806 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2807
2808         Add initial is<>() / downcast<>() support for any type of Nodes
2809         https://bugs.webkit.org/show_bug.cgi?id=137056
2810
2811         Reviewed by Benjamin Poulain.
2812
2813         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
2814         instead of isFormControlElement() / toHTMLFormControlElement().
2815
2816         * WebView/WebHTMLRepresentation.mm:
2817         (searchForLabelsBeforeElement):
2818
2819 2014-09-24  Christophe Dumez  <cdumez@apple.com>
2820
2821         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
2822         https://bugs.webkit.org/show_bug.cgi?id=137068
2823
2824         Reviewed by Ryosuke Niwa.
2825
2826         Start using is<HTML*Element>() instead of isHTML*Element().
2827         Remaining usages will be updated in a follow-up patch to
2828         reduce the size of the change.
2829
2830         * WebCoreSupport/WebChromeClient.mm:
2831         (WebChromeClient::focusedElementChanged):
2832         * WebCoreSupport/WebEditorClient.mm:
2833         (WebEditorClient::textFieldDidBeginEditing):
2834         (WebEditorClient::textFieldDidEndEditing):
2835         (WebEditorClient::textDidChangeInTextField):
2836         (WebEditorClient::doTextFieldCommandFromEvent):
2837         (WebEditorClient::textWillBeDeletedInTextField):
2838         (WebEditorClient::textDidChangeInTextArea):
2839         * WebView/WebHTMLRepresentation.mm:
2840         (inputElementFromDOMElement):
2841
2842 2014-09-21  Timothy Hatcher  <timothy@apple.com>
2843
2844         Make the Web Inspector use a separate web process.
2845
2846         https://bugs.webkit.org/show_bug.cgi?id=135120
2847
2848         Reviewed by Anders Carlsson.
2849
2850         * WebCoreSupport/WebInspectorClient.h:
2851         * WebCoreSupport/WebInspectorClient.mm:
2852         (WebInspectorClient::WebInspectorClient):
2853         (WebInspectorClient::openInspectorFrontend):
2854         (WebInspectorClient::releaseFrontend):
2855         Own WebInspectorFrontendClient instead of moving it.
2856
2857 2014-09-23  Chris Dumez  <cdumez@apple.com>
2858
2859         Use downcast<HTML*Element>() instead of toHTML*Element()
2860         https://bugs.webkit.org/show_bug.cgi?id=137007
2861
2862         Reviewed by Benjamin Poulain.
2863
2864         Use downcast<HTML*Element>() instead of toHTML*Element().
2865
2866         * DOM/WebDOMOperations.mm:
2867         (-[DOMHTMLInputElement _setAutofilled:]):
2868         * WebCoreSupport/WebChromeClient.mm:
2869         (WebChromeClient::focusedElementChanged):
2870         * WebCoreSupport/WebEditorClient.mm:
2871         (WebEditorClient::textFieldDidBeginEditing):
2872         (WebEditorClient::textFieldDidEndEditing):
2873         (WebEditorClient::textDidChangeInTextField):
2874         (WebEditorClient::doTextFieldCommandFromEvent):
2875         (WebEditorClient::textWillBeDeletedInTextField):
2876         (WebEditorClient::textDidChangeInTextArea):
2877         * WebView/WebHTMLRepresentation.mm:
2878         (inputElementFromDOMElement):
2879
2880 2014-09-21  Chris Dumez  <cdumez@apple.com>
2881
2882         Generate Element casting helper functions
2883         https://bugs.webkit.org/show_bug.cgi?id=136839
2884
2885         Reviewed by Darin Adler.
2886
2887         Use JSXXX::toWrapped() instead of toXXX() function.
2888
2889         * DOM/WebDOMOperations.mm:
2890         * WebView/WebView.mm:
2891         (-[WebView _notificationIDForTesting:]):
2892
2893 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
2894
2895         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
2896         https://bugs.webkit.org/show_bug.cgi?id=136972
2897
2898         Reviewed by Darin Adler.
2899
2900         * WebView/WebNotification.h:
2901         * WebView/WebNotification.mm:
2902         (-[WebNotification initWithCoreNotification:notificationID:]):
2903         Switch to RetainPtr and adopt into _private to ensure when we are
2904         deallocated that _private will get deallocated.
2905
2906 2014-09-19  Dean Jackson  <dino@apple.com>
2907
2908         Multithreaded WebGL is a bad idea - remove it
2909         https://bugs.webkit.org/show_bug.cgi?id=136964
2910         <rdar://problem/18399858>
2911
2912         Reviewed by Brent Fulgham.
2913
2914         Remove the setting to allow multithreaded WebGL.
2915
2916         * WebView/WebPreferenceKeysPrivate.h:
2917         * WebView/WebPreferences.mm:
2918         (+[WebPreferences initialize]):
2919         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
2920         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
2921         * WebView/WebPreferencesPrivate.h:
2922         * WebView/WebView.mm:
2923         (-[WebView _preferencesChanged:]):
2924
2925 2014-09-19  Daniel Bates  <dabates@apple.com>
2926
2927         Always assume internal SDK when building configuration Production
2928         https://bugs.webkit.org/show_bug.cgi?id=136925
2929         <rdar://problem/18362399>
2930
2931         Reviewed by Dan Bernstein.
2932
2933         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
2934         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
2935
2936         * Configurations/Base.xcconfig:
2937
2938 2014-09-17  Daniel Bates  <dabates@apple.com>
2939
2940         Unreviewed, rolling out r173695.
2941
2942         Broke building third-party Legacy WebKit apps; will
2943         investigate offline
2944
2945         Reverted changeset:
2946
2947         "[iOS] Make WebCore build with public iOS SDK"
2948         https://bugs.webkit.org/show_bug.cgi?id=136487
2949         http://trac.webkit.org/changeset/173695
2950
2951 2014-09-17  Daniel Bates  <dabates@apple.com>
2952
2953         [iOS] Make WebCore build with public iOS SDK
2954         https://bugs.webkit.org/show_bug.cgi?id=136487
2955
2956         Reviewed by David Kilzer.
2957
2958         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
2959         actual SPI header(s).
2960
2961         * DOM/WebDOMOperationsPrivate.h:
2962         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
2963         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
2964         such files into the WebKit framework as private headers.
2965         * WebCoreSupport/WebFrameLoaderClient.mm:
2966         * WebInspector/WebNodeHighlight.mm:
2967         * WebView/WebIndicateLayer.mm:
2968         * WebView/WebRenderLayer.h:
2969         * WebView/WebView.mm:
2970
2971 2014-09-16  Daniel Bates  <dabates@apple.com>
2972
2973         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
2974         https://bugs.webkit.org/show_bug.cgi?id=136862
2975
2976         Reviewed by David Kilzer.
2977
2978         * Configurations/DebugRelease.xcconfig:
2979
2980 2014-09-16  Enrica Casucci  <enrica@apple.com>
2981
2982         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
2983         https://bugs.webkit.org/show_bug.cgi?id=136474
2984
2985         Reviewed by Benjamin Poulain.
2986
2987         This is the updated version of the patch that was landed in r173340.
2988         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
2989         and removes the assumption that EAffinity values match NSSelectionAffinity
2990         values. It also removes the includes in TextAffinity.h, creating the need to
2991         include explicitly the files when necessary.
2992
2993         * WebCoreSupport/WebEditorClient.h:
2994         (kit):
2995         (core):
2996
2997 2014-09-14  Daniel Bates  <dabates@apple.com>
2998
2999         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3000         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3001
3002         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3003
3004         * WebView/WebFrame.mm:
3005         (-[WebFrame focusedNodeHasContent]):
3006
3007 2014-09-14  Chris Dumez  <cdumez@apple.com>
3008
3009         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3010         https://bugs.webkit.org/show_bug.cgi?id=136789
3011
3012         Reviewed by Darin Adler.
3013
3014         Rename childNodeCount() to countChildNodes().
3015
3016         * WebView/WebHTMLView.mm:
3017         (-[WebHTMLView attributedString]):
3018
3019 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3020
3021         Re-add the request autocomplete feature
3022
3023         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3024
3025         This feature was rolled out in r148731 because it was only used by
3026         Chromium. As we consider supporting this feature, roll it back in, but
3027         leave it disabled.
3028
3029         This rolls out r148731 (which removed the feature) with small changes
3030         needed to make the code build in ToT, to match modern style, to make
3031         the tests run, and to remove unused code.
3032
3033         Reviewed by Andy Estes.
3034
3035         * Configurations/FeatureDefines.xcconfig:
3036         * WebCoreSupport/WebFrameLoaderClient.h:
3037
3038 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3039
3040         Unreviewed, rolling out r173575.
3041         https://bugs.webkit.org/show_bug.cgi?id=136790
3042
3043         Failing tests (Requested by enrica on #webkit).
3044
3045         Reverted changeset:
3046
3047         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3048         https://bugs.webkit.org/show_bug.cgi?id=136474
3049         http://trac.webkit.org/changeset/173575
3050
3051 2014-09-12  Enrica Casucci  <enrica@apple.com>
3052
3053         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3054         https://bugs.webkit.org/show_bug.cgi?id=136474
3055
3056         Reviewed by Benjamin Poulain.
3057
3058         This is the updated version of the patch that was landed in r173340.
3059         I changed the use of IntPoint to FloatPoint since it was causing tests
3060         to fail.
3061         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3062         and removes the assumption that EAffinity values match NSSelectionAffinity
3063         values. It also removes the includes in TextAffinity.h, creating the need to
3064         include explicitly the files when necessary. It also removes the unnecessary
3065         use of platform specific types, replacing them with WebCore types.
3066
3067         * WebCoreSupport/WebEditorClient.h:
3068         (kit):
3069         (core):
3070         * WebView/WebFrameView.mm:
3071         (-[WebFrameView _scrollToBeginningOfDocument]):
3072         (-[WebFrameView _scrollToEndOfDocument]):
3073
3074 2014-09-11  Bear Travis  <betravis@adobe.com>
3075
3076         [CSS Font Loading] Enable CSS Font Loading on Mac
3077         https://bugs.webkit.org/show_bug.cgi?id=135473
3078
3079         Reviewed by Antti Koivisto.
3080
3081         Enable CSS Font Loading in FeatureDefines.
3082
3083         * Configurations/FeatureDefines.xcconfig:
3084
3085 2014-09-11  Beth Dakin  <bdakin@apple.com>
3086
3087         Support rubber-banding in sub-frames
3088         https://bugs.webkit.org/show_bug.cgi?id=136726
3089         -and corresponding-
3090         rdar://problem/10011924
3091
3092         Reviewed by Tim Horton.
3093
3094         rubberBandingForOverflowScrollEnabled is re-named to
3095         rubberBandingForSubScrollableRegionsEnabled
3096         * WebView/WebView.mm:
3097         (-[WebView _preferencesChanged:]):
3098
3099 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3100
3101         Disable the "unreachable-code" warning
3102         https://bugs.webkit.org/show_bug.cgi?id=136677
3103
3104         Reviewed by Darin Adler.
3105
3106         * Configurations/Base.xcconfig:
3107
3108 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3109
3110         Fix 32-bit Mac build for new warnings
3111         https://bugs.webkit.org/show_bug.cgi?id=136624
3112
3113         Reviewed by Darin Adler.
3114         
3115         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3116
3117         * Carbon/HIViewAdapter.m:
3118         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3119
3120 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3121
3122         Remove FILTERS flag
3123         https://bugs.webkit.org/show_bug.cgi?id=136571
3124
3125         Reviewed by Darin Adler.
3126
3127         * Configurations/FeatureDefines.xcconfig:
3128
3129 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3130
3131         32-bit build fix after r173364.
3132
3133         * Carbon/HIViewAdapter.m:
3134         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3135
3136 2014-09-08  Dan Bernstein  <mitz@apple.com>
3137
3138         Build fix.
3139
3140         Added back SPI that is still in use.
3141
3142         * Misc/WebNSURLExtras.h:
3143         * Misc/WebNSURLExtras.mm:
3144         (-[NSURL _webkit_URLByRemovingFragment]):
3145
3146 2014-09-08  Dan Bernstein  <mitz@apple.com>
3147
3148         iOS Simulator build fix.
3149
3150         * Misc/WebKitSystemBits.m:
3151         (WebMemorySize):
3152
3153 2014-09-07  Darin Adler  <darin@apple.com>
3154
3155         Fix build failure seen on Mountain Lion buildbot.
3156
3157         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3158         of an int, to avoid warning about mixing signs.
3159
3160 2014-09-06  Darin Adler  <darin@apple.com>
3161
3162         Make updates suggested by new version of Xcode
3163         https://bugs.webkit.org/show_bug.cgi?id=136603
3164
3165         Reviewed by Mark Rowe.
3166
3167         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3168         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3169
3170         * History/WebURLsWithTitles.m:
3171         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3172         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3173         not turned on because it gives us too many false positives).
3174         * Misc/WebElementDictionary.mm:
3175         (-[WebElementDictionary objectForKey:]): Ditto.
3176         * Misc/WebNSDataExtras.m:
3177         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3178         (-[NSData _webkit_guessedMIMEType]): Ditto.
3179         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3180         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3181
3182         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3183         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3184         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3185         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3186         and _webkit_URLFragment methods.
3187
3188         * Misc/WebNSURLExtras.mm:
3189         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3190         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3191         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3192         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3193         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3194         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3195         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3196         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3197         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3198         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3199         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3200         (-[NSString _webkit_URLFragment]): Deleted.
3201
3202         * Plugins/WebPluginDatabase.mm:
3203         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3204         to iterate an array instead of a loop using the type "unsigned int".
3205
3206         * WebCoreSupport/WebOpenPanelResultListener.mm:
3207         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3208
3209         * WebView/WebDelegateImplementationCaching.mm:
3210         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3211         directly without a proper type for the function pointer. This might have been causing
3212         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3213         functions that were already doing this correctly.
3214
3215         * WebView/WebTextCompletionController.mm:
3216         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3217
3218 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3219
3220         Web Inspector: convert DockSide to an enum class
3221         https://bugs.webkit.org/show_bug.cgi?id=136601
3222
3223         Reviewed by Timothy Hatcher.
3224
3225         * WebCoreSupport/WebInspectorClient.mm:
3226         (WebInspectorFrontendClient::frontendLoaded):
3227         (-[WebInspectorWindowController attachWindow:]):
3228         (-[WebInspectorWindowController attach]):
3229         (-[WebInspectorWindowController detach]):
3230         * WebInspector/WebInspectorFrontend.mm:
3231         (-[WebInspectorFrontend attach]):
3232
3233 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3234
3235         Unreviewed, rolling out r173340 and r173342.
3236         https://bugs.webkit.org/show_bug.cgi?id=136596
3237
3238         Broke many tests (Requested by ap on #webkit).
3239
3240         Reverted changesets:
3241
3242         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3243         https://bugs.webkit.org/show_bug.cgi?id=136474
3244         http://trac.webkit.org/changeset/173340
3245
3246         "Build fix after r173340."
3247         http://trac.webkit.org/changeset/173342
3248
3249 2014-09-05  Enrica Casucci  <enrica@apple.com>
3250
3251         Build fix after r173340.
3252
3253         * WebCoreSupport/WebEditorClient.h:
3254         (kit):
3255         (core):
3256
3257 2014-09-05  Enrica Casucci  <enrica@apple.com>
3258
3259         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3260         https://bugs.webkit.org/show_bug.cgi?id=136474
3261
3262         Reviewed by Benjamin Poulain.
3263
3264         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3265         and removes the assumption that EAffinity values match NSSelectionAffinity
3266         values. It also removes the includes in TextAffinity.h, creating the need to
3267         include explicitly the files when necessary. It also removes the unnecessary
3268         use of platform specific types, replacing them with WebCore types.
3269
3270         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3271         * WebView/WebFrameView.mm:
3272         (-[WebFrameView _scrollToBeginningOfDocument]):
3273         (-[WebFrameView _scrollToEndOfDocument]):
3274
3275 2014-09-05  Daniel Bates  <dabates@apple.com>
3276
3277         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3278         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3279
3280         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3281
3282         * WebView/WebHTMLView.mm:
3283         (-[WebHTMLView viewDidMoveToWindow]):
3284
3285 2014-09-05  Daniel Bates  <dabates@apple.com>
3286
3287         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3288         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3289
3290         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3291         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3292
3293         * WebView/WebHTMLView.mm:
3294         (-[WebHTMLView viewDidMoveToWindow]):
3295
3296 2014-09-05  Daniel Bates  <dabates@apple.com>
3297
3298         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3299         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3300
3301         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3302
3303         * WebView/WebHTMLView.mm:
3304         (-[WebHTMLView setDataSource:]):
3305
3306 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3307
3308         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
3309         https://bugs.webkit.org/show_bug.cgi?id=136564
3310
3311         Reviewed by Dan Bernstein.
3312         
3313         WebKit1 depended on mouse moved event notifications to track mouse
3314         moves, and on being specially called by Safari to track flags
3315         changes. WebKit2 does both these things better - it uses a tracking area
3316         and event monitors. Copy those approaches.
3317
3318         * WebKit.order: Remove reference to obsolete call.
3319         * WebView/WebHTMLView.mm:
3320         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
3321         area, since we now just always have one.
3322         (-[WebHTMLViewPrivate clear]): ditto
3323         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3324         New method that posts a fake mouse move event in response to
3325         a flags change event, for use by the event monitor.
3326         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
3327         still kept around for benefit of older Safari.
3328         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
3329         special mouseover mode (previously handled in a weird way).
3330         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
3331         (-[WebHTMLView viewWillMoveToWindow:]): ditto
3332         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
3333         changed monitor.
3334         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
3335         tracking area or mouse moved observer.
3336         (-[WebHTMLView windowDidResignKey:]): ditto
3337         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
3338         moved observer.
3339         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
3340         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
3341         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
3342         up tracking area - we have to do it here, because before this point, the
3343         WebHTMLView does not know its WebView, which is where dashboard settings
3344         live.
3345         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
3346         (-[WebHTMLView addMouseMovedObserver]): Deleted.
3347         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
3348
3349 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3350
3351         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
3352         https://bugs.webkit.org/show_bug.cgi?id=136560
3353
3354         Reviewed by Joseph Pecoraro.
3355
3356         I removed the disk image caching code in r173265. However, we still have clients that call
3357         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
3358
3359         * WebView/WebPreferences.mm:
3360         (-[WebPreferences setDiskImageCacheEnabled:]):
3361         * WebView/WebPreferencesPrivate.h:
3362
3363 2014-09-03  Andy Estes  <aestes@apple.com>
3364
3365         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3366         https://bugs.webkit.org/show_bug.cgi?id=136521
3367
3368         Reviewed by Anders Carlsson.
3369
3370         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
3371
3372             s/(^ *)WEBCORE_EXPORT /\1/g
3373
3374         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
3375
3376         * MigrateHeaders.make:
3377
3378 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
3379
3380         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
3381         https://bugs.webkit.org/show_bug.cgi?id=136527
3382
3383         Reviewed by Alexey Proskuryakov.
3384
3385         * WebCoreSupport/WebSystemInterface.mm:
3386         (InitWebCoreSystemInterface):
3387
3388 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3389
3390         Remove CSS_FILTERS flag
3391         https://bugs.webkit.org/show_bug.cgi?id=136529
3392
3393         Reviewed by Dirk Schulze.
3394
3395         * Configurations/FeatureDefines.xcconfig:
3396
3397 2014-09-04  Pratik Solanki  <psolanki@apple.com>
3398
3399         Remove iOS specific disk image cache
3400         https://bugs.webkit.org/show_bug.cgi?id=136517
3401
3402         Reviewed by Antti Koivisto.
3403
3404         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
3405         this now since we don't enable it in WebKit2 on iOS.
3406
3407         * Misc/WebCache.mm:
3408         (+[WebCache statistics]):
3409         * WebView/WebDataSource.mm:
3410         (-[WebDataSource _setAllowToBeMemoryMapped]):
3411         (-[WebDataSource setDataSourceDelegate:]):
3412         (-[WebDataSource dataSourceDelegate]):
3413         (-[WebDataSource dealloc]):
3414         (BufferMemoryMapped): Deleted.
3415         * WebView/WebPreferenceKeysPrivate.h:
3416         * WebView/WebPreferences.mm:
3417         (+[WebPreferences initialize]):
3418         (-[WebPreferences diskImageCacheEnabled]): Deleted.
3419         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
3420         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
3421         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
3422         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
3423         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
3424         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
3425         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
3426         * WebView/WebPreferencesPrivate.h:
3427         * WebView/WebView.mm:
3428         (-[WebView _commonInitializationWithFrameName:groupName:]):
3429         (+[WebView _handleMemoryWarning]):
3430         (-[WebView _preferencesChanged:]):
3431
3432 2014-09-04  Daniel Bates  <dabates@apple.com>
3433
3434         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
3435         https://bugs.webkit.org/show_bug.cgi?id=136494
3436
3437         Reviewed by Andy Estes.
3438
3439         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
3440         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
3441
3442 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
3443
3444         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
3445         https://bugs.webkit.org/show_bug.cgi?id=136476
3446
3447         Reviewed by Timothy Hatcher.
3448
3449         * Misc/WebCoreStatistics.mm:
3450         (+[WebCoreStatistics shouldPrintExceptions]):
3451         (+[WebCoreStatistics setShouldPrintExceptions:]):
3452
3453 2014-09-03  Enrica Casucci  <enrica@apple.com>
3454
3455         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
3456         https://bugs.webkit.org/show_bug.cgi?id=136474
3457
3458         Reviewed by Tim Horton.
3459
3460         * WebCoreSupport/WebEditorClient.mm:
3461         (undoNameForEditAction):
3462
3463 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
3464
3465         Clean up naming for and slightly refactor legacy video fullscreen support
3466         https://bugs.webkit.org/show_bug.cgi?id=136446
3467
3468         Reviewed by Jer Noble.
3469
3470         Key changes:
3471         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
3472         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
3473         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
3474         
3475         The old versions had unnecessary parameters, did not clearly distinguish their purpose
3476         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
3477         Also changed many other places to use HTMLVideoElement* instead of Node* or 
3478         HTMLMediaElement* when they were in fact only used for video elements and would only
3479         work for such.
3480
3481         * WebCoreSupport/WebChromeClient.h:
3482         * WebCoreSupport/WebChromeClient.mm:
3483         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
3484         Also no more need to check for video elementness.
3485         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
3486         (WebChromeClient::exitVideoFullscreen): ditto
3487         * WebView/WebView.mm:
3488         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
3489         refactoring.
3490         (-[WebView _exitVideoFullscreen]): ditto
3491         (-[WebView _close]): ditto
3492         * WebView/WebViewInternal.h:
3493
3494 2014-09-03  Dan Bernstein  <mitz@apple.com>
3495
3496         Get rid of HIGH_DPI_CANVAS leftovers
3497         https://bugs.webkit.org/show_bug.cgi?id=136491
3498
3499         Reviewed by Benjamin Poulain.
3500
3501         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
3502         and removed it from FEATURE_DEFINES.
3503
3504 2014-08-31  Tim Horton  <timothy_horton@apple.com>
3505
3506         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
3507         https://bugs.webkit.org/show_bug.cgi?id=136416
3508
3509         Reviewed by Dan Bernstein.
3510
3511         * WebView/WebFrameView.mm:
3512         (-[WebFrameView drawRect:]):
3513         We only end up filling, so only set the fill color.
3514
3515 2014-08-26  Maciej Stachowiak  <mjs@apple.com>
3516
3517         Use RetainPtr::autorelease in some places where it seems appropriate
3518         https://bugs.webkit.org/show_bug.cgi?id=136280
3519
3520         Reviewed by Darin Adler.
3521
3522         * WebView/WebHTMLView.mm:
3523         (imageFromRect): Use RetainPtr in this function.
3524         * WebView/WebPDFRepresentation.mm:
3525         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
3526         in this method.
3527
3528 2014-08-29  Csaba Osztrogonác  <ossy@webkit.org>
3529
3530         Unreviwed, remove empty directories.
3531
3532         * ForwardingHeaders/wtf: Removed.
3533
3534 2014-08-27  Zalan Bujtas  <zalan@apple.com>
3535
3536         Subpixel layout: Rename LayoutRect's device pixel snapping functions.
3537         https://bugs.webkit.org/show_bug.cgi?id=136319
3538
3539         Reviewed by Simon Fraser.
3540
3541         From pixelSnappedForPainting() to snapRectToDevicePixels() and 
3542         pixelSnappedIntRect*() to snappedIntRect*().
3543
3544         No change in functionality.
3545
3546         * WebView/WebView.mm:
3547         (-[WebView _dashboardRegions]):
3548         (-[WebView trackedRepaintRects]):
3549
3550 2014-08-25  Maciej Stachowiak  <mjs@apple.com>
3551
3552         Replace use of WKCopyCFLocalizationPreferredName with NSLocale public API
3553         https://bugs.webkit.org/show_bug.cgi?id=136082
3554
3555         Reviewed by Alexey Proskuryakov.
3556
3557         * Plugins/Hosted/NetscapePluginHostManager.mm:
3558         (WebKit::NetscapePluginHostManager::spawnPluginHost): Get current
3559         localization name using WebCore helper instead of SPI.
3560         * Plugins/WebBasePluginPackage.mm: Fixed the include style for this 
3561         file.
3562         (-[WebBasePluginPackage getPluginInfoFromPLists]): Get current