1 2011-02-01 David Hyatt <hyatt@apple.com>
3 Reviewed by Oliver Hunt.
5 https://bugs.webkit.org/show_bug.cgi?id=53520
7 Remove the physical terminology from IntRect and FloatRect.
9 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
10 we need to update our terminology to be more accurate.
12 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
13 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
14 even for flipped rectangles.
16 * WebView/WebHTMLView.mm:
17 (setNeedsDisplayInRect):
19 2011-02-01 Beth Dakin <bdakin@apple.com>
21 Reviewed by Sam Weinig.
23 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
25 * WebCoreSupport/WebSystemInterface.mm:
26 (InitWebCoreSystemInterface):
28 2011-02-01 Dave Hyatt <hyatt@apple.com>
30 Reviewed by Darin Adler.
32 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
35 Change printing functions to check writing-mode and properly swap width and height
38 * WebView/WebDynamicScrollBarsView.mm:
39 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
40 * WebView/WebFrame.mm:
41 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
42 * WebView/WebFrameInternal.h:
43 * WebView/WebHTMLView.mm:
44 (-[WebHTMLView _web_setPrintingModeRecursive]):
45 (-[WebHTMLView _web_clearPrintingModeRecursive]):
46 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
47 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
48 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
49 (-[WebHTMLView _endPrintMode]):
50 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
51 (-[WebHTMLView _endScreenPaginationMode]):
52 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
53 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
54 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
55 (-[WebHTMLView _scaleFactorForPrintOperation:]):
56 (-[WebHTMLView setPageWidthForPrinting:]):
57 (-[WebHTMLView knowsPageRange:]):
59 2011-01-31 Oliver Hunt <oliver@apple.com>
61 Convert markstack to a slot visitor API
62 https://bugs.webkit.org/show_bug.cgi?id=53219
64 rolling r77098, r77099, r77100, r77109, and
65 r77111 back in, along with a few more Qt fix attempts.
67 * WebView/WebScriptDebugDelegate.mm:
68 (-[WebScriptCallFrame scopeChain]):
70 2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
72 Unreviewed, rolling out r77098, r77099, r77100, r77109, and
74 http://trac.webkit.org/changeset/77098
75 http://trac.webkit.org/changeset/77099
76 http://trac.webkit.org/changeset/77100
77 http://trac.webkit.org/changeset/77109
78 http://trac.webkit.org/changeset/77111
79 https://bugs.webkit.org/show_bug.cgi?id=53219
83 * WebView/WebScriptDebugDelegate.mm:
84 (-[WebScriptCallFrame scopeChain]):
86 2011-01-30 Oliver Hunt <oliver@apple.com>
88 Convert markstack to a slot visitor API
89 https://bugs.webkit.org/show_bug.cgi?id=53219
91 rolling r77006 and r77020 back in.
93 * WebView/WebScriptDebugDelegate.mm:
94 (-[WebScriptCallFrame scopeChain]):
96 2011-01-28 Geoffrey Garen <ggaren@apple.com>
98 Reviewed by Maciej Stachowiak.
100 Some more Heap cleanup.
101 https://bugs.webkit.org/show_bug.cgi?id=53357
103 Updated for JavaScriptCore changes.
105 * Misc/WebCoreStatistics.mm:
106 (+[WebCoreStatistics memoryStatistics]):
108 2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
110 Unreviewed, rolling out r77006 and r77020.
111 http://trac.webkit.org/changeset/77006
112 http://trac.webkit.org/changeset/77020
113 https://bugs.webkit.org/show_bug.cgi?id=53360
115 "Broke Windows tests" (Requested by rniwa on #webkit).
117 * WebView/WebScriptDebugDelegate.mm:
118 (-[WebScriptCallFrame scopeChain]):
120 2011-01-27 Oliver Hunt <oliver@apple.com>
122 Reviewed by Geoffrey Garen.
124 Convert markstack to a slot visitor API
125 https://bugs.webkit.org/show_bug.cgi?id=53219
127 Update to new marking api
129 * WebView/WebScriptDebugDelegate.mm:
130 (-[WebScriptCallFrame scopeChain]):
132 2011-01-28 Dan Bernstein <mitz@apple.com>
134 Reviewed by Sam Weinig.
136 <select> can't display right-to-left (rtl) languages
137 https://bugs.webkit.org/show_bug.cgi?id=19785
139 * WebCoreSupport/WebChromeClient.h:
140 * WebCoreSupport/WebChromeClient.mm:
141 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
142 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
144 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
146 Unreviewed, rolling out r76891.
147 http://trac.webkit.org/changeset/76891
148 https://bugs.webkit.org/show_bug.cgi?id=53280
150 Makes every layout test crash (Requested by othermaciej on
153 * Misc/WebIconDatabase.mm:
154 (-[ThreadEnabler threadEnablingSelector:]):
155 (importToWebCoreFormat):
157 2011-01-27 Nate Chapin <japhet@chromium.org>
159 Reviewed by Adam Barth.
161 Use Document::url() instead of FrameLoader::url().
162 https://bugs.webkit.org/show_bug.cgi?id=41165
164 * WebView/WebView.mm:
165 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
167 2011-01-27 Dan Bernstein <mitz@apple.com>
169 Rubber-stamped by Anders Carlsson.
171 Reverted an accidental change in r76561.
173 * WebView/WebHTMLView.mm:
175 2011-01-26 David Kilzer <ddkilzer@apple.com>
177 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
178 <rdar://problem/8821760>
180 Reviewed by Antti Koivisto.
182 * WebCoreSupport/WebSystemInterface.mm:
183 (InitWebCoreSystemInterface): Added initialization for
184 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
186 2011-01-26 Beth Dakin <bdakin@apple.com>
188 Reviewed by Darin Adler.
190 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
191 when using WKScrollbars.
193 * WebCoreSupport/WebSystemInterface.mm:
194 (InitWebCoreSystemInterface):
196 2011-01-25 Darin Adler <darin@apple.com>
198 Reviewed by Anders Carlsson.
200 WebKit is using CSBackupSetItemExcluded incorrectly
201 https://bugs.webkit.org/show_bug.cgi?id=53095
202 rdar://problem/8790540
204 * Misc/WebIconDatabase.mm:
205 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
206 It was incorrect, and this responsibility has been moved to WebCore.
208 2011-01-24 Chris Marrin <cmarrin@apple.com>
210 Reviewed by Eric Seidel.
212 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
213 https://bugs.webkit.org/show_bug.cgi?id=53041
215 * Configurations/FeatureDefines.xcconfig:
217 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
219 Reviewed by Pavel Feldman.
221 Web Inspector: remove "attached" state related methods from InspectorAgent
222 https://bugs.webkit.org/show_bug.cgi?id=53086
224 * WebCoreSupport/WebInspectorClient.h:
225 * WebCoreSupport/WebInspectorClient.mm:
226 (-[WebInspectorWindowController showWindow:]):
227 (-[WebInspectorWindowController attach]):
228 (-[WebInspectorWindowController detach]):
230 2011-01-23 Dan Bernstein <mitz@apple.com>
232 Reviewed by John Sullivan.
234 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
236 * WebCoreSupport/WebChromeClient.mm:
237 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
239 2011-01-22 Alexey Proskuryakov <ap@apple.com>
241 Reviewed by Darin Adler.
243 https://bugs.webkit.org/show_bug.cgi?id=52473
244 Auto-scaling to avoid orphans is broken, remove dysfunctional code
246 * WebView/WebHTMLView.mm:
247 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
248 (-[WebHTMLView _scaleFactorForPrintOperation:]):
249 (-[WebHTMLView knowsPageRange:]):
251 2011-01-21 Mark Rowe <mrowe@apple.com>
253 Rubber-stamped by Jon Honeycutt.
255 Fix the build when using Clang by removing some unused variables.
257 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
258 (-[WebHostedNetscapePluginView updateAndSetWindow]):
259 * WebView/WebFullScreenController.mm:
260 (-[WebFullScreenController enterFullscreen:]):
261 (-[WebFullScreenController exitFullscreen]):
263 2011-01-21 Chris Rogers <crogers@google.com>
265 Reviewed by Darin Fisher.
267 Add run-time enable support for the web audio API
268 https://bugs.webkit.org/show_bug.cgi?id=52741
270 * WebView/WebPreferenceKeysPrivate.h:
271 * WebView/WebPreferences.mm:
272 (-[WebPreferences webAudioEnabled]):
273 (-[WebPreferences setWebAudioEnabled:]):
274 * WebView/WebPreferencesPrivate.h:
275 * WebView/WebView.mm:
276 (-[WebView _preferencesChangedNotification:]):
278 2011-01-20 John Sullivan <sullivan@apple.com>
280 Reviewed by Mark Rowe.
282 Shift-tab doesn't cycle through fields in http authentication panel
283 https://bugs.webkit.org/show_bug.cgi?id=52850
285 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
286 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
287 Re-wired the key loop so that there aren't two views with the same nextKeyView.
289 2011-01-20 Beth Dakin <bdakin@apple.com>
291 Reviewed by Geoffrey Garen.
293 Fix for <rdar://problem/8890255>
295 Allow WebKitSystemInterface to draw scrollbars
297 * WebCoreSupport/WebSystemInterface.mm:
298 (InitWebCoreSystemInterface):
300 2011-01-19 Simon Fraser <simon.fraser@apple.com>
302 Reviewed by Sam Weinig.
304 GraphicsLayers in subframes can get sync'd multiple times
305 https://bugs.webkit.org/show_bug.cgi?id=52489
307 * WebView/WebView.mm:
308 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
309 was renamed to syncCompositingStateIncludingSubframes().
311 2011-01-19 Darin Adler <darin@apple.com>
313 Reviewed by Sam Weinig.
315 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
316 https://bugs.webkit.org/show_bug.cgi?id=52104
317 rdar://problem/8704226
319 * WebView/WebDelegateImplementationCaching.h:
320 Fix type of second integer in CallScriptDebugDelegate function overload
321 to be int to match the actual Objective-C method. Added a new overload
322 that includes a BOOL in the right place. Added a boolean named
323 exceptionWasRaisedExpectsHasHandlerFlag.
325 * WebView/WebDelegateImplementationCaching.mm:
326 (CallDelegate): Added overloads as above.
327 (CallScriptDebugDelegate): Ditto.
329 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
330 boolean argument. Marked the old method informally deprecated.
332 * WebView/WebScriptDebugger.mm:
333 (WebScriptDebugger::exception): Added code to call with or without the
334 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
336 * WebView/WebView.mm:
337 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
338 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
339 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
341 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
343 Reviewed by Mihai Parparita.
345 Perform some forward declaration
346 https://bugs.webkit.org/show_bug.cgi?id=52522
348 * Misc/WebKitNSStringExtras.mm:
350 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
352 Reviewed by Yury Semikhatsky.
354 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
355 https://bugs.webkit.org/show_bug.cgi?id=52721
357 * WebView/WebScriptDebugger.h:
358 * WebView/WebScriptDebugger.mm:
360 (WebScriptDebugger::sourceParsed):
362 2011-01-19 Levi Weintraub <leviw@google.com>
364 Reviewed by Ryosuke Niwa.
366 Updating to use Position::parentAnchoredEquivalent instead of
367 the old htmlediting rangeCompliantEquivalent.
369 remove rangeCompliantEquivalent and replace it with Position methods
370 https://bugs.webkit.org/show_bug.cgi?id=25057
372 * WebView/WebFrame.mm:
373 (-[WebFrame _smartDeleteRangeForProposedRange:]):
375 2011-01-18 Chris Fleizach <cfleizach@apple.com>
377 Reviewed by Darin Adler.
379 REGRESSION: A problem with Voiceover and finding links
380 https://bugs.webkit.org/show_bug.cgi?id=52324
382 * WebView/WebDynamicScrollBarsView.mm:
383 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
385 2011-01-17 David Kilzer <ddkilzer@apple.com>
387 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
389 Reviewed by Dan Bernstein.
391 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
392 DOMDocumentPrivate.h to the PrivateHeaders directory.
394 2011-01-17 Enrica Casucci <enrica@apple.com>
396 Reviewed by Alexey Proskuryakov.
398 Drag and drop support: refactoring of image from link and image from selection
399 https://bugs.webkit.org/show_bug.cgi?id=52496
401 This work cleans up the Mac code and makes it more similar to the Windows implementation,
402 avoiding the use of an NSView when the FrameView can be used.
403 The refactoring is a necessary step towards the complete support of drag and drop
406 * WebCoreSupport/WebDragClient.mm:
407 (WebDragClient::createDragImageForLink): Added.
408 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
409 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
411 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
413 Reviewed by Yury Semikhatsky.
415 Web Inspector: simplify debugger enabling routine.
416 https://bugs.webkit.org/show_bug.cgi?id=52472
418 * WebInspector/WebInspector.mm:
419 (-[WebInspector startDebuggingJavaScript:]):
421 2011-01-16 Dan Bernstein <mitz@apple.com>
423 Reviewed by Simon Fraser.
425 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
426 https://bugs.webkit.org/show_bug.cgi?id=52550
428 * Plugins/WebNetscapePluginView.mm:
429 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
430 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
432 2011-01-16 Simon Fraser <simon.fraser@apple.com>
434 Reviewed by Dan Bernstein.
436 Issues with iframes and plugins when the WebView is scaled.
437 <rdar://problem/6213380>
439 When _scaleWebView has been called on a WebView, iframes
440 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
441 This is caused by AppKit NSViews not playing nicely with the scale
442 applied through style.
444 Work around most of these issues by adjusting the bounds size
445 of widgets to allow iframe contents to paint with the correct scale,
446 and fix various places in the code where we relied on coordinate
447 transforms via NSViews (which ignore CSS transforms).
449 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
450 (-[WebHostedNetscapePluginView updateAndSetWindow]):
451 * WebView/WebFrameView.mm:
452 (-[WebFrameView setBoundsSize:]):
454 2011-01-16 Beth Dakin <bdakin@apple.com>
456 Reviewed by Kevin Decker.
458 Fix for <rdar://problem/8871204>
460 Don't try to save elasticity state. Just rely on
461 NSScrollElasticityAutomatic to restore the correct state.
462 * WebCoreSupport/WebFrameLoaderClient.h:
463 * WebCoreSupport/WebFrameLoaderClient.mm:
464 (WebFrameLoaderClient::WebFrameLoaderClient):
465 (WebFrameLoaderClient::dispatchDidFirstLayout):
466 (WebFrameLoaderClient::provisionalLoadStarted):
468 2011-01-14 Simon Fraser <simon.fraser@apple.com>
470 Reviewed by Dan Bernstein.
472 Plugins render incorrectly with transformed ancestors
473 https://bugs.webkit.org/show_bug.cgi?id=52507
475 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
476 in the ancestor chain of a plugin.
478 So use of this method with calls to -actualVisibleRectInWindow, which
479 maps rects through the render tree to compute the correct rect,
480 clipping via windowClipRect() if necessary.
482 Not testable, because doing so relies on the behavior of some
483 plugins, which stop rendering if setWindow passes an empty rect.
485 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
486 (-[WebHostedNetscapePluginView updateAndSetWindow]):
487 * Plugins/WebBaseNetscapePluginView.h:
488 * Plugins/WebBaseNetscapePluginView.mm:
489 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
490 * Plugins/WebNetscapePluginView.mm:
491 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
493 2011-01-14 Yuzo Fujishima <yuzo@google.com>
495 Reviewed by Antti Koivisto.
497 Rename cache() to memoryCache()
498 https://bugs.webkit.org/show_bug.cgi?id=52433
501 (+[WebCache statistics]):
502 (+[WebCache setDisabled:]):
503 (+[WebCache isDisabled]):
504 * WebView/WebView.mm:
505 (+[WebView _setCacheModel:]):
507 2011-01-13 Geoffrey Garen <ggaren@apple.com>
509 Reviewed by Oliver Hunt.
511 Split out a MarkedSpace strategy object from Heap.
512 https://bugs.webkit.org/show_bug.cgi?id=52421
514 * Misc/WebCoreStatistics.mm:
515 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
517 2011-01-14 Dan Bernstein <mitz@apple.com>
519 Reviewed by Simon Fraser.
521 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
523 * WebView/WebHTMLView.mm:
524 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
525 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
526 that the NSView tree doesn’t change from under AppKit as it traverses it.
528 2011-01-14 Beth Dakin <bdakin@apple.com>
530 Reviewed by Mark Rowe.
532 Fix for <rdar://problem/7793902> Artifacts when scrolling
533 page in Safari while page is loading
535 Call setDrawsBackground:YES on the scrollView in
536 dispatchDidFirstLayout() rather than waiting until
537 frameLoadCompleted(). Also suspend scrolling elasticity
538 between provisionalLoadStarted() and dispatchDidFirstLayout()
539 * WebCoreSupport/WebFrameLoaderClient.h:
540 * WebCoreSupport/WebFrameLoaderClient.mm:
541 (WebFrameLoaderClient::WebFrameLoaderClient):
542 (WebFrameLoaderClient::dispatchDidFirstLayout):
543 (WebFrameLoaderClient::provisionalLoadStarted):
545 2011-01-12 Enrica Casucci <enrica@apple.com>
547 Reviewed by Darin Adler.
549 WebKit2: Add support for drag and drop
550 https://bugs.webkit.org/show_bug.cgi?id=52343
551 <rdar://problem/7660558>
553 The DragData class has been extended to provide
554 additional context from the application (keyboard state, modal windows, etc.)
555 as well as information of the drag pasteboard being used.
556 These are the changes to align the behavior for WebKit.
558 * WebView/WebView.mm:
559 (-[WebView applicationFlags:]): Added.
560 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
561 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
562 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
563 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
565 2011-01-12 Beth Dakin <bdakin@apple.com>
567 Reviewed by Anders Carlsson.
569 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
570 Expose fixed layout through WebKit SPI
572 <rdar://problem/8844464>
574 And now with getters!
575 * WebView/WebView.mm:
576 (-[WebView _useFixedLayout]):
577 (-[WebView _fixedLayoutSize]):
578 * WebView/WebViewPrivate.h:
580 2011-01-12 Beth Dakin <bdakin@apple.com>
582 Reviewed by Anders Carlsson.
584 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
585 fixed layout through WebKit SPI
587 <rdar://problem/8844464>
589 * WebView/WebView.mm:
590 (-[WebView _setUseFixedLayout:]):
591 (-[WebView _setFixedLayoutSize:]):
592 * WebView/WebViewPrivate.h:
594 2011-01-07 Enrica Casucci <enrica@apple.com>
596 Reviewed by Alexey Proskuryakov.
598 Paste and drag and drop use different code paths to interact with the pasteboard.
599 https://bugs.webkit.org/show_bug.cgi?id=52093
600 The change consists in a refactoring of the code to have only one class that
601 deals with the pasteboard on Mac.
603 * WebCoreSupport/WebEditorClient.h:
604 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
605 exposed by NSURLExtras.
606 (WebEditorClient::canonicalizeURL):
607 (WebEditorClient::canonicalizeURLString):
608 * WebCoreSupport/WebPasteboardHelper.h: Removed.
609 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
610 * WebView/WebHTMLView.mm: Removed comment.
611 * WebView/WebView.mm: The following methods have been changed to use the new DragData
612 constructor that doesn't use the WebPasteboardHelper reference.
613 (-[WebView draggingEntered:]):
614 (-[WebView draggingUpdated:]):
615 (-[WebView draggingExited:]):
616 (-[WebView performDragOperation:]):
618 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
620 Reviewed by Alexey Proskuryakov.
622 Forward declare some headers where possible
623 https://bugs.webkit.org/show_bug.cgi?id=52133
625 * WebView/WebFrame.mm:
627 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
629 Reviewed by Darin Fisher.
631 https://bugs.webkit.org/show_bug.cgi?id=41441
632 createWindow method should only do window-creating without URL navigation
634 * WebCoreSupport/WebChromeClient.mm:
635 (WebChromeClient::createWindow):
637 2011-01-08 Dan Bernstein <mitz@apple.com>
639 Try to fix the Leopard build.
641 * WebView/WebFullScreenController.mm:
643 2011-01-07 Jer Noble <jer.noble@apple.com>
645 Yet another Leopard build fix: NSRect and CGRect are not inter-
648 * WebView/WebFullScreenController.mm:
649 (-[WebFullScreenController exitFullscreen]):
651 2011-01-07 Jer Noble <jer.noble@apple.com>
653 Fix the Leopard build: Replace CoreAnimation SL-only functions
654 with Leopard equivalents.
656 * WebView/WebFullScreenController.mm:
657 (+[CATransaction setDisableActions:]):
658 (+[CATransaction setAnimationDuration:]):
659 (-[WebFullScreenController _animationDuration]):
660 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
662 2010-12-21 Jer Noble <jer.noble@apple.com>
664 Reviewed by Simon Fraser.
666 Implement WebKit Full Screen support.
667 https://bugs.webkit.org/show_bug.cgi?id=49481
668 rdar://problem/8247444
670 Support the new fullscreen Chrome client requests. WebView will pass
671 through these requests to a WebFullscreenController.
673 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
674 * WebView/WebView.mm:
675 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
676 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
677 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
678 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
679 * WebView/WebViewData.h: Add ivar newFullscreenController.
681 2010-12-17 Jer Noble <jer@kokode.apple.com>
683 Reviewed by Simon Fraser.
685 Implement WebKit Full Screen support.
686 https://bugs.webkit.org/show_bug.cgi?id=49481
687 rdar://problem/8247444
689 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
690 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
691 window, and a custom CAAnimation animates that layer between the initial screen rect of the
692 full screen element, to its final value. WebFullscreenController will swap the WebView out of
693 its original window, and into the fullscreen window. The controller will replace the WebView
694 with a placeholder view, so that if the placeholder moves or resized while the WebView is
695 absent, the WebView will move back to the correct location when exiting fullscreen.
697 * WebView/WebFullscreenController.h: Added.
698 * WebView/WebFullscreenController.mm: Added.
699 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
700 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
701 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
702 (-[WebFullscreenController applicationDidResignActive:]):
703 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
704 the new screen parameters.
705 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
706 from its original screen rect into fullscreen.
707 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
708 Set up the animation that will take the fullscreen element back into its original screen
710 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
711 whether to disable screensaver and sleep.
712 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
713 looking for HTMLVideoElements; returns whether any are found to be playing.
714 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
716 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
717 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
718 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
719 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
720 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
721 (-[WebFullscreenWindow backgroundLayer]): Ditto.
722 (-[WebFullscreenWindow animationView]): Ditto.
723 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
724 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
726 2011-01-07 James Robinson <jamesr@chromium.org>
728 Revert "Implement mozilla's animationTime property"
729 https://bugs.webkit.org/show_bug.cgi?id=51952
731 This approach isn't quite right.
733 * WebView/WebHTMLView.mm:
734 (-[WebHTMLView drawRect:]):
735 * WebView/WebView.mm:
736 (layerSyncRunLoopObserverCallBack):
738 2011-01-06 Gavin Barraclough <barraclough@apple.com>
740 Reviewed by Geoff Garen.
742 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
744 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
745 destructor early, in order to release wrappers once we know we no longer intend to use them.
746 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
747 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
748 A sequence of events that triggers the bug would look like this:
750 (1) Create a DOMWrapperWorld.
751 (2) Register a timer in the world.
752 (3) Call unregisterWorld() on the world.
753 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
754 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
755 called forgetWorld() none exists.
756 (6) Attempt to add a wrapper to a NULL map.
758 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
760 * WebView/WebScriptWorld.mm:
761 (-[WebScriptWorld unregisterWorld]):
763 2011-01-04 Chris Fleizach <cfleizach@apple.com>
765 Reviewed by Sam Weinig.
767 WK2: Support Accessibility
768 https://bugs.webkit.org/show_bug.cgi?id=51859
770 Use rootObject() method to get top of AX tree.
772 * WebCoreSupport/WebFrameLoaderClient.h:
773 (WebFrameLoaderClient::accessibilityRemoteObject):
774 * WebView/WebFrame.mm:
775 (-[WebFrame setAccessibleName:]):
776 (-[WebFrame accessibilityRoot]):
777 * WebView/WebFrameInternal.h:
778 * WebView/WebFramePrivate.h:
779 * WebView/WebHTMLView.mm:
780 (-[WebHTMLView accessibilityAttributeValue:]):
781 (-[WebHTMLView accessibilityFocusedUIElement]):
782 (-[WebHTMLView accessibilityHitTest:]):
783 (-[WebHTMLView _accessibilityParentForSubview:]):
785 2011-01-04 David Kilzer <ddkilzer@apple.com>
787 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
789 Reviewed by Eric Carlson.
791 This originally broke in r61581. It is inside an
792 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
795 * WebCoreSupport/WebFrameLoaderClient.mm: Call
796 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
797 use WebCore::PluginInfo.name instead of
798 -[WebBasePluginPackage name].
800 2011-01-02 Dan Bernstein <mitz@apple.com>
802 Rubber-stamped by Simon Fraser.
804 <rdar://problem/8812159> Update copyright strings
808 2010-12-29 Dan Bernstein <mitz@apple.com>
810 Reviewed by Ada Chan.
812 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
813 https://bugs.webkit.org/show_bug.cgi?id=51717
815 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
816 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
818 * WebView/WebDocumentInternal.h:
819 * WebView/WebHTMLView.mm:
820 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
821 (-[WebHTMLView _findString:options:]):
822 * WebView/WebView.mm:
825 2010-12-28 Daniel Bates <dbates@rim.com>
827 Reviewed by Sam Weinig.
829 Substitute // MARK: for compiler-specific #pragma mark
830 https://bugs.webkit.org/show_bug.cgi?id=51657
832 For consistency, we should substitute "// MARK:" for compiler-
833 specific "#pragma mark" in the source files for the Mac port.
835 * History/WebHistory.mm:
836 * Plugins/WebBaseNetscapePluginView.mm:
837 * Plugins/WebNetscapePluginView.mm:
838 * WebCoreSupport/WebInspectorClient.mm:
839 * WebCoreSupport/WebSecurityOrigin.mm:
840 * WebView/WebPDFView.mm:
841 * WebView/WebVideoFullscreenController.mm:
842 * WebView/WebVideoFullscreenHUDWindowController.mm:
844 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
846 Reviewed by Darin Adler.
848 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
849 https://bugs.webkit.org/show_bug.cgi?id=38535
851 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
852 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
853 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
854 call frame from this stack when an exception throws because the saved top frame could be invalid.
856 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
857 callEvent and returnEvent.
859 * WebView/WebScriptDebugger.mm:
860 (WebScriptDebugger::willExecuteProgram):
861 (WebScriptDebugger::didExecuteProgram):
863 2010-12-22 Sam Weinig <sam@webkit.org>
865 Reviewed by Darin Adler.
867 WebKit2 needs to mirror the frame tree in the UIProcess
868 https://bugs.webkit.org/show_bug.cgi?id=51546
870 - Add client functions to notify that a frame has been added or
871 removed from the page cache.
873 * WebCoreSupport/WebFrameLoaderClient.h:
874 * WebCoreSupport/WebFrameLoaderClient.mm:
875 (WebFrameLoaderClient::didSaveToPageCache):
876 (WebFrameLoaderClient::didRestoreFromPageCache):
878 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
880 Reviewed by Eric Seidel.
882 Editor.h doesn't need to include SelectionController.h
883 https://bugs.webkit.org/show_bug.cgi?id=51441
885 Renamed SelectionController::EDirection to SelectionDirection.
887 * WebView/WebFrame.mm:
888 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
889 Takes SelectionDirection instead of SelectionController::EDirection.
890 * WebView/WebFrameInternal.h:
891 * WebView/WebTextCompletionController.mm:
892 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
894 2010-12-22 Simon Fraser <simon.fraser@apple.com>
896 Reviewed by Darin Adler.
898 Cache snapshots of plug-ins before painting, to avoid script running during painting
899 https://bugs.webkit.org/show_bug.cgi?id=51493
901 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
902 or when printing), plug-ins which otherwise use the CA rendering model
903 are sent a paint event. Some plug-ins may run script while handling this event,
904 or out of process plug-ins may process queued requests at this time. Running
905 script while inside layout or painting can have bad consequences, because it
906 can result in arbitrary changes to the render tree.
908 This patch avoids sending plug-ins paint events inside of painting. Instead,
909 we ask the plug-ins to cache a snapshot before we paint, and then the software
910 paint simply draws that snapshot.
912 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
913 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
914 draw it. Also only send the snapshot message to the plugin proxy if we
915 know we're snapshotting, since even if creating the snapshot image failed,
916 we still don't want to call to the plug-in.
918 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
919 * Plugins/WebBaseNetscapePluginView.mm:
920 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
921 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
923 * Plugins/WebNetscapePluginView.mm:
924 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
925 * WebCoreSupport/WebFrameLoaderClient.mm:
926 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
927 to cache and clear the snapshots.
929 2010-12-21 Cameron Zwarich <zwarich@apple.com>
931 Reviewed by Darin Adler.
933 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
934 https://bugs.webkit.org/show_bug.cgi?id=51431
935 <rdar://problem/8791757>
937 * Plugins/WebBasePluginPackage.mm:
938 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
939 it doesn't underflow.
941 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
943 Reviewed by Cameron Zwarich.
945 REGRESSION(r74172): 125 java tests fail on Mac
946 https://bugs.webkit.org/show_bug.cgi?id=51214
948 The regression was caused by an incorrectly adding sizeof(struct fat_header)
949 to a pointer for uint32_t as supposed to uint8_t.
951 Fixed the bug by explicitly casting it to uint8_t* before the addition.
953 * Plugins/WebBasePluginPackage.mm:
954 (-[WebBasePluginPackage isNativeLibraryData:]):
956 2010-12-15 Cameron Zwarich <zwarich@apple.com>
958 Reviewed by Darin Adler.
960 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
961 https://bugs.webkit.org/show_bug.cgi?id=51144
963 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
964 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
965 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
966 inline storage is at the beginning of the Vector, it is still better to fix this
967 and silence the warning.
969 * Plugins/WebBasePluginPackage.mm:
971 (-[WebBasePluginPackage isNativeLibraryData:]):
973 2010-12-14 Mark Rowe <mrowe@apple.com>
975 Reviewed by Sam Weinig.
977 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
979 * History/WebHistoryItem.mm:
980 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
981 always including the target in the output.
983 2010-12-13 Alexey Proskuryakov <ap@apple.com>
985 Reviewed by Adam Barth.
987 https://bugs.webkit.org/show_bug.cgi?id=50953
988 DNS Prefetch should be an opt-in feature
990 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
992 2010-12-13 Mike Thole <mthole@apple.com>
994 Rubber-stamped by John Sullivan.
996 https://bugs.webkit.org/show_bug.cgi?id=50956
997 WebAuthenticationPanel.nib appears to have a cut-off sentence
999 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
1000 The contents of this text field are updated dynamically before the sheet is displayed.
1002 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1003 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1005 2010-12-13 Antti Koivisto <antti@apple.com>
1007 Reviewed by Alexey Proskuryakov.
1009 https://bugs.webkit.org/show_bug.cgi?id=50758
1010 <rdar://problem/8722094>
1011 Defer loading print stylesheets
1013 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
1015 * WebView/WebView.mm:
1016 (+[WebView _setLoadResourcesSerially:forHost:]):
1017 * WebView/WebViewPrivate.h:
1019 2010-12-09 Matthew Delaney <mdelaney@apple.com>
1021 Reviewed by Simon Fraser.
1023 Adopt new CG API for canvas
1024 https://bugs.webkit.org/show_bug.cgi?id=50591
1026 * WebCoreSupport/WebSystemInterface.mm:
1028 2010-10-28 MORITA Hajime <morrita@google.com>
1030 Reviewed by Ojan Vafai.
1032 spellcheck does not check pasted text
1033 https://bugs.webkit.org/show_bug.cgi?id=40092
1035 Added asynchronous spell checking API to WebEditorClient using
1036 -[NSSpellChecker requestCheckingOfString].
1037 Note that WebEditorSpellCheckResponder is a small class to receive
1038 requested spell-checking result. Note that this feature is
1039 disabled at default.
1041 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
1042 enable the feature from LayoutTestController.
1044 * WebCoreSupport/WebEditorClient.h:
1045 * WebCoreSupport/WebEditorClient.mm:
1046 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
1047 (-[WebEditorSpellCheckResponder perform]):
1048 (toCoreSpellingResult):
1049 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
1050 (WebEditorClient::requestCheckingOfString):
1051 * WebView/WebPreferenceKeysPrivate.h:
1052 * WebView/WebPreferences.mm:
1053 (+[WebPreferences initialize]):
1054 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
1055 (-[WebPreferences asynchronousSpellCheckingEnabled]):
1056 * WebView/WebPreferencesPrivate.h:
1057 * WebView/WebView.mm:
1058 (-[WebView _preferencesChangedNotification:]):
1060 2010-12-09 Anders Carlsson <andersca@apple.com>
1062 Fix a bug uncovered by clang++.
1064 * WebView/WebHTMLView.mm:
1065 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1067 2010-12-09 Anders Carlsson <andersca@apple.com>
1069 Clang++ build fixes.
1071 Silence a couple of warnings.
1073 * WebView/WebFrame.mm:
1074 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1075 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1076 * WebView/WebTextCompletionController.mm:
1077 (-[WebTextCompletionController filterKeyDown:]):
1079 2010-12-09 David Hyatt <hyatt@apple.com>
1081 Reviewed by Dan Bernstein.
1083 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
1084 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
1086 * WebView/WebFrameView.mm:
1087 (-[WebFrameView _isVerticalDocument]):
1088 (-[WebFrameView _isFlippedDocument]):
1089 (-[WebFrameView _scrollToEndOfDocument]):
1090 (-[WebFrameView _pageInBlockProgressionDirection:]):
1091 (-[WebFrameView scrollPageUp:]):
1092 (-[WebFrameView scrollPageDown:]):
1094 2010-12-08 Andy Estes <aestes@apple.com>
1096 Reviewed by Darin Adler.
1098 Enable pre-HTML5 parser quirks for Apple Mail.app
1099 https://bugs.webkit.org/show_bug.cgi?id=50727
1101 * WebView/WebView.mm:
1102 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
1103 application is Mail.app.
1105 2010-12-08 Brian Weinstein <bweinstein@apple.com>
1107 Reviewed by John Sullivan.
1109 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
1110 https://bugs.webkit.org/show_bug.cgi?id=50683
1112 If our context menu item already has an action, don't overwrite the action with the context menu
1115 * WebView/WebHTMLView.mm:
1116 (setMenuItemTarget):
1118 2010-12-08 Anders Carlsson <andersca@apple.com>
1120 Remove an unused variable.
1122 * WebView/WebDynamicScrollBarsView.mm:
1123 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
1125 2010-12-07 Brian Weinstein <bweinstein@apple.com>
1127 Reviewed by John Sullivan.
1129 Layering Violation in ContextMenu - member variable of type HitTestResult
1130 https://bugs.webkit.org/show_bug.cgi?id=50586
1132 Update users of ContextMenu and ContextMenuController to match where the new functions
1135 * WebCoreSupport/WebContextMenuClient.mm:
1136 (WebContextMenuClient::getCustomMenuFromDefaultItems):
1137 (WebContextMenuClient::contextMenuItemSelected):
1138 * WebView/WebHTMLView.mm:
1139 (-[WebMenuTarget validateMenuItem:]):
1141 2010-12-07 Brian Weinstein <bweinstein@apple.com>
1143 Reviewed by John Sullivan.
1145 Part of Layering Violation in ContextMenu
1146 https://bugs.webkit.org/show_bug.cgi?id=50586
1148 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
1149 was a layering violation. Also, make sure we set the menu item targets for all menu
1150 items before showing them, because the ContextMenu constructor doesn't do that anymore.
1152 * WebView/WebHTMLView.mm:
1153 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
1154 (-[WebMenuTarget WebCore::]): Ditto.
1155 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
1156 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
1157 (-[WebMenuTarget validateMenuItem:]): Ditto.
1159 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
1160 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
1161 submenus), and calls setMenuItemTarget on them.
1162 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
1165 2010-12-06 Darin Adler <darin@apple.com>
1167 Reviewed by Sam Weinig.
1169 Pass security origin to make local file decision correctly
1170 https://bugs.webkit.org/show_bug.cgi?id=48603
1172 * WebView/WebPDFView.mm:
1173 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
1175 2010-12-07 Martin Robinson <mrobinson@igalia.com>
1177 Unreviewed, rolling out r73392.
1178 http://trac.webkit.org/changeset/73392
1179 https://bugs.webkit.org/show_bug.cgi?id=50489
1181 This commit caused crashes on the GTK+ bots
1183 * WebView/WebFrame.mm:
1184 (-[WebFrame _canProvideDocumentSource]):
1186 2010-12-07 Kenichi Ishibashi <bashi@google.com>
1188 Reviewed by Kent Tamura.
1190 Let HTMLObjectElement be a form associated element
1191 https://bugs.webkit.org/show_bug.cgi?id=48821
1193 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
1195 * WebView/WebHTMLRepresentation.mm:
1196 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
1197 FormAssociatedElement instead of HTMLFormControlElement.
1198 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1200 2010-12-06 Nate Chapin <japhet@chromium.org>
1202 Reviewed by Adam Barth.
1204 Update calls to DocumentWriter.
1205 https://bugs.webkit.org/show_bug.cgi?id=50489
1207 * WebView/WebFrame.mm:
1208 (-[WebFrame _canProvideDocumentSource]):
1210 2010-12-06 Chris Marrin <cmarrin@apple.com>
1212 Reviewed by Simon Fraser.
1214 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1215 https://bugs.webkit.org/show_bug.cgi?id=49388
1217 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
1218 GraphicsLayer::platformLayer().
1220 * WebCoreSupport/WebChromeClient.mm:
1221 (WebChromeClient::attachRootGraphicsLayer):
1223 2010-12-04 Dan Bernstein <mitz@apple.com>
1225 Reviewed by Sam Weinig.
1227 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
1228 https://bugs.webkit.org/show_bug.cgi?id=50530
1230 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
1231 * WebView/WebHTMLView.mm:
1232 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
1233 which is passed through to WebCore.
1234 * WebView/WebPDFView.mm:
1235 (isFrameInRange): Added this helper function.
1236 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
1237 a check if the frame is in the range.
1238 * WebView/WebView.mm:
1239 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
1240 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
1241 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
1242 * WebView/WebViewPrivate.h:
1244 2010-12-03 Sam Weinig <sam@webkit.org>
1246 Reviewed by Maciej Stachowiak.
1248 Enable <a ping> for Mac/Windows/WebKit2 builds
1249 <rdar://problem/8504473>
1250 https://bugs.webkit.org/show_bug.cgi?id=50488
1252 * WebView/WebPreferences.mm:
1253 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
1255 2010-12-03 Jia Pu <jpu@apple.com>
1257 Reviewed by Darin Adler.
1259 Need to move all code that applies correction into correction panel callback.
1260 https://bugs.webkit.org/show_bug.cgi?id=50426
1261 <rdar://problem/8720832>
1263 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
1265 * WebCoreSupport/WebEditorClient.mm:
1266 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
1267 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
1268 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
1270 2010-12-02 Simon Fraser <simon.fraser@apple.com>
1272 Revert r73217 and r73227 because of continued bustage.
1274 * WebCoreSupport/WebChromeClient.mm:
1275 (WebChromeClient::attachRootGraphicsLayer):
1277 2010-12-02 Chris Marrin <cmarrin@apple.com>
1279 Reviewed by Simon Fraser.
1281 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1282 https://bugs.webkit.org/show_bug.cgi?id=49388
1284 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
1285 GraphicsLayer::platformLayer().
1287 * WebCoreSupport/WebChromeClient.mm:
1288 (WebChromeClient::attachRootGraphicsLayer):
1290 2010-12-02 Mark Rowe <mrowe@apple.com>
1292 Reviewed by Beth Dakin.
1294 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
1296 * Misc/WebNSFileManagerExtras.m:
1297 (setMetaData): Create an autorelease pool for the duration of the thread body.
1299 2010-12-02 John Knottenbelt <jknotten@chromium.org>
1301 Reviewed by Steve Block.
1303 Move requestGeolocationPermissionForFrame to GeolocationClient
1304 https://bugs.webkit.org/show_bug.cgi?id=50061
1306 This change facilitates client-based geolocation implementation by
1307 bringing together permission control into the geolocation client
1310 Move method ChromeClient::requestGeolocationPermissionForFrame to
1311 GeolocationClient::requestPermission, and supporting class
1312 WebGeolocationPolicyListener. The moved code is unchanged except
1313 that requestPermission now takes only one argument (Geolocation*)
1314 and the Frame parameter is retrieved from the Geolocation object.
1316 * WebCoreSupport/WebChromeClient.h:
1317 * WebCoreSupport/WebChromeClient.mm:
1318 * WebCoreSupport/WebGeolocationClient.h:
1319 (WebGeolocationClient::cancelPermissionRequest):
1320 * WebCoreSupport/WebGeolocationClient.mm:
1321 (WebGeolocationClient::requestPermission):
1322 (-[WebGeolocationPolicyListener initWithGeolocation:]):
1323 (-[WebGeolocationPolicyListener allow]):
1324 (-[WebGeolocationPolicyListener deny]):
1326 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
1328 Reviewed by Eric Carlson.
1330 Style Fixes in WebPluginController
1331 https://bugs.webkit.org/show_bug.cgi?id=50397
1333 * Plugins/WebPluginController.mm:
1334 (-[WebPluginController startAllPlugins]):
1335 (-[WebPluginController stopAllPlugins]):
1337 2010-12-02 John Sullivan <sullivan@apple.com>
1339 Reviewed by Adam Roben.
1341 Slightly speculative fix for:
1343 <rdar://problem/8712674>
1344 <https://bugs.webkit.org/show_bug.cgi?id=50393>
1345 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
1347 * Panels/WebAuthenticationPanel.m:
1348 (-[WebAuthenticationPanel setUpForChallenge:]):
1349 If the realm is nil, use @"" instead.
1351 2010-12-01 Jia Pu <jpu@apple.com>
1353 Reviewed by Darin Adler.
1355 Support multiple correction candidates panel for misspelled word on Mac OS X.
1356 https://bugs.webkit.org/show_bug.cgi?id=50137
1357 <rdar://problem/8568059>
1359 This patch is for supporting multiple correction suggestion panel on Mac OS X.
1360 The behavior and implementation is similar to that of reversion candiate panel.
1362 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
1364 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
1365 Added code to handle new multiple suggestion canidate panel type.
1366 (WebEditorClient::showCorrectionPanel):
1367 (WebEditorClient::getGuessesForWord):
1369 2010-12-01 David Hyatt <hyatt@apple.com>
1371 Reviewed by Darin Adler.
1373 https://bugs.webkit.org/show_bug.cgi?id=46645
1375 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
1376 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
1377 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
1379 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
1380 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
1383 * WebView/WebDynamicScrollBarsView.mm:
1384 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
1385 (-[WebDynamicScrollBarsView updateScrollers]):
1386 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
1387 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
1388 (-[WebDynamicScrollBarsView scrollOrigin]):
1389 * WebView/WebFrameView.mm:
1390 (-[WebFrameView _scrollToBeginningOfDocument]):
1391 (-[WebFrameView _scrollToEndOfDocument]):
1393 2010-11-29 Dan Bernstein <mitz@apple.com>
1395 Reviewed by Darin Adler.
1397 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
1398 https://bugs.webkit.org/show_bug.cgi?id=50038
1399 Based on a patch from Darin Adler.
1401 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
1402 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
1403 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
1404 method. Made WebHTMLView conform to the new protocol.
1405 * WebView/WebHTMLView.mm:
1406 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
1407 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
1408 -findString:options:.
1409 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
1410 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
1411 * WebView/WebPDFView.mm:
1412 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
1413 * WebView/WebView.mm:
1414 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
1415 -countMatchesForText:options:highlight:limit:markMatches.
1416 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
1417 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
1418 -findString:options:.
1419 (incrementFrame): Changed to use WebFindOptions.
1420 (findString): Added this helper method that performs the search using the best supported
1421 method for the document view.
1422 (-[WebView findString:options:]): Changed -searchFor::::: into this.
1423 (-[WebView canMarkAllTextMatches]):
1424 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
1426 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
1427 (-[WebView rectsForTextMatches]): Ditto.
1428 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
1429 of countMatchesForText:.
1431 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
1433 Reviewed by David Hyatt.
1435 Right-to-left pages should be scrollable to reveal left overflow.
1436 https://bugs.webkit.org/show_bug.cgi?id=23556
1438 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
1439 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
1440 pages with a left overflow.
1442 * WebView/WebDynamicScrollBarsView.h:
1443 * WebView/WebDynamicScrollBarsView.mm:
1444 (-[WebDynamicScrollBarsView inProgramaticScroll]):
1445 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
1446 (-[WebDynamicScrollBarsView updateScrollers]):
1447 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
1448 (-[WebDynamicScrollBarsView setScrollOriginX:]):
1449 (-[WebDynamicScrollBarsView scrollOriginX]):
1450 * WebView/WebFrameView.mm:
1451 (-[WebFrameView _scrollToBeginningOfDocument]):
1452 (-[WebFrameView _scrollToEndOfDocument]):
1453 * WebView/WebHTMLView.mm:
1454 (-[WebHTMLView _frameOrBoundsChanged]):
1456 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
1458 Reviewed by Tony Chang.
1460 SelectionController::typingStyle() should return EditingStyle*
1461 https://bugs.webkit.org/show_bug.cgi?id=49813
1463 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
1464 Also added SelectionController::copyTypingStyle() to copy the typing style
1465 as an instance of CSSMutableStyleDeclaration.
1467 No tests are added since this is no behavioral change.
1469 * WebView/WebFrame.mm:
1470 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
1472 2010-11-19 Michael Saboff <msaboff@apple.com>
1474 Reviewed by Sam Weinig
1476 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
1478 * MigrateHeaders.make:
1480 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
1482 Reviewed by Dirk Schulze.
1484 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
1485 https://bugs.webkit.org/show_bug.cgi?id=49580
1487 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
1489 2010-11-18 Mark Rowe <mrowe@apple.com>
1491 Rubber-stamped by Adam Roben.
1493 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
1495 * Configurations/WebKit.xcconfig:
1497 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
1499 Unreviewed, rolling out r72288.
1500 http://trac.webkit.org/changeset/72288
1501 https://bugs.webkit.org/show_bug.cgi?id=49730
1503 'krit attempted to do that, but revert got stuck' (Requested
1504 by antonm on #webkit).
1506 * WebView/WebRenderLayer.mm:
1508 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
1510 Reviewed by Dirk Schulze.
1512 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
1513 https://bugs.webkit.org/show_bug.cgi?id=49580
1515 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
1517 2010-11-16 Stephanie Lewis <slewis@apple.com>
1519 Reviewed by Geoff Garen.
1521 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1523 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
1524 every WebView, and the WebKit API doesn't support that ownership model.
1526 * WebView/WebDeviceOrientationProviderMock.h:
1527 * WebView/WebDeviceOrientationProviderMock.mm:
1528 (+[WebDeviceOrientationProviderMock shared]):
1530 2010-11-16 Dave Hyatt <hyatt@apple.com>
1532 Reviewed by Dan Bernstein.
1534 https://bugs.webkit.org/show_bug.cgi?id=11004
1536 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
1537 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
1538 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
1539 of the constructor rather than using [NSFont pointSize].
1541 https://bugs.webkit.org/show_bug.cgi?id=49582
1543 Negative leading is not handled correctly. There are two bugs here. The first is that
1544 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
1545 set them before so that we can allow them to be < 0.
1547 The second issue is that we should understand where fonts will end up relative to
1548 our baseline (excluding line height), and only allow those boxes to impact ascent and
1549 descent if the actual font box (without factoring in line height) is above or below the
1550 root line box baseline.
1552 Added fast/css/negative-leading.html
1554 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
1556 * Misc/WebKitNSStringExtras.mm:
1557 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1558 (-[NSString _web_widthWithFont:]):
1559 * Misc/WebStringTruncator.mm:
1561 * WebView/WebPreferences.mm:
1562 (+[WebPreferences initialize]):
1564 2010-11-16 Anders Carlsson <andersca@apple.com>
1568 * WebCoreSupport/WebFrameLoaderClient.mm:
1570 2010-11-14 Kent Tamura <tkent@chromium.org>
1572 Reviewed by Andreas Kling.
1574 KeyboardEvent::keyIdentifier() should return "const String&"
1575 https://bugs.webkit.org/show_bug.cgi?id=49426
1577 * WebCoreSupport/WebEditorClient.mm:
1578 (selectorForKeyEvent):
1579 Change the type of a variable to have keyIdentifier(); String -> const String&
1581 2010-11-12 John Knottenbelt <jknotten@chromium.org>
1583 Reviewed by Steve Block.
1585 Rename GeolocationControllerClient to GeolocationClient.
1586 https://bugs.webkit.org/show_bug.cgi?id=49259
1588 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
1589 (WebGeolocationClient::webView):
1590 (WebGeolocationClient::setEnableHighAccuracy):
1591 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
1592 (WebGeolocationClient::WebGeolocationClient):
1593 (WebGeolocationClient::geolocationDestroyed):
1594 (WebGeolocationClient::startUpdating):
1595 (WebGeolocationClient::stopUpdating):
1596 (WebGeolocationClient::lastPosition):
1598 * WebView/WebView.mm:
1599 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1601 2010-11-10 Beth Dakin <bdakin@apple.com>
1603 Reviewed by Simon Fraser.
1605 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
1606 -[WebView _scaleWebView:] should take and origin and scroll the
1609 <rdar://problem/8643921>
1611 * WebView/WebView.mm:
1612 (-[WebView _scaleWebView:atOrigin:]):
1613 * WebView/WebViewPrivate.h:
1615 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
1617 Reviewed by David Hyatt.
1619 HTML5 Ruby support should be mandatory feature
1620 https://bugs.webkit.org/show_bug.cgi?id=49272
1622 Remove Ruby as optional feature.
1624 * Configurations/FeatureDefines.xcconfig:
1626 2010-11-08 Ned Holbrook <nholbrook@apple.com>
1628 Reviewed by Adam Barth.
1630 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
1631 https://bugs.webkit.org/show_bug.cgi?id=48886
1633 * WebCoreSupport/WebSystemInterface.mm:
1634 (InitWebCoreSystemInterface):
1636 2010-11-08 Nate Chapin <japhet@chromium.org>
1638 Unreviewed, build fix.
1640 Clumsy typo in r71562.
1642 * Plugins/Hosted/HostedNetscapePluginStream.mm:
1643 (WebKit::HostedNetscapePluginStream::start):
1645 2010-11-08 Nate Chapin <japhet@chromium.org>
1647 Reviewed by Alexey Proskuryakov.
1649 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
1651 * Plugins/Hosted/HostedNetscapePluginStream.mm:
1652 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
1653 * Plugins/WebNetscapePluginStream.mm:
1654 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
1655 * WebView/WebView.mm:
1656 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
1658 2010-11-08 Anders Carlsson <andersca@apple.com>
1660 Reviewed by Dan Bernstein.
1662 Plug-in views should not assume that plugins are RenderEmbeddedObjects
1663 https://bugs.webkit.org/show_bug.cgi?id=49196
1664 <rdar://problem/8638467>
1666 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1667 (-[WebHostedNetscapePluginView pluginHostDied]):
1669 2010-11-08 Alexey Proskuryakov <ap@apple.com>
1671 Reviewed by Darin Adler.
1673 https://bugs.webkit.org/show_bug.cgi?id=48685
1674 Notify UI process about focused frame
1676 Added an empty implementation of the new ChromeClient method.
1678 * WebCoreSupport/WebChromeClient.h:
1679 * WebCoreSupport/WebChromeClient.mm:
1680 (WebChromeClient::focusedFrameChanged):
1682 2010-11-08 Anders Carlsson <andersca@apple.com>
1686 * MigrateHeaders.make:
1688 2010-11-08 Anders Carlsson <andersca@apple.com>
1690 Reviewed by Adam Roben.
1692 Remove use of HIGetScaleFactor
1693 https://bugs.webkit.org/show_bug.cgi?id=49186
1694 <rdar://problem/8618410>
1696 Scale factors can vary on a display-by-display basis and it doesn't make sense
1697 to compute scale factor event coordinates like this.
1699 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1702 2010-11-08 Simon Fraser <simon.fraser@apple.com>
1704 Reviewed by Sam Weinig.
1706 Allow applets to participate in accelerated compositing
1707 https://bugs.webkit.org/show_bug.cgi?id=49117
1708 <rdar://problem/8625819>
1710 If Java is being loaded via the Netscape Plugin API, create a
1711 NetscapePluginWidget so that it has an implementation of platformLayer().
1713 Also clean up by using early returns.
1715 * WebCoreSupport/WebFrameLoaderClient.mm:
1717 2010-11-07 Adam Barth <abarth@webkit.org>
1719 Reviewed by Eric Seidel.
1721 Rename Cache to MemoryCache
1722 https://bugs.webkit.org/show_bug.cgi?id=49159
1725 (+[WebCache statistics]):
1726 * WebCoreSupport/WebDeviceOrientationClient.mm:
1727 (WebDeviceOrientationClient::setController):
1728 * WebView/WebView.mm:
1730 2010-11-05 Alexey Proskuryakov <ap@apple.com>
1732 Reviewed by Darin Adler.
1734 https://bugs.webkit.org/show_bug.cgi?id=49100
1735 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
1737 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
1738 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
1739 (see bug comments), and there seems to be no harm in executing this function in that case.
1741 2010-11-05 Chris Marrin <cmarrin@apple.com>
1743 Reviewed by Simon Fraser.
1745 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
1746 https://bugs.webkit.org/show_bug.cgi?id=49073
1748 * WebView/WebFrame.mm:
1749 (-[WebFrame _suspendAnimations]):
1750 (-[WebFrame _resumeAnimations]):
1752 2010-11-04 Alexey Proskuryakov <ap@apple.com>
1754 Reviewed by Darin Adler.
1756 https://bugs.webkit.org/show_bug.cgi?id=49008
1757 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
1759 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
1760 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
1761 deleted during wait:
1763 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
1766 We didn't recognize the latter.
1768 * Plugins/Hosted/NetscapePluginHostProxy.mm:
1769 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
1770 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1771 (WebKit::NetscapePluginInstanceProxy::waitForReply):
1772 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1773 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
1775 2010-11-05 Chris Marrin <cmarrin@apple.com>
1777 Reviewed by Simon Fraser.
1779 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
1780 https://bugs.webkit.org/show_bug.cgi?id=46945
1782 * WebView/WebFrame.mm:
1783 (-[WebFrame _suspendAnimations]):
1784 (-[WebFrame _resumeAnimations]):
1786 2010-11-04 Jia Pu <jpu@apple.com>
1788 Reviewed by Dan Bernstein.
1790 reversion bubble in WebViews
1791 https://bugs.webkit.org/show_bug.cgi?id=47630
1792 <rdar://problem/8530960>
1794 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
1796 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
1797 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
1798 change to use new reversion API in AppKit.
1799 (WebEditorClient::WebEditorClient):
1800 (WebEditorClient::~WebEditorClient):
1801 (WebEditorClient::respondToChangedSelection):
1802 (WebEditorClient::showCorrectionPanel):
1803 (WebEditorClient::dismissCorrectionPanel):
1804 (WebEditorClient::isShowingCorrectionPanel):
1806 2010-11-04 Mike Thole <mthole@apple.com>
1808 Reviewed by Dan Bernstein.
1810 Title for images should use localized numerals
1811 https://bugs.webkit.org/show_bug.cgi?id=49017
1813 * WebCoreSupport/WebPlatformStrategies.mm:
1814 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
1816 2010-11-02 Daniel Bates <dbates@rim.com>
1818 Reviewed by Adam Barth.
1820 For unnamed frames, window.name returns a generated name
1821 https://bugs.webkit.org/show_bug.cgi?id=6751
1825 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
1827 * WebView/WebFrame.mm:
1830 2010-11-01 Brady Eidson <beidson@apple.com>
1832 Reviewed by Anders Carlsson.
1834 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
1835 Context menu support for WebKit 2.
1837 * WebCoreSupport/WebChromeClient.h:
1838 (WebChromeClient::showContextMenu):
1840 2010-10-29 Daniel Bates <dbates@rim.com>
1842 No review, rolling out 70971.
1843 http://trac.webkit.org/changeset/70971
1844 https://bugs.webkit.org/show_bug.cgi?id=6751
1846 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
1847 it caused layout test failures on all bots. In particular, the
1848 child count in a generated frame name differs after this patch. We need
1849 to look into this further.
1851 * WebView/WebFrame.mm:
1854 2010-10-28 Antonio Gomes <agomes@rim.com>
1856 Reviewed by Ojan Vafai.
1858 Needs a "LinuxEditingBehavior", perhaps with a better name
1859 https://bugs.webkit.org/show_bug.cgi?id=36627
1861 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
1863 * WebView/WebFrame.mm:
1865 * WebView/WebPreferencesPrivate.h:
1867 2010-10-29 Daniel Bates <dbates@rim.com>
1869 Reviewed by Adam Barth.
1871 For unnamed frames, window.name returns a generated name
1872 https://bugs.webkit.org/show_bug.cgi?id=6751
1874 Modified Mac-port to use FrameTree::uniqueName().
1876 * WebView/WebFrame.mm:
1879 2010-10-29 Darin Adler <darin@apple.com>
1881 Reviewed by Sam Weinig.
1883 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
1884 https://bugs.webkit.org/show_bug.cgi?id=48574
1886 * History/WebBackForwardList.mm:
1887 Use BackForwardListImpl.
1889 2010-10-29 Alexey Proskuryakov <ap@apple.com>
1891 Rubber-stamped by Sam Weinig.
1893 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
1894 create views for subframes.
1896 * WebView/WebViewData.h: Double negation is better than a lie.
1898 2010-10-27 Jer Noble <jer.noble@apple.com>
1900 Reviewed by Darin Adler.
1902 Full screen video in Safari (still) exits full-screen if you switch to another
1903 app on a multi-display system.
1904 https://bugs.webkit.org/show_bug.cgi?id=47364
1905 <rdar://problem/8382299>
1907 The FullScreen window does not technically close when it deactivates, but the
1908 two NSWindows that make up the FullScreen feature should not hide when deactivated.
1910 * WebView/WebVideoFullscreenController.mm:
1911 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
1912 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
1913 * WebView/WebVideoFullscreenHUDWindowController.mm:
1914 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
1916 2010-10-29 Alexey Proskuryakov <ap@apple.com>
1918 Reviewed by Darin Adler.
1920 https://bugs.webkit.org/show_bug.cgi?id=48576
1921 Let WebKit2 client know when a frame is a frameset
1923 Added a blank implementation of the new FrameLoaderClient method.
1925 * WebCoreSupport/WebFrameLoaderClient.h:
1926 * WebCoreSupport/WebFrameLoaderClient.mm:
1927 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
1929 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
1931 Reviewed by Adam Roben and David Kilzer.
1933 Fix and cleanup of build systems
1934 https://bugs.webkit.org/show_bug.cgi?id=48342
1936 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
1938 2010-10-28 Dan Bernstein <mitz@apple.com>
1940 Reviewed by Mark Rowe.
1942 LLVM compiler build fix
1944 * Misc/WebDownload.mm:
1945 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
1946 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
1948 2010-10-28 Ivan Krstić <ike@apple.com>
1950 Reviewed by Mark Rowe.
1952 Remove unused experimental proxied panel interface.
1953 <rdar://problem/7237059>
1955 * Plugins/Hosted/NetscapePluginHostManager.h:
1956 * Plugins/Hosted/NetscapePluginHostManager.mm:
1957 (WebKit::NetscapePluginHostManager::hostForPlugin):
1958 (WebKit::NetscapePluginHostManager::spawnPluginHost):
1959 (WebKit::NetscapePluginHostManager::instantiatePlugin):
1960 * Plugins/Hosted/NetscapePluginHostProxy.mm:
1961 * Plugins/Hosted/WebKitPluginClient.defs:
1962 * Plugins/Hosted/WebKitPluginHost.defs:
1963 * WebCoreSupport/WebSystemInterface.mm:
1964 (InitWebCoreSystemInterface):
1965 * WebView/WebPreferenceKeysPrivate.h:
1966 * WebView/WebPreferences.mm:
1967 (+[WebPreferences initialize]):
1968 * WebView/WebPreferencesPrivate.h:
1970 2010-10-27 Pratik Solanki <psolanki@apple.com>
1972 Reviewed by Darin Adler.
1974 Improve memSize calculation in [WebView _setCacheModel]
1975 https://bugs.webkit.org/show_bug.cgi?id=48484
1977 * WebView/WebView.mm:
1978 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
1979 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
1980 bigger power of 2. Also update WebCore cache settings.
1982 2010-10-26 Darin Adler <darin@apple.com>
1984 Reviewed by Sam Weinig.
1986 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
1987 https://bugs.webkit.org/show_bug.cgi?id=42322
1988 rdar://problem/8193631
1990 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
1991 https://bugs.webkit.org/show_bug.cgi?id=42333
1992 rdar://problem/8193643
1994 * History/WebBackForwardList.mm:
1995 (core): Return BackForwardListImpl.
1996 (kit): Take BackForwardListImpl.
1997 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
1998 (-[WebBackForwardList dealloc]): Ditto.
1999 (-[WebBackForwardList finalize]): Ditto.
2000 (-[WebBackForwardList description]): Ditto.
2001 (-[WebBackForwardList setPageCacheSize:]): Ditto.
2002 (-[WebBackForwardList pageCacheSize]): Ditto.
2003 * History/WebBackForwardListInternal.h: Ditto.
2004 * WebView/WebFrameView.mm:
2005 (-[WebFrameView keyDown:]): Ditto.
2006 * WebView/WebView.mm:
2007 (-[WebView initWithCoder:]): Ditto.
2008 (-[WebView encodeWithCoder:]): Ditto.
2009 (-[WebView backForwardList]): Ditto.
2010 (-[WebView setMaintainsBackForwardList:]): Ditto.
2012 2010-10-27 Chris Rogers <crogers@google.com>
2014 Reviewed by Chris Marrin.
2016 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
2017 https://bugs.webkit.org/show_bug.cgi?id=48279
2019 * Configurations/FeatureDefines.xcconfig:
2021 2010-10-27 Beth Dakin <bdakin@apple.com>
2023 Reviewed by Darin Adler.
2025 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
2026 SPI to scale a WebView
2028 <rdar://problem/8107667>
2030 This patch adds SPI to Mac WebKit that scales the page by the given
2033 * WebView/WebView.mm:
2034 (-[WebView _scaleWebView:]):
2035 (-[WebView _viewScaleFactor]):
2036 * WebView/WebViewPrivate.h:
2038 2010-10-27 Dan Bernstein <mitz@apple.com>
2040 Reviewed by Darin Adler.
2042 REGRESSION (r70335): Incorrect article layout in Safari Reader
2043 https://bugs.webkit.org/show_bug.cgi?id=48436
2045 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
2046 * WebView/WebView.mm:
2047 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
2048 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
2049 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
2052 2010-10-18 Jer Noble <jer.noble@apple.com>
2054 Reviewed by Eric Carlson.
2056 Safari fullscreen media element tickles when it should not.
2058 https://bugs.webkit.org/show_bug.cgi?id=47861
2060 * WebView/WebVideoFullscreenController.mm:
2061 (-[WebVideoFullscreenController updatePowerAssertions]):
2063 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
2065 Reviewed by Dmitry Titov.
2067 Resource tracking failure when trying to move a frame between documents
2068 https://bugs.webkit.org/show_bug.cgi?id=44713
2070 * WebCoreSupport/WebFrameLoaderClient.h:
2071 * WebCoreSupport/WebFrameLoaderClient.mm:
2072 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2074 (WebFrameLoaderClient::transferLoadingResourceFromPage):
2075 Update resource tracking for a resource load that has been transferred
2078 2010-10-25 Oliver Hunt <oliver@apple.com>
2080 Reviewed by Gavin Barraclough.
2082 Remove exec and globalData arguments from jsNumber
2083 https://bugs.webkit.org/show_bug.cgi?id=48270
2085 Mechanical removal of exec parameter to jsNumber
2087 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2088 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2089 * Plugins/Hosted/ProxyInstance.mm:
2090 (WebKit::ProxyInstance::numberValue):
2092 2010-10-24 Dan Bernstein <mitz@apple.com>
2094 Reviewed by Anders Carlsson.
2096 Expose HitTestResult::absoluteMediaURL() via WebKit API
2097 https://bugs.webkit.org/show_bug.cgi?id=48219
2099 * Misc/WebElementDictionary.mm:
2100 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
2102 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
2103 * WebKit.exp: Export WebElementMediaURLKey.
2104 * WebView/WebView.mm: Define WebElementMediaURLKey.
2105 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
2107 2010-10-24 Dan Bernstein <mitz@apple.com>
2109 Reviewed by Simon Fraser.
2111 Removed deprecated methods from the WebHTMLHighlighter private protocol.
2113 * WebCoreSupport/WebChromeClient.mm:
2114 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
2116 (WebChromeClient::paintCustomHighlight): Call
2117 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
2118 * WebView/WebHTMLViewPrivate.h:
2120 2010-10-23 Xan Lopez <xlopez@igalia.com>
2122 Reviewed by Sam Weinig.
2124 Unify globalData APIs
2125 https://bugs.webkit.org/show_bug.cgi?id=47969
2127 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2128 (WebKit::NetscapePluginInstanceProxy::evaluate):
2129 (WebKit::NetscapePluginInstanceProxy::invoke):
2130 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2131 (WebKit::NetscapePluginInstanceProxy::construct):
2132 * WebView/WebScriptDebugDelegate.mm:
2133 (-[WebScriptCallFrame evaluateWebScript:]):
2135 2010-10-23 David Kilzer <ddkilzer@apple.com>
2137 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
2139 Reviewed by Sam Weinig.
2141 The only method defined in WebHTMLRepresentationInternal.h is
2142 also defined in WebHTMLRepresentation.h, so use that instead.
2144 * WebView/WebHTMLRepresentationInternal.h: Removed.
2146 2010-10-23 Alexey Proskuryakov <ap@apple.com>
2148 Reviewed by Anders Carlsson.
2150 https://bugs.webkit.org/show_bug.cgi?id=48083
2151 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
2153 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
2155 2010-10-22 Sam Weinig <sam@webkit.org>
2157 Reviewed by Anders Carlsson.
2159 WebKit2 needs to pass the current event modifier flags when requesting a new window
2160 https://bugs.webkit.org/show_bug.cgi?id=48140
2162 * WebCoreSupport/WebChromeClient.h:
2163 * WebCoreSupport/WebChromeClient.mm:
2164 (WebChromeClient::createWindow):
2165 * WebCoreSupport/WebFrameLoaderClient.h:
2166 * WebCoreSupport/WebFrameLoaderClient.mm:
2167 (WebFrameLoaderClient::dispatchCreatePage):
2168 Add NavigationAction parameter.
2170 2010-10-21 Andy Estes <aestes@apple.com>
2172 Reviewed by Eric Carlson.
2174 WebKit shouldn't load a plug-in based on file extension if a MIME type
2176 https://bugs.webkit.org/show_bug.cgi?id=48046
2178 If a MIME type is specified in an object or embed element, and that MIME
2179 type isn't supported by an installed plug-in, WebKit shouldn't attempt
2180 to find a plug-in based on the file extension of the url attribute.
2181 Doing so can lead to cases where a plug-in is loaded that can't handle
2182 resources of the MIME type specified by the author.
2184 * WebCoreSupport/WebFrameLoaderClient.mm:
2185 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
2186 extension if MIME type is the empty string.
2188 2010-10-20 Simon Fraser <simon.fraser@apple.com>
2190 Reviewed by Dan Bernstein.
2192 Composited elements drawn twice when WebView is layer-backed
2193 https://bugs.webkit.org/show_bug.cgi?id=48024
2194 <rdar://problem/7916580>
2196 When drawing content in a layer-backed WebView, WebFrame's test
2197 for drawing to a bitmap succeeded, causing us to paint flattened
2198 compositing layers into the view. They would also be rendered
2199 by the normal compositing path, resulting in double rendering.
2201 Fix this by detecting when the WebHTMLView is being drawn into
2202 a layer, and avoiding flattening in that case.
2204 * WebView/WebFrame.mm:
2205 (-[WebFrame _showFlattenedCompositingLayers:]):
2206 (-[WebFrame _drawRect:contentsOnly:]):
2207 * WebView/WebHTMLView.mm:
2208 (-[WebHTMLView drawLayer:inContext:]):
2209 (-[WebHTMLView _web_isDrawingIntoLayer]):
2210 * WebView/WebHTMLViewInternal.h:
2212 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
2214 Reviewed by David Levin.
2216 Repost the DatabaseTracker notifications to the main thread, if needed.
2217 https://bugs.webkit.org/show_bug.cgi?id=40655
2219 * Storage/WebDatabaseTrackerClient.mm:
2220 (DidModifyOriginData::dispatchToMainThread):
2221 (DidModifyOriginData::DidModifyOriginData):
2222 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
2223 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
2224 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
2226 2010-10-20 Simon Fraser <simon.fraser@apple.com>
2228 Reviewed by Darin Adler.
2230 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
2231 https://bugs.webkit.org/show_bug.cgi?id=47369
2233 r46947 added code that limits the size of the layer-backed view on Leopard when
2234 the page height exceeds 4096px (later adjusted to 2048px in r48401).
2236 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
2237 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
2238 to account for layer-backed view size-limiting was not fixed at the same time.
2239 This change corrects that.
2241 * WebView/WebHTMLView.mm:
2242 (-[WebHTMLView _updateLayerHostingViewPosition]):
2244 2010-10-19 Simon Fraser <simon.fraser@apple.com>
2246 Reviewed by Dan Bernstein.
2248 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
2250 AppKit has some special code to prevent it meddling with view's layers
2251 under layer-backed WebViews. When a layer-backed WebView became composited,
2252 this caused our layer to remain zero-sized. Fix this by manually
2253 setting the geometry for our layer, if the WebHTMLView has a layer.
2255 This does not seem to be a problem if the WebView becomes layer-backed, or
2256 stops being layer-backed after the WebView starts using compositing.
2258 * WebView/WebHTMLView.mm:
2259 (-[WebHTMLView attachRootLayer:]):
2261 2010-10-20 Dirk Schulze <krit@webkit.org>
2263 Reviewed by Nikolas Zimmermann.
2265 Merge ColorSpace and ImageColorSpace enums
2266 https://bugs.webkit.org/show_bug.cgi?id=47922
2268 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
2269 to follow webkit style rules.
2271 * Misc/WebKitNSStringExtras.mm:
2272 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2274 2010-10-19 Alexey Proskuryakov <ap@apple.com>
2276 Reviewed by Anders Carlsson.
2278 https://bugs.webkit.org/show_bug.cgi?id=47933
2279 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
2281 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
2282 We need to keep _webkit_preferredLanguageCode for Safari.
2284 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
2285 Initialize wkCopyCFLocalizationPreferredName.
2287 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
2289 2010-10-18 Alexey Proskuryakov <ap@apple.com>
2291 Reviewed by David Kilzer.
2293 https://bugs.webkit.org/show_bug.cgi?id=47864
2294 Convert WebNSUserDefaultsExtras.m to .mm
2296 Also, fixed some issues in the process:
2297 - removed locking, which was only necessary when this code was in Foundation;
2298 - fixed notification center observer to actually work (previously, it picked up changes
2299 when application preferences changed, not when system language did);
2300 - removed unused NSString category;
2303 * Misc/WebNSUserDefaultsExtras.m: Removed.
2304 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
2305 (createHTTPStyleLanguageCode):
2306 (+[NSUserDefaults _webkit_defaultsDidChange]):
2307 (addLanguageChangeObserver):
2308 (+[NSUserDefaults _webkit_preferredLanguageCode]):
2310 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
2312 Reviewed by Eric Seidel.
2314 Switch to using the new Carbon NPAPI event declarations, and remove
2317 https://bugs.webkit.org/show_bug.cgi?id=40784
2319 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2320 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2321 (WebNetscapePluginEventHandlerCarbon::mouseExited):
2322 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2323 (WebNetscapePluginEventHandlerCarbon::focusChanged):
2325 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
2327 Reviewed by Timothy Hatcher.
2329 Web Inspector: disable private browsing for inspector
2330 https://bugs.webkit.org/show_bug.cgi?id=47827
2332 * WebCoreSupport/WebInspectorClient.mm:
2333 (-[WebInspectorWindowController init]):
2335 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
2337 Reviewed by Pavel Feldman.
2339 Web Inspector: inspector settings/properties/states management
2340 should be extracted into separate class.
2342 We have a lot of flags/values in InspectorController.
2343 Some flags are persisting into profile.
2344 Others are part of inspector state for frontend.
2345 All these flags should keep their values after navigation.
2346 It'd be better to extract these flags/values into separate
2347 class which will care about theirs lifetime.
2349 https://bugs.webkit.org/show_bug.cgi?id=47275
2351 * WebCoreSupport/WebInspectorClient.mm:
2352 (-[WebInspectorWindowController showWindow:]):
2353 (-[WebInspectorWindowController attach]):
2354 (-[WebInspectorWindowController detach]):
2356 2010-10-13 Gavin Barraclough <barraclough@apple.com>
2358 Reviewed by Oliver Hunt.
2360 https://bugs.webkit.org/show_bug.cgi?id=43987
2361 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
2362 to construct their internal result string. Remove ScriptString (this is now
2365 * WebCoreSupport/WebFrameLoaderClient.mm:
2367 2010-10-12 Andy Estes <aestes@apple.com>
2369 Rubber-stamped by Darin Adler.
2371 Check in some cleanup from the previous commit.
2373 * WebView/WebView.mm:
2374 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
2376 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
2377 a separate class method into the only method that used it and removed
2378 the now-unnecessary class method.
2380 2010-10-12 Eric Seidel <eric@webkit.org>
2382 Reviewed by Darin Adler.
2384 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
2385 https://bugs.webkit.org/show_bug.cgi?id=45693
2387 Re-implement this former WebCore parser quirk as a
2388 Mac-only userscript-based quirk. As far as I can tell
2389 from Darin's description this should satisfy Mail's needs.
2391 * Misc/MailQuirksUserScript.js: Added.
2392 * WebView/WebView.mm:
2393 (+[WebView _mailQuirksUserScript]):
2394 (-[WebView _injectMailQuirksScript]):
2395 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2397 2010-10-12 Simon Fraser <simon.fraser@apple.com>
2399 Reviewed by Sam Weinig.
2401 Add 'didDraw' callback for framerate tracking
2402 https://bugs.webkit.org/show_bug.cgi?id=47478
2404 Add a callback at the end of -[WebHTMLView drawRect:] so
2405 a delegate can get notified when a draw happens.
2407 * WebView/WebHTMLView.mm:
2408 (-[WebHTMLView drawRect:]):
2409 * WebView/WebUIDelegatePrivate.h:
2411 2010-10-11 Anders Carlsson <andersca@apple.com>
2413 Reviewed by Darin Adler.
2415 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
2416 https://bugs.webkit.org/show_bug.cgi?id=47523
2418 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
2420 * Misc/WebIconFetcher.h: Removed.
2421 * Misc/WebIconFetcher.mm: Removed.
2422 * Misc/WebIconFetcherInternal.h: Removed.
2423 * WebView/WebFrame.mm:
2424 * WebView/WebFramePrivate.h:
2426 2010-10-11 Jessie Berlin <jberlin@apple.com>
2428 Reviewed by Darin Adler.
2430 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
2431 representation of a WebKit1 WebSerializedJSValue.
2432 https://bugs.webkit.org/show_bug.cgi?id=47439
2434 * WebView/WebSerializedJSValue.mm:
2435 (-[WebSerializedJSValue internalRepresentation]):
2436 * WebView/WebSerializedJSValuePrivate.h:
2438 2010-10-07 Jessie Berlin <jberlin@apple.com>
2440 Reviewed by Sam Weinig.
2442 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
2443 representation of a WebKit2 WebSerializedScriptValue.
2444 https://bugs.webkit.org/show_bug.cgi?id=47390
2446 * WebView/WebSerializedJSValue.mm:
2447 (-[WebSerializedJSValue initWithInternalRepresentation:]):
2448 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
2449 internal representation.
2450 * WebView/WebSerializedJSValuePrivate.h: Added.
2452 2010-10-07 Antonio Gomes <agomes@rim.com>
2454 Reviewed by Simon Fraser.
2456 [Mac] [DRT] implement setSpatialNavigationEnabled
2457 https://bugs.webkit.org/show_bug.cgi?id=47291
2459 Added the needed bits to make it possible to enabled spatial navigation
2460 for the Mac port. For now it is being only used by DRT.
2462 * WebView/WebPreferenceKeysPrivate.h:
2463 * WebView/WebPreferences.mm:
2464 (+[WebPreferences initialize]):
2465 (-[WebPreferences isSpatialNavigationEnabled]):
2466 (-[WebPreferences setSpatialNavigationEnabled:]):
2467 * WebView/WebPreferencesPrivate.h:
2468 * WebView/WebView.mm:
2469 (-[WebView _preferencesChangedNotification:]):
2471 2010-10-07 Jer Noble <jer.noble@apple.com>
2473 Fix the Leopard 64-bit build.
2475 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
2476 framework search path.
2477 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
2479 2010-10-06 Jer Noble <jer.noble@apple.com>
2481 Reviewed by Darin Adler.
2483 Screensaver starts while watching fullscreen playback.
2484 https://bugs.webkit.org/show_bug.cgi?id=47299
2485 <rdar://problem/8478956>
2487 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
2489 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
2490 * WebView/WebVideoFullscreenController.mm:
2491 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
2492 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
2493 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
2494 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
2495 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
2496 or _disableTickleTimer.
2498 2010-10-05 Philippe Normand <pnormand@igalia.com>
2500 Reviewed by Martin Robinson.
2502 check for ENABLE(GLIB_SUPPORT) in WebView
2503 https://bugs.webkit.org/show_bug.cgi?id=46788
2505 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
2507 * WebView/WebView.mm:
2508 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2509 (-[WebView _close]):
2510 * WebView/WebViewData.h:
2511 * WebView/WebViewInternal.h:
2513 2010-10-01 Anders Carlsson <andersca@apple.com>
2515 Fix Snow Leopard build.
2517 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2518 (WebKit::NetscapePluginInstanceProxy::getProxy):
2520 2010-10-01 Anders Carlsson <andersca@apple.com>
2522 Reviewed by Dan Bernstein.
2524 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
2525 https://bugs.webkit.org/show_bug.cgi?id=47022
2526 <rdar://problem/8504712>
2528 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2529 (WebKit::NetscapePluginInstanceProxy::getProxy):
2530 * Plugins/WebBaseNetscapePluginView.h:
2531 * Plugins/WebBaseNetscapePluginView.mm:
2532 * Plugins/WebNetscapePluginView.mm:
2533 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
2535 2010-09-30 Darin Adler <darin@apple.com>
2537 Reviewed by Sam Weinig.
2539 Remove remaining calls to deprecatedParseURL
2540 https://bugs.webkit.org/show_bug.cgi?id=26599
2542 * DOM/WebDOMOperations.mm:
2543 (-[DOMDocument URLWithAttributeString:]):
2544 * WebCoreSupport/WebFrameLoaderClient.mm:
2545 (WebFrameLoaderClient::createPlugin):
2546 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2548 2010-09-30 Anders Carlsson <andersca@apple.com>
2550 Reviewed by Darin Adler.
2552 -[DOMDocument _documentRange] throws an exception if there is no document element
2553 https://bugs.webkit.org/show_bug.cgi?id=46934
2554 <rdar://problem/8169260>
2556 If there is no document element, just return an empty range. Otherwise we'll try to call
2557 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
2559 * DOM/WebDOMOperations.mm:
2560 (-[DOMDocument _documentRange]):
2562 2010-09-30 Chris Marrin <cmarrin@apple.com>
2564 Reviewed by Simon Fraser.
2566 Make 2D accelerated canvas rendering build on Mac
2567 https://bugs.webkit.org/show_bug.cgi?id=46007
2569 Added ACCELERATED_2D_CANVAS to FeatureDefines
2571 * Configurations/FeatureDefines.xcconfig:
2573 2010-09-30 Dan Bernstein <mitz@apple.com>
2575 Reviewed by John Sullivan.
2577 Add printing SPI allowing full control over shrink-to-fit
2578 https://bugs.webkit.org/show_bug.cgi?id=46877
2580 * WebView/WebHTMLView.mm:
2581 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
2582 * WebView/WebHTMLViewPrivate.h:
2584 2010-09-28 Johnny Ding <jnd@chromium.org>
2586 Reviewed by Adam Barth.
2588 https://bugs.webkit.org/show_bug.cgi?id=41292
2589 Some windowed plugins did not handle events through EventHandler, so we
2590 never set right gesture state for those events.
2591 This change is to set right allowPopupsFromPlugin flag to current
2592 execution frame, so WeKit can always get right gesture state on Mac.
2593 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
2594 process, that process passes the allowPopupsFromPlugin flag to
2595 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
2596 NetscapePluginInstanceProxy::evaluate.
2598 * Plugins/WebNetscapePluginView.mm:
2599 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2601 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
2603 Reviewed by Dmitry Titov.
2605 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
2606 https://bugs.webkit.org/show_bug.cgi?id=46663
2608 * WebCoreSupport/WebFrameLoaderClient.h:
2609 * WebCoreSupport/WebFrameLoaderClient.mm:
2610 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2612 2010-09-26 Antonio Gomes <agomes@rim.com>
2614 Reviewed by Kenneth Rohde Christiansen.
2616 DRT/Mac nodesFromRect support
2618 [Mac][DRT] Implement LayoutTestController::nodesFromRect
2619 https://bugs.webkit.org/show_bug.cgi?id=46580
2621 Implement nodesFromRect as a private method to access non-exposed Document
2622 methods, similarly to computedStyleIncludingVisitedInfo.
2624 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
2625 These headers makes it possible to:
2626 1) Get a Document off of a JSDocument;
2627 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
2628 gotten from Document::nodesFromRect to JS bindings.
2629 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
2630 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
2631 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
2633 2010-09-24 Jia Pu <jpu@apple.com>
2635 Reviewed by Dan Bernstein.
2637 automaticSpellingCorrectionEnabled isn't updated.
2638 https://bugs.webkit.org/show_bug.cgi?id=46486
2639 <rdar://problem/8475212>
2641 * WebView/WebView.mm:
2642 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
2643 instead of "automaticTextReplacementEnabled".
2645 2010-09-23 Alexey Proskuryakov <ap@apple.com>
2647 Reviewed by Darin Adler.
2649 https://bugs.webkit.org/show_bug.cgi?id=46380
2650 REGRESSION: Crash when downloading a file
2652 Downloading cannot be tested in DRT.
2654 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2655 Don't copy null strings.
2657 2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
2659 Reviewed by Yury Semikhatsky.
2661 Web Inspector: CRASH at node highlight on MAC Safari.
2662 1) run-safari --debug
2664 3) open elements panel
2665 4) hover mouse over elements panel items multiple times
2667 Looks like it is a race condition. WebNodeHighlightView doesn't check
2668 the pointer to WebNodeHighligh object and it can be nil.
2670 https://bugs.webkit.org/show_bug.cgi?id=46261
2672 * WebInspector/WebNodeHighlightView.mm:
2673 (-[WebNodeHighlightView drawRect:]):
2675 2010-09-23 Andy Estes <aestes@apple.com>
2677 Reviewed by Darin Adler.
2679 REGRESSION (r61285): some Dashboard widgets are always invisible due to
2680 HTML parser changes.
2681 https://bugs.webkit.org/show_bug.cgi?id=46435
2683 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
2686 * WebView/WebView.mm:
2687 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
2688 shouldUsePreHTML5ParserQuirks(). Return true if
2689 WebCore::Settings::usesDashboardCompatibilityMode() is true.
2690 (-[WebView _preferencesChangedNotification:]):
2691 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
2692 if Dashboard behavior is set to backward compatibility mode.
2694 2010-09-23 Matthew Delaney <mdelaney@apple.com>
2696 Reviewed by Simon Fraser.
2698 Reduce minimum DOMTimer interval
2699 https://bugs.webkit.org/show_bug.cgi?id=45362
2701 * WebView/WebView.mm:
2702 Updating set interval call to use Settings' static version inside
2703 one time init block.
2705 2010-09-22 Andy Estes <aestes@apple.com>
2707 Reviewed by Darin Adler.
2709 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
2710 https://bugs.webkit.org/show_bug.cgi?id=46334
2712 Microsoft My Day loads scripts using self-closing script tags, markup
2713 which is incompatible with the HTML5 parser. Enable parser quirks for
2716 * WebView/WebView.mm:
2717 (shouldUsePreHTML5ParserQuirks): Return true if the application is
2718 Microsoft My Day and was linked against a version of WebKit prior to the
2719 introduction of the HTML5 parser.
2721 2010-09-23 Nate Chapin <japhet@chromium.org>
2723 Reviewed by Darin Fisher.
2725 Add hyperlink auditing settings (i.e., <a ping>).
2726 https://bugs.webkit.org/show_bug.cgi?id=30458
2728 * WebView/WebPreferenceKeysPrivate.h:
2729 * WebView/WebPreferences.mm:
2730 (+[WebPreferences initialize]):
2731 (-[WebPreferences setMemoryInfoEnabled:]):
2732 (-[WebPreferences hyperlinkAuditingEnabled]):
2733 (-[WebPreferences setHyperlinkAuditingEnabled:]):
2734 * WebView/WebPreferencesPrivate.h:
2735 * WebView/WebView.mm:
2736 (-[WebView _preferencesChangedNotification:]):
2738 2010-09-22 Alexey Proskuryakov <ap@apple.com>
2740 Reviewed by Anders Carlsson.
2742 https://bugs.webkit.org/show_bug.cgi?id=43667
2743 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
2745 Test: plugins/get-javascript-url.html
2747 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2748 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
2751 2010-09-21 Darin Adler <darin@apple.com>
2753 Reviewed by Anders Carlsson.
2755 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
2756 https://bugs.webkit.org/show_bug.cgi?id=46220
2758 * Misc/WebNSFileManagerExtras.m:
2759 (setMetaData): Use CFRelease instead of HardRelease.
2760 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
2761 instead of -[NSObject copy] combined with HardRetainWithNSRelease.
2763 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
2765 Reviewed by Kenneth Rohde Christiansen.
2767 PluginStrategy should satisfy the needs of Qt
2768 https://bugs.webkit.org/show_bug.cgi?id=45857
2769 No new functionality so no new tests.
2771 * WebCoreSupport/WebPlatformStrategies.h:
2772 * WebCoreSupport/WebPlatformStrategies.mm:
2773 (WebPlatformStrategies::getPluginInfo):
2775 2010-09-22 Paul Knight <pknight@apple.com>
2777 Reviewed by Simon Fraser.
2779 -[WebView _scheduleCompositingLayerSync] should wake the run loop
2780 https://bugs.webkit.org/show_bug.cgi?id=46226
2782 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
2784 * WebView/WebView.mm:
2785 (-[WebView _scheduleCompositingLayerSync]):
2787 2010-09-21 Andy Estes <aestes@apple.com>
2789 Reviewed by Darin Adler.
2791 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
2792 https://bugs.webkit.org/show_bug.cgi?id=46134
2794 AIM clients linked against versions of WebKit prior to the introduction
2795 of the HTML5 parser contain markup incompatible with the new parser.
2796 Enable parser quirks in this case to remain compatible with these
2799 * WebView/WebView.mm:
2800 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
2801 application is AIM and was linked against a version of WebKit prior to
2802 the introduction of the HTML5 parser, or if the
2803 WebKitPreHTML5ParserQuirks WebPreference is enabled.
2804 (-[WebView _preferencesChangedNotification:]): Call
2805 WebCore::Settings::setUsePreHTML5ParserQuirks().
2807 2010-09-21 Steve Block <steveblock@google.com>
2809 Reviewed by Jeremy Orlow.
2811 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
2812 https://bugs.webkit.org/show_bug.cgi?id=45891
2814 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
2816 * WebCoreSupport/WebDeviceOrientationClient.h:
2817 * WebCoreSupport/WebDeviceOrientationClient.mm:
2818 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
2820 2010-09-20 Philippe Normand <pnormand@igalia.com>
2822 Reviewed by Eric Carlson.
2824 [GTK] enhanced context menu for media elements
2825 https://bugs.webkit.org/show_bug.cgi?id=45021
2827 New localized strings for the media element context-menu.
2829 * WebCoreSupport/WebPlatformStrategies.h:
2830 * WebCoreSupport/WebPlatformStrategies.mm:
2831 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
2832 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
2833 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
2834 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
2835 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
2836 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
2837 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
2838 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
2839 (WebPlatformStrategies::contextMenuItemTagMediaPause):
2840 (WebPlatformStrategies::contextMenuItemTagMediaMute):
2842 2010-09-20 Andy Estes <aestes@apple.com>
2844 Reviewed by Adam Barth.
2846 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2847 https://bugs.webkit.org/show_bug.cgi?id=40961
2849 Implement WebKitUsePreHTML5ParserQuirks preference.
2851 * WebView/WebPreferenceKeysPrivate.h:
2852 * WebView/WebPreferences.mm:
2853 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
2855 (-[WebPreferences usePreHTML5ParserQuirks]):
2856 (-[WebPreferences setUsePreHTML5ParserQuirks:]):
2857 * WebView/WebPreferencesPrivate.h:
2858 * WebView/WebView.mm:
2859 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
2860 with the value of WebKitUsePreHTML5ParserQuirks when a preference
2863 2010-09-20 Enrica Casucci <enrica@apple.com>
2865 Reviewed by Sam Weinig.
2867 Pasteboard doesn't work in WebKit2.
2868 https://bugs.webkit.org/show_bug.cgi?id=42317
2869 <rdar://problem/7660537>
2871 Some changes to fix style inconsistencies.
2872 Added OBJC 2.0 style enumeration.
2874 * WebCoreSupport/WebEditorClient.h:
2875 * WebCoreSupport/WebEditorClient.mm:
2876 (WebEditorClient::userVisibleString):
2877 (createExcludedElementsForAttributedStringConversion):
2878 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
2880 (WebEditorClient::setInsertionPasteboard):
2881 (WebEditorClient::pasteboardTypesForSelection):
2883 2010-09-17 David Hyatt <hyatt@apple.com>
2885 Reviewed by Simon Fraser.
2887 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
2889 Make printing store the page height in the RenderView and push that into the layout state to
2890 use the new pagination model. The old pagination model is retained because it is still used
2891 for embedded WebViews.
2893 * WebView/WebHTMLView.mm:
2894 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2896 2010-09-17 Darin Adler <darin@apple.com>
2898 Reviewed by Sam Weinig.
2900 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
2901 https://bugs.webkit.org/show_bug.cgi?id=42863
2903 * WebView/WebView.mm:
2904 (-[WebView _setZoomMultiplier:isTextOnly:]):
2905 Call functions on Frame instead of FrameView.
2907 2010-09-17 Matthew Delaney <mdelaney@apple.com>
2909 Reviewed by Simon Fraser.
2911 Reduce minimum DOMTimer interval
2912 https://bugs.webkit.org/show_bug.cgi?id=45362
2914 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2916 2010-09-17 Chris Marrin <cmarrin@apple.com>
2918 Reviewed by Simon Fraser.
2920 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
2921 https://bugs.webkit.org/show_bug.cgi?id=45911
2923 * WebView/WebPreferenceKeysPrivate.h:
2924 * WebView/WebPreferences.mm:
2925 (+[WebPreferences initialize]):
2926 (-[WebPreferences accelerated2dCanvasEnabled]):
2927 (-[WebPreferences setAccelerated2dCanvasEnabled:]):
2928 * WebView/WebPreferencesPrivate.h:
2929 * WebView/WebView.mm:
2930 (-[WebView _preferencesChangedNotification:]):
2932 2010-09-17 Jia Pu <jpu@apple.com>
2934 Reviewed by Dan Bernstein.
2936 WebKit should use system wide spell checking preference when application specific one isn't set.
2937 https://bugs.webkit.org/show_bug.cgi?id=45789
2938 <rdar://problem/8416041>
2940 * WebView/WebView.mm:
2941 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
2942 when the application level preferences are not set.
2944 2010-09-16 John Sullivan <sullivan@apple.com>
2946 Reviewed by Darin Adler.
2948 <rdar://problem/8395558>
2949 https://bugs.webkit.org/show_bug.cgi?id=45938
2950 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
2952 * WebView/WebHTMLView.mm:
2953 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
2954 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
2955 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
2956 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
2957 before enumerating it, to ensure that the selector can't mutate the array being enumerated.
2958 (-[WebHTMLView viewWillMoveToHostWindow:]):
2959 Updated for _web_makePluginSubviewsPerformSelector:: signature change.
2960 (-[WebHTMLView viewDidMoveToHostWindow]):
2963 2010-09-16 Darin Adler <darin@apple.com>
2965 Reviewed by Andreas Kling.
2967 Reduce use of HTMLInputElement::inputType so we can remove it later
2968 https://bugs.webkit.org/show_bug.cgi?id=45903
2970 * WebView/WebHTMLRepresentation.mm:
2971 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
2972 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
2974 2010-09-16 Patrick Gansterer <paroga@paroga.com>
2976 Reviewed by Darin Adler.
2978 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
2979 https://bugs.webkit.org/show_bug.cgi?id=41510
2981 This prevents usage of nil value, which would cause an uncaught exception.
2983 * WebView/WebPreferences.mm:
2984 (-[WebPreferences setUserStyleSheetLocation:]):
2986 2010-09-16 Dan Bernstein <mitz@apple.com>
2988 Reverted the previous change because r67628 has been reverted.
2990 * WebCoreSupport/WebPlatformStrategies.h:
2991 * WebCoreSupport/WebPlatformStrategies.mm:
2993 2010-09-16 Dan Bernstein <mitz@apple.com>
2995 Build fix after r67628. Added context menu item localizable strings for the items
2996 added in r67628, following equivalent menu items in Mac OS X when possible. However,
2997 this set of menu items does not make much sense for Mac OS X, and this should be
2998 addressed separately.
3000 * WebCoreSupport/WebPlatformStrategies.h:
3001 * WebCoreSupport/WebPlatformStrategies.mm:
3002 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
3003 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
3004 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
3005 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
3006 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
3007 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
3008 (WebPlatformStrategies::contextMenuItemTagMediaPause):
3009 (WebPlatformStrategies::contextMenuItemTagMediaMute):
3010 (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
3012 2010-09-16 Eric Uhrhane <ericu@chromium.org>
3014 Reviewed by Jian Li.
3016 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3017 https://bugs.webkit.org/show_bug.cgi?id=45798
3019 * Configurations/FeatureDefines.xcconfig:
3021 2010-09-15 Simon Fraser <simon.fraser@apple.com>
3023 Reviewed by Adam Roben.
3025 https://bugs.webkit.org/show_bug.cgi?id=44715
3026 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
3028 Move geometry flipping to platform-specific code.
3030 * WebView/WebHTMLView.mm:
3031 (-[WebHTMLView attachRootLayer:]):
3033 2010-09-14 Jia Pu <jpu@apple.com>
3035 Reviewed by Dan Bernstein.
3037 Only intercept ESC key press when autocorrection UI is visible.
3038 https://bugs.webkit.org/show_bug.cgi?id=45071
3040 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
3041 which provides an inteface to query whether autocorrection panel is shown.
3043 * WebCoreSupport/WebEditorClient.mm:
3044 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
3045 for invalid correction panel tag. Replaced -1 with this constant.
3046 (WebEditorClient::dismissCorrectionPanel): Ditto
3047 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
3049 2010-09-14 Mark Rowe <mrowe@apple.com>
3051 Reviewed by John Sullivan.
3053 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
3055 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
3056 * Misc/WebKitVersionChecks.m:
3057 (WebKitLinkedOnOrAfter):
3058 (setWebKitLinkTimeVersion): Set the overridden version.
3059 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
3060 * WebView/WebPreferences.mm:
3061 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
3062 * WebView/WebPreferencesPrivate.h:
3064 2010-09-14 Eric Seidel <eric@webkit.org>
3066 Unreviewed, reverting changes r67451 and r67451.
3067 Broke lots of builders.
3069 Only intercept ESC key press when autocorrection UI is visible.
3070 https://bugs.webkit.org/show_bug.cgi?id=45071
3072 * WebCoreSupport/WebEditorClient.h:
3073 * WebCoreSupport/WebEditorClient.mm:
3074 (WebEditorClient::WebEditorClient):
3075 (WebEditorClient::dismissCorrectionPanel):
3077 2010-09-14 Jia Pu <jpu@apple.com>
3079 Reviewed by Dan Bernstein.
3081 Only intercept ESC key press when autocorrection UI is visible.
3082 https://bugs.webkit.org/show_bug.cgi?id=45071
3084 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
3085 which provides an inteface to query whether autocorrection panel is shown.
3087 * WebCoreSupport/WebEditorClient.mm:
3088 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
3089 for invalid correction panel tag. Replaced -1 with this constant.
3090 (WebEditorClient::dismissCorrectionPanel): Ditto
3091 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
3093 2010-09-13 Darin Adler <darin@apple.com>
3095 Reviewed by Adam Barth.
3097 Preparation for eliminating deprecatedParseURL
3098 https://bugs.webkit.org/show_bug.cgi?id=45695
3100 * DOM/WebDOMOperations.mm:
3101 (-[DOMDocument webFrame]): Get rid of unneeded local variable.
3102 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
3104 2010-09-13 Enrica Casucci <enrica@apple.com>
3106 Reviewed by Sam Weinig.
3108 Paste should be implemented in WebCore like Copy and Cut for Mac also.
3109 https://bugs.webkit.org/show_bug.cgi?id=45494
3110 <rdar://problem/7660537>
3112 On the Mac platform, the implementation of the paste operation is all done
3113 at the WebKit level. In order to support it on WebKit2 it is necessary to
3114 refactor the code and move this functionality at the level of WebCore like
3115 we already have on Windows.
3116 The original code relies on some in AppKit functions that call back into
3117 WebKit causing problems in WebKit2. All this functionality has been moved
3118 at the level of the editor client where it can be dealt with appropriately.
3120 * WebCoreSupport/WebEditorClient.h:
3121 * WebCoreSupport/WebEditorClient.mm:
3122 (excludedElementsForAttributedStringConversion):
3123 (WebEditorClient::documentFragmentFromAttributedString): Added.
3124 (WebEditorClient::setInsertionPasteboard):
3125 * WebCoreSupport/WebFrameLoaderClient.h:
3126 * WebCoreSupport/WebFrameLoaderClient.mm:
3127 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
3128 of the editor client.
3129 * WebView/WebHTMLView.mm: Removed paste method.
3131 2010-09-13 John Sullivan <sullivan@apple.com>
3133 Reviewed by Adam Roben.
3135 https://bugs.webkit.org/show_bug.cgi?id=45677
3136 [WebView canMarkAllTextMatches] can crash if called after [WebView close]
3138 <rdar://problem/8404890>
3140 * WebView/WebView.mm:
3141 (-[WebView canMarkAllTextMatches]):
3142 Return NO immediately if the webview has already been closed. This was an overlooked
3143 case from the fix for 45175.
3145 2010-09-10 MORITA Hajime <morrita@google.com>
3147 Reviewed by Tony Chang.
3149 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3150 https://bugs.webkit.org/show_bug.cgi?id=45441
3152 Moved the actual logic of hasSpellingMarker into WebCore to share
3153 it with other ports.
3155 * WebView/WebFrame.mm:
3156 (-[WebFrame hasSpellingMarker:length:]):
3158 2010-09-11 Adam Barth <abarth@webkit.org>
3160 Reviewed by Sam Weinig.
3162 Make SecurityOrigin::canDisplay an instance function
3163 https://bugs.webkit.org/show_bug.cgi?id=45219
3165 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3166 (WebKit::NetscapePluginInstanceProxy::loadRequest):
3167 * Plugins/WebNetscapePluginStream.mm:
3168 (WebNetscapePluginStream::WebNetscapePluginStream):
3169 * Plugins/WebNetscapePluginView.mm:
3170 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3171 * Plugins/WebPluginContainerCheck.mm:
3172 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3173 * WebView/WebFrame.mm:
3174 (-[WebFrame _allowsFollowingLink:]):
3176 2010-09-10 Sam Weinig <sam@webkit.org>
3178 Reviewed by Darin Adler.
3180 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3181 Precursor to <rdar://problem/7660657>
3182 https://bugs.webkit.org/show_bug.cgi?id=45522
3184 * WebView/WebView.mm:
3185 (-[WebView _preferencesChangedNotification:]):
3186 (-[WebView _setZoomMultiplier:isTextOnly:]):
3187 (-[WebView _realZoomMultiplierIsTextOnly]):
3188 * WebView/WebViewData.h:
3189 * WebView/WebViewData.mm:
3190 (-[WebViewPrivate init]):
3191 Move tracking of text only zoom here from WebCore.
3193 2010-09-10 Stephanie Lewis <slewis@apple.com>
3195 Reviewed by Alexey Proskuryakov.
3197 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
3198 other implementation details of JavaScriptCore. Necessary to fix PPC build.
3200 https://bugs.webkit.org/show_bug.cgi?id=45528
3202 * Misc/WebCoreStatistics.mm:
3203 (+[WebCoreStatistics memoryStatistics]):
3205 2010-09-10 Darin Adler <darin@apple.com>
3207 Reviewed by Sam Weinig.
3209 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
3210 https://bugs.webkit.org/show_bug.cgi?id=45582
3212 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
3214 * WebCoreSupport/WebChromeClient.mm:
3215 (WebChromeClient::dashboardRegionsChanged): Changed this to call
3216 -[WebView _dashboardRegions] so we don't have two copies of that code.
3218 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
3219 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
3221 * WebView/WebView.mm:
3222 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
3224 2010-09-10 Adam Barth <abarth@webkit.org>
3226 Reviewed by Darin Fisher.
3228 Move code from WebKit-layer to DocumentLoader
3229 https://bugs.webkit.org/show_bug.cgi?id=45569
3231 This code is the most confused, but now should be a bit cleaner.
3232 There's still a magical fake-setting for creating renderers that needs
3233 to be cleaned up, but we can do that in a separate patch.
3235 * WebView/WebFrame.mm:
3236 (-[WebFrame _commitData:]):
3237 * WebView/WebFrameInternal.h:
3238 * WebView/WebHTMLRepresentation.mm:
3239 (-[WebHTMLRepresentation receivedData:withDataSource:]):
3240 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3242 2010-09-09 Darin Adler <darin@apple.com>
3244 Reviewed by Adam Barth.
3246 Move functions from Frame to SelectionController as planned
3247 https://bugs.webkit.org/show_bug.cgi?id=45508
3249 * WebView/WebFrame.mm:
3250 (-[WebFrame _selectionGranularity]):
3251 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
3252 (-[WebFrame _typingStyle]):
3253 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3254 * WebView/WebHTMLRepresentation.mm:
3255 (-[WebHTMLRepresentation currentForm]):
3256 * WebView/WebHTMLView.mm:
3257 (-[WebHTMLView jumpToSelection:]):
3258 (-[WebHTMLView centerSelectionInVisibleArea:]):
3259 (-[WebHTMLView _canSmartCopyOrDelete]):
3260 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3261 (-[WebHTMLView selectionRect]):
3262 (-[WebHTMLView selectionTextRects]):
3263 (-[WebHTMLView selectionImageRect]):
3264 * WebView/WebView.mm:
3265 (-[WebView setEditable:]):
3266 Call functions on selection().
3268 2010-09-10 Adam Barth <abarth@webkit.org>
3270 Reviewed by Eric Seidel.
3272 Main resource bytes shouldn't bounce through FrameLoader
3273 https://bugs.webkit.org/show_bug.cgi?id=45496
3275 Now return the bytes to the DocumentLoader.
3277 Previously, we were checking the document for null. However, Frame can
3278 never have a null document, so this check is no longer needed.
3280 * WebView/WebFrame.mm:
3281 (-[WebFrame _addData:]):
3283 2010-09-09 John Therrell <jtherrell@apple.com>
3285 Reviewed by Alexey Proskuryakov.
3287 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
3288 https://bugs.webkit.org/show_bug.cgi?id=45134
3290 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
3291 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
3292 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
3294 * Misc/WebCoreStatistics.mm:
3295 (+[WebCoreStatistics memoryStatistics]):
3296 Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
3298 2010-09-09 Jer Noble <jer.noble@apple.com>
3300 Reviewed by Mark Rowe.
3302 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
3303 <rdar://problem/8412657>
3305 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
3307 2010-09-08 Darin Adler <darin@apple.com>
3309 Reviewed by Adam Barth.
3311 Move functions from Frame to Editor as planned
3312 https://bugs.webkit.org/show_bug.cgi?id=45218
3314 * WebView/WebFrame.mm:
3315 (-[WebFrame _selectedString]):
3316 (-[WebFrame _firstRectForDOMRange:]):
3317 (-[WebFrame _markDOMRange]):
3318 (-[WebFrame _setTypingStyle:withUndoAction:]):
3319 * WebView/WebHTMLRepresentation.mm:
3320 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3321 * WebView/WebHTMLView.mm:
3322 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3323 (-[WebHTMLView toggleBaseWritingDirection:]):
3324 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3325 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
3326 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
3327 (-[WebHTMLView markedTextMatchesAreHighlighted]):
3328 * WebView/WebView.mm:
3329 (-[WebView setEditable:]):
3330 Changed call sites to use editor().
3332 2010-09-08 MORITA Hajime <morrita@google.com>
3334 Reviewed by Ojan Vafai.
3336 spellcheck does not check pasted text
3337 https://bugs.webkit.org/show_bug.cgi?id=40092
3339 Implemented async spell-check APIs on WebEditorClient.
3340 The implementations are using [NSSpellChecker requestCheckingOfString]
3341 which is available only on Mac OS 10.6 or later.
3343 Note that [NSSpellChecker requestCheckingOfString] could invoke
3344 the callback block on on of their worker thread, so we need to
3345 return the result to the main thread where WebCore is running.
3346 For that purpose, we made WebEditorSpellCheckResponder class.
3348 Test: editing/spelling/spellcheck-pasted-text-001.html
3350 * WebCoreSupport/WebEditorClient.h:
3351 * WebCoreSupport/WebEditorClient.mm:
3352 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
3353 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
3354 (-[WebEditorSpellCheckResponder perform]): Added.
3355 (WebEditorClient::requestCheckingOfString): Added.
3356 * WebView/WebFramePrivate.h:
3358 2010-09-08 MORITA Hajime <morrita@google.com>
3360 Reviewed by Tony Chang.
3362 spelling underline gets lost on backspace
3363 https://bugs.webkit.org/show_bug.cgi?id=41423
3365 Switched to use a anchorNode of the selection instead of a focused
3366 node for finer control of node selection in spellingNode():
3367 With the focused node, we cannot select other nodes but the first
3368 child of that node. In some case, we need to inspect these.
3370 The API is only for LayoutTests, and the change is compatible for
3371 existing test cases.
3373 * WebView/WebFrame.mm:
3376 2010-09-08 Adam Barth <abarth@webkit.org>
3378 Rubber-stamped by Eric Seidel.
3380 Rename DocLoader to CachedResourceLoader because that's what it does.
3382 * WebView/WebFrame.mm:
3384 2010-09-07 Anders Carlsson <andersca@apple.com>
3386 Reviewed by Oliver Hunt.
3390 * Misc/WebLocalizableStrings.h:
3391 Fix a struct/tag mismatch.
3393 * WebView/WebDeviceOrientationProviderMock.mm:
3394 (-[WebDeviceOrientationProviderMock init]):
3395 Remove stray semicolon.
3397 * WebView/WebViewData.h:
3398 Remove unused class forward declaration.
3400 2010-09-07 Anders Carlsson <andersca@apple.com>
3402 Reviewed by Darin Adler.
3404 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
3406 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
3408 * Configurations/Base.xcconfig:
3410 2010-09-06 Adam Barth <abarth@webkit.org>
3412 Reviewed by Darin Adler.
3414 Rename SecurityOrigin::canLoad to canDisplay
3415 https://bugs.webkit.org/show_bug.cgi?id=45214
3417 Propagate name change.
3419 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3420 (WebKit::NetscapePluginInstanceProxy::loadRequest):
3421 * Plugins/WebNetscapePluginStream.mm:
3422 (WebNetscapePluginStream::WebNetscapePluginStream):
3423 * Plugins/WebNetscapePluginView.mm:
3424 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3425 * Plugins/WebPluginContainerCheck.mm:
3426 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3427 * WebView/WebFrame.mm:
3428 (-[WebFrame _allowsFollowingLink:]):
3430 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3432 Reviewed by Darin Adler.
3434 Add NetworkingContext to avoid layer violations
3435 https://bugs.webkit.org/show_bug.cgi?id=42292
3437 Add Mac's specific implementation of FrameNetworkingContext.
3439 * WebCoreSupport/WebFrameLoaderClient.h:
3440 * WebCoreSupport/WebFrameLoaderClient.mm:
3441 * WebCoreSupport/WebFrameNetworkingContext.mm:
3442 (WebFrameNetworkingContext::needsSiteSpecificQuirks):
3443 (WebFrameNetworkingContext::localFileContentSniffingEnabled):
3444 (WebFrameNetworkingContext::scheduledRunLoopPairs):
3445 (WebFrameNetworkingContext::blockedError):
3447 2010-09-03 John Sullivan <sullivan@apple.com>
3449 Reviewed by Dan Bernstein.
3451 https://bugs.webkit.org/show_bug.cgi?id=45175
3452 [WebView unmarkAllTextMatches] will crash if the webview is already closed
3454 Made this and related methods robust against being called when the WebView is closed.
3456 * WebView/WebView.mm:
3457 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
3458 Bail out if the WebView is closed.
3459 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
3461 (-[WebView unmarkAllTextMatches]):
3463 (-[WebView rectsForTextMatches]):
3466 2010-09-03 Hironori Bono <hbono@chromium.org>
3468 Reviewed by Kent Tamura.
3470 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
3471 and implements it for Mac.
3472 https://bugs.webkit.org/show_bug.cgi?id=41832
3474 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
3476 (-[WebFrame hasSpellingMarker:length:]):
3477 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
3479 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
3481 Reviewed by Pavel Feldman.
3483 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3484 https://bugs.webkit.org/show_bug.cgi?id=44230
3486 * WebCoreSupport/WebInspectorClient.h:
3487 * WebCoreSupport/WebInspectorClient.mm:
3488 (WebInspectorFrontendClient::closeWindow):
3489 (WebInspectorFrontendClient::disconnectFromBackend):
3490 (-[WebInspectorWindowController windowShouldClose:]):
3491 (-[WebInspectorWindowController destroyInspectorView:]):
3493 2010-09-02 Steve Block <steveblock@google.com>
3495 Reviewed by Adam Barth.
3497 Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
3498 https://bugs.webkit.org/show_bug.cgi?id=43181
3500 This patch hooks up the mock device orientation client on Mac for use
3503 The patch adds a new WebDeviceOrientationClient for Mac. This client acts
3504 as a proxy to either a real or mock device orientation provider, both of
3505 which implement a new WebDeviceOrientationProvider interface.
3507 The provider is created by the embedder and passed to the WebView, from
3508 where WebDeviceOrientationClient can access it.
3510 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
3511 the existing WebCore mock.
3513 * WebCoreSupport/WebDeviceOrientationClient.h: Added.
3514 * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
3515 (WebDeviceOrientationClient::WebDeviceOrientationClient):
3516 (WebDeviceOrientationClient::setController):
3517 (WebDeviceOrientationClient::startUpdating):
3518 (WebDeviceOrientationClient::stopUpdating):
3519 (WebDeviceOrientationClient::lastOrientation):
3521 * WebView/WebDeviceOrientation.h: Added.
3522 * WebView/WebDeviceOrientation.mm: Added.
3523 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
3525 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
3526 (-[WebDeviceOrientation dealloc]):
3527 * WebView/WebDeviceOrientationInternal.h: Added.
3528 * WebView/WebDeviceOrientationProvider.h: Added.
3529 * WebView/WebDeviceOrientationProviderMock.h: Added.
3530 * WebView/WebDeviceOrientationProviderMock.mm: Added.
3531 (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
3532 (-[WebDeviceOrientationProviderMockInternal setController:]):
3533 (-[WebDeviceOrientationProviderMockInternal startUpdating]):
3534 (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
3535 (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
3536 (-[WebDeviceOrientationProviderMock init]):
3537 (-[WebDeviceOrientationProviderMock dealloc]):
3538 (-[WebDeviceOrientationProviderMock setOrientation:]):
3539 (-[WebDeviceOrientationProviderMock setController:]):
3540 (-[WebDeviceOrientationProviderMock startUpdating]):
3541 (-[WebDeviceOrientationProviderMock stopUpdating]):
3542 (-[WebDeviceOrientationProviderMock lastOrientation]):
3543 * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
3544 * WebView/WebView.mm:
3545 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3546 (-[WebView _setDeviceOrientationProvider:]):
3547 (-[WebView _deviceOrientationProvider]):
3548 * WebView/WebViewData.h:
3549 * WebView/WebViewPrivate.h:
3551 2010-09-01 Jia Pu <jpu@apple.com>
3553 Reviewed by Dan Bernstein.
3555 Add support for autocorrection UI on Mac OS X.
3556 https://bugs.webkit.org/show_bug.cgi?id=44958
3557 <rdar://problem/7326847>
3559 See detailed high level description in WebCore/ChangeLog.
3561 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
3562 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
3564 * WebCoreSupport/WebEditorClient.mm:
3565 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
3566 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
3567 dismissed before destroying the object.
3568 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
3569 (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
3570 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
3572 2010-09-01 Mark Rowe <mrowe@apple.com>
3574 Reviewed by Adam Roben.
3576 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
3578 * Carbon/HIViewAdapter.m:
3579 * Carbon/HIWebView.mm:
3580 * Misc/QuickDrawCompatibility.h: Added.
3581 * Plugins/WebNetscapePluginView.mm:
3583 2010-08-31 Dave Hyatt <hyatt@apple.com>
3585 Reviewed by Sam Weinig.
3587 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
3588 the former can occur in more places without having to do the latter.
3590 Eliminate Mac-specific code for style re-application and recursive layout/style updating in
3591 favor of the cross-platform code that all the other ports use.
3593 * Carbon/HIWebView.mm:
3595 * WebCoreSupport/WebFrameLoaderClient.mm:
3596 (WebFrameLoaderClient::forceLayout):
3597 * WebView/WebHTMLView.mm:
3598 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
3599 (-[WebHTMLView viewWillDraw]):
3600 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3601 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3602 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3603 (-[WebHTMLView reapplyStyles]):
3604 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3605 (-[WebHTMLView setNeedsToApplyStyles:]):
3606 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
3607 (-[WebHTMLView _layoutIfNeeded]):
3608 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
3609 * WebView/WebHTMLViewInternal.h:
3610 * WebView/WebView.mm:
3611 (-[WebView _viewWillDrawInternal]):
3613 2010-08-31 Sam Weinig <sam@webkit.org>
3615 Reviewed by Darin Adler.
3617 Add ability to count text matches without marking
3618 https://bugs.webkit.org/show_bug.cgi?id=43996
3620 Safari needs to be able to count text matches without triggering lots of repainting.
3621 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
3622 parameter. For backwards compatibility markAllMatchesForText: calls
3623 countMatchesForText: and passes YES for markMatches:.
3625 * WebView/WebDocumentInternal.h:
3626 * WebView/WebHTMLView.mm:
3627 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
3628 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
3629 * WebView/WebPDFView.mm:
3630 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
3631 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
3632 * WebView/WebView.mm:
3633 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
3634 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
3635 * WebView/WebViewPrivate.h:
3637 2010-08-31 Darin Adler <darin@apple.com>
3639 Reviewed by Anders Carlsson.
3641 * WebInspector/WebInspectorFrontend.mm:
3642 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
3644 2010-08-30 Mark Rowe <mrowe@apple.com>
3646 Reviewed by Darin Adler.
3648 <rdar://problem/8369736> WebKit build fails.
3650 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
3652 * Carbon/HIViewAdapter.m:
3653 * Carbon/HIWebView.mm:
3654 * Plugins/WebNetscapePluginView.mm:
3656 2010-08-30 Andy Estes <aestes@apple.com>
3658 Reviewed by Darin Adler.
3660 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
3661 https://bugs.webkit.org/show_bug.cgi?id=44865
3663 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
3664 for authentication fail to log in. This is due to a bug in AppleConnect that r66156
3665 exposed, but since this will have a significant impact on users of WebKit nightly
3666 builds, a plugin-specific hack should be added while the underlying issue is being
3669 * WebCoreSupport/WebFrameLoaderClient.mm:
3670 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
3671 if the plugin is of type 'application/x-snkp'.
3673 2010-08-27 Jer Noble <jer.noble@apple.com>
3675 Reviewed by Eric Carlson.
3677 text/plain non-video files cause <video> to hang (while reading them?)
3678 https://bugs.webkit.org/show_bug.cgi?id=44212
3680 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
3681 the initialization routine.
3683 * WebCoreSupport/WebSystemInterface.mm:
3684 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
3686 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
3688 Unreviewed, rolling out r66198.
3689 http://trac.webkit.org/changeset/66198
3690 https://bugs.webkit.org/show_bug.cgi?id=44856
3692 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
3694 * WebCoreSupport/WebInspectorClient.h:
3695 * WebCoreSupport/WebInspectorClient.mm:
3696 (WebInspectorFrontendClient::closeWindow):
3697 (-[WebInspectorWindowController windowShouldClose:]):
3698 (-[WebInspectorWindowController destroyInspectorView]):
3700 2010-08-28 Darin Adler <darin@apple.com>
3702 Reviewed by Sam Weinig.
3704 Make an internal method used by Apple Mail into SPI
3705 https://bugs.webkit.org/show_bug.cgi?id=44832
3706 rdar://problem/5748951
3708 * WebView/WebFrame.mm:
3709 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
3710 from the internal section to the private section.
3711 * WebView/WebFrameInternal.h: Moved the method declaration out of here.
3712 * WebView/WebFramePrivate.h: Moved the method declaration in here.
3714 2010-08-27 Jer Noble <jer.noble@apple.com>
3716 Reviewed by Eric Carlson.
3718 Add JavaScript API to allow a page to go fullscreen.
3719 rdar://problem/6867795
3721 Added chrome client overrides which support entering and exiting full screen. A new preference has
3722 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
3723 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
3724 when the chrome has started/finished its full screen animation.
3726 * Configurations/FeatureDefines.xcconfig:
3727 * WebCoreSupport/WebChromeClient.h:
3728 * WebCoreSupport/WebChromeClient.mm:
3729 (WebChromeClient::supportsFullscreenForElement):
3730 (WebChromeClient::enterFullscreenForElement):
3731 (WebChromeClient::exitFullscreenForElement):
3732 (-[WebKitFullScreenListener initWithElement:]):
3733 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
3734 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
3735 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
3736 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
3737 * WebView/WebPreferenceKeysPrivate.h:
3738 * WebView/WebPreferences.h:
3739 * WebView/WebPreferences.mm:
3740 (+[WebPreferences initialize]):
3741 (-[WebPreferences setFullScreenEnabled:]):
3742 (-[WebPreferences fullScreenEnabled]):
3743 * WebView/WebUIDelegatePrivate.h:
3744 * WebView/WebView.mm:
3745 (-[WebView _preferencesChangedNotification:]):
3747 2010-08-27 David Hyatt <hyatt@apple.com>
3749 Reviewed by Simon Fraser.
3751 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
3753 Rename the various modes to match the HTML5 specification:
3754 ParseMode -> CompatibilityMode
3755 CompatMode -> QuirksMode
3756 AlmostStrictMode -> LimitedQuirksMode
3757 StrictMode -> NoQuirksMode
3759 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
3760 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
3762 Clean up user stylesheets to minimize style recalculation when the mode is switched.
3764 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
3765 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
3766 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
3769 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
3772 * WebView/WebView.mm:
3773 (-[WebView _preferencesChangedNotification:]):
3775 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
3777 Reviewed by Pavel Feldman.
3779 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3780 https://bugs.webkit.org/show_bug.cgi?id=44230
3782 * WebCoreSupport/WebInspectorClient.h:
3783 * WebCoreSupport/WebInspectorClient.mm:
3784 (WebInspectorFrontendClient::closeWindow):
3785 (WebInspectorFrontendClient::disconnectFromBackend):
3786 (-[WebInspectorWindowController windowShouldClose:]):
3787 (-[WebInspectorWindowController destroyInspectorView:]):
3789 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
3791 Unreviewed. Revert r66103 since Qt tests are failing.
3793 * WebCoreSupport/WebInspectorClient.h:
3794 * WebCoreSupport/WebInspectorClient.mm:
3795 (WebInspectorFrontendClient::closeWindow):
3796 (-[WebInspectorWindowController windowShouldClose:]):
3797 (-[WebInspectorWindowController destroyInspectorView]):
3799 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
3801 Reviewed by Pavel Feldman.
3803 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
3804 https://bugs.webkit.org/show_bug.cgi?id=44230
3806 * WebCoreSupport/WebInspectorClient.h:
3807 * WebCoreSupport/WebInspectorClient.mm:
3808 (WebInspectorFrontendClient::closeWindow):
3809 (WebInspectorFrontendClient::disconnectFromBackend):
3810 (-[WebInspectorWindowController windowShouldClose:]):
3811 (-[WebInspectorWindowController destroyInspectorView:]):
3813 2010-08-24 Eric Seidel <eric@webkit.org>
3815 Reviewed by Adam Barth.
3817 Remove HTML5 parser testing infrastructure now that we don't need it
3818 https://bugs.webkit.org/show_bug.cgi?id=44581
3820 * WebView/WebPreferenceKeysPrivate.h:
3821 * WebView/WebPreferences.mm:
3822 (+[WebPreferences initialize]):
3823 * WebView/WebPreferencesPrivate.h:
3824 * WebView/WebView.mm:
3825 (-[WebView _preferencesChangedNotification:]):
3827 2010-08-24 Sam Weinig <sam@webkit.org>
3829 Reviewed by Oliver Hunt.
3831 Paste event fires twice for mac WebKit
3832 <rdar://problem/8094611>
3833 https://bugs.webkit.org/show_bug.cgi?id=44535
3835 The mac implementation of paste in WebKit was accidentally calling
3836 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
3837 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
3838 Use the new pasteAsPlainTextBypassingDHTML function to bypass the
3841 * WebView/WebHTMLView.mm:
3842 (-[WebHTMLView paste:]):
3844 2010-08-24 Daniel Cheng <dcheng@chromium.org>
3846 Reviewed by Eric Seidel.
3848 [chromium] Generate drag images for HTML elements and selections.
3849 https://bugs.webkit.org/show_bug.cgi?id=43449
3851 Fix up calls to Frame::nodeImage, which has a new signature.
3853 * Plugins/WebBaseNetscapePluginView.mm:
3854 (-[WebBaseNetscapePluginView halt]):
3856 2010-08-23 Mike Thole <mthole@apple.com>
3858 Reviewed by Dan Bernstein.
3860 WebPDFView should remove itself as the delegate of its PDFView before being dealloced
3861 https://bugs.webkit.org/show_bug.cgi?id=44441
3863 * WebView/WebPDFView.mm:
3864 (-[WebPDFView dealloc]): Set the PDFView's delegate to nil.
3866 2010-08-22 Daniel Bates <dbates@rim.com>
3868 Reviewed by Eric Seidel.
3870 Encapsulate document marker management into DocumentMarkerController
3871 https://bugs.webkit.org/show_bug.cgi?id=44383
3873 Modify call sites in the Apple Mac port to use DocumentMarkerController.
3875 No functionality was changed, so no new tests.
3877 * WebView/WebFrame.mm:
3878 (-[WebFrame _unmarkAllBadGrammar]):
3879 (-[WebFrame _unmarkAllMisspellings]):
3880 * WebView/WebHTMLView.mm:
3881 (-[WebHTMLView unmarkAllTextMatches]):
3882 (-[WebHTMLView rectsForTextMatches]):
3884 2010-08-19 David Kilzer <ddkilzer@apple.com>
3886 <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
3888 Reviewed by Joseph Pecoraro.
3890 * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
3891 USE(PLUGIN_HOST_PROCESS) to
3892 USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
3893 * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
3894 * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
3895 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
3896 * Plugins/Hosted/ProxyInstance.mm: Ditto.
3897 * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
3898 * WebCoreSupport/WebChromeClient.mm: Ditto.
3899 (WebChromeClient::createWindow):
3900 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3901 (WebFrameLoaderClient::dispatchCreatePage):
3902 * WebView/WebHTMLView.mm:
3903 (needsCursorRectsSupportAtPoint): Added #if
3904 ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
3905 * WebView/WebView.mm:
3906 (+[WebView _isNodeHaltedPlugin:]): Ditto.
3907 (+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
3908 (+[WebView _restartHaltedPluginForNode:]): Ditto.
3910 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3912 Reviewed by Darin Adler.
3914 Add NetworkingContext to avoid layer violations
3915 https://bugs.webkit.org/show_bug.cgi?id=42292
3917 Preparation: Just add the files to the build system.
3919 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
3920 Placeholder with tentative code that might be changed when landing
3922 * WebCoreSupport/WebFrameNetworkingContext.mm: Added.
3923 Empty placeholder for now.
3925 2010-08-17 Brady Eidson <beidson@apple.com>
3927 Reviewed by Sam Weinig.
3929 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
3930 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
3932 * WebView/WebView.mm:
3933 (-[WebView canGoBack]): Return false if loads are deferred.
3934 (-[WebView canGoForward]): Ditto.
3936 2010-08-14 Joseph Pecoraro <joepeck@webkit.org>
3938 Reviewed by Pavel Feldman.
3940 Web Inspector: -[WebInspector attach] and detach should work
3941 https://bugs.webkit.org/show_bug.cgi?id=43924
3943 For actions that relate only to the Web Inspector's Frontend
3944 window (actions on the InspectorFrontendClient) the new Obj-C
3945 wrapper class WebInspectorFrontend can be used. For now, this
3946 is just attach and detach.
3948 * WebCoreSupport/WebInspectorClient.mm:
3949 (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
3950 * WebInspector/WebInspector.h:
3951 * WebInspector/WebInspector.mm:
3952 (-[WebInspector dealloc]):
3953 (-[WebInspector attach:]): delegate to the frontend.
3954 (-[WebInspector detach:]): delegate to the frontend.
3955 (-[WebInspector setFrontend:]):
3956 * WebInspector/WebInspectorFrontend.h: Added.
3957 * WebInspector/WebInspectorFrontend.mm: Added.
3958 (-[WebInspectorFrontend initWithFrontendClient:]):
3959 (-[WebInspectorFrontend attach]):
3960 (-[WebInspectorFrontend detach]):
3961 * WebInspector/WebInspectorPrivate.h:
3963 2010-08-13 Gavin Barraclough <barraclough@apple.com>
3965 Rubber stamped by Sam Weinig.
3966 Switch String::/UString::ascii() to return a CString.
3968 * Plugins/Hosted/ProxyInstance.mm:
3969 (WebKit::ProxyInstance::methodsNamed):
3970 (WebKit::ProxyInstance::fieldNamed):
3972 2010-08-13 Gavin Barraclough <barraclough@apple.com>
3974 Reviewed by Sam Weinig
3976 Unify UString::UTF8String() & String::utf8() methods,
3977 remove UString::cost() & make atArrayIndex a free function.
3979 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3980 (WebKit::NetscapePluginInstanceProxy::enumerate):
3982 2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
3984 Unreviewed, rolling out r65295.
3985 http://trac.webkit.org/changeset/65295
3986 https://bugs.webkit.org/show_bug.cgi?id=43950
3988 It broke 4 sputnik tests (Requested by Ossy on #webkit).
3990 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3991 (WebKit::NetscapePluginInstanceProxy::enumerate):
3993 2010-08-12 Gavin Barraclough <barraclough@apple.com>
3995 Reviewed by Sam Weinig
3997 Unify UString::UTF8String() & String::utf8() methods,
3998 remove UString::cost() & make atArrayIndex a free function.
4000 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4001 (WebKit::NetscapePluginInstanceProxy::enumerate):
4003 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
4006 https://bugs.webkit.org/show_bug.cgi?id=43794
4008 * WebView/WebView.mm:
4009 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
4010 (-[WebView _preferencesChangedNotification:]):
4012 2010-08-10 Jeremy Orlow <jorlow@chromium.org>
4014 Reviewed by Adam Barth.
4016 Some settings are linked to the PageGroup not the Page. Create a new class for those.
4017 https://bugs.webkit.org/show_bug.cgi?id=43794
4019 Change WebView to use the new GroupSettings class rather than Settings for the
4020 settings that moved. This is sub-optimal since the settings aren't really
4021 per-view, but we can't really change the API at this point.
4023 * WebView/WebView.mm:
4024 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
4025 (-[WebView _preferencesChangedNotification:]):
4027 2010-08-11 Gavin Barraclough <barraclough@apple.com>
4029 Rubber stamps by Darin Adler & Sam Weinig.
4031 Bug 43867 - Some UString cleanup
4033 Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
4034 Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().
4036 * WebView/WebScriptDebugger.mm:
4039 2010-08-10 David Hyatt <hyatt@apple.com>
4041 Reviewed by Dan Bernstein.
4043 https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
4045 Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
4048 * WebView/WebHTMLView.mm:
4049 (-[WebHTMLView _web_setPrintingModeRecursive]):
4050 (-[WebHTMLView _web_clearPrintingModeRecursive]):
4051 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
4052 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
4053 (-[WebHTMLView _endPrintMode]):
4054 (-[WebHTMLView _isInScreenPaginationMode]):
4055 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
4056 (-[WebHTMLView _endScreenPaginationMode]):
4057 (-[WebHTMLView reapplyStyles]):
4058 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
4059 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
4060 (-[WebHTMLView setPageWidthForPrinting:]):
4061 * WebView/WebHTMLViewPrivate.h:
4063 2010-08-10 Gavin Barraclough <barraclough@apple.com>
4065 Build fix (update more includes)
4067 * Plugins/Hosted/NetscapePluginHostManager.h:
4069 2010-08-10 Chris Marrin <cmarrin@apple.com>
4071 Reviewed by Oliver Hunt.
4073 Add suspendAnimations/resumeAnimation API to DRT
4074 https://bugs.webkit.org/show_bug.cgi?id=43733
4076 Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.
4078 * WebView/WebFrame.mm:
4079 (-[WebFrame _suspendAnimations]):
4080 (-[WebFrame _resumeAnimations]):
4081 * WebView/WebFramePrivate.h:
4083 2010-08-10 Gavin Barraclough <barraclough@apple.com>
4085 Rubber stamped by Sam Weinig
4087 Bug 43817 - Remove UString::Rep
4088 UString::Rep has for a long time been replaced by UStringImpl (Rep
4089 remaining as a typedef). UStringImpl has since been removed too
4090 (unified with StringImpl). Remove Rep, rename rep() to impl() and
4091 m_rep to m_impl. Also add impl() method to Identifier, and rename
4092 its UString member from _ustring to m_string.
4094 * Plugins/Hosted/ProxyInstance.mm:
4095 (WebKit::ProxyInstance::methodsNamed):
4096 (WebKit::ProxyInstance::fieldNamed):
4098 2010-08-06 Gavin Barraclough <barraclough@apple.com>
4100 Rubber stamped by Sam Weinig
4102 Bug 43594 - Add string forwards to Forward.h
4103 This allows us to remove forward declarations for these classes from
4104 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
4106 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
4107 * Plugins/WebBaseNetscapePluginView.h:
4108 * WebCoreSupport/WebFrameLoaderClient.h:
4109 * WebCoreSupport/WebIconDatabaseClient.h:
4110 * WebCoreSupport/WebPluginHalterClient.h:
4111 * WebView/WebViewInternal.h:
4113 2010-08-04 MORITA Hajime <morrita@google.com>
4115 Reviewed by Tony Chang.
4117 Pasting should fire textInput event.
4118 https://bugs.webkit.org/show_bug.cgi?id=42958
4120 On paste, invoke Editor instead of direct command invocation,
4121 which allows dispatching events before actual paste.
4123 * WebView/WebHTMLView.mm:
4124 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
4126 2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
4128 Reviewed by Eric Seidel.
4130 add "const" to WebChromeClient::webView().
4131 https://bugs.webkit.org/show_bug.cgi?id=43631
4133 Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
4134 is const method now, and calling webView() inside port-specific didReceiveViewportArguments
4135 implementation fails compiling if webView() is not const.
4137 * WebCoreSupport/WebChromeClient.h:
4138 (WebChromeClient::webView):