370430030f6ccc7971015beae6493b15bc8c5161
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
2
3         [CSS Grid Layout] Remove runtime feature
4         https://bugs.webkit.org/show_bug.cgi?id=132382
5
6         Reviewed by Benjamin Poulain.
7
8         Remove cssGridLayoutEnabled setting usage.
9
10         * WebKit.order:
11         * WebView/WebPreferenceKeysPrivate.h:
12         * WebView/WebPreferences.mm:
13         (+[WebPreferences initialize]):
14         (-[WebPreferences cssGridLayoutEnabled]): Deleted.
15         (-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
16         * WebView/WebPreferencesPrivate.h:
17         * WebView/WebView.mm:
18         (-[WebView _preferencesChanged:]):
19
20 2014-05-06  Dean Jackson  <dino@apple.com>
21
22         [Mac] Allow focus rings to redraw themselves if necessary
23         https://bugs.webkit.org/show_bug.cgi?id=132593
24
25         Reviewed by Simon Fraser.
26
27         * WebCoreSupport/WebSystemInterface.mm:
28         (InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.
29
30 2014-05-06  Brady Eidson  <beidson@apple.com>
31
32         Don't select an image that is about to have its menu shown.
33         <rdar://problem/16807845> and https://bugs.webkit.org/show_bug.cgi?id=132579
34
35         Reviewed by Tim Horton.
36
37         * Misc/WebSharingServicePickerController.mm:
38         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
39           Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.
40
41 2014-05-06  Anders Carlsson  <andersca@apple.com>
42
43         Move the WebKitLegacy header check to the right file
44         https://bugs.webkit.org/show_bug.cgi?id=132620
45         <rdar://problem/16815716>
46
47         Reviewed by Dan Bernstein.
48
49         * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:
50         * WebKitLegacy/WebKit.h:
51
52 2014-05-06  Anders Carlsson  <andersca@apple.com>
53
54         Put WebKitPluginHost.app in WebKitLegacy.framework
55         https://bugs.webkit.org/show_bug.cgi?id=132592
56         <rdar://problem/15920046>
57
58         Reviewed by Dan Bernstein.
59
60         * Plugins/Hosted/NetscapePluginHostManager.mm:
61         (WebKit::NetscapePluginHostManager::spawnPluginHost):
62
63 2014-05-06  Darin Adler  <darin@apple.com>
64
65         [iOS] Fix two more AdoptCF I missed in my last patch.
66
67         * WebView/WebHTMLView.mm:
68         (imageFromRect): Use adoptCF instead of AdoptCF.
69
70 2014-05-05  Andreas Kling  <akling@apple.com>
71
72         Unreviewed, rolling out r168334.
73
74         Broke builds.
75
76         Reverted changeset:
77
78         "Put WebKitPluginHost.app in WebKitLegacy.framework"
79         https://bugs.webkit.org/show_bug.cgi?id=132592
80         http://trac.webkit.org/changeset/168334
81
82 2014-05-05  Anders Carlsson  <andersca@apple.com>
83
84         Put WebKitPluginHost.app in WebKitLegacy.framework
85         https://bugs.webkit.org/show_bug.cgi?id=132592
86         <rdar://problem/15920046>
87
88         Reviewed by Dan Bernstein.
89
90         * Plugins/Hosted/NetscapePluginHostManager.mm:
91         (WebKit::NetscapePluginHostManager::spawnPluginHost):
92
93 2014-05-02  Brady Eidson  <beidson@apple.com>
94
95         Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:.
96         <rdar://problem/16797425> and https://bugs.webkit.org/show_bug.cgi?id=132484
97
98         Reviewed by Tim Horton.
99
100         * Misc/WebSharingServicePickerController.mm:
101         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
102
103         * WebCoreSupport/WebContextMenuClient.h:
104         * WebCoreSupport/WebContextMenuClient.mm:
105         (WebContextMenuClient::screenRectForHitTestNode):
106
107 2014-05-02  Brady Eidson  <beidson@apple.com>
108
109         Crash inside [WebSharingServicePickerController clear]
110         <rdar://problem/16791944> and https://bugs.webkit.org/show_bug.cgi?id=132477
111
112         Reviewed by Tim Horton.
113
114         * Misc/WebSharingServicePickerController.h:
115         * Misc/WebSharingServicePickerController.mm:
116         (-[WebSharingServicePickerController clear]): clear can be called twice, so null check _menuClient.
117
118         * WebCoreSupport/WebContextMenuClient.h:
119         * WebCoreSupport/WebContextMenuClient.mm:
120         (WebContextMenuClient::~WebContextMenuClient): For a sanity check, call clear on the picker here.
121
122 2014-05-01  Tim Horton  <timothy_horton@apple.com>
123
124         More 32-bit build fixes.
125
126         * Misc/WebSharingServicePickerController.mm:
127         (-[WebSharingServicePickerController sharingService:didShareItems:]):
128
129 2014-05-01  Tim Horton  <timothy_horton@apple.com>
130
131         Temporarily "fix" the 32-bit build.
132
133         * Misc/WebSharingServicePickerController.mm:
134         This will fail miserably at runtime, but we shouldn't ever get here in a 32-bit process.
135
136 2014-05-01  Brady Eidson  <beidson@apple.com>
137
138         Update service picker API usage.
139         <rdar://problem/16772674> and https://bugs.webkit.org/show_bug.cgi?id=132452
140
141         Reviewed by Tim Horton.
142
143         * Misc/WebSharingServicePickerController.h:
144         * Misc/WebSharingServicePickerController.mm:
145         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
146           Factor out a common "didShare" handler that optionally validates whether the data represents an image.
147         (-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling
148           on off-main thread call back to the main thread.
149
150         * WebCoreSupport/WebContextMenuClient.mm:
151         (WebContextMenuClient::contextMenuForEvent): Update API usage.
152
153 2014-05-01  Anders Carlsson  <andersca@apple.com>
154
155         Support OS-version-specific install paths for WebKit.framework
156         https://bugs.webkit.org/show_bug.cgi?id=132448
157         <rdar://problem/16784932>
158
159         Reviewed by Dan Bernstein.
160
161         * WebKitLegacy/WebKit.m:
162         Add version specific install names.
163
164 2014-04-30  Alexey Proskuryakov  <ap@apple.com>
165
166         Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
167         Clean up unnecessary methods in the BackForwardClient interface
168
169         It broke a regression test and an API test.
170
171         * History/WebBackForwardList.mm:
172         (-[WebBackForwardList initWithBackForwardList:]):
173         (-[WebBackForwardList init]):
174         (-[WebBackForwardList dealloc]):
175         (-[WebBackForwardList finalize]):
176         (-[WebBackForwardList setPageCacheSize:]):
177         (-[WebBackForwardList pageCacheSize]):
178         * History/WebBackForwardListInternal.h:
179         * WebCoreSupport/WebFrameLoaderClient.mm:
180         (WebFrameLoaderClient::canCachePage):
181         * WebView/WebFrameView.mm:
182         (-[WebFrameView keyDown:keyDown:]):
183         * WebView/WebView.mm:
184         (-[WebView _loadBackForwardListFromOtherView:]):
185         (-[WebView initWithCoder:]):
186         (-[WebView encodeWithCoder:]):
187         (-[WebView backForwardList]):
188         (-[WebView setMaintainsBackForwardList:]):
189
190 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
191
192         Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
193         https://bugs.webkit.org/show_bug.cgi?id=132396
194
195         Reviewed by Eric Carlson.
196
197         Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.
198
199         * Configurations/FeatureDefines.xcconfig:
200         * Plugins/WebPluginContainerPrivate.h:
201         * Plugins/WebPluginController.h:
202         * Plugins/WebPluginController.mm:
203         (-[WebPluginController dealloc]):
204         (-[WebPluginController plugInsAreRunning]):
205         (-[WebPluginController stopAllPlugins]):
206         (-[WebPluginController stopPluginsForPageCache]):
207         (-[WebPluginController restorePluginsFromCache]):
208         (-[WebPluginController addPlugin:]):
209         (-[WebPluginController destroyPlugin:]):
210         (-[WebPluginController destroyAllPlugins]):
211         (-[NSView isMediaPlugInProxyView]): Deleted.
212         (-[NSView setIsMediaPlugInProxyView:]): Deleted.
213         (-[WebPluginController mediaPlugInProxyViewCreated:]): Deleted.
214         (+[WebPluginController pluginViewHidden:]): Deleted.
215         (mediaProxyClient): Deleted.
216         (-[WebPluginController _webPluginContainerSetMediaPlayerProxy:forElement:]): Deleted.
217         (-[WebPluginController _webPluginContainerPostMediaPlayerNotification:forElement:]): Deleted.
218         * WebCoreSupport/WebFrameLoaderClient.h:
219         * WebCoreSupport/WebFrameLoaderClient.mm:
220         (pluginView):
221         * WebView/WebView.mm:
222         (-[WebView _preferencesChanged:]):
223         (-[WebView _videoProxyPluginForMIMEType:]): Deleted.
224         * WebView/WebViewInternal.h:
225
226 2014-04-30  Anders Carlsson  <andersca@apple.com>
227
228         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
229         https://bugs.webkit.org/show_bug.cgi?id=132399
230         <rdar://problem/15920046>
231
232         Reviewed by Dan Bernstein.
233
234         * Carbon/CarbonUtils.h:
235         * Carbon/HIViewAdapter.h:
236         * Carbon/HIWebView.h:
237         Import WebKitLegacy headers instead of WebKit headers.
238
239         * Configurations/WebKit.xcconfig:
240         Move the definitions needed for building WebKitLegacy.framework to WebKitLegacy.xcconfig and
241         add the relevant definitions needed for re-exporting WebKitLegacy.framework.
242
243         * Configurations/WebKitLegacy.xcconfig:
244         Add definitions needed for building the "old" WebKit API as WebKitLegacy.framework.
245
246         * DOM/WebDOMOperations.h:
247         * DOM/WebDOMOperations.mm:
248         * DOM/WebDOMOperationsInternal.h:
249         * DOM/WebDOMOperationsPrivate.h:
250         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
251         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
252         * DefaultDelegates/WebDefaultEditingDelegate.m:
253         * History/WebBackForwardListInternal.h:
254         * History/WebBackForwardListPrivate.h:
255         * History/WebHistoryItemPrivate.h:
256         * History/WebHistoryPrivate.h:
257         * History/WebURLsWithTitles.m:
258         Import WebKitLegacy headers instead of WebKit headers.
259
260         * MigrateHeaders.make:
261         Update header paths now that all WebKitLegacy headers are private.
262         Remove migration of WebKit2 headers, that is done by MigrateHeadersFromWebKitLegacy.make now.
263         
264         * Misc/WebCoreStatistics.h:
265         * Misc/WebDownload.h:
266         * Misc/WebDownload.mm:
267         * Misc/WebDownloadInternal.h:
268         * Misc/WebElementDictionary.mm:
269         * Misc/WebIconDatabasePrivate.h:
270         * Misc/WebKit.h:
271         * Misc/WebKitErrors.m:
272         * Misc/WebKitErrorsPrivate.h:
273         * Misc/WebKitNSStringExtras.mm:
274         * Misc/WebLocalizableStrings.mm:
275         * Misc/WebNSDataExtras.m:
276         * Misc/WebNSDictionaryExtras.m:
277         * Misc/WebNSEventExtras.m:
278         * Misc/WebNSFileManagerExtras.mm:
279         * Misc/WebNSImageExtras.m:
280         * Misc/WebNSPasteboardExtras.mm:
281         * Misc/WebNSViewExtras.h:
282         * Misc/WebNSViewExtras.m:
283         * Panels/WebAuthenticationPanel.m:
284         * Panels/WebPanelAuthenticationHandler.m:
285         * Plugins/Hosted/HostedNetscapePluginStream.h:
286         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
287         * Plugins/Hosted/WebKitPluginAgent.defs:
288         * Plugins/Hosted/WebKitPluginAgentReply.defs:
289         * Plugins/Hosted/WebKitPluginClient.defs:
290         * Plugins/Hosted/WebKitPluginHost.defs:
291         * Plugins/Hosted/WebKitPluginHostTypes.defs:
292         * Plugins/WebBaseNetscapePluginView.mm:
293         * Plugins/WebBasePluginPackage.h:
294         * Plugins/WebBasePluginPackage.mm:
295         * Plugins/WebNetscapeContainerCheckPrivate.h:
296         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
297         * Plugins/WebNetscapePluginStream.h:
298         * Plugins/WebNetscapePluginView.h:
299         * Plugins/WebNetscapePluginView.mm:
300         * Plugins/WebPlugin.h:
301         * Plugins/WebPluginController.h:
302         * Plugins/WebPluginDatabase.h:
303         * Plugins/WebPluginPackage.h:
304         * Plugins/WebPluginPackage.mm:
305         * Plugins/WebPluginViewFactory.h:
306         * Plugins/WebPluginViewFactoryPrivate.h:
307         * Plugins/npapi.mm:
308         * Storage/WebDatabaseManagerPrivate.h:
309         * WebCoreSupport/WebContextMenuClient.mm:
310         * WebCoreSupport/WebFrameLoaderClient.mm:
311         * WebCoreSupport/WebFrameNetworkingContext.mm:
312         * WebCoreSupport/WebGeolocationClient.mm:
313         * WebCoreSupport/WebInspectorClient.mm:
314         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
315         * WebCoreSupport/WebKeyGenerator.mm:
316         * WebInspector/WebInspectorPrivate.h:
317         * WebInspector/WebNodeHighlight.h:
318         * WebInspector/WebNodeHighlightView.h:
319         Import WebKitLegacy headers instead of WebKit headers.
320         
321         * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: Added.
322         New makefile that handles copying WebKitLegacy headers to the WebKit framework, rewriting WebKitLegacy
323         imports to WebKit imports. (On iOS the WebKit headers just forward to the relevant WebKitLegacy headers).
324         On OS X, this also handles copying WebKit2 headers to the WebKit framework, rewriting WebKit2 imports to WebKit imports
325         and getting rid of C SPI imports.
326         
327         * WebKitLegacy/MigrateHeadersToLegacy.make: Removed.
328         This is no longer needed.
329         
330         * WebKitLegacy/WebKit.h: Added.
331         New umbrella header that imports the modern API if available, as well as the legacy API (using WebKit/WebKitLegacy.h).
332
333         * WebKitLegacy/WebKit.m:
334         This is an empty file so we'll have something to link.
335
336         * WebKitLegacy/WebKitPrivate.h:
337         New SPI header that imports the private headers of the modern API.
338
339         * WebView/WebDataSource.h:
340         * WebView/WebDataSource.mm:
341         * WebView/WebDataSourcePrivate.h:
342         * WebView/WebDelegateImplementationCaching.h:
343         * WebView/WebDocument.h:
344         * WebView/WebDocumentInternal.h:
345         * WebView/WebDocumentPrivate.h:
346         * WebView/WebEditingDelegate.h:
347         * WebView/WebEditingDelegatePrivate.h:
348         * WebView/WebFrameLoadDelegate.h:
349         * WebView/WebFrameLoadDelegatePrivate.h:
350         * WebView/WebFramePrivate.h:
351         * WebView/WebFrameView.h:
352         * WebView/WebFrameViewInternal.h:
353         * WebView/WebFrameViewPrivate.h:
354         * WebView/WebHTMLRepresentation.h:
355         * WebView/WebHTMLRepresentation.mm:
356         * WebView/WebHTMLRepresentationPrivate.h:
357         * WebView/WebHTMLView.h:
358         * WebView/WebHTMLView.mm:
359         * WebView/WebHTMLViewPrivate.h:
360         * WebView/WebPDFView.h:
361         * WebView/WebPolicyDelegatePrivate.h:
362         * WebView/WebPreferencesPrivate.h:
363         * WebView/WebResourcePrivate.h:
364         * WebView/WebUIDelegate.h:
365         * WebView/WebUIDelegatePrivate.h:
366         * WebView/WebView.h:
367         * WebView/WebView.mm:
368         * WebView/WebViewPrivate.h:
369         Import WebKitLegacy headers instead of WebKit headers.
370
371         * migrate-headers.sh:
372         Derived sources are put in DerivedSources/WebKitLegacy now.
373
374 2014-04-30  David Hyatt  <hyatt@apple.com>
375
376         [New Multicolumn] Enable new multi-column mode
377         https://bugs.webkit.org/show_bug.cgi?id=131825
378
379         Reviewed by Simon Fraser.
380
381         * WebView/WebPreferences.mm:
382         (+[WebPreferences initialize]):
383
384 2014-04-30  Brian J. Burg  <burg@cs.washington.edu>
385
386         Clean up unnecessary methods in the BackForwardClient interface
387         https://bugs.webkit.org/show_bug.cgi?id=131637
388
389         Reviewed by Andreas Kling.
390
391         BackForwardClient instances now have ownership lifetime semantics, so
392         WebBackForwardList now explicitly deletes its inner BackForwardList.
393
394         Convert uses of WebCore::BackForwardList through backForward().client() to
395         accept references instead of pointers.
396
397         Use BackForwardController methods rather than directly operating with the
398         BackForwardClient where possible.
399
400         Remove page cache-related methods that are not used anywhere and that call
401         BackForwardClient::page(), which is removed by this change.
402
403         * History/WebBackForwardList.mm:
404         (-[WebBackForwardList initWithBackForwardList:]):
405         (-[WebBackForwardList init]):
406         (-[WebBackForwardList dealloc]):
407         (-[WebBackForwardList finalize]):
408         (-[WebBackForwardList setPageCacheSize]): Deleted.
409         (-[WebBackForwardList pageCacheSize]): Deleted.
410         (-[WebBackForwardList itemAtIndex:]): Deleted.
411         * History/WebBackForwardListInternal.h:
412         * WebCoreSupport/WebFrameLoaderClient.mm:
413         (WebFrameLoaderClient::canCachePage):
414         * WebView/WebFrameView.mm:
415         (-[WebFrameView keyDown:keyDown:]):
416         * WebView/WebView.mm:
417         (-[WebView _loadBackForwardListFromOtherView:]):
418         (-[WebView initWithCoder:]):
419         (-[WebView encodeWithCoder:]):
420         (-[WebView backForwardList]):
421         (-[WebView setMaintainsBackForwardList:]):
422
423 2014-04-29  Sam Weinig  <sam@webkit.org>
424
425         [iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS
426         https://bugs.webkit.org/show_bug.cgi?id=132359
427
428         Reviewed by Darin Adler.
429
430         * WebView/WebHTMLView.mm:
431         (imageFromRect):
432         (selectionImage):
433         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
434         Bring back the old FrameSnapshottingMac code for drawing the selection image as drag code for this
435         is still unimplemented on iOS.
436
437         * WebView/WebView.mm:
438         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
439         Set the page scale for "simple HTML documents" (this is already done for the all other documents), 
440         to ensure that the snapshot is the correct size.
441
442 2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
443
444         [CSS Grid Layout] Enable runtime feature by default
445         https://bugs.webkit.org/show_bug.cgi?id=132189
446
447         Reviewed by Benjamin Poulain.
448
449         * WebView/WebPreferences.mm:
450         (+[WebPreferences initialize]): Remove unneeded changes that
451         enable/disable the runtime feature depending on the compilation flag.
452         And set it to true by default.
453
454 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
455
456         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
457         https://bugs.webkit.org/show_bug.cgi?id=112840
458
459         Rubber stamped by Geoffrey Garen.
460
461         * Configurations/FeatureDefines.xcconfig:
462
463 2014-04-29  Brady Eidson  <beidson@apple.com>
464
465         Change Image Controls replacement to use selection and paste
466         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
467
468         Reviewed by Tim Horton.
469
470         * Misc/WebSharingServicePickerController.mm:
471         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
472           replacement data to a special pasteboard, then replace the current selection from
473           that pasteboard.
474
475 2014-04-27  Sam Weinig  <sam@webkit.org>
476
477         [iOS WebKit2] Add support for text autosizing
478         <rdar://problem/16545245>
479         https://bugs.webkit.org/show_bug.cgi?id=132237
480
481         Reviewed by Tim Horton.
482
483         * WebView/WebFrame.mm:
484         (-[WebFrame _setTextAutosizingWidth:]):
485         Forward setting of the text autosizing width to the Page.
486
487 2014-04-25  Dean Jackson  <dino@apple.com>
488
489         Allow a platform-specific size enumeration to be passed into popup-menu display
490         https://bugs.webkit.org/show_bug.cgi?id=132195
491
492         Reviewed by Brent Fulgham. With some in-person review comments from Sam Weinig.
493
494         Platforms like OS X use a set of predefined sizes for built-in controls
495         used for <select>: normal, small and mini. Expose that information to
496         the PopupMenuClient via the PopupMenuStyle, allowing it to be passed
497         into the platform code in WebKitSystemInterface.
498
499         * WebCoreSupport/PopupMenuMac.mm:
500         (PopupMenuMac::show): Convert the WebCore menu size type into the
501         WebCoreSystemInterface type.
502
503 2014-04-24  Commit Queue  <commit-queue@webkit.org>
504
505         Unreviewed, rolling out r167700.
506         https://bugs.webkit.org/show_bug.cgi?id=132142
507
508         Incorrectly reverted the change in r167547 for
509         webkit.org/b/131898 (Requested by rniwa on #webkit).
510
511         Reverted changeset:
512
513         "Cursor doesn't change back to pointer when leaving the Safari
514         window"
515         https://bugs.webkit.org/show_bug.cgi?id=132038
516         http://trac.webkit.org/changeset/167700
517
518 2014-04-24  Brady Eidson  <beidson@apple.com>
519
520         Rename "IMAGE_CONTROLS" feature to "SERVICE_CONTROLS"
521         https://bugs.webkit.org/show_bug.cgi?id=132155
522
523         Reviewed by Tim Horton.
524
525         * Configurations/FeatureDefines.xcconfig:
526         * Misc/WebSharingServicePickerController.h:
527         * Misc/WebSharingServicePickerController.mm:
528         * WebCoreSupport/WebContextMenuClient.h:
529         * WebCoreSupport/WebContextMenuClient.mm:
530         (WebContextMenuClient::contextMenuForEvent):
531         * WebView/WebPreferences.mm:
532         (+[WebPreferences initialize]):
533         * WebView/WebView.mm:
534         (-[WebView _preferencesChanged:]):
535
536 2014-04-24  Ryosuke Niwa  <rniwa@webkit.org>
537
538         Text caret disappears in Mail after returning from another application
539         https://bugs.webkit.org/show_bug.cgi?id=132111
540
541         Reviewed by Darin Adler.
542
543         The bug was caused by our SPI _windowChangedKeyState not getting called upon deminiaturization.
544
545         Fixed the bug by using the standard NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification
546         notifications as done in WebKit2 since they DO get called upon deminiaturization.
547
548         * WebView/WebView.mm:
549         (-[WebView addWindowObserversForWindow:]):
550         (-[WebView removeWindowObservers]):
551         (-[WebView _windowKeyStateChanged:]):
552         (-[WebView _windowChangedKeyState]): Deleted.
553
554 2014-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
555
556         FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
557         https://bugs.webkit.org/show_bug.cgi?id=132110
558
559         Reviewed by Tim Horton.
560
561         Updates callers to use '.' instead of '->'.
562
563         No new tests are necessary because there should be no behavior change.
564
565         * Misc/WebCoreStatistics.mm:
566         (+[WebCoreStatistics cachedFontDataCount]):
567         (+[WebCoreStatistics cachedFontDataInactiveCount]):
568         (+[WebCoreStatistics purgeInactiveFontData]):
569         * WebView/WebView.mm:
570         (+[WebView purgeInactiveFontData]):
571
572 2014-04-24  Eric Carlson  <eric.carlson@apple.com>
573
574         [iOS] Manage AudioSession category according to media type
575         https://bugs.webkit.org/show_bug.cgi?id=132096
576
577         Reviewed by Jer Noble.
578
579         * WebView/WebView.mm:
580         (-[WebView _commonInitializationWithFrameName:groupName:]): Tell 
581             WebCore to manage the AudioSession when running in MobileSafari.
582
583 2014-04-23  Andreas Kling  <akling@apple.com>
584
585         Remove Apple Dictionary workaround in WebFrameLoaderClient.
586         <https://webkit.org/b/132095>
587
588         Kill a hack to work around a WK1 client bug that got fixed years ago.
589         See <rdar://problem/6471058> for backstory.
590
591         Reviewed by Darin Adler.
592
593         * WebCoreSupport/WebFrameLoaderClient.mm:
594         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
595         (WebFrameLoaderClient::dispatchWillSendRequest):
596         (applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
597         (applyAppleDictionaryApplicationQuirk): Deleted.
598
599 2014-04-23  Anders Carlsson  <andersca@apple.com>
600
601         Don't migrate the WKView.h header from WebCore to WebKit
602         https://bugs.webkit.org/show_bug.cgi?id=132086
603
604         Reviewed by Dan Bernstein.
605
606         * MigrateHeaders.make:
607         Remove WKView.h from the list of headers to migrate.
608
609         * WebView/WebView.mm:
610         Import WKView.h.
611
612 2014-04-22  Ryosuke Niwa  <rniwa@webkit.org>
613
614         Cursor doesn't change back to pointer when leaving the Safari window
615         https://bugs.webkit.org/show_bug.cgi?id=132038
616
617         Reviewed by Alexey Proskuryakov.
618
619         Since the cursor type is now updated asynchronously after r147739,
620         [window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
621         evalutes to false depending on how fast cursor is moving.
622
623         Instead, check whether the NSWindow of the WebView is the key window or not since
624         key window appears to control the cursor style in Cocoa as far as I've tested:
625         https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
626
627         * WebCoreSupport/WebChromeClient.mm:
628         (WebChromeClient::setCursor):
629
630 2014-04-22  Commit Queue  <commit-queue@webkit.org>
631
632         Unreviewed, rolling out r167674.
633         https://bugs.webkit.org/show_bug.cgi?id=132025
634
635         Going a different way with this (Requested by bradee-oh on
636         #webkit).
637
638         Reverted changeset:
639
640         "Change Image Controls replacement to use selection and paste"
641         https://bugs.webkit.org/show_bug.cgi?id=131992
642         http://trac.webkit.org/changeset/167674
643
644 2014-04-22  Brady Eidson  <beidson@apple.com>
645
646         Change Image Controls replacement to use selection and paste
647         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
648
649         Reviewed by Tim Horton.
650
651         * Misc/WebSharingServicePickerController.mm:
652         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
653           replacement data to a special pasteboard, then replace the current selection from
654           that pasteboard.
655
656 2014-04-21  Eric Carlson  <eric.carlson@apple.com>
657
658         [Mac] implement WebKitDataCue
659         https://bugs.webkit.org/show_bug.cgi?id=131799
660
661         Reviewed by Dean Jackson.
662
663         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
664
665 2014-04-21  Joseph Pecoraro  <pecoraro@apple.com>
666
667         Remove unused WebKitSystemInterface functions
668         https://bugs.webkit.org/show_bug.cgi?id=131938
669
670         Reviewed by Alexey Proskuryakov.
671
672         * WebCoreSupport/WebSystemInterface.mm:
673         (InitWebCoreSystemInterface):
674
675 2014-04-21  Zan Dobersek  <zdobersek@igalia.com>
676
677         Move cross-port Source/WebCore/page/ code to std::unique_ptr
678         https://bugs.webkit.org/show_bug.cgi?id=130534
679
680         Reviewed by Darin Adler.
681
682         * WebView/WebHTMLRepresentation.mm:
683         (searchForLabelsBeforeElement): Pass a RegExp reference to Frame::searchForLabelsAboveCell().
684
685 2014-04-19  Darin Adler  <darin@apple.com>
686
687         [Mac] WebView adjusts the cursor even when another window is in front
688         https://bugs.webkit.org/show_bug.cgi?id=131898
689         rdar://problem/14619911
690
691         Reviewed by Dan Bernstein.
692
693         * WebCoreSupport/WebChromeClient.mm:
694         (WebChromeClient::setCursor): Added a check that the window is under the cursor
695         and do nothing if it's not.
696
697 2014-04-18  Commit Queue  <commit-queue@webkit.org>
698
699         Unreviewed, rolling out r167527.
700         https://bugs.webkit.org/show_bug.cgi?id=131883
701
702         Broke 32-bit build (Requested by ap on #webkit).
703
704         Reverted changeset:
705
706         "[Mac] implement WebKitDataCue"
707         https://bugs.webkit.org/show_bug.cgi?id=131799
708         http://trac.webkit.org/changeset/167527
709
710 2014-04-18  Eric Carlson  <eric.carlson@apple.com>
711
712         [Mac] implement WebKitDataCue
713         https://bugs.webkit.org/show_bug.cgi?id=131799
714
715         Reviewed by Dean Jackson.
716
717         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
718
719 2014-04-17  Daniel Bates  <dabates@apple.com>
720
721         [iOS] Hook up screen.{availHeight, availWidth, height, width}
722         https://bugs.webkit.org/show_bug.cgi?id=131821
723         <rdar://problem/16413795>
724
725         Reviewed by Benjamin Poulain and Tim Horton.
726
727         Add declaration for WKGetViewportAvailableScreenSize() to return the available screen size.
728
729         Additionally substitute "ScreenSize" for "ViewportScreenSize" to make the code more understandable.
730
731         * WebCoreSupport/WebSystemInterface.mm:
732         (InitWebCoreSystemInterface):
733
734 2014-04-17  Darin Adler  <darin@apple.com>
735
736         Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe
737         https://bugs.webkit.org/show_bug.cgi?id=131785
738         rdar://problem/16003108
739
740         Reviewed by Brady Eidson.
741         
742         * Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.
743
744 2014-04-16  Tim Horton  <timothy_horton@apple.com>
745
746         Images dragged from WebKit1 on 2x displays are too big
747         https://bugs.webkit.org/show_bug.cgi?id=131775
748         <rdar://problem/15933525>
749
750         Reviewed by Simon Fraser.
751
752         * WebCoreSupport/WebDragClient.mm:
753         (WebDragClient::startDrag):
754         Scale the drag image's logical size down by the device scale factor
755         in WebKit1 just like we do in WebKit2.
756
757 2014-04-13  Andy Estes  <aestes@apple.com>
758
759         [QuickLook] Move file system-related code into WebKit
760         https://bugs.webkit.org/show_bug.cgi?id=131597
761
762         Reviewed by Dan Bernstein.
763
764         Moved file system and WebKit1-only code from QuickLookHandle into a new
765         QuickLookHandleClient subclass.
766
767         * WebCoreSupport/WebFrameLoaderClient.h:
768         * WebCoreSupport/WebFrameLoaderClient.mm:
769
770 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
771
772         Eliminate DragSession structure
773         https://bugs.webkit.org/show_bug.cgi?id=131465
774
775         Reviewed by Benjamin Poulain.
776
777         * WebView/WebView.mm:
778         (-[WebView draggingEntered:]):
779         (-[WebView draggingUpdated:]):
780
781 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
782
783         Rename some dragging functions
784         https://bugs.webkit.org/show_bug.cgi?id=131460
785
786         Reviewed by Tim Horton.
787
788         Renamed performDrag to performDragOperation.
789
790         * WebView/WebView.mm: (-[WebView performDragOperation:]):
791
792 2014-04-08  Jon Lee  <jonlee@apple.com>
793
794         Turn MSE on by default
795         https://bugs.webkit.org/show_bug.cgi?id=131313
796         <rdar://problem/16525223>
797
798         Reviewed by Jer Noble.
799
800         * Configurations/FeatureDefines.xcconfig:
801         * WebView/WebPreferences.mm:
802         (+[WebPreferences initialize]): Set default to true.
803
804 2014-04-08  Alexey Proskuryakov  <ap@apple.com>
805
806         Rename Clipboard to DataTransfer
807         https://bugs.webkit.org/show_bug.cgi?id=131371
808
809         Reviewed by Anders Carlsson.
810
811         * WebCoreSupport/WebDragClient.h:
812         * WebCoreSupport/WebDragClient.mm:
813         (WebDragClient::willPerformDragSourceAction):
814         (WebDragClient::startDrag):
815         * WebView/WebPDFView.mm:
816
817 2014-04-08  Dan Bernstein  <mitz@apple.com>
818
819         WebKit part of [Cocoa] Add WKFormDelegate
820         https://bugs.webkit.org/show_bug.cgi?id=131343
821
822         Reviewed by Anders Carlsson.
823
824         * MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.
825
826 2014-04-08  Daniel Bates  <dabates@apple.com>
827
828         Fallback to default storage session when there isn't a valid session ID
829         https://bugs.webkit.org/show_bug.cgi?id=131326
830         <rdar://problem/16231679>
831
832         Reviewed by Alexey Proskuryakov.
833
834         Fixes and issue where we may use the wrong storage session after disabling
835         a private browsing session.
836
837         Currently WebKit1 and WebKit2 without NetworkProcess assume that there
838         is always a non-null private browsing storage session so long as the page
839         has a non-default session ID. Instead we should only use the private browsing
840         storage session when it's non-null and the page has a non-default session ID;
841         otherwise, we should use the default storage session. This change will make
842         the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
843         the behavior in WebKit2 with NetworkProcess.
844
845         * WebCoreSupport/WebFrameNetworkingContext.mm:
846         (WebFrameNetworkingContext::storageSession):
847
848 2014-04-06  Sam Weinig  <sam@webkit.org>
849
850         Document user content related APIs
851
852         Reviewed by Anders Carlsson.
853
854         * MigrateHeaders.make:
855
856 2014-04-06  Darin Adler  <darin@apple.com>
857
858         Refactor post-attach and HTMLObjectElement-related code
859         https://bugs.webkit.org/show_bug.cgi?id=131282
860
861         Reviewed by Antti Koivisto.
862
863         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
864         doing a static_cast.
865
866 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
867
868         Enable WEB_REPLAY for PLATFORM(MAC)
869         https://bugs.webkit.org/show_bug.cgi?id=130700
870
871         Reviewed by Timothy Hatcher.
872
873         * Configurations/FeatureDefines.xcconfig:
874
875 2014-04-03  Sam Weinig  <sam@webkit.org>
876
877         [WebKit2] Promote user script SPI to API
878         https://bugs.webkit.org/show_bug.cgi?id=131181
879
880         Reviewed by Anders Carlsson.
881
882         * MigrateHeaders.make:
883
884 2014-04-02  Benjamin Poulain  <bpoulain@apple.com>
885
886         [iOS] Remove the legacy string drawing code
887         https://bugs.webkit.org/show_bug.cgi?id=131088
888
889         Reviewed by Sam Weinig.
890
891         * Configurations/WebKit.xcconfig:
892
893 2014-04-02  Mark Rowe  <mrowe@apple.com>
894
895         <https://webkit.org/b/131135> Introduce LockHistory and LockBackForwardList enums to use in place of bools.
896
897         These arguments are often passed using literals at the call site, where the use of bools severely hinders
898         the readability of the code.
899
900         Reviewed by Andreas Kling.
901
902         * WebView/WebPDFView.mm:
903         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
904
905 2014-04-02  Stephanie Lewis  <slewis@apple.com>
906
907         Roll out http://trac.webkit.org/changeset/166144
908         <rdar://problem/16481284> PLT stops loading on news.google.com
909         
910         Unreviewed rollout.
911
912         Rollout 166144 since it prevents the PLT from completing.
913
914         * WebCoreSupport/WebFrameLoaderClient.mm:
915
916 2014-04-02  Daniel Bates  <dabates@apple.com>
917
918         Remove Settings::maximumDecodedImageSize()
919         https://bugs.webkit.org/show_bug.cgi?id=131057
920         <rdar://problem/15626368>
921
922         Reviewed by Darin Adler. 
923
924         Remove preferences key WebKitMaximumImageSize.
925
926         * WebView/WebPreferenceKeysPrivate.h:
927         * WebView/WebPreferences.mm:
928         (+[WebPreferences initialize]):
929         (-[WebPreferences _maximumImageSize:]): Deleted.
930         * WebView/WebPreferencesPrivate.h:
931         * WebView/WebView.mm:
932         (-[WebView _preferencesChanged:]):
933
934 2014-04-02  Martin Hock  <mhock@apple.com>
935
936         Unify private browsing with sessions.
937         https://bugs.webkit.org/show_bug.cgi?id=130099
938
939         Reviewed by Alexey Proskuryakov.
940
941         * WebCoreSupport/WebFrameLoaderClient.mm: Change WebCore::Settings::privateBrowsingEnabled() to Page::sessionID().isEphemeral().
942         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
943         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
944         (WebFrameNetworkingContext::storageSession):
945         * WebView/WebView.mm: Change WebCore::Settings::setPrivateBrowsingEnabled() to Page::enableLegacyPrivateBrowsing().
946         (-[WebView _preferencesChanged:]):
947
948 2014-04-01  Anders Carlsson  <andersca@apple.com>
949
950         Migrate more headers
951         https://bugs.webkit.org/show_bug.cgi?id=131068
952
953         Reviewed by Tim Horton.
954
955         * MigrateHeaders.make:
956
957 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
958
959         [CSS Grid Layout] Enable runtime feature if feature flag is enabled
960         https://bugs.webkit.org/show_bug.cgi?id=130013
961
962         Reviewed by Simon Fraser.
963
964         Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
965
966         * WebView/WebPreferences.mm:
967         (+[WebPreferences initialize]):
968
969 2014-03-31  Simon Fraser  <simon.fraser@apple.com>
970
971         Enable WEB_TIMING on Mac and iOS
972         https://bugs.webkit.org/show_bug.cgi?id=128064
973
974         Reviewed by Sam Weinig, Brent Fulgham.
975
976         Enable WEB_TIMING.
977
978         * Configurations/FeatureDefines.xcconfig:
979
980 2014-03-31  Dean Jackson  <dino@apple.com>
981
982         Remove WEB_ANIMATIONS
983         https://bugs.webkit.org/show_bug.cgi?id=130989
984
985         Reviewed by Simon Fraser.
986
987         Remove this feature flag until we plan to implement.
988
989         * Configurations/FeatureDefines.xcconfig:
990
991 2014-03-31  Antti Koivisto  <antti@apple.com>
992
993         Rename TileCache to LegacyTileCache
994         https://bugs.webkit.org/show_bug.cgi?id=130986
995
996         Reviewed by Simon Fraser.
997
998         * WebView/WebView.mm:
999         (+[WebView drainLayerPool]):
1000         (+[WebView _setTileCacheLayerPoolCapacity:]):
1001
1002 2014-03-28  Darin Adler  <darin@apple.com>
1003
1004         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1005         https://bugs.webkit.org/show_bug.cgi?id=130889
1006
1007         Reviewed by Alexey Proskuryakov.
1008
1009         * Misc/WebStringTruncator.mm:
1010         (defaultMenuFont): Changed to use NeverDestroyed since I had to touch this file anyway.
1011         (fontFromNSFont): Ditto. Also improved variable names a bit.
1012         (+[WebStringTruncator initialize]): Added threading initialization, needed for main
1013         thread assertions in string truncator code.
1014
1015 2014-03-27  Commit Queue  <commit-queue@webkit.org>
1016
1017         Unreviewed, rolling out r166360.
1018         https://bugs.webkit.org/show_bug.cgi?id=130869
1019
1020         Seems to have broken PLT (Requested by ap on #webkit).
1021
1022         Reverted changeset:
1023
1024         "Connection::dispatchOneMessage() can be re-entered while
1025         handling Cmd-key menu"
1026         https://bugs.webkit.org/show_bug.cgi?id=130767
1027         http://trac.webkit.org/changeset/166360
1028
1029 2014-03-27  Alexey Proskuryakov  <ap@apple.com>
1030
1031         Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
1032         equivalents, ASSERT(!_data->_keyDownEventBeingResent)
1033         https://bugs.webkit.org/show_bug.cgi?id=130767
1034         <rdar://problem/16307487>
1035
1036         Reviewed by Darin Adler.
1037
1038         Switched to a WebCore wrapper for RunLoop::initializeMainRunLoop that adds
1039         NSModalPanelRunLoopMode to RunLoop event source and timer modes.
1040
1041         * Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]):
1042         * History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
1043         * History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
1044         * Misc/WebCache.mm: (+[WebCache initialize]):
1045         * Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
1046         * Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]):
1047         * Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
1048         * Plugins/WebBaseNetscapePluginView.mm:
1049         * Plugins/WebBasePluginPackage.mm:
1050         * Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
1051         * WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]):
1052         * WebCoreSupport/WebFrameLoaderClient.mm:
1053         * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
1054         * WebView/WebDataSource.mm: (+[WebDataSource initialize]):
1055         * WebView/WebHTMLView.mm:
1056         (+[WebHTMLViewPrivate initialize]):
1057         (+[WebHTMLView initialize]):
1058         * WebView/WebPreferences.mm: (+[WebPreferences initialize]):
1059         * WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
1060         * WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]):
1061         * WebView/WebView.mm: (+[WebView initialize]):
1062         * WebView/WebViewData.mm: (+[WebViewPrivate initialize]):
1063
1064 2014-03-26  Timothy Hatcher  <timothy@apple.com>
1065
1066         Propagate the hiddenFromInspector flag on ResourceRequest in
1067         places when a new request a made or passed between processes.
1068
1069         https://bugs.webkit.org/show_bug.cgi?id=130741
1070
1071         Reviewed by Joseph Pecoraro.
1072
1073         * WebCoreSupport/WebFrameLoaderClient.mm:
1074         (WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
1075         the new request.
1076
1077 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
1078
1079         [CSS Shapes] Remove shape-inside support
1080         https://bugs.webkit.org/show_bug.cgi?id=130698
1081
1082         Reviewed by David Hyatt.
1083
1084         * Configurations/FeatureDefines.xcconfig:
1085
1086 2014-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1087
1088         [iOS] Inspector View Indication Support
1089         https://bugs.webkit.org/show_bug.cgi?id=130709
1090
1091         Reviewed by Simon Fraser.
1092
1093         * WebCoreSupport/WebInspectorClient.h:
1094         * WebCoreSupport/WebInspectorClient.mm:
1095         (WebInspectorClient::didSetSearchingForNode): Deleted.
1096         (WebInspectorClient::releaseFrontend): Deleted.
1097         * WebView/WebView.mm:
1098         (-[WebView setShowingInspectorIndication:]):
1099         * WebView/WebViewPrivate.h:
1100         Renamed methods.
1101
1102 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
1103
1104         Activate WebVTT Tests Once Merging is Complete
1105         https://bugs.webkit.org/show_bug.cgi?id=130420
1106
1107         Reviewed by Eric Carlson.
1108
1109         * Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
1110
1111 2014-03-24  Andy Estes  <aestes@apple.com>
1112
1113         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
1114         https://bugs.webkit.org/show_bug.cgi?id=129322
1115
1116         Reviewed by Anders Carlsson.
1117
1118         * WebCoreSupport/WebFrameLoaderClient.mm:
1119         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
1120         RetainPtr returned by releaseConnectionForDownload() rather than
1121         manually releasing.
1122
1123 2014-03-24  Jon Lee  <jonlee@apple.com>
1124
1125         Build fixes.
1126
1127         Unreviewed.
1128
1129         * WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.
1130
1131 2014-03-23  Sam Weinig  <sam@webkit.org>
1132
1133         Remove some unnecessary .get()s that Darin noticed.
1134
1135         * WebView/WebHTMLRepresentation.mm:
1136         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1137         * WebView/WebHTMLView.mm:
1138         (-[WebHTMLView attributedString]):
1139
1140 2014-03-23  Sam Weinig  <sam@webkit.org>
1141
1142         Simplify the HTMLConverter interface (Part 2)
1143         https://bugs.webkit.org/show_bug.cgi?id=130654
1144
1145         Reviewed by Darin Adler.
1146
1147         * WebView/WebHTMLRepresentation.mm:
1148         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1149         * WebView/WebHTMLView.mm:
1150         (-[WebHTMLView attributedSubstringFromRange:]):
1151         (-[WebHTMLView attributedString]):
1152         (-[WebHTMLView selectedAttributedString]):
1153
1154 2014-03-23  Darin Adler  <darin@apple.com>
1155
1156         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1157         https://bugs.webkit.org/show_bug.cgi?id=130653
1158
1159         Reviewed by Antti Koivisto.
1160
1161         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
1162         doing a static_cast.
1163
1164 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1165
1166         Don't flush compositing layers within FrameView::willPaintContents()
1167         https://bugs.webkit.org/show_bug.cgi?id=130627
1168
1169         Reviewed by Sam Weinig.
1170         
1171         Make _flushCompositingChanges private so DRT can call it;
1172         moved it into the Private category.
1173
1174         * WebView/WebView.mm:
1175         (-[WebView _flushCompositingChanges]):
1176         * WebView/WebViewPrivate.h:
1177
1178 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1179
1180         Remove duplicate line added during merging
1181         https://bugs.webkit.org/show_bug.cgi?id=130623
1182
1183         Reviewed by Beth Dakin.
1184         
1185         Remove a duplicate call to -_viewWillDrawInternal which
1186         was added during merges.
1187
1188         * WebView/WebView.mm:
1189         (LayerFlushController::flushLayers):
1190
1191 2014-03-21  Darin Adler  <darin@apple.com>
1192
1193         Improve idiom used for string building in a few places
1194         https://bugs.webkit.org/show_bug.cgi?id=130561
1195
1196         Reviewed by Andreas Kling.
1197
1198         * WebView/WebHTMLRepresentation.mm:
1199         (regExpForLabels): Use StringBuilder.
1200
1201 2014-03-21  Darin Adler  <darin@apple.com>
1202
1203         Add a combined decodeAndFlush to TextResourceDecoder
1204         https://bugs.webkit.org/show_bug.cgi?id=130560
1205
1206         Reviewed by Andreas Kling.
1207
1208         * WebView/WebView.mm:
1209         (+[WebView _decodeData:]): Use decodeAndFlush.
1210
1211 2014-03-20  Anders Carlsson  <andersca@apple.com>
1212
1213         Fix build.
1214
1215         * MigrateHeaders.make:
1216
1217 2014-03-20  Pratik Solanki  <psolanki@apple.com>
1218
1219         [iOS] Get code to compile on older iOS versions
1220         https://bugs.webkit.org/show_bug.cgi?id=130142
1221         <rdar://problem/16302908>
1222
1223         Reviewed by Darin Adler.
1224
1225         * History/WebHistory.mm:
1226         (getDayBoundaries):
1227         * Plugins/WebPluginController.h:
1228         * Plugins/WebPluginController.mm:
1229         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1230         * WebCoreSupport/WebFrameLoaderClient.mm:
1231         (pluginView):
1232         * WebView/WebPreferences.mm:
1233         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
1234         * WebView/WebPreferencesPrivate.h:
1235
1236 2014-03-20  Lucas Forschler  <lforschler@apple.com>
1237
1238     Rollout r165944.  Build break.
1239     
1240 2014-03-19  Pratik Solanki  <psolanki@apple.com>
1241
1242         [iOS] Get code to compile on older iOS versions
1243         https://bugs.webkit.org/show_bug.cgi?id=130142
1244         <rdar://problem/16302908>
1245
1246         Reviewed by Darin Adler.
1247
1248         * History/WebHistory.mm:
1249         (getDayBoundaries):
1250         * Plugins/WebPluginController.h:
1251         * Plugins/WebPluginController.mm:
1252         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1253         * WebCoreSupport/WebFrameLoaderClient.mm:
1254         (pluginView):
1255         * WebView/WebPreferences.mm:
1256         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
1257         * WebView/WebPreferencesPrivate.h:
1258
1259 2014-03-19  Jer Noble  <jer.noble@apple.com>
1260
1261         [Mac][EME] Query whether decoder support exists before creating a new MediaKeys object.
1262         https://bugs.webkit.org/show_bug.cgi?id=130459
1263
1264         Reviewed by Eric Carlson.
1265
1266         * WebCoreSupport/WebSystemInterface.mm:
1267         (InitWebCoreSystemInterface): Initialize the new WCSI method.
1268
1269 2014-03-19  Brady Eidson  <beidson@apple.com>
1270
1271         Filter out editable services from image menu for non-contenteditable images
1272         <rdar://problem/16319645> and https://bugs.webkit.org/show_bug.cgi?id=130437
1273
1274         Reviewed by Tim Horton.
1275
1276         * Misc/WebSharingServicePickerController.h:
1277         * Misc/WebSharingServicePickerController.mm:
1278         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1279           Filter out editing services based on the includeEditorServices flag.
1280         * WebCoreSupport/WebContextMenuClient.mm:
1281         (WebContextMenuClient::contextMenuForEvent):
1282
1283 2014-03-19  Jer Noble  <jer.noble@apple.com>
1284
1285         [iOS] Disable the video plugin proxy by default on WK1.
1286         https://bugs.webkit.org/show_bug.cgi?id=130460
1287
1288         Reviewed by Eric Carlson.
1289
1290         Update the defaults to universally enable the AVFoundationEnabled preference, disable the
1291         VideoPluginProxyEnabled preference, and on iOS only enable the AVKitEnabled preference.
1292
1293         * WebView/WebPreferences.mm:
1294         (+[WebPreferences initialize]):
1295
1296 2014-03-18  Samuel White  <samuel_white@apple.com>
1297
1298         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
1299         https://bugs.webkit.org/show_bug.cgi?id=130250
1300
1301         Reviewed by Chris Fleizach.
1302
1303         Added ability to toggle enhanced accessibility on and off to support tests that require it.
1304
1305         * WebView/WebFrame.mm:
1306         (-[WebFrame enhancedAccessibilityEnabled]):
1307         (-[WebFrame setEnhancedAccessibility:]):
1308         * WebView/WebFramePrivate.h:
1309
1310 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
1311
1312         More FTL enabling.
1313
1314         Rubber stamped by Dan Bernstein.
1315
1316         * Configurations/FeatureDefines.xcconfig:
1317
1318 2014-03-17  Andy Estes  <aestes@apple.com>
1319
1320         Remove staging code added for <http://webkit.org/b/129358> [iOS] Support network state notification using CPNetworkObserver
1321
1322         Reviewed by Enrica Casucci.
1323
1324         * WebView/WebView.mm:
1325
1326 2014-03-17  Anders Carlsson  <andersca@apple.com>
1327
1328         WebKitLegacy headers should #import the relevant WebKit headers
1329         https://bugs.webkit.org/show_bug.cgi?id=130372
1330         <rdar://problem/16349094>
1331
1332         Reviewed by Dan Bernstein.
1333
1334         Create forwarding headers instead.
1335
1336         * WebKitLegacy/MigrateHeadersToLegacy.make:
1337
1338 2014-03-17  Tim Horton  <timothy_horton@apple.com>
1339
1340         Rename WKThumbnailView to _WKThumbnailView
1341         https://bugs.webkit.org/show_bug.cgi?id=130361
1342
1343         Reviewed by Anders Carlsson.
1344
1345         * MigrateHeaders.make:
1346
1347 2014-03-17  David Farler  <dfarler@apple.com>
1348
1349         REGRESSION: WebKitLegacy causes ASan build to fail
1350         <rdar://problem/16344326>
1351
1352         Reviewed by David Kilzer.
1353
1354         * Configurations/DebugRelease.xcconfig: Remove $(inherited) from
1355         OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
1356         double complete ASAN flags.
1357
1358 2014-03-16  Brent Fulgham  <bfulgham@apple.com>
1359
1360         Provide preference to enable additional AVFoundation options
1361         https://bugs.webkit.org/show_bug.cgi?id=130275
1362
1363         Reviewed by Eric Carlson.
1364
1365         * WebView/WebPreferenceKeysPrivate.h: Added new preference.
1366         * WebView/WebPreferences.mm:
1367         (+[WebPreferences initialize]): Initialize preference to false.
1368         (-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
1369         (-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
1370         * WebView/WebPreferencesPrivate.h:
1371         * WebView/WebView.mm:
1372         (-[WebView _preferencesChanged:]): Handle new preference.
1373
1374 2014-03-16  Darin Adler  <darin@apple.com>
1375
1376         Remove all deprecatedCharacters use from WebKit directory
1377         https://bugs.webkit.org/show_bug.cgi?id=130305
1378
1379         Reviewed by Andreas Kling.
1380
1381         * History/BinaryPropertyList.cpp:
1382         (BinaryPropertyListSerializer::appendStringObject): Use operator[]
1383         instead of deprecatedCharacters.
1384
1385 2014-03-14  Mark Rowe  <mrowe@apple.com>
1386
1387         Fix the production build.
1388
1389         Don't rely on USE_INTERNAL_SDK being set for the Production configuration since UseInternalSDK.xcconfig won't
1390         be at the expected relative path when working from installed source.
1391
1392         * Configurations/Base.xcconfig:
1393
1394 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
1395
1396         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
1397         https://bugs.webkit.org/show_bug.cgi?id=130276
1398         <rdar://problem/16266927>
1399         
1400         Reviewed by Simon Fraser.
1401
1402         * Carbon/CarbonUtils.h:
1403         * Carbon/CarbonUtils.m:
1404         * Carbon/CarbonWindowAdapter.h:
1405         * Carbon/CarbonWindowAdapter.mm:
1406         * Carbon/CarbonWindowContentView.h:
1407         * Carbon/CarbonWindowContentView.m:
1408         * Carbon/CarbonWindowFrame.h:
1409         * Carbon/CarbonWindowFrame.m:
1410         * Carbon/HIViewAdapter.h:
1411         * Carbon/HIViewAdapter.m:
1412         * Carbon/HIWebView.h:
1413         * Carbon/HIWebView.mm:
1414         * DOM/WebDOMOperations.h:
1415         * DOM/WebDOMOperations.mm:
1416         * DOM/WebDOMOperationsInternal.h:
1417         * DOM/WebDOMOperationsPrivate.h:
1418         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
1419         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1420         * DefaultDelegates/WebDefaultEditingDelegate.h:
1421         * DefaultDelegates/WebDefaultEditingDelegate.m:
1422         * DefaultDelegates/WebDefaultPolicyDelegate.h:
1423         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1424         * DefaultDelegates/WebDefaultUIDelegate.h:
1425         * DefaultDelegates/WebDefaultUIDelegate.m:
1426         * History/WebBackForwardList.h:
1427         * History/WebBackForwardList.mm:
1428         * History/WebBackForwardListInternal.h:
1429         * History/WebBackForwardListPrivate.h:
1430         * History/WebHistory.h:
1431         * History/WebHistory.mm:
1432         * History/WebHistoryInternal.h:
1433         * History/WebHistoryItem.h:
1434         * History/WebHistoryItem.mm:
1435         * History/WebHistoryItemInternal.h:
1436         * History/WebHistoryItemPrivate.h:
1437         * History/WebHistoryPrivate.h:
1438         * History/WebURLsWithTitles.h:
1439         * History/WebURLsWithTitles.m:
1440         * MigrateHeaders.make:
1441         * Misc/OldWebAssertions.c:
1442         * Misc/WebCache.h:
1443         * Misc/WebCache.mm:
1444         * Misc/WebCoreStatistics.h:
1445         * Misc/WebCoreStatistics.mm:
1446         * Misc/WebDownload.h:
1447         * Misc/WebDownload.mm:
1448         * Misc/WebDownloadInternal.h:
1449         * Misc/WebElementDictionary.h:
1450         * Misc/WebElementDictionary.mm:
1451         * Misc/WebIconDatabase.h:
1452         * Misc/WebIconDatabase.mm:
1453         * Misc/WebIconDatabaseDelegate.h:
1454         * Misc/WebIconDatabaseInternal.h:
1455         * Misc/WebIconDatabasePrivate.h:
1456         * Misc/WebKit.h:
1457         * Misc/WebKitErrors.h:
1458         * Misc/WebKitErrors.m:
1459         * Misc/WebKitErrorsPrivate.h:
1460         * Misc/WebKitLogging.h:
1461         * Misc/WebKitLogging.m:
1462         * Misc/WebKitNSStringExtras.h:
1463         * Misc/WebKitNSStringExtras.mm:
1464         * Misc/WebKitStatistics.h:
1465         * Misc/WebKitStatistics.m:
1466         * Misc/WebKitStatisticsPrivate.h:
1467         * Misc/WebKitSystemBits.h:
1468         * Misc/WebKitSystemBits.m:
1469         * Misc/WebKitVersionChecks.h:
1470         * Misc/WebKitVersionChecks.m:
1471         * Misc/WebLocalizableStrings.h:
1472         * Misc/WebLocalizableStrings.mm:
1473         * Misc/WebNSArrayExtras.h:
1474         * Misc/WebNSArrayExtras.m:
1475         * Misc/WebNSControlExtras.h:
1476         * Misc/WebNSControlExtras.m:
1477         * Misc/WebNSDataExtras.h:
1478         * Misc/WebNSDataExtras.m:
1479         * Misc/WebNSDataExtrasPrivate.h:
1480         * Misc/WebNSDictionaryExtras.h:
1481         * Misc/WebNSDictionaryExtras.m:
1482         * Misc/WebNSEventExtras.h:
1483         * Misc/WebNSEventExtras.m:
1484         * Misc/WebNSFileManagerExtras.h:
1485         * Misc/WebNSFileManagerExtras.mm:
1486         * Misc/WebNSImageExtras.h:
1487         * Misc/WebNSImageExtras.m:
1488         * Misc/WebNSObjectExtras.h:
1489         * Misc/WebNSObjectExtras.mm:
1490         * Misc/WebNSPasteboardExtras.h:
1491         * Misc/WebNSPasteboardExtras.mm:
1492         * Misc/WebNSPrintOperationExtras.h:
1493         * Misc/WebNSPrintOperationExtras.m:
1494         * Misc/WebNSURLExtras.h:
1495         * Misc/WebNSURLExtras.mm:
1496         * Misc/WebNSURLRequestExtras.h:
1497         * Misc/WebNSURLRequestExtras.m:
1498         * Misc/WebNSUserDefaultsExtras.h:
1499         * Misc/WebNSUserDefaultsExtras.mm:
1500         * Misc/WebNSViewExtras.h:
1501         * Misc/WebNSViewExtras.m:
1502         * Misc/WebNSWindowExtras.h:
1503         * Misc/WebNSWindowExtras.m:
1504         * Misc/WebStringTruncator.h:
1505         * Misc/WebStringTruncator.mm:
1506         * Misc/WebTypesInternal.h:
1507         * Panels/WebAuthenticationPanel.h:
1508         * Panels/WebAuthenticationPanel.m:
1509         * Panels/WebPanelAuthenticationHandler.h:
1510         * Panels/WebPanelAuthenticationHandler.m:
1511         * Plugins/Hosted/ProxyRuntimeObject.h:
1512         * Plugins/Hosted/ProxyRuntimeObject.mm:
1513         * Plugins/WebBaseNetscapePluginView.h:
1514         * Plugins/WebBaseNetscapePluginView.mm:
1515         * Plugins/WebBasePluginPackage.h:
1516         * Plugins/WebBasePluginPackage.mm:
1517         * Plugins/WebJavaPlugIn.h:
1518         * Plugins/WebNetscapeContainerCheckContextInfo.h:
1519         * Plugins/WebNetscapeContainerCheckPrivate.h:
1520         * Plugins/WebNetscapeContainerCheckPrivate.mm:
1521         * Plugins/WebNetscapePluginPackage.h:
1522         * Plugins/WebNetscapePluginPackage.mm:
1523         * Plugins/WebNetscapePluginStream.h:
1524         * Plugins/WebNetscapePluginStream.mm:
1525         * Plugins/WebNetscapePluginView.h:
1526         * Plugins/WebNetscapePluginView.mm:
1527         * Plugins/WebPlugin.h:
1528         * Plugins/WebPluginContainer.h:
1529         * Plugins/WebPluginContainerCheck.h:
1530         * Plugins/WebPluginContainerCheck.mm:
1531         * Plugins/WebPluginContainerPrivate.h:
1532         * Plugins/WebPluginController.h:
1533         * Plugins/WebPluginController.mm:
1534         * Plugins/WebPluginDatabase.h:
1535         * Plugins/WebPluginDatabase.mm:
1536         * Plugins/WebPluginPackage.h:
1537         * Plugins/WebPluginPackage.mm:
1538         * Plugins/WebPluginRequest.h:
1539         * Plugins/WebPluginRequest.m:
1540         * Plugins/WebPluginViewFactory.h:
1541         * Plugins/WebPluginViewFactoryPrivate.h:
1542         * Plugins/WebPluginsPrivate.h:
1543         * Plugins/WebPluginsPrivate.m:
1544         * Plugins/npapi.mm:
1545         * Storage/WebDatabaseManager.mm:
1546         * Storage/WebDatabaseManagerInternal.h:
1547         * Storage/WebDatabaseManagerPrivate.h:
1548         * WebCoreSupport/SearchPopupMenuMac.mm:
1549         * WebCoreSupport/WebAlternativeTextClient.h:
1550         * WebCoreSupport/WebAlternativeTextClient.mm:
1551         * WebCoreSupport/WebCachedFramePlatformData.h:
1552         * WebCoreSupport/WebChromeClient.h:
1553         * WebCoreSupport/WebChromeClient.mm:
1554         * WebCoreSupport/WebContextMenuClient.h:
1555         * WebCoreSupport/WebContextMenuClient.mm:
1556         * WebCoreSupport/WebDragClient.h:
1557         * WebCoreSupport/WebDragClient.mm:
1558         * WebCoreSupport/WebEditorClient.h:
1559         * WebCoreSupport/WebEditorClient.mm:
1560         * WebCoreSupport/WebFrameLoaderClient.h:
1561         * WebCoreSupport/WebFrameLoaderClient.mm:
1562         * WebCoreSupport/WebIconDatabaseClient.h:
1563         * WebCoreSupport/WebIconDatabaseClient.mm:
1564         * WebCoreSupport/WebInspectorClient.h:
1565         * WebCoreSupport/WebInspectorClient.mm:
1566         * WebCoreSupport/WebJavaScriptTextInputPanel.h:
1567         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1568         * WebCoreSupport/WebSecurityOrigin.mm:
1569         * WebCoreSupport/WebSecurityOriginInternal.h:
1570         * WebCoreSupport/WebSecurityOriginPrivate.h:
1571         * WebCoreSupport/WebSystemInterface.h:
1572         * WebCoreSupport/WebSystemInterface.mm:
1573         * WebInspector/WebInspector.h:
1574         * WebInspector/WebInspector.mm:
1575         * WebInspector/WebInspectorPrivate.h:
1576         * WebInspector/WebNodeHighlight.h:
1577         * WebInspector/WebNodeHighlight.mm:
1578         * WebInspector/WebNodeHighlightView.h:
1579         * WebInspector/WebNodeHighlightView.mm:
1580         * WebInspector/WebNodeHighlighter.h:
1581         * WebInspector/WebNodeHighlighter.mm:
1582         * WebKitLegacy/MigrateHeadersToLegacy.make:
1583         * WebKitPrefix.h:
1584         * WebView/WebArchive.h:
1585         * WebView/WebArchive.mm:
1586         * WebView/WebArchiveInternal.h:
1587         * WebView/WebClipView.h:
1588         * WebView/WebClipView.mm:
1589         * WebView/WebDashboardRegion.h:
1590         * WebView/WebDashboardRegion.mm:
1591         * WebView/WebDataSource.h:
1592         * WebView/WebDataSource.mm:
1593         * WebView/WebDataSourceInternal.h:
1594         * WebView/WebDataSourcePrivate.h:
1595         * WebView/WebDelegateImplementationCaching.h:
1596         * WebView/WebDelegateImplementationCaching.mm:
1597         * WebView/WebDocument.h:
1598         * WebView/WebDocumentInternal.h:
1599         * WebView/WebDocumentLoaderMac.h:
1600         * WebView/WebDocumentLoaderMac.mm:
1601         * WebView/WebDocumentPrivate.h:
1602         * WebView/WebDynamicScrollBarsViewInternal.h:
1603         * WebView/WebEditingDelegate.h:
1604         * WebView/WebEditingDelegatePrivate.h:
1605         * WebView/WebFormDelegate.h:
1606         * WebView/WebFormDelegate.m:
1607         * WebView/WebFormDelegatePrivate.h:
1608         * WebView/WebFrame.h:
1609         * WebView/WebFrame.mm:
1610         * WebView/WebFrameInternal.h:
1611         * WebView/WebFrameLoadDelegate.h:
1612         * WebView/WebFrameLoadDelegatePrivate.h:
1613         * WebView/WebFramePrivate.h:
1614         * WebView/WebFrameView.h:
1615         * WebView/WebFrameView.mm:
1616         * WebView/WebFrameViewInternal.h:
1617         * WebView/WebFrameViewPrivate.h:
1618         * WebView/WebHTMLRepresentation.h:
1619         * WebView/WebHTMLRepresentation.mm:
1620         * WebView/WebHTMLRepresentationPrivate.h:
1621         * WebView/WebHTMLView.h:
1622         * WebView/WebHTMLView.mm:
1623         * WebView/WebHTMLViewInternal.h:
1624         * WebView/WebHTMLViewPrivate.h:
1625         * WebView/WebNotification.h:
1626         * WebView/WebNotification.mm:
1627         * WebView/WebNotificationInternal.h:
1628         * WebView/WebPDFRepresentation.h:
1629         * WebView/WebPDFRepresentation.mm:
1630         * WebView/WebPDFView.h:
1631         * WebView/WebPDFView.mm:
1632         * WebView/WebPolicyDelegate.h:
1633         * WebView/WebPolicyDelegate.mm:
1634         * WebView/WebPolicyDelegatePrivate.h:
1635         * WebView/WebPreferenceKeysPrivate.h:
1636         * WebView/WebPreferences.h:
1637         * WebView/WebPreferences.mm:
1638         * WebView/WebPreferencesPrivate.h:
1639         * WebView/WebRenderLayer.h:
1640         * WebView/WebRenderLayer.mm:
1641         * WebView/WebRenderNode.h:
1642         * WebView/WebRenderNode.mm:
1643         * WebView/WebResource.h:
1644         * WebView/WebResource.mm:
1645         * WebView/WebResourceInternal.h:
1646         * WebView/WebResourceLoadDelegate.h:
1647         * WebView/WebResourceLoadDelegatePrivate.h:
1648         * WebView/WebResourcePrivate.h:
1649         * WebView/WebScriptDebugDelegate.h:
1650         * WebView/WebScriptDebugDelegate.mm:
1651         * WebView/WebScriptDebugger.h:
1652         * WebView/WebScriptDebugger.mm:
1653         * WebView/WebTextCompletionController.mm:
1654         * WebView/WebUIDelegate.h:
1655         * WebView/WebUIDelegatePrivate.h:
1656         * WebView/WebView.h:
1657         * WebView/WebView.mm:
1658         * WebView/WebViewData.h:
1659         * WebView/WebViewData.mm:
1660         * WebView/WebViewInternal.h:
1661         * WebView/WebViewPrivate.h:
1662
1663 2014-03-14  Ryosuke Niwa  <rniwa@webkit.org>
1664
1665         REGRESSION(r165385): [WebTextIterator currentRange] crashes
1666         https://bugs.webkit.org/show_bug.cgi?id=130271
1667
1668         Reviewed by Anders Carlsson.
1669
1670         After r165385, TextIterator::range no longer checked the nullity of m_positionNode. As a result,
1671         [WebTextIterator currentRange] which simply calls TextIterator::range crashes when an application
1672         that embeds WebKit doesn't check [WebTextIterator atEnd] first.
1673
1674         Preserve the old public API behavior by checking atEnd in [WebTextIterator currentRange].
1675
1676         * WebView/WebTextIterator.mm:
1677         (-[WebTextIterator currentRange]):
1678
1679 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1680
1681         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1682         https://bugs.webkit.org/show_bug.cgi?id=129612
1683
1684         Reviewed by Darin Adler.
1685
1686         For new code use static NeverDestroyed<T> instead.
1687
1688         * History/WebBackForwardList.mm:
1689         (backForwardLists):
1690         * History/WebHistoryItem.mm:
1691         (historyItemWrappers):
1692         * Misc/WebNSPasteboardExtras.mm:
1693         (+[NSPasteboard _web_writableTypesForURL]):
1694         (_writableTypesForImageWithoutArchive):
1695         (_writableTypesForImageWithArchive):
1696         * Misc/WebStringTruncator.mm:
1697         (fontFromNSFont):
1698         * Plugins/Hosted/NetscapePluginHostManager.mm:
1699         (WebKit::NetscapePluginHostManager::shared):
1700         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1701         (WebKit::pluginProxyMap):
1702         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1703         (WebKit::globalExceptionString):
1704         * Plugins/Hosted/ProxyInstance.mm:
1705         (WebKit::proxyClass):
1706         * Plugins/WebNetscapePluginStream.mm:
1707         (streams):
1708         * Storage/WebDatabaseManager.mm:
1709         (transactionBackgroundTaskIdentifierLock):
1710         * WebCoreSupport/WebUserMediaClient.mm:
1711         (userMediaRequestsMap):
1712         * WebView/WebHTMLRepresentation.mm:
1713         (regExpForLabels):
1714         * WebView/WebView.mm:
1715         (aeDescFromJSValue):
1716
1717 2014-03-13  Tim Horton  <timothy_horton@apple.com>
1718
1719         Fix relative paths to UseInternalSDK.xcconfig for ANGLE and WebKit/mac
1720
1721         Rubber-stamped by Mark Rowe.
1722
1723         One-too-few "..".
1724
1725         * Configurations/Base.xcconfig:
1726
1727 2014-03-13  Anders Carlsson  <andersca@apple.com>
1728
1729         Fix build.
1730
1731         * Misc/WebSharingServicePickerController.mm:
1732
1733 2014-03-13  Radu Stavila  <stavila@adobe.com>
1734
1735         Webkit not building on XCode 5.1 due to garbage collection no longer being supported
1736         https://bugs.webkit.org/show_bug.cgi?id=130087
1737
1738         Reviewed by Mark Rowe.
1739
1740         Disable garbage collection on macosx when not using internal SDK.
1741
1742         * Configurations/Base.xcconfig:
1743
1744 2014-03-10  Darin Adler  <darin@apple.com>
1745
1746         Avoid copy-prone idiom "for (auto item : collection)"
1747         https://bugs.webkit.org/show_bug.cgi?id=129990
1748
1749         Reviewed by Geoffrey Garen.
1750
1751         * WebView/WebFrame.mm:
1752         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
1753         Use auto*. Also removed uneeded ASSERT_NO_EXCEPTION, which is already
1754         the default without specifying it explicitly.
1755
1756 2014-03-12  Brian Burg  <bburg@apple.com>
1757
1758         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1759         https://bugs.webkit.org/show_bug.cgi?id=129744
1760
1761         Reviewed by Timothy Hatcher.
1762
1763         * WebInspector/WebInspector.mm:
1764         (-[WebInspector evaluateInFrontend:script:]):
1765         * WebInspector/WebInspectorPrivate.h:
1766
1767 2014-03-12  Dean Jackson  <dino@apple.com>
1768
1769         [WebGL] WebKit1 + WebKit2 iOS clients should check load policy
1770         https://bugs.webkit.org/show_bug.cgi?id=130162
1771
1772         Reviewed by Simon Fraser.
1773
1774         Implement the webGLPolicyForURL methods, calling into WebKitSystemInterface.
1775
1776         * Configurations/WebKit.xcconfig: Add MobileAsset to iOS config.
1777         * WebCoreSupport/WebFrameLoaderClient.h:
1778         * WebCoreSupport/WebFrameLoaderClient.mm:
1779
1780 2014-03-12  Joseph Pecoraro  <pecoraro@apple.com>
1781
1782         Web Inspector: Disable REMOTE_INSPECTOR in earlier OS X releases
1783         https://bugs.webkit.org/show_bug.cgi?id=130118
1784
1785         Reviewed by Timothy Hatcher.
1786
1787         * Configurations/FeatureDefines.xcconfig:
1788
1789         * WebCoreSupport/WebInspectorClient.mm:
1790         (WebInspectorClient::indicate):
1791         (WebInspectorClient::hideIndication):
1792         Properly guard REMOTE_INSPECTOR only calls.
1793
1794 2014-03-12  Tim Horton  <timothy_horton@apple.com>
1795
1796         Build fix for ENABLE(IMAGE_CONTROLS) after 165479
1797
1798         * Misc/WebSharingServicePickerController.h:
1799         * Misc/WebSharingServicePickerController.mm:
1800         Don't use new-runtime features in code that has to build 32-bit.
1801
1802 2014-03-12  Anders Carlsson  <andersca@apple.com>
1803
1804         <rdar://problem/16307346> Add new WebKitLegacy.framework.
1805
1806         Reviewed by Dan Bernstein.
1807
1808         * Configurations/WebKitLegacy.xcconfig:
1809         Add xcconfig file for the new framework.
1810
1811         * WebKitLegacy/Info.plist:
1812         Add Info.plist for WebKitLegacy.framework.
1813
1814         * WebKitLegacy/MigrateHeadersToLegacy.make:
1815         Add makefile that copies headers from WebKit to WebKitLegacy and rewrites includes from WebKit/ to WebKitLegacy/
1816         * WebKitLegacy/WebKitLegacy.cpp:
1817         Add an empty file so we'll have something to link.
1818
1819 2014-03-12  Tim Horton  <timothy_horton@apple.com>
1820
1821         Hook up image controls for WebKit1
1822         https://bugs.webkit.org/show_bug.cgi?id=130062
1823         <rdar://problem/15964809>
1824
1825         Reviewed by Brady Eidson.
1826
1827         * Misc/WebSharingServicePickerController.h: Added.
1828         * Misc/WebSharingServicePickerController.mm: Added.
1829         (-[WebSharingServicePickerController initWithImage:menuClient:]):
1830         (-[WebSharingServicePickerController menu]):
1831         (-[WebSharingServicePickerController sharingServicePicker:delegateForSharingService:]):
1832         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
1833         (-[WebSharingServicePickerController sharingService:didShareItems:]):
1834         (-[WebSharingServicePickerController sharingService:didFailToShareItems:error:]):
1835         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1836         Add a NSSharingServiceDelegate and NSSharingServicePickerDelegate, which will also
1837         provide a NSMenu instance for WebContextMenuClient to pop up when image controls are needed.
1838         When data is returned from the service, it is re-inserted into the image via replaceControlledImage.
1839
1840         * WebCoreSupport/WebContextMenuClient.h:
1841         * WebCoreSupport/WebContextMenuClient.mm:
1842         (WebContextMenuClient::contextMenuForEvent):
1843         Factor out code to decide which NSMenu to use, so that we can use early-returns to simplify it.
1844         If we hit an image with image controls, use the WebSharingServicePickerController's menu.
1845
1846         (WebContextMenuClient::showContextMenu):
1847         (WebContextMenuClient::clearSharingServicePickerController):
1848
1849 2014-03-10  Jer Noble  <jer.noble@apple.com>
1850
1851         [iOS][WK1] Crash in HTMLMediaElement::createElementRenderer() - "-[NSSet addObject:]: object cannot be nil"
1852         https://bugs.webkit.org/show_bug.cgi?id=129634
1853
1854         Reviewed by Eric Carlson.
1855
1856         If a plugin fails to create a NSView, a nil object is inserted into the WebPluginController's
1857         pluginViews set. This is an exceptional case, so add an ASSERT so that this error will continue
1858         to occur in debug builds, but also add an early return so as not to crash release builds.
1859
1860         * Plugins/WebPluginController.mm:
1861         (+[WebPluginController addPlugInView:]):
1862
1863 2014-03-06  Alexey Proskuryakov  <ap@apple.com>
1864
1865         [Mac] Don't perform a round-trip through WebProcess before interpreting key events
1866         https://bugs.webkit.org/show_bug.cgi?id=129812
1867
1868         Reviewed by Darin Adler.
1869
1870         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleInputMethodKeydown):
1871         Added a FIXME. WebKit1/mac is the only port that uses this roundabout way to
1872         interpret events, so it would simplify code if we switched it to WebKit2/mac model.
1873
1874 2014-03-08  Simon Fraser  <simon.fraser@apple.com>
1875
1876         [iOS Wk2] Can't scroll after going back to page in page cache
1877         https://bugs.webkit.org/show_bug.cgi?id=129989
1878         <rdar://problem/16217588>
1879
1880         Reviewed by Dan Bernstein.
1881
1882         iOS has a special FrameLoader::forceLayoutWithoutRecalculatingStyle()
1883         function that is called instead of FrameView::forceLayout(). This was unimplemented
1884         for the WK2 FrameLoaderClient, so no layout was forced, with the result
1885         that the contentSize was never updated and scrolling was broken.
1886         
1887         Fix by renaming the client function to forceLayoutOnRestoreFromPageCache()
1888         and having it return a bool to say whether the default forceLayout()
1889         should be done. WK1 can then continue to have its custom behavior,
1890         and Wk2 will simply do a forceLayout().
1891         
1892         Also remove FrameLaoderClient::forceLayout(), which was never called.
1893
1894         * WebCoreSupport/WebFrameLoaderClient.h:
1895         * WebCoreSupport/WebFrameLoaderClient.mm:
1896         (WebFrameLoaderClient::forceLayoutOnRestoreFromPageCache):
1897
1898 2014-03-07  Anders Carlsson  <andersca@apple.com>
1899
1900         Add the remaining WebKit2 headers to WEBKIT2_HEADERS
1901         https://bugs.webkit.org/show_bug.cgi?id=129942
1902         <rdar://problem/15920020>
1903
1904         Reviewed by Tim Horton.
1905
1906         * MigrateHeaders.make:
1907
1908 2014-03-07  Anders Carlsson  <andersca@apple.com>
1909
1910         MigrateHeaders.make should remove C SPI includes from WebKit2 headers
1911         https://bugs.webkit.org/show_bug.cgi?id=129937
1912         <rdar://problem/15920020>
1913
1914         Reviewed by Tim Horton.
1915
1916         * MigrateHeaders.make:
1917         Add WKPreferences.h to WEBKIT2_HEADERS. 
1918         Add a sed rule that deletes all lines that start with a # and contain <WebKit/*Ref.h>.
1919
1920 2014-03-07  Anders Carlsson  <andersca@apple.com>
1921
1922         Make it possible to copy WebKit2 headers to WebKit.framework
1923         https://bugs.webkit.org/show_bug.cgi?id=129935
1924         <rdar://problem/15920020>
1925
1926         Reviewed by Dan Bernstein.
1927
1928         * MigrateHeaders.make:
1929         Gather a list of public and private WebKit2 headers and filter them against the WEBKIT2_HEADERS list.
1930         The matching headers are copied to the respective Headers or PrivateHeaders directories under WebKit.framework,
1931         and also have their #imports rewritten to reference WebKit instead of WebKit2.
1932
1933         * migrate-headers.sh: Added.
1934         Set up the WEBKIT2_FRAMEWORKS_DIR if needed.
1935
1936 2014-03-07  Anders Carlsson  <andersca@apple.com>
1937
1938         Fix a typo
1939         <rdar://problem/15920020>
1940
1941         Rubber-stamped by Dan Bernstein.
1942
1943         * Configurations/WebKit.xcconfig:
1944
1945 2014-03-07  Anders Carlsson  <andersca@apple.com>
1946
1947         Tweak the WebKit2 frameworks directories
1948         https://bugs.webkit.org/show_bug.cgi?id=129910
1949         <rdar://problem/15920020>
1950
1951         Reviewed by Dan Bernstein.
1952
1953         Use an SDK relative directory for production builds.
1954
1955         * Configurations/WebKit.xcconfig:
1956
1957 2014-03-07  Anders Carlsson  <andersca@apple.com>
1958
1959         Link WebKit.framework against WebKit2.framework and re-export all WebKit2 symbols
1960         https://bugs.webkit.org/show_bug.cgi?id=129901
1961         <rdar://problem/15920020>
1962
1963         Reviewed by Andreas Kling.
1964
1965         * Configurations/WebKit.xcconfig:
1966
1967 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1968
1969         Web Inspector: Expose the console object in JSContexts to interact with Web Inspector
1970         https://bugs.webkit.org/show_bug.cgi?id=127944
1971
1972         Reviewed by Geoffrey Garen.
1973
1974         * WebCoreSupport/WebChromeClient.h:
1975         * WebCoreSupport/WebChromeClient.mm:
1976         Update namespaces.
1977
1978 2014-03-05  Eric Carlson  <eric.carlson@apple.com>
1979
1980         [iOS] Show external device name/type in placeholder
1981         https://bugs.webkit.org/show_bug.cgi?id=129723
1982
1983         Reviewed by Jer Noble.
1984
1985         * WebCoreSupport/WebSystemInterface.mm:
1986         (InitWebCoreSystemInterface):
1987
1988 2014-03-05  Simon Fraser  <simon.fraser@apple.com>
1989
1990         ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework
1991         https://bugs.webkit.org/show_bug.cgi?id=129752
1992
1993         Reviewed by Enrica Casucci.
1994         
1995         Call URLByCanonicalizingURL() which is implemented in WebCore.
1996
1997         * Misc/WebNSURLExtras.mm:
1998         (-[NSURL _webkit_canonicalize]):
1999
2000 2014-03-04  Zalan Bujtas  <zalan@apple.com>
2001
2002         Enable device pixel repaint rect tracking.
2003         https://bugs.webkit.org/show_bug.cgi?id=129712
2004
2005         Reviewed by Simon Fraser.
2006
2007         Tracked repaint rects are device pixel snapped now to support hiDPI test cases.
2008
2009         * WebView/WebView.mm:
2010         (-[WebView trackedRepaintRects]): Keep existing behavior for now.
2011
2012 2014-03-04  Simon Fraser  <simon.fraser@apple.com>
2013
2014         Allow iOS DumpRenderTree crashes to show application-specific information
2015         https://bugs.webkit.org/show_bug.cgi?id=129705
2016
2017         Reviewed by David Kilzer.
2018
2019         Make the WKSI function SetCrashReportApplicationSpecificInformation available
2020         in iOS simulator builds.
2021
2022         * WebCoreSupport/WebSystemInterface.mm:
2023         (InitWebCoreSystemInterface):
2024
2025 2014-03-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2026
2027         Merge API shims and JSLock
2028         https://bugs.webkit.org/show_bug.cgi?id=129650
2029
2030         Reviewed by Mark Lam.
2031
2032         JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason 
2033         to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.
2034
2035         * WebView/WebFrame.mm:
2036         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2037
2038 2014-03-02  Darin Adler  <darin@apple.com>
2039
2040         Sort Mac platform export files so they merge better
2041         https://bugs.webkit.org/show_bug.cgi?id=129581
2042
2043         Reviewed by Sam Weinig.
2044
2045         * WebKit.exp: Ran the new sort-export-file on this.
2046
2047 2014-03-02  Darin Adler  <darin@apple.com>
2048
2049         Change public text iterator API implementations to not depend on 16-bit character pointers
2050         https://bugs.webkit.org/show_bug.cgi?id=129566
2051
2052         Reviewed by Anders Carlsson.
2053
2054         * WebView/WebTextIterator.mm:
2055         (-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
2056         (-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
2057         next text.
2058         (-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
2059         (-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
2060         probably be removing TextIterator::length eventually.
2061
2062 2014-03-01  Pratik Solanki  <psolanki@apple.com>
2063
2064         [iOS] selectionImageForcingBlackText should return autoreleased object
2065         https://bugs.webkit.org/show_bug.cgi?id=129437
2066         <rdar://problem/15810384>
2067
2068         Reviewed by Darin Adler.
2069
2070         * WebView/WebHTMLView.mm:
2071         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2072
2073 2014-02-28  Dan Bernstein  <mitz@apple.com>
2074
2075         [Mac] Remove MailQuirksUserScript.js
2076         https://bugs.webkit.org/show_bug.cgi?id=129536
2077
2078         Reviewed by Andy Estes.
2079
2080         * Configurations/WebKit.xcconfig: Removed from EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
2081         * Misc/MailQuirksUserScript.js: Removed. This file has been unused since r147447.
2082
2083 2014-02-28  Timothy Hatcher  <timothy@apple.com>
2084
2085         Properly handle when Test.html is not present in Production builds.
2086
2087         https://bugs.webkit.org/show_bug.cgi?id=129506
2088
2089         Reviewed by Joseph Pecoraro.
2090
2091         * WebCoreSupport/WebInspectorClient.mm:
2092         (-[WebInspectorWindowController inspectorTestPagePath]):
2093         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2094
2095 2014-02-27  Brian Burg  <bburg@apple.com>
2096
2097         Web Inspector: model tests should use a special Test.html inspector page
2098         https://bugs.webkit.org/show_bug.cgi?id=129190
2099
2100         Reviewed by Timothy Hatcher.
2101
2102         Support creating a separate test inspector page, based on the value of
2103         InspectorController::isUnderTest(). Modify the navigation policy to check
2104         the URL against both normal and test inspector pages.
2105
2106         * WebCoreSupport/WebInspectorClient.mm:
2107         (WebInspectorClient::openInspectorFrontend):
2108         (-[WebInspectorWindowController init]):
2109         (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
2110         Move the initial navigation of the inspector page to this method, and change
2111         the URL based on the value of InspectorController::isUnderTest().
2112
2113         (-[WebInspectorWindowController inspectorTestPagePath]): Added.
2114         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2115
2116 2014-02-27  Pratik Solanki  <psolanki@apple.com>
2117
2118         Assertion failure at CachedResource.h:196: ASSERT(!m_purgeableData)
2119         https://bugs.webkit.org/show_bug.cgi?id=129349
2120         <rdar://problem/14871837>
2121
2122         Reviewed by Joseph Pecoraro.
2123
2124         The code for clearing out memory mapped notification callbacks is only needed when loading
2125         PDFs. And in such cases, we always have dataSourceDelegate object. So make this code
2126         conditional on its presence so that we don't trigger the assert for non-PDF main resources.
2127
2128         * WebView/WebDataSource.mm:
2129         (-[WebDataSource dealloc]):
2130
2131 2014-02-26  Andy Estes  <aestes@apple.com>
2132
2133         [iOS] Support network state notification using CPNetworkObserver
2134         https://bugs.webkit.org/show_bug.cgi?id=129358
2135
2136         Reviewed by Dan Bernstein.
2137
2138         * WebView/WebView.mm:
2139         (-[WebView _setNetworkStateIsOnline:]): Retained an empty
2140         implementation for binary compatibility for UIKit.
2141         (+[WebView _doNotStartObservingNetworkReachability]): Called
2142         Settings::setShouldOptOutOfNetworkStateObservation(true).
2143         * WebView/WebViewPrivate.h: Removed declaration of
2144         _setNetworkStateIsOnline: and declared
2145         _doNotStartObservingNetworkReachability.
2146
2147 2014-02-25  Anders Carlsson  <andersca@apple.com>
2148
2149         Get rid of VisitedLinkStrategy
2150         https://bugs.webkit.org/show_bug.cgi?id=129324
2151
2152         Reviewed by Dan Bernstein.
2153
2154         * WebCoreSupport/WebPlatformStrategies.h:
2155         * WebCoreSupport/WebPlatformStrategies.mm:
2156
2157 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2158
2159         [CSS Grid Layout] Add ENABLE flag
2160         https://bugs.webkit.org/show_bug.cgi?id=129153
2161
2162         Reviewed by Simon Fraser.
2163
2164         Added ENABLE_CSS_GRID_LAYOUT feature flag.
2165
2166         * Configurations/FeatureDefines.xcconfig:
2167
2168 2014-02-24  Anders Carlsson  <andersca@apple.com>
2169
2170         Add WebViewGroup
2171         https://bugs.webkit.org/show_bug.cgi?id=129280
2172
2173         Reviewed by Dan Bernstein.
2174
2175         This is a first step towards getting rid of page groups in WebCore. The idea is that
2176         everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
2177         WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.
2178
2179         * WebCoreSupport/WebViewGroup.h: Added.
2180         * WebCoreSupport/WebViewGroup.mm: Added.
2181         (webViewGroups):
2182         (WebViewGroup::getOrCreate):
2183         (WebViewGroup::WebViewGroup):
2184         (WebViewGroup::~WebViewGroup):
2185         (WebViewGroup::addWebView):
2186         (WebViewGroup::removeWebView):
2187         * WebView/WebView.mm:
2188         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2189         (-[WebView _close]):
2190         (-[WebView setGroupName:]):
2191         * WebView/WebViewData.h:
2192         * WebView/WebViewData.mm:
2193
2194 2014-02-24  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2195
2196         Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
2197         https://bugs.webkit.org/show_bug.cgi?id=129255
2198
2199         Reviewed by Csaba Osztrogonác.
2200
2201         ENABLE_WORKERS macro was removed in r159679.
2202         Support is now also removed from xcconfig files.
2203
2204         * Configurations/FeatureDefines.xcconfig:
2205
2206 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2207
2208         Remove redundant setting in FeatureDefines.xcconfig
2209
2210         * Configurations/FeatureDefines.xcconfig:
2211
2212 2014-02-23  Sam Weinig  <sam@webkit.org>
2213
2214         Update FeatureDefines.xcconfig
2215
2216         Rubber-stamped by Anders Carlsson.
2217
2218         * Configurations/FeatureDefines.xcconfig:
2219
2220 2014-02-23  Sam Weinig  <sam@webkit.org>
2221
2222         Move telephone number detection behind its own ENABLE macro
2223         https://bugs.webkit.org/show_bug.cgi?id=129236
2224
2225         Reviewed by Dean Jackson.
2226
2227         * Configurations/FeatureDefines.xcconfig:
2228         Add ENABLE_TELEPHONE_NUMBER_DETECTION.
2229
2230 2014-02-21  Sam Weinig  <sam@webkit.org>
2231
2232         Expose phase and momentum phase as SPI on DOMWheelEvent
2233         <rdar://problem/16110871>
2234         https://bugs.webkit.org/show_bug.cgi?id=129184
2235
2236         Reviewed by Anders Carlsson.
2237
2238         * DOM/WebDOMOperations.mm:
2239         (toNSEventPhase):
2240         (-[DOMWheelEvent _phase]):
2241         (-[DOMWheelEvent _momentumPhase]):
2242         * DOM/WebDOMOperationsPrivate.h:
2243         Expose _phase and _momentumPhase as SPI.
2244
2245         * MigrateHeaders.make:
2246         Make DOMWheelEventInternal.h to WebKit.
2247
2248 2014-02-22  David Kilzer  <ddkilzer@apple.com>
2249
2250         Revert r164434 since it actually broke ASan builds
2251         <http://webkit.org/b/128871>
2252
2253         * Configurations/WebKit.xcconfig: This caused -asan-blacklist to
2254         be included twice on every compiler command, which caused clang
2255         to error out.
2256
2257 2014-02-21  Brent Fulgham  <bfulgham@apple.com>
2258
2259         Extend media support for WebVTT sources
2260         https://bugs.webkit.org/show_bug.cgi?id=129156
2261
2262         Reviewed by Eric Carlson.
2263
2264         * Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
2265
2266 2014-02-20  Brady Eidson  <beidson@apple.com>
2267
2268         Add very basic image control rendering
2269         https://bugs.webkit.org/show_bug.cgi?id=129080
2270
2271         Reviewed by Tim Horton.
2272
2273         Expose the imageControlsEnabled setting to WebKit1 so DRT can use it.
2274
2275         * WebView/WebPreferenceKeysPrivate.h:
2276         * WebView/WebPreferences.mm:
2277         (+[WebPreferences initialize]):
2278         (-[WebPreferences imageControlsEnabled]):
2279         (-[WebPreferences setImageControlsEnabled:]):
2280         * WebView/WebPreferencesPrivate.h:
2281
2282         * WebView/WebView.mm:
2283         (-[WebView _preferencesChanged:]):
2284
2285 2014-02-20  David Kilzer  <ddkilzer@apple.com>
2286
2287         [ASan] WebKit1 sources are not compiled using ASAN macros
2288         <http://webkit.org/b/128871>
2289
2290         Reviewed by Brent Fulgham.
2291
2292         * Configurations/WebKit.xcconfig: Use $inherited for
2293         OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
2294         and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
2295         DebugRelease.xcconfig.
2296
2297 2014-02-19  Brady Eidson  <beidson@apple.com>
2298
2299         Add FeatureDefines for image controls
2300         https://bugs.webkit.org/show_bug.cgi?id=129022
2301
2302         Reviewed by Jer Noble.
2303
2304         * Configurations/FeatureDefines.xcconfig:
2305
2306 2014-02-18  Sam Weinig  <sam@webkit.org>
2307
2308         Simplify HTML tokenizer parameterization down to what is used
2309         https://bugs.webkit.org/show_bug.cgi?id=128977
2310
2311         Reviewed by Alexey Proskuryakov.
2312
2313         Remove unused _setCustomHTMLTokenizerTimeDelay and _setCustomHTMLTokenizerChunkSize SPI.
2314
2315         * WebView/WebView.mm:
2316         * WebView/WebViewPrivate.h:
2317
2318 2014-02-17  Anders Carlsson  <andersca@apple.com>
2319
2320         Remove view source code
2321         https://bugs.webkit.org/show_bug.cgi?id=127233
2322
2323         Reviewed by Antti Koivisto.
2324
2325         * WebView/WebView.mm:
2326         * WebView/WebViewPrivate.h:
2327
2328 2014-02-17  Sergio Correia  <sergio.correia@openbossa.org>
2329
2330         Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
2331         https://bugs.webkit.org/show_bug.cgi?id=128681
2332
2333         Reviewed by Timothy Hatcher.
2334
2335         Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
2336         WebCore/inspector/*. Besides files in there, a few other files in
2337         JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
2338         and WebCore/testing were touched.
2339
2340         * WebCoreSupport/WebInspectorClient.h:
2341         * WebCoreSupport/WebInspectorClient.mm:
2342
2343 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
2344
2345         [Mac] Remove WebSerializedJSValue SPI
2346         https://bugs.webkit.org/show_bug.cgi?id=128720
2347
2348         Reviewed by Anders Carlsson.
2349
2350         * WebKit.exp:
2351         * WebView/WebSerializedJSValue.h: Removed.
2352         * WebView/WebSerializedJSValue.mm: Removed.
2353         * WebView/WebSerializedJSValuePrivate.h: Removed.
2354
2355 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
2356
2357         [Mac] All WebKit clients should encrypt WebCrypto keys automatically
2358         https://bugs.webkit.org/show_bug.cgi?id=128852
2359
2360         Reviewed by Oliver Hunt.
2361
2362         * WebCoreSupport/WebChromeClient.mm:
2363         (WebChromeClient::wrapCryptoKey):
2364         (WebChromeClient::unwrapCryptoKey):
2365         Call the default implementation if key is not provided by a client.
2366
2367 2014-02-14  Anders Carlsson  <andersca@apple.com>
2368
2369         Control tints don't update inside WebViews
2370         https://bugs.webkit.org/show_bug.cgi?id=128862
2371
2372         Reviewed by Ryosuke Niwa.
2373
2374         * WebView/WebView.mm:
2375         (-[WebView _windowChangedKeyState]):
2376         Call [super _windowChangedKeyState].
2377
2378 2014-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
2379
2380         During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
2381         https://bugs.webkit.org/show_bug.cgi?id=128688
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
2386
2387         * WebView/WebPreferenceKeysPrivate.h:
2388         * WebView/WebPreferences.mm:
2389         (-[WebPreferences shouldConvertPositionStyleOnCopy]):
2390         (-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
2391         * WebView/WebPreferencesPrivate.h:
2392         * WebView/WebView.mm:
2393         (-[WebView _preferencesChanged:]):
2394
2395 2014-02-13  Alexey Proskuryakov  <ap@apple.com>
2396
2397         [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
2398         https://bugs.webkit.org/show_bug.cgi?id=128725
2399
2400         Reviewed by Anders Carlsson.
2401
2402         * WebCoreSupport/WebChromeClient.mm:
2403         (WebChromeClient::wrapCryptoKey):
2404         (WebChromeClient::unwrapCryptoKey):
2405         * WebView/WebUIDelegatePrivate.h:
2406         Looks like UIDelegate is the closest we have to a reasonable place.
2407
2408 2014-02-13  Dan Bernstein  <mitz@apple.com>
2409
2410         iOS build fix.
2411
2412         * WebView/WebView.mm:
2413         (+[WebView registerForMemoryNotifications]):
2414
2415 2014-02-12  Alexey Proskuryakov  <ap@apple.com>
2416
2417         Wrap WebCrypto keys in SerializedScriptValue
2418         https://bugs.webkit.org/show_bug.cgi?id=128680
2419
2420         Reviewed by Anders Carlsson.
2421
2422         Retrieve a master key (placeholder code for now), and use it to wrap key data.
2423
2424         * WebCoreSupport/WebChromeClient.mm:
2425         (WebChromeClient::wrapCryptoKey):
2426         (WebChromeClient::unwrapCryptoKey):
2427
2428 2014-02-11  Ryosuke Niwa  <rniwa@webkit.org>
2429
2430         Frame::rectForSelection shouldn't instantiate FrameSelection
2431         https://bugs.webkit.org/show_bug.cgi?id=128587
2432
2433         Reviewed by Enrica Casucci.
2434
2435         * WebCoreSupport/WebEditorClient.h:
2436         * WebCoreSupport/WebEditorClient.mm:
2437         (WebEditorClient::WebEditorClient):
2438         (WebEditorClient::respondToChangedSelection):
2439
2440 2014-02-10  Myles C. Maxfield  <mmaxfield@apple.com>
2441
2442         Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
2443         https://bugs.webkit.org/show_bug.cgi?id=128194
2444
2445         Reviewed by Simon Fraser.
2446
2447         * WebView/WebPreferenceKeysPrivate.h:
2448         * WebView/WebPreferences.mm:
2449         (-[WebPreferences convertPositionStyleOnCopy]):
2450         (-[WebPreferences setConvertPositionStyleOnCopy:]):
2451         * WebView/WebPreferencesPrivate.h: Opt-in to new behavior
2452         * WebView/WebView.mm:
2453         (-[WebView _preferencesChanged:]):
2454
2455 2014-02-11  Andy Estes  <aestes@apple.com>
2456
2457         [Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
2458         https://bugs.webkit.org/show_bug.cgi?id=128583
2459
2460         Reviewed by Anders Carlsson.
2461
2462         The delegate method was removed in Snow Leopard.
2463
2464         * Misc/WebDownload.mm:
2465
2466 2014-02-11  Alexey Proskuryakov  <ap@apple.com>
2467
2468         iOS build fix.
2469
2470         * WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.
2471
2472 2014-02-10  Alexey Proskuryakov  <ap@apple.com>
2473
2474         Add hooks for wrapping CryptoKeys in SerializedScriptValue
2475         https://bugs.webkit.org/show_bug.cgi?id=128567
2476
2477         Reviewed by Anders Carlsson.
2478
2479         * WebCoreSupport/WebChromeClient.h:
2480         * WebCoreSupport/WebChromeClient.mm:
2481         (WebChromeClient::wrapCryptoKey):
2482         (WebChromeClient::unwrapCryptoKey):
2483         Dummy implementation, to be filled in later.
2484
2485 2014-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2486
2487         Cleanup the interface of FrameSelection
2488         https://bugs.webkit.org/show_bug.cgi?id=128481
2489
2490         Reviewed by Andreas Kling.
2491
2492         * WebView/WebHTMLView.mm:
2493         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2494         (-[WebHTMLView selectionRect]):
2495         (-[WebHTMLView selectionImageRect]):
2496
2497 2014-02-08  Dan Bernstein  <mitz@apple.com>
2498
2499         Remove use of PLATFORM(MAC) from WebKit/mac
2500         https://bugs.webkit.org/show_bug.cgi?id=128476
2501
2502         Reviewed by Anders Carlsson.
2503
2504         * WebCoreSupport/WebFrameLoaderClient.h:
2505         * WebCoreSupport/WebSystemInterface.mm:
2506         (InitWebCoreSystemInterface):
2507
2508 2014-02-08  Dan Bernstein  <mitz@apple.com>
2509
2510         Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
2511         https://bugs.webkit.org/show_bug.cgi?id=128456
2512
2513         Reviewed by Anders Carlsson.
2514
2515         * WebCoreSupport/WebChromeClient.h:
2516         * WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
2517         * WebView/WebHTMLView.mm:
2518         (-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
2519         (-[WebHTMLViewPrivate clear]): Ditto.
2520         * WebView/WebHTMLViewInternal.h: Removed declaration.
2521         * WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.
2522
2523 2014-02-08  Dan Bernstein  <mitz@apple.com>
2524
2525         iOS build fix after r163712.
2526
2527         * WebCoreSupport/WebEditorClient.h:
2528         * WebCoreSupport/WebEditorClient.mm:
2529
2530 2014-02-08  Darin Adler  <darin@apple.com>
2531
2532         Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
2533         https://bugs.webkit.org/show_bug.cgi?id=128233
2534
2535         Reviewed by Anders Carlsson.
2536
2537         * WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines
2538         for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
2539         Changed interfaces to use StringView.
2540
2541         * WebCoreSupport/WebEditorClient.mm:
2542         (WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
2543         function instead of a similar function that was local in this file.
2544         (WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
2545         (WebEditorClient::checkSpellingOfString): Changed to take a StringView.
2546         (WebEditorClient::checkGrammarOfString): Ditto.
2547
2548         * WebView/WebTextIterator.mm:
2549         (-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
2550         (-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
2551         instead of with TextIterator::characters/length.
2552
2553 2014-02-07  Gavin Barraclough  <barraclough@apple.com>
2554
2555         Remove isInitialState flag from Page::setViewState
2556         https://bugs.webkit.org/show_bug.cgi?id=128428
2557
2558         Reviewed by Sam Weinig.
2559
2560         * WebView/WebView.mm:
2561         (-[WebView _commonInitializationWithFrameName:groupName:]):
2562         (-[WebView _updateVisibilityState]):
2563         (-[WebView _setIsVisible:]):
2564         (-[WebView _setVisibilityState:isInitialState:]):
2565         (-[WebView _windowWillOrderOnScreen:]):
2566         (-[WebView _windowWillOrderOffScreen:]):
2567             - don't pass isInitialState to setViewState.
2568
2569 2014-02-06  Filip Pizlo  <fpizlo@apple.com>
2570
2571         More FTL build scaffolding
2572         https://bugs.webkit.org/show_bug.cgi?id=128330
2573
2574         Reviewed by Geoffrey Garen.
2575
2576         * Configurations/FeatureDefines.xcconfig:
2577
2578 2014-02-07  Dan Bernstein  <mitz@apple.com>
2579
2580         iOS build fix.
2581
2582         * Misc/WebElementDictionary.mm:
2583         (+[WebElementDictionary initializeLookupTable]):
2584         (-[WebElementDictionary _image]):
2585         (-[WebElementDictionary _imageRect]):
2586
2587 2014-02-06  Joseph Pecoraro  <pecoraro@apple.com>
2588
2589         Web Inspector: Add Console support to JSContext Inspection
2590         https://bugs.webkit.org/show_bug.cgi?id=127941
2591
2592         Reviewed by Geoffrey Garen.
2593
2594         * WebCoreSupport/WebChromeClient.h:
2595         * WebCoreSupport/WebChromeClient.mm:
2596         (stringForMessageSource):
2597         (stringForMessageLevel):
2598         (WebChromeClient::addMessageToConsole):
2599
2600 2014-02-05  Gavin Barraclough  <barraclough@apple.com>
2601
2602         Change Page, FocusController to use ViewState
2603         https://bugs.webkit.org/show_bug.cgi?id=126533
2604
2605         Reviewed by Tim Horton.
2606
2607         These classes currently maintain a set of separate fields to represent the view state;
2608         combine these into a single field, and allow WebPage to send the combined update rather
2609         than individual changes.
2610
2611         Maintain existing interface for WebKit1 clients.
2612
2613         * WebView/WebView.mm:
2614         (-[WebView _windowWillOrderOnScreen:]):
2615         (-[WebView _windowWillOrderOffScreen:]):
2616             - remove calls to FocusController::setContentIsVisible, these are redundant
2617               (this is handled when page visibility is set).
2618
2619 2014-02-05  Andreas Kling  <akling@apple.com>
2620
2621         Remove ENABLE(DIRECTORY_UPLOAD).
2622         <https://webkit.org/b/128275>
2623
2624         Rubber-stamped by Ryosuke Niwa.
2625
2626         * Configurations/FeatureDefines.xcconfig:
2627
2628 2014-02-05  Csaba Osztrogonác  <ossy@webkit.org>
2629
2630         Remove ENABLE(SVG) guards
2631         https://bugs.webkit.org/show_bug.cgi?id=127991
2632
2633         Reviewed by Sam Weinig.
2634
2635         * Configurations/FeatureDefines.xcconfig:
2636
2637 2014-02-04  Andreas Kling  <akling@apple.com>
2638
2639         Remove <iframe seamless> support.
2640         <https://webkit.org/b/128213>
2641
2642         Rubber-stamped by Antti Koivisto.
2643
2644         * Configurations/FeatureDefines.xcconfig:
2645         * WebView/WebPreferenceKeysPrivate.h:
2646         * WebView/WebPreferences.mm:
2647         * WebView/WebPreferencesPrivate.h:
2648         * WebView/WebView.mm:
2649         (-[WebView _preferencesChanged:]):
2650
2651 2014-02-03  Dean Jackson  <dino@apple.com>
2652
2653         Feature flag for shape-inside
2654         https://bugs.webkit.org/show_bug.cgi?id=128001
2655
2656         Reviewed by Simon Fraser.
2657
2658         Add CSS_SHAPE_INSIDE flag.
2659
2660         * Configurations/FeatureDefines.xcconfig:
2661
2662 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
2663
2664         Remove inline member functions of FrameSelection that access m_selection
2665         https://bugs.webkit.org/show_bug.cgi?id=127986
2666
2667         Reviewed by Enrica Casucci.
2668
2669         * WebView/WebFrame.mm:
2670         (-[WebFrame hasEditableSelection]):
2671         (-[WebFrame selectionAffinity]):
2672         (-[WebFrame getDictationResultRanges:andMetadatas:]):
2673         (-[WebFrame hasRichlyEditableSelection]):
2674         (-[WebFrame focusedNodeHasContent]):
2675         * WebView/WebHTMLView.mm:
2676         (-[WebHTMLView readSelectionFromPasteboard:]):
2677         (-[WebHTMLView _hasSelection]):
2678         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
2679         (-[WebHTMLView _hasInsertionPoint]):
2680         (-[WebHTMLView _isEditable]):
2681         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2682         (-[WebHTMLView maintainsInactiveSelection]):
2683         (isTextInput):
2684         (isInPasswordField):
2685         * WebView/WebView.mm:
2686         (-[WebView selectionAffinity]):
2687
2688 2014-01-31  Tim Horton  <timothy_horton@apple.com>
2689
2690         [wk2] PlatformCALayerRemoteCustom doesn't work on iOS
2691         https://bugs.webkit.org/show_bug.cgi?id=128025
2692         <rdar://problem/15950271>
2693
2694         Reviewed by Simon Fraser.
2695
2696         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2697         (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
2698         Use the new macro name.
2699
2700 2014-01-30  David Kilzer  <ddkilzer@apple.com>
2701
2702         Add security-checked cast for WebCore::CachedImage
2703         <http://webkit.org/b/127967>
2704
2705         Reviewed by Darin Adler.
2706
2707         * Misc/WebCache.mm:
2708         (+[WebCache imageForURL:]):
2709         - Use WebCore::toCachedImage().
2710
2711 2014-01-30  David Kilzer  <ddkilzer@apple.com>
2712
2713         De-virtual-ize CachedResource::isImage()
2714         <http://webkit.org/b/127936>
2715
2716         Reviewed by Andreas Kling.
2717
2718         Also replace explicit type() checks with isImage().
2719
2720         * Misc/WebCache.mm:
2721         (+[WebCache imageForURL:]): Use !isImage().
2722
2723 2014-01-30  Beth Dakin  <bdakin@apple.com>
2724
2725         https://bugs.webkit.org/show_bug.cgi?id=127371
2726         Explore new API that could be used to help build infinitely scrolling websites
2727         -and corresponding-
2728         <rdar://problem/15244768>
2729
2730         Reviewed by Sam Weinig.
2731
2732         FrameView::scrollPositionChangedViaPlatformWidget() now take two parameters 
2733         representing the old scroll position and the new position.
2734         * WebView/WebHTMLView.mm:
2735         (-[WebHTMLView _frameOrBoundsChanged]):
2736
2737 2014-01-30  Andrei Bucur  <abucur@adobe.com>
2738
2739         Remove the ACCELERATED_COMPOSITING flag
2740         https://bugs.webkit.org/show_bug.cgi?id=127833
2741
2742         Reviewed by Antti Koivisto.
2743
2744         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
2745         mandatory.
2746
2747         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2748         (-[WebHostedNetscapePluginView createPlugin]):
2749         (-[WebHostedNetscapePluginView createPluginLayer]):
2750         * Plugins/WebNetscapePluginView.mm:
2751         (-[WebNetscapePluginView createPlugin]):
2752         (-[WebNetscapePluginView getVariable:value:]):
2753         * Plugins/WebPluginController.mm:
2754         (-[WebPluginController superlayerForPluginView:]):
2755         * WebCoreSupport/WebChromeClient.h:
2756         (WebChromeClient::allowedCompositingTriggers):
2757         * WebCoreSupport/WebChromeClient.mm:
2758         * WebCoreSupport/WebFrameLoaderClient.mm:
2759         (PluginWidgetIOS::detachPluginLayer):
2760         (NetscapePluginWidget::platformLayer):
2761         * WebView/WebClipView.mm:
2762         (-[WebClipView _immediateScrollToPoint:]):
2763         * WebView/WebHTMLView.mm:
2764         (setNeedsDisplayInRect):
2765         (+[WebHTMLViewPrivate initialize]):
2766         (-[WebHTMLViewPrivate clear]):
2767         (-[WebHTMLView _setAsideSubviews]):
2768         (-[WebHTMLView hitTest:]):
2769         (-[WebHTMLView _isUsingAcceleratedCompositing]):
2770         (-[WebHTMLView _compositingLayersHostingView]):
2771         (-[WebHTMLView viewDidMoveToSuperview]):
2772         (-[WebHTMLView drawRect:]):
2773         * WebView/WebHTMLViewInternal.h:
2774         * WebView/WebRenderLayer.mm:
2775         (+[WebRenderLayer compositingInfoForLayer:]):
2776         * WebView/WebView.mm:
2777         (-[WebView _close]):
2778         (-[WebView _setMediaLayer:forPluginView:]):
2779         (-[WebView _postsAcceleratedCompositingNotifications]):
2780         (-[WebView _setPostsAcceleratedCompositingNotifications:]):
2781         (-[WebView _isUsingAcceleratedCompositing]):
2782         (-[WebView _isSoftwareRenderable]):
2783         (-[WebView close]):
2784         * WebView/WebViewData.h:
2785         * WebView/WebViewData.mm:
2786         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2787         * WebView/WebViewInternal.h:
2788
2789 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2790
2791         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
2792         https://bugs.webkit.org/show_bug.cgi?id=127845
2793
2794         Reviewed by Joseph Pecoraro.
2795
2796         * Configurations/FeatureDefines.xcconfig:
2797
2798 2014-01-29  Dan Bernstein  <mitz@apple.com>
2799
2800         Moved linking against common frameworks and a library from the .xcconfig file into the target.
2801
2802         Reviewed by Tim Horton.
2803
2804         * Configurations/WebKit.xcconfig:
2805
2806 2014-01-29  Ryosuke Niwa  <rniwa@webkit.org>
2807
2808         checkTextOfParagraph releases NSString twice
2809         https://bugs.webkit.org/show_bug.cgi?id=127881
2810         <rdar://problem/15937446>
2811
2812         Reviewed by Anders Carlsson.
2813
2814         textString is released once by an explicit call to release and again by it going out of scope.
2815         Don't do the explicit release.
2816
2817         The bug was spotted by Sam Weinig.
2818
2819         * WebCoreSupport/WebEditorClient.mm:
2820         (WebEditorClient::checkTextOfParagraph):
2821
2822 2014-01-29  Anders Carlsson  <andersca@apple.com>
2823
2824         Fix build.
2825
2826         * WebView/WebPDFView.mm:
2827         (_applicationInfoForMIMEType):
2828
2829 2014-01-28  Mark Rowe  <mrowe@apple.com>
2830
2831         <https://webkit.org/b/127767> Disable some deprecation warnings to fix the build.
2832
2833         Reviewed by Ryosuke Niwa.
2834
2835         * WebCoreSupport/PopupMenuMac.mm:
2836         (PopupMenuMac::populate):
2837
2838 2014-01-27  Joseph Pecoraro  <pecoraro@apple.com>
2839
2840         WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
2841         https://bugs.webkit.org/show_bug.cgi?id=127664
2842
2843         Reviewed by Darin Adler.
2844
2845         * Configurations/Base.xcconfig:
2846         * History/BinaryPropertyList.cpp:
2847         (BinaryPropertyListSerializer::appendObjectReference):
2848         (BinaryPropertyListSerializer::startObject):
2849         (BinaryPropertyListSerializer::addAggregateObjectReference):
2850         * WebView/WebPDFView.mm:
2851         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2852
2853 2014-01-27  Andy Estes  <aestes@apple.com>
2854
2855         Scrub WebKit API headers of WTF macros
2856         https://bugs.webkit.org/show_bug.cgi?id=127706
2857
2858         Reviewed by David Kilzer.
2859
2860         * Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
2861         * WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
2862         to !defined(ENABLE_REMOTE_INSPECTOR) || ENABLE_REMOTE_INSPECTOR. We are
2863         in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
2864         default on iOS, so include this block unless the feature is explicitly
2865         disabled.
2866         * postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS
2867         and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.
2868
2869 2014-01-27  Tim Horton  <timothy_horton@apple.com>
2870
2871         Another iOS build fix.
2872
2873         * Misc/WebElementDictionary.mm:
2874         (-[WebElementDictionary _image]):
2875         We were apparently depending on Image::getNSImage() being defined
2876         (yet always returning nullptr) on iOS.
2877
2878 2014-01-26  David Kilzer  <ddkilzer@apple.com>
2879
2880         Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
2881         <http://webkit.org/b/127669>
2882
2883         Reviewed by Joseph Pecoraro.
2884
2885         * WebView/WebPreferences.mm:
2886         (+[WebPreferences initialize]): Remove duplicate code.
2887
2888 2014-01-24  Andy Estes  <aestes@apple.com>
2889
2890         [iOS] Upstream changes in Tools/DumpRenderTree
2891         https://bugs.webkit.org/show_bug.cgi?id=127412
2892
2893         Reviewed by Simon Fraser.
2894
2895         * Misc/WebCoreStatistics.h: Included CGContext.h.
2896
2897 2014-01-26  Anders Carlsson  <andersca@apple.com>
2898
2899         Move history item visit count handling to WebKit
2900         https://bugs.webkit.org/show_bug.cgi?id=127659
2901
2902         Reviewed by Dan Bernstein.
2903
2904         Move code to deal with visit count and visit dates here from WebCore.
2905
2906         * History/HistoryPropertyList.mm:
2907         (HistoryPropertyListWriter::writeHistoryItem):
2908         * History/WebHistoryItem.mm:
2909         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
2910         (-[WebHistoryItem copyWithZone:]):
2911         (-[WebHistoryItem lastVisitedTimeInterval]):
2912         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
2913         (-[WebHistoryItem setVisitCount:]):
2914         (-[WebHistoryItem _mergeAutoCompleteHints:]):
2915         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2916         (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
2917         (-[WebHistoryItem _recordInitialVisit]):
2918         (timeToDay):
2919         (-[WebHistoryItem _padDailyCountsForNewVisit:]):
2920         (-[WebHistoryItem _collapseDailyVisitsToWeekly]):
2921         (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
2922         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
2923         * History/WebHistoryItemInternal.h:
2924
2925 2014-01-26  Anders Carlsson  <andersca@apple.com>
2926
2927         Fix build.
2928
2929         Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.
2930
2931         * History/HistoryPropertyList.h:
2932         * History/HistoryPropertyList.mm:
2933         (HistoryPropertyListWriter::HistoryPropertyListWriter):
2934         (HistoryPropertyListWriter::buffer):
2935         (HistoryPropertyListWriter::releaseData):
2936         (HistoryPropertyListWriter::writeObjects):
2937         (HistoryPropertyListWriter::writeHistoryItem):
2938         * History/WebHistory.mm:
2939         (WebHistoryWriter::writeHistoryItems):
2940         * History/WebHistoryItem.mm:
2941
2942 2014-01-26  Anders Carlsson  <andersca@apple.com>
2943
2944         Move lastVisitWasHTTPNonGet out to WebHistoryItem
2945         https://bugs.webkit.org/show_bug.cgi?id=127657
2946
2947         Reviewed by Dan Bernstein.
2948
2949         Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
2950
2951         * History/WebHistory.mm:
2952         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
2953         Set entry->_private->_lastVisitWasHTTPNonGet.
2954
2955         * History/WebHistoryItem.h:
2956         Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
2957
2958         * History/WebHistoryItem.mm:
2959         (-[WebHistoryItem copyWithZone:]):
2960         Assign _private->_lastVisitWasHTTPNonGet.
2961
2962         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2963         Set _private->_lastVisitWasHTTPNonGet.
2964
2965         * History/WebHistoryItemInternal.h:
2966         Move WebHistoryItemPrivate interface here.
2967
2968 2014-01-26  Anders Carlsson  <andersca@apple.com>
2969
2970         Turn WebHistoryItemPrivate back into a real Objective-C class
2971         https://bugs.webkit.org/show_bug.cgi?id=127653
2972
2973         Reviewed by Sam Weinig.
2974
2975         This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.
2976
2977         * History/WebHistoryItem.mm:
2978         (-[WebHistoryItem dealloc]):
2979         (-[WebHistoryItem finalize]):
2980         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
2981
2982 2014-01-25  Sam Weinig  <sam@webkit.org>
2983
2984         Remove unused support for DRAGGABLE_REGION
2985         https://bugs.webkit.org/show_bug.cgi?id=127642
2986
2987         Reviewed by Simon Fraser.
2988
2989         * Configurations/FeatureDefines.xcconfig:
2990
2991 2014-01-25  Anders Carlsson  <andersca@apple.com>
2992
2993         Remove an unused FrameLoaderClient function
2994         https://bugs.webkit.org/show_bug.cgi?id=127628
2995
2996         Reviewed by Andreas Kling.
2997
2998         * WebCoreSupport/WebFrameLoaderClient.h:
2999         * WebCoreSupport/WebFrameLoaderClient.mm:
3000
3001 2014-01-25  Anders Carlsson  <andersca@apple.com>
3002
3003         Build fix.
3004
3005         * WebView/WebViewData.h:
3006
3007 2014-01-25  Anders Carlsson  <andersca@apple.com>
3008
3009         Get rid of BackForwardController::isActive()
3010         https://bugs.webkit.org/show_bug.cgi?id=127604
3011
3012         Reviewed by Sam Weinig.
3013
3014         * WebCoreSupport/WebFrameLoaderClient.mm:
3015         (WebFrameLoaderClient::canCachePage):
3016         Move isActive logic here.
3017
3018 2014-01-24  Anders Carlsson  <andersca@apple.com>
3019
3020         Remove back/forward list related functions from Page
3021         https://bugs.webkit.org/show_bug.cgi?id=127596
3022
3023         Reviewed by Andreas Kling.
3024
3025         * WebView/WebFrameView.mm:
3026         (-[WebFrameView keyDown:keyDown:]):
3027         * WebView/WebView.mm:
3028         (-[WebView _loadBackForwardListFromOtherView:]):
3029         (-[WebView initWithCoder:]):
3030         (-[WebView encodeWithCoder:]):
3031         (-[WebView backForwardList]):
3032         (-[WebView setMaintainsBackForwardList:]):
3033         (-[WebView goBack]):
3034         (-[WebView goForward]):
3035         (-[WebView canGoBack]):
3036         (-[WebView canGoForward]):
3037
3038 2014-01-24  Anders Carlsson  <andersca@apple.com>
3039
3040         Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead
3041         https://bugs.webkit.org/show_bug.cgi?id=127571
3042
3043         Reviewed by Antti Koivisto.
3044
3045         * WebView/WebView.mm:
3046         (-[WebView _preferencesChanged:]):
3047         Convert the layout interval to std::chrono::milliseconds.
3048
3049 2014-01-24  Zan Dobersek  <zdobersek@igalia.com>
3050
3051         Move HistoryItem to std::unique_ptr
3052         https://bugs.webkit.org/show_bug.cgi?id=127275
3053
3054         Reviewed by Darin Adler.
3055
3056         * History/WebHistoryItem.mm: The Vector object that's passed to HistoryItem::setRedirectURLs
3057         should now be handled by std::unique_ptr and passed on through move semantics.
3058         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3059
3060 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
3061
3062         Move RegularExpression into JavaScriptCore for inspector
3063         https://bugs.webkit.org/show_bug.cgi?id=127526
3064
3065         Reviewed by Geoffrey Garen.
3066
3067         * WebView/WebHTMLRepresentation.mm:
3068
3069 2014-01-23  Benjamin Poulain  <bpoulain@apple.com>
3070
3071         Remote Inspector uses the Page pointer before the page is created on iOS
3072         https://bugs.webkit.org/show_bug.cgi?id=127534
3073
3074         Reviewed by Joseph Pecoraro.
3075
3076         * WebView/WebView.mm:
3077         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3078
3079 2014-01-23  Jon Honeycutt  <jhoneycutt@apple.com>
3080
3081         Assertion failure in WebCore::PseudoElement::didRecalcStyle()
3082         <https://bugs.webkit.org/show_bug.cgi?id=126761>
3083         <rdar://problem/15793540>
3084
3085         Some areas of code were erroneously checking the value of
3086         RenderObject::isImage() rather than RenderObject::isRenderImage()
3087         before casting the object to RenderImage.
3088
3089         This could lead to an assertion failure for RenderListMarkers, which
3090         may return true for isImage(), but are not RenderImages.
3091
3092         Reviewed by Andy Estes.
3093
3094         * Misc/WebNSPasteboardExtras.mm:
3095         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3096         Check isRenderImage() rather than isImage() before casting to
3097         RenderImage.
3098
3099 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
3100
3101         Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
3102         https://bugs.webkit.org/show_bug.cgi?id=127409
3103
3104         Reviewed by Geoffrey Garen.
3105
3106         * WebCoreSupport/WebInspectorClient.mm:
3107         (-[WebInspectorWindowController destroyInspectorView:]):
3108         Include InspectorDisconnectReason.
3109
3110 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
3111
3112         Remove CSS Custom Filters code and tests
3113         https://bugs.webkit.org/show_bug.cgi?id=127382
3114
3115         Reviewed by Simon Fraser.
3116
3117         * Configurations/FeatureDefines.xcconfig:
3118         * WebView/WebPreferenceKeysPrivate.h:
3119         * WebView/WebPreferences.mm:
3120         (+[WebPreferences initialize]):
3121         * WebView/WebPreferencesPrivate.h:
3122         * WebView/WebView.mm:
3123         (-[WebView _preferencesChanged:]):
3124
3125 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
3126
3127         Remove CSS3_TEXT_DECORATION define
3128         https://bugs.webkit.org/show_bug.cgi?id=127333
3129
3130         Reviewed by Simon Fraser.
3131
3132         This is required for unprefixing the text-decoration-* CSS properties.
3133
3134         * Configurations/FeatureDefines.xcconfig:
3135
3136 2014-01-22  Dan Bernstein  <mitz@apple.com>
3137
3138         Build fix for iOS clients of WebUIDelegatePrivate.h.
3139
3140         * WebView/WebUIDelegatePrivate.h: Ensure that ENABLE_DASHBOARD_SUPPORT is defined on iOS.
3141
3142 2014-01-21  Dan Bernstein  <mitz@apple.com>
3143
3144         Added a method declaration that was missed in r161185.
3145
3146         Reviewed by Sam Weinig.
3147
3148         * WebView/WebViewPrivate.h: Declared -removeVisitedLink:.
3149
3150 2014-01-21  Commit Queue  <commit-queue@webkit.org>
3151
3152         Unreviewed, rolling out r162452.
3153         http://trac.webkit.org/changeset/162452
3154         https://bugs.webkit.org/show_bug.cgi?id=127366
3155
3156         broke a few tests on all Mac WebKit1 bots (Requested by
3157         thorton on #webkit).
3158
3159         * WebView/WebView.mm:
3160         (-[WebView _windowWillOrderOnScreen:]):
3161         (-[WebView _windowWillOrderOffScreen:]):
3162
3163 2014-01-21  Gavin Barraclough  <barraclough@apple.com>
3164
3165         Change Page, FocusController to use ViewState
3166         https://bugs.webkit.org/show_bug.cgi?id=126533
3167
3168         Reviewed by Tim Horton.
3169
3170         These classes currently maintain a set of separate fields to represent the view state;
3171         combine these into a single field, and allow WebPage to send the combined update rather
3172         than individual changes.
3173
3174         Maintain existing interface for WebKit1 clients.
3175
3176         * WebView/WebView.mm:
3177         (-[WebView _windowWillOrderOnScreen:]):
3178         (-[WebView _windowWillOrderOffScreen:]):
3179             - remove calls to FocusController::setContentIsVisible, these are redundant
3180               (this is handled when page visibility is set).
3181
3182 2014-01-20  Jeremy Jones  <jeremyj@apple.com>
3183
3184         Add AVKit fullscreen video interface.
3185         https://bugs.webkit.org/show_bug.cgi?id=126818
3186
3187         Reviewed by Eric Carlson.
3188
3189         * WebCoreSupport/WebChromeClient.h:
3190         * WebCoreSupport/WebChromeClient.mm:
3191         (WebChromeClient::supportsFullscreenForNode):
3192         Enable *FullscreenForNode for HTMLMediaElement for iOS
3193
3194         * WebView/WebPreferenceKeysPrivate.h:
3195         * WebView/WebPreferences.mm:
3196         (+[WebPreferences initialize]):
3197         (-[WebPreferences mediaPlaybackFullscreenAVKit]):
3198         (-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
3199         * WebView/WebPreferencesPrivate.h:
3200         * WebView/WebView.mm:
3201         (-[WebView _preferencesChanged:]):
3202         (-[WebView _enterFullscreenForNode:WebCore::]):
3203         * WebView/WebViewInternal.h:
3204         Add a disabled pref mediaPlaybackFullscreenAVKit.
3205         Use WebVideoFullscreenControllerAVKit on iOS
3206
3207 2014-01-18  Brian Burg  <bburg@apple.com>
3208
3209         Web Inspector: Page should use std::unique_ptr for InspectorController
3210         https://bugs.webkit.org/show_bug.cgi?id=127068
3211
3212         Reviewed by Joseph Pecoraro.
3213
3214         Convert call sites to use a InspectorController reference.
3215         Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
3216
3217         * WebCoreSupport/WebInspectorClient.mm:
3218         (WebInspectorClient::openInspectorFrontend):
3219         (-[WebInspectorWindowController destroyInspectorView:]):
3220         * WebInspector/WebInspector.mm:
3221         (-[WebInspector showWindow]):
3222         (-[WebInspector isJavaScriptProfilingEnabled]):
3223         (-[WebInspector setJavaScriptProfilingEnabled:]):
3224         (-[WebInspector close:]):
3225         (-[WebInspector evaluateInFrontend:callId:script:]):
3226         * WebInspector/WebNodeHighlighter.mm:
3227         (-[WebNodeHighlighter highlight]):
3228
3229 2014-01-18  Anders Carlsson  <andersca@apple.com>
3230
3231         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
3232         https://bugs.webkit.org/show_bug.cgi?id=127225
3233
3234         Reviewed by Andreas Kling.
3235
3236         This concludes the removal of over 8.8 million lines of threaded parser code.
3237
3238         * Configurations/FeatureDefines.xcconfig:
3239
3240 2014-01-17  Anders Carlsson  <andersca@apple.com>
3241
3242         Clean up PageCache classes
3243         https://bugs.webkit.org/show_bug.cgi?id=127202
3244
3245         Reviewed by Andreas Kling.
3246
3247         * WebCoreSupport/WebFrameLoaderClient.mm:
3248         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
3249         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
3250
3251 2014-01-17  Anders Carlsson  <andersca@apple.com>
3252
3253         Remove another unused FrameLoaderClient callback
3254         https://bugs.webkit.org/show_bug.cgi?id=127192
3255
3256         Reviewed by Dan Bernstein.
3257
3258         * WebCoreSupport/WebFrameLoaderClient.h:
3259         * WebCoreSupport/WebFrameLoaderClient.mm:
3260
3261 2014-01-17  Anders Carlsson  <andersca@apple.com>
3262
3263         Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
3264         https://bugs.webkit.org/show_bug.cgi?id=127189
3265
3266         Reviewed by Dan Bernstein.
3267
3268         This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.
3269         
3270         * WebCoreSupport/WebFrameLoaderClient.h:
3271         * WebCoreSupport/WebFrameLoaderClient.mm:
3272         Remove didPerformFirstNavigation() implementation.
3273
3274         * WebView/WebView.mm:
3275         (-[WebView _checkDidPerformFirstNavigation]):
3276         Check if we have both a current item and a previous item which indicates that we've navigated once.
3277         The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
3278         we have to check that there's a current item as well.
3279
3280         (-[WebView _didCommitLoadForFrame:]):
3281         Call _didCommitLoadForFrame.
3282
3283         * WebView/WebViewData.h:
3284         Add new ivar.
3285
3286 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
3287
3288         More iOS build fix.
3289
3290         * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
3291         NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.
3292
3293 2014-01-16  Daniel Bates  <dabates@apple.com>
3294
3295         [iOS] MobileSafari build fix. Declare iOS-specific method mainFrameIconURL
3296
3297         For now, add mainFrameIconURL() to WebView.h. We should further investigate its
3298         usage and API/SPI status.
3299
3300         * WebView/WebView.h:
3301
3302 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
3303
3304         [Mac] [iOS] Add support for CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain
3305         https://bugs.webkit.org/show_bug.cgi?id=127139
3306
3307         Reviewed by Brady Eidson.
3308
3309         * WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):
3310         Handle the new case.
3311
3312 2014-01-16  Daniel Bates  <dabates@apple.com>
3313
3314         [iOS] Fix UIKit build warning about undefined macro ENABLE_NETSCAPE_PLUGIN_API
3315
3316         * WebView/WebFramePrivate.h: Wrap use of ENABLE_NETSCAPE_PLUGIN_API in TARGET_OS_IPHONE.
3317
3318 2014-01-16  Anders Carlsson  <andersca@apple.com>
3319
3320         Change all uses of FINAL to final now that all our compilers support it
3321         https://bugs.webkit.org/show_bug.cgi?id=127142
3322
3323         Reviewed by Benjamin Poulain.
3324
3325         * WebCoreSupport/WebUserMediaClient.h:
3326         * WebView/WebScriptDebugger.h:
3327
3328 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3329
3330         Remove workaround for compilers not supporting explicit override control
3331         https://bugs.webkit.org/show_bug.cgi?id=127111
3332
3333         Reviewed by Anders Carlsson.
3334
3335         Now all compilers support explicit override control, this workaround can be removed.
3336
3337         * Storage/WebDatabaseManagerClient.h:
3338         * Storage/WebStorageTrackerClient.h:
3339         * WebCoreSupport/WebAlternativeTextClient.h:
3340         * WebCoreSupport/WebChromeClient.h:
3341         * WebCoreSupport/WebContextMenuClient.h:
3342         * WebCoreSupport/WebDeviceOrientationClient.h:
3343         * WebCoreSupport/WebDragClient.h:
3344         * WebCoreSupport/WebEditorClient.h:
3345         * WebCoreSupport/WebFrameLoaderClient.h:
3346         * WebCoreSupport/WebFrameNetworkingContext.h:
3347         * WebCoreSupport/WebGeolocationClient.h:
3348         * WebCoreSupport/WebIconDatabaseClient.h:
3349         * WebCoreSupport/WebInspectorClient.h:
3350         * WebCoreSupport/WebNotificationClient.h:
3351         * WebCoreSupport/WebPlatformStrategies.h:
3352         * WebCoreSupport/WebProgressTrackerClient.h:
3353         * WebCoreSupport/WebUserMediaClient.h:
3354         * WebView/WebScriptDebugger.h:
3355         * WebView/WebViewData.h:
3356
3357 2014-01-16  Andy Estes  <aestes@apple.com>
3358
3359         [iOS] Fix build issues with exported headers
3360
3361         * DOM/WebDOMOperationsPrivate.h: Changed PLATFORM(IOS) to
3362         TARGET_OS_IPHONE.
3363         * MigrateHeaders.make: Excluded WAKScrollView.h from normal replacement
3364         rules so that WebCoreFrameScrollView won't inadvertently get changed to
3365         WebKitFrameScrollView.
3366         * Plugins/WebPlugin.h: Moved contents of WebPluginPrivate.h to here in
3367         order to maintain source compatibility.
3368         * Plugins/WebPluginController.mm: Removed an import of WebPluginPrivate.h.
3369         * Plugins/WebPluginPrivate.h: Removed.
3370         * Storage/WebDatabaseManagerPrivate.h: Replaced ENABLE(SQL_DATABASE)
3371         with ENABLE_SQL_DATABASE.
3372         * WebView/WebViewPrivate.h: Added declaration of
3373         -[WebView _touchEventRegions] for source compatibility.
3374
3375 2014-01-15  Benjamin Poulain  <bpoulain@apple.com>
3376
3377         Fix the iOS build after r162114
3378
3379         Unreviewed.
3380
3381         * WebView/WebViewPrivate.h: I forgot to remove the declaration, fix that.
3382
3383 2014-01-15  Benjamin Poulain  <bpoulain@apple.com>
3384
3385         Move user agent code to WebCore and unify some code between OS X and iOS
3386         https://bugs.webkit.org/show_bug.cgi?id=127080
3387
3388         Reviewed by Sam Weinig.
3389
3390         * WebCoreSupport/WebSystemInterface.mm:
3391         (InitWebCoreSystemInterface):
3392         * WebView/WebView.mm:
3393         (userVisibleWebKitVersionString):
3394         (+[WebView _standardUserAgentWithApplicationName:]):
3395         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]):
3396
3397 2014-01-15  Joseph Pecoraro  <pecoraro@apple.com>
3398
3399         [iOS] Clean up REMOTE_INSPECTOR code in OpenSource after the iOS merge
3400         https://bugs.webkit.org/show_bug.cgi?id=127069
3401
3402         Reviewed by Timothy Hatcher.
3403
3404         * WebView/WebView.mm:
3405         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3406         (+[WebView _enableRemoteInspector]):
3407         (+[WebView _disableRemoteInspector]):
3408         (+[WebView _disableAutoStartRemoteInspector]):
3409         (+[WebView _isRemoteInspectorEnabled]):
3410         (+[WebView _hasRemoteInspectorSession]):
3411         (-[WebView allowsRemoteInspection]):
3412         Implement with RemoteInspector.h SPIs.
3413
3414         (-[WebView setAllowsRemoteInspection:]):
3415         (-[WebView setHostApplicationBundleId:name:]):
3416         Still unimplemented, update comment.
3417
3418         (-[WebView _didCommitLoadForFrame:]):
3419         Remove dead path, WebCore now pushes updates on navigations.
3420
3421         * WebView/WebViewData.h:
3422         * WebView/WebViewData.mm:
3423         (-[WebViewPrivate init]):
3424         Remove now unused ivar.
3425
3426 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
3427
3428         More iOS build fixing.
3429
3430         * WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
3431         Removed a now unused local variable.
3432
3433 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
3434
3435         Build fix for iOS.
3436
3437         * WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
3438         Update a remaining call site of _updatePrivateBrowsingStateFram:to:.
3439
3440 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
3441
3442         Crash when multiple WebView instances have different PrivateBrowsing settings
3443         https://bugs.webkit.org/show_bug.cgi?id=127019
3444
3445         * WebView/WebPreferences.mm: (-[WebPreferences _updatePrivateBrowsingStateTo:]):
3446         Added a null check to fix Safari crash on startup when extensions are enabled.
3447
3448 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
3449
3450         Crash when multiple WebView instances have different PrivateBrowsing settings
3451         https://bugs.webkit.org/show_bug.cgi?id=127019
3452
3453         Reviewed by Sam Weinig.
3454
3455         * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
3456         browsing session simply because one preferences object doesn't use private browsing.
3457         There could be others that do.
3458
3459         * WebView/WebPreferences.mm: Track how many WebPreferences objects use private
3460         browsing, and only delete the private session when there are none any more.
3461
3462 2014-01-15  David Kilzer  <ddkilzer@apple.com>
3463
3464         [iOS] Missing RenderObject::style() symbol in WebDOMOperations.mm
3465
3466         Fixes the following linker error:
3467
3468             Undefined symbols for architecture x86_64:
3469               "__ZNK7WebCore12RenderObject5styleEv", referenced from:
3470                   -[DOMNode(WebDOMNodeOperations) isHorizontalWritingMode] in WebDOMOperations.o
3471
3472         * DOM/WebDOMOperations.mm: Include RenderElement.h instead of
3473         RenderObject.h since the inline RenderObject::style() method
3474         moved to the former header.
3475
3476 2014-01-15  Commit Queue  <commit-queue@webkit.org>
3477
3478         Unreviewed, rolling out r162054.
3479         http://trac.webkit.org/changeset/162054
3480         https://bugs.webkit.org/show_bug.cgi?id=127053
3481
3482         Causes assertion failures in DumpRenderTree (Requested by ap
3483         on #webkit).
3484
3485         * WebView/WebPreferences.mm:
3486         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
3487         (-[WebPreferences initWithCoder:]):
3488         (+[WebPreferences standardPreferences]):
3489         (-[WebPreferences dealloc]):
3490         (-[WebPreferences setPrivateBrowsingEnabled:]):
3491         (-[WebPreferences _invalidateCachedPreferences]):
3492         * WebView/WebView.mm:
3493         (-[WebView _preferencesChanged:]):
3494
3495 2014-01-14  Alexey Proskuryakov  <ap@apple.com>
3496
3497         Crash when multiple WebView instances have different PrivateBrowsing settings
3498         https://bugs.webkit.org/show_bug.cgi?id=127019
3499
3500         Reviewed by Sam Weinig.
3501
3502         * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
3503         browsing session simply because one preferences object doesn't use private browsing.
3504         There could be others that do.
3505
3506         * WebView/WebPreferences.mm: Track how many WebPreferences objects use private
3507         browsing, and only delete the private session when there are none any more.
3508
3509 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3510
3511         Fix the iOS build after r162034.
3512
3513         * WebCoreSupport/WebProgressTrackerClient.mm:
3514         * WebView/WebView.mm:
3515         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3516
3517 2014-01-14  Mark Rowe  <mrowe@apple.com>
3518
3519         Stop cmp from spewing useless info during postprocess-headers.sh.
3520
3521         * postprocess-headers.sh: Pass -s to silence cmp since we only care about the
3522         exit status.
3523
3524 2014-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3525
3526         [iOS] Crash in NavigatorBase::vendor loading apple.com
3527         https://bugs.webkit.org/show_bug.cgi?id=127028
3528
3529         Reviewed by Daniel Bates.
3530
3531         Fill in iOS WebKitSystemInterface functions.
3532
3533         * WebCoreSupport/WebSystemInterface.mm:
3534         (InitWebCoreSystemInterface):
3535
3536 2014-01-14  Anders Carlsson  <andersca@apple.com>
3537
3538         Create separate progress tracker clients
3539         https://bugs.webkit.org/show_bug.cgi?id=127025
3540
3541         Reviewed by Sam Weinig.
3542
3543         * WebCoreSupport/WebFrameLoaderClient.h:
3544         * WebCoreSupport/WebFrameLoaderClient.mm:
3545         * WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
3546         * WebCoreSupport/WebProgressTrackerClient.mm: Added.
3547         (WebProgressTrackerClient::WebProgressTrackerClient):
3548         (WebProgressTrackerClient::progressTrackerDestroyed):
3549         (WebProgressTrackerClient::willChangeEstimatedProgress):
3550         (WebProgressTrackerClient::didChangeEstimatedProgress):
3551         (WebProgressTrackerClient::progressStarted):
3552         (WebProgressTrackerClient::progressEstimateChanged):
3553         (WebProgressTrackerClient::progressFinished):
3554         * WebView/WebView.mm:
3555         (-[WebView _commonInitializationWithFrameName:groupName:]):
3556         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3557
3558 2014-01-14  Dean Jackson  <dino@apple.com>
3559
3560         Correct grave mistake in updating the pbxproj file rather than xcconfig.
3561
3562         * Configurations/WebKit.xcconfig:
3563
3564 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3565
3566         #define ENABLE_DASHBOARD_SUPPORT for iOS.
3567
3568         * WebView/WebViewPrivate.h:
3569
3570 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3571
3572         Clean up exports and headers for iOS.
3573         
3574         Need to export WebArchivePboardType on Mac and iOS.
3575
3576         * WebKit.exp:
3577         * WebKit.mac.exp:
3578
3579 2014-01-14  Simon Fraser  <simon.fraser@apple.com>
3580
3581         Fix header availability checks on iOS
3582         https://bugs.webkit.org/show_bug.cgi?id=127016
3583
3584         Reviewed by Andy Estes.
3585
3586         Make DOMTouch* and DOMGesture* headers public headers on iOS,
3587         and fix MigrateHeaders.make to skip availability checks when
3588         building for iOS.
3589
3590         * MigrateHeaders.make:
3591