338297850cbdf9f79895f22fdf882a12ccb522f7
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-01-22  Beth Dakin  <bdakin@apple.com>
2
3         ibtoold crash below -[WebView close]
4         https://bugs.webkit.org/show_bug.cgi?id=140782
5         -and corresponding-
6         rdar://problem/19558472
7
8         Reviewed by Tim Horton.
9
10         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
11         it is because interface builder is messing with our views.
12         * WebView/WebImmediateActionController.h:
13         * WebView/WebImmediateActionController.mm:
14         (-[WebImmediateActionController webViewClosed]):
15         (-[WebImmediateActionController _cancelImmediateAction]):
16         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
17         (-[WebImmediateActionController _updateImmediateActionItem]):
18
19 2015-01-21  Beth Dakin  <bdakin@apple.com>
20
21         Crash in QuickLook preview delegate method
22         https://bugs.webkit.org/show_bug.cgi?id=140740
23         -and corresponding-
24         rdar://problem/19540806
25
26         Reviewed by Tim Horton.
27
28         Clear out the delegate.
29         * WebView/WebImmediateActionController.mm:
30         (-[WebImmediateActionController webViewClosed]):
31
32 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
33
34         Remove ENABLE(INSPECTOR) ifdef guards
35         https://bugs.webkit.org/show_bug.cgi?id=140668
36
37         Reviewed by Darin Adler.
38
39         * Configurations/FeatureDefines.xcconfig:
40         * WebCoreSupport/WebFrameLoaderClient.mm:
41         (WebFrameLoaderClient::dispatchWillSendRequest):
42
43 2015-01-20  Anders Carlsson  <andersca@apple.com>
44
45         Remove USE(GLIB) code from WebKit1
46         https://bugs.webkit.org/show_bug.cgi?id=140714
47
48         Reviewed by Andreas Kling.
49
50         * WebView/WebView.mm:
51         (-[WebView _commonInitializationWithFrameName:groupName:]):
52         (-[WebView _close]):
53         (-[WebView _clearGlibLoopObserver]): Deleted.
54         (glibContextIterationCallback): Deleted.
55         (-[WebView _scheduleGlibContextIterations]): Deleted.
56         * WebView/WebViewData.h:
57         * WebView/WebViewInternal.h:
58
59 2015-01-20  David Kilzer  <ddkilzer@apple.com>
60
61         Switch to comparing PLATFORM_NAME in terms of macosx
62         <http://webkit.org/b/139516>
63
64         Reviewed by Timothy Hatcher.
65
66         * MigrateHeaders.make:
67         * postprocess-headers.sh:
68
69 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
70
71         [SVG -> OTF Converter] Flip the switch on
72         https://bugs.webkit.org/show_bug.cgi?id=140592
73
74         Reviewed by Antti Koivisto.
75
76         * Configurations/FeatureDefines.xcconfig:
77
78 2015-01-19  Beth Dakin  <bdakin@apple.com>
79
80         Speculative build fix.
81
82         * WebView/WebView.mm:
83         (-[WebView _commonInitializationWithFrameName:groupName:]):
84
85 2015-01-19  Beth Dakin  <bdakin@apple.com>
86
87         Speculative build fix.
88
89         * WebView/WebView.mm:
90         (-[WebView _convertRectFromRootView:]):
91
92 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
93
94         Adjust naming of action menu SPI
95         https://bugs.webkit.org/show_bug.cgi?id=140644
96         <rdar://problem/19448129>
97
98         Reviewed by Brian Weinstein.
99
100         * WebView/WebActionMenuController.mm:
101         (-[WebActionMenuController prepareForMenu:withEvent:]):
102         (-[WebActionMenuController willOpenMenu:withEvent:]):
103         (-[WebActionMenuController didCloseMenu:withEvent:]):
104         * WebView/WebView.mm:
105         (-[WebView _commonInitializationWithFrameName:groupName:]):
106         (-[WebView prepareForMenu:withEvent:]):
107         (-[WebView willOpenMenu:withEvent:]):
108         (-[WebView didCloseMenu:withEvent:]):
109
110 2015-01-19  Beth Dakin  <bdakin@apple.com>
111
112         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
113         offset by flipped-ness
114         https://bugs.webkit.org/show_bug.cgi?id=140643
115         -and corresponding-
116         rdar://problem/19489593
117
118         Reviewed by Tim Horton.
119
120         We universally flipped because we assumed that the root view was flipped and the 
121         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
122         fixes that assumption by checking the WebView’s flipped-ness.
123         * WebView/WebView.mm:
124         (-[WebView _convertRectFromRootView:]):
125
126 2015-01-19  Commit Queue  <commit-queue@webkit.org>
127
128         Unreviewed, rolling out r178653.
129         https://bugs.webkit.org/show_bug.cgi?id=140634
130
131         Broke multiple SVG tests on Mountain Lion (Requested by ap on
132         #webkit).
133
134         Reverted changeset:
135
136         "[SVG -> OTF Converter] Flip the switch on"
137         https://bugs.webkit.org/show_bug.cgi?id=140592
138         http://trac.webkit.org/changeset/178653
139
140 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
141
142         [SVG -> OTF Converter] Flip the switch on
143         https://bugs.webkit.org/show_bug.cgi?id=140592
144
145         Reviewed by Antti Koivisto.
146
147         * Configurations/FeatureDefines.xcconfig:
148
149 2015-01-18  Daniel Bates  <dabates@apple.com>
150
151         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
152         (https://bugs.webkit.org/show_bug.cgi?id=129441)
153
154         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
155         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
156
157         * WebInspector/WebNodeHighlightView.mm:
158         (-[WebNodeHighlightView layoutSublayers:]):
159
160 2015-01-16  Beth Dakin  <bdakin@apple.com>
161
162         Make sure early cancellation of immediate action actually does that in WK1
163         https://bugs.webkit.org/show_bug.cgi?id=140566
164         -and corresponding-
165         rdar://problem/19490114
166
167         Reviewed by Tim Horton.
168
169         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
170         asynchronously.
171         * WebView/WebImmediateActionController.mm:
172         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
173
174 2015-01-16  Daniel Bates  <dabates@apple.com>
175
176         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
177         (https://bugs.webkit.org/show_bug.cgi?id=140360)
178
179         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
180
181         * Misc/WebDownload.h:
182
183 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
184
185         Remove ENABLE(SQL_DATABASE) guards
186         https://bugs.webkit.org/show_bug.cgi?id=140434
187
188         Reviewed by Darin Adler.
189
190         * Configurations/FeatureDefines.xcconfig:
191         * Storage/WebDatabaseManager.mm:
192         (databasesDirectoryPath):
193         * Storage/WebDatabaseManagerClient.h:
194         * Storage/WebDatabaseManagerClient.mm:
195         * Storage/WebDatabaseManagerInternal.h:
196         * Storage/WebDatabaseManagerPrivate.h:
197         * Storage/WebDatabaseQuotaManager.mm:
198         (-[WebDatabaseQuotaManager usage]):
199         (-[WebDatabaseQuotaManager quota]):
200         (-[WebDatabaseQuotaManager setQuota:]):
201         * WebCoreSupport/WebChromeClient.h:
202         * WebCoreSupport/WebChromeClient.mm:
203         * WebCoreSupport/WebSecurityOrigin.mm:
204         (-[WebSecurityOrigin usage]):
205         (-[WebSecurityOrigin quota]):
206         (-[WebSecurityOrigin setQuota:]):
207         * WebView/WebFrame.mm:
208         (-[WebFrame _cacheabilityDictionary]):
209         * WebView/WebView.mm:
210         (-[WebView _commonInitializationWithFrameName:groupName:]):
211         (-[WebView _preferencesChanged:]):
212
213 2015-01-14  Chris Dumez  <cdumez@apple.com>
214
215         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
216         https://bugs.webkit.org/show_bug.cgi?id=140347
217
218         Reviewed by Darin Adler.
219
220         Call FontDescription::setIsItalic() instead of setItalic() as the
221         call site passes a boolean.
222
223         * WebView/WebHTMLView.mm:
224         (fontNameForDescription):
225
226 2015-01-13  Anders Carlsson  <andersca@apple.com>
227
228         Temporarily reintroduce the informal delegate protocols
229         https://bugs.webkit.org/show_bug.cgi?id=140416
230
231         Reviewed by Dan Bernstein.
232
233         * WebView/WebEditingDelegate.h:
234         * WebView/WebFrameLoadDelegate.h:
235         * WebView/WebPolicyDelegate.h:
236         * WebView/WebResourceLoadDelegate.h:
237         * WebView/WebUIDelegate.h:
238
239 2015-01-13  Beth Dakin  <bdakin@apple.com>
240
241         Should disable immediate actions for iTunes
242         https://bugs.webkit.org/show_bug.cgi?id=140405
243         -and corresponding-
244         rdar://problem/19461358
245
246         Reviewed by Tim Horton.
247
248         * WebView/WebImmediateActionController.mm:
249         (-[WebImmediateActionController _updateImmediateActionItem]):
250
251 2015-01-11  Sam Weinig  <sam@webkit.org>
252
253         Remove support for SharedWorkers
254         https://bugs.webkit.org/show_bug.cgi?id=140344
255
256         Reviewed by Anders Carlsson.
257
258         * Configurations/FeatureDefines.xcconfig:
259         * WebCoreSupport/WebPlatformStrategies.h:
260         * WebCoreSupport/WebPlatformStrategies.mm:
261         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
262
263 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
264
265         Get rid of unnecessary reimplementations of CGFloor/Ceiling
266         https://bugs.webkit.org/show_bug.cgi?id=140375
267
268         Reviewed by Simon Fraser.
269
270         * Misc/WebKitNSStringExtras.mm:
271         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
272         (webkit_CGCeiling): Deleted.
273         Delete unnecessary code, use the real CGFloor/Ceiling instead.
274
275 2015-01-12  Anders Carlsson  <andersca@apple.com>
276
277         Make delegates conform to formal delegate protocols
278         https://bugs.webkit.org/show_bug.cgi?id=140370
279
280         Reviewed by Dan Bernstein.
281
282         * DefaultDelegates/WebDefaultPolicyDelegate.h:
283         * WebCoreSupport/WebInspectorClient.mm:
284         Add protocols to the interface declarations.
285
286         * WebView/WebActionMenuController.mm:
287         (-[WebActionMenuController prepareForMenu:withEvent:]):
288         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
289         * WebView/WebImmediateActionController.mm:
290         (-[WebImmediateActionController _updateImmediateActionItem]):
291         (-[WebImmediateActionController _menuItemForDataDetectedText]):
292         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
293
294 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
295
296         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
297         https://bugs.webkit.org/show_bug.cgi?id=136769
298
299         Reviewed by Antti Koivisto.
300
301         * Configurations/FeatureDefines.xcconfig:
302
303 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
304
305         Multi-rect TextIndicators are vertically flipped in WebKit1
306         https://bugs.webkit.org/show_bug.cgi?id=140350
307         <rdar://problem/19441243>
308
309         Reviewed by Beth Dakin.
310
311         * WebView/WebView.mm:
312         (-[WebView _setTextIndicator:fadeOut:]):
313         Convert the textBoundingRect from root view to screen coordinates.
314
315 2015-01-12  Anders Carlsson  <andersca@apple.com>
316
317         Make WebResourceDelegate a formal protocol as well
318         https://bugs.webkit.org/show_bug.cgi?id=140364
319
320         Reviewed by Dan Bernstein.
321
322         * WebView/WebResourceLoadDelegate.h:
323
324 2015-01-12  Anders Carlsson  <andersca@apple.com>
325
326         Delegates should be formal protocols
327         https://bugs.webkit.org/show_bug.cgi?id=140360
328         rdar://problem/17380856
329
330         Reviewed by Dan Bernstein.
331
332         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
333
334         * DefaultDelegates/WebDefaultUIDelegate.h:
335         * Misc/WebDownload.h:
336         * WebView/WebEditingDelegate.h:
337         * WebView/WebFrameLoadDelegate.h:
338         * WebView/WebPolicyDelegate.h:
339         * WebView/WebUIDelegate.h:
340
341 2015-01-09  Anders Carlsson  <andersca@apple.com>
342
343         Get rid of the database strategy
344         https://bugs.webkit.org/show_bug.cgi?id=140322
345
346         Reviewed by Sam Weinig.
347
348         * WebCoreSupport/WebPlatformStrategies.h:
349         * WebCoreSupport/WebPlatformStrategies.mm:
350         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
351
352 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
353
354         Can't use DataDetectors after immediate action preparation
355         https://bugs.webkit.org/show_bug.cgi?id=140263
356         <rdar://problem/19412705>
357
358         Reviewed by Beth Dakin.
359
360         * WebView/WebImmediateActionController.mm:
361         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
362         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
363         To match WebKit2, only call shouldUseActions if the animation is actually
364         going to begin, not when preparing for it. This way, we're guaranteed
365         to get a didCancel or didComplete.
366
367 2015-01-08  Dean Jackson  <dino@apple.com>
368
369         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
370         https://bugs.webkit.org/show_bug.cgi?id=140232
371         <rdar://problem/19371010>
372
373         Reviewed by Anders Carlsson.
374
375         Remove the applicationChromeMode setting, but leave stubs in to make
376         sure existing binaries don't break.
377
378         * WebCoreSupport/WebInspectorClient.mm:
379         (-[WebInspectorWindowController init]):
380         * WebView/WebPreferenceKeysPrivate.h:
381         * WebView/WebPreferences.mm:
382         (+[WebPreferences initialize]):
383         (-[WebPreferences applicationChromeModeEnabled]):
384         (-[WebPreferences setApplicationChromeModeEnabled:]):
385         * WebView/WebView.mm:
386         (-[WebView _preferencesChanged:]):
387
388 2015-01-07  Daniel Bates  <dabates@apple.com>
389
390         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
391         https://bugs.webkit.org/show_bug.cgi?id=137371
392
393         Reviewed by David Kilzer.
394
395         Use SPI wrapper headers instead of directly references private SPI headers.
396
397         * Plugins/Hosted/NetscapePluginHostManager.mm:
398
399 2015-01-07  Commit Queue  <commit-queue@webkit.org>
400
401         Unreviewed, rolling out r178068.
402         https://bugs.webkit.org/show_bug.cgi?id=140235
403
404         Breaks the iOS build (Requested by enrica on #webkit).
405
406         Reverted changeset:
407
408         "[iOS] Make WebKit2 build with public iOS SDK and more build
409         fixes for DRT"
410         https://bugs.webkit.org/show_bug.cgi?id=137371
411         http://trac.webkit.org/changeset/178068
412
413 2015-01-07  Daniel Bates  <dabates@apple.com>
414
415         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
416         https://bugs.webkit.org/show_bug.cgi?id=137371
417
418         Reviewed by David Kilzer.
419
420         Use SPI wrapper headers instead of directly references private SPI headers.
421
422         * Plugins/Hosted/NetscapePluginHostManager.mm:
423
424 2015-01-07  Beth Dakin  <bdakin@apple.com>
425
426         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
427         link
428         https://bugs.webkit.org/show_bug.cgi?id=140206
429         -and corresponding-
430         rdar://problem/19300492
431
432         Reviewed by Tim Horton.
433
434         Providing and item frame will ensure that the original link is not obscured.
435         * WebView/WebImmediateActionController.mm:
436         (elementBoundingBoxInWindowCoordinatesFromNode):
437         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
438
439         For now use a max size that is smaller than the WebView, with the screen’s aspect 
440         ratio, and scaled down.
441         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
442
443 2015-01-07  Anders Carlsson  <andersca@apple.com>
444
445         Give simple HTML documents a database provider
446         https://bugs.webkit.org/show_bug.cgi?id=140192
447         rdar://problem/19398825
448
449         Reviewed by Tim Horton.
450
451         * WebView/WebView.mm:
452         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
453
454 2015-01-06  Anders Carlsson  <andersca@apple.com>
455
456         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
457         https://bugs.webkit.org/show_bug.cgi?id=140140
458
459         Reviewed by Andreas Kling.
460
461         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
462         out of WebCore since nobody else is using it.
463
464         * Plugins/WebNetscapePluginView.h:
465         * Plugins/WebNetscapePluginView.mm:
466         (-[WebNetscapePluginView _createPlugin]):
467         (-[WebNetscapePluginView _destroyPlugin]):
468         * Plugins/npapi.mm:
469         (NPN_PluginThreadAsyncCall):
470
471 2015-01-06  Anders Carlsson  <andersca@apple.com>
472
473         Add a WebKit1 database provider
474         https://bugs.webkit.org/show_bug.cgi?id=140126
475
476         Reviewed by Sam Weinig.
477
478         Set the database provider.
479
480         * WebView/WebView.mm:
481         (-[WebView _commonInitializationWithFrameName:groupName:]):
482
483 2015-01-06  Commit Queue  <commit-queue@webkit.org>
484
485         Unreviewed, rolling out r177963.
486         https://bugs.webkit.org/show_bug.cgi?id=140136
487
488         Caused lots of crashes (Requested by smfr on #webkit).
489
490         Reverted changeset:
491
492         "Add a WebKit1 database provider"
493         https://bugs.webkit.org/show_bug.cgi?id=140126
494         http://trac.webkit.org/changeset/177963
495
496 2015-01-06  Anders Carlsson  <andersca@apple.com>
497
498         Add a WebKit1 database provider
499         https://bugs.webkit.org/show_bug.cgi?id=140126
500
501         Reviewed by Sam Weinig.
502
503         Set the database provider.
504
505         * WebView/WebView.mm:
506         (-[WebView _commonInitializationWithFrameName:groupName:]):
507
508 2015-01-01  Jeff Miller  <jeffm@apple.com>
509
510         Update user-visible copyright strings to include 2015
511         https://bugs.webkit.org/show_bug.cgi?id=139880
512
513         Reviewed by Darin Adler.
514
515         * Info.plist:
516
517 2014-12-30  Dan Bernstein  <mitz@apple.com>
518
519         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
520         https://bugs.webkit.org/show_bug.cgi?id=140003
521
522         Reviewed by Darin Adler.
523
524         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
525         that takes their "string" parameter as a "value" "parameter and has an attribute telling
526         the compiler that if the "value" parameter is a format string then the function returns a
527         modified version of it. The result is that if UI_STRING is used as a format string parameter
528         to some function or method, the compiler will check the format specifiers in the string
529         against the other parameters.
530
531 2014-12-29  Dan Bernstein  <mitz@apple.com>
532
533         Fixed the iOS build.
534
535         * Configurations/WebKitLegacy.xcconfig:
536
537 2014-12-29  Anders Carlsson  <andersca@apple.com>
538
539         Get rid of some PageGroup storage functions
540         https://bugs.webkit.org/show_bug.cgi?id=139996
541
542         Reviewed by Sam Weinig.
543
544         Call WebStorageNamespaceProvider directly instead.
545
546         * Storage/WebStorageManager.mm:
547         (-[WebStorageManager syncLocalStorage]):
548         (+[WebStorageManager closeIdleLocalStorageDatabases]):
549         * WebView/WebView.mm:
550         (+[WebView _applicationWillTerminate]):
551
552 2014-12-29  Anders Carlsson  <andersca@apple.com>
553
554         Move storage code from WebCore to WebKit
555         https://bugs.webkit.org/show_bug.cgi?id=139558
556
557         Reviewed by Darin Adler.
558
559         * Storage/WebStorageManager.mm:
560         * Storage/WebStorageTrackerClient.h:
561         * WebView/WebView.mm:
562
563 2014-12-26  Dan Bernstein  <mitz@apple.com>
564
565         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
566         https://bugs.webkit.org/show_bug.cgi?id=139950
567
568         Reviewed by David Kilzer.
569
570         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
571         in a manner that works with Xcode 5.1.1.
572
573 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
574
575         Install a TextIndicator for link immediate actions
576         https://bugs.webkit.org/show_bug.cgi?id=139897
577         <rdar://problem/19333076>
578
579         Reviewed by Anders Carlsson.
580
581         * WebView/WebImmediateActionController.h:
582         * WebView/WebImmediateActionController.mm:
583         (-[WebImmediateActionController _clearImmediateActionState]):
584         Tear down the TextIndicator, just like WebKit2.
585
586         (-[WebImmediateActionController _defaultAnimationController]):
587         Install a TextIndicator for links.
588
589         (-[WebImmediateActionController menuItemDidClose:]):
590         Tear down the TextIndicator when the QL preview closes.
591
592         (-[WebImmediateActionController _menuItemForDataDetectedText]):
593         Directly install and uninstall the TextIndicator for DataDetectors.
594
595         (-[WebImmediateActionController _showTextIndicator]): Deleted.
596         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
597         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
598
599 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
600
601         [iOS] add optimized fullscreen API
602         https://bugs.webkit.org/show_bug.cgi?id=139833
603         <rdar://problem/18844486>
604
605         Reviewed by Simon Fraser.
606
607         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
608
609 2014-12-20  David Kilzer  <ddkilzer@apple.com>
610
611         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
612         <http://webkit.org/b/139463>
613
614         Reviewed by Mark Rowe.
615
616         * Configurations/Base.xcconfig:
617         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
618           on OS X.
619         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
620         * Configurations/DebugRelease.xcconfig:
621         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
622         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
623         * Configurations/Version.xcconfig:
624         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
625         * Configurations/WebKitLegacy.xcconfig:
626         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
627           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
628           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
629           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
630           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
631           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
632           WEBCORE_PRIVATE_HEADERS_DIR_Production and
633           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
634           based on SDK.
635         - Fix PRODUCTION_ROOT to actually be set properly.
636         - Simplify EXPORTED_SYMBOLS_FILE_i386.
637
638         * migrate-headers.sh:
639         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
640         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
641           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
642           WebKitLegacy.xcconfig.
643
644 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
645
646         Fix pink background on CoreAnimation plug-ins in WebKit1
647         https://bugs.webkit.org/show_bug.cgi?id=139845
648         rdar://problem/19313075
649
650         Reviewed by Tim Horton.
651         
652         r154078 left in some debugging code that set a pink background on plug-in hosting
653         layers. Remove it.
654
655         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
656         (-[WebHostedNetscapePluginView createPluginLayer]):
657
658 2014-12-19  Andreas Kling  <akling@apple.com>
659
660         Ref-ify TextIterator API.
661         <https://webkit.org/b/139823>
662
663         Reviewed by Antti Koivisto.
664
665         * WebView/WebTextIterator.mm:
666         (-[WebTextIterator currentRange]):
667
668 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
669
670         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
671         https://bugs.webkit.org/show_bug.cgi?id=139797
672
673         Reviewed by Mark Lam.
674
675         * WebView/WebScriptDebugger.h:
676         * WebView/WebScriptDebugger.mm:
677         (WebScriptDebugger::handlePause):
678         Standardize on passing JSGlobalObject parameter first.
679
680 2014-12-19  Commit Queue  <commit-queue@webkit.org>
681
682         Unreviewed, rolling out r177574.
683         https://bugs.webkit.org/show_bug.cgi?id=139821
684
685         "Broke Production builds by installing
686         libWebCoreTestSupport.dylib in the wrong directory" (Requested
687         by ddkilzer on #webkit).
688
689         Reverted changeset:
690
691         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
692         WebInspectorUI, WebKit, WebKit2"
693         https://bugs.webkit.org/show_bug.cgi?id=139463
694         http://trac.webkit.org/changeset/177574
695
696 2014-12-19  David Kilzer  <ddkilzer@apple.com>
697
698         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
699         <http://webkit.org/b/139463>
700
701         Reviewed by Mark Rowe.
702
703         * Configurations/Base.xcconfig:
704         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
705           on OS X.
706         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
707         * Configurations/DebugRelease.xcconfig:
708         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
709         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
710         * Configurations/Version.xcconfig:
711         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
712         * Configurations/WebKitLegacy.xcconfig:
713         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
714           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
715           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
716           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
717           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
718           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
719           WEBCORE_PRIVATE_HEADERS_DIR_Production and
720           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
721           based on SDK.
722         - Fix PRODUCTION_ROOT to actually be set properly.
723         - Simplify EXPORTED_SYMBOLS_FILE_i386.
724
725         * migrate-headers.sh:
726         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
727         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
728           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
729           WebKitLegacy.xcconfig.
730
731 2014-12-18  Andreas Kling  <akling@apple.com>
732
733         Ref-ify various Document-related things.
734         <https://webkit.org/b/139796>
735
736         Reviewed by Anders Carlsson.
737
738         * WebView/WebFrame.mm:
739         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
740
741 2014-12-18  Beth Dakin  <bdakin@apple.com>
742
743         Need to re-enable action menus
744         https://bugs.webkit.org/show_bug.cgi?id=139795
745         -and corresponding-
746         rdar://problem/19299367
747
748         Reviewed by Tim Horton.
749
750         Re-enable the menus by un-commenting the code to create the menu and controller.
751         * WebView/WebView.mm:
752         (-[WebView _commonInitializationWithFrameName:groupName:]):
753
754 2014-12-16  Sam Weinig  <sam@webkit.org>
755
756         Unify the Mac and iOS implementations of FontPlatformData a bit
757         https://bugs.webkit.org/show_bug.cgi?id=139721
758
759         Reviewed by Anders Carlsson.
760
761         * WebView/WebHTMLView.mm:
762         (fontNameForDescription):
763         Update for new function name.
764
765 2014-12-18  Antti Koivisto  <antti@apple.com>
766
767         Remove alwaysUseBaselineOfPrimaryFont setting
768         https://bugs.webkit.org/show_bug.cgi?id=139770
769
770         Reviewed by Anders Carlsson.
771
772         * WebView/WebPreferenceKeysPrivate.h:
773         * WebView/WebPreferences.mm:
774         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
775         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
776         * WebView/WebPreferencesPrivate.h:
777         * WebView/WebView.mm:
778         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
779         (-[WebView _preferencesChanged:]):
780
781 2014-12-17  Andreas Kling  <akling@apple.com>
782
783         Ref-ify Range::create().
784         <https://webkit.org/b/139755>
785
786         Reviewed by Anders Carlsson.
787
788         * WebView/WebHTMLRepresentation.mm:
789         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
790         * WebView/WebHTMLView.mm:
791         (-[WebHTMLView attributedString]):
792
793 2014-12-17  Anders Carlsson  <andersca@apple.com>
794
795         Unify -[WebResource description]
796         https://bugs.webkit.org/show_bug.cgi?id=139762
797
798         Reviewed by Dan Bernstein.
799
800         * WebView/WebResource.mm:
801         (-[WebResource description]):
802
803 2014-12-17  Anders Carlsson  <andersca@apple.com>
804
805         Get rid of an ugly #define hack in WebFrameLoaderClient
806         https://bugs.webkit.org/show_bug.cgi?id=139761
807
808         Reviewed by Dan Bernstein.
809
810         Also replace @private with @package in all public headers, for consistency.
811
812         * History/WebBackForwardList.h:
813         * History/WebHistory.h:
814         * Misc/WebDownload.h:
815         * WebCoreSupport/WebFrameLoaderClient.mm:
816         * WebView/WebArchive.h:
817         * WebView/WebDataSource.h:
818         * WebView/WebFrame.h:
819         * WebView/WebFrameView.h:
820         * WebView/WebPreferences.h:
821         * WebView/WebResource.h:
822
823 2014-12-17  Dan Bernstein  <mitz@apple.com>
824
825         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
826         https://bugs.webkit.org/show_bug.cgi?id=139760
827
828         Reviewed by Anders Carlsson.
829
830         * Configurations/WebKitLegacy.xcconfig:
831
832 2014-12-17  Andreas Kling  <akling@apple.com>
833
834         Purge PassRefPtr from Frame.
835         <https://webkit.org/b/139731>
836
837         Reviewed by Anders Carlsson.
838
839         * WebCoreSupport/WebFrameLoaderClient.mm:
840         (WebFrameLoaderClient::transitionToCommittedForNewPage):
841         * WebView/WebFrame.mm:
842         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
843         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
844         * WebView/WebFrameInternal.h:
845
846 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
847
848         Implement and adopt two new TextIndicator presentation animations
849         https://bugs.webkit.org/show_bug.cgi?id=139715
850         <rdar://problem/19237945>
851
852         Reviewed by Anders Carlsson.
853
854         * WebView/WebActionMenuController.mm:
855         (-[WebActionMenuController _showTextIndicator]):
856         * WebView/WebHTMLView.mm:
857         (-[WebHTMLView quickLookWithEvent:]):
858         Remove the completionHandler from text indicator presentation.
859
860         * WebView/WebImmediateActionController.mm:
861         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
862         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
863         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
864         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
865         (-[WebImmediateActionController _menuItemForDataDetectedText]):
866         (-[WebImmediateActionController _animationControllerForText]):
867         (-[WebImmediateActionController _showTextIndicator]):
868         Forward immediate action gesture recognizer animation progress
869         to TextIndicator. Force us to keep the selection when immediate
870         action popovers steal first responder status from the WebView.
871         If the Lookup range is equal to the selection range, use a Crossfade
872         animation; otherwise, use a FadeIn animation.
873
874         * WebView/WebView.mm:
875         (-[WebView _setMaintainsInactiveSelection:]):
876         (-[WebView maintainsInactiveSelection]):
877         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
878         (-[WebView _setTextIndicator:fadeOut:]):
879         (-[WebView _clearTextIndicator]):
880         (-[WebView _setTextIndicatorAnimationProgress:]):
881         (-[WebView _showDictionaryLookupPopup:]):
882         (-[WebView _dictionaryLookupPopoverWillClose:]):
883         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
884         Remove the completionHandler from text indicator presentation.
885         Add a _setMaintainsInactiveSelection, which allows WebKit internals
886         to change the return value of -maintainsInactiveSelection, allowing
887         us to keep the selection alive when the WebView loses first responder status.
888
889         * WebView/WebViewData.h:
890         * WebView/WebViewInternal.h:
891
892 2014-12-16  Andreas Kling  <akling@apple.com>
893
894         Use Ref for SecurityOrigin.
895         <https://webkit.org/b/139710>
896
897         Reviewed by Anders Carlsson.
898
899         * Storage/WebStorageTrackerClient.mm:
900         (WebStorageTrackerClient::dispatchDidModifyOrigin):
901         * WebView/WebView.mm:
902         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
903         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
904
905 2014-12-16  Beth Dakin  <bdakin@apple.com>
906
907         Crash getting default animation controller for some text
908         https://bugs.webkit.org/show_bug.cgi?id=139712
909         -and corresponding-
910         rdar://problem/19271707
911
912         Reviewed by Tim Horton.
913
914         Must null-check the range.
915         * WebView/WebImmediateActionController.mm:
916         (-[WebImmediateActionController _animationControllerForText]):
917
918 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
919
920         Immediate action popovers can get stuck open
921         https://bugs.webkit.org/show_bug.cgi?id=139709
922         <rdar://problem/19270279>
923
924         Reviewed by Beth Dakin.
925
926         * WebView/WebImmediateActionController.mm:
927         (-[WebImmediateActionController _clearImmediateActionState]):
928         Don't clear the animation controller; it breaks things and was unnecessary.
929
930 2014-12-16  Tim Horton  <timothy_horton@apple.com>
931
932         Disable TextIndication for Lookup immediate actions
933         https://bugs.webkit.org/show_bug.cgi?id=139684
934
935         Reviewed by Anders Carlsson.
936
937         * WebView/WebView.mm:
938         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
939
940 2014-12-15  Beth Dakin  <bdakin@apple.com>
941
942         Build fix.
943
944         * WebView/WebImmediateActionController.mm:
945
946 2014-12-15  Beth Dakin  <bdakin@apple.com>
947
948         Speculative build fix.
949
950         * WebView/WebView.mm:
951         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
952         * WebView/WebViewInternal.h:
953
954 2014-12-15  Beth Dakin  <bdakin@apple.com>
955
956         Make lookup an immediate action instead of an action menu item
957         https://bugs.webkit.org/show_bug.cgi?id=139661
958         -and corresponding-
959         rdar://problem/19198414
960
961         Reviewed by Tim Horton.
962
963         Remove the lookup menu items and non-unused static function associated with 
964         lookup.
965         * WebView/WebActionMenuController.mm:
966         (-[WebActionMenuController _defaultMenuItemsForText]):
967         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
968         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
969         (-[WebActionMenuController _createActionMenuItemForTag:]):
970         (-[WebActionMenuController _lookupText:]): Deleted.
971         (performDictionaryLookupForSelection): Deleted.
972         (performDictionaryLookupForRange): Deleted.
973
974         Set the defaultAnimationController to the lookup-provided animation controller 
975         when appropriate.
976         * WebView/WebImmediateActionController.mm:
977         (-[WebImmediateActionController _defaultAnimationController]):
978         (dictionaryPopupInfoForRange):
979         (-[WebImmediateActionController _animationControllerForText]):
980
981         New type.
982         * WebView/WebUIDelegatePrivate.h:
983
984         New function to get the lookup animation controller.
985         * WebView/WebView.mm:
986         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
987         * WebView/WebViewInternal.h:
988
989 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
990
991         Implement Data Detectors immediate actions for Legacy WebKit
992         https://bugs.webkit.org/show_bug.cgi?id=139619
993         <rdar://problem/19198539>
994
995         Reviewed by Beth Dakin.
996
997         * WebView/WebImmediateActionController.mm:
998         (-[WebImmediateActionController _menuItemForDataDetectedText]):
999         Note that this action context is only for immediate actions.
1000
1001 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1002
1003         Addressing post-review comments in r177035
1004         https://bugs.webkit.org/show_bug.cgi?id=139557
1005
1006         Reviewed by Darin Adler.
1007
1008         * WebView/WebActionMenuController.mm:
1009         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1010
1011 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1012
1013         Implement Data Detectors immediate actions for Legacy WebKit
1014         https://bugs.webkit.org/show_bug.cgi?id=139619
1015         <rdar://problem/19198539>
1016
1017         Reviewed by Eric Carlson.
1018
1019         * WebView/WebHTMLView.mm:
1020         (-[WebHTMLView mouseDown:mouseDown:]):
1021         Send mouseDown along to the WebImmediateActionController too.
1022
1023         * WebView/WebImmediateActionController.h:
1024         * WebView/WebImmediateActionController.mm:
1025         (-[WebImmediateActionController webViewClosed]):
1026         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1027         (-[WebImmediateActionController _cancelImmediateAction]):
1028         (-[WebImmediateActionController _clearImmediateActionState]):
1029         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1030         (-[WebImmediateActionController _defaultAnimationController]):
1031         (-[WebImmediateActionController _updateImmediateActionItem]):
1032         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1033         (-[WebImmediateActionController _showTextIndicator]):
1034         (-[WebImmediateActionController _hideTextIndicator]):
1035         Copy most of the DataDetectors implementation into WebImmediateActionController.
1036
1037         * WebView/WebUIDelegatePrivate.h:
1038         Add a new type.
1039
1040         * WebView/WebView.mm:
1041         (-[WebView _commonInitializationWithFrameName:groupName:]):
1042         Temporarily disable action menus.
1043
1044         (-[WebView _immediateActionController]):
1045         * WebView/WebViewInternal.h:
1046
1047 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1048
1049         Delete Notation because we don't use it
1050         https://bugs.webkit.org/show_bug.cgi?id=139171
1051
1052         Reviewed by Kent Tamura.
1053
1054         * MigrateHeaders.make:
1055
1056 2014-12-14  Andreas Kling  <akling@apple.com>
1057
1058         Replace PassRef with Ref/Ref&& across the board.
1059         <https://webkit.org/b/139587>
1060
1061         Reviewed by Darin Adler.
1062
1063         * WebCoreSupport/WebEditorClient.mm:
1064         (WebEditorClient::shouldApplyStyle):
1065         * WebCoreSupport/WebVisitedLinkStore.h:
1066         * WebCoreSupport/WebVisitedLinkStore.mm:
1067         (WebVisitedLinkStore::create):
1068
1069 2014-12-11  Dan Bernstein  <mitz@apple.com>
1070
1071         Fix a leak introduced in r177199.
1072
1073         Reviewed by Anders Carlsson.
1074
1075         * WebView/WebImmediateActionController.mm:
1076         (-[WebImmediateActionController _updateImmediateActionItem]):
1077
1078 2014-12-11  Beth Dakin  <bdakin@apple.com>
1079
1080         WK1: Need new SPI for Webkit clients to override default immediate action
1081         https://bugs.webkit.org/show_bug.cgi?id=139568
1082         -and corresponding-
1083         rdar://problem/19225448
1084
1085         Reviewed by Dan Bernstein.
1086
1087         Call SPI giving clients a chance to override the default behavior.
1088         * WebView/WebImmediateActionController.mm:
1089         (-[WebImmediateActionController _updateImmediateActionItem]):
1090
1091         New SPI.
1092         * WebView/WebUIDelegatePrivate.h:
1093
1094 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1095
1096         Move the preview popover to WebImmediateActionController
1097         https://bugs.webkit.org/show_bug.cgi?id=139563
1098         <rdar://problem/19208291>
1099
1100         Reviewed by Beth Dakin.
1101
1102         * WebView/WebActionMenuController.mm:
1103         (-[WebActionMenuController _defaultMenuItemsForLink]):
1104         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1105         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1106         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1107         * WebView/WebImmediateActionController.h:
1108         * WebView/WebImmediateActionController.mm:
1109         (-[WebImmediateActionController webViewClosed]):
1110         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1111         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1112         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1113         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1114         (-[WebImmediateActionController _updateImmediateActionItem]):
1115         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1116         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1117         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1118         Move page preview popover related code to WebImmediateActionController.
1119
1120         * WebView/WebUIDelegatePrivate.h:
1121         Add a link preview type.
1122
1123         * WebView/WebView.mm:
1124         (-[WebView _commonInitializationWithFrameName:groupName:]):
1125         Pass the gesture recognizer to the WebImmediateActionController.
1126
1127 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1128
1129         Fix the build.
1130
1131         * WebView/WebImmediateActionController.h:
1132         * WebView/WebImmediateActionController.mm:
1133
1134 2014-12-11  Anders Carlsson  <andersca@apple.com>
1135
1136         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1137         https://bugs.webkit.org/show_bug.cgi?id=139547
1138
1139         Reviewed by Sam Weinig.
1140
1141         * WebView/WebView.mm:
1142         (+[WebView _handleMemoryWarning]):
1143
1144 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1145
1146         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1147         https://bugs.webkit.org/show_bug.cgi?id=139504
1148         rdar://problem/19034674
1149
1150         Reviewed by Enrica Casucci.
1151
1152         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1153
1154         * WebCoreSupport/WebEditorClient.h:
1155         * WebCoreSupport/WebEditorClient.mm:
1156         (WebEditorClient::discardedComposition):
1157
1158 2014-12-10  Anders Carlsson  <andersca@apple.com>
1159
1160         Get rid of the storage strategy
1161         https://bugs.webkit.org/show_bug.cgi?id=139519
1162
1163         Reviewed by Antti Koivisto.
1164
1165         * WebCoreSupport/WebPlatformStrategies.h:
1166         * WebCoreSupport/WebPlatformStrategies.mm:
1167         (WebPlatformStrategies::createStorageStrategy): Deleted.
1168
1169 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1170
1171         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1172         https://bugs.webkit.org/show_bug.cgi?id=139529
1173         <rdar://problem/19213620>
1174
1175         Reviewed by Beth Dakin.
1176
1177         * WebView/WebActionMenuController.mm:
1178         (-[WebActionMenuController _copySelection:]):
1179         (-[WebActionMenuController _paste:]):
1180         Use the copy: and paste: methods on WebView so that we traverse subviews
1181         when trying to respond, otherwise these actions don't work in subframes.
1182
1183 2014-12-10  Beth Dakin  <bdakin@apple.com>
1184
1185         WK1: Add initial support for immediate actions
1186         https://bugs.webkit.org/show_bug.cgi?id=139522
1187
1188         Reviewed by Dan Bernstein.
1189
1190         This basic implementation of the controller will use the delegate methods to 
1191         perform and cache a HitTest when relevant. Future patches will patch 
1192         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1193         immediate action that should be taken.
1194         * WebView/WebImmediateActionController.h: Added.
1195         * WebView/WebImmediateActionController.mm: Added.
1196         (-[WebImmediateActionController webViewClosed]):
1197         (-[WebImmediateActionController _clearImmediateActionState]):
1198         (-[WebImmediateActionController performHitTestAtPoint:]):
1199         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1200         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1201         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1202         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1203         (-[WebImmediateActionController _updateImmediateActionItem]):
1204
1205         New enum for immediate action types.
1206         * WebView/WebUIDelegatePrivate.h:
1207
1208         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1209         * WebView/WebView.mm:
1210         (-[WebView _commonInitializationWithFrameName:groupName:]):
1211         (-[WebView _close]):
1212         * WebView/WebViewData.h:
1213         * WebView/WebViewData.mm:
1214         (-[WebViewPrivate dealloc]):
1215
1216 2014-12-08  Anders Carlsson  <andersca@apple.com>
1217
1218         Use the new storage namespace provider in WebKit1
1219         https://bugs.webkit.org/show_bug.cgi?id=139425
1220
1221         Reviewed by Tim Horton.
1222
1223         * WebView/WebView.mm:
1224         (-[WebView _commonInitializationWithFrameName:groupName:]):
1225         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1226         Set the storage namespace provider from the web page group.
1227
1228 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1229
1230         Should have copy and paste items in all text menus
1231         https://bugs.webkit.org/show_bug.cgi?id=139510
1232         <rdar://problem/19198388>
1233
1234         Reviewed by Beth Dakin.
1235
1236         * WebView/WebActionMenuController.mm:
1237         (-[WebActionMenuController _defaultMenuItemsForText]):
1238         Add a disabled paste menu item into the read-only text menu.
1239
1240         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1241         Add a disabled copy menu item into the editable whitespace text menu.
1242
1243 2014-12-10  Anders Carlsson  <andersca@apple.com>
1244
1245         Add WebStorageNamespaceProvider::closeLocalStorage
1246         https://bugs.webkit.org/show_bug.cgi?id=139502
1247
1248         Reviewed by Tim Horton.
1249
1250         * WebView/WebView.mm:
1251         (+[WebView _applicationWillTerminate]):
1252         Call WebStorageNamespaceProvider::closeLocalStorage.
1253
1254 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1255
1256         Unreviewed, rolling out r177037.
1257         https://bugs.webkit.org/show_bug.cgi?id=139464
1258
1259         broke ~50 API tests (Requested by thorton on #webkit).
1260
1261         Reverted changeset:
1262
1263         "Use the new storage namespace provider in WebKit1"
1264         https://bugs.webkit.org/show_bug.cgi?id=139425
1265         http://trac.webkit.org/changeset/177037
1266
1267 2014-12-08  Anders Carlsson  <andersca@apple.com>
1268
1269         Use the new storage namespace provider in WebKit1
1270         https://bugs.webkit.org/show_bug.cgi?id=139425
1271
1272         Reviewed by Tim Horton.
1273
1274         * WebView/WebView.mm:
1275         (-[WebView _commonInitializationWithFrameName:groupName:]):
1276         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1277         Set the storage namespace provider from the web page group.
1278
1279 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1280
1281         Delete Node::boundingBox()
1282         https://bugs.webkit.org/show_bug.cgi?id=139333
1283
1284         Reviewed by Zalan Bujtas.
1285
1286         * WebView/WebActionMenuController.mm:
1287         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1288         RenderObject::absoluteBoundingBoxRect().
1289
1290 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1291
1292         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1293         https://bugs.webkit.org/show_bug.cgi?id=138843
1294         rdar://problem/18793695
1295
1296         Reviewed by Dan Bernstein.
1297
1298         * Panels/WebAuthenticationPanel.m:
1299         (-[WebAuthenticationPanel cancel:]):
1300         (-[WebAuthenticationPanel logIn:]):
1301         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1302         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1303         that only when using an old NSWindow API.
1304
1305 2014-12-08  Beth Dakin  <bdakin@apple.com>
1306
1307         Copy and Lookup menu items should be disabled when something is not copyable
1308         https://bugs.webkit.org/show_bug.cgi?id=139423
1309
1310         Reviewed by Tim Horton.
1311
1312         Disable both lookup and copy when a HitTestResult does not allow copy.
1313         * WebView/WebActionMenuController.mm:
1314
1315         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1316         disable state otherwise.
1317         * WebView/WebView.mm:
1318         (-[WebView _commonInitializationWithFrameName:groupName:]):
1319
1320 2014-12-08  Anders Carlsson  <andersca@apple.com>
1321
1322         Adding user content to a group should force that group to be created
1323         https://bugs.webkit.org/show_bug.cgi?id=139421
1324         rdar://problem/19180108
1325
1326         Reviewed by Sam Weinig.
1327
1328         * WebCoreSupport/WebViewGroup.h:
1329         Store the local storage database path in the group.
1330
1331         * WebCoreSupport/WebViewGroup.mm:
1332         (WebViewGroup::getOrCreate):
1333         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1334         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1335
1336         (WebViewGroup::WebViewGroup):
1337         Initialize the new member variable.
1338
1339         (WebViewGroup::storageNamespaceProvider):
1340         Create the namespace provider lazily.
1341
1342         * WebView/WebView.mm:
1343         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1344         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1345         Use getOrCreate instead of get.
1346
1347 2014-12-08  Anders Carlsson  <andersca@apple.com>
1348
1349         WebStorageNamespaceProvider should know about its local storage database path
1350         https://bugs.webkit.org/show_bug.cgi?id=139413
1351
1352         Reviewed by Andreas Kling.
1353
1354         * WebCoreSupport/WebViewGroup.h:
1355         * WebCoreSupport/WebViewGroup.mm:
1356         (WebViewGroup::getOrCreate):
1357         (WebViewGroup::WebViewGroup):
1358         * WebView/WebView.mm:
1359         (-[WebView _commonInitializationWithFrameName:groupName:]):
1360         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1361         (-[WebView setGroupName:]):
1362         (-[WebView groupName]): Deleted.
1363
1364 2014-12-08  Daniel Bates  <dabates@apple.com>
1365
1366         [iOS] Fix the WebKit build with the public SDK
1367
1368         Include header NSURLDownloadSPI.h.
1369
1370         * WebCoreSupport/WebFrameLoaderClient.mm:
1371
1372 2014-12-07  Dan Bernstein  <mitz@apple.com>
1373
1374         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1375         https://bugs.webkit.org/show_bug.cgi?id=139348
1376
1377         Reviewed by Anders Carlsson.
1378
1379         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1380         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1381         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1382         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1383         avoiding the ambiguity.
1384
1385         * WebView/WebActionMenuController.mm:
1386         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1387
1388 2014-12-06  Anders Carlsson  <andersca@apple.com>
1389
1390         Add a stubbed out version of WebStorageNamespaceProvider
1391         https://bugs.webkit.org/show_bug.cgi?id=139213
1392
1393         Reviewed by Sam Weinig.
1394
1395         * WebCoreSupport/WebViewGroup.h:
1396         (WebViewGroup::storageNamespaceProvider):
1397         * WebCoreSupport/WebViewGroup.mm:
1398         (WebViewGroup::getOrCreate):
1399         (WebViewGroup::WebViewGroup):
1400         Give WebViewGroup a storage namespace provider.
1401
1402 2014-12-06  Anders Carlsson  <andersca@apple.com>
1403
1404         Fix build with newer versions of clang.
1405         rdar://problem/18978687
1406
1407         Add missing overrides and missing casts.
1408
1409         * Storage/WebDatabaseManagerClient.h:
1410         * Storage/WebStorageTrackerClient.h:
1411         * WebCoreSupport/WebChromeClient.h:
1412         * WebCoreSupport/WebFrameLoaderClient.h:
1413         * WebCoreSupport/WebInspectorClient.h:
1414         * WebView/WebDataSource.mm:
1415         (-[WebDataSource _makeRepresentation]):
1416         * WebView/WebFrameView.mm:
1417         (-[WebFrameView _makeDocumentViewForDataSource:]):
1418
1419 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1420
1421         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1422         https://bugs.webkit.org/show_bug.cgi?id=139306
1423         <rdar://problem/19157955>
1424
1425         Reviewed by Beth Dakin.
1426
1427         * WebView/WebView.mm:
1428         (-[WebView _commonInitializationWithFrameName:groupName:]):
1429         (-[WebView _initWithFrame:frameName:groupName:]):
1430         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1431
1432 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1433
1434         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1435         <http://webkit.org/b/139286>
1436
1437         Reviewed by Daniel Bates.
1438
1439         * Configurations/FeatureDefines.xcconfig: Switch back to using
1440         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1441
1442 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1443
1444         Fix the 32-bit build.
1445
1446         * WebView/WebView.mm:
1447         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1448
1449 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1450
1451         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1452         https://bugs.webkit.org/show_bug.cgi?id=139252
1453         <rdar://problem/19140827>
1454
1455         Reviewed by Anders Carlsson.
1456
1457         * WebView/WebView.mm:
1458         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1459         Adjust to the WebCore changes.
1460
1461 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1462
1463         Implement action menus for tel: URLs
1464         https://bugs.webkit.org/show_bug.cgi?id=139240
1465         <rdar://problem/19115662>
1466
1467         Reviewed by Anders Carlsson.
1468
1469         * WebView/WebActionMenuController.mm:
1470         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1471         Make sure to use the newly created currentActionContext... everywhere.
1472
1473 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1474
1475         Implement action menus for tel: URLs
1476         https://bugs.webkit.org/show_bug.cgi?id=139240
1477         <rdar://problem/19115662>
1478
1479         Reviewed by Anders Carlsson.
1480
1481         * WebView/WebActionMenuController.mm:
1482         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1483         Make sure to use the newly created currentActionContext.
1484
1485 2014-12-03  Beth Dakin  <bdakin@apple.com>
1486
1487         <input> elements get whitespace action menu instead of editable text menu
1488         https://bugs.webkit.org/show_bug.cgi?id=139241
1489         -and corresponding-
1490         rdar://problem/19072083
1491
1492         Reviewed by Sam Weinig.
1493
1494         We should disallow shadow content in the hit test. This is the default and it is 
1495         how context menus behave. We originally wanted to text inside shadow content so 
1496         that we could find the text, but the new function I added to HitTestResult will 
1497         allow that.
1498         * WebView/WebActionMenuController.mm:
1499         (-[WebActionMenuController performHitTestAtPoint:]):
1500
1501         Adjust to the fact that we don’t hit test shadow content any more.
1502         (-[WebActionMenuController focusAndSelectHitTestResult]):
1503
1504         Offer the text menus for text inside form controls.
1505         (-[WebActionMenuController _defaultMenuItems]):
1506
1507 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1508
1509         Implement action menus for tel: URLs
1510         https://bugs.webkit.org/show_bug.cgi?id=139240
1511         <rdar://problem/19115662>
1512
1513         Reviewed by Anders Carlsson.
1514
1515         * WebView/WebActionMenuController.mm:
1516         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1517         Rename this function as it will work for both mailto and tel URLs.
1518         Adjust it to use contextForView:.
1519
1520         (-[WebActionMenuController webView:willHandleMouseDown:]):
1521         (-[WebActionMenuController prepareForMenu:withEvent:]):
1522         (-[WebActionMenuController didCloseMenu:withEvent:]):
1523         (-[WebActionMenuController _defaultMenuItems]):
1524         Don't check the menu type when going to interact with _currentActionContext.
1525         We'll only have a _currentActionContext if we have a data detected item,
1526         and there are multiple menu types that end up using DDActionContext.
1527
1528         * WebView/WebUIDelegatePrivate.h:
1529         Add a new type.
1530
1531 2014-12-03  Anders Carlsson  <andersca@apple.com>
1532
1533         Set a visited link store when creating a simple WebView
1534         https://bugs.webkit.org/show_bug.cgi?id=139234
1535         <rdar://problem/19132978>
1536
1537         Reviewed by Sam Weinig.
1538
1539         * WebView/WebView.mm:
1540         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1541
1542 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1543
1544         Fix the build.
1545
1546         * WebCoreSupport/WebFrameLoaderClient.mm:
1547
1548 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1549
1550         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1551         https://bugs.webkit.org/show_bug.cgi?id=139149
1552
1553         Reviewed by Anders Carlsson.
1554
1555         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1556         We used to delete caches from disk, but they were still active in memory. Now we also
1557         obsolete them in memory, so documents that use a cache still work, but new ones don't
1558         pick one up.
1559
1560         * WebCoreSupport/WebApplicationCache.mm:
1561         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1562         need to delete in-momry caches too. Keep existing behavior.
1563         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1564         that properly deletes caches.
1565
1566 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1567
1568         Remove a SnowLeopard-era quirk for QuickLook
1569         https://bugs.webkit.org/show_bug.cgi?id=139208
1570         <rdar://problem/19121822>
1571
1572         Reviewed by Alexey Proskuryakov.
1573
1574         * WebCoreSupport/WebFrameLoaderClient.h:
1575         * WebCoreSupport/WebFrameLoaderClient.mm:
1576
1577 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1578
1579         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1580         https://bugs.webkit.org/show_bug.cgi?id=139204
1581
1582         Reviewed by Anders Carlsson.
1583
1584         * WebView/WebView.mm:
1585         (-[WebView _commonInitializationWithFrameName:groupName:]):
1586         (-[WebView _showDictionaryLookupPopup:]):
1587         * WebView/WebViewData.h:
1588         Work around this by delaying the softlinking (and setting up the notification
1589         observer) until we actually need it. There's still an underlying bug, but
1590         this will fix the test.
1591
1592 2014-12-02  Beth Dakin  <bdakin@apple.com>
1593
1594         Yet another build fix.
1595
1596         * WebView/WebActionMenuController.mm:
1597         (-[WebActionMenuController _defaultMenuItemsForLink]):
1598
1599 2014-12-02  Beth Dakin  <bdakin@apple.com>
1600
1601         Build fix.
1602
1603         * WebView/WebActionMenuController.mm:
1604         (-[WebActionMenuController _defaultMenuItemsForLink]):
1605
1606 2014-12-02  Beth Dakin  <bdakin@apple.com>
1607
1608         More build fixing.
1609
1610         * WebView/WebActionMenuController.mm:
1611         (-[WebActionMenuController _defaultMenuItemsForLink]):
1612
1613 2014-12-02  Beth Dakin  <bdakin@apple.com>
1614
1615         Should use standardQuickLookMenuItem for apps that don't implement customizations
1616         https://bugs.webkit.org/show_bug.cgi?id=139193
1617         -and corresponding-
1618         rdar://problem/18944696
1619
1620         Reviewed by Anders Carlsson.
1621
1622         Use [NSMenuItem standardQuickLookMenuItem].
1623         * WebView/WebActionMenuController.mm:
1624         (-[WebActionMenuController _defaultMenuItemsForLink]):
1625
1626         Delegate methods to set up the standardQuickLookMenuItem.
1627         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
1628         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
1629         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
1630
1631         Remove all of the old QLPreviewBubble code.
1632         (-[WebActionMenuController _createActionMenuItemForTag:]):
1633         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
1634
1635 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1636
1637         Fix the build.
1638
1639         * WebView/WebViewData.h:
1640
1641 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1642
1643         Implement Lookup transition from selection for Legacy WebKit
1644         https://bugs.webkit.org/show_bug.cgi?id=139180
1645         <rdar://problem/19067172>
1646
1647         Reviewed by Beth Dakin.
1648
1649         * WebView/DictionaryPopupInfo.h: Added.
1650         Split DictionaryPopupInfo out into its own file.
1651
1652         * WebView/WebActionMenuController.mm:
1653         (-[WebActionMenuController _lookupText:]):
1654         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
1655
1656         (performDictionaryLookupForSelection):
1657         (performDictionaryLookupForRange):
1658         Plumb the transition style through these helpers.
1659         Create a TextIndicator from the selection range.
1660
1661         * WebView/WebHTMLView.mm:
1662         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1663         Make use of TextIndicator (and DictionaryPopupInfo, and the new
1664         _showDictionaryLookupPopup on WebView) to add a transition from blue
1665         when performing Lookup from the context menu.
1666
1667         (-[WebHTMLView quickLookWithEvent:]):
1668         Remove our TextIndicator whenever a normal three-finger-tap event
1669         comes through, as it will have its own indication.
1670
1671         * WebView/WebView.mm:
1672         (-[WebView _commonInitializationWithFrameName:groupName:]):
1673         (-[WebView _dictionaryLookupPopoverWillClose:]):
1674         Register for the LUNotificationPopoverWillClose notification and remove
1675         our TextIndicator when it is called, just like in WebKit2.
1676         Deregistration is already handled in _close.
1677
1678         (-[WebView _showDictionaryLookupPopup:]):
1679         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
1680         if the relevant API is available.
1681
1682         * WebView/WebViewInternal.h:
1683
1684 2014-12-02  Anders Carlsson  <andersca@apple.com>
1685
1686         Remove visited link handling from PageGroup
1687         https://bugs.webkit.org/show_bug.cgi?id=139185
1688
1689         Reviewed by Sam Weinig.
1690
1691         * History/WebHistory.mm:
1692         (-[WebHistoryPrivate removeItemForURLString:]):
1693         (-[WebHistoryPrivate removeAllItems]):
1694         (+[WebHistory setOptionalSharedHistory:]):
1695         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1696         (+[WebHistory _removeAllVisitedLinks]):
1697         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
1698         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
1699         * History/WebHistoryInternal.h:
1700         * WebCoreSupport/WebChromeClient.h:
1701         * WebCoreSupport/WebChromeClient.mm:
1702         (WebChromeClient::populateVisitedLinks): Deleted.
1703         * WebView/WebView.mm:
1704         (-[WebView addVisitedLinks:]):
1705         (-[WebView removeVisitedLink:]):
1706
1707 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1708
1709         Try to fix the Mac build.
1710
1711         * WebView/WebView.mm:
1712         (-[WebView _commonInitializationWithFrameName:groupName:]):
1713         (-[WebView _close]):
1714
1715 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
1716
1717         Fix the iOS build.
1718
1719         * WebView/WebActionMenuController.h:
1720         * WebView/WebActionMenuController.mm:
1721         * WebView/WebHTMLView.mm:
1722         (-[WebHTMLView scrollWheel:scrollWheel:]):
1723         (-[WebHTMLView mouseDown:mouseDown:]):
1724         * WebView/WebView.mm:
1725         * WebView/WebViewData.h:
1726         * WebView/WebViewData.mm:
1727         (-[WebViewPrivate dealloc]):
1728         * WebView/WebViewInternal.h:
1729
1730 2014-12-01  Tim Horton  <timothy_horton@apple.com>
1731
1732         Implement yellow highlight for WebKit1 data detectors
1733         https://bugs.webkit.org/show_bug.cgi?id=138956
1734         <rdar://problem/18992185>
1735
1736         Reviewed by Beth Dakin.
1737
1738         * WebView/WebActionMenuController.h:
1739         * WebView/WebActionMenuController.mm:
1740         (-[WebActionMenuController webView:willHandleMouseDown:]):
1741         (-[WebActionMenuController webView:didHandleScrollWheel:]):
1742         (-[WebActionMenuController prepareForMenu:withEvent:]):
1743         (-[WebActionMenuController didCloseMenu:withEvent:]):
1744         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
1745         (-[WebActionMenuController _showTextIndicator]):
1746         (-[WebActionMenuController _hideTextIndicator]):
1747         (-[WebActionMenuController _dismissActionMenuPopovers]):
1748         Copy the WebKit2 WKActionMenuController TextIndicator implementation
1749         into WebActionMenuController. The only significant difference is
1750         that we build the TextIndicator right at menu construction time
1751         instead of in the Web process.
1752
1753         * WebView/WebHTMLView.mm:
1754         (-[WebHTMLView scrollWheel:]):
1755         Let the WebActionMenuController know that we're handling a scroll.
1756
1757         (-[WebHTMLView mouseDown:]):
1758         Let the WebActionMenuController know that we're handling a mouseDown.
1759
1760         * WebView/WebView.mm:
1761         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1762         (-[WebView _clearTextIndicator]):
1763         (-[WebView _actionMenuController]):
1764         (-[WebView _convertRectFromRootView:]): Deleted.
1765         * WebView/WebViewData.h:
1766         * WebView/WebViewData.mm:
1767         * WebView/WebViewInternal.h:
1768         Keep a TextIndicatorWindow on WebView, just like WKView does.
1769         Expose the WebActionMenuController on WebView (internally).
1770
1771 2014-12-01  Anders Carlsson  <andersca@apple.com>
1772
1773         Remove old site specific quirks code that was added in 2009
1774         https://bugs.webkit.org/show_bug.cgi?id=139141
1775
1776         Reviewed by Antti Koivisto.
1777
1778         * WebCoreSupport/WebFrameNetworkingContext.h:
1779         * WebCoreSupport/WebFrameNetworkingContext.mm:
1780         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
1781
1782 2014-11-30  Anders Carlsson  <andersca@apple.com>
1783
1784         Fix a test failure.
1785
1786         * History/WebHistory.mm:
1787         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
1788         Call through to the visited link store.
1789
1790         (+[WebHistory _removeAllVisitedLinks]):
1791         Ditto.
1792
1793         * WebCoreSupport/WebVisitedLinkStore.mm:
1794         (WebVisitedLinkStore::isLinkVisited):
1795         Make sure to populate visited links.
1796
1797 2014-11-30  Anders Carlsson  <andersca@apple.com>
1798
1799         Switch over to the visited link store from the WebViewGroup
1800         https://bugs.webkit.org/show_bug.cgi?id=139112
1801
1802         Reviewed by Sam Weinig.
1803
1804         * WebView/WebView.mm:
1805         (-[WebView _commonInitializationWithFrameName:groupName:]):
1806         (-[WebView setGroupName:]):
1807
1808 2014-11-30  Anders Carlsson  <andersca@apple.com>
1809
1810         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
1811         https://bugs.webkit.org/show_bug.cgi?id=139111
1812
1813         Reviewed by Sam Weinig.
1814
1815         * WebCoreSupport/WebVisitedLinkStore.h:
1816         * WebCoreSupport/WebVisitedLinkStore.mm:
1817         (WebVisitedLinkStore::removeVisitedLink):
1818         * WebView/WebView.mm:
1819         (-[WebView removeVisitedLink:]):
1820
1821 2014-11-29  Anders Carlsson  <andersca@apple.com>
1822
1823         Populate visited links
1824         https://bugs.webkit.org/show_bug.cgi?id=139101
1825
1826         Reviewed by Sam Weinig.
1827
1828         * History/WebHistory.mm:
1829         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
1830         Helper function that adds all visited link to the given store.
1831
1832         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
1833         Call the private method.
1834
1835         * History/WebHistoryInternal.h:
1836         * WebCoreSupport/WebVisitedLinkStore.h:
1837         Add new members.
1838
1839         * WebCoreSupport/WebVisitedLinkStore.mm:
1840         (WebVisitedLinkStore::addVisitedLink):
1841         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
1842
1843         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1844         Implement this. First try the delegate, then try the shared history.
1845
1846         (WebVisitedLinkStore::addVisitedLinkHash):
1847         Factor code that adds the link to the hash table into a separate function.
1848
1849         * WebView/WebView.mm:
1850         (-[WebView addVisitedLinks:]):
1851         Add the visited links to the store.
1852
1853 2014-11-29  Anders Carlsson  <andersca@apple.com>
1854
1855         More work on the legacy WebKit visited link store
1856         https://bugs.webkit.org/show_bug.cgi?id=139100
1857
1858         Reviewed by Sam Weinig.
1859
1860         * History/WebHistory.mm:
1861         (+[WebHistory setOptionalSharedHistory:]):
1862         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
1863
1864         * WebCoreSupport/WebVisitedLinkStore.h:
1865         * WebCoreSupport/WebVisitedLinkStore.mm:
1866         (visitedLinkStores):
1867         (WebVisitedLinkStore::WebVisitedLinkStore):
1868         (WebVisitedLinkStore::~WebVisitedLinkStore):
1869         Keep track of live visited link stores.
1870
1871         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
1872         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
1873
1874         (WebVisitedLinkStore::removeAllVisitedLinks):
1875         Iterate over all live link stores and remove their links.
1876
1877         (WebVisitedLinkStore::isLinkVisited):
1878         Populate visited links and check if our hash table contains the link.
1879
1880         (WebVisitedLinkStore::addVisitedLink):
1881         Add the link hash to the table.
1882
1883         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
1884         Add stub.
1885
1886         (WebVisitedLinkStore::removeVisitedLinkHashes):
1887         Clear out the hash table.
1888
1889 2014-11-27  Anders Carlsson  <andersca@apple.com>
1890
1891         Add a stubbed out WebVisitedLinkStore to WebViewGroup
1892         https://bugs.webkit.org/show_bug.cgi?id=139066
1893
1894         Reviewed by Antti Koivisto.
1895
1896         * WebCoreSupport/WebViewGroup.h:
1897         (WebViewGroup::visitedLinkStore):
1898         * WebCoreSupport/WebViewGroup.mm:
1899         (WebViewGroup::WebViewGroup):
1900         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1901         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
1902         (WebVisitedLinkStore::create):
1903         (WebVisitedLinkStore::WebVisitedLinkStore):
1904         (WebVisitedLinkStore::~WebVisitedLinkStore):
1905         (WebVisitedLinkStore::isLinkVisited):
1906         (WebVisitedLinkStore::addVisitedLink):
1907
1908 2014-11-25  Anders Carlsson  <andersca@apple.com>
1909
1910         Remove user content handling from PageGroup
1911         https://bugs.webkit.org/show_bug.cgi?id=139051
1912
1913         Reviewed by Antti Koivisto.
1914
1915         Use the user content controller in the web view group.
1916
1917         * WebView/WebView.mm:
1918         (-[WebView _injectOutlookQuirksScript]):
1919
1920 2014-11-25  Anders Carlsson  <andersca@apple.com>
1921
1922         Add a user content controller to WebViewGroup and use it for user content
1923         https://bugs.webkit.org/show_bug.cgi?id=139043
1924
1925         Reviewed by Antti Koivisto.
1926
1927         This is another tiny step towards getting rid of user content handling inside PageGroup.
1928
1929         * WebCoreSupport/WebViewGroup.h:
1930         (WebViewGroup::userContentController):
1931         Add a UserContentController member and getter.
1932
1933         * WebCoreSupport/WebViewGroup.mm:
1934         (WebViewGroup::get):
1935         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
1936
1937         (WebViewGroup::WebViewGroup):
1938         Create a user content controller.
1939
1940         * WebView/WebView.mm:
1941         (-[WebView _commonInitializationWithFrameName:groupName:]):
1942         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
1943         set its user content controller in the PageConfiguration.
1944
1945         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1946         Ditto.
1947
1948         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1949         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1950         (+[WebView _removeUserScriptFromGroup:world:url:]):
1951         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
1952         (+[WebView _removeUserScriptsFromGroup:world:]):
1953         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
1954         (+[WebView _removeAllUserContentFromGroup:]):
1955         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
1956
1957         (-[WebView setGroupName:]):
1958         Set the user content controller to the new WebViewGroup's user content controller.
1959
1960 2014-11-21  Jer Noble  <jer.noble@apple.com>
1961
1962         Support multiple signatures of diagnostic logging.
1963         https://bugs.webkit.org/show_bug.cgi?id=138690
1964
1965         Reviewed by Anders Carlsson.
1966
1967         Page::PageClients has been renamed PageConfiguration.
1968
1969         * WebView/WebView.mm:
1970         (-[WebView _commonInitializationWithFrameName:groupName:]):
1971         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1972
1973 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1974
1975         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1976         https://bugs.webkit.org/show_bug.cgi?id=138981
1977
1978         Reviewed by Simon Fraser.
1979
1980         * WebView/WebPreferenceKeysPrivate.h:
1981         * WebView/WebPreferences.mm:
1982         (+[WebPreferences initialize]):
1983         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
1984         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
1985         * WebView/WebPreferencesPrivate.h:
1986         * WebView/WebView.mm:
1987         (-[WebView _preferencesChanged:]):
1988
1989 2014-11-21  Tim Horton  <timothy_horton@apple.com>
1990
1991         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
1992         ​https://bugs.webkit.org/show_bug.cgi?id=138960
1993         <rdar://problem/19056715>
1994
1995         Reviewed by Anders Carlsson.
1996
1997         * WebView/WebActionMenuController.mm:
1998         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
1999         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2000         Use DataDetectors SPI instead of an explicit blacklist.
2001
2002 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2003
2004         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2005         https://bugs.webkit.org/show_bug.cgi?id=138960
2006         <rdar://problem/19056715>
2007
2008         Reviewed by Beth Dakin.
2009
2010         * WebView/WebActionMenuController.mm:
2011         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2012         Blacklist contact results, because they don't have useful menus. If we
2013         bail before setting up _currentActionContext, we'll still allow fallthrough
2014         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2015
2016         This doesn't break the case that r176351 was intended to fix,
2017         because in that case we were detecting e.g. addresses.
2018
2019 2014-11-21  Anders Carlsson  <andersca@apple.com>
2020
2021         Remove the Timer parameters from timer callbacks
2022         https://bugs.webkit.org/show_bug.cgi?id=138974
2023
2024         Reviewed by Antti Koivisto.
2025
2026         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2027         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2028         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2029         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2030         * Plugins/WebNetscapePluginStream.h:
2031         * Plugins/WebNetscapePluginStream.mm:
2032         (WebNetscapePluginStream::WebNetscapePluginStream):
2033         (WebNetscapePluginStream::deliverDataTimerFired):
2034
2035 2014-11-21  Anders Carlsson  <andersca@apple.com>
2036
2037         Make memoryCache() return a reference
2038         https://bugs.webkit.org/show_bug.cgi?id=138939
2039
2040         Reviewed by Antti Koivisto.
2041
2042         * Misc/WebCache.mm:
2043         (+[WebCache statistics]):
2044         (+[WebCache emptyInMemoryResources]):
2045         (+[WebCache sizeOfDeadResources:]):
2046         (+[WebCache addImageToCache:forURL:forFrame:]):
2047         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2048         (+[WebCache imageForURL:]):
2049         (+[WebCache setDisabled:]):
2050         (+[WebCache isDisabled]):
2051         * WebView/WebView.mm:
2052         (+[WebView _setCacheModel:]):
2053
2054 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2055
2056         Remove the remaining vestiges of minimal-ui
2057         https://bugs.webkit.org/show_bug.cgi?id=138890
2058
2059         Reviewed by Sam Weinig.
2060
2061         * History/WebHistoryItem.mm:
2062         * History/WebHistoryItemPrivate.h:
2063
2064 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2065
2066         Cancel DataDetectors menu earlier if we know it can't be presented
2067         https://bugs.webkit.org/show_bug.cgi?id=138922
2068         <rdar://problem/18950441>
2069
2070         Reviewed by Beth Dakin.
2071
2072         * WebView/WebActionMenuController.mm:
2073         (-[WebActionMenuController prepareForMenu:withEvent:]):
2074         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2075         and use a bigger hammer (removeAllItems).
2076
2077         (-[WebActionMenuController willOpenMenu:withEvent:]):
2078         If we end up with a menu with no items, don't change selection or anything.
2079
2080 2014-11-20  Beth Dakin  <bdakin@apple.com>
2081
2082         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2083         https://bugs.webkit.org/show_bug.cgi?id=138568
2084         -and corresponding-
2085         rdar://problem/18904600
2086
2087         Reviewed by Tim Horton.
2088
2089         Skip images for lookup.
2090         * WebView/WebActionMenuController.mm:
2091         (performDictionaryLookupForRange):
2092
2093 2014-11-19  Beth Dakin  <bdakin@apple.com>
2094
2095         Invoking an action menu on a selection should result in the text menu
2096         https://bugs.webkit.org/show_bug.cgi?id=138892
2097         -and corresponding-
2098         rdar://problem/18996776
2099
2100         Reviewed by Tim Horton.
2101
2102         * WebView/WebActionMenuController.mm:
2103         (-[WebActionMenuController _defaultMenuItems]):
2104
2105 2014-11-19  Beth Dakin  <bdakin@apple.com>
2106
2107         Data detected results with no menu items should not fall through to regular text 
2108         action menus
2109         https://bugs.webkit.org/show_bug.cgi?id=138887
2110         -and corresponding-
2111         rdar://problem/18971616
2112
2113         Reviewed by Tim Horton.
2114
2115         * WebView/WebActionMenuController.mm:
2116         (-[WebActionMenuController _defaultMenuItems]):
2117
2118 2014-11-19  Daniel Bates  <dabates@apple.com>
2119
2120         [iOS] Make WebKit build with public iOS SDK
2121         https://bugs.webkit.org/show_bug.cgi?id=136863
2122
2123         Reviewed by David Kilzer.
2124
2125         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2126         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2127         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2128         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2129         may be used by Apple internal clients that do not include wtf/Platform.h.
2130         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2131         private Foundation headers directly.
2132         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2133         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2134         instead of including private CFNetwork headers directly. Also fixed up style and
2135         ordering of header include directives.
2136         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2137         CFNetwork headers directly. Also sort the #import directives.
2138         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2139         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2140
2141 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2142
2143         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2144         <http://webkit.org/b/138813>
2145
2146         Reviewed by Mark Rowe.
2147
2148         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2149         selectors.
2150
2151 2014-11-18  Chris Dumez  <cdumez@apple.com>
2152
2153         Add a setting to toggle DOMTimer throttling support
2154         https://bugs.webkit.org/show_bug.cgi?id=138844
2155         <rdar://problem/19020874>
2156
2157         Reviewed by Andreas Kling.
2158
2159         Add a setting to disable DOM timers throttling, in order to help
2160         developers determine if a specific issue is caused by timer
2161         throttling.
2162
2163         * WebView/WebPreferenceKeysPrivate.h:
2164         * WebView/WebPreferences.mm:
2165         (+[WebPreferences initialize]):
2166         (-[WebPreferences domTimersThrottlingEnabled]):
2167         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2168         * WebView/WebPreferencesPrivate.h:
2169         * WebView/WebView.mm:
2170         (-[WebView _preferencesChanged:]):
2171
2172 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2173
2174         Avoid re-encoding action menu image data
2175         https://bugs.webkit.org/show_bug.cgi?id=138817
2176         <rdar://problem/18840382>
2177
2178         Reviewed by Anders Carlsson.
2179
2180         * WebView/WebActionMenuController.mm:
2181         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2182         (-[WebActionMenuController _addImageToPhotos:]):
2183         Build a temporary filename from a UUID and the image's desired extension.
2184         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2185         Build an image menu only if we have an image, URL, data, and extension.
2186
2187 2014-11-18  Daniel Bates  <dabates@apple.com>
2188
2189         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2190         SPI are not available in public SDK
2191         https://bugs.webkit.org/show_bug.cgi?id=138802
2192
2193         Reviewed by David Kilzer.
2194
2195         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2196         libdispatch and MobileGestalt headers directly.
2197
2198         * WebView/WebView.mm:
2199
2200 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2201
2202         Remove calls to deprecated NSMenu methods
2203         https://bugs.webkit.org/show_bug.cgi?id=138808.
2204
2205         Reviewed by Anders Carlsson.
2206
2207         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2208
2209         * WebCoreSupport/PopupMenuMac.mm:
2210         (PopupMenuMac::populate):
2211
2212 2014-11-17  Daniel Bates  <dabates@apple.com>
2213
2214         Unreviewed, rolling out r176232.
2215
2216         Broke the Mac build. Will investigate offline.
2217
2218         Reverted changeset:
2219
2220         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2221         MobileGestalt"
2222         https://bugs.webkit.org/show_bug.cgi?id=138802
2223         http://trac.webkit.org/changeset/176232
2224
2225 2014-11-17  Daniel Bates  <dabates@apple.com>
2226
2227         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2228         SPI are not available in public SDK
2229         https://bugs.webkit.org/show_bug.cgi?id=138802
2230
2231         Reviewed by David Kilzer.
2232
2233         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2234         libdispatch and MobileGestalt headers directly.
2235
2236         * WebView/WebView.mm:
2237
2238 2014-11-17  Beth Dakin  <bdakin@apple.com>
2239
2240         Whitespace action menus should focus the HitTestResult and create an insertion 
2241         point
2242         https://bugs.webkit.org/show_bug.cgi?id=138786
2243         -and corresponding-
2244         rdar://problem/18944893
2245
2246         Reviewed by Tim Horton.
2247
2248         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2249         the selection based on the HitTest location.
2250
2251         * WebView/WebActionMenuController.mm:
2252         (-[WebActionMenuController isMenuForTextContent]):
2253         (-[WebActionMenuController focusAndSelectHitTestResult]):
2254         (-[WebActionMenuController willOpenMenu:withEvent:]):
2255
2256 2014-11-17  Daniel Bates  <dabates@apple.com>
2257
2258         [iOS] QuartzCore SPI not available in public SDK
2259         https://bugs.webkit.org/show_bug.cgi?id=138751
2260
2261         Reviewed by David Kilzer.
2262
2263         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2264
2265         * WebInspector/WebNodeHighlight.mm:
2266         * WebView/WebIndicateLayer.mm:
2267
2268 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2269
2270         [iOS] allow host application to opt-out of alternate fullscreen
2271         https://bugs.webkit.org/show_bug.cgi?id=138787
2272
2273         Reviewed by Darin Adler.
2274
2275         * WebView/WebPreferenceKeysPrivate.h:
2276         * WebView/WebPreferences.mm:
2277         (+[WebPreferences initialize]):
2278         (-[WebPreferences allowsAlternateFullscreen]):
2279         (-[WebPreferences setAllowsAlternateFullscreen:]):
2280         * WebView/WebPreferencesPrivate.h:
2281         * WebView/WebView.mm:
2282         (-[WebView _preferencesChanged:]):
2283
2284 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2285
2286         Use TextIndicator instead of the built in Lookup highlight
2287         https://bugs.webkit.org/show_bug.cgi?id=138775
2288         <rdar://problem/18953982>
2289
2290         Reviewed by Anders Carlsson.
2291
2292         * WebCoreSupport/WebSystemInterface.mm:
2293         (InitWebCoreSystemInterface):
2294         Remove a WKSI import.
2295
2296         * WebView/WebActionMenuController.mm:
2297         (-[WebActionMenuController _lookupText:]):
2298         (-[WebActionMenuController _createActionMenuItemForTag:]):
2299         Make use of the new Lookup SPI header.
2300         Disable the Lookup item if lookup is not available.
2301
2302 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2303
2304         Implement data detectors and mailto action menus for WebKit1
2305         https://bugs.webkit.org/show_bug.cgi?id=138765
2306         <rdar://problem/18877535>
2307
2308         Reviewed by Beth Dakin.
2309
2310         * WebView/WebActionMenuController.h:
2311         * WebView/WebActionMenuController.mm:
2312         (-[WebActionMenuController willOpenMenu:withEvent:]):
2313         Tell DataDetectors that the menu is going to open.
2314         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2315
2316         (-[WebActionMenuController didCloseMenu:withEvent:]):
2317         Tell DataDetectors that the menu closed.
2318
2319         (-[WebActionMenuController _defaultMenuItemsForLink]):
2320         Move these checks out of _defaultMenuItemsForLink, because we expect this
2321         to always return a complete link menu.
2322
2323         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2324         Implement. More or less copied from WebKit2.
2325
2326         (-[WebActionMenuController _selectDataDetectedText]):
2327         Select the stashed range.
2328
2329         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2330         Implement. More or less copied from WebKit2.
2331         The yellow highlight isn't hooked up yet.
2332         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2333
2334         (-[WebActionMenuController _selectLookupText]):
2335         Remove an unnecessary return.
2336
2337         (-[WebActionMenuController _defaultMenuItems]):
2338         Call into the two new menu types.
2339
2340         * WebView/WebUIDelegatePrivate.h:
2341
2342 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2343
2344         Get rid of WebFontCache
2345         https://bugs.webkit.org/show_bug.cgi?id=134752
2346
2347         Reviewed by Dave Hyatt.
2348
2349         * WebView/WebHTMLView.mm:
2350
2351 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2352
2353         Update some artwork for the legacy WebKit action menu
2354         https://bugs.webkit.org/show_bug.cgi?id=138758
2355         <rdar://problem/18989840>
2356
2357         * WebView/WebActionMenuController.mm:
2358         (webKitBundleImageNamed): Deleted.
2359         Fix the build.
2360
2361 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2362
2363         Update some artwork for the legacy WebKit action menu
2364         https://bugs.webkit.org/show_bug.cgi?id=138758
2365         <rdar://problem/18989840>
2366
2367         Reviewed by Simon Fraser.
2368
2369         * WebView/WebActionMenuController.mm:
2370         (-[WebActionMenuController _createActionMenuItemForTag:]):
2371
2372 2014-11-14  Daniel Bates  <dabates@apple.com>
2373
2374         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2375         https://bugs.webkit.org/show_bug.cgi?id=138742
2376
2377         Reviewed by Pratik Solanki.
2378
2379         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2380
2381         * WebCoreSupport/WebFrameLoaderClient.mm:
2382
2383 2014-11-14  Beth Dakin  <bdakin@apple.com>
2384
2385         WK1: Webpage preview can come up in wrong location
2386         https://bugs.webkit.org/show_bug.cgi?id=138747
2387         -and corresponding-
2388         rdar://problem/18979004
2389
2390         Reviewed by Tim Horton.
2391
2392         Converting to window twice is bad.
2393         * WebView/WebActionMenuController.mm:
2394         (elementBoundingBoxInWindowCoordinatesFromNode):
2395         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2396         (elementBoundingBoxFromNode): Deleted.
2397
2398 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2399
2400         Move FontMac and FontCacheMac off of WKSI
2401         https://bugs.webkit.org/show_bug.cgi?id=138633
2402
2403         Reviewed by Simon Fraser.
2404
2405         * WebCoreSupport/WebSystemInterface.mm:
2406         (InitWebCoreSystemInterface):
2407         * WebKit.order:
2408
2409 2014-11-13  Beth Dakin  <bdakin@apple.com>
2410
2411         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2412         https://bugs.webkit.org/show_bug.cgi?id=138716
2413         -and corresponding-
2414         rdar://problem/18977222
2415
2416         Reviewed by Tim Horton.
2417
2418         It’s not necessary to use the WebElementDictionary for so many things now that we 
2419         are caching the HitTestResult. We should just use the HitTestResult.
2420
2421         * WebView/WebActionMenuController.mm:
2422         (-[WebActionMenuController prepareForMenu:withEvent:]):
2423         (-[WebActionMenuController _openURLFromActionMenu:]):
2424         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2425         (elementBoundingBoxFromNode):
2426         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2427         (-[WebActionMenuController _defaultMenuItemsForLink]):
2428         (-[WebActionMenuController _defaultMenuItemsForImage]):
2429         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2430         (-[WebActionMenuController _defaultMenuItemsForText]):
2431         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2432         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2433         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2434         (-[WebActionMenuController _createActionMenuItemForTag:]):
2435         (-[WebActionMenuController _defaultMenuItems]):
2436         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2437         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2438         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2439         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2440         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2441         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2442         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2443         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2444         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2445         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2446
2447 2014-11-13  Daniel Bates  <dabates@apple.com>
2448
2449         [iOS] NSGeometry data types are not available in the public SDK
2450         https://bugs.webkit.org/show_bug.cgi?id=137536
2451
2452         Reviewed by David Kilzer.
2453
2454         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2455         private header.
2456
2457         * DOM/WebDOMOperationsPrivate.h:
2458
2459 2014-11-13  Beth Dakin  <bdakin@apple.com>
2460
2461         WK1: Support default actions for video
2462         https://bugs.webkit.org/show_bug.cgi?id=138713
2463         -and corresponding-
2464         rdar://problem/18877520
2465
2466         Reviewed by Tim Horton.
2467
2468         Call setToNonShadowAncestor() for media HitTestResults.
2469         * WebView/WebActionMenuController.mm:
2470         (-[WebActionMenuController performHitTestAtPoint:]):
2471
2472         Default items and actions.
2473         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2474         (-[WebActionMenuController _copyVideoURL:]):
2475         (-[WebActionMenuController _saveVideoToDownloads:]):
2476         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2477         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2478         * WebView/WebUIDelegatePrivate.h:
2479
2480 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2481
2482         WK1: Update icon for Add to Reading List
2483         https://bugs.webkit.org/show_bug.cgi?id=138710
2484         <rdar://problem/18975774>
2485
2486         Reviewed by Beth Dakin.
2487
2488         * WebView/WebActionMenuController.mm:
2489         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2490         Use the right icon, matching WebKit2.
2491
2492 2014-11-12  Beth Dakin  <bdakin@apple.com>
2493
2494         WK1: Support default actions for images
2495         https://bugs.webkit.org/show_bug.cgi?id=138668
2496         -and corresponding-
2497         rdar://problem/18785434
2498
2499         Reviewed by Tim Horton.
2500
2501         * WebView/WebActionMenuController.h:
2502         * WebView/WebActionMenuController.mm:
2503         (-[WebActionMenuController didCloseMenu:withEvent:]):
2504         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2505         (-[WebActionMenuController _copyImage:]):
2506         (temporaryPhotosDirectoryPath):
2507         (pathToPhotoOnDisk):
2508         (-[WebActionMenuController _canAddMediaToPhotos]):
2509         (-[WebActionMenuController _addImageToPhotos:]):
2510         (-[WebActionMenuController _saveImageToDownloads:]):
2511         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2512         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2513         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2514         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2515         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2516         * WebView/WebUIDelegatePrivate.h:
2517
2518 2014-11-11  Beth Dakin  <bdakin@apple.com>
2519
2520         Action menu hit testing is not working properly with all WK1 apps
2521         https://bugs.webkit.org/show_bug.cgi?id=138643
2522         -and corresponding-
2523         rdar://problem/18949376
2524
2525         Reviewed by Tim Horton.
2526
2527         * WebView/WebActionMenuController.mm:
2528         (-[WebActionMenuController prepareForMenu:withEvent:]):
2529         (-[WebActionMenuController _lookupText:]):
2530
2531 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2532
2533         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2534         https://bugs.webkit.org/show_bug.cgi?id=138623
2535
2536         Reviewed by Geoff Garen.
2537
2538         * WebCoreSupport/WebSystemInterface.mm:
2539         (InitWebCoreSystemInterface):
2540         * WebKit.order:
2541
2542 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2543
2544         Localize strings for action menus
2545         https://bugs.webkit.org/show_bug.cgi?id=138591
2546         <rdar://problem/18815343>
2547
2548         Reviewed by Dan Bates.
2549
2550         * WebView/WebActionMenuController.mm:
2551         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2552         Make use of the new strings.
2553
2554 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2555
2556         Cleanup from r175379
2557         https://bugs.webkit.org/show_bug.cgi?id=138616
2558
2559         Reviewed by Simon Fraser.
2560
2561         * WebCoreSupport/WebSystemInterface.mm:
2562         (InitWebCoreSystemInterface):
2563         * WebKit.order:
2564
2565 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2566
2567         Move CTFontTransformGlyphs out from WKSI
2568         https://bugs.webkit.org/show_bug.cgi?id=138599
2569
2570         Reviewed by Simon Fraser.
2571
2572         * WebCoreSupport/WebSystemInterface.mm:
2573         (InitWebCoreSystemInterface):
2574         * WebKit.order:
2575
2576 2014-11-11  Dan Bernstein  <mitz@apple.com>
2577
2578         More iOS build fix.
2579
2580         * WebView/WebHTMLViewInternal.h:
2581
2582 2014-11-11  Dan Bernstein  <mitz@apple.com>
2583
2584         iOS build fix.
2585
2586         * WebView/WebHTMLView.mm:
2587
2588 2014-11-10  Beth Dakin  <bdakin@apple.com>
2589
2590         WK1: Support default actions for editable text with misspelled word
2591         https://bugs.webkit.org/show_bug.cgi?id=138590
2592         -and corresponding-
2593         rdar://problem/18877506
2594
2595         Reviewed by Tim Horton.
2596
2597         If there are misspelled word suggestions for editable text, create a new type of 
2598         menu with a spelling suggestion sub-menu.
2599
2600         * WebView/WebActionMenuController.mm:
2601         (-[WebActionMenuController isMenuForTextContent]):
2602         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2603         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2604         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2605         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2606         * WebView/WebHTMLView.mm:
2607         (-[WebHTMLView _changeSpellingToWord:]):
2608         * WebView/WebHTMLViewInternal.h:
2609         * WebView/WebUIDelegatePrivate.h:
2610
2611 2014-11-10  Beth Dakin  <bdakin@apple.com>
2612
2613         WK1: Support default actions for editable whitespace
2614         https://bugs.webkit.org/show_bug.cgi?id=138586
2615         -and corresponding-
2616         rdar://problem/18932048
2617
2618         Reviewed by Tim Horton.
2619
2620         New menu type. Just wants paste.
2621
2622         * WebView/WebActionMenuController.mm:
2623         (-[WebActionMenuController isMenuForTextContent]):
2624         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
2625         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2626         * WebView/WebUIDelegatePrivate.h:
2627
2628 2014-11-10  Beth Dakin  <bdakin@apple.com>
2629
2630         WK1: Support default actions for editable text
2631         https://bugs.webkit.org/show_bug.cgi?id=138580
2632         -and corresponding-
2633         rdar://problem/18877497
2634
2635         Reviewed by Tim Horton.
2636
2637         New menu type, and new action type for paste. 
2638
2639         * WebView/WebActionMenuController.mm:
2640         (-[WebActionMenuController isMenuForTextContent]):
2641         (-[WebActionMenuController willOpenMenu:withEvent:]):
2642         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
2643         (-[WebActionMenuController _paste:]):
2644         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2645         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2646         * WebView/WebUIDelegatePrivate.h:
2647
2648 2014-11-10  Beth Dakin  <bdakin@apple.com>
2649
2650         WK1: Text is getting selected even when an action menu fails to invoke
2651         https://bugs.webkit.org/show_bug.cgi?id=138576
2652         -and corresponding-
2653         rdar://problem/18931330
2654
2655         Reviewed by Tim Horton.
2656
2657         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
2658         * WebView/WebActionMenuController.h:
2659         * WebView/WebActionMenuController.mm:
2660         (-[WebActionMenuController prepareForMenu:withEvent:]):
2661         (-[WebActionMenuController willOpenMenu:withEvent:]):
2662
2663         _selectLookupText no longer needs to return a BOOL indicating success or failure.
2664         (-[WebActionMenuController _selectLookupText]):
2665         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2666
2667         Pass willOpenMenu: on to the controller.
2668         * WebView/WebView.mm:
2669         (-[WebView willOpenMenu:withEvent:]):
2670
2671 2014-11-10  Beth Dakin  <bdakin@apple.com>
2672
2673         Speculative build fix.
2674
2675         * WebView/WebActionMenuController.mm:
2676
2677 2014-11-10  Beth Dakin  <bdakin@apple.com>
2678
2679         Action menu initialization should be moved to _commonInitializationWithFrameName
2680         https://bugs.webkit.org/show_bug.cgi?id=138572
2681         -and corresponding-
2682         rdar://problem/18929733
2683
2684         Reviewed by Tim Horton.
2685
2686         * WebView/WebView.mm:
2687         (-[WebView _commonInitializationWithFrameName:groupName:]):
2688         (-[WebView _initWithFrame:frameName:groupName:]):
2689
2690 2014-11-10  Beth Dakin  <bdakin@apple.com>
2691
2692         WK1: Support default actions for read-only text
2693         https://bugs.webkit.org/show_bug.cgi?id=138552
2694         -and corresponding-
2695         rdar://problem/18877483
2696
2697         Reviewed by Tim Horton.
2698
2699         New WKSystemInterface functions that WebCore needs to use.
2700         * WebCoreSupport/WebSystemInterface.mm:
2701         (InitWebCoreSystemInterface):
2702
2703         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
2704         makes a lot of things easier.
2705         * WebView/WebActionMenuController.h:
2706         * WebView/WebActionMenuController.mm:
2707
2708         Perform the hit test ourselves instead of calling into WebView so that we can more 
2709         easily save the WebCore::HitTestResult for ourselves.
2710         (-[WebActionMenuController performHitTestAtPoint:]):
2711
2712         Clear selection for non-text menus.
2713         (-[WebActionMenuController prepareForMenu:withEvent:]):
2714
2715         Re-set the _type here just to be safe.
2716         (-[WebActionMenuController didCloseMenu:withEvent:]):
2717
2718         Moving this method to be next to the link actions so they can be within a pragma 
2719         mark.
2720         (-[WebActionMenuController _defaultMenuItemsForLink:]):
2721
2722         New method for default text actions — lookup and copy.
2723         (-[WebActionMenuController _defaultMenuItemsForText:]):
2724         (-[WebActionMenuController _copySelection:]):
2725         (-[WebActionMenuController _lookupText:]):
2726
2727         If there is not already a selection, invoking the action menu on text should 
2728         select the lookup text.
2729         (-[WebActionMenuController _selectLookupText]):
2730         (performDictionaryLookupForSelection):
2731         (performDictionaryLookupForRange):
2732
2733         Handle text now.
2734         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2735         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2736
2737         New enum values.
2738         * WebView/WebUIDelegatePrivate.h:
2739
2740         Pass didCloseMenu on to the controller.
2741         * WebView/WebView.mm:
2742         (-[WebView didCloseMenu:withEvent:]):
2743
2744 2014-11-09  Chris Dumez  <cdumez@apple.com>
2745
2746         Add a more correct way to compare floating point numbers and use it
2747         https://bugs.webkit.org/show_bug.cgi?id=138527
2748
2749         Reviewed by Darin Adler.
2750
2751         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
2752         to compare floating-point numbers.
2753
2754         * WebView/WebHTMLView.mm:
2755         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
2756
2757 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2758
2759         Delete cookies between tests
2760         https://bugs.webkit.org/show_bug.cgi?id=138528
2761
2762         Reviewed by Sam Weinig.
2763
2764         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
2765         * WebView/WebPreferencesPrivate.h:
2766         Added an SPI for DumpRenderTree.
2767
2768 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
2769
2770         [iOS] Update optimized fullscreen media controls
2771         https://bugs.webkit.org/show_bug.cgi?id=138493
2772
2773         Reviewed by Brent Fulgham.
2774
2775         * WebCoreSupport/WebSystemInterface.mm:
2776         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
2777
2778 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
2779
2780         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
2781         https://bugs.webkit.org/show_bug.cgi?id=138443
2782
2783         Reviewed by Anders Carlsson.
2784
2785         Wrapping the dealloc method in its own autorelease pool avoids the problem of
2786         complex tear-downs leading to the WebView itself being added to an autorelease
2787         pool that is not drained until after the instance has been dealloc'd.
2788  
2789         * WebView/WebView.mm:
2790         (-[WebView dealloc]):
2791
2792 2014-11-05  Jer Noble  <jer.noble@apple.com>
2793
2794         De-templatize Timer
2795         https://bugs.webkit.org/show_bug.cgi?id=138450
2796
2797         Reviewed by Anders Carlsson.
2798
2799         Remove template specifiers from Timer.
2800
2801         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2802         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2803         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2804         * Plugins/WebNetscapePluginStream.h:
2805         * Plugins/WebNetscapePluginStream.mm:
2806         (WebNetscapePluginStream::deliverDataTimerFired):
2807
2808 2014-11-05  Dan Bernstein  <mitz@apple.com>
2809
2810         Remove the unused deletion UI feature
2811         https://bugs.webkit.org/show_bug.cgi?id=138442
2812
2813         Rubber-stamped by Alexey Proskuryakov.
2814
2815         * DefaultDelegates/WebDefaultEditingDelegate.m:
2816         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
2817         * WebCoreSupport/WebEditorClient.h:
2818         * WebCoreSupport/WebEditorClient.mm:
2819         (WebEditorClient::shouldShowDeleteInterface): Deleted.
2820         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
2821         -webView:shouldShowDeleteInterfaceForElement:.
2822
2823 2014-11-03  Dean Jackson  <dino@apple.com>
2824
2825         Add ENABLE_FILTERS_LEVEL_2 feature guard.
2826         https://bugs.webkit.org/show_bug.cgi?id=138362
2827
2828         Reviewed by Tim Horton.
2829
2830         Add a new feature define for Level 2 of CSS Filters.
2831         http://dev.w3.org/fxtf/filters-2/
2832
2833         * Configurations/FeatureDefines.xcconfig:
2834
2835 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
2836
2837         Add button and enable optimized fullscreen.
2838         https://bugs.webkit.org/show_bug.cgi?id=138351
2839
2840         Reviewed by Eric Carlson.
2841
2842         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
2843
2844         * WebCoreSupport/WebSystemInterface.mm:
2845         (InitWebCoreSystemInterface): added
2846
2847 2014-11-04  Chris Dumez  <cdumez@apple.com>
2848
2849         Add ptr() method to Ref class
2850         https://bugs.webkit.org/show_bug.cgi?id=138361
2851
2852         Reviewed by Darin Adler.
2853
2854         Use the new Ref::ptr() method.
2855
2856         * WebView/WebFrame.mm:
2857         (-[WebFrame _setTypingStyle:withUndoAction:]):
2858         * WebView/WebHTMLView.mm:
2859         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2860         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2861         * WebView/WebView.mm:
2862         (-[WebView applyStyle:]):
2863
2864 2014-11-04  Darin Adler  <darin@apple.com>
2865
2866         Eliminate ResourceBuffer and use SharedBuffer directly instead
2867         https://bugs.webkit.org/show_bug.cgi?id=138174
2868
2869         Reviewed by Antti Koivisto.
2870
2871         * WebView/WebDataSource.mm:
2872         (-[WebDataSource data]): Use SharedBuffer directly.
2873         * WebView/WebHTMLView.mm:
2874         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2875
2876 2014-11-03  Commit Queue  <commit-queue@webkit.org>
2877
2878         Unreviewed, rolling out r175406, r175413, and r175423.
2879         https://bugs.webkit.org/show_bug.cgi?id=138327
2880
2881         Multipart tests are still broken (Requested by ap on #webkit).
2882
2883         Reverted changesets:
2884
2885         "Eliminate ResourceBuffer and use SharedBuffer directly
2886         instead"
2887         https://bugs.webkit.org/show_bug.cgi?id=138174
2888         http://trac.webkit.org/changeset/175406
2889
2890         "Unreviewed, iOS build fix since 175406."
2891         http://trac.webkit.org/changeset/175413
2892
2893         "Fix assertion in CachedResource::addDataBuffer"
2894         http://trac.webkit.org/changeset/175423
2895
2896 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2897
2898         Use std::unique_ptr for TypeCountSet
2899         https://bugs.webkit.org/show_bug.cgi?id=138242
2900
2901         Reviewed by Andreas Kling.
2902
2903         * Misc/WebCoreStatistics.mm:
2904         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
2905         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
2906
2907 2014-10-31  Beth Dakin  <bdakin@apple.com>
2908
2909         Use system art for action menus when possible
2910         https://bugs.webkit.org/show_bug.cgi?id=138260
2911
2912         Reviewed by Tim Horton.
2913
2914         * WebView/WebActionMenuController.mm:
2915         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2916
2917 2014-10-30  Darin Adler  <darin@apple.com>
2918
2919         Eliminate ResourceBuffer and use SharedBuffer directly instead
2920         https://bugs.webkit.org/show_bug.cgi?id=138174
2921
2922         Reviewed by Antti Koivisto.
2923
2924         * WebView/WebDataSource.mm:
2925         (-[WebDataSource data]): Use SharedBuffer directly.
2926         * WebView/WebHTMLView.mm:
2927         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2928
2929 2014-10-30  Jer Noble  <jer.noble@apple.com>
2930
2931         [EME] Add Setting for accessing storage location for MediaKeys data
2932         https://bugs.webkit.org/show_bug.cgi?id=138147
2933
2934         Reviewed by Brady Eidson.
2935
2936         * WebView/WebPreferenceKeysPrivate.h:
2937         * WebView/WebPreferences.mm:
2938         (+[WebPreferences initialize]): Set default location.
2939         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
2940         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
2941         * WebView/WebPreferencesPrivate.h:
2942         * WebView/WebView.mm:
2943         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
2944
2945 2014-10-30  Dana Burkart  <dburkart@apple.com>
2946
2947         <rdar://problem/18821260> Prepare for the mysterious future
2948
2949         Reviewed by Lucas Forschler.
2950
2951         * Configurations/Base.xcconfig:
2952         * Configurations/DebugRelease.xcconfig:
2953         * Configurations/FeatureDefines.xcconfig:
2954         * Configurations/Version.xcconfig:
2955
2956 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
2957
2958         Add optimized fullscreen mode.
2959         https://bugs.webkit.org/show_bug.cgi?id=138044
2960
2961         Reviewed by Jer Noble.
2962
2963         Enable different types of fullscreen video behavior.
2964         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
2965
2966         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
2967         * WebCoreSupport/WebChromeClient.mm:
2968         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
2969         * WebView/WebView.mm:
2970         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
2971         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
2972         * WebView/WebViewInternal.h: ditto
2973
2974 2014-10-27  Beth Dakin  <bdakin@apple.com>
2975
2976         Provide a way for WebKit1 clients to override default action menu items
2977         https://bugs.webkit.org/show_bug.cgi?id=138066
2978         -and corresponding-
2979         rdar://problem/18451638
2980
2981         Reviewed by Anders Carlsson.
2982
2983         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
2984         send that along to clients customizing the menu.
2985         * WebView/WebActionMenuController.h:
2986         * WebView/WebActionMenuController.mm:
2987         (-[WebActionMenuController prepareForMenu:withEvent:]):
2988         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2989
2990         New enum and new SPI to customize menus.
2991         * WebView/WebUIDelegatePrivate.h:
2992
2993 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
2994
2995         Fix the iOS build
2996
2997         * Configurations/WebKitLegacy.xcconfig:
2998         * WebView/WebView.mm:
2999
3000 2014-10-24  Beth Dakin  <bdakin@apple.com>
3001
3002         Build fix.
3003
3004         * WebView/WebActionMenuController.mm:
3005         (-[WebActionMenuController _openURLFromActionMenu:]):
3006         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3007         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3008
3009 2014-10-24  Beth Dakin  <bdakin@apple.com>
3010
3011         WebKit1 should support action menus
3012         https://bugs.webkit.org/show_bug.cgi?id=138032
3013
3014         Reviewed by Tim Horton.
3015
3016         This patch adds basic support for action menus and adds actions for links.
3017
3018         Helper class takes care of all of the action menu work. WebView will forward the 
3019         prepareForMenu: message, and then the helper class takes it from there.
3020         * WebView/WebActionMenuController.h: Added.
3021         * WebView/WebActionMenuController.mm: Added.
3022         (-[WebActionMenuController webViewClosed]):
3023         (-[WebActionMenuController prepareForMenu:withEvent:]):
3024
3025         Selectors for link actions.
3026         (-[WebActionMenuController _openURLFromActionMenu:]):
3027         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3028         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
3029         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3030         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3031         (webKitBundleImageNamed):
3032         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3033         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3034
3035         Tags for the action menu items.
3036         * WebView/WebUIDelegatePrivate.h:
3037         * WebView/WebView.mm:
3038
3039         Set the action menu if possible and create the controller.
3040         (-[WebView _initWithFrame:frameName:groupName:]):
3041         (-[WebView _close]):
3042         (-[WebView prepareForMenu:withEvent:]):
3043
3044         WebViewData stores the WebActionMenuHelper
3045         * WebView/WebViewData.h:
3046         * WebView/WebViewData.mm:
3047         (-[WebViewPrivate dealloc]):
3048
3049 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
3050
3051         Web Inspector: Provide a way to have alternate inspector agents
3052         https://bugs.webkit.org/show_bug.cgi?id=137901
3053
3054         Reviewed by Brian Burg.
3055
3056         * Configurations/FeatureDefines.xcconfig:
3057
3058 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3059
3060         Add some SPI headers for NSExtension and NSSharingService{Picker}
3061         https://bugs.webkit.org/show_bug.cgi?id=138027
3062
3063         Reviewed by Anders Carlsson.
3064
3065         * Misc/WebSharingServicePickerController.h:
3066         * Misc/WebSharingServicePickerController.mm:
3067         * WebCoreSupport/WebSelectionServiceController.mm:
3068         * WebCoreSupport/WebContextMenuClient.mm:
3069         Fix a sorting issue.
3070         Replace redefinitions with SPI header #imports.
3071
3072 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3073
3074         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
3075         https://bugs.webkit.org/show_bug.cgi?id=138013
3076
3077         Reviewed by Dan Bernstein.
3078
3079         * WebCoreSupport/WebSelectionServiceController.mm:
3080         (WebSelectionServiceController::hasRelevantSelectionServices):
3081         Don't adopt this autoreleased object.
3082
3083 2014-10-22  Chris Dumez  <cdumez@apple.com>
3084
3085         [Mac][WK2] Fix applicationIsSafari() detection
3086         https://bugs.webkit.org/show_bug.cgi?id=137893
3087
3088         Reviewed by Alexey Proskuryakov.
3089
3090         Provide an implementation for FrameLoaderClient's new
3091         needsQuickLookResourceCachingQuirks() that returns
3092         a static flag initialized using
3093         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3094
3095         * WebCoreSupport/WebFrameLoaderClient.h:
3096         * WebCoreSupport/WebFrameLoaderClient.mm:
3097
3098 2014-10-20  Chris Dumez  <cdumez@apple.com>
3099
3100         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3101         https://bugs.webkit.org/show_bug.cgi?id=137797
3102
3103         Reviewed by Darin Adler.
3104
3105         Call ResourceRequest::setDomainForPartitionName() instead of
3106         setPartitionName() as the argument is a domain, not a valid
3107         partition name.
3108
3109         * Misc/WebCache.mm:
3110         (+[WebCache addImageToCache:forURL:forFrame:]):
3111         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3112
3113 2014-10-20  Andy Estes  <aestes@apple.com>
3114
3115         Fix the iOS build.
3116
3117         * WebView/WebFrame.mm:
3118         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3119         (-[WebFrame dictationResultMetadataForRange:]):
3120
3121 2014-10-19  Chris Dumez  <cdumez@apple.com>
3122
3123         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3124         https://bugs.webkit.org/show_bug.cgi?id=137845
3125
3126         Reviewed by Darin Adler.
3127
3128         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3129         clean up the surrounding code.
3130
3131         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3132         (-[WebHostedNetscapePluginView pluginHostDied]):
3133         * Plugins/WebBaseNetscapePluginView.mm:
3134         (-[WebBaseNetscapePluginView _windowClipRect]):
3135         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3136         * WebCoreSupport/WebFrameLoaderClient.mm:
3137         (WebFrameLoaderClient::createPlugin):
3138         (WebFrameLoaderClient::createJavaAppletWidget):
3139
3140 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3141
3142         Build fix for 32-bit Yosemite
3143
3144         * WebCoreSupport/WebContextMenuClient.mm:
3145         (WebContextMenuClient::contextMenuForEvent):
3146         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3147
3148 2014-10-17  Chris Dumez  <cdumez@apple.com>
3149
3150         Use is<>() / downcast<>() for RenderBox
3151         https://bugs.webkit.org/show_bug.cgi?id=137804
3152
3153         Reviewed by Andreas Kling.
3154
3155         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3156         code.
3157
3158         * WebCoreSupport/WebContextMenuClient.mm:
3159         (WebContextMenuClient::clientFloatRectForNode):
3160         * WebView/WebFrame.mm:
3161         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3162
3163 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3164
3165         Fix the build with the public SDK.
3166
3167         * WebCoreSupport/WebSelectionServiceController.mm:
3168         We should transition all this SPI to real SPI headers as soon as possible.
3169
3170 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3171
3172         Implement selection services menu for Legacy WebKit
3173         https://bugs.webkit.org/show_bug.cgi?id=137582
3174         <rdar://problem/18604241>
3175
3176         Reviewed by Brady Eidson.
3177
3178         * Misc/WebSharingServicePickerController.h:
3179         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3180         Add WebSharingServicePickerClient, which other classes can implement
3181         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3182         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3183
3184         * Misc/WebSharingServicePickerController.mm:
3185         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3186
3187         (-[WebSharingServicePickerController clear]):
3188         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3189         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3190         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3191         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3192         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3193         Make use of WebSharingServicePickerClient.
3194
3195         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3196         If we're returned a NSAttributedString, paste it on top of the current selection,
3197         similar to what the WebKit2 implementation currently does.
3198         
3199         * WebCoreSupport/WebChromeClient.h:
3200         * WebCoreSupport/WebChromeClient.mm:
3201         (WebChromeClient::handleTelephoneNumberClick):
3202         (WebChromeClient::handleSelectionServiceClick):
3203         (WebChromeClient::hasRelevantSelectionServices):
3204         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3205
3206         * WebCoreSupport/WebContextMenuClient.h:
3207         * WebCoreSupport/WebContextMenuClient.mm:
3208         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3209         (WebContextMenuClient::pageForSharingServicePicker):
3210         (WebContextMenuClient::windowForSharingServicePicker):
3211         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3212         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3213         (WebContextMenuClient::contextMenuForEvent):
3214         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3215         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3216         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3217         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3218         having WebSharingServicePickerController tightly bound to it.
3219         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3220         instead of handing it data directly.
3221
3222         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3223         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3224         (WebSelectionServiceController::WebSelectionServiceController):
3225         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3226         for selection services.
3227
3228         (WebSelectionServiceController::handleSelectionServiceClick):
3229         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3230
3231         (hasCompatibleServicesForItems):
3232         (WebSelectionServiceController::hasRelevantSelectionServices):
3233         Determine whether or not services are available.
3234
3235         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3236         (WebSelectionServiceController::pageForSharingServicePicker):
3237         (WebSelectionServiceController::windowForSharingServicePicker):
3238         Implement the rest of the WebSharingServicePickerClient overrides.
3239
3240         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3241         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3242         These are only useful for image sharing services, so we don't need to
3243         implement them (WebContextMenuClient does, on the other hand).
3244
3245         * WebView/WebView.mm:
3246         (-[WebView _selectionServiceController]):
3247         * WebView/WebViewData.h:
3248         * WebView/WebViewData.mm:
3249         * WebView/WebViewInternal.h:
3250         Keep a WebSelectionServiceController.
3251
3252 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3253
3254         Improve debug description of WAKViews
3255         https://bugs.webkit.org/show_bug.cgi?id=137716
3256
3257         Reviewed by Simon Fraser.
3258
3259         * WebView/WebView.mm:
3260         (-[WebView _touchEventRegions]): Adding a comment.
3261
3262 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3263
3264         Addressing post-review comment.
3265         https://bugs.webkit.org/show_bug.cgi?id=137550
3266
3267         Unreviewed.
3268
3269         * WebView/WebHTMLView.mm:
3270         (fontNameForDescription):
3271         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3272
3273 2014-10-14  Chris Dumez  <cdumez@apple.com>
3274
3275         Use is<>() / downcast<>() for RenderImage
3276         https://bugs.webkit.org/show_bug.cgi?id=137683
3277
3278         Reviewed by Mihnea Ovidenie.
3279
3280         Use is<>() / downcast<>() for RenderImage.
3281
3282         * Misc/WebNSPasteboardExtras.mm:
3283         (imageFromElement):
3284         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3285
3286 2014-10-10  Daniel Bates  <dabates@apple.com>
3287
3288         Remove unused classes WebRender{Node, Layer}
3289         https://bugs.webkit.org/show_bug.cgi?id=137628
3290
3291         Reviewed by Simon Fraser.
3292
3293         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3294         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3295
3296         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3297         of excluded source files when building for iOS.
3298         * WebKit.exp: Remove symbol for WebRenderLayer.
3299         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3300         * WebView/WebRenderLayer.h: Removed.
3301         * WebView/WebRenderLayer.mm: Removed.
3302         * WebView/WebRenderNode.h: Removed.
3303         * WebView/WebRenderNode.mm: Removed.
3304
3305 2014-10-10  Chris Dumez  <cdumez@apple.com>
3306
3307         Use is<>() / downcast<>() for RenderBoxModelObject
3308         https://bugs.webkit.org/show_bug.cgi?id=137587
3309
3310         Reviewed by Mihnea Ovidenie.
3311
3312         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3313         surrounding code.
3314
3315         * Plugins/WebBaseNetscapePluginView.mm:
3316         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3317         * WebView/WebRenderLayer.mm:
3318         (-[WebRenderLayer initWithWebFrame:]):
3319
3320 2014-10-09  Dean Jackson  <dino@apple.com>
3321
3322         Remove ENABLE_CSS3_CONDITIONAL_RULES
3323         https://bugs.webkit.org/show_bug.cgi?id=137571
3324
3325         Reviewed by Simon Fraser.
3326
3327         * Configurations/FeatureDefines.xcconfig:
3328
3329 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3330
3331         Add a WebKit1 preference for selection services
3332         https://bugs.webkit.org/show_bug.cgi?id=137498
3333         <rdar://problem/18572699>
3334
3335         Reviewed by Simon Fraser.
3336
3337         * WebView/WebPreferenceKeysPrivate.h:
3338         * WebView/WebPreferences.mm:
3339         (+[WebPreferences initialize]):
3340         (-[WebPreferences serviceControlsEnabled]):
3341         (-[WebPreferences setServiceControlsEnabled:]):
3342         * WebView/WebPreferencesPrivate.h:
3343         * WebView/WebView.mm:
3344         (-[WebView _preferencesChanged:]):
3345         Add and plumb the preference.
3346
3347 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3348
3349         Remove second-to-last client of WebFontCache
3350         https://bugs.webkit.org/show_bug.cgi?id=137550
3351
3352         Reviewed by Darin Adler.
3353
3354         Use FontCache::getCachedFontData() instead of WebFontCache.
3355
3356         * WebView/WebHTMLView.mm:
3357         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3358
3359 2014-10-09  Chris Dumez  <cdumez@apple.com>
3360
3361         Use is<>() / downcast<>() for Widget subclasses
3362         https://bugs.webkit.org/show_bug.cgi?id=137549
3363
3364         Reviewed by Darin Adler.
3365
3366         Use is<>() / downcast<>() for Widget subclasses and clean up the
3367         surrounding code.
3368
3369         * WebView/WebRenderNode.mm:
3370         (copyRenderNode):
3371         * WebView/WebView.mm:
3372         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3373
3374 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3375
3376         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3377         https://bugs.webkit.org/show_bug.cgi?id=137476
3378
3379         Reviewed by Darin Adler.
3380
3381         * WebView/WebRenderNode.mm:
3382         (copyRenderNode):
3383
3384 2014-10-06  Dan Bernstein  <mitz@apple.com>
3385
3386         Build fix.
3387
3388         * Misc/WebCache.mm:
3389         (+[WebCache imageForURL:]):
3390
3391 2014-10-06  Chris Dumez  <cdumez@apple.com>
3392
3393         Unreviewed build fix after r174333.
3394
3395         Forgot explicit WebCore:: namespace.
3396
3397         * Misc/WebCache.mm:
3398         (+[WebCache imageForURL:]):
3399
3400 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3401
3402         Use is<>() / downcast<>() for CachedResource subclasses
3403         https://bugs.webkit.org/show_bug.cgi?id=137431
3404
3405         Reviewed by Benjamin Poulain.
3406
3407         Use is<>() / downcast<>() for CachedResource subclasses.
3408
3409         * Misc/WebCache.mm:
3410         (+[WebCache imageForURL:]):
3411
3412 2014-10-02  Daniel Bates  <dabates@apple.com>
3413
3414         Use version number 101000 instead of 10100 for OS X Yosemite
3415         https://bugs.webkit.org/show_bug.cgi?id=137372
3416
3417         Reviewed by Mark Rowe.
3418
3419         The version number for OS X Yosemite is 101000.
3420
3421         * WebView/WebView.mm:
3422         (-[WebView _preferencesChanged:]):
3423
3424 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3425
3426         Move PageOverlay[Controller] to WebCore
3427         https://bugs.webkit.org/show_bug.cgi?id=137164
3428         <rdar://problem/18508258>
3429
3430         Reviewed by Anders Carlsson.
3431
3432         * WebCoreSupport/WebChromeClient.h:
3433         * WebCoreSupport/WebChromeClient.mm:
3434         (WebChromeClient::attachViewOverlayGraphicsLayer):
3435         Add an empty ChromeClient override.
3436
3437 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3438
3439         Have is<>(T*) function do a null check on the pointer argument
3440         https://bugs.webkit.org/show_bug.cgi?id=137333
3441
3442         Reviewed by Gavin Barraclough.
3443
3444         Have is<>(T*) function do a null check on the argument instead of a
3445         simple assertion. This makes sense for 2 reasons:
3446         1. It is more consistent with downcast<>(T*), which will succeed even
3447            if the argument is a nullptr.
3448         2. It simplifies the code a bit as it gets rid of a lot of explicit
3449            null checks.
3450
3451         * WebCoreSupport/WebChromeClient.mm:
3452         (WebChromeClient::focusedElementChanged):
3453         * WebCoreSupport/WebEditorClient.mm:
3454         (WebEditorClient::textFieldDidBeginEditing):
3455         (WebEditorClient::textFieldDidEndEditing):
3456         (WebEditorClient::textDidChangeInTextField):
3457         (WebEditorClient::doTextFieldCommandFromEvent):
3458         (WebEditorClient::textWillBeDeletedInTextField):
3459         (WebEditorClient::textDidChangeInTextArea):
3460         * WebView/WebHTMLRepresentation.mm:
3461         (inputElementFromDOMElement):
3462         (searchForLabelsBeforeElement):
3463         * WebView/WebRenderLayer.mm:
3464         (+[WebRenderLayer nameForLayer:]):
3465
3466 2014-10-01  Mark Rowe  <mrowe@apple.com>
3467
3468         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3469
3470         Reviewed by Dan Bernstein.
3471
3472         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3473
3474 2014-09-30  Chris Dumez  <cdumez@apple.com>
3475
3476         Use is<>() / downcast<>() for Element
3477         https://bugs.webkit.org/show_bug.cgi?id=137241
3478
3479         Reviewed by Andreas Kling.
3480
3481         Use is<>() / downcast<>() for Element instead of isElementNode() /
3482         toElement().
3483
3484         * WebView/WebRenderLayer.mm:
3485         (+[WebRenderLayer nameForLayer:]):
3486
3487 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3488
3489         Move ColorInputType class to std::unique_ptr
3490         https://bugs.webkit.org/show_bug.cgi?id=137173
3491
3492         Reviewed by Darin Adler.
3493
3494         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3495         Child classes follow this change as well.
3496
3497         * WebCoreSupport/WebChromeClient.h:
3498         * WebCoreSupport/WebChromeClient.mm:
3499         (WebChromeClient::createColorChooser):
3500
3501 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3502
3503         Add initial is<>() / downcast<>() support for any type of Nodes
3504         https://bugs.webkit.org/show_bug.cgi?id=137056
3505
3506         Reviewed by Benjamin Poulain.
3507
3508         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3509         instead of isFormControlElement() / toHTMLFormControlElement().
3510
3511         * WebView/WebHTMLRepresentation.mm:
3512         (searchForLabelsBeforeElement):
3513
3514 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3515
3516         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3517         https://bugs.webkit.org/show_bug.cgi?id=137068
3518
3519         Reviewed by Ryosuke Niwa.
3520
3521         Start using is<HTML*Element>() instead of isHTML*Element().
3522         Remaining usages will be updated in a follow-up patch to
3523         reduce the size of the change.
3524
3525         * WebCoreSupport/WebChromeClient.mm:
3526         (WebChromeClient::focusedElementChanged):
3527         * WebCoreSupport/WebEditorClient.mm:
3528         (WebEditorClient::textFieldDidBeginEditing):
3529         (WebEditorClient::textFieldDidEndEditing):
3530         (WebEditorClient::textDidChangeInTextField):
3531         (WebEditorClient::doTextFieldCommandFromEvent):
3532         (WebEditorClient::textWillBeDeletedInTextField):
3533         (WebEditorClient::textDidChangeInTextArea):
3534         * WebView/WebHTMLRepresentation.mm:
3535         (inputElementFromDOMElement):
3536
3537 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3538
3539         Make the Web Inspector use a separate web process.
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=135120
3542
3543         Reviewed by Anders Carlsson.
3544
3545         * WebCoreSupport/WebInspectorClient.h:
3546         * WebCoreSupport/WebInspectorClient.mm:
3547         (WebInspectorClient::WebInspectorClient):
3548         (WebInspectorClient::openInspectorFrontend):
3549         (WebInspectorClient::releaseFrontend):
3550         Own WebInspectorFrontendClient instead of moving it.
3551
3552 2014-09-23  Chris Dumez  <cdumez@apple.com>
3553
3554         Use downcast<HTML*Element>() instead of toHTML*Element()
3555         https://bugs.webkit.org/show_bug.cgi?id=137007
3556
3557         Reviewed by Benjamin Poulain.
3558
3559         Use downcast<HTML*Element>() instead of toHTML*Element().
3560
3561         * DOM/WebDOMOperations.mm:
3562         (-[DOMHTMLInputElement _setAutofilled:]):
3563         * WebCoreSupport/WebChromeClient.mm:
3564         (WebChromeClient::focusedElementChanged):
3565         * WebCoreSupport/WebEditorClient.mm:
3566         (WebEditorClient::textFieldDidBeginEditing):
3567         (WebEditorClient::textFieldDidEndEditing):
3568         (WebEditorClient::textDidChangeInTextField):
3569         (WebEditorClient::doTextFieldCommandFromEvent):
3570         (WebEditorClient::textWillBeDeletedInTextField):
3571         (WebEditorClient::textDidChangeInTextArea):
3572         * WebView/WebHTMLRepresentation.mm:
3573         (inputElementFromDOMElement):
3574
3575 2014-09-21  Chris Dumez  <cdumez@apple.com>
3576
3577         Generate Element casting helper functions
3578         https://bugs.webkit.org/show_bug.cgi?id=136839
3579
3580         Reviewed by Darin Adler.
3581
3582         Use JSXXX::toWrapped() instead of toXXX() function.
3583
3584         * DOM/WebDOMOperations.mm:
3585         * WebView/WebView.mm:
3586         (-[WebView _notificationIDForTesting:]):
3587
3588 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3589
3590         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3591         https://bugs.webkit.org/show_bug.cgi?id=136972
3592
3593         Reviewed by Darin Adler.
3594
3595         * WebView/WebNotification.h:
3596         * WebView/WebNotification.mm:
3597         (-[WebNotification initWithCoreNotification:notificationID:]):
3598         Switch to RetainPtr and adopt into _private to ensure when we are
3599         deallocated that _private will get deallocated.
3600
3601 2014-09-19  Dean Jackson  <dino@apple.com>
3602
3603         Multithreaded WebGL is a bad idea - remove it
3604         https://bugs.webkit.org/show_bug.cgi?id=136964
3605         <rdar://problem/18399858>
3606
3607         Reviewed by Brent Fulgham.
3608
3609         Remove the setting to allow multithreaded WebGL.
3610
3611         * WebView/WebPreferenceKeysPrivate.h:
3612         * WebView/WebPreferences.mm:
3613         (+[WebPreferences initialize]):
3614         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
3615         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
3616         * WebView/WebPreferencesPrivate.h:
3617         * WebView/WebView.mm:
3618         (-[WebView _preferencesChanged:]):
3619
3620 2014-09-19  Daniel Bates  <dabates@apple.com>
3621
3622         Always assume internal SDK when building configuration Production
3623         https://bugs.webkit.org/show_bug.cgi?id=136925
3624         <rdar://problem/18362399>
3625
3626         Reviewed by Dan Bernstein.
3627
3628         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
3629         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
3630
3631         * Configurations/Base.xcconfig:
3632
3633 2014-09-17  Daniel Bates  <dabates@apple.com>
3634
3635         Unreviewed, rolling out r173695.
3636
3637         Broke building third-party Legacy WebKit apps; will
3638         investigate offline
3639
3640         Reverted changeset:
3641
3642         "[iOS] Make WebCore build with public iOS SDK"
3643         https://bugs.webkit.org/show_bug.cgi?id=136487
3644         http://trac.webkit.org/changeset/173695
3645
3646 2014-09-17  Daniel Bates  <dabates@apple.com>
3647
3648         [iOS] Make WebCore build with public iOS SDK
3649         https://bugs.webkit.org/show_bug.cgi?id=136487
3650
3651         Reviewed by David Kilzer.
3652
3653         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
3654         actual SPI header(s).
3655
3656         * DOM/WebDOMOperationsPrivate.h:
3657         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
3658         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
3659         such files into the WebKit framework as private headers.
3660         * WebCoreSupport/WebFrameLoaderClient.mm:
3661         * WebInspector/WebNodeHighlight.mm:
3662         * WebView/WebIndicateLayer.mm:
3663         * WebView/WebRenderLayer.h:
3664         * WebView/WebView.mm:
3665
3666 2014-09-16  Daniel Bates  <dabates@apple.com>
3667
3668         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3669         https://bugs.webkit.org/show_bug.cgi?id=136862
3670
3671         Reviewed by David Kilzer.
3672
3673         * Configurations/DebugRelease.xcconfig:
3674
3675 2014-09-16  Enrica Casucci  <enrica@apple.com>
3676
3677         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3678         https://bugs.webkit.org/show_bug.cgi?id=136474
3679
3680         Reviewed by Benjamin Poulain.
3681
3682         This is the updated version of the patch that was landed in r173340.
3683         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3684         and removes the assumption that EAffinity values match NSSelectionAffinity
3685         values. It also removes the includes in TextAffinity.h, creating the need to
3686         include explicitly the files when necessary.
3687
3688         * WebCoreSupport/WebEditorClient.h:
3689         (kit):
3690         (core):
3691
3692 2014-09-14  Daniel Bates  <dabates@apple.com>
3693
3694         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
3695         (https://bugs.webkit.org/show_bug.cgi?id=136789)
3696
3697         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
3698
3699         * WebView/WebFrame.mm:
3700         (-[WebFrame focusedNodeHasContent]):
3701
3702 2014-09-14  Chris Dumez  <cdumez@apple.com>
3703
3704         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
3705         https://bugs.webkit.org/show_bug.cgi?id=136789
3706
3707         Reviewed by Darin Adler.
3708
3709         Rename childNodeCount() to countChildNodes().
3710
3711         * WebView/WebHTMLView.mm:
3712         (-[WebHTMLView attributedString]):
3713
3714 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
3715
3716         Re-add the request autocomplete feature
3717
3718         <https://bugs.webkit.org/show_bug.cgi?id=136730>
3719
3720         This feature was rolled out in r148731 because it was only used by
3721         Chromium. As we consider supporting this feature, roll it back in, but
3722         leave it disabled.
3723
3724         This rolls out r148731 (which removed the feature) with small changes
3725         needed to make the code build in ToT, to match modern style, to make
3726         the tests run, and to remove unused code.
3727
3728         Reviewed by Andy Estes.
3729
3730         * Configurations/FeatureDefines.xcconfig:
3731         * WebCoreSupport/WebFrameLoaderClient.h:
3732
3733 2014-09-12  Commit Queue  <commit-queue@webkit.org>
3734
3735         Unreviewed, rolling out r173575.
3736         https://bugs.webkit.org/show_bug.cgi?id=136790
3737
3738         Failing tests (Requested by enrica on #webkit).
3739
3740         Reverted changeset:
3741
3742         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3743         https://bugs.webkit.org/show_bug.cgi?id=136474
3744         http://trac.webkit.org/changeset/173575
3745
3746 2014-09-12  Enrica Casucci  <enrica@apple.com>
3747
3748         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3749         https://bugs.webkit.org/show_bug.cgi?id=136474
3750
3751         Reviewed by Benjamin Poulain.
3752
3753         This is the updated version of the patch that was landed in r173340.
3754         I changed the use of IntPoint to FloatPoint since it was causing tests
3755         to fail.
3756         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3757         and removes the assumption that EAffinity values match NSSelectionAffinity
3758         values. It also removes the includes in TextAffinity.h, creating the need to
3759         include explicitly the files when necessary. It also removes the unnecessary
3760         use of platform specific types, replacing them with WebCore types.
3761
3762         * WebCoreSupport/WebEditorClient.h:
3763         (kit):
3764         (core):
3765         * WebView/WebFrameView.mm:
3766         (-[WebFrameView _scrollToBeginningOfDocument]):
3767         (-[WebFrameView _scrollToEndOfDocument]):
3768
3769 2014-09-11  Bear Travis  <betravis@adobe.com>
3770
3771         [CSS Font Loading] Enable CSS Font Loading on Mac
3772         https://bugs.webkit.org/show_bug.cgi?id=135473
3773
3774         Reviewed by Antti Koivisto.
3775
3776         Enable CSS Font Loading in FeatureDefines.
3777
3778         * Configurations/FeatureDefines.xcconfig:
3779
3780 2014-09-11  Beth Dakin  <bdakin@apple.com>
3781
3782         Support rubber-banding in sub-frames
3783         https://bugs.webkit.org/show_bug.cgi?id=136726
3784         -and corresponding-
3785         rdar://problem/10011924
3786
3787         Reviewed by Tim Horton.
3788
3789         rubberBandingForOverflowScrollEnabled is re-named to
3790         rubberBandingForSubScrollableRegionsEnabled
3791         * WebView/WebView.mm:
3792         (-[WebView _preferencesChanged:]):
3793
3794 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
3795
3796         Disable the "unreachable-code" warning
3797         https://bugs.webkit.org/show_bug.cgi?id=136677
3798
3799         Reviewed by Darin Adler.
3800
3801         * Configurations/Base.xcconfig:
3802
3803 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
3804
3805         Fix 32-bit Mac build for new warnings
3806         https://bugs.webkit.org/show_bug.cgi?id=136624
3807
3808         Reviewed by Darin Adler.
3809         
3810         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
3811
3812         * Carbon/HIViewAdapter.m:
3813         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
3814
3815 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3816
3817         Remove FILTERS flag
3818         https://bugs.webkit.org/show_bug.cgi?id=136571
3819
3820         Reviewed by Darin Adler.
3821
3822         * Configurations/FeatureDefines.xcconfig:
3823
3824 2014-09-08  Jessie Berlin  <jberlin@apple.com>
3825
3826         32-bit build fix after r173364.
3827
3828         * Carbon/HIViewAdapter.m:
3829         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
3830
3831 2014-09-08  Dan Bernstein  <mitz@apple.com>
3832
3833         Build fix.
3834
3835         Added back SPI that is still in use.
3836
3837         * Misc/WebNSURLExtras.h:
3838         * Misc/WebNSURLExtras.mm:
3839         (-[NSURL _webkit_URLByRemovingFragment]):
3840
3841 2014-09-08  Dan Bernstein  <mitz@apple.com>
3842
3843         iOS Simulator build fix.
3844
3845         * Misc/WebKitSystemBits.m:
3846         (WebMemorySize):
3847
3848 2014-09-07  Darin Adler  <darin@apple.com>
3849
3850         Fix build failure seen on Mountain Lion buildbot.
3851
3852         * Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
3853         of an int, to avoid warning about mixing signs.
3854
3855 2014-09-06  Darin Adler  <darin@apple.com>
3856
3857         Make updates suggested by new version of Xcode
3858         https://bugs.webkit.org/show_bug.cgi?id=136603
3859
3860         Reviewed by Mark Rowe.
3861
3862         * Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
3863         and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
3864
3865         * History/WebURLsWithTitles.m:
3866         (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
3867         unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
3868         not turned on because it gives us too many false positives).
3869         * Misc/WebElementDictionary.mm:
3870         (-[WebElementDictionary objectForKey:]): Ditto.
3871         * Misc/WebNSDataExtras.m:
3872         (-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
3873         (-[NSData _webkit_guessedMIMEType]): Ditto.
3874         (-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
3875         (-[NSData _web_locationAfterFirstBlankLine]): Ditto.
3876
3877         * Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
3878         _webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
3879         _webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
3880         _web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
3881         and _webkit_URLFragment methods.
3882
3883         * Misc/WebNSURLExtras.mm:
3884         (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
3885         (-[NSURL _webkit_URLByRemovingFragment]): Deleted.
3886         (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
3887         (-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
3888         (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
3889         (-[NSURL _web_URLWithLowercasedScheme]): Deleted.
3890         (-[NSString _webkit_isFTPDirectoryURL]): Deleted.
3891         (-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
3892         (-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
3893         (-[NSString _web_decodeHostNameWithRange:]): Deleted.
3894         (-[NSString _web_encodeHostNameWithRange:]): Deleted.
3895         (-[NSString _webkit_URLFragment]): Deleted.
3896
3897         * Plugins/WebPluginDatabase.mm:
3898         (-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
3899         to iterate an array instead of a loop using the type "unsigned int".
3900
3901         * WebCoreSupport/WebOpenPanelResultListener.mm:
3902         (-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
3903
3904         * WebView/WebDelegateImplementationCaching.mm:
3905         (CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
3906         directly without a proper type for the function pointer. This might have been causing
3907         an actual problem on 64-bit systems, and it was different from all the other CallDelegate
3908         functions that were already doing this correctly.
3909
3910         * WebView/WebTextCompletionController.mm:
3911         (-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
3912
3913 2014-09-06  Brian J. Burg  <burg@cs.washington.edu>
3914
3915         Web Inspector: convert DockSide to an enum class
3916         https://bugs.webkit.org/show_bug.cgi?id=136601
3917
3918         Reviewed by Timothy Hatcher.
3919
3920         * WebCoreSupport/WebInspectorClient.mm:
3921         (WebInspectorFrontendClient::frontendLoaded):
3922         (-[WebInspectorWindowController attachWindow:]):
3923         (-[WebInspectorWindowController attach]):
3924         (-[WebInspectorWindowController detach]):
3925         * WebInspector/WebInspectorFrontend.mm:
3926         (-[WebInspectorFrontend attach]):
3927
3928 2014-09-05  Commit Queue  <commit-queue@webkit.org>
3929
3930         Unreviewed, rolling out r173340 and r173342.
3931         https://bugs.webkit.org/show_bug.cgi?id=136596
3932
3933         Broke many tests (Requested by ap on #webkit).
3934
3935         Reverted changesets:
3936
3937         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
3938         https://bugs.webkit.org/show_bug.cgi?id=136474
3939         http://trac.webkit.org/changeset/173340
3940
3941         "Build fix after r173340."
3942         http://trac.webkit.org/changeset/173342
3943
3944 2014-09-05  Enrica Casucci  <enrica@apple.com>
3945
3946         Build fix after r173340.
3947
3948         * WebCoreSupport/WebEditorClient.h:
3949         (kit):
3950         (core):
3951
3952 2014-09-05  Enrica Casucci  <enrica@apple.com>
3953
3954         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
3955         https://bugs.webkit.org/show_bug.cgi?id=136474
3956
3957         Reviewed by Benjamin Poulain.
3958
3959         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
3960         and removes the assumption that EAffinity values match NSSelectionAffinity
3961         values. It also removes the includes in TextAffinity.h, creating the need to
3962         include explicitly the files when necessary. It also removes the unnecessary
3963         use of platform specific types, replacing them with WebCore types.
3964
3965         * WebCoreSupport/WebEditorClient.h: Added kit and core for EAffinity.
3966         * WebView/WebFrameView.mm:
3967         (-[WebFrameView _scrollToBeginningOfDocument]):
3968         (-[WebFrameView _scrollToEndOfDocument]):
3969
3970 2014-09-05  Daniel Bates  <dabates@apple.com>
3971
3972         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3973         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3974
3975         Move #endif inside -viewDidMoveToWindow up one line such that the closing brace ('}') is after it.
3976
3977         * WebView/WebHTMLView.mm:
3978         (-[WebHTMLView viewDidMoveToWindow]):
3979
3980 2014-09-05  Daniel Bates  <dabates@apple.com>
3981
3982         [iOS] Another attempt to fix the iOS build after <http://trac.webkit.org/changeset/173309>
3983         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3984
3985         Add !PLATFORM(IOS)-guard in -viewDidMoveToWindow around code that references WebHTMLViewPrivate.flagsChangedEventMonitor.
3986         The instance variable WebHTMLViewPrivate.flagsChangedEventMonitor is guarded by !PLATFORM(IOS).
3987
3988         * WebView/WebHTMLView.mm:
3989         (-[WebHTMLView viewDidMoveToWindow]):
3990
3991 2014-09-05  Daniel Bates  <dabates@apple.com>
3992
3993         [iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173309>
3994         (https://bugs.webkit.org/show_bug.cgi?id=136564)
3995
3996         Include more code inside the !PLATFORM(IOS)-guarded section in -setDataSource:.
3997
3998         * WebView/WebHTMLView.mm:
3999         (-[WebHTMLView setDataSource:]):
4000
4001 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
4002
4003         Use tracking areas instead of (SPI) mouse moved notifications, and follow flags changes with an event monitor
4004         https://bugs.webkit.org/show_bug.cgi?id=136564
4005
4006         Reviewed by Dan Bernstein.
4007         
4008         WebKit1 depended on mouse moved event notifications to track mouse
4009         moves, and on being specially called by Safari to track flags
4010         changes. WebKit2 does both these things better - it uses a tracking area
4011         and event monitors. Copy those approaches.
4012
4013         * WebKit.order: Remove reference to obsolete call.
4014         * WebView/WebHTMLView.mm:
4015         (-[WebHTMLViewPrivate dealloc]): No need to deallocate tracking
4016         area, since we now just always have one.
4017         (-[WebHTMLViewPrivate clear]): ditto
4018         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
4019         New method that posts a fake mouse move event in response to
4020         a flags change event, for use by the event monitor.
4021         (+[WebHTMLView _postFlagsChangedEvent:]): Empty this old call,
4022         still kept around for benefit of older Safari.
4023         (-[WebHTMLView _updateMouseoverWithEvent:]): Handle Dashboard's
4024         special mouseover mode (previously handled in a weird way).
4025         (-[WebHTMLView close]): No more need to mess with mouse moved observer.
4026         (-[WebHTMLView viewWillMoveToWindow:]): ditto
4027         (-[WebHTMLView viewDidMoveToWindow]): ditto; but now hook up a flags
4028         changed monitor.
4029         (-[WebHTMLView windowDidBecomeKey:]): No need to handle non-key window
4030         tracking area or mouse moved observer.
4031         (-[WebHTMLView windowDidResignKey:]): ditto
4032         (-[WebHTMLView windowWillOrderOnScreen:]): No need to mess with mouse
4033         moved observer.
4034         (-[WebHTMLView windowWillOrderOffScreen:]): ditto
4035         (-[WebHTMLView mouseMoved:]): Converted from the old mouseMovedNotification:
4036         (-[WebHTMLView setDataSource:]): Change if around body to early return. Hook
4037         up tracking area - we have to do it here, because before this point, the
4038         WebHTMLView does not know its WebView, which is where dashboard settings
4039         live.
4040         (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Deleted.
4041         (-[WebHTMLView addMouseMovedObserver]): Deleted.
4042         (-[WebHTMLView removeMouseMovedObserver]): Deleted.
4043
4044 2014-09-04  Pratik Solanki  <psolanki@apple.com>
4045
4046         Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility
4047         https://bugs.webkit.org/show_bug.cgi?id=136560
4048
4049         Reviewed by Joseph Pecoraro.
4050
4051         I removed the disk image caching code in r173265. However, we still have clients that call
4052         setDiskImageCacheEnabled. Add in a stub method until we can wean the clients off this call.
4053
4054         * WebView/WebPreferences.mm:
4055         (-[WebPreferences setDiskImageCacheEnabled:]):
4056         * WebView/WebPreferencesPrivate.h:
4057
4058 2014-09-03  Andy Estes  <aestes@apple.com>
4059
4060         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
4061         https://bugs.webkit.org/show_bug.cgi?id=136521
4062
4063         Reviewed by Anders Carlsson.
4064
4065         Taught MigrateHeaders.make to remove WEBCORE_EXPORT from headers using this sed expression:
4066
4067             s/(^ *)WEBCORE_EXPORT /\1/g
4068
4069         This removes WEBCORE_EXPORT and a single following space character but preserves preceeding spaces.
4070
4071         * MigrateHeaders.make:
4072
4073 2014-09-04  Maciej Stachowiak  <mjs@apple.com>
4074
4075         Remove WebCoreSystemInterface glue for otherwise unused WKSI calls
4076         https://bugs.webkit.org/show_bug.cgi?id=136527
4077
4078         Reviewed by Alexey Proskuryakov.
4079
4080         * WebCoreSupport/WebSystemInterface.mm:
4081         (InitWebCoreSystemInterface):
4082
4083 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4084
4085         Remove CSS_FILTERS flag
4086         https://bugs.webkit.org/show_bug.cgi?id=136529
4087
4088         Reviewed by Dirk Schulze.
4089
4090         * Configurations/FeatureDefines.xcconfig:
4091
4092 2014-09-04  Pratik Solanki  <psolanki@apple.com>
4093
4094         Remove iOS specific disk image cache
4095         https://bugs.webkit.org/show_bug.cgi?id=136517
4096
4097         Reviewed by Antti Koivisto.
4098
4099         Disk image cache code unnecessarily complicates SharedBuffer implementation. We can remove
4100         this now since we don't enable it in WebKit2 on iOS.
4101
4102         * Misc/WebCache.mm:
4103         (+[WebCache statistics]):
4104         * WebView/WebDataSource.mm:
4105         (-[WebDataSource _setAllowToBeMemoryMapped]):
4106         (-[WebDataSource setDataSourceDelegate:]):
4107         (-[WebDataSource dataSourceDelegate]):
4108         (-[WebDataSource dealloc]):
4109         (BufferMemoryMapped): Deleted.
4110         * WebView/WebPreferenceKeysPrivate.h:
4111         * WebView/WebPreferences.mm:
4112         (+[WebPreferences initialize]):
4113         (-[WebPreferences diskImageCacheEnabled]): Deleted.
4114         (-[WebPreferences setDiskImageCacheEnabled:]): Deleted.
4115         (-[WebPreferences diskImageCacheMinimumImageSize]): Deleted.
4116         (-[WebPreferences setDiskImageCacheMinimumImageSize:]): Deleted.
4117         (-[WebPreferences diskImageCacheMaximumCacheSize]): Deleted.
4118         (-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Deleted.
4119         (-[WebPreferences _diskImageCacheSavedCacheDirectory]): Deleted.
4120         (-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Deleted.
4121         * WebView/WebPreferencesPrivate.h:
4122         * WebView/WebView.mm:
4123         (-[WebView _commonInitializationWithFrameName:groupName:]):
4124         (+[WebView _handleMemoryWarning]):
4125         (-[WebView _preferencesChanged:]):
4126
4127 2014-09-04  Daniel Bates  <dabates@apple.com>
4128
4129         [iOS] Make iOS build when ENABLE_TOUCH_EVENT and ENABLE_IOS_TOUCH_EVENTS disabled
4130         https://bugs.webkit.org/show_bug.cgi?id=136494
4131
4132         Reviewed by Andy Estes.
4133
4134         * MigrateHeaders.make: Migrate header WebEventRegion.h only when ENABLE_IOS_TOUCH_EVENTS is defined.
4135         * WebView/WebView.mm: Substitute ENABLE(IOS_TOUCH_EVENTS) for ENABLE(TOUCH_EVENTS).
4136
4137 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
4138
4139         Web Inspector: fix prefixes for subclasses of JSC::ConsoleClient
4140         https://bugs.webkit.org/show_bug.cgi?id=136476
4141
4142         Reviewed by Timothy Hatcher.
4143
4144         * Misc/WebCoreStatistics.mm:
4145         (+[WebCoreStatistics shouldPrintExceptions]):
4146         (+[WebCoreStatistics setShouldPrintExceptions:]):
4147
4148 2014-09-03  Enrica Casucci  <enrica@apple.com>
4149
4150         Remove PLATFORM(IOS) from WebCore/editing (Part 1).
4151         https://bugs.webkit.org/show_bug.cgi?id=136474
4152
4153         Reviewed by Tim Horton.
4154
4155         * WebCoreSupport/WebEditorClient.mm:
4156         (undoNameForEditAction):
4157
4158 2014-09-02  Maciej Stachowiak  <mjs@apple.com>
4159
4160         Clean up naming for and slightly refactor legacy video fullscreen support
4161         https://bugs.webkit.org/show_bug.cgi?id=136446
4162
4163         Reviewed by Jer Noble.
4164
4165         Key changes:
4166         supportsFullscreenForNode(Node*) --> supportsVideoFullscreen()
4167         enterFullscreenForNode(Node*) --> enterVideoFullscreenForVideoElement(HTMLVideoElement*)
4168         exitFullscreenForNode(Node*) --> exitVideoFullscreen()
4169         
4170         The old versions had unnecessary parameters, did not clearly distinguish their purpose
4171         from enterFullscreenForElement and friends, and wrongly claimed generality to all Nodes.
4172         Also changed many other places to use HTMLVideoElement* instead of Node* or 
4173         HTMLMediaElement* when they were in fact only used for video elements and would only
4174         work for such.
4175
4176         * WebCoreSupport/WebChromeClient.h:
4177         * WebCoreSupport/WebChromeClient.mm:
4178         (WebChromeClient::supportsVideoFullscreen): Adjust for main refactoring.
4179         Also no more need to check for video elementness.
4180         (WebChromeClient::enterVideoFullscreenForVideoElement): Adjust for main refactoring.
4181         (WebChromeClient::exitVideoFullscreen): ditto
4182         * WebView/WebView.mm:
4183         (-[WebView _enterVideoFullscreenForVideoElement:]): Adjust for main
4184         refactoring.
4185         (-[WebView _exitVideoFullscreen]): ditto
4186         (-[WebView _close]): ditto
4187         * WebView/WebViewInternal.h:
4188
4189 2014-09-03  Dan Bernstein  <mitz@apple.com>
4190
4191         Get rid of HIGH_DPI_CANVAS leftovers
4192         https://bugs.webkit.org/show_bug.cgi?id=136491
4193
4194         Reviewed by Benjamin Poulain.
4195
4196         * Configurations/FeatureDefines.xcconfig: Removed definition of ENABLE_HIGH_DPI_CANVAS
4197         and removed it from FEATURE_DEFINES.
4198
4199 2014-08-31  Tim Horton  <timothy_horton@apple.com>
4200
4201         Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor
4202         https://bugs.webkit.org/show_bug.cgi?id=136416
4203
4204         Reviewed by Dan Bernstein.
4205