2eb32285123975db28f6a1f8867c32804c145770
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-06-02  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Sam Weinig.
4
5         Need a way to install the memory pressure handler without initializing WebKit1
6         https://bugs.webkit.org/show_bug.cgi?id=61975
7
8         Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
9         -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
10         but we'd like to be able to install a memory pressure handler without creating a WebView or even
11         calling any WebView method since that will call +[WebView initialize].
12
13         * WebKit.exp:
14         * WebView/WebView.mm:
15         (WebInstallMemoryPressureHandler):
16         * WebView/WebViewPrivate.h:
17
18 2011-05-27  Stephanie Lewis  <slewis@apple.com>
19
20         Unreviewed.
21
22         Fix a typo in the order_file flag.
23
24         * Configurations/Base.xcconfig:
25
26 2011-05-27  Stephanie Lewis  <slewis@apple.com>
27
28         Rubber Stamped by Adam Roben.
29
30         Update Order Files.  Use -order_file flag since it can order more of the binary.
31
32         * Configurations/Base.xcconfig:
33         * WebKit.order:
34
35 2011-05-25  Stephanie Lewis  <slewis@apple.com>
36
37         Reviewed by Brady Eidson.
38
39         https://bugs.webkit.org/show_bug.cgi?id=61407
40         part of <rdar://problem/8675177>
41         Remove Quicklook pref.  Moving it enirely down into WebCore so it can
42         be calculated only on reloads.
43
44         * WebView/WebPreferenceKeysPrivate.h:
45         * WebView/WebPreferences.mm:
46         (+[WebPreferences initialize]):
47         * WebView/WebPreferencesPrivate.h:
48         * WebView/WebView.mm:
49         (-[WebView _preferencesChanged:]):
50
51 2011-05-24  Jer Noble  <jer.noble@apple.com>
52
53         Reviewed by Darin Adler.
54
55         Video fails to play on Vimeo
56         https://bugs.webkit.org/show_bug.cgi?id=61403
57
58         * WebCoreSupport/WebSystemInterface.mm:
59         (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
60             wkQTMovieResolvedURL.
61
62 2011-05-24  Keishi Hattori  <keishi@webkit.org>
63
64         Reviewed by Kent Tamura.
65
66         Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
67         https://bugs.webkit.org/show_bug.cgi?id=61273
68
69         * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
70
71 2011-05-24  Adam Barth  <abarth@webkit.org>
72
73         Reviewed by Eric Seidel.
74
75         Add FIXME comments about removing FrameLoader::isProcessingUserGesture
76         https://bugs.webkit.org/show_bug.cgi?id=61395
77
78         * WebView/WebView.mm:
79         (-[WebView _isProcessingUserGesture]):
80
81 2011-05-24  Michael Saboff  <msaboff@apple.com>
82
83         Reviewed by Geoffrey Garen.
84
85         Improve handling in WebCore of low memory situations
86         https://bugs.webkit.org/show_bug.cgi?id=61222
87
88         Added call to enable memory pressure handling.
89
90         * WebView/WebView.mm:
91         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
92         * WebView/WebViewInternal.h:
93
94 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
95
96         Rubberstamped by David Kilzer.
97
98         Updated some files that I forgot in my previous MHTML CL.
99
100         * Configurations/FeatureDefines.xcconfig:
101
102 2011-05-20  Jeremy Noble  <jer.noble@apple.com>
103
104         Reviewed by Simon Fraser.
105
106         Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
107         https://bugs.webkit.org/show_bug.cgi?id=61224
108
109         Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
110         versions of same.
111
112         * WebView/WebFullScreenController.mm:
113         (-[WebFullScreenController windowDidEnterFullscreen:]):
114         (-[WebFullScreenController enterFullscreen:]):
115         (-[WebFullScreenController exitFullscreen]):
116         (-[WebFullscreenWindow setRendererLayer:]):
117
118 2011-05-20  Andy Estes  <aestes@apple.com>
119
120         Reviewed by Darin Adler.
121
122         WebView loses firstResponder status when entering full-screen mode.
123         https://bugs.webkit.org/show_bug.cgi?id=61153
124
125         * Misc/WebNSWindowExtras.h:
126         * Misc/WebNSWindowExtras.m:
127         (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
128         convenience method to NSWindow that makes the given NSResponder first
129         responder only if it is a descendant of the given view.
130         * WebView/WebFullScreenController.mm:
131         (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
132         was a descendant of the browser window's first responder when entering
133         full-screen mode, set the full-screen window's first responder to that
134         same NSResponder.
135         (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
136         done in windowDidEnterFullscreen:.
137
138 2011-05-20  Enrica Casucci  <enrica@apple.com>
139
140         Reviewed by David Kilzer.
141
142         Add delegate methods about focus and blur to all elements.
143         https://bugs.webkit.org/show_bug.cgi?id=61218
144
145         We want to have delegates for these events for all the elements, not only the form elements.
146         The patch changes the name of the methods in a way that is not form element specific.
147
148         * WebCoreSupport/WebChromeClient.h:
149         * WebCoreSupport/WebChromeClient.mm:
150         (WebChromeClient::elementDidFocus):
151         (WebChromeClient::elementDidBlur):
152         * WebView/WebUIDelegatePrivate.h:
153
154 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
155
156         Reviewed by Sam Weinig.
157
158         numberOfActiveAnimations() can include animations from documents in the page cache
159         https://bugs.webkit.org/show_bug.cgi?id=53641
160
161         Pass the Frame's document as the one to count animations on.
162
163         * WebView/WebFrame.mm:
164         (-[WebFrame _numberOfActiveAnimations]):
165
166 2011-05-17  Timothy Hatcher  <timothy@apple.com>
167
168         Update the the context menu to reflect the system search provider on Mac.
169
170         <rdar://problem/9198419>
171
172         Reviewed by Sam Weinig.
173
174         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
175         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
176         create the web search context menu title.
177         * WebCoreSupport/WebSystemInterface.mm:
178         (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
179
180 2011-05-16  Emil A Eklund  <eae@chromium.org>
181
182         Reviewed by Eric Seidel.
183
184         Replace docTop/Right/Bottom/Left/Width/Height with documentRect
185         https://bugs.webkit.org/show_bug.cgi?id=60743
186
187         Replace uses of docWidth/Height with documentRect.
188
189         * WebView/WebFrame.mm:
190         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
191
192 2011-05-16  Yuzo Fujishima  <yuzo@google.com>
193
194         Reviewed by Antti Koivisto.
195
196         Fix for Bug 43704 - Web font is printed as blank if it is not cached
197         https://bugs.webkit.org/show_bug.cgi?id=43704
198
199         * WebView/WebHTMLView.mm:
200         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
201
202 2011-05-16  David Kilzer  <ddkilzer@apple.com>
203
204         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
205         <rdar://problem/9446430>
206
207         Reviewed by Mark Rowe.
208
209         * Configurations/Base.xcconfig: Fixed typo.
210
211 2011-05-13  Jon Lee  <jonlee@apple.com>
212
213         Reviewed by Simon Fraser.
214
215         Can't horizontally scroll iframes and overflow because wheel events are always accepted
216         https://bugs.webkit.org/show_bug.cgi?id=60779
217
218         * WebCoreSupport/WebChromeClient.h:
219         (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
220         (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
221
222 2011-05-13  Sam Weinig  <sam@webkit.org>
223
224         Reviewed by Anders Carlsson.
225
226         Prune #includes from FrameView.h (Part 2)
227         https://bugs.webkit.org/show_bug.cgi?id=60748
228
229         - Update files that were depending on FrameView.h #including Frame.h or
230           Page.h.
231
232         * WebView/WebClipView.mm:
233         * WebView/WebHTMLView.mm:
234         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
235
236 2011-05-12  Pratik Solanki  <psolanki@apple.com>
237
238         Reviewed by Antti Koivisto.
239
240         Part of WebCore should use CFNetwork-based loader on Mac
241         https://bugs.webkit.org/show_bug.cgi?id=51836
242
243         Use CFRunLoop when using CFNetwork.
244
245         * WebView/WebView.mm:
246         (-[WebView scheduleInRunLoop:forMode:]):
247         (-[WebView unscheduleFromRunLoop:forMode:]):
248
249 2011-05-12  Pratik Solanki  <psolanki@apple.com>
250
251         Reviewed by Antti Koivisto.
252
253         Part of WebCore should use CFNetwork-based loader on Mac
254         https://bugs.webkit.org/show_bug.cgi?id=51836
255
256         Include AuthenticationCF.h header file.
257
258         * Misc/WebDownload.mm:
259         * Plugins/WebBaseNetscapePluginView.mm:
260         * WebCoreSupport/WebFrameLoaderClient.mm:
261
262 2011-05-12  Adele Peterson  <adele@apple.com>
263
264         Reviewed by Darin Adler and Adam Barth.
265
266         Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
267         https://bugs.webkit.org/show_bug.cgi?id=60685
268
269         Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
270         we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
271
272         * Misc/SolarWalkQuirksUserScript.js: Added.
273         * WebView/WebView.mm:
274         (needsSolarWalkQuirksScript):
275         (leakSolarWalkQuirksUserScriptContents):
276         (-[WebView _injectSolarWalkQuirksScript]):
277         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
278
279 2011-05-12  Jia Pu  <jpu@apple.com>
280
281         Reviewed by Darin Adler.
282
283         Regression caused by changeset 86281
284         https://bugs.webkit.org/show_bug.cgi?id=60712
285         <rdar://problem/9427970>
286
287         Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
288         So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
289         returns. So we don't need to use the condition to coordinate between these two function. In fact,
290         all callbacks are delivered on main thread. We don't really need any locking here.
291
292         Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
293         been removed.
294
295         * WebCoreSupport/CorrectionPanel.h:
296         * WebCoreSupport/CorrectionPanel.mm:
297         (CorrectionPanel::CorrectionPanel):
298         (CorrectionPanel::show):
299         (CorrectionPanel::dismiss):
300         (CorrectionPanel::dismissInternal):
301         (CorrectionPanel::handleAcceptedReplacement):
302         * WebCoreSupport/WebEditorClient.mm:
303         (WebEditorClient::dismissCorrectionPanelSoon):
304
305 2011-05-12  Patrick Gansterer  <paroga@webkit.org>
306
307         Reviewed by Adam Barth.
308
309         Enable OwnPtr strict mode in PluginHalter
310         https://bugs.webkit.org/show_bug.cgi?id=60681
311
312         * WebView/WebView.mm:
313         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
314
315 2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
316
317         Reviewed by Darin Adler.
318
319         String operator+ reallocates unnecessarily when concatting > 2 strings
320         https://bugs.webkit.org/show_bug.cgi?id=58420
321
322         Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
323
324         * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
325         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
326
327 2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
328
329         Reviewed by Darin Adler.
330
331         Perform some forward declarations suggested by include-what-you-use
332         https://bugs.webkit.org/show_bug.cgi?id=60545
333
334         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
335         * WebView/WebFrame.mm:
336
337 2011-05-11  Jia Pu  <jpu@apple.com>
338
339         Reviewed by Darin Adler.
340
341         CorrectionPanel sometimes hangs in dismissSoon().
342         https://bugs.webkit.org/show_bug.cgi?id=60599
343         <rdar://problem/9313628>
344
345         Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
346         to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
347         for condition checking.
348
349         * WebCoreSupport/CorrectionPanel.h:
350         * WebCoreSupport/CorrectionPanel.mm:
351         (CorrectionPanel::CorrectionPanel):
352         (CorrectionPanel::show):
353         (CorrectionPanel::dismissSoon):
354         (CorrectionPanel::dismissInternal):
355         (CorrectionPanel::handleAcceptedReplacement):
356
357 2011-05-10  Anton D'Auria  <adauria@apple.com>
358
359         Reviewed by David Levin.
360
361         Add ApplicationCache API to get disk usage per origin
362         https://bugs.webkit.org/show_bug.cgi?id=57127
363
364         Added Mac port API.
365
366         * WebCoreSupport/WebApplicationCache.h:
367         * WebCoreSupport/WebApplicationCache.mm:
368         (+[WebApplicationCache diskUsageForOrigin:]):
369
370 2011-05-10  Anton D'Auria  <adauria@apple.com>
371
372         Reviewed by Alexey Proskuryakov.
373
374         Add ApplicationCache API to get disk usage per origin
375         https://bugs.webkit.org/show_bug.cgi?id=57127
376
377         Added Mac port API.
378
379         * WebCoreSupport/WebApplicationCache.h:
380         * WebCoreSupport/WebApplicationCache.mm:
381         (+[WebApplicationCache diskUsageForOrigin:]):
382
383 2011-05-10  Beth Dakin  <bdakin@apple.com>
384
385         Reviewed by Darin Adler.
386
387         https://bugs.webkit.org/show_bug.cgi?id=60582
388         Crash switching overlay/non-overlay scrollbar preference still possible
389         -and corresponding-
390         <rdar://problem/9323983>
391
392         * WebCoreSupport/WebSystemInterface.mm:
393         (InitWebCoreSystemInterface):
394
395 2011-05-09  Jeremy Noble  <jer.noble@apple.com>
396
397         Reviewed by Darin Adler.
398
399         Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
400         https://bugs.webkit.org/show_bug.cgi?id=60496
401
402         When animating into and out of full screen, order out and back in the original webView window,
403         disabling animations when necessary.  The exitFullscreen method was targeting the wrong window,
404         as the webView is hosted in the full screen window when we ask for it's parent window.
405
406         * WebView/WebFullScreenController.mm:
407         (-[WebFullScreenController windowDidEnterFullscreen:]):
408         (-[WebFullScreenController exitFullscreen]):
409
410 2011-05-04  Philippe Normand  <pnormand@igalia.com>
411
412         Reviewed by Dimitri Glazkov.
413
414         Implement LayoutTestController::pseudoShadowId()
415         https://bugs.webkit.org/show_bug.cgi?id=60034
416
417         * DOM/WebDOMOperations.mm:
418         (-[DOMElement _shadowPseudoId]):
419         * DOM/WebDOMOperationsPrivate.h:
420
421 2011-05-05  Dan Bernstein  <mitz@apple.com>
422
423         Reviewed by Simon Fraser.
424
425         WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
426
427         * WebCoreSupport/WebSystemInterface.mm:
428         (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
429
430 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
431
432         Reviewed by Eric Seidel.
433
434         Rename SelectionController to FrameSelection
435         https://bugs.webkit.org/show_bug.cgi?id=60234
436
437         * WebView/WebFrame.mm:
438         (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
439         * WebView/WebFrameInternal.h:
440         * WebView/WebHTMLView.mm:
441         * WebView/WebTextCompletionController.mm:
442         (-[WebTextCompletionController doCompletion]):
443         * WebView/WebView.mm:
444
445 2011-05-04  Cris Neckar  <cdn@chromium.org>
446
447         Reviewed by Adam Barth.
448
449         Expose WebView directly through ChromeClient.
450         https://bugs.webkit.org/show_bug.cgi?id=49902
451
452         * WebCoreSupport/WebChromeClient.h:
453         (WebChromeClient::webView):
454         * WebView/WebFrame.mm:
455         (kit):
456
457 2011-05-04  Tao Bai  <michaelbai@chromium.org>
458
459         Reviewed by David Kilzer.
460
461         Populate touch-icon url to FrameLoaderClient
462         https://bugs.webkit.org/show_bug.cgi?id=59143
463
464         Respect the interface change in FrameLoaderClient.
465
466         * Configurations/FeatureDefines.xcconfig:
467         * WebCoreSupport/WebFrameLoaderClient.h:
468         * WebCoreSupport/WebFrameLoaderClient.mm:
469         (WebFrameLoaderClient::dispatchDidChangeIcons):
470
471 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
472
473         Reviewed by Dimitri Glazkov.
474
475         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
476         https://bugs.webkit.org/show_bug.cgi?id=58703
477
478         * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
479
480 2011-05-02  Adam Roben  <aroben@apple.com>
481
482         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
483
484         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
485         doesn't work, but should
486
487         Reviewed by Adam Barth.
488
489         * History/WebHistory.mm:
490         * Plugins/WebNetscapePluginEventHandler.mm:
491         * WebView/WebView.mm:
492
493 2011-05-02  Brady Eidson  <beidson@apple.com>
494
495         Reviewed by Anders Carlsson.
496
497         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
498         In Aperture, a WebView might be dealloc'ed before it finishes loading.
499
500         * WebView/WebView.mm:
501         (needsSelfRetainWhileLoadingQuirk):
502         (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
503         (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
504         (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
505         (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
506
507 2011-05-02  Adam Barth  <abarth@webkit.org>
508
509         Reviewed by David Levin.
510
511         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
512         https://bugs.webkit.org/show_bug.cgi?id=59924
513
514         * History/WebHistory.mm:
515         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
516         * Plugins/WebBaseNetscapePluginView.mm:
517         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
518         * WebCoreSupport/WebFrameLoaderClient.mm:
519         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
520         * WebView/WebView.mm:
521         (-[WebView _injectMailQuirksScript]):
522         (-[WebView _injectOutlookQuirksScript]):
523         (toStringVector):
524
525 2011-05-02  Sam Weinig  <sam@webkit.org>
526
527         Reviewed by Adam Barth.
528
529         Prune some #includes from DOMWindow.h
530         https://bugs.webkit.org/show_bug.cgi?id=59907
531
532         * Plugins/WebBaseNetscapePluginView.mm:
533         * WebView/WebFrame.mm:
534         Add now missing SecurityOrigin.h #includes.
535
536 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
537
538         Reviewed by Eric Seidel.
539
540         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
541         https://bugs.webkit.org/show_bug.cgi?id=59837
542
543         Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
544
545         * WebView/WebHTMLView.mm:
546         (-[WebHTMLView menuForEvent:]):
547         (-[WebHTMLView acceptsFirstMouse:]):
548         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
549
550 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
551
552         Reviewed by Eric Seidel.
553
554         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
555         https://bugs.webkit.org/show_bug.cgi?id=59835
556
557         Moved currentKeyboardEvent.
558
559         * WebView/WebHTMLView.mm:
560         (currentKeyboardEvent):
561         (-[WebHTMLView becomeFirstResponder]):
562
563 2011-04-29  Dean Jackson  <dino@apple.com>
564
565         Reviewed by Simon Fraser.
566
567         Add ENABLE macro for WebKitAnimation
568         https://bugs.webkit.org/show_bug.cgi?id=59729
569
570         Add new feature to toggle WebKit Animation API.
571
572         * Configurations/FeatureDefines.xcconfig:
573
574 2011-04-28  David Kilzer  <ddkilzer@apple.com>
575
576         <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
577
578         Reviewed by Anders Carlsson.
579
580         * History/WebHistory.mm:
581         (-[WebHistoryPrivate init]):
582         * Misc/WebElementDictionary.mm:
583         (-[WebElementDictionary initWithHitTestResult:]):
584         * Misc/WebIconDatabase.mm:
585         (-[WebIconDatabase init]):
586         * Plugins/WebPluginController.mm:
587         (-[WebPluginController initWithDocumentView:]):
588         * Plugins/WebPluginRequest.m:
589         (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
590         * WebCoreSupport/WebEditorClient.mm:
591         (-[WebEditCommand initWithEditCommand:]):
592         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
593         (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
594         * WebView/WebNavigationData.mm:
595         (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
596
597 2011-04-28  David Levin  <levin@chromium.org>
598
599         Reviewed by Adam Barth.
600
601         Remove IMAGE_RESIZER related code.
602         https://bugs.webkit.org/show_bug.cgi?id=59735
603
604         * Configurations/FeatureDefines.xcconfig:
605
606 2011-04-28  Adam Barth  <abarth@webkit.org>
607
608         Reviewed by Eric Seidel.
609
610         Remove WML
611         https://bugs.webkit.org/show_bug.cgi?id=59678
612
613         Remove WML-related configuration options and private APIs.
614
615         * Configurations/FeatureDefines.xcconfig:
616         * WebCoreSupport/WebChromeClient.mm:
617         (stringForMessageSource):
618         * WebView/WebFramePrivate.h:
619         * WebView/WebUIDelegatePrivate.h:
620
621 2011-04-28  Brian Weinstein  <bweinstein@apple.com>
622
623         Reviewed by Timothy Hatcher.
624
625         Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
626         https://bugs.webkit.org/show_bug.cgi?id=59747
627
628         Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
629         Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
630
631         * WebCoreSupport/WebInspectorClient.mm:
632         (-[WebInspectorWindowController showWebInspector:]):
633         (-[WebInspectorWindowController showErrorConsole:]):
634         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
635         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
636         (-[WebInspectorWindowController validateUserInterfaceItem:]):
637
638 2011-04-28  David Kilzer  <ddkilzer@apple.com>
639
640         <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
641
642         Reviewed by Dan Bernstein.
643
644         * WebView/WebFullScreenController.mm:
645         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
646         Use a RetainPtr to hold the CALayer and to fix the leak.
647
648 2011-04-28  David Kilzer  <ddkilzer@apple.com>
649
650         Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
651
652         Addresses review comment from Darin Adler.
653
654         * WebView/WebPDFView.mm:
655         (-[WebPDFView menuForEvent:]): Use a local variable and -release
656         instead of -autorelease.
657
658 2011-04-28  Anders Carlsson  <andersca@apple.com>
659
660         Fix a thinko - separateRealmLabel is not an NSImageView.
661
662         * Panels/WebAuthenticationPanel.h:
663
664 2011-04-28  David Kilzer  <ddkilzer@apple.com>
665
666         <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
667
668         Reviewed by Dan Bernstein.
669
670         * WebView/WebPDFView.mm:
671         (-[WebPDFView menuForEvent:]): Call -autorelease after copying
672         each NSMenuItem.  Regressed in r9566 for Bug 3711.
673
674 2011-04-28  Enrica Casucci  <enrica@apple.com>
675
676         Reviewed by Beth Dakin.
677
678         Momentum scroll tweak for WebKit.
679         https://bugs.webkit.org/show_bug.cgi?id=59723
680         <rdar://problem/9259933>
681
682         * WebView/WebDynamicScrollBarsView.mm:
683         (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
684
685 2011-04-27  Anders Carlsson  <andersca@apple.com>
686
687         Follow-up Leopard build fix.
688
689         * Carbon/HIViewAdapter.m:
690         (_webkit_NSView_setNeedsDisplayInRect):
691
692 2011-04-27  Anders Carlsson  <andersca@apple.com>
693
694         More clang++ 32-bit build fixes.
695
696         * Carbon/CarbonWindowAdapter.mm:
697         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
698         (-[CarbonWindowAdapter setContentView:]):
699         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
700         * Carbon/HIViewAdapter.m:
701         (_webkit_NSView_setNeedsDisplayInRect):
702         * Panels/WebAuthenticationPanel.h:
703         * Plugins/WebBaseNetscapePluginView.mm:
704         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
705         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
706         (getCarbonEvent):
707         * WebCoreSupport/WebChromeClient.mm:
708         (WebChromeClient::scrollRectIntoView):
709         * WebCoreSupport/WebViewFactory.mm:
710         (-[WebViewFactory accessibilityConvertScreenRect:]):
711         * WebView/WebFrameView.mm:
712         (-[WebFrameView _scrollToBeginningOfDocument]):
713         (-[WebFrameView _scrollToEndOfDocument]):
714         * WebView/WebFullScreenController.mm:
715         (-[WebFullScreenController windowDidEnterFullscreen:]):
716         * WebView/WebHTMLView.mm:
717         (-[WebHTMLView _hitViewForEvent:]):
718         (coreGraphicsScreenPointForAppKitScreenPoint):
719         * WebView/WebPDFView.mm:
720         (-[WebPDFView setScrollPoint:]):
721
722 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
723
724         Reviewed by Pavel Feldman.
725
726         REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
727         https://bugs.webkit.org/show_bug.cgi?id=44230
728
729         Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
730         inspector is closed.
731
732         * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
733         comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
734         pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
735         There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
736         front-end page.
737
738         Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
739         (-[WebInspectorWindowController initWithInspectedWebView:]):
740         (-[WebInspectorWindowController close]):
741         (-[WebInspectorWindowController showWindow:]):
742         (-[WebInspectorWindowController setAttachedWindowHeight:]):
743         (-[WebInspectorWindowController destroyInspectorView:]):
744
745 2011-04-26  Sam Weinig  <sam@webkit.org>
746
747         Reviewed by David Hyatt.
748
749         Remove Datagrid from the tree
750         https://bugs.webkit.org/show_bug.cgi?id=59543
751
752         * Configurations/FeatureDefines.xcconfig:
753         Remove feature.
754
755 2011-04-26  Dan Bernstein  <mitz@apple.com>
756
757         Reviewed by Mark Rowe.
758
759         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
760
761         * Configurations/Base.xcconfig:
762         * Configurations/CompilerVersion.xcconfig: Added.
763
764 2011-04-25  Adam Barth  <abarth@webkit.org>
765
766         Reviewed by David Levin.
767
768         WebKit2 should play nice with strict OwnPtrs
769         https://bugs.webkit.org/show_bug.cgi?id=59426
770
771         Fix include ordering.
772
773         * WebView/WebDeviceOrientationProviderMock.mm:
774
775 2011-04-25  Adam Barth  <abarth@webkit.org>
776
777         Reviewed by David Levin.
778
779         WebKit1 should build cleanly with strict OwnPtrs
780         https://bugs.webkit.org/show_bug.cgi?id=59424
781
782         * History/WebHistoryItem.mm:
783         (-[WebHistoryItem initFromDictionaryRepresentation:]):
784         * Plugins/WebNetscapePluginEventHandler.h:
785         * Plugins/WebNetscapePluginEventHandler.mm:
786         (WebNetscapePluginEventHandler::create):
787         * Plugins/WebNetscapePluginView.mm:
788         (-[WebNetscapePluginView createPlugin]):
789         * WebView/WebDeviceOrientationProviderMock.mm:
790         * WebView/WebTextIterator.mm:
791         (-[WebTextIterator initWithRange:]):
792
793 2011-04-25  Jon Lee  <jonlee@apple.com>
794
795         Reviewed by Maciej Stachowiak.
796
797         Overlay scroller hard to see on pages with dark background (59183)
798         https://bugs.webkit.org/show_bug.cgi?id=59183
799         <rdar://problem/8975367>
800         
801         * WebCoreSupport/WebSystemInterface.mm:
802         (InitWebCoreSystemInterface): adding method to allow changing style
803
804 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
805
806         Unreviewed, rolling out r84740.
807         http://trac.webkit.org/changeset/84740
808         https://bugs.webkit.org/show_bug.cgi?id=59290
809
810         change breaks apple internal builds and is incorrect
811         (Requested by smfr on #webkit).
812
813         * WebCoreSupport/WebSystemInterface.mm:
814         (InitWebCoreSystemInterface):
815
816 2011-04-22  Jon Lee  <jonlee@apple.com>
817
818         Reviewed by Beth Dakin.
819
820         Overlay scroller hard to see on pages with dark background (59183)
821         https://bugs.webkit.org/show_bug.cgi?id=59183
822         <rdar://problem/8975367>
823         
824         * WebCoreSupport/WebSystemInterface.mm:
825         (InitWebCoreSystemInterface): adding method to allow changing style
826
827 2011-04-19  Jer Noble  <jer.noble@apple.com>
828
829         Reviewed by Daniel Bates.
830
831         Full Screen from within an <iframe> does not cause <iframe> to resize.
832         https://bugs.webkit.org/show_bug.cgi?id=58638
833
834         Tests: fullscreen/full-screen-frameset-allowed.html
835                fullscreen/full-screen-frameset-not-allowed.html
836
837         Return the _element's document instead of the WKView's document, which 
838         will be different in the case of elements within <iframe>s.
839
840         * WebView/WebFullScreenController.mm:
841         (-[WebFullScreenController _document]):
842
843 2011-04-22  Jer Noble  <jer.noble@apple.com>
844
845         Reviewed by Maciej Stachowiak.
846
847         Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
848         https://bugs.webkit.org/show_bug.cgi?id=59147
849
850         Add a new user default preference, and plumb that preference down to WebCore
851         Settings. Allow the fullScreenEnabled preference to override the new 
852         isAVFoundationEnabled preference, so that clients of the legacy full screen
853         mode will continue to use that mode normally.
854
855         * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
856         * WebView/WebPreferences.mm:
857         (+[WebPreferences initialize]): Set the default value of new
858             preference.
859         (-[WebPreferences setAVFoundationEnabled:]): Added.
860         (-[WebPreferences isAVFoundationEnabled]): Added.
861         * WebView/WebPreferencesPrivate.h:
862         * WebView/WebView.mm:
863         (-[WebView _preferencesChanged:]): Update the WebCore settings with the
864             new values from WebPreferences.
865
866 2011-04-22  Sam Weinig  <sam@webkit.org>
867
868         Reviewed by Gavin Barraclough.
869
870         Remove remaining uses of deprecated version of toJS
871         https://bugs.webkit.org/show_bug.cgi?id=59170
872
873         * DOM/WebDOMOperations.mm:
874         (-[DOMElement _shadowRoot:]):
875         (-[DOMElement _ensureShadowRoot:]):
876         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
877
878 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
879
880         Reviewed by Adam Roben.
881
882         Add a feature define to allow <details> and <summary> to be disabled
883         https://bugs.webkit.org/show_bug.cgi?id=59118
884         <rdar://problem/9257045>
885
886         * Configurations/FeatureDefines.xcconfig:
887
888 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
889
890         Reviewed by Sam Weinig.
891
892         Add Frame* to the argument lists of canCopyCut and canPaste
893         https://bugs.webkit.org/show_bug.cgi?id=59153
894
895         * WebCoreSupport/WebEditorClient.h:
896         * WebCoreSupport/WebEditorClient.mm:
897         (WebEditorClient::canCopyCut):
898         (WebEditorClient::canPaste):
899
900 2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
901
902         Unreviewed, rolling out r82052.
903         http://trac.webkit.org/changeset/82052
904         https://bugs.webkit.org/show_bug.cgi?id=59135
905
906         New full screen api should be opt-in, not opt-out. (Requested
907         by jernoble on #webkit).
908
909         * WebView/WebPreferences.mm:
910         (+[WebPreferences initialize]):
911
912 2011-04-21  Beth Dakin  <bdakin@apple.com>
913
914         Reviewed by Dan Bernstein.
915
916         https://bugs.webkit.org/show_bug.cgi?id=59048
917         Need to track whether overlay scrollbar is currently visible and in lower-
918         righthand corner
919         -and corresponding-
920         <rdar://problem/9211232>
921
922         A new WebSystemInterface is needed for this.
923         * WebCoreSupport/WebSystemInterface.mm:
924         (InitWebCoreSystemInterface):
925
926 2011-04-21  Dirk Schulze  <krit@webkit.org>
927
928         Reviewed by Nikolas Zimmermann.
929
930         SVG feDropShadow implementation of SVG Filters 1.2
931         https://bugs.webkit.org/show_bug.cgi?id=52513
932
933         * MigrateHeaders.make:
934
935 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
936
937         Reviewed by Dimitri Glazkov.
938
939         layoutTestController can create and destroy shadow DOM
940         https://bugs.webkit.org/show_bug.cgi?id=59058
941
942         Support for new methods in Mac DRT.
943
944         * DOM/WebDOMOperations.mm:
945         (-[DOMElement _ensureShadowRoot:]):
946         (-[DOMElement _removeShadowRoot]):
947         * DOM/WebDOMOperationsPrivate.h:
948
949 2011-04-20  Eric Carlson  <eric.carlson@apple.com>
950
951         Reviewed by Dan Bernstein.
952
953         Adopt QTKit API for listing and deleting file in its media cache.
954         <rdar://problem/9130029> 
955
956         * WebCoreSupport/WebSystemInterface.mm:
957         (InitWebCoreSystemInterface): Initialize new functions.
958
959 2011-04-19  Matthew Delaney  <mdelaney@apple.com>
960
961         Reviewed by Simon Fraser.
962
963         WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
964         https://bugs.webkit.org/show_bug.cgi?id=58936
965
966         * WebView/WebPreferences.mm:
967         (+[WebPreferences initialize]):
968
969 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
970
971         Reviewed by Pavel Feldman.
972
973         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
974         https://bugs.webkit.org/show_bug.cgi?id=58883
975
976         * WebCoreSupport/WebFrameLoaderClient.h:
977         * WebCoreSupport/WebFrameLoaderClient.mm:
978         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
979
980 2011-04-18  Jia Pu  <jpu@apple.com>
981
982         Reviewed by Mark Rowe.
983
984         WebKit needs to stop importing <AppKit/NSTextChecker.h>
985         https://bugs.webkit.org/show_bug.cgi?id=58798
986         <rdar://problem/9294938>
987
988         Use public header <AppKit/NSSpellChecker.h> instead.
989
990         * WebCoreSupport/CorrectionPanel.h:
991         * WebCoreSupport/CorrectionPanel.mm:
992         (correctionIndicatorType):
993         (CorrectionPanel::show):
994         (CorrectionPanel::dismissInternal):
995         (CorrectionPanel::handleAcceptedReplacement):
996         * WebCoreSupport/WebEditorClient.mm:
997         * WebView/WebView.mm:
998
999 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
1000
1001         Reviewed by Timothy Hatcher.
1002
1003         Stop using -[NSString initWithContentsOfFile:]
1004         https://bugs.webkit.org/show_bug.cgi?id=58763
1005
1006         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
1007
1008         * WebView/WebView.mm:
1009         (leakMailQuirksUserScriptContents):
1010         (leakOutlookQuirksUserScriptContents):
1011
1012 2011-04-17  David Kilzer  <ddkilzer@apple.com>
1013
1014         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
1015         <rdar://problem/9268729>
1016
1017         Reviewed by Dan Bernstein.
1018
1019         This replaces support for the WebKitEnableHTTPPipelining user
1020         default with methods on the WebCore::ResourceRequest class in
1021         WebCore, the WebView class in WebKit1, and the WebContext class
1022         in WebKit2.  It also removes support for the
1023         WebKitForceHTTPPipeliningPriorityHigh user default which was not
1024         needed.
1025
1026         * WebView/WebView.mm:
1027         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
1028         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
1029         * WebView/WebViewPrivate.h:
1030         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
1031         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
1032
1033 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
1034
1035         Reviewed by Dan Bernstein.
1036
1037         Assign to self in WebInspectorWindowController constructors
1038         https://bugs.webkit.org/show_bug.cgi?id=58749
1039
1040         * WebCoreSupport/WebInspectorClient.mm:
1041         (-[WebInspectorWindowController init]):
1042         (-[WebInspectorWindowController initWithInspectedWebView:]):
1043
1044 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
1045
1046         Reviewed by Timothy Hatcher.
1047
1048         Move WebNodeHighlighter into its own file
1049         https://bugs.webkit.org/show_bug.cgi?id=58746
1050
1051         Extract this class into its own file alongside the
1052         other WebNodeHighlight files. In doing so do some
1053         cleanup on WebInspectorClient removing some methods
1054         that were never called.
1055
1056         * WebCoreSupport/WebInspectorClient.mm:
1057         (WebInspectorClient::WebInspectorClient): style fix.
1058         * WebInspector/WebNodeHighlighter.h: Added.
1059         * WebInspector/WebNodeHighlighter.mm: Added.
1060         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
1061         (-[WebNodeHighlighter dealloc]):
1062         (-[WebNodeHighlighter highlightNode:]):
1063         (-[WebNodeHighlighter hideHighlight]):
1064         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
1065         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
1066
1067 2011-04-15  Jia Pu  <jpu@apple.com>
1068
1069         Reviewed by Dan Bernstein.
1070
1071         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
1072         https://bugs.webkit.org/show_bug.cgi?id=58717
1073
1074         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
1075
1076         * WebCoreSupport/CorrectionPanel.mm:
1077         (CorrectionPanel::show):
1078
1079 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1080
1081         Reviewed by James Robinson.
1082
1083         Add a flag to guard Page Visibility API changes.
1084         https://bugs.webkit.org/show_bug.cgi?id=58464
1085
1086         * Configurations/FeatureDefines.xcconfig:
1087
1088 2011-04-15  Oliver Hunt  <oliver@apple.com>
1089
1090         GC allocate Structure
1091         https://bugs.webkit.org/show_bug.cgi?id=58483
1092
1093         Rolling r83894 r83827 r83810 r83809 r83808 back in with
1094         a workaround for the gcc bug seen by the gtk bots
1095
1096         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1097         * Plugins/Hosted/ProxyInstance.mm:
1098         (WebKit::ProxyRuntimeMethod::createStructure):
1099         * Plugins/Hosted/ProxyRuntimeObject.h:
1100         (WebKit::ProxyRuntimeObject::createStructure):
1101
1102 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
1103
1104         Reviewed by Dan Bernstein.
1105
1106         WebKit2: Password field input does not switch to ASCII-compatible source
1107         https://bugs.webkit.org/show_bug.cgi?id=58583
1108         <rdar://problem/9059651>
1109
1110         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
1111         necessary logic, needed to return a nil text input context when in password fields.
1112
1113         * WebView/WebHTMLView.mm:
1114         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
1115         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
1116         (-[WebHTMLView windowDidResignKey:]): Ditto.
1117         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
1118         because the first responder is still different an this point, so set a boolean variable to
1119         let _updateSecureInputState know what's going on.
1120         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
1121         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
1122         allowed input sources accorsing to current selection.
1123         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
1124
1125 2011-04-15  Sam Weinig  <sam@webkit.org>
1126
1127         Reviewed by Maciej Stachowiak.
1128
1129         Make mac WebKit1 use the default localization strategy
1130         https://bugs.webkit.org/show_bug.cgi?id=58628
1131
1132         * WebCoreSupport/WebPlatformStrategies.h:
1133         * WebCoreSupport/WebPlatformStrategies.mm:
1134         Remove the localization strategy code. The equivalent is now
1135         in WebCore/platform/DefaultLocalizationStrategy.cpp.
1136
1137 2011-04-15  Anna Cavender  <annacc@chromium.org>
1138
1139         Reviewed by Eric Carlson.
1140
1141         Renaming TRACK feature define to VIDEO_TRACK
1142         https://bugs.webkit.org/show_bug.cgi?id=53556
1143
1144         * Configurations/FeatureDefines.xcconfig:
1145
1146 2011-04-14  Pratik Solanki  <psolanki@apple.com>
1147
1148         Reviewed by David Kilzer.
1149
1150         Set minimum priority for fast lane connections
1151         https://bugs.webkit.org/show_bug.cgi?id=58353
1152
1153         * WebCoreSupport/WebSystemInterface.mm:
1154         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
1155
1156 2011-04-13  Sam Weinig  <sam@webkit.org>
1157
1158         Reviewed by Gavin Barraclough.
1159
1160         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
1161         <rdar://problem/9260518>
1162
1163         * WebCoreSupport/WebSystemInterface.mm:
1164         (InitWebCoreSystemInterface):
1165         Initialize new WKSI functions.
1166
1167 2011-04-13  David Kilzer  <ddkilzer@apple.com>
1168
1169         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
1170
1171         Reviewed by Anders Carlsson.
1172
1173         Fixes the following warning with -Wcast-align enabled:
1174
1175             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
1176                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
1177                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1178
1179         * Plugins/WebBasePluginPackage.mm:
1180         (-[WebBasePluginPackage isNativeLibraryData:]): Added
1181         COMPILE_ASSERT() to make sure our pointer math is valid.
1182         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
1183         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
1184         casts with reinterpret_cast.
1185
1186 2011-04-12  Enrica Casucci  <enrica@apple.com>
1187
1188         Reviewed by Alexey Proskuryakov.
1189
1190         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
1191         https://bugs.webkit.org/show_bug.cgi?id=58382
1192         <rdar://problem/9239370>
1193
1194         Execution of some editing commands could trigger a call to selectedRange that
1195         internally calls executeSavedKeypressCommands creating an infinite recursion.
1196
1197         * WebView/WebHTMLView.mm:
1198         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
1199         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
1200
1201 2011-04-12  Alice Liu  <alice.liu@apple.com>
1202
1203         Reviewed by Sam Weinig.
1204
1205         https://bugs.webkit.org/show_bug.cgi?id=58292
1206         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1207
1208         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
1209         * WebView/WebPreferences.mm:
1210         (+[WebPreferences initialize]): Initialize to false.
1211         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
1212         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
1213         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
1214         * WebView/WebView.mm:
1215         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
1216
1217 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
1218
1219         Reviewed by Maciej Stachowiak.
1220
1221         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1222         https://bugs.webkit.org/show_bug.cgi?id=58175
1223         <rdar://problem/9060555>
1224
1225         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1226         should be changed to match WebKit2.
1227
1228 2011-04-06  Timothy Hatcher  <timothy@apple.com>
1229
1230         Fix a bug where the context menu does not show in PDF documents if there is no
1231         UI delegate or the UI delegate does not respond to the context menu selector.
1232
1233         https://webkit.org/b/57958
1234
1235         Reviewed by Darin Adler.
1236
1237         * WebView/WebView.mm:
1238         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
1239         if UIDelegate is nil or doesn't respond to the selector. So check that
1240         here to distinguish between using defaultMenuItems or the delegate
1241         really returning nil to say "no context menu".
1242
1243 2011-04-11  Jer Noble  <jer.noble@apple.com>
1244
1245         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
1246
1247         * WebView/WebFullScreenController.mm:
1248         (-[WebFullScreenController enterFullscreen:]):
1249
1250 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
1251
1252         Reviewed by Oliver Hunt.
1253
1254         A few heap-related renames and file moves.
1255         
1256         WeakGCPtr<T> => Weak<T>
1257         Global<T> => Strong<T>
1258         collector/ => heap/
1259         collector/* => heap/*
1260         runtime/WeakGCPtr.h => heap/Weak.h
1261         
1262         (Eventually, even more files should move into the heap directory. Like
1263         Heap.h and Heap.cpp, for example.)
1264
1265         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1266         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1267         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
1268         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
1269         (WebKit::NetscapePluginInstanceProxy::evaluate):
1270         * WebView/WebScriptDebugger.h:
1271
1272 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
1273
1274         Reviewed by Darin Adler.
1275
1276         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1277         https://bugs.webkit.org/show_bug.cgi?id=58175
1278         <rdar://problem/9060555>
1279
1280         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1281         should be changed to match WebKit2.
1282
1283 2011-04-08  Alpha Lam  <hclam@chromium.org>
1284
1285         Unreviewed, rolling out r83335.
1286         http://trac.webkit.org/changeset/83335
1287         https://bugs.webkit.org/show_bug.cgi?id=53556
1288
1289         GTK and QT bots are broken
1290
1291         * Configurations/FeatureDefines.xcconfig:
1292
1293 2011-04-07  Anna Cavender  <annacc@chromium.org>
1294
1295         Reviewed by Eric Carlson.
1296
1297         Setup ENABLE(TRACK) feature define
1298         https://bugs.webkit.org/show_bug.cgi?id=53556
1299
1300         * Configurations/FeatureDefines.xcconfig:
1301
1302 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
1303
1304         Reviewed by Darin Adler.
1305
1306         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
1307         https://bugs.webkit.org/show_bug.cgi?id=58128
1308         <rdar://problem/9244553>
1309         
1310         The root of the problem here was an O(N^2) issue - each WebView,
1311         upon having its preferences initialized, would broadcast a
1312         notification that was listened to by all other WebViews sharing
1313         its preferences.
1314         
1315         To maintain the API contract, I split the notification into two,
1316         one that is for public API consumption, and the other which is for
1317         internal use only. Changes that don't need to be picked up by
1318         other WebViews broadcast the public notification only. And we
1319         avoid WebView broadcasting a notification just to get itself to
1320         update.
1321
1322         * Misc/WebIconDatabase.mm:
1323         (-[WebIconDatabase _startUpIconDatabase]):
1324         (-[WebIconDatabase _shutDownIconDatabase]):
1325         * Plugins/WebBaseNetscapePluginView.mm:
1326         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1327         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
1328         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1329         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
1330         * WebView/WebPreferences.mm:
1331         (-[WebPreferences initWithIdentifier:]):
1332         (-[WebPreferences _setStringValue:forKey:]):
1333         (-[WebPreferences _setIntegerValue:forKey:]):
1334         (-[WebPreferences _setFloatValue:forKey:]):
1335         (-[WebPreferences _setBoolValue:forKey:]):
1336         (-[WebPreferences _setLongLongValue:forKey:]):
1337         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1338         (-[WebPreferences _postPreferencesChangedNotification]):
1339         (-[WebPreferences _postPreferencesChangedAPINotification]):
1340         * WebView/WebPreferencesPrivate.h:
1341         * WebView/WebView.mm:
1342         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1343         (-[WebView _preferencesChangedNotification:]):
1344         (-[WebView _preferencesChanged:]):
1345         (-[WebView setUsesPageCache:]):
1346         (+[WebView initialize]):
1347         (-[WebView setPreferences:]):
1348         (-[WebView _keyboardUIMode]):
1349         * WebView/WebViewInternal.h:
1350
1351 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1352
1353         Revert ENABLE_TRACK patch due to compile failures.
1354
1355         * Configurations/FeatureDefines.xcconfig:
1356
1357 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
1358
1359         Reviewed by Anders Carlsson.
1360
1361         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
1362         https://bugs.webkit.org/show_bug.cgi?id=58066
1363         <rdar://problem/8965302>
1364
1365         * WebView/WebHTMLRepresentation.mm:
1366         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1367         * WebView/WebHTMLView.mm:
1368         (-[WebHTMLView attributedSubstringFromRange:]):
1369         (-[WebHTMLView attributedString]):
1370         (-[WebHTMLView selectedAttributedString]):
1371         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
1372
1373 2011-04-07  Andy Estes  <aestes@apple.com>
1374
1375         Reviewed by Darin Adler.
1376
1377         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
1378         not included when replying to an email.
1379         https://bugs.webkit.org/show_bug.cgi?id=57794
1380         
1381         Outlook populates a reply message by creating an empty WebView and
1382         using DOM API to populate the WebView's empty document with content
1383         from the original message. It expects the initial empty document to
1384         simply be "<html></html>", and it proceeds to dynamically create and
1385         append a BODY node and add the original message content as a child of
1386         that node. Outlook then takes the innerHTML of the frame's first body
1387         element and copies it into a *new* document that is displayed and
1388         edited in the reply message window.
1389         
1390         Due to implementing the HTML5 tree building algorithm in r64712,
1391         initial empty documents went from being "<html></html>" to being
1392         "<html><head></head><body></body></html>". Outlook still dynamically
1393         creates a BODY node to parent the original message content, but this
1394         BODY node duplicates the one created by the tree builder. When Outlook
1395         then takes the innerHTML of the first body element to populate the
1396         reply message window it gets the empty body element created by the
1397         parser, not the one it created with the original message content.
1398         
1399         Fix this by injecting a user script into the initial empty document
1400         that removes the HEAD and BODY nodes created by the parser. This
1401         ensures that the BODY created by Outlook is the only BODY in the
1402         document.
1403
1404         * Misc/OutlookQuirksUserScript.js: Added.
1405         * WebView/WebView.mm:
1406         (leakMailQuirksUserScriptContents):
1407         (-[WebView _injectMailQuirksScript]):
1408         (needsOutlookQuirksScript):
1409         (leakOutlookQuirksUserScriptContents):
1410         (-[WebView _injectOutlookQuirksScript]):
1411         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1412
1413 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1414
1415         Reviewed by David Levin.
1416
1417         Add QUOTA build flag for unified quota API
1418         https://bugs.webkit.org/show_bug.cgi?id=57918
1419
1420         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
1421
1422 2011-04-06  Robert Sesek  <rsesek@chromium.org>
1423
1424         Reviewed by Alexey Proskuryakov.
1425
1426         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
1427         https://bugs.webkit.org/show_bug.cgi?id=54969
1428
1429         * WebView/WebFrame.mm:
1430         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
1431         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
1432
1433 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
1434
1435         Reviewed by Darin Adler.
1436
1437         Move attributedStringFromRange down to WebCore
1438         https://bugs.webkit.org/show_bug.cgi?id=57905
1439
1440         * Misc/WebNSAttributedStringExtras.h: Removed.
1441         * Misc/WebNSAttributedStringExtras.mm: Removed.
1442         * WebView/WebHTMLRepresentation.mm:
1443         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1444         * WebView/WebHTMLView.mm:
1445         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1446         (-[WebHTMLView attributedSubstringFromRange:]):
1447         (-[WebHTMLView attributedString]):
1448         (-[WebHTMLView selectedAttributedString]):
1449         * WebView/WebPDFView.mm:
1450         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1451
1452 2011-04-04  MORITA Hajime  <morrita@google.com>
1453
1454         Reviewed by Ryosuke Niwa.
1455
1456         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1457         https://bugs.webkit.org/show_bug.cgi?id=56085
1458
1459         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
1460         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
1461         for requestCheckingOfString method.
1462         
1463         * WebCoreSupport/WebEditorClient.h:
1464         * WebCoreSupport/WebEditorClient.mm:
1465         (toCoreTextCheckingResults):
1466         (WebEditorClient::checkTextOfParagraph):
1467         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
1468         (-[WebEditorSpellCheckResponder perform]):
1469         (WebEditorClient::requestCheckingOfString):
1470         * WebView/WebFrame.mm:
1471         (-[WebFrame markersForSelectionStartAsText]):
1472         * WebView/WebFramePrivate.h:
1473
1474 2011-04-05  Anders Carlsson  <andersca@apple.com>
1475
1476         Didn't mean to land this.
1477
1478         * Plugins/WebNetscapePluginView.mm:
1479         (-[WebNetscapePluginView getVariable:value:]):
1480
1481 2011-04-04  David Kilzer  <ddkilzer@apple.com>
1482
1483         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
1484
1485         Reviewed by Alexey Proskuryakov.
1486
1487         * WebCoreSupport/WebSystemInterface.mm:
1488         (InitWebCoreSystemInterface): Added initialization for
1489         wkSetHTTPPipeliningMaximumPriority().
1490
1491 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
1492
1493         Reviewed by Dan Bernstein.
1494
1495         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1496         https://bugs.webkit.org/show_bug.cgi?id=51230
1497         <rdar://problem/8780989>
1498
1499         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
1500         WebKits to WebCore, because WebKit shouldn't be smart.
1501
1502 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1503
1504         Reviewed by Darin Adler.
1505
1506         REGRESSION: Assertion failure when executing a complex custom key binding
1507         https://bugs.webkit.org/show_bug.cgi?id=57681
1508
1509         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
1510         commands when they can't possibly change the result.
1511
1512 2011-04-01  Anders Carlsson  <andersca@apple.com>
1513
1514         Reviewed by Sam Weinig.
1515
1516         Shockwave plug-in doesn't accept mouse events
1517         https://bugs.webkit.org/show_bug.cgi?id=57653
1518         <rdar://problem/8483273>
1519
1520         Fix an unrelated bug found by the added test.
1521
1522         * Plugins/WebBaseNetscapePluginView.mm:
1523         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1524         Make sure to always set destX and destY.
1525
1526 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1527
1528         Reviewed by Darin Adler.
1529
1530         Make WebKit2 text input handling more like WebKit1
1531         https://bugs.webkit.org/show_bug.cgi?id=57649
1532
1533         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
1534         * WebView/WebHTMLView.mm:
1535         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
1536         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
1537         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1538         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1539         (-[WebHTMLView selectedRange]): Ditto.
1540         (-[WebHTMLView markedRange]): Ditto.
1541         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1542         (-[WebHTMLView hasMarkedText]): Ditto.
1543         (-[WebHTMLView unmarkText]): Ditto.
1544         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
1545         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
1546         be able to call text input protocol methods from here (and we didn't even reset it back on
1547         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
1548         (-[WebHTMLView insertText:]): Ditto.
1549
1550 2011-04-01  Timothy Hatcher  <timothy@apple.com>
1551
1552         Make momentum scroll event latching work in WebKit2 on Mac.
1553
1554         <rdar://problem/8751861>
1555
1556         Reviewed by Darin Adler.
1557
1558         * WebCoreSupport/WebSystemInterface.mm:
1559         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
1560         * WebView/WebDynamicScrollBarsView.mm:
1561         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
1562
1563 2011-03-31  Darin Adler  <darin@apple.com>
1564
1565         Reviewed by Anders Carlsson.
1566
1567         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
1568         https://bugs.webkit.org/show_bug.cgi?id=26667
1569
1570         * WebView/WebHTMLView.mm:
1571         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
1572         nil rather than asserting that it is non-nil. One case where WebView will be nil
1573         is when the frame is closed, but in any case where it is nil, the correct thing
1574         to do is to not try to handle the style key.
1575
1576 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
1577
1578         Patch by John Harvey, reviewed and tweaked by me.
1579
1580         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
1581
1582         * Plugins/Hosted/WebTextInputWindowController.m:
1583         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1584
1585 2011-03-31  Evan Martin  <evan@chromium.org>
1586
1587         Reviewed by Eric Seidel.
1588
1589         <title> should support dir attribute
1590         https://bugs.webkit.org/show_bug.cgi?id=50961
1591
1592         Update to new FrameLoaderClient interface.
1593
1594         * WebCoreSupport/WebFrameLoaderClient.h:
1595         * WebCoreSupport/WebFrameLoaderClient.mm:
1596         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1597         (WebFrameLoaderClient::setTitle):
1598
1599 2011-03-30  Dominic Cooney  <dominicc@google.com>
1600
1601         Reviewed by Dimitri Glazkov.
1602
1603         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1604         https://bugs.webkit.org/show_bug.cgi?id=57415
1605
1606         * DOM/WebDOMOperations.mm:
1607         (-[DOMElement _shadowRoot:]):
1608         * DOM/WebDOMOperationsPrivate.h:
1609
1610 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
1611
1612         Reviewed by Darin Adler.
1613
1614         WebHTMLView shouldn't resend noop: commands
1615         https://bugs.webkit.org/show_bug.cgi?id=57504
1616         <rdar://problem/9209390>
1617
1618         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
1619         which we get e.g. when handling Cmd-key combos.
1620
1621 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
1622
1623         Reviewed by Darin Adler.
1624
1625         REGRESSION (r82320): Spacebar no longer pages down
1626         https://bugs.webkit.org/show_bug.cgi?id=57423
1627         <rdar://problem/9207702>
1628
1629         Also includes some unrelated cleanup that I had in my tree.
1630
1631         * WebView/WebHTMLView.mm:
1632         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
1633         being dispatched to the right frame.
1634         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
1635         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
1636         Even if this specific command hasn't been handled, that doesn't nullify side effects from
1637         previous commands.
1638         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
1639         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
1640         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
1641         going to look at it.
1642
1643 2011-03-30  Sam Weinig  <sam@webkit.org>
1644
1645         Reviewed by Brady Eidson.
1646
1647         WebKit2: Attempting to view css file from url causes it to download
1648         <rdar://problem/9102611>
1649         https://bugs.webkit.org/show_bug.cgi?id=57501
1650
1651         * WebView/WebHTMLRepresentation.h:
1652         * WebView/WebHTMLRepresentation.mm:
1653         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1654         * WebView/WebHTMLView.mm:
1655         (+[WebHTMLView unsupportedTextMIMETypes]):
1656         Re-factor unsupportedTextMIMETypes to pull from WebCore's
1657         MIMETypeRegistry, so that the list can be shared with WebKit2.
1658
1659 2011-03-29  Beth Dakin  <bdakin@apple.com>
1660
1661         Reviewed by Maciej Stachowiak.
1662
1663         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
1664         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
1665         -and corresponding-
1666         <rdar://problem/8665411>
1667
1668         * Misc/WebNSControlExtras.m:
1669         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1670         * WebCoreSupport/WebChromeClient.mm:
1671         (WebChromeClient::scaleFactor):
1672         * WebView/WebHTMLView.mm:
1673         (-[WebHTMLView viewDidMoveToWindow]):
1674         (-[WebHTMLView attachRootLayer:]):
1675
1676 2011-03-29  Kent Tamura  <tkent@chromium.org>
1677
1678         Reviewed by Dimitri Glazkov.
1679
1680         Make validation message bubble testable
1681         https://bugs.webkit.org/show_bug.cgi?id=57290
1682
1683         * WebView/WebView.mm:
1684         (-[WebView _preferencesChangedNotification:]): Copy the private value of
1685           the timer magnification to WebCore::Settings.
1686         (-[WebView validationMessageTimerMagnification]): Added.
1687         (-[WebView setValidationMessageTimerMagnification:]): Added.
1688         * WebView/WebViewData.h: Declare a member for the timer magnification.
1689         * WebView/WebViewData.mm:
1690         (-[WebViewPrivate init]): Initialize the timer magnification.
1691         * WebView/WebViewPrivate.h:
1692           Declare a setter and a getter for the timer magnification.
1693
1694 2011-03-29  Kent Tamura  <tkent@chromium.org>
1695
1696         Reviewed by Dimitri Glazkov.
1697
1698         [Mac] Enable interactive-validation tests on Mac DRT
1699         https://bugs.webkit.org/show_bug.cgi?id=57308
1700
1701         * WebView/WebView.mm:
1702         (-[WebView _preferencesChangedNotification:]):
1703           Convey a WebView flag for interactive validation to WebCore::Settings.
1704         (-[WebView interactiveFormValidationEnabled]): Added.
1705         (-[WebView setInteractiveFormValidationEnabled:]): Added.
1706         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
1707         * WebView/WebViewData.mm:
1708         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
1709         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
1710
1711 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1712
1713         Update the order of the context menu to better match AppKit on Mac.
1714
1715         <rdar://problem/9054893>
1716
1717         Reviewed by John Sullivan.
1718
1719         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1720         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
1721         * WebCoreSupport/WebPlatformStrategies.h:
1722         * WebCoreSupport/WebPlatformStrategies.mm:
1723         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
1724
1725 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
1726
1727         Reviewed by Darin Adler.
1728
1729         https://bugs.webkit.org/show_bug.cgi?id=57379
1730         Clean up WK1 key event handling logic
1731
1732         No bugs knowingly fixed, but this makes the code more consistent.
1733
1734         * WebView/WebHTMLView.mm:
1735         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
1736         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
1737         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
1738         from other functions. We need to execute saved commands when an input method asks for current
1739         state, because providing stale state could confuse it.
1740         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
1741         changes.
1742         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
1743         the answer would be stale.
1744         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1745         (-[WebHTMLView selectedRange]): Ditto.
1746         (-[WebHTMLView markedRange]): Ditto.
1747         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1748         (-[WebHTMLView hasMarkedText]): Ditto.
1749         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
1750         operating on stale data. Also, updated for eventWasHandled renaming.
1751         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1752         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
1753         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
1754         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
1755         could have a noop: as one of its commands, although that's hardly practical).
1756         Added the same "from input method" logic that we have in insertText: - I don't know of any
1757         IMs that call this method, but we clearly need to execute it as part of IM processing when
1758         there is marked text.
1759         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
1760         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
1761         if current selection isn't editable. This is different from doCommandBySelector:, where we
1762         need to give super class a chance to handle the event if our processing fails.
1763         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
1764         return value of _interpretKeyEvent is computed differently.
1765
1766 2011-03-28  Adele Peterson  <adele@apple.com>
1767
1768         Reviewed by Eric Seidel.
1769
1770         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1771         https://bugs.webkit.org/show_bug.cgi?id=57173
1772
1773         * WebView/WebFrame.mm:
1774         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
1775         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
1776         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
1777
1778 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
1779
1780         Reviewed by Darin Adler.
1781
1782         https://bugs.webkit.org/show_bug.cgi?id=57260
1783         Clean up text input code a little
1784
1785         * WebCoreSupport/WebEditorClient.mm:
1786         (WebEditorClient::handleKeyboardEvent):
1787         (WebEditorClient::handleInputMethodKeydown):
1788         * WebView/WebHTMLViewInternal.h:
1789         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
1790         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
1791         and also possibly saves resulting commands for later execution.
1792
1793         * WebView/WebHTMLView.mm:
1794         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
1795         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
1796         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
1797         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
1798         because the first call resulted in no saved commands, becasue it's confusing and apparently
1799         useless (I couldn't find any broken behavior).
1800         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
1801         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1802         (-[WebHTMLView doCommandBySelector:]): Ditto.
1803         (-[WebHTMLView insertText:]): Ditto.
1804
1805         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
1806         method on WebView.
1807
1808 2011-03-27  Jer Noble  <jer.noble@apple.com>
1809
1810         Reviewed by Maciej Stachowiak.
1811
1812         Full Screen: disable keyboard access by default
1813         https://bugs.webkit.org/show_bug.cgi?id=56684
1814
1815         Take into account whether keyboard access was requested when deciding whether full
1816         screen mode is supported.
1817
1818         * WebCoreSupport/WebChromeClient.h:
1819         * WebCoreSupport/WebChromeClient.mm:
1820         (WebChromeClient::supportsFullScreenForElement):
1821         * WebView/WebView.mm:
1822         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
1823         * WebView/WebViewInternal.h:
1824
1825 2011-03-26  Jer Noble  <jer.noble@apple.com>
1826
1827         Reviewed by Eric Carlson.
1828
1829         Enable the Full Screen API by default in WebKit/mac and WebKit2
1830         https://bugs.webkit.org/show_bug.cgi?id=56956
1831
1832         * WebView/WebPreferences.mm:
1833         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
1834
1835 2011-03-25  Andy Estes  <aestes@apple.com>
1836
1837         Reviewed by Adele Peterson.
1838
1839         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1840         https://bugs.webkit.org/show_bug.cgi?id=49016
1841
1842         Update objectContentType() implementation to handle the
1843         shouldPreferPlugInsForImages flag.
1844
1845         * WebCoreSupport/WebFrameLoaderClient.h:
1846         * WebCoreSupport/WebFrameLoaderClient.mm:
1847         (WebFrameLoaderClient::objectContentType):
1848
1849 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1850
1851         Unreviewed, rolling out r81939.
1852         http://trac.webkit.org/changeset/81939
1853         https://bugs.webkit.org/show_bug.cgi?id=57084
1854
1855         Rolling out 81939, as it's causing a number of app cache test
1856         failures. (Requested by jernoble on #webkit).
1857
1858         * WebView/WebView.mm:
1859         (-[WebView _preferencesChangedNotification:]):
1860
1861 2011-03-23  Jer Noble  <jer.noble@apple.com>
1862
1863         Reviewed by Maciej Stachowiak.
1864
1865         Application Cache should save audio/ and video/ mime types as flat files
1866         https://bugs.webkit.org/show_bug.cgi?id=53784
1867         <rdar://problem/8932473>
1868
1869         No new tests.
1870
1871         Initialize the AppCache Total size quotas with the values for WebKitPreferences
1872         upon startup.
1873
1874         * WebView/WebView.mm:
1875         (-[WebView _preferencesChangedNotification:]):
1876
1877 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1878
1879         Unreviewed, rolling out r81916 and r81917.
1880         http://trac.webkit.org/changeset/81916
1881         http://trac.webkit.org/changeset/81917
1882         https://bugs.webkit.org/show_bug.cgi?id=57071
1883
1884         broke a test on platforms that do not have QuickTime installed
1885         (Requested by estes on #webkit).
1886
1887         * WebCoreSupport/WebFrameLoaderClient.h:
1888         * WebCoreSupport/WebFrameLoaderClient.mm:
1889         (WebFrameLoaderClient::objectContentType):
1890
1891 2011-03-24  Andy Estes  <aestes@apple.com>
1892
1893         Reviewed by Darin Adler.
1894
1895         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1896         https://bugs.webkit.org/show_bug.cgi?id=49016
1897
1898         Update objectContentType() implementation to handle the
1899         shouldPreferPlugInsForImages flag.
1900
1901         * WebCoreSupport/WebFrameLoaderClient.h:
1902         * WebCoreSupport/WebFrameLoaderClient.mm:
1903         (WebFrameLoaderClient::objectContentType):
1904
1905 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
1906
1907         Reviewed by Oliver Hunt.
1908
1909         Ensure that all compilation takes place within a dynamic global object scope
1910         https://bugs.webkit.org/show_bug.cgi?id=57054
1911
1912         * WebView/WebScriptDebugDelegate.mm:
1913         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
1914
1915 2011-03-24  Jia Pu  <jpu@apple.com>
1916
1917         Reviewed by Darin Adler.
1918
1919         Dismissed reversion suggestion is incorrectly learned.
1920         https://bugs.webkit.org/show_bug.cgi?id=57039
1921
1922         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
1923         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
1924         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
1925         incorrect automatic learning.
1926
1927         * WebCoreSupport/CorrectionPanel.mm:
1928         (CorrectionPanel::dismissInternal):
1929
1930 2011-03-24  David Kilzer  <ddkilzer@apple.com>
1931
1932         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
1933
1934         Reviewed by Joseph Pecoraro.
1935
1936         * Plugins/WebPluginContainerPrivate.h: Changed value of
1937         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
1938
1939 2011-03-23  Jia Pu  <jpu@apple.com>
1940
1941         Reviewed by Darin Adler.
1942
1943         Hook up new AppKit autocorrection UI with WK2.
1944         https://bugs.webkit.org/show_bug.cgi?id=56055
1945         <rdar://problem/8947463>
1946
1947         Please see WebCore/ChangeLog for detail.
1948
1949         * WebCoreSupport/CorrectionPanel.h: Added.
1950         (CorrectionPanel::isShowing):
1951         * WebCoreSupport/CorrectionPanel.mm: Added.
1952         (correctionBubbleType):
1953         (CorrectionPanel::CorrectionPanel):
1954         (CorrectionPanel::~CorrectionPanel):
1955         (CorrectionPanel::show):
1956         (CorrectionPanel::dismiss):
1957         (CorrectionPanel::dismissSoon):
1958         (CorrectionPanel::dismissInternal):
1959         (CorrectionPanel::recordAutocorrectionResponse):
1960         * WebCoreSupport/WebEditorClient.h:
1961         * WebCoreSupport/WebEditorClient.mm:
1962         (WebEditorClient::WebEditorClient):
1963         (WebEditorClient::showCorrectionPanel):
1964         (WebEditorClient::dismissCorrectionPanel):
1965         (WebEditorClient::dismissCorrectionPanelSoon):
1966         (WebEditorClient::recordAutocorrectionResponse):
1967         * WebView/WebView.mm:
1968         (-[WebView handleCorrectionPanelResult:]):
1969         * WebView/WebViewPrivate.h:
1970
1971 2011-03-23  Enrica Casucci  <enrica@apple.com>
1972
1973         Reviewed by Alexey Proskuryakov.
1974
1975         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
1976         https://bugs.webkit.org/show_bug.cgi?id=56974
1977         <rdar://problem/8284642>
1978
1979         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
1980         where readSelectionFromPasteboard was accidentally removed.
1981         This method and writeSelectionToPasteboard are needed to support Mac OS X
1982         services.
1983         
1984         * WebView/WebHTMLView.mm:
1985         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
1986         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
1987
1988 2011-03-23  Brady Eidson  <beidson@apple.com>
1989
1990         Reviewed by Sam Weinig.
1991
1992         Change IconDatabase opening to allow for arbitrary filenames
1993         https://bugs.webkit.org/show_bug.cgi?id=56977
1994
1995         * Misc/WebIconDatabase.mm:
1996         (-[WebIconDatabase _startUpIconDatabase]):
1997
1998 2011-03-22  Anton D'Auria  <adauria@apple.com>
1999
2000         Reviewed by Alexey Proskuryakov.
2001
2002         Add +[WebApplicationCache getOriginsWithCache]
2003         https://bugs.webkit.org/show_bug.cgi?id=56722
2004
2005         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
2006
2007         * WebCoreSupport/WebApplicationCache.h:
2008         * WebCoreSupport/WebApplicationCache.mm:
2009         (+[WebApplicationCache originsWithCache]):
2010
2011 2011-03-22  Anders Carlsson  <andersca@apple.com>
2012
2013         Reviewed by Sam Weinig.
2014
2015         OBJECT element with DivX source is always downloaded
2016         https://bugs.webkit.org/show_bug.cgi?id=56879
2017
2018         * Plugins/WebBasePluginPackage.mm:
2019         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2020         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
2021         specifies multiple file extensions in a single element.
2022
2023 2011-03-22  Brady Eidson  <beidson@apple.com>
2024
2025         Reviewed by Sam Weinig.
2026
2027         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
2028         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
2029
2030         Note that while the new client calls always come through on the main thread, our mechanisms to
2031         route dispatches to the main thread are still valid and will still work.
2032
2033         Update to the new IconDatabaseClient interface:
2034         * WebCoreSupport/WebIconDatabaseClient.h:
2035         * WebCoreSupport/WebIconDatabaseClient.mm:
2036         (WebIconDatabaseClient::didRemoveAllIcons):
2037         (WebIconDatabaseClient::didImportIconURLForPageURL):
2038         (WebIconDatabaseClient::didImportIconDataForPageURL):
2039         (WebIconDatabaseClient::didChangeIconForPageURL):
2040         (WebIconDatabaseClient::didFinishURLImport):
2041
2042 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
2043
2044         Reviewed by Simon Fraser.
2045
2046         Have WebKit push acceleratedDrawing preferences to settings
2047         https://bugs.webkit.org/show_bug.cgi?id=56792
2048
2049         * WebView/WebView.mm:
2050
2051 2011-03-21  Nate Chapin  <japhet@chromium.org>
2052
2053         Reviewed by Brady Eidson.
2054
2055         Expose a preference to use caching quirks for QuickLook,
2056         and use it if the QuickLook framework is loaded.
2057
2058         https://bugs.webkit.org/show_bug.cgi?id=38690
2059
2060         * WebView/WebPreferenceKeysPrivate.h:
2061         * WebView/WebPreferences.mm:
2062         (useQuickLookQuirks):
2063         (+[WebPreferences initialize]):
2064         (-[WebPreferences useQuickLookResourceCachingQuirks]):
2065         * WebView/WebPreferencesPrivate.h:
2066         * WebView/WebView.mm:
2067         (-[WebView _preferencesChangedNotification:]):
2068
2069 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
2070
2071         Reviewed by Darin Adler.
2072
2073         AX: showContextMenu not working in WK2
2074         https://bugs.webkit.org/show_bug.cgi?id=56734
2075
2076         Implement showContextMenu() so accessibility related code can call this
2077         independent of whether WK1 or WK2 is running.
2078
2079         * WebCoreSupport/WebChromeClient.h:
2080         * WebCoreSupport/WebChromeClient.mm:
2081         (WebChromeClient::showContextMenu):
2082
2083 2011-03-21  Chang Shu  <cshu@webkit.org>
2084
2085         Reviewed by Alexey Proskuryakov.
2086
2087         REGRESSION (r79953): Can't type in MS Outlook 2011
2088         https://bugs.webkit.org/show_bug.cgi?id=56665
2089
2090         r79953 removed the WebView level editablity which is persistent no matter whether
2091         underlying document itself is changed and editability gets lost. The resolution is to
2092         set this WebView editable value to WebCore. This avoids the callback from WebCore to
2093         WebKit which was the main goal in r79953 to improve performance.
2094
2095         * WebView/WebView.mm:
2096         (-[WebView setEditable:]):
2097         (-[WebView isEditable]):
2098
2099 2011-03-19  Anton D'Auria  <adauria@apple.com>
2100
2101         Reviewed by Alexey Proskuryakov.
2102
2103         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2104         https://bugs.webkit.org/show_bug.cgi?id=56415
2105         
2106         Use new ApplicationCache API to delete all cache for an origin.
2107
2108         * WebCoreSupport/WebApplicationCache.h:
2109         * WebCoreSupport/WebApplicationCache.mm:
2110         (+[WebApplicationCache deleteOrigin:]):
2111
2112 2011-03-17  Brady Eidson  <beidson@apple.com>
2113
2114         Reviewed by Sam Weinig.
2115
2116         https://bugs.webkit.org/show_bug.cgi?id=56425
2117         More groundwork for WebKit2 IconDatabase
2118
2119         Update already-used function names:
2120         * Misc/WebIconDatabase.mm:
2121         (-[WebIconDatabase iconForURL:withSize:cache:]):
2122         (-[WebIconDatabase iconURLForURL:]):
2123         * WebView/WebView.mm:
2124         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2125
2126 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
2127
2128         Reviewed by Yury Semikhatsky.
2129
2130         Web Inspector: implement inspector session storage.
2131         https://bugs.webkit.org/show_bug.cgi?id=56643
2132
2133         * WebCoreSupport/WebInspectorClient.h:
2134         * WebCoreSupport/WebInspectorClient.mm:
2135         (WebInspectorClient::saveSessionSetting):
2136         (WebInspectorClient::loadSessionSetting):
2137         (WebInspectorFrontendClient::saveSessionSetting):
2138         (WebInspectorFrontendClient::loadSessionSetting):
2139         (-[WebInspectorWindowController inspectorClient]):
2140
2141 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
2142
2143         Reviewed by Oliver Hunt.
2144
2145         Fixed a leak seen on the buildbot.
2146
2147         * WebCoreSupport/WebInspectorClient.mm:
2148         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
2149
2150 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
2151
2152         Reviewed by Alexey Proskuryakov.
2153
2154         Logic error in -[WebHTMLView close]
2155         https://bugs.webkit.org/show_bug.cgi?id=56445
2156
2157         Page is always nil at this point, because [self _webView] is nil,
2158         so the conditional code is never run.
2159
2160         * WebView/WebHTMLView.mm:
2161         (-[WebHTMLView close]):
2162
2163 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
2164
2165         Reviewed by Darin Adler.
2166
2167         WK2: Need to propagate enhanced accessibility flag from UI -> web process
2168         https://bugs.webkit.org/show_bug.cgi?id=56379
2169
2170         * WebView/WebFrame.mm:
2171         (-[WebFrame accessibilityRoot]):
2172
2173 2011-03-15  Oliver Hunt  <oliver@apple.com>
2174
2175         Reviewed by Geoffrey Garen.
2176
2177         Make Structure creation require a JSGlobalData
2178         https://bugs.webkit.org/show_bug.cgi?id=56438
2179
2180         Mechanical change to make all Structure creation use a JSGlobalData&
2181
2182         * Plugins/Hosted/ProxyInstance.mm:
2183         (WebKit::ProxyRuntimeMethod::createStructure):
2184         * Plugins/Hosted/ProxyRuntimeObject.h:
2185         (WebKit::ProxyRuntimeObject::createStructure):
2186
2187 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2188
2189         Forgot to save a modification to this file when committing.
2190
2191         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2192
2193 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2194
2195         Reviewed by Darin Adler.
2196
2197         REGRESSION (WebKit2): keygen element doesn't work
2198         https://bugs.webkit.org/show_bug.cgi?id=56402
2199         <rdar://problem/9006545>
2200
2201         * WebCoreSupport/WebKeyGenerator.h:
2202         * WebCoreSupport/WebKeyGenerator.m: Removed.
2203         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
2204         (+[WebKeyGenerator sharedGenerator]):
2205         (toWebCertificateParseResult):
2206         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
2207         this misnamed and misplaced code for now.
2208
2209         * WebCoreSupport/WebPlatformStrategies.h:
2210         * WebCoreSupport/WebPlatformStrategies.mm:
2211         (WebPlatformStrategies::keygenMenuItem512):
2212         (WebPlatformStrategies::keygenMenuItem1024):
2213         (WebPlatformStrategies::keygenMenuItem2048):
2214         (WebPlatformStrategies::keygenKeychainItemName):
2215         Added strings used by keygen.
2216
2217         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
2218         pointer to a function used by keygen.
2219
2220         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
2221         initialized now.
2222
2223 2011-03-15  Beth Dakin  <bdakin@apple.com>
2224
2225         Reviewed by Simon Fraser.
2226
2227         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
2228
2229         New WebKitystemInterface function to force the scrollbars to flash
2230         * WebCoreSupport/WebSystemInterface.mm:
2231         (InitWebCoreSystemInterface):
2232
2233 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2234
2235         Reviewed by Tony Chang.
2236
2237         Autofilled form elements are assigned fixed background color but not text color
2238         https://bugs.webkit.org/show_bug.cgi?id=48382
2239
2240         * DOM/WebDOMOperations.mm:
2241         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
2242         * DOM/WebDOMOperationsPrivate.h:
2243
2244 2011-03-15  Adam Roben  <aroben@apple.com>
2245
2246         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
2247
2248         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
2249         WebStorageTrackerClient::dispatchDidModifyOrigin
2250
2251         Reviewed by Antti Koivisto.
2252
2253         * Storage/WebStorageTrackerClient.mm:
2254         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
2255         to us by dispatchDidModifyOrigin.
2256         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
2257         unnecessary cast.
2258
2259 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2260
2261         Reviewed by Darin Adler.
2262
2263         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2264         info into the headers rather than in export symbol definition files, but disable it on 
2265         all platforms initially so we can deal with port build issues one port at a time.
2266         
2267         https://bugs.webkit.org/show_bug.cgi?id=27551
2268
2269         * WebKitPrefix.h:
2270
2271 2011-03-14  Brady Eidson  <beidson@apple.com>
2272
2273         Reviewed by Anders Carlsson.
2274
2275         https://bugs.webkit.org/show_bug.cgi?id=56320
2276         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
2277
2278         * History/WebHistoryItem.mm:
2279         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
2280
2281 2011-03-13  Pratik Solanki  <psolanki@apple.com>
2282
2283         Reviewed by Brady Eidson.
2284
2285         Make adjustMIMETypeIfNecessary use CFNetwork directly
2286         https://bugs.webkit.org/show_bug.cgi?id=55912
2287
2288         * WebCoreSupport/WebSystemInterface.mm:
2289         (InitWebCoreSystemInterface): Support for new WKSI functions.
2290
2291 2011-03-12  Mark Rowe  <mrowe@apple.com>
2292
2293         Fix the 32-bit build.
2294
2295         * Carbon/CarbonWindowAdapter.mm:
2296         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
2297         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
2298
2299 2011-03-11  Brady Eidson  <beidson@apple.com>
2300
2301         Reviewed by Anders Carlsson
2302
2303         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
2304         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
2305
2306         * Misc/WebIconDatabase.mm:
2307         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
2308         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
2309         (importToWebCoreFormat):
2310
2311 2011-03-11  Anton D'Auria  <adauria@apple.com>
2312
2313         Reviewed and landed by Brady Eidson.
2314
2315         https://bugs.webkit.org/show_bug.cgi?id=51878
2316         Add WebKit1 API to view and delete local storage
2317
2318         * Storage/WebStorageManager.mm: Added.
2319         (+[WebStorageManager sharedWebStorageManager]):
2320         (-[WebStorageManager origins]):
2321         (-[WebStorageManager deleteAllOrigins]):
2322         (-[WebStorageManager deleteOrigin:]):
2323         (-[WebStorageManager syncLocalStorage]):
2324         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
2325         (storageDirectoryPath):
2326         (WebKitInitializeStorageIfNecessary):
2327         * Storage/WebStorageManagerInternal.h: Added.
2328         * Storage/WebStorageManagerPrivate.h: Added.
2329         * Storage/WebStorageTrackerClient.h: Added.
2330         * Storage/WebStorageTrackerClient.mm: Added.
2331         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
2332         (WebStorageTrackerClient::WebStorageTrackerClient):
2333         (WebStorageTrackerClient::~WebStorageTrackerClient):
2334         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
2335         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2336         * WebCoreSupport/WebSecurityOrigin.mm:
2337         (-[WebSecurityOrigin protocol]):
2338         (-[WebSecurityOrigin host]):
2339         (-[WebSecurityOrigin databaseIdentifier]):
2340         (-[WebSecurityOrigin domain]):
2341         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
2342         * WebCoreSupport/WebSecurityOriginPrivate.h:
2343         * WebKit.exp:
2344         * WebView/WebView.mm:
2345         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2346
2347 2011-03-10  Anders Carlsson  <andersca@apple.com>
2348
2349         Reviewed by Sam Weinig.
2350
2351         <rdar://problem/9117047>
2352         Don't paint more than 60 times per second even when scrolling
2353
2354         * WebView/WebClipView.mm:
2355         (-[WebClipView _immediateScrollToPoint:]):
2356
2357 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
2358
2359         Reviewed by Simon Fraser.
2360
2361         Plumb through settings for accelerated drawing for canvas
2362         https://bugs.webkit.org/show_bug.cgi?id=56039
2363
2364         * WebView/WebPreferenceKeysPrivate.h:
2365         * WebView/WebPreferences.mm:
2366         * WebView/WebPreferencesPrivate.h:
2367
2368 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
2369
2370         Reviewed by Tony Chang.
2371
2372         VisiblePosition's next and previous should take an enum instead of a boolean
2373         https://bugs.webkit.org/show_bug.cgi?id=56135
2374
2375         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
2376         StayInEditableContent.
2377
2378         * WebView/WebView.mm:
2379         (-[WebView _selectionIsAll]):
2380
2381 2011-03-09  Jessie Berlin  <jberlin@apple.com>
2382
2383         Reviewed by Adam Roben.
2384
2385         Use the Cookie Storage from the Private Browsing Storage Session directly
2386         https://bugs.webkit.org/show_bug.cgi?id=55986
2387
2388         * WebCoreSupport/WebSystemInterface.mm:
2389         (InitWebCoreSystemInterface):
2390
2391 2011-03-08  Darin Adler  <darin@apple.com>
2392
2393         Reviewed by Timothy Hatcher.
2394
2395         Promote a method used outside WebKit from internal to private
2396         https://bugs.webkit.org/show_bug.cgi?id=55949
2397
2398         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
2399         Minor tweak, not directly related to the rest of this patch.
2400
2401         * WebView/WebFrame.mm:
2402         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
2403         this method from the internal category into the private category.
2404         Streamlined the code a bit.
2405
2406         * WebView/WebFrameInternal.h: Removed _computePageRects method.
2407         * WebView/WebFramePrivate.h: Added _computePageRects method.
2408
2409 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2410
2411         Reviewed by Darin Adler.
2412
2413         selectionHasStyle and selectionStartHasStyle should use EditingStyle
2414         https://bugs.webkit.org/show_bug.cgi?id=55902
2415
2416         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
2417
2418         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
2419         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
2420
2421 2011-03-07  Dan Bernstein  <mitz@apple.com>
2422
2423         LLVM Compiler build fix.
2424
2425         * WebCoreSupport/WebEditorClient.mm:
2426         (WebEditorClient::checkGrammarOfString):
2427
2428 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2429
2430         Reviewed by Beth Dakin.
2431
2432         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
2433         https://bugs.webkit.org/show_bug.cgi?id=55706
2434
2435         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
2436         returns the scroll bar objects).
2437         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
2438         will expect that as its child, instead of the WebCore ScrollView object.
2439
2440         * WebView/WebDynamicScrollBarsView.mm:
2441         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2442         * WebView/WebFrame.mm:
2443         (-[WebFrame accessibilityRoot]):
2444
2445 2011-03-07  Sam Weinig  <sam@webkit.org>
2446
2447         Reviewed by Anders Carlsson.
2448
2449         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2450         https://bugs.webkit.org/show_bug.cgi?id=55827
2451
2452         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2453         and pass the entire response, instead of just the MIMEType.
2454
2455         * WebCoreSupport/WebFrameLoaderClient.h:
2456         * WebCoreSupport/WebFrameLoaderClient.mm:
2457         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2458
2459 2011-03-06  Dan Bernstein  <mitz@apple.com>
2460
2461         LLVM Compiler build fix.
2462
2463         * DOM/WebDOMOperations.mm:
2464         (-[DOMHTMLInputElement _setValueForUser:]):
2465
2466 2011-03-06  Jessie Berlin  <jberlin@apple.com>
2467
2468         Reviewed by Sam Weinig.
2469
2470         WebKit2: Use CFNetwork Sessions API.
2471         https://bugs.webkit.org/show_bug.cgi?id=55435.
2472
2473         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
2474         Private Browsing Storage Session.
2475
2476         * WebCoreSupport/WebSystemInterface.mm:
2477         (InitWebCoreSystemInterface):
2478         Add support for using the new WKSI functions in WebCore.
2479
2480 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2481
2482         Reviewed by Darin Adler.
2483
2484         HTMLInputElement::setValue() should schedule change event when the element is focused
2485         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2486         https://bugs.webkit.org/show_bug.cgi?id=53160
2487
2488         * DOM/WebDOMOperations.mm:
2489         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
2490         * DOM/WebDOMOperationsPrivate.h:
2491         * WebView/WebViewInternal.h:
2492
2493 2011-03-04  Jia Pu  <jpu@apple.com>
2494
2495         Reviewed by Darin Adler.
2496
2497         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
2498         https://bugs.webkit.org/show_bug.cgi?id=55717
2499         <rdar://problem/9018127>
2500
2501         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
2502         is already in window coordinate. We don't need to do further conversion anymore.
2503
2504         * WebCoreSupport/WebEditorClient.mm:
2505         (WebEditorClient::showCorrectionPanel):
2506
2507 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2508
2509         Reviewed by Maciej Stachowiak.
2510
2511         WebKit2: Use CFNetwork Sessions API.
2512         https://bugs.webkit.org/show_bug.cgi?id=55435.
2513
2514         When Private Browsing is enabled, get the cached url response from the cache associated with
2515         the Private Browsing Storage Session.
2516
2517         * WebView/WebView.mm:
2518         (-[WebView _cachedResponseForURL:]):
2519
2520 2011-03-03  Anders Carlsson  <andersca@apple.com>
2521
2522         Reviewed by Sam Weinig.
2523
2524         Get rid of Page::globalHistoryItem
2525         https://bugs.webkit.org/show_bug.cgi?id=55738
2526
2527         * WebCoreSupport/WebFrameLoaderClient.h:
2528         * WebCoreSupport/WebFrameLoaderClient.mm:
2529         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
2530         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
2531     
2532         * WebView/WebView.mm:
2533         (-[WebView _globalHistoryItem]):
2534         (-[WebView _setGlobalHistoryItem:]):
2535         Set _globalHistoryItem ivar.
2536
2537         * WebView/WebViewData.h:
2538         * WebView/WebViewData.mm:
2539         Add _globalHistoryItem ivar.
2540
2541 2011-03-03  Brady Eidson  <beidson@apple.com>
2542
2543         Reviewed by Darin Adler.
2544
2545         https://bugs.webkit.org/show_bug.cgi?id=55721
2546         Global IconDatabase should be returned by reference, not as a pointer
2547
2548         * Misc/WebCoreStatistics.mm:
2549         (+[WebCoreStatistics iconPageURLMappingCount]):
2550         (+[WebCoreStatistics iconRetainedPageURLCount]):
2551         (+[WebCoreStatistics iconRecordCount]):
2552         (+[WebCoreStatistics iconsWithDataCount]):
2553         * Misc/WebIconDatabase.mm:
2554         (-[WebIconDatabase init]):
2555         (-[WebIconDatabase iconForURL:withSize:cache:]):
2556         (-[WebIconDatabase iconURLForURL:]):
2557         (-[WebIconDatabase defaultIconWithSize:]):
2558         (-[WebIconDatabase retainIconForURL:]):
2559         (-[WebIconDatabase releaseIconForURL:]):
2560         (-[WebIconDatabase isEnabled]):
2561         (-[WebIconDatabase setEnabled:]):
2562         (-[WebIconDatabase removeAllIcons]):
2563         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
2564         (-[WebIconDatabase _startUpIconDatabase]):
2565         (-[WebIconDatabase _applicationWillTerminate:]):
2566         (-[WebIconDatabase _resetCachedWebPreferences:]):
2567         (importToWebCoreFormat):
2568         * WebView/WebView.mm:
2569         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2570
2571 2011-03-03  Jessie Berlin  <jberlin@apple.com>
2572
2573         Reviewed by Adam Roben.
2574
2575         WebKit2: Use CFNetwork Sessions API.
2576         https://bugs.webkit.org/show_bug.cgi?id=55435.
2577
2578         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
2579
2580         * WebCoreSupport/WebSystemInterface.mm:
2581         (InitWebCoreSystemInterface):
2582         Support using WKCopyRequestWithStorageSession in WebCore.
2583
2584 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2585
2586         Reviewed by Darin Adler.
2587
2588         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2589         https://bugs.webkit.org/show_bug.cgi?id=55633
2590         <rdar://problem/8963023>
2591
2592         * WebCoreSupport/WebChromeClient.h:
2593         * WebCoreSupport/WebChromeClient.mm:
2594         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
2595
2596         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2597         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
2598         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
2599         so I've preserved it.
2600
2601 2011-03-02  Jessie Berlin  <jberlin@apple.com>
2602
2603         Rubber-stamped by Dan Bernstein.
2604
2605         Fix crashes in private browsing tests in WK1 on Snow Leopard.
2606
2607         * WebCoreSupport/WebSystemInterface.mm:
2608         (InitWebCoreSystemInterface):
2609         Put the INIT call for wkCreatePrivateStorageSession outside of the
2610         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
2611         guards.
2612
2613 2011-03-02  Jessie Berlin  <jberlin@apple.com>
2614
2615         Reviewed by Adam Roben.
2616
2617         WebKit2: Use CFNetwork Sessions API.
2618         https://bugs.webkit.org/show_bug.cgi?id=55435.
2619
2620         Add the ability to create a Private Browsing Storage Session.
2621
2622         * WebCoreSupport/WebSystemInterface.mm:
2623         (InitWebCoreSystemInterface):
2624         Support calling wkCreatePrivateStorageSession from WebCore.
2625
2626 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2627
2628         Reviewed by David Levin.
2629
2630         Add feature define for data transfer items
2631         https://bugs.webkit.org/show_bug.cgi?id=55510
2632
2633         * Configurations/FeatureDefines.xcconfig:
2634
2635 2011-03-02  Sam Weinig  <sam@webkit.org>
2636
2637         Reviewed by Anders Carlsson.
2638
2639         Fix remaining localization issues by piping all localized strings through WebCore's
2640         localization bottleneck.
2641         <rdar://problem/8728860>
2642
2643         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2644         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2645         * Misc/WebKitErrors.m:
2646         * Misc/WebLocalizableStringsInternal.h: Added.
2647         * Misc/WebLocalizableStringsInternal.mm: Added.
2648         (WebLocalizedStringInternal):
2649         * Panels/WebAuthenticationPanel.m:
2650         (-[WebAuthenticationPanel setUpForChallenge:]):
2651         * Plugins/Hosted/NetscapePluginHostManager.mm:
2652         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2653         * WebCoreSupport/WebEditorClient.mm:
2654         (undoNameForEditAction):
2655         * WebCoreSupport/WebInspectorClient.mm:
2656         (WebInspectorFrontendClient::updateWindowTitle):
2657         (-[WebInspectorWindowController validateUserInterfaceItem:]):
2658         * WebCoreSupport/WebKeyGenerator.m:
2659         (-[WebKeyGenerator strengthMenuItemTitles]):
2660         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
2661         * WebCoreSupport/WebPlatformStrategies.mm:
2662         * WebView/WebHTMLView.mm:
2663         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2664         * WebView/WebPDFView.mm:
2665         (-[WebPDFView menuForEvent:]):
2666
2667 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
2668
2669         Reviewed by Adam Roben.
2670
2671         Part of WebKit2: Need a way to send notifications to client when cookies change
2672         https://bugs.webkit.org/show_bug.cgi?id=55427
2673         <rdar://problem/9056027>
2674         
2675         Add stubs for CookiesStrategy on Mac WebKit1.
2676
2677         * WebCoreSupport/WebPlatformStrategies.h:
2678         * WebCoreSupport/WebPlatformStrategies.mm:
2679         (WebPlatformStrategies::createCookiesStrategy):
2680         (WebPlatformStrategies::notifyCookiesChanged):
2681
2682 2011-03-01  Philippe Normand  <pnormand@igalia.com>
2683
2684         Reviewed by Eric Carlson.
2685
2686         [GStreamer] support in mac video fullscreen controller
2687         https://bugs.webkit.org/show_bug.cgi?id=52280
2688
2689         Factored the code to configure the video overlay in a new private
2690         method of the controller and added GStreamer support to it.
2691
2692         * WebView/WebVideoFullscreenController.h:
2693         * WebView/WebVideoFullscreenController.mm:
2694         (-[WebVideoFullscreenController setupVideoOverlay:]):
2695         (-[WebVideoFullscreenController windowDidLoad]):
2696         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
2697         (-[WebVideoFullscreenController windowDidExitFullscreen]):
2698
2699 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
2700
2701         Reviewed by Timothy Hatcher.
2702
2703         All Console Messages should be passed to ChromeClients.
2704         https://bugs.webkit.org/show_bug.cgi?id=54926
2705
2706         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
2707         which supersedes -webView:addMessageToConsole if it exists. The new delegate
2708         does not filter to only JavaScript originated console messages. The old
2709         delegate is left around for clients that expect filtered messages, like
2710         DashCode and older versions of Safari.
2711
2712         The dictionary message passed to the delegate now includes more information
2713         about the message source, type, and level.
2714
2715         * WebCoreSupport/WebChromeClient.mm:
2716         (stringForMessageSource):
2717         (stringForMessageType):
2718         (stringForMessageLevel):
2719         (WebChromeClient::addMessageToConsole):
2720         * WebView/WebUIDelegatePrivate.h:
2721
2722 2011-03-01  Levi Weintraub  <leviw@chromium.org>
2723
2724         Reviewed by Ryosuke Niwa.
2725
2726         Stop instantiating legacy editing Positions in VisiblePosition
2727         https://bugs.webkit.org/show_bug.cgi?id=52919
2728
2729         Changing usage of legacy VisiblePosition constructor. Since we were dealing
2730         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
2731
2732         * WebView/WebFrame.mm:
2733         (-[WebFrame _caretRectAtPosition:affinity:]):
2734         * WebView/WebFrameInternal.h:
2735         * WebView/WebTextCompletionController.mm:
2736         (-[WebTextCompletionController doCompletion]):
2737
2738 2011-03-01  Sam Weinig  <sam@webkit.org>
2739
2740         Reviewed by Timothy Hatcher.
2741
2742         WebKit2 needs to be made localizable
2743         https://bugs.webkit.org/show_bug.cgi?id=55483
2744
2745         * WebCoreSupport/WebPlatformStrategies.mm:
2746         Use WebCore's localizedString function instead of WebLocalizableStrings
2747         since WebCore is now responsible for localization.
2748
2749 2011-02-25 Steve Block <steveblock@google.com>
2750
2751         Reviewed by Jeremy Orlow.
2752
2753         Bridge.h should not include BridgeJSC.h
2754         https://bugs.webkit.org/show_bug.cgi?id=55212
2755
2756         Include BridgeJSC.h directly instead.
2757
2758         * Plugins/Hosted/ProxyInstance.h:
2759         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2760
2761 2011-02-28  Chang Shu  <cshu@webkit.org>
2762
2763         Reviewed by Ryosuke Niwa.
2764
2765         Remove the support of Frame::isContentEditable and its dependencies.
2766         https://bugs.webkit.org/show_bug.cgi?id=54292
2767
2768         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2769
2770         * WebCoreSupport/WebEditorClient.h:
2771         * WebCoreSupport/WebEditorClient.mm:
2772         * WebView/WebView.mm:
2773         (-[WebView setEditable:]):
2774         (-[WebView isEditable]):
2775         * WebView/WebViewData.h:
2776
2777 2011-02-28  Oliver Hunt  <oliver@apple.com>
2778
2779         Reviewed by Gavin Barraclough.
2780
2781         Make ScopeChainNode GC allocated
2782         https://bugs.webkit.org/show_bug.cgi?id=55283
2783
2784         More updates for the absence of the ScopeChain class
2785
2786         * WebView/WebScriptDebugDelegate.mm:
2787         (-[WebScriptCallFrame scopeChain]):
2788
2789 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2790
2791         Reviewed by Pavel Feldman.
2792
2793         DumpRenderTree should reset frame opener between tests.
2794         https://bugs.webkit.org/show_bug.cgi?id=54874
2795
2796         Added clearOpener method to WebFramePrivate.
2797
2798         * WebView/WebFrame.mm:
2799         (-[WebFrame _clearOpener]):
2800         * WebView/WebFramePrivate.h:
2801
2802 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2803
2804         Unreviewed, rolling out r79764.
2805         http://trac.webkit.org/changeset/79764
2806         https://bugs.webkit.org/show_bug.cgi?id=55295
2807
2808         "broke Chromium builds" (Requested by rniwa on #webkit).
2809
2810         * WebView/WebFrame.mm:
2811         * WebView/WebFramePrivate.h:
2812
2813 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
2814
2815         Reviewed by David Kilzer.
2816
2817         https://bugs.webkit.org/show_bug.cgi?id=48781
2818
2819         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
2820
2821         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
2822         should paint the default broken image when an image fails to load or decode.  The method also passes the
2823         URL of the failed image.
2824
2825         * WebCoreSupport/WebFrameLoaderClient.h:
2826         * WebCoreSupport/WebFrameLoaderClient.mm:
2827         (WebFrameLoaderClient::shouldPaintBrokenImage):
2828         * WebView/WebDelegateImplementationCaching.h:
2829         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
2830         (CallResourceLoadDelegateReturningBoolean):
2831         * WebView/WebResourceLoadDelegatePrivate.h:
2832         * WebView/WebView.mm:
2833         (-[WebView _cacheResourceLoadDelegateImplementations]):
2834
2835 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2836
2837         Reviewed by Pavel Feldman.
2838
2839         DumpRenderTree should reset frame opener between tests.
2840         https://bugs.webkit.org/show_bug.cgi?id=54874
2841
2842         Added clearOpener method to WebFramePrivate.
2843
2844         * WebView/WebFrame.mm:
2845         (-[WebFrame _clearOpener]):
2846         * WebView/WebFramePrivate.h:
2847
2848 2011-02-25  Mark Rowe  <mrowe@apple.com>
2849
2850         <rdar://problem/8902546> Build fix.
2851
2852         * Misc/QuickDrawCompatibility.h:
2853
2854 2011-02-24  Anders Carlsson  <andersca@apple.com>
2855
2856         Fix clang build.
2857
2858         * WebCoreSupport/WebKeyGenerator.m:
2859         (toWebCertificateParseResult):
2860         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
2861         * WebView/WebTextCompletionController.mm:
2862
2863 2011-02-24  Peter Kasting  <pkasting@google.com>
2864
2865         Reviewed by Eric Seidel.
2866
2867         Drop the "U; " encryption level from the User Agent string.
2868         https://bugs.webkit.org/show_bug.cgi?id=54566
2869
2870         * WebView/WebView.mm:
2871         (+[WebView _standardUserAgentWithApplicationName:]):
2872
2873 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2874
2875         Unreviewed, rolling out r79570.
2876         http://trac.webkit.org/changeset/79570
2877         https://bugs.webkit.org/show_bug.cgi?id=54874
2878
2879         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2880         was not updated
2881
2882         * WebView/WebFrame.mm:
2883         * WebView/WebFramePrivate.h:
2884
2885 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2886
2887         Reviewed by Alexey Proskuryakov.
2888
2889         DumpRenderTree should reset frame opener between tests.
2890         https://bugs.webkit.org/show_bug.cgi?id=54874
2891
2892         Added clearOpener method to WebFramePrivate.
2893
2894         * WebView/WebFrame.mm:
2895         (-[WebFrame _clearOpener]):
2896         * WebView/WebFramePrivate.h:
2897
2898 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2899
2900         Reviewed by Alexey Proskuryakov.
2901
2902         Drop the language tag part from the User Agent string
2903         https://bugs.webkit.org/show_bug.cgi?id=54560
2904
2905         * WebView/WebView.mm:
2906         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
2907         language tag part.
2908
2909 2011-02-22  Brady Eidson  <beidson@apple.com>
2910
2911         Reviewed by Anders Carlsson.
2912
2913         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
2914         API to view and delete Application Cache data by origin.
2915
2916         * WebCoreSupport/WebApplicationCache.mm:
2917         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
2918
2919 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2920
2921         Reviewed by Kent Tamura.
2922
2923         Rename Position::node() to Position::deprecatedNode()
2924         https://bugs.webkit.org/show_bug.cgi?id=54622
2925
2926         * WebView/WebFrame.mm:
2927         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2928
2929 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2930
2931         Reviewed by Kent Tamura.
2932
2933         Rename Position::node() to Position::deprecatedNode()
2934         https://bugs.webkit.org/show_bug.cgi?id=54622
2935         
2936         Done the rename.
2937
2938         * WebView/WebFrame.mm:
2939         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
2940         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
2941
2942 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
2943
2944         Reviewed by Sam Weinig.
2945
2946         Bug 54786 - Devirtualize JSCell::classInfo()
2947
2948         Instead of making a virtual function call, add a pointer to the ClassInfo
2949         onto Structure.
2950
2951         This removes a virtual function call, and paves the way towards removing all
2952         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
2953         (these should be able to move onto ClassInfo).
2954
2955         Calls to Structure::create must now pass a pointer to the ClassInfo for the
2956         structure. All objects now have a ClassInfo pointer, non-object cell types
2957         still do not.
2958
2959         Changes are most mechanical, involving three steps:
2960             * Remove virtual classInfo() methods.
2961             * Add &s_info parameter to calls to Structure::create.
2962             * Rename ClassInfo static members on classes from 'info' to 's_info',
2963               for consistency.
2964
2965         * Plugins/Hosted/ProxyInstance.mm:
2966         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2967         (WebKit::ProxyRuntimeMethod::createStructure):
2968         * Plugins/Hosted/ProxyRuntimeObject.h:
2969         (WebKit::ProxyRuntimeObject::createStructure):
2970         * Plugins/Hosted/ProxyRuntimeObject.mm:
2971         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2972         * WebView/WebView.mm:
2973         (aeDescFromJSValue):
2974
2975 2011-02-19  Brian Ryner  <bryner@chromium.org>
2976
2977         Reviewed by Adam Barth.
2978
2979         Add missing #include of DocumentLoader.h, needed since the transitive
2980         include through Document.h is removed.
2981         https://bugs.webkit.org/show_bug.cgi?id=50489
2982
2983         * WebView/WebFrame.mm:
2984
2985 2011-02-19  Charlie Reis  <creis@chromium.org>
2986
2987         Reviewed by Mihai Parparita.
2988
2989         Ensure loading has stopped in HistoryController::goToItem
2990         https://bugs.webkit.org/show_bug.cgi?id=54517
2991
2992         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2993
2994         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2995
2996         * WebCoreSupport/WebFrameLoaderClient.mm:
2997         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2998         * WebCoreSupport/WebFrameLoaderClient.h:
2999
3000 2011-02-16  David Hyatt  <hyatt@apple.com>
3001
3002         Reviewed by Dan Bernstein.
3003
3004         https://bugs.webkit.org/show_bug.cgi?id=54244
3005         
3006         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
3007         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
3008         
3009         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
3010         been changed as well.
3011         
3012         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
3013         
3014         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
3015         
3016         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
3017         still have a precise floating point position.
3018
3019         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
3020         be rounding justification spacing in their font code.
3021
3022         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
3023
3024         * Misc/WebKitNSStringExtras.mm:
3025         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3026         (-[NSString _web_widthWithFont:]):
3027
3028 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
3029
3030         Reviewed by Adam Roben.
3031
3032         HTML5 <details> and <summary>: localized text
3033         https://bugs.webkit.org/show_bug.cgi?id=54260
3034
3035         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
3036         provide the default label to be used by a <details> tag that has no <summary> child.
3037
3038         * WebCoreSupport/WebPlatformStrategies.h:
3039         * WebCoreSupport/WebPlatformStrategies.mm:
3040         (WebPlatformStrategies::defaultDetailsSummaryText):
3041
3042 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
3043
3044         Reviewed by Simon Fraser.
3045
3046         Allow acceleratesDrawing for WebKit2
3047         https://bugs.webkit.org/show_bug.cgi?id=54511
3048
3049         Plumb through preference for accelerated drawing.
3050         
3051         * WebView/WebPreferenceKeysPrivate.h:
3052         * WebView/WebPreferences.mm:
3053         (+[WebPreferences initialize]):
3054         (-[WebPreferences acceleratedDrawingEnabled]):
3055         (-[WebPreferences setAcceleratedDrawingEnabled:]):
3056         * WebView/WebPreferencesPrivate.h:
3057
3058 2011-02-15  David Kilzer  <ddkilzer@apple.com>
3059
3060         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
3061
3062         Reviewed by Darin Adler.
3063
3064         * WebView/WebDynamicScrollBarsView.h:
3065         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
3066         declaration.
3067         * WebView/WebDynamicScrollBarsView.mm:
3068         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
3069         implementation into correct category.
3070         * WebView/WebDynamicScrollBarsViewInternal.h:
3071         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
3072         declaration.
3073         * WebView/WebHTMLView.mm: Included
3074         WebDynamicScrollBarsViewInternal.h instead of
3075         WebDynamicScrollBarsView.h.
3076
3077 2011-02-14  Oliver Hunt  <oliver@apple.com>
3078
3079         Reviewed by Gavin Barraclough and Geoff Garen.
3080
3081         Refactor handles and weak pointers to become nicer and more automatic
3082         https://bugs.webkit.org/show_bug.cgi?id=54415
3083
3084         Update to use Global<> instead of ProtectedPtr, and refactored slightly
3085         to get global data to places it's needed for when we're assigning to
3086         Global<>s
3087
3088         * ForwardingHeaders/collector/handles/Global.h: Added.
3089         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3090         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3091         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
3092         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
3093         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
3094         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3095         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
3096         (WebKit::NetscapePluginInstanceProxy::evaluate):
3097         (WebKit::NetscapePluginInstanceProxy::invoke):
3098         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3099         (WebKit::NetscapePluginInstanceProxy::construct):
3100         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
3101         * WebView/WebScriptDebugger.h:
3102         * WebView/WebScriptDebugger.mm:
3103         (WebScriptDebugger::WebScriptDebugger):
3104
3105 2011-02-15  Jia Pu  <jpu@apple.com>
3106
3107         Reviewed by Darin Adler.
3108
3109         Autocorrection should respect undo.
3110         https://bugs.webkit.org/show_bug.cgi?id=52221
3111         <rdar://problem/8663399>
3112
3113         Please see WebCore/ChangeLog for detailed description.
3114
3115         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
3116
3117         * WebCoreSupport/WebEditorClient.mm:
3118         (WebEditorClient::recordAutocorrectionResponse): Ditto.
3119
3120         * WebView/WebFrame.mm:
3121         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3122              Adopted new signature of ReplaceSelectionCommand::create().
3123
3124 2011-02-15  David Kilzer  <ddkilzer@apple.com>
3125
3126         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
3127
3128         Reviewed by Darin Adler.
3129
3130         * WebView/WebDynamicScrollBarsView.h:
3131         * WebView/WebDynamicScrollBarsView.mm:
3132         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
3133         -inProgramaticScroll.
3134         * WebView/WebHTMLView.mm:
3135         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
3136
3137 2011-02-15  Kenneth Russell  <kbr@google.com>
3138
3139         Reviewed by Darin Fisher.
3140
3141         Allow controlling minimum DOMTimer interval on a per-page basis
3142         https://bugs.webkit.org/show_bug.cgi?id=54312
3143
3144         Added needed methods to implement LayoutTestController's new
3145         setMinimumTimerInterval method.
3146
3147         * WebView/WebView.mm:
3148         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3149         (+[WebView _defaultMinimumTimerInterval]):
3150         (-[WebView _setMinimumTimerInterval:]):
3151         * WebView/WebViewPrivate.h:
3152
3153 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
3154
3155         Reviewed by Oliver Hunt.
3156
3157         A little more encapsulation for the heap: Removed CollectorHeapIterator
3158         https://bugs.webkit.org/show_bug.cgi?id=54298
3159
3160         * Misc/WebCoreStatistics.mm:
3161         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
3162         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
3163
3164 2011-02-10  Nate Chapin  <japhet@chromium.org>
3165
3166         Reviewed by Adam Barth.
3167
3168         Update calls to DocumentWriter.
3169         https://bugs.webkit.org/show_bug.cgi?id=50489
3170
3171         * WebView/WebFrame.mm:
3172         (-[WebFrame _canProvideDocumentSource]):
3173
3174 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
3175
3176         Reviewed by Anders Carlsson.
3177
3178         AX: AX needs to stop using WebCoreViewFactory
3179         https://bugs.webkit.org/show_bug.cgi?id=54153
3180
3181         * WebCoreSupport/WebSystemInterface.mm:
3182         (InitWebCoreSystemInterface):
3183
3184 2011-02-10  Peter Varga  <pvarga@webkit.org>
3185
3186         Reviewed by Csaba Osztrogonác.
3187
3188         Remove PCRE source from trunk
3189         https://bugs.webkit.org/show_bug.cgi?id=54188
3190
3191         * ForwardingHeaders/pcre/pcre.h: Removed.
3192
3193 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
3194
3195         Reviewed by Yury Semikhatsky.
3196
3197         Web Inspector: follow up on InspectorAgent split -
3198         removing unnecessary methods from InspectorController.
3199         https://bugs.webkit.org/show_bug.cgi?id=54093
3200
3201         * WebInspector/WebInspector.mm:
3202         (-[WebInspector showConsole:]):
3203         (-[WebInspector stopProfilingJavaScript:]):
3204
3205 2011-02-08  Dan Bernstein  <mitz@apple.com>
3206
3207         Reviewed by Jon Honeycutt and Maciej Stachowiak.
3208
3209         <rdar://problem/8959420> Find in Mail no longer cycles around
3210
3211         * WebView/WebHTMLView.mm:
3212         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
3213         the wrap option according to the flag.
3214
3215 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3216
3217         Unreviewed, rolling out r77980.
3218         http://trac.webkit.org/changeset/77980
3219         https://bugs.webkit.org/show_bug.cgi?id=54043
3220
3221         "Crashes on Windows and Linux..." (Requested by leviw on
3222         #webkit).
3223
3224         * WebView/WebFrame.mm:
3225         (-[WebFrame _caretRectAtNode:offset:affinity:]):
3226         * WebView/WebFrameInternal.h:
3227         * WebView/WebTextCompletionController.mm:
3228         (-[WebTextCompletionController doCompletion]):
3229
3230 2011-02-08  Levi Weintraub  <leviw@chromium.org>
3231
3232         Reviewed by Ryosuke Niwa.
3233
3234         Stop instantiating legacy editing Positions in VisiblePosition
3235         https://bugs.webkit.org/show_bug.cgi?id=52919
3236
3237         Changing usage of legacy VisiblePosition constructor. Since we were dealing
3238         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
3239
3240         * WebView/WebFrame.mm:
3241         (-[WebFrame _caretRectAtPosition:affinity:]):
3242         * WebView/WebFrameInternal.h:
3243         * WebView/WebTextCompletionController.mm:
3244         (-[WebTextCompletionController doCompletion]):
3245
3246 2011-02-08  Adam Barth  <abarth@webkit.org>
3247
3248         Reviewed by Eric Seidel.
3249
3250         Remove orphan code from old parser
3251         https://bugs.webkit.org/show_bug.cgi?id=53984
3252
3253         * WebCoreSupport/WebChromeClient.h:
3254
3255 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
3256
3257         Reviewed by Yury Semikhatsky.
3258
3259         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
3260
3261         https://bugs.webkit.org/show_bug.cgi?id=53169
3262
3263         Minor change enforced by major changes in WebCore/inspector/InspectorController.
3264
3265         * WebInspector/WebInspector.mm:
3266         (-[WebInspector isTimelineProfilingEnabled]):
3267
3268 2011-02-07  Enrica Casucci  <enrica@apple.com>
3269
3270         Reviewed Adam Roben and Darin Adler.
3271
3272         WebKit2: drag and drop support on Windows.
3273         https://bugs.webkit.org/show_bug.cgi?id=52775
3274
3275         Removed createDragImageForLink from DragClient.
3276
3277         * WebCoreSupport/WebDragClient.h:
3278         * WebCoreSupport/WebDragClient.mm:
3279         (WebDragClient::startDrag):
3280
3281 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
3282
3283         Reviewed by Pavel Feldman.
3284
3285         Web Inspector: remove settings related methods from InspectorClient
3286         https://bugs.webkit.org/show_bug.cgi?id=53686
3287
3288         * WebCoreSupport/WebInspectorClient.h:
3289         * WebCoreSupport/WebInspectorClient.mm:
3290         (WebInspectorClient::openInspectorFrontend):
3291         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3292
3293 2011-02-03  James Kozianski  <koz@chromium.org>
3294
3295         Reviewed by Dimitri Glazkov.
3296
3297         Add navigator.registerProtocolHandler behind a flag.
3298         https://bugs.webkit.org/show_bug.cgi?id=52609
3299
3300         * Configurations/FeatureDefines.xcconfig:
3301
3302 2011-02-03  Adam Langley  <agl@chromium.org>
3303
3304         Reviewed by Adam Barth.
3305
3306         Plumb mixed script URL to FrameLoaderClient
3307         https://bugs.webkit.org/show_bug.cgi?id=52384
3308
3309         Regressions covered by http/tests/security/mixedContent/*
3310
3311         * WebCoreSupport/WebFrameLoaderClient.h:
3312         * WebCoreSupport/WebFrameLoaderClient.mm:
3313         (WebFrameLoaderClient::didRunInsecureContent):
3314
3315 2011-02-03  Beth Dakin  <bdakin@apple.com>
3316
3317         Reviewed by Sam Weinig.
3318
3319         Fix for <rdar://problem/8944544> Ability to animate track
3320         for WKPainter scrollers
3321
3322         * WebCoreSupport/WebSystemInterface.mm:
3323         (InitWebCoreSystemInterface):
3324
3325 2011-02-02  Mark Rowe  <mrowe@apple.com>
3326
3327         Reviewed by Beth Dakin.
3328
3329         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
3330
3331         * WebCoreSupport/WebSystemInterface.mm:
3332         (InitWebCoreSystemInterface): Add some missing initializers.
3333
3334 2011-02-02  Steve Lacey  <sjl@chromium.org>
3335
3336         Reviewed by Eric Carlson.
3337
3338         Implement basic media statistics on media elements.
3339         https://bugs.webkit.org/show_bug.cgi?id=53322
3340
3341         * Configurations/FeatureDefines.xcconfig:
3342
3343 2011-02-01  Sam Weinig  <sam@webkit.org>
3344
3345         Reviewed by Beth Dakin.
3346
3347         Part 2 for <rdar://problem/8492788>
3348         Adopt WKScrollbarPainterController
3349
3350         Use header detection to define scrollbar painting controller #define.
3351
3352         * WebCoreSupport/WebSystemInterface.mm:
3353         (InitWebCoreSystemInterface):
3354
3355 2011-02-01  David Hyatt  <hyatt@apple.com>
3356
3357         Reviewed by Oliver Hunt.
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=53520
3360         
3361         Remove the physical terminology from IntRect and FloatRect.
3362         
3363         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
3364         we need to update our terminology to be more accurate.
3365
3366         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
3367         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
3368         even for flipped rectangles.
3369
3370         * WebView/WebHTMLView.mm:
3371         (setNeedsDisplayInRect):
3372
3373 2011-02-01  Beth Dakin  <bdakin@apple.com>
3374
3375         Reviewed by Sam Weinig.
3376
3377         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
3378
3379         * WebCoreSupport/WebSystemInterface.mm:
3380         (InitWebCoreSystemInterface):
3381
3382 2011-02-01  Dave Hyatt  <hyatt@apple.com>
3383
3384         Reviewed by Darin Adler.
3385
3386         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
3387         with vertical text.
3388
3389         Change printing functions to check writing-mode and properly swap width and height
3390         as needed.
3391
3392         * WebView/WebDynamicScrollBarsView.mm:
3393         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
3394         * WebView/WebFrame.mm:
3395         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
3396         * WebView/WebFrameInternal.h:
3397         * WebView/WebHTMLView.mm:
3398         (-[WebHTMLView _web_setPrintingModeRecursive]):
3399         (-[WebHTMLView _web_clearPrintingModeRecursive]):
3400         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
3401         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
3402         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
3403         (-[WebHTMLView _endPrintMode]):
3404         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
3405         (-[WebHTMLView _endScreenPaginationMode]):
3406         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3407         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
3408         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
3409         (-[WebHTMLView _scaleFactorForPrintOperation:]):
3410         (-[WebHTMLView setPageWidthForPrinting:]):
3411         (-[WebHTMLView knowsPageRange:]):
3412
3413 2011-01-31  Oliver Hunt  <oliver@apple.com>
3414
3415         Convert markstack to a slot visitor API
3416         https://bugs.webkit.org/show_bug.cgi?id=53219
3417
3418         rolling r77098, r77099, r77100, r77109, and
3419         r77111 back in, along with a few more Qt fix attempts.
3420
3421         * WebView/WebScriptDebugDelegate.mm:
3422         (-[WebScriptCallFrame scopeChain]):
3423
3424 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
3425
3426         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
3427         r77111.
3428         http://trac.webkit.org/changeset/77098
3429         http://trac.webkit.org/changeset/77099
3430         http://trac.webkit.org/changeset/77100
3431         http://trac.webkit.org/changeset/77109
3432         http://trac.webkit.org/changeset/77111
3433         https://bugs.webkit.org/show_bug.cgi?id=53219
3434
3435         Qt build is broken
3436
3437         * WebView/WebScriptDebugDelegate.mm:
3438         (-[WebScriptCallFrame scopeChain]):
3439
3440 2011-01-30  Oliver Hunt  <oliver@apple.com>
3441
3442         Convert markstack to a slot visitor API
3443         https://bugs.webkit.org/show_bug.cgi?id=53219
3444
3445         rolling r77006 and r77020 back in.
3446
3447         * WebView/WebScriptDebugDelegate.mm:
3448         (-[WebScriptCallFrame scopeChain]):
3449
3450 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
3451
3452         Reviewed by Maciej Stachowiak.
3453
3454         Some more Heap cleanup.
3455         https://bugs.webkit.org/show_bug.cgi?id=53357
3456
3457         Updated for JavaScriptCore changes.
3458
3459         * Misc/WebCoreStatistics.mm:
3460         (+[WebCoreStatistics memoryStatistics]):
3461
3462 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3463
3464         Unreviewed, rolling out r77006 and r77020.
3465         http://trac.webkit.org/changeset/77006
3466         http://trac.webkit.org/changeset/77020
3467         https://bugs.webkit.org/show_bug.cgi?id=53360
3468
3469         "Broke Windows tests" (Requested by rniwa on #webkit).
3470
3471         * WebView/WebScriptDebugDelegate.mm:
3472         (-[WebScriptCallFrame scopeChain]):
3473
3474 2011-01-27  Oliver Hunt  <oliver@apple.com>
3475
3476         Reviewed by Geoffrey Garen.
3477
3478         Convert markstack to a slot visitor API
3479         https://bugs.webkit.org/show_bug.cgi?id=53219
3480
3481         Update to new marking api
3482
3483         * WebView/WebScriptDebugDelegate.mm:
3484         (-[WebScriptCallFrame scopeChain]):
3485
3486 2011-01-28  Dan Bernstein  <mitz@apple.com>
3487
3488         Reviewed by Sam Weinig.
3489
3490         <select> can't display right-to-left (rtl) languages
3491         https://bugs.webkit.org/show_bug.cgi?id=19785
3492
3493         * WebCoreSupport/WebChromeClient.h:
3494         * WebCoreSupport/WebChromeClient.mm:
3495         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
3496         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
3497
3498 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3499
3500         Unreviewed, rolling out r76891.
3501         http://trac.webkit.org/changeset/76891
3502         https://bugs.webkit.org/show_bug.cgi?id=53280
3503
3504         Makes every layout test crash (Requested by othermaciej on
3505         #webkit).
3506
3507         * Misc/WebIconDatabase.mm:
3508         (-[ThreadEnabler threadEnablingSelector:]):
3509         (importToWebCoreFormat):
3510
3511 2011-01-27  Nate Chapin  <japhet@chromium.org>
3512
3513         Reviewed by Adam Barth.
3514
3515         Use Document::url() instead of FrameLoader::url().
3516         https://bugs.webkit.org/show_bug.cgi?id=41165
3517
3518         * WebView/WebView.mm:
3519         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
3520
3521 2011-01-27  Dan Bernstein  <mitz@apple.com>
3522
3523         Rubber-stamped by Anders Carlsson.
3524
3525         Reverted an accidental change in r76561.
3526
3527         * WebView/WebHTMLView.mm:
3528
3529 2011-01-26  David Kilzer  <ddkilzer@apple.com>
3530
3531         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
3532         <rdar://problem/8821760>
3533
3534         Reviewed by Antti Koivisto.
3535
3536         * WebCoreSupport/WebSystemInterface.mm:
3537         (InitWebCoreSystemInterface): Added initialization for
3538         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
3539
3540 2011-01-26  Beth Dakin  <bdakin@apple.com>
3541
3542         Reviewed by Darin Adler.
3543
3544         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
3545         when using WKScrollbars.
3546
3547         * WebCoreSupport/WebSystemInterface.mm:
3548         (InitWebCoreSystemInterface):
3549
3550 2011-01-25  Darin Adler  <darin@apple.com>
3551
3552         Reviewed by Anders Carlsson.
3553
3554         WebKit is using CSBackupSetItemExcluded incorrectly
3555         https://bugs.webkit.org/show_bug.cgi?id=53095
3556         rdar://problem/8790540
3557
3558         * Misc/WebIconDatabase.mm:
3559         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
3560         It was incorrect, and this responsibility has been moved to WebCore.
3561
3562 2011-01-24  Chris Marrin  <cmarrin@apple.com>
3563
3564         Reviewed by Eric Seidel.
3565
3566         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
3567         https://bugs.webkit.org/show_bug.cgi?id=53041
3568
3569         * Configurations/FeatureDefines.xcconfig:
3570
3571 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
3572
3573         Reviewed by Pavel Feldman.
3574
3575         Web Inspector: remove "attached" state related methods from InspectorAgent
3576         https://bugs.webkit.org/show_bug.cgi?id=53086
3577
3578         * WebCoreSupport/WebInspectorClient.h:
3579         * WebCoreSupport/WebInspectorClient.mm:
3580         (-[WebInspectorWindowController showWindow:]):
3581         (-[WebInspectorWindowController attach]):
3582         (-[WebInspectorWindowController detach]):
3583
3584 2011-01-23  Dan Bernstein  <mitz@apple.com>
3585
3586         Reviewed by John Sullivan.
3587
3588         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
3589
3590         * WebCoreSupport/WebChromeClient.mm:
3591         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
3592
3593 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
3594
3595         Reviewed by Darin Adler.
3596
3597         https://bugs.webkit.org/show_bug.cgi?id=52473
3598         Auto-scaling to avoid orphans is broken, remove dysfunctional code
3599
3600         * WebView/WebHTMLView.mm:
3601         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
3602         (-[WebHTMLView _scaleFactorForPrintOperation:]):
3603         (-[WebHTMLView knowsPageRange:]):
3604
3605 2011-01-21  Mark Rowe  <mrowe@apple.com>
3606
3607         Rubber-stamped by Jon Honeycutt.
3608
3609         Fix the build when using Clang by removing some unused variables.
3610
3611         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3612         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3613         * WebView/WebFullScreenController.mm:
3614         (-[WebFullScreenController enterFullscreen:]):
3615         (-[WebFullScreenController exitFullscreen]):
3616
3617 2011-01-21  Chris Rogers  <crogers@google.com>
3618
3619         Reviewed by Darin Fisher.
3620
3621         Add run-time enable support for the web audio API
3622         https://bugs.webkit.org/show_bug.cgi?id=52741
3623
3624         * WebView/WebPreferenceKeysPrivate.h:
3625         * WebView/WebPreferences.mm:
3626         (-[WebPreferences webAudioEnabled]):
3627         (-[WebPreferences setWebAudioEnabled:]):
3628         * WebView/WebPreferencesPrivate.h:
3629         * WebView/WebView.mm:
3630         (-[WebView _preferencesChangedNotification:]):
3631
3632 2011-01-20  John Sullivan  <sullivan@apple.com>
3633
3634         Reviewed by Mark Rowe.
3635
3636         Shift-tab doesn't cycle through fields in http authentication panel
3637         https://bugs.webkit.org/show_bug.cgi?id=52850
3638
3639         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
3640         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
3641         Re-wired the key loop so that there aren't two views with the same nextKeyView.
3642
3643 2011-01-20  Beth Dakin  <bdakin@apple.com>
3644
3645         Reviewed by Geoffrey Garen.
3646
3647         Fix for <rdar://problem/8890255>
3648
3649         Allow WebKitSystemInterface to draw scrollbars 
3650         when appropriate.
3651         * WebCoreSupport/WebSystemInterface.mm:
3652         (InitWebCoreSystemInterface):
3653
3654 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
3655
3656         Reviewed by Sam Weinig.
3657
3658         GraphicsLayers in subframes can get sync'd multiple times
3659         https://bugs.webkit.org/show_bug.cgi?id=52489
3660
3661         * WebView/WebView.mm:
3662         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
3663         was renamed to syncCompositingStateIncludingSubframes().
3664
3665 2011-01-19  Darin Adler  <darin@apple.com>
3666
3667         Reviewed by Sam Weinig.
3668
3669         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
3670         https://bugs.webkit.org/show_bug.cgi?id=52104
3671         rdar://problem/8704226
3672
3673         * WebView/WebDelegateImplementationCaching.h:
3674         Fix type of second integer in CallScriptDebugDelegate function overload
3675         to be int to match the actual Objective-C method. Added a new overload
3676         that includes a BOOL in the right place. Added a boolean named
3677         exceptionWasRaisedExpectsHasHandlerFlag.
3678
3679         * WebView/WebDelegateImplementationCaching.mm:
3680         (CallDelegate): Added overloads as above.
3681         (CallScriptDebugDelegate): Ditto.
3682
3683         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
3684         boolean argument. Marked the old method informally deprecated.
3685
3686         * WebView/WebScriptDebugger.mm:
3687         (WebScriptDebugger::exception): Added code to call with or without the
3688         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
3689
3690         * WebView/WebView.mm:
3691         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
3692         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
3693         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
3694
3695 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
3696
3697         Reviewed by Mihai Parparita.
3698
3699         Perform some forward declaration
3700         https://bugs.webkit.org/show_bug.cgi?id=52522
3701
3702         * Misc/WebKitNSStringExtras.mm:
3703
3704 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
3705
3706         Reviewed by Yury Semikhatsky.
3707
3708         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
3709         https://bugs.webkit.org/show_bug.cgi?id=52721
3710
3711         * WebView/WebScriptDebugger.h:
3712         * WebView/WebScriptDebugger.mm:
3713         (toNSString):
3714         (WebScriptDebugger::sourceParsed):
3715
3716 2011-01-19  Levi Weintraub  <leviw@google.com>
3717
3718         Reviewed by Ryosuke Niwa.
3719
3720         Updating to use Position::parentAnchoredEquivalent instead of
3721         the old htmlediting rangeCompliantEquivalent.
3722
3723         remove rangeCompliantEquivalent and replace it with Position methods
3724         https://bugs.webkit.org/show_bug.cgi?id=25057
3725
3726         * WebView/WebFrame.mm:
3727         (-[WebFrame _smartDeleteRangeForProposedRange:]):
3728
3729 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
3730
3731         Reviewed by Darin Adler.
3732
3733         REGRESSION: A problem with Voiceover and finding links
3734         https://bugs.webkit.org/show_bug.cgi?id=52324
3735
3736         * WebView/WebDynamicScrollBarsView.mm:
3737         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
3738
3739 2011-01-17  David Kilzer  <ddkilzer@apple.com>
3740
3741         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
3742
3743         Reviewed by Dan Bernstein.
3744
3745         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
3746         DOMDocumentPrivate.h to the PrivateHeaders directory.
3747
3748 2011-01-17  Enrica Casucci  <enrica@apple.com>
3749
3750         Reviewed by Alexey Proskuryakov.
3751
3752         Drag and drop support: refactoring of image from link and image from selection
3753         https://bugs.webkit.org/show_bug.cgi?id=52496
3754
3755         This work cleans up the Mac code and makes it more similar to the Windows implementation,
3756         avoiding the use of an NSView when the FrameView can be used.
3757         The refactoring is a necessary step towards the complete support of drag and drop
3758         in WebKit2.
3759
3760         * WebCoreSupport/WebDragClient.mm:
3761         (WebDragClient::createDragImageForLink): Added.
3762         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
3763         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
3764
3765 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
3766
3767         Reviewed by Yury Semikhatsky.
3768
3769         Web Inspector: simplify debugger enabling routine.
3770         https://bugs.webkit.org/show_bug.cgi?id=52472
3771
3772         * WebInspector/WebInspector.mm:
3773         (-[WebInspector startDebuggingJavaScript:]):
3774
3775 2011-01-16  Dan Bernstein  <mitz@apple.com>
3776
3777         Reviewed by Simon Fraser.
3778
3779         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
3780         https://bugs.webkit.org/show_bug.cgi?id=52550
3781
3782         * Plugins/WebNetscapePluginView.mm:
3783         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
3784         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
3785
3786 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
3787
3788         Reviewed by Dan Bernstein.
3789
3790         Issues with iframes and plugins when the WebView is scaled.
3791         <rdar://problem/6213380>
3792         
3793         When _scaleWebView has been called on a WebView, iframes
3794         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
3795         This is caused by AppKit NSViews not playing nicely with the scale
3796         applied through style.
3797         
3798         Work around most of these issues by adjusting the bounds size
3799         of widgets to allow iframe contents to paint with the correct scale,
3800         and fix various places in the code where we relied on coordinate
3801         transforms via NSViews (which ignore CSS transforms).
3802
3803         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3804         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3805         * WebView/WebFrameView.mm:
3806         (-[WebFrameView setBoundsSize:]):
3807
3808 2011-01-16  Beth Dakin  <bdakin@apple.com>
3809
3810         Reviewed by Kevin Decker.
3811
3812         Fix for <rdar://problem/8871204>
3813
3814         Don't try to save elasticity state. Just rely on
3815         NSScrollElasticityAutomatic to restore the correct state.
3816         * WebCoreSupport/WebFrameLoaderClient.h:
3817         * WebCoreSupport/WebFrameLoaderClient.mm:
3818         (WebFrameLoaderClient::WebFrameLoaderClient):
3819         (WebFrameLoaderClient::dispatchDidFirstLayout):
3820         (WebFrameLoaderClient::provisionalLoadStarted):
3821
3822 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
3823
3824         Reviewed by Dan Bernstein.
3825
3826         Plugins render incorrectly with transformed ancestors
3827         https://bugs.webkit.org/show_bug.cgi?id=52507
3828         
3829         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
3830         in the ancestor chain of a plugin.
3831         
3832         So use of this method with calls to -actualVisibleRectInWindow, which
3833         maps rects through the render tree to compute the correct rect,
3834         clipping via windowClipRect() if necessary.
3835         
3836         Not testable, because doing so relies on the behavior of some
3837         plugins, which stop rendering if setWindow passes an empty rect.
3838
3839         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3840         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3841         * Plugins/WebBaseNetscapePluginView.h:
3842         * Plugins/WebBaseNetscapePluginView.mm:
3843         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3844         * Plugins/WebNetscapePluginView.mm:
3845         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3846
3847 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
3848
3849         Reviewed by Antti Koivisto.
3850
3851         Rename cache() to memoryCache()
3852         https://bugs.webkit.org/show_bug.cgi?id=52433
3853
3854         * Misc/WebCache.mm:
3855         (+[WebCache statistics]):
3856         (+[WebCache setDisabled:]):
3857         (+[WebCache isDisabled]):
3858         * WebView/WebView.mm:
3859         (+[WebView _setCacheModel:]):
3860
3861 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
3862
3863         Reviewed by Oliver Hunt.
3864
3865         Split out a MarkedSpace strategy object from Heap.
3866         https://bugs.webkit.org/show_bug.cgi?id=52421
3867
3868         * Misc/WebCoreStatistics.mm:
3869         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
3870
3871 2011-01-14  Dan Bernstein  <mitz@apple.com>
3872
3873         Reviewed by Simon Fraser.
3874
3875         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
3876
3877         * WebView/WebHTMLView.mm:
3878         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
3879         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
3880         that the NSView tree doesn’t change from under AppKit as it traverses it.
3881
3882 2011-01-14  Beth Dakin  <bdakin@apple.com>
3883
3884         Reviewed by Mark Rowe.
3885
3886         Fix for <rdar://problem/7793902> Artifacts when scrolling
3887         page in Safari while page is loading
3888
3889         Call setDrawsBackground:YES on the scrollView in 
3890         dispatchDidFirstLayout() rather than waiting until
3891         frameLoadCompleted(). Also suspend scrolling elasticity
3892         between provisionalLoadStarted() and dispatchDidFirstLayout()
3893         * WebCoreSupport/WebFrameLoaderClient.h:
3894         * WebCoreSupport/WebFrameLoaderClient.mm:
3895         (WebFrameLoaderClient::WebFrameLoaderClient):
3896         (WebFrameLoaderClient::dispatchDidFirstLayout):
3897         (WebFrameLoaderClient::provisionalLoadStarted):
3898
3899 2011-01-12  Enrica Casucci  <enrica@apple.com>
3900
3901         Reviewed by Darin Adler.
3902
3903         WebKit2: Add support for drag and drop
3904         https://bugs.webkit.org/show_bug.cgi?id=52343
3905         <rdar://problem/7660558>
3906         
3907         The DragData class has been extended to provide
3908         additional context from the application (keyboard state, modal windows, etc.)
3909         as well as information of the drag pasteboard being used.
3910         These are the changes to align the behavior for WebKit.
3911
3912         * WebView/WebView.mm:
3913         (-[WebView applicationFlags:]): Added.
3914         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
3915         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
3916         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
3917         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
3918
3919 2011-01-12  Beth Dakin  <bdakin@apple.com>
3920
3921         Reviewed by Anders Carlsson.
3922
3923         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
3924         Expose fixed layout through WebKit SPI
3925         -and corresponding-
3926         <rdar://problem/8844464>
3927
3928         And now with getters!
3929         * WebView/WebView.mm:
3930         (-[WebView _useFixedLayout]):
3931         (-[WebView _fixedLayoutSize]):
3932         * WebView/WebViewPrivate.h:
3933
3934 2011-01-12  Beth Dakin  <bdakin@apple.com>
3935
3936         Reviewed by Anders Carlsson.
3937
3938         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
3939         fixed layout through WebKit SPI
3940         -and corresponding-
3941         <rdar://problem/8844464>
3942
3943         * WebView/WebView.mm:
3944         (-[WebView _setUseFixedLayout:]):
3945         (-[WebView _setFixedLayoutSize:]):
3946         * WebView/WebViewPrivate.h:
3947
3948 2011-01-07  Enrica Casucci  <enrica@apple.com>
3949
3950         Reviewed by Alexey Proskuryakov.
3951
3952         Paste and drag and drop use different code paths to interact with the pasteboard.
3953         https://bugs.webkit.org/show_bug.cgi?id=52093
3954         The change consists in a refactoring of the code to have only one class that
3955         deals with the pasteboard on Mac.
3956
3957         * WebCoreSupport/WebEditorClient.h:
3958         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
3959         exposed by NSURLExtras.
3960         (WebEditorClient::canonicalizeURL):
3961         (WebEditorClient::canonicalizeURLString):
3962         * WebCoreSupport/WebPasteboardHelper.h: Removed.
3963         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
3964         * WebView/WebHTMLView.mm: Removed comment.
3965         * WebView/WebView.mm: The following methods have been changed to use the new DragData
3966         constructor that doesn't use the WebPasteboardHelper reference.
3967         (-[WebView draggingEntered:]):
3968         (-[WebView draggingUpdated:]):
3969         (-[WebView draggingExited:]):
3970         (-[WebView performDragOperation:]):
3971
3972 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
3973
3974         Reviewed by Alexey Proskuryakov.
3975
3976         Forward declare some headers where possible
3977         https://bugs.webkit.org/show_bug.cgi?id=52133
3978
3979         * WebView/WebFrame.mm:
3980
3981 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3982
3983         Reviewed by Darin Fisher.
3984
3985         https://bugs.webkit.org/show_bug.cgi?id=41441
3986         createWindow method should only do window-creating without URL navigation
3987
3988         * WebCoreSupport/WebChromeClient.mm:
3989         (WebChromeClient::createWindow):
3990
3991 2011-01-08  Dan Bernstein  <mitz@apple.com>
3992
3993         Try to fix the Leopard build.
3994
3995         * WebView/WebFullScreenController.mm:
3996
3997 2011-01-07  Jer Noble  <jer.noble@apple.com>
3998
3999         Yet another Leopard build fix: NSRect and CGRect are not inter-
4000         changable in 32-bit.  
4001         
4002         * WebView/WebFullScreenController.mm:
4003         (-[WebFullScreenController exitFullscreen]):
4004
4005 2011-01-07  Jer Noble  <jer.noble@apple.com>
4006
4007         Fix the Leopard build: Replace CoreAnimation SL-only functions
4008         with Leopard equivalents.
4009
4010         * WebView/WebFullScreenController.mm:
4011         (+[CATransaction setDisableActions:]):
4012         (+[CATransaction setAnimationDuration:]):
4013         (-[WebFullScreenController _animationDuration]):
4014         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
4015
4016 2010-12-21  Jer Noble  <jer.noble@apple.com>
4017
4018         Reviewed by Simon Fraser.
4019
4020         Implement WebKit Full Screen support.
4021         https://bugs.webkit.org/show_bug.cgi?id=49481
4022         rdar://problem/8247444
4023
4024         Support the new fullscreen Chrome client requests.  WebView will pass
4025         through these requests to a WebFullscreenController.
4026
4027         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
4028         * WebView/WebView.mm:
4029         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
4030         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
4031         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
4032         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
4033         * WebView/WebViewData.h: Add ivar newFullscreenController.
4034
4035 2010-12-17  Jer Noble  <jer@kokode.apple.com>
4036
4037         Reviewed by Simon Fraser.
4038
4039         Implement WebKit Full Screen support.
4040         https://bugs.webkit.org/show_bug.cgi?id=49481
4041         rdar://problem/8247444
4042         
4043         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
4044         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
4045         window, and a custom CAAnimation animates that layer between the initial screen rect of the
4046         full screen element, to its final value. WebFullscreenController will swap the WebView out of
4047         its original window, and into the fullscreen window. The controller will replace the WebView
4048         with a placeholder view, so that if the placeholder moves or resized while the WebView is
4049         absent, the WebView will move back to the correct location when exiting fullscreen.
4050
4051         * WebView/WebFullscreenController.h: Added.
4052         * WebView/WebFullscreenController.mm: Added.
4053         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
4054         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
4055         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
4056         (-[WebFullscreenController applicationDidResignActive:]):
4057         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
4058             the new screen parameters.
4059         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
4060             from its original screen rect into fullscreen.
4061         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
4062             Set up the animation that will take the fullscreen element back into its original screen
4063             rect.
4064         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
4065             whether to disable screensaver and sleep.
4066         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
4067             looking for HTMLVideoElements; returns whether any are found to be playing.
4068         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
4069             and shift keys.
4070         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
4071         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
4072         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
4073         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
4074         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
4075         (-[WebFullscreenWindow backgroundLayer]): Ditto.
4076         (-[WebFullscreenWindow animationView]): Ditto.
4077         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
4078         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
4079         
4080 2011-01-07  James Robinson  <jamesr@chromium.org>
4081
4082         Revert "Implement mozilla's animationTime property"
4083         https://bugs.webkit.org/show_bug.cgi?id=51952
4084
4085         This approach isn't quite right.
4086
4087         * WebView/WebHTMLView.mm:
4088         (-[WebHTMLView drawRect:]):
4089         * WebView/WebView.mm:
4090         (layerSyncRunLoopObserverCallBack):
4091
4092 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
4093
4094         Reviewed by Geoff Garen.
4095
4096         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
4097
4098         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
4099         destructor early, in order to release wrappers once we know we no longer intend to use them.
4100         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
4101         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
4102         A sequence of events that triggers the bug would look like this:
4103
4104         (1) Create a DOMWrapperWorld.
4105         (2) Register a timer in the world.
4106         (3) Call unregisterWorld() on the world.
4107         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
4108         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
4109             called forgetWorld() none exists.
4110         (6) Attempt to add a wrapper to a NULL map.
4111
4112         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
4113
4114         * WebView/WebScriptWorld.mm:
4115         (-[WebScriptWorld unregisterWorld]):
4116
4117 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4118
4119         Reviewed by Sam Weinig.
4120
4121         WK2: Support Accessibility
4122         https://bugs.webkit.org/show_bug.cgi?id=51859
4123
4124         Use rootObject() method to get top of AX tree.
4125
4126         * WebCoreSupport/WebFrameLoaderClient.h:
4127         (WebFrameLoaderClient::accessibilityRemoteObject):
4128         * WebView/WebFrame.mm:
4129         (-[WebFrame setAccessibleName:]):
4130         (-[WebFrame accessibilityRoot]):
4131         * WebView/WebFrameInternal.h:
4132         * WebView/WebFramePrivate.h:
4133         * WebView/WebHTMLView.mm:
4134         (-[WebHTMLView accessibilityAttributeValue:]):
4135         (-[WebHTMLView accessibilityFocusedUIElement]):
4136         (-[WebHTMLView accessibilityHitTest:]):
4137         (-[WebHTMLView _accessibilityParentForSubview:]):
4138
4139 2011-01-04  David Kilzer  <ddkilzer@apple.com>
4140
4141         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
4142
4143         Reviewed by Eric Carlson.
4144
4145         This originally broke in r61581.  It is inside an
4146         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
4147         build then.
4148
4149         * WebCoreSupport/WebFrameLoaderClient.mm: Call
4150         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
4151         use WebCore::PluginInfo.name instead of
4152         -[WebBasePluginPackage name].
4153
4154 2011-01-02  Dan Bernstein  <mitz@apple.com>
4155
4156         Rubber-stamped by Simon Fraser.
4157
4158         <rdar://problem/8812159> Update copyright strings
4159
4160         * Info.plist:
4161
4162 2010-12-29  Dan Bernstein  <mitz@apple.com>
4163
4164         Reviewed by Ada Chan.
4165
4166         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
4167         https://bugs.webkit.org/show_bug.cgi?id=51717
4168
4169         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
4170         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
4171
4172         * WebView/WebDocumentInternal.h:
4173         * WebView/WebHTMLView.mm:
4174         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
4175         (-[WebHTMLView _findString:options:]):
4176         * WebView/WebView.mm:
4177         (findString):
4178
4179 2010-12-28  Daniel Bates  <dbates@rim.com>
4180
4181         Reviewed by Sam Weinig.
4182