Source/WebKit/mac/ChangeLog

   1 2011-03-02  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Anders Carlsson.
   4
   5         Fix remaining localization issues by piping all localized strings through WebCore's
   6         localization bottleneck.
   7         <rdar://problem/8728860>
   8
   9         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  10         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
  11         * Misc/WebKitErrors.m:
  12         * Misc/WebLocalizableStringsInternal.h: Added.
  13         * Misc/WebLocalizableStringsInternal.mm: Added.
  14         (WebLocalizedStringInternal):
  15         * Panels/WebAuthenticationPanel.m:
  16         (-[WebAuthenticationPanel setUpForChallenge:]):
  17         * Plugins/Hosted/NetscapePluginHostManager.mm:
  18         (WebKit::NetscapePluginHostManager::spawnPluginHost):
  19         * WebCoreSupport/WebEditorClient.mm:
  20         (undoNameForEditAction):
  21         * WebCoreSupport/WebInspectorClient.mm:
  22         (WebInspectorFrontendClient::updateWindowTitle):
  23         (-[WebInspectorWindowController validateUserInterfaceItem:]):
  24         * WebCoreSupport/WebKeyGenerator.m:
  25         (-[WebKeyGenerator strengthMenuItemTitles]):
  26         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
  27         * WebCoreSupport/WebPlatformStrategies.mm:
  28         * WebView/WebHTMLView.mm:
  29         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
  30         * WebView/WebPDFView.mm:
  31         (-[WebPDFView menuForEvent:]):
  32
  33 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
  34
  35         Reviewed by Adam Roben.
  36
  37         Part of WebKit2: Need a way to send notifications to client when cookies change
  38         https://bugs.webkit.org/show_bug.cgi?id=55427
  39         <rdar://problem/9056027>
  40
  41         Add stubs for CookiesStrategy on Mac WebKit1.
  42
  43         * WebCoreSupport/WebPlatformStrategies.h:
  44         * WebCoreSupport/WebPlatformStrategies.mm:
  45         (WebPlatformStrategies::createCookiesStrategy):
  46         (WebPlatformStrategies::notifyCookiesChanged):
  47
  48 2011-03-01  Philippe Normand  <pnormand@igalia.com>
  49
  50         Reviewed by Eric Carlson.
  51
  52         [GStreamer] support in mac video fullscreen controller
  53         https://bugs.webkit.org/show_bug.cgi?id=52280
  54
  55         Factored the code to configure the video overlay in a new private
  56         method of the controller and added GStreamer support to it.
  57
  58         * WebView/WebVideoFullscreenController.h:
  59         * WebView/WebVideoFullscreenController.mm:
  60         (-[WebVideoFullscreenController setupVideoOverlay:]):
  61         (-[WebVideoFullscreenController windowDidLoad]):
  62         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
  63         (-[WebVideoFullscreenController windowDidExitFullscreen]):
  64
  65 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
  66
  67         Reviewed by Timothy Hatcher.
  68
  69         All Console Messages should be passed to ChromeClients.
  70         https://bugs.webkit.org/show_bug.cgi?id=54926
  71
  72         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
  73         which supersedes -webView:addMessageToConsole if it exists. The new delegate
  74         does not filter to only JavaScript originated console messages. The old
  75         delegate is left around for clients that expect filtered messages, like
  76         DashCode and older versions of Safari.
  77
  78         The dictionary message passed to the delegate now includes more information
  79         about the message source, type, and level.
  80
  81         * WebCoreSupport/WebChromeClient.mm:
  82         (stringForMessageSource):
  83         (stringForMessageType):
  84         (stringForMessageLevel):
  85         (WebChromeClient::addMessageToConsole):
  86         * WebView/WebUIDelegatePrivate.h:
  87
  88 2011-03-01  Levi Weintraub  <leviw@chromium.org>
  89
  90         Reviewed by Ryosuke Niwa.
  91
  92         Stop instantiating legacy editing Positions in VisiblePosition
  93         https://bugs.webkit.org/show_bug.cgi?id=52919
  94
  95         Changing usage of legacy VisiblePosition constructor. Since we were dealing
  96         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
  97
  98         * WebView/WebFrame.mm:
  99         (-[WebFrame _caretRectAtPosition:affinity:]):
 100         * WebView/WebFrameInternal.h:
 101         * WebView/WebTextCompletionController.mm:
 102         (-[WebTextCompletionController doCompletion]):
 103
 104 2011-03-01  Sam Weinig  <sam@webkit.org>
 105
 106         Reviewed by Timothy Hatcher.
 107
 108         WebKit2 needs to be made localizable
 109         https://bugs.webkit.org/show_bug.cgi?id=55483
 110
 111         * WebCoreSupport/WebPlatformStrategies.mm:
 112         Use WebCore's localizedString function instead of WebLocalizableStrings
 113         since WebCore is now responsible for localization.
 114
 115 2011-02-25 Steve Block <steveblock@google.com>
 116
 117         Reviewed by Jeremy Orlow.
 118
 119         Bridge.h should not include BridgeJSC.h
 120         https://bugs.webkit.org/show_bug.cgi?id=55212
 121
 122         Include BridgeJSC.h directly instead.
 123
 124         * Plugins/Hosted/ProxyInstance.h:
 125         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 126
 127 2011-02-28  Chang Shu  <cshu@webkit.org>
 128
 129         Reviewed by Ryosuke Niwa.
 130
 131         Remove the support of Frame::isContentEditable and its dependencies.
 132         https://bugs.webkit.org/show_bug.cgi?id=54292
 133
 134         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
 135
 136         * WebCoreSupport/WebEditorClient.h:
 137         * WebCoreSupport/WebEditorClient.mm:
 138         * WebView/WebView.mm:
 139         (-[WebView setEditable:]):
 140         (-[WebView isEditable]):
 141         * WebView/WebViewData.h:
 142
 143 2011-02-28  Oliver Hunt  <oliver@apple.com>
 144
 145         Reviewed by Gavin Barraclough.
 146
 147         Make ScopeChainNode GC allocated
 148         https://bugs.webkit.org/show_bug.cgi?id=55283
 149
 150         More updates for the absence of the ScopeChain class
 151
 152         * WebView/WebScriptDebugDelegate.mm:
 153         (-[WebScriptCallFrame scopeChain]):
 154
 155 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
 156
 157         Reviewed by Pavel Feldman.
 158
 159         DumpRenderTree should reset frame opener between tests.
 160         https://bugs.webkit.org/show_bug.cgi?id=54874
 161
 162         Added clearOpener method to WebFramePrivate.
 163
 164         * WebView/WebFrame.mm:
 165         (-[WebFrame _clearOpener]):
 166         * WebView/WebFramePrivate.h:
 167
 168 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 169
 170         Unreviewed, rolling out r79764.
 171         http://trac.webkit.org/changeset/79764
 172         https://bugs.webkit.org/show_bug.cgi?id=55295
 173
 174         "broke Chromium builds" (Requested by rniwa on #webkit).
 175
 176         * WebView/WebFrame.mm:
 177         * WebView/WebFramePrivate.h:
 178
 179 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
 180
 181         Reviewed by David Kilzer.
 182
 183         https://bugs.webkit.org/show_bug.cgi?id=48781
 184
 185         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
 186
 187         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
 188         should paint the default broken image when an image fails to load or decode.  The method also passes the
 189         URL of the failed image.
 190
 191         * WebCoreSupport/WebFrameLoaderClient.h:
 192         * WebCoreSupport/WebFrameLoaderClient.mm:
 193         (WebFrameLoaderClient::shouldPaintBrokenImage):
 194         * WebView/WebDelegateImplementationCaching.h:
 195         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
 196         (CallResourceLoadDelegateReturningBoolean):
 197         * WebView/WebResourceLoadDelegatePrivate.h:
 198         * WebView/WebView.mm:
 199         (-[WebView _cacheResourceLoadDelegateImplementations]):
 200
 201 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
 202
 203         Reviewed by Pavel Feldman.
 204
 205         DumpRenderTree should reset frame opener between tests.
 206         https://bugs.webkit.org/show_bug.cgi?id=54874
 207
 208         Added clearOpener method to WebFramePrivate.
 209
 210         * WebView/WebFrame.mm:
 211         (-[WebFrame _clearOpener]):
 212         * WebView/WebFramePrivate.h:
 213
 214 2011-02-25  Mark Rowe  <mrowe@apple.com>
 215
 216         <rdar://problem/8902546> Build fix.
 217
 218         * Misc/QuickDrawCompatibility.h:
 219
 220 2011-02-24  Anders Carlsson  <andersca@apple.com>
 221
 222         Fix clang build.
 223
 224         * WebCoreSupport/WebKeyGenerator.m:
 225         (toWebCertificateParseResult):
 226         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
 227         * WebView/WebTextCompletionController.mm:
 228
 229 2011-02-24  Peter Kasting  <pkasting@google.com>
 230
 231         Reviewed by Eric Seidel.
 232
 233         Drop the "U; " encryption level from the User Agent string.
 234         https://bugs.webkit.org/show_bug.cgi?id=54566
 235
 236         * WebView/WebView.mm:
 237         (+[WebView _standardUserAgentWithApplicationName:]):
 238
 239 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
 240
 241         Unreviewed, rolling out r79570.
 242         http://trac.webkit.org/changeset/79570
 243         https://bugs.webkit.org/show_bug.cgi?id=54874
 244
 245         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
 246         was not updated
 247
 248         * WebView/WebFrame.mm:
 249         * WebView/WebFramePrivate.h:
 250
 251 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
 252
 253         Reviewed by Alexey Proskuryakov.
 254
 255         DumpRenderTree should reset frame opener between tests.
 256         https://bugs.webkit.org/show_bug.cgi?id=54874
 257
 258         Added clearOpener method to WebFramePrivate.
 259
 260         * WebView/WebFrame.mm:
 261         (-[WebFrame _clearOpener]):
 262         * WebView/WebFramePrivate.h:
 263
 264 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 265
 266         Reviewed by Alexey Proskuryakov.
 267
 268         Drop the language tag part from the User Agent string
 269         https://bugs.webkit.org/show_bug.cgi?id=54560
 270
 271         * WebView/WebView.mm:
 272         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
 273         language tag part.
 274
 275 2011-02-22  Brady Eidson  <beidson@apple.com>
 276
 277         Reviewed by Anders Carlsson.
 278
 279         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
 280         API to view and delete Application Cache data by origin.
 281
 282         * WebCoreSupport/WebApplicationCache.mm:
 283         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
 284
 285 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
 286
 287         Reviewed by Kent Tamura.
 288
 289         Rename Position::node() to Position::deprecatedNode()
 290         https://bugs.webkit.org/show_bug.cgi?id=54622
 291
 292         * WebView/WebFrame.mm:
 293         (-[WebFrame _smartDeleteRangeForProposedRange:]):
 294
 295 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
 296
 297         Reviewed by Kent Tamura.
 298
 299         Rename Position::node() to Position::deprecatedNode()
 300         https://bugs.webkit.org/show_bug.cgi?id=54622
 301
 302         Done the rename.
 303
 304         * WebView/WebFrame.mm:
 305         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
 306         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
 307
 308 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
 309
 310         Reviewed by Sam Weinig.
 311
 312         Bug 54786 - Devirtualize JSCell::classInfo()
 313
 314         Instead of making a virtual function call, add a pointer to the ClassInfo
 315         onto Structure.
 316
 317         This removes a virtual function call, and paves the way towards removing all
 318         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
 319         (these should be able to move onto ClassInfo).
 320
 321         Calls to Structure::create must now pass a pointer to the ClassInfo for the
 322         structure. All objects now have a ClassInfo pointer, non-object cell types
 323         still do not.
 324
 325         Changes are most mechanical, involving three steps:
 326             * Remove virtual classInfo() methods.
 327             * Add &s_info parameter to calls to Structure::create.
 328             * Rename ClassInfo static members on classes from 'info' to 's_info',
 329               for consistency.
 330
 331         * Plugins/Hosted/ProxyInstance.mm:
 332         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
 333         (WebKit::ProxyRuntimeMethod::createStructure):
 334         * Plugins/Hosted/ProxyRuntimeObject.h:
 335         (WebKit::ProxyRuntimeObject::createStructure):
 336         * Plugins/Hosted/ProxyRuntimeObject.mm:
 337         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
 338         * WebView/WebView.mm:
 339         (aeDescFromJSValue):
 340
 341 2011-02-19  Brian Ryner  <bryner@chromium.org>
 342
 343         Reviewed by Adam Barth.
 344
 345         Add missing #include of DocumentLoader.h, needed since the transitive
 346         include through Document.h is removed.
 347         https://bugs.webkit.org/show_bug.cgi?id=50489
 348
 349         * WebView/WebFrame.mm:
 350
 351 2011-02-19  Charlie Reis  <creis@chromium.org>
 352
 353         Reviewed by Mihai Parparita.
 354
 355         Ensure loading has stopped in HistoryController::goToItem
 356         https://bugs.webkit.org/show_bug.cgi?id=54517
 357
 358         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
 359
 360         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
 361
 362         * WebCoreSupport/WebFrameLoaderClient.mm:
 363         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
 364         * WebCoreSupport/WebFrameLoaderClient.h:
 365
 366 2011-02-16  David Hyatt  <hyatt@apple.com>
 367
 368         Reviewed by Dan Bernstein.
 369
 370         https://bugs.webkit.org/show_bug.cgi?id=54244
 371
 372         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
 373         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
 374
 375         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
 376         been changed as well.
 377
 378         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
 379
 380         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
 381
 382         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
 383         still have a precise floating point position.
 384
 385         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
 386         be rounding justification spacing in their font code.
 387
 388         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
 389
 390         * Misc/WebKitNSStringExtras.mm:
 391         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
 392         (-[NSString _web_widthWithFont:]):
 393
 394 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
 395
 396         Reviewed by Adam Roben.
 397
 398         HTML5 <details> and <summary>: localized text
 399         https://bugs.webkit.org/show_bug.cgi?id=54260
 400
 401         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
 402         provide the default label to be used by a <details> tag that has no <summary> child.
 403
 404         * WebCoreSupport/WebPlatformStrategies.h:
 405         * WebCoreSupport/WebPlatformStrategies.mm:
 406         (WebPlatformStrategies::defaultDetailsSummaryText):
 407
 408 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
 409
 410         Reviewed by Simon Fraser.
 411
 412         Allow acceleratesDrawing for WebKit2
 413         https://bugs.webkit.org/show_bug.cgi?id=54511
 414
 415         Plumb through preference for accelerated drawing.
 416
 417         * WebView/WebPreferenceKeysPrivate.h:
 418         * WebView/WebPreferences.mm:
 419         (+[WebPreferences initialize]):
 420         (-[WebPreferences acceleratedDrawingEnabled]):
 421         (-[WebPreferences setAcceleratedDrawingEnabled:]):
 422         * WebView/WebPreferencesPrivate.h:
 423
 424 2011-02-15  David Kilzer  <ddkilzer@apple.com>
 425
 426         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
 427
 428         Reviewed by Darin Adler.
 429
 430         * WebView/WebDynamicScrollBarsView.h:
 431         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
 432         declaration.
 433         * WebView/WebDynamicScrollBarsView.mm:
 434         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
 435         implementation into correct category.
 436         * WebView/WebDynamicScrollBarsViewInternal.h:
 437         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
 438         declaration.
 439         * WebView/WebHTMLView.mm: Included
 440         WebDynamicScrollBarsViewInternal.h instead of
 441         WebDynamicScrollBarsView.h.
 442
 443 2011-02-14  Oliver Hunt  <oliver@apple.com>
 444
 445         Reviewed by Gavin Barraclough and Geoff Garen.
 446
 447         Refactor handles and weak pointers to become nicer and more automatic
 448         https://bugs.webkit.org/show_bug.cgi?id=54415
 449
 450         Update to use Global<> instead of ProtectedPtr, and refactored slightly
 451         to get global data to places it's needed for when we're assigning to
 452         Global<>s
 453
 454         * ForwardingHeaders/collector/handles/Global.h: Added.
 455         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
 456         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
 457         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
 458         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
 459         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
 460         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
 461         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
 462         (WebKit::NetscapePluginInstanceProxy::evaluate):
 463         (WebKit::NetscapePluginInstanceProxy::invoke):
 464         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
 465         (WebKit::NetscapePluginInstanceProxy::construct):
 466         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
 467         * WebView/WebScriptDebugger.h:
 468         * WebView/WebScriptDebugger.mm:
 469         (WebScriptDebugger::WebScriptDebugger):
 470
 471 2011-02-15  Jia Pu  <jpu@apple.com>
 472
 473         Reviewed by Darin Adler.
 474
 475         Autocorrection should respect undo.
 476         https://bugs.webkit.org/show_bug.cgi?id=52221
 477         <rdar://problem/8663399>
 478
 479         Please see WebCore/ChangeLog for detailed description.
 480
 481         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
 482
 483         * WebCoreSupport/WebEditorClient.mm:
 484         (WebEditorClient::recordAutocorrectionResponse): Ditto.
 485
 486         * WebView/WebFrame.mm:
 487         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
 488              Adopted new signature of ReplaceSelectionCommand::create().
 489
 490 2011-02-15  David Kilzer  <ddkilzer@apple.com>
 491
 492         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
 493
 494         Reviewed by Darin Adler.
 495
 496         * WebView/WebDynamicScrollBarsView.h:
 497         * WebView/WebDynamicScrollBarsView.mm:
 498         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
 499         -inProgramaticScroll.
 500         * WebView/WebHTMLView.mm:
 501         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
 502
 503 2011-02-15  Kenneth Russell  <kbr@google.com>
 504
 505         Reviewed by Darin Fisher.
 506
 507         Allow controlling minimum DOMTimer interval on a per-page basis
 508         https://bugs.webkit.org/show_bug.cgi?id=54312
 509
 510         Added needed methods to implement LayoutTestController's new
 511         setMinimumTimerInterval method.
 512
 513         * WebView/WebView.mm:
 514         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
 515         (+[WebView _defaultMinimumTimerInterval]):
 516         (-[WebView _setMinimumTimerInterval:]):
 517         * WebView/WebViewPrivate.h:
 518
 519 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
 520
 521         Reviewed by Oliver Hunt.
 522
 523         A little more encapsulation for the heap: Removed CollectorHeapIterator
 524         https://bugs.webkit.org/show_bug.cgi?id=54298
 525
 526         * Misc/WebCoreStatistics.mm:
 527         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
 528         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
 529
 530 2011-02-10  Nate Chapin  <japhet@chromium.org>
 531
 532         Reviewed by Adam Barth.
 533
 534         Update calls to DocumentWriter.
 535         https://bugs.webkit.org/show_bug.cgi?id=50489
 536
 537         * WebView/WebFrame.mm:
 538         (-[WebFrame _canProvideDocumentSource]):
 539
 540 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
 541
 542         Reviewed by Anders Carlsson.
 543
 544         AX: AX needs to stop using WebCoreViewFactory
 545         https://bugs.webkit.org/show_bug.cgi?id=54153
 546
 547         * WebCoreSupport/WebSystemInterface.mm:
 548         (InitWebCoreSystemInterface):
 549
 550 2011-02-10  Peter Varga  <pvarga@webkit.org>
 551
 552         Reviewed by Csaba Osztrogonác.
 553
 554         Remove PCRE source from trunk
 555         https://bugs.webkit.org/show_bug.cgi?id=54188
 556
 557         * ForwardingHeaders/pcre/pcre.h: Removed.
 558
 559 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
 560
 561         Reviewed by Yury Semikhatsky.
 562
 563         Web Inspector: follow up on InspectorAgent split -
 564         removing unnecessary methods from InspectorController.
 565         https://bugs.webkit.org/show_bug.cgi?id=54093
 566
 567         * WebInspector/WebInspector.mm:
 568         (-[WebInspector showConsole:]):
 569         (-[WebInspector stopProfilingJavaScript:]):
 570
 571 2011-02-08  Dan Bernstein  <mitz@apple.com>
 572
 573         Reviewed by Jon Honeycutt and Maciej Stachowiak.
 574
 575         <rdar://problem/8959420> Find in Mail no longer cycles around
 576
 577         * WebView/WebHTMLView.mm:
 578         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
 579         the wrap option according to the flag.
 580
 581 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
 582
 583         Unreviewed, rolling out r77980.
 584         http://trac.webkit.org/changeset/77980
 585         https://bugs.webkit.org/show_bug.cgi?id=54043
 586
 587         "Crashes on Windows and Linux..." (Requested by leviw on
 588         #webkit).
 589
 590         * WebView/WebFrame.mm:
 591         (-[WebFrame _caretRectAtNode:offset:affinity:]):
 592         * WebView/WebFrameInternal.h:
 593         * WebView/WebTextCompletionController.mm:
 594         (-[WebTextCompletionController doCompletion]):
 595
 596 2011-02-08  Levi Weintraub  <leviw@chromium.org>
 597
 598         Reviewed by Ryosuke Niwa.
 599
 600         Stop instantiating legacy editing Positions in VisiblePosition
 601         https://bugs.webkit.org/show_bug.cgi?id=52919
 602
 603         Changing usage of legacy VisiblePosition constructor. Since we were dealing
 604         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
 605
 606         * WebView/WebFrame.mm:
 607         (-[WebFrame _caretRectAtPosition:affinity:]):
 608         * WebView/WebFrameInternal.h:
 609         * WebView/WebTextCompletionController.mm:
 610         (-[WebTextCompletionController doCompletion]):
 611
 612 2011-02-08  Adam Barth  <abarth@webkit.org>
 613
 614         Reviewed by Eric Seidel.
 615
 616         Remove orphan code from old parser
 617         https://bugs.webkit.org/show_bug.cgi?id=53984
 618
 619         * WebCoreSupport/WebChromeClient.h:
 620
 621 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
 622
 623         Reviewed by Yury Semikhatsky.
 624
 625         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
 626
 627         https://bugs.webkit.org/show_bug.cgi?id=53169
 628
 629         Minor change enforced by major changes in WebCore/inspector/InspectorController.
 630
 631         * WebInspector/WebInspector.mm:
 632         (-[WebInspector isTimelineProfilingEnabled]):
 633
 634 2011-02-07  Enrica Casucci  <enrica@apple.com>
 635
 636         Reviewed Adam Roben and Darin Adler.
 637
 638         WebKit2: drag and drop support on Windows.
 639         https://bugs.webkit.org/show_bug.cgi?id=52775
 640
 641         Removed createDragImageForLink from DragClient.
 642
 643         * WebCoreSupport/WebDragClient.h:
 644         * WebCoreSupport/WebDragClient.mm:
 645         (WebDragClient::startDrag):
 646
 647 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
 648
 649         Reviewed by Pavel Feldman.
 650
 651         Web Inspector: remove settings related methods from InspectorClient
 652         https://bugs.webkit.org/show_bug.cgi?id=53686
 653
 654         * WebCoreSupport/WebInspectorClient.h:
 655         * WebCoreSupport/WebInspectorClient.mm:
 656         (WebInspectorClient::openInspectorFrontend):
 657         (WebInspectorFrontendClient::WebInspectorFrontendClient):
 658
 659 2011-02-03  James Kozianski  <koz@chromium.org>
 660
 661         Reviewed by Dimitri Glazkov.
 662
 663         Add navigator.registerProtocolHandler behind a flag.
 664         https://bugs.webkit.org/show_bug.cgi?id=52609
 665
 666         * Configurations/FeatureDefines.xcconfig:
 667
 668 2011-02-03  Adam Langley  <agl@chromium.org>
 669
 670         Reviewed by Adam Barth.
 671
 672         Plumb mixed script URL to FrameLoaderClient
 673         https://bugs.webkit.org/show_bug.cgi?id=52384
 674
 675         Regressions covered by http/tests/security/mixedContent/*
 676
 677         * WebCoreSupport/WebFrameLoaderClient.h:
 678         * WebCoreSupport/WebFrameLoaderClient.mm:
 679         (WebFrameLoaderClient::didRunInsecureContent):
 680
 681 2011-02-03  Beth Dakin  <bdakin@apple.com>
 682
 683         Reviewed by Sam Weinig.
 684
 685         Fix for <rdar://problem/8944544> Ability to animate track
 686         for WKPainter scrollers
 687
 688         * WebCoreSupport/WebSystemInterface.mm:
 689         (InitWebCoreSystemInterface):
 690
 691 2011-02-02  Mark Rowe  <mrowe@apple.com>
 692
 693         Reviewed by Beth Dakin.
 694
 695         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
 696
 697         * WebCoreSupport/WebSystemInterface.mm:
 698         (InitWebCoreSystemInterface): Add some missing initializers.
 699
 700 2011-02-02  Steve Lacey  <sjl@chromium.org>
 701
 702         Reviewed by Eric Carlson.
 703
 704         Implement basic media statistics on media elements.
 705         https://bugs.webkit.org/show_bug.cgi?id=53322
 706
 707         * Configurations/FeatureDefines.xcconfig:
 708
 709 2011-02-01  Sam Weinig  <sam@webkit.org>
 710
 711         Reviewed by Beth Dakin.
 712
 713         Part 2 for <rdar://problem/8492788>
 714         Adopt WKScrollbarPainterController
 715
 716         Use header detection to define scrollbar painting controller #define.
 717
 718         * WebCoreSupport/WebSystemInterface.mm:
 719         (InitWebCoreSystemInterface):
 720
 721 2011-02-01  David Hyatt  <hyatt@apple.com>
 722
 723         Reviewed by Oliver Hunt.
 724
 725         https://bugs.webkit.org/show_bug.cgi?id=53520
 726
 727         Remove the physical terminology from IntRect and FloatRect.
 728
 729         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
 730         we need to update our terminology to be more accurate.
 731
 732         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
 733         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
 734         even for flipped rectangles.
 735
 736         * WebView/WebHTMLView.mm:
 737         (setNeedsDisplayInRect):
 738
 739 2011-02-01  Beth Dakin  <bdakin@apple.com>
 740
 741         Reviewed by Sam Weinig.
 742
 743         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
 744
 745         * WebCoreSupport/WebSystemInterface.mm:
 746         (InitWebCoreSystemInterface):
 747
 748 2011-02-01  Dave Hyatt  <hyatt@apple.com>
 749
 750         Reviewed by Darin Adler.
 751
 752         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
 753         with vertical text.
 754
 755         Change printing functions to check writing-mode and properly swap width and height
 756         as needed.
 757
 758         * WebView/WebDynamicScrollBarsView.mm:
 759         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
 760         * WebView/WebFrame.mm:
 761         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
 762         * WebView/WebFrameInternal.h:
 763         * WebView/WebHTMLView.mm:
 764         (-[WebHTMLView _web_setPrintingModeRecursive]):
 765         (-[WebHTMLView _web_clearPrintingModeRecursive]):
 766         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
 767         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
 768         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
 769         (-[WebHTMLView _endPrintMode]):
 770         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
 771         (-[WebHTMLView _endScreenPaginationMode]):
 772         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
 773         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
 774         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
 775         (-[WebHTMLView _scaleFactorForPrintOperation:]):
 776         (-[WebHTMLView setPageWidthForPrinting:]):
 777         (-[WebHTMLView knowsPageRange:]):
 778
 779 2011-01-31  Oliver Hunt  <oliver@apple.com>
 780
 781         Convert markstack to a slot visitor API
 782         https://bugs.webkit.org/show_bug.cgi?id=53219
 783
 784         rolling r77098, r77099, r77100, r77109, and
 785         r77111 back in, along with a few more Qt fix attempts.
 786
 787         * WebView/WebScriptDebugDelegate.mm:
 788         (-[WebScriptCallFrame scopeChain]):
 789
 790 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
 791
 792         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
 793         r77111.
 794         http://trac.webkit.org/changeset/77098
 795         http://trac.webkit.org/changeset/77099
 796         http://trac.webkit.org/changeset/77100
 797         http://trac.webkit.org/changeset/77109
 798         http://trac.webkit.org/changeset/77111
 799         https://bugs.webkit.org/show_bug.cgi?id=53219
 800
 801         Qt build is broken
 802
 803         * WebView/WebScriptDebugDelegate.mm:
 804         (-[WebScriptCallFrame scopeChain]):
 805
 806 2011-01-30  Oliver Hunt  <oliver@apple.com>
 807
 808         Convert markstack to a slot visitor API
 809         https://bugs.webkit.org/show_bug.cgi?id=53219
 810
 811         rolling r77006 and r77020 back in.
 812
 813         * WebView/WebScriptDebugDelegate.mm:
 814         (-[WebScriptCallFrame scopeChain]):
 815
 816 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
 817
 818         Reviewed by Maciej Stachowiak.
 819
 820         Some more Heap cleanup.
 821         https://bugs.webkit.org/show_bug.cgi?id=53357
 822
 823         Updated for JavaScriptCore changes.
 824
 825         * Misc/WebCoreStatistics.mm:
 826         (+[WebCoreStatistics memoryStatistics]):
 827
 828 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
 829
 830         Unreviewed, rolling out r77006 and r77020.
 831         http://trac.webkit.org/changeset/77006
 832         http://trac.webkit.org/changeset/77020
 833         https://bugs.webkit.org/show_bug.cgi?id=53360
 834
 835         "Broke Windows tests" (Requested by rniwa on #webkit).
 836
 837         * WebView/WebScriptDebugDelegate.mm:
 838         (-[WebScriptCallFrame scopeChain]):
 839
 840 2011-01-27  Oliver Hunt  <oliver@apple.com>
 841
 842         Reviewed by Geoffrey Garen.
 843
 844         Convert markstack to a slot visitor API
 845         https://bugs.webkit.org/show_bug.cgi?id=53219
 846
 847         Update to new marking api
 848
 849         * WebView/WebScriptDebugDelegate.mm:
 850         (-[WebScriptCallFrame scopeChain]):
 851
 852 2011-01-28  Dan Bernstein  <mitz@apple.com>
 853
 854         Reviewed by Sam Weinig.
 855
 856         <select> can't display right-to-left (rtl) languages
 857         https://bugs.webkit.org/show_bug.cgi?id=19785
 858
 859         * WebCoreSupport/WebChromeClient.h:
 860         * WebCoreSupport/WebChromeClient.mm:
 861         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
 862         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
 863
 864 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 865
 866         Unreviewed, rolling out r76891.
 867         http://trac.webkit.org/changeset/76891
 868         https://bugs.webkit.org/show_bug.cgi?id=53280
 869
 870         Makes every layout test crash (Requested by othermaciej on
 871         #webkit).
 872
 873         * Misc/WebIconDatabase.mm:
 874         (-[ThreadEnabler threadEnablingSelector:]):
 875         (importToWebCoreFormat):
 876
 877 2011-01-27  Nate Chapin  <japhet@chromium.org>
 878
 879         Reviewed by Adam Barth.
 880
 881         Use Document::url() instead of FrameLoader::url().
 882         https://bugs.webkit.org/show_bug.cgi?id=41165
 883
 884         * WebView/WebView.mm:
 885         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
 886
 887 2011-01-27  Dan Bernstein  <mitz@apple.com>
 888
 889         Rubber-stamped by Anders Carlsson.
 890
 891         Reverted an accidental change in r76561.
 892
 893         * WebView/WebHTMLView.mm:
 894
 895 2011-01-26  David Kilzer  <ddkilzer@apple.com>
 896
 897         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
 898         <rdar://problem/8821760>
 899
 900         Reviewed by Antti Koivisto.
 901
 902         * WebCoreSupport/WebSystemInterface.mm:
 903         (InitWebCoreSystemInterface): Added initialization for
 904         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
 905
 906 2011-01-26  Beth Dakin  <bdakin@apple.com>
 907
 908         Reviewed by Darin Adler.
 909
 910         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
 911         when using WKScrollbars.
 912
 913         * WebCoreSupport/WebSystemInterface.mm:
 914         (InitWebCoreSystemInterface):
 915
 916 2011-01-25  Darin Adler  <darin@apple.com>
 917
 918         Reviewed by Anders Carlsson.
 919
 920         WebKit is using CSBackupSetItemExcluded incorrectly
 921         https://bugs.webkit.org/show_bug.cgi?id=53095
 922         rdar://problem/8790540
 923
 924         * Misc/WebIconDatabase.mm:
 925         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
 926         It was incorrect, and this responsibility has been moved to WebCore.
 927
 928 2011-01-24  Chris Marrin  <cmarrin@apple.com>
 929
 930         Reviewed by Eric Seidel.
 931
 932         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
 933         https://bugs.webkit.org/show_bug.cgi?id=53041
 934
 935         * Configurations/FeatureDefines.xcconfig:
 936
 937 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
 938
 939         Reviewed by Pavel Feldman.
 940
 941         Web Inspector: remove "attached" state related methods from InspectorAgent
 942         https://bugs.webkit.org/show_bug.cgi?id=53086
 943
 944         * WebCoreSupport/WebInspectorClient.h:
 945         * WebCoreSupport/WebInspectorClient.mm:
 946         (-[WebInspectorWindowController showWindow:]):
 947         (-[WebInspectorWindowController attach]):
 948         (-[WebInspectorWindowController detach]):
 949
 950 2011-01-23  Dan Bernstein  <mitz@apple.com>
 951
 952         Reviewed by John Sullivan.
 953
 954         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
 955
 956         * WebCoreSupport/WebChromeClient.mm:
 957         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
 958
 959 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
 960
 961         Reviewed by Darin Adler.
 962
 963         https://bugs.webkit.org/show_bug.cgi?id=52473
 964         Auto-scaling to avoid orphans is broken, remove dysfunctional code
 965
 966         * WebView/WebHTMLView.mm:
 967         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
 968         (-[WebHTMLView _scaleFactorForPrintOperation:]):
 969         (-[WebHTMLView knowsPageRange:]):
 970
 971 2011-01-21  Mark Rowe  <mrowe@apple.com>
 972
 973         Rubber-stamped by Jon Honeycutt.
 974
 975         Fix the build when using Clang by removing some unused variables.
 976
 977         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
 978         (-[WebHostedNetscapePluginView updateAndSetWindow]):
 979         * WebView/WebFullScreenController.mm:
 980         (-[WebFullScreenController enterFullscreen:]):
 981         (-[WebFullScreenController exitFullscreen]):
 982
 983 2011-01-21  Chris Rogers  <crogers@google.com>
 984
 985         Reviewed by Darin Fisher.
 986
 987         Add run-time enable support for the web audio API
 988         https://bugs.webkit.org/show_bug.cgi?id=52741
 989
 990         * WebView/WebPreferenceKeysPrivate.h:
 991         * WebView/WebPreferences.mm:
 992         (-[WebPreferences webAudioEnabled]):
 993         (-[WebPreferences setWebAudioEnabled:]):
 994         * WebView/WebPreferencesPrivate.h:
 995         * WebView/WebView.mm:
 996         (-[WebView _preferencesChangedNotification:]):
 997
 998 2011-01-20  John Sullivan  <sullivan@apple.com>
 999
1000         Reviewed by Mark Rowe.
1001
1002         Shift-tab doesn't cycle through fields in http authentication panel
1003         https://bugs.webkit.org/show_bug.cgi?id=52850
1004
1005         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1006         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1007         Re-wired the key loop so that there aren't two views with the same nextKeyView.
1008
1009 2011-01-20  Beth Dakin  <bdakin@apple.com>
1010
1011         Reviewed by Geoffrey Garen.
1012
1013         Fix for <rdar://problem/8890255>
1014
1015         Allow WebKitSystemInterface to draw scrollbars
1016         when appropriate.
1017         * WebCoreSupport/WebSystemInterface.mm:
1018         (InitWebCoreSystemInterface):
1019
1020 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
1021
1022         Reviewed by Sam Weinig.
1023
1024         GraphicsLayers in subframes can get sync'd multiple times
1025         https://bugs.webkit.org/show_bug.cgi?id=52489
1026
1027         * WebView/WebView.mm:
1028         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
1029         was renamed to syncCompositingStateIncludingSubframes().
1030
1031 2011-01-19  Darin Adler  <darin@apple.com>
1032
1033         Reviewed by Sam Weinig.
1034
1035         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
1036         https://bugs.webkit.org/show_bug.cgi?id=52104
1037         rdar://problem/8704226
1038
1039         * WebView/WebDelegateImplementationCaching.h:
1040         Fix type of second integer in CallScriptDebugDelegate function overload
1041         to be int to match the actual Objective-C method. Added a new overload
1042         that includes a BOOL in the right place. Added a boolean named
1043         exceptionWasRaisedExpectsHasHandlerFlag.
1044
1045         * WebView/WebDelegateImplementationCaching.mm:
1046         (CallDelegate): Added overloads as above.
1047         (CallScriptDebugDelegate): Ditto.
1048
1049         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
1050         boolean argument. Marked the old method informally deprecated.
1051
1052         * WebView/WebScriptDebugger.mm:
1053         (WebScriptDebugger::exception): Added code to call with or without the
1054         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
1055
1056         * WebView/WebView.mm:
1057         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
1058         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
1059         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
1060
1061 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
1062
1063         Reviewed by Mihai Parparita.
1064
1065         Perform some forward declaration
1066         https://bugs.webkit.org/show_bug.cgi?id=52522
1067
1068         * Misc/WebKitNSStringExtras.mm:
1069
1070 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
1071
1072         Reviewed by Yury Semikhatsky.
1073
1074         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
1075         https://bugs.webkit.org/show_bug.cgi?id=52721
1076
1077         * WebView/WebScriptDebugger.h:
1078         * WebView/WebScriptDebugger.mm:
1079         (toNSString):
1080         (WebScriptDebugger::sourceParsed):
1081
1082 2011-01-19  Levi Weintraub  <leviw@google.com>
1083
1084         Reviewed by Ryosuke Niwa.
1085
1086         Updating to use Position::parentAnchoredEquivalent instead of
1087         the old htmlediting rangeCompliantEquivalent.
1088
1089         remove rangeCompliantEquivalent and replace it with Position methods
1090         https://bugs.webkit.org/show_bug.cgi?id=25057
1091
1092         * WebView/WebFrame.mm:
1093         (-[WebFrame _smartDeleteRangeForProposedRange:]):
1094
1095 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
1096
1097         Reviewed by Darin Adler.
1098
1099         REGRESSION: A problem with Voiceover and finding links
1100         https://bugs.webkit.org/show_bug.cgi?id=52324
1101
1102         * WebView/WebDynamicScrollBarsView.mm:
1103         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1104
1105 2011-01-17  David Kilzer  <ddkilzer@apple.com>
1106
1107         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
1108
1109         Reviewed by Dan Bernstein.
1110
1111         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
1112         DOMDocumentPrivate.h to the PrivateHeaders directory.
1113
1114 2011-01-17  Enrica Casucci  <enrica@apple.com>
1115
1116         Reviewed by Alexey Proskuryakov.
1117
1118         Drag and drop support: refactoring of image from link and image from selection
1119         https://bugs.webkit.org/show_bug.cgi?id=52496
1120
1121         This work cleans up the Mac code and makes it more similar to the Windows implementation,
1122         avoiding the use of an NSView when the FrameView can be used.
1123         The refactoring is a necessary step towards the complete support of drag and drop
1124         in WebKit2.
1125
1126         * WebCoreSupport/WebDragClient.mm:
1127         (WebDragClient::createDragImageForLink): Added.
1128         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
1129         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
1130
1131 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
1132
1133         Reviewed by Yury Semikhatsky.
1134
1135         Web Inspector: simplify debugger enabling routine.
1136         https://bugs.webkit.org/show_bug.cgi?id=52472
1137
1138         * WebInspector/WebInspector.mm:
1139         (-[WebInspector startDebuggingJavaScript:]):
1140
1141 2011-01-16  Dan Bernstein  <mitz@apple.com>
1142
1143         Reviewed by Simon Fraser.
1144
1145         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
1146         https://bugs.webkit.org/show_bug.cgi?id=52550
1147
1148         * Plugins/WebNetscapePluginView.mm:
1149         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
1150         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
1151
1152 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
1153
1154         Reviewed by Dan Bernstein.
1155
1156         Issues with iframes and plugins when the WebView is scaled.
1157         <rdar://problem/6213380>
1158
1159         When _scaleWebView has been called on a WebView, iframes
1160         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
1161         This is caused by AppKit NSViews not playing nicely with the scale
1162         applied through style.
1163
1164         Work around most of these issues by adjusting the bounds size
1165         of widgets to allow iframe contents to paint with the correct scale,
1166         and fix various places in the code where we relied on coordinate
1167         transforms via NSViews (which ignore CSS transforms).
1168
1169         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1170         (-[WebHostedNetscapePluginView updateAndSetWindow]):
1171         * WebView/WebFrameView.mm:
1172         (-[WebFrameView setBoundsSize:]):
1173
1174 2011-01-16  Beth Dakin  <bdakin@apple.com>
1175
1176         Reviewed by Kevin Decker.
1177
1178         Fix for <rdar://problem/8871204>
1179
1180         Don't try to save elasticity state. Just rely on
1181         NSScrollElasticityAutomatic to restore the correct state.
1182         * WebCoreSupport/WebFrameLoaderClient.h:
1183         * WebCoreSupport/WebFrameLoaderClient.mm:
1184         (WebFrameLoaderClient::WebFrameLoaderClient):
1185         (WebFrameLoaderClient::dispatchDidFirstLayout):
1186         (WebFrameLoaderClient::provisionalLoadStarted):
1187
1188 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
1189
1190         Reviewed by Dan Bernstein.
1191
1192         Plugins render incorrectly with transformed ancestors
1193         https://bugs.webkit.org/show_bug.cgi?id=52507
1194
1195         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
1196         in the ancestor chain of a plugin.
1197
1198         So use of this method with calls to -actualVisibleRectInWindow, which
1199         maps rects through the render tree to compute the correct rect,
1200         clipping via windowClipRect() if necessary.
1201
1202         Not testable, because doing so relies on the behavior of some
1203         plugins, which stop rendering if setWindow passes an empty rect.
1204
1205         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1206         (-[WebHostedNetscapePluginView updateAndSetWindow]):
1207         * Plugins/WebBaseNetscapePluginView.h:
1208         * Plugins/WebBaseNetscapePluginView.mm:
1209         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1210         * Plugins/WebNetscapePluginView.mm:
1211         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1212
1213 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
1214
1215         Reviewed by Antti Koivisto.
1216
1217         Rename cache() to memoryCache()
1218         https://bugs.webkit.org/show_bug.cgi?id=52433
1219
1220         * Misc/WebCache.mm:
1221         (+[WebCache statistics]):
1222         (+[WebCache setDisabled:]):
1223         (+[WebCache isDisabled]):
1224         * WebView/WebView.mm:
1225         (+[WebView _setCacheModel:]):
1226
1227 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
1228
1229         Reviewed by Oliver Hunt.
1230
1231         Split out a MarkedSpace strategy object from Heap.
1232         https://bugs.webkit.org/show_bug.cgi?id=52421
1233
1234         * Misc/WebCoreStatistics.mm:
1235         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
1236
1237 2011-01-14  Dan Bernstein  <mitz@apple.com>
1238
1239         Reviewed by Simon Fraser.
1240
1241         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
1242
1243         * WebView/WebHTMLView.mm:
1244         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
1245         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
1246         that the NSView tree doesn’t change from under AppKit as it traverses it.
1247
1248 2011-01-14  Beth Dakin  <bdakin@apple.com>
1249
1250         Reviewed by Mark Rowe.
1251
1252         Fix for <rdar://problem/7793902> Artifacts when scrolling
1253         page in Safari while page is loading
1254
1255         Call setDrawsBackground:YES on the scrollView in
1256         dispatchDidFirstLayout() rather than waiting until
1257         frameLoadCompleted(). Also suspend scrolling elasticity
1258         between provisionalLoadStarted() and dispatchDidFirstLayout()
1259         * WebCoreSupport/WebFrameLoaderClient.h:
1260         * WebCoreSupport/WebFrameLoaderClient.mm:
1261         (WebFrameLoaderClient::WebFrameLoaderClient):
1262         (WebFrameLoaderClient::dispatchDidFirstLayout):
1263         (WebFrameLoaderClient::provisionalLoadStarted):
1264
1265 2011-01-12  Enrica Casucci  <enrica@apple.com>
1266
1267         Reviewed by Darin Adler.
1268
1269         WebKit2: Add support for drag and drop
1270         https://bugs.webkit.org/show_bug.cgi?id=52343
1271         <rdar://problem/7660558>
1272
1273         The DragData class has been extended to provide
1274         additional context from the application (keyboard state, modal windows, etc.)
1275         as well as information of the drag pasteboard being used.
1276         These are the changes to align the behavior for WebKit.
1277
1278         * WebView/WebView.mm:
1279         (-[WebView applicationFlags:]): Added.
1280         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
1281         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
1282         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
1283         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
1284
1285 2011-01-12  Beth Dakin  <bdakin@apple.com>
1286
1287         Reviewed by Anders Carlsson.
1288
1289         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
1290         Expose fixed layout through WebKit SPI
1291         -and corresponding-
1292         <rdar://problem/8844464>
1293
1294         And now with getters!
1295         * WebView/WebView.mm:
1296         (-[WebView _useFixedLayout]):
1297         (-[WebView _fixedLayoutSize]):
1298         * WebView/WebViewPrivate.h:
1299
1300 2011-01-12  Beth Dakin  <bdakin@apple.com>
1301
1302         Reviewed by Anders Carlsson.
1303
1304         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
1305         fixed layout through WebKit SPI
1306         -and corresponding-
1307         <rdar://problem/8844464>
1308
1309         * WebView/WebView.mm:
1310         (-[WebView _setUseFixedLayout:]):
1311         (-[WebView _setFixedLayoutSize:]):
1312         * WebView/WebViewPrivate.h:
1313
1314 2011-01-07  Enrica Casucci  <enrica@apple.com>
1315
1316         Reviewed by Alexey Proskuryakov.
1317
1318         Paste and drag and drop use different code paths to interact with the pasteboard.
1319         https://bugs.webkit.org/show_bug.cgi?id=52093
1320         The change consists in a refactoring of the code to have only one class that
1321         deals with the pasteboard on Mac.
1322
1323         * WebCoreSupport/WebEditorClient.h:
1324         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
1325         exposed by NSURLExtras.
1326         (WebEditorClient::canonicalizeURL):
1327         (WebEditorClient::canonicalizeURLString):
1328         * WebCoreSupport/WebPasteboardHelper.h: Removed.
1329         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
1330         * WebView/WebHTMLView.mm: Removed comment.
1331         * WebView/WebView.mm: The following methods have been changed to use the new DragData
1332         constructor that doesn't use the WebPasteboardHelper reference.
1333         (-[WebView draggingEntered:]):
1334         (-[WebView draggingUpdated:]):
1335         (-[WebView draggingExited:]):
1336         (-[WebView performDragOperation:]):
1337
1338 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         Forward declare some headers where possible
1343         https://bugs.webkit.org/show_bug.cgi?id=52133
1344
1345         * WebView/WebFrame.mm:
1346
1347 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
1348
1349         Reviewed by Darin Fisher.
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=41441
1352         createWindow method should only do window-creating without URL navigation
1353
1354         * WebCoreSupport/WebChromeClient.mm:
1355         (WebChromeClient::createWindow):
1356
1357 2011-01-08  Dan Bernstein  <mitz@apple.com>
1358
1359         Try to fix the Leopard build.
1360
1361         * WebView/WebFullScreenController.mm:
1362
1363 2011-01-07  Jer Noble  <jer.noble@apple.com>
1364
1365         Yet another Leopard build fix: NSRect and CGRect are not inter-
1366         changable in 32-bit.
1367
1368         * WebView/WebFullScreenController.mm:
1369         (-[WebFullScreenController exitFullscreen]):
1370
1371 2011-01-07  Jer Noble  <jer.noble@apple.com>
1372
1373         Fix the Leopard build: Replace CoreAnimation SL-only functions
1374         with Leopard equivalents.
1375
1376         * WebView/WebFullScreenController.mm:
1377         (+[CATransaction setDisableActions:]):
1378         (+[CATransaction setAnimationDuration:]):
1379         (-[WebFullScreenController _animationDuration]):
1380         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1381
1382 2010-12-21  Jer Noble  <jer.noble@apple.com>
1383
1384         Reviewed by Simon Fraser.
1385
1386         Implement WebKit Full Screen support.
1387         https://bugs.webkit.org/show_bug.cgi?id=49481
1388         rdar://problem/8247444
1389
1390         Support the new fullscreen Chrome client requests.  WebView will pass
1391         through these requests to a WebFullscreenController.
1392
1393         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
1394         * WebView/WebView.mm:
1395         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
1396         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
1397         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
1398         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
1399         * WebView/WebViewData.h: Add ivar newFullscreenController.
1400
1401 2010-12-17  Jer Noble  <jer@kokode.apple.com>
1402
1403         Reviewed by Simon Fraser.
1404
1405         Implement WebKit Full Screen support.
1406         https://bugs.webkit.org/show_bug.cgi?id=49481
1407         rdar://problem/8247444
1408
1409         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
1410         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
1411         window, and a custom CAAnimation animates that layer between the initial screen rect of the
1412         full screen element, to its final value. WebFullscreenController will swap the WebView out of
1413         its original window, and into the fullscreen window. The controller will replace the WebView
1414         with a placeholder view, so that if the placeholder moves or resized while the WebView is
1415         absent, the WebView will move back to the correct location when exiting fullscreen.
1416
1417         * WebView/WebFullscreenController.h: Added.
1418         * WebView/WebFullscreenController.mm: Added.
1419         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
1420         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
1421         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
1422         (-[WebFullscreenController applicationDidResignActive:]):
1423         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
1424             the new screen parameters.
1425         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
1426             from its original screen rect into fullscreen.
1427         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
1428             Set up the animation that will take the fullscreen element back into its original screen
1429             rect.
1430         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
1431             whether to disable screensaver and sleep.
1432         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
1433             looking for HTMLVideoElements; returns whether any are found to be playing.
1434         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
1435             and shift keys.
1436         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
1437         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
1438         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
1439         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
1440         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
1441         (-[WebFullscreenWindow backgroundLayer]): Ditto.
1442         (-[WebFullscreenWindow animationView]): Ditto.
1443         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
1444         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
1445
1446 2011-01-07  James Robinson  <jamesr@chromium.org>
1447
1448         Revert "Implement mozilla's animationTime property"
1449         https://bugs.webkit.org/show_bug.cgi?id=51952
1450
1451         This approach isn't quite right.
1452
1453         * WebView/WebHTMLView.mm:
1454         (-[WebHTMLView drawRect:]):
1455         * WebView/WebView.mm:
1456         (layerSyncRunLoopObserverCallBack):
1457
1458 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
1459
1460         Reviewed by Geoff Garen.
1461
1462         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
1463
1464         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
1465         destructor early, in order to release wrappers once we know we no longer intend to use them.
1466         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
1467         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
1468         A sequence of events that triggers the bug would look like this:
1469
1470         (1) Create a DOMWrapperWorld.
1471         (2) Register a timer in the world.
1472         (3) Call unregisterWorld() on the world.
1473         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
1474         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
1475             called forgetWorld() none exists.
1476         (6) Attempt to add a wrapper to a NULL map.
1477
1478         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
1479
1480         * WebView/WebScriptWorld.mm:
1481         (-[WebScriptWorld unregisterWorld]):
1482
1483 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1484
1485         Reviewed by Sam Weinig.
1486
1487         WK2: Support Accessibility
1488         https://bugs.webkit.org/show_bug.cgi?id=51859
1489
1490         Use rootObject() method to get top of AX tree.
1491
1492         * WebCoreSupport/WebFrameLoaderClient.h:
1493         (WebFrameLoaderClient::accessibilityRemoteObject):
1494         * WebView/WebFrame.mm:
1495         (-[WebFrame setAccessibleName:]):
1496         (-[WebFrame accessibilityRoot]):
1497         * WebView/WebFrameInternal.h:
1498         * WebView/WebFramePrivate.h:
1499         * WebView/WebHTMLView.mm:
1500         (-[WebHTMLView accessibilityAttributeValue:]):
1501         (-[WebHTMLView accessibilityFocusedUIElement]):
1502         (-[WebHTMLView accessibilityHitTest:]):
1503         (-[WebHTMLView _accessibilityParentForSubview:]):
1504
1505 2011-01-04  David Kilzer  <ddkilzer@apple.com>
1506
1507         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
1508
1509         Reviewed by Eric Carlson.
1510
1511         This originally broke in r61581.  It is inside an
1512         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
1513         build then.
1514
1515         * WebCoreSupport/WebFrameLoaderClient.mm: Call
1516         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
1517         use WebCore::PluginInfo.name instead of
1518         -[WebBasePluginPackage name].
1519
1520 2011-01-02  Dan Bernstein  <mitz@apple.com>
1521
1522         Rubber-stamped by Simon Fraser.
1523
1524         <rdar://problem/8812159> Update copyright strings
1525
1526         * Info.plist:
1527
1528 2010-12-29  Dan Bernstein  <mitz@apple.com>
1529
1530         Reviewed by Ada Chan.
1531
1532         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
1533         https://bugs.webkit.org/show_bug.cgi?id=51717
1534
1535         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
1536         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
1537
1538         * WebView/WebDocumentInternal.h:
1539         * WebView/WebHTMLView.mm:
1540         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1541         (-[WebHTMLView _findString:options:]):
1542         * WebView/WebView.mm:
1543         (findString):
1544
1545 2010-12-28  Daniel Bates  <dbates@rim.com>
1546
1547         Reviewed by Sam Weinig.
1548
1549         Substitute // MARK: for compiler-specific #pragma mark
1550         https://bugs.webkit.org/show_bug.cgi?id=51657
1551
1552         For consistency, we should substitute "// MARK:" for compiler-
1553         specific "#pragma mark" in the source files for the Mac port.
1554
1555         * History/WebHistory.mm:
1556         * Plugins/WebBaseNetscapePluginView.mm:
1557         * Plugins/WebNetscapePluginView.mm:
1558         * WebCoreSupport/WebInspectorClient.mm:
1559         * WebCoreSupport/WebSecurityOrigin.mm:
1560         * WebView/WebPDFView.mm:
1561         * WebView/WebVideoFullscreenController.mm:
1562         * WebView/WebVideoFullscreenHUDWindowController.mm:
1563
1564 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
1565
1566         Reviewed by Darin Adler.
1567
1568         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
1569         https://bugs.webkit.org/show_bug.cgi?id=38535
1570
1571         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
1572         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
1573         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
1574         call frame from this stack when an exception throws because the saved top frame could be invalid.
1575
1576         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
1577         callEvent and returnEvent.
1578
1579         * WebView/WebScriptDebugger.mm:
1580         (WebScriptDebugger::willExecuteProgram):
1581         (WebScriptDebugger::didExecuteProgram):
1582
1583 2010-12-22  Sam Weinig  <sam@webkit.org>
1584
1585         Reviewed by Darin Adler.
1586
1587         WebKit2 needs to mirror the frame tree in the UIProcess
1588         https://bugs.webkit.org/show_bug.cgi?id=51546
1589
1590         - Add client functions to notify that a frame has been added or
1591           removed from the page cache.
1592
1593         * WebCoreSupport/WebFrameLoaderClient.h:
1594         * WebCoreSupport/WebFrameLoaderClient.mm:
1595         (WebFrameLoaderClient::didSaveToPageCache):
1596         (WebFrameLoaderClient::didRestoreFromPageCache):
1597
1598 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1599
1600         Reviewed by Eric Seidel.
1601
1602         Editor.h doesn't need to include SelectionController.h
1603         https://bugs.webkit.org/show_bug.cgi?id=51441
1604
1605         Renamed SelectionController::EDirection to SelectionDirection.
1606
1607         * WebView/WebFrame.mm:
1608         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
1609         Takes SelectionDirection instead of SelectionController::EDirection.
1610         * WebView/WebFrameInternal.h:
1611         * WebView/WebTextCompletionController.mm:
1612         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
1613
1614 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
1615
1616         Reviewed by Darin Adler.
1617
1618         Cache snapshots of plug-ins before painting, to avoid script running during painting
1619         https://bugs.webkit.org/show_bug.cgi?id=51493
1620
1621         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
1622         or when printing), plug-ins which otherwise use the CA rendering model
1623         are sent a paint event. Some plug-ins may run script while handling this event,
1624         or out of process plug-ins may process queued requests at this time. Running
1625         script while inside layout or painting can have bad consequences, because it
1626         can result in arbitrary changes to the render tree.
1627
1628         This patch avoids sending plug-ins paint events inside of painting. Instead,
1629         we ask the plug-ins to cache a snapshot before we paint, and then the software
1630         paint simply draws that snapshot.
1631
1632         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1633         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
1634         draw it. Also only send the snapshot message to the plugin proxy if we
1635         know we're snapshotting, since even if creating the snapshot image failed,
1636         we still don't want to call to the plug-in.
1637
1638         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
1639         * Plugins/WebBaseNetscapePluginView.mm:
1640         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
1641         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
1642
1643         * Plugins/WebNetscapePluginView.mm:
1644         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
1645         * WebCoreSupport/WebFrameLoaderClient.mm:
1646         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
1647         to cache and clear the snapshots.
1648
1649 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
1650
1651         Reviewed by Darin Adler.
1652
1653         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
1654         https://bugs.webkit.org/show_bug.cgi?id=51431
1655         <rdar://problem/8791757>
1656
1657         * Plugins/WebBasePluginPackage.mm:
1658         (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
1659         it doesn't underflow.
1660
1661 2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
1662
1663         Reviewed by Cameron Zwarich.
1664
1665         REGRESSION(r74172): 125 java tests fail on Mac
1666         https://bugs.webkit.org/show_bug.cgi?id=51214
1667
1668         The regression was caused by an incorrectly adding sizeof(struct fat_header)
1669         to a pointer for uint32_t as supposed to uint8_t.
1670
1671         Fixed the bug by explicitly casting it to uint8_t* before the addition.
1672
1673         * Plugins/WebBasePluginPackage.mm:
1674         (-[WebBasePluginPackage isNativeLibraryData:]):
1675
1676 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
1677
1678         Reviewed by Darin Adler.
1679
1680         Clang -Wcast-align gives an error in WebBasePluginPackage.mm
1681         https://bugs.webkit.org/show_bug.cgi?id=51144
1682
1683         Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
1684         we were calling it on a byte array 32 bits at a time. While this is okay in practice,
1685         since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
1686         inline storage is at the beginning of the Vector, it is still better to fix this
1687         and silence the warning.
1688
1689         * Plugins/WebBasePluginPackage.mm:
1690         (swapIntsInHeader):
1691         (-[WebBasePluginPackage isNativeLibraryData:]):
1692
1693 2010-12-14  Mark Rowe  <mrowe@apple.com>
1694
1695         Reviewed by Sam Weinig.
1696
1697         <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
1698
1699         * History/WebHistoryItem.mm:
1700         (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
1701         always including the target in the output.
1702
1703 2010-12-13  Alexey Proskuryakov  <ap@apple.com>
1704
1705         Reviewed by Adam Barth.
1706
1707         https://bugs.webkit.org/show_bug.cgi?id=50953
1708         DNS Prefetch should be an opt-in feature
1709
1710         * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
1711
1712 2010-12-13  Mike Thole  <mthole@apple.com>
1713
1714         Rubber-stamped by John Sullivan.
1715
1716         https://bugs.webkit.org/show_bug.cgi?id=50956
1717         WebAuthenticationPanel.nib appears to have a cut-off sentence
1718
1719         Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
1720         The contents of this text field are updated dynamically before the sheet is displayed.
1721
1722         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1723         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1724
1725 2010-12-13  Antti Koivisto  <antti@apple.com>
1726
1727         Reviewed by Alexey Proskuryakov.
1728
1729         https://bugs.webkit.org/show_bug.cgi?id=50758
1730         <rdar://problem/8722094>
1731         Defer loading print stylesheets
1732
1733         Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
1734
1735         * WebView/WebView.mm:
1736         (+[WebView _setLoadResourcesSerially:forHost:]):
1737         * WebView/WebViewPrivate.h:
1738
1739 2010-12-09  Matthew Delaney  <mdelaney@apple.com>
1740
1741         Reviewed by Simon Fraser.
1742
1743         Adopt new CG API for canvas
1744         https://bugs.webkit.org/show_bug.cgi?id=50591
1745
1746         * WebCoreSupport/WebSystemInterface.mm:
1747
1748 2010-10-28  MORITA Hajime  <morrita@google.com>
1749
1750         Reviewed by Ojan Vafai.
1751
1752         spellcheck does not check pasted text
1753         https://bugs.webkit.org/show_bug.cgi?id=40092
1754
1755         Added asynchronous spell checking API to WebEditorClient using
1756         -[NSSpellChecker requestCheckingOfString].
1757         Note that WebEditorSpellCheckResponder is a small class to receive
1758         requested spell-checking result. Note that this feature is
1759         disabled at default.
1760
1761         Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
1762         enable the feature from LayoutTestController.
1763
1764         * WebCoreSupport/WebEditorClient.h:
1765         * WebCoreSupport/WebEditorClient.mm:
1766         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
1767         (-[WebEditorSpellCheckResponder perform]):
1768         (toCoreSpellingResult):
1769         (-[WebEditorSpellCheckResponder WTF::WebCore::]):
1770         (WebEditorClient::requestCheckingOfString):
1771         * WebView/WebPreferenceKeysPrivate.h:
1772         * WebView/WebPreferences.mm:
1773         (+[WebPreferences initialize]):
1774         (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
1775         (-[WebPreferences asynchronousSpellCheckingEnabled]):
1776         * WebView/WebPreferencesPrivate.h:
1777         * WebView/WebView.mm:
1778         (-[WebView _preferencesChangedNotification:]):
1779
1780 2010-12-09  Anders Carlsson  <andersca@apple.com>
1781
1782         Fix a bug uncovered by clang++.
1783
1784         * WebView/WebHTMLView.mm:
1785         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1786
1787 2010-12-09  Anders Carlsson  <andersca@apple.com>
1788
1789         Clang++ build fixes.
1790
1791         Silence a couple of warnings.
1792
1793         * WebView/WebFrame.mm:
1794         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1795         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1796         * WebView/WebTextCompletionController.mm:
1797         (-[WebTextCompletionController filterKeyDown:]):
1798
1799 2010-12-09  David Hyatt  <hyatt@apple.com>
1800
1801         Reviewed by Dan Bernstein.
1802
1803         https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
1804         writing-mode.  This first part of the patch just patches Mac WebKit 1 views.
1805
1806         * WebView/WebFrameView.mm:
1807         (-[WebFrameView _isVerticalDocument]):
1808         (-[WebFrameView _isFlippedDocument]):
1809         (-[WebFrameView _scrollToEndOfDocument]):
1810         (-[WebFrameView _pageInBlockProgressionDirection:]):
1811         (-[WebFrameView scrollPageUp:]):
1812         (-[WebFrameView scrollPageDown:]):
1813
1814 2010-12-08  Andy Estes  <aestes@apple.com>
1815
1816         Reviewed by Darin Adler.
1817
1818         Enable pre-HTML5 parser quirks for Apple Mail.app
1819         https://bugs.webkit.org/show_bug.cgi?id=50727
1820
1821         * WebView/WebView.mm:
1822         (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
1823         application is Mail.app.
1824
1825 2010-12-08  Brian Weinstein  <bweinstein@apple.com>
1826
1827         Reviewed by John Sullivan.
1828
1829         REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
1830         https://bugs.webkit.org/show_bug.cgi?id=50683
1831
1832         If our context menu item already has an action, don't overwrite the action with the context menu
1833         forwarder.
1834
1835         * WebView/WebHTMLView.mm:
1836         (setMenuItemTarget):
1837
1838 2010-12-08  Anders Carlsson  <andersca@apple.com>
1839
1840         Remove an unused variable.
1841
1842         * WebView/WebDynamicScrollBarsView.mm:
1843         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
1844
1845 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
1846
1847         Reviewed by John Sullivan.
1848
1849         Layering Violation in ContextMenu - member variable of type HitTestResult
1850         https://bugs.webkit.org/show_bug.cgi?id=50586
1851
1852         Update users of ContextMenu and ContextMenuController to match where the new functions
1853         are located.
1854
1855         * WebCoreSupport/WebContextMenuClient.mm:
1856         (WebContextMenuClient::getCustomMenuFromDefaultItems):
1857         (WebContextMenuClient::contextMenuItemSelected):
1858         * WebView/WebHTMLView.mm:
1859         (-[WebMenuTarget validateMenuItem:]):
1860
1861 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
1862
1863         Reviewed by John Sullivan.
1864
1865         Part of Layering Violation in ContextMenu
1866         https://bugs.webkit.org/show_bug.cgi?id=50586
1867
1868         Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
1869         was a layering violation. Also, make sure we set the menu item targets for all menu
1870         items before showing them, because the ContextMenu constructor doesn't do that anymore.
1871
1872         * WebView/WebHTMLView.mm:
1873         (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
1874         (-[WebMenuTarget WebCore::]): Ditto.
1875         (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
1876         (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
1877         (-[WebMenuTarget validateMenuItem:]): Ditto.
1878
1879         (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
1880         (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
1881             submenus), and calls setMenuItemTarget on them.
1882         (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
1883             them to the menu.
1884
1885 2010-12-06  Darin Adler  <darin@apple.com>
1886
1887         Reviewed by Sam Weinig.
1888
1889         Pass security origin to make local file decision correctly
1890         https://bugs.webkit.org/show_bug.cgi?id=48603
1891
1892         * WebView/WebPDFView.mm:
1893         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
1894
1895 2010-12-07  Martin Robinson  <mrobinson@igalia.com>
1896
1897         Unreviewed, rolling out r73392.
1898         http://trac.webkit.org/changeset/73392
1899         https://bugs.webkit.org/show_bug.cgi?id=50489
1900
1901         This commit caused crashes on the GTK+ bots
1902
1903         * WebView/WebFrame.mm:
1904         (-[WebFrame _canProvideDocumentSource]):
1905
1906 2010-12-07  Kenichi Ishibashi  <bashi@google.com>
1907
1908         Reviewed by Kent Tamura.
1909
1910         Let HTMLObjectElement be a form associated element
1911         https://bugs.webkit.org/show_bug.cgi?id=48821
1912
1913         Modified to use FormAssociatedElement instead of HTMLFormControlElement.
1914
1915         * WebView/WebHTMLRepresentation.mm:
1916         (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
1917         FormAssociatedElement instead of HTMLFormControlElement.
1918         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1919
1920 2010-12-06  Nate Chapin  <japhet@chromium.org>
1921
1922         Reviewed by Adam Barth.
1923
1924         Update calls to DocumentWriter.
1925         https://bugs.webkit.org/show_bug.cgi?id=50489
1926
1927         * WebView/WebFrame.mm:
1928         (-[WebFrame _canProvideDocumentSource]):
1929
1930 2010-12-06  Chris Marrin  <cmarrin@apple.com>
1931
1932         Reviewed by Simon Fraser.
1933
1934         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
1935         https://bugs.webkit.org/show_bug.cgi?id=49388
1936
1937         Got rid of GraphicsLayer::nativeLayer() call, replacing it with
1938         GraphicsLayer::platformLayer().
1939
1940         * WebCoreSupport/WebChromeClient.mm:
1941         (WebChromeClient::attachRootGraphicsLayer):
1942
1943 2010-12-04  Dan Bernstein  <mitz@apple.com>
1944
1945         Reviewed by Sam Weinig.
1946
1947         WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
1948         https://bugs.webkit.org/show_bug.cgi?id=50530
1949
1950         * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
1951         * WebView/WebHTMLView.mm:
1952         (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
1953         which is passed through to WebCore.
1954         * WebView/WebPDFView.mm:
1955         (isFrameInRange): Added this helper function.
1956         (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
1957         a check if the frame is in the range.
1958         * WebView/WebView.mm:
1959         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
1960         (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
1961         parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
1962         * WebView/WebViewPrivate.h:
1963
1964 2010-12-03  Sam Weinig  <sam@webkit.org>
1965
1966         Reviewed by Maciej Stachowiak.
1967
1968         Enable <a ping> for Mac/Windows/WebKit2 builds
1969         <rdar://problem/8504473>
1970         https://bugs.webkit.org/show_bug.cgi?id=50488
1971
1972         * WebView/WebPreferences.mm:
1973         (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
1974
1975 2010-12-03  Jia Pu  <jpu@apple.com>
1976
1977         Reviewed by Darin Adler.
1978
1979         Need to move all code that applies correction into correction panel callback.
1980         https://bugs.webkit.org/show_bug.cgi?id=50426
1981         <rdar://problem/8720832>
1982
1983         * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
1984
1985         * WebCoreSupport/WebEditorClient.mm:
1986         (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
1987         (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
1988         (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
1989
1990 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1991
1992         Revert r73217 and r73227 because of continued bustage.
1993
1994         * WebCoreSupport/WebChromeClient.mm:
1995         (WebChromeClient::attachRootGraphicsLayer):
1996
1997 2010-12-02  Chris Marrin  <cmarrin@apple.com>
1998
1999         Reviewed by Simon Fraser.
2000
2001         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
2002         https://bugs.webkit.org/show_bug.cgi?id=49388
2003
2004         Got rid of GraphicsLayer::nativeLayer() call, replacing it with
2005         GraphicsLayer::platformLayer().
2006
2007         * WebCoreSupport/WebChromeClient.mm:
2008         (WebChromeClient::attachRootGraphicsLayer):
2009
2010 2010-12-02  Mark Rowe  <mrowe@apple.com>
2011
2012         Reviewed by Beth Dakin.
2013
2014         <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
2015
2016         * Misc/WebNSFileManagerExtras.m:
2017         (setMetaData): Create an autorelease pool for the duration of the thread body.
2018
2019 2010-12-02  John Knottenbelt  <jknotten@chromium.org>
2020
2021         Reviewed by Steve Block.
2022
2023         Move requestGeolocationPermissionForFrame to GeolocationClient
2024         https://bugs.webkit.org/show_bug.cgi?id=50061
2025
2026         This change facilitates client-based geolocation implementation by
2027         bringing together permission control into the geolocation client
2028         interface.
2029
2030         Move method ChromeClient::requestGeolocationPermissionForFrame to
2031         GeolocationClient::requestPermission, and supporting class
2032         WebGeolocationPolicyListener. The moved code is unchanged except
2033         that requestPermission now takes only one argument (Geolocation*)
2034         and the Frame parameter is retrieved from the Geolocation object.
2035
2036         * WebCoreSupport/WebChromeClient.h:
2037         * WebCoreSupport/WebChromeClient.mm:
2038         * WebCoreSupport/WebGeolocationClient.h:
2039         (WebGeolocationClient::cancelPermissionRequest):
2040         * WebCoreSupport/WebGeolocationClient.mm:
2041         (WebGeolocationClient::requestPermission):
2042         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2043         (-[WebGeolocationPolicyListener allow]):
2044         (-[WebGeolocationPolicyListener deny]):
2045
2046 2010-12-02  Joseph Pecoraro  <joepeck@webkit.org>
2047
2048         Reviewed by Eric Carlson.
2049
2050         Style Fixes in WebPluginController
2051         https://bugs.webkit.org/show_bug.cgi?id=50397
2052
2053         * Plugins/WebPluginController.mm:
2054         (-[WebPluginController startAllPlugins]):
2055         (-[WebPluginController stopAllPlugins]):
2056
2057 2010-12-02  John Sullivan  <sullivan@apple.com>
2058
2059         Reviewed by Adam Roben.
2060
2061         Slightly speculative fix for:
2062
2063         <rdar://problem/8712674>
2064         <https://bugs.webkit.org/show_bug.cgi?id=50393>
2065         setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
2066
2067         * Panels/WebAuthenticationPanel.m:
2068         (-[WebAuthenticationPanel setUpForChallenge:]):
2069         If the realm is nil, use @"" instead.
2070
2071 2010-12-01  Jia Pu  <jpu@apple.com>
2072
2073         Reviewed by Darin Adler.
2074
2075         Support multiple correction candidates panel for misspelled word on Mac OS X.
2076         https://bugs.webkit.org/show_bug.cgi?id=50137
2077         <rdar://problem/8568059>
2078
2079         This patch is for supporting multiple correction suggestion panel on Mac OS X.
2080         The behavior and implementation is similar to that of reversion candiate panel.
2081
2082         * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
2083
2084         * WebCoreSupport/WebEditorClient.mm:  Adopted new signatures defined in base class.
2085           Added code to handle new multiple suggestion canidate panel type.
2086         (WebEditorClient::showCorrectionPanel):
2087         (WebEditorClient::getGuessesForWord):
2088
2089 2010-12-01  David Hyatt  <hyatt@apple.com>
2090
2091         Reviewed by Darin Adler.
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=46645
2094
2095         Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
2096         recently added for horizontal RTL documents and applies it to writing modes as well.  Now the
2097         scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
2098
2099         This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
2100         makes them behave the same as the cross-platform code (allowing for cross-platform results to be
2101         landed).
2102
2103         * WebView/WebDynamicScrollBarsView.mm:
2104         (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
2105         (-[WebDynamicScrollBarsView updateScrollers]):
2106         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
2107         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
2108         (-[WebDynamicScrollBarsView scrollOrigin]):
2109         * WebView/WebFrameView.mm:
2110         (-[WebFrameView _scrollToBeginningOfDocument]):
2111         (-[WebFrameView _scrollToEndOfDocument]):
2112
2113 2010-11-29  Dan Bernstein  <mitz@apple.com>
2114
2115         Reviewed by Darin Adler.
2116
2117         WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
2118         https://bugs.webkit.org/show_bug.cgi?id=50038
2119         Based on a patch from Darin Adler.
2120
2121         * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
2122         replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
2123         method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
2124         method. Made WebHTMLView conform to the new protocol.
2125         * WebView/WebHTMLView.mm:
2126         (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
2127         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
2128         -findString:options:.
2129         (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
2130         (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
2131         * WebView/WebPDFView.mm:
2132         (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
2133         * WebView/WebView.mm:
2134         (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
2135         -countMatchesForText:options:highlight:limit:markMatches.
2136         (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
2137         (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
2138         -findString:options:.
2139         (incrementFrame): Changed to use WebFindOptions.
2140         (findString): Added this helper method that performs the search using the best supported
2141         method for the document view.
2142         (-[WebView findString:options:]): Changed -searchFor::::: into this.
2143         (-[WebView canMarkAllTextMatches]):
2144         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
2145         WebFindOptions.
2146         (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
2147         (-[WebView rectsForTextMatches]): Ditto.
2148         * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
2149         of countMatchesForText:.
2150
2151 2010-11-29  Jeremy Moskovich  <jeremy@chromium.org>
2152
2153         Reviewed by David Hyatt.
2154
2155         Right-to-left pages should be scrollable to reveal left overflow.
2156         https://bugs.webkit.org/show_bug.cgi?id=23556
2157
2158         Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
2159         Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
2160         pages with a left overflow.
2161
2162         * WebView/WebDynamicScrollBarsView.h:
2163         * WebView/WebDynamicScrollBarsView.mm:
2164         (-[WebDynamicScrollBarsView inProgramaticScroll]):
2165         (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
2166         (-[WebDynamicScrollBarsView updateScrollers]):
2167         (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
2168         (-[WebDynamicScrollBarsView setScrollOriginX:]):
2169         (-[WebDynamicScrollBarsView scrollOriginX]):
2170         * WebView/WebFrameView.mm:
2171         (-[WebFrameView _scrollToBeginningOfDocument]):
2172         (-[WebFrameView _scrollToEndOfDocument]):
2173         * WebView/WebHTMLView.mm:
2174         (-[WebHTMLView _frameOrBoundsChanged]):
2175
2176 2010-11-22  Ryosuke Niwa  <rniwa@webkit.org>
2177
2178         Reviewed by Tony Chang.
2179
2180         SelectionController::typingStyle() should return EditingStyle*
2181         https://bugs.webkit.org/show_bug.cgi?id=49813
2182
2183         Changed the return value of SelectionController::typingStyle() to EditingStyle*.
2184         Also added SelectionController::copyTypingStyle() to copy the typing style
2185         as an instance of CSSMutableStyleDeclaration.
2186
2187         No tests are added since this is no behavioral change.
2188
2189         * WebView/WebFrame.mm:
2190         (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
2191
2192 2010-11-19  Michael Saboff  <msaboff@apple.com>
2193
2194         Reviewed by Sam Weinig
2195
2196         Remove DOMSVGAnimatedPathData.h from all: target to fix build.
2197
2198         * MigrateHeaders.make:
2199
2200 2010-11-19  Nikolas Zimmermann  <nzimmermann@rim.com>
2201
2202         Reviewed by Dirk Schulze.
2203
2204         Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
2205         https://bugs.webkit.org/show_bug.cgi?id=49580
2206
2207         * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
2208
2209 2010-11-18  Mark Rowe  <mrowe@apple.com>
2210
2211         Rubber-stamped by Adam Roben.
2212
2213         <rdar://problem/8602509&8602717&8602724> Enable compaction support.
2214
2215         * Configurations/WebKit.xcconfig:
2216
2217 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2218
2219         Unreviewed, rolling out r72288.
2220         http://trac.webkit.org/changeset/72288
2221         https://bugs.webkit.org/show_bug.cgi?id=49730
2222
2223         'krit attempted to do that, but revert got stuck' (Requested
2224         by antonm on #webkit).
2225
2226         * WebView/WebRenderLayer.mm:
2227
2228 2010-11-17  Nikolas Zimmermann  <nzimmermann@rim.com>
2229
2230         Reviewed by Dirk Schulze.
2231
2232         Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
2233         https://bugs.webkit.org/show_bug.cgi?id=49580
2234
2235         * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
2236
2237 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2238
2239         Reviewed by Geoff Garen.
2240
2241         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2242
2243         Make a static provider for WebDeviceOrientationProviderMock.  The old code allocated a new WebDeviceOrientationProviderMock for
2244         every WebView, and the WebKit API doesn't support that ownership model.
2245
2246         * WebView/WebDeviceOrientationProviderMock.h:
2247         * WebView/WebDeviceOrientationProviderMock.mm:
2248         (+[WebDeviceOrientationProviderMock shared]):
2249
2250 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2251
2252         Reviewed by Dan Bernstein.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=11004
2255
2256         font-size:0 is ignored.  Remove the minimum font size of 1 in CSSStyleSelector.
2257         Change the pref value for minimum font size from 1 to 0.  Make sure to never use the NSFont's size,
2258         since it doesn't honor a size of 0.  Instead pass the size in to the FontPlatformData(NSFont*) version
2259         of the constructor rather than using [NSFont pointSize].
2260
2261         https://bugs.webkit.org/show_bug.cgi?id=49582
2262
2263         Negative leading is not handled correctly.  There are two bugs here.  The first is that
2264         maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
2265         set them before so that we can allow them to be < 0.
2266
2267         The second issue is that we should understand where fonts will end up relative to
2268         our baseline (excluding line height), and only allow those boxes to impact ascent and
2269         descent if the actual font box (without factoring in line height) is above or below the
2270         root line box baseline.
2271
2272         Added fast/css/negative-leading.html
2273
2274         These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
2275
2276         * Misc/WebKitNSStringExtras.mm:
2277         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2278         (-[NSString _web_widthWithFont:]):
2279         * Misc/WebStringTruncator.mm:
2280         (fontFromNSFont):
2281         * WebView/WebPreferences.mm:
2282         (+[WebPreferences initialize]):
2283
2284 2010-11-16  Anders Carlsson  <andersca@apple.com>
2285
2286         Fix clang++ build.
2287
2288         * WebCoreSupport/WebFrameLoaderClient.mm:
2289
2290 2010-11-14  Kent Tamura  <tkent@chromium.org>
2291
2292         Reviewed by Andreas Kling.
2293
2294         KeyboardEvent::keyIdentifier() should return "const String&"
2295         https://bugs.webkit.org/show_bug.cgi?id=49426
2296
2297         * WebCoreSupport/WebEditorClient.mm:
2298         (selectorForKeyEvent):
2299           Change the type of a variable to have keyIdentifier(); String -> const String&
2300
2301 2010-11-12  John Knottenbelt  <jknotten@chromium.org>
2302
2303         Reviewed by Steve Block.
2304
2305         Rename GeolocationControllerClient to GeolocationClient.
2306         https://bugs.webkit.org/show_bug.cgi?id=49259
2307
2308         * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
2309         (WebGeolocationClient::webView):
2310         (WebGeolocationClient::setEnableHighAccuracy):
2311         * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
2312         (WebGeolocationClient::WebGeolocationClient):
2313         (WebGeolocationClient::geolocationDestroyed):
2314         (WebGeolocationClient::startUpdating):
2315         (WebGeolocationClient::stopUpdating):
2316         (WebGeolocationClient::lastPosition):
2317         * WebKit.order:
2318         * WebView/WebView.mm:
2319         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2320
2321 2010-11-10  Beth Dakin  <bdakin@apple.com>
2322
2323         Reviewed by Simon Fraser.
2324
2325         Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
2326         -[WebView _scaleWebView:] should take and origin and scroll the
2327         document
2328         -and corresponding-
2329         <rdar://problem/8643921>
2330
2331         * WebView/WebView.mm:
2332         (-[WebView _scaleWebView:atOrigin:]):
2333         * WebView/WebViewPrivate.h:
2334
2335 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2336
2337         Reviewed by David Hyatt.
2338
2339         HTML5 Ruby support should be mandatory feature
2340         https://bugs.webkit.org/show_bug.cgi?id=49272
2341
2342         Remove Ruby as optional feature.
2343
2344         * Configurations/FeatureDefines.xcconfig:
2345
2346 2010-11-08  Ned Holbrook  <nholbrook@apple.com>
2347
2348         Reviewed by Adam Barth.
2349
2350         Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
2351         https://bugs.webkit.org/show_bug.cgi?id=48886
2352
2353         * WebCoreSupport/WebSystemInterface.mm:
2354         (InitWebCoreSystemInterface):
2355
2356 2010-11-08  Nate Chapin  <japhet@chromium.org>
2357
2358         Unreviewed, build fix.
2359
2360         Clumsy typo in r71562.
2361
2362         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2363         (WebKit::HostedNetscapePluginStream::start):
2364
2365 2010-11-08  Nate Chapin  <japhet@chromium.org>
2366
2367         Reviewed by Alexey Proskuryakov.
2368
2369         Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
2370
2371         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2372         (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
2373         * Plugins/WebNetscapePluginStream.mm:
2374         (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
2375         * WebView/WebView.mm:
2376         (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
2377
2378 2010-11-08  Anders Carlsson  <andersca@apple.com>
2379
2380         Reviewed by Dan Bernstein.
2381
2382         Plug-in views should not assume that plugins are RenderEmbeddedObjects
2383         https://bugs.webkit.org/show_bug.cgi?id=49196
2384         <rdar://problem/8638467>
2385
2386         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2387         (-[WebHostedNetscapePluginView pluginHostDied]):
2388
2389 2010-11-08  Alexey Proskuryakov  <ap@apple.com>
2390
2391         Reviewed by Darin Adler.
2392
2393         https://bugs.webkit.org/show_bug.cgi?id=48685
2394         Notify UI process about focused frame
2395
2396         Added an empty implementation of the new ChromeClient method.
2397
2398         * WebCoreSupport/WebChromeClient.h:
2399         * WebCoreSupport/WebChromeClient.mm:
2400         (WebChromeClient::focusedFrameChanged):
2401
2402 2010-11-08  Anders Carlsson  <andersca@apple.com>
2403
2404         Build fix.
2405
2406         * MigrateHeaders.make:
2407
2408 2010-11-08  Anders Carlsson  <andersca@apple.com>
2409
2410         Reviewed by Adam Roben.
2411
2412         Remove use of HIGetScaleFactor
2413         https://bugs.webkit.org/show_bug.cgi?id=49186
2414         <rdar://problem/8618410>
2415
2416         Scale factors can vary on a display-by-display basis and it doesn't make sense
2417         to compute scale factor event coordinates like this.
2418
2419         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2420         (getCarbonEvent):
2421
2422 2010-11-08  Simon Fraser  <simon.fraser@apple.com>
2423
2424         Reviewed by Sam Weinig.
2425
2426         Allow applets to participate in accelerated compositing
2427         https://bugs.webkit.org/show_bug.cgi?id=49117
2428         <rdar://problem/8625819>
2429
2430         If Java is being loaded via the Netscape Plugin API, create a
2431         NetscapePluginWidget so that it has an implementation of platformLayer().
2432
2433         Also clean up by using early returns.
2434
2435         * WebCoreSupport/WebFrameLoaderClient.mm:
2436
2437 2010-11-07  Adam Barth  <abarth@webkit.org>
2438
2439         Reviewed by Eric Seidel.
2440
2441         Rename Cache to MemoryCache
2442         https://bugs.webkit.org/show_bug.cgi?id=49159
2443
2444         * Misc/WebCache.mm:
2445         (+[WebCache statistics]):
2446         * WebCoreSupport/WebDeviceOrientationClient.mm:
2447         (WebDeviceOrientationClient::setController):
2448         * WebView/WebView.mm:
2449
2450 2010-11-05  Alexey Proskuryakov  <ap@apple.com>
2451
2452         Reviewed by Darin Adler.
2453
2454         https://bugs.webkit.org/show_bug.cgi?id=49100
2455         ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
2456
2457         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
2458         Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
2459         (see bug comments), and there seems to be no harm in executing this function in that case.
2460
2461 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2462
2463         Reviewed by Simon Fraser.
2464
2465         Move resumeAnimations/suspendAnimations from Frame to AnimationController.
2466         https://bugs.webkit.org/show_bug.cgi?id=49073
2467
2468         * WebView/WebFrame.mm:
2469         (-[WebFrame _suspendAnimations]):
2470         (-[WebFrame _resumeAnimations]):
2471
2472 2010-11-04  Alexey Proskuryakov  <ap@apple.com>
2473
2474         Reviewed by Darin Adler.
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=49008
2477         <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
2478
2479         Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
2480         the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
2481         deleted during wait:
2482         - plugin crashed;
2483         - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
2484         while waiting).
2485
2486         We didn't recognize the latter.
2487
2488         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2489         (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
2490         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2491         (WebKit::NetscapePluginInstanceProxy::waitForReply):
2492         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2493         (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
2494
2495 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2496
2497         Reviewed by Simon Fraser.
2498
2499         Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
2500         https://bugs.webkit.org/show_bug.cgi?id=46945
2501
2502         * WebView/WebFrame.mm:
2503         (-[WebFrame _suspendAnimations]):
2504         (-[WebFrame _resumeAnimations]):
2505
2506 2010-11-04  Jia Pu  <jpu@apple.com>
2507
2508         Reviewed by Dan Bernstein.
2509
2510         reversion bubble in WebViews
2511         https://bugs.webkit.org/show_bug.cgi?id=47630
2512         <rdar://problem/8530960>
2513
2514         This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
2515
2516         * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
2517         * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
2518           change to use new reversion API in AppKit.
2519         (WebEditorClient::WebEditorClient):
2520         (WebEditorClient::~WebEditorClient):
2521         (WebEditorClient::respondToChangedSelection):
2522         (WebEditorClient::showCorrectionPanel):
2523         (WebEditorClient::dismissCorrectionPanel):
2524         (WebEditorClient::isShowingCorrectionPanel):
2525
2526 2010-11-04  Mike Thole  <mthole@apple.com>
2527
2528         Reviewed by Dan Bernstein.
2529
2530         Title for images should use localized numerals
2531         https://bugs.webkit.org/show_bug.cgi?id=49017
2532
2533         * WebCoreSupport/WebPlatformStrategies.mm:
2534         (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
2535
2536 2010-11-02  Daniel Bates  <dbates@rim.com>
2537
2538         Reviewed by Adam Barth.
2539
2540         For unnamed frames, window.name returns a generated name
2541         https://bugs.webkit.org/show_bug.cgi?id=6751
2542
2543         Part 1 of 2.
2544
2545         Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
2546
2547         * WebView/WebFrame.mm:
2548         (-[WebFrame name]):
2549
2550 2010-11-01  Brady Eidson  <beidson@apple.com>
2551
2552         Reviewed by Anders Carlsson.
2553
2554         <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
2555         Context menu support for WebKit 2.
2556
2557         * WebCoreSupport/WebChromeClient.h:
2558         (WebChromeClient::showContextMenu):
2559
2560 2010-10-29  Daniel Bates  <dbates@rim.com>
2561
2562         No review, rolling out 70971.
2563         http://trac.webkit.org/changeset/70971
2564         https://bugs.webkit.org/show_bug.cgi?id=6751
2565
2566         Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
2567         it caused layout test failures on all bots. In particular, the
2568         child count in a generated frame name differs after this patch. We need
2569         to look into this further.
2570
2571         * WebView/WebFrame.mm:
2572         (-[WebFrame name]):
2573
2574 2010-10-28  Antonio Gomes  <agomes@rim.com>
2575
2576         Reviewed by Ojan Vafai.
2577
2578         Needs a "LinuxEditingBehavior", perhaps with a better name
2579         https://bugs.webkit.org/show_bug.cgi?id=36627
2580
2581         Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
2582
2583         * WebView/WebFrame.mm:
2584         (core):
2585         * WebView/WebPreferencesPrivate.h:
2586
2587 2010-10-29  Daniel Bates  <dbates@rim.com>
2588
2589         Reviewed by Adam Barth.
2590
2591         For unnamed frames, window.name returns a generated name
2592         https://bugs.webkit.org/show_bug.cgi?id=6751
2593
2594         Modified Mac-port to use FrameTree::uniqueName().
2595
2596         * WebView/WebFrame.mm:
2597         (-[WebFrame name]):
2598
2599 2010-10-29  Darin Adler  <darin@apple.com>
2600
2601         Reviewed by Sam Weinig.
2602
2603         Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
2604         https://bugs.webkit.org/show_bug.cgi?id=48574
2605
2606         * History/WebBackForwardList.mm:
2607         Use BackForwardListImpl.
2608
2609 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
2610
2611         Rubber-stamped by Sam Weinig.
2612
2613         Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
2614         create views for subframes.
2615
2616         * WebView/WebViewData.h: Double negation is better than a lie.
2617
2618 2010-10-27  Jer Noble  <jer.noble@apple.com>
2619
2620         Reviewed by Darin Adler.
2621
2622         Full screen video in Safari (still) exits full-screen if you switch to another
2623         app on a multi-display system.
2624         https://bugs.webkit.org/show_bug.cgi?id=47364
2625         <rdar://problem/8382299>
2626
2627         The FullScreen window does not technically close when it deactivates, but the
2628         two NSWindows that make up the FullScreen feature should not hide when deactivated.
2629
2630         * WebView/WebVideoFullscreenController.mm:
2631         (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
2632         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
2633         * WebView/WebVideoFullscreenHUDWindowController.mm:
2634         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
2635
2636 2010-10-29  Alexey Proskuryakov  <ap@apple.com>
2637
2638         Reviewed by Darin Adler.
2639
2640         https://bugs.webkit.org/show_bug.cgi?id=48576
2641         Let WebKit2 client know when a frame is a frameset
2642
2643         Added a blank implementation of the new FrameLoaderClient method.
2644
2645         * WebCoreSupport/WebFrameLoaderClient.h:
2646         * WebCoreSupport/WebFrameLoaderClient.mm:
2647         (WebFrameLoaderClient::dispatchDidBecomeFrameset):
2648
2649 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2650
2651         Reviewed by Adam Roben and David Kilzer.
2652
2653         Fix and cleanup of build systems
2654         https://bugs.webkit.org/show_bug.cgi?id=48342
2655
2656         * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
2657
2658 2010-10-28  Dan Bernstein  <mitz@apple.com>
2659
2660         Reviewed by Mark Rowe.
2661
2662         LLVM compiler build fix
2663
2664         * Misc/WebDownload.mm:
2665         (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
2666         id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
2667
2668 2010-10-28  Ivan Krstić  <ike@apple.com>
2669
2670         Reviewed by Mark Rowe.
2671
2672         Remove unused experimental proxied panel interface.
2673         <rdar://problem/7237059>
2674
2675         * Plugins/Hosted/NetscapePluginHostManager.h:
2676         * Plugins/Hosted/NetscapePluginHostManager.mm:
2677         (WebKit::NetscapePluginHostManager::hostForPlugin):
2678         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2679         (WebKit::NetscapePluginHostManager::instantiatePlugin):
2680         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2681         * Plugins/Hosted/WebKitPluginClient.defs:
2682         * Plugins/Hosted/WebKitPluginHost.defs:
2683         * WebCoreSupport/WebSystemInterface.mm:
2684         (InitWebCoreSystemInterface):
2685         * WebView/WebPreferenceKeysPrivate.h:
2686         * WebView/WebPreferences.mm:
2687         (+[WebPreferences initialize]):
2688         * WebView/WebPreferencesPrivate.h:
2689
2690 2010-10-27  Pratik Solanki  <psolanki@apple.com>
2691
2692         Reviewed by Darin Adler.
2693
2694         Improve memSize calculation in [WebView _setCacheModel]
2695         https://bugs.webkit.org/show_bug.cgi?id=48484
2696
2697         * WebView/WebView.mm:
2698         (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
2699         (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
2700         bigger power of 2. Also update WebCore cache settings.
2701
2702 2010-10-26  Darin Adler  <darin@apple.com>
2703
2704         Reviewed by Sam Weinig.
2705
2706         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
2707         https://bugs.webkit.org/show_bug.cgi?id=42322
2708         rdar://problem/8193631
2709
2710         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
2711         https://bugs.webkit.org/show_bug.cgi?id=42333
2712         rdar://problem/8193643
2713
2714         * History/WebBackForwardList.mm:
2715         (core): Return BackForwardListImpl.
2716         (kit): Take BackForwardListImpl.
2717         (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
2718         (-[WebBackForwardList dealloc]): Ditto.
2719         (-[WebBackForwardList finalize]): Ditto.
2720         (-[WebBackForwardList description]): Ditto.
2721         (-[WebBackForwardList setPageCacheSize:]): Ditto.
2722         (-[WebBackForwardList pageCacheSize]): Ditto.
2723         * History/WebBackForwardListInternal.h: Ditto.
2724         * WebView/WebFrameView.mm:
2725         (-[WebFrameView keyDown:]): Ditto.
2726         * WebView/WebView.mm:
2727         (-[WebView initWithCoder:]): Ditto.
2728         (-[WebView encodeWithCoder:]): Ditto.
2729         (-[WebView backForwardList]): Ditto.
2730         (-[WebView setMaintainsBackForwardList:]): Ditto.
2731
2732 2010-10-27  Chris Rogers  <crogers@google.com>
2733
2734         Reviewed by Chris Marrin.
2735
2736         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
2737         https://bugs.webkit.org/show_bug.cgi?id=48279
2738
2739         * Configurations/FeatureDefines.xcconfig:
2740
2741 2010-10-27  Beth Dakin  <bdakin@apple.com>
2742
2743         Reviewed by Darin Adler.
2744
2745         Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
2746         SPI to scale a WebView
2747         -and corresponding-
2748         <rdar://problem/8107667>
2749
2750         This patch adds SPI to Mac WebKit that scales the page by the given
2751         scale factor.
2752
2753         * WebView/WebView.mm:
2754         (-[WebView _scaleWebView:]):
2755         (-[WebView _viewScaleFactor]):
2756         * WebView/WebViewPrivate.h:
2757
2758 2010-10-27  Dan Bernstein  <mitz@apple.com>
2759
2760         Reviewed by Darin Adler.
2761
2762         REGRESSION (r70335): Incorrect article layout in Safari Reader
2763         https://bugs.webkit.org/show_bug.cgi?id=48436
2764
2765         * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
2766         * WebView/WebView.mm:
2767         (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
2768         versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
2769         (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
2770         based on the above.
2771
2772 2010-10-18  Jer Noble  <jer.noble@apple.com>
2773
2774         Reviewed by Eric Carlson.
2775
2776         Safari fullscreen media element tickles when it should not.
2777
2778         https://bugs.webkit.org/show_bug.cgi?id=47861
2779
2780         * WebView/WebVideoFullscreenController.mm:
2781         (-[WebVideoFullscreenController updatePowerAssertions]):
2782
2783 2010-10-26  Jenn Braithwaite  <jennb@chromium.org>
2784
2785         Reviewed by Dmitry Titov.
2786
2787         Resource tracking failure when trying to move a frame between documents
2788         https://bugs.webkit.org/show_bug.cgi?id=44713
2789
2790         * WebCoreSupport/WebFrameLoaderClient.h:
2791         * WebCoreSupport/WebFrameLoaderClient.mm:
2792         (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
2793         Empty method.
2794         (WebFrameLoaderClient::transferLoadingResourceFromPage):
2795         Update resource tracking for a resource load that has been transferred
2796         to a new page.
2797
2798 2010-10-25  Oliver Hunt  <oliver@apple.com>
2799
2800         Reviewed by Gavin Barraclough.
2801
2802         Remove exec and globalData arguments from jsNumber
2803         https://bugs.webkit.org/show_bug.cgi?id=48270
2804
2805         Mechanical removal of exec parameter to jsNumber
2806
2807         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2808         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
2809         * Plugins/Hosted/ProxyInstance.mm:
2810         (WebKit::ProxyInstance::numberValue):
2811
2812 2010-10-24  Dan Bernstein  <mitz@apple.com>
2813
2814         Reviewed by Anders Carlsson.
2815
2816         Expose HitTestResult::absoluteMediaURL() via WebKit API
2817         https://bugs.webkit.org/show_bug.cgi?id=48219
2818
2819         * Misc/WebElementDictionary.mm:
2820         (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
2821         _absoluteMediaURL.
2822         (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
2823         * WebKit.exp: Export WebElementMediaURLKey.
2824         * WebView/WebView.mm: Define WebElementMediaURLKey.
2825         * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
2826
2827 2010-10-24  Dan Bernstein  <mitz@apple.com>
2828
2829         Reviewed by Simon Fraser.
2830
2831         Removed deprecated methods from the WebHTMLHighlighter private protocol.
2832
2833         * WebCoreSupport/WebChromeClient.mm:
2834         (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
2835         unconditionally.
2836         (WebChromeClient::paintCustomHighlight): Call
2837         -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
2838         * WebView/WebHTMLViewPrivate.h:
2839
2840 2010-10-23  Xan Lopez  <xlopez@igalia.com>
2841
2842         Reviewed by Sam Weinig.
2843
2844         Unify globalData APIs
2845         https://bugs.webkit.org/show_bug.cgi?id=47969
2846
2847         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2848         (WebKit::NetscapePluginInstanceProxy::evaluate):
2849         (WebKit::NetscapePluginInstanceProxy::invoke):
2850         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2851         (WebKit::NetscapePluginInstanceProxy::construct):
2852         * WebView/WebScriptDebugDelegate.mm:
2853         (-[WebScriptCallFrame evaluateWebScript:]):
2854
2855 2010-10-23  David Kilzer  <ddkilzer@apple.com>
2856
2857         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
2858
2859         Reviewed by Sam Weinig.
2860
2861         The only method defined in WebHTMLRepresentationInternal.h is
2862         also defined in WebHTMLRepresentation.h, so use that instead.
2863
2864         * WebView/WebHTMLRepresentationInternal.h: Removed.
2865
2866 2010-10-23  Alexey Proskuryakov  <ap@apple.com>
2867
2868         Reviewed by Anders Carlsson.
2869
2870         https://bugs.webkit.org/show_bug.cgi?id=48083
2871         <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
2872
2873         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
2874
2875 2010-10-22  Sam Weinig  <sam@webkit.org>
2876
2877         Reviewed by Anders Carlsson.
2878
2879         WebKit2 needs to pass the current event modifier flags when requesting a new window
2880         https://bugs.webkit.org/show_bug.cgi?id=48140
2881
2882         * WebCoreSupport/WebChromeClient.h:
2883         * WebCoreSupport/WebChromeClient.mm:
2884         (WebChromeClient::createWindow):
2885         * WebCoreSupport/WebFrameLoaderClient.h:
2886         * WebCoreSupport/WebFrameLoaderClient.mm:
2887         (WebFrameLoaderClient::dispatchCreatePage):
2888         Add NavigationAction parameter.
2889
2890 2010-10-21  Andy Estes  <aestes@apple.com>
2891
2892         Reviewed by Eric Carlson.
2893
2894         WebKit shouldn't load a plug-in based on file extension if a MIME type
2895         is specified.
2896         https://bugs.webkit.org/show_bug.cgi?id=48046
2897
2898         If a MIME type is specified in an object or embed element, and that MIME
2899         type isn't supported by an installed plug-in, WebKit shouldn't attempt
2900         to find a plug-in based on the file extension of the url attribute.
2901         Doing so can lead to cases where a plug-in is loaded that can't handle
2902         resources of the MIME type specified by the author.
2903
2904         * WebCoreSupport/WebFrameLoaderClient.mm:
2905         (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
2906         extension if MIME type is the empty string.
2907
2908 2010-10-20  Simon Fraser  <simon.fraser@apple.com>
2909
2910         Reviewed by Dan Bernstein.
2911
2912         Composited elements drawn twice when WebView is layer-backed
2913         https://bugs.webkit.org/show_bug.cgi?id=48024
2914         <rdar://problem/7916580>
2915
2916         When drawing content in a layer-backed WebView, WebFrame's test
2917         for drawing to a bitmap succeeded, causing us to paint flattened
2918         compositing layers into the view. They would also be rendered
2919         by the normal compositing path, resulting in double rendering.
2920
2921         Fix this by detecting when the WebHTMLView is being drawn into
2922         a layer, and avoiding flattening in that case.
2923
2924         * WebView/WebFrame.mm:
2925         (-[WebFrame _showFlattenedCompositingLayers:]):
2926         (-[WebFrame _drawRect:contentsOnly:]):
2927         * WebView/WebHTMLView.mm:
2928         (-[WebHTMLView drawLayer:inContext:]):
2929         (-[WebHTMLView _web_isDrawingIntoLayer]):
2930         * WebView/WebHTMLViewInternal.h:
2931
2932 2010-10-20  Dumitru Daniliuc  <dumi@chromium.org>
2933
2934         Reviewed by David Levin.
2935
2936         Repost the DatabaseTracker notifications to the main thread, if needed.
2937         https://bugs.webkit.org/show_bug.cgi?id=40655
2938
2939         * Storage/WebDatabaseTrackerClient.mm:
2940         (DidModifyOriginData::dispatchToMainThread):
2941         (DidModifyOriginData::DidModifyOriginData):
2942         (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
2943         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
2944         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
2945
2946 2010-10-20  Simon Fraser  <simon.fraser@apple.com>
2947
2948         Reviewed by Darin Adler.
2949
2950         REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
2951         https://bugs.webkit.org/show_bug.cgi?id=47369
2952
2953         r46947 added code that limits the size of the layer-backed view on Leopard when
2954         the page height exceeds 4096px (later adjusted to 2048px in r48401).
2955
2956         Later, r67576 altered the geometry flipping behavior to push the geometry flipping
2957         down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
2958         to account for layer-backed view size-limiting was not fixed at the same time.
2959         This change corrects that.
2960
2961         * WebView/WebHTMLView.mm:
2962         (-[WebHTMLView _updateLayerHostingViewPosition]):
2963
2964 2010-10-19  Simon Fraser  <simon.fraser@apple.com>
2965
2966         Reviewed by Dan Bernstein.
2967
2968         <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
2969
2970         AppKit has some special code to prevent it meddling with view's layers
2971         under layer-backed WebViews. When a layer-backed WebView became composited,
2972         this caused our layer to remain zero-sized. Fix this by manually
2973         setting the geometry for our layer, if the WebHTMLView has a layer.
2974
2975         This does not seem to be a problem if the WebView becomes layer-backed, or
2976         stops being layer-backed after the WebView starts using compositing.
2977
2978         * WebView/WebHTMLView.mm:
2979         (-[WebHTMLView attachRootLayer:]):
2980
2981 2010-10-20  Dirk Schulze  <krit@webkit.org>
2982
2983         Reviewed by Nikolas Zimmermann.
2984
2985         Merge ColorSpace and ImageColorSpace enums
2986         https://bugs.webkit.org/show_bug.cgi?id=47922
2987
2988         Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
2989         to follow webkit style rules.
2990
2991         * Misc/WebKitNSStringExtras.mm:
2992         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2993
2994 2010-10-19  Alexey Proskuryakov  <ap@apple.com>
2995
2996         Reviewed by Anders Carlsson.
2997
2998         https://bugs.webkit.org/show_bug.cgi?id=47933
2999         <rdar://problem/8494337> navigator.language doesn't work in WebKit2
3000
3001         * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
3002         We need to keep _webkit_preferredLanguageCode for Safari.
3003
3004         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
3005         Initialize wkCopyCFLocalizationPreferredName.
3006
3007         * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
3008
3009 2010-10-18  Alexey Proskuryakov  <ap@apple.com>
3010
3011         Reviewed by David Kilzer.
3012
3013         https://bugs.webkit.org/show_bug.cgi?id=47864
3014         Convert WebNSUserDefaultsExtras.m to .mm
3015
3016         Also, fixed some issues in the process:
3017         - removed locking, which was only necessary when this code was in Foundation;
3018         - fixed notification center observer to actually work (previously, it picked up changes
3019         when application preferences changed, not when system language did);
3020         - removed unused NSString category;
3021         - updated style.
3022
3023         * Misc/WebNSUserDefaultsExtras.m: Removed.
3024         * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
3025         (createHTTPStyleLanguageCode):
3026         (+[NSUserDefaults _webkit_defaultsDidChange]):
3027         (addLanguageChangeObserver):
3028         (+[NSUserDefaults _webkit_preferredLanguageCode]):
3029
3030 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
3031
3032         Reviewed by Eric Seidel.
3033
3034         Switch to using the new Carbon NPAPI event declarations, and remove
3035         the old ones.
3036
3037         https://bugs.webkit.org/show_bug.cgi?id=40784
3038
3039         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3040         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
3041         (WebNetscapePluginEventHandlerCarbon::mouseExited):
3042         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
3043         (WebNetscapePluginEventHandlerCarbon::focusChanged):
3044
3045 2010-10-18  Pavel Podivilov  <podivilov@chromium.org>
3046
3047         Reviewed by Timothy Hatcher.
3048
3049         Web Inspector: disable private browsing for inspector
3050         https://bugs.webkit.org/show_bug.cgi?id=47827
3051
3052         * WebCoreSupport/WebInspectorClient.mm:
3053         (-[WebInspectorWindowController init]):
3054
3055 2010-10-14  Ilya Tikhonovsky  <loislo@chromium.org>
3056
3057         Reviewed by Pavel Feldman.
3058
3059         Web Inspector: inspector settings/properties/states management
3060         should be extracted into separate class.
3061
3062         We have a lot of flags/values in InspectorController.
3063         Some flags are persisting into profile.
3064         Others are part of inspector state for frontend.
3065         All these flags should keep their values after navigation.
3066         It'd be better to extract these flags/values into separate
3067         class which will care about theirs lifetime.
3068
3069         https://bugs.webkit.org/show_bug.cgi?id=47275
3070
3071         * WebCoreSupport/WebInspectorClient.mm:
3072         (-[WebInspectorWindowController showWindow:]):
3073         (-[WebInspectorWindowController attach]):
3074         (-[WebInspectorWindowController detach]):
3075
3076 2010-10-13  Gavin Barraclough  <barraclough@apple.com>
3077
3078         Reviewed by Oliver Hunt.
3079
3080         https://bugs.webkit.org/show_bug.cgi?id=43987
3081         Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
3082         to construct their internal result string.  Remove ScriptString (this is now
3083         redundant).
3084
3085         * WebCoreSupport/WebFrameLoaderClient.mm:
3086
3087 2010-10-12  Andy Estes  <aestes@apple.com>
3088
3089         Rubber-stamped by Darin Adler.
3090
3091         Check in some cleanup from the previous commit.
3092
3093         * WebView/WebView.mm:
3094         (leakMailQuirksUserScriptPath): Renamed to indicate that this function
3095         leaks an NSString.
3096         (-[WebView _injectMailQuirksScript]): Moved a static initialization from
3097         a separate class method into the only method that used it and removed
3098         the now-unnecessary class method.
3099
3100 2010-10-12  Eric Seidel  <eric@webkit.org>
3101
3102         Reviewed by Darin Adler.
3103
3104         REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
3105         https://bugs.webkit.org/show_bug.cgi?id=45693
3106
3107         Re-implement this former WebCore parser quirk as a
3108         Mac-only userscript-based quirk.  As far as I can tell
3109         from Darin's description this should satisfy Mail's needs.
3110
3111         * Misc/MailQuirksUserScript.js: Added.
3112         * WebView/WebView.mm:
3113         (+[WebView _mailQuirksUserScript]):
3114         (-[WebView _injectMailQuirksScript]):
3115         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3116
3117 2010-10-12  Simon Fraser  <simon.fraser@apple.com>
3118
3119         Reviewed by Sam Weinig.
3120
3121         Add 'didDraw' callback for framerate tracking
3122         https://bugs.webkit.org/show_bug.cgi?id=47478
3123
3124         Add a callback at the end of -[WebHTMLView drawRect:] so
3125         a delegate can get notified when a draw happens.
3126
3127         * WebView/WebHTMLView.mm:
3128         (-[WebHTMLView drawRect:]):
3129         * WebView/WebUIDelegatePrivate.h:
3130
3131 2010-10-11  Anders Carlsson  <andersca@apple.com>
3132
3133         Reviewed by Darin Adler.
3134
3135         Remove WebIconFetcher from WebKit and IconFetcher from WebCore
3136         https://bugs.webkit.org/show_bug.cgi?id=47523
3137
3138         Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
3139
3140         * Misc/WebIconFetcher.h: Removed.
3141         * Misc/WebIconFetcher.mm: Removed.
3142         * Misc/WebIconFetcherInternal.h: Removed.
3143         * WebView/WebFrame.mm:
3144         * WebView/WebFramePrivate.h:
3145
3146 2010-10-11  Jessie Berlin  <jberlin@apple.com>
3147
3148         Reviewed by Darin Adler.
3149
3150         Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
3151         representation of a WebKit1 WebSerializedJSValue.
3152         https://bugs.webkit.org/show_bug.cgi?id=47439
3153
3154         * WebView/WebSerializedJSValue.mm:
3155         (-[WebSerializedJSValue internalRepresentation]):
3156         * WebView/WebSerializedJSValuePrivate.h:
3157
3158 2010-10-07  Jessie Berlin  <jberlin@apple.com>
3159
3160         Reviewed by Sam Weinig.
3161
3162         Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
3163         representation of a WebKit2 WebSerializedScriptValue.
3164         https://bugs.webkit.org/show_bug.cgi?id=47390
3165
3166         * WebView/WebSerializedJSValue.mm:
3167         (-[WebSerializedJSValue initWithInternalRepresentation:]):
3168         Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
3169         internal representation.
3170         * WebView/WebSerializedJSValuePrivate.h: Added.
3171
3172 2010-10-07  Antonio Gomes  <agomes@rim.com>
3173
3174         Reviewed by Simon Fraser.
3175
3176         [Mac] [DRT] implement setSpatialNavigationEnabled
3177         https://bugs.webkit.org/show_bug.cgi?id=47291
3178
3179         Added the needed bits to make it possible to enabled spatial navigation
3180         for the Mac port. For now it is being only used by DRT.
3181
3182         * WebView/WebPreferenceKeysPrivate.h:
3183         * WebView/WebPreferences.mm:
3184         (+[WebPreferences initialize]):
3185         (-[WebPreferences isSpatialNavigationEnabled]):
3186         (-[WebPreferences setSpatialNavigationEnabled:]):
3187         * WebView/WebPreferencesPrivate.h:
3188         * WebView/WebView.mm:
3189         (-[WebView _preferencesChangedNotification:]):
3190
3191 2010-10-07  Jer Noble  <jer.noble@apple.com>
3192
3193         Fix the Leopard 64-bit build.
3194
3195         * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
3196             framework search path.
3197         * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
3198
3199 2010-10-06  Jer Noble  <jer.noble@apple.com>
3200
3201         Reviewed by Darin Adler.
3202
3203         Screensaver starts while watching fullscreen playback.
3204         https://bugs.webkit.org/show_bug.cgi?id=47299
3205         <rdar://problem/8478956>
3206
3207         To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
3208
3209         * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
3210         * WebView/WebVideoFullscreenController.mm:
3211         (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
3212         (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
3213         (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
3214         (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
3215         (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
3216             or _disableTickleTimer.
3217
3218 2010-10-05  Philippe Normand  <pnormand@igalia.com>
3219
3220         Reviewed by Martin Robinson.
3221
3222         check for ENABLE(GLIB_SUPPORT) in WebView
3223         https://bugs.webkit.org/show_bug.cgi?id=46788
3224
3225         Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
3226
3227         * WebView/WebView.mm:
3228         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3229         (-[WebView _close]):
3230         * WebView/WebViewData.h:
3231         * WebView/WebViewInternal.h:
3232
3233 2010-10-01  Anders Carlsson  <andersca@apple.com>
3234
3235         Fix Snow Leopard build.
3236
3237         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3238         (WebKit::NetscapePluginInstanceProxy::getProxy):
3239
3240 2010-10-01  Anders Carlsson  <andersca@apple.com>
3241
3242         Reviewed by Dan Bernstein.
3243
3244         Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
3245         https://bugs.webkit.org/show_bug.cgi?id=47022
3246         <rdar://problem/8504712>
3247
3248         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3249         (WebKit::NetscapePluginInstanceProxy::getProxy):
3250         * Plugins/WebBaseNetscapePluginView.h:
3251         * Plugins/WebBaseNetscapePluginView.mm:
3252         * Plugins/WebNetscapePluginView.mm:
3253         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3254
3255 2010-09-30  Darin Adler  <darin@apple.com>
3256
3257         Reviewed by Sam Weinig.
3258
3259         Remove remaining calls to deprecatedParseURL
3260         https://bugs.webkit.org/show_bug.cgi?id=26599
3261
3262         * DOM/WebDOMOperations.mm:
3263         (-[DOMDocument URLWithAttributeString:]):
3264         * WebCoreSupport/WebFrameLoaderClient.mm:
3265         (WebFrameLoaderClient::createPlugin):
3266         Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
3267
3268 2010-09-30  Anders Carlsson  <andersca@apple.com>
3269
3270         Reviewed by Darin Adler.
3271
3272         -[DOMDocument _documentRange] throws an exception if there is no document element
3273         https://bugs.webkit.org/show_bug.cgi?id=46934
3274         <rdar://problem/8169260>
3275
3276         If there is no document element, just return an empty range. Otherwise we'll try to call
3277         Range::selectNode with a null Node which will throw a NOT_FOUND exception.
3278
3279         * DOM/WebDOMOperations.mm:
3280         (-[DOMDocument _documentRange]):
3281
3282 2010-09-30  Chris Marrin  <cmarrin@apple.com>
3283
3284         Reviewed by Simon Fraser.
3285
3286         Make 2D accelerated canvas rendering build on Mac
3287         https://bugs.webkit.org/show_bug.cgi?id=46007
3288
3289         Added ACCELERATED_2D_CANVAS to FeatureDefines
3290
3291         * Configurations/FeatureDefines.xcconfig:
3292
3293 2010-09-30  Dan Bernstein  <mitz@apple.com>
3294
3295         Reviewed by John Sullivan.
3296
3297         Add printing SPI allowing full control over shrink-to-fit
3298         https://bugs.webkit.org/show_bug.cgi?id=46877
3299
3300         * WebView/WebHTMLView.mm:
3301         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
3302         * WebView/WebHTMLViewPrivate.h:
3303
3304 2010-09-28  Johnny Ding  <jnd@chromium.org>
3305
3306         Reviewed by Adam Barth.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=41292
3309         Some windowed plugins did not handle events through EventHandler, so we
3310         never set right gesture state for those events.
3311         This change is to set right allowPopupsFromPlugin flag to current
3312         execution frame, so WeKit can always get right gesture state on Mac.
3313         From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
3314         process, that process passes the allowPopupsFromPlugin flag to
3315         WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
3316         NetscapePluginInstanceProxy::evaluate.
3317
3318         * Plugins/WebNetscapePluginView.mm:
3319         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3320
3321 2010-09-28  Jenn Braithwaite  <jennb@chromium.org>
3322
3323         Reviewed by Dmitry Titov.
3324
3325         Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
3326         https://bugs.webkit.org/show_bug.cgi?id=46663
3327
3328         * WebCoreSupport/WebFrameLoaderClient.h:
3329         * WebCoreSupport/WebFrameLoaderClient.mm:
3330         (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
3331
3332 2010-09-26  Antonio Gomes  <agomes@rim.com>
3333
3334         Reviewed by Kenneth Rohde Christiansen.
3335
3336         DRT/Mac nodesFromRect support
3337
3338         [Mac][DRT] Implement LayoutTestController::nodesFromRect
3339         https://bugs.webkit.org/show_bug.cgi?id=46580
3340
3341         Implement nodesFromRect as a private method to access non-exposed Document
3342         methods, similarly to computedStyleIncludingVisitedInfo.
3343
3344         * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
3345         These headers makes it possible to:
3346         1) Get a Document off of a JSDocument;
3347         2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
3348         gotten from Document::nodesFromRect to JS bindings.
3349         (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
3350         * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
3351         Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
3352
3353 2010-09-24  Jia Pu  <jpu@apple.com>
3354
3355         Reviewed by Dan Bernstein.
3356
3357         automaticSpellingCorrectionEnabled isn't updated.
3358         https://bugs.webkit.org/show_bug.cgi?id=46486
3359         <rdar://problem/8475212>
3360
3361         * WebView/WebView.mm:
3362         (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
3363           instead of "automaticTextReplacementEnabled".
3364
3365 2010-09-23  Alexey Proskuryakov  <ap@apple.com>
3366
3367         Reviewed by Darin Adler.
3368
3369         https://bugs.webkit.org/show_bug.cgi?id=46380
3370         REGRESSION: Crash when downloading a file
3371
3372         Downloading cannot be tested in DRT.
3373
3374         * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3375         Don't copy null strings.
3376
3377 2010-09-24  Ilya Tikhonovsky  <loislo@chromium.org>
3378
3379         Reviewed by Yury Semikhatsky.
3380
3381         Web Inspector: CRASH at node highlight on MAC Safari.
3382         1) run-safari --debug
3383         2) open inspector
3384         3) open elements panel
3385         4) hover mouse over elements panel items multiple times
3386         5) CRASH
3387         Looks like it is a race condition. WebNodeHighlightView doesn't check
3388         the pointer to WebNodeHighligh object and it can be nil.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=46261
3391
3392         * WebInspector/WebNodeHighlightView.mm:
3393         (-[WebNodeHighlightView drawRect:]):
3394
3395 2010-09-23  Andy Estes  <aestes@apple.com>
3396
3397         Reviewed by Darin Adler.
3398
3399         REGRESSION (r61285): some Dashboard widgets are always invisible due to
3400         HTML parser changes.
3401         https://bugs.webkit.org/show_bug.cgi?id=46435
3402
3403         Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
3404         mode.
3405
3406         * WebView/WebView.mm:
3407         (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
3408         shouldUsePreHTML5ParserQuirks(). Return true if
3409         WebCore::Settings::usesDashboardCompatibilityMode() is true.
3410         (-[WebView _preferencesChangedNotification:]):
3411         (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
3412         if Dashboard behavior is set to backward compatibility mode.
3413
3414 2010-09-23  Matthew Delaney  <mdelaney@apple.com>
3415
3416         Reviewed by Simon Fraser.
3417
3418         Reduce minimum DOMTimer interval
3419         https://bugs.webkit.org/show_bug.cgi?id=45362
3420
3421         * WebView/WebView.mm:
3422         Updating set interval call to use Settings' static version inside
3423         one time init block.
3424
3425 2010-09-22  Andy Estes  <aestes@apple.com>
3426
3427         Reviewed by Darin Adler.
3428
3429         REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
3430         https://bugs.webkit.org/show_bug.cgi?id=46334
3431
3432         Microsoft My Day loads scripts using self-closing script tags, markup
3433         which is incompatible with the HTML5 parser. Enable parser quirks for
3434         this application.
3435
3436         * WebView/WebView.mm:
3437         (shouldUsePreHTML5ParserQuirks): Return true if the application is
3438         Microsoft My Day and was linked against a version of WebKit prior to the
3439         introduction of the HTML5 parser.
3440
3441 2010-09-23  Nate Chapin  <japhet@chromium.org>
3442
3443         Reviewed by Darin Fisher.
3444
3445         Add hyperlink auditing settings (i.e., <a ping>).
3446         https://bugs.webkit.org/show_bug.cgi?id=30458
3447
3448         * WebView/WebPreferenceKeysPrivate.h:
3449         * WebView/WebPreferences.mm:
3450         (+[WebPreferences initialize]):
3451         (-[WebPreferences setMemoryInfoEnabled:]):
3452         (-[WebPreferences hyperlinkAuditingEnabled]):
3453         (-[WebPreferences setHyperlinkAuditingEnabled:]):
3454         * WebView/WebPreferencesPrivate.h:
3455         * WebView/WebView.mm:
3456         (-[WebView _preferencesChangedNotification:]):
3457
3458 2010-09-22  Alexey Proskuryakov  <ap@apple.com>
3459
3460         Reviewed by Anders Carlsson.
3461
3462         https://bugs.webkit.org/show_bug.cgi?id=43667
3463         ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
3464
3465         Test: plugins/get-javascript-url.html
3466
3467         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3468         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
3469         like any other one.
3470
3471 2010-09-21  Darin Adler  <darin@apple.com>
3472
3473         Reviewed by Anders Carlsson.
3474
3475         Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
3476         https://bugs.webkit.org/show_bug.cgi?id=46220
3477
3478         * Misc/WebNSFileManagerExtras.m:
3479         (setMetaData): Use CFRelease instead of HardRelease.
3480         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
3481         instead of -[NSObject copy] combined with HardRetainWithNSRelease.
3482
3483 2010-09-22  Balazs Kelemen  <kb@inf.u-szeged.hu>
3484
3485         Reviewed by Kenneth Rohde Christiansen.
3486
3487         PluginStrategy should satisfy the needs of Qt
3488         https://bugs.webkit.org/show_bug.cgi?id=45857
3489         No new functionality so no new tests.
3490
3491         * WebCoreSupport/WebPlatformStrategies.h:
3492         * WebCoreSupport/WebPlatformStrategies.mm:
3493         (WebPlatformStrategies::getPluginInfo):
3494
3495 2010-09-22  Paul Knight  <pknight@apple.com>
3496
3497         Reviewed by Simon Fraser.
3498
3499         -[WebView _scheduleCompositingLayerSync] should wake the run loop
3500         https://bugs.webkit.org/show_bug.cgi?id=46226
3501
3502         Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
3503
3504         * WebView/WebView.mm:
3505         (-[WebView _scheduleCompositingLayerSync]):
3506
3507 2010-09-21  Andy Estes  <aestes@apple.com>
3508
3509         Reviewed by Darin Adler.
3510
3511         REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
3512         https://bugs.webkit.org/show_bug.cgi?id=46134
3513
3514         AIM clients linked against versions of WebKit prior to the introduction
3515         of the HTML5 parser contain markup incompatible with the new parser.
3516         Enable parser quirks in this case to remain compatible with these
3517         clients.
3518
3519         * WebView/WebView.mm:
3520         (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
3521         application is AIM and was linked against a version of WebKit prior to
3522         the introduction of the HTML5 parser, or if the
3523         WebKitPreHTML5ParserQuirks WebPreference is enabled.
3524         (-[WebView _preferencesChangedNotification:]): Call
3525         WebCore::Settings::setUsePreHTML5ParserQuirks().
3526
3527 2010-09-21  Steve Block  <steveblock@google.com>
3528
3529         Reviewed by Jeremy Orlow.
3530
3531         DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
3532         https://bugs.webkit.org/show_bug.cgi?id=45891
3533
3534         Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
3535
3536         * WebCoreSupport/WebDeviceOrientationClient.h:
3537         * WebCoreSupport/WebDeviceOrientationClient.mm:
3538         (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
3539
3540 2010-09-20  Philippe Normand  <pnormand@igalia.com>
3541
3542         Reviewed by Eric Carlson.
3543
3544         [GTK] enhanced context menu for media elements
3545         https://bugs.webkit.org/show_bug.cgi?id=45021
3546
3547         New localized strings for the media element context-menu.
3548
3549         * WebCoreSupport/WebPlatformStrategies.h:
3550         * WebCoreSupport/WebPlatformStrategies.mm:
3551         (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
3552         (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
3553         (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
3554         (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
3555         (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
3556         (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
3557         (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
3558         (WebPlatformStrategies::contextMenuItemTagMediaPlay):
3559         (WebPlatformStrategies::contextMenuItemTagMediaPause):
3560         (WebPlatformStrategies::contextMenuItemTagMediaMute):
3561
3562 2010-09-20  Andy Estes  <aestes@apple.com>
3563
3564         Reviewed by Adam Barth.
3565
3566         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
3567         https://bugs.webkit.org/show_bug.cgi?id=40961
3568
3569         Implement WebKitUsePreHTML5ParserQuirks preference.
3570
3571         * WebView/WebPreferenceKeysPrivate.h:
3572         * WebView/WebPreferences.mm:
3573         (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
3574         false.
3575         (-[WebPreferences usePreHTML5ParserQuirks]):
3576         (-[WebPreferences setUsePreHTML5ParserQuirks:]):
3577         * WebView/WebPreferencesPrivate.h:
3578         * WebView/WebView.mm:
3579         (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
3580         with the value of WebKitUsePreHTML5ParserQuirks when a preference
3581         changes.
3582
3583 2010-09-20  Enrica Casucci  <enrica@apple.com>
3584
3585         Reviewed by Sam Weinig.
3586
3587         Pasteboard doesn't work in WebKit2.
3588         https://bugs.webkit.org/show_bug.cgi?id=42317
3589         <rdar://problem/7660537>
3590
3591         Some changes to fix style inconsistencies.
3592         Added OBJC 2.0 style enumeration.
3593
3594         * WebCoreSupport/WebEditorClient.h:
3595         * WebCoreSupport/WebEditorClient.mm:
3596         (WebEditorClient::userVisibleString):
3597         (createExcludedElementsForAttributedStringConversion):
3598         (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
3599         a Vector of RefPtr.
3600         (WebEditorClient::setInsertionPasteboard):
3601         (WebEditorClient::pasteboardTypesForSelection):
3602
3603 2010-09-17  David Hyatt  <hyatt@apple.com>
3604
3605         Reviewed by Simon Fraser.
3606
3607         https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
3608
3609         Make printing store the page height in the RenderView and push that into the layout state to
3610         use the new pagination model.  The old pagination model is retained because it is still used
3611         for embedded WebViews.
3612
3613         * WebView/WebHTMLView.mm:
3614         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
3615
3616 2010-09-17  Darin Adler  <darin@apple.com>
3617
3618         Reviewed by Sam Weinig.
3619
3620         REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
3621         https://bugs.webkit.org/show_bug.cgi?id=42863
3622
3623         * WebView/WebView.mm:
3624         (-[WebView _setZoomMultiplier:isTextOnly:]):
3625         Call functions on Frame instead of FrameView.
3626
3627 2010-09-17  Matthew Delaney  <mdelaney@apple.com>
3628
3629         Reviewed by Simon Fraser.
3630
3631         Reduce minimum DOMTimer interval
3632         https://bugs.webkit.org/show_bug.cgi?id=45362
3633
3634         * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
3635
3636 2010-09-17  Chris Marrin  <cmarrin@apple.com>
3637
3638         Reviewed by Simon Fraser.
3639
3640         Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
3641         https://bugs.webkit.org/show_bug.cgi?id=45911
3642
3643         * WebView/WebPreferenceKeysPrivate.h:
3644         * WebView/WebPreferences.mm:
3645         (+[WebPreferences initialize]):
3646         (-[WebPreferences accelerated2dCanvasEnabled]):
3647         (-[WebPreferences setAccelerated2dCanvasEnabled:]):
3648         * WebView/WebPreferencesPrivate.h:
3649         * WebView/WebView.mm:
3650         (-[WebView _preferencesChangedNotification:]):
3651
3652 2010-09-17  Jia Pu  <jpu@apple.com>
3653
3654         Reviewed by Dan Bernstein.
3655
3656         WebKit should use system wide spell checking preference when application specific one isn't set.
3657         https://bugs.webkit.org/show_bug.cgi?id=45789
3658         <rdar://problem/8416041>
3659
3660         * WebView/WebView.mm:
3661         (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
3662           when the application level preferences are not set.
3663
3664 2010-09-16  John Sullivan  <sullivan@apple.com>
3665
3666         Reviewed by Darin Adler.
3667
3668         <rdar://problem/8395558>
3669         https://bugs.webkit.org/show_bug.cgi?id=45938
3670         _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
3671
3672         * WebView/WebHTMLView.mm:
3673         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3674         Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
3675         was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
3676         this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
3677         before enumerating it, to ensure that the selector can't mutate the array being enumerated.
3678         (-[WebHTMLView viewWillMoveToHostWindow:]):
3679         Updated for _web_makePluginSubviewsPerformSelector:: signature change.
3680         (-[WebHTMLView viewDidMoveToHostWindow]):
3681         Ditto.
3682
3683 2010-09-16  Darin Adler  <darin@apple.com>
3684
3685         Reviewed by Andreas Kling.
3686
3687         Reduce use of HTMLInputElement::inputType so we can remove it later
3688         https://bugs.webkit.org/show_bug.cgi?id=45903
3689
3690         * WebView/WebHTMLRepresentation.mm:
3691         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
3692         (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
3693
3694 2010-09-16  Patrick Gansterer  <paroga@paroga.com>
3695
3696         Reviewed by Darin Adler.
3697
3698         Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
3699         https://bugs.webkit.org/show_bug.cgi?id=41510
3700
3701         This prevents usage of nil value, which would cause an uncaught exception.
3702
3703         * WebView/WebPreferences.mm:
3704         (-[WebPreferences setUserStyleSheetLocation:]):
3705
3706 2010-09-16  Dan Bernstein  <mitz@apple.com>
3707
3708         Reverted the previous change because r67628 has been reverted.
3709
3710         * WebCoreSupport/WebPlatformStrategies.h:
3711         * WebCoreSupport/WebPlatformStrategies.mm:
3712
3713 2010-09-16  Dan Bernstein  <mitz@apple.com>
3714
3715         Build fix after r67628. Added context menu item localizable strings for the items
3716         added in r67628, following equivalent menu items in Mac OS X when possible. However,
3717         this set of menu items does not make much sense for Mac OS X, and this should be
3718         addressed separately.
3719
3720         * WebCoreSupport/WebPlatformStrategies.h:
3721         * WebCoreSupport/WebPlatformStrategies.mm:
3722         (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
3723         (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
3724         (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
3725         (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
3726         (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
3727         (WebPlatformStrategies::contextMenuItemTagMediaPlay):
3728         (WebPlatformStrategies::contextMenuItemTagMediaPause):
3729         (WebPlatformStrategies::contextMenuItemTagMediaMute):
3730         (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
3731
3732 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3733
3734         Reviewed by Jian Li.
3735
3736         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3737         https://bugs.webkit.org/show_bug.cgi?id=45798
3738
3739         * Configurations/FeatureDefines.xcconfig:
3740
3741 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3742
3743         Reviewed by Adam Roben.
3744
3745         https://bugs.webkit.org/show_bug.cgi?id=44715
3746         maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
3747
3748         Move geometry flipping to platform-specific code.
3749
3750         * WebView/WebHTMLView.mm:
3751         (-[WebHTMLView attachRootLayer:]):
3752
3753 2010-09-14  Jia Pu  <jpu@apple.com>
3754
3755         Reviewed by Dan Bernstein.
3756
3757         Only intercept ESC key press when autocorrection UI is visible.
3758         https://bugs.webkit.org/show_bug.cgi?id=45071
3759
3760         * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
3761           which provides an inteface to query whether autocorrection panel is shown.
3762
3763         * WebCoreSupport/WebEditorClient.mm:
3764         (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
3765           for invalid correction panel tag. Replaced -1 with this constant.
3766         (WebEditorClient::dismissCorrectionPanel): Ditto
3767         (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
3768
3769 2010-09-14  Mark Rowe  <mrowe@apple.com>
3770
3771         Reviewed by John Sullivan.
3772
3773         Part of <rdar://problem/8420003>.  Make it possible to override the version number used in linked-in-or-after checks.
3774
3775         * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
3776         * Misc/WebKitVersionChecks.m:
3777         (WebKitLinkedOnOrAfter):
3778         (setWebKitLinkTimeVersion): Set the overridden version.
3779         (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
3780         * WebView/WebPreferences.mm:
3781         (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
3782         * WebView/WebPreferencesPrivate.h:
3783
3784 2010-09-14  Eric Seidel  <eric@webkit.org>
3785
3786         Unreviewed, reverting changes r67451 and r67451.
3787         Broke lots of builders.
3788
3789         Only intercept ESC key press when autocorrection UI is visible.
3790         https://bugs.webkit.org/show_bug.cgi?id=45071
3791
3792         * WebCoreSupport/WebEditorClient.h:
3793         * WebCoreSupport/WebEditorClient.mm:
3794         (WebEditorClient::WebEditorClient):
3795         (WebEditorClient::dismissCorrectionPanel):
3796
3797 2010-09-14  Jia Pu  <jpu@apple.com>
3798
3799         Reviewed by Dan Bernstein.
3800
3801         Only intercept ESC key press when autocorrection UI is visible.
3802         https://bugs.webkit.org/show_bug.cgi?id=45071
3803
3804         * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
3805           which provides an inteface to query whether autocorrection panel is shown.
3806
3807         * WebCoreSupport/WebEditorClient.mm:
3808         (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
3809           for invalid correction panel tag. Replaced -1 with this constant.
3810         (WebEditorClient::dismissCorrectionPanel): Ditto
3811         (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
3812
3813 2010-09-13  Darin Adler  <darin@apple.com>
3814
3815         Reviewed by Adam Barth.
3816
3817         Preparation for eliminating deprecatedParseURL
3818         https://bugs.webkit.org/show_bug.cgi?id=45695
3819
3820         * DOM/WebDOMOperations.mm:
3821         (-[DOMDocument webFrame]): Get rid of unneeded local variable.
3822         (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
3823
3824 2010-09-13  Enrica Casucci  <enrica@apple.com>
3825
3826         Reviewed by Sam Weinig.
3827
3828         Paste should be implemented in WebCore like Copy and Cut for Mac also.
3829         https://bugs.webkit.org/show_bug.cgi?id=45494
3830         <rdar://problem/7660537>
3831
3832         On the Mac platform, the implementation of the paste operation is all done
3833         at the WebKit level. In order to support it on WebKit2 it is necessary to
3834         refactor the code and move this functionality at the level of WebCore like
3835         we already have on Windows.
3836         The original code relies on some in AppKit functions that call back into
3837         WebKit causing problems in WebKit2. All this functionality has been moved
3838         at the level of the editor client where it can be dealt with appropriately.
3839
3840         * WebCoreSupport/WebEditorClient.h:
3841         * WebCoreSupport/WebEditorClient.mm:
3842         (excludedElementsForAttributedStringConversion):
3843         (WebEditorClient::documentFragmentFromAttributedString): Added.
3844         (WebEditorClient::setInsertionPasteboard):
3845         * WebCoreSupport/WebFrameLoaderClient.h:
3846         * WebCoreSupport/WebFrameLoaderClient.mm:
3847         (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
3848         of the editor client.
3849         * WebView/WebHTMLView.mm: Removed paste method.
3850
3851 2010-09-13  John Sullivan  <sullivan@apple.com>
3852
3853         Reviewed by Adam Roben.
3854
3855         https://bugs.webkit.org/show_bug.cgi?id=45677
3856         [WebView canMarkAllTextMatches] can crash if called after [WebView close]
3857
3858         <rdar://problem/8404890>
3859
3860         * WebView/WebView.mm:
3861         (-[WebView canMarkAllTextMatches]):
3862         Return NO immediately if the webview has already been closed. This was an overlooked
3863         case from the fix for 45175.
3864
3865 2010-09-10  MORITA Hajime  <morrita@google.com>
3866
3867         Reviewed by Tony Chang.
3868
3869         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3870         https://bugs.webkit.org/show_bug.cgi?id=45441
3871
3872         Moved the actual logic of hasSpellingMarker into WebCore to share
3873         it with other ports.
3874
3875         * WebView/WebFrame.mm:
3876         (-[WebFrame hasSpellingMarker:length:]):
3877
3878 2010-09-11  Adam Barth  <abarth@webkit.org>
3879
3880         Reviewed by Sam Weinig.
3881
3882         Make SecurityOrigin::canDisplay an instance function
3883         https://bugs.webkit.org/show_bug.cgi?id=45219
3884
3885         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3886         (WebKit::NetscapePluginInstanceProxy::loadRequest):
3887         * Plugins/WebNetscapePluginStream.mm:
3888         (WebNetscapePluginStream::WebNetscapePluginStream):
3889         * Plugins/WebNetscapePluginView.mm:
3890         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3891         * Plugins/WebPluginContainerCheck.mm:
3892         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3893         * WebView/WebFrame.mm:
3894         (-[WebFrame _allowsFollowingLink:]):
3895
3896 2010-09-10  Sam Weinig  <sam@webkit.org>
3897
3898         Reviewed by Darin Adler.
3899
3900         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3901         Precursor to <rdar://problem/7660657>
3902         https://bugs.webkit.org/show_bug.cgi?id=45522
3903
3904         * WebView/WebView.mm:
3905         (-[WebView _preferencesChangedNotification:]):
3906         (-[WebView _setZoomMultiplier:isTextOnly:]):
3907         (-[WebView _realZoomMultiplierIsTextOnly]):
3908         * WebView/WebViewData.h:
3909         * WebView/WebViewData.mm:
3910         (-[WebViewPrivate init]):
3911         Move tracking of text only zoom here from WebCore.
3912
3913 2010-09-10  Stephanie Lewis  <slewis@apple.com>
3914
3915         Reviewed by Alexey Proskuryakov.
3916
3917         Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
3918         other implementation details of JavaScriptCore.  Necessary to fix PPC build.
3919
3920         https://bugs.webkit.org/show_bug.cgi?id=45528
3921
3922         * Misc/WebCoreStatistics.mm:
3923         (+[WebCoreStatistics memoryStatistics]):
3924
3925 2010-09-10  Darin Adler  <darin@apple.com>
3926
3927         Reviewed by Sam Weinig.
3928
3929         Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
3930         https://bugs.webkit.org/show_bug.cgi?id=45582
3931
3932         * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
3933
3934         * WebCoreSupport/WebChromeClient.mm:
3935         (WebChromeClient::dashboardRegionsChanged): Changed this to call
3936         -[WebView _dashboardRegions] so we don't have two copies of that code.
3937
3938         * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
3939         * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
3940
3941         * WebView/WebView.mm:
3942         (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
3943
3944 2010-09-10  Adam Barth  <abarth@webkit.org>
3945
3946         Reviewed by Darin Fisher.
3947
3948         Move code from WebKit-layer to DocumentLoader
3949         https://bugs.webkit.org/show_bug.cgi?id=45569
3950
3951         This code is the most confused, but now should be a bit cleaner.
3952         There's still a magical fake-setting for creating renderers that needs
3953         to be cleaned up, but we can do that in a separate patch.
3954
3955         * WebView/WebFrame.mm:
3956         (-[WebFrame _commitData:]):
3957         * WebView/WebFrameInternal.h:
3958         * WebView/WebHTMLRepresentation.mm:
3959         (-[WebHTMLRepresentation receivedData:withDataSource:]):
3960         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3961
3962 2010-09-09  Darin Adler  <darin@apple.com>
3963
3964         Reviewed by Adam Barth.
3965
3966         Move functions from Frame to SelectionController as planned
3967         https://bugs.webkit.org/show_bug.cgi?id=45508
3968
3969         * WebView/WebFrame.mm:
3970         (-[WebFrame _selectionGranularity]):
3971         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
3972         (-[WebFrame _typingStyle]):
3973         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3974         * WebView/WebHTMLRepresentation.mm:
3975         (-[WebHTMLRepresentation currentForm]):
3976         * WebView/WebHTMLView.mm:
3977         (-[WebHTMLView jumpToSelection:]):
3978         (-[WebHTMLView centerSelectionInVisibleArea:]):
3979         (-[WebHTMLView _canSmartCopyOrDelete]):
3980         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
3981         (-[WebHTMLView selectionRect]):
3982         (-[WebHTMLView selectionTextRects]):
3983         (-[WebHTMLView selectionImageRect]):
3984         * WebView/WebView.mm:
3985         (-[WebView setEditable:]):
3986         Call functions on selection().
3987
3988 2010-09-10  Adam Barth  <abarth@webkit.org>
3989
3990         Reviewed by Eric Seidel.
3991
3992         Main resource bytes shouldn't bounce through FrameLoader
3993         https://bugs.webkit.org/show_bug.cgi?id=45496
3994
3995         Now return the bytes to the DocumentLoader.
3996
3997         Previously, we were checking the document for null.  However, Frame can
3998         never have a null document, so this check is no longer needed.
3999
4000         * WebView/WebFrame.mm:
4001         (-[WebFrame _addData:]):
4002
4003 2010-09-09  John Therrell  <jtherrell@apple.com>
4004
4005         Reviewed by Alexey Proskuryakov.
4006
4007         Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
4008         https://bugs.webkit.org/show_bug.cgi?id=45134
4009
4010         Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
4011         and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
4012         and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
4013
4014         * Misc/WebCoreStatistics.mm:
4015         (+[WebCoreStatistics memoryStatistics]):
4016         Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
4017
4018 2010-09-09  Jer Noble  <jer.noble@apple.com>
4019
4020         Reviewed by Mark Rowe.
4021
4022         Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
4023         <rdar://problem/8412657>
4024
4025         * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
4026
4027 2010-09-08  Darin Adler  <darin@apple.com>
4028
4029         Reviewed by Adam Barth.
4030
4031         Move functions from Frame to Editor as planned
4032         https://bugs.webkit.org/show_bug.cgi?id=45218
4033
4034         * WebView/WebFrame.mm:
4035         (-[WebFrame _selectedString]):
4036         (-[WebFrame _firstRectForDOMRange:]):
4037         (-[WebFrame _markDOMRange]):
4038         (-[WebFrame _setTypingStyle:withUndoAction:]):
4039         * WebView/WebHTMLRepresentation.mm:
4040         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
4041         * WebView/WebHTMLView.mm:
4042         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
4043         (-[WebHTMLView toggleBaseWritingDirection:]):
4044         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
4045         (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
4046         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
4047         (-[WebHTMLView markedTextMatchesAreHighlighted]):
4048         * WebView/WebView.mm:
4049         (-[WebView setEditable:]):
4050         Changed call sites to use editor().
4051
4052 2010-09-08  MORITA Hajime  <morrita@google.com>
4053
4054         Reviewed by Ojan Vafai.
4055
4056         spellcheck does not check pasted text
4057         https://bugs.webkit.org/show_bug.cgi?id=40092
4058
4059         Implemented async spell-check APIs on WebEditorClient.
4060         The implementations are using [NSSpellChecker requestCheckingOfString]
4061         which is available only on Mac OS 10.6 or later.
4062
4063         Note that [NSSpellChecker requestCheckingOfString] could invoke
4064         the callback block on on of their worker thread, so we need to
4065         return the result to the main thread where WebCore is running.
4066         For that purpose, we made WebEditorSpellCheckResponder class.
4067
4068         Test: editing/spelling/spellcheck-pasted-text-001.html
4069
4070         * WebCoreSupport/WebEditorClient.h:
4071         * WebCoreSupport/WebEditorClient.mm:
4072         (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
4073         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
4074         (-[WebEditorSpellCheckResponder perform]): Added.
4075         (WebEditorClient::requestCheckingOfString): Added.
4076         * WebView/WebFramePrivate.h:
4077
4078 2010-09-08  MORITA Hajime  <morrita@google.com>
4079
4080         Reviewed by Tony Chang.
4081
4082         spelling underline gets lost on backspace
4083         https://bugs.webkit.org/show_bug.cgi?id=41423
4084
4085         Switched to use a anchorNode of the selection instead of a focused
4086         node for finer control of node selection in spellingNode():
4087         With the focused node, we cannot select other nodes but the first
4088         child of that node. In some case, we need to inspect these.
4089
4090         The API is only for LayoutTests, and the change is compatible for
4091         existing test cases.
4092
4093         * WebView/WebFrame.mm:
4094         (spellingNode):
4095
4096 2010-09-08  Adam Barth  <abarth@webkit.org>
4097
4098         Rubber-stamped by Eric Seidel.
4099
4100         Rename DocLoader to CachedResourceLoader because that's what it does.
4101
4102         * WebView/WebFrame.mm:
4103
4104 2010-09-07  Anders Carlsson  <andersca@apple.com>
4105
4106         Reviewed by Oliver Hunt.
4107
4108         Fix clang++ build.
4109
4110         * Misc/WebLocalizableStrings.h:
4111         Fix a struct/tag mismatch.
4112
4113         * WebView/WebDeviceOrientationProviderMock.mm:
4114         (-[WebDeviceOrientationProviderMock init]):
4115         Remove stray semicolon.
4116
4117         * WebView/WebViewData.h:
4118         Remove unused class forward declaration.
4119
4120 2010-09-07  Anders Carlsson  <andersca@apple.com>
4121
4122         Reviewed by Darin Adler.
4123
4124         <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
4125
4126         Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
4127
4128         * Configurations/Base.xcconfig:
4129
4130 2010-09-06  Adam Barth  <abarth@webkit.org>
4131
4132         Reviewed by Darin Adler.
4133
4134         Rename SecurityOrigin::canLoad to canDisplay
4135         https://bugs.webkit.org/show_bug.cgi?id=45214
4136
4137         Propagate name change.
4138
4139         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4140         (WebKit::NetscapePluginInstanceProxy::loadRequest):
4141         * Plugins/WebNetscapePluginStream.mm:
4142         (WebNetscapePluginStream::WebNetscapePluginStream):
4143         * Plugins/WebNetscapePluginView.mm:
4144         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
4145         * Plugins/WebPluginContainerCheck.mm:
4146         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
4147         * WebView/WebFrame.mm:
4148         (-[WebFrame _allowsFollowingLink:]):
4149
4150 2010-09-03  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4151
4152         Reviewed by Darin Adler.
4153
4154         Add NetworkingContext to avoid layer violations
4155         https://bugs.webkit.org/show_bug.cgi?id=42292
4156
4157         Add Mac's specific implementation of FrameNetworkingContext.
4158
4159         * WebCoreSupport/WebFrameLoaderClient.h:
4160         * WebCoreSupport/WebFrameLoaderClient.mm:
4161         * WebCoreSupport/WebFrameNetworkingContext.mm:
4162         (WebFrameNetworkingContext::needsSiteSpecificQuirks):
4163         (WebFrameNetworkingContext::localFileContentSniffingEnabled):
4164         (WebFrameNetworkingContext::scheduledRunLoopPairs):
4165         (WebFrameNetworkingContext::blockedError):
4166