2011-04-15 Shishir Agrawal <shishir@chromium.org>
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
2
3         Reviewed by James Robinson.
4
5         Add a flag to guard Page Visibility API changes.
6         https://bugs.webkit.org/show_bug.cgi?id=58464
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2011-04-15  Oliver Hunt  <oliver@apple.com>
11
12         GC allocate Structure
13         https://bugs.webkit.org/show_bug.cgi?id=58483
14
15         Rolling r83894 r83827 r83810 r83809 r83808 back in with
16         a workaround for the gcc bug seen by the gtk bots
17
18         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19         * Plugins/Hosted/ProxyInstance.mm:
20         (WebKit::ProxyRuntimeMethod::createStructure):
21         * Plugins/Hosted/ProxyRuntimeObject.h:
22         (WebKit::ProxyRuntimeObject::createStructure):
23
24 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
25
26         Reviewed by Dan Bernstein.
27
28         WebKit2: Password field input does not switch to ASCII-compatible source
29         https://bugs.webkit.org/show_bug.cgi?id=58583
30         <rdar://problem/9059651>
31
32         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
33         necessary logic, needed to return a nil text input context when in password fields.
34
35         * WebView/WebHTMLView.mm:
36         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
37         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
38         (-[WebHTMLView windowDidResignKey:]): Ditto.
39         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
40         because the first responder is still different an this point, so set a boolean variable to
41         let _updateSecureInputState know what's going on.
42         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
43         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
44         allowed input sources accorsing to current selection.
45         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
46
47 2011-04-15  Sam Weinig  <sam@webkit.org>
48
49         Reviewed by Maciej Stachowiak.
50
51         Make mac WebKit1 use the default localization strategy
52         https://bugs.webkit.org/show_bug.cgi?id=58628
53
54         * WebCoreSupport/WebPlatformStrategies.h:
55         * WebCoreSupport/WebPlatformStrategies.mm:
56         Remove the localization strategy code. The equivalent is now
57         in WebCore/platform/DefaultLocalizationStrategy.cpp.
58
59 2011-04-15  Anna Cavender  <annacc@chromium.org>
60
61         Reviewed by Eric Carlson.
62
63         Renaming TRACK feature define to VIDEO_TRACK
64         https://bugs.webkit.org/show_bug.cgi?id=53556
65
66         * Configurations/FeatureDefines.xcconfig:
67
68 2011-04-14  Pratik Solanki  <psolanki@apple.com>
69
70         Reviewed by David Kilzer.
71
72         Set minimum priority for fast lane connections
73         https://bugs.webkit.org/show_bug.cgi?id=58353
74
75         * WebCoreSupport/WebSystemInterface.mm:
76         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
77
78 2011-04-13  Sam Weinig  <sam@webkit.org>
79
80         Reviewed by Gavin Barraclough.
81
82         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
83         <rdar://problem/9260518>
84
85         * WebCoreSupport/WebSystemInterface.mm:
86         (InitWebCoreSystemInterface):
87         Initialize new WKSI functions.
88
89 2011-04-13  David Kilzer  <ddkilzer@apple.com>
90
91         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
92
93         Reviewed by Anders Carlsson.
94
95         Fixes the following warning with -Wcast-align enabled:
96
97             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
98                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
99                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
100
101         * Plugins/WebBasePluginPackage.mm:
102         (-[WebBasePluginPackage isNativeLibraryData:]): Added
103         COMPILE_ASSERT() to make sure our pointer math is valid.
104         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
105         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
106         casts with reinterpret_cast.
107
108 2011-04-12  Enrica Casucci  <enrica@apple.com>
109
110         Reviewed by Alexey Proskuryakov.
111
112         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
113         https://bugs.webkit.org/show_bug.cgi?id=58382
114         <rdar://problem/9239370>
115
116         Execution of some editing commands could trigger a call to selectedRange that
117         internally calls executeSavedKeypressCommands creating an infinite recursion.
118
119         * WebView/WebHTMLView.mm:
120         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
121         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
122
123 2011-04-12  Alice Liu  <alice.liu@apple.com>
124
125         Reviewed by Sam Weinig.
126
127         https://bugs.webkit.org/show_bug.cgi?id=58292
128         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
129
130         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
131         * WebView/WebPreferences.mm:
132         (+[WebPreferences initialize]): Initialize to false.
133         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
134         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
135         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
136         * WebView/WebView.mm:
137         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
138
139 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
140
141         Reviewed by Maciej Stachowiak.
142
143         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
144         https://bugs.webkit.org/show_bug.cgi?id=58175
145         <rdar://problem/9060555>
146
147         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
148         should be changed to match WebKit2.
149
150 2011-04-06  Timothy Hatcher  <timothy@apple.com>
151
152         Fix a bug where the context menu does not show in PDF documents if there is no
153         UI delegate or the UI delegate does not respond to the context menu selector.
154
155         https://webkit.org/b/57958
156
157         Reviewed by Darin Adler.
158
159         * WebView/WebView.mm:
160         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
161         if UIDelegate is nil or doesn't respond to the selector. So check that
162         here to distinguish between using defaultMenuItems or the delegate
163         really returning nil to say "no context menu".
164
165 2011-04-11  Jer Noble  <jer.noble@apple.com>
166
167         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
168
169         * WebView/WebFullScreenController.mm:
170         (-[WebFullScreenController enterFullscreen:]):
171
172 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
173
174         Reviewed by Oliver Hunt.
175
176         A few heap-related renames and file moves.
177         
178         WeakGCPtr<T> => Weak<T>
179         Global<T> => Strong<T>
180         collector/ => heap/
181         collector/* => heap/*
182         runtime/WeakGCPtr.h => heap/Weak.h
183         
184         (Eventually, even more files should move into the heap directory. Like
185         Heap.h and Heap.cpp, for example.)
186
187         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
188         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
189         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
190         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
191         (WebKit::NetscapePluginInstanceProxy::evaluate):
192         * WebView/WebScriptDebugger.h:
193
194 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
195
196         Reviewed by Darin Adler.
197
198         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
199         https://bugs.webkit.org/show_bug.cgi?id=58175
200         <rdar://problem/9060555>
201
202         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
203         should be changed to match WebKit2.
204
205 2011-04-08  Alpha Lam  <hclam@chromium.org>
206
207         Unreviewed, rolling out r83335.
208         http://trac.webkit.org/changeset/83335
209         https://bugs.webkit.org/show_bug.cgi?id=53556
210
211         GTK and QT bots are broken
212
213         * Configurations/FeatureDefines.xcconfig:
214
215 2011-04-07  Anna Cavender  <annacc@chromium.org>
216
217         Reviewed by Eric Carlson.
218
219         Setup ENABLE(TRACK) feature define
220         https://bugs.webkit.org/show_bug.cgi?id=53556
221
222         * Configurations/FeatureDefines.xcconfig:
223
224 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
225
226         Reviewed by Darin Adler.
227
228         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
229         https://bugs.webkit.org/show_bug.cgi?id=58128
230         <rdar://problem/9244553>
231         
232         The root of the problem here was an O(N^2) issue - each WebView,
233         upon having its preferences initialized, would broadcast a
234         notification that was listened to by all other WebViews sharing
235         its preferences.
236         
237         To maintain the API contract, I split the notification into two,
238         one that is for public API consumption, and the other which is for
239         internal use only. Changes that don't need to be picked up by
240         other WebViews broadcast the public notification only. And we
241         avoid WebView broadcasting a notification just to get itself to
242         update.
243
244         * Misc/WebIconDatabase.mm:
245         (-[WebIconDatabase _startUpIconDatabase]):
246         (-[WebIconDatabase _shutDownIconDatabase]):
247         * Plugins/WebBaseNetscapePluginView.mm:
248         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
249         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
250         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
251         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
252         * WebView/WebPreferences.mm:
253         (-[WebPreferences initWithIdentifier:]):
254         (-[WebPreferences _setStringValue:forKey:]):
255         (-[WebPreferences _setIntegerValue:forKey:]):
256         (-[WebPreferences _setFloatValue:forKey:]):
257         (-[WebPreferences _setBoolValue:forKey:]):
258         (-[WebPreferences _setLongLongValue:forKey:]):
259         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
260         (-[WebPreferences _postPreferencesChangedNotification]):
261         (-[WebPreferences _postPreferencesChangedAPINotification]):
262         * WebView/WebPreferencesPrivate.h:
263         * WebView/WebView.mm:
264         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
265         (-[WebView _preferencesChangedNotification:]):
266         (-[WebView _preferencesChanged:]):
267         (-[WebView setUsesPageCache:]):
268         (+[WebView initialize]):
269         (-[WebView setPreferences:]):
270         (-[WebView _keyboardUIMode]):
271         * WebView/WebViewInternal.h:
272
273 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
274
275         Revert ENABLE_TRACK patch due to compile failures.
276
277         * Configurations/FeatureDefines.xcconfig:
278
279 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
280
281         Reviewed by Anders Carlsson.
282
283         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
284         https://bugs.webkit.org/show_bug.cgi?id=58066
285         <rdar://problem/8965302>
286
287         * WebView/WebHTMLRepresentation.mm:
288         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
289         * WebView/WebHTMLView.mm:
290         (-[WebHTMLView attributedSubstringFromRange:]):
291         (-[WebHTMLView attributedString]):
292         (-[WebHTMLView selectedAttributedString]):
293         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
294
295 2011-04-07  Andy Estes  <aestes@apple.com>
296
297         Reviewed by Darin Adler.
298
299         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
300         not included when replying to an email.
301         https://bugs.webkit.org/show_bug.cgi?id=57794
302         
303         Outlook populates a reply message by creating an empty WebView and
304         using DOM API to populate the WebView's empty document with content
305         from the original message. It expects the initial empty document to
306         simply be "<html></html>", and it proceeds to dynamically create and
307         append a BODY node and add the original message content as a child of
308         that node. Outlook then takes the innerHTML of the frame's first body
309         element and copies it into a *new* document that is displayed and
310         edited in the reply message window.
311         
312         Due to implementing the HTML5 tree building algorithm in r64712,
313         initial empty documents went from being "<html></html>" to being
314         "<html><head></head><body></body></html>". Outlook still dynamically
315         creates a BODY node to parent the original message content, but this
316         BODY node duplicates the one created by the tree builder. When Outlook
317         then takes the innerHTML of the first body element to populate the
318         reply message window it gets the empty body element created by the
319         parser, not the one it created with the original message content.
320         
321         Fix this by injecting a user script into the initial empty document
322         that removes the HEAD and BODY nodes created by the parser. This
323         ensures that the BODY created by Outlook is the only BODY in the
324         document.
325
326         * Misc/OutlookQuirksUserScript.js: Added.
327         * WebView/WebView.mm:
328         (leakMailQuirksUserScriptContents):
329         (-[WebView _injectMailQuirksScript]):
330         (needsOutlookQuirksScript):
331         (leakOutlookQuirksUserScriptContents):
332         (-[WebView _injectOutlookQuirksScript]):
333         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
334
335 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
336
337         Reviewed by David Levin.
338
339         Add QUOTA build flag for unified quota API
340         https://bugs.webkit.org/show_bug.cgi?id=57918
341
342         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
343
344 2011-04-06  Robert Sesek  <rsesek@chromium.org>
345
346         Reviewed by Alexey Proskuryakov.
347
348         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
349         https://bugs.webkit.org/show_bug.cgi?id=54969
350
351         * WebView/WebFrame.mm:
352         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
353         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
354
355 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
356
357         Reviewed by Darin Adler.
358
359         Move attributedStringFromRange down to WebCore
360         https://bugs.webkit.org/show_bug.cgi?id=57905
361
362         * Misc/WebNSAttributedStringExtras.h: Removed.
363         * Misc/WebNSAttributedStringExtras.mm: Removed.
364         * WebView/WebHTMLRepresentation.mm:
365         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
366         * WebView/WebHTMLView.mm:
367         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
368         (-[WebHTMLView attributedSubstringFromRange:]):
369         (-[WebHTMLView attributedString]):
370         (-[WebHTMLView selectedAttributedString]):
371         * WebView/WebPDFView.mm:
372         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
373
374 2011-04-04  MORITA Hajime  <morrita@google.com>
375
376         Reviewed by Ryosuke Niwa.
377
378         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
379         https://bugs.webkit.org/show_bug.cgi?id=56085
380
381         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
382         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
383         for requestCheckingOfString method.
384         
385         * WebCoreSupport/WebEditorClient.h:
386         * WebCoreSupport/WebEditorClient.mm:
387         (toCoreTextCheckingResults):
388         (WebEditorClient::checkTextOfParagraph):
389         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
390         (-[WebEditorSpellCheckResponder perform]):
391         (WebEditorClient::requestCheckingOfString):
392         * WebView/WebFrame.mm:
393         (-[WebFrame markersForSelectionStartAsText]):
394         * WebView/WebFramePrivate.h:
395
396 2011-04-05  Anders Carlsson  <andersca@apple.com>
397
398         Didn't mean to land this.
399
400         * Plugins/WebNetscapePluginView.mm:
401         (-[WebNetscapePluginView getVariable:value:]):
402
403 2011-04-04  David Kilzer  <ddkilzer@apple.com>
404
405         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
406
407         Reviewed by Alexey Proskuryakov.
408
409         * WebCoreSupport/WebSystemInterface.mm:
410         (InitWebCoreSystemInterface): Added initialization for
411         wkSetHTTPPipeliningMaximumPriority().
412
413 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
414
415         Reviewed by Dan Bernstein.
416
417         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
418         https://bugs.webkit.org/show_bug.cgi?id=51230
419         <rdar://problem/8780989>
420
421         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
422         WebKits to WebCore, because WebKit shouldn't be smart.
423
424 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
425
426         Reviewed by Darin Adler.
427
428         REGRESSION: Assertion failure when executing a complex custom key binding
429         https://bugs.webkit.org/show_bug.cgi?id=57681
430
431         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
432         commands when they can't possibly change the result.
433
434 2011-04-01  Anders Carlsson  <andersca@apple.com>
435
436         Reviewed by Sam Weinig.
437
438         Shockwave plug-in doesn't accept mouse events
439         https://bugs.webkit.org/show_bug.cgi?id=57653
440         <rdar://problem/8483273>
441
442         Fix an unrelated bug found by the added test.
443
444         * Plugins/WebBaseNetscapePluginView.mm:
445         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
446         Make sure to always set destX and destY.
447
448 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
449
450         Reviewed by Darin Adler.
451
452         Make WebKit2 text input handling more like WebKit1
453         https://bugs.webkit.org/show_bug.cgi?id=57649
454
455         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
456         * WebView/WebHTMLView.mm:
457         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
458         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
459         (-[WebHTMLView characterIndexForPoint:]): Ditto.
460         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
461         (-[WebHTMLView selectedRange]): Ditto.
462         (-[WebHTMLView markedRange]): Ditto.
463         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
464         (-[WebHTMLView hasMarkedText]): Ditto.
465         (-[WebHTMLView unmarkText]): Ditto.
466         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
467         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
468         be able to call text input protocol methods from here (and we didn't even reset it back on
469         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
470         (-[WebHTMLView insertText:]): Ditto.
471
472 2011-04-01  Timothy Hatcher  <timothy@apple.com>
473
474         Make momentum scroll event latching work in WebKit2 on Mac.
475
476         <rdar://problem/8751861>
477
478         Reviewed by Darin Adler.
479
480         * WebCoreSupport/WebSystemInterface.mm:
481         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
482         * WebView/WebDynamicScrollBarsView.mm:
483         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
484
485 2011-03-31  Darin Adler  <darin@apple.com>
486
487         Reviewed by Anders Carlsson.
488
489         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
490         https://bugs.webkit.org/show_bug.cgi?id=26667
491
492         * WebView/WebHTMLView.mm:
493         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
494         nil rather than asserting that it is non-nil. One case where WebView will be nil
495         is when the frame is closed, but in any case where it is nil, the correct thing
496         to do is to not try to handle the style key.
497
498 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
499
500         Patch by John Harvey, reviewed and tweaked by me.
501
502         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
503
504         * Plugins/Hosted/WebTextInputWindowController.m:
505         (-[WebTextInputPanel _interpretKeyEvent:string:]):
506
507 2011-03-31  Evan Martin  <evan@chromium.org>
508
509         Reviewed by Eric Seidel.
510
511         <title> should support dir attribute
512         https://bugs.webkit.org/show_bug.cgi?id=50961
513
514         Update to new FrameLoaderClient interface.
515
516         * WebCoreSupport/WebFrameLoaderClient.h:
517         * WebCoreSupport/WebFrameLoaderClient.mm:
518         (WebFrameLoaderClient::dispatchDidReceiveTitle):
519         (WebFrameLoaderClient::setTitle):
520
521 2011-03-30  Dominic Cooney  <dominicc@google.com>
522
523         Reviewed by Dimitri Glazkov.
524
525         Adds layoutTestController.shadowRoot accessor to Mac DRT.
526         https://bugs.webkit.org/show_bug.cgi?id=57415
527
528         * DOM/WebDOMOperations.mm:
529         (-[DOMElement _shadowRoot:]):
530         * DOM/WebDOMOperationsPrivate.h:
531
532 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
533
534         Reviewed by Darin Adler.
535
536         WebHTMLView shouldn't resend noop: commands
537         https://bugs.webkit.org/show_bug.cgi?id=57504
538         <rdar://problem/9209390>
539
540         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
541         which we get e.g. when handling Cmd-key combos.
542
543 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
544
545         Reviewed by Darin Adler.
546
547         REGRESSION (r82320): Spacebar no longer pages down
548         https://bugs.webkit.org/show_bug.cgi?id=57423
549         <rdar://problem/9207702>
550
551         Also includes some unrelated cleanup that I had in my tree.
552
553         * WebView/WebHTMLView.mm:
554         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
555         being dispatched to the right frame.
556         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
557         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
558         Even if this specific command hasn't been handled, that doesn't nullify side effects from
559         previous commands.
560         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
561         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
562         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
563         going to look at it.
564
565 2011-03-30  Sam Weinig  <sam@webkit.org>
566
567         Reviewed by Brady Eidson.
568
569         WebKit2: Attempting to view css file from url causes it to download
570         <rdar://problem/9102611>
571         https://bugs.webkit.org/show_bug.cgi?id=57501
572
573         * WebView/WebHTMLRepresentation.h:
574         * WebView/WebHTMLRepresentation.mm:
575         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
576         * WebView/WebHTMLView.mm:
577         (+[WebHTMLView unsupportedTextMIMETypes]):
578         Re-factor unsupportedTextMIMETypes to pull from WebCore's
579         MIMETypeRegistry, so that the list can be shared with WebKit2.
580
581 2011-03-29  Beth Dakin  <bdakin@apple.com>
582
583         Reviewed by Maciej Stachowiak.
584
585         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
586         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
587         -and corresponding-
588         <rdar://problem/8665411>
589
590         * Misc/WebNSControlExtras.m:
591         (-[NSControl sizeToFitAndAdjustWindowHeight]):
592         * WebCoreSupport/WebChromeClient.mm:
593         (WebChromeClient::scaleFactor):
594         * WebView/WebHTMLView.mm:
595         (-[WebHTMLView viewDidMoveToWindow]):
596         (-[WebHTMLView attachRootLayer:]):
597
598 2011-03-29  Kent Tamura  <tkent@chromium.org>
599
600         Reviewed by Dimitri Glazkov.
601
602         Make validation message bubble testable
603         https://bugs.webkit.org/show_bug.cgi?id=57290
604
605         * WebView/WebView.mm:
606         (-[WebView _preferencesChangedNotification:]): Copy the private value of
607           the timer magnification to WebCore::Settings.
608         (-[WebView validationMessageTimerMagnification]): Added.
609         (-[WebView setValidationMessageTimerMagnification:]): Added.
610         * WebView/WebViewData.h: Declare a member for the timer magnification.
611         * WebView/WebViewData.mm:
612         (-[WebViewPrivate init]): Initialize the timer magnification.
613         * WebView/WebViewPrivate.h:
614           Declare a setter and a getter for the timer magnification.
615
616 2011-03-29  Kent Tamura  <tkent@chromium.org>
617
618         Reviewed by Dimitri Glazkov.
619
620         [Mac] Enable interactive-validation tests on Mac DRT
621         https://bugs.webkit.org/show_bug.cgi?id=57308
622
623         * WebView/WebView.mm:
624         (-[WebView _preferencesChangedNotification:]):
625           Convey a WebView flag for interactive validation to WebCore::Settings.
626         (-[WebView interactiveFormValidationEnabled]): Added.
627         (-[WebView setInteractiveFormValidationEnabled:]): Added.
628         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
629         * WebView/WebViewData.mm:
630         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
631         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
632
633 2011-03-29  Timothy Hatcher  <timothy@apple.com>
634
635         Update the order of the context menu to better match AppKit on Mac.
636
637         <rdar://problem/9054893>
638
639         Reviewed by John Sullivan.
640
641         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
642         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
643         * WebCoreSupport/WebPlatformStrategies.h:
644         * WebCoreSupport/WebPlatformStrategies.mm:
645         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
646
647 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
648
649         Reviewed by Darin Adler.
650
651         https://bugs.webkit.org/show_bug.cgi?id=57379
652         Clean up WK1 key event handling logic
653
654         No bugs knowingly fixed, but this makes the code more consistent.
655
656         * WebView/WebHTMLView.mm:
657         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
658         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
659         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
660         from other functions. We need to execute saved commands when an input method asks for current
661         state, because providing stale state could confuse it.
662         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
663         changes.
664         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
665         the answer would be stale.
666         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
667         (-[WebHTMLView selectedRange]): Ditto.
668         (-[WebHTMLView markedRange]): Ditto.
669         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
670         (-[WebHTMLView hasMarkedText]): Ditto.
671         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
672         operating on stale data. Also, updated for eventWasHandled renaming.
673         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
674         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
675         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
676         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
677         could have a noop: as one of its commands, although that's hardly practical).
678         Added the same "from input method" logic that we have in insertText: - I don't know of any
679         IMs that call this method, but we clearly need to execute it as part of IM processing when
680         there is marked text.
681         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
682         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
683         if current selection isn't editable. This is different from doCommandBySelector:, where we
684         need to give super class a chance to handle the event if our processing fails.
685         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
686         return value of _interpretKeyEvent is computed differently.
687
688 2011-03-28  Adele Peterson  <adele@apple.com>
689
690         Reviewed by Eric Seidel.
691
692         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
693         https://bugs.webkit.org/show_bug.cgi?id=57173
694
695         * WebView/WebFrame.mm:
696         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
697         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
698         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
699
700 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
701
702         Reviewed by Darin Adler.
703
704         https://bugs.webkit.org/show_bug.cgi?id=57260
705         Clean up text input code a little
706
707         * WebCoreSupport/WebEditorClient.mm:
708         (WebEditorClient::handleKeyboardEvent):
709         (WebEditorClient::handleInputMethodKeydown):
710         * WebView/WebHTMLViewInternal.h:
711         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
712         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
713         and also possibly saves resulting commands for later execution.
714
715         * WebView/WebHTMLView.mm:
716         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
717         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
718         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
719         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
720         because the first call resulted in no saved commands, becasue it's confusing and apparently
721         useless (I couldn't find any broken behavior).
722         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
723         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
724         (-[WebHTMLView doCommandBySelector:]): Ditto.
725         (-[WebHTMLView insertText:]): Ditto.
726
727         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
728         method on WebView.
729
730 2011-03-27  Jer Noble  <jer.noble@apple.com>
731
732         Reviewed by Maciej Stachowiak.
733
734         Full Screen: disable keyboard access by default
735         https://bugs.webkit.org/show_bug.cgi?id=56684
736
737         Take into account whether keyboard access was requested when deciding whether full
738         screen mode is supported.
739
740         * WebCoreSupport/WebChromeClient.h:
741         * WebCoreSupport/WebChromeClient.mm:
742         (WebChromeClient::supportsFullScreenForElement):
743         * WebView/WebView.mm:
744         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
745         * WebView/WebViewInternal.h:
746
747 2011-03-26  Jer Noble  <jer.noble@apple.com>
748
749         Reviewed by Eric Carlson.
750
751         Enable the Full Screen API by default in WebKit/mac and WebKit2
752         https://bugs.webkit.org/show_bug.cgi?id=56956
753
754         * WebView/WebPreferences.mm:
755         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
756
757 2011-03-25  Andy Estes  <aestes@apple.com>
758
759         Reviewed by Adele Peterson.
760
761         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
762         https://bugs.webkit.org/show_bug.cgi?id=49016
763
764         Update objectContentType() implementation to handle the
765         shouldPreferPlugInsForImages flag.
766
767         * WebCoreSupport/WebFrameLoaderClient.h:
768         * WebCoreSupport/WebFrameLoaderClient.mm:
769         (WebFrameLoaderClient::objectContentType):
770
771 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
772
773         Unreviewed, rolling out r81939.
774         http://trac.webkit.org/changeset/81939
775         https://bugs.webkit.org/show_bug.cgi?id=57084
776
777         Rolling out 81939, as it's causing a number of app cache test
778         failures. (Requested by jernoble on #webkit).
779
780         * WebView/WebView.mm:
781         (-[WebView _preferencesChangedNotification:]):
782
783 2011-03-23  Jer Noble  <jer.noble@apple.com>
784
785         Reviewed by Maciej Stachowiak.
786
787         Application Cache should save audio/ and video/ mime types as flat files
788         https://bugs.webkit.org/show_bug.cgi?id=53784
789         <rdar://problem/8932473>
790
791         No new tests.
792
793         Initialize the AppCache Total size quotas with the values for WebKitPreferences
794         upon startup.
795
796         * WebView/WebView.mm:
797         (-[WebView _preferencesChangedNotification:]):
798
799 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
800
801         Unreviewed, rolling out r81916 and r81917.
802         http://trac.webkit.org/changeset/81916
803         http://trac.webkit.org/changeset/81917
804         https://bugs.webkit.org/show_bug.cgi?id=57071
805
806         broke a test on platforms that do not have QuickTime installed
807         (Requested by estes on #webkit).
808
809         * WebCoreSupport/WebFrameLoaderClient.h:
810         * WebCoreSupport/WebFrameLoaderClient.mm:
811         (WebFrameLoaderClient::objectContentType):
812
813 2011-03-24  Andy Estes  <aestes@apple.com>
814
815         Reviewed by Darin Adler.
816
817         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
818         https://bugs.webkit.org/show_bug.cgi?id=49016
819
820         Update objectContentType() implementation to handle the
821         shouldPreferPlugInsForImages flag.
822
823         * WebCoreSupport/WebFrameLoaderClient.h:
824         * WebCoreSupport/WebFrameLoaderClient.mm:
825         (WebFrameLoaderClient::objectContentType):
826
827 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
828
829         Reviewed by Oliver Hunt.
830
831         Ensure that all compilation takes place within a dynamic global object scope
832         https://bugs.webkit.org/show_bug.cgi?id=57054
833
834         * WebView/WebScriptDebugDelegate.mm:
835         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
836
837 2011-03-24  Jia Pu  <jpu@apple.com>
838
839         Reviewed by Darin Adler.
840
841         Dismissed reversion suggestion is incorrectly learned.
842         https://bugs.webkit.org/show_bug.cgi?id=57039
843
844         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
845         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
846         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
847         incorrect automatic learning.
848
849         * WebCoreSupport/CorrectionPanel.mm:
850         (CorrectionPanel::dismissInternal):
851
852 2011-03-24  David Kilzer  <ddkilzer@apple.com>
853
854         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
855
856         Reviewed by Joseph Pecoraro.
857
858         * Plugins/WebPluginContainerPrivate.h: Changed value of
859         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
860
861 2011-03-23  Jia Pu  <jpu@apple.com>
862
863         Reviewed by Darin Adler.
864
865         Hook up new AppKit autocorrection UI with WK2.
866         https://bugs.webkit.org/show_bug.cgi?id=56055
867         <rdar://problem/8947463>
868
869         Please see WebCore/ChangeLog for detail.
870
871         * WebCoreSupport/CorrectionPanel.h: Added.
872         (CorrectionPanel::isShowing):
873         * WebCoreSupport/CorrectionPanel.mm: Added.
874         (correctionBubbleType):
875         (CorrectionPanel::CorrectionPanel):
876         (CorrectionPanel::~CorrectionPanel):
877         (CorrectionPanel::show):
878         (CorrectionPanel::dismiss):
879         (CorrectionPanel::dismissSoon):
880         (CorrectionPanel::dismissInternal):
881         (CorrectionPanel::recordAutocorrectionResponse):
882         * WebCoreSupport/WebEditorClient.h:
883         * WebCoreSupport/WebEditorClient.mm:
884         (WebEditorClient::WebEditorClient):
885         (WebEditorClient::showCorrectionPanel):
886         (WebEditorClient::dismissCorrectionPanel):
887         (WebEditorClient::dismissCorrectionPanelSoon):
888         (WebEditorClient::recordAutocorrectionResponse):
889         * WebView/WebView.mm:
890         (-[WebView handleCorrectionPanelResult:]):
891         * WebView/WebViewPrivate.h:
892
893 2011-03-23  Enrica Casucci  <enrica@apple.com>
894
895         Reviewed by Alexey Proskuryakov.
896
897         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
898         https://bugs.webkit.org/show_bug.cgi?id=56974
899         <rdar://problem/8284642>
900
901         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
902         where readSelectionFromPasteboard was accidentally removed.
903         This method and writeSelectionToPasteboard are needed to support Mac OS X
904         services.
905         
906         * WebView/WebHTMLView.mm:
907         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
908         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
909
910 2011-03-23  Brady Eidson  <beidson@apple.com>
911
912         Reviewed by Sam Weinig.
913
914         Change IconDatabase opening to allow for arbitrary filenames
915         https://bugs.webkit.org/show_bug.cgi?id=56977
916
917         * Misc/WebIconDatabase.mm:
918         (-[WebIconDatabase _startUpIconDatabase]):
919
920 2011-03-22  Anton D'Auria  <adauria@apple.com>
921
922         Reviewed by Alexey Proskuryakov.
923
924         Add +[WebApplicationCache getOriginsWithCache]
925         https://bugs.webkit.org/show_bug.cgi?id=56722
926
927         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
928
929         * WebCoreSupport/WebApplicationCache.h:
930         * WebCoreSupport/WebApplicationCache.mm:
931         (+[WebApplicationCache originsWithCache]):
932
933 2011-03-22  Anders Carlsson  <andersca@apple.com>
934
935         Reviewed by Sam Weinig.
936
937         OBJECT element with DivX source is always downloaded
938         https://bugs.webkit.org/show_bug.cgi?id=56879
939
940         * Plugins/WebBasePluginPackage.mm:
941         (-[WebBasePluginPackage getPluginInfoFromPLists]):
942         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
943         specifies multiple file extensions in a single element.
944
945 2011-03-22  Brady Eidson  <beidson@apple.com>
946
947         Reviewed by Sam Weinig.
948
949         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
950         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
951
952         Note that while the new client calls always come through on the main thread, our mechanisms to
953         route dispatches to the main thread are still valid and will still work.
954
955         Update to the new IconDatabaseClient interface:
956         * WebCoreSupport/WebIconDatabaseClient.h:
957         * WebCoreSupport/WebIconDatabaseClient.mm:
958         (WebIconDatabaseClient::didRemoveAllIcons):
959         (WebIconDatabaseClient::didImportIconURLForPageURL):
960         (WebIconDatabaseClient::didImportIconDataForPageURL):
961         (WebIconDatabaseClient::didChangeIconForPageURL):
962         (WebIconDatabaseClient::didFinishURLImport):
963
964 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
965
966         Reviewed by Simon Fraser.
967
968         Have WebKit push acceleratedDrawing preferences to settings
969         https://bugs.webkit.org/show_bug.cgi?id=56792
970
971         * WebView/WebView.mm:
972
973 2011-03-21  Nate Chapin  <japhet@chromium.org>
974
975         Reviewed by Brady Eidson.
976
977         Expose a preference to use caching quirks for QuickLook,
978         and use it if the QuickLook framework is loaded.
979
980         https://bugs.webkit.org/show_bug.cgi?id=38690
981
982         * WebView/WebPreferenceKeysPrivate.h:
983         * WebView/WebPreferences.mm:
984         (useQuickLookQuirks):
985         (+[WebPreferences initialize]):
986         (-[WebPreferences useQuickLookResourceCachingQuirks]):
987         * WebView/WebPreferencesPrivate.h:
988         * WebView/WebView.mm:
989         (-[WebView _preferencesChangedNotification:]):
990
991 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
992
993         Reviewed by Darin Adler.
994
995         AX: showContextMenu not working in WK2
996         https://bugs.webkit.org/show_bug.cgi?id=56734
997
998         Implement showContextMenu() so accessibility related code can call this
999         independent of whether WK1 or WK2 is running.
1000
1001         * WebCoreSupport/WebChromeClient.h:
1002         * WebCoreSupport/WebChromeClient.mm:
1003         (WebChromeClient::showContextMenu):
1004
1005 2011-03-21  Chang Shu  <cshu@webkit.org>
1006
1007         Reviewed by Alexey Proskuryakov.
1008
1009         REGRESSION (r79953): Can't type in MS Outlook 2011
1010         https://bugs.webkit.org/show_bug.cgi?id=56665
1011
1012         r79953 removed the WebView level editablity which is persistent no matter whether
1013         underlying document itself is changed and editability gets lost. The resolution is to
1014         set this WebView editable value to WebCore. This avoids the callback from WebCore to
1015         WebKit which was the main goal in r79953 to improve performance.
1016
1017         * WebView/WebView.mm:
1018         (-[WebView setEditable:]):
1019         (-[WebView isEditable]):
1020
1021 2011-03-19  Anton D'Auria  <adauria@apple.com>
1022
1023         Reviewed by Alexey Proskuryakov.
1024
1025         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1026         https://bugs.webkit.org/show_bug.cgi?id=56415
1027         
1028         Use new ApplicationCache API to delete all cache for an origin.
1029
1030         * WebCoreSupport/WebApplicationCache.h:
1031         * WebCoreSupport/WebApplicationCache.mm:
1032         (+[WebApplicationCache deleteOrigin:]):
1033
1034 2011-03-17  Brady Eidson  <beidson@apple.com>
1035
1036         Reviewed by Sam Weinig.
1037
1038         https://bugs.webkit.org/show_bug.cgi?id=56425
1039         More groundwork for WebKit2 IconDatabase
1040
1041         Update already-used function names:
1042         * Misc/WebIconDatabase.mm:
1043         (-[WebIconDatabase iconForURL:withSize:cache:]):
1044         (-[WebIconDatabase iconURLForURL:]):
1045         * WebView/WebView.mm:
1046         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1047
1048 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
1049
1050         Reviewed by Yury Semikhatsky.
1051
1052         Web Inspector: implement inspector session storage.
1053         https://bugs.webkit.org/show_bug.cgi?id=56643
1054
1055         * WebCoreSupport/WebInspectorClient.h:
1056         * WebCoreSupport/WebInspectorClient.mm:
1057         (WebInspectorClient::saveSessionSetting):
1058         (WebInspectorClient::loadSessionSetting):
1059         (WebInspectorFrontendClient::saveSessionSetting):
1060         (WebInspectorFrontendClient::loadSessionSetting):
1061         (-[WebInspectorWindowController inspectorClient]):
1062
1063 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
1064
1065         Reviewed by Oliver Hunt.
1066
1067         Fixed a leak seen on the buildbot.
1068
1069         * WebCoreSupport/WebInspectorClient.mm:
1070         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
1071
1072 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
1073
1074         Reviewed by Alexey Proskuryakov.
1075
1076         Logic error in -[WebHTMLView close]
1077         https://bugs.webkit.org/show_bug.cgi?id=56445
1078
1079         Page is always nil at this point, because [self _webView] is nil,
1080         so the conditional code is never run.
1081
1082         * WebView/WebHTMLView.mm:
1083         (-[WebHTMLView close]):
1084
1085 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
1086
1087         Reviewed by Darin Adler.
1088
1089         WK2: Need to propagate enhanced accessibility flag from UI -> web process
1090         https://bugs.webkit.org/show_bug.cgi?id=56379
1091
1092         * WebView/WebFrame.mm:
1093         (-[WebFrame accessibilityRoot]):
1094
1095 2011-03-15  Oliver Hunt  <oliver@apple.com>
1096
1097         Reviewed by Geoffrey Garen.
1098
1099         Make Structure creation require a JSGlobalData
1100         https://bugs.webkit.org/show_bug.cgi?id=56438
1101
1102         Mechanical change to make all Structure creation use a JSGlobalData&
1103
1104         * Plugins/Hosted/ProxyInstance.mm:
1105         (WebKit::ProxyRuntimeMethod::createStructure):
1106         * Plugins/Hosted/ProxyRuntimeObject.h:
1107         (WebKit::ProxyRuntimeObject::createStructure):
1108
1109 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1110
1111         Forgot to save a modification to this file when committing.
1112
1113         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
1114
1115 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
1116
1117         Reviewed by Darin Adler.
1118
1119         REGRESSION (WebKit2): keygen element doesn't work
1120         https://bugs.webkit.org/show_bug.cgi?id=56402
1121         <rdar://problem/9006545>
1122
1123         * WebCoreSupport/WebKeyGenerator.h:
1124         * WebCoreSupport/WebKeyGenerator.m: Removed.
1125         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
1126         (+[WebKeyGenerator sharedGenerator]):
1127         (toWebCertificateParseResult):
1128         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
1129         this misnamed and misplaced code for now.
1130
1131         * WebCoreSupport/WebPlatformStrategies.h:
1132         * WebCoreSupport/WebPlatformStrategies.mm:
1133         (WebPlatformStrategies::keygenMenuItem512):
1134         (WebPlatformStrategies::keygenMenuItem1024):
1135         (WebPlatformStrategies::keygenMenuItem2048):
1136         (WebPlatformStrategies::keygenKeychainItemName):
1137         Added strings used by keygen.
1138
1139         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
1140         pointer to a function used by keygen.
1141
1142         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
1143         initialized now.
1144
1145 2011-03-15  Beth Dakin  <bdakin@apple.com>
1146
1147         Reviewed by Simon Fraser.
1148
1149         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
1150
1151         New WebKitystemInterface function to force the scrollbars to flash
1152         * WebCoreSupport/WebSystemInterface.mm:
1153         (InitWebCoreSystemInterface):
1154
1155 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1156
1157         Reviewed by Tony Chang.
1158
1159         Autofilled form elements are assigned fixed background color but not text color
1160         https://bugs.webkit.org/show_bug.cgi?id=48382
1161
1162         * DOM/WebDOMOperations.mm:
1163         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
1164         * DOM/WebDOMOperationsPrivate.h:
1165
1166 2011-03-15  Adam Roben  <aroben@apple.com>
1167
1168         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
1169
1170         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
1171         WebStorageTrackerClient::dispatchDidModifyOrigin
1172
1173         Reviewed by Antti Koivisto.
1174
1175         * Storage/WebStorageTrackerClient.mm:
1176         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
1177         to us by dispatchDidModifyOrigin.
1178         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
1179         unnecessary cast.
1180
1181 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1182
1183         Reviewed by Darin Adler.
1184
1185         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1186         info into the headers rather than in export symbol definition files, but disable it on 
1187         all platforms initially so we can deal with port build issues one port at a time.
1188         
1189         https://bugs.webkit.org/show_bug.cgi?id=27551
1190
1191         * WebKitPrefix.h:
1192
1193 2011-03-14  Brady Eidson  <beidson@apple.com>
1194
1195         Reviewed by Anders Carlsson.
1196
1197         https://bugs.webkit.org/show_bug.cgi?id=56320
1198         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
1199
1200         * History/WebHistoryItem.mm:
1201         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
1202
1203 2011-03-13  Pratik Solanki  <psolanki@apple.com>
1204
1205         Reviewed by Brady Eidson.
1206
1207         Make adjustMIMETypeIfNecessary use CFNetwork directly
1208         https://bugs.webkit.org/show_bug.cgi?id=55912
1209
1210         * WebCoreSupport/WebSystemInterface.mm:
1211         (InitWebCoreSystemInterface): Support for new WKSI functions.
1212
1213 2011-03-12  Mark Rowe  <mrowe@apple.com>
1214
1215         Fix the 32-bit build.
1216
1217         * Carbon/CarbonWindowAdapter.mm:
1218         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
1219         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
1220
1221 2011-03-11  Brady Eidson  <beidson@apple.com>
1222
1223         Reviewed by Anders Carlsson
1224
1225         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
1226         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
1227
1228         * Misc/WebIconDatabase.mm:
1229         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
1230         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
1231         (importToWebCoreFormat):
1232
1233 2011-03-11  Anton D'Auria  <adauria@apple.com>
1234
1235         Reviewed and landed by Brady Eidson.
1236
1237         https://bugs.webkit.org/show_bug.cgi?id=51878
1238         Add WebKit1 API to view and delete local storage
1239
1240         * Storage/WebStorageManager.mm: Added.
1241         (+[WebStorageManager sharedWebStorageManager]):
1242         (-[WebStorageManager origins]):
1243         (-[WebStorageManager deleteAllOrigins]):
1244         (-[WebStorageManager deleteOrigin:]):
1245         (-[WebStorageManager syncLocalStorage]):
1246         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
1247         (storageDirectoryPath):
1248         (WebKitInitializeStorageIfNecessary):
1249         * Storage/WebStorageManagerInternal.h: Added.
1250         * Storage/WebStorageManagerPrivate.h: Added.
1251         * Storage/WebStorageTrackerClient.h: Added.
1252         * Storage/WebStorageTrackerClient.mm: Added.
1253         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
1254         (WebStorageTrackerClient::WebStorageTrackerClient):
1255         (WebStorageTrackerClient::~WebStorageTrackerClient):
1256         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
1257         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1258         * WebCoreSupport/WebSecurityOrigin.mm:
1259         (-[WebSecurityOrigin protocol]):
1260         (-[WebSecurityOrigin host]):
1261         (-[WebSecurityOrigin databaseIdentifier]):
1262         (-[WebSecurityOrigin domain]):
1263         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
1264         * WebCoreSupport/WebSecurityOriginPrivate.h:
1265         * WebKit.exp:
1266         * WebView/WebView.mm:
1267         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1268
1269 2011-03-10  Anders Carlsson  <andersca@apple.com>
1270
1271         Reviewed by Sam Weinig.
1272
1273         <rdar://problem/9117047>
1274         Don't paint more than 60 times per second even when scrolling
1275
1276         * WebView/WebClipView.mm:
1277         (-[WebClipView _immediateScrollToPoint:]):
1278
1279 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
1280
1281         Reviewed by Simon Fraser.
1282
1283         Plumb through settings for accelerated drawing for canvas
1284         https://bugs.webkit.org/show_bug.cgi?id=56039
1285
1286         * WebView/WebPreferenceKeysPrivate.h:
1287         * WebView/WebPreferences.mm:
1288         * WebView/WebPreferencesPrivate.h:
1289
1290 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
1291
1292         Reviewed by Tony Chang.
1293
1294         VisiblePosition's next and previous should take an enum instead of a boolean
1295         https://bugs.webkit.org/show_bug.cgi?id=56135
1296
1297         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
1298         StayInEditableContent.
1299
1300         * WebView/WebView.mm:
1301         (-[WebView _selectionIsAll]):
1302
1303 2011-03-09  Jessie Berlin  <jberlin@apple.com>
1304
1305         Reviewed by Adam Roben.
1306
1307         Use the Cookie Storage from the Private Browsing Storage Session directly
1308         https://bugs.webkit.org/show_bug.cgi?id=55986
1309
1310         * WebCoreSupport/WebSystemInterface.mm:
1311         (InitWebCoreSystemInterface):
1312
1313 2011-03-08  Darin Adler  <darin@apple.com>
1314
1315         Reviewed by Timothy Hatcher.
1316
1317         Promote a method used outside WebKit from internal to private
1318         https://bugs.webkit.org/show_bug.cgi?id=55949
1319
1320         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
1321         Minor tweak, not directly related to the rest of this patch.
1322
1323         * WebView/WebFrame.mm:
1324         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
1325         this method from the internal category into the private category.
1326         Streamlined the code a bit.
1327
1328         * WebView/WebFrameInternal.h: Removed _computePageRects method.
1329         * WebView/WebFramePrivate.h: Added _computePageRects method.
1330
1331 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1332
1333         Reviewed by Darin Adler.
1334
1335         selectionHasStyle and selectionStartHasStyle should use EditingStyle
1336         https://bugs.webkit.org/show_bug.cgi?id=55902
1337
1338         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
1339
1340         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
1341         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
1342
1343 2011-03-07  Dan Bernstein  <mitz@apple.com>
1344
1345         LLVM Compiler build fix.
1346
1347         * WebCoreSupport/WebEditorClient.mm:
1348         (WebEditorClient::checkGrammarOfString):
1349
1350 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1351
1352         Reviewed by Beth Dakin.
1353
1354         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1355         https://bugs.webkit.org/show_bug.cgi?id=55706
1356
1357         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
1358         returns the scroll bar objects).
1359         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
1360         will expect that as its child, instead of the WebCore ScrollView object.
1361
1362         * WebView/WebDynamicScrollBarsView.mm:
1363         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
1364         * WebView/WebFrame.mm:
1365         (-[WebFrame accessibilityRoot]):
1366
1367 2011-03-07  Sam Weinig  <sam@webkit.org>
1368
1369         Reviewed by Anders Carlsson.
1370
1371         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1372         https://bugs.webkit.org/show_bug.cgi?id=55827
1373
1374         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1375         and pass the entire response, instead of just the MIMEType.
1376
1377         * WebCoreSupport/WebFrameLoaderClient.h:
1378         * WebCoreSupport/WebFrameLoaderClient.mm:
1379         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1380
1381 2011-03-06  Dan Bernstein  <mitz@apple.com>
1382
1383         LLVM Compiler build fix.
1384
1385         * DOM/WebDOMOperations.mm:
1386         (-[DOMHTMLInputElement _setValueForUser:]):
1387
1388 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1389
1390         Reviewed by Sam Weinig.
1391
1392         WebKit2: Use CFNetwork Sessions API.
1393         https://bugs.webkit.org/show_bug.cgi?id=55435.
1394
1395         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1396         Private Browsing Storage Session.
1397
1398         * WebCoreSupport/WebSystemInterface.mm:
1399         (InitWebCoreSystemInterface):
1400         Add support for using the new WKSI functions in WebCore.
1401
1402 2011-03-05  Ilya Sherman  <isherman@chromium.org>
1403
1404         Reviewed by Darin Adler.
1405
1406         HTMLInputElement::setValue() should schedule change event when the element is focused
1407         In service of https://code.google.com/p/chromium/issues/detail?id=42716
1408         https://bugs.webkit.org/show_bug.cgi?id=53160
1409
1410         * DOM/WebDOMOperations.mm:
1411         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
1412         * DOM/WebDOMOperationsPrivate.h:
1413         * WebView/WebViewInternal.h:
1414
1415 2011-03-04  Jia Pu  <jpu@apple.com>
1416
1417         Reviewed by Darin Adler.
1418
1419         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
1420         https://bugs.webkit.org/show_bug.cgi?id=55717
1421         <rdar://problem/9018127>
1422
1423         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
1424         is already in window coordinate. We don't need to do further conversion anymore.
1425
1426         * WebCoreSupport/WebEditorClient.mm:
1427         (WebEditorClient::showCorrectionPanel):
1428
1429 2011-03-04  Jessie Berlin  <jberlin@apple.com>
1430
1431         Reviewed by Maciej Stachowiak.
1432
1433         WebKit2: Use CFNetwork Sessions API.
1434         https://bugs.webkit.org/show_bug.cgi?id=55435.
1435
1436         When Private Browsing is enabled, get the cached url response from the cache associated with
1437         the Private Browsing Storage Session.
1438
1439         * WebView/WebView.mm:
1440         (-[WebView _cachedResponseForURL:]):
1441
1442 2011-03-03  Anders Carlsson  <andersca@apple.com>
1443
1444         Reviewed by Sam Weinig.
1445
1446         Get rid of Page::globalHistoryItem
1447         https://bugs.webkit.org/show_bug.cgi?id=55738
1448
1449         * WebCoreSupport/WebFrameLoaderClient.h:
1450         * WebCoreSupport/WebFrameLoaderClient.mm:
1451         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1452         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
1453     
1454         * WebView/WebView.mm:
1455         (-[WebView _globalHistoryItem]):
1456         (-[WebView _setGlobalHistoryItem:]):
1457         Set _globalHistoryItem ivar.
1458
1459         * WebView/WebViewData.h:
1460         * WebView/WebViewData.mm:
1461         Add _globalHistoryItem ivar.
1462
1463 2011-03-03  Brady Eidson  <beidson@apple.com>
1464
1465         Reviewed by Darin Adler.
1466
1467         https://bugs.webkit.org/show_bug.cgi?id=55721
1468         Global IconDatabase should be returned by reference, not as a pointer
1469
1470         * Misc/WebCoreStatistics.mm:
1471         (+[WebCoreStatistics iconPageURLMappingCount]):
1472         (+[WebCoreStatistics iconRetainedPageURLCount]):
1473         (+[WebCoreStatistics iconRecordCount]):
1474         (+[WebCoreStatistics iconsWithDataCount]):
1475         * Misc/WebIconDatabase.mm:
1476         (-[WebIconDatabase init]):
1477         (-[WebIconDatabase iconForURL:withSize:cache:]):
1478         (-[WebIconDatabase iconURLForURL:]):
1479         (-[WebIconDatabase defaultIconWithSize:]):
1480         (-[WebIconDatabase retainIconForURL:]):
1481         (-[WebIconDatabase releaseIconForURL:]):
1482         (-[WebIconDatabase isEnabled]):
1483         (-[WebIconDatabase setEnabled:]):
1484         (-[WebIconDatabase removeAllIcons]):
1485         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
1486         (-[WebIconDatabase _startUpIconDatabase]):
1487         (-[WebIconDatabase _applicationWillTerminate:]):
1488         (-[WebIconDatabase _resetCachedWebPreferences:]):
1489         (importToWebCoreFormat):
1490         * WebView/WebView.mm:
1491         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1492
1493 2011-03-03  Jessie Berlin  <jberlin@apple.com>
1494
1495         Reviewed by Adam Roben.
1496
1497         WebKit2: Use CFNetwork Sessions API.
1498         https://bugs.webkit.org/show_bug.cgi?id=55435.
1499
1500         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
1501
1502         * WebCoreSupport/WebSystemInterface.mm:
1503         (InitWebCoreSystemInterface):
1504         Support using WKCopyRequestWithStorageSession in WebCore.
1505
1506 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1507
1508         Reviewed by Darin Adler.
1509
1510         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1511         https://bugs.webkit.org/show_bug.cgi?id=55633
1512         <rdar://problem/8963023>
1513
1514         * WebCoreSupport/WebChromeClient.h:
1515         * WebCoreSupport/WebChromeClient.mm:
1516         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
1517
1518         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1519         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
1520         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
1521         so I've preserved it.
1522
1523 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1524
1525         Rubber-stamped by Dan Bernstein.
1526
1527         Fix crashes in private browsing tests in WK1 on Snow Leopard.
1528
1529         * WebCoreSupport/WebSystemInterface.mm:
1530         (InitWebCoreSystemInterface):
1531         Put the INIT call for wkCreatePrivateStorageSession outside of the
1532         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
1533         guards.
1534
1535 2011-03-02  Jessie Berlin  <jberlin@apple.com>
1536
1537         Reviewed by Adam Roben.
1538
1539         WebKit2: Use CFNetwork Sessions API.
1540         https://bugs.webkit.org/show_bug.cgi?id=55435.
1541
1542         Add the ability to create a Private Browsing Storage Session.
1543
1544         * WebCoreSupport/WebSystemInterface.mm:
1545         (InitWebCoreSystemInterface):
1546         Support calling wkCreatePrivateStorageSession from WebCore.
1547
1548 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
1549
1550         Reviewed by David Levin.
1551
1552         Add feature define for data transfer items
1553         https://bugs.webkit.org/show_bug.cgi?id=55510
1554
1555         * Configurations/FeatureDefines.xcconfig:
1556
1557 2011-03-02  Sam Weinig  <sam@webkit.org>
1558
1559         Reviewed by Anders Carlsson.
1560
1561         Fix remaining localization issues by piping all localized strings through WebCore's
1562         localization bottleneck.
1563         <rdar://problem/8728860>
1564
1565         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1566         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1567         * Misc/WebKitErrors.m:
1568         * Misc/WebLocalizableStringsInternal.h: Added.
1569         * Misc/WebLocalizableStringsInternal.mm: Added.
1570         (WebLocalizedStringInternal):
1571         * Panels/WebAuthenticationPanel.m:
1572         (-[WebAuthenticationPanel setUpForChallenge:]):
1573         * Plugins/Hosted/NetscapePluginHostManager.mm:
1574         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1575         * WebCoreSupport/WebEditorClient.mm:
1576         (undoNameForEditAction):
1577         * WebCoreSupport/WebInspectorClient.mm:
1578         (WebInspectorFrontendClient::updateWindowTitle):
1579         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1580         * WebCoreSupport/WebKeyGenerator.m:
1581         (-[WebKeyGenerator strengthMenuItemTitles]):
1582         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
1583         * WebCoreSupport/WebPlatformStrategies.mm:
1584         * WebView/WebHTMLView.mm:
1585         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1586         * WebView/WebPDFView.mm:
1587         (-[WebPDFView menuForEvent:]):
1588
1589 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
1590
1591         Reviewed by Adam Roben.
1592
1593         Part of WebKit2: Need a way to send notifications to client when cookies change
1594         https://bugs.webkit.org/show_bug.cgi?id=55427
1595         <rdar://problem/9056027>
1596         
1597         Add stubs for CookiesStrategy on Mac WebKit1.
1598
1599         * WebCoreSupport/WebPlatformStrategies.h:
1600         * WebCoreSupport/WebPlatformStrategies.mm:
1601         (WebPlatformStrategies::createCookiesStrategy):
1602         (WebPlatformStrategies::notifyCookiesChanged):
1603
1604 2011-03-01  Philippe Normand  <pnormand@igalia.com>
1605
1606         Reviewed by Eric Carlson.
1607
1608         [GStreamer] support in mac video fullscreen controller
1609         https://bugs.webkit.org/show_bug.cgi?id=52280
1610
1611         Factored the code to configure the video overlay in a new private
1612         method of the controller and added GStreamer support to it.
1613
1614         * WebView/WebVideoFullscreenController.h:
1615         * WebView/WebVideoFullscreenController.mm:
1616         (-[WebVideoFullscreenController setupVideoOverlay:]):
1617         (-[WebVideoFullscreenController windowDidLoad]):
1618         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
1619         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1620
1621 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
1622
1623         Reviewed by Timothy Hatcher.
1624
1625         All Console Messages should be passed to ChromeClients.
1626         https://bugs.webkit.org/show_bug.cgi?id=54926
1627
1628         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
1629         which supersedes -webView:addMessageToConsole if it exists. The new delegate
1630         does not filter to only JavaScript originated console messages. The old
1631         delegate is left around for clients that expect filtered messages, like
1632         DashCode and older versions of Safari.
1633
1634         The dictionary message passed to the delegate now includes more information
1635         about the message source, type, and level.
1636
1637         * WebCoreSupport/WebChromeClient.mm:
1638         (stringForMessageSource):
1639         (stringForMessageType):
1640         (stringForMessageLevel):
1641         (WebChromeClient::addMessageToConsole):
1642         * WebView/WebUIDelegatePrivate.h:
1643
1644 2011-03-01  Levi Weintraub  <leviw@chromium.org>
1645
1646         Reviewed by Ryosuke Niwa.
1647
1648         Stop instantiating legacy editing Positions in VisiblePosition
1649         https://bugs.webkit.org/show_bug.cgi?id=52919
1650
1651         Changing usage of legacy VisiblePosition constructor. Since we were dealing
1652         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
1653
1654         * WebView/WebFrame.mm:
1655         (-[WebFrame _caretRectAtPosition:affinity:]):
1656         * WebView/WebFrameInternal.h:
1657         * WebView/WebTextCompletionController.mm:
1658         (-[WebTextCompletionController doCompletion]):
1659
1660 2011-03-01  Sam Weinig  <sam@webkit.org>
1661
1662         Reviewed by Timothy Hatcher.
1663
1664         WebKit2 needs to be made localizable
1665         https://bugs.webkit.org/show_bug.cgi?id=55483
1666
1667         * WebCoreSupport/WebPlatformStrategies.mm:
1668         Use WebCore's localizedString function instead of WebLocalizableStrings
1669         since WebCore is now responsible for localization.
1670
1671 2011-02-25 Steve Block <steveblock@google.com>
1672
1673         Reviewed by Jeremy Orlow.
1674
1675         Bridge.h should not include BridgeJSC.h
1676         https://bugs.webkit.org/show_bug.cgi?id=55212
1677
1678         Include BridgeJSC.h directly instead.
1679
1680         * Plugins/Hosted/ProxyInstance.h:
1681         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1682
1683 2011-02-28  Chang Shu  <cshu@webkit.org>
1684
1685         Reviewed by Ryosuke Niwa.
1686
1687         Remove the support of Frame::isContentEditable and its dependencies.
1688         https://bugs.webkit.org/show_bug.cgi?id=54292
1689
1690         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
1691
1692         * WebCoreSupport/WebEditorClient.h:
1693         * WebCoreSupport/WebEditorClient.mm:
1694         * WebView/WebView.mm:
1695         (-[WebView setEditable:]):
1696         (-[WebView isEditable]):
1697         * WebView/WebViewData.h:
1698
1699 2011-02-28  Oliver Hunt  <oliver@apple.com>
1700
1701         Reviewed by Gavin Barraclough.
1702
1703         Make ScopeChainNode GC allocated
1704         https://bugs.webkit.org/show_bug.cgi?id=55283
1705
1706         More updates for the absence of the ScopeChain class
1707
1708         * WebView/WebScriptDebugDelegate.mm:
1709         (-[WebScriptCallFrame scopeChain]):
1710
1711 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1712
1713         Reviewed by Pavel Feldman.
1714
1715         DumpRenderTree should reset frame opener between tests.
1716         https://bugs.webkit.org/show_bug.cgi?id=54874
1717
1718         Added clearOpener method to WebFramePrivate.
1719
1720         * WebView/WebFrame.mm:
1721         (-[WebFrame _clearOpener]):
1722         * WebView/WebFramePrivate.h:
1723
1724 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1725
1726         Unreviewed, rolling out r79764.
1727         http://trac.webkit.org/changeset/79764
1728         https://bugs.webkit.org/show_bug.cgi?id=55295
1729
1730         "broke Chromium builds" (Requested by rniwa on #webkit).
1731
1732         * WebView/WebFrame.mm:
1733         * WebView/WebFramePrivate.h:
1734
1735 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
1736
1737         Reviewed by David Kilzer.
1738
1739         https://bugs.webkit.org/show_bug.cgi?id=48781
1740
1741         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
1742
1743         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
1744         should paint the default broken image when an image fails to load or decode.  The method also passes the
1745         URL of the failed image.
1746
1747         * WebCoreSupport/WebFrameLoaderClient.h:
1748         * WebCoreSupport/WebFrameLoaderClient.mm:
1749         (WebFrameLoaderClient::shouldPaintBrokenImage):
1750         * WebView/WebDelegateImplementationCaching.h:
1751         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
1752         (CallResourceLoadDelegateReturningBoolean):
1753         * WebView/WebResourceLoadDelegatePrivate.h:
1754         * WebView/WebView.mm:
1755         (-[WebView _cacheResourceLoadDelegateImplementations]):
1756
1757 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
1758
1759         Reviewed by Pavel Feldman.
1760
1761         DumpRenderTree should reset frame opener between tests.
1762         https://bugs.webkit.org/show_bug.cgi?id=54874
1763
1764         Added clearOpener method to WebFramePrivate.
1765
1766         * WebView/WebFrame.mm:
1767         (-[WebFrame _clearOpener]):
1768         * WebView/WebFramePrivate.h:
1769
1770 2011-02-25  Mark Rowe  <mrowe@apple.com>
1771
1772         <rdar://problem/8902546> Build fix.
1773
1774         * Misc/QuickDrawCompatibility.h:
1775
1776 2011-02-24  Anders Carlsson  <andersca@apple.com>
1777
1778         Fix clang build.
1779
1780         * WebCoreSupport/WebKeyGenerator.m:
1781         (toWebCertificateParseResult):
1782         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
1783         * WebView/WebTextCompletionController.mm:
1784
1785 2011-02-24  Peter Kasting  <pkasting@google.com>
1786
1787         Reviewed by Eric Seidel.
1788
1789         Drop the "U; " encryption level from the User Agent string.
1790         https://bugs.webkit.org/show_bug.cgi?id=54566
1791
1792         * WebView/WebView.mm:
1793         (+[WebView _standardUserAgentWithApplicationName:]):
1794
1795 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
1796
1797         Unreviewed, rolling out r79570.
1798         http://trac.webkit.org/changeset/79570
1799         https://bugs.webkit.org/show_bug.cgi?id=54874
1800
1801         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
1802         was not updated
1803
1804         * WebView/WebFrame.mm:
1805         * WebView/WebFramePrivate.h:
1806
1807 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
1808
1809         Reviewed by Alexey Proskuryakov.
1810
1811         DumpRenderTree should reset frame opener between tests.
1812         https://bugs.webkit.org/show_bug.cgi?id=54874
1813
1814         Added clearOpener method to WebFramePrivate.
1815
1816         * WebView/WebFrame.mm:
1817         (-[WebFrame _clearOpener]):
1818         * WebView/WebFramePrivate.h:
1819
1820 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1821
1822         Reviewed by Alexey Proskuryakov.
1823
1824         Drop the language tag part from the User Agent string
1825         https://bugs.webkit.org/show_bug.cgi?id=54560
1826
1827         * WebView/WebView.mm:
1828         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
1829         language tag part.
1830
1831 2011-02-22  Brady Eidson  <beidson@apple.com>
1832
1833         Reviewed by Anders Carlsson.
1834
1835         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
1836         API to view and delete Application Cache data by origin.
1837
1838         * WebCoreSupport/WebApplicationCache.mm:
1839         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
1840
1841 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1842
1843         Reviewed by Kent Tamura.
1844
1845         Rename Position::node() to Position::deprecatedNode()
1846         https://bugs.webkit.org/show_bug.cgi?id=54622
1847
1848         * WebView/WebFrame.mm:
1849         (-[WebFrame _smartDeleteRangeForProposedRange:]):
1850
1851 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
1852
1853         Reviewed by Kent Tamura.
1854
1855         Rename Position::node() to Position::deprecatedNode()
1856         https://bugs.webkit.org/show_bug.cgi?id=54622
1857         
1858         Done the rename.
1859
1860         * WebView/WebFrame.mm:
1861         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
1862         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
1863
1864 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
1865
1866         Reviewed by Sam Weinig.
1867
1868         Bug 54786 - Devirtualize JSCell::classInfo()
1869
1870         Instead of making a virtual function call, add a pointer to the ClassInfo
1871         onto Structure.
1872
1873         This removes a virtual function call, and paves the way towards removing all
1874         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
1875         (these should be able to move onto ClassInfo).
1876
1877         Calls to Structure::create must now pass a pointer to the ClassInfo for the
1878         structure. All objects now have a ClassInfo pointer, non-object cell types
1879         still do not.
1880
1881         Changes are most mechanical, involving three steps:
1882             * Remove virtual classInfo() methods.
1883             * Add &s_info parameter to calls to Structure::create.
1884             * Rename ClassInfo static members on classes from 'info' to 's_info',
1885               for consistency.
1886
1887         * Plugins/Hosted/ProxyInstance.mm:
1888         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
1889         (WebKit::ProxyRuntimeMethod::createStructure):
1890         * Plugins/Hosted/ProxyRuntimeObject.h:
1891         (WebKit::ProxyRuntimeObject::createStructure):
1892         * Plugins/Hosted/ProxyRuntimeObject.mm:
1893         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1894         * WebView/WebView.mm:
1895         (aeDescFromJSValue):
1896
1897 2011-02-19  Brian Ryner  <bryner@chromium.org>
1898
1899         Reviewed by Adam Barth.
1900
1901         Add missing #include of DocumentLoader.h, needed since the transitive
1902         include through Document.h is removed.
1903         https://bugs.webkit.org/show_bug.cgi?id=50489
1904
1905         * WebView/WebFrame.mm:
1906
1907 2011-02-19  Charlie Reis  <creis@chromium.org>
1908
1909         Reviewed by Mihai Parparita.
1910
1911         Ensure loading has stopped in HistoryController::goToItem
1912         https://bugs.webkit.org/show_bug.cgi?id=54517
1913
1914         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
1915
1916         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
1917
1918         * WebCoreSupport/WebFrameLoaderClient.mm:
1919         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
1920         * WebCoreSupport/WebFrameLoaderClient.h:
1921
1922 2011-02-16  David Hyatt  <hyatt@apple.com>
1923
1924         Reviewed by Dan Bernstein.
1925
1926         https://bugs.webkit.org/show_bug.cgi?id=54244
1927         
1928         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
1929         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
1930         
1931         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
1932         been changed as well.
1933         
1934         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
1935         
1936         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
1937         
1938         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
1939         still have a precise floating point position.
1940
1941         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
1942         be rounding justification spacing in their font code.
1943
1944         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
1945
1946         * Misc/WebKitNSStringExtras.mm:
1947         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
1948         (-[NSString _web_widthWithFont:]):
1949
1950 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
1951
1952         Reviewed by Adam Roben.
1953
1954         HTML5 <details> and <summary>: localized text
1955         https://bugs.webkit.org/show_bug.cgi?id=54260
1956
1957         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
1958         provide the default label to be used by a <details> tag that has no <summary> child.
1959
1960         * WebCoreSupport/WebPlatformStrategies.h:
1961         * WebCoreSupport/WebPlatformStrategies.mm:
1962         (WebPlatformStrategies::defaultDetailsSummaryText):
1963
1964 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
1965
1966         Reviewed by Simon Fraser.
1967
1968         Allow acceleratesDrawing for WebKit2
1969         https://bugs.webkit.org/show_bug.cgi?id=54511
1970
1971         Plumb through preference for accelerated drawing.
1972         
1973         * WebView/WebPreferenceKeysPrivate.h:
1974         * WebView/WebPreferences.mm:
1975         (+[WebPreferences initialize]):
1976         (-[WebPreferences acceleratedDrawingEnabled]):
1977         (-[WebPreferences setAcceleratedDrawingEnabled:]):
1978         * WebView/WebPreferencesPrivate.h:
1979
1980 2011-02-15  David Kilzer  <ddkilzer@apple.com>
1981
1982         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
1983
1984         Reviewed by Darin Adler.
1985
1986         * WebView/WebDynamicScrollBarsView.h:
1987         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
1988         declaration.
1989         * WebView/WebDynamicScrollBarsView.mm:
1990         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
1991         implementation into correct category.
1992         * WebView/WebDynamicScrollBarsViewInternal.h:
1993         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
1994         declaration.
1995         * WebView/WebHTMLView.mm: Included
1996         WebDynamicScrollBarsViewInternal.h instead of
1997         WebDynamicScrollBarsView.h.
1998
1999 2011-02-14  Oliver Hunt  <oliver@apple.com>
2000
2001         Reviewed by Gavin Barraclough and Geoff Garen.
2002
2003         Refactor handles and weak pointers to become nicer and more automatic
2004         https://bugs.webkit.org/show_bug.cgi?id=54415
2005
2006         Update to use Global<> instead of ProtectedPtr, and refactored slightly
2007         to get global data to places it's needed for when we're assigning to
2008         Global<>s
2009
2010         * ForwardingHeaders/collector/handles/Global.h: Added.
2011         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2012         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2013         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
2014         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2015         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
2016         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2017         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
2018         (WebKit::NetscapePluginInstanceProxy::evaluate):
2019         (WebKit::NetscapePluginInstanceProxy::invoke):
2020         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2021         (WebKit::NetscapePluginInstanceProxy::construct):
2022         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
2023         * WebView/WebScriptDebugger.h:
2024         * WebView/WebScriptDebugger.mm:
2025         (WebScriptDebugger::WebScriptDebugger):
2026
2027 2011-02-15  Jia Pu  <jpu@apple.com>
2028
2029         Reviewed by Darin Adler.
2030
2031         Autocorrection should respect undo.
2032         https://bugs.webkit.org/show_bug.cgi?id=52221
2033         <rdar://problem/8663399>
2034
2035         Please see WebCore/ChangeLog for detailed description.
2036
2037         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
2038
2039         * WebCoreSupport/WebEditorClient.mm:
2040         (WebEditorClient::recordAutocorrectionResponse): Ditto.
2041
2042         * WebView/WebFrame.mm:
2043         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2044              Adopted new signature of ReplaceSelectionCommand::create().
2045
2046 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2047
2048         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
2049
2050         Reviewed by Darin Adler.
2051
2052         * WebView/WebDynamicScrollBarsView.h:
2053         * WebView/WebDynamicScrollBarsView.mm:
2054         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
2055         -inProgramaticScroll.
2056         * WebView/WebHTMLView.mm:
2057         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
2058
2059 2011-02-15  Kenneth Russell  <kbr@google.com>
2060
2061         Reviewed by Darin Fisher.
2062
2063         Allow controlling minimum DOMTimer interval on a per-page basis
2064         https://bugs.webkit.org/show_bug.cgi?id=54312
2065
2066         Added needed methods to implement LayoutTestController's new
2067         setMinimumTimerInterval method.
2068
2069         * WebView/WebView.mm:
2070         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2071         (+[WebView _defaultMinimumTimerInterval]):
2072         (-[WebView _setMinimumTimerInterval:]):
2073         * WebView/WebViewPrivate.h:
2074
2075 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
2076
2077         Reviewed by Oliver Hunt.
2078
2079         A little more encapsulation for the heap: Removed CollectorHeapIterator
2080         https://bugs.webkit.org/show_bug.cgi?id=54298
2081
2082         * Misc/WebCoreStatistics.mm:
2083         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2084         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
2085
2086 2011-02-10  Nate Chapin  <japhet@chromium.org>
2087
2088         Reviewed by Adam Barth.
2089
2090         Update calls to DocumentWriter.
2091         https://bugs.webkit.org/show_bug.cgi?id=50489
2092
2093         * WebView/WebFrame.mm:
2094         (-[WebFrame _canProvideDocumentSource]):
2095
2096 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
2097
2098         Reviewed by Anders Carlsson.
2099
2100         AX: AX needs to stop using WebCoreViewFactory
2101         https://bugs.webkit.org/show_bug.cgi?id=54153
2102
2103         * WebCoreSupport/WebSystemInterface.mm:
2104         (InitWebCoreSystemInterface):
2105
2106 2011-02-10  Peter Varga  <pvarga@webkit.org>
2107
2108         Reviewed by Csaba Osztrogonác.
2109
2110         Remove PCRE source from trunk
2111         https://bugs.webkit.org/show_bug.cgi?id=54188
2112
2113         * ForwardingHeaders/pcre/pcre.h: Removed.
2114
2115 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
2116
2117         Reviewed by Yury Semikhatsky.
2118
2119         Web Inspector: follow up on InspectorAgent split -
2120         removing unnecessary methods from InspectorController.
2121         https://bugs.webkit.org/show_bug.cgi?id=54093
2122
2123         * WebInspector/WebInspector.mm:
2124         (-[WebInspector showConsole:]):
2125         (-[WebInspector stopProfilingJavaScript:]):
2126
2127 2011-02-08  Dan Bernstein  <mitz@apple.com>
2128
2129         Reviewed by Jon Honeycutt and Maciej Stachowiak.
2130
2131         <rdar://problem/8959420> Find in Mail no longer cycles around
2132
2133         * WebView/WebHTMLView.mm:
2134         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
2135         the wrap option according to the flag.
2136
2137 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2138
2139         Unreviewed, rolling out r77980.
2140         http://trac.webkit.org/changeset/77980
2141         https://bugs.webkit.org/show_bug.cgi?id=54043
2142
2143         "Crashes on Windows and Linux..." (Requested by leviw on
2144         #webkit).
2145
2146         * WebView/WebFrame.mm:
2147         (-[WebFrame _caretRectAtNode:offset:affinity:]):
2148         * WebView/WebFrameInternal.h:
2149         * WebView/WebTextCompletionController.mm:
2150         (-[WebTextCompletionController doCompletion]):
2151
2152 2011-02-08  Levi Weintraub  <leviw@chromium.org>
2153
2154         Reviewed by Ryosuke Niwa.
2155
2156         Stop instantiating legacy editing Positions in VisiblePosition
2157         https://bugs.webkit.org/show_bug.cgi?id=52919
2158
2159         Changing usage of legacy VisiblePosition constructor. Since we were dealing
2160         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
2161
2162         * WebView/WebFrame.mm:
2163         (-[WebFrame _caretRectAtPosition:affinity:]):
2164         * WebView/WebFrameInternal.h:
2165         * WebView/WebTextCompletionController.mm:
2166         (-[WebTextCompletionController doCompletion]):
2167
2168 2011-02-08  Adam Barth  <abarth@webkit.org>
2169
2170         Reviewed by Eric Seidel.
2171
2172         Remove orphan code from old parser
2173         https://bugs.webkit.org/show_bug.cgi?id=53984
2174
2175         * WebCoreSupport/WebChromeClient.h:
2176
2177 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
2178
2179         Reviewed by Yury Semikhatsky.
2180
2181         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=53169
2184
2185         Minor change enforced by major changes in WebCore/inspector/InspectorController.
2186
2187         * WebInspector/WebInspector.mm:
2188         (-[WebInspector isTimelineProfilingEnabled]):
2189
2190 2011-02-07  Enrica Casucci  <enrica@apple.com>
2191
2192         Reviewed Adam Roben and Darin Adler.
2193
2194         WebKit2: drag and drop support on Windows.
2195         https://bugs.webkit.org/show_bug.cgi?id=52775
2196
2197         Removed createDragImageForLink from DragClient.
2198
2199         * WebCoreSupport/WebDragClient.h:
2200         * WebCoreSupport/WebDragClient.mm:
2201         (WebDragClient::startDrag):
2202
2203 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
2204
2205         Reviewed by Pavel Feldman.
2206
2207         Web Inspector: remove settings related methods from InspectorClient
2208         https://bugs.webkit.org/show_bug.cgi?id=53686
2209
2210         * WebCoreSupport/WebInspectorClient.h:
2211         * WebCoreSupport/WebInspectorClient.mm:
2212         (WebInspectorClient::openInspectorFrontend):
2213         (WebInspectorFrontendClient::WebInspectorFrontendClient):
2214
2215 2011-02-03  James Kozianski  <koz@chromium.org>
2216
2217         Reviewed by Dimitri Glazkov.
2218
2219         Add navigator.registerProtocolHandler behind a flag.
2220         https://bugs.webkit.org/show_bug.cgi?id=52609
2221
2222         * Configurations/FeatureDefines.xcconfig:
2223
2224 2011-02-03  Adam Langley  <agl@chromium.org>
2225
2226         Reviewed by Adam Barth.
2227
2228         Plumb mixed script URL to FrameLoaderClient
2229         https://bugs.webkit.org/show_bug.cgi?id=52384
2230
2231         Regressions covered by http/tests/security/mixedContent/*
2232
2233         * WebCoreSupport/WebFrameLoaderClient.h:
2234         * WebCoreSupport/WebFrameLoaderClient.mm:
2235         (WebFrameLoaderClient::didRunInsecureContent):
2236
2237 2011-02-03  Beth Dakin  <bdakin@apple.com>
2238
2239         Reviewed by Sam Weinig.
2240
2241         Fix for <rdar://problem/8944544> Ability to animate track
2242         for WKPainter scrollers
2243
2244         * WebCoreSupport/WebSystemInterface.mm:
2245         (InitWebCoreSystemInterface):
2246
2247 2011-02-02  Mark Rowe  <mrowe@apple.com>
2248
2249         Reviewed by Beth Dakin.
2250
2251         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
2252
2253         * WebCoreSupport/WebSystemInterface.mm:
2254         (InitWebCoreSystemInterface): Add some missing initializers.
2255
2256 2011-02-02  Steve Lacey  <sjl@chromium.org>
2257
2258         Reviewed by Eric Carlson.
2259
2260         Implement basic media statistics on media elements.
2261         https://bugs.webkit.org/show_bug.cgi?id=53322
2262
2263         * Configurations/FeatureDefines.xcconfig:
2264
2265 2011-02-01  Sam Weinig  <sam@webkit.org>
2266
2267         Reviewed by Beth Dakin.
2268
2269         Part 2 for <rdar://problem/8492788>
2270         Adopt WKScrollbarPainterController
2271
2272         Use header detection to define scrollbar painting controller #define.
2273
2274         * WebCoreSupport/WebSystemInterface.mm:
2275         (InitWebCoreSystemInterface):
2276
2277 2011-02-01  David Hyatt  <hyatt@apple.com>
2278
2279         Reviewed by Oliver Hunt.
2280
2281         https://bugs.webkit.org/show_bug.cgi?id=53520
2282         
2283         Remove the physical terminology from IntRect and FloatRect.
2284         
2285         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
2286         we need to update our terminology to be more accurate.
2287
2288         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
2289         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
2290         even for flipped rectangles.
2291
2292         * WebView/WebHTMLView.mm:
2293         (setNeedsDisplayInRect):
2294
2295 2011-02-01  Beth Dakin  <bdakin@apple.com>
2296
2297         Reviewed by Sam Weinig.
2298
2299         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
2300
2301         * WebCoreSupport/WebSystemInterface.mm:
2302         (InitWebCoreSystemInterface):
2303
2304 2011-02-01  Dave Hyatt  <hyatt@apple.com>
2305
2306         Reviewed by Darin Adler.
2307
2308         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
2309         with vertical text.
2310
2311         Change printing functions to check writing-mode and properly swap width and height
2312         as needed.
2313
2314         * WebView/WebDynamicScrollBarsView.mm:
2315         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
2316         * WebView/WebFrame.mm:
2317         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
2318         * WebView/WebFrameInternal.h:
2319         * WebView/WebHTMLView.mm:
2320         (-[WebHTMLView _web_setPrintingModeRecursive]):
2321         (-[WebHTMLView _web_clearPrintingModeRecursive]):
2322         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
2323         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
2324         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
2325         (-[WebHTMLView _endPrintMode]):
2326         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
2327         (-[WebHTMLView _endScreenPaginationMode]):
2328         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
2329         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
2330         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
2331         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2332         (-[WebHTMLView setPageWidthForPrinting:]):
2333         (-[WebHTMLView knowsPageRange:]):
2334
2335 2011-01-31  Oliver Hunt  <oliver@apple.com>
2336
2337         Convert markstack to a slot visitor API
2338         https://bugs.webkit.org/show_bug.cgi?id=53219
2339
2340         rolling r77098, r77099, r77100, r77109, and
2341         r77111 back in, along with a few more Qt fix attempts.
2342
2343         * WebView/WebScriptDebugDelegate.mm:
2344         (-[WebScriptCallFrame scopeChain]):
2345
2346 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
2347
2348         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
2349         r77111.
2350         http://trac.webkit.org/changeset/77098
2351         http://trac.webkit.org/changeset/77099
2352         http://trac.webkit.org/changeset/77100
2353         http://trac.webkit.org/changeset/77109
2354         http://trac.webkit.org/changeset/77111
2355         https://bugs.webkit.org/show_bug.cgi?id=53219
2356
2357         Qt build is broken
2358
2359         * WebView/WebScriptDebugDelegate.mm:
2360         (-[WebScriptCallFrame scopeChain]):
2361
2362 2011-01-30  Oliver Hunt  <oliver@apple.com>
2363
2364         Convert markstack to a slot visitor API
2365         https://bugs.webkit.org/show_bug.cgi?id=53219
2366
2367         rolling r77006 and r77020 back in.
2368
2369         * WebView/WebScriptDebugDelegate.mm:
2370         (-[WebScriptCallFrame scopeChain]):
2371
2372 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
2373
2374         Reviewed by Maciej Stachowiak.
2375
2376         Some more Heap cleanup.
2377         https://bugs.webkit.org/show_bug.cgi?id=53357
2378
2379         Updated for JavaScriptCore changes.
2380
2381         * Misc/WebCoreStatistics.mm:
2382         (+[WebCoreStatistics memoryStatistics]):
2383
2384 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2385
2386         Unreviewed, rolling out r77006 and r77020.
2387         http://trac.webkit.org/changeset/77006
2388         http://trac.webkit.org/changeset/77020
2389         https://bugs.webkit.org/show_bug.cgi?id=53360
2390
2391         "Broke Windows tests" (Requested by rniwa on #webkit).
2392
2393         * WebView/WebScriptDebugDelegate.mm:
2394         (-[WebScriptCallFrame scopeChain]):
2395
2396 2011-01-27  Oliver Hunt  <oliver@apple.com>
2397
2398         Reviewed by Geoffrey Garen.
2399
2400         Convert markstack to a slot visitor API
2401         https://bugs.webkit.org/show_bug.cgi?id=53219
2402
2403         Update to new marking api
2404
2405         * WebView/WebScriptDebugDelegate.mm:
2406         (-[WebScriptCallFrame scopeChain]):
2407
2408 2011-01-28  Dan Bernstein  <mitz@apple.com>
2409
2410         Reviewed by Sam Weinig.
2411
2412         <select> can't display right-to-left (rtl) languages
2413         https://bugs.webkit.org/show_bug.cgi?id=19785
2414
2415         * WebCoreSupport/WebChromeClient.h:
2416         * WebCoreSupport/WebChromeClient.mm:
2417         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
2418         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
2419
2420 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2421
2422         Unreviewed, rolling out r76891.
2423         http://trac.webkit.org/changeset/76891
2424         https://bugs.webkit.org/show_bug.cgi?id=53280
2425
2426         Makes every layout test crash (Requested by othermaciej on
2427         #webkit).
2428
2429         * Misc/WebIconDatabase.mm:
2430         (-[ThreadEnabler threadEnablingSelector:]):
2431         (importToWebCoreFormat):
2432
2433 2011-01-27  Nate Chapin  <japhet@chromium.org>
2434
2435         Reviewed by Adam Barth.
2436
2437         Use Document::url() instead of FrameLoader::url().
2438         https://bugs.webkit.org/show_bug.cgi?id=41165
2439
2440         * WebView/WebView.mm:
2441         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2442
2443 2011-01-27  Dan Bernstein  <mitz@apple.com>
2444
2445         Rubber-stamped by Anders Carlsson.
2446
2447         Reverted an accidental change in r76561.
2448
2449         * WebView/WebHTMLView.mm:
2450
2451 2011-01-26  David Kilzer  <ddkilzer@apple.com>
2452
2453         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
2454         <rdar://problem/8821760>
2455
2456         Reviewed by Antti Koivisto.
2457
2458         * WebCoreSupport/WebSystemInterface.mm:
2459         (InitWebCoreSystemInterface): Added initialization for
2460         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
2461
2462 2011-01-26  Beth Dakin  <bdakin@apple.com>
2463
2464         Reviewed by Darin Adler.
2465
2466         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
2467         when using WKScrollbars.
2468
2469         * WebCoreSupport/WebSystemInterface.mm:
2470         (InitWebCoreSystemInterface):
2471
2472 2011-01-25  Darin Adler  <darin@apple.com>
2473
2474         Reviewed by Anders Carlsson.
2475
2476         WebKit is using CSBackupSetItemExcluded incorrectly
2477         https://bugs.webkit.org/show_bug.cgi?id=53095
2478         rdar://problem/8790540
2479
2480         * Misc/WebIconDatabase.mm:
2481         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
2482         It was incorrect, and this responsibility has been moved to WebCore.
2483
2484 2011-01-24  Chris Marrin  <cmarrin@apple.com>
2485
2486         Reviewed by Eric Seidel.
2487
2488         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
2489         https://bugs.webkit.org/show_bug.cgi?id=53041
2490
2491         * Configurations/FeatureDefines.xcconfig:
2492
2493 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
2494
2495         Reviewed by Pavel Feldman.
2496
2497         Web Inspector: remove "attached" state related methods from InspectorAgent
2498         https://bugs.webkit.org/show_bug.cgi?id=53086
2499
2500         * WebCoreSupport/WebInspectorClient.h:
2501         * WebCoreSupport/WebInspectorClient.mm:
2502         (-[WebInspectorWindowController showWindow:]):
2503         (-[WebInspectorWindowController attach]):
2504         (-[WebInspectorWindowController detach]):
2505
2506 2011-01-23  Dan Bernstein  <mitz@apple.com>
2507
2508         Reviewed by John Sullivan.
2509
2510         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
2511
2512         * WebCoreSupport/WebChromeClient.mm:
2513         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
2514
2515 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
2516
2517         Reviewed by Darin Adler.
2518
2519         https://bugs.webkit.org/show_bug.cgi?id=52473
2520         Auto-scaling to avoid orphans is broken, remove dysfunctional code
2521
2522         * WebView/WebHTMLView.mm:
2523         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
2524         (-[WebHTMLView _scaleFactorForPrintOperation:]):
2525         (-[WebHTMLView knowsPageRange:]):
2526
2527 2011-01-21  Mark Rowe  <mrowe@apple.com>
2528
2529         Rubber-stamped by Jon Honeycutt.
2530
2531         Fix the build when using Clang by removing some unused variables.
2532
2533         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2534         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2535         * WebView/WebFullScreenController.mm:
2536         (-[WebFullScreenController enterFullscreen:]):
2537         (-[WebFullScreenController exitFullscreen]):
2538
2539 2011-01-21  Chris Rogers  <crogers@google.com>
2540
2541         Reviewed by Darin Fisher.
2542
2543         Add run-time enable support for the web audio API
2544         https://bugs.webkit.org/show_bug.cgi?id=52741
2545
2546         * WebView/WebPreferenceKeysPrivate.h:
2547         * WebView/WebPreferences.mm:
2548         (-[WebPreferences webAudioEnabled]):
2549         (-[WebPreferences setWebAudioEnabled:]):
2550         * WebView/WebPreferencesPrivate.h:
2551         * WebView/WebView.mm:
2552         (-[WebView _preferencesChangedNotification:]):
2553
2554 2011-01-20  John Sullivan  <sullivan@apple.com>
2555
2556         Reviewed by Mark Rowe.
2557
2558         Shift-tab doesn't cycle through fields in http authentication panel
2559         https://bugs.webkit.org/show_bug.cgi?id=52850
2560
2561         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
2562         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
2563         Re-wired the key loop so that there aren't two views with the same nextKeyView.
2564
2565 2011-01-20  Beth Dakin  <bdakin@apple.com>
2566
2567         Reviewed by Geoffrey Garen.
2568
2569         Fix for <rdar://problem/8890255>
2570
2571         Allow WebKitSystemInterface to draw scrollbars 
2572         when appropriate.
2573         * WebCoreSupport/WebSystemInterface.mm:
2574         (InitWebCoreSystemInterface):
2575
2576 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
2577
2578         Reviewed by Sam Weinig.
2579
2580         GraphicsLayers in subframes can get sync'd multiple times
2581         https://bugs.webkit.org/show_bug.cgi?id=52489
2582
2583         * WebView/WebView.mm:
2584         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
2585         was renamed to syncCompositingStateIncludingSubframes().
2586
2587 2011-01-19  Darin Adler  <darin@apple.com>
2588
2589         Reviewed by Sam Weinig.
2590
2591         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
2592         https://bugs.webkit.org/show_bug.cgi?id=52104
2593         rdar://problem/8704226
2594
2595         * WebView/WebDelegateImplementationCaching.h:
2596         Fix type of second integer in CallScriptDebugDelegate function overload
2597         to be int to match the actual Objective-C method. Added a new overload
2598         that includes a BOOL in the right place. Added a boolean named
2599         exceptionWasRaisedExpectsHasHandlerFlag.
2600
2601         * WebView/WebDelegateImplementationCaching.mm:
2602         (CallDelegate): Added overloads as above.
2603         (CallScriptDebugDelegate): Ditto.
2604
2605         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
2606         boolean argument. Marked the old method informally deprecated.
2607
2608         * WebView/WebScriptDebugger.mm:
2609         (WebScriptDebugger::exception): Added code to call with or without the
2610         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
2611
2612         * WebView/WebView.mm:
2613         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
2614         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
2615         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
2616
2617 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
2618
2619         Reviewed by Mihai Parparita.
2620
2621         Perform some forward declaration
2622         https://bugs.webkit.org/show_bug.cgi?id=52522
2623
2624         * Misc/WebKitNSStringExtras.mm:
2625
2626 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
2627
2628         Reviewed by Yury Semikhatsky.
2629
2630         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
2631         https://bugs.webkit.org/show_bug.cgi?id=52721
2632
2633         * WebView/WebScriptDebugger.h:
2634         * WebView/WebScriptDebugger.mm:
2635         (toNSString):
2636         (WebScriptDebugger::sourceParsed):
2637
2638 2011-01-19  Levi Weintraub  <leviw@google.com>
2639
2640         Reviewed by Ryosuke Niwa.
2641
2642         Updating to use Position::parentAnchoredEquivalent instead of
2643         the old htmlediting rangeCompliantEquivalent.
2644
2645         remove rangeCompliantEquivalent and replace it with Position methods
2646         https://bugs.webkit.org/show_bug.cgi?id=25057
2647
2648         * WebView/WebFrame.mm:
2649         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2650
2651 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
2652
2653         Reviewed by Darin Adler.
2654
2655         REGRESSION: A problem with Voiceover and finding links
2656         https://bugs.webkit.org/show_bug.cgi?id=52324
2657
2658         * WebView/WebDynamicScrollBarsView.mm:
2659         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2660
2661 2011-01-17  David Kilzer  <ddkilzer@apple.com>
2662
2663         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
2664
2665         Reviewed by Dan Bernstein.
2666
2667         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
2668         DOMDocumentPrivate.h to the PrivateHeaders directory.
2669
2670 2011-01-17  Enrica Casucci  <enrica@apple.com>
2671
2672         Reviewed by Alexey Proskuryakov.
2673
2674         Drag and drop support: refactoring of image from link and image from selection
2675         https://bugs.webkit.org/show_bug.cgi?id=52496
2676
2677         This work cleans up the Mac code and makes it more similar to the Windows implementation,
2678         avoiding the use of an NSView when the FrameView can be used.
2679         The refactoring is a necessary step towards the complete support of drag and drop
2680         in WebKit2.
2681
2682         * WebCoreSupport/WebDragClient.mm:
2683         (WebDragClient::createDragImageForLink): Added.
2684         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
2685         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
2686
2687 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
2688
2689         Reviewed by Yury Semikhatsky.
2690
2691         Web Inspector: simplify debugger enabling routine.
2692         https://bugs.webkit.org/show_bug.cgi?id=52472
2693
2694         * WebInspector/WebInspector.mm:
2695         (-[WebInspector startDebuggingJavaScript:]):
2696
2697 2011-01-16  Dan Bernstein  <mitz@apple.com>
2698
2699         Reviewed by Simon Fraser.
2700
2701         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
2702         https://bugs.webkit.org/show_bug.cgi?id=52550
2703
2704         * Plugins/WebNetscapePluginView.mm:
2705         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
2706         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
2707
2708 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
2709
2710         Reviewed by Dan Bernstein.
2711
2712         Issues with iframes and plugins when the WebView is scaled.
2713         <rdar://problem/6213380>
2714         
2715         When _scaleWebView has been called on a WebView, iframes
2716         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
2717         This is caused by AppKit NSViews not playing nicely with the scale
2718         applied through style.
2719         
2720         Work around most of these issues by adjusting the bounds size
2721         of widgets to allow iframe contents to paint with the correct scale,
2722         and fix various places in the code where we relied on coordinate
2723         transforms via NSViews (which ignore CSS transforms).
2724
2725         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2726         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2727         * WebView/WebFrameView.mm:
2728         (-[WebFrameView setBoundsSize:]):
2729
2730 2011-01-16  Beth Dakin  <bdakin@apple.com>
2731
2732         Reviewed by Kevin Decker.
2733
2734         Fix for <rdar://problem/8871204>
2735
2736         Don't try to save elasticity state. Just rely on
2737         NSScrollElasticityAutomatic to restore the correct state.
2738         * WebCoreSupport/WebFrameLoaderClient.h:
2739         * WebCoreSupport/WebFrameLoaderClient.mm:
2740         (WebFrameLoaderClient::WebFrameLoaderClient):
2741         (WebFrameLoaderClient::dispatchDidFirstLayout):
2742         (WebFrameLoaderClient::provisionalLoadStarted):
2743
2744 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
2745
2746         Reviewed by Dan Bernstein.
2747
2748         Plugins render incorrectly with transformed ancestors
2749         https://bugs.webkit.org/show_bug.cgi?id=52507
2750         
2751         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
2752         in the ancestor chain of a plugin.
2753         
2754         So use of this method with calls to -actualVisibleRectInWindow, which
2755         maps rects through the render tree to compute the correct rect,
2756         clipping via windowClipRect() if necessary.
2757         
2758         Not testable, because doing so relies on the behavior of some
2759         plugins, which stop rendering if setWindow passes an empty rect.
2760
2761         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2762         (-[WebHostedNetscapePluginView updateAndSetWindow]):
2763         * Plugins/WebBaseNetscapePluginView.h:
2764         * Plugins/WebBaseNetscapePluginView.mm:
2765         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2766         * Plugins/WebNetscapePluginView.mm:
2767         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2768
2769 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
2770
2771         Reviewed by Antti Koivisto.
2772
2773         Rename cache() to memoryCache()
2774         https://bugs.webkit.org/show_bug.cgi?id=52433
2775
2776         * Misc/WebCache.mm:
2777         (+[WebCache statistics]):
2778         (+[WebCache setDisabled:]):
2779         (+[WebCache isDisabled]):
2780         * WebView/WebView.mm:
2781         (+[WebView _setCacheModel:]):
2782
2783 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
2784
2785         Reviewed by Oliver Hunt.
2786
2787         Split out a MarkedSpace strategy object from Heap.
2788         https://bugs.webkit.org/show_bug.cgi?id=52421
2789
2790         * Misc/WebCoreStatistics.mm:
2791         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
2792
2793 2011-01-14  Dan Bernstein  <mitz@apple.com>
2794
2795         Reviewed by Simon Fraser.
2796
2797         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
2798
2799         * WebView/WebHTMLView.mm:
2800         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
2801         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
2802         that the NSView tree doesn’t change from under AppKit as it traverses it.
2803
2804 2011-01-14  Beth Dakin  <bdakin@apple.com>
2805
2806         Reviewed by Mark Rowe.
2807
2808         Fix for <rdar://problem/7793902> Artifacts when scrolling
2809         page in Safari while page is loading
2810
2811         Call setDrawsBackground:YES on the scrollView in 
2812         dispatchDidFirstLayout() rather than waiting until
2813         frameLoadCompleted(). Also suspend scrolling elasticity
2814         between provisionalLoadStarted() and dispatchDidFirstLayout()
2815         * WebCoreSupport/WebFrameLoaderClient.h:
2816         * WebCoreSupport/WebFrameLoaderClient.mm:
2817         (WebFrameLoaderClient::WebFrameLoaderClient):
2818         (WebFrameLoaderClient::dispatchDidFirstLayout):
2819         (WebFrameLoaderClient::provisionalLoadStarted):
2820
2821 2011-01-12  Enrica Casucci  <enrica@apple.com>
2822
2823         Reviewed by Darin Adler.
2824
2825         WebKit2: Add support for drag and drop
2826         https://bugs.webkit.org/show_bug.cgi?id=52343
2827         <rdar://problem/7660558>
2828         
2829         The DragData class has been extended to provide
2830         additional context from the application (keyboard state, modal windows, etc.)
2831         as well as information of the drag pasteboard being used.
2832         These are the changes to align the behavior for WebKit.
2833
2834         * WebView/WebView.mm:
2835         (-[WebView applicationFlags:]): Added.
2836         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
2837         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
2838         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
2839         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
2840
2841 2011-01-12  Beth Dakin  <bdakin@apple.com>
2842
2843         Reviewed by Anders Carlsson.
2844
2845         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
2846         Expose fixed layout through WebKit SPI
2847         -and corresponding-
2848         <rdar://problem/8844464>
2849
2850         And now with getters!
2851         * WebView/WebView.mm:
2852         (-[WebView _useFixedLayout]):
2853         (-[WebView _fixedLayoutSize]):
2854         * WebView/WebViewPrivate.h:
2855
2856 2011-01-12  Beth Dakin  <bdakin@apple.com>
2857
2858         Reviewed by Anders Carlsson.
2859
2860         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
2861         fixed layout through WebKit SPI
2862         -and corresponding-
2863         <rdar://problem/8844464>
2864
2865         * WebView/WebView.mm:
2866         (-[WebView _setUseFixedLayout:]):
2867         (-[WebView _setFixedLayoutSize:]):
2868         * WebView/WebViewPrivate.h:
2869
2870 2011-01-07  Enrica Casucci  <enrica@apple.com>
2871
2872         Reviewed by Alexey Proskuryakov.
2873
2874         Paste and drag and drop use different code paths to interact with the pasteboard.
2875         https://bugs.webkit.org/show_bug.cgi?id=52093
2876         The change consists in a refactoring of the code to have only one class that
2877         deals with the pasteboard on Mac.
2878
2879         * WebCoreSupport/WebEditorClient.h:
2880         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
2881         exposed by NSURLExtras.
2882         (WebEditorClient::canonicalizeURL):
2883         (WebEditorClient::canonicalizeURLString):
2884         * WebCoreSupport/WebPasteboardHelper.h: Removed.
2885         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
2886         * WebView/WebHTMLView.mm: Removed comment.
2887         * WebView/WebView.mm: The following methods have been changed to use the new DragData
2888         constructor that doesn't use the WebPasteboardHelper reference.
2889         (-[WebView draggingEntered:]):
2890         (-[WebView draggingUpdated:]):
2891         (-[WebView draggingExited:]):
2892         (-[WebView performDragOperation:]):
2893
2894 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
2895
2896         Reviewed by Alexey Proskuryakov.
2897
2898         Forward declare some headers where possible
2899         https://bugs.webkit.org/show_bug.cgi?id=52133
2900
2901         * WebView/WebFrame.mm:
2902
2903 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
2904
2905         Reviewed by Darin Fisher.
2906
2907         https://bugs.webkit.org/show_bug.cgi?id=41441
2908         createWindow method should only do window-creating without URL navigation
2909
2910         * WebCoreSupport/WebChromeClient.mm:
2911         (WebChromeClient::createWindow):
2912
2913 2011-01-08  Dan Bernstein  <mitz@apple.com>
2914
2915         Try to fix the Leopard build.
2916
2917         * WebView/WebFullScreenController.mm:
2918
2919 2011-01-07  Jer Noble  <jer.noble@apple.com>
2920
2921         Yet another Leopard build fix: NSRect and CGRect are not inter-
2922         changable in 32-bit.  
2923         
2924         * WebView/WebFullScreenController.mm:
2925         (-[WebFullScreenController exitFullscreen]):
2926
2927 2011-01-07  Jer Noble  <jer.noble@apple.com>
2928
2929         Fix the Leopard build: Replace CoreAnimation SL-only functions
2930         with Leopard equivalents.
2931
2932         * WebView/WebFullScreenController.mm:
2933         (+[CATransaction setDisableActions:]):
2934         (+[CATransaction setAnimationDuration:]):
2935         (-[WebFullScreenController _animationDuration]):
2936         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
2937
2938 2010-12-21  Jer Noble  <jer.noble@apple.com>
2939
2940         Reviewed by Simon Fraser.
2941
2942         Implement WebKit Full Screen support.
2943         https://bugs.webkit.org/show_bug.cgi?id=49481
2944         rdar://problem/8247444
2945
2946         Support the new fullscreen Chrome client requests.  WebView will pass
2947         through these requests to a WebFullscreenController.
2948
2949         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
2950         * WebView/WebView.mm:
2951         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
2952         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
2953         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
2954         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
2955         * WebView/WebViewData.h: Add ivar newFullscreenController.
2956
2957 2010-12-17  Jer Noble  <jer@kokode.apple.com>
2958
2959         Reviewed by Simon Fraser.
2960
2961         Implement WebKit Full Screen support.
2962         https://bugs.webkit.org/show_bug.cgi?id=49481
2963         rdar://problem/8247444
2964         
2965         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
2966         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
2967         window, and a custom CAAnimation animates that layer between the initial screen rect of the
2968         full screen element, to its final value. WebFullscreenController will swap the WebView out of
2969         its original window, and into the fullscreen window. The controller will replace the WebView
2970         with a placeholder view, so that if the placeholder moves or resized while the WebView is
2971         absent, the WebView will move back to the correct location when exiting fullscreen.
2972
2973         * WebView/WebFullscreenController.h: Added.
2974         * WebView/WebFullscreenController.mm: Added.
2975         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
2976         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
2977         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
2978         (-[WebFullscreenController applicationDidResignActive:]):
2979         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
2980             the new screen parameters.
2981         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
2982             from its original screen rect into fullscreen.
2983         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
2984             Set up the animation that will take the fullscreen element back into its original screen
2985             rect.
2986         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
2987             whether to disable screensaver and sleep.
2988         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
2989             looking for HTMLVideoElements; returns whether any are found to be playing.
2990         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
2991             and shift keys.
2992         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
2993         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
2994         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
2995         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
2996         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
2997         (-[WebFullscreenWindow backgroundLayer]): Ditto.
2998         (-[WebFullscreenWindow animationView]): Ditto.
2999         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
3000         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
3001         
3002 2011-01-07  James Robinson  <jamesr@chromium.org>
3003
3004         Revert "Implement mozilla's animationTime property"
3005         https://bugs.webkit.org/show_bug.cgi?id=51952
3006
3007         This approach isn't quite right.
3008
3009         * WebView/WebHTMLView.mm:
3010         (-[WebHTMLView drawRect:]):
3011         * WebView/WebView.mm:
3012         (layerSyncRunLoopObserverCallBack):
3013
3014 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
3015
3016         Reviewed by Geoff Garen.
3017
3018         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
3019
3020         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
3021         destructor early, in order to release wrappers once we know we no longer intend to use them.
3022         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
3023         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
3024         A sequence of events that triggers the bug would look like this:
3025
3026         (1) Create a DOMWrapperWorld.
3027         (2) Register a timer in the world.
3028         (3) Call unregisterWorld() on the world.
3029         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
3030         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
3031             called forgetWorld() none exists.
3032         (6) Attempt to add a wrapper to a NULL map.
3033
3034         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
3035
3036         * WebView/WebScriptWorld.mm:
3037         (-[WebScriptWorld unregisterWorld]):
3038
3039 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3040
3041         Reviewed by Sam Weinig.
3042
3043         WK2: Support Accessibility
3044         https://bugs.webkit.org/show_bug.cgi?id=51859
3045
3046         Use rootObject() method to get top of AX tree.
3047
3048         * WebCoreSupport/WebFrameLoaderClient.h:
3049         (WebFrameLoaderClient::accessibilityRemoteObject):
3050         * WebView/WebFrame.mm:
3051         (-[WebFrame setAccessibleName:]):
3052         (-[WebFrame accessibilityRoot]):
3053         * WebView/WebFrameInternal.h:
3054         * WebView/WebFramePrivate.h:
3055         * WebView/WebHTMLView.mm:
3056         (-[WebHTMLView accessibilityAttributeValue:]):
3057         (-[WebHTMLView accessibilityFocusedUIElement]):
3058         (-[WebHTMLView accessibilityHitTest:]):
3059         (-[WebHTMLView _accessibilityParentForSubview:]):
3060
3061 2011-01-04  David Kilzer  <ddkilzer@apple.com>
3062
3063         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
3064
3065         Reviewed by Eric Carlson.
3066
3067         This originally broke in r61581.  It is inside an
3068         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
3069         build then.
3070
3071         * WebCoreSupport/WebFrameLoaderClient.mm: Call
3072         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
3073         use WebCore::PluginInfo.name instead of
3074         -[WebBasePluginPackage name].
3075
3076 2011-01-02  Dan Bernstein  <mitz@apple.com>
3077
3078         Rubber-stamped by Simon Fraser.
3079
3080         <rdar://problem/8812159> Update copyright strings
3081
3082         * Info.plist:
3083
3084 2010-12-29  Dan Bernstein  <mitz@apple.com>
3085
3086         Reviewed by Ada Chan.
3087
3088         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
3089         https://bugs.webkit.org/show_bug.cgi?id=51717
3090
3091         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
3092         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
3093
3094         * WebView/WebDocumentInternal.h:
3095         * WebView/WebHTMLView.mm:
3096         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3097         (-[WebHTMLView _findString:options:]):
3098         * WebView/WebView.mm:
3099         (findString):
3100
3101 2010-12-28  Daniel Bates  <dbates@rim.com>
3102
3103         Reviewed by Sam Weinig.
3104
3105         Substitute // MARK: for compiler-specific #pragma mark
3106         https://bugs.webkit.org/show_bug.cgi?id=51657
3107
3108         For consistency, we should substitute "// MARK:" for compiler-
3109         specific "#pragma mark" in the source files for the Mac port.
3110
3111         * History/WebHistory.mm:
3112         * Plugins/WebBaseNetscapePluginView.mm:
3113         * Plugins/WebNetscapePluginView.mm:
3114         * WebCoreSupport/WebInspectorClient.mm:
3115         * WebCoreSupport/WebSecurityOrigin.mm:
3116         * WebView/WebPDFView.mm:
3117         * WebView/WebVideoFullscreenController.mm:
3118         * WebView/WebVideoFullscreenHUDWindowController.mm:
3119
3120 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
3121
3122         Reviewed by Darin Adler.
3123
3124         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
3125         https://bugs.webkit.org/show_bug.cgi?id=38535
3126
3127         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
3128         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
3129         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
3130         call frame from this stack when an exception throws because the saved top frame could be invalid.
3131
3132         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
3133         callEvent and returnEvent.
3134
3135         * WebView/WebScriptDebugger.mm:
3136         (WebScriptDebugger::willExecuteProgram):
3137         (WebScriptDebugger::didExecuteProgram):
3138
3139 2010-12-22  Sam Weinig  <sam@webkit.org>
3140
3141         Reviewed by Darin Adler.
3142
3143         WebKit2 needs to mirror the frame tree in the UIProcess
3144         https://bugs.webkit.org/show_bug.cgi?id=51546
3145
3146         - Add client functions to notify that a frame has been added or
3147           removed from the page cache.
3148
3149         * WebCoreSupport/WebFrameLoaderClient.h:
3150         * WebCoreSupport/WebFrameLoaderClient.mm:
3151         (WebFrameLoaderClient::didSaveToPageCache):
3152         (WebFrameLoaderClient::didRestoreFromPageCache):
3153
3154 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3155
3156         Reviewed by Eric Seidel.
3157
3158         Editor.h doesn't need to include SelectionController.h
3159         https://bugs.webkit.org/show_bug.cgi?id=51441
3160
3161         Renamed SelectionController::EDirection to SelectionDirection.
3162
3163         * WebView/WebFrame.mm:
3164         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
3165         Takes SelectionDirection instead of SelectionController::EDirection.
3166         * WebView/WebFrameInternal.h:
3167         * WebView/WebTextCompletionController.mm:
3168         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
3169
3170 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
3171
3172         Reviewed by Darin Adler.
3173
3174         Cache snapshots of plug-ins before painting, to avoid script running during painting
3175         https://bugs.webkit.org/show_bug.cgi?id=51493
3176
3177         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
3178         or when printing), plug-ins which otherwise use the CA rendering model
3179         are sent a paint event. Some plug-ins may run script while handling this event,
3180         or out of process plug-ins may process queued requests at this time. Running
3181         script while inside layout or painting can have bad consequences, because it
3182         can result in arbitrary changes to the render tree.
3183         
3184         This patch avoids sending plug-ins paint events inside of painting. Instead,
3185         we ask the plug-ins to cache a snapshot before we paint, and then the software
3186         paint simply draws that snapshot.
3187
3188         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3189         (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
3190         draw it. Also only send the snapshot message to the plugin proxy if we
3191         know we're snapshotting, since even if creating the snapshot image failed,
3192         we still don't want to call to the plug-in.
3193
3194         * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
3195         * Plugins/WebBaseNetscapePluginView.mm:
3196         (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
3197         (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
3198
3199         * Plugins/WebNetscapePluginView.mm:
3200         (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
3201         * WebCoreSupport/WebFrameLoaderClient.mm:
3202         (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
3203         to cache and clear the snapshots.
3204
3205 2010-12-21  Cameron Zwarich  <zwarich@apple.com>
3206
3207         Reviewed by Darin Adler.
3208
3209         -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
3210         https://bugs.webkit.org/show_bug.cgi?id=51431
3211         <rdar://problem/8791757>
3212
3213         * Plugins/WebBasePluginPackage.mm:
3214         (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
3215         it doesn't underflow.
3216
3217 2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3218
3219         Reviewed by Cameron Zwarich.
3220
3221         REGRESSION(r74172): 125 java tests fail on Mac
3222         https://bugs.webkit.org/show_bug.cgi?id=51214
3223
3224         The regression was caused by an incorrectly adding sizeof(struct fat_header)
3225         to a pointer for uint32_t as supposed to uint8_t.
3226
3227         Fixed the bug by explicitly casting it to uint8_t* before the addition.
3228
3229         * Plugins/WebBasePluginPackage.mm:
3230         (-[WebBasePluginPackage isNativeLibraryData:]):
3231
3232 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
3233
3234         Reviewed by Darin Adler.
3235
3236         Clang -Wcast-align gives an error in WebBasePluginPackage.mm
3237         https://bugs.webkit.org/show_bug.cgi?id=51144
3238
3239         Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
3240         we were calling it on a byte array 32 bits at a time. While this is okay in practice,
3241         since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
3242         inline storage is at the beginning of the Vector, it is still better to fix this
3243         and silence the warning.
3244
3245         * Plugins/WebBasePluginPackage.mm:
3246         (swapIntsInHeader):
3247         (-[WebBasePluginPackage isNativeLibraryData:]):
3248
3249 2010-12-14  Mark Rowe  <mrowe@apple.com>
3250
3251         Reviewed by Sam Weinig.
3252
3253         <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
3254
3255         * History/WebHistoryItem.mm:
3256         (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
3257         always including the target in the output.
3258
3259 2010-12-13  Alexey Proskuryakov  <ap@apple.com>
3260
3261         Reviewed by Adam Barth.
3262
3263         https://bugs.webkit.org/show_bug.cgi?id=50953
3264         DNS Prefetch should be an opt-in feature
3265
3266         * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
3267
3268 2010-12-13  Mike Thole  <mthole@apple.com>
3269
3270         Rubber-stamped by John Sullivan.
3271
3272         https://bugs.webkit.org/show_bug.cgi?id=50956
3273         WebAuthenticationPanel.nib appears to have a cut-off sentence
3274         
3275         Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
3276         The contents of this text field are updated dynamically before the sheet is displayed.
3277
3278         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
3279         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
3280
3281 2010-12-13  Antti Koivisto  <antti@apple.com>
3282
3283         Reviewed by Alexey Proskuryakov.
3284
3285         https://bugs.webkit.org/show_bug.cgi?id=50758
3286         <rdar://problem/8722094> 
3287         Defer loading print stylesheets
3288         
3289         Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
3290
3291         * WebView/WebView.mm:
3292         (+[WebView _setLoadResourcesSerially:forHost:]):
3293         * WebView/WebViewPrivate.h:
3294
3295 2010-12-09  Matthew Delaney  <mdelaney@apple.com>
3296
3297         Reviewed by Simon Fraser.
3298
3299         Adopt new CG API for canvas
3300         https://bugs.webkit.org/show_bug.cgi?id=50591
3301
3302         * WebCoreSupport/WebSystemInterface.mm:
3303
3304 2010-10-28  MORITA Hajime  <morrita@google.com>
3305
3306         Reviewed by Ojan Vafai.
3307
3308         spellcheck does not check pasted text
3309         https://bugs.webkit.org/show_bug.cgi?id=40092
3310
3311         Added asynchronous spell checking API to WebEditorClient using
3312         -[NSSpellChecker requestCheckingOfString].
3313         Note that WebEditorSpellCheckResponder is a small class to receive
3314         requested spell-checking result. Note that this feature is
3315         disabled at default.
3316         
3317         Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to 
3318         enable the feature from LayoutTestController.
3319
3320         * WebCoreSupport/WebEditorClient.h:
3321         * WebCoreSupport/WebEditorClient.mm:
3322         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
3323         (-[WebEditorSpellCheckResponder perform]):
3324         (toCoreSpellingResult):
3325         (-[WebEditorSpellCheckResponder WTF::WebCore::]):
3326         (WebEditorClient::requestCheckingOfString):
3327         * WebView/WebPreferenceKeysPrivate.h:
3328         * WebView/WebPreferences.mm:
3329         (+[WebPreferences initialize]):
3330         (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
3331         (-[WebPreferences asynchronousSpellCheckingEnabled]):
3332         * WebView/WebPreferencesPrivate.h:
3333         * WebView/WebView.mm:
3334         (-[WebView _preferencesChangedNotification:]):
3335
3336 2010-12-09  Anders Carlsson  <andersca@apple.com>
3337
3338         Fix a bug uncovered by clang++.
3339
3340         * WebView/WebHTMLView.mm:
3341         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3342
3343 2010-12-09  Anders Carlsson  <andersca@apple.com>
3344
3345         Clang++ build fixes.
3346
3347         Silence a couple of warnings.
3348
3349         * WebView/WebFrame.mm:
3350         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3351         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3352         * WebView/WebTextCompletionController.mm:
3353         (-[WebTextCompletionController filterKeyDown:]):
3354
3355 2010-12-09  David Hyatt  <hyatt@apple.com>
3356
3357         Reviewed by Dan Bernstein.
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
3360         writing-mode.  This first part of the patch just patches Mac WebKit 1 views.
3361
3362         * WebView/WebFrameView.mm:
3363         (-[WebFrameView _isVerticalDocument]):
3364         (-[WebFrameView _isFlippedDocument]):
3365         (-[WebFrameView _scrollToEndOfDocument]):
3366         (-[WebFrameView _pageInBlockProgressionDirection:]):
3367         (-[WebFrameView scrollPageUp:]):
3368         (-[WebFrameView scrollPageDown:]):
3369
3370 2010-12-08  Andy Estes  <aestes@apple.com>
3371
3372         Reviewed by Darin Adler.
3373
3374         Enable pre-HTML5 parser quirks for Apple Mail.app
3375         https://bugs.webkit.org/show_bug.cgi?id=50727
3376
3377         * WebView/WebView.mm:
3378         (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
3379         application is Mail.app.
3380
3381 2010-12-08  Brian Weinstein  <bweinstein@apple.com>
3382
3383         Reviewed by John Sullivan.
3384
3385         REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
3386         https://bugs.webkit.org/show_bug.cgi?id=50683
3387         
3388         If our context menu item already has an action, don't overwrite the action with the context menu
3389         forwarder.
3390
3391         * WebView/WebHTMLView.mm:
3392         (setMenuItemTarget):
3393
3394 2010-12-08  Anders Carlsson  <andersca@apple.com>
3395
3396         Remove an unused variable.
3397
3398         * WebView/WebDynamicScrollBarsView.mm:
3399         (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
3400
3401 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
3402
3403         Reviewed by John Sullivan.
3404
3405         Layering Violation in ContextMenu - member variable of type HitTestResult
3406         https://bugs.webkit.org/show_bug.cgi?id=50586
3407         
3408         Update users of ContextMenu and ContextMenuController to match where the new functions 
3409         are located.
3410
3411         * WebCoreSupport/WebContextMenuClient.mm:
3412         (WebContextMenuClient::getCustomMenuFromDefaultItems):
3413         (WebContextMenuClient::contextMenuItemSelected):
3414         * WebView/WebHTMLView.mm:
3415         (-[WebMenuTarget validateMenuItem:]):
3416
3417 2010-12-07  Brian Weinstein  <bweinstein@apple.com>
3418
3419         Reviewed by John Sullivan.
3420
3421         Part of Layering Violation in ContextMenu
3422         https://bugs.webkit.org/show_bug.cgi?id=50586
3423         
3424         Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
3425         was a layering violation. Also, make sure we set the menu item targets for all menu
3426         items before showing them, because the ContextMenu constructor doesn't do that anymore.
3427
3428         * WebView/WebHTMLView.mm:
3429         (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
3430         (-[WebMenuTarget WebCore::]): Ditto.
3431         (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
3432         (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
3433         (-[WebMenuTarget validateMenuItem:]): Ditto.
3434
3435         (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
3436         (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
3437             submenus), and calls setMenuItemTarget on them.
3438         (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
3439             them to the menu.
3440
3441 2010-12-06  Darin Adler  <darin@apple.com>
3442
3443         Reviewed by Sam Weinig.
3444
3445         Pass security origin to make local file decision correctly
3446         https://bugs.webkit.org/show_bug.cgi?id=48603
3447
3448         * WebView/WebPDFView.mm:
3449         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
3450
3451 2010-12-07  Martin Robinson  <mrobinson@igalia.com>
3452
3453         Unreviewed, rolling out r73392.
3454         http://trac.webkit.org/changeset/73392
3455         https://bugs.webkit.org/show_bug.cgi?id=50489
3456
3457         This commit caused crashes on the GTK+ bots
3458
3459         * WebView/WebFrame.mm:
3460         (-[WebFrame _canProvideDocumentSource]):
3461
3462 2010-12-07  Kenichi Ishibashi  <bashi@google.com>
3463
3464         Reviewed by Kent Tamura.
3465
3466         Let HTMLObjectElement be a form associated element
3467         https://bugs.webkit.org/show_bug.cgi?id=48821
3468
3469         Modified to use FormAssociatedElement instead of HTMLFormControlElement.
3470
3471         * WebView/WebHTMLRepresentation.mm:
3472         (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
3473         FormAssociatedElement instead of HTMLFormControlElement.
3474         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3475
3476 2010-12-06  Nate Chapin  <japhet@chromium.org>
3477
3478         Reviewed by Adam Barth.
3479
3480         Update calls to DocumentWriter.
3481         https://bugs.webkit.org/show_bug.cgi?id=50489
3482
3483         * WebView/WebFrame.mm:
3484         (-[WebFrame _canProvideDocumentSource]):
3485
3486 2010-12-06  Chris Marrin  <cmarrin@apple.com>
3487
3488         Reviewed by Simon Fraser.
3489
3490         Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
3491         https://bugs.webkit.org/show_bug.cgi?id=49388
3492
3493         Got rid of GraphicsLayer::nativeLayer() call, replacing it with 
3494         GraphicsLayer::platformLayer().
3495
3496         * WebCoreSupport/WebChromeClient.mm:
3497         (WebChromeClient::attachRootGraphicsLayer):
3498
3499 2010-12-04  Dan Bernstein  <mitz@apple.com>
3500
3501         Reviewed by Sam Weinig.
3502
3503         WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
3504         https://bugs.webkit.org/show_bug.cgi?id=50530
3505
3506         * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
3507         * WebView/WebHTMLView.mm:
3508         (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
3509         which is passed through to WebCore.
3510         * WebView/WebPDFView.mm:
3511         (isFrameInRange): Added this helper function.
3512         (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
3513         a check if the frame is in the range.
3514         * WebView/WebView.mm:
3515         (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
3516         (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
3517         parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
3518         * WebView/WebViewPrivate.h:
3519
3520 2010-12-03  Sam Weinig  <sam@webkit.org>
3521
3522         Reviewed by Maciej Stachowiak.
3523
3524         Enable <a ping> for Mac/Windows/WebKit2 builds
3525         <rdar://problem/8504473>
3526         https://bugs.webkit.org/show_bug.cgi?id=50488
3527
3528         * WebView/WebPreferences.mm:
3529         (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
3530