Export various NSString symbols from WebViewPrivate.h
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
2
3         Export various NSString symbols from WebViewPrivate.h
4         https://bugs.webkit.org/show_bug.cgi?id=168689
5
6         Reviewed by Alexey Proskuryakov.
7
8         * WebKit.exp:
9
10 2017-02-21  Commit Queue  <commit-queue@webkit.org>
11
12         Unreviewed, rolling out r212768.
13         https://bugs.webkit.org/show_bug.cgi?id=168698
14
15         Rolling out since this would break other projects. (Requested
16         by aakashjain on #webkit).
17
18         Reverted changeset:
19
20         "[iOS] Remove old WebKit1 MemoryMeasure helper."
21         https://bugs.webkit.org/show_bug.cgi?id=168675
22         http://trac.webkit.org/changeset/212768
23
24 2017-02-20  Simon Fraser  <simon.fraser@apple.com>
25
26         Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
27         https://bugs.webkit.org/show_bug.cgi?id=168620
28         <rdar://problem/30617772>
29
30         Reviewed by Tim Horton.
31
32         * WebView/WebPreferenceKeysPrivate.h:
33         * WebView/WebPreferences.mm:
34         (+[WebPreferences initialize]):
35         (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
36         (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
37         * WebView/WebPreferencesPrivate.h:
38
39 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
40
41         Export various NSString symbols from WebUIDelegatePrivate.h
42         https://bugs.webkit.org/show_bug.cgi?id=168679
43
44         Reviewed by Joseph Pecoraro.
45
46         * WebKit.exp:
47
48 2017-02-21  Aakash Jain  <aakash_jain@apple.com>
49
50         Export symbols for various classes present in webkit SPI
51         https://bugs.webkit.org/show_bug.cgi?id=168674
52
53         Reviewed by Dan Bernstein.
54
55         * WebKit.exp:
56
57 2017-02-21  Andreas Kling  <akling@apple.com>
58
59         [iOS] Remove old WebKit1 MemoryMeasure helper.
60         <https://webkit.org/b/168675>
61
62         Reviewed by Sam Weinig.
63
64         * Configurations/WebKitLegacy.xcconfig:
65         * Misc/WebCache.mm:
66         (+[WebCache emptyInMemoryResources]):
67         * WebView/WebView.mm:
68
69 2017-02-21  Andreas Kling  <akling@apple.com>
70
71         [iOS] WebKit1 should use shared memory pressure handler code.
72         <https://webkit.org/b/168653>
73
74         Reviewed by Antti Koivisto.
75
76         Register a WebThread-aware memory callback with the shared MemoryPressureHandler
77         and get rid of the old iOS WebKit1 specific implementation. Some of it was even
78         dead code since MobileSafari has been using WebKit2 for quite a while.
79
80         * WebView/WebView.h:
81         * WebView/WebView.mm:
82         (WebInstallMemoryPressureHandler):
83         (+[WebView _handleMemoryWarning]): Deleted.
84         (+[WebView registerForMemoryNotifications]): Deleted.
85         (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
86         (+[WebView garbageCollectNow]): Deleted.
87         (+[WebView purgeInactiveFontData]): Deleted.
88         (+[WebView drainLayerPool]): Deleted.
89         (+[WebView discardAllCompiledCode]): Deleted.
90         (+[WebView _clearMemoryPressure]): Deleted.
91         (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
92         * WebView/WebViewPrivate.h:
93
94 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
95
96         Stop exporting interface WebCoreScrollView on iOS
97         https://bugs.webkit.org/show_bug.cgi?id=168536
98
99         Reviewed by Dan Bernstein.
100
101         * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
102         * WebKit.mac.exp: Ditto.
103         * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
104
105 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
106
107         Exclude various mac-specific header files from iOS build
108         https://bugs.webkit.org/show_bug.cgi?id=168621
109
110         Reviewed by Dan Bernstein.
111
112         * Configurations/WebKitLegacy.xcconfig:
113
114 2017-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
115
116         Add plumbing to the UI process for TextIndicatorData when computing the drag image
117         https://bugs.webkit.org/show_bug.cgi?id=168583
118         Work towards <rdar://problem/30313681>
119
120         Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
121
122         Reviewed by Tim Horton.
123
124         * WebView/WebHTMLView.mm:
125         (-[WebHTMLView _selectionDraggingImage]):
126         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
127
128 2017-02-17  Anders Carlsson  <andersca@apple.com>
129
130         Add a new drag code path and use it for dragging plain text
131         https://bugs.webkit.org/show_bug.cgi?id=168534
132
133         Reviewed by Geoffrey Garen.
134
135         * WebCoreSupport/WebDragClient.h:
136         Add new members.
137
138         * WebCoreSupport/WebDragClient.mm:
139         (WebDragClient::useLegacyDragClient):
140         Return false here.
141
142         (WebDragClient::beginDrag):
143         New client member function. Create an NSDraggingItem and use it to begin a dragging session.
144
145         * WebView/WebHTMLView.mm:
146         (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
147         Get the source operation mask from WebCore.
148
149         (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
150         Send a fake mouse up event.
151
152         * WebView/WebHTMLViewInternal.h:
153         Declare that WebHTMLView conforms to NSDraggingSource.
154
155 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
156
157         List of WebCore symbols to re-export from WebKitLegacy should be built automatically
158         https://bugs.webkit.org/show_bug.cgi?id=168342
159         rdar://problem/26182266
160
161         Reviewed by Tim Horton.
162
163         * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
164         symbols to re-export.
165
166 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
167
168         Stop exporting DOMTokenList from WebKit
169         https://bugs.webkit.org/show_bug.cgi?id=168544
170
171         Reviewed by Alexey Proskuryakov.
172
173         * WebKit.exp:
174
175 2017-02-20  Alexey Proskuryakov  <ap@apple.com>
176
177         Clean up how WebKit exports _WebCreateFragment
178         https://bugs.webkit.org/show_bug.cgi?id=168579
179
180         Reviewed by Dan Bernstein.
181
182         * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
183         * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
184
185 2017-02-20  Aakash Jain  <aakash_jain@apple.com>
186
187         Stop exporting DOMNodeFilter
188         https://bugs.webkit.org/show_bug.cgi?id=168542
189
190         Reviewed by Alexey Proskuryakov.
191
192         * WebKit.exp:
193
194 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
195
196         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
197         https://bugs.webkit.org/show_bug.cgi?id=167693
198
199         Reviewed by Sergio Villar Senin.
200
201         * Configurations/FeatureDefines.xcconfig:
202         * WebView/WebPreferences.mm:
203         (+[WebPreferences initialize]):
204         * WebView/WebView.mm:
205         (-[WebView _preferencesChanged:]):
206
207 2017-02-15  Brady Eidson  <beidson@apple.com>
208
209         Stop backing up localStorage databases to iCloud by default.
210         <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
211
212         Reviewed by Geoffrey Garen.
213
214         * Misc/WebKitVersionChecks.h:
215         * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
216         (WebKitLinkedOnOrAfter):
217         (setWebKitLinkTimeVersion):
218         (WebKitLinkTimeVersion):
219         (linkedOnOrAfter):
220
221         * Storage/WebStorageManager.mm:
222         (WebKitInitializeStorageIfNecessary):
223
224 2017-02-16  Daniel Bates  <dabates@apple.com>
225
226         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
227         https://bugs.webkit.org/show_bug.cgi?id=168417
228         <rdar://problem/30541748>
229
230         Reviewed by Brent Fulgham.
231
232         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
233         Widget* as it is always called with a valid Widget.
234
235         * WebCoreSupport/WebFrameLoaderClient.h:
236         * WebCoreSupport/WebFrameLoaderClient.mm:
237         (WebFrameLoaderClient::redirectDataToPlugin):
238         * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
239         as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
240         r180570 (2 years ago) though Xcode still references this ordering file (why?).
241
242 2017-02-16  Yusuke Suzuki  <utatane.tea@gmail.com>
243
244         [JSC] Drop PassRefPtr in inspector/
245         https://bugs.webkit.org/show_bug.cgi?id=168420
246
247         Reviewed by Alex Christensen.
248
249         * WebView/WebScriptDebugger.mm:
250         (WebScriptDebugger::handlePause):
251
252 2017-02-16  Simon Fraser  <simon.fraser@apple.com>
253
254         Clean up use of some CALayer-related SPI
255         https://bugs.webkit.org/show_bug.cgi?id=168401
256
257         Reviewed by Tim Horton.
258
259         Include CALayer.h not CATiledLayer.h.
260
261         * WebInspector/WebNodeHighlight.h:
262
263 2017-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
264
265         Fix the build after r212379
266
267         Rubber-stamped by Anders Carlsson.
268
269         * WebCoreSupport/WebDragClient.mm:
270         (WebDragClient::startDrag):
271
272 2017-02-15  Anders Carlsson  <andersca@apple.com>
273
274         Modernize DragClient::startDrag somewhat
275         https://bugs.webkit.org/show_bug.cgi?id=168379
276
277         Reviewed by Tim Horton.
278
279         Update for WebCore changes.
280
281         * WebCoreSupport/WebDragClient.h:
282         * WebCoreSupport/WebDragClient.mm:
283         (WebDragClient::startDrag):
284
285 2017-02-14  Dean Jackson  <dino@apple.com>
286
287         Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
288         https://bugs.webkit.org/show_bug.cgi?id=168339
289
290         Reviewed by Simon Fraser.
291
292         Use a better name.
293
294         * WebView/WebPreferenceKeysPrivate.h:
295         * WebView/WebPreferences.mm:
296         (+[WebPreferences initialize]):
297         (-[WebPreferences forceLowPowerGPUForWebGL]):
298         (-[WebPreferences setForceLowPowerGPUForWebGL:]):
299         (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
300         (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
301         * WebView/WebPreferencesPrivate.h:
302         * WebView/WebView.mm:
303         (-[WebView _preferencesChanged:]):
304
305 2017-02-14  Chris Dumez  <cdumez@apple.com>
306
307         HTML Form Validation bubble should take minimum font size setting into consideration
308         https://bugs.webkit.org/show_bug.cgi?id=168271
309         <rdar://problem/29869869>
310
311         Reviewed by Simon Fraser.
312
313         * WebView/WebView.mm:
314         (-[WebView _contentsOfUserInterfaceItem:]):
315         Return font size used in the validation bubble.
316
317         (-[WebView showFormValidationMessage:withAnchorRect:]):
318         Pass minimum font size setting when constructing the validation bubble.
319
320 2017-02-14  Anders Carlsson  <andersca@apple.com>
321
322         Remove an unused delegate method
323         https://bugs.webkit.org/show_bug.cgi?id=168328
324
325         Reviewed by Wenson Hsieh.
326
327         * DefaultDelegates/WebDefaultUIDelegate.m:
328         (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
329
330 2017-02-14  Alexey Proskuryakov  <ap@apple.com>
331
332         WebCore shouldn't export SystemMemory.h
333         https://bugs.webkit.org/show_bug.cgi?id=168285
334
335         Reviewed by Alex Christensen.
336
337         * MigrateHeaders.make: And WebKit shouldn't re-export it.
338
339 2017-02-13  Alexey Proskuryakov  <ap@apple.com>
340
341         WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
342         https://bugs.webkit.org/show_bug.cgi?id=168282
343
344         Reviewed by Dan Bernstein.
345
346         * MigrateHeaders.make:
347
348 2017-02-12  Dan Bernstein  <mitz@apple.com>
349
350         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
351
352         * WebView/WebHTMLView.mm:
353         (createShareMenuItem): Use non-deprecated method.
354
355 2017-02-12  Dan Bernstein  <mitz@apple.com>
356
357         [Cocoa] Some -respondsToSelector: checks are unnecessary
358         https://bugs.webkit.org/show_bug.cgi?id=168183
359
360         Reviewed by Tim Horton.
361
362         * WebView/WebFullScreenController.mm:
363         (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
364           responds to -isOnActiveSpace.
365         (-[WebFullScreenController exitFullScreen]): Ditto.
366         (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
367           NSApplication responds to -setPresentationOptions.
368
369         * WebView/WebHTMLView.mm:
370         (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
371         (-[WebHTMLView otherMouseDown:]): Ditto.
372
373         * WebView/WebImmediateActionController.mm:
374         (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
375         (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
376
377         * WebView/WebView.mm:
378         (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
379         (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
380
381 2017-02-10  Daniel Bates  <dabates@apple.com>
382
383         Detach frame from document when entering page cache
384         https://bugs.webkit.org/show_bug.cgi?id=166774
385         <rdar://problem/29904368>
386
387         Reviewed by Chris Dumez.
388
389         * WebView/WebPreferenceKeysPrivate.h:
390         * WebView/WebPreferences.mm:
391         (+[WebPreferences initialize]):
392         (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
393         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
394         * WebView/WebPreferencesPrivate.h:
395         * WebView/WebView.mm:
396         (-[WebView _preferencesChanged:]):
397
398 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
399
400         [Resource Timing] Enable Resource Timing by default in Tests
401         https://bugs.webkit.org/show_bug.cgi?id=168145
402
403         Reviewed by Ryosuke Niwa.
404
405         * WebView/WebPreferenceKeysPrivate.h:
406         * WebView/WebPreferences.mm:
407         (+[WebPreferences initialize]):
408         (-[WebPreferences resourceTimingEnabled]):
409         (-[WebPreferences setResourceTimingEnabled:]):
410         * WebView/WebPreferencesPrivate.h:
411         * WebView/WebView.mm:
412         (-[WebView _preferencesChanged:]):
413
414 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
415
416         cleanup WebLocalizableStrings.
417         https://bugs.webkit.org/show_bug.cgi?id=168078
418
419         Reviewed by Alexey Proskuryakov.
420
421         * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle 
422         as it's for each framework's own consumption, and never needs to be exported.
423
424 2017-02-10  Aakash Jain  <aakash_jain@apple.com>
425
426         WebResourceLoadDelegatePrivate.h cannot be imported standalone
427         https://bugs.webkit.org/show_bug.cgi?id=168096
428
429         Reviewed by Alexey Proskuryakov.
430
431         * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger. 
432
433 2017-02-09  Antti Koivisto  <antti@apple.com>
434
435         Remove most cases of #if ENABLE(CACHE_PARTITIONING)
436         https://bugs.webkit.org/show_bug.cgi?id=167990
437
438         Reviewed by Sam Weinig.
439
440         * Misc/WebCache.mm:
441         (+[WebCache addImageToCache:forURL:forFrame:]):
442         (+[WebCache removeImageFromCacheForURL:forFrame:]):
443         * WebCoreSupport/WebSystemInterface.mm:
444         (InitWebCoreSystemInterface):
445
446 2017-02-07  Alexey Proskuryakov  <ap@apple.com>
447
448         Don't migrate WebKit DOM headers in MigrateHeaders.make
449         https://bugs.webkit.org/show_bug.cgi?id=167608
450
451         Reviewed by Darin Adler.
452
453         Stop migrating DOM headers that are now in WebKit.
454
455         * DOM/DOMDOMImplementation.h: Removed.
456         * DOM/DOMDOMImplementation.mm: Removed.
457         * DOM/DOMDOMImplementationInternal.h: Removed.
458         * DOM/DOMDOMTokenList.h: Removed.
459         * DOM/DOMDOMTokenList.mm: Removed.
460         * DOM/DOMDOMTokenListInternal.h: Removed.
461         * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
462         * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
463         * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
464         * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
465         * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
466         * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
467         As the files are not in WebCore any more, there is no need to differentiate from
468         WebCore internal headers with the same name. This makes it possible to make these
469         headers private using Xcode mechanisms, as opposed to copying with a shell script.
470
471         * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
472         files don't have it.
473
474         * DOM/DOMCore.h:
475         * DOM/DOMDocument.mm:
476         * DOM/DOMHTMLAnchorElement.mm:
477         * DOM/DOMHTMLAreaElement.mm:
478         * DOM/DOMHTMLLinkElement.mm:
479         * DOM/DOMUtility.mm:
480         No more "DOMDOM".
481
482         * WebKit.exp:
483         No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
484         renaming it is likely to be safe.
485
486         * MigrateHeaders.make: Don't migrate WebKit headers.
487
488         * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
489         on macOS.
490
491 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
492
493         Don't re-export PluginData.h from WebKit
494         https://bugs.webkit.org/show_bug.cgi?id=168020
495
496         Reviewed by Alexey Proskuryakov.
497
498         * MigrateHeaders.make: Removed PluginData.h
499
500 2017-02-08  Aakash Jain  <aakash_jain@apple.com>
501
502         Don't re-export WKUtilities.h from WebKit
503         https://bugs.webkit.org/show_bug.cgi?id=167977
504
505         Reviewed by Alexey Proskuryakov.
506
507         * MigrateHeaders.make: Removed WKUtilities.h
508
509 2017-02-06  Alex Christensen  <achristensen@webkit.org>
510
511         credentials should be partitioned by main document domain
512         https://bugs.webkit.org/show_bug.cgi?id=166998
513         rdar://problem/22901123
514
515         Reviewed by Brady Eidson.
516
517         * Misc/WebDownload.mm:
518         * Plugins/WebBaseNetscapePluginView.mm:
519         (WebKit::getAuthenticationInfo):
520         Don't use partitioned credentials for WebKit1 plugins or downloads.
521         Downloads should be authenticated before becoming a download anyways.
522
523 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
524
525         Rename AnimationController to CSSAnimationController
526         https://bugs.webkit.org/show_bug.cgi?id=167829
527
528         Reviewed by Simon Fraser.
529
530         * WebView/WebFrame.mm:
531         * WebView/WebView.mm:
532
533 2017-02-03  Chris Dumez  <cdumez@apple.com>
534
535         Dismiss HTML form validation popover when pressing Escape key
536         https://bugs.webkit.org/show_bug.cgi?id=167716
537         <rdar://problem/29872943>
538
539         Reviewed by Simon Fraser.
540
541         Override ValidationMessageClient::hideAnyValidationMessage().
542
543         * WebCoreSupport/WebValidationMessageClient.h:
544         * WebCoreSupport/WebValidationMessageClient.mm:
545         (WebValidationMessageClient::hideAnyValidationMessage):
546
547 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
548
549         Drag images should be anchored to the mouse location
550         https://bugs.webkit.org/show_bug.cgi?id=167690
551         <rdar://problem/30295261>
552
553         Reviewed by Enrica Casucci.
554
555         Adds some plumbing for the anchor point in the WK1 client layer.
556
557         * WebCoreSupport/WebDragClient.h:
558         * WebCoreSupport/WebDragClient.mm:
559         (WebDragClient::startDrag):
560
561 2017-02-02  Chris Dumez  <cdumez@apple.com>
562
563         Rename Node::inDocument() to isConnected()
564         https://bugs.webkit.org/show_bug.cgi?id=167743
565
566         Reviewed by Sam Weinig.
567
568         Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
569         - https://dom.spec.whatwg.org/#connected
570
571         * DOM/DOMNode.mm:
572         (-[DOMNode isConnected]):
573         * WebView/WebFrame.mm:
574         (-[WebFrame selectNSRange:onElement:]):
575
576 2017-02-02  Chris Dumez  <cdumez@apple.com>
577
578         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
579         https://bugs.webkit.org/show_bug.cgi?id=167738
580         <rdar://problem/30229990>
581
582         Reviewed by Andreas Kling.
583
584         The BackForwardClient no longer needs to worry about removing HistoryItems
585         from the PageCache now that WebCore takes care of it.
586
587         * History/BackForwardList.mm:
588         (BackForwardList::close):
589
590 2017-02-02  Yongjun Zhang  <yongjun_zhang@apple.com>
591
592         In iOS, we should take background assertion when accessing localstorage databases.
593         https://bugs.webkit.org/show_bug.cgi?id=165478
594
595         Move database transaction background task handling code from WebDatabaseManager to
596         WebCore's WebSQLiteDatabaseTrackerClient.
597
598         Reviewed by Brady Eidson.
599
600         * Storage/WebDatabaseManager.mm:
601         * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
602         * WebCoreSupport/WebApplicationCache.mm:
603         (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
604         * WebView/WebView.mm:
605         (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
606
607 2017-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
608
609         [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
610         https://bugs.webkit.org/show_bug.cgi?id=167695
611         <rdar://problem/30305390>
612
613         Reviewed by Sam Weinig.
614
615         Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
616         exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
617         is destroyed.
618
619         * WebView/WebView.mm:
620         (-[WebView _commonInitializationWithFrameName:groupName:]):
621
622 2017-01-31  Joseph Pecoraro  <pecoraro@apple.com>
623
624         ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
625         https://bugs.webkit.org/show_bug.cgi?id=167684
626
627         Reviewed by Dan Bernstein.
628
629         * DOM/DOMHTML.mm:
630         (-[DOMHTMLInputElement _isAutofilled]): Deleted.
631         (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
632         Consolidate in the WebDOMOperationsPrivate category.
633
634         * DOM/DOMPrivate.h:
635         Include WebDOMOperationsPrivate header to get other DOM Private categories.
636
637         * DOM/WebDOMOperations.mm:
638         (-[DOMHTMLInputElement _isAutofilled]):
639         * DOM/WebDOMOperationsPrivate.h:
640         Include getter alongside the setter.
641
642 2017-01-31  Jessie Berlin  <jberlin@webkit.org>
643
644         Build fix.
645
646         * Misc/WebNSPasteboardExtras.mm:
647         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
648         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
649         * WebView/WebHTMLView.mm:
650         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
651         (-[WebHTMLView copyFont:]):
652
653 2017-01-30  Andy Estes  <aestes@apple.com>
654
655         [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
656         https://bugs.webkit.org/show_bug.cgi?id=167625
657
658         Reviewed by Andreas Kling.
659
660         * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
661         * WebCoreSupport/WebFrameLoaderClient.mm:
662         (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
663         (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
664
665 2017-01-30  Chris Dumez  <cdumez@apple.com>
666
667         Drop legacy Attributes.isId attribute
668         https://bugs.webkit.org/show_bug.cgi?id=167603
669
670         Reviewed by Ryosuke Niwa.
671
672         Keep Attr.isId in ObjC bindings.
673
674         * DOM/DOMAttr.mm:
675         (-[DOMAttr isId]):
676
677 2017-01-30  Andreas Kling  <akling@apple.com>
678
679         [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
680         <https://webkit.org/b/167580>
681
682         Reviewed by Antti Koivisto.
683
684         Avoid the implicit strong capture of self by keeping it in a __block variable.
685         Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
686         This fixes huge WebHTMLView leaks seen on the leaks bot.
687
688         * WebView/WebHTMLView.mm:
689         (-[WebHTMLViewPrivate dealloc]):
690         (-[WebHTMLView viewDidMoveToWindow]):
691
692 2017-01-29  Andy Estes  <aestes@apple.com>
693
694         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
695         https://bugs.webkit.org/show_bug.cgi?id=167563
696         <rdar://problem/30253207>
697
698         Reviewed by Andreas Kling.
699
700         Instead of only saving QuickLook documents to a temporary file when the client is
701         MobileSafari, base this decision on a WebPreference that clients can choose to enable.
702
703         This also changes the SPI for accessing the temporary file path and UTI. Instead of
704         -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
705         the frame that saved the QuickLook document, the content dictionary is now stored as a
706         property of WebDataSource.
707
708         This also removes the manual lifetime management of the QLPreviewConverter from
709         QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
710         which ensures it lives long enough to respond to subresource requests.
711
712         New API test: QuickLook.LegacyQuickLookContent
713
714         * WebCoreSupport/WebFrameLoaderClient.mm:
715         (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
716         write a temporary file to here from the QuickLookDocumentWriter constructor.
717         * WebView/WebDataSource.mm: Declared _quickLookContent.
718         (-[WebDataSource _quickLookContent]):
719         (-[WebDataSource _setQuickLookContent:]):
720         * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
721         * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
722         * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
723         * WebView/WebPreferences.mm:
724         (-[WebPreferences quickLookDocumentSavingEnabled]):
725         (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
726         * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
727         * WebView/WebView.mm:
728         (-[WebView quickLookContentForURL:]): Changed to always return nil.
729         * WebView/WebViewPrivate.h: Added a comment stating that clients should use
730         -[WebDataSource _quickLookContent] instead.
731
732 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
733
734         Add Link Preload as an off-by-default experimental feature menu item.
735         https://bugs.webkit.org/show_bug.cgi?id=167201
736
737         Reviewed by Ryosuke Niwa.
738
739         * WebView/WebPreferenceKeysPrivate.h:
740         * WebView/WebPreferences.mm:
741         (-[WebPreferences linkPreloadEnabled]):
742         (-[WebPreferences setLinkPreloadEnabled:]):
743         * WebView/WebPreferencesPrivate.h:
744         * WebView/WebView.mm:
745         (-[WebView _preferencesChanged:]):
746
747 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
748
749         Add User Timing Experimental Feature
750         https://bugs.webkit.org/show_bug.cgi?id=167542
751         <rdar://problem/22746307>
752
753         Reviewed by Ryosuke Niwa.
754
755         * WebView/WebPreferenceKeysPrivate.h:
756         * WebView/WebPreferences.mm:
757         (+[WebPreferences initialize]):
758         (-[WebPreferences userTimingEnabled]):
759         (-[WebPreferences setUserTimingEnabled:]):
760         * WebView/WebPreferencesPrivate.h:
761         * WebView/WebView.mm:
762         (-[WebView _preferencesChanged:]):
763         Add setting for User Timing runtime enabled feature.
764
765 2017-01-27  Wenson Hsieh  <wenson_hsieh@apple.com>
766
767         [WK1] Do not prevent the drag client from initializing on Mac
768         https://bugs.webkit.org/show_bug.cgi?id=167541
769
770         Reviewed by Dan Bernstein.
771
772         Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
773         initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
774         This caused certain clients, such as Mail, to crash when a webView closes due to  null dereference.
775
776         * WebCoreSupport/WebDragClient.mm:
777         (WebDragClient::WebDragClient):
778         (WebDragClient::actionMaskForDrag):
779         (WebDragClient::willPerformDragDestinationAction):
780         (WebDragClient::dragSourceActionMaskForPoint):
781         (WebDragClient::willPerformDragSourceAction):
782         (WebDragClient::startDrag):
783         (WebDragClient::declareAndWriteDragImage):
784         (WebDragClient::declareAndWriteAttachment):
785         * WebView/WebView.mm:
786         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
787
788 2017-01-26  Chris Dumez  <cdumez@apple.com>
789
790         Crash when navigating back to a page in PacheCache when one of its frames has been removed
791         https://bugs.webkit.org/show_bug.cgi?id=167421
792         <rdar://problem/30188490>
793
794         Reviewed by Darin Adler.
795
796         Add a new setting allowing layout tests to enable PageCache in a window
797         that has an opener, for convenience.
798
799         * WebView/WebPreferenceKeysPrivate.h:
800         * WebView/WebPreferences.mm:
801         (+[WebPreferences initialize]):
802         (-[WebPreferences allowsPageCacheWithWindowOpener]):
803         (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
804         * WebView/WebPreferencesPrivate.h:
805         * WebView/WebView.mm:
806         (-[WebView _preferencesChanged:]):
807
808 2017-01-26  Keith Miller  <keith_miller@apple.com>
809
810         classInfo should take a VM so it is not materialized from the object on each call
811         https://bugs.webkit.org/show_bug.cgi?id=167424
812
813         Rubber Stamped by Michael Saboff.
814
815         Previously, classInfo() would get the VM from the target's
816         MarkedBlock.  Most callers already have a VM on hand, so it is
817         wasteful to compute the VM from the marked block every time. This
818         patch refactors some of the most common callers of classInfo(),
819         jsDynamicCast and inherits to take a VM as well.
820
821         * DOM/DOM.mm:
822         (+[DOMNode _nodeFromJSWrapper:]):
823         * DOM/DOMUtility.mm:
824         (createDOMWrapper):
825         * DOM/WebDOMOperations.mm:
826         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
827         (WebKit::getObjectID):
828         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
829         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
830         * Plugins/Hosted/ProxyInstance.mm:
831         (WebKit::ProxyRuntimeMethod::finishCreation):
832         (WebKit::ProxyInstance::invokeMethod):
833         * Plugins/Hosted/ProxyRuntimeObject.mm:
834         (WebKit::ProxyRuntimeObject::finishCreation):
835         * WebView/WebFrame.mm:
836         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
837         * WebView/WebView.mm:
838         (+[WebView _reportException:inContext:]):
839         (aeDescFromJSValue):
840         (-[WebView _notificationIDForTesting:]):
841
842 2017-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
843
844         REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
845         https://bugs.webkit.org/show_bug.cgi?id=167472
846         <rdar://problem/30149809>
847
848         Reviewed by Beth Dakin.
849
850         Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
851         initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
852         purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
853         If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
854         previous state, so we should just allow the touch bar to update instead.
855
856         * WebView/WebView.mm:
857         (-[WebView updateTextTouchBar]):
858
859 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
860
861         Crash when setting custom scale factor.
862         https://bugs.webkit.org/show_bug.cgi?id=167369
863
864         Reviewed by Sam Weinig.
865
866         Add null pointer check.
867
868         * WebView/WebView.mm:
869         (-[WebView _setCustomBackingScaleFactor:]):
870
871 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
872
873         Refactor drag and drop implementation on Mac
874         https://bugs.webkit.org/show_bug.cgi?id=167427
875
876         Reviewed by Enrica Casucci.
877
878         Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
879
880         * Misc/WebNSPasteboardExtras.h:
881         * WebCoreSupport/WebDragClient.mm:
882         * WebView/WebFrame.mm:
883         * WebView/WebFrameInternal.h:
884         * WebView/WebHTMLView.mm:
885         * WebView/WebView.mm:
886         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
887
888 2017-01-24  Youenn Fablet  <youennf@gmail.com>
889
890         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
891         https://bugs.webkit.org/show_bug.cgi?id=167294
892
893         Reviewed by Alex Christensen.
894
895         * WebView/WebView.mm:
896         (-[WebView _commonInitializationWithFrameName:groupName:]):
897
898 2017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
899
900         Add support for named pasteboards, pasteboard strategies and platform pasteboards
901         https://bugs.webkit.org/show_bug.cgi?id=167404
902
903         Reviewed by Enrica Casucci.
904
905         Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
906
907         * WebCoreSupport/WebPlatformStrategies.h:
908         * WebCoreSupport/WebPlatformStrategies.mm:
909         (WebPlatformStrategies::writeToPasteboard):
910         (WebPlatformStrategies::getPasteboardItemsCount):
911         (WebPlatformStrategies::readBufferFromPasteboard):
912         (WebPlatformStrategies::readURLFromPasteboard):
913         (WebPlatformStrategies::readStringFromPasteboard):
914
915 2017-01-25  Aakash Jain  <aakash_jain@apple.com>
916
917         LoadWebLocalizedStrings method should be moved in correct file
918         https://bugs.webkit.org/show_bug.cgi?id=167393
919
920         Reviewed by Alexey Proskuryakov.
921
922         * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
923         * Misc/WebLocalizableStrings.mm:
924         (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
925         (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
926
927 2017-01-24  Zalan Bujtas  <zalan@apple.com>
928
929         Add simple line layout toggle to MiniBrowser
930         https://bugs.webkit.org/show_bug.cgi?id=167405
931
932         Reviewed by Andreas Kling.
933
934         * WebView/WebPreferenceKeysPrivate.h:
935         * WebView/WebPreferences.mm:
936         (+[WebPreferences initialize]):
937         (-[WebPreferences simpleLineLayoutEnabled]):
938         (-[WebPreferences setSimpleLineLayoutEnabled:]):
939         * WebView/WebPreferencesPrivate.h:
940         * WebView/WebView.mm:
941         (-[WebView _preferencesChanged:]):
942
943 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
944
945         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
946         https://bugs.webkit.org/show_bug.cgi?id=167394
947
948         Reviewed by Ryosuke Niwa.
949
950         * Configurations/FeatureDefines.xcconfig:
951
952 2017-01-23  Chris Dumez  <cdumez@apple.com>
953
954         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
955         https://bugs.webkit.org/show_bug.cgi?id=167308
956         <rdar://problem/30144964>
957
958         Unreviewed, do a partial revert of r211033 to fix assertion.
959
960         * WebCoreSupport/WebChromeClient.h:
961         * WebCoreSupport/WebChromeClient.mm:
962         (WebChromeClient::exitFullScreenForElement):
963
964 2017-01-23  Joseph Pecoraro  <pecoraro@apple.com>
965
966         Remove allowWindowOpenWithoutUserGesture setting
967         https://bugs.webkit.org/show_bug.cgi?id=167301
968
969         Reviewed by Darin Adler.
970
971         * WebView/WebView.mm:
972         (-[WebView _preferencesChanged:]):
973         Use the equivalent existing setting.
974
975 2017-01-20  Darin Adler  <darin@apple.com>
976
977         Remove PassRefPtr from "page" directory of WebCore, also deploy references
978         https://bugs.webkit.org/show_bug.cgi?id=167224
979
980         Reviewed by Chris Dumez.
981
982         * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
983         (-[WebApplicationCacheQuotaManager quota]): Pass reference.
984
985         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
986         * WebCoreSupport/WebChromeClient.mm:
987         (WebChromeClient::focusedElementChanged): Ditto.
988         (WebChromeClient::createWindow): Ditto.
989         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
990         (WebChromeClient::runJavaScriptAlert): Ditto.
991         (WebChromeClient::runJavaScriptConfirm): Ditto.
992         (WebChromeClient::runJavaScriptPrompt): Ditto.
993         (WebChromeClient::contentsSizeChanged): Ditto.
994         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
995         (WebChromeClient::print): Ditto.
996         (WebChromeClient::exceededDatabaseQuota): Ditto.
997         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
998         (WebChromeClient::createColorChooser): Ditto.
999         (WebChromeClient::elementDidFocus): Ditto.
1000         (WebChromeClient::elementDidBlur): Ditto.
1001         (WebChromeClient::createPopupMenu): Ditto.
1002         (WebChromeClient::createSearchPopupMenu): Ditto.
1003         (WebChromeClient::attachRootGraphicsLayer): Ditto.
1004         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
1005         (WebChromeClient::supportsFullScreenForElement): Ditto.
1006         (WebChromeClient::enterFullScreenForElement): Ditto.
1007         (WebChromeClient::exitFullScreenForElement): Ditto.
1008
1009         * WebView/WebFrame.mm:
1010         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1011         Updated for change to the appendChild function.
1012
1013 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1014
1015         Remove -[WebFrame sendOrientationChangeEvent:] which is unused
1016         https://bugs.webkit.org/show_bug.cgi?id=167276
1017
1018         Reviewed by Alex Christensen.
1019         
1020         It was usurped by -deviceOrientationChanged in 2014.
1021
1022         * WebView/WebFrame.mm:
1023         (-[WebFrame sendOrientationChangeEvent:]): Deleted.
1024         * WebView/WebFramePrivate.h:
1025
1026 2017-01-21  Simon Fraser  <simon.fraser@apple.com>
1027
1028         Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
1029         https://bugs.webkit.org/show_bug.cgi?id=167271
1030
1031         Reviewed by Alex Christensen.
1032         
1033         -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
1034         overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
1035
1036         * WebView/WebView.mm:
1037         (-[WebView _contentsSizeRespectingOverflow]): Deleted.
1038         * WebView/WebViewPrivate.h:
1039
1040 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1041
1042         Remove never changing IndexedDB RuntimeEnabledFeature
1043         https://bugs.webkit.org/show_bug.cgi?id=167278
1044
1045         Reviewed by Darin Adler.
1046
1047         * WebView/WebView.mm:
1048         (-[WebView _preferencesChanged:]):
1049
1050 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1051
1052         Cleanup RuntimeEnabledFeatures
1053         https://bugs.webkit.org/show_bug.cgi?id=167228
1054
1055         Reviewed by Simon Fraser.
1056
1057         * WebView/WebView.mm:
1058         (-[WebView _preferencesChanged:]):
1059
1060 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1061
1062         Remove outdated ENABLE(CSP_NEXT) build flag
1063         https://bugs.webkit.org/show_bug.cgi?id=167252
1064
1065         Reviewed by Brent Fulgham.
1066
1067         * Configurations/FeatureDefines.xcconfig:
1068
1069 2017-01-20  Antoine Quint  <graouts@apple.com>
1070
1071         [Modern Media Controls] Turn modern media controls on by default
1072         https://bugs.webkit.org/show_bug.cgi?id=165668
1073
1074         Reviewed by Dean Jackson.
1075
1076         Enabled modern media controls by default in WK1.
1077
1078         * WebView/WebPreferences.mm:
1079         (+[WebPreferences initialize]):
1080
1081 2017-01-19  Chris Dumez  <cdumez@apple.com>
1082
1083         iterable<> should be enabled on WK1
1084         https://bugs.webkit.org/show_bug.cgi?id=167221
1085         <rdar://problem/30108531>
1086
1087         Reviewed by Youenn Fablet.
1088
1089         * WebView/WebPreferenceKeysPrivate.h:
1090         * WebView/WebPreferences.mm:
1091         (-[WebPreferences setCustomElementsEnabled:]):
1092         (-[WebPreferences DOMIteratorEnabled]): Deleted.
1093         (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
1094         * WebView/WebPreferencesPrivate.h:
1095         * WebView/WebView.mm:
1096         (-[WebView _preferencesChanged:]):
1097
1098 2017-01-19  Chris Dumez  <cdumez@apple.com>
1099
1100         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
1101         https://bugs.webkit.org/show_bug.cgi?id=167215
1102         <rdar://problem/29885052>
1103
1104         Reviewed by Andreas Kling.
1105
1106         Make sure HTML validation bubble gets dismissed when its associated
1107         element's frame gets detached and that we do not crash.
1108
1109         * WebCoreSupport/WebValidationMessageClient.h:
1110         * WebCoreSupport/WebValidationMessageClient.mm:
1111         (WebValidationMessageClient::documentDetached):
1112
1113 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1114
1115         [Cocoa] Variation fonts are erroneously disabled on iOS
1116         https://bugs.webkit.org/show_bug.cgi?id=167172
1117
1118         Reviewed by Simon Fraser.
1119
1120         OpenSource builders don't seem to understand sdk=embedded*.
1121
1122         * Configurations/FeatureDefines.xcconfig:
1123
1124 2017-01-19  Andreas Kling  <akling@apple.com>
1125
1126         ScriptExecutionContext::topOrigin() should return a reference.
1127         <https://webkit.org/b/167190>
1128
1129         Reviewed by Sam Weinig.
1130
1131         * Misc/WebCache.mm:
1132         (+[WebCache addImageToCache:forURL:forFrame:]):
1133         (+[WebCache removeImageFromCacheForURL:forFrame:]):
1134
1135 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1136
1137         Unreviewed fix for the macOS build.
1138
1139         * Carbon/CarbonWindowAdapter.mm:
1140         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1141
1142 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1143
1144         Unreviewed, rolling out r210848.
1145
1146         This change introduced media-related LayoutTest failures and
1147         crashes on macOS.
1148
1149         Reverted changeset:
1150
1151         "[Modern Media Controls] Turn modern media controls on by
1152         default"
1153         https://bugs.webkit.org/show_bug.cgi?id=165668
1154         http://trac.webkit.org/changeset/210848
1155
1156 2017-01-18  Andreas Kling  <akling@apple.com>
1157
1158         Document::securityOrigin() should return a reference.
1159         <https://webkit.org/b/167124>
1160
1161         Reviewed by Sam Weinig.
1162
1163         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1164         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1165         * Plugins/WebNetscapePluginStream.mm:
1166         (WebNetscapePluginStream::WebNetscapePluginStream):
1167         * Plugins/WebNetscapePluginView.mm:
1168         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1169         * Plugins/WebPluginContainerCheck.mm:
1170         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1171         * WebCoreSupport/WebChromeClient.mm:
1172         (WebChromeClient::exceededDatabaseQuota):
1173         * WebCoreSupport/WebFrameLoaderClient.h:
1174         * WebCoreSupport/WebFrameLoaderClient.mm:
1175         (WebFrameLoaderClient::didRunInsecureContent):
1176         * WebCoreSupport/WebGeolocationClient.mm:
1177         (WebGeolocationClient::requestPermission):
1178         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
1179         * WebView/WebFrame.mm:
1180         (-[WebFrame _allowsFollowingLink:]):
1181
1182 2017-01-18  Antoine Quint  <graouts@apple.com>
1183
1184         [Modern Media Controls] Turn modern media controls on by default
1185         https://bugs.webkit.org/show_bug.cgi?id=165668
1186
1187         Reviewed by Dean Jackson.
1188
1189         Enabled modern media controls by default in WK1. 
1190
1191         * WebView/WebPreferences.mm:
1192         (+[WebPreferences initialize]):
1193
1194 2017-01-15  Darin Adler  <darin@apple.com>
1195
1196         Remove PassRefPtr from "loader" directory of WebCore
1197         https://bugs.webkit.org/show_bug.cgi?id=167055
1198
1199         Reviewed by Alex Christensen.
1200
1201         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1202         Also made class final and most functions private and final.
1203         * WebCoreSupport/WebChromeClient.mm:
1204         (WebChromeClient::runOpenPanel): Updated to take references.
1205
1206         * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
1207         * WebCoreSupport/WebEditorClient.mm:
1208         (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
1209         (+[WebUndoStep stepWithUndoStep:]): Ditto.
1210         (-[WebUndoStep step]): Return reference instead of pointer.
1211         (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
1212         (-[WebEditorUndoTarget redoEditing:]): Ditto.
1213         (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
1214         PassRefPtr.
1215         (WebEditorClient::registerUndoStep): Ditto.
1216         (WebEditorClient::registerRedoStep): Ditto.
1217
1218         * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
1219         FrameLoaderClient, marked functions final instead of override.
1220         * WebCoreSupport/WebFrameLoaderClient.mm:
1221         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
1222         pointer instead of PassRefPtr.
1223         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1224         (makeFormFieldValuesDictionary): Take a reference.
1225         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
1226         of PassRefPtr.
1227         (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
1228         of PassRefPtr.
1229         (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
1230         (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
1231         (WebFrameLoaderClient::createPlugin): Ditto.
1232         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
1233         (WebFrameLoaderClient::createNetworkingContext): Ditto.
1234         (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
1235
1236         * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
1237         * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
1238
1239         * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
1240         PassRefPtr. Use RefPtr for class field.
1241         * WebCoreSupport/WebOpenPanelResultListener.mm:
1242         (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
1243         correctly without us declaring anything explicitly.
1244         (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
1245         and let RefPtr do the work.
1246         (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
1247         (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
1248         (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
1249         Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
1250         and uncheckedAppend.
1251
1252         * WebView/WebArchive.mm:
1253         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1254         Updated for changes to LegacyWebArchive.
1255         (-[WebArchive mainResource]): Ditto.
1256         (-[WebArchive subresources]): Ditto.
1257         (-[WebArchive subframeArchives]): Ditto.
1258
1259         * WebView/WebDataSource.mm:
1260         (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
1261         instead of NSEnumerator.
1262         (-[WebDataSource _fileWrapperForURL:]): Use auto.
1263         (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
1264         (-[WebDataSource mainResource]): Ditto.
1265         (-[WebDataSource subresources]): Ditto.
1266         (-[WebDataSource subresourceForURL:]): Ditto.
1267         (-[WebDataSource addSubresource:]): Ditto.
1268
1269         * WebView/WebResource.mm:
1270         (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
1271         (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
1272         care of it
1273         (-[WebResource initWithCoder:]): Pass a reference.
1274         (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
1275         (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
1276         (-[WebResource _coreResource]): Return reference rather than pointer.
1277         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1278         Added code to handle the null case and pass a reference rather than a pointer.
1279         * WebView/WebResourceInternal.h: Updated for the above.
1280
1281 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1282
1283         Unreviewed, rolling out r210834
1284         https://bugs.webkit.org/show_bug.cgi?id=165668
1285
1286         It introduced dozens of test timeouts.
1287
1288         Reverted changeset:
1289         "[Modern Media Controls] Turn modern media controls on by default"
1290         https://bugs.webkit.org/show_bug.cgi?id=165668
1291         http://trac.webkit.org/changeset/210834
1292
1293 2017-01-17  Antoine Quint  <graouts@apple.com>
1294
1295         [Modern Media Controls] Turn modern media controls on by default
1296         https://bugs.webkit.org/show_bug.cgi?id=165668
1297
1298         Reviewed by Dean Jackson.
1299
1300         Enabled modern media controls by default in WK1. 
1301
1302         * WebView/WebPreferences.mm:
1303         (+[WebPreferences initialize]):
1304
1305 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1306
1307         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1308         https://bugs.webkit.org/show_bug.cgi?id=116551
1309         <rdar://problem/13949830>
1310
1311         Reviewed by Alex Christensen.
1312
1313         * Configurations/FeatureDefines.xcconfig:
1314
1315 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1316
1317         Crash when closing tab with debugger paused
1318         https://bugs.webkit.org/show_bug.cgi?id=161746
1319         <rdar://problem/15607819>
1320
1321         Reviewed by Brian Burg and Brent Fulgham.
1322
1323         * WebView/WebView.mm:
1324         (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
1325         (WebKit::DeferredPageDestructor::DeferredPageDestructor):
1326         (WebKit::DeferredPageDestructor::tryDestruction):
1327         (-[WebView _close]):
1328         Defer destruction of the Page if we are in a nested runloop.
1329
1330 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1331
1332         Remove the REQUEST_ANIMATION_FRAME flag
1333         https://bugs.webkit.org/show_bug.cgi?id=156980
1334         <rdar://problem/25906849>
1335
1336         Reviewed by Simon Fraser.
1337
1338         * Configurations/FeatureDefines.xcconfig:
1339
1340 2017-01-16  Andy Estes  <aestes@apple.com>
1341
1342         [QuickLook] Do some cleanup in QuickLookHandle
1343         https://bugs.webkit.org/show_bug.cgi?id=166864
1344
1345         Reviewed by Darin Adler.
1346
1347         * WebCoreSupport/WebFrameLoaderClient.mm:
1348         (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
1349         Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
1350
1351 2017-01-15  Tim Horton  <timothy_horton@apple.com>
1352
1353         De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
1354         https://bugs.webkit.org/show_bug.cgi?id=167063
1355
1356         Reviewed by Dan Bernstein.
1357
1358         * WebView/WebHTMLView.mm:
1359         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1360         (-[WebHTMLView _updateFontPanel]):
1361         * WebView/WebView.mm:
1362         (-[WebView typingAttributes]):
1363         Adjust to fontAttributesForSelectionStart returning a RetainPtr.
1364
1365 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1366
1367         Remove ENABLE(DETAILS_ELEMENT) guards
1368         https://bugs.webkit.org/show_bug.cgi?id=167042
1369
1370         Reviewed by Alex Christensen.
1371
1372         * Configurations/FeatureDefines.xcconfig:
1373
1374 2017-01-11  Darin Adler  <darin@apple.com>
1375
1376         Remove PassRefPtr from more of "platform"
1377         https://bugs.webkit.org/show_bug.cgi?id=166809
1378
1379         Reviewed by Sam Weinig.
1380
1381         * WebCoreSupport/WebFrameLoaderClient.mm:
1382         (NetscapePluginWidget::handleEvent): Pass a reference.
1383         * WebView/WebView.mm:
1384         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
1385         Updated since the children set now contains Ref instead of RefPtr.
1386
1387 2017-01-13  Sam Weinig  <sam@webkit.org>
1388
1389         [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
1390         https://bugs.webkit.org/show_bug.cgi?id=167006
1391
1392         Reviewed by Geoffrey Garen.
1393
1394         * WebView/WebDeviceOrientation.mm:
1395         (convert):
1396         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1397         Update for new use of std::optional.
1398
1399 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
1400
1401         Remove unnecessary includes of Page.h
1402         https://bugs.webkit.org/show_bug.cgi?id=166996
1403
1404         Reviewed by Yusuke Suzuki.
1405
1406         * DOM/DOMHTML.mm:
1407         * History/WebBackForwardList.mm:
1408         * Plugins/WebPluginController.mm:
1409         * WebCoreSupport/WebNotificationClient.mm:
1410         * WebCoreSupport/WebPlatformStrategies.mm:
1411         * WebCoreSupport/WebUserMediaClient.mm:
1412         * WebView/WebFullScreenController.mm:
1413
1414 2017-01-12  Chris Dumez  <cdumez@apple.com>
1415
1416         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1417         https://bugs.webkit.org/show_bug.cgi?id=166995
1418
1419         Reviewed by Jer Noble.
1420
1421         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1422         as some people are having trouble building without it.
1423
1424         * Configurations/FeatureDefines.xcconfig:
1425
1426 2017-01-12  Chris Dumez  <cdumez@apple.com>
1427
1428         HTML form validation popover sometimes does not go away
1429         https://bugs.webkit.org/show_bug.cgi?id=166990
1430         <rdar://problem/29985957>
1431
1432         Reviewed by Tim Horton.
1433
1434         Update code using ValidationBubble now that it is RefCounted.
1435
1436         * WebView/WebView.mm:
1437         (-[WebView showFormValidationMessage:withAnchorRect:]):
1438
1439 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1440
1441         Remove pointerLockElement from DOMDocumentPrivate.h
1442         https://bugs.webkit.org/show_bug.cgi?id=166882
1443
1444         Reviewed by Simon Fraser.
1445
1446         Removed pointerLockElement declaration that was supposed to be removed in r209637.
1447
1448         * DOM/DOMDocumentPrivate.h:
1449
1450 2017-01-06  Darin Adler  <darin@apple.com>
1451
1452         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
1453         https://bugs.webkit.org/show_bug.cgi?id=166797
1454
1455         Reviewed by Alex Christensen.
1456
1457         * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
1458         * WebCoreSupport/WebEditorClient.mm:
1459         (WebEditorClient::requestCheckingOfString): Take a reference
1460         instead of a PassRefPtr.
1461
1462 2017-01-05  Chris Dumez  <cdumez@apple.com>
1463
1464         Turn preferLowPowerWebGLRendering setting on by default
1465         https://bugs.webkit.org/show_bug.cgi?id=166737
1466         <rdar://problem/29870033>
1467
1468         Reviewed by Dean Jackson.
1469
1470         Temporarily turn preferLowPowerWebGLRendering setting on by default until
1471         we deal better with WebGL content in background tabs.
1472
1473         * WebView/WebPreferences.mm:
1474         (+[WebPreferences initialize]):
1475
1476 2017-01-05  Enrica Casucci  <enrica@apple.com>
1477
1478         Support File Promise during drag for macOS.
1479         https://bugs.webkit.org/show_bug.cgi?id=165204
1480         rdar://problem/19595567
1481
1482         Reviewed by Tim Horton.
1483
1484         Adds support for dropping a File Promise in a WebView.
1485         The implementation uses new File Promise API available in Sierra.
1486
1487         * Misc/WebNSPasteboardExtras.mm:
1488         (+[NSPasteboard _web_dragTypesForURL]):
1489         * WebView/WebView.mm:
1490         (-[WebView performDragOperation:]):
1491
1492 2017-01-05  Andreas Kling  <akling@apple.com>
1493
1494         Remove ChromeClient::needTouchEvents().
1495         <https://webkit.org/b/166723>
1496
1497         Rubber-stamped by Antti Koivisto.
1498
1499         * WebCoreSupport/WebChromeClient.h:
1500
1501 2017-01-04  Darin Adler  <darin@apple.com>
1502
1503         Remove PassRefPtr use from the "html" directory, other improvements
1504         https://bugs.webkit.org/show_bug.cgi?id=166635
1505
1506         Reviewed by Alex Christensen.
1507
1508         * WebCoreSupport/WebChromeClient.h:
1509         * WebCoreSupport/WebChromeClient.mm:
1510         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
1511
1512 2017-01-04  Ryan Haddad  <ryanhaddad@apple.com>
1513
1514         Unreviewed, rolling out r210287.
1515
1516         This change caused editing test failures on macOS.
1517
1518         Reverted changeset:
1519
1520         "Support File Promise during drag for macOS."
1521         https://bugs.webkit.org/show_bug.cgi?id=165204
1522         http://trac.webkit.org/changeset/210287
1523
1524 2017-01-04  Enrica Casucci  <enrica@apple.com>
1525
1526         Support File Promise during drag for macOS.
1527         https://bugs.webkit.org/show_bug.cgi?id=165204
1528         rdar://problem/19595567
1529
1530         Reviewed by Tim Horton.
1531
1532         Adds support for dropping a File Promise in a WebView.
1533         The implementation uses new File Promise API available in Sierra.
1534
1535         * Misc/WebNSPasteboardExtras.mm:
1536         (+[NSPasteboard _web_dragTypesForURL]):
1537         * WebView/WebView.mm:
1538         (-[WebView performDragOperation:]):
1539
1540 2017-01-04  Tim Horton  <timothy_horton@apple.com>
1541
1542         Provide a setting for clients to always prefer low-power WebGL
1543         https://bugs.webkit.org/show_bug.cgi?id=166675
1544         <rdar://problem/29834093>
1545
1546         Reviewed by Dan Bernstein.
1547
1548         * WebView/WebPreferenceKeysPrivate.h:
1549         * WebView/WebPreferences.mm:
1550         (+[WebPreferences initialize]):
1551         (-[WebPreferences preferLowPowerWebGLRendering]):
1552         (-[WebPreferences setPreferLowPowerWebGLRendering:]):
1553         * WebView/WebPreferencesPrivate.h:
1554         * WebView/WebView.mm:
1555         (-[WebView _preferencesChanged:]):
1556         Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
1557
1558 2017-01-03  Tim Horton  <timothy_horton@apple.com>
1559
1560         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
1561         https://bugs.webkit.org/show_bug.cgi?id=166450
1562         <rdar://problem/29447824>
1563
1564         Reviewed by Darin Adler.
1565
1566         * WebCoreSupport/CorrectionPanel.h:
1567         * WebCoreSupport/CorrectionPanel.mm:
1568         (CorrectionPanel::recordAutocorrectionResponse):
1569         (CorrectionPanel::handleAcceptedReplacement):
1570         * WebCoreSupport/WebAlternativeTextClient.mm:
1571         (toCorrectionResponse):
1572         (WebAlternativeTextClient::recordAutocorrectionResponse):
1573         Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
1574         through recordAutocorrectionResponse, for debugging's sake.
1575         Drop the NSView parameter because we don't need it, just the tag.
1576         Convert the new AutocorrectionResponseType value to its corresponding
1577         NSCorrectionResponse value.
1578
1579 2017-01-01  Jeff Miller  <jeffm@apple.com>
1580
1581         Update user-visible copyright strings to include 2017
1582         https://bugs.webkit.org/show_bug.cgi?id=166278
1583
1584         Reviewed by Dan Bernstein.
1585
1586         * Info.plist:
1587
1588 2016-12-30  Darin Adler  <darin@apple.com>
1589
1590         Remove PassRefPtr use from the "dom" directory, related cleanup
1591         https://bugs.webkit.org/show_bug.cgi?id=166569
1592
1593         Reviewed by Alex Christensen.
1594
1595         * WebCoreSupport/WebFrameLoaderClient.mm:
1596         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
1597         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
1598         (WebFrameLoaderClient::setTitle): Ditto.
1599         (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
1600         * WebView/WebFrame.mm:
1601         (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
1602         Not needed now, but useful later if we ever can get rid of the explicit constructors.
1603         (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
1604         * WebView/WebHTMLRepresentation.mm:
1605         (-[WebHTMLRepresentation title]): Updated to use struct.
1606
1607 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
1608
1609         Propagate the source origin as much as possible
1610         https://bugs.webkit.org/show_bug.cgi?id=166348
1611
1612         Reviewed by Darin Adler.
1613
1614         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1615         (WebKit::NetscapePluginInstanceProxy::evaluate):
1616
1617 2016-12-23  Andy Estes  <aestes@apple.com>
1618
1619         [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
1620         https://bugs.webkit.org/show_bug.cgi?id=166471
1621
1622         Reviewed by Andreas Kling.
1623
1624         When DumpRenderTree starts up, it calls
1625         +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
1626         builds, this triggers the ASSERT(isMainThread()) in
1627         NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
1628         started, we are on the main thread, and we are not holding the Web thread lock. This is
1629         causing all layout tests to crash in the iOS WK1 Debug configuration.
1630
1631         * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1632         Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
1633
1634 2016-12-22  Andy Estes  <aestes@apple.com>
1635
1636         Make WebCore::EditorInsertAction an enum class
1637         https://bugs.webkit.org/show_bug.cgi?id=166424
1638
1639         Reviewed by Brent Fulgham.
1640
1641         * WebCoreSupport/WebEditorClient.mm:
1642         (kit):
1643
1644 2016-12-21  Beth Dakin  <bdakin@apple.com>
1645
1646         Holding down on candidates in the TouchBar should show panel on screen
1647         https://bugs.webkit.org/show_bug.cgi?id=166367
1648         -and corresponding-
1649         <rdar://problem/28479236>
1650
1651         Reviewed by Tim Horton.
1652
1653         Stray whitespace.
1654         * WebCoreSupport/WebEditorClient.mm:
1655         (WebEditorClient::handleRequestedCandidates):
1656
1657         Call the version of setCandidates: that takes a rect. We need to keep the helper 
1658         function in WK1 (unlike WK2) since we also use it for testing.
1659         * WebView/WebView.mm:
1660         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1661
1662 2016-12-20  Dean Jackson  <dino@apple.com>
1663
1664         Remove INDIE_UI
1665         https://bugs.webkit.org/show_bug.cgi?id=165881
1666         <rdar://problem/29672532>
1667
1668         Reviewed by Simon Fraser.
1669
1670         The Indie UI work has been discontinued.
1671
1672         * Configurations/FeatureDefines.xcconfig:
1673
1674 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1675
1676         [ES6] Enable ES6 Modules
1677         https://bugs.webkit.org/show_bug.cgi?id=165849
1678
1679         Reviewed by Geoffrey Garen.
1680
1681         * WebView/WebPreferenceKeysPrivate.h:
1682         * WebView/WebPreferences.mm:
1683         (+[WebPreferences initialize]):
1684         (-[WebPreferences es6ModulesEnabled]): Deleted.
1685         (-[WebPreferences setES6ModulesEnabled:]): Deleted.
1686         * WebView/WebPreferencesPrivate.h:
1687         * WebView/WebView.mm:
1688         (-[WebView _preferencesChanged:]):
1689
1690 2016-12-16  Dave Hyatt  <hyatt@apple.com>
1691
1692         [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
1693         https://bugs.webkit.org/show_bug.cgi?id=165968
1694
1695         Reviewed by Andreas Kling.
1696
1697         * DOM/DOMCSS.mm:
1698         (kitClass):
1699         * DOM/DOMCSSPrimitiveValue.mm:
1700         (-[DOMCSSPrimitiveValue getCounterValue]):
1701         (-[DOMCSSPrimitiveValue getRectValue]):
1702         (kit):
1703         * DOM/DOMCSSPrimitiveValueInternal.h:
1704         * DOM/DOMCSSStyleDeclaration.mm:
1705         * DOM/DOMCSSValue.mm:
1706         (kit):
1707         * DOM/DOMCSSValueInternal.h:
1708         * DOM/DOMCSSValueList.mm:
1709         * DOM/DOMCounter.mm:
1710         (kit):
1711         * DOM/DOMCounterInternal.h:
1712         * DOM/DOMRGBColor.mm:
1713         (kit):
1714         * DOM/DOMRGBColorInternal.h:
1715         * DOM/DOMRect.mm:
1716         (kit):
1717         * DOM/DOMRectInternal.h:
1718         * DOM/DOMUtility.mm:
1719         (createDOMWrapper):
1720
1721 2016-12-16  Chris Dumez  <cdumez@apple.com>
1722
1723         HTML form validation bubble should be dismissed on navigation
1724         https://bugs.webkit.org/show_bug.cgi?id=165960
1725         <rdar://problem/29668086>
1726
1727         Reviewed by Simon Fraser.
1728
1729         Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
1730
1731         * WebView/WebView.mm:
1732         (-[WebView _didStartProvisionalLoadForFrame:]):
1733
1734 2016-12-15  Darin Adler  <darin@apple.com>
1735
1736         Use asString instead of toWTFString, toString, or getString when we already checked isString
1737         https://bugs.webkit.org/show_bug.cgi?id=165895
1738
1739         Reviewed by Yusuke Suzuki.
1740
1741         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1742         (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
1743         toWTFString.
1744         * WebView/WebView.mm:
1745         (aeDescFromJSValue): Use asString/value instead of getString.
1746
1747 2016-12-15  Chris Dumez  <cdumez@apple.com>
1748
1749         Make sure HTML validation bubble's state is updated after layout
1750         https://bugs.webkit.org/show_bug.cgi?id=165922
1751         <rdar://problem/29694730>
1752
1753         Reviewed by Simon Fraser.
1754
1755         Make sure HTML validation bubble's state is updated after layout.
1756         In particular, if the validation bubble's associated element has
1757         moved or is no longer visible, we now hide the bubble.
1758
1759         * WebCoreSupport/WebValidationMessageClient.h:
1760         * WebCoreSupport/WebValidationMessageClient.mm:
1761         (WebValidationMessageClient::showValidationMessage):
1762         (WebValidationMessageClient::hideValidationMessage):
1763         (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
1764
1765 2016-12-15  Chris Dumez  <cdumez@apple.com>
1766
1767         Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
1768         https://bugs.webkit.org/show_bug.cgi?id=165904
1769
1770         Reviewed by Sam Weinig.
1771
1772         Update ObjC bindings so they keep building.
1773
1774         * DOM/DOMUIEvent.mm:
1775         (-[DOMUIEvent keyCode]):
1776         (-[DOMUIEvent charCode]):
1777
1778 2016-12-15  Andreas Kling  <akling@apple.com>
1779
1780         Always clear RenderLayer backing stores when going into page cache.
1781         <https://webkit.org/b/165901>
1782
1783         Reviewed by Simon Fraser.
1784
1785         * WebView/WebView.mm:
1786         (+[WebView _setCacheModel:]):
1787
1788 2016-12-12  Alex Christensen  <achristensen@webkit.org>
1789
1790         Remove unused workaround for Silverlight
1791         https://bugs.webkit.org/show_bug.cgi?id=165773
1792
1793         Reviewed by Dean Jackson.
1794
1795         * Plugins/WebNetscapePluginView.mm:
1796         (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
1797         This code was introduced in January 2010.  Microsoft fixed their bug shortly thereafter.
1798         Allowing 6 years for users to update Silverlight is more than enough.
1799         Safari doesn't even use WebKit1 for this any more.
1800         I need this to be removed because this is the only non-WebGL code that needs to link against
1801         the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
1802
1803 2016-12-12  Chris Dumez  <cdumez@apple.com>
1804
1805         Document.visibilityState should use an IDL string enumeration
1806         https://bugs.webkit.org/show_bug.cgi?id=165774
1807
1808         Reviewed by Daniel Bates.
1809
1810         * DOM/DOMDocument.mm:
1811         (-[DOMDocument visibilityState]):
1812         * WebView/WebView.mm:
1813         (kit):
1814
1815 2016-12-12  Jer Noble  <jer.noble@apple.com>
1816
1817         Remove implementation of legacy Mozilla-based Fullscreen API.
1818         https://bugs.webkit.org/show_bug.cgi?id=165689
1819         <rdar://problem/29603053>
1820
1821         Reviewed by Eric Carlson.
1822
1823         * DOM/DOMElement.mm:
1824         (-[DOMElement webkitRequestFullScreen:]):
1825
1826 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
1827
1828         The DOM should have an advancing wavefront opaque root barrier
1829         https://bugs.webkit.org/show_bug.cgi?id=165712
1830
1831         Reviewed by Yusuke Suzuki.
1832         
1833         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
1834
1835         * Misc/WebCoreStatistics.mm:
1836         (+[WebCoreStatistics javaScriptObjectsCount]):
1837         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1838         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1839         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1840         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1841         (+[WebCoreStatistics javaScriptObjectTypeCounts]):
1842         (+[WebCoreStatistics shouldPrintExceptions]):
1843         (+[WebCoreStatistics setShouldPrintExceptions:]):
1844         (+[WebCoreStatistics memoryStatistics]):
1845         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1846         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1847         (identifierFromIdentifierRep):
1848         * Plugins/Hosted/ProxyInstance.mm:
1849         (WebKit::ProxyInstance::getPropertyNames):
1850         * Plugins/WebNetscapePluginStream.mm:
1851         (WebNetscapePluginStream::wantsAllStreams):
1852         * Plugins/WebNetscapePluginView.mm:
1853         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
1854         (-[WebNetscapePluginView privateBrowsingModeDidChange]):
1855         (-[WebNetscapePluginView setWindowIfNecessary]):
1856         (-[WebNetscapePluginView createPluginScriptableObject]):
1857         (-[WebNetscapePluginView getFormValue:]):
1858         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1859         (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
1860         (-[WebNetscapePluginView loadPluginRequest:]):
1861         (-[WebNetscapePluginView _printedPluginBitmap]):
1862         * Plugins/WebPluginController.mm:
1863         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1864         (-[WebPluginController stopOnePlugin:]):
1865         (-[WebPluginController stopOnePluginForPageCache:]):
1866         (-[WebPluginController destroyOnePlugin:]):
1867         (-[WebPluginController startAllPlugins]):
1868         (-[WebPluginController addPlugin:]):
1869
1870 2016-12-09  Dave Hyatt  <hyatt@apple.com>
1871
1872         [CSS Parser] Remove the old CSS Parser
1873         https://bugs.webkit.org/show_bug.cgi?id=165645
1874
1875         Reviewed by Daniel Bates.
1876
1877         * DOM/DOMCSS.mm:
1878         (kitClass):
1879         * DOM/DOMCSSRule.h:
1880
1881 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
1882
1883         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
1884         https://bugs.webkit.org/show_bug.cgi?id=165251
1885
1886         Reviewed by Dean Jackson.
1887
1888         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
1889
1890         * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
1891         * WebView/WebPreferences.mm:
1892         (+[WebPreferences initialize]):
1893         (-[WebPreferences mediaStreamEnabled]):
1894         (-[WebPreferences setMediaStreamEnabled:]):
1895         (-[WebPreferences peerConnectionEnabled]):
1896         (-[WebPreferences setPeerConnectionEnabled:]):
1897         * WebView/WebPreferencesPrivate.h:
1898         * WebView/WebView.mm:
1899         (-[WebView _preferencesChanged:]):
1900
1901 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
1902
1903         Don’t expose pointer lock in WebKit1 Objective-C API
1904         https://bugs.webkit.org/show_bug.cgi?id=165692
1905
1906         Reviewed by Simon Fraser.
1907
1908         * DOM/DOMDocument.mm:
1909         (-[DOMDocument pointerLockElement]): Deleted.
1910         (-[DOMDocument exitPointerLock]): Deleted.
1911         * DOM/DOMElement.mm:
1912         (-[DOMElement requestPointerLock]): Deleted.
1913         * DOM/DOMMouseEvent.mm:
1914         (-[DOMMouseEvent movementX]): Deleted.
1915         (-[DOMMouseEvent movementY]): Deleted.
1916
1917 2016-12-09  Ryosuke Niwa  <rniwa@webkit.org>
1918
1919         document.webkitFullscreenElement leaks elements inside a shadow tree
1920         https://bugs.webkit.org/show_bug.cgi?id=158471
1921
1922         Reviewed by Chris Dumez.
1923
1924         Use the API for bindings to avoid exposing nodes inside a shadow tree.
1925
1926         * DOM/DOMDocument.mm:
1927         (-[DOMDocument webkitCurrentFullScreenElement]):
1928         (-[DOMDocument webkitFullscreenElement]):
1929
1930 2016-12-09  Beth Dakin  <bdakin@apple.com>
1931
1932         Password fields should not show the emoji button in TouchBar
1933         https://bugs.webkit.org/show_bug.cgi?id=165673
1934         -and corresponding-
1935         rdar://problem/29235739
1936
1937         Reviewed by Wenson Hsieh.
1938
1939         This patch adds a new ivar for the password touch bar and password 
1940         candidateListTouchBarItem. Since this TouchBar will actually have a different set 
1941         of identifiers than the plain text TouchBar, it should just have its own variable.
1942
1943         The candidate list should be the only item for passwords.
1944         * WebView/WebView.mm:
1945         (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
1946
1947         Account for _passwordTextTouchBar.
1948         (-[WebView didChangeAutomaticTextCompletion:]):
1949         (-[WebView setUpTextTouchBar:]):
1950         (-[WebView textTouchBar]):
1951
1952         The empty candidates array is not needed. We can just set @[ ] as the candidates 
1953         for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the 
1954         other parts of the code to prevent us from requesting or setting other candidates 
1955         when in a password field. 
1956         (-[WebView updateTextTouchBar]):
1957
1958         Account for _passwordTextTouchBar.
1959         (-[WebView candidateList]):
1960         * WebView/WebViewData.h:
1961
1962 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
1963
1964         Enable SharedArrayBuffer, remove the flag
1965         https://bugs.webkit.org/show_bug.cgi?id=165614
1966
1967         Rubber stamped by Geoffrey Garen.
1968
1969         * WebView/WebPreferencesPrivate.h:
1970
1971 2016-12-07  Dean Jackson  <dino@apple.com>
1972
1973         Remove runtime toggle for pointer-lock
1974         https://bugs.webkit.org/show_bug.cgi?id=165577
1975         <rdar://problems/29566996>
1976
1977         Reviewed by Jon Lee.
1978
1979         Remove any runtime calls to check if pointer-lock is enabled. It's
1980         either compiled in or out.
1981
1982         * WebView/WebPreferenceKeysPrivate.h:
1983         * WebView/WebPreferences.mm:
1984         (-[WebPreferences pointerLockEnabled]): Deleted.
1985         (-[WebPreferences setPointerLockEnabled:]): Deleted.
1986         * WebView/WebPreferencesPrivate.h:
1987         * WebView/WebView.mm:
1988         (-[WebView _preferencesChanged:]):
1989
1990 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
1991
1992         Correct SDKROOT values in xcconfig files
1993         https://bugs.webkit.org/show_bug.cgi?id=165487
1994         rdar://problem/29539209
1995
1996         Reviewed by Dan Bernstein.
1997
1998         Fix suggested by Dan Bernstein.
1999
2000         * Configurations/DebugRelease.xcconfig:
2001
2002 2016-12-05  Simon Fraser  <simon.fraser@apple.com>
2003
2004         Improve the behavior of scroll-into-view when the target is inside position:fixed
2005         https://bugs.webkit.org/show_bug.cgi?id=165354
2006
2007         Reviewed by Zalan Bujtas.
2008
2009         Plumb through 'insideFixed'. We don't get compute it, so behavior from
2010         these call sites won't change.
2011
2012         * WebView/WebFrame.mm:
2013         (-[WebFrame _scrollDOMRangeToVisible:]):
2014         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2015
2016 2016-12-06  Simon Fraser  <simon.fraser@apple.com>
2017
2018         Enable visual viewports by default on Mac, and iOS Wk2
2019         https://bugs.webkit.org/show_bug.cgi?id=165452
2020
2021         Reviewed by Zalan Bujtas.
2022
2023         Turn visual viewports on by default for WK1 on Mac.
2024
2025         * WebView/WebPreferences.mm:
2026         (+[WebPreferences initialize]):
2027
2028 2016-12-05  Dean Jackson  <dino@apple.com>
2029
2030         pointer lock needs to be feature detectable
2031         https://bugs.webkit.org/show_bug.cgi?id=165426
2032         <rdar://problem/29486715>
2033
2034         Reviewed by Antoine Quint.
2035
2036         Set the RuntimeEnabledFeature as preferences
2037         change.
2038
2039         * WebView/WebView.mm:
2040         (-[WebView _preferencesChanged:]):
2041
2042 2016-12-05  Ryan Haddad  <ryanhaddad@apple.com>
2043
2044         Unreviewed, rolling out r209299.
2045
2046         This change appears to have caused LayoutTest failures on
2047         Sierra WK1.
2048
2049         Reverted changeset:
2050
2051         "Improve the behavior of scroll-into-view when the target is
2052         inside position:fixed"
2053         https://bugs.webkit.org/show_bug.cgi?id=165354
2054         http://trac.webkit.org/changeset/209299
2055
2056 2016-12-02  Simon Fraser  <simon.fraser@apple.com>
2057
2058         Improve the behavior of scroll-into-view when the target is inside position:fixed
2059         https://bugs.webkit.org/show_bug.cgi?id=165354
2060
2061         Reviewed by Zalan Bujtas.
2062
2063         Plumb through 'insideFixed'. We don't get compute it, so behavior from
2064         these call sites won't change.
2065
2066         * WebView/WebFrame.mm:
2067         (-[WebFrame _scrollDOMRangeToVisible:]):
2068         (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2069
2070 2016-12-02  Andy Estes  <aestes@apple.com>
2071
2072         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
2073         https://bugs.webkit.org/show_bug.cgi?id=164492
2074
2075         Reviewed by Dan Bernstein.
2076
2077         * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2078         com.apple.$(PRODUCT_NAME:rfc1034identifier).
2079         * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
2080         ${PRODUCT_BUNDLE_IDENTIFIER}.
2081
2082 2016-12-02  Chris Dumez  <cdumez@apple.com>
2083
2084         Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
2085         https://bugs.webkit.org/show_bug.cgi?id=165328
2086
2087         Reviewed by Simon Fraser.
2088
2089         Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
2090
2091         * WebView/WebViewData.mm:
2092         (-[WebViewPrivate init]):
2093
2094 2016-12-02  Chris Dumez  <cdumez@apple.com>
2095
2096         [Mac][WK1] Implement new HTML interactive form validation user interface
2097         https://bugs.webkit.org/show_bug.cgi?id=164483
2098
2099         Reviewed by Simon Fraser.
2100
2101         Implement new HTML interactive form validation user interface on Mac
2102         WK1 and enable it by default.
2103
2104         * WebCoreSupport/WebValidationMessageClient.h: Added.
2105         * WebCoreSupport/WebValidationMessageClient.mm: Added.
2106         (WebValidationMessageClient::WebValidationMessageClient):
2107         (WebValidationMessageClient::~WebValidationMessageClient):
2108         (WebValidationMessageClient::showValidationMessage):
2109         (WebValidationMessageClient::hideValidationMessage):
2110         (WebValidationMessageClient::isValidationMessageVisible):
2111         * WebView/WebHTMLView.mm:
2112         (-[WebHTMLView _frameOrBoundsChanged]):
2113         * WebView/WebView.mm:
2114         (-[WebView _commonInitializationWithFrameName:groupName:]):
2115         (-[WebView _willStartScrollingOrZooming]):
2116         (-[WebView _contentsOfUserInterfaceItem:]):
2117         (-[WebView _scaleWebView:atOrigin:]):
2118         (-[WebView _didScrollDocumentInFrameView:]):
2119         (-[WebView _setZoomMultiplier:isTextOnly:]):
2120         (-[WebView showFormValidationMessage:withAnchorRect:]):
2121         (-[WebView hideFormValidationMessage]):
2122         * WebView/WebViewData.h:
2123         * WebView/WebViewData.mm:
2124         (-[WebViewPrivate init]):
2125         * WebView/WebViewInternal.h:
2126         * WebView/WebViewPrivate.h:
2127
2128 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
2129
2130         Add a runtime flag for SubtleCrypto
2131         https://bugs.webkit.org/show_bug.cgi?id=164982
2132
2133         Reviewed by Brent Fulgham.
2134
2135         * WebView/WebPreferenceKeysPrivate.h:
2136         * WebView/WebPreferences.mm:
2137         (+[WebPreferences initialize]):
2138         (-[WebPreferences subtleCryptoEnabled]):
2139         (-[WebPreferences setSubtleCryptoEnabled:]):
2140         * WebView/WebPreferencesPrivate.h:
2141         * WebView/WebView.mm:
2142         (-[WebView _preferencesChanged:]):
2143
2144 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
2145
2146         Add separate settings and preferences to enable/disable async decoding for large images and animated images
2147         https://bugs.webkit.org/show_bug.cgi?id=165177
2148
2149         Reviewed by Simon Fraser.
2150         
2151         Hook up the async image decoding settings for WebKit1.
2152
2153         * WebView/WebPreferenceKeysPrivate.h:
2154         * WebView/WebPreferences.mm:
2155         (+[WebPreferences initialize]):
2156         (-[WebPreferences largeImageAsyncDecodingEnabled]):
2157         (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
2158         (-[WebPreferences animatedImageAsyncDecodingEnabled]):
2159         (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
2160         (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
2161         (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
2162         * WebView/WebPreferencesPrivate.h:
2163         * WebView/WebView.mm:
2164         (-[WebView _preferencesChanged:]):
2165
2166 2016-11-29  Andy Estes  <aestes@apple.com>
2167
2168         [Cocoa] Enable two clang warnings recommended by Xcode
2169         https://bugs.webkit.org/show_bug.cgi?id=164498
2170
2171         Reviewed by Mark Lam.
2172
2173         * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
2174
2175 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2176
2177         [WTF] Import std::optional reference implementation as WTF::Optional
2178         https://bugs.webkit.org/show_bug.cgi?id=164199
2179
2180         Reviewed by Saam Barati and Sam Weinig.
2181
2182         Use WTF::Optional::value_or.
2183
2184         * DOM/DOMHTMLOptionsCollection.mm:
2185         (-[DOMHTMLOptionsCollection add:index:]):
2186         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2187         (WebKit::NetscapePluginInstanceProxy::evaluate):
2188         * Plugins/WebNetscapePluginView.mm:
2189         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2190         * WebCoreSupport/WebFrameLoaderClient.h:
2191         * WebCoreSupport/WebFrameLoaderClient.mm:
2192         (WebFrameLoaderClient::dispatchDidCommitLoad):
2193         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2194         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2195         (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2196         (WebPaymentCoordinatorClient::completeShippingContactSelection):
2197         (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2198         * WebCoreSupport/WebSecurityOrigin.mm:
2199         (-[WebSecurityOrigin port]):
2200         * WebView/WebHTMLView.mm:
2201         (toAction):
2202         (toTag):
2203
2204 2016-11-26  Sam Weinig  <sam@webkit.org>
2205
2206         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
2207         https://bugs.webkit.org/show_bug.cgi?id=164965
2208
2209         Reviewed by Simon Fraser.
2210
2211         * WebView/WebPreferenceKeysPrivate.h:
2212         * WebView/WebPreferences.mm:
2213         (-[WebPreferences intersectionObserverEnabled]):
2214         (-[WebPreferences setIntersectionObserverEnabled:]):
2215         * WebView/WebPreferencesPrivate.h:
2216         * WebView/WebView.mm:
2217         (-[WebView _preferencesChanged:]):
2218         Add a preference, defaulting to off, for enabling IntersectionObserver.
2219
2220 2016-11-22  Dan Bernstein  <mitz@apple.com>
2221
2222         [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
2223         https://bugs.webkit.org/show_bug.cgi?id=165036
2224         <rdar://problem/5708580>
2225
2226         Reviewed by Alexey Proskuryakov.
2227
2228         * WebView/WebHTMLView.mm:
2229         (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
2230           similarly to what we do in -keyDown: and to what WKWebView does with all key events.
2231
2232 2016-11-21  Alex Christensen  <achristensen@webkit.org>
2233
2234         Fix Sierra CMake build after r208452
2235         https://bugs.webkit.org/show_bug.cgi?id=164437
2236
2237         * WebView/WebView.mm:
2238         (-[WebView updateMediaTouchBar]):
2239         I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
2240         It's needed for playbackSessionInterface to exist.
2241
2242 2016-11-18  Enrica Casucci  <enrica@apple.com>
2243
2244         Refactor drag and drop for WebKit2 to encode DragData message exchange.
2245         https://bugs.webkit.org/show_bug.cgi?id=164945
2246
2247         Reviewed by Tim Horton.
2248
2249         * WebCoreSupport/WebDragClient.h:
2250         * WebCoreSupport/WebDragClient.mm:
2251         (WebDragClient::actionMaskForDrag):
2252         (WebDragClient::willPerformDragDestinationAction):
2253
2254 2016-11-18  Jeremy Jones  <jeremyj@apple.com>
2255
2256         Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
2257         https://bugs.webkit.org/show_bug.cgi?id=163801
2258
2259         Reviewed by Simon Fraser.
2260
2261         Plumb through PointerLockEnabled setting.
2262
2263         * Configurations/FeatureDefines.xcconfig:
2264         * WebCoreSupport/WebChromeClient.mm:
2265         (WebChromeClient::requestPointerUnlock):
2266         * WebView/WebPreferenceKeysPrivate.h:
2267         * WebView/WebPreferences.mm:
2268         (-[WebPreferences pointerLockEnabled]):
2269         (-[WebPreferences setPointerLockEnabled:]):
2270         * WebView/WebPreferencesPrivate.h:
2271         * WebView/WebView.mm:
2272         (-[WebView _preferencesChanged:]):
2273
2274 2016-11-17  Dan Bernstein  <mitz@apple.com>
2275
2276         Try to fix some non-macOS builds.
2277
2278         * WebView/WebView.mm:
2279
2280 2016-11-16  Dave Hyatt  <hyatt@apple.com>
2281
2282         [CSS Parser] Add @supports, @keyframe and media query parsing options
2283         https://bugs.webkit.org/show_bug.cgi?id=164821
2284
2285         Reviewed by Sam Weinig and Zalan Bujtas.
2286
2287         Fix up the create call now that fallback descriptor syntax is gone.
2288
2289         * DOM/DOM.mm:
2290         (-[DOMHTMLLinkElement _mediaQueryMatches]):
2291
2292 2016-11-17  Saam Barati  <sbarati@apple.com>
2293
2294         Remove async/await compile time flag and enable tests
2295         https://bugs.webkit.org/show_bug.cgi?id=164828
2296         <rdar://problem/28639334>
2297
2298         Reviewed by Yusuke Suzuki.
2299
2300         * Configurations/FeatureDefines.xcconfig:
2301
2302 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2303
2304         [JSC] WTF::TemporaryChange with WTF::SetForScope
2305         https://bugs.webkit.org/show_bug.cgi?id=164761
2306
2307         Reviewed by Saam Barati.
2308
2309         * WebView/WebView.mm:
2310         (-[WebView updateTextTouchBar]):
2311
2312 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2313
2314         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
2315         https://bugs.webkit.org/show_bug.cgi?id=164827
2316
2317         Reviewed by Ryosuke Niwa.
2318
2319         * Configurations/FeatureDefines.xcconfig:
2320         * WebView/WebPreferenceKeysPrivate.h:
2321         * WebView/WebPreferences.mm:
2322         (+[WebPreferences initialize]):
2323         (-[WebPreferences es6ModulesEnabled]):
2324         (-[WebPreferences setES6ModulesEnabled:]):
2325         * WebView/WebPreferencesPrivate.h:
2326         * WebView/WebView.mm:
2327         (-[WebView _preferencesChanged:]):
2328
2329 2016-11-14  Alex Christensen  <achristensen@webkit.org>
2330
2331         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
2332         https://bugs.webkit.org/show_bug.cgi?id=164720
2333
2334         Reviewed by Brady Eidson.
2335
2336         * Storage/WebDatabaseManager.mm:
2337         (-[WebDatabaseManager origins]):
2338         (-[WebDatabaseManager databasesWithOrigin:]):
2339         (-[WebDatabaseManager deleteOrigin:]):
2340         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2341         * Storage/WebDatabaseManagerClient.h:
2342         * Storage/WebDatabaseManagerClient.mm:
2343         (DidModifyOriginData::dispatchToMainThread):
2344         (DidModifyOriginData::DidModifyOriginData):
2345         (WebDatabaseManagerClient::dispatchDidModifyOrigin):
2346         (WebDatabaseManagerClient::dispatchDidModifyDatabase):
2347         * Storage/WebDatabaseQuotaManager.mm:
2348         (-[WebDatabaseQuotaManager usage]):
2349         (-[WebDatabaseQuotaManager quota]):
2350         (-[WebDatabaseQuotaManager setQuota:]):
2351         * Storage/WebStorageManager.mm:
2352         (-[WebStorageManager origins]):
2353         (-[WebStorageManager deleteOrigin:]):
2354         * Storage/WebStorageTrackerClient.h:
2355         * Storage/WebStorageTrackerClient.mm:
2356         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2357         * WebCoreSupport/WebSecurityOrigin.mm:
2358         (-[WebSecurityOrigin usage]):
2359         (-[WebSecurityOrigin quota]):
2360         (-[WebSecurityOrigin setQuota:]):
2361
2362 2016-11-13  Darin Adler  <darin@apple.com>
2363
2364         Fix exception handling in SQL database code, streamline and update code
2365         https://bugs.webkit.org/show_bug.cgi?id=164685
2366
2367         Reviewed by Sam Weinig.
2368
2369         * Storage/WebDatabaseManager.mm:
2370         (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
2371         a reference.
2372         (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
2373         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
2374         but continue to use DatabaseManager.
2375         (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
2376         reference.
2377         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
2378
2379         * Storage/WebDatabaseManagerClient.h: Updated to take references.
2380         * Storage/WebDatabaseManagerClient.mm:
2381         (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
2382         members in the class definition.
2383         (DidModifyOriginData::dispatchToMainThread): Take references.
2384         (DidModifyOriginData::DidModifyOriginData): Ditto.
2385         (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
2386         (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
2387         (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
2388         DatabaseTracker::singleton instead of tracker.
2389
2390         * Storage/WebDatabaseQuotaManager.mm:
2391         (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
2392         (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
2393         (-[WebDatabaseQuotaManager quota]): Ditto.
2394         (-[WebDatabaseQuotaManager setQuota:]): Ditto.
2395         * WebCoreSupport/WebSecurityOrigin.mm:
2396         (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
2397         (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
2398         (-[WebSecurityOrigin quota]): Ditto.
2399         (-[WebSecurityOrigin setQuota:]): Ditto.
2400         * WebView/WebFrame.mm:
2401         (-[WebFrame _cacheabilityDictionary]): Pass a reference.
2402
2403 2016-11-12  Darin Adler  <darin@apple.com>
2404
2405         Remove a few assorted uses of ExceptionCode
2406         https://bugs.webkit.org/show_bug.cgi?id=164683
2407
2408         Reviewed by Chris Dumez.
2409
2410         * DOM/DOMDOMImplementation.mm:
2411         (-[DOMImplementation createDocumentType:publicId:systemId:]):
2412         Use raiseOnDOMError instead of much longer hand written equivalent.
2413         (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
2414
2415         * DOM/DOMDocument.mm:
2416         (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
2417         so we are not using a specific exception code.
2418
2419         * DOM/DOMHTMLOptionsCollection.mm:
2420         (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
2421         much longer hand written equivalent.
2422         * DOM/DOMHTMLSelectElement.mm:
2423         (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
2424         statement after calling a "no return" function.
2425
2426         * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
2427         raiseOnDOMError functions that take ExceptionCode; keep the ones that take
2428         Exception and ExceptionOr. Renamed the other overload of raiseDOMException
2429         to raiseDOMErrorException; it is only used as the non-inline implementation
2430         part of the inline raiseOnDOMError function.
2431         * DOM/ExceptionHandlers.mm:
2432         (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
2433         to this source file instead of in the header.
2434         (raiseTypeErrorException): Updated for name change.
2435         (raiseNotSupportedErrorException): Added.
2436
2437 2016-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2438
2439         Hovering over a slotted Text node clears hover state
2440         https://bugs.webkit.org/show_bug.cgi?id=164002
2441         <rdar://problem/29040471>
2442
2443         Reviewed by Simon Fraser.
2444
2445         * WebView/WebImmediateActionController.mm:
2446         (-[WebImmediateActionController performHitTestAtPoint:]):
2447
2448 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2449
2450         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
2451         https://bugs.webkit.org/show_bug.cgi?id=164538
2452         <rdar://problem/8418711>
2453
2454         Reviewed by Ryosuke Niwa.
2455
2456         Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
2457         WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
2458         of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
2459         code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
2460
2461         * DOM/DOMHTML.mm:
2462         (webAutocapitalizeType):
2463         (-[DOMHTMLInputElement _autocapitalizeType]):
2464         (-[DOMHTMLTextAreaElement _autocapitalizeType]):
2465         * DOM/DOMHTMLElement.mm:
2466         (-[DOMHTMLElement autocorrect]):
2467         (-[DOMHTMLElement setAutocorrect:]):
2468         (-[DOMHTMLElement autocapitalize]):
2469         (-[DOMHTMLElement setAutocapitalize:]):
2470         * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
2471         * DOM/DOMHTMLFormElement.mm:
2472         (-[DOMHTMLFormElement autocorrect]): Deleted.
2473         (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
2474         (-[DOMHTMLFormElement autocapitalize]): Deleted.
2475         (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
2476         * DOM/DOMHTMLInputElement.mm:
2477         (-[DOMHTMLInputElement autocorrect]): Deleted.
2478         (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
2479         (-[DOMHTMLInputElement autocapitalize]): Deleted.
2480         (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
2481         * DOM/DOMHTMLInputElementPrivate.h:
2482         * DOM/DOMHTMLTextAreaElement.mm:
2483         (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
2484         (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
2485         (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
2486         (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
2487         * DOM/DOMHTMLTextAreaElementPrivate.h:
2488
2489         We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
2490         change to import DOMHTMLElementPrivate.h directly.
2491
2492         * DOM/DOMPrivate.h:
2493         * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
2494         * MigrateHeaders.make:
2495
2496 2016-11-11  Beth Dakin  <bdakin@apple.com>
2497
2498         Move to modern TouchBar methods
2499         https://bugs.webkit.org/show_bug.cgi?id=164655
2500         -and corresponding-
2501         rdar://problem/29226911
2502
2503         Reviewed by Wenson Hsieh.
2504
2505         customizationDefaultItemIdentifiers -> defaultItemIdentifiers
2506         itemIdentifiers -> defaultItemIdentifiers
2507         defaultItems -> templateItems
2508
2509         * WebView/WebView.mm:
2510         (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
2511         (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
2512         (-[WebView setUpTextTouchBar:]):
2513         (-[WebView updateTextTouchBar]):
2514         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
2515         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
2516
2517 2016-11-11  Darin Adler  <darin@apple.com>
2518
2519         Move Node from ExceptionCode to ExceptionOr
2520         https://bugs.webkit.org/show_bug.cgi?id=164515
2521
2522         Reviewed by Sam Weinig.
2523
2524         * DOM/DOMHTMLSelectElement.mm:
2525         (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
2526         now that it was renamed.
2527         * DOM/DOMNode.mm:
2528         (-[DOMNode setNodeValue:]): Updated exception handling.
2529         (-[DOMNode setPrefix:]): Ditto.
2530         (-[DOMNode setTextContent:]): Ditto.
2531         (-[DOMNode insertBefore:refChild:]): Ditto.
2532         (-[DOMNode replaceChild:oldChild:]): Ditto.
2533         (-[DOMNode removeChild:]): Ditto.
2534         (-[DOMNode appendChild:]): Ditto.
2535         (-[DOMNode cloneNode:]): Ditto.
2536
2537 2016-11-11  Beth Dakin  <bdakin@apple.com>
2538
2539         Get touch bar code building for open source builds
2540         https://bugs.webkit.org/show_bug.cgi?id=164610
2541
2542         Reviewed by Wenson Hsieh.
2543
2544         * WebKitPrefix.h:
2545
2546 2016-11-10  Alex Christensen  <achristensen@webkit.org>
2547
2548         Fix assertion after r208534.
2549         https://bugs.webkit.org/show_bug.cgi?id=160497
2550
2551         * WebView/WebView.mm:
2552         (-[WebView _commonInitializationWithFrameName:groupName:]):
2553         (WebInstallMemoryPressureHandler):
2554         WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
2555         When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
2556         only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
2557
2558 2016-11-10  Alex Christensen  <achristensen@webkit.org>
2559
2560         Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
2561         https://bugs.webkit.org/show_bug.cgi?id=164573
2562
2563         Reviewed by Brady Eidson.
2564
2565         * WebCoreSupport/WebSecurityOrigin.mm:
2566         (-[WebSecurityOrigin databaseIdentifier]):
2567
2568 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2569
2570         MemoryPressureHandler shouldn't know how to release WebCore memory
2571         https://bugs.webkit.org/show_bug.cgi?id=160497
2572
2573         Reviewed by Michael Catanzaro.
2574
2575         Set the low memory handler before installing the memory pressure handler.
2576
2577         * WebView/WebView.mm:
2578         (-[WebView _commonInitializationWithFrameName:groupName:]):
2579
2580 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
2583         https://bugs.webkit.org/show_bug.cgi?id=164501
2584         <rdar://problem/29152282>
2585
2586         Reviewed by Sam Weinig.
2587
2588         Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
2589         instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
2590
2591         * WebView/WebHTMLView.mm:
2592         (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
2593         (-[WebHTMLView attributedString]):
2594         (-[WebHTMLView selectedAttributedString]):
2595         (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
2596
2597 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
2598
2599         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
2600         https://bugs.webkit.org/show_bug.cgi?id=155185
2601         <rdar://problem/11101440>
2602
2603         Reviewed by Brady Eidson.
2604
2605         Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
2606         quirk says that localStorage access should be granted, without needing to grant universal file access.
2607
2608         If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
2609         grants universal file access.
2610
2611         * WebView/WebPreferenceKeysPrivate.h:
2612         * WebView/WebPreferences.mm:
2613         (-[WebPreferences needsLocalStorageQuirk]): Added.
2614         (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
2615         * WebView/WebPreferencesPrivate.h:
2616         * WebView/WebView.mm:
2617         (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
2618
2619 2016-11-09  Alex Christensen  <achristensen@webkit.org>
2620
2621         Clean up Storage code
2622         https://bugs.webkit.org/show_bug.cgi?id=164562
2623
2624         Reviewed by Brady Eidson.
2625
2626         * Storage/WebStorageManager.mm:
2627         (-[WebStorageManager origins]):
2628         (-[WebStorageManager deleteAllOrigins]):
2629         (-[WebStorageManager deleteOrigin:]):
2630         (-[WebStorageManager diskUsageForOrigin:]):
2631         (-[WebStorageManager syncLocalStorage]):
2632         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
2633         (+[WebStorageManager setStorageDatabaseIdleInterval:]):
2634         (+[WebStorageManager closeIdleLocalStorageDatabases]):
2635         (WebKitInitializeStorageIfNecessary):
2636         * WebView/WebView.mm:
2637         (+[WebView _applicationWillTerminate]):
2638
2639 2016-11-09  Beth Dakin  <bdakin@apple.com>
2640
2641         Another attempted build fix.
2642
2643         * WebView/WebView.mm:
2644
2645 2016-11-09  Beth Dakin  <bdakin@apple.com>
2646
2647         Attempted build fix.
2648
2649         * WebView/WebView.mm:
2650
2651 2016-11-09  Darin Adler  <darin@apple.com>
2652
2653         Move Range from ExceptionCode to ExceptionOr
2654         https://bugs.webkit.org/show_bug.cgi?id=164457
2655
2656         Reviewed by Alex Christensen.
2657
2658         * DOM/DOMRange.mm:
2659         (-[DOMRange setStart:offset:]): Updated exception handling.
2660         (-[DOMRange setEnd:offset:]): Ditto.
2661         (-[DOMRange setStartBefore:]): Ditto.
2662         (-[DOMRange setStartAfter:]): Ditto.
2663         (-[DOMRange setEndBefore:]): Ditto.
2664         (-[DOMRange setEndAfter:]): Ditto.
2665         (-[DOMRange selectNode:]): Ditto.
2666         (-[DOMRange selectNodeContents:]): Ditto.
2667         (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
2668         (-[DOMRange deleteContents]): Ditto.
2669         (-[DOMRange extractContents]): Ditto.
2670         (-[DOMRange cloneContents]): Ditto.
2671         (-[DOMRange insertNode:]): Ditto.
2672         (-[DOMRange surroundContents:]): Ditto.
2673         (-[DOMRange createContextualFragment:]): Ditto.
2674         (-[DOMRange compareNode:]): Ditto.
2675         (-[DOMRange intersectsNode:]): Ditto.
2676         (-[DOMRange comparePoint:offset:]): Ditto.
2677         (-[DOMRange isPointInRange:offset:]): Ditto.
2678         (-[DOMRange expand:]): Ditto.
2679         * WebView/WebFrame.mm:
2680         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
2681         (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
2682         This function was incorrectly implemented (set both start and end of
2683         the range to the computed start), not declared in any header file,
2684         not used anywhere inside WebKit, and I also could not find a use of it
2685         in outside-WebKit Apple code.
2686         * mac/DOM/DOMUIKitExtensions.mm:
2687         (-[DOMRange move:inDirection:]): Ditto.
2688         (-[DOMRange extend:inDirection:]): Ditto.
2689
2690 2016-11-09  Darin Adler  <darin@apple.com>
2691
2692         Move EventTarget from ExceptionCode to ExceptionOr
2693         https://bugs.webkit.org/show_bug.cgi?id=164465
2694
2695         Reviewed by Youenn Fablet.
2696
2697         * DOM/DOMNode.mm:
2698         (-[DOMNode dispatchEvent:]): Updated exception handling.
2699
2700 2016-11-09  Chris Dumez  <cdumez@apple.com>
2701
2702         [Mac] Stop using deprecated AppKit enumeration values
2703         https://bugs.webkit.org/show_bug.cgi?id=164494
2704
2705         Reviewed by Darin Adler.
2706
2707         Stop using deprecated AppKit enumeration values.
2708
2709         * Carbon/CarbonWindowAdapter.mm:
2710         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2711         (-[CarbonWindowAdapter sendSuperEvent:]):
2712         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2713         (WebKit::NetscapePluginHostProxy::beginModal):
2714         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2715         (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
2716         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2717         (-[WebHostedNetscapePluginView drawRect:]):
2718         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2719         (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
2720         * WebCoreSupport/PopupMenuMac.mm:
2721         (PopupMenuMac::populate):
2722         (PopupMenuMac::show):
2723         * WebCoreSupport/WebContextMenuClient.mm:
2724         (WebContextMenuClient::showContextMenu):
2725         * WebCoreSupport/WebFrameLoaderClient.mm:
2726         (WebFrameLoaderClient::actionDictionary):
2727         * WebCoreSupport/WebInspectorClient.mm:
2728         (WebInspectorFrontendClient::canAttach):
2729         (-[WebInspectorWindowController window]):
2730         * WebInspector/WebNodeHighlight.mm:
2731         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2732         * WebView/WebFrameView.mm:
2733         (-[WebFrameView keyDown:keyDown:]):
2734         * WebView/WebFullScreenController.mm:
2735         (-[WebFullScreenController init]):
2736         (createBackgroundFullscreenWindow):
2737         * WebView/WebHTMLView.mm:
2738         (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
2739         (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
2740         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2741         (isQuickLookEvent):
2742         (-[WebHTMLView hitTest:]):
2743         (-[WebHTMLView _sendToolTipMouseExited]):
2744         (-[WebHTMLView _sendToolTipMouseEntered]):
2745         (mouseEventIsPartOfClickOrDrag):
2746         (-[WebHTMLView _updateMouseoverWithEvent:]):
2747         (-[WebHTMLView _autoscroll]):
2748         (-[WebHTMLView acceptsFirstResponder]):
2749         (-[WebHTMLView viewDidMoveToWindow]):
2750         (-[WebHTMLView mouseDown:mouseDown:]):
2751         (currentKeyboardEvent):
2752         (-[WebHTMLView _handleStyleKeyEquivalent:]):
2753         (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
2754         * WebView/WebPDFView.mm:
2755         (-[WebPDFView hitTest:]):
2756         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2757         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
2758         * WebView/WebTextCompletionController.mm:
2759         (-[WebTextCompletionController _buildUI]):
2760         (-[WebTextCompletionController _placePopupWindow:]):
2761         * WebView/WebView.mm:
2762         (-[WebView applicationFlags:]):
2763
2764 2016-11-09  Beth Dakin  <bdakin@apple.com>
2765
2766         Support TouchBar in WebKit
2767         https://bugs.webkit.org/show_bug.cgi?id=164437
2768         -and corresponding-
2769         rdar://problem/28876524
2770
2771         Reviewed by Darin Adler.
2772
2773         * WebCoreSupport/WebEditorClient.mm:
2774         (WebEditorClient::respondToChangedSelection):
2775         (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
2776         * WebView/WebHTMLView.mm:
2777         (-[WebHTMLView candidateListTouchBarItem]):
2778         * WebView/WebView.mm:
2779         (-[_WebTextListTouchBarViewController initWithWebView:]):
2780         (-[_WebTextListTouchBarViewController _selectList:]):
2781         (-[_WebTextListTouchBarViewController setCurrentListType:]):
2782         (-[WebTextTouchBarItemController initWithWebView:]):
2783         (-[WebTextTouchBarItemController itemForIdentifier:]):
2784         (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
2785         (-[WebTextTouchBarItemController setTextIsBold:]):
2786         (-[WebTextTouchBarItemController setTextIsItalic:]):
2787         (-[WebTextTouchBarItemController setTextIsUnderlined:]):
2788         (-[WebTextTouchBarItemController _webChangeTextStyle:]):
2789         (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
2790         (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
2791         (-[WebTextTouchBarItemController textColor]):
2792         (-[WebTextTouchBarItemController setTextColor:]):
2793         (-[WebTextTouchBarItemController _webChangeColor:]):
2794         (-[WebTextTouchBarItemController textListViewController]):
2795         (-[WebView _commonInitializationWithFrameName:groupName:]):
2796         (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2797         (-[WebView shouldRequestCandidates]):
2798         (-[WebView forceRequestCandidatesForTesting]):
2799         (-[WebView makeTouchBar]):
2800         (-[WebView touchBar:makeItemForIdentifier:]):
2801         (textCheckingResultFromNSTextCheckingResult):
2802         (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
2803         (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
2804         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2805         (-[WebView _clearPlaybackControlsManager]):
2806         (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
2807         (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
2808         (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
2809         (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
2810         (-[WebView touchBarDidExitCustomization:]):
2811         (-[WebView touchBarWillEnterCustomization:]):
2812         (-[WebView didChangeAutomaticTextCompletion:]):
2813         (-[WebView setUpTextTouchBar:]):
2814         (-[WebView _isRichlyEditable]):
2815         (-[WebView textTouchBar]):
2816         (-[WebView updateTextTouchBar]):
2817         (-[WebView updateMediaTouchBar]):
2818         (-[WebView updateTouchBar]):
2819         (-[WebView prepareForMouseDown]):
2820         (-[WebView prepareForMouseUp]):
2821         (-[WebView webViewAdditionsWillDestroyView]):
2822         (-[WebView candidateList]):
2823         (-[WebView updateWebViewAdditions]): Deleted.
2824         * WebView/WebViewData.h:
2825         * WebView/WebViewInternal.h:
2826         * WebView/WebViewPrivate.h:
2827
2828 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2829
2830         Safari does not emit composition end if blurred for dead key / Japanese IME
2831         https://bugs.webkit.org/show_bug.cgi?id=164369
2832         <rdar://problem/29050439>
2833
2834         Reviewed by Ryosuke Niwa.
2835
2836         When canceling a composition, make sure that we clear the system IME state.
2837
2838         * WebCoreSupport/WebEditorClient.h:
2839         * WebCoreSupport/WebEditorClient.mm:
2840         (WebEditorClient::canceledComposition):
2841
2842 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2843
2844         Add a setting and preferences to enable/disable async image decoding
2845         https://bugs.webkit.org/show_bug.cgi?id=164417
2846
2847         Reviewed by Simon Fraser.
2848
2849         Hook up the asyncImageDecodingEnabled setting for WebKit1.
2850
2851         * WebView/WebPreferenceKeysPrivate.h:
2852         * WebView/WebPreferences.mm:
2853         (+[WebPreferences initialize]):
2854         (-[WebPreferences asyncImageDecodingEnabled]):
2855         (-[WebPreferences setAsyncImageDecodingEnabled:]):
2856         * WebView/WebPreferencesPrivate.h:
2857         * WebView/WebView.mm:
2858         (-[WebView _preferencesChanged:]):
2859
2860 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2861
2862         Remove PassRefPtr from DumpRenderTree
2863         https://bugs.webkit.org/show_bug.cgi?id=164307
2864
2865         Reviewed by Sam Weinig.
2866
2867         * WebView/WebGeolocationPosition.mm:
2868         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2869
2870 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2871
2872         [Readable Streams API] Enable creation of ReadableByteStreamController
2873         https://bugs.webkit.org/show_bug.cgi?id=164014
2874
2875         Reviewed by Youenn Fablet.
2876
2877         Added flag for the byte stream part of Readable Streams API.
2878
2879         * Configurations/FeatureDefines.xcconfig:
2880
2881 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
2882
2883         Remove CUSTOM_ELEMENTS build flag
2884         https://bugs.webkit.org/show_bug.cgi?id=164267
2885
2886         Reviewed by Antti Koivisto.
2887
2888         Removed the build flag.
2889
2890         * Configurations/FeatureDefines.xcconfig:
2891         * WebView/WebPreferences.mm:
2892         (+[WebPreferences initialize]):
2893         * WebView/WebView.mm:
2894         (-[WebView _preferencesChanged:]):
2895
2896 2016-11-01  Eric Carlson  <eric.carlson@apple.com>
2897
2898         [MediaStream] restrict media capture secure connections
2899         https://bugs.webkit.org/show_bug.cgi?id=164234
2900         <rdar://problem/28944906>
2901
2902         Reviewed by Alex Christensen.
2903
2904         * WebView/WebPreferenceKeysPrivate.h:
2905         * WebView/WebPreferences.mm:
2906         (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
2907         (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
2908         (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
2909         * WebView/WebPreferencesPrivate.h:
2910
2911         * WebView/WebView.mm:
2912         (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
2913
2914 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
2915
2916         JSC should support SharedArrayBuffer
2917         https://bugs.webkit.org/show_bug.cgi?id=163986
2918
2919         Reviewed by Keith Miller.
2920         
2921         Support the RuntimeFlag.
2922
2923         * WebView/WebPreferencesPrivate.h:
2924
2925 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2926
2927         [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
2928         https://bugs.webkit.org/show_bug.cgi?id=164236
2929         <rdar://problem/28747712>
2930
2931         Reviewed by Beth Dakin.
2932
2933         See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
2934         dictionary lookup.
2935
2936         * WebCoreSupport/WebEditorClient.mm:
2937         (WebEditorClient::respondToChangedSelection):
2938         * WebView/WebImmediateActionController.mm:
2939         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2940
2941 2016-10-31  Darin Adler  <darin@apple.com>
2942
2943         Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
2944         https://bugs.webkit.org/show_bug.cgi?id=164214
2945
2946         Reviewed by Alex Christensen.
2947
2948         * DOM/DOMCSSPrimitiveValue.mm:
2949         (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
2950         is a reference now.
2951         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
2952
2953         * DOM/DOMDocument.mm:
2954         (-[DOMDocument querySelector:]): Updated exception handling.
2955         (-[DOMDocument querySelectorAll:]): Ditto.
2956         * DOM/DOMDocumentFragment.mm:
2957         (-[DOMDocumentFragment querySelector:]): Ditto.
2958         (-[DOMDocumentFragment querySelectorAll:]): Ditto.
2959         * DOM/DOMElement.mm:
2960         (-[DOMElement querySelector:]): Ditto.
2961         (-[DOMElement querySelectorAll:]): Ditto.
2962
2963 2016-10-31  Darin Adler  <darin@apple.com>
2964
2965         Convert Document from ExceptionCode to Exception
2966         https://bugs.webkit.org/show_bug.cgi?id=164212
2967
2968         Reviewed by Alex Christensen.
2969
2970         * DOM/DOMDocument.mm:
2971         (-[DOMDocument setXmlVersion:]): Updated exception handling.
2972         (-[DOMDocument cookie]): Ditto.
2973         (-[DOMDocument setCookie:]): Ditto.
2974         (-[DOMDocument setBody:]): Ditto.
2975         (-[DOMDocument createElement:]): Ditto.
2976         (-[DOMDocument createCDATASection:]): Ditto.
2977         (-[DOMDocument createProcessingInstruction:data:]): Ditto.
2978         (-[DOMDocument createAttribute:]): Ditto.
2979         (-[DOMDocument createEntityReference:]): Ditto.
2980         (-[DOMDocument importNode:deep:]): Ditto.
2981         (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
2982         (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
2983         (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
2984         (-[DOMDocument adoptNode:]): Ditto.
2985         (-[DOMDocument createEvent:]): Ditto.
2986
2987 2016-10-30  Darin Adler  <darin@apple.com>
2988
2989         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
2990         https://bugs.webkit.org/show_bug.cgi?id=164206
2991
2992         Reviewed by Chris Dumez.
2993
2994         * DOM/DOMElement.mm:
2995         (-[DOMElement setInnerHTML:]): Updated exception handling.
2996         (-[DOMElement setOuterHTML:]): Ditto.
2997         (-[DOMElement setAttribute:value:]): Ditto.
2998         (-[DOMElement setAttributeNode:]): Ditto.
2999         (-[DOMElement removeAttributeNode:]): Ditto.
3000         (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
3001         (-[DOMElement setAttributeNodeNS:]): Ditto.
3002         (-[DOMElement matches:]): Ditto.
3003         (-[DOMElement closest:]): Ditto.
3004         (-[DOMElement webkitMatchesSelector:]): Ditto.
3005         * DOM/DOMHTMLElement.mm:
3006         (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
3007         (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
3008         (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
3009         * DOM/DOMNamedNodeMap.mm:
3010         (-[DOMNamedNodeMap setNamedItem:]): Ditto.
3011         (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
3012         (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
3013         (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
3014
3015 2016-10-29  Darin Adler  <darin@apple.com>
3016
3017         Convert more of DOM from ExceptionCode to Exception
3018         https://bugs.webkit.org/show_bug.cgi?id=164173
3019
3020         Reviewed by Ryosuke Niwa.
3021
3022         * DOM/DOMCharacterData.mm:
3023         (-[DOMCharacterData substringData:length:]): Updated since this
3024         now uses ExceptionOr.
3025         (-[DOMCharacterData insertData:data:]): Ditto.
3026         (-[DOMCharacterData deleteData:length:]): Ditto.
3027         (-[DOMCharacterData replaceData:length:data:]): Ditto.
3028         * DOM/DOMText.mm:
3029         (-[DOMText splitText:]): Ditto.
3030         (-[DOMText replaceWholeText:]): Removed unneeded exception code
3031         handling from function that does not throw an exception.
3032
3033 2016-10-28  Darin Adler  <darin@apple.com>
3034
3035         Move all classes in the HTML directory from ExceptionCode to Exception
3036         https://bugs.webkit.org/show_bug.cgi?id=163876
3037
3038         Reviewed by Sam Weinig.
3039
3040         * DOM/DOMCharacterData.mm:
3041         (-[DOMCharacterData remove]): Updated exception handling.
3042         * DOM/DOMDOMTokenList.mm:
3043         (-[DOMDOMTokenList toggle:force:]): Ditto.
3044         * DOM/DOMDocumentType.mm:
3045         (-[DOMDocumentType remove]): Ditto.
3046         * DOM/DOMElement.mm:
3047         (-[DOMElement remove]): Ditto.
3048         * DOM/DOMHTML.mm:
3049         (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
3050         * DOM/DOMHTMLCanvasElement.mm:
3051         (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
3052         * DOM/DOMHTMLElement.mm:
3053         (-[DOMHTMLElement setInnerText:]): Ditto.
3054         (-[DOMHTMLElement setOuterText:]): Ditto.
3055         (-[DOMHTMLElement setContentEditable:]): Ditto.
3056         * DOM/DOMHTMLInputElement.mm:
3057         (-[DOMHTMLInputElement setMaxLength:]): Ditto.
3058         (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
3059         (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
3060         (-[DOMHTMLInputElement stepUp:]): Ditto.
3061         (-[DOMHTMLInputElement stepDown:]): Ditto.
3062         (-[DOMHTMLInputElement setRangeText:]): Ditto.
3063         (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
3064         * DOM/DOMHTMLMarqueeElement.mm:
3065         (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
3066         * DOM/DOMHTMLMediaElement.mm:
3067         (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
3068         (-[DOMHTMLMediaElement setVolume:]): Ditto.
3069         * DOM/DOMHTMLOptionsCollection.mm:
3070         (-[DOMHTMLOptionsCollection setLength:]): Ditto.
3071         * DOM/DOMHTMLTableElement.mm:
3072         (-[DOMHTMLTableElement setCaption:]): Ditto.
3073         (-[DOMHTMLTableElement setTHead:]): Ditto.
3074         (-[DOMHTMLTableElement setTFoot:]): Ditto.
3075         (-[DOMHTMLTableElement insertRow:]): Ditto.
3076         (-[DOMHTMLTableElement deleteRow:]): Ditto.
3077         * DOM/DOMHTMLTableRowElement.mm:
3078         (-[DOMHTMLTableRowElement insertCell:]): Ditto.
3079         (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
3080         * DOM/DOMHTMLTableSectionElement.mm:
3081         (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
3082         (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
3083         * DOM/DOMHTMLTextAreaElement.mm:
3084         (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
3085         (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
3086         (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
3087         * DOM/DOMHTMLVideoElement.mm:
3088         (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
3089         (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
3090         version (lowercase S) instead of repeating the logic from that method.
3091         (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
3092         * DOM/DOMTimeRanges.mm:
3093         (-[DOMTimeRanges start:]): Updated exception handling.
3094         (-[DOMTimeRanges end:]): Ditto.
3095
3096 2016-10-27  Chris Dumez  <cdumez@apple.com>
3097
3098         Regression(r203601): Caused crashes in iBooks
3099         https://bugs.webkit.org/show_bug.cgi?id=164093
3100         <rdar://problem/28745634>
3101
3102         Reviewed by Darin Adler.
3103
3104         Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
3105         which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
3106
3107         * DOM/DOMNode.mm:
3108         (-[DOMNode compareDocumentPosition:]):
3109
3110 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3111
3112         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
3113         https://bugs.webkit.org/show_bug.cgi?id=163948
3114         <rdar://problem/28921433>
3115
3116         Reviewed by Darin Adler.
3117
3118         Add support for new drag and drop-related EditAction enum values.
3119
3120         * WebCoreSupport/WebEditorClient.mm:
3121         (undoNameForEditAction):
3122
3123 2016-10-27  Dan Bernstein  <mitz@apple.com>
3124
3125         Reapplied the configuration changes from r207934 without breaking iOS builds.
3126
3127         * Configurations/Base.xcconfig:
3128         * Configurations/WebKitLegacy.xcconfig:
3129
3130 2016-10-27  Dan Bernstein  <mitz@apple.com>
3131
3132         Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
3133
3134         * Configurations/Base.xcconfig:
3135         * Configurations/WebKitLegacy.xcconfig:
3136
3137 2016-10-26  Dan Bernstein  <mitz@apple.com>
3138
3139         [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
3140         https://bugs.webkit.org/show_bug.cgi?id=164048
3141
3142         Reviewed by Tim Horton.
3143
3144         * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
3145         * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
3146           headers.
3147
3148         * History/WebBackForwardList.h: Fixed parameter name in @param entry.
3149         * Misc/WebDownload.h: Removed empty entries.
3150         * Misc/WebIconDatabase.h: Remove incorrect @param entries.
3151         * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
3152         * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
3153         * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
3154         * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
3155         * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
3156         * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
3157         * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
3158           Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
3159         * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
3160         * WebView/WebView.h: Changed @method to @property in a couple of places.
3161         * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
3162
3163 2016-10-26  Brian Burg  <bburg@apple.com>
3164
3165         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
3166         https://bugs.webkit.org/show_bug.cgi?id=164046
3167
3168         Reviewed by Joseph Pecoraro.
3169
3170         * WebCoreSupport/WebInspectorClient.h:
3171
3172 2016-10-21  Alex Christensen  <achristensen@webkit.org>
3173
3174         URL::port should return Optional<uint16_t>
3175         https://bugs.webkit.org/show_bug.cgi?id=163806
3176
3177         Reviewed by Darin Adler.
3178
3179         * WebCoreSupport/WebSecurityOrigin.mm:
3180         (-[WebSecurityOrigin port]):
3181
3182 2016-10-24  Dave Hyatt  <hyatt@apple.com>
3183
3184         Remove CSSCharsetRule from the CSS OM
3185         https://bugs.webkit.org/show_bug.cgi?id=163891
3186
3187         Reviewed by Darin Adler.
3188
3189         * DOM/DOMCSSCharsetRule.mm:
3190         (-[DOMCSSCharsetRule encoding]):
3191
3192 2016-10-24  Youenn Fablet  <youenn@apple.com>
3193
3194         Activate WEB_RTC compilation flags for Mac bots
3195         https://bugs.webkit.org/show_bug.cgi?id=163886
3196
3197         Reviewed by Eric Carlson.
3198
3199         * Configurations/FeatureDefines.xcconfig:
3200
3201 2016-10-23  Chris Dumez  <cdumez@apple.com>
3202
3203         addEventListener() / removeEventListener() should use a union for last parameter
3204         https://bugs.webkit.org/show_bug.cgi?id=163863
3205
3206         Reviewed by Darin Adler.
3207
3208         Cast BOOL to bool to help to compiler construct the new variant-type parameter.
3209
3210         * DOM/DOMNode.mm:
3211         (-[DOMNode addEventListener:listener:useCapture:]):
3212         (-[DOMNode addEventListener:::]):
3213         (-[DOMNode removeEventListener:listener:useCapture:]):
3214         (-[DOMNode removeEventListener:::]):
3215
3216 2016-10-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3217
3218         Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
3219         https://bugs.webkit.org/show_bug.cgi?id=163460
3220         <rdar://problem/28784142>
3221
3222         Reviewed by Darin Adler.
3223
3224         Handle new EditAction types for inserting/deleting pending/final compositions.
3225
3226         * WebCoreSupport/WebEditorClient.mm:
3227         (undoNameForEditAction):
3228
3229 2016-10-21  Jeremy Jones  <jeremyj@apple.com>
3230
3231         Implement basic pointer lock behavior for WebKit and WebKit2.
3232         https://bugs.webkit.org/show_bug.cgi?id=162745
3233
3234         Reviewed by Simon Fraser.
3235
3236         Add basic pointer lock functionality. User permission is not yet implemented.
3237
3238         * WebCoreSupport/WebChromeClient.h:
3239         * WebCoreSupport/WebChromeClient.mm:
3240         (WebChromeClient::requestPointerLock):
3241         (WebChromeClient::requestPointerUnlock):
3242
3243 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3244
3245         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3246         https://bugs.webkit.org/show_bug.cgi?id=163374
3247
3248         Reviewed by Darin Adler.
3249
3250         * Configurations/FeatureDefines.xcconfig:
3251
3252 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3253
3254         Revert r207151
3255         https://bugs.webkit.org/show_bug.cgi?id=163675
3256
3257         Reviewed by Brent Fulgham.
3258
3259         * Misc/WebDownload.mm:
3260         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
3261         * Misc/WebDownloadInternal.h:
3262         * WebCoreSupport/WebFrameLoaderClient.mm:
3263         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3264         * WebView/WebPreferences.mm:
3265         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
3266         * WebView/WebView.mm:
3267         (-[WebView scheduleInRunLoop:forMode:]):
3268         (-[WebView unscheduleFromRunLoop:forMode:]):
3269
3270 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
3271
3272         Unreviewed, rolling out r207557.
3273
3274         This change caused animations/font-variations tests to time
3275         out on pre-Sierra Macs.
3276
3277         Reverted changeset:
3278
3279         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
3280         iOS 9"
3281         https://bugs.webkit.org/show_bug.cgi?id=163374
3282         http://trac.webkit.org/changeset/207557
3283
3284 2016-10-19  Chris Dumez  <cdumez@apple.com>
3285
3286         Move HTML Interactive Form Validation behind an experimental flag
3287         https://bugs.webkit.org/show_bug.cgi?id=163673
3288
3289         Reviewed by Daniel Bates.
3290
3291         Re-disable HTML Interactive Form Validation by default on Mac WK1.
3292
3293         * WebView/WebViewData.mm:
3294         (-[WebViewPrivate init]):
3295
3296 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
3297
3298         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
3299         https://bugs.webkit.org/show_bug.cgi?id=163374
3300
3301         Reviewed by Darin Adler.
3302
3303         * Configurations/FeatureDefines.xcconfig:
3304
3305 2016-10-19  Simon Fraser  <simon.fraser@apple.com>
3306
3307         WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
3308         https://bugs.webkit.org/show_bug.cgi?id=163680
3309
3310         Reviewed by Dean Jackson.
3311
3312         Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
3313
3314         * WebView/WebView.mm:
3315         (-[WebView _preferencesChanged:]):
3316
3317 2016-10-19  Darin Adler  <darin@apple.com>
3318
3319         Move XPath from ExceptionCode to Exception
3320         https://bugs.webkit.org/show_bug.cgi?id=163656
3321
3322         Reviewed by Chris Dumez.
3323
3324         * DOM/DOMDocument.mm:
3325         (wrap): Added. Helper function for wrapping a resolver.
3326         (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
3327         (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
3328         * DOM/DOMXPathExpression.mm:
3329         (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
3330         * DOM/DOMXPathResult.mm:
3331         (-[DOMXPathResult numberValue]): Ditto.
3332         (-[DOMXPathResult stringValue]): Ditto.
3333         (-[DOMXPathResult booleanValue]): Ditto.
3334         (-[DOMXPathResult singleNodeValue]): Ditto.
3335         (-[DOMXPathResult snapshotLength]): Ditto.
3336         (-[DOMXPathResult iterateNext]): Ditto.
3337         (-[DOMXPathResult snapshotItem:]): Ditto.
3338
3339 2016-10-18  Sam Weinig  <sam@webkit.org>
3340
3341         Replace std::experimental::variant with WTF::Variant (or similar)
3342         https://bugs.webkit.org/show_bug.cgi?id=163626
3343
3344         Reviewed by Chris Dumez.
3345
3346         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
3347         into the WTF namespace.
3348
3349         * DOM/DOMHTMLSelectElement.mm:
3350         (-[DOMHTMLSelectElement add:before:]):
3351
3352 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
3353
3354         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
3355         https://bugs.webkit.org/show_bug.cgi?id=163627
3356
3357         Reviewed by Dean Jackson.
3358
3359         Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
3360
3361         * WebView/WebViewPrivate.h:
3362
3363 2016-10-18  Dean Jackson  <dino@apple.com>
3364
3365         Remove CSS_SHAPES feature definition. This should always be on.
3366         https://bugs.webkit.org/show_bug.cgi?id=163628
3367         <rdar://problem/28834613>
3368
3369         Reviewed by Tim Horton.
3370
3371         * Configurations/FeatureDefines.xcconfig:
3372
3373 2016-10-18  Chris Dumez  <cdumez@apple.com>
3374
3375         Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
3376         https://bugs.webkit.org/show_bug.cgi?id=163608
3377
3378         Reviewed by Ryosuke Niwa.
3379
3380         Update add() call sites now that it takes std::variant types in.
3381
3382         * DOM/DOMHTMLOptionsCollection.mm:
3383         (-[DOMHTMLOptionsCollection add:index:]):
3384         * DOM/DOMHTMLSelectElement.mm:
3385         (-[DOMHTMLSelectElement add:before:]):
3386
3387 2016-10-18  Anders Carlsson  <andersca@apple.com>
3388
3389         Get rid of more WebHistoryItem cruft
3390         https://bugs.webkit.org/show_bug.cgi?id=163623
3391
3392         Reviewed by Tim Horton.
3393
3394         * History/WebHistoryItem.mm:
3395         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3396         * History/WebHistoryItemPrivate.h:
3397
3398 2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3399
3400         Showing and hiding candidates list is very distracting after selecting word
3401         https://bugs.webkit.org/show_bug.cgi?id=163609
3402         <rdar://problem/28747712>
3403
3404         Reviewed by Tim Horton.
3405
3406         Introduce WebView hooks for mousedown and mouseup. See radar for more details.
3407
3408         * WebView/WebHTMLView.mm:
3409         (-[WebHTMLView mouseDown:mouseDown:]):
3410         (-[WebHTMLView mouseUp:mouseUp:]):
3411         * WebView/WebView.mm:
3412         (-[WebView prepareForMouseDown]):
3413         (-[WebView prepareForMouseUp]):
3414         * WebView/WebViewInternal.h:
3415
3416 2016-10-17  Anders Carlsson  <andersca@apple.com>
3417
3418         Move some history specific HistoryItem code to WebHistoryItem
3419         https://bugs.webkit.org/show_bug.cgi?id=163567
3420
3421         Reviewed by Tim Horton.
3422
3423         * History/HistoryPropertyList.mm:
3424         (HistoryPropertyListWriter::writeHistoryItem):
3425         * History/WebHistory.mm:
3426         (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
3427         * History/WebHistoryItem.mm:
3428         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3429         * History/WebHistoryItemInternal.h:
3430         * WebCoreSupport/WebFrameLoaderClient.mm:
3431         (addRedirectURL):
3432         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
3433
3434 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
3435
3436         [MediaStream] Resolve constraints and enumerate devices in the UI process
3437         https://bugs.webkit.org/show_bug.cgi?id=162147
3438         <rdar://problem/28803569>
3439
3440         Reviewed by Darin Adler.
3441
3442         * WebCoreSupport/WebUserMediaClient.h:
3443         * WebCoreSupport/WebUserMediaClient.mm:
3444         (AddPermissionCheckToMap):
3445         (RemovePermissionCheckFromMap):
3446         (WebUserMediaClient::pageDestroyed):
3447         (WebUserMediaClient::requestUserMediaAccess):
3448         (WebUserMediaClient::enumerateMediaDevices):
3449         (WebUserMediaClient::cancelMediaDevicesEnumerationRequest):
3450         (-[WebUserMediaPolicyListener allow]):
3451         (-[WebUserMediaPolicyListener deny]):
3452         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
3453         (-[WebUserMediaPolicyCheckerListener cancelMediaDevicesEnumerationRequest]):
3454         (-[WebUserMediaPolicyCheckerListener allow]):
3455         (-[WebUserMediaPolicyCheckerListener deny]):
3456         (WebUserMediaClient::checkUserMediaPermission): Deleted.
3457         (WebUserMediaClient::cancelUserMediaPermissionCheck): Deleted.
3458         (-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]): Deleted.
3459         (-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]): Deleted.
3460
3461 2016-10-17  Antti Koivisto  <antti@apple.com>
3462
3463         Rename setNeedsStyleRecalc to invalidateStyle
3464         https://bugs.webkit.org/show_bug.cgi?id=163542
3465
3466         Reviewed by Darin Adler.
3467
3468         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3469         (-[WebHostedNetscapePluginView createPluginLayer]):
3470         * Plugins/WebNetscapePluginView.mm:
3471         (-[WebNetscapePluginView createPlugin]):
3472
3473 2016-10-17  Jeremy Jones  <jeremyj@apple.com>
3474
3475         Enable keyboard in fullscreen.
3476         https://bugs.webkit.org/show_bug.cgi?id=163146
3477
3478         Reviewed by Jer Noble.
3479
3480         Allow keyboard in fullscreen.
3481
3482         * WebView/WebView.mm:
3483         (-[WebView _supportsFullScreenForElement:withKeyboard:]):
3484
3485 2016-10-17  Chris Dumez  <cdumez@apple.com>
3486
3487         Move form.reportValidity() behind InteractiveFormValidation setting
3488         https://bugs.webkit.org/show_bug.cgi?id=163550
3489
3490         Reviewed by Darin Adler.
3491
3492         Enable InteractiveFormValidation setting by default and link it to
3493         RuntimeEnabledFeatures so we can use it in the IDL.
3494
3495         * WebView/WebView.mm:
3496         (-[WebView _preferencesChanged:]):
3497         * WebView/WebViewData.mm:
3498         (-[WebViewPrivate init]):
3499
3500 2016-10-17  Anders Carlsson  <andersca@apple.com>
3501
3502         Fix iOS build.
3503
3504         * History/WebBackForwardList.mm:
3505         (-[WebBackForwardList dictionaryRepresentation]):
3506
3507 2016-10-17  Anders Carlsson  <andersca@apple.com>
3508
3509         CTTE some of the BackForwardList member functions
3510         https://bugs.webkit.org/show_bug.cgi?id=163555
3511
3512         Reviewed by Dan Bernstein.
3513
3514         * History/BackForwardList.h:
3515         (BackForwardList::entries):
3516         * History/BackForwardList.mm:
3517         (BackForwardList::removeItem):
3518         (BackForwardList::containsItem):
3519         (BackForwardList::entries): Deleted.
3520         * History/WebBackForwardList.mm:
3521         (-[WebBackForwardList removeItem:]):
3522         (-[WebBackForwardList containsItem:]):
3523         (-[WebBackForwardList description]):
3524
3525 2016-10-17  Anders Carlsson  <andersca@apple.com>
3526
3527         Remove WEBCORE_EXPORT from BackForwardList, it lives in WebKit now
3528         https://bugs.webkit.org/show_bug.cgi?id=163551
3529
3530         Reviewed by Tim Horton.
3531
3532         * History/BackForwardList.h:
3533
3534 2016-10-16  Darin Adler  <darin@apple.com>
3535
3536         Move CSS classes from ExceptionCode to Exception
3537         https://bugs.webkit.org/show_bug.cgi?id=163494
3538
3539         Reviewed by Sam Weinig.
3540
3541         * DOM/DOMCSSMediaRule.mm:
3542         (-[DOMCSSMediaRule insertRule:index:]): Use raiseOnDOMError
3543         the new way to handle ExceptionOr instead of ExceptionCode.
3544         (-[DOMCSSMediaRule deleteRule:]): Ditto.
3545         * DOM/DOMCSSPrimitiveValue.mm:
3546         (-[DOMCSSPrimitiveValue setFloatValue:floatValue:]): Ditto.
3547         (-[DOMCSSPrimitiveValue getFloatValue:]): Ditto.
3548         (-[DOMCSSPrimitiveValue setStringValue:stringValue:]): Ditto.
3549         (-[DOMCSSPrimitiveValue getStringValue]): Ditto.
3550         (-[DOMCSSPrimitiveValue getCounterValue]): Ditto.
3551         (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
3552         (-[DOMCSSPrimitiveValue getRGBColorValue]): Ditto.