18c7e5a8a7e2dd7cb91dbfb782eb6507b34bdd80
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2015-02-15  Sam Weinig  <sam@webkit.org>
2
3         Add experimental <attachment> element support
4         https://bugs.webkit.org/show_bug.cgi?id=141626
5
6         Reviewed by Tim Horton.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2015-02-14  Joseph Pecoraro  <pecoraro@apple.com>
11
12         [Mac] Possible DDActionContext leaks, RetainPtr cleanup
13         https://bugs.webkit.org/show_bug.cgi?id=141613
14
15         Reviewed by Tim Horton.
16
17         * WebCoreSupport/WebEditorClient.mm:
18         (WebEditorClient::WebEditorClient):
19         Avoid unnecessary retain/autorelease by adopting.
20
21         * WebView/WebActionMenuController.mm:
22         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
23         Adopt the allocated object.
24
25 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
26
27         Web Inspector: remove some unnecessary Inspector prefixes from class names in Inspector namespace
28         https://bugs.webkit.org/show_bug.cgi?id=141372
29
30         Reviewed by Joseph Pecoraro.
31
32         * WebCoreSupport/WebInspectorClient.mm:
33         (-[WebInspectorWindowController destroyInspectorView:]):
34
35 2015-02-14  Alexey Proskuryakov  <ap@apple.com>
36
37         rel="noreferrer" should make window.opener null
38         https://bugs.webkit.org/show_bug.cgi?id=141579
39
40         Reviewed by Darin Adler.
41
42         * WebView/WebPDFView.mm:
43         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for a new WebCore
44         function signature. There is no rel="noreferrer" in PDF, so we can just always allow.
45
46 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
47
48         [Streams API] Implement a barebone ReadableStream interface
49         https://bugs.webkit.org/show_bug.cgi?id=141045
50
51         Reviewed by Benjamin Poulain.
52
53         * Configurations/FeatureDefines.xcconfig:
54
55 2015-02-03  Enrica Casucci  <enrica@apple.com>
56
57         [iOS] Add support for deleteFromInputWithFlags.
58         https://bugs.webkit.org/show_bug.cgi?id=141216
59         rdar://problem/19130081
60
61         Reviewed by Benjamin Poulain.
62
63         Adopts the new method as soon as it is available.
64         The patch also removes some obsolete code used for staging.
65
66         * WebView/WebHTMLView.mm:
67         (-[WebHTMLView _handleEditingKeyEvent:]):
68
69 2015-02-02  Chris Dumez  <cdumez@apple.com>
70
71         Access MemoryCache singleton using MemoryCache::singleton()
72         https://bugs.webkit.org/show_bug.cgi?id=141104
73
74         Reviewed by Andreas Kling.
75
76         Access MemoryCache singleton using MemoryCache::singleton() static
77         member function, instead of a free function, as per the recent
78         coding style discussion on WebKit-dev.
79
80 2015-02-01  Chris Dumez  <cdumez@apple.com>
81
82         Use more references in HistoryItem
83         https://bugs.webkit.org/show_bug.cgi?id=141133
84
85         Reviewed by Andreas Kling.
86
87         Use more references in HistoryItem instead of pointers.
88
89 2015-01-31  Sam Weinig  <sam@webkit.org>
90
91         Remove even more Mountain Lion support
92         https://bugs.webkit.org/show_bug.cgi?id=141124
93
94         Reviewed by Alexey Proskuryakov.
95
96         * Configurations/Base.xcconfig:
97         * Configurations/DebugRelease.xcconfig:
98         * Configurations/FeatureDefines.xcconfig:
99         * Configurations/Version.xcconfig:
100         * Configurations/WebKitLegacy.xcconfig:
101
102 2015-01-30  Eric Carlson  <eric.carlson@apple.com>
103
104         Remove MediaPlayerProxy.h
105         https://bugs.webkit.org/show_bug.cgi?id=141087
106
107         Reviewed by Sam Weinig.
108
109         * MigrateHeaders.make: Don't need to copy MediaPlayerProxy.h.
110         * Plugins/WebPluginController.mm: Don't include MediaPlayerProxy.h.
111
112 2015-01-30  Chris Dumez  <cdumez@apple.com>
113
114         Rename shared() static member functions to singleton() for singleton classes.
115         https://bugs.webkit.org/show_bug.cgi?id=141088
116
117         Reviewed by Ryosuke Niwa and Benjamin Poulain.
118
119         Rename shared() static member functions to singleton() for singleton
120         classes as per the recent coding style change.
121
122 2015-01-29  Beth Dakin  <bdakin@apple.com>
123
124         Remove more Mountain Lion code from WebKit
125         https://bugs.webkit.org/show_bug.cgi?id=141050
126
127         Reviewed by Anders Carlsson.
128
129         * History/WebHistory.mm:
130         (getDayBoundaries):
131         * Panels/WebAuthenticationPanel.m:
132         (-[WebAuthenticationPanel cancel:]):
133         (-[WebAuthenticationPanel logIn:]):
134         (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]):
135         * WebCoreSupport/WebSystemInterface.mm:
136         (InitWebCoreSystemInterface):
137         * WebView/WebFrameView.mm:
138         * WebView/WebPreferences.mm:
139         (+[WebPreferences initialize]):
140         (needsScreenFontsEnabledQuirk):
141         * WebView/WebView.mm:
142         (+[WebView registerForMemoryNotifications]):
143         (-[WebView _preferencesChanged:]):
144         (+[WebView initialize]):
145         (+[WebView _shouldAutomaticQuoteSubstitutionBeEnabled]):
146         (+[WebView _shouldAutomaticDashSubstitutionBeEnabled]):
147         (+[WebView _didChangeAutomaticDashSubstitutionEnabled:]):
148
149 2015-01-29  Sam Weinig  <sam@webkit.org>
150
151         Remove support for screen font substitution
152         https://bugs.webkit.org/show_bug.cgi?id=141038
153
154         Reviewed by Tim Horton.
155
156         * Misc/WebKitNSStringExtras.mm:
157         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
158         (-[NSString _web_widthWithFont:]):
159         * Misc/WebStringTruncator.mm:
160         (fontFromNSFont):
161         Update for new signature of the FontPlatformData constructor, which no longer cares about
162         whether to use printer fonts.
163
164         * WebView/WebPreferenceKeysPrivate.h:
165         Remove the WebKitScreenFontSubstitutionEnabledKey key.
166
167         * WebView/WebPreferences.mm:
168         (+[WebPreferences initialize]):
169         Remove support for WebKitScreenFontSubstitutionEnabledKey.
170
171         (needsScreenFontsEnabledQuirk): Deleted.
172         Remove support for the Mountain Lion era 1-Password quirk.
173
174         (-[WebPreferences screenFontSubstitutionEnabled]): Deleted.
175         (-[WebPreferences setScreenFontSubstitutionEnabled:]): Deleted.
176         * WebView/WebPreferencesPrivate.h:
177         * WebView/WebView.mm:
178         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
179         (-[WebView _preferencesChanged:]):
180         Remove support for the screen font substitution setting.
181
182 2015-01-29  Chris Dumez  <cdumez@apple.com>
183
184         Clean up / modernize PageCache class
185         https://bugs.webkit.org/show_bug.cgi?id=141009
186
187         Reviewed by Darin Adler.
188
189         Clean up / modernize PageCache class.
190
191         * History/WebBackForwardList.mm:
192         (-[WebBackForwardList pageCacheSize]):
193         * WebView/WebView.mm:
194         (-[WebView _loadBackForwardListFromOtherView:]):
195         (-[WebView goToBackForwardItem:]):
196         (+[WebView _setCacheModel:]):
197
198 2015-01-28  Beth Dakin  <bdakin@apple.com>
199
200         Remove Mountain Lion code from WebKit and WebKit2
201         https://bugs.webkit.org/show_bug.cgi?id=141010
202
203         Reviewed by Sam Weinig.
204
205         * DOM/WebDOMOperations.mm:
206         (toNSEventPhase):
207         * WebView/WebHTMLView.mm:
208         (isQuickLookEvent):
209
210 2015-01-28  Dana Burkart  <dburkart@apple.com>
211
212         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
213         https://bugs.webkit.org/show_bug.cgi?id=136765
214
215         Reviewed by Alexey Proskuryakov.
216
217         * Configurations/Base.xcconfig:
218         * Configurations/DebugRelease.xcconfig:
219
220 2015-01-28  Chris Dumez  <cdumez@apple.com>
221
222         Fix typo in markPagesForVistedLinkStyleRecalc()
223         https://bugs.webkit.org/show_bug.cgi?id=140977
224
225         Reviewed by Darin Adler.
226
227         * WebCoreSupport/WebVisitedLinkStore.mm:
228         (WebVisitedLinkStore::removeAllVisitedLinks):
229         (WebVisitedLinkStore::removeVisitedLink):
230         (WebVisitedLinkStore::addVisitedLinkHash):
231
232 2015-01-28  Chris Dumez  <cdumez@apple.com>
233
234         Rename pageCache() to PageCache::shared() and return a reference
235         https://bugs.webkit.org/show_bug.cgi?id=140983
236
237         Reviewed by Andreas Kling.
238
239         Rename pageCache() to PageCache::shared() as this is a singleton class
240         and have it return a reference instead of a pointer.
241
242         * History/WebBackForwardList.mm:
243         (-[WebBackForwardList pageCacheSize]):
244         * Misc/WebCoreStatistics.mm:
245         (+[WebCoreStatistics cachedPageCount]):
246         (+[WebCoreStatistics cachedFrameCount]):
247         * WebCoreSupport/WebVisitedLinkStore.mm:
248         (WebVisitedLinkStore::removeAllVisitedLinks):
249         (WebVisitedLinkStore::removeVisitedLink):
250         (WebVisitedLinkStore::addVisitedLinkHash):
251         * WebView/WebView.mm:
252         (+[WebView _setCacheModel:]):
253
254 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
255
256         More build fixes for newer clang.
257
258         Rubber-stamped by Anders Carlsson.
259
260         Marked a deprecated accessibility method as such.
261
262         * WebView/WebFrame.mm:
263         (-[WebFrame accessibilityRoot]):
264
265 2015-01-27  Beth Dakin  <bdakin@apple.com>
266
267         Immediate action gesture recognizer still doesn't work well with IB
268         https://bugs.webkit.org/show_bug.cgi?id=140967
269         -and corresponding-
270         rdar://problem/19621509
271
272         Reviewed by Tim Horton.
273
274         We should add (or remove) the gesture recognizer in viewDidMoveToWindow because 
275         initWithFrame it too early and IB might mess with it.
276         * WebView/WebImmediateActionController.h:
277         * WebView/WebImmediateActionController.mm:
278         (-[WebImmediateActionController immediateActionRecognizer]):
279         * WebView/WebView.mm:
280         (-[WebView _commonInitializationWithFrameName:groupName:]):
281         (-[WebView viewDidMoveToWindow]):
282
283 2015-01-27  Dan Bernstein  <mitz@apple.com>
284
285         Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
286
287         Rubber-stamped by Anders Carlsson.
288
289         * WebView/WebView.h: Added forward declarations of the protocols.
290
291 2015-01-26  Anders Carlsson  <andersca@apple.com>
292
293         Make it easy to test enabling formal delegate protocols
294         https://bugs.webkit.org/show_bug.cgi?id=140892
295
296         Reviewed by Dan Bernstein.
297
298         Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
299
300         * Misc/WebDownload.h:
301         * WebView/WebFrameLoadDelegate.h:
302         * WebView/WebPolicyDelegate.h:
303         * WebView/WebResourceLoadDelegate.h:
304         * WebView/WebUIDelegate.h:
305         * WebView/WebView.h:
306
307 2015-01-26  Chris Dumez  <cdumez@apple.com>
308
309         Rename Document::body() to Document::bodyOrFrameset() for clarity
310         https://bugs.webkit.org/show_bug.cgi?id=140902
311
312         Reviewed by Andreas Kling.
313
314         Rename Document::body() to Document::bodyOrFrameset() for clarity. This
315         method does not necessarily return an HTMLBodyElement, it can also
316         return a frameset as per the specification:
317         http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
318
319         This method is often misused internally (the caller is only interested
320         in the <body> element). I will fix these instances in a follow-up patch,
321         this patch is only renaming mechanically.
322
323 2015-01-26  Chris Dumez  <cdumez@apple.com>
324
325         First argument to DOM traversal functions should be a reference
326         https://bugs.webkit.org/show_bug.cgi?id=140895
327
328         Reviewed by Antti Koivisto.
329
330         First argument to DOM traversal functions should be a reference instead
331         of a pointer as it is dereferenced without null-check.
332
333 2015-01-26  Myles C. Maxfield  <mmaxfield@apple.com>
334
335         [iOS] [SVG -> OTF Converter] Flip the switch off on iOS
336         https://bugs.webkit.org/show_bug.cgi?id=140860
337
338         Reviewed by Darin Adler.
339
340         The fonts it makes are grotesque. (See what I did there? Typographic
341         humor is the best humor.)
342
343         * Configurations/FeatureDefines.xcconfig:
344
345 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
346
347         QLPreviewMenuItem popovers don't close when the page scrolls
348         https://bugs.webkit.org/show_bug.cgi?id=140806
349         <rdar://problem/19555618>
350
351         Reviewed by Beth Dakin.
352
353         Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
354
355         * WebView/WebHTMLView.mm:
356         (-[WebHTMLView scrollWheel:scrollWheel:]):
357         Send scrollWheel along to WebImmediateActionController.
358
359         * WebView/WebImmediateActionController.h:
360         * WebView/WebImmediateActionController.mm:
361         (-[WebImmediateActionController webView:didHandleScrollWheel:]):
362         (-[WebImmediateActionController _clearImmediateActionState]):
363         (-[WebImmediateActionController _defaultAnimationController]):
364         Keep track of the active QLPreviewMenuItem, and close it upon scroll.
365
366 2015-01-23  Timothy Horton  <timothy_horton@apple.com>
367
368         Infinite recursion in _clearImmediateActionState
369         https://bugs.webkit.org/show_bug.cgi?id=140807
370         <rdar://problem/19571601>
371
372         Reviewed by Anders Carlsson.
373
374         * WebView/WebImmediateActionController.mm:
375         (-[WebImmediateActionController _clearImmediateActionState]):
376         Use this opportunity to bring identical code to WebKit1, to avoid
377         getting DataDetectors stuck when an immediate action is canceled.
378
379 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
380
381         Add a build flag for ES6 class syntax
382         https://bugs.webkit.org/show_bug.cgi?id=140760
383
384         Reviewed by Michael Saboff.
385
386         * Configurations/FeatureDefines.xcconfig:
387
388 2015-01-22  Beth Dakin  <bdakin@apple.com>
389
390         ibtoold crash below -[WebView close]
391         https://bugs.webkit.org/show_bug.cgi?id=140782
392         -and corresponding-
393         rdar://problem/19558472
394
395         Reviewed by Tim Horton.
396
397         Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but 
398         it is because interface builder is messing with our views.
399         * WebView/WebImmediateActionController.h:
400         * WebView/WebImmediateActionController.mm:
401         (-[WebImmediateActionController webViewClosed]):
402         (-[WebImmediateActionController _cancelImmediateAction]):
403         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
404         (-[WebImmediateActionController _updateImmediateActionItem]):
405
406 2015-01-21  Beth Dakin  <bdakin@apple.com>
407
408         Crash in QuickLook preview delegate method
409         https://bugs.webkit.org/show_bug.cgi?id=140740
410         -and corresponding-
411         rdar://problem/19540806
412
413         Reviewed by Tim Horton.
414
415         Clear out the delegate.
416         * WebView/WebImmediateActionController.mm:
417         (-[WebImmediateActionController webViewClosed]):
418
419 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
420
421         Remove ENABLE(INSPECTOR) ifdef guards
422         https://bugs.webkit.org/show_bug.cgi?id=140668
423
424         Reviewed by Darin Adler.
425
426         * Configurations/FeatureDefines.xcconfig:
427         * WebCoreSupport/WebFrameLoaderClient.mm:
428         (WebFrameLoaderClient::dispatchWillSendRequest):
429
430 2015-01-20  Anders Carlsson  <andersca@apple.com>
431
432         Remove USE(GLIB) code from WebKit1
433         https://bugs.webkit.org/show_bug.cgi?id=140714
434
435         Reviewed by Andreas Kling.
436
437         * WebView/WebView.mm:
438         (-[WebView _commonInitializationWithFrameName:groupName:]):
439         (-[WebView _close]):
440         (-[WebView _clearGlibLoopObserver]): Deleted.
441         (glibContextIterationCallback): Deleted.
442         (-[WebView _scheduleGlibContextIterations]): Deleted.
443         * WebView/WebViewData.h:
444         * WebView/WebViewInternal.h:
445
446 2015-01-20  David Kilzer  <ddkilzer@apple.com>
447
448         Switch to comparing PLATFORM_NAME in terms of macosx
449         <http://webkit.org/b/139516>
450
451         Reviewed by Timothy Hatcher.
452
453         * MigrateHeaders.make:
454         * postprocess-headers.sh:
455
456 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
457
458         [SVG -> OTF Converter] Flip the switch on
459         https://bugs.webkit.org/show_bug.cgi?id=140592
460
461         Reviewed by Antti Koivisto.
462
463         * Configurations/FeatureDefines.xcconfig:
464
465 2015-01-19  Beth Dakin  <bdakin@apple.com>
466
467         Speculative build fix.
468
469         * WebView/WebView.mm:
470         (-[WebView _commonInitializationWithFrameName:groupName:]):
471
472 2015-01-19  Beth Dakin  <bdakin@apple.com>
473
474         Speculative build fix.
475
476         * WebView/WebView.mm:
477         (-[WebView _convertRectFromRootView:]):
478
479 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
480
481         Adjust naming of action menu SPI
482         https://bugs.webkit.org/show_bug.cgi?id=140644
483         <rdar://problem/19448129>
484
485         Reviewed by Brian Weinstein.
486
487         * WebView/WebActionMenuController.mm:
488         (-[WebActionMenuController prepareForMenu:withEvent:]):
489         (-[WebActionMenuController willOpenMenu:withEvent:]):
490         (-[WebActionMenuController didCloseMenu:withEvent:]):
491         * WebView/WebView.mm:
492         (-[WebView _commonInitializationWithFrameName:groupName:]):
493         (-[WebView prepareForMenu:withEvent:]):
494         (-[WebView willOpenMenu:withEvent:]):
495         (-[WebView didCloseMenu:withEvent:]):
496
497 2015-01-19  Beth Dakin  <bdakin@apple.com>
498
499         REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is 
500         offset by flipped-ness
501         https://bugs.webkit.org/show_bug.cgi?id=140643
502         -and corresponding-
503         rdar://problem/19489593
504
505         Reviewed by Tim Horton.
506
507         We universally flipped because we assumed that the root view was flipped and the 
508         WebView was not. However, in Dictionary, the WebView is flipped! So this patch 
509         fixes that assumption by checking the WebView’s flipped-ness.
510         * WebView/WebView.mm:
511         (-[WebView _convertRectFromRootView:]):
512
513 2015-01-19  Commit Queue  <commit-queue@webkit.org>
514
515         Unreviewed, rolling out r178653.
516         https://bugs.webkit.org/show_bug.cgi?id=140634
517
518         Broke multiple SVG tests on Mountain Lion (Requested by ap on
519         #webkit).
520
521         Reverted changeset:
522
523         "[SVG -> OTF Converter] Flip the switch on"
524         https://bugs.webkit.org/show_bug.cgi?id=140592
525         http://trac.webkit.org/changeset/178653
526
527 2015-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
528
529         [SVG -> OTF Converter] Flip the switch on
530         https://bugs.webkit.org/show_bug.cgi?id=140592
531
532         Reviewed by Antti Koivisto.
533
534         * Configurations/FeatureDefines.xcconfig:
535
536 2015-01-18  Daniel Bates  <dabates@apple.com>
537
538         Attempt to fix the iOS build after <http://trac.webkit.org/changeset/178631>
539         (https://bugs.webkit.org/show_bug.cgi?id=129441)
540
541         Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
542         Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.
543
544         * WebInspector/WebNodeHighlightView.mm:
545         (-[WebNodeHighlightView layoutSublayers:]):
546
547 2015-01-16  Beth Dakin  <bdakin@apple.com>
548
549         Make sure early cancellation of immediate action actually does that in WK1
550         https://bugs.webkit.org/show_bug.cgi?id=140566
551         -and corresponding-
552         rdar://problem/19490114
553
554         Reviewed by Tim Horton.
555
556         Work around an AppKit bug by dispatching the call to _cancelImmediateAction 
557         asynchronously.
558         * WebView/WebImmediateActionController.mm:
559         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
560
561 2015-01-16  Daniel Bates  <dabates@apple.com>
562
563         Fix the public iOS SDK build after <http://trac.webkit.org/changeset/178285>
564         (https://bugs.webkit.org/show_bug.cgi?id=140360)
565
566         Forward declare protocol NSURLDownloadDelegate as it is SPI on iOS.
567
568         * Misc/WebDownload.h:
569
570 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
571
572         Remove ENABLE(SQL_DATABASE) guards
573         https://bugs.webkit.org/show_bug.cgi?id=140434
574
575         Reviewed by Darin Adler.
576
577         * Configurations/FeatureDefines.xcconfig:
578         * Storage/WebDatabaseManager.mm:
579         (databasesDirectoryPath):
580         * Storage/WebDatabaseManagerClient.h:
581         * Storage/WebDatabaseManagerClient.mm:
582         * Storage/WebDatabaseManagerInternal.h:
583         * Storage/WebDatabaseManagerPrivate.h:
584         * Storage/WebDatabaseQuotaManager.mm:
585         (-[WebDatabaseQuotaManager usage]):
586         (-[WebDatabaseQuotaManager quota]):
587         (-[WebDatabaseQuotaManager setQuota:]):
588         * WebCoreSupport/WebChromeClient.h:
589         * WebCoreSupport/WebChromeClient.mm:
590         * WebCoreSupport/WebSecurityOrigin.mm:
591         (-[WebSecurityOrigin usage]):
592         (-[WebSecurityOrigin quota]):
593         (-[WebSecurityOrigin setQuota:]):
594         * WebView/WebFrame.mm:
595         (-[WebFrame _cacheabilityDictionary]):
596         * WebView/WebView.mm:
597         (-[WebView _commonInitializationWithFrameName:groupName:]):
598         (-[WebView _preferencesChanged:]):
599
600 2015-01-14  Chris Dumez  <cdumez@apple.com>
601
602         Make 'TypeName' parameter unnecessary in CSSPropertyNames.in
603         https://bugs.webkit.org/show_bug.cgi?id=140347
604
605         Reviewed by Darin Adler.
606
607         Call FontDescription::setIsItalic() instead of setItalic() as the
608         call site passes a boolean.
609
610         * WebView/WebHTMLView.mm:
611         (fontNameForDescription):
612
613 2015-01-13  Anders Carlsson  <andersca@apple.com>
614
615         Temporarily reintroduce the informal delegate protocols
616         https://bugs.webkit.org/show_bug.cgi?id=140416
617
618         Reviewed by Dan Bernstein.
619
620         * WebView/WebEditingDelegate.h:
621         * WebView/WebFrameLoadDelegate.h:
622         * WebView/WebPolicyDelegate.h:
623         * WebView/WebResourceLoadDelegate.h:
624         * WebView/WebUIDelegate.h:
625
626 2015-01-13  Beth Dakin  <bdakin@apple.com>
627
628         Should disable immediate actions for iTunes
629         https://bugs.webkit.org/show_bug.cgi?id=140405
630         -and corresponding-
631         rdar://problem/19461358
632
633         Reviewed by Tim Horton.
634
635         * WebView/WebImmediateActionController.mm:
636         (-[WebImmediateActionController _updateImmediateActionItem]):
637
638 2015-01-11  Sam Weinig  <sam@webkit.org>
639
640         Remove support for SharedWorkers
641         https://bugs.webkit.org/show_bug.cgi?id=140344
642
643         Reviewed by Anders Carlsson.
644
645         * Configurations/FeatureDefines.xcconfig:
646         * WebCoreSupport/WebPlatformStrategies.h:
647         * WebCoreSupport/WebPlatformStrategies.mm:
648         (WebPlatformStrategies::createSharedWorkerStrategy): Deleted.
649
650 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
651
652         Get rid of unnecessary reimplementations of CGFloor/Ceiling
653         https://bugs.webkit.org/show_bug.cgi?id=140375
654
655         Reviewed by Simon Fraser.
656
657         * Misc/WebKitNSStringExtras.mm:
658         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
659         (webkit_CGCeiling): Deleted.
660         Delete unnecessary code, use the real CGFloor/Ceiling instead.
661
662 2015-01-12  Anders Carlsson  <andersca@apple.com>
663
664         Make delegates conform to formal delegate protocols
665         https://bugs.webkit.org/show_bug.cgi?id=140370
666
667         Reviewed by Dan Bernstein.
668
669         * DefaultDelegates/WebDefaultPolicyDelegate.h:
670         * WebCoreSupport/WebInspectorClient.mm:
671         Add protocols to the interface declarations.
672
673         * WebView/WebActionMenuController.mm:
674         (-[WebActionMenuController prepareForMenu:withEvent:]):
675         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
676         * WebView/WebImmediateActionController.mm:
677         (-[WebImmediateActionController _updateImmediateActionItem]):
678         (-[WebImmediateActionController _menuItemForDataDetectedText]):
679         Cast to id when trying to invoke delegate methods that aren't on WebUIDelegate.
680
681 2015-01-12  Myles C. Maxfield  <mmaxfield@apple.com>
682
683         Allow targetting the SVG->OTF font converter with ENABLE(SVG_OTF_CONVERTER)
684         https://bugs.webkit.org/show_bug.cgi?id=136769
685
686         Reviewed by Antti Koivisto.
687
688         * Configurations/FeatureDefines.xcconfig:
689
690 2015-01-12  Timothy Horton  <timothy_horton@apple.com>
691
692         Multi-rect TextIndicators are vertically flipped in WebKit1
693         https://bugs.webkit.org/show_bug.cgi?id=140350
694         <rdar://problem/19441243>
695
696         Reviewed by Beth Dakin.
697
698         * WebView/WebView.mm:
699         (-[WebView _setTextIndicator:fadeOut:]):
700         Convert the textBoundingRect from root view to screen coordinates.
701
702 2015-01-12  Anders Carlsson  <andersca@apple.com>
703
704         Make WebResourceDelegate a formal protocol as well
705         https://bugs.webkit.org/show_bug.cgi?id=140364
706
707         Reviewed by Dan Bernstein.
708
709         * WebView/WebResourceLoadDelegate.h:
710
711 2015-01-12  Anders Carlsson  <andersca@apple.com>
712
713         Delegates should be formal protocols
714         https://bugs.webkit.org/show_bug.cgi?id=140360
715         rdar://problem/17380856
716
717         Reviewed by Dan Bernstein.
718
719         This is the first half of this change. The second half involves actually changing the delegate properties to be protocols.
720
721         * DefaultDelegates/WebDefaultUIDelegate.h:
722         * Misc/WebDownload.h:
723         * WebView/WebEditingDelegate.h:
724         * WebView/WebFrameLoadDelegate.h:
725         * WebView/WebPolicyDelegate.h:
726         * WebView/WebUIDelegate.h:
727
728 2015-01-09  Anders Carlsson  <andersca@apple.com>
729
730         Get rid of the database strategy
731         https://bugs.webkit.org/show_bug.cgi?id=140322
732
733         Reviewed by Sam Weinig.
734
735         * WebCoreSupport/WebPlatformStrategies.h:
736         * WebCoreSupport/WebPlatformStrategies.mm:
737         (WebPlatformStrategies::createDatabaseStrategy): Deleted.
738
739 2015-01-08  Timothy Horton  <timothy_horton@apple.com>
740
741         Can't use DataDetectors after immediate action preparation
742         https://bugs.webkit.org/show_bug.cgi?id=140263
743         <rdar://problem/19412705>
744
745         Reviewed by Beth Dakin.
746
747         * WebView/WebImmediateActionController.mm:
748         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
749         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
750         To match WebKit2, only call shouldUseActions if the animation is actually
751         going to begin, not when preparing for it. This way, we're guaranteed
752         to get a didCancel or didComplete.
753
754 2015-01-08  Dean Jackson  <dino@apple.com>
755
756         Text not drawn or white-on-white for "Close Page"/"Go Back" button on safe browsing warning page
757         https://bugs.webkit.org/show_bug.cgi?id=140232
758         <rdar://problem/19371010>
759
760         Reviewed by Anders Carlsson.
761
762         Remove the applicationChromeMode setting, but leave stubs in to make
763         sure existing binaries don't break.
764
765         * WebCoreSupport/WebInspectorClient.mm:
766         (-[WebInspectorWindowController init]):
767         * WebView/WebPreferenceKeysPrivate.h:
768         * WebView/WebPreferences.mm:
769         (+[WebPreferences initialize]):
770         (-[WebPreferences applicationChromeModeEnabled]):
771         (-[WebPreferences setApplicationChromeModeEnabled:]):
772         * WebView/WebView.mm:
773         (-[WebView _preferencesChanged:]):
774
775 2015-01-07  Daniel Bates  <dabates@apple.com>
776
777         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
778         https://bugs.webkit.org/show_bug.cgi?id=137371
779
780         Reviewed by David Kilzer.
781
782         Use SPI wrapper headers instead of directly references private SPI headers.
783
784         * Plugins/Hosted/NetscapePluginHostManager.mm:
785
786 2015-01-07  Commit Queue  <commit-queue@webkit.org>
787
788         Unreviewed, rolling out r178068.
789         https://bugs.webkit.org/show_bug.cgi?id=140235
790
791         Breaks the iOS build (Requested by enrica on #webkit).
792
793         Reverted changeset:
794
795         "[iOS] Make WebKit2 build with public iOS SDK and more build
796         fixes for DRT"
797         https://bugs.webkit.org/show_bug.cgi?id=137371
798         http://trac.webkit.org/changeset/178068
799
800 2015-01-07  Daniel Bates  <dabates@apple.com>
801
802         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
803         https://bugs.webkit.org/show_bug.cgi?id=137371
804
805         Reviewed by David Kilzer.
806
807         Use SPI wrapper headers instead of directly references private SPI headers.
808
809         * Plugins/Hosted/NetscapePluginHostManager.mm:
810
811 2015-01-07  Beth Dakin  <bdakin@apple.com>
812
813         Adopt delegate callbacks so that standardQuickLookMenuItem does not obscure the 
814         link
815         https://bugs.webkit.org/show_bug.cgi?id=140206
816         -and corresponding-
817         rdar://problem/19300492
818
819         Reviewed by Tim Horton.
820
821         Providing and item frame will ensure that the original link is not obscured.
822         * WebView/WebImmediateActionController.mm:
823         (elementBoundingBoxInWindowCoordinatesFromNode):
824         (-[WebImmediateActionController menuItem:itemFrameForPoint:]):
825
826         For now use a max size that is smaller than the WebView, with the screen’s aspect 
827         ratio, and scaled down.
828         (-[WebImmediateActionController menuItem:maxSizeForPoint:]):
829
830 2015-01-07  Anders Carlsson  <andersca@apple.com>
831
832         Give simple HTML documents a database provider
833         https://bugs.webkit.org/show_bug.cgi?id=140192
834         rdar://problem/19398825
835
836         Reviewed by Tim Horton.
837
838         * WebView/WebView.mm:
839         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
840
841 2015-01-06  Anders Carlsson  <andersca@apple.com>
842
843         Reimplement NPN_PluginThreadAsyncCall without using PluginMainThreadScheduler
844         https://bugs.webkit.org/show_bug.cgi?id=140140
845
846         Reviewed by Andreas Kling.
847
848         Just use a dispatch_async call to the main queue. This will let us move PluginMainThreadScheduler
849         out of WebCore since nobody else is using it.
850
851         * Plugins/WebNetscapePluginView.h:
852         * Plugins/WebNetscapePluginView.mm:
853         (-[WebNetscapePluginView _createPlugin]):
854         (-[WebNetscapePluginView _destroyPlugin]):
855         * Plugins/npapi.mm:
856         (NPN_PluginThreadAsyncCall):
857
858 2015-01-06  Anders Carlsson  <andersca@apple.com>
859
860         Add a WebKit1 database provider
861         https://bugs.webkit.org/show_bug.cgi?id=140126
862
863         Reviewed by Sam Weinig.
864
865         Set the database provider.
866
867         * WebView/WebView.mm:
868         (-[WebView _commonInitializationWithFrameName:groupName:]):
869
870 2015-01-06  Commit Queue  <commit-queue@webkit.org>
871
872         Unreviewed, rolling out r177963.
873         https://bugs.webkit.org/show_bug.cgi?id=140136
874
875         Caused lots of crashes (Requested by smfr on #webkit).
876
877         Reverted changeset:
878
879         "Add a WebKit1 database provider"
880         https://bugs.webkit.org/show_bug.cgi?id=140126
881         http://trac.webkit.org/changeset/177963
882
883 2015-01-06  Anders Carlsson  <andersca@apple.com>
884
885         Add a WebKit1 database provider
886         https://bugs.webkit.org/show_bug.cgi?id=140126
887
888         Reviewed by Sam Weinig.
889
890         Set the database provider.
891
892         * WebView/WebView.mm:
893         (-[WebView _commonInitializationWithFrameName:groupName:]):
894
895 2015-01-01  Jeff Miller  <jeffm@apple.com>
896
897         Update user-visible copyright strings to include 2015
898         https://bugs.webkit.org/show_bug.cgi?id=139880
899
900         Reviewed by Darin Adler.
901
902         * Info.plist:
903
904 2014-12-30  Dan Bernstein  <mitz@apple.com>
905
906         [Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
907         https://bugs.webkit.org/show_bug.cgi?id=140003
908
909         Reviewed by Darin Adler.
910
911         * Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function
912         that takes their "string" parameter as a "value" "parameter and has an attribute telling
913         the compiler that if the "value" parameter is a format string then the function returns a
914         modified version of it. The result is that if UI_STRING is used as a format string parameter
915         to some function or method, the compiler will check the format specifiers in the string
916         against the other parameters.
917
918 2014-12-29  Dan Bernstein  <mitz@apple.com>
919
920         Fixed the iOS build.
921
922         * Configurations/WebKitLegacy.xcconfig:
923
924 2014-12-29  Anders Carlsson  <andersca@apple.com>
925
926         Get rid of some PageGroup storage functions
927         https://bugs.webkit.org/show_bug.cgi?id=139996
928
929         Reviewed by Sam Weinig.
930
931         Call WebStorageNamespaceProvider directly instead.
932
933         * Storage/WebStorageManager.mm:
934         (-[WebStorageManager syncLocalStorage]):
935         (+[WebStorageManager closeIdleLocalStorageDatabases]):
936         * WebView/WebView.mm:
937         (+[WebView _applicationWillTerminate]):
938
939 2014-12-29  Anders Carlsson  <andersca@apple.com>
940
941         Move storage code from WebCore to WebKit
942         https://bugs.webkit.org/show_bug.cgi?id=139558
943
944         Reviewed by Darin Adler.
945
946         * Storage/WebStorageManager.mm:
947         * Storage/WebStorageTrackerClient.h:
948         * WebView/WebView.mm:
949
950 2014-12-26  Dan Bernstein  <mitz@apple.com>
951
952         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
953         https://bugs.webkit.org/show_bug.cgi?id=139950
954
955         Reviewed by David Kilzer.
956
957         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
958         in a manner that works with Xcode 5.1.1.
959
960 2014-12-23  Timothy Horton  <timothy_horton@apple.com>
961
962         Install a TextIndicator for link immediate actions
963         https://bugs.webkit.org/show_bug.cgi?id=139897
964         <rdar://problem/19333076>
965
966         Reviewed by Anders Carlsson.
967
968         * WebView/WebImmediateActionController.h:
969         * WebView/WebImmediateActionController.mm:
970         (-[WebImmediateActionController _clearImmediateActionState]):
971         Tear down the TextIndicator, just like WebKit2.
972
973         (-[WebImmediateActionController _defaultAnimationController]):
974         Install a TextIndicator for links.
975
976         (-[WebImmediateActionController menuItemDidClose:]):
977         Tear down the TextIndicator when the QL preview closes.
978
979         (-[WebImmediateActionController _menuItemForDataDetectedText]):
980         Directly install and uninstall the TextIndicator for DataDetectors.
981
982         (-[WebImmediateActionController _showTextIndicator]): Deleted.
983         (-[WebImmediateActionController _hideTextIndicator]): Deleted.
984         Remove the isShowingTextIndicator mechanism, just like it was removed from WebKit2.
985
986 2014-12-20  Eric Carlson  <eric.carlson@apple.com>
987
988         [iOS] add optimized fullscreen API
989         https://bugs.webkit.org/show_bug.cgi?id=139833
990         <rdar://problem/18844486>
991
992         Reviewed by Simon Fraser.
993
994         * Configurations/FeatureDefines.xcconfig:  Add ENABLE_VIDEO_PRESENTATION_MODE.
995
996 2014-12-20  David Kilzer  <ddkilzer@apple.com>
997
998         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
999         <http://webkit.org/b/139463>
1000
1001         Reviewed by Mark Rowe.
1002
1003         * Configurations/Base.xcconfig:
1004         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1005           on OS X.
1006         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1007         * Configurations/DebugRelease.xcconfig:
1008         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1009         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1010         * Configurations/Version.xcconfig:
1011         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1012         * Configurations/WebKitLegacy.xcconfig:
1013         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1014           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1015           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1016           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1017           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1018           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1019           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1020           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1021           based on SDK.
1022         - Fix PRODUCTION_ROOT to actually be set properly.
1023         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1024
1025         * migrate-headers.sh:
1026         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1027         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1028           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1029           WebKitLegacy.xcconfig.
1030
1031 2014-12-19  Simon Fraser  <simon.fraser@apple.com>
1032
1033         Fix pink background on CoreAnimation plug-ins in WebKit1
1034         https://bugs.webkit.org/show_bug.cgi?id=139845
1035         rdar://problem/19313075
1036
1037         Reviewed by Tim Horton.
1038         
1039         r154078 left in some debugging code that set a pink background on plug-in hosting
1040         layers. Remove it.
1041
1042         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1043         (-[WebHostedNetscapePluginView createPluginLayer]):
1044
1045 2014-12-19  Andreas Kling  <akling@apple.com>
1046
1047         Ref-ify TextIterator API.
1048         <https://webkit.org/b/139823>
1049
1050         Reviewed by Antti Koivisto.
1051
1052         * WebView/WebTextIterator.mm:
1053         (-[WebTextIterator currentRange]):
1054
1055 2014-12-19  Joseph Pecoraro  <pecoraro@apple.com>
1056
1057         Web Inspector: CRASH inspector-protocol/debugger/breakpoint-action-detach.html
1058         https://bugs.webkit.org/show_bug.cgi?id=139797
1059
1060         Reviewed by Mark Lam.
1061
1062         * WebView/WebScriptDebugger.h:
1063         * WebView/WebScriptDebugger.mm:
1064         (WebScriptDebugger::handlePause):
1065         Standardize on passing JSGlobalObject parameter first.
1066
1067 2014-12-19  Commit Queue  <commit-queue@webkit.org>
1068
1069         Unreviewed, rolling out r177574.
1070         https://bugs.webkit.org/show_bug.cgi?id=139821
1071
1072         "Broke Production builds by installing
1073         libWebCoreTestSupport.dylib in the wrong directory" (Requested
1074         by ddkilzer on #webkit).
1075
1076         Reverted changeset:
1077
1078         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
1079         WebInspectorUI, WebKit, WebKit2"
1080         https://bugs.webkit.org/show_bug.cgi?id=139463
1081         http://trac.webkit.org/changeset/177574
1082
1083 2014-12-19  David Kilzer  <ddkilzer@apple.com>
1084
1085         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
1086         <http://webkit.org/b/139463>
1087
1088         Reviewed by Mark Rowe.
1089
1090         * Configurations/Base.xcconfig:
1091         - Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS
1092           on OS X.
1093         - Set GCC_OPTIMIZATION_LEVEL_normal based on SDK.
1094         * Configurations/DebugRelease.xcconfig:
1095         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
1096         - Set WEBKIT_SYSTEM_INTERFACE_LIBRARY based on SDK.
1097         * Configurations/Version.xcconfig:
1098         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
1099         * Configurations/WebKitLegacy.xcconfig:
1100         - Set EXCLUDED_SOURCE_FILE_NAMES, EXPORTED_SYMBOLS_FILE_x86_64,
1101           FRAMEWORK_SEARCH_PATHS, OTHER_CFLAGS, INSTALL_PATH,
1102           DYLIB_INSTALL_NAME_BASE, OTHER_LDFLAGS, SECTORDER_FLAGS,
1103           NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR,
1104           WEBKIT_LEGACY_FRAMEWORKS_DIR, NORMAL_PRODUCTION_FRAMEWORKS_DIR,
1105           PRODUCTION_FRAMEWORKS_DIR, PRODUCTION_ROOT,
1106           WEBCORE_PRIVATE_HEADERS_DIR_Production and
1107           WEBKITSYSTEMINTERFACE_STATIC_LIBRARY_HEADERS_FOLDER_PATH_engineering
1108           based on SDK.
1109         - Fix PRODUCTION_ROOT to actually be set properly.
1110         - Simplify EXPORTED_SYMBOLS_FILE_i386.
1111
1112         * migrate-headers.sh:
1113         - Get rid of unused WEBKIT2_FRAMEWORKS_DIR variable.
1114         - Change WEBCORE_PRIVATE_HEADERS_DIR_macosx_Production to
1115           WEBCORE_PRIVATE_HEADERS_DIR_Production based on changes to
1116           WebKitLegacy.xcconfig.
1117
1118 2014-12-18  Andreas Kling  <akling@apple.com>
1119
1120         Ref-ify various Document-related things.
1121         <https://webkit.org/b/139796>
1122
1123         Reviewed by Anders Carlsson.
1124
1125         * WebView/WebFrame.mm:
1126         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
1127
1128 2014-12-18  Beth Dakin  <bdakin@apple.com>
1129
1130         Need to re-enable action menus
1131         https://bugs.webkit.org/show_bug.cgi?id=139795
1132         -and corresponding-
1133         rdar://problem/19299367
1134
1135         Reviewed by Tim Horton.
1136
1137         Re-enable the menus by un-commenting the code to create the menu and controller.
1138         * WebView/WebView.mm:
1139         (-[WebView _commonInitializationWithFrameName:groupName:]):
1140
1141 2014-12-16  Sam Weinig  <sam@webkit.org>
1142
1143         Unify the Mac and iOS implementations of FontPlatformData a bit
1144         https://bugs.webkit.org/show_bug.cgi?id=139721
1145
1146         Reviewed by Anders Carlsson.
1147
1148         * WebView/WebHTMLView.mm:
1149         (fontNameForDescription):
1150         Update for new function name.
1151
1152 2014-12-18  Antti Koivisto  <antti@apple.com>
1153
1154         Remove alwaysUseBaselineOfPrimaryFont setting
1155         https://bugs.webkit.org/show_bug.cgi?id=139770
1156
1157         Reviewed by Anders Carlsson.
1158
1159         * WebView/WebPreferenceKeysPrivate.h:
1160         * WebView/WebPreferences.mm:
1161         (-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
1162         (-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
1163         * WebView/WebPreferencesPrivate.h:
1164         * WebView/WebView.mm:
1165         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1166         (-[WebView _preferencesChanged:]):
1167
1168 2014-12-17  Andreas Kling  <akling@apple.com>
1169
1170         Ref-ify Range::create().
1171         <https://webkit.org/b/139755>
1172
1173         Reviewed by Anders Carlsson.
1174
1175         * WebView/WebHTMLRepresentation.mm:
1176         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1177         * WebView/WebHTMLView.mm:
1178         (-[WebHTMLView attributedString]):
1179
1180 2014-12-17  Anders Carlsson  <andersca@apple.com>
1181
1182         Unify -[WebResource description]
1183         https://bugs.webkit.org/show_bug.cgi?id=139762
1184
1185         Reviewed by Dan Bernstein.
1186
1187         * WebView/WebResource.mm:
1188         (-[WebResource description]):
1189
1190 2014-12-17  Anders Carlsson  <andersca@apple.com>
1191
1192         Get rid of an ugly #define hack in WebFrameLoaderClient
1193         https://bugs.webkit.org/show_bug.cgi?id=139761
1194
1195         Reviewed by Dan Bernstein.
1196
1197         Also replace @private with @package in all public headers, for consistency.
1198
1199         * History/WebBackForwardList.h:
1200         * History/WebHistory.h:
1201         * Misc/WebDownload.h:
1202         * WebCoreSupport/WebFrameLoaderClient.mm:
1203         * WebView/WebArchive.h:
1204         * WebView/WebDataSource.h:
1205         * WebView/WebFrame.h:
1206         * WebView/WebFrameView.h:
1207         * WebView/WebPreferences.h:
1208         * WebView/WebResource.h:
1209
1210 2014-12-17  Dan Bernstein  <mitz@apple.com>
1211
1212         <rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
1213         https://bugs.webkit.org/show_bug.cgi?id=139760
1214
1215         Reviewed by Anders Carlsson.
1216
1217         * Configurations/WebKitLegacy.xcconfig:
1218
1219 2014-12-17  Andreas Kling  <akling@apple.com>
1220
1221         Purge PassRefPtr from Frame.
1222         <https://webkit.org/b/139731>
1223
1224         Reviewed by Anders Carlsson.
1225
1226         * WebCoreSupport/WebFrameLoaderClient.mm:
1227         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1228         * WebView/WebFrame.mm:
1229         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1230         (+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
1231         * WebView/WebFrameInternal.h:
1232
1233 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1234
1235         Implement and adopt two new TextIndicator presentation animations
1236         https://bugs.webkit.org/show_bug.cgi?id=139715
1237         <rdar://problem/19237945>
1238
1239         Reviewed by Anders Carlsson.
1240
1241         * WebView/WebActionMenuController.mm:
1242         (-[WebActionMenuController _showTextIndicator]):
1243         * WebView/WebHTMLView.mm:
1244         (-[WebHTMLView quickLookWithEvent:]):
1245         Remove the completionHandler from text indicator presentation.
1246
1247         * WebView/WebImmediateActionController.mm:
1248         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1249         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
1250         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1251         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1252         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1253         (-[WebImmediateActionController _animationControllerForText]):
1254         (-[WebImmediateActionController _showTextIndicator]):
1255         Forward immediate action gesture recognizer animation progress
1256         to TextIndicator. Force us to keep the selection when immediate
1257         action popovers steal first responder status from the WebView.
1258         If the Lookup range is equal to the selection range, use a Crossfade
1259         animation; otherwise, use a FadeIn animation.
1260
1261         * WebView/WebView.mm:
1262         (-[WebView _setMaintainsInactiveSelection:]):
1263         (-[WebView maintainsInactiveSelection]):
1264         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1265         (-[WebView _setTextIndicator:fadeOut:]):
1266         (-[WebView _clearTextIndicator]):
1267         (-[WebView _setTextIndicatorAnimationProgress:]):
1268         (-[WebView _showDictionaryLookupPopup:]):
1269         (-[WebView _dictionaryLookupPopoverWillClose:]):
1270         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1271         Remove the completionHandler from text indicator presentation.
1272         Add a _setMaintainsInactiveSelection, which allows WebKit internals
1273         to change the return value of -maintainsInactiveSelection, allowing
1274         us to keep the selection alive when the WebView loses first responder status.
1275
1276         * WebView/WebViewData.h:
1277         * WebView/WebViewInternal.h:
1278
1279 2014-12-16  Andreas Kling  <akling@apple.com>
1280
1281         Use Ref for SecurityOrigin.
1282         <https://webkit.org/b/139710>
1283
1284         Reviewed by Anders Carlsson.
1285
1286         * Storage/WebStorageTrackerClient.mm:
1287         (WebStorageTrackerClient::dispatchDidModifyOrigin):
1288         * WebView/WebView.mm:
1289         (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1290         (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
1291
1292 2014-12-16  Beth Dakin  <bdakin@apple.com>
1293
1294         Crash getting default animation controller for some text
1295         https://bugs.webkit.org/show_bug.cgi?id=139712
1296         -and corresponding-
1297         rdar://problem/19271707
1298
1299         Reviewed by Tim Horton.
1300
1301         Must null-check the range.
1302         * WebView/WebImmediateActionController.mm:
1303         (-[WebImmediateActionController _animationControllerForText]):
1304
1305 2014-12-16  Timothy Horton  <timothy_horton@apple.com>
1306
1307         Immediate action popovers can get stuck open
1308         https://bugs.webkit.org/show_bug.cgi?id=139709
1309         <rdar://problem/19270279>
1310
1311         Reviewed by Beth Dakin.
1312
1313         * WebView/WebImmediateActionController.mm:
1314         (-[WebImmediateActionController _clearImmediateActionState]):
1315         Don't clear the animation controller; it breaks things and was unnecessary.
1316
1317 2014-12-16  Tim Horton  <timothy_horton@apple.com>
1318
1319         Disable TextIndication for Lookup immediate actions
1320         https://bugs.webkit.org/show_bug.cgi?id=139684
1321
1322         Reviewed by Anders Carlsson.
1323
1324         * WebView/WebView.mm:
1325         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1326
1327 2014-12-15  Beth Dakin  <bdakin@apple.com>
1328
1329         Build fix.
1330
1331         * WebView/WebImmediateActionController.mm:
1332
1333 2014-12-15  Beth Dakin  <bdakin@apple.com>
1334
1335         Speculative build fix.
1336
1337         * WebView/WebView.mm:
1338         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1339         * WebView/WebViewInternal.h:
1340
1341 2014-12-15  Beth Dakin  <bdakin@apple.com>
1342
1343         Make lookup an immediate action instead of an action menu item
1344         https://bugs.webkit.org/show_bug.cgi?id=139661
1345         -and corresponding-
1346         rdar://problem/19198414
1347
1348         Reviewed by Tim Horton.
1349
1350         Remove the lookup menu items and non-unused static function associated with 
1351         lookup.
1352         * WebView/WebActionMenuController.mm:
1353         (-[WebActionMenuController _defaultMenuItemsForText]):
1354         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
1355         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
1356         (-[WebActionMenuController _createActionMenuItemForTag:]):
1357         (-[WebActionMenuController _lookupText:]): Deleted.
1358         (performDictionaryLookupForSelection): Deleted.
1359         (performDictionaryLookupForRange): Deleted.
1360
1361         Set the defaultAnimationController to the lookup-provided animation controller 
1362         when appropriate.
1363         * WebView/WebImmediateActionController.mm:
1364         (-[WebImmediateActionController _defaultAnimationController]):
1365         (dictionaryPopupInfoForRange):
1366         (-[WebImmediateActionController _animationControllerForText]):
1367
1368         New type.
1369         * WebView/WebUIDelegatePrivate.h:
1370
1371         New function to get the lookup animation controller.
1372         * WebView/WebView.mm:
1373         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1374         * WebView/WebViewInternal.h:
1375
1376 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1377
1378         Implement Data Detectors immediate actions for Legacy WebKit
1379         https://bugs.webkit.org/show_bug.cgi?id=139619
1380         <rdar://problem/19198539>
1381
1382         Reviewed by Beth Dakin.
1383
1384         * WebView/WebImmediateActionController.mm:
1385         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1386         Note that this action context is only for immediate actions.
1387
1388 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1389
1390         Addressing post-review comments in r177035
1391         https://bugs.webkit.org/show_bug.cgi?id=139557
1392
1393         Reviewed by Darin Adler.
1394
1395         * WebView/WebActionMenuController.mm:
1396         (elementBoundingBoxInWindowCoordinatesFromNode): Migrate off rendererBoundingBox().
1397
1398 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
1399
1400         Implement Data Detectors immediate actions for Legacy WebKit
1401         https://bugs.webkit.org/show_bug.cgi?id=139619
1402         <rdar://problem/19198539>
1403
1404         Reviewed by Eric Carlson.
1405
1406         * WebView/WebHTMLView.mm:
1407         (-[WebHTMLView mouseDown:mouseDown:]):
1408         Send mouseDown along to the WebImmediateActionController too.
1409
1410         * WebView/WebImmediateActionController.h:
1411         * WebView/WebImmediateActionController.mm:
1412         (-[WebImmediateActionController webViewClosed]):
1413         (-[WebImmediateActionController webView:willHandleMouseDown:]):
1414         (-[WebImmediateActionController _cancelImmediateAction]):
1415         (-[WebImmediateActionController _clearImmediateActionState]):
1416         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1417         (-[WebImmediateActionController _defaultAnimationController]):
1418         (-[WebImmediateActionController _updateImmediateActionItem]):
1419         (-[WebImmediateActionController _menuItemForDataDetectedText]):
1420         (-[WebImmediateActionController _showTextIndicator]):
1421         (-[WebImmediateActionController _hideTextIndicator]):
1422         Copy most of the DataDetectors implementation into WebImmediateActionController.
1423
1424         * WebView/WebUIDelegatePrivate.h:
1425         Add a new type.
1426
1427         * WebView/WebView.mm:
1428         (-[WebView _commonInitializationWithFrameName:groupName:]):
1429         Temporarily disable action menus.
1430
1431         (-[WebView _immediateActionController]):
1432         * WebView/WebViewInternal.h:
1433
1434 2014-12-15  Myles C. Maxfield  <mmaxfield@apple.com>
1435
1436         Delete Notation because we don't use it
1437         https://bugs.webkit.org/show_bug.cgi?id=139171
1438
1439         Reviewed by Kent Tamura.
1440
1441         * MigrateHeaders.make:
1442
1443 2014-12-14  Andreas Kling  <akling@apple.com>
1444
1445         Replace PassRef with Ref/Ref&& across the board.
1446         <https://webkit.org/b/139587>
1447
1448         Reviewed by Darin Adler.
1449
1450         * WebCoreSupport/WebEditorClient.mm:
1451         (WebEditorClient::shouldApplyStyle):
1452         * WebCoreSupport/WebVisitedLinkStore.h:
1453         * WebCoreSupport/WebVisitedLinkStore.mm:
1454         (WebVisitedLinkStore::create):
1455
1456 2014-12-11  Dan Bernstein  <mitz@apple.com>
1457
1458         Fix a leak introduced in r177199.
1459
1460         Reviewed by Anders Carlsson.
1461
1462         * WebView/WebImmediateActionController.mm:
1463         (-[WebImmediateActionController _updateImmediateActionItem]):
1464
1465 2014-12-11  Beth Dakin  <bdakin@apple.com>
1466
1467         WK1: Need new SPI for Webkit clients to override default immediate action
1468         https://bugs.webkit.org/show_bug.cgi?id=139568
1469         -and corresponding-
1470         rdar://problem/19225448
1471
1472         Reviewed by Dan Bernstein.
1473
1474         Call SPI giving clients a chance to override the default behavior.
1475         * WebView/WebImmediateActionController.mm:
1476         (-[WebImmediateActionController _updateImmediateActionItem]):
1477
1478         New SPI.
1479         * WebView/WebUIDelegatePrivate.h:
1480
1481 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1482
1483         Move the preview popover to WebImmediateActionController
1484         https://bugs.webkit.org/show_bug.cgi?id=139563
1485         <rdar://problem/19208291>
1486
1487         Reviewed by Beth Dakin.
1488
1489         * WebView/WebActionMenuController.mm:
1490         (-[WebActionMenuController _defaultMenuItemsForLink]):
1491         (-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
1492         (-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
1493         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
1494         * WebView/WebImmediateActionController.h:
1495         * WebView/WebImmediateActionController.mm:
1496         (-[WebImmediateActionController webViewClosed]):
1497         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1498         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1499         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1500         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1501         (-[WebImmediateActionController _updateImmediateActionItem]):
1502         (-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
1503         (-[WebImmediateActionController menuItem:previewItemAtPoint:]):
1504         (-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
1505         Move page preview popover related code to WebImmediateActionController.
1506
1507         * WebView/WebUIDelegatePrivate.h:
1508         Add a link preview type.
1509
1510         * WebView/WebView.mm:
1511         (-[WebView _commonInitializationWithFrameName:groupName:]):
1512         Pass the gesture recognizer to the WebImmediateActionController.
1513
1514 2014-12-11  Timothy Horton  <timothy_horton@apple.com>
1515
1516         Fix the build.
1517
1518         * WebView/WebImmediateActionController.h:
1519         * WebView/WebImmediateActionController.mm:
1520
1521 2014-12-11  Anders Carlsson  <andersca@apple.com>
1522
1523         Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
1524         https://bugs.webkit.org/show_bug.cgi?id=139547
1525
1526         Reviewed by Sam Weinig.
1527
1528         * WebView/WebView.mm:
1529         (+[WebView _handleMemoryWarning]):
1530
1531 2014-12-11  Alexey Proskuryakov  <ap@apple.com>
1532
1533         REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
1534         https://bugs.webkit.org/show_bug.cgi?id=139504
1535         rdar://problem/19034674
1536
1537         Reviewed by Enrica Casucci.
1538
1539         Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
1540
1541         * WebCoreSupport/WebEditorClient.h:
1542         * WebCoreSupport/WebEditorClient.mm:
1543         (WebEditorClient::discardedComposition):
1544
1545 2014-12-10  Anders Carlsson  <andersca@apple.com>
1546
1547         Get rid of the storage strategy
1548         https://bugs.webkit.org/show_bug.cgi?id=139519
1549
1550         Reviewed by Antti Koivisto.
1551
1552         * WebCoreSupport/WebPlatformStrategies.h:
1553         * WebCoreSupport/WebPlatformStrategies.mm:
1554         (WebPlatformStrategies::createStorageStrategy): Deleted.
1555
1556 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1557
1558         Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
1559         https://bugs.webkit.org/show_bug.cgi?id=139529
1560         <rdar://problem/19213620>
1561
1562         Reviewed by Beth Dakin.
1563
1564         * WebView/WebActionMenuController.mm:
1565         (-[WebActionMenuController _copySelection:]):
1566         (-[WebActionMenuController _paste:]):
1567         Use the copy: and paste: methods on WebView so that we traverse subviews
1568         when trying to respond, otherwise these actions don't work in subframes.
1569
1570 2014-12-10  Beth Dakin  <bdakin@apple.com>
1571
1572         WK1: Add initial support for immediate actions
1573         https://bugs.webkit.org/show_bug.cgi?id=139522
1574
1575         Reviewed by Dan Bernstein.
1576
1577         This basic implementation of the controller will use the delegate methods to 
1578         perform and cache a HitTest when relevant. Future patches will patch 
1579         _updateImmediateActionItem to use the HitTestResult to determine if there is any 
1580         immediate action that should be taken.
1581         * WebView/WebImmediateActionController.h: Added.
1582         * WebView/WebImmediateActionController.mm: Added.
1583         (-[WebImmediateActionController webViewClosed]):
1584         (-[WebImmediateActionController _clearImmediateActionState]):
1585         (-[WebImmediateActionController performHitTestAtPoint:]):
1586         (-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
1587         (-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
1588         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
1589         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
1590         (-[WebImmediateActionController _updateImmediateActionItem]):
1591
1592         New enum for immediate action types.
1593         * WebView/WebUIDelegatePrivate.h:
1594
1595         Create an NSImmediateActionGestureRecognizer if possible and a controller.
1596         * WebView/WebView.mm:
1597         (-[WebView _commonInitializationWithFrameName:groupName:]):
1598         (-[WebView _close]):
1599         * WebView/WebViewData.h:
1600         * WebView/WebViewData.mm:
1601         (-[WebViewPrivate dealloc]):
1602
1603 2014-12-08  Anders Carlsson  <andersca@apple.com>
1604
1605         Use the new storage namespace provider in WebKit1
1606         https://bugs.webkit.org/show_bug.cgi?id=139425
1607
1608         Reviewed by Tim Horton.
1609
1610         * WebView/WebView.mm:
1611         (-[WebView _commonInitializationWithFrameName:groupName:]):
1612         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1613         Set the storage namespace provider from the web page group.
1614
1615 2014-12-10  Timothy Horton  <timothy_horton@apple.com>
1616
1617         Should have copy and paste items in all text menus
1618         https://bugs.webkit.org/show_bug.cgi?id=139510
1619         <rdar://problem/19198388>
1620
1621         Reviewed by Beth Dakin.
1622
1623         * WebView/WebActionMenuController.mm:
1624         (-[WebActionMenuController _defaultMenuItemsForText]):
1625         Add a disabled paste menu item into the read-only text menu.
1626
1627         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
1628         Add a disabled copy menu item into the editable whitespace text menu.
1629
1630 2014-12-10  Anders Carlsson  <andersca@apple.com>
1631
1632         Add WebStorageNamespaceProvider::closeLocalStorage
1633         https://bugs.webkit.org/show_bug.cgi?id=139502
1634
1635         Reviewed by Tim Horton.
1636
1637         * WebView/WebView.mm:
1638         (+[WebView _applicationWillTerminate]):
1639         Call WebStorageNamespaceProvider::closeLocalStorage.
1640
1641 2014-12-09  Commit Queue  <commit-queue@webkit.org>
1642
1643         Unreviewed, rolling out r177037.
1644         https://bugs.webkit.org/show_bug.cgi?id=139464
1645
1646         broke ~50 API tests (Requested by thorton on #webkit).
1647
1648         Reverted changeset:
1649
1650         "Use the new storage namespace provider in WebKit1"
1651         https://bugs.webkit.org/show_bug.cgi?id=139425
1652         http://trac.webkit.org/changeset/177037
1653
1654 2014-12-08  Anders Carlsson  <andersca@apple.com>
1655
1656         Use the new storage namespace provider in WebKit1
1657         https://bugs.webkit.org/show_bug.cgi?id=139425
1658
1659         Reviewed by Tim Horton.
1660
1661         * WebView/WebView.mm:
1662         (-[WebView _commonInitializationWithFrameName:groupName:]):
1663         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1664         Set the storage namespace provider from the web page group.
1665
1666 2014-12-09  Myles C. Maxfield  <mmaxfield@apple.com>
1667
1668         Delete Node::boundingBox()
1669         https://bugs.webkit.org/show_bug.cgi?id=139333
1670
1671         Reviewed by Zalan Bujtas.
1672
1673         * WebView/WebActionMenuController.mm:
1674         (elementBoundingBoxInWindowCoordinatesFromNode): Use
1675         RenderObject::absoluteBoundingBoxRect().
1676
1677 2014-12-08  Alexey Proskuryakov  <ap@apple.com>
1678
1679         REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
1680         https://bugs.webkit.org/show_bug.cgi?id=138843
1681         rdar://problem/18793695
1682
1683         Reviewed by Dan Bernstein.
1684
1685         * Panels/WebAuthenticationPanel.m:
1686         (-[WebAuthenticationPanel cancel:]):
1687         (-[WebAuthenticationPanel logIn:]):
1688         Don't close the panel before using panel.sheetParent, because the parent becomes nil.
1689         In fact, we don't need to close it at all, it's enough to call orderOut:, and even
1690         that only when using an old NSWindow API.
1691
1692 2014-12-08  Beth Dakin  <bdakin@apple.com>
1693
1694         Copy and Lookup menu items should be disabled when something is not copyable
1695         https://bugs.webkit.org/show_bug.cgi?id=139423
1696
1697         Reviewed by Tim Horton.
1698
1699         Disable both lookup and copy when a HitTestResult does not allow copy.
1700         * WebView/WebActionMenuController.mm:
1701
1702         Set autoenablesItems to NO. It’s messing with our ability to control the enable/
1703         disable state otherwise.
1704         * WebView/WebView.mm:
1705         (-[WebView _commonInitializationWithFrameName:groupName:]):
1706
1707 2014-12-08  Anders Carlsson  <andersca@apple.com>
1708
1709         Adding user content to a group should force that group to be created
1710         https://bugs.webkit.org/show_bug.cgi?id=139421
1711         rdar://problem/19180108
1712
1713         Reviewed by Sam Weinig.
1714
1715         * WebCoreSupport/WebViewGroup.h:
1716         Store the local storage database path in the group.
1717
1718         * WebCoreSupport/WebViewGroup.mm:
1719         (WebViewGroup::getOrCreate):
1720         If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
1721         set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
1722
1723         (WebViewGroup::WebViewGroup):
1724         Initialize the new member variable.
1725
1726         (WebViewGroup::storageNamespaceProvider):
1727         Create the namespace provider lazily.
1728
1729         * WebView/WebView.mm:
1730         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1731         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1732         Use getOrCreate instead of get.
1733
1734 2014-12-08  Anders Carlsson  <andersca@apple.com>
1735
1736         WebStorageNamespaceProvider should know about its local storage database path
1737         https://bugs.webkit.org/show_bug.cgi?id=139413
1738
1739         Reviewed by Andreas Kling.
1740
1741         * WebCoreSupport/WebViewGroup.h:
1742         * WebCoreSupport/WebViewGroup.mm:
1743         (WebViewGroup::getOrCreate):
1744         (WebViewGroup::WebViewGroup):
1745         * WebView/WebView.mm:
1746         (-[WebView _commonInitializationWithFrameName:groupName:]):
1747         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1748         (-[WebView setGroupName:]):
1749         (-[WebView groupName]): Deleted.
1750
1751 2014-12-08  Daniel Bates  <dabates@apple.com>
1752
1753         [iOS] Fix the WebKit build with the public SDK
1754
1755         Include header NSURLDownloadSPI.h.
1756
1757         * WebCoreSupport/WebFrameLoaderClient.mm:
1758
1759 2014-12-07  Dan Bernstein  <mitz@apple.com>
1760
1761         Introduce and deploy a function that allocates and returns an instance of a soft-linked class
1762         https://bugs.webkit.org/show_bug.cgi?id=139348
1763
1764         Reviewed by Anders Carlsson.
1765
1766         In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
1767         picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
1768         to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
1769         doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
1770         avoiding the ambiguity.
1771
1772         * WebView/WebActionMenuController.mm:
1773         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1774
1775 2014-12-06  Anders Carlsson  <andersca@apple.com>
1776
1777         Add a stubbed out version of WebStorageNamespaceProvider
1778         https://bugs.webkit.org/show_bug.cgi?id=139213
1779
1780         Reviewed by Sam Weinig.
1781
1782         * WebCoreSupport/WebViewGroup.h:
1783         (WebViewGroup::storageNamespaceProvider):
1784         * WebCoreSupport/WebViewGroup.mm:
1785         (WebViewGroup::getOrCreate):
1786         (WebViewGroup::WebViewGroup):
1787         Give WebViewGroup a storage namespace provider.
1788
1789 2014-12-06  Anders Carlsson  <andersca@apple.com>
1790
1791         Fix build with newer versions of clang.
1792         rdar://problem/18978687
1793
1794         Add missing overrides and missing casts.
1795
1796         * Storage/WebDatabaseManagerClient.h:
1797         * Storage/WebStorageTrackerClient.h:
1798         * WebCoreSupport/WebChromeClient.h:
1799         * WebCoreSupport/WebFrameLoaderClient.h:
1800         * WebCoreSupport/WebInspectorClient.h:
1801         * WebView/WebDataSource.mm:
1802         (-[WebDataSource _makeRepresentation]):
1803         * WebView/WebFrameView.mm:
1804         (-[WebFrameView _makeDocumentViewForDataSource:]):
1805
1806 2014-12-05  Tim Horton  <timothy_horton@apple.com>
1807
1808         Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
1809         https://bugs.webkit.org/show_bug.cgi?id=139306
1810         <rdar://problem/19157955>
1811
1812         Reviewed by Beth Dakin.
1813
1814         * WebView/WebView.mm:
1815         (-[WebView _commonInitializationWithFrameName:groupName:]):
1816         (-[WebView _initWithFrame:frameName:groupName:]):
1817         Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
1818
1819 2014-12-05  David Kilzer  <ddkilzer@apple.com>
1820
1821         FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
1822         <http://webkit.org/b/139286>
1823
1824         Reviewed by Daniel Bates.
1825
1826         * Configurations/FeatureDefines.xcconfig: Switch back to using
1827         PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
1828
1829 2014-12-04  Timothy Horton  <timothy_horton@apple.com>
1830
1831         Fix the 32-bit build.
1832
1833         * WebView/WebView.mm:
1834         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1835
1836 2014-12-04  Tim Horton  <timothy_horton@apple.com>
1837
1838         TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
1839         https://bugs.webkit.org/show_bug.cgi?id=139252
1840         <rdar://problem/19140827>
1841
1842         Reviewed by Anders Carlsson.
1843
1844         * WebView/WebView.mm:
1845         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
1846         Adjust to the WebCore changes.
1847
1848 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1849
1850         Implement action menus for tel: URLs
1851         https://bugs.webkit.org/show_bug.cgi?id=139240
1852         <rdar://problem/19115662>
1853
1854         Reviewed by Anders Carlsson.
1855
1856         * WebView/WebActionMenuController.mm:
1857         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1858         Make sure to use the newly created currentActionContext... everywhere.
1859
1860 2014-12-03  Timothy Horton  <timothy_horton@apple.com>
1861
1862         Implement action menus for tel: URLs
1863         https://bugs.webkit.org/show_bug.cgi?id=139240
1864         <rdar://problem/19115662>
1865
1866         Reviewed by Anders Carlsson.
1867
1868         * WebView/WebActionMenuController.mm:
1869         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1870         Make sure to use the newly created currentActionContext.
1871
1872 2014-12-03  Beth Dakin  <bdakin@apple.com>
1873
1874         <input> elements get whitespace action menu instead of editable text menu
1875         https://bugs.webkit.org/show_bug.cgi?id=139241
1876         -and corresponding-
1877         rdar://problem/19072083
1878
1879         Reviewed by Sam Weinig.
1880
1881         We should disallow shadow content in the hit test. This is the default and it is 
1882         how context menus behave. We originally wanted to text inside shadow content so 
1883         that we could find the text, but the new function I added to HitTestResult will 
1884         allow that.
1885         * WebView/WebActionMenuController.mm:
1886         (-[WebActionMenuController performHitTestAtPoint:]):
1887
1888         Adjust to the fact that we don’t hit test shadow content any more.
1889         (-[WebActionMenuController focusAndSelectHitTestResult]):
1890
1891         Offer the text menus for text inside form controls.
1892         (-[WebActionMenuController _defaultMenuItems]):
1893
1894 2014-12-03  Tim Horton  <timothy_horton@apple.com>
1895
1896         Implement action menus for tel: URLs
1897         https://bugs.webkit.org/show_bug.cgi?id=139240
1898         <rdar://problem/19115662>
1899
1900         Reviewed by Anders Carlsson.
1901
1902         * WebView/WebActionMenuController.mm:
1903         (-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
1904         Rename this function as it will work for both mailto and tel URLs.
1905         Adjust it to use contextForView:.
1906
1907         (-[WebActionMenuController webView:willHandleMouseDown:]):
1908         (-[WebActionMenuController prepareForMenu:withEvent:]):
1909         (-[WebActionMenuController didCloseMenu:withEvent:]):
1910         (-[WebActionMenuController _defaultMenuItems]):
1911         Don't check the menu type when going to interact with _currentActionContext.
1912         We'll only have a _currentActionContext if we have a data detected item,
1913         and there are multiple menu types that end up using DDActionContext.
1914
1915         * WebView/WebUIDelegatePrivate.h:
1916         Add a new type.
1917
1918 2014-12-03  Anders Carlsson  <andersca@apple.com>
1919
1920         Set a visited link store when creating a simple WebView
1921         https://bugs.webkit.org/show_bug.cgi?id=139234
1922         <rdar://problem/19132978>
1923
1924         Reviewed by Sam Weinig.
1925
1926         * WebView/WebView.mm:
1927         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1928
1929 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
1930
1931         Fix the build.
1932
1933         * WebCoreSupport/WebFrameLoaderClient.mm:
1934
1935 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1936
1937         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1938         https://bugs.webkit.org/show_bug.cgi?id=139149
1939
1940         Reviewed by Anders Carlsson.
1941
1942         This changes API behavior. I think that it's OK, because existing behavior made no sense.
1943         We used to delete caches from disk, but they were still active in memory. Now we also
1944         obsolete them in memory, so documents that use a cache still work, but new ones don't
1945         pick one up.
1946
1947         * WebCoreSupport/WebApplicationCache.mm:
1948         (+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
1949         need to delete in-momry caches too. Keep existing behavior.
1950         (+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
1951         that properly deletes caches.
1952
1953 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1954
1955         Remove a SnowLeopard-era quirk for QuickLook
1956         https://bugs.webkit.org/show_bug.cgi?id=139208
1957         <rdar://problem/19121822>
1958
1959         Reviewed by Alexey Proskuryakov.
1960
1961         * WebCoreSupport/WebFrameLoaderClient.h:
1962         * WebCoreSupport/WebFrameLoaderClient.mm:
1963
1964 2014-12-02  Tim Horton  <timothy_horton@apple.com>
1965
1966         Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
1967         https://bugs.webkit.org/show_bug.cgi?id=139204
1968
1969         Reviewed by Anders Carlsson.
1970
1971         * WebView/WebView.mm:
1972         (-[WebView _commonInitializationWithFrameName:groupName:]):
1973         (-[WebView _showDictionaryLookupPopup:]):
1974         * WebView/WebViewData.h:
1975         Work around this by delaying the softlinking (and setting up the notification
1976         observer) until we actually need it. There's still an underlying bug, but
1977         this will fix the test.
1978
1979 2014-12-02  Beth Dakin  <bdakin@apple.com>
1980
1981         Yet another build fix.
1982
1983         * WebView/WebActionMenuController.mm:
1984         (-[WebActionMenuController _defaultMenuItemsForLink]):
1985
1986 2014-12-02  Beth Dakin  <bdakin@apple.com>
1987
1988         Build fix.
1989
1990         * WebView/WebActionMenuController.mm:
1991         (-[WebActionMenuController _defaultMenuItemsForLink]):
1992
1993 2014-12-02  Beth Dakin  <bdakin@apple.com>
1994
1995         More build fixing.
1996
1997         * WebView/WebActionMenuController.mm:
1998         (-[WebActionMenuController _defaultMenuItemsForLink]):
1999
2000 2014-12-02  Beth Dakin  <bdakin@apple.com>
2001
2002         Should use standardQuickLookMenuItem for apps that don't implement customizations
2003         https://bugs.webkit.org/show_bug.cgi?id=139193
2004         -and corresponding-
2005         rdar://problem/18944696
2006
2007         Reviewed by Anders Carlsson.
2008
2009         Use [NSMenuItem standardQuickLookMenuItem].
2010         * WebView/WebActionMenuController.mm:
2011         (-[WebActionMenuController _defaultMenuItemsForLink]):
2012
2013         Delegate methods to set up the standardQuickLookMenuItem.
2014         (-[WebActionMenuController menuItem:viewAtScreenPoint:]):
2015         (-[WebActionMenuController menuItem:previewItemAtPoint:]):
2016         (-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
2017
2018         Remove all of the old QLPreviewBubble code.
2019         (-[WebActionMenuController _createActionMenuItemForTag:]):
2020         (-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
2021
2022 2014-12-02  Timothy Horton  <timothy_horton@apple.com>
2023
2024         Fix the build.
2025
2026         * WebView/WebViewData.h:
2027
2028 2014-12-02  Tim Horton  <timothy_horton@apple.com>
2029
2030         Implement Lookup transition from selection for Legacy WebKit
2031         https://bugs.webkit.org/show_bug.cgi?id=139180
2032         <rdar://problem/19067172>
2033
2034         Reviewed by Beth Dakin.
2035
2036         * WebView/DictionaryPopupInfo.h: Added.
2037         Split DictionaryPopupInfo out into its own file.
2038
2039         * WebView/WebActionMenuController.mm:
2040         (-[WebActionMenuController _lookupText:]):
2041         Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
2042
2043         (performDictionaryLookupForSelection):
2044         (performDictionaryLookupForRange):
2045         Plumb the transition style through these helpers.
2046         Create a TextIndicator from the selection range.
2047
2048         * WebView/WebHTMLView.mm:
2049         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2050         Make use of TextIndicator (and DictionaryPopupInfo, and the new
2051         _showDictionaryLookupPopup on WebView) to add a transition from blue
2052         when performing Lookup from the context menu.
2053
2054         (-[WebHTMLView quickLookWithEvent:]):
2055         Remove our TextIndicator whenever a normal three-finger-tap event
2056         comes through, as it will have its own indication.
2057
2058         * WebView/WebView.mm:
2059         (-[WebView _commonInitializationWithFrameName:groupName:]):
2060         (-[WebView _dictionaryLookupPopoverWillClose:]):
2061         Register for the LUNotificationPopoverWillClose notification and remove
2062         our TextIndicator when it is called, just like in WebKit2.
2063         Deregistration is already handled in _close.
2064
2065         (-[WebView _showDictionaryLookupPopup:]):
2066         Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
2067         if the relevant API is available.
2068
2069         * WebView/WebViewInternal.h:
2070
2071 2014-12-02  Anders Carlsson  <andersca@apple.com>
2072
2073         Remove visited link handling from PageGroup
2074         https://bugs.webkit.org/show_bug.cgi?id=139185
2075
2076         Reviewed by Sam Weinig.
2077
2078         * History/WebHistory.mm:
2079         (-[WebHistoryPrivate removeItemForURLString:]):
2080         (-[WebHistoryPrivate removeAllItems]):
2081         (+[WebHistory setOptionalSharedHistory:]):
2082         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2083         (+[WebHistory _removeAllVisitedLinks]):
2084         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
2085         (-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
2086         * History/WebHistoryInternal.h:
2087         * WebCoreSupport/WebChromeClient.h:
2088         * WebCoreSupport/WebChromeClient.mm:
2089         (WebChromeClient::populateVisitedLinks): Deleted.
2090         * WebView/WebView.mm:
2091         (-[WebView addVisitedLinks:]):
2092         (-[WebView removeVisitedLink:]):
2093
2094 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2095
2096         Try to fix the Mac build.
2097
2098         * WebView/WebView.mm:
2099         (-[WebView _commonInitializationWithFrameName:groupName:]):
2100         (-[WebView _close]):
2101
2102 2014-12-01  Timothy Horton  <timothy_horton@apple.com>
2103
2104         Fix the iOS build.
2105
2106         * WebView/WebActionMenuController.h:
2107         * WebView/WebActionMenuController.mm:
2108         * WebView/WebHTMLView.mm:
2109         (-[WebHTMLView scrollWheel:scrollWheel:]):
2110         (-[WebHTMLView mouseDown:mouseDown:]):
2111         * WebView/WebView.mm:
2112         * WebView/WebViewData.h:
2113         * WebView/WebViewData.mm:
2114         (-[WebViewPrivate dealloc]):
2115         * WebView/WebViewInternal.h:
2116
2117 2014-12-01  Tim Horton  <timothy_horton@apple.com>
2118
2119         Implement yellow highlight for WebKit1 data detectors
2120         https://bugs.webkit.org/show_bug.cgi?id=138956
2121         <rdar://problem/18992185>
2122
2123         Reviewed by Beth Dakin.
2124
2125         * WebView/WebActionMenuController.h:
2126         * WebView/WebActionMenuController.mm:
2127         (-[WebActionMenuController webView:willHandleMouseDown:]):
2128         (-[WebActionMenuController webView:didHandleScrollWheel:]):
2129         (-[WebActionMenuController prepareForMenu:withEvent:]):
2130         (-[WebActionMenuController didCloseMenu:withEvent:]):
2131         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2132         (-[WebActionMenuController _showTextIndicator]):
2133         (-[WebActionMenuController _hideTextIndicator]):
2134         (-[WebActionMenuController _dismissActionMenuPopovers]):
2135         Copy the WebKit2 WKActionMenuController TextIndicator implementation
2136         into WebActionMenuController. The only significant difference is
2137         that we build the TextIndicator right at menu construction time
2138         instead of in the Web process.
2139
2140         * WebView/WebHTMLView.mm:
2141         (-[WebHTMLView scrollWheel:]):
2142         Let the WebActionMenuController know that we're handling a scroll.
2143
2144         (-[WebHTMLView mouseDown:]):
2145         Let the WebActionMenuController know that we're handling a mouseDown.
2146
2147         * WebView/WebView.mm:
2148         (-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
2149         (-[WebView _clearTextIndicator]):
2150         (-[WebView _actionMenuController]):
2151         (-[WebView _convertRectFromRootView:]): Deleted.
2152         * WebView/WebViewData.h:
2153         * WebView/WebViewData.mm:
2154         * WebView/WebViewInternal.h:
2155         Keep a TextIndicatorWindow on WebView, just like WKView does.
2156         Expose the WebActionMenuController on WebView (internally).
2157
2158 2014-12-01  Anders Carlsson  <andersca@apple.com>
2159
2160         Remove old site specific quirks code that was added in 2009
2161         https://bugs.webkit.org/show_bug.cgi?id=139141
2162
2163         Reviewed by Antti Koivisto.
2164
2165         * WebCoreSupport/WebFrameNetworkingContext.h:
2166         * WebCoreSupport/WebFrameNetworkingContext.mm:
2167         (WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
2168
2169 2014-11-30  Anders Carlsson  <andersca@apple.com>
2170
2171         Fix a test failure.
2172
2173         * History/WebHistory.mm:
2174         (+[WebHistory _setVisitedLinkTrackingEnabled:]):
2175         Call through to the visited link store.
2176
2177         (+[WebHistory _removeAllVisitedLinks]):
2178         Ditto.
2179
2180         * WebCoreSupport/WebVisitedLinkStore.mm:
2181         (WebVisitedLinkStore::isLinkVisited):
2182         Make sure to populate visited links.
2183
2184 2014-11-30  Anders Carlsson  <andersca@apple.com>
2185
2186         Switch over to the visited link store from the WebViewGroup
2187         https://bugs.webkit.org/show_bug.cgi?id=139112
2188
2189         Reviewed by Sam Weinig.
2190
2191         * WebView/WebView.mm:
2192         (-[WebView _commonInitializationWithFrameName:groupName:]):
2193         (-[WebView setGroupName:]):
2194
2195 2014-11-30  Anders Carlsson  <andersca@apple.com>
2196
2197         Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
2198         https://bugs.webkit.org/show_bug.cgi?id=139111
2199
2200         Reviewed by Sam Weinig.
2201
2202         * WebCoreSupport/WebVisitedLinkStore.h:
2203         * WebCoreSupport/WebVisitedLinkStore.mm:
2204         (WebVisitedLinkStore::removeVisitedLink):
2205         * WebView/WebView.mm:
2206         (-[WebView removeVisitedLink:]):
2207
2208 2014-11-29  Anders Carlsson  <andersca@apple.com>
2209
2210         Populate visited links
2211         https://bugs.webkit.org/show_bug.cgi?id=139101
2212
2213         Reviewed by Sam Weinig.
2214
2215         * History/WebHistory.mm:
2216         (-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
2217         Helper function that adds all visited link to the given store.
2218
2219         (-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
2220         Call the private method.
2221
2222         * History/WebHistoryInternal.h:
2223         * WebCoreSupport/WebVisitedLinkStore.h:
2224         Add new members.
2225
2226         * WebCoreSupport/WebVisitedLinkStore.mm:
2227         (WebVisitedLinkStore::addVisitedLink):
2228         Get the characters from the URL string and hash them, then call addVisitedLinkHash.
2229
2230         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2231         Implement this. First try the delegate, then try the shared history.
2232
2233         (WebVisitedLinkStore::addVisitedLinkHash):
2234         Factor code that adds the link to the hash table into a separate function.
2235
2236         * WebView/WebView.mm:
2237         (-[WebView addVisitedLinks:]):
2238         Add the visited links to the store.
2239
2240 2014-11-29  Anders Carlsson  <andersca@apple.com>
2241
2242         More work on the legacy WebKit visited link store
2243         https://bugs.webkit.org/show_bug.cgi?id=139100
2244
2245         Reviewed by Sam Weinig.
2246
2247         * History/WebHistory.mm:
2248         (+[WebHistory setOptionalSharedHistory:]):
2249         Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
2250
2251         * WebCoreSupport/WebVisitedLinkStore.h:
2252         * WebCoreSupport/WebVisitedLinkStore.mm:
2253         (visitedLinkStores):
2254         (WebVisitedLinkStore::WebVisitedLinkStore):
2255         (WebVisitedLinkStore::~WebVisitedLinkStore):
2256         Keep track of live visited link stores.
2257
2258         (WebVisitedLinkStore::setShouldTrackVisitedLinks):
2259         Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
2260
2261         (WebVisitedLinkStore::removeAllVisitedLinks):
2262         Iterate over all live link stores and remove their links.
2263
2264         (WebVisitedLinkStore::isLinkVisited):
2265         Populate visited links and check if our hash table contains the link.
2266
2267         (WebVisitedLinkStore::addVisitedLink):
2268         Add the link hash to the table.
2269
2270         (WebVisitedLinkStore::populateVisitedLinksIfNeeded):
2271         Add stub.
2272
2273         (WebVisitedLinkStore::removeVisitedLinkHashes):
2274         Clear out the hash table.
2275
2276 2014-11-27  Anders Carlsson  <andersca@apple.com>
2277
2278         Add a stubbed out WebVisitedLinkStore to WebViewGroup
2279         https://bugs.webkit.org/show_bug.cgi?id=139066
2280
2281         Reviewed by Antti Koivisto.
2282
2283         * WebCoreSupport/WebViewGroup.h:
2284         (WebViewGroup::visitedLinkStore):
2285         * WebCoreSupport/WebViewGroup.mm:
2286         (WebViewGroup::WebViewGroup):
2287         * WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2288         * WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
2289         (WebVisitedLinkStore::create):
2290         (WebVisitedLinkStore::WebVisitedLinkStore):
2291         (WebVisitedLinkStore::~WebVisitedLinkStore):
2292         (WebVisitedLinkStore::isLinkVisited):
2293         (WebVisitedLinkStore::addVisitedLink):
2294
2295 2014-11-25  Anders Carlsson  <andersca@apple.com>
2296
2297         Remove user content handling from PageGroup
2298         https://bugs.webkit.org/show_bug.cgi?id=139051
2299
2300         Reviewed by Antti Koivisto.
2301
2302         Use the user content controller in the web view group.
2303
2304         * WebView/WebView.mm:
2305         (-[WebView _injectOutlookQuirksScript]):
2306
2307 2014-11-25  Anders Carlsson  <andersca@apple.com>
2308
2309         Add a user content controller to WebViewGroup and use it for user content
2310         https://bugs.webkit.org/show_bug.cgi?id=139043
2311
2312         Reviewed by Antti Koivisto.
2313
2314         This is another tiny step towards getting rid of user content handling inside PageGroup.
2315
2316         * WebCoreSupport/WebViewGroup.h:
2317         (WebViewGroup::userContentController):
2318         Add a UserContentController member and getter.
2319
2320         * WebCoreSupport/WebViewGroup.mm:
2321         (WebViewGroup::get):
2322         Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
2323
2324         (WebViewGroup::WebViewGroup):
2325         Create a user content controller.
2326
2327         * WebView/WebView.mm:
2328         (-[WebView _commonInitializationWithFrameName:groupName:]):
2329         Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
2330         set its user content controller in the PageConfiguration.
2331
2332         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2333         Ditto.
2334
2335         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
2336         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
2337         (+[WebView _removeUserScriptFromGroup:world:url:]):
2338         (+[WebView _removeUserStyleSheetFromGroup:world:url:]):
2339         (+[WebView _removeUserScriptsFromGroup:world:]):
2340         (+[WebView _removeUserStyleSheetsFromGroup:world:]):
2341         (+[WebView _removeAllUserContentFromGroup:]):
2342         Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
2343
2344         (-[WebView setGroupName:]):
2345         Set the user content controller to the new WebViewGroup's user content controller.
2346
2347 2014-11-21  Jer Noble  <jer.noble@apple.com>
2348
2349         Support multiple signatures of diagnostic logging.
2350         https://bugs.webkit.org/show_bug.cgi?id=138690
2351
2352         Reviewed by Anders Carlsson.
2353
2354         Page::PageClients has been renamed PageConfiguration.
2355
2356         * WebView/WebView.mm:
2357         (-[WebView _commonInitializationWithFrameName:groupName:]):
2358         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2359
2360 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2361
2362         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2363         https://bugs.webkit.org/show_bug.cgi?id=138981
2364
2365         Reviewed by Simon Fraser.
2366
2367         * WebView/WebPreferenceKeysPrivate.h:
2368         * WebView/WebPreferences.mm:
2369         (+[WebPreferences initialize]):
2370         (-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
2371         (-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
2372         * WebView/WebPreferencesPrivate.h:
2373         * WebView/WebView.mm:
2374         (-[WebView _preferencesChanged:]):
2375
2376 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2377
2378         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2379         ​https://bugs.webkit.org/show_bug.cgi?id=138960
2380         <rdar://problem/19056715>
2381
2382         Reviewed by Anders Carlsson.
2383
2384         * WebView/WebActionMenuController.mm:
2385         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2386         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2387         Use DataDetectors SPI instead of an explicit blacklist.
2388
2389 2014-11-21  Tim Horton  <timothy_horton@apple.com>
2390
2391         REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
2392         https://bugs.webkit.org/show_bug.cgi?id=138960
2393         <rdar://problem/19056715>
2394
2395         Reviewed by Beth Dakin.
2396
2397         * WebView/WebActionMenuController.mm:
2398         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2399         Blacklist contact results, because they don't have useful menus. If we
2400         bail before setting up _currentActionContext, we'll still allow fallthrough
2401         to ordinary text actions, avoiding mysterious failure when a contact is detected.
2402
2403         This doesn't break the case that r176351 was intended to fix,
2404         because in that case we were detecting e.g. addresses.
2405
2406 2014-11-21  Anders Carlsson  <andersca@apple.com>
2407
2408         Remove the Timer parameters from timer callbacks
2409         https://bugs.webkit.org/show_bug.cgi?id=138974
2410
2411         Reviewed by Antti Koivisto.
2412
2413         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
2414         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2415         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
2416         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
2417         * Plugins/WebNetscapePluginStream.h:
2418         * Plugins/WebNetscapePluginStream.mm:
2419         (WebNetscapePluginStream::WebNetscapePluginStream):
2420         (WebNetscapePluginStream::deliverDataTimerFired):
2421
2422 2014-11-21  Anders Carlsson  <andersca@apple.com>
2423
2424         Make memoryCache() return a reference
2425         https://bugs.webkit.org/show_bug.cgi?id=138939
2426
2427         Reviewed by Antti Koivisto.
2428
2429         * Misc/WebCache.mm:
2430         (+[WebCache statistics]):
2431         (+[WebCache emptyInMemoryResources]):
2432         (+[WebCache sizeOfDeadResources:]):
2433         (+[WebCache addImageToCache:forURL:forFrame:]):
2434         (+[WebCache removeImageFromCacheForURL:forFrame:]):
2435         (+[WebCache imageForURL:]):
2436         (+[WebCache setDisabled:]):
2437         (+[WebCache isDisabled]):
2438         * WebView/WebView.mm:
2439         (+[WebView _setCacheModel:]):
2440
2441 2014-11-20  Benjamin Poulain  <bpoulain@apple.com>
2442
2443         Remove the remaining vestiges of minimal-ui
2444         https://bugs.webkit.org/show_bug.cgi?id=138890
2445
2446         Reviewed by Sam Weinig.
2447
2448         * History/WebHistoryItem.mm:
2449         * History/WebHistoryItemPrivate.h:
2450
2451 2014-11-20  Tim Horton  <timothy_horton@apple.com>
2452
2453         Cancel DataDetectors menu earlier if we know it can't be presented
2454         https://bugs.webkit.org/show_bug.cgi?id=138922
2455         <rdar://problem/18950441>
2456
2457         Reviewed by Beth Dakin.
2458
2459         * WebView/WebActionMenuController.mm:
2460         (-[WebActionMenuController prepareForMenu:withEvent:]):
2461         Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
2462         and use a bigger hammer (removeAllItems).
2463
2464         (-[WebActionMenuController willOpenMenu:withEvent:]):
2465         If we end up with a menu with no items, don't change selection or anything.
2466
2467 2014-11-20  Beth Dakin  <bdakin@apple.com>
2468
2469         Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
2470         https://bugs.webkit.org/show_bug.cgi?id=138568
2471         -and corresponding-
2472         rdar://problem/18904600
2473
2474         Reviewed by Tim Horton.
2475
2476         Skip images for lookup.
2477         * WebView/WebActionMenuController.mm:
2478         (performDictionaryLookupForRange):
2479
2480 2014-11-19  Beth Dakin  <bdakin@apple.com>
2481
2482         Invoking an action menu on a selection should result in the text menu
2483         https://bugs.webkit.org/show_bug.cgi?id=138892
2484         -and corresponding-
2485         rdar://problem/18996776
2486
2487         Reviewed by Tim Horton.
2488
2489         * WebView/WebActionMenuController.mm:
2490         (-[WebActionMenuController _defaultMenuItems]):
2491
2492 2014-11-19  Beth Dakin  <bdakin@apple.com>
2493
2494         Data detected results with no menu items should not fall through to regular text 
2495         action menus
2496         https://bugs.webkit.org/show_bug.cgi?id=138887
2497         -and corresponding-
2498         rdar://problem/18971616
2499
2500         Reviewed by Tim Horton.
2501
2502         * WebView/WebActionMenuController.mm:
2503         (-[WebActionMenuController _defaultMenuItems]):
2504
2505 2014-11-19  Daniel Bates  <dabates@apple.com>
2506
2507         [iOS] Make WebKit build with public iOS SDK
2508         https://bugs.webkit.org/show_bug.cgi?id=136863
2509
2510         Reviewed by David Kilzer.
2511
2512         * History/WebHistory.mm: Include header NSCalendarDateSPI.h.
2513         * History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
2514         * Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
2515         We use __has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
2516         may be used by Apple internal clients that do not include wtf/Platform.h.
2517         * Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
2518         private Foundation headers directly.
2519         * Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
2520         * WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
2521         instead of including private CFNetwork headers directly. Also fixed up style and
2522         ordering of header include directives.
2523         * WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
2524         CFNetwork headers directly. Also sort the #import directives.
2525         * WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
2526         and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
2527
2528 2014-11-18  David Kilzer  <ddkilzer@apple.com>
2529
2530         FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
2531         <http://webkit.org/b/138813>
2532
2533         Reviewed by Mark Rowe.
2534
2535         * Configurations/FeatureDefines.xcconfig: Switch to using SDK
2536         selectors.
2537
2538 2014-11-18  Chris Dumez  <cdumez@apple.com>
2539
2540         Add a setting to toggle DOMTimer throttling support
2541         https://bugs.webkit.org/show_bug.cgi?id=138844
2542         <rdar://problem/19020874>
2543
2544         Reviewed by Andreas Kling.
2545
2546         Add a setting to disable DOM timers throttling, in order to help
2547         developers determine if a specific issue is caused by timer
2548         throttling.
2549
2550         * WebView/WebPreferenceKeysPrivate.h:
2551         * WebView/WebPreferences.mm:
2552         (+[WebPreferences initialize]):
2553         (-[WebPreferences domTimersThrottlingEnabled]):
2554         (-[WebPreferences setDOMTimersThrottlingEnabled:]):
2555         * WebView/WebPreferencesPrivate.h:
2556         * WebView/WebView.mm:
2557         (-[WebView _preferencesChanged:]):
2558
2559 2014-11-18  Tim Horton  <timothy_horton@apple.com>
2560
2561         Avoid re-encoding action menu image data
2562         https://bugs.webkit.org/show_bug.cgi?id=138817
2563         <rdar://problem/18840382>
2564
2565         Reviewed by Anders Carlsson.
2566
2567         * WebView/WebActionMenuController.mm:
2568         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2569         (-[WebActionMenuController _addImageToPhotos:]):
2570         Build a temporary filename from a UUID and the image's desired extension.
2571         Use the Image's encoded data instead of re-encoding it with CGImageDestination.
2572         Build an image menu only if we have an image, URL, data, and extension.
2573
2574 2014-11-18  Daniel Bates  <dabates@apple.com>
2575
2576         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2577         SPI are not available in public SDK
2578         https://bugs.webkit.org/show_bug.cgi?id=138802
2579
2580         Reviewed by David Kilzer.
2581
2582         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2583         libdispatch and MobileGestalt headers directly.
2584
2585         * WebView/WebView.mm:
2586
2587 2014-11-17  Brian Weinstein  <bweinstein@apple.com>
2588
2589         Remove calls to deprecated NSMenu methods
2590         https://bugs.webkit.org/show_bug.cgi?id=138808.
2591
2592         Reviewed by Anders Carlsson.
2593
2594         -[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
2595
2596         * WebCoreSupport/PopupMenuMac.mm:
2597         (PopupMenuMac::populate):
2598
2599 2014-11-17  Daniel Bates  <dabates@apple.com>
2600
2601         Unreviewed, rolling out r176232.
2602
2603         Broke the Mac build. Will investigate offline.
2604
2605         Reverted changeset:
2606
2607         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2608         MobileGestalt"
2609         https://bugs.webkit.org/show_bug.cgi?id=138802
2610         http://trac.webkit.org/changeset/176232
2611
2612 2014-11-17  Daniel Bates  <dabates@apple.com>
2613
2614         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2615         SPI are not available in public SDK
2616         https://bugs.webkit.org/show_bug.cgi?id=138802
2617
2618         Reviewed by David Kilzer.
2619
2620         Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
2621         libdispatch and MobileGestalt headers directly.
2622
2623         * WebView/WebView.mm:
2624
2625 2014-11-17  Beth Dakin  <bdakin@apple.com>
2626
2627         Whitespace action menus should focus the HitTestResult and create an insertion 
2628         point
2629         https://bugs.webkit.org/show_bug.cgi?id=138786
2630         -and corresponding-
2631         rdar://problem/18944893
2632
2633         Reviewed by Tim Horton.
2634
2635         Whitespace menus should cause the HitTestResult to be focused, and they should set 
2636         the selection based on the HitTest location.
2637
2638         * WebView/WebActionMenuController.mm:
2639         (-[WebActionMenuController isMenuForTextContent]):
2640         (-[WebActionMenuController focusAndSelectHitTestResult]):
2641         (-[WebActionMenuController willOpenMenu:withEvent:]):
2642
2643 2014-11-17  Daniel Bates  <dabates@apple.com>
2644
2645         [iOS] QuartzCore SPI not available in public SDK
2646         https://bugs.webkit.org/show_bug.cgi?id=138751
2647
2648         Reviewed by David Kilzer.
2649
2650         Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
2651
2652         * WebInspector/WebNodeHighlight.mm:
2653         * WebView/WebIndicateLayer.mm:
2654
2655 2014-11-17  Eric Carlson  <eric.carlson@apple.com>
2656
2657         [iOS] allow host application to opt-out of alternate fullscreen
2658         https://bugs.webkit.org/show_bug.cgi?id=138787
2659
2660         Reviewed by Darin Adler.
2661
2662         * WebView/WebPreferenceKeysPrivate.h:
2663         * WebView/WebPreferences.mm:
2664         (+[WebPreferences initialize]):
2665         (-[WebPreferences allowsAlternateFullscreen]):
2666         (-[WebPreferences setAllowsAlternateFullscreen:]):
2667         * WebView/WebPreferencesPrivate.h:
2668         * WebView/WebView.mm:
2669         (-[WebView _preferencesChanged:]):
2670
2671 2014-11-16  Tim Horton  <timothy_horton@apple.com>
2672
2673         Use TextIndicator instead of the built in Lookup highlight
2674         https://bugs.webkit.org/show_bug.cgi?id=138775
2675         <rdar://problem/18953982>
2676
2677         Reviewed by Anders Carlsson.
2678
2679         * WebCoreSupport/WebSystemInterface.mm:
2680         (InitWebCoreSystemInterface):
2681         Remove a WKSI import.
2682
2683         * WebView/WebActionMenuController.mm:
2684         (-[WebActionMenuController _lookupText:]):
2685         (-[WebActionMenuController _createActionMenuItemForTag:]):
2686         Make use of the new Lookup SPI header.
2687         Disable the Lookup item if lookup is not available.
2688
2689 2014-11-15  Tim Horton  <timothy_horton@apple.com>
2690
2691         Implement data detectors and mailto action menus for WebKit1
2692         https://bugs.webkit.org/show_bug.cgi?id=138765
2693         <rdar://problem/18877535>
2694
2695         Reviewed by Beth Dakin.
2696
2697         * WebView/WebActionMenuController.h:
2698         * WebView/WebActionMenuController.mm:
2699         (-[WebActionMenuController willOpenMenu:withEvent:]):
2700         Tell DataDetectors that the menu is going to open.
2701         Select the text (or not) based on the number of items in the menu, just like WebKit2.
2702
2703         (-[WebActionMenuController didCloseMenu:withEvent:]):
2704         Tell DataDetectors that the menu closed.
2705
2706         (-[WebActionMenuController _defaultMenuItemsForLink]):
2707         Move these checks out of _defaultMenuItemsForLink, because we expect this
2708         to always return a complete link menu.
2709
2710         (-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
2711         Implement. More or less copied from WebKit2.
2712
2713         (-[WebActionMenuController _selectDataDetectedText]):
2714         Select the stashed range.
2715
2716         (-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
2717         Implement. More or less copied from WebKit2.
2718         The yellow highlight isn't hooked up yet.
2719         Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
2720
2721         (-[WebActionMenuController _selectLookupText]):
2722         Remove an unnecessary return.
2723
2724         (-[WebActionMenuController _defaultMenuItems]):
2725         Call into the two new menu types.
2726
2727         * WebView/WebUIDelegatePrivate.h:
2728
2729 2014-11-14  Myles C. Maxfield  <mmaxfield@apple.com>
2730
2731         Get rid of WebFontCache
2732         https://bugs.webkit.org/show_bug.cgi?id=134752
2733
2734         Reviewed by Dave Hyatt.
2735
2736         * WebView/WebHTMLView.mm:
2737
2738 2014-11-14  Timothy Horton  <timothy_horton@apple.com>
2739
2740         Update some artwork for the legacy WebKit action menu
2741         https://bugs.webkit.org/show_bug.cgi?id=138758
2742         <rdar://problem/18989840>
2743
2744         * WebView/WebActionMenuController.mm:
2745         (webKitBundleImageNamed): Deleted.
2746         Fix the build.
2747
2748 2014-11-14  Tim Horton  <timothy_horton@apple.com>
2749
2750         Update some artwork for the legacy WebKit action menu
2751         https://bugs.webkit.org/show_bug.cgi?id=138758
2752         <rdar://problem/18989840>
2753
2754         Reviewed by Simon Fraser.
2755
2756         * WebView/WebActionMenuController.mm:
2757         (-[WebActionMenuController _createActionMenuItemForTag:]):
2758
2759 2014-11-14  Daniel Bates  <dabates@apple.com>
2760
2761         [iOS] NSFileManager and QuickLook SPI not available in public SDK
2762         https://bugs.webkit.org/show_bug.cgi?id=138742
2763
2764         Reviewed by Pratik Solanki.
2765
2766         Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
2767
2768         * WebCoreSupport/WebFrameLoaderClient.mm:
2769
2770 2014-11-14  Beth Dakin  <bdakin@apple.com>
2771
2772         WK1: Webpage preview can come up in wrong location
2773         https://bugs.webkit.org/show_bug.cgi?id=138747
2774         -and corresponding-
2775         rdar://problem/18979004
2776
2777         Reviewed by Tim Horton.
2778
2779         Converting to window twice is bad.
2780         * WebView/WebActionMenuController.mm:
2781         (elementBoundingBoxInWindowCoordinatesFromNode):
2782         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2783         (elementBoundingBoxFromNode): Deleted.
2784
2785 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2786
2787         Move FontMac and FontCacheMac off of WKSI
2788         https://bugs.webkit.org/show_bug.cgi?id=138633
2789
2790         Reviewed by Simon Fraser.
2791
2792         * WebCoreSupport/WebSystemInterface.mm:
2793         (InitWebCoreSystemInterface):
2794         * WebKit.order:
2795
2796 2014-11-13  Beth Dakin  <bdakin@apple.com>
2797
2798         WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
2799         https://bugs.webkit.org/show_bug.cgi?id=138716
2800         -and corresponding-
2801         rdar://problem/18977222
2802
2803         Reviewed by Tim Horton.
2804
2805         It’s not necessary to use the WebElementDictionary for so many things now that we 
2806         are caching the HitTestResult. We should just use the HitTestResult.
2807
2808         * WebView/WebActionMenuController.mm:
2809         (-[WebActionMenuController prepareForMenu:withEvent:]):
2810         (-[WebActionMenuController _openURLFromActionMenu:]):
2811         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
2812         (elementBoundingBoxFromNode):
2813         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
2814         (-[WebActionMenuController _defaultMenuItemsForLink]):
2815         (-[WebActionMenuController _defaultMenuItemsForImage]):
2816         (-[WebActionMenuController _defaultMenuItemsForVideo]):
2817         (-[WebActionMenuController _defaultMenuItemsForText]):
2818         (-[WebActionMenuController _defaultMenuItemsForEditableText]):
2819         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
2820         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
2821         (-[WebActionMenuController _createActionMenuItemForTag:]):
2822         (-[WebActionMenuController _defaultMenuItems]):
2823         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
2824         (-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
2825         (-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
2826         (-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
2827         (-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
2828         (-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
2829         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
2830         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
2831         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
2832         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
2833
2834 2014-11-13  Daniel Bates  <dabates@apple.com>
2835
2836         [iOS] NSGeometry data types are not available in the public SDK
2837         https://bugs.webkit.org/show_bug.cgi?id=137536
2838
2839         Reviewed by David Kilzer.
2840
2841         Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
2842         private header.
2843
2844         * DOM/WebDOMOperationsPrivate.h:
2845
2846 2014-11-13  Beth Dakin  <bdakin@apple.com>
2847
2848         WK1: Support default actions for video
2849         https://bugs.webkit.org/show_bug.cgi?id=138713
2850         -and corresponding-
2851         rdar://problem/18877520
2852
2853         Reviewed by Tim Horton.
2854
2855         Call setToNonShadowAncestor() for media HitTestResults.
2856         * WebView/WebActionMenuController.mm:
2857         (-[WebActionMenuController performHitTestAtPoint:]):
2858
2859         Default items and actions.
2860         (-[WebActionMenuController _defaultMenuItemsForVideo:]):
2861         (-[WebActionMenuController _copyVideoURL:]):
2862         (-[WebActionMenuController _saveVideoToDownloads:]):
2863         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2864         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2865         * WebView/WebUIDelegatePrivate.h:
2866
2867 2014-11-13  Tim Horton  <timothy_horton@apple.com>
2868
2869         WK1: Update icon for Add to Reading List
2870         https://bugs.webkit.org/show_bug.cgi?id=138710
2871         <rdar://problem/18975774>
2872
2873         Reviewed by Beth Dakin.
2874
2875         * WebView/WebActionMenuController.mm:
2876         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2877         Use the right icon, matching WebKit2.
2878
2879 2014-11-12  Beth Dakin  <bdakin@apple.com>
2880
2881         WK1: Support default actions for images
2882         https://bugs.webkit.org/show_bug.cgi?id=138668
2883         -and corresponding-
2884         rdar://problem/18785434
2885
2886         Reviewed by Tim Horton.
2887
2888         * WebView/WebActionMenuController.h:
2889         * WebView/WebActionMenuController.mm:
2890         (-[WebActionMenuController didCloseMenu:withEvent:]):
2891         (-[WebActionMenuController _defaultMenuItemsForImage:]):
2892         (-[WebActionMenuController _copyImage:]):
2893         (temporaryPhotosDirectoryPath):
2894         (pathToPhotoOnDisk):
2895         (-[WebActionMenuController _canAddMediaToPhotos]):
2896         (-[WebActionMenuController _addImageToPhotos:]):
2897         (-[WebActionMenuController _saveImageToDownloads:]):
2898         (-[WebActionMenuController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
2899         (-[WebActionMenuController sharingServicePicker:delegateForSharingService:]):
2900         (-[WebActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2901         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2902         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2903         * WebView/WebUIDelegatePrivate.h:
2904
2905 2014-11-11  Beth Dakin  <bdakin@apple.com>
2906
2907         Action menu hit testing is not working properly with all WK1 apps
2908         https://bugs.webkit.org/show_bug.cgi?id=138643
2909         -and corresponding-
2910         rdar://problem/18949376
2911
2912         Reviewed by Tim Horton.
2913
2914         * WebView/WebActionMenuController.mm:
2915         (-[WebActionMenuController prepareForMenu:withEvent:]):
2916         (-[WebActionMenuController _lookupText:]):
2917
2918 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2919
2920         Finish moving CTFontGetVerticalGlyphsForCharacters and CTLineCreateWithUniCharProvider out from WKSI
2921         https://bugs.webkit.org/show_bug.cgi?id=138623
2922
2923         Reviewed by Geoff Garen.
2924
2925         * WebCoreSupport/WebSystemInterface.mm:
2926         (InitWebCoreSystemInterface):
2927         * WebKit.order:
2928
2929 2014-11-11  Tim Horton  <timothy_horton@apple.com>
2930
2931         Localize strings for action menus
2932         https://bugs.webkit.org/show_bug.cgi?id=138591
2933         <rdar://problem/18815343>
2934
2935         Reviewed by Dan Bates.
2936
2937         * WebView/WebActionMenuController.mm:
2938         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2939         Make use of the new strings.
2940
2941 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2942
2943         Cleanup from r175379
2944         https://bugs.webkit.org/show_bug.cgi?id=138616
2945
2946         Reviewed by Simon Fraser.
2947
2948         * WebCoreSupport/WebSystemInterface.mm:
2949         (InitWebCoreSystemInterface):
2950         * WebKit.order:
2951
2952 2014-11-11  Myles C. Maxfield  <mmaxfield@apple.com>
2953
2954         Move CTFontTransformGlyphs out from WKSI
2955         https://bugs.webkit.org/show_bug.cgi?id=138599
2956
2957         Reviewed by Simon Fraser.
2958
2959         * WebCoreSupport/WebSystemInterface.mm:
2960         (InitWebCoreSystemInterface):
2961         * WebKit.order:
2962
2963 2014-11-11  Dan Bernstein  <mitz@apple.com>
2964
2965         More iOS build fix.
2966
2967         * WebView/WebHTMLViewInternal.h:
2968
2969 2014-11-11  Dan Bernstein  <mitz@apple.com>
2970
2971         iOS build fix.
2972
2973         * WebView/WebHTMLView.mm:
2974
2975 2014-11-10  Beth Dakin  <bdakin@apple.com>
2976
2977         WK1: Support default actions for editable text with misspelled word
2978         https://bugs.webkit.org/show_bug.cgi?id=138590
2979         -and corresponding-
2980         rdar://problem/18877506
2981
2982         Reviewed by Tim Horton.
2983
2984         If there are misspelled word suggestions for editable text, create a new type of 
2985         menu with a spelling suggestion sub-menu.
2986
2987         * WebView/WebActionMenuController.mm:
2988         (-[WebActionMenuController isMenuForTextContent]):
2989         (-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]):
2990         (-[WebActionMenuController _changeSelectionToSuggestion:]):
2991         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
2992         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
2993         * WebView/WebHTMLView.mm:
2994         (-[WebHTMLView _changeSpellingToWord:]):
2995         * WebView/WebHTMLViewInternal.h:
2996         * WebView/WebUIDelegatePrivate.h:
2997
2998 2014-11-10  Beth Dakin  <bdakin@apple.com>
2999
3000         WK1: Support default actions for editable whitespace
3001         https://bugs.webkit.org/show_bug.cgi?id=138586
3002         -and corresponding-
3003         rdar://problem/18932048
3004
3005         Reviewed by Tim Horton.
3006
3007         New menu type. Just wants paste.
3008
3009         * WebView/WebActionMenuController.mm:
3010         (-[WebActionMenuController isMenuForTextContent]):
3011         (-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]):
3012         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3013         * WebView/WebUIDelegatePrivate.h:
3014
3015 2014-11-10  Beth Dakin  <bdakin@apple.com>
3016
3017         WK1: Support default actions for editable text
3018         https://bugs.webkit.org/show_bug.cgi?id=138580
3019         -and corresponding-
3020         rdar://problem/18877497
3021
3022         Reviewed by Tim Horton.
3023
3024         New menu type, and new action type for paste. 
3025
3026         * WebView/WebActionMenuController.mm:
3027         (-[WebActionMenuController isMenuForTextContent]):
3028         (-[WebActionMenuController willOpenMenu:withEvent:]):
3029         (-[WebActionMenuController _defaultMenuItemsForEditableText:]):
3030         (-[WebActionMenuController _paste:]):
3031         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3032         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3033         * WebView/WebUIDelegatePrivate.h:
3034
3035 2014-11-10  Beth Dakin  <bdakin@apple.com>
3036
3037         WK1: Text is getting selected even when an action menu fails to invoke
3038         https://bugs.webkit.org/show_bug.cgi?id=138576
3039         -and corresponding-
3040         rdar://problem/18931330
3041
3042         Reviewed by Tim Horton.
3043
3044         Selection changes should happen in willOpenMenu: instead of prepareForMenu:
3045         * WebView/WebActionMenuController.h:
3046         * WebView/WebActionMenuController.mm:
3047         (-[WebActionMenuController prepareForMenu:withEvent:]):
3048         (-[WebActionMenuController willOpenMenu:withEvent:]):
3049
3050         _selectLookupText no longer needs to return a BOOL indicating success or failure.
3051         (-[WebActionMenuController _selectLookupText]):
3052         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3053
3054         Pass willOpenMenu: on to the controller.
3055         * WebView/WebView.mm:
3056         (-[WebView willOpenMenu:withEvent:]):
3057
3058 2014-11-10  Beth Dakin  <bdakin@apple.com>
3059
3060         Speculative build fix.
3061
3062         * WebView/WebActionMenuController.mm:
3063
3064 2014-11-10  Beth Dakin  <bdakin@apple.com>
3065
3066         Action menu initialization should be moved to _commonInitializationWithFrameName
3067         https://bugs.webkit.org/show_bug.cgi?id=138572
3068         -and corresponding-
3069         rdar://problem/18929733
3070
3071         Reviewed by Tim Horton.
3072
3073         * WebView/WebView.mm:
3074         (-[WebView _commonInitializationWithFrameName:groupName:]):
3075         (-[WebView _initWithFrame:frameName:groupName:]):
3076
3077 2014-11-10  Beth Dakin  <bdakin@apple.com>
3078
3079         WK1: Support default actions for read-only text
3080         https://bugs.webkit.org/show_bug.cgi?id=138552
3081         -and corresponding-
3082         rdar://problem/18877483
3083
3084         Reviewed by Tim Horton.
3085
3086         New WKSystemInterface functions that WebCore needs to use.
3087         * WebCoreSupport/WebSystemInterface.mm:
3088         (InitWebCoreSystemInterface):
3089
3090         WebActionMenuController now keeps an ivar for the WebCore::HitTestResult. This 
3091         makes a lot of things easier.
3092         * WebView/WebActionMenuController.h:
3093         * WebView/WebActionMenuController.mm:
3094
3095         Perform the hit test ourselves instead of calling into WebView so that we can more 
3096         easily save the WebCore::HitTestResult for ourselves.
3097         (-[WebActionMenuController performHitTestAtPoint:]):
3098
3099         Clear selection for non-text menus.
3100         (-[WebActionMenuController prepareForMenu:withEvent:]):
3101
3102         Re-set the _type here just to be safe.
3103         (-[WebActionMenuController didCloseMenu:withEvent:]):
3104
3105         Moving this method to be next to the link actions so they can be within a pragma 
3106         mark.
3107         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3108
3109         New method for default text actions — lookup and copy.
3110         (-[WebActionMenuController _defaultMenuItemsForText:]):
3111         (-[WebActionMenuController _copySelection:]):
3112         (-[WebActionMenuController _lookupText:]):
3113
3114         If there is not already a selection, invoking the action menu on text should 
3115         select the lookup text.
3116         (-[WebActionMenuController _selectLookupText]):
3117         (performDictionaryLookupForSelection):
3118         (performDictionaryLookupForRange):
3119
3120         Handle text now.
3121         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3122         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3123
3124         New enum values.
3125         * WebView/WebUIDelegatePrivate.h:
3126
3127         Pass didCloseMenu on to the controller.
3128         * WebView/WebView.mm:
3129         (-[WebView didCloseMenu:withEvent:]):
3130
3131 2014-11-09  Chris Dumez  <cdumez@apple.com>
3132
3133         Add a more correct way to compare floating point numbers and use it
3134         https://bugs.webkit.org/show_bug.cgi?id=138527
3135
3136         Reviewed by Darin Adler.
3137
3138         Use the new WTF::areEssentuallyEqual() utility function from MathExtras.h
3139         to compare floating-point numbers.
3140
3141         * WebView/WebHTMLView.mm:
3142         (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
3143
3144 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
3145
3146         Delete cookies between tests
3147         https://bugs.webkit.org/show_bug.cgi?id=138528
3148
3149         Reviewed by Sam Weinig.
3150
3151         * WebView/WebPreferences.mm: (+[WebPreferences _clearNetworkLoaderSession]):
3152         * WebView/WebPreferencesPrivate.h:
3153         Added an SPI for DumpRenderTree.
3154
3155 2014-11-07  Eric Carlson  <eric.carlson@apple.com>
3156
3157         [iOS] Update optimized fullscreen media controls
3158         https://bugs.webkit.org/show_bug.cgi?id=138493
3159
3160         Reviewed by Brent Fulgham.
3161
3162         * WebCoreSupport/WebSystemInterface.mm:
3163         (InitWebCoreSystemInterface): Initialize GetMediaUIImageData.
3164
3165 2014-11-06  Daniel Jalkut  <jalkut@red-sweater.com>
3166
3167         Wrap the bulk of -[WebView dealloc] with an autorelease pool.
3168         https://bugs.webkit.org/show_bug.cgi?id=138443
3169
3170         Reviewed by Anders Carlsson.
3171
3172         Wrapping the dealloc method in its own autorelease pool avoids the problem of
3173         complex tear-downs leading to the WebView itself being added to an autorelease
3174         pool that is not drained until after the instance has been dealloc'd.
3175  
3176         * WebView/WebView.mm:
3177         (-[WebView dealloc]):
3178
3179 2014-11-05  Jer Noble  <jer.noble@apple.com>
3180
3181         De-templatize Timer
3182         https://bugs.webkit.org/show_bug.cgi?id=138450
3183
3184         Reviewed by Anders Carlsson.
3185
3186         Remove template specifiers from Timer.
3187
3188         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3189         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3190         (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
3191         * Plugins/WebNetscapePluginStream.h:
3192         * Plugins/WebNetscapePluginStream.mm:
3193         (WebNetscapePluginStream::deliverDataTimerFired):
3194
3195 2014-11-05  Dan Bernstein  <mitz@apple.com>
3196
3197         Remove the unused deletion UI feature
3198         https://bugs.webkit.org/show_bug.cgi?id=138442
3199
3200         Rubber-stamped by Alexey Proskuryakov.
3201
3202         * DefaultDelegates/WebDefaultEditingDelegate.m:
3203         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted.
3204         * WebCoreSupport/WebEditorClient.h:
3205         * WebCoreSupport/WebEditorClient.mm:
3206         (WebEditorClient::shouldShowDeleteInterface): Deleted.
3207         * WebView/WebEditingDelegatePrivate.h: Removed declaration of
3208         -webView:shouldShowDeleteInterfaceForElement:.
3209
3210 2014-11-03  Dean Jackson  <dino@apple.com>
3211
3212         Add ENABLE_FILTERS_LEVEL_2 feature guard.
3213         https://bugs.webkit.org/show_bug.cgi?id=138362
3214
3215         Reviewed by Tim Horton.
3216
3217         Add a new feature define for Level 2 of CSS Filters.
3218         http://dev.w3.org/fxtf/filters-2/
3219
3220         * Configurations/FeatureDefines.xcconfig:
3221
3222 2014-11-03  Jeremy Jones  <jeremyj@apple.com>
3223
3224         Add button and enable optimized fullscreen.
3225         https://bugs.webkit.org/show_bug.cgi?id=138351
3226
3227         Reviewed by Eric Carlson.
3228
3229         Add IsOptimizedFullscreenSupported to enable the feature only where appropriate.
3230
3231         * WebCoreSupport/WebSystemInterface.mm:
3232         (InitWebCoreSystemInterface): added
3233
3234 2014-11-04  Chris Dumez  <cdumez@apple.com>
3235
3236         Add ptr() method to Ref class
3237         https://bugs.webkit.org/show_bug.cgi?id=138361
3238
3239         Reviewed by Darin Adler.
3240
3241         Use the new Ref::ptr() method.
3242
3243         * WebView/WebFrame.mm:
3244         (-[WebFrame _setTypingStyle:withUndoAction:]):
3245         * WebView/WebHTMLView.mm:
3246         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3247         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
3248         * WebView/WebView.mm:
3249         (-[WebView applyStyle:]):
3250
3251 2014-11-04  Darin Adler  <darin@apple.com>
3252
3253         Eliminate ResourceBuffer and use SharedBuffer directly instead
3254         https://bugs.webkit.org/show_bug.cgi?id=138174
3255
3256         Reviewed by Antti Koivisto.
3257
3258         * WebView/WebDataSource.mm:
3259         (-[WebDataSource data]): Use SharedBuffer directly.
3260         * WebView/WebHTMLView.mm:
3261         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3262
3263 2014-11-03  Commit Queue  <commit-queue@webkit.org>
3264
3265         Unreviewed, rolling out r175406, r175413, and r175423.
3266         https://bugs.webkit.org/show_bug.cgi?id=138327
3267
3268         Multipart tests are still broken (Requested by ap on #webkit).
3269
3270         Reverted changesets:
3271
3272         "Eliminate ResourceBuffer and use SharedBuffer directly
3273         instead"
3274         https://bugs.webkit.org/show_bug.cgi?id=138174
3275         http://trac.webkit.org/changeset/175406
3276
3277         "Unreviewed, iOS build fix since 175406."
3278         http://trac.webkit.org/changeset/175413
3279
3280         "Fix assertion in CachedResource::addDataBuffer"
3281         http://trac.webkit.org/changeset/175423
3282
3283 2014-10-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3284
3285         Use std::unique_ptr for TypeCountSet
3286         https://bugs.webkit.org/show_bug.cgi?id=138242
3287
3288         Reviewed by Andreas Kling.
3289
3290         * Misc/WebCoreStatistics.mm:
3291         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Use std::unique_ptr<> instead of OwnPtr.
3292         (+[WebCoreStatistics javaScriptObjectTypeCounts]): ditto.
3293
3294 2014-10-31  Beth Dakin  <bdakin@apple.com>
3295
3296         Use system art for action menus when possible
3297         https://bugs.webkit.org/show_bug.cgi?id=138260
3298
3299         Reviewed by Tim Horton.
3300
3301         * WebView/WebActionMenuController.mm:
3302         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3303
3304 2014-10-30  Darin Adler  <darin@apple.com>
3305
3306         Eliminate ResourceBuffer and use SharedBuffer directly instead
3307         https://bugs.webkit.org/show_bug.cgi?id=138174
3308
3309         Reviewed by Antti Koivisto.
3310
3311         * WebView/WebDataSource.mm:
3312         (-[WebDataSource data]): Use SharedBuffer directly.
3313         * WebView/WebHTMLView.mm:
3314         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3315
3316 2014-10-30  Jer Noble  <jer.noble@apple.com>
3317
3318         [EME] Add Setting for accessing storage location for MediaKeys data
3319         https://bugs.webkit.org/show_bug.cgi?id=138147
3320
3321         Reviewed by Brady Eidson.
3322
3323         * WebView/WebPreferenceKeysPrivate.h:
3324         * WebView/WebPreferences.mm:
3325         (+[WebPreferences initialize]): Set default location.
3326         (-[WebPreferences mediaKeysStorageDirectory]): Simple accessor.
3327         (-[WebPreferences setMediaKeysStorageDirectory:]): Simple setter.
3328         * WebView/WebPreferencesPrivate.h:
3329         * WebView/WebView.mm:
3330         (-[WebView _preferencesChanged:]): Pass location from WebPreferences into Settings.
3331
3332 2014-10-30  Dana Burkart  <dburkart@apple.com>
3333
3334         <rdar://problem/18821260> Prepare for the mysterious future
3335
3336         Reviewed by Lucas Forschler.
3337
3338         * Configurations/Base.xcconfig:
3339         * Configurations/DebugRelease.xcconfig:
3340         * Configurations/FeatureDefines.xcconfig:
3341         * Configurations/Version.xcconfig:
3342
3343 2014-10-28  Jeremy Jones  <jeremyj@apple.com>
3344
3345         Add optimized fullscreen mode.
3346         https://bugs.webkit.org/show_bug.cgi?id=138044
3347
3348         Reviewed by Jer Noble.
3349
3350         Enable different types of fullscreen video behavior.
3351         Add an enum parameter to enterVideoFullscreenForVideoElement for alternate types of fullscreen.
3352
3353         * WebCoreSupport/WebChromeClient.h: Add fullscreenType parameter
3354         * WebCoreSupport/WebChromeClient.mm:
3355         (WebChromeClient::enterVideoFullscreenForVideoElement): ditto
3356         * WebView/WebView.mm:
3357         (-[WebView _enterVideoFullscreenForVideoElement:type:]): ditto
3358         (-[WebView _enterVideoFullscreenForVideoElement:]): Deleted.
3359         * WebView/WebViewInternal.h: ditto
3360
3361 2014-10-27  Beth Dakin  <bdakin@apple.com>
3362
3363         Provide a way for WebKit1 clients to override default action menu items
3364         https://bugs.webkit.org/show_bug.cgi?id=138066
3365         -and corresponding-
3366         rdar://problem/18451638
3367
3368         Reviewed by Anders Carlsson.
3369
3370         WebActionMenuController now has an ivar for the WebActionMenuType so that it can 
3371         send that along to clients customizing the menu.
3372         * WebView/WebActionMenuController.h:
3373         * WebView/WebActionMenuController.mm:
3374         (-[WebActionMenuController prepareForMenu:withEvent:]):
3375         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3376
3377         New enum and new SPI to customize menus.
3378         * WebView/WebUIDelegatePrivate.h:
3379
3380 2014-10-24  Benjamin Poulain  <bpoulain@apple.com>
3381
3382         Fix the iOS build
3383
3384         * Configurations/WebKitLegacy.xcconfig:
3385         * WebView/WebView.mm:
3386
3387 2014-10-24  Beth Dakin  <bdakin@apple.com>
3388
3389         Build fix.
3390
3391         * WebView/WebActionMenuController.mm:
3392         (-[WebActionMenuController _openURLFromActionMenu:]):
3393         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3394         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3395
3396 2014-10-24  Beth Dakin  <bdakin@apple.com>
3397
3398         WebKit1 should support action menus
3399         https://bugs.webkit.org/show_bug.cgi?id=138032
3400
3401         Reviewed by Tim Horton.
3402
3403         This patch adds basic support for action menus and adds actions for links.
3404
3405         Helper class takes care of all of the action menu work. WebView will forward the 
3406         prepareForMenu: message, and then the helper class takes it from there.
3407         * WebView/WebActionMenuController.h: Added.
3408         * WebView/WebActionMenuController.mm: Added.
3409         (-[WebActionMenuController webViewClosed]):
3410         (-[WebActionMenuController prepareForMenu:withEvent:]):
3411
3412         Selectors for link actions.
3413         (-[WebActionMenuController _openURLFromActionMenu:]):
3414         (-[WebActionMenuController _addToReadingListFromActionMenu:]):
3415         (-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
3416         (-[WebActionMenuController _quickLookURLFromActionMenu:]):
3417         (-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
3418         (webKitBundleImageNamed):
3419         (-[WebActionMenuController _defaultMenuItemsForLink:]):
3420         (-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
3421
3422         Tags for the action menu items.
3423         * WebView/WebUIDelegatePrivate.h:
3424         * WebView/WebView.mm:
3425
3426         Set the action menu if possible and create the controller.
3427         (-[WebView _initWithFrame:frameName:groupName:]):
3428         (-[WebView _close]):
3429         (-[WebView prepareForMenu:withEvent:]):
3430
3431         WebViewData stores the WebActionMenuHelper
3432         * WebView/WebViewData.h:
3433         * WebView/WebViewData.mm:
3434         (-[WebViewPrivate dealloc]):
3435
3436 2014-10-23  Joseph Pecoraro  <pecoraro@apple.com>
3437
3438         Web Inspector: Provide a way to have alternate inspector agents
3439         https://bugs.webkit.org/show_bug.cgi?id=137901
3440
3441         Reviewed by Brian Burg.
3442
3443         * Configurations/FeatureDefines.xcconfig:
3444
3445 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3446
3447         Add some SPI headers for NSExtension and NSSharingService{Picker}
3448         https://bugs.webkit.org/show_bug.cgi?id=138027
3449
3450         Reviewed by Anders Carlsson.
3451
3452         * Misc/WebSharingServicePickerController.h:
3453         * Misc/WebSharingServicePickerController.mm:
3454         * WebCoreSupport/WebSelectionServiceController.mm:
3455         * WebCoreSupport/WebContextMenuClient.mm:
3456         Fix a sorting issue.
3457         Replace redefinitions with SPI header #imports.
3458
3459 2014-10-23  Tim Horton  <timothy_horton@apple.com>
3460
3461         Crashes under WebSelectionServiceController::hasRelevantSelectionServices
3462         https://bugs.webkit.org/show_bug.cgi?id=138013
3463
3464         Reviewed by Dan Bernstein.
3465
3466         * WebCoreSupport/WebSelectionServiceController.mm:
3467         (WebSelectionServiceController::hasRelevantSelectionServices):
3468         Don't adopt this autoreleased object.
3469
3470 2014-10-22  Chris Dumez  <cdumez@apple.com>
3471
3472         [Mac][WK2] Fix applicationIsSafari() detection
3473         https://bugs.webkit.org/show_bug.cgi?id=137893
3474
3475         Reviewed by Alexey Proskuryakov.
3476
3477         Provide an implementation for FrameLoaderClient's new
3478         needsQuickLookResourceCachingQuirks() that returns
3479         a static flag initialized using
3480         QuickLookMac::computeNeedsQuickLookResourceCachingQuirks().
3481
3482         * WebCoreSupport/WebFrameLoaderClient.h:
3483         * WebCoreSupport/WebFrameLoaderClient.mm:
3484
3485 2014-10-20  Chris Dumez  <cdumez@apple.com>
3486
3487         ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition
3488         https://bugs.webkit.org/show_bug.cgi?id=137797
3489
3490         Reviewed by Darin Adler.
3491
3492         Call ResourceRequest::setDomainForPartitionName() instead of
3493         setPartitionName() as the argument is a domain, not a valid
3494         partition name.
3495
3496         * Misc/WebCache.mm:
3497         (+[WebCache addImageToCache:forURL:forFrame:]):
3498         (+[WebCache removeImageFromCacheForURL:forFrame:]):
3499
3500 2014-10-20  Andy Estes  <aestes@apple.com>
3501
3502         Fix the iOS build.
3503
3504         * WebView/WebFrame.mm:
3505         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3506         (-[WebFrame dictationResultMetadataForRange:]):
3507
3508 2014-10-19  Chris Dumez  <cdumez@apple.com>
3509
3510         Use is<>() / downcast<>() for all remaining RenderObject subclasses
3511         https://bugs.webkit.org/show_bug.cgi?id=137845
3512
3513         Reviewed by Darin Adler.
3514
3515         Use is<>() / downcast<>() for all remaining RenderObject subclasses and 
3516         clean up the surrounding code.
3517
3518         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3519         (-[WebHostedNetscapePluginView pluginHostDied]):
3520         * Plugins/WebBaseNetscapePluginView.mm:
3521         (-[WebBaseNetscapePluginView _windowClipRect]):
3522         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3523         * WebCoreSupport/WebFrameLoaderClient.mm:
3524         (WebFrameLoaderClient::createPlugin):
3525         (WebFrameLoaderClient::createJavaAppletWidget):
3526
3527 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3528
3529         Build fix for 32-bit Yosemite
3530
3531         * WebCoreSupport/WebContextMenuClient.mm:
3532         (WebContextMenuClient::contextMenuForEvent):
3533         Avoid using NSItemProvider in 32-bit, because it doesn't exist.
3534
3535 2014-10-17  Chris Dumez  <cdumez@apple.com>
3536
3537         Use is<>() / downcast<>() for RenderBox
3538         https://bugs.webkit.org/show_bug.cgi?id=137804
3539
3540         Reviewed by Andreas Kling.
3541
3542         Use is<>() / downcast<>() for RenderBox and clean up the surrounding
3543         code.
3544
3545         * WebCoreSupport/WebContextMenuClient.mm:
3546         (WebContextMenuClient::clientFloatRectForNode):
3547         * WebView/WebFrame.mm:
3548         (-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
3549
3550 2014-10-17  Tim Horton  <timothy_horton@apple.com>
3551
3552         Fix the build with the public SDK.
3553
3554         * WebCoreSupport/WebSelectionServiceController.mm:
3555         We should transition all this SPI to real SPI headers as soon as possible.
3556
3557 2014-10-16  Tim Horton  <timothy_horton@apple.com>
3558
3559         Implement selection services menu for Legacy WebKit
3560         https://bugs.webkit.org/show_bug.cgi?id=137582
3561         <rdar://problem/18604241>
3562
3563         Reviewed by Brady Eidson.
3564
3565         * Misc/WebSharingServicePickerController.h:
3566         Move SPI into the header (in the near future it will be moved to a modern-style SPI header).
3567         Add WebSharingServicePickerClient, which other classes can implement
3568         instead of tying WebSharingServicePickerController strongly to WebContextMenuClient.
3569         Make initWithData:... -> initWithItems:... instead, taking an array of NSItemProviders.
3570
3571         * Misc/WebSharingServicePickerController.mm:
3572         Pass in NSSharingServicePickerStyle, so that clients can specify the style.
3573
3574         (-[WebSharingServicePickerController clear]):
3575         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
3576         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
3577         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
3578         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
3579         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3580         Make use of WebSharingServicePickerClient.
3581
3582         (-[WebSharingServicePickerController sharingService:didShareItems:]):
3583         If we're returned a NSAttributedString, paste it on top of the current selection,
3584         similar to what the WebKit2 implementation currently does.
3585         
3586         * WebCoreSupport/WebChromeClient.h:
3587         * WebCoreSupport/WebChromeClient.mm:
3588         (WebChromeClient::handleTelephoneNumberClick):
3589         (WebChromeClient::handleSelectionServiceClick):
3590         (WebChromeClient::hasRelevantSelectionServices):
3591         Override the services-related ChromeClient functions, forward them to WebSelectionServiceController.
3592
3593         * WebCoreSupport/WebContextMenuClient.h:
3594         * WebCoreSupport/WebContextMenuClient.mm:
3595         (WebContextMenuClient::sharingServicePickerWillBeDestroyed):
3596         (WebContextMenuClient::pageForSharingServicePicker):
3597         (WebContextMenuClient::windowForSharingServicePicker):
3598         (WebContextMenuClient::screenRectForCurrentSharingServicePickerItem):
3599         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3600         (WebContextMenuClient::contextMenuForEvent):
3601         (WebContextMenuClient::screenRectForHitTestNode): Deleted.
3602         (WebContextMenuClient::renderedImageForControlledImage): Deleted.
3603         (WebContextMenuClient::clearSharingServicePickerController): Deleted.
3604         Have WebContextMenuClient implement WebSharingServicePickerClient to avoid
3605         having WebSharingServicePickerController tightly bound to it.
3606         Make an NSItemProvider array when instantiating WebSharingServicePickerController
3607         instead of handing it data directly.
3608
3609         * WebCoreSupport/WebSelectionServiceController.h: Copied from Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.h.
3610         * WebCoreSupport/WebSelectionServiceController.mm: Added.
3611         (WebSelectionServiceController::WebSelectionServiceController):
3612         Add WebSelectionServiceController, which will act as the WebSharingServicePickerClient
3613         for selection services.
3614
3615         (WebSelectionServiceController::handleSelectionServiceClick):
3616         Create a WebSharingSericePickerController with the selection's attributed string, and show its menu.
3617
3618         (hasCompatibleServicesForItems):
3619         (WebSelectionServiceController::hasRelevantSelectionServices):
3620         Determine whether or not services are available.
3621
3622         (WebSelectionServiceController::sharingServicePickerWillBeDestroyed):
3623         (WebSelectionServiceController::pageForSharingServicePicker):
3624         (WebSelectionServiceController::windowForSharingServicePicker):
3625         Implement the rest of the WebSharingServicePickerClient overrides.
3626
3627         (WebSelectionServiceController::screenRectForCurrentSharingServicePickerItem):
3628         (WebSelectionServiceController::imageForCurrentSharingServicePickerItem):
3629         These are only useful for image sharing services, so we don't need to
3630         implement them (WebContextMenuClient does, on the other hand).
3631
3632         * WebView/WebView.mm:
3633         (-[WebView _selectionServiceController]):
3634         * WebView/WebViewData.h:
3635         * WebView/WebViewData.mm:
3636         * WebView/WebViewInternal.h:
3637         Keep a WebSelectionServiceController.
3638
3639 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3640
3641         Improve debug description of WAKViews
3642         https://bugs.webkit.org/show_bug.cgi?id=137716
3643
3644         Reviewed by Simon Fraser.
3645
3646         * WebView/WebView.mm:
3647         (-[WebView _touchEventRegions]): Adding a comment.
3648
3649 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3650
3651         Addressing post-review comment.
3652         https://bugs.webkit.org/show_bug.cgi?id=137550
3653
3654         Unreviewed.
3655
3656         * WebView/WebHTMLView.mm:
3657         (fontNameForDescription):
3658         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3659
3660 2014-10-14  Chris Dumez  <cdumez@apple.com>
3661
3662         Use is<>() / downcast<>() for RenderImage
3663         https://bugs.webkit.org/show_bug.cgi?id=137683
3664
3665         Reviewed by Mihnea Ovidenie.
3666
3667         Use is<>() / downcast<>() for RenderImage.
3668
3669         * Misc/WebNSPasteboardExtras.mm:
3670         (imageFromElement):
3671         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3672
3673 2014-10-10  Daniel Bates  <dabates@apple.com>
3674
3675         Remove unused classes WebRender{Node, Layer}
3676         https://bugs.webkit.org/show_bug.cgi?id=137628
3677
3678         Reviewed by Simon Fraser.
3679
3680         We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
3681         For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.
3682
3683         * Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list
3684         of excluded source files when building for iOS.
3685         * WebKit.exp: Remove symbol for WebRenderLayer.
3686         * WebKit.mac.exp: Remove symbol for WebRenderNode.
3687         * WebView/WebRenderLayer.h: Removed.
3688         * WebView/WebRenderLayer.mm: Removed.
3689         * WebView/WebRenderNode.h: Removed.
3690         * WebView/WebRenderNode.mm: Removed.
3691
3692 2014-10-10  Chris Dumez  <cdumez@apple.com>
3693
3694         Use is<>() / downcast<>() for RenderBoxModelObject
3695         https://bugs.webkit.org/show_bug.cgi?id=137587
3696
3697         Reviewed by Mihnea Ovidenie.
3698
3699         Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
3700         surrounding code.
3701
3702         * Plugins/WebBaseNetscapePluginView.mm:
3703         (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
3704         * WebView/WebRenderLayer.mm:
3705         (-[WebRenderLayer initWithWebFrame:]):
3706
3707 2014-10-09  Dean Jackson  <dino@apple.com>
3708
3709         Remove ENABLE_CSS3_CONDITIONAL_RULES
3710         https://bugs.webkit.org/show_bug.cgi?id=137571
3711
3712         Reviewed by Simon Fraser.
3713
3714         * Configurations/FeatureDefines.xcconfig:
3715
3716 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3717
3718         Add a WebKit1 preference for selection services
3719         https://bugs.webkit.org/show_bug.cgi?id=137498
3720         <rdar://problem/18572699>
3721
3722         Reviewed by Simon Fraser.
3723
3724         * WebView/WebPreferenceKeysPrivate.h:
3725         * WebView/WebPreferences.mm:
3726         (+[WebPreferences initialize]):
3727         (-[WebPreferences serviceControlsEnabled]):
3728         (-[WebPreferences setServiceControlsEnabled:]):
3729         * WebView/WebPreferencesPrivate.h:
3730         * WebView/WebView.mm:
3731         (-[WebView _preferencesChanged:]):
3732         Add and plumb the preference.
3733
3734 2014-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
3735
3736         Remove second-to-last client of WebFontCache
3737         https://bugs.webkit.org/show_bug.cgi?id=137550
3738
3739         Reviewed by Darin Adler.
3740
3741         Use FontCache::getCachedFontData() instead of WebFontCache.
3742
3743         * WebView/WebHTMLView.mm:
3744         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3745
3746 2014-10-09  Chris Dumez  <cdumez@apple.com>
3747
3748         Use is<>() / downcast<>() for Widget subclasses
3749         https://bugs.webkit.org/show_bug.cgi?id=137549
3750
3751         Reviewed by Darin Adler.
3752
3753         Use is<>() / downcast<>() for Widget subclasses and clean up the
3754         surrounding code.
3755
3756         * WebView/WebRenderNode.mm:
3757         (copyRenderNode):
3758         * WebView/WebView.mm:
3759         (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
3760
3761 2014-10-07  Christophe Dumez  <cdumez@apple.com>
3762
3763         Use is<>() / downcast<>() for RenderText / RenderTextFragment
3764         https://bugs.webkit.org/show_bug.cgi?id=137476
3765
3766         Reviewed by Darin Adler.
3767
3768         * WebView/WebRenderNode.mm:
3769         (copyRenderNode):
3770
3771 2014-10-06  Dan Bernstein  <mitz@apple.com>
3772
3773         Build fix.
3774
3775         * Misc/WebCache.mm:
3776         (+[WebCache imageForURL:]):
3777
3778 2014-10-06  Chris Dumez  <cdumez@apple.com>
3779
3780         Unreviewed build fix after r174333.
3781
3782         Forgot explicit WebCore:: namespace.
3783
3784         * Misc/WebCache.mm:
3785         (+[WebCache imageForURL:]):
3786
3787 2014-10-05  Christophe Dumez  <cdumez@apple.com>
3788
3789         Use is<>() / downcast<>() for CachedResource subclasses
3790         https://bugs.webkit.org/show_bug.cgi?id=137431
3791
3792         Reviewed by Benjamin Poulain.
3793
3794         Use is<>() / downcast<>() for CachedResource subclasses.
3795
3796         * Misc/WebCache.mm:
3797         (+[WebCache imageForURL:]):
3798
3799 2014-10-02  Daniel Bates  <dabates@apple.com>
3800
3801         Use version number 101000 instead of 10100 for OS X Yosemite
3802         https://bugs.webkit.org/show_bug.cgi?id=137372
3803
3804         Reviewed by Mark Rowe.
3805
3806         The version number for OS X Yosemite is 101000.
3807
3808         * WebView/WebView.mm:
3809         (-[WebView _preferencesChanged:]):
3810
3811 2014-10-02  Tim Horton  <timothy_horton@apple.com>
3812
3813         Move PageOverlay[Controller] to WebCore
3814         https://bugs.webkit.org/show_bug.cgi?id=137164
3815         <rdar://problem/18508258>
3816
3817         Reviewed by Anders Carlsson.
3818
3819         * WebCoreSupport/WebChromeClient.h:
3820         * WebCoreSupport/WebChromeClient.mm:
3821         (WebChromeClient::attachViewOverlayGraphicsLayer):
3822         Add an empty ChromeClient override.
3823
3824 2014-10-01  Christophe Dumez  <cdumez@apple.com>
3825
3826         Have is<>(T*) function do a null check on the pointer argument
3827         https://bugs.webkit.org/show_bug.cgi?id=137333
3828
3829         Reviewed by Gavin Barraclough.
3830
3831         Have is<>(T*) function do a null check on the argument instead of a
3832         simple assertion. This makes sense for 2 reasons:
3833         1. It is more consistent with downcast<>(T*), which will succeed even
3834            if the argument is a nullptr.
3835         2. It simplifies the code a bit as it gets rid of a lot of explicit
3836            null checks.
3837
3838         * WebCoreSupport/WebChromeClient.mm:
3839         (WebChromeClient::focusedElementChanged):
3840         * WebCoreSupport/WebEditorClient.mm:
3841         (WebEditorClient::textFieldDidBeginEditing):
3842         (WebEditorClient::textFieldDidEndEditing):
3843         (WebEditorClient::textDidChangeInTextField):
3844         (WebEditorClient::doTextFieldCommandFromEvent):
3845         (WebEditorClient::textWillBeDeletedInTextField):
3846         (WebEditorClient::textDidChangeInTextArea):
3847         * WebView/WebHTMLRepresentation.mm:
3848         (inputElementFromDOMElement):
3849         (searchForLabelsBeforeElement):
3850         * WebView/WebRenderLayer.mm:
3851         (+[WebRenderLayer nameForLayer:]):
3852
3853 2014-10-01  Mark Rowe  <mrowe@apple.com>
3854
3855         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3856
3857         Reviewed by Dan Bernstein.
3858
3859         * Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.
3860
3861 2014-09-30  Chris Dumez  <cdumez@apple.com>
3862
3863         Use is<>() / downcast<>() for Element
3864         https://bugs.webkit.org/show_bug.cgi?id=137241
3865
3866         Reviewed by Andreas Kling.
3867
3868         Use is<>() / downcast<>() for Element instead of isElementNode() /
3869         toElement().
3870
3871         * WebView/WebRenderLayer.mm:
3872         (+[WebRenderLayer nameForLayer:]):
3873
3874 2014-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3875
3876         Move ColorInputType class to std::unique_ptr
3877         https://bugs.webkit.org/show_bug.cgi?id=137173
3878
3879         Reviewed by Darin Adler.
3880
3881         Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
3882         Child classes follow this change as well.
3883
3884         * WebCoreSupport/WebChromeClient.h:
3885         * WebCoreSupport/WebChromeClient.mm:
3886         (WebChromeClient::createColorChooser):
3887
3888 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3889
3890         Add initial is<>() / downcast<>() support for any type of Nodes
3891         https://bugs.webkit.org/show_bug.cgi?id=137056
3892
3893         Reviewed by Benjamin Poulain.
3894
3895         Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
3896         instead of isFormControlElement() / toHTMLFormControlElement().
3897
3898         * WebView/WebHTMLRepresentation.mm:
3899         (searchForLabelsBeforeElement):
3900
3901 2014-09-24  Christophe Dumez  <cdumez@apple.com>
3902
3903         Use is<HTML*Element>() instead of isHTML*Element() - Part 1
3904         https://bugs.webkit.org/show_bug.cgi?id=137068
3905
3906         Reviewed by Ryosuke Niwa.
3907
3908         Start using is<HTML*Element>() instead of isHTML*Element().
3909         Remaining usages will be updated in a follow-up patch to
3910         reduce the size of the change.
3911
3912         * WebCoreSupport/WebChromeClient.mm:
3913         (WebChromeClient::focusedElementChanged):
3914         * WebCoreSupport/WebEditorClient.mm:
3915         (WebEditorClient::textFieldDidBeginEditing):
3916         (WebEditorClient::textFieldDidEndEditing):
3917         (WebEditorClient::textDidChangeInTextField):
3918         (WebEditorClient::doTextFieldCommandFromEvent):
3919         (WebEditorClient::textWillBeDeletedInTextField):
3920         (WebEditorClient::textDidChangeInTextArea):
3921         * WebView/WebHTMLRepresentation.mm:
3922         (inputElementFromDOMElement):
3923
3924 2014-09-21  Timothy Hatcher  <timothy@apple.com>
3925
3926         Make the Web Inspector use a separate web process.
3927
3928         https://bugs.webkit.org/show_bug.cgi?id=135120
3929
3930         Reviewed by Anders Carlsson.
3931
3932         * WebCoreSupport/WebInspectorClient.h:
3933         * WebCoreSupport/WebInspectorClient.mm:
3934         (WebInspectorClient::WebInspectorClient):
3935         (WebInspectorClient::openInspectorFrontend):
3936         (WebInspectorClient::releaseFrontend):
3937         Own WebInspectorFrontendClient instead of moving it.
3938
3939 2014-09-23  Chris Dumez  <cdumez@apple.com>
3940
3941         Use downcast<HTML*Element>() instead of toHTML*Element()
3942         https://bugs.webkit.org/show_bug.cgi?id=137007
3943
3944         Reviewed by Benjamin Poulain.
3945
3946         Use downcast<HTML*Element>() instead of toHTML*Element().
3947
3948         * DOM/WebDOMOperations.mm:
3949         (-[DOMHTMLInputElement _setAutofilled:]):
3950         * WebCoreSupport/WebChromeClient.mm:
3951         (WebChromeClient::focusedElementChanged):
3952         * WebCoreSupport/WebEditorClient.mm:
3953         (WebEditorClient::textFieldDidBeginEditing):
3954         (WebEditorClient::textFieldDidEndEditing):
3955         (WebEditorClient::textDidChangeInTextField):
3956         (WebEditorClient::doTextFieldCommandFromEvent):
3957         (WebEditorClient::textWillBeDeletedInTextField):
3958         (WebEditorClient::textDidChangeInTextArea):
3959         * WebView/WebHTMLRepresentation.mm:
3960         (inputElementFromDOMElement):
3961
3962 2014-09-21  Chris Dumez  <cdumez@apple.com>
3963
3964         Generate Element casting helper functions
3965         https://bugs.webkit.org/show_bug.cgi?id=136839
3966
3967         Reviewed by Darin Adler.
3968
3969         Use JSXXX::toWrapped() instead of toXXX() function.
3970
3971         * DOM/WebDOMOperations.mm:
3972         * WebView/WebView.mm:
3973         (-[WebView _notificationIDForTesting:]):
3974
3975 2014-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3976
3977         Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
3978         https://bugs.webkit.org/show_bug.cgi?id=136972
3979
3980         Reviewed by Darin Adler.
3981
3982         * WebView/WebNotification.h:
3983         * WebView/WebNotification.mm:
3984         (-[WebNotification initWithCoreNotification:notificationID:]):
3985         Switch to RetainPtr and adopt into _private to ensure when we are
3986         deallocated that _private will get deallocated.
3987
3988 2014-09-19  Dean Jackson  <dino@apple.com>
3989
3990         Multithreaded WebGL is a bad idea - remove it
3991         https://bugs.webkit.org/show_bug.cgi?id=136964
3992         <rdar://problem/18399858>
3993
3994         Reviewed by Brent Fulgham.
3995
3996         Remove the setting to allow multithreaded WebGL.
3997
3998         * WebView/WebPreferenceKeysPrivate.h:
3999         * WebView/WebPreferences.mm:
4000         (+[WebPreferences initialize]):
4001         (-[WebPreferences multithreadedWebGLEnabled]): Deleted.
4002         (-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.
4003         * WebView/WebPreferencesPrivate.h:
4004         * WebView/WebView.mm:
4005         (-[WebView _preferencesChanged:]):
4006
4007 2014-09-19  Daniel Bates  <dabates@apple.com>
4008
4009         Always assume internal SDK when building configuration Production
4010         https://bugs.webkit.org/show_bug.cgi?id=136925
4011         <rdar://problem/18362399>
4012
4013         Reviewed by Dan Bernstein.
4014
4015         As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
4016         and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.
4017
4018         * Configurations/Base.xcconfig:
4019
4020 2014-09-17  Daniel Bates  <dabates@apple.com>
4021
4022         Unreviewed, rolling out r173695.
4023
4024         Broke building third-party Legacy WebKit apps; will
4025         investigate offline
4026
4027         Reverted changeset:
4028
4029         "[iOS] Make WebCore build with public iOS SDK"
4030         https://bugs.webkit.org/show_bug.cgi?id=136487
4031         http://trac.webkit.org/changeset/173695
4032
4033 2014-09-17  Daniel Bates  <dabates@apple.com>
4034
4035         [iOS] Make WebCore build with public iOS SDK
4036         https://bugs.webkit.org/show_bug.cgi?id=136487
4037
4038         Reviewed by David Kilzer.
4039
4040         Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
4041         actual SPI header(s).
4042
4043         * DOM/WebDOMOperationsPrivate.h:
4044         * MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header
4045         file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
4046         such files into the WebKit framework as private headers.
4047         * WebCoreSupport/WebFrameLoaderClient.mm:
4048         * WebInspector/WebNodeHighlight.mm:
4049         * WebView/WebIndicateLayer.mm:
4050         * WebView/WebRenderLayer.h:
4051         * WebView/WebView.mm:
4052
4053 2014-09-16  Daniel Bates  <dabates@apple.com>
4054
4055         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
4056         https://bugs.webkit.org/show_bug.cgi?id=136862
4057
4058         Reviewed by David Kilzer.
4059
4060         * Configurations/DebugRelease.xcconfig:
4061
4062 2014-09-16  Enrica Casucci  <enrica@apple.com>
4063
4064         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
4065         https://bugs.webkit.org/show_bug.cgi?id=136474
4066
4067         Reviewed by Benjamin Poulain.
4068
4069         This is the updated version of the patch that was landed in r173340.
4070         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
4071         and removes the assumption that EAffinity values match NSSelectionAffinity
4072         values. It also removes the includes in TextAffinity.h, creating the need to
4073         include explicitly the files when necessary.
4074
4075         * WebCoreSupport/WebEditorClient.h:
4076         (kit):
4077         (core):
4078
4079 2014-09-14  Daniel Bates  <dabates@apple.com>
4080
4081         [iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
4082         (https://bugs.webkit.org/show_bug.cgi?id=136789)
4083
4084         Substitute Node::countChildNodes() for Node::childNodeCount() in more places.
4085
4086         * WebView/WebFrame.mm:
4087         (-[WebFrame focusedNodeHasContent]):
4088
4089 2014-09-14  Chris Dumez  <cdumez@apple.com>
4090
4091         Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
4092         https://bugs.webkit.org/show_bug.cgi?id=136789
4093
4094         Reviewed by Darin Adler.
4095
4096         Rename childNodeCount() to countChildNodes().
4097
4098         * WebView/WebHTMLView.mm:
4099         (-[WebHTMLView attributedString]):
4100
4101 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
4102
4103         Re-add the request autocomplete feature
4104
4105         <https://bugs.webkit.org/show_bug.cgi?id=136730>
4106
4107         This feature was rolled out in r148731 because it was only used by
4108         Chromium. As we consider supporting this feature, roll it back in, but
4109         leave it disabled.
4110
4111         This rolls out r148731 (which removed the feature) with small changes
4112         needed to make the code build in ToT, to match modern style, to make
4113         the tests run, and to remove unused code.
4114
4115         Reviewed by Andy Estes.
4116
4117         * Configurations/FeatureDefines.xcconfig:
4118         * WebCoreSupport/WebFrameLoaderClient.h:
4119
4120 2014-09-12  Commit Queue  <commit-queue@webkit.org>
4121
4122         Unreviewed, rolling out r173575.
4123         https://bugs.webkit.org/show_bug.cgi?id=136790
4124
4125         Failing tests (Requested by enrica on #webkit).
4126
4127         Reverted changeset:
4128
4129         "Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
4130         https://bugs.webkit.org/show_bug.cgi?id=136474
4131         http://trac.webkit.org/changeset/173575
4132
4133 2014-09-12  Enrica Casucci  <enrica@apple.com>
4134
4135         Remove PLATFORM(IOS) from WebCore/editing (Part 3).
4136         https://bugs.webkit.org/show_bug.cgi?id=136474
4137
4138         Reviewed by Benjamin Poulain.
4139
4140         This is the updated version of the patch that was landed in r173340.
4141         I changed the use of IntPoint to FloatPoint since it was causing tests
4142         to fail.
4143         This patch removes the use of PLATFORM(IOS) from TextAffinity.h
4144         and removes the assumption that EAffinity values match NSSelectionAffinity
4145         values. It also removes the includes in TextAffinity.h, creating the need to
4146         include explicitly the files when necessary. It also removes the unnecessary
4147         use of platform specific types, replacing them with WebCore types.
4148
4149         * WebCoreSupport/WebEditorClient.h:
4150         (kit):
4151         (core):
4152         * WebView/WebFrameView.mm:
4153         (-[WebFrameView _scrollToBeginningOfDocument]):
4154         (-[WebFrameView _scrollToEndOfDocument]):
4155
4156 2014-09-11  Bear Travis  <betravis@adobe.com>
4157
4158         [CSS Font Loading] Enable CSS Font Loading on Mac
4159         https://bugs.webkit.org/show_bug.cgi?id=135473
4160
4161         Reviewed by Antti Koivisto.
4162
4163         Enable CSS Font Loading in FeatureDefines.
4164
4165         * Configurations/FeatureDefines.xcconfig:
4166
4167 2014-09-11  Beth Dakin  <bdakin@apple.com>
4168
4169         Support rubber-banding in sub-frames
4170         https://bugs.webkit.org/show_bug.cgi?id=136726
4171         -and corresponding-
4172         rdar://problem/10011924
4173
4174         Reviewed by Tim Horton.
4175
4176         rubberBandingForOverflowScrollEnabled is re-named to
4177         rubberBandingForSubScrollableRegionsEnabled
4178         * WebView/WebView.mm:
4179         (-[WebView _preferencesChanged:]):
4180
4181 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
4182
4183         Disable the "unreachable-code" warning
4184         https://bugs.webkit.org/show_bug.cgi?id=136677
4185
4186         Reviewed by Darin Adler.
4187
4188         * Configurations/Base.xcconfig:
4189
4190 2014-09-08  Maciej Stachowiak  <mjs@apple.com>
4191
4192         Fix 32-bit Mac build for new warnings
4193         https://bugs.webkit.org/show_bug.cgi?id=136624
4194
4195         Reviewed by Darin Adler.
4196         
4197         (Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
4198
4199         * Carbon/HIViewAdapter.m:
4200         (+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
4201
4202 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4203
4204         Remove FILTERS flag
4205         https://bugs.webkit.org/show_bug.cgi?id=136571
4206
4207         Reviewed by Darin Adler.
4208
4209         * Configurations/FeatureDefines.xcconfig:
4210
4211 2014-09-08  Jessie Berlin  <jberlin@apple.com>
4212
4213         32-bit build fix after r173364.
4214
4215         * Carbon/HIViewAdapter.m:
4216         (+[HIViewAdapter bindHIViewToNSView:nsView:]):
4217
4218 2014-09-08  Dan Bernstein  <mitz@apple.com>
4219
4220         Build fix.
4221
4222         Added back SPI that is still in use.
4223
4224         * Misc/WebNSURLExtras.h:
4225         * Misc/WebNSURLExtras.mm: