14067a5cabd3a4dd7b0b0cd4ab481ef3472745be
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2011-05-24  Michael Saboff  <msaboff@apple.com>
2
3         Reviewed by Geoffrey Garen.
4
5         Improve handling in WebCore of low memory situations
6         https://bugs.webkit.org/show_bug.cgi?id=61222
7
8         Added call to enable memory pressure handling.
9
10         * WebView/WebView.mm:
11         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
12         * WebView/WebViewInternal.h:
13
14 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
15
16         Rubberstamped by David Kilzer.
17
18         Updated some files that I forgot in my previous MHTML CL.
19
20         * Configurations/FeatureDefines.xcconfig:
21
22 2011-05-20  Jeremy Noble  <jer.noble@apple.com>
23
24         Reviewed by Simon Fraser.
25
26         Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
27         https://bugs.webkit.org/show_bug.cgi?id=61224
28
29         Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
30         versions of same.
31
32         * WebView/WebFullScreenController.mm:
33         (-[WebFullScreenController windowDidEnterFullscreen:]):
34         (-[WebFullScreenController enterFullscreen:]):
35         (-[WebFullScreenController exitFullscreen]):
36         (-[WebFullscreenWindow setRendererLayer:]):
37
38 2011-05-20  Andy Estes  <aestes@apple.com>
39
40         Reviewed by Darin Adler.
41
42         WebView loses firstResponder status when entering full-screen mode.
43         https://bugs.webkit.org/show_bug.cgi?id=61153
44
45         * Misc/WebNSWindowExtras.h:
46         * Misc/WebNSWindowExtras.m:
47         (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
48         convenience method to NSWindow that makes the given NSResponder first
49         responder only if it is a descendant of the given view.
50         * WebView/WebFullScreenController.mm:
51         (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
52         was a descendant of the browser window's first responder when entering
53         full-screen mode, set the full-screen window's first responder to that
54         same NSResponder.
55         (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
56         done in windowDidEnterFullscreen:.
57
58 2011-05-20  Enrica Casucci  <enrica@apple.com>
59
60         Reviewed by David Kilzer.
61
62         Add delegate methods about focus and blur to all elements.
63         https://bugs.webkit.org/show_bug.cgi?id=61218
64
65         We want to have delegates for these events for all the elements, not only the form elements.
66         The patch changes the name of the methods in a way that is not form element specific.
67
68         * WebCoreSupport/WebChromeClient.h:
69         * WebCoreSupport/WebChromeClient.mm:
70         (WebChromeClient::elementDidFocus):
71         (WebChromeClient::elementDidBlur):
72         * WebView/WebUIDelegatePrivate.h:
73
74 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
75
76         Reviewed by Sam Weinig.
77
78         numberOfActiveAnimations() can include animations from documents in the page cache
79         https://bugs.webkit.org/show_bug.cgi?id=53641
80
81         Pass the Frame's document as the one to count animations on.
82
83         * WebView/WebFrame.mm:
84         (-[WebFrame _numberOfActiveAnimations]):
85
86 2011-05-17  Timothy Hatcher  <timothy@apple.com>
87
88         Update the the context menu to reflect the system search provider on Mac.
89
90         <rdar://problem/9198419>
91
92         Reviewed by Sam Weinig.
93
94         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
95         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
96         create the web search context menu title.
97         * WebCoreSupport/WebSystemInterface.mm:
98         (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
99
100 2011-05-16  Emil A Eklund  <eae@chromium.org>
101
102         Reviewed by Eric Seidel.
103
104         Replace docTop/Right/Bottom/Left/Width/Height with documentRect
105         https://bugs.webkit.org/show_bug.cgi?id=60743
106
107         Replace uses of docWidth/Height with documentRect.
108
109         * WebView/WebFrame.mm:
110         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
111
112 2011-05-16  Yuzo Fujishima  <yuzo@google.com>
113
114         Reviewed by Antti Koivisto.
115
116         Fix for Bug 43704 - Web font is printed as blank if it is not cached
117         https://bugs.webkit.org/show_bug.cgi?id=43704
118
119         * WebView/WebHTMLView.mm:
120         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
121
122 2011-05-16  David Kilzer  <ddkilzer@apple.com>
123
124         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
125         <rdar://problem/9446430>
126
127         Reviewed by Mark Rowe.
128
129         * Configurations/Base.xcconfig: Fixed typo.
130
131 2011-05-13  Jon Lee  <jonlee@apple.com>
132
133         Reviewed by Simon Fraser.
134
135         Can't horizontally scroll iframes and overflow because wheel events are always accepted
136         https://bugs.webkit.org/show_bug.cgi?id=60779
137
138         * WebCoreSupport/WebChromeClient.h:
139         (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
140         (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
141
142 2011-05-13  Sam Weinig  <sam@webkit.org>
143
144         Reviewed by Anders Carlsson.
145
146         Prune #includes from FrameView.h (Part 2)
147         https://bugs.webkit.org/show_bug.cgi?id=60748
148
149         - Update files that were depending on FrameView.h #including Frame.h or
150           Page.h.
151
152         * WebView/WebClipView.mm:
153         * WebView/WebHTMLView.mm:
154         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
155
156 2011-05-12  Pratik Solanki  <psolanki@apple.com>
157
158         Reviewed by Antti Koivisto.
159
160         Part of WebCore should use CFNetwork-based loader on Mac
161         https://bugs.webkit.org/show_bug.cgi?id=51836
162
163         Use CFRunLoop when using CFNetwork.
164
165         * WebView/WebView.mm:
166         (-[WebView scheduleInRunLoop:forMode:]):
167         (-[WebView unscheduleFromRunLoop:forMode:]):
168
169 2011-05-12  Pratik Solanki  <psolanki@apple.com>
170
171         Reviewed by Antti Koivisto.
172
173         Part of WebCore should use CFNetwork-based loader on Mac
174         https://bugs.webkit.org/show_bug.cgi?id=51836
175
176         Include AuthenticationCF.h header file.
177
178         * Misc/WebDownload.mm:
179         * Plugins/WebBaseNetscapePluginView.mm:
180         * WebCoreSupport/WebFrameLoaderClient.mm:
181
182 2011-05-12  Adele Peterson  <adele@apple.com>
183
184         Reviewed by Darin Adler and Adam Barth.
185
186         Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
187         https://bugs.webkit.org/show_bug.cgi?id=60685
188
189         Solar Walk uses a self closing title tag, so to match the behavior of the old parser, 
190         we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
191
192         * Misc/SolarWalkQuirksUserScript.js: Added.
193         * WebView/WebView.mm:
194         (needsSolarWalkQuirksScript):
195         (leakSolarWalkQuirksUserScriptContents):
196         (-[WebView _injectSolarWalkQuirksScript]):
197         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
198
199 2011-05-12  Jia Pu  <jpu@apple.com>
200
201         Reviewed by Darin Adler.
202
203         Regression caused by changeset 86281
204         https://bugs.webkit.org/show_bug.cgi?id=60712
205         <rdar://problem/9427970>
206
207         Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
208         So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
209         returns. So we don't need to use the condition to coordinate between these two function. In fact,
210         all callbacks are delivered on main thread. We don't really need any locking here.
211
212         Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
213         been removed.
214
215         * WebCoreSupport/CorrectionPanel.h:
216         * WebCoreSupport/CorrectionPanel.mm:
217         (CorrectionPanel::CorrectionPanel):
218         (CorrectionPanel::show):
219         (CorrectionPanel::dismiss):
220         (CorrectionPanel::dismissInternal):
221         (CorrectionPanel::handleAcceptedReplacement):
222         * WebCoreSupport/WebEditorClient.mm:
223         (WebEditorClient::dismissCorrectionPanelSoon):
224
225 2011-05-12  Patrick Gansterer  <paroga@webkit.org>
226
227         Reviewed by Adam Barth.
228
229         Enable OwnPtr strict mode in PluginHalter
230         https://bugs.webkit.org/show_bug.cgi?id=60681
231
232         * WebView/WebView.mm:
233         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
234
235 2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
236
237         Reviewed by Darin Adler.
238
239         String operator+ reallocates unnecessarily when concatting > 2 strings
240         https://bugs.webkit.org/show_bug.cgi?id=58420
241
242         Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
243
244         * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
245         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
246
247 2011-05-10  Tony Gentilcore  <tonyg@chromium.org>
248
249         Reviewed by Darin Adler.
250
251         Perform some forward declarations suggested by include-what-you-use
252         https://bugs.webkit.org/show_bug.cgi?id=60545
253
254         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
255         * WebView/WebFrame.mm:
256
257 2011-05-11  Jia Pu  <jpu@apple.com>
258
259         Reviewed by Darin Adler.
260
261         CorrectionPanel sometimes hangs in dismissSoon().
262         https://bugs.webkit.org/show_bug.cgi?id=60599
263         <rdar://problem/9313628>
264
265         Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
266         to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
267         for condition checking.
268
269         * WebCoreSupport/CorrectionPanel.h:
270         * WebCoreSupport/CorrectionPanel.mm:
271         (CorrectionPanel::CorrectionPanel):
272         (CorrectionPanel::show):
273         (CorrectionPanel::dismissSoon):
274         (CorrectionPanel::dismissInternal):
275         (CorrectionPanel::handleAcceptedReplacement):
276
277 2011-05-10  Anton D'Auria  <adauria@apple.com>
278
279         Reviewed by David Levin.
280
281         Add ApplicationCache API to get disk usage per origin
282         https://bugs.webkit.org/show_bug.cgi?id=57127
283
284         Added Mac port API.
285
286         * WebCoreSupport/WebApplicationCache.h:
287         * WebCoreSupport/WebApplicationCache.mm:
288         (+[WebApplicationCache diskUsageForOrigin:]):
289
290 2011-05-10  Anton D'Auria  <adauria@apple.com>
291
292         Reviewed by Alexey Proskuryakov.
293
294         Add ApplicationCache API to get disk usage per origin
295         https://bugs.webkit.org/show_bug.cgi?id=57127
296
297         Added Mac port API.
298
299         * WebCoreSupport/WebApplicationCache.h:
300         * WebCoreSupport/WebApplicationCache.mm:
301         (+[WebApplicationCache diskUsageForOrigin:]):
302
303 2011-05-10  Beth Dakin  <bdakin@apple.com>
304
305         Reviewed by Darin Adler.
306
307         https://bugs.webkit.org/show_bug.cgi?id=60582
308         Crash switching overlay/non-overlay scrollbar preference still possible
309         -and corresponding-
310         <rdar://problem/9323983>
311
312         * WebCoreSupport/WebSystemInterface.mm:
313         (InitWebCoreSystemInterface):
314
315 2011-05-09  Jeremy Noble  <jer.noble@apple.com>
316
317         Reviewed by Darin Adler.
318
319         Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
320         https://bugs.webkit.org/show_bug.cgi?id=60496
321
322         When animating into and out of full screen, order out and back in the original webView window,
323         disabling animations when necessary.  The exitFullscreen method was targeting the wrong window,
324         as the webView is hosted in the full screen window when we ask for it's parent window.
325
326         * WebView/WebFullScreenController.mm:
327         (-[WebFullScreenController windowDidEnterFullscreen:]):
328         (-[WebFullScreenController exitFullscreen]):
329
330 2011-05-04  Philippe Normand  <pnormand@igalia.com>
331
332         Reviewed by Dimitri Glazkov.
333
334         Implement LayoutTestController::pseudoShadowId()
335         https://bugs.webkit.org/show_bug.cgi?id=60034
336
337         * DOM/WebDOMOperations.mm:
338         (-[DOMElement _shadowPseudoId]):
339         * DOM/WebDOMOperationsPrivate.h:
340
341 2011-05-05  Dan Bernstein  <mitz@apple.com>
342
343         Reviewed by Simon Fraser.
344
345         WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
346
347         * WebCoreSupport/WebSystemInterface.mm:
348         (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
349
350 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
351
352         Reviewed by Eric Seidel.
353
354         Rename SelectionController to FrameSelection
355         https://bugs.webkit.org/show_bug.cgi?id=60234
356
357         * WebView/WebFrame.mm:
358         (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
359         * WebView/WebFrameInternal.h:
360         * WebView/WebHTMLView.mm:
361         * WebView/WebTextCompletionController.mm:
362         (-[WebTextCompletionController doCompletion]):
363         * WebView/WebView.mm:
364
365 2011-05-04  Cris Neckar  <cdn@chromium.org>
366
367         Reviewed by Adam Barth.
368
369         Expose WebView directly through ChromeClient.
370         https://bugs.webkit.org/show_bug.cgi?id=49902
371
372         * WebCoreSupport/WebChromeClient.h:
373         (WebChromeClient::webView):
374         * WebView/WebFrame.mm:
375         (kit):
376
377 2011-05-04  Tao Bai  <michaelbai@chromium.org>
378
379         Reviewed by David Kilzer.
380
381         Populate touch-icon url to FrameLoaderClient
382         https://bugs.webkit.org/show_bug.cgi?id=59143
383
384         Respect the interface change in FrameLoaderClient.
385
386         * Configurations/FeatureDefines.xcconfig:
387         * WebCoreSupport/WebFrameLoaderClient.h:
388         * WebCoreSupport/WebFrameLoaderClient.mm:
389         (WebFrameLoaderClient::dispatchDidChangeIcons):
390
391 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
392
393         Reviewed by Dimitri Glazkov.
394
395         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
396         https://bugs.webkit.org/show_bug.cgi?id=58703
397
398         * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
399
400 2011-05-02  Adam Roben  <aroben@apple.com>
401
402         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
403
404         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
405         doesn't work, but should
406
407         Reviewed by Adam Barth.
408
409         * History/WebHistory.mm:
410         * Plugins/WebNetscapePluginEventHandler.mm:
411         * WebView/WebView.mm:
412
413 2011-05-02  Brady Eidson  <beidson@apple.com>
414
415         Reviewed by Anders Carlsson.
416
417         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
418         In Aperture, a WebView might be dealloc'ed before it finishes loading.
419
420         * WebView/WebView.mm:
421         (needsSelfRetainWhileLoadingQuirk):
422         (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
423         (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
424         (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
425         (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
426
427 2011-05-02  Adam Barth  <abarth@webkit.org>
428
429         Reviewed by David Levin.
430
431         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
432         https://bugs.webkit.org/show_bug.cgi?id=59924
433
434         * History/WebHistory.mm:
435         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
436         * Plugins/WebBaseNetscapePluginView.mm:
437         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
438         * WebCoreSupport/WebFrameLoaderClient.mm:
439         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
440         * WebView/WebView.mm:
441         (-[WebView _injectMailQuirksScript]):
442         (-[WebView _injectOutlookQuirksScript]):
443         (toStringVector):
444
445 2011-05-02  Sam Weinig  <sam@webkit.org>
446
447         Reviewed by Adam Barth.
448
449         Prune some #includes from DOMWindow.h
450         https://bugs.webkit.org/show_bug.cgi?id=59907
451
452         * Plugins/WebBaseNetscapePluginView.mm:
453         * WebView/WebFrame.mm:
454         Add now missing SecurityOrigin.h #includes.
455
456 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
457
458         Reviewed by Eric Seidel.
459
460         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
461         https://bugs.webkit.org/show_bug.cgi?id=59837
462
463         Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
464
465         * WebView/WebHTMLView.mm:
466         (-[WebHTMLView menuForEvent:]):
467         (-[WebHTMLView acceptsFirstMouse:]):
468         (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
469
470 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
471
472         Reviewed by Eric Seidel.
473
474         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
475         https://bugs.webkit.org/show_bug.cgi?id=59835
476
477         Moved currentKeyboardEvent.
478
479         * WebView/WebHTMLView.mm:
480         (currentKeyboardEvent):
481         (-[WebHTMLView becomeFirstResponder]):
482
483 2011-04-29  Dean Jackson  <dino@apple.com>
484
485         Reviewed by Simon Fraser.
486
487         Add ENABLE macro for WebKitAnimation
488         https://bugs.webkit.org/show_bug.cgi?id=59729
489
490         Add new feature to toggle WebKit Animation API.
491
492         * Configurations/FeatureDefines.xcconfig:
493
494 2011-04-28  David Kilzer  <ddkilzer@apple.com>
495
496         <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
497
498         Reviewed by Anders Carlsson.
499
500         * History/WebHistory.mm:
501         (-[WebHistoryPrivate init]):
502         * Misc/WebElementDictionary.mm:
503         (-[WebElementDictionary initWithHitTestResult:]):
504         * Misc/WebIconDatabase.mm:
505         (-[WebIconDatabase init]):
506         * Plugins/WebPluginController.mm:
507         (-[WebPluginController initWithDocumentView:]):
508         * Plugins/WebPluginRequest.m:
509         (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
510         * WebCoreSupport/WebEditorClient.mm:
511         (-[WebEditCommand initWithEditCommand:]):
512         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
513         (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
514         * WebView/WebNavigationData.mm:
515         (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
516
517 2011-04-28  David Levin  <levin@chromium.org>
518
519         Reviewed by Adam Barth.
520
521         Remove IMAGE_RESIZER related code.
522         https://bugs.webkit.org/show_bug.cgi?id=59735
523
524         * Configurations/FeatureDefines.xcconfig:
525
526 2011-04-28  Adam Barth  <abarth@webkit.org>
527
528         Reviewed by Eric Seidel.
529
530         Remove WML
531         https://bugs.webkit.org/show_bug.cgi?id=59678
532
533         Remove WML-related configuration options and private APIs.
534
535         * Configurations/FeatureDefines.xcconfig:
536         * WebCoreSupport/WebChromeClient.mm:
537         (stringForMessageSource):
538         * WebView/WebFramePrivate.h:
539         * WebView/WebUIDelegatePrivate.h:
540
541 2011-04-28  Brian Weinstein  <bweinstein@apple.com>
542
543         Reviewed by Timothy Hatcher.
544
545         Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
546         https://bugs.webkit.org/show_bug.cgi?id=59747
547
548         Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
549         Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
550
551         * WebCoreSupport/WebInspectorClient.mm:
552         (-[WebInspectorWindowController showWebInspector:]):
553         (-[WebInspectorWindowController showErrorConsole:]):
554         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
555         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
556         (-[WebInspectorWindowController validateUserInterfaceItem:]):
557
558 2011-04-28  David Kilzer  <ddkilzer@apple.com>
559
560         <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
561
562         Reviewed by Dan Bernstein.
563
564         * WebView/WebFullScreenController.mm:
565         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
566         Use a RetainPtr to hold the CALayer and to fix the leak.
567
568 2011-04-28  David Kilzer  <ddkilzer@apple.com>
569
570         Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
571
572         Addresses review comment from Darin Adler.
573
574         * WebView/WebPDFView.mm:
575         (-[WebPDFView menuForEvent:]): Use a local variable and -release
576         instead of -autorelease.
577
578 2011-04-28  Anders Carlsson  <andersca@apple.com>
579
580         Fix a thinko - separateRealmLabel is not an NSImageView.
581
582         * Panels/WebAuthenticationPanel.h:
583
584 2011-04-28  David Kilzer  <ddkilzer@apple.com>
585
586         <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
587
588         Reviewed by Dan Bernstein.
589
590         * WebView/WebPDFView.mm:
591         (-[WebPDFView menuForEvent:]): Call -autorelease after copying
592         each NSMenuItem.  Regressed in r9566 for Bug 3711.
593
594 2011-04-28  Enrica Casucci  <enrica@apple.com>
595
596         Reviewed by Beth Dakin.
597
598         Momentum scroll tweak for WebKit.
599         https://bugs.webkit.org/show_bug.cgi?id=59723
600         <rdar://problem/9259933>
601
602         * WebView/WebDynamicScrollBarsView.mm:
603         (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
604
605 2011-04-27  Anders Carlsson  <andersca@apple.com>
606
607         Follow-up Leopard build fix.
608
609         * Carbon/HIViewAdapter.m:
610         (_webkit_NSView_setNeedsDisplayInRect):
611
612 2011-04-27  Anders Carlsson  <andersca@apple.com>
613
614         More clang++ 32-bit build fixes.
615
616         * Carbon/CarbonWindowAdapter.mm:
617         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
618         (-[CarbonWindowAdapter setContentView:]):
619         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
620         * Carbon/HIViewAdapter.m:
621         (_webkit_NSView_setNeedsDisplayInRect):
622         * Panels/WebAuthenticationPanel.h:
623         * Plugins/WebBaseNetscapePluginView.mm:
624         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
625         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
626         (getCarbonEvent):
627         * WebCoreSupport/WebChromeClient.mm:
628         (WebChromeClient::scrollRectIntoView):
629         * WebCoreSupport/WebViewFactory.mm:
630         (-[WebViewFactory accessibilityConvertScreenRect:]):
631         * WebView/WebFrameView.mm:
632         (-[WebFrameView _scrollToBeginningOfDocument]):
633         (-[WebFrameView _scrollToEndOfDocument]):
634         * WebView/WebFullScreenController.mm:
635         (-[WebFullScreenController windowDidEnterFullscreen:]):
636         * WebView/WebHTMLView.mm:
637         (-[WebHTMLView _hitViewForEvent:]):
638         (coreGraphicsScreenPointForAppKitScreenPoint):
639         * WebView/WebPDFView.mm:
640         (-[WebPDFView setScrollPoint:]):
641
642 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
643
644         Reviewed by Pavel Feldman.
645
646         REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
647         https://bugs.webkit.org/show_bug.cgi?id=44230
648
649         Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
650         inspector is closed.
651
652         * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
653         comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
654         pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
655         There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
656         front-end page.
657
658         Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
659         (-[WebInspectorWindowController initWithInspectedWebView:]):
660         (-[WebInspectorWindowController close]):
661         (-[WebInspectorWindowController showWindow:]):
662         (-[WebInspectorWindowController setAttachedWindowHeight:]):
663         (-[WebInspectorWindowController destroyInspectorView:]):
664
665 2011-04-26  Sam Weinig  <sam@webkit.org>
666
667         Reviewed by David Hyatt.
668
669         Remove Datagrid from the tree
670         https://bugs.webkit.org/show_bug.cgi?id=59543
671
672         * Configurations/FeatureDefines.xcconfig:
673         Remove feature.
674
675 2011-04-26  Dan Bernstein  <mitz@apple.com>
676
677         Reviewed by Mark Rowe.
678
679         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
680
681         * Configurations/Base.xcconfig:
682         * Configurations/CompilerVersion.xcconfig: Added.
683
684 2011-04-25  Adam Barth  <abarth@webkit.org>
685
686         Reviewed by David Levin.
687
688         WebKit2 should play nice with strict OwnPtrs
689         https://bugs.webkit.org/show_bug.cgi?id=59426
690
691         Fix include ordering.
692
693         * WebView/WebDeviceOrientationProviderMock.mm:
694
695 2011-04-25  Adam Barth  <abarth@webkit.org>
696
697         Reviewed by David Levin.
698
699         WebKit1 should build cleanly with strict OwnPtrs
700         https://bugs.webkit.org/show_bug.cgi?id=59424
701
702         * History/WebHistoryItem.mm:
703         (-[WebHistoryItem initFromDictionaryRepresentation:]):
704         * Plugins/WebNetscapePluginEventHandler.h:
705         * Plugins/WebNetscapePluginEventHandler.mm:
706         (WebNetscapePluginEventHandler::create):
707         * Plugins/WebNetscapePluginView.mm:
708         (-[WebNetscapePluginView createPlugin]):
709         * WebView/WebDeviceOrientationProviderMock.mm:
710         * WebView/WebTextIterator.mm:
711         (-[WebTextIterator initWithRange:]):
712
713 2011-04-25  Jon Lee  <jonlee@apple.com>
714
715         Reviewed by Maciej Stachowiak.
716
717         Overlay scroller hard to see on pages with dark background (59183)
718         https://bugs.webkit.org/show_bug.cgi?id=59183
719         <rdar://problem/8975367>
720         
721         * WebCoreSupport/WebSystemInterface.mm:
722         (InitWebCoreSystemInterface): adding method to allow changing style
723
724 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
725
726         Unreviewed, rolling out r84740.
727         http://trac.webkit.org/changeset/84740
728         https://bugs.webkit.org/show_bug.cgi?id=59290
729
730         change breaks apple internal builds and is incorrect
731         (Requested by smfr on #webkit).
732
733         * WebCoreSupport/WebSystemInterface.mm:
734         (InitWebCoreSystemInterface):
735
736 2011-04-22  Jon Lee  <jonlee@apple.com>
737
738         Reviewed by Beth Dakin.
739
740         Overlay scroller hard to see on pages with dark background (59183)
741         https://bugs.webkit.org/show_bug.cgi?id=59183
742         <rdar://problem/8975367>
743         
744         * WebCoreSupport/WebSystemInterface.mm:
745         (InitWebCoreSystemInterface): adding method to allow changing style
746
747 2011-04-19  Jer Noble  <jer.noble@apple.com>
748
749         Reviewed by Daniel Bates.
750
751         Full Screen from within an <iframe> does not cause <iframe> to resize.
752         https://bugs.webkit.org/show_bug.cgi?id=58638
753
754         Tests: fullscreen/full-screen-frameset-allowed.html
755                fullscreen/full-screen-frameset-not-allowed.html
756
757         Return the _element's document instead of the WKView's document, which 
758         will be different in the case of elements within <iframe>s.
759
760         * WebView/WebFullScreenController.mm:
761         (-[WebFullScreenController _document]):
762
763 2011-04-22  Jer Noble  <jer.noble@apple.com>
764
765         Reviewed by Maciej Stachowiak.
766
767         Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
768         https://bugs.webkit.org/show_bug.cgi?id=59147
769
770         Add a new user default preference, and plumb that preference down to WebCore
771         Settings. Allow the fullScreenEnabled preference to override the new 
772         isAVFoundationEnabled preference, so that clients of the legacy full screen
773         mode will continue to use that mode normally.
774
775         * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
776         * WebView/WebPreferences.mm:
777         (+[WebPreferences initialize]): Set the default value of new
778             preference.
779         (-[WebPreferences setAVFoundationEnabled:]): Added.
780         (-[WebPreferences isAVFoundationEnabled]): Added.
781         * WebView/WebPreferencesPrivate.h:
782         * WebView/WebView.mm:
783         (-[WebView _preferencesChanged:]): Update the WebCore settings with the
784             new values from WebPreferences.
785
786 2011-04-22  Sam Weinig  <sam@webkit.org>
787
788         Reviewed by Gavin Barraclough.
789
790         Remove remaining uses of deprecated version of toJS
791         https://bugs.webkit.org/show_bug.cgi?id=59170
792
793         * DOM/WebDOMOperations.mm:
794         (-[DOMElement _shadowRoot:]):
795         (-[DOMElement _ensureShadowRoot:]):
796         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
797
798 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
799
800         Reviewed by Adam Roben.
801
802         Add a feature define to allow <details> and <summary> to be disabled
803         https://bugs.webkit.org/show_bug.cgi?id=59118
804         <rdar://problem/9257045>
805
806         * Configurations/FeatureDefines.xcconfig:
807
808 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
809
810         Reviewed by Sam Weinig.
811
812         Add Frame* to the argument lists of canCopyCut and canPaste
813         https://bugs.webkit.org/show_bug.cgi?id=59153
814
815         * WebCoreSupport/WebEditorClient.h:
816         * WebCoreSupport/WebEditorClient.mm:
817         (WebEditorClient::canCopyCut):
818         (WebEditorClient::canPaste):
819
820 2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
821
822         Unreviewed, rolling out r82052.
823         http://trac.webkit.org/changeset/82052
824         https://bugs.webkit.org/show_bug.cgi?id=59135
825
826         New full screen api should be opt-in, not opt-out. (Requested
827         by jernoble on #webkit).
828
829         * WebView/WebPreferences.mm:
830         (+[WebPreferences initialize]):
831
832 2011-04-21  Beth Dakin  <bdakin@apple.com>
833
834         Reviewed by Dan Bernstein.
835
836         https://bugs.webkit.org/show_bug.cgi?id=59048
837         Need to track whether overlay scrollbar is currently visible and in lower-
838         righthand corner
839         -and corresponding-
840         <rdar://problem/9211232>
841
842         A new WebSystemInterface is needed for this.
843         * WebCoreSupport/WebSystemInterface.mm:
844         (InitWebCoreSystemInterface):
845
846 2011-04-21  Dirk Schulze  <krit@webkit.org>
847
848         Reviewed by Nikolas Zimmermann.
849
850         SVG feDropShadow implementation of SVG Filters 1.2
851         https://bugs.webkit.org/show_bug.cgi?id=52513
852
853         * MigrateHeaders.make:
854
855 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
856
857         Reviewed by Dimitri Glazkov.
858
859         layoutTestController can create and destroy shadow DOM
860         https://bugs.webkit.org/show_bug.cgi?id=59058
861
862         Support for new methods in Mac DRT.
863
864         * DOM/WebDOMOperations.mm:
865         (-[DOMElement _ensureShadowRoot:]):
866         (-[DOMElement _removeShadowRoot]):
867         * DOM/WebDOMOperationsPrivate.h:
868
869 2011-04-20  Eric Carlson  <eric.carlson@apple.com>
870
871         Reviewed by Dan Bernstein.
872
873         Adopt QTKit API for listing and deleting file in its media cache.
874         <rdar://problem/9130029> 
875
876         * WebCoreSupport/WebSystemInterface.mm:
877         (InitWebCoreSystemInterface): Initialize new functions.
878
879 2011-04-19  Matthew Delaney  <mdelaney@apple.com>
880
881         Reviewed by Simon Fraser.
882
883         WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
884         https://bugs.webkit.org/show_bug.cgi?id=58936
885
886         * WebView/WebPreferences.mm:
887         (+[WebPreferences initialize]):
888
889 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
890
891         Reviewed by Pavel Feldman.
892
893         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
894         https://bugs.webkit.org/show_bug.cgi?id=58883
895
896         * WebCoreSupport/WebFrameLoaderClient.h:
897         * WebCoreSupport/WebFrameLoaderClient.mm:
898         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
899
900 2011-04-18  Jia Pu  <jpu@apple.com>
901
902         Reviewed by Mark Rowe.
903
904         WebKit needs to stop importing <AppKit/NSTextChecker.h>
905         https://bugs.webkit.org/show_bug.cgi?id=58798
906         <rdar://problem/9294938>
907
908         Use public header <AppKit/NSSpellChecker.h> instead.
909
910         * WebCoreSupport/CorrectionPanel.h:
911         * WebCoreSupport/CorrectionPanel.mm:
912         (correctionIndicatorType):
913         (CorrectionPanel::show):
914         (CorrectionPanel::dismissInternal):
915         (CorrectionPanel::handleAcceptedReplacement):
916         * WebCoreSupport/WebEditorClient.mm:
917         * WebView/WebView.mm:
918
919 2011-04-17  Cameron Zwarich  <zwarich@apple.com>
920
921         Reviewed by Timothy Hatcher.
922
923         Stop using -[NSString initWithContentsOfFile:]
924         https://bugs.webkit.org/show_bug.cgi?id=58763
925
926         -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
927
928         * WebView/WebView.mm:
929         (leakMailQuirksUserScriptContents):
930         (leakOutlookQuirksUserScriptContents):
931
932 2011-04-17  David Kilzer  <ddkilzer@apple.com>
933
934         <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
935         <rdar://problem/9268729>
936
937         Reviewed by Dan Bernstein.
938
939         This replaces support for the WebKitEnableHTTPPipelining user
940         default with methods on the WebCore::ResourceRequest class in
941         WebCore, the WebView class in WebKit1, and the WebContext class
942         in WebKit2.  It also removes support for the
943         WebKitForceHTTPPipeliningPriorityHigh user default which was not
944         needed.
945
946         * WebView/WebView.mm:
947         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
948         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
949         * WebView/WebViewPrivate.h:
950         (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
951         (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
952
953 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
954
955         Reviewed by Dan Bernstein.
956
957         Assign to self in WebInspectorWindowController constructors
958         https://bugs.webkit.org/show_bug.cgi?id=58749
959
960         * WebCoreSupport/WebInspectorClient.mm:
961         (-[WebInspectorWindowController init]):
962         (-[WebInspectorWindowController initWithInspectedWebView:]):
963
964 2011-04-17  Joseph Pecoraro  <joepeck@webkit.org>
965
966         Reviewed by Timothy Hatcher.
967
968         Move WebNodeHighlighter into its own file
969         https://bugs.webkit.org/show_bug.cgi?id=58746
970
971         Extract this class into its own file alongside the
972         other WebNodeHighlight files. In doing so do some
973         cleanup on WebInspectorClient removing some methods
974         that were never called.
975
976         * WebCoreSupport/WebInspectorClient.mm:
977         (WebInspectorClient::WebInspectorClient): style fix.
978         * WebInspector/WebNodeHighlighter.h: Added.
979         * WebInspector/WebNodeHighlighter.mm: Added.
980         (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
981         (-[WebNodeHighlighter dealloc]):
982         (-[WebNodeHighlighter highlightNode:]):
983         (-[WebNodeHighlighter hideHighlight]):
984         (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
985         (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
986
987 2011-04-15  Jia Pu  <jpu@apple.com>
988
989         Reviewed by Dan Bernstein.
990
991         [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
992         https://bugs.webkit.org/show_bug.cgi?id=58717
993
994         Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
995
996         * WebCoreSupport/CorrectionPanel.mm:
997         (CorrectionPanel::show):
998
999 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1000
1001         Reviewed by James Robinson.
1002
1003         Add a flag to guard Page Visibility API changes.
1004         https://bugs.webkit.org/show_bug.cgi?id=58464
1005
1006         * Configurations/FeatureDefines.xcconfig:
1007
1008 2011-04-15  Oliver Hunt  <oliver@apple.com>
1009
1010         GC allocate Structure
1011         https://bugs.webkit.org/show_bug.cgi?id=58483
1012
1013         Rolling r83894 r83827 r83810 r83809 r83808 back in with
1014         a workaround for the gcc bug seen by the gtk bots
1015
1016         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1017         * Plugins/Hosted/ProxyInstance.mm:
1018         (WebKit::ProxyRuntimeMethod::createStructure):
1019         * Plugins/Hosted/ProxyRuntimeObject.h:
1020         (WebKit::ProxyRuntimeObject::createStructure):
1021
1022 2011-04-14  Alexey Proskuryakov  <ap@apple.com>
1023
1024         Reviewed by Dan Bernstein.
1025
1026         WebKit2: Password field input does not switch to ASCII-compatible source
1027         https://bugs.webkit.org/show_bug.cgi?id=58583
1028         <rdar://problem/9059651>
1029
1030         Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
1031         necessary logic, needed to return a nil text input context when in password fields.
1032
1033         * WebView/WebHTMLView.mm:
1034         (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
1035         (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
1036         (-[WebHTMLView windowDidResignKey:]): Ditto.
1037         (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
1038         because the first responder is still different an this point, so set a boolean variable to
1039         let _updateSecureInputState know what's going on.
1040         (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
1041         (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
1042         allowed input sources accorsing to current selection.
1043         (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
1044
1045 2011-04-15  Sam Weinig  <sam@webkit.org>
1046
1047         Reviewed by Maciej Stachowiak.
1048
1049         Make mac WebKit1 use the default localization strategy
1050         https://bugs.webkit.org/show_bug.cgi?id=58628
1051
1052         * WebCoreSupport/WebPlatformStrategies.h:
1053         * WebCoreSupport/WebPlatformStrategies.mm:
1054         Remove the localization strategy code. The equivalent is now
1055         in WebCore/platform/DefaultLocalizationStrategy.cpp.
1056
1057 2011-04-15  Anna Cavender  <annacc@chromium.org>
1058
1059         Reviewed by Eric Carlson.
1060
1061         Renaming TRACK feature define to VIDEO_TRACK
1062         https://bugs.webkit.org/show_bug.cgi?id=53556
1063
1064         * Configurations/FeatureDefines.xcconfig:
1065
1066 2011-04-14  Pratik Solanki  <psolanki@apple.com>
1067
1068         Reviewed by David Kilzer.
1069
1070         Set minimum priority for fast lane connections
1071         https://bugs.webkit.org/show_bug.cgi?id=58353
1072
1073         * WebCoreSupport/WebSystemInterface.mm:
1074         (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
1075
1076 2011-04-13  Sam Weinig  <sam@webkit.org>
1077
1078         Reviewed by Gavin Barraclough.
1079
1080         WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
1081         <rdar://problem/9260518>
1082
1083         * WebCoreSupport/WebSystemInterface.mm:
1084         (InitWebCoreSystemInterface):
1085         Initialize new WKSI functions.
1086
1087 2011-04-13  David Kilzer  <ddkilzer@apple.com>
1088
1089         <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
1090
1091         Reviewed by Anders Carlsson.
1092
1093         Fixes the following warning with -Wcast-align enabled:
1094
1095             Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
1096                          archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
1097                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1098
1099         * Plugins/WebBasePluginPackage.mm:
1100         (-[WebBasePluginPackage isNativeLibraryData:]): Added
1101         COMPILE_ASSERT() to make sure our pointer math is valid.
1102         Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
1103         by sizeof(uint32_t) to fix the pointer math.  Replaced C-style
1104         casts with reinterpret_cast.
1105
1106 2011-04-12  Enrica Casucci  <enrica@apple.com>
1107
1108         Reviewed by Alexey Proskuryakov.
1109
1110         Infinite recursion in WebHTMLView executeSavedKeypressCommands.
1111         https://bugs.webkit.org/show_bug.cgi?id=58382
1112         <rdar://problem/9239370>
1113
1114         Execution of some editing commands could trigger a call to selectedRange that
1115         internally calls executeSavedKeypressCommands creating an infinite recursion.
1116
1117         * WebView/WebHTMLView.mm:
1118         (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
1119         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
1120
1121 2011-04-12  Alice Liu  <alice.liu@apple.com>
1122
1123         Reviewed by Sam Weinig.
1124
1125         https://bugs.webkit.org/show_bug.cgi?id=58292
1126         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1127
1128         * WebView/WebPreferenceKeysPrivate.h: Add preference key.
1129         * WebView/WebPreferences.mm:
1130         (+[WebPreferences initialize]): Initialize to false.
1131         (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
1132         (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
1133         * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
1134         * WebView/WebView.mm:
1135         (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
1136
1137 2011-04-11  Alexey Proskuryakov  <ap@apple.com>
1138
1139         Reviewed by Maciej Stachowiak.
1140
1141         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1142         https://bugs.webkit.org/show_bug.cgi?id=58175
1143         <rdar://problem/9060555>
1144
1145         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1146         should be changed to match WebKit2.
1147
1148 2011-04-06  Timothy Hatcher  <timothy@apple.com>
1149
1150         Fix a bug where the context menu does not show in PDF documents if there is no
1151         UI delegate or the UI delegate does not respond to the context menu selector.
1152
1153         https://webkit.org/b/57958
1154
1155         Reviewed by Darin Adler.
1156
1157         * WebView/WebView.mm:
1158         (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
1159         if UIDelegate is nil or doesn't respond to the selector. So check that
1160         here to distinguish between using defaultMenuItems or the delegate
1161         really returning nil to say "no context menu".
1162
1163 2011-04-11  Jer Noble  <jer.noble@apple.com>
1164
1165         Unreviewed; roll out unintentional change to WebFullScreenController.mm.
1166
1167         * WebView/WebFullScreenController.mm:
1168         (-[WebFullScreenController enterFullscreen:]):
1169
1170 2011-04-08  Geoffrey Garen  <ggaren@apple.com>
1171
1172         Reviewed by Oliver Hunt.
1173
1174         A few heap-related renames and file moves.
1175         
1176         WeakGCPtr<T> => Weak<T>
1177         Global<T> => Strong<T>
1178         collector/ => heap/
1179         collector/* => heap/*
1180         runtime/WeakGCPtr.h => heap/Weak.h
1181         
1182         (Eventually, even more files should move into the heap directory. Like
1183         Heap.h and Heap.cpp, for example.)
1184
1185         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1186         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1187         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
1188         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
1189         (WebKit::NetscapePluginInstanceProxy::evaluate):
1190         * WebView/WebScriptDebugger.h:
1191
1192 2011-04-08  Alexey Proskuryakov  <ap@apple.com>
1193
1194         Reviewed by Darin Adler.
1195
1196         WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
1197         https://bugs.webkit.org/show_bug.cgi?id=58175
1198         <rdar://problem/9060555>
1199
1200         * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
1201         should be changed to match WebKit2.
1202
1203 2011-04-08  Alpha Lam  <hclam@chromium.org>
1204
1205         Unreviewed, rolling out r83335.
1206         http://trac.webkit.org/changeset/83335
1207         https://bugs.webkit.org/show_bug.cgi?id=53556
1208
1209         GTK and QT bots are broken
1210
1211         * Configurations/FeatureDefines.xcconfig:
1212
1213 2011-04-07  Anna Cavender  <annacc@chromium.org>
1214
1215         Reviewed by Eric Carlson.
1216
1217         Setup ENABLE(TRACK) feature define
1218         https://bugs.webkit.org/show_bug.cgi?id=53556
1219
1220         * Configurations/FeatureDefines.xcconfig:
1221
1222 2011-04-08  Maciej Stachowiak  <mjs@apple.com>
1223
1224         Reviewed by Darin Adler.
1225
1226         -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
1227         https://bugs.webkit.org/show_bug.cgi?id=58128
1228         <rdar://problem/9244553>
1229         
1230         The root of the problem here was an O(N^2) issue - each WebView,
1231         upon having its preferences initialized, would broadcast a
1232         notification that was listened to by all other WebViews sharing
1233         its preferences.
1234         
1235         To maintain the API contract, I split the notification into two,
1236         one that is for public API consumption, and the other which is for
1237         internal use only. Changes that don't need to be picked up by
1238         other WebViews broadcast the public notification only. And we
1239         avoid WebView broadcasting a notification just to get itself to
1240         update.
1241
1242         * Misc/WebIconDatabase.mm:
1243         (-[WebIconDatabase _startUpIconDatabase]):
1244         (-[WebIconDatabase _shutDownIconDatabase]):
1245         * Plugins/WebBaseNetscapePluginView.mm:
1246         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1247         (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
1248         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1249         (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
1250         * WebView/WebPreferences.mm:
1251         (-[WebPreferences initWithIdentifier:]):
1252         (-[WebPreferences _setStringValue:forKey:]):
1253         (-[WebPreferences _setIntegerValue:forKey:]):
1254         (-[WebPreferences _setFloatValue:forKey:]):
1255         (-[WebPreferences _setBoolValue:forKey:]):
1256         (-[WebPreferences _setLongLongValue:forKey:]):
1257         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1258         (-[WebPreferences _postPreferencesChangedNotification]):
1259         (-[WebPreferences _postPreferencesChangedAPINotification]):
1260         * WebView/WebPreferencesPrivate.h:
1261         * WebView/WebView.mm:
1262         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1263         (-[WebView _preferencesChangedNotification:]):
1264         (-[WebView _preferencesChanged:]):
1265         (-[WebView setUsesPageCache:]):
1266         (+[WebView initialize]):
1267         (-[WebView setPreferences:]):
1268         (-[WebView _keyboardUIMode]):
1269         * WebView/WebViewInternal.h:
1270
1271 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1272
1273         Revert ENABLE_TRACK patch due to compile failures.
1274
1275         * Configurations/FeatureDefines.xcconfig:
1276
1277 2011-04-07  Alexey Proskuryakov  <ap@apple.com>
1278
1279         Reviewed by Anders Carlsson.
1280
1281         REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
1282         https://bugs.webkit.org/show_bug.cgi?id=58066
1283         <rdar://problem/8965302>
1284
1285         * WebView/WebHTMLRepresentation.mm:
1286         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1287         * WebView/WebHTMLView.mm:
1288         (-[WebHTMLView attributedSubstringFromRange:]):
1289         (-[WebHTMLView attributedString]):
1290         (-[WebHTMLView selectedAttributedString]):
1291         Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
1292
1293 2011-04-07  Andy Estes  <aestes@apple.com>
1294
1295         Reviewed by Darin Adler.
1296
1297         REGRESSION (r64712): Microsoft Outlook 2011: original message contents
1298         not included when replying to an email.
1299         https://bugs.webkit.org/show_bug.cgi?id=57794
1300         
1301         Outlook populates a reply message by creating an empty WebView and
1302         using DOM API to populate the WebView's empty document with content
1303         from the original message. It expects the initial empty document to
1304         simply be "<html></html>", and it proceeds to dynamically create and
1305         append a BODY node and add the original message content as a child of
1306         that node. Outlook then takes the innerHTML of the frame's first body
1307         element and copies it into a *new* document that is displayed and
1308         edited in the reply message window.
1309         
1310         Due to implementing the HTML5 tree building algorithm in r64712,
1311         initial empty documents went from being "<html></html>" to being
1312         "<html><head></head><body></body></html>". Outlook still dynamically
1313         creates a BODY node to parent the original message content, but this
1314         BODY node duplicates the one created by the tree builder. When Outlook
1315         then takes the innerHTML of the first body element to populate the
1316         reply message window it gets the empty body element created by the
1317         parser, not the one it created with the original message content.
1318         
1319         Fix this by injecting a user script into the initial empty document
1320         that removes the HEAD and BODY nodes created by the parser. This
1321         ensures that the BODY created by Outlook is the only BODY in the
1322         document.
1323
1324         * Misc/OutlookQuirksUserScript.js: Added.
1325         * WebView/WebView.mm:
1326         (leakMailQuirksUserScriptContents):
1327         (-[WebView _injectMailQuirksScript]):
1328         (needsOutlookQuirksScript):
1329         (leakOutlookQuirksUserScriptContents):
1330         (-[WebView _injectOutlookQuirksScript]):
1331         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1332
1333 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1334
1335         Reviewed by David Levin.
1336
1337         Add QUOTA build flag for unified quota API
1338         https://bugs.webkit.org/show_bug.cgi?id=57918
1339
1340         * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
1341
1342 2011-04-06  Robert Sesek  <rsesek@chromium.org>
1343
1344         Reviewed by Alexey Proskuryakov.
1345
1346         Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
1347         https://bugs.webkit.org/show_bug.cgi?id=54969
1348
1349         * WebView/WebFrame.mm:
1350         (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
1351         (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
1352
1353 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
1354
1355         Reviewed by Darin Adler.
1356
1357         Move attributedStringFromRange down to WebCore
1358         https://bugs.webkit.org/show_bug.cgi?id=57905
1359
1360         * Misc/WebNSAttributedStringExtras.h: Removed.
1361         * Misc/WebNSAttributedStringExtras.mm: Removed.
1362         * WebView/WebHTMLRepresentation.mm:
1363         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1364         * WebView/WebHTMLView.mm:
1365         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1366         (-[WebHTMLView attributedSubstringFromRange:]):
1367         (-[WebHTMLView attributedString]):
1368         (-[WebHTMLView selectedAttributedString]):
1369         * WebView/WebPDFView.mm:
1370         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1371
1372 2011-04-04  MORITA Hajime  <morrita@google.com>
1373
1374         Reviewed by Ryosuke Niwa.
1375
1376         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1377         https://bugs.webkit.org/show_bug.cgi?id=56085
1378
1379         Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
1380         NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
1381         for requestCheckingOfString method.
1382         
1383         * WebCoreSupport/WebEditorClient.h:
1384         * WebCoreSupport/WebEditorClient.mm:
1385         (toCoreTextCheckingResults):
1386         (WebEditorClient::checkTextOfParagraph):
1387         (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
1388         (-[WebEditorSpellCheckResponder perform]):
1389         (WebEditorClient::requestCheckingOfString):
1390         * WebView/WebFrame.mm:
1391         (-[WebFrame markersForSelectionStartAsText]):
1392         * WebView/WebFramePrivate.h:
1393
1394 2011-04-05  Anders Carlsson  <andersca@apple.com>
1395
1396         Didn't mean to land this.
1397
1398         * Plugins/WebNetscapePluginView.mm:
1399         (-[WebNetscapePluginView getVariable:value:]):
1400
1401 2011-04-04  David Kilzer  <ddkilzer@apple.com>
1402
1403         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
1404
1405         Reviewed by Alexey Proskuryakov.
1406
1407         * WebCoreSupport/WebSystemInterface.mm:
1408         (InitWebCoreSystemInterface): Added initialization for
1409         wkSetHTTPPipeliningMaximumPriority().
1410
1411 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
1412
1413         Reviewed by Dan Bernstein.
1414
1415         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1416         https://bugs.webkit.org/show_bug.cgi?id=51230
1417         <rdar://problem/8780989>
1418
1419         * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
1420         WebKits to WebCore, because WebKit shouldn't be smart.
1421
1422 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1423
1424         Reviewed by Darin Adler.
1425
1426         REGRESSION: Assertion failure when executing a complex custom key binding
1427         https://bugs.webkit.org/show_bug.cgi?id=57681
1428
1429         * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
1430         commands when they can't possibly change the result.
1431
1432 2011-04-01  Anders Carlsson  <andersca@apple.com>
1433
1434         Reviewed by Sam Weinig.
1435
1436         Shockwave plug-in doesn't accept mouse events
1437         https://bugs.webkit.org/show_bug.cgi?id=57653
1438         <rdar://problem/8483273>
1439
1440         Fix an unrelated bug found by the added test.
1441
1442         * Plugins/WebBaseNetscapePluginView.mm:
1443         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1444         Make sure to always set destX and destY.
1445
1446 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1447
1448         Reviewed by Darin Adler.
1449
1450         Make WebKit2 text input handling more like WebKit1
1451         https://bugs.webkit.org/show_bug.cgi?id=57649
1452
1453         * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
1454         * WebView/WebHTMLView.mm:
1455         (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
1456         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
1457         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1458         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1459         (-[WebHTMLView selectedRange]): Ditto.
1460         (-[WebHTMLView markedRange]): Ditto.
1461         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1462         (-[WebHTMLView hasMarkedText]): Ditto.
1463         (-[WebHTMLView unmarkText]): Ditto.
1464         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
1465         type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
1466         be able to call text input protocol methods from here (and we didn't even reset it back on
1467         return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
1468         (-[WebHTMLView insertText:]): Ditto.
1469
1470 2011-04-01  Timothy Hatcher  <timothy@apple.com>
1471
1472         Make momentum scroll event latching work in WebKit2 on Mac.
1473
1474         <rdar://problem/8751861>
1475
1476         Reviewed by Darin Adler.
1477
1478         * WebCoreSupport/WebSystemInterface.mm:
1479         (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
1480         * WebView/WebDynamicScrollBarsView.mm:
1481         (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
1482
1483 2011-03-31  Darin Adler  <darin@apple.com>
1484
1485         Reviewed by Anders Carlsson.
1486
1487         Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
1488         https://bugs.webkit.org/show_bug.cgi?id=26667
1489
1490         * WebView/WebHTMLView.mm:
1491         (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
1492         nil rather than asserting that it is non-nil. One case where WebView will be nil
1493         is when the frame is closed, but in any case where it is nil, the correct thing
1494         to do is to not try to handle the style key.
1495
1496 2011-03-31  Alexey Proskuryakov  <ap@apple.com>
1497
1498         Patch by John Harvey, reviewed and tweaked by me.
1499
1500         <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
1501
1502         * Plugins/Hosted/WebTextInputWindowController.m:
1503         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1504
1505 2011-03-31  Evan Martin  <evan@chromium.org>
1506
1507         Reviewed by Eric Seidel.
1508
1509         <title> should support dir attribute
1510         https://bugs.webkit.org/show_bug.cgi?id=50961
1511
1512         Update to new FrameLoaderClient interface.
1513
1514         * WebCoreSupport/WebFrameLoaderClient.h:
1515         * WebCoreSupport/WebFrameLoaderClient.mm:
1516         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1517         (WebFrameLoaderClient::setTitle):
1518
1519 2011-03-30  Dominic Cooney  <dominicc@google.com>
1520
1521         Reviewed by Dimitri Glazkov.
1522
1523         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1524         https://bugs.webkit.org/show_bug.cgi?id=57415
1525
1526         * DOM/WebDOMOperations.mm:
1527         (-[DOMElement _shadowRoot:]):
1528         * DOM/WebDOMOperationsPrivate.h:
1529
1530 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
1531
1532         Reviewed by Darin Adler.
1533
1534         WebHTMLView shouldn't resend noop: commands
1535         https://bugs.webkit.org/show_bug.cgi?id=57504
1536         <rdar://problem/9209390>
1537
1538         * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
1539         which we get e.g. when handling Cmd-key combos.
1540
1541 2011-03-30  Alexey Proskuryakov  <ap@apple.com>
1542
1543         Reviewed by Darin Adler.
1544
1545         REGRESSION (r82320): Spacebar no longer pages down
1546         https://bugs.webkit.org/show_bug.cgi?id=57423
1547         <rdar://problem/9207702>
1548
1549         Also includes some unrelated cleanup that I had in my tree.
1550
1551         * WebView/WebHTMLView.mm:
1552         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
1553         being dispatched to the right frame.
1554         (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
1555         (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
1556         Even if this specific command hasn't been handled, that doesn't nullify side effects from
1557         previous commands.
1558         (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
1559         bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
1560         another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
1561         going to look at it.
1562
1563 2011-03-30  Sam Weinig  <sam@webkit.org>
1564
1565         Reviewed by Brady Eidson.
1566
1567         WebKit2: Attempting to view css file from url causes it to download
1568         <rdar://problem/9102611>
1569         https://bugs.webkit.org/show_bug.cgi?id=57501
1570
1571         * WebView/WebHTMLRepresentation.h:
1572         * WebView/WebHTMLRepresentation.mm:
1573         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1574         * WebView/WebHTMLView.mm:
1575         (+[WebHTMLView unsupportedTextMIMETypes]):
1576         Re-factor unsupportedTextMIMETypes to pull from WebCore's
1577         MIMETypeRegistry, so that the list can be shared with WebKit2.
1578
1579 2011-03-29  Beth Dakin  <bdakin@apple.com>
1580
1581         Reviewed by Maciej Stachowiak.
1582
1583         Fix for https://bugs.webkit.org/show_bug.cgi?id=57408 
1584         webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard 
1585         -and corresponding-
1586         <rdar://problem/8665411>
1587
1588         * Misc/WebNSControlExtras.m:
1589         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1590         * WebCoreSupport/WebChromeClient.mm:
1591         (WebChromeClient::scaleFactor):
1592         * WebView/WebHTMLView.mm:
1593         (-[WebHTMLView viewDidMoveToWindow]):
1594         (-[WebHTMLView attachRootLayer:]):
1595
1596 2011-03-29  Kent Tamura  <tkent@chromium.org>
1597
1598         Reviewed by Dimitri Glazkov.
1599
1600         Make validation message bubble testable
1601         https://bugs.webkit.org/show_bug.cgi?id=57290
1602
1603         * WebView/WebView.mm:
1604         (-[WebView _preferencesChangedNotification:]): Copy the private value of
1605           the timer magnification to WebCore::Settings.
1606         (-[WebView validationMessageTimerMagnification]): Added.
1607         (-[WebView setValidationMessageTimerMagnification:]): Added.
1608         * WebView/WebViewData.h: Declare a member for the timer magnification.
1609         * WebView/WebViewData.mm:
1610         (-[WebViewPrivate init]): Initialize the timer magnification.
1611         * WebView/WebViewPrivate.h:
1612           Declare a setter and a getter for the timer magnification.
1613
1614 2011-03-29  Kent Tamura  <tkent@chromium.org>
1615
1616         Reviewed by Dimitri Glazkov.
1617
1618         [Mac] Enable interactive-validation tests on Mac DRT
1619         https://bugs.webkit.org/show_bug.cgi?id=57308
1620
1621         * WebView/WebView.mm:
1622         (-[WebView _preferencesChangedNotification:]):
1623           Convey a WebView flag for interactive validation to WebCore::Settings.
1624         (-[WebView interactiveFormValidationEnabled]): Added.
1625         (-[WebView setInteractiveFormValidationEnabled:]): Added.
1626         * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
1627         * WebView/WebViewData.mm:
1628         (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
1629         * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
1630
1631 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1632
1633         Update the order of the context menu to better match AppKit on Mac.
1634
1635         <rdar://problem/9054893>
1636
1637         Reviewed by John Sullivan.
1638
1639         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1640         (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
1641         * WebCoreSupport/WebPlatformStrategies.h:
1642         * WebCoreSupport/WebPlatformStrategies.mm:
1643         (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
1644
1645 2011-03-29  Alexey Proskuryakov  <ap@apple.com>
1646
1647         Reviewed by Darin Adler.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=57379
1650         Clean up WK1 key event handling logic
1651
1652         No bugs knowingly fixed, but this makes the code more consistent.
1653
1654         * WebView/WebHTMLView.mm:
1655         (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
1656         eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
1657         (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
1658         from other functions. We need to execute saved commands when an input method asks for current
1659         state, because providing stale state could confuse it.
1660         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
1661         changes.
1662         (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
1663         the answer would be stale.
1664         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1665         (-[WebHTMLView selectedRange]): Ditto.
1666         (-[WebHTMLView markedRange]): Ditto.
1667         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1668         (-[WebHTMLView hasMarkedText]): Ditto.
1669         (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
1670         operating on stale data. Also, updated for eventWasHandled renaming.
1671         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1672         (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
1673         it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
1674         fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
1675         could have a noop: as one of its commands, although that's hardly practical).
1676         Added the same "from input method" logic that we have in insertText: - I don't know of any
1677         IMs that call this method, but we clearly need to execute it as part of IM processing when
1678         there is marked text.
1679         (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
1680         eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
1681         if current selection isn't editable. This is different from doCommandBySelector:, where we
1682         need to give super class a chance to handle the event if our processing fails.
1683         Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
1684         return value of _interpretKeyEvent is computed differently.
1685
1686 2011-03-28  Adele Peterson  <adele@apple.com>
1687
1688         Reviewed by Eric Seidel.
1689
1690         Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
1691         https://bugs.webkit.org/show_bug.cgi?id=57173
1692
1693         * WebView/WebFrame.mm:
1694         (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
1695         (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
1696         * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
1697
1698 2011-03-28  Alexey Proskuryakov  <ap@apple.com>
1699
1700         Reviewed by Darin Adler.
1701
1702         https://bugs.webkit.org/show_bug.cgi?id=57260
1703         Clean up text input code a little
1704
1705         * WebCoreSupport/WebEditorClient.mm:
1706         (WebEditorClient::handleKeyboardEvent):
1707         (WebEditorClient::handleInputMethodKeydown):
1708         * WebView/WebHTMLViewInternal.h:
1709         Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
1710         anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
1711         and also possibly saves resulting commands for later execution.
1712
1713         * WebView/WebHTMLView.mm:
1714         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
1715         return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
1716         WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
1717         handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
1718         because the first call resulted in no saved commands, becasue it's confusing and apparently
1719         useless (I couldn't find any broken behavior).
1720         (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
1721         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1722         (-[WebHTMLView doCommandBySelector:]): Ditto.
1723         (-[WebHTMLView insertText:]): Ditto.
1724
1725         * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
1726         method on WebView.
1727
1728 2011-03-27  Jer Noble  <jer.noble@apple.com>
1729
1730         Reviewed by Maciej Stachowiak.
1731
1732         Full Screen: disable keyboard access by default
1733         https://bugs.webkit.org/show_bug.cgi?id=56684
1734
1735         Take into account whether keyboard access was requested when deciding whether full
1736         screen mode is supported.
1737
1738         * WebCoreSupport/WebChromeClient.h:
1739         * WebCoreSupport/WebChromeClient.mm:
1740         (WebChromeClient::supportsFullScreenForElement):
1741         * WebView/WebView.mm:
1742         (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
1743         * WebView/WebViewInternal.h:
1744
1745 2011-03-26  Jer Noble  <jer.noble@apple.com>
1746
1747         Reviewed by Eric Carlson.
1748
1749         Enable the Full Screen API by default in WebKit/mac and WebKit2
1750         https://bugs.webkit.org/show_bug.cgi?id=56956
1751
1752         * WebView/WebPreferences.mm:
1753         (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
1754
1755 2011-03-25  Andy Estes  <aestes@apple.com>
1756
1757         Reviewed by Adele Peterson.
1758
1759         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1760         https://bugs.webkit.org/show_bug.cgi?id=49016
1761
1762         Update objectContentType() implementation to handle the
1763         shouldPreferPlugInsForImages flag.
1764
1765         * WebCoreSupport/WebFrameLoaderClient.h:
1766         * WebCoreSupport/WebFrameLoaderClient.mm:
1767         (WebFrameLoaderClient::objectContentType):
1768
1769 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1770
1771         Unreviewed, rolling out r81939.
1772         http://trac.webkit.org/changeset/81939
1773         https://bugs.webkit.org/show_bug.cgi?id=57084
1774
1775         Rolling out 81939, as it's causing a number of app cache test
1776         failures. (Requested by jernoble on #webkit).
1777
1778         * WebView/WebView.mm:
1779         (-[WebView _preferencesChangedNotification:]):
1780
1781 2011-03-23  Jer Noble  <jer.noble@apple.com>
1782
1783         Reviewed by Maciej Stachowiak.
1784
1785         Application Cache should save audio/ and video/ mime types as flat files
1786         https://bugs.webkit.org/show_bug.cgi?id=53784
1787         <rdar://problem/8932473>
1788
1789         No new tests.
1790
1791         Initialize the AppCache Total size quotas with the values for WebKitPreferences
1792         upon startup.
1793
1794         * WebView/WebView.mm:
1795         (-[WebView _preferencesChangedNotification:]):
1796
1797 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1798
1799         Unreviewed, rolling out r81916 and r81917.
1800         http://trac.webkit.org/changeset/81916
1801         http://trac.webkit.org/changeset/81917
1802         https://bugs.webkit.org/show_bug.cgi?id=57071
1803
1804         broke a test on platforms that do not have QuickTime installed
1805         (Requested by estes on #webkit).
1806
1807         * WebCoreSupport/WebFrameLoaderClient.h:
1808         * WebCoreSupport/WebFrameLoaderClient.mm:
1809         (WebFrameLoaderClient::objectContentType):
1810
1811 2011-03-24  Andy Estes  <aestes@apple.com>
1812
1813         Reviewed by Darin Adler.
1814
1815         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1816         https://bugs.webkit.org/show_bug.cgi?id=49016
1817
1818         Update objectContentType() implementation to handle the
1819         shouldPreferPlugInsForImages flag.
1820
1821         * WebCoreSupport/WebFrameLoaderClient.h:
1822         * WebCoreSupport/WebFrameLoaderClient.mm:
1823         (WebFrameLoaderClient::objectContentType):
1824
1825 2011-03-24  Geoffrey Garen  <ggaren@apple.com>
1826
1827         Reviewed by Oliver Hunt.
1828
1829         Ensure that all compilation takes place within a dynamic global object scope
1830         https://bugs.webkit.org/show_bug.cgi?id=57054
1831
1832         * WebView/WebScriptDebugDelegate.mm:
1833         (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
1834
1835 2011-03-24  Jia Pu  <jpu@apple.com>
1836
1837         Reviewed by Darin Adler.
1838
1839         Dismissed reversion suggestion is incorrectly learned.
1840         https://bugs.webkit.org/show_bug.cgi?id=57039
1841
1842         CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
1843         [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
1844         is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
1845         incorrect automatic learning.
1846
1847         * WebCoreSupport/CorrectionPanel.mm:
1848         (CorrectionPanel::dismissInternal):
1849
1850 2011-03-24  David Kilzer  <ddkilzer@apple.com>
1851
1852         <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
1853
1854         Reviewed by Joseph Pecoraro.
1855
1856         * Plugins/WebPluginContainerPrivate.h: Changed value of
1857         ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
1858
1859 2011-03-23  Jia Pu  <jpu@apple.com>
1860
1861         Reviewed by Darin Adler.
1862
1863         Hook up new AppKit autocorrection UI with WK2.
1864         https://bugs.webkit.org/show_bug.cgi?id=56055
1865         <rdar://problem/8947463>
1866
1867         Please see WebCore/ChangeLog for detail.
1868
1869         * WebCoreSupport/CorrectionPanel.h: Added.
1870         (CorrectionPanel::isShowing):
1871         * WebCoreSupport/CorrectionPanel.mm: Added.
1872         (correctionBubbleType):
1873         (CorrectionPanel::CorrectionPanel):
1874         (CorrectionPanel::~CorrectionPanel):
1875         (CorrectionPanel::show):
1876         (CorrectionPanel::dismiss):
1877         (CorrectionPanel::dismissSoon):
1878         (CorrectionPanel::dismissInternal):
1879         (CorrectionPanel::recordAutocorrectionResponse):
1880         * WebCoreSupport/WebEditorClient.h:
1881         * WebCoreSupport/WebEditorClient.mm:
1882         (WebEditorClient::WebEditorClient):
1883         (WebEditorClient::showCorrectionPanel):
1884         (WebEditorClient::dismissCorrectionPanel):
1885         (WebEditorClient::dismissCorrectionPanelSoon):
1886         (WebEditorClient::recordAutocorrectionResponse):
1887         * WebView/WebView.mm:
1888         (-[WebView handleCorrectionPanelResult:]):
1889         * WebView/WebViewPrivate.h:
1890
1891 2011-03-23  Enrica Casucci  <enrica@apple.com>
1892
1893         Reviewed by Alexey Proskuryakov.
1894
1895         Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
1896         https://bugs.webkit.org/show_bug.cgi?id=56974
1897         <rdar://problem/8284642>
1898
1899         This fixes a regression introduced by http://trac.webkit.org/changeset/61794
1900         where readSelectionFromPasteboard was accidentally removed.
1901         This method and writeSelectionToPasteboard are needed to support Mac OS X
1902         services.
1903         
1904         * WebView/WebHTMLView.mm:
1905         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
1906         (-[WebHTMLView readSelectionFromPasteboard:]): Added.
1907
1908 2011-03-23  Brady Eidson  <beidson@apple.com>
1909
1910         Reviewed by Sam Weinig.
1911
1912         Change IconDatabase opening to allow for arbitrary filenames
1913         https://bugs.webkit.org/show_bug.cgi?id=56977
1914
1915         * Misc/WebIconDatabase.mm:
1916         (-[WebIconDatabase _startUpIconDatabase]):
1917
1918 2011-03-22  Anton D'Auria  <adauria@apple.com>
1919
1920         Reviewed by Alexey Proskuryakov.
1921
1922         Add +[WebApplicationCache getOriginsWithCache]
1923         https://bugs.webkit.org/show_bug.cgi?id=56722
1924
1925         Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
1926
1927         * WebCoreSupport/WebApplicationCache.h:
1928         * WebCoreSupport/WebApplicationCache.mm:
1929         (+[WebApplicationCache originsWithCache]):
1930
1931 2011-03-22  Anders Carlsson  <andersca@apple.com>
1932
1933         Reviewed by Sam Weinig.
1934
1935         OBJECT element with DivX source is always downloaded
1936         https://bugs.webkit.org/show_bug.cgi?id=56879
1937
1938         * Plugins/WebBasePluginPackage.mm:
1939         (-[WebBasePluginPackage getPluginInfoFromPLists]):
1940         Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
1941         specifies multiple file extensions in a single element.
1942
1943 2011-03-22  Brady Eidson  <beidson@apple.com>
1944
1945         Reviewed by Sam Weinig.
1946
1947         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
1948         WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
1949
1950         Note that while the new client calls always come through on the main thread, our mechanisms to
1951         route dispatches to the main thread are still valid and will still work.
1952
1953         Update to the new IconDatabaseClient interface:
1954         * WebCoreSupport/WebIconDatabaseClient.h:
1955         * WebCoreSupport/WebIconDatabaseClient.mm:
1956         (WebIconDatabaseClient::didRemoveAllIcons):
1957         (WebIconDatabaseClient::didImportIconURLForPageURL):
1958         (WebIconDatabaseClient::didImportIconDataForPageURL):
1959         (WebIconDatabaseClient::didChangeIconForPageURL):
1960         (WebIconDatabaseClient::didFinishURLImport):
1961
1962 2011-03-22  Matthew Delaney  <mdelaney@apple.com>
1963
1964         Reviewed by Simon Fraser.
1965
1966         Have WebKit push acceleratedDrawing preferences to settings
1967         https://bugs.webkit.org/show_bug.cgi?id=56792
1968
1969         * WebView/WebView.mm:
1970
1971 2011-03-21  Nate Chapin  <japhet@chromium.org>
1972
1973         Reviewed by Brady Eidson.
1974
1975         Expose a preference to use caching quirks for QuickLook,
1976         and use it if the QuickLook framework is loaded.
1977
1978         https://bugs.webkit.org/show_bug.cgi?id=38690
1979
1980         * WebView/WebPreferenceKeysPrivate.h:
1981         * WebView/WebPreferences.mm:
1982         (useQuickLookQuirks):
1983         (+[WebPreferences initialize]):
1984         (-[WebPreferences useQuickLookResourceCachingQuirks]):
1985         * WebView/WebPreferencesPrivate.h:
1986         * WebView/WebView.mm:
1987         (-[WebView _preferencesChangedNotification:]):
1988
1989 2011-03-21  Chris Fleizach  <cfleizach@apple.com>
1990
1991         Reviewed by Darin Adler.
1992
1993         AX: showContextMenu not working in WK2
1994         https://bugs.webkit.org/show_bug.cgi?id=56734
1995
1996         Implement showContextMenu() so accessibility related code can call this
1997         independent of whether WK1 or WK2 is running.
1998
1999         * WebCoreSupport/WebChromeClient.h:
2000         * WebCoreSupport/WebChromeClient.mm:
2001         (WebChromeClient::showContextMenu):
2002
2003 2011-03-21  Chang Shu  <cshu@webkit.org>
2004
2005         Reviewed by Alexey Proskuryakov.
2006
2007         REGRESSION (r79953): Can't type in MS Outlook 2011
2008         https://bugs.webkit.org/show_bug.cgi?id=56665
2009
2010         r79953 removed the WebView level editablity which is persistent no matter whether
2011         underlying document itself is changed and editability gets lost. The resolution is to
2012         set this WebView editable value to WebCore. This avoids the callback from WebCore to
2013         WebKit which was the main goal in r79953 to improve performance.
2014
2015         * WebView/WebView.mm:
2016         (-[WebView setEditable:]):
2017         (-[WebView isEditable]):
2018
2019 2011-03-19  Anton D'Auria  <adauria@apple.com>
2020
2021         Reviewed by Alexey Proskuryakov.
2022
2023         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2024         https://bugs.webkit.org/show_bug.cgi?id=56415
2025         
2026         Use new ApplicationCache API to delete all cache for an origin.
2027
2028         * WebCoreSupport/WebApplicationCache.h:
2029         * WebCoreSupport/WebApplicationCache.mm:
2030         (+[WebApplicationCache deleteOrigin:]):
2031
2032 2011-03-17  Brady Eidson  <beidson@apple.com>
2033
2034         Reviewed by Sam Weinig.
2035
2036         https://bugs.webkit.org/show_bug.cgi?id=56425
2037         More groundwork for WebKit2 IconDatabase
2038
2039         Update already-used function names:
2040         * Misc/WebIconDatabase.mm:
2041         (-[WebIconDatabase iconForURL:withSize:cache:]):
2042         (-[WebIconDatabase iconURLForURL:]):
2043         * WebView/WebView.mm:
2044         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2045
2046 2011-03-18  Pavel Podivilov  <podivilov@chromium.org>
2047
2048         Reviewed by Yury Semikhatsky.
2049
2050         Web Inspector: implement inspector session storage.
2051         https://bugs.webkit.org/show_bug.cgi?id=56643
2052
2053         * WebCoreSupport/WebInspectorClient.h:
2054         * WebCoreSupport/WebInspectorClient.mm:
2055         (WebInspectorClient::saveSessionSetting):
2056         (WebInspectorClient::loadSessionSetting):
2057         (WebInspectorFrontendClient::saveSessionSetting):
2058         (WebInspectorFrontendClient::loadSessionSetting):
2059         (-[WebInspectorWindowController inspectorClient]):
2060
2061 2011-03-17  Geoffrey Garen  <ggaren@apple.com>
2062
2063         Reviewed by Oliver Hunt.
2064
2065         Fixed a leak seen on the buildbot.
2066
2067         * WebCoreSupport/WebInspectorClient.mm:
2068         (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
2069
2070 2011-03-16  Jeff Johnson  <github@lapcatsoftware.com>
2071
2072         Reviewed by Alexey Proskuryakov.
2073
2074         Logic error in -[WebHTMLView close]
2075         https://bugs.webkit.org/show_bug.cgi?id=56445
2076
2077         Page is always nil at this point, because [self _webView] is nil,
2078         so the conditional code is never run.
2079
2080         * WebView/WebHTMLView.mm:
2081         (-[WebHTMLView close]):
2082
2083 2011-03-16  Chris Fleizach  <cfleizach@apple.com>
2084
2085         Reviewed by Darin Adler.
2086
2087         WK2: Need to propagate enhanced accessibility flag from UI -> web process
2088         https://bugs.webkit.org/show_bug.cgi?id=56379
2089
2090         * WebView/WebFrame.mm:
2091         (-[WebFrame accessibilityRoot]):
2092
2093 2011-03-15  Oliver Hunt  <oliver@apple.com>
2094
2095         Reviewed by Geoffrey Garen.
2096
2097         Make Structure creation require a JSGlobalData
2098         https://bugs.webkit.org/show_bug.cgi?id=56438
2099
2100         Mechanical change to make all Structure creation use a JSGlobalData&
2101
2102         * Plugins/Hosted/ProxyInstance.mm:
2103         (WebKit::ProxyRuntimeMethod::createStructure):
2104         * Plugins/Hosted/ProxyRuntimeObject.h:
2105         (WebKit::ProxyRuntimeObject::createStructure):
2106
2107 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2108
2109         Forgot to save a modification to this file when committing.
2110
2111         * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
2112
2113 2011-03-15  Alexey Proskuryakov  <ap@apple.com>
2114
2115         Reviewed by Darin Adler.
2116
2117         REGRESSION (WebKit2): keygen element doesn't work
2118         https://bugs.webkit.org/show_bug.cgi?id=56402
2119         <rdar://problem/9006545>
2120
2121         * WebCoreSupport/WebKeyGenerator.h:
2122         * WebCoreSupport/WebKeyGenerator.m: Removed.
2123         * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
2124         (+[WebKeyGenerator sharedGenerator]):
2125         (toWebCertificateParseResult):
2126         WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
2127         this misnamed and misplaced code for now.
2128
2129         * WebCoreSupport/WebPlatformStrategies.h:
2130         * WebCoreSupport/WebPlatformStrategies.mm:
2131         (WebPlatformStrategies::keygenMenuItem512):
2132         (WebPlatformStrategies::keygenMenuItem1024):
2133         (WebPlatformStrategies::keygenMenuItem2048):
2134         (WebPlatformStrategies::keygenKeychainItemName):
2135         Added strings used by keygen.
2136
2137         * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
2138         pointer to a function used by keygen.
2139
2140         * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
2141         initialized now.
2142
2143 2011-03-15  Beth Dakin  <bdakin@apple.com>
2144
2145         Reviewed by Simon Fraser.
2146
2147         WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
2148
2149         New WebKitystemInterface function to force the scrollbars to flash
2150         * WebCoreSupport/WebSystemInterface.mm:
2151         (InitWebCoreSystemInterface):
2152
2153 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2154
2155         Reviewed by Tony Chang.
2156
2157         Autofilled form elements are assigned fixed background color but not text color
2158         https://bugs.webkit.org/show_bug.cgi?id=48382
2159
2160         * DOM/WebDOMOperations.mm:
2161         (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
2162         * DOM/WebDOMOperationsPrivate.h:
2163
2164 2011-03-15  Adam Roben  <aroben@apple.com>
2165
2166         Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
2167
2168         Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
2169         WebStorageTrackerClient::dispatchDidModifyOrigin
2170
2171         Reviewed by Antti Koivisto.
2172
2173         * Storage/WebStorageTrackerClient.mm:
2174         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
2175         to us by dispatchDidModifyOrigin.
2176         (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
2177         unnecessary cast.
2178
2179 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2180
2181         Reviewed by Darin Adler.
2182
2183         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2184         info into the headers rather than in export symbol definition files, but disable it on 
2185         all platforms initially so we can deal with port build issues one port at a time.
2186         
2187         https://bugs.webkit.org/show_bug.cgi?id=27551
2188
2189         * WebKitPrefix.h:
2190
2191 2011-03-14  Brady Eidson  <beidson@apple.com>
2192
2193         Reviewed by Anders Carlsson.
2194
2195         https://bugs.webkit.org/show_bug.cgi?id=56320
2196         Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
2197
2198         * History/WebHistoryItem.mm:
2199         (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
2200
2201 2011-03-13  Pratik Solanki  <psolanki@apple.com>
2202
2203         Reviewed by Brady Eidson.
2204
2205         Make adjustMIMETypeIfNecessary use CFNetwork directly
2206         https://bugs.webkit.org/show_bug.cgi?id=55912
2207
2208         * WebCoreSupport/WebSystemInterface.mm:
2209         (InitWebCoreSystemInterface): Support for new WKSI functions.
2210
2211 2011-03-12  Mark Rowe  <mrowe@apple.com>
2212
2213         Fix the 32-bit build.
2214
2215         * Carbon/CarbonWindowAdapter.mm:
2216         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
2217         (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
2218
2219 2011-03-11  Brady Eidson  <beidson@apple.com>
2220
2221         Reviewed by Anders Carlsson
2222
2223         <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
2224         Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
2225
2226         * Misc/WebIconDatabase.mm:
2227         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
2228         (-[WebIconDatabase _startUpIconDatabase]): Ditto.
2229         (importToWebCoreFormat):
2230
2231 2011-03-11  Anton D'Auria  <adauria@apple.com>
2232
2233         Reviewed and landed by Brady Eidson.
2234
2235         https://bugs.webkit.org/show_bug.cgi?id=51878
2236         Add WebKit1 API to view and delete local storage
2237
2238         * Storage/WebStorageManager.mm: Added.
2239         (+[WebStorageManager sharedWebStorageManager]):
2240         (-[WebStorageManager origins]):
2241         (-[WebStorageManager deleteAllOrigins]):
2242         (-[WebStorageManager deleteOrigin:]):
2243         (-[WebStorageManager syncLocalStorage]):
2244         (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
2245         (storageDirectoryPath):
2246         (WebKitInitializeStorageIfNecessary):
2247         * Storage/WebStorageManagerInternal.h: Added.
2248         * Storage/WebStorageManagerPrivate.h: Added.
2249         * Storage/WebStorageTrackerClient.h: Added.
2250         * Storage/WebStorageTrackerClient.mm: Added.
2251         (WebStorageTrackerClient::sharedWebStorageTrackerClient):
2252         (WebStorageTrackerClient::WebStorageTrackerClient):
2253         (WebStorageTrackerClient::~WebStorageTrackerClient):
2254         (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
2255         (WebStorageTrackerClient::dispatchDidModifyOrigin):
2256         * WebCoreSupport/WebSecurityOrigin.mm:
2257         (-[WebSecurityOrigin protocol]):
2258         (-[WebSecurityOrigin host]):
2259         (-[WebSecurityOrigin databaseIdentifier]):
2260         (-[WebSecurityOrigin domain]):
2261         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
2262         * WebCoreSupport/WebSecurityOriginPrivate.h:
2263         * WebKit.exp:
2264         * WebView/WebView.mm:
2265         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2266
2267 2011-03-10  Anders Carlsson  <andersca@apple.com>
2268
2269         Reviewed by Sam Weinig.
2270
2271         <rdar://problem/9117047>
2272         Don't paint more than 60 times per second even when scrolling
2273
2274         * WebView/WebClipView.mm:
2275         (-[WebClipView _immediateScrollToPoint:]):
2276
2277 2011-03-09  Matthew Delaney  <mdelaney@apple.com>
2278
2279         Reviewed by Simon Fraser.
2280
2281         Plumb through settings for accelerated drawing for canvas
2282         https://bugs.webkit.org/show_bug.cgi?id=56039
2283
2284         * WebView/WebPreferenceKeysPrivate.h:
2285         * WebView/WebPreferences.mm:
2286         * WebView/WebPreferencesPrivate.h:
2287
2288 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
2289
2290         Reviewed by Tony Chang.
2291
2292         VisiblePosition's next and previous should take an enum instead of a boolean
2293         https://bugs.webkit.org/show_bug.cgi?id=56135
2294
2295         SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
2296         StayInEditableContent.
2297
2298         * WebView/WebView.mm:
2299         (-[WebView _selectionIsAll]):
2300
2301 2011-03-09  Jessie Berlin  <jberlin@apple.com>
2302
2303         Reviewed by Adam Roben.
2304
2305         Use the Cookie Storage from the Private Browsing Storage Session directly
2306         https://bugs.webkit.org/show_bug.cgi?id=55986
2307
2308         * WebCoreSupport/WebSystemInterface.mm:
2309         (InitWebCoreSystemInterface):
2310
2311 2011-03-08  Darin Adler  <darin@apple.com>
2312
2313         Reviewed by Timothy Hatcher.
2314
2315         Promote a method used outside WebKit from internal to private
2316         https://bugs.webkit.org/show_bug.cgi?id=55949
2317
2318         * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
2319         Minor tweak, not directly related to the rest of this patch.
2320
2321         * WebView/WebFrame.mm:
2322         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
2323         this method from the internal category into the private category.
2324         Streamlined the code a bit.
2325
2326         * WebView/WebFrameInternal.h: Removed _computePageRects method.
2327         * WebView/WebFramePrivate.h: Added _computePageRects method.
2328
2329 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2330
2331         Reviewed by Darin Adler.
2332
2333         selectionHasStyle and selectionStartHasStyle should use EditingStyle
2334         https://bugs.webkit.org/show_bug.cgi?id=55902
2335
2336         selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
2337
2338         * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
2339         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
2340
2341 2011-03-07  Dan Bernstein  <mitz@apple.com>
2342
2343         LLVM Compiler build fix.
2344
2345         * WebCoreSupport/WebEditorClient.mm:
2346         (WebEditorClient::checkGrammarOfString):
2347
2348 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2349
2350         Reviewed by Beth Dakin.
2351
2352         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
2353         https://bugs.webkit.org/show_bug.cgi?id=55706
2354
2355         Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
2356         returns the scroll bar objects).
2357         Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
2358         will expect that as its child, instead of the WebCore ScrollView object.
2359
2360         * WebView/WebDynamicScrollBarsView.mm:
2361         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
2362         * WebView/WebFrame.mm:
2363         (-[WebFrame accessibilityRoot]):
2364
2365 2011-03-07  Sam Weinig  <sam@webkit.org>
2366
2367         Reviewed by Anders Carlsson.
2368
2369         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2370         https://bugs.webkit.org/show_bug.cgi?id=55827
2371
2372         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2373         and pass the entire response, instead of just the MIMEType.
2374
2375         * WebCoreSupport/WebFrameLoaderClient.h:
2376         * WebCoreSupport/WebFrameLoaderClient.mm:
2377         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2378
2379 2011-03-06  Dan Bernstein  <mitz@apple.com>
2380
2381         LLVM Compiler build fix.
2382
2383         * DOM/WebDOMOperations.mm:
2384         (-[DOMHTMLInputElement _setValueForUser:]):
2385
2386 2011-03-06  Jessie Berlin  <jberlin@apple.com>
2387
2388         Reviewed by Sam Weinig.
2389
2390         WebKit2: Use CFNetwork Sessions API.
2391         https://bugs.webkit.org/show_bug.cgi?id=55435.
2392
2393         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
2394         Private Browsing Storage Session.
2395
2396         * WebCoreSupport/WebSystemInterface.mm:
2397         (InitWebCoreSystemInterface):
2398         Add support for using the new WKSI functions in WebCore.
2399
2400 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2401
2402         Reviewed by Darin Adler.
2403
2404         HTMLInputElement::setValue() should schedule change event when the element is focused
2405         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2406         https://bugs.webkit.org/show_bug.cgi?id=53160
2407
2408         * DOM/WebDOMOperations.mm:
2409         (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
2410         * DOM/WebDOMOperationsPrivate.h:
2411         * WebView/WebViewInternal.h:
2412
2413 2011-03-04  Jia Pu  <jpu@apple.com>
2414
2415         Reviewed by Darin Adler.
2416
2417         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
2418         https://bugs.webkit.org/show_bug.cgi?id=55717
2419         <rdar://problem/9018127>
2420
2421         With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
2422         is already in window coordinate. We don't need to do further conversion anymore.
2423
2424         * WebCoreSupport/WebEditorClient.mm:
2425         (WebEditorClient::showCorrectionPanel):
2426
2427 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2428
2429         Reviewed by Maciej Stachowiak.
2430
2431         WebKit2: Use CFNetwork Sessions API.
2432         https://bugs.webkit.org/show_bug.cgi?id=55435.
2433
2434         When Private Browsing is enabled, get the cached url response from the cache associated with
2435         the Private Browsing Storage Session.
2436
2437         * WebView/WebView.mm:
2438         (-[WebView _cachedResponseForURL:]):
2439
2440 2011-03-03  Anders Carlsson  <andersca@apple.com>
2441
2442         Reviewed by Sam Weinig.
2443
2444         Get rid of Page::globalHistoryItem
2445         https://bugs.webkit.org/show_bug.cgi?id=55738
2446
2447         * WebCoreSupport/WebFrameLoaderClient.h:
2448         * WebCoreSupport/WebFrameLoaderClient.mm:
2449         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
2450         Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
2451     
2452         * WebView/WebView.mm:
2453         (-[WebView _globalHistoryItem]):
2454         (-[WebView _setGlobalHistoryItem:]):
2455         Set _globalHistoryItem ivar.
2456
2457         * WebView/WebViewData.h:
2458         * WebView/WebViewData.mm:
2459         Add _globalHistoryItem ivar.
2460
2461 2011-03-03  Brady Eidson  <beidson@apple.com>
2462
2463         Reviewed by Darin Adler.
2464
2465         https://bugs.webkit.org/show_bug.cgi?id=55721
2466         Global IconDatabase should be returned by reference, not as a pointer
2467
2468         * Misc/WebCoreStatistics.mm:
2469         (+[WebCoreStatistics iconPageURLMappingCount]):
2470         (+[WebCoreStatistics iconRetainedPageURLCount]):
2471         (+[WebCoreStatistics iconRecordCount]):
2472         (+[WebCoreStatistics iconsWithDataCount]):
2473         * Misc/WebIconDatabase.mm:
2474         (-[WebIconDatabase init]):
2475         (-[WebIconDatabase iconForURL:withSize:cache:]):
2476         (-[WebIconDatabase iconURLForURL:]):
2477         (-[WebIconDatabase defaultIconWithSize:]):
2478         (-[WebIconDatabase retainIconForURL:]):
2479         (-[WebIconDatabase releaseIconForURL:]):
2480         (-[WebIconDatabase isEnabled]):
2481         (-[WebIconDatabase setEnabled:]):
2482         (-[WebIconDatabase removeAllIcons]):
2483         (+[WebIconDatabase _checkIntegrityBeforeOpening]):
2484         (-[WebIconDatabase _startUpIconDatabase]):
2485         (-[WebIconDatabase _applicationWillTerminate:]):
2486         (-[WebIconDatabase _resetCachedWebPreferences:]):
2487         (importToWebCoreFormat):
2488         * WebView/WebView.mm:
2489         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
2490
2491 2011-03-03  Jessie Berlin  <jberlin@apple.com>
2492
2493         Reviewed by Adam Roben.
2494
2495         WebKit2: Use CFNetwork Sessions API.
2496         https://bugs.webkit.org/show_bug.cgi?id=55435.
2497
2498         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
2499
2500         * WebCoreSupport/WebSystemInterface.mm:
2501         (InitWebCoreSystemInterface):
2502         Support using WKCopyRequestWithStorageSession in WebCore.
2503
2504 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2505
2506         Reviewed by Darin Adler.
2507
2508         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2509         https://bugs.webkit.org/show_bug.cgi?id=55633
2510         <rdar://problem/8963023>
2511
2512         * WebCoreSupport/WebChromeClient.h:
2513         * WebCoreSupport/WebChromeClient.mm:
2514         Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
2515
2516         * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2517         Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
2518         require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
2519         so I've preserved it.
2520
2521 2011-03-02  Jessie Berlin  <jberlin@apple.com>
2522
2523         Rubber-stamped by Dan Bernstein.
2524
2525         Fix crashes in private browsing tests in WK1 on Snow Leopard.
2526
2527         * WebCoreSupport/WebSystemInterface.mm:
2528         (InitWebCoreSystemInterface):
2529         Put the INIT call for wkCreatePrivateStorageSession outside of the
2530         #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
2531         guards.
2532
2533 2011-03-02  Jessie Berlin  <jberlin@apple.com>
2534
2535         Reviewed by Adam Roben.
2536
2537         WebKit2: Use CFNetwork Sessions API.
2538         https://bugs.webkit.org/show_bug.cgi?id=55435.
2539
2540         Add the ability to create a Private Browsing Storage Session.
2541
2542         * WebCoreSupport/WebSystemInterface.mm:
2543         (InitWebCoreSystemInterface):
2544         Support calling wkCreatePrivateStorageSession from WebCore.
2545
2546 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2547
2548         Reviewed by David Levin.
2549
2550         Add feature define for data transfer items
2551         https://bugs.webkit.org/show_bug.cgi?id=55510
2552
2553         * Configurations/FeatureDefines.xcconfig:
2554
2555 2011-03-02  Sam Weinig  <sam@webkit.org>
2556
2557         Reviewed by Anders Carlsson.
2558
2559         Fix remaining localization issues by piping all localized strings through WebCore's
2560         localization bottleneck.
2561         <rdar://problem/8728860>
2562
2563         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2564         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2565         * Misc/WebKitErrors.m:
2566         * Misc/WebLocalizableStringsInternal.h: Added.
2567         * Misc/WebLocalizableStringsInternal.mm: Added.
2568         (WebLocalizedStringInternal):
2569         * Panels/WebAuthenticationPanel.m:
2570         (-[WebAuthenticationPanel setUpForChallenge:]):
2571         * Plugins/Hosted/NetscapePluginHostManager.mm:
2572         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2573         * WebCoreSupport/WebEditorClient.mm:
2574         (undoNameForEditAction):
2575         * WebCoreSupport/WebInspectorClient.mm:
2576         (WebInspectorFrontendClient::updateWindowTitle):
2577         (-[WebInspectorWindowController validateUserInterfaceItem:]):
2578         * WebCoreSupport/WebKeyGenerator.m:
2579         (-[WebKeyGenerator strengthMenuItemTitles]):
2580         (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
2581         * WebCoreSupport/WebPlatformStrategies.mm:
2582         * WebView/WebHTMLView.mm:
2583         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
2584         * WebView/WebPDFView.mm:
2585         (-[WebPDFView menuForEvent:]):
2586
2587 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
2588
2589         Reviewed by Adam Roben.
2590
2591         Part of WebKit2: Need a way to send notifications to client when cookies change
2592         https://bugs.webkit.org/show_bug.cgi?id=55427
2593         <rdar://problem/9056027>
2594         
2595         Add stubs for CookiesStrategy on Mac WebKit1.
2596
2597         * WebCoreSupport/WebPlatformStrategies.h:
2598         * WebCoreSupport/WebPlatformStrategies.mm:
2599         (WebPlatformStrategies::createCookiesStrategy):
2600         (WebPlatformStrategies::notifyCookiesChanged):
2601
2602 2011-03-01  Philippe Normand  <pnormand@igalia.com>
2603
2604         Reviewed by Eric Carlson.
2605
2606         [GStreamer] support in mac video fullscreen controller
2607         https://bugs.webkit.org/show_bug.cgi?id=52280
2608
2609         Factored the code to configure the video overlay in a new private
2610         method of the controller and added GStreamer support to it.
2611
2612         * WebView/WebVideoFullscreenController.h:
2613         * WebView/WebVideoFullscreenController.mm:
2614         (-[WebVideoFullscreenController setupVideoOverlay:]):
2615         (-[WebVideoFullscreenController windowDidLoad]):
2616         (-[WebVideoFullscreenController setMediaElement:WebCore::]):
2617         (-[WebVideoFullscreenController windowDidExitFullscreen]):
2618
2619 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
2620
2621         Reviewed by Timothy Hatcher.
2622
2623         All Console Messages should be passed to ChromeClients.
2624         https://bugs.webkit.org/show_bug.cgi?id=54926
2625
2626         Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
2627         which supersedes -webView:addMessageToConsole if it exists. The new delegate
2628         does not filter to only JavaScript originated console messages. The old
2629         delegate is left around for clients that expect filtered messages, like
2630         DashCode and older versions of Safari.
2631
2632         The dictionary message passed to the delegate now includes more information
2633         about the message source, type, and level.
2634
2635         * WebCoreSupport/WebChromeClient.mm:
2636         (stringForMessageSource):
2637         (stringForMessageType):
2638         (stringForMessageLevel):
2639         (WebChromeClient::addMessageToConsole):
2640         * WebView/WebUIDelegatePrivate.h:
2641
2642 2011-03-01  Levi Weintraub  <leviw@chromium.org>
2643
2644         Reviewed by Ryosuke Niwa.
2645
2646         Stop instantiating legacy editing Positions in VisiblePosition
2647         https://bugs.webkit.org/show_bug.cgi?id=52919
2648
2649         Changing usage of legacy VisiblePosition constructor. Since we were dealing
2650         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
2651
2652         * WebView/WebFrame.mm:
2653         (-[WebFrame _caretRectAtPosition:affinity:]):
2654         * WebView/WebFrameInternal.h:
2655         * WebView/WebTextCompletionController.mm:
2656         (-[WebTextCompletionController doCompletion]):
2657
2658 2011-03-01  Sam Weinig  <sam@webkit.org>
2659
2660         Reviewed by Timothy Hatcher.
2661
2662         WebKit2 needs to be made localizable
2663         https://bugs.webkit.org/show_bug.cgi?id=55483
2664
2665         * WebCoreSupport/WebPlatformStrategies.mm:
2666         Use WebCore's localizedString function instead of WebLocalizableStrings
2667         since WebCore is now responsible for localization.
2668
2669 2011-02-25 Steve Block <steveblock@google.com>
2670
2671         Reviewed by Jeremy Orlow.
2672
2673         Bridge.h should not include BridgeJSC.h
2674         https://bugs.webkit.org/show_bug.cgi?id=55212
2675
2676         Include BridgeJSC.h directly instead.
2677
2678         * Plugins/Hosted/ProxyInstance.h:
2679         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2680
2681 2011-02-28  Chang Shu  <cshu@webkit.org>
2682
2683         Reviewed by Ryosuke Niwa.
2684
2685         Remove the support of Frame::isContentEditable and its dependencies.
2686         https://bugs.webkit.org/show_bug.cgi?id=54292
2687
2688         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2689
2690         * WebCoreSupport/WebEditorClient.h:
2691         * WebCoreSupport/WebEditorClient.mm:
2692         * WebView/WebView.mm:
2693         (-[WebView setEditable:]):
2694         (-[WebView isEditable]):
2695         * WebView/WebViewData.h:
2696
2697 2011-02-28  Oliver Hunt  <oliver@apple.com>
2698
2699         Reviewed by Gavin Barraclough.
2700
2701         Make ScopeChainNode GC allocated
2702         https://bugs.webkit.org/show_bug.cgi?id=55283
2703
2704         More updates for the absence of the ScopeChain class
2705
2706         * WebView/WebScriptDebugDelegate.mm:
2707         (-[WebScriptCallFrame scopeChain]):
2708
2709 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2710
2711         Reviewed by Pavel Feldman.
2712
2713         DumpRenderTree should reset frame opener between tests.
2714         https://bugs.webkit.org/show_bug.cgi?id=54874
2715
2716         Added clearOpener method to WebFramePrivate.
2717
2718         * WebView/WebFrame.mm:
2719         (-[WebFrame _clearOpener]):
2720         * WebView/WebFramePrivate.h:
2721
2722 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2723
2724         Unreviewed, rolling out r79764.
2725         http://trac.webkit.org/changeset/79764
2726         https://bugs.webkit.org/show_bug.cgi?id=55295
2727
2728         "broke Chromium builds" (Requested by rniwa on #webkit).
2729
2730         * WebView/WebFrame.mm:
2731         * WebView/WebFramePrivate.h:
2732
2733 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
2734
2735         Reviewed by David Kilzer.
2736
2737         https://bugs.webkit.org/show_bug.cgi?id=48781
2738
2739         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
2740
2741         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
2742         should paint the default broken image when an image fails to load or decode.  The method also passes the
2743         URL of the failed image.
2744
2745         * WebCoreSupport/WebFrameLoaderClient.h:
2746         * WebCoreSupport/WebFrameLoaderClient.mm:
2747         (WebFrameLoaderClient::shouldPaintBrokenImage):
2748         * WebView/WebDelegateImplementationCaching.h:
2749         * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
2750         (CallResourceLoadDelegateReturningBoolean):
2751         * WebView/WebResourceLoadDelegatePrivate.h:
2752         * WebView/WebView.mm:
2753         (-[WebView _cacheResourceLoadDelegateImplementations]):
2754
2755 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2756
2757         Reviewed by Pavel Feldman.
2758
2759         DumpRenderTree should reset frame opener between tests.
2760         https://bugs.webkit.org/show_bug.cgi?id=54874
2761
2762         Added clearOpener method to WebFramePrivate.
2763
2764         * WebView/WebFrame.mm:
2765         (-[WebFrame _clearOpener]):
2766         * WebView/WebFramePrivate.h:
2767
2768 2011-02-25  Mark Rowe  <mrowe@apple.com>
2769
2770         <rdar://problem/8902546> Build fix.
2771
2772         * Misc/QuickDrawCompatibility.h:
2773
2774 2011-02-24  Anders Carlsson  <andersca@apple.com>
2775
2776         Fix clang build.
2777
2778         * WebCoreSupport/WebKeyGenerator.m:
2779         (toWebCertificateParseResult):
2780         (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
2781         * WebView/WebTextCompletionController.mm:
2782
2783 2011-02-24  Peter Kasting  <pkasting@google.com>
2784
2785         Reviewed by Eric Seidel.
2786
2787         Drop the "U; " encryption level from the User Agent string.
2788         https://bugs.webkit.org/show_bug.cgi?id=54566
2789
2790         * WebView/WebView.mm:
2791         (+[WebView _standardUserAgentWithApplicationName:]):
2792
2793 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2794
2795         Unreviewed, rolling out r79570.
2796         http://trac.webkit.org/changeset/79570
2797         https://bugs.webkit.org/show_bug.cgi?id=54874
2798
2799         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2800         was not updated
2801
2802         * WebView/WebFrame.mm:
2803         * WebView/WebFramePrivate.h:
2804
2805 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         DumpRenderTree should reset frame opener between tests.
2810         https://bugs.webkit.org/show_bug.cgi?id=54874
2811
2812         Added clearOpener method to WebFramePrivate.
2813
2814         * WebView/WebFrame.mm:
2815         (-[WebFrame _clearOpener]):
2816         * WebView/WebFramePrivate.h:
2817
2818 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2819
2820         Reviewed by Alexey Proskuryakov.
2821
2822         Drop the language tag part from the User Agent string
2823         https://bugs.webkit.org/show_bug.cgi?id=54560
2824
2825         * WebView/WebView.mm:
2826         (+[WebView _standardUserAgentWithApplicationName:]): Drop the
2827         language tag part.
2828
2829 2011-02-22  Brady Eidson  <beidson@apple.com>
2830
2831         Reviewed by Anders Carlsson.
2832
2833         Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
2834         API to view and delete Application Cache data by origin.
2835
2836         * WebCoreSupport/WebApplicationCache.mm:
2837         (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
2838
2839 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2840
2841         Reviewed by Kent Tamura.
2842
2843         Rename Position::node() to Position::deprecatedNode()
2844         https://bugs.webkit.org/show_bug.cgi?id=54622
2845
2846         * WebView/WebFrame.mm:
2847         (-[WebFrame _smartDeleteRangeForProposedRange:]):
2848
2849 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2850
2851         Reviewed by Kent Tamura.
2852
2853         Rename Position::node() to Position::deprecatedNode()
2854         https://bugs.webkit.org/show_bug.cgi?id=54622
2855         
2856         Done the rename.
2857
2858         * WebView/WebFrame.mm:
2859         (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
2860         use containerNode() and offsetInContainerNode() instead of deprecated member functions.
2861
2862 2011-02-18  Gavin Barraclough  <barraclough@apple.com>
2863
2864         Reviewed by Sam Weinig.
2865
2866         Bug 54786 - Devirtualize JSCell::classInfo()
2867
2868         Instead of making a virtual function call, add a pointer to the ClassInfo
2869         onto Structure.
2870
2871         This removes a virtual function call, and paves the way towards removing all
2872         the createStructure methods, and StructureFlags/AnonymousSlotCount properties
2873         (these should be able to move onto ClassInfo).
2874
2875         Calls to Structure::create must now pass a pointer to the ClassInfo for the
2876         structure. All objects now have a ClassInfo pointer, non-object cell types
2877         still do not.
2878
2879         Changes are most mechanical, involving three steps:
2880             * Remove virtual classInfo() methods.
2881             * Add &s_info parameter to calls to Structure::create.
2882             * Rename ClassInfo static members on classes from 'info' to 's_info',
2883               for consistency.
2884
2885         * Plugins/Hosted/ProxyInstance.mm:
2886         (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2887         (WebKit::ProxyRuntimeMethod::createStructure):
2888         * Plugins/Hosted/ProxyRuntimeObject.h:
2889         (WebKit::ProxyRuntimeObject::createStructure):
2890         * Plugins/Hosted/ProxyRuntimeObject.mm:
2891         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2892         * WebView/WebView.mm:
2893         (aeDescFromJSValue):
2894
2895 2011-02-19  Brian Ryner  <bryner@chromium.org>
2896
2897         Reviewed by Adam Barth.
2898
2899         Add missing #include of DocumentLoader.h, needed since the transitive
2900         include through Document.h is removed.
2901         https://bugs.webkit.org/show_bug.cgi?id=50489
2902
2903         * WebView/WebFrame.mm:
2904
2905 2011-02-19  Charlie Reis  <creis@chromium.org>
2906
2907         Reviewed by Mihai Parparita.
2908
2909         Ensure loading has stopped in HistoryController::goToItem
2910         https://bugs.webkit.org/show_bug.cgi?id=54517
2911
2912         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2913
2914         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2915
2916         * WebCoreSupport/WebFrameLoaderClient.mm:
2917         (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2918         * WebCoreSupport/WebFrameLoaderClient.h:
2919
2920 2011-02-16  David Hyatt  <hyatt@apple.com>
2921
2922         Reviewed by Dan Bernstein.
2923
2924         https://bugs.webkit.org/show_bug.cgi?id=54244
2925         
2926         Convert the line box tree to floating point and eliminate font rounding hacks.  This patch removes all of the rounding
2927         hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
2928         
2929         The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
2930         been changed as well.
2931         
2932         In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
2933         
2934         Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
2935         
2936         Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
2937         still have a precise floating point position.
2938
2939         Justification will now allow subpixel positioning to occur as well.  Platforms that don't support subpixel positioning should already
2940         be rounding justification spacing in their font code.
2941
2942         Many layout test results change on Mac, since rounding hacks were used there and are now gone.
2943
2944         * Misc/WebKitNSStringExtras.mm:
2945         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2946         (-[NSString _web_widthWithFont:]):
2947
2948 2011-02-10  Luiz Agostini  <luiz.agostini@openbossa.org>
2949
2950         Reviewed by Adam Roben.
2951
2952         HTML5 <details> and <summary>: localized text
2953         https://bugs.webkit.org/show_bug.cgi?id=54260
2954
2955         The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2956         provide the default label to be used by a <details> tag that has no <summary> child.
2957
2958         * WebCoreSupport/WebPlatformStrategies.h:
2959         * WebCoreSupport/WebPlatformStrategies.mm:
2960         (WebPlatformStrategies::defaultDetailsSummaryText):
2961
2962 2011-02-16  Matthew Delaney  <mdelaney@apple.com>
2963
2964         Reviewed by Simon Fraser.
2965
2966         Allow acceleratesDrawing for WebKit2
2967         https://bugs.webkit.org/show_bug.cgi?id=54511
2968
2969         Plumb through preference for accelerated drawing.
2970         
2971         * WebView/WebPreferenceKeysPrivate.h:
2972         * WebView/WebPreferences.mm:
2973         (+[WebPreferences initialize]):
2974         (-[WebPreferences acceleratedDrawingEnabled]):
2975         (-[WebPreferences setAcceleratedDrawingEnabled:]):
2976         * WebView/WebPreferencesPrivate.h:
2977
2978 2011-02-15  David Kilzer  <ddkilzer@apple.com>
2979
2980         <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
2981
2982         Reviewed by Darin Adler.
2983
2984         * WebView/WebDynamicScrollBarsView.h:
2985         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
2986         declaration.
2987         * WebView/WebDynamicScrollBarsView.mm:
2988         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
2989         implementation into correct category.
2990         * WebView/WebDynamicScrollBarsViewInternal.h:
2991         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
2992         declaration.
2993         * WebView/WebHTMLView.mm: Included
2994         WebDynamicScrollBarsViewInternal.h instead of
2995         WebDynamicScrollBarsView.h.
2996
2997 2011-02-14  Oliver Hunt  <oliver@apple.com>
2998
2999         Reviewed by Gavin Barraclough and Geoff Garen.
3000
3001         Refactor handles and weak pointers to become nicer and more automatic
3002         https://bugs.webkit.org/show_bug.cgi?id=54415
3003
3004         Update to use Global<> instead of ProtectedPtr, and refactored slightly
3005         to get global data to places it's needed for when we're assigning to
3006         Global<>s
3007
3008         * ForwardingHeaders/collector/handles/Global.h: Added.
3009         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3010         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3011         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
3012         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
3013         (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
3014         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3015         (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
3016         (WebKit::NetscapePluginInstanceProxy::evaluate):
3017         (WebKit::NetscapePluginInstanceProxy::invoke):
3018         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3019         (WebKit::NetscapePluginInstanceProxy::construct):
3020         (WebKit::NetscapePluginInstanceProxy::addValueToArray):
3021         * WebView/WebScriptDebugger.h:
3022         * WebView/WebScriptDebugger.mm:
3023         (WebScriptDebugger::WebScriptDebugger):
3024
3025 2011-02-15  Jia Pu  <jpu@apple.com>
3026
3027         Reviewed by Darin Adler.
3028
3029         Autocorrection should respect undo.
3030         https://bugs.webkit.org/show_bug.cgi?id=52221
3031         <rdar://problem/8663399>
3032
3033         Please see WebCore/ChangeLog for detailed description.
3034
3035         * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
3036
3037         * WebCoreSupport/WebEditorClient.mm:
3038         (WebEditorClient::recordAutocorrectionResponse): Ditto.
3039
3040         * WebView/WebFrame.mm:
3041         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3042              Adopted new signature of ReplaceSelectionCommand::create().
3043
3044 2011-02-15  David Kilzer  <ddkilzer@apple.com>
3045
3046         <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
3047
3048         Reviewed by Darin Adler.
3049
3050         * WebView/WebDynamicScrollBarsView.h:
3051         * WebView/WebDynamicScrollBarsView.mm:
3052         (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
3053         -inProgramaticScroll.
3054         * WebView/WebHTMLView.mm:
3055         (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
3056
3057 2011-02-15  Kenneth Russell  <kbr@google.com>
3058
3059         Reviewed by Darin Fisher.
3060
3061         Allow controlling minimum DOMTimer interval on a per-page basis
3062         https://bugs.webkit.org/show_bug.cgi?id=54312
3063
3064         Added needed methods to implement LayoutTestController's new
3065         setMinimumTimerInterval method.
3066
3067         * WebView/WebView.mm:
3068         (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3069         (+[WebView _defaultMinimumTimerInterval]):
3070         (-[WebView _setMinimumTimerInterval:]):
3071         * WebView/WebViewPrivate.h:
3072
3073 2011-02-11  Geoffrey Garen  <ggaren@apple.com>
3074
3075         Reviewed by Oliver Hunt.
3076
3077         A little more encapsulation for the heap: Removed CollectorHeapIterator
3078         https://bugs.webkit.org/show_bug.cgi?id=54298
3079
3080         * Misc/WebCoreStatistics.mm:
3081         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
3082         (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
3083
3084 2011-02-10  Nate Chapin  <japhet@chromium.org>
3085
3086         Reviewed by Adam Barth.
3087
3088         Update calls to DocumentWriter.
3089         https://bugs.webkit.org/show_bug.cgi?id=50489
3090
3091         * WebView/WebFrame.mm:
3092         (-[WebFrame _canProvideDocumentSource]):
3093
3094 2011-02-10  Chris Fleizach  <cfleizach@apple.com>
3095
3096         Reviewed by Anders Carlsson.
3097
3098         AX: AX needs to stop using WebCoreViewFactory
3099         https://bugs.webkit.org/show_bug.cgi?id=54153
3100
3101         * WebCoreSupport/WebSystemInterface.mm:
3102         (InitWebCoreSystemInterface):
3103
3104 2011-02-10  Peter Varga  <pvarga@webkit.org>
3105
3106         Reviewed by Csaba Osztrogonác.
3107
3108         Remove PCRE source from trunk
3109         https://bugs.webkit.org/show_bug.cgi?id=54188
3110
3111         * ForwardingHeaders/pcre/pcre.h: Removed.
3112
3113 2011-02-09  Pavel Feldman  <pfeldman@chromium.org>
3114
3115         Reviewed by Yury Semikhatsky.
3116
3117         Web Inspector: follow up on InspectorAgent split -
3118         removing unnecessary methods from InspectorController.
3119         https://bugs.webkit.org/show_bug.cgi?id=54093
3120
3121         * WebInspector/WebInspector.mm:
3122         (-[WebInspector showConsole:]):
3123         (-[WebInspector stopProfilingJavaScript:]):
3124
3125 2011-02-08  Dan Bernstein  <mitz@apple.com>
3126
3127         Reviewed by Jon Honeycutt and Maciej Stachowiak.
3128
3129         <rdar://problem/8959420> Find in Mail no longer cycles around
3130
3131         * WebView/WebHTMLView.mm:
3132         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
3133         the wrap option according to the flag.
3134
3135 2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3136
3137         Unreviewed, rolling out r77980.
3138         http://trac.webkit.org/changeset/77980
3139         https://bugs.webkit.org/show_bug.cgi?id=54043
3140
3141         "Crashes on Windows and Linux..." (Requested by leviw on
3142         #webkit).
3143
3144         * WebView/WebFrame.mm:
3145         (-[WebFrame _caretRectAtNode:offset:affinity:]):
3146         * WebView/WebFrameInternal.h:
3147         * WebView/WebTextCompletionController.mm:
3148         (-[WebTextCompletionController doCompletion]):
3149
3150 2011-02-08  Levi Weintraub  <leviw@chromium.org>
3151
3152         Reviewed by Ryosuke Niwa.
3153
3154         Stop instantiating legacy editing Positions in VisiblePosition
3155         https://bugs.webkit.org/show_bug.cgi?id=52919
3156
3157         Changing usage of legacy VisiblePosition constructor. Since we were dealing
3158         with positions from DOM Ranges, we're guaranteed a parent-anchored position.
3159
3160         * WebView/WebFrame.mm:
3161         (-[WebFrame _caretRectAtPosition:affinity:]):
3162         * WebView/WebFrameInternal.h:
3163         * WebView/WebTextCompletionController.mm:
3164         (-[WebTextCompletionController doCompletion]):
3165
3166 2011-02-08  Adam Barth  <abarth@webkit.org>
3167
3168         Reviewed by Eric Seidel.
3169
3170         Remove orphan code from old parser
3171         https://bugs.webkit.org/show_bug.cgi?id=53984
3172
3173         * WebCoreSupport/WebChromeClient.h:
3174
3175 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
3176
3177         Reviewed by Yury Semikhatsky.
3178
3179         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
3180
3181         https://bugs.webkit.org/show_bug.cgi?id=53169
3182
3183         Minor change enforced by major changes in WebCore/inspector/InspectorController.
3184
3185         * WebInspector/WebInspector.mm:
3186         (-[WebInspector isTimelineProfilingEnabled]):
3187
3188 2011-02-07  Enrica Casucci  <enrica@apple.com>
3189
3190         Reviewed Adam Roben and Darin Adler.
3191
3192         WebKit2: drag and drop support on Windows.
3193         https://bugs.webkit.org/show_bug.cgi?id=52775
3194
3195         Removed createDragImageForLink from DragClient.
3196
3197         * WebCoreSupport/WebDragClient.h:
3198         * WebCoreSupport/WebDragClient.mm:
3199         (WebDragClient::startDrag):
3200
3201 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
3202
3203         Reviewed by Pavel Feldman.
3204
3205         Web Inspector: remove settings related methods from InspectorClient
3206         https://bugs.webkit.org/show_bug.cgi?id=53686
3207
3208         * WebCoreSupport/WebInspectorClient.h:
3209         * WebCoreSupport/WebInspectorClient.mm:
3210         (WebInspectorClient::openInspectorFrontend):
3211         (WebInspectorFrontendClient::WebInspectorFrontendClient):
3212
3213 2011-02-03  James Kozianski  <koz@chromium.org>
3214
3215         Reviewed by Dimitri Glazkov.
3216
3217         Add navigator.registerProtocolHandler behind a flag.
3218         https://bugs.webkit.org/show_bug.cgi?id=52609
3219
3220         * Configurations/FeatureDefines.xcconfig:
3221
3222 2011-02-03  Adam Langley  <agl@chromium.org>
3223
3224         Reviewed by Adam Barth.
3225
3226         Plumb mixed script URL to FrameLoaderClient
3227         https://bugs.webkit.org/show_bug.cgi?id=52384
3228
3229         Regressions covered by http/tests/security/mixedContent/*
3230
3231         * WebCoreSupport/WebFrameLoaderClient.h:
3232         * WebCoreSupport/WebFrameLoaderClient.mm:
3233         (WebFrameLoaderClient::didRunInsecureContent):
3234
3235 2011-02-03  Beth Dakin  <bdakin@apple.com>
3236
3237         Reviewed by Sam Weinig.
3238
3239         Fix for <rdar://problem/8944544> Ability to animate track
3240         for WKPainter scrollers
3241
3242         * WebCoreSupport/WebSystemInterface.mm:
3243         (InitWebCoreSystemInterface):
3244
3245 2011-02-02  Mark Rowe  <mrowe@apple.com>
3246
3247         Reviewed by Beth Dakin.
3248
3249         <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
3250
3251         * WebCoreSupport/WebSystemInterface.mm:
3252         (InitWebCoreSystemInterface): Add some missing initializers.
3253
3254 2011-02-02  Steve Lacey  <sjl@chromium.org>
3255
3256         Reviewed by Eric Carlson.
3257
3258         Implement basic media statistics on media elements.
3259         https://bugs.webkit.org/show_bug.cgi?id=53322
3260
3261         * Configurations/FeatureDefines.xcconfig:
3262
3263 2011-02-01  Sam Weinig  <sam@webkit.org>
3264
3265         Reviewed by Beth Dakin.
3266
3267         Part 2 for <rdar://problem/8492788>
3268         Adopt WKScrollbarPainterController
3269
3270         Use header detection to define scrollbar painting controller #define.
3271
3272         * WebCoreSupport/WebSystemInterface.mm:
3273         (InitWebCoreSystemInterface):
3274
3275 2011-02-01  David Hyatt  <hyatt@apple.com>
3276
3277         Reviewed by Oliver Hunt.
3278
3279         https://bugs.webkit.org/show_bug.cgi?id=53520
3280         
3281         Remove the physical terminology from IntRect and FloatRect.
3282         
3283         Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
3284         we need to update our terminology to be more accurate.
3285
3286         I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
3287         renaming right() and bottom() to maxX() and maxY().  These terms remain accurate
3288         even for flipped rectangles.
3289
3290         * WebView/WebHTMLView.mm:
3291         (setNeedsDisplayInRect):
3292
3293 2011-02-01  Beth Dakin  <bdakin@apple.com>
3294
3295         Reviewed by Sam Weinig.
3296
3297         Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
3298
3299         * WebCoreSupport/WebSystemInterface.mm:
3300         (InitWebCoreSystemInterface):
3301
3302 2011-02-01  Dave Hyatt  <hyatt@apple.com>
3303
3304         Reviewed by Darin Adler.
3305
3306         https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
3307         with vertical text.
3308
3309         Change printing functions to check writing-mode and properly swap width and height
3310         as needed.
3311
3312         * WebView/WebDynamicScrollBarsView.mm:
3313         (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
3314         * WebView/WebFrame.mm:
3315         (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
3316         * WebView/WebFrameInternal.h:
3317         * WebView/WebHTMLView.mm:
3318         (-[WebHTMLView _web_setPrintingModeRecursive]):
3319         (-[WebHTMLView _web_clearPrintingModeRecursive]):
3320         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
3321         (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
3322         (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
3323         (-[WebHTMLView _endPrintMode]):
3324         (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
3325         (-[WebHTMLView _endScreenPaginationMode]):
3326         (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3327         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
3328         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
3329         (-[WebHTMLView _scaleFactorForPrintOperation:]):
3330         (-[WebHTMLView setPageWidthForPrinting:]):
3331         (-[WebHTMLView knowsPageRange:]):
3332
3333 2011-01-31  Oliver Hunt  <oliver@apple.com>
3334
3335         Convert markstack to a slot visitor API
3336         https://bugs.webkit.org/show_bug.cgi?id=53219
3337
3338         rolling r77098, r77099, r77100, r77109, and
3339         r77111 back in, along with a few more Qt fix attempts.
3340
3341         * WebView/WebScriptDebugDelegate.mm:
3342         (-[WebScriptCallFrame scopeChain]):
3343
3344 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
3345
3346         Unreviewed, rolling out r77098, r77099, r77100, r77109, and
3347         r77111.
3348         http://trac.webkit.org/changeset/77098
3349         http://trac.webkit.org/changeset/77099
3350         http://trac.webkit.org/changeset/77100
3351         http://trac.webkit.org/changeset/77109
3352         http://trac.webkit.org/changeset/77111
3353         https://bugs.webkit.org/show_bug.cgi?id=53219
3354
3355         Qt build is broken
3356
3357         * WebView/WebScriptDebugDelegate.mm:
3358         (-[WebScriptCallFrame scopeChain]):
3359
3360 2011-01-30  Oliver Hunt  <oliver@apple.com>
3361
3362         Convert markstack to a slot visitor API
3363         https://bugs.webkit.org/show_bug.cgi?id=53219
3364
3365         rolling r77006 and r77020 back in.
3366
3367         * WebView/WebScriptDebugDelegate.mm:
3368         (-[WebScriptCallFrame scopeChain]):
3369
3370 2011-01-28  Geoffrey Garen  <ggaren@apple.com>
3371
3372         Reviewed by Maciej Stachowiak.
3373
3374         Some more Heap cleanup.
3375         https://bugs.webkit.org/show_bug.cgi?id=53357
3376
3377         Updated for JavaScriptCore changes.
3378
3379         * Misc/WebCoreStatistics.mm:
3380         (+[WebCoreStatistics memoryStatistics]):
3381
3382 2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3383
3384         Unreviewed, rolling out r77006 and r77020.
3385         http://trac.webkit.org/changeset/77006
3386         http://trac.webkit.org/changeset/77020
3387         https://bugs.webkit.org/show_bug.cgi?id=53360
3388
3389         "Broke Windows tests" (Requested by rniwa on #webkit).
3390
3391         * WebView/WebScriptDebugDelegate.mm:
3392         (-[WebScriptCallFrame scopeChain]):
3393
3394 2011-01-27  Oliver Hunt  <oliver@apple.com>
3395
3396         Reviewed by Geoffrey Garen.
3397
3398         Convert markstack to a slot visitor API
3399         https://bugs.webkit.org/show_bug.cgi?id=53219
3400
3401         Update to new marking api
3402
3403         * WebView/WebScriptDebugDelegate.mm:
3404         (-[WebScriptCallFrame scopeChain]):
3405
3406 2011-01-28  Dan Bernstein  <mitz@apple.com>
3407
3408         Reviewed by Sam Weinig.
3409
3410         <select> can't display right-to-left (rtl) languages
3411         https://bugs.webkit.org/show_bug.cgi?id=19785
3412
3413         * WebCoreSupport/WebChromeClient.h:
3414         * WebCoreSupport/WebChromeClient.mm:
3415         (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
3416         (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
3417
3418 2011-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3419
3420         Unreviewed, rolling out r76891.
3421         http://trac.webkit.org/changeset/76891
3422         https://bugs.webkit.org/show_bug.cgi?id=53280
3423
3424         Makes every layout test crash (Requested by othermaciej on
3425         #webkit).
3426
3427         * Misc/WebIconDatabase.mm:
3428         (-[ThreadEnabler threadEnablingSelector:]):
3429         (importToWebCoreFormat):
3430
3431 2011-01-27  Nate Chapin  <japhet@chromium.org>
3432
3433         Reviewed by Adam Barth.
3434
3435         Use Document::url() instead of FrameLoader::url().
3436         https://bugs.webkit.org/show_bug.cgi?id=41165
3437
3438         * WebView/WebView.mm:
3439         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
3440
3441 2011-01-27  Dan Bernstein  <mitz@apple.com>
3442
3443         Rubber-stamped by Anders Carlsson.
3444
3445         Reverted an accidental change in r76561.
3446
3447         * WebView/WebHTMLView.mm:
3448
3449 2011-01-26  David Kilzer  <ddkilzer@apple.com>
3450
3451         <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
3452         <rdar://problem/8821760>
3453
3454         Reviewed by Antti Koivisto.
3455
3456         * WebCoreSupport/WebSystemInterface.mm:
3457         (InitWebCoreSystemInterface): Added initialization for
3458         GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
3459
3460 2011-01-26  Beth Dakin  <bdakin@apple.com>
3461
3462         Reviewed by Darin Adler.
3463
3464         Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics 
3465         when using WKScrollbars.
3466
3467         * WebCoreSupport/WebSystemInterface.mm:
3468         (InitWebCoreSystemInterface):
3469
3470 2011-01-25  Darin Adler  <darin@apple.com>
3471
3472         Reviewed by Anders Carlsson.
3473
3474         WebKit is using CSBackupSetItemExcluded incorrectly
3475         https://bugs.webkit.org/show_bug.cgi?id=53095
3476         rdar://problem/8790540
3477
3478         * Misc/WebIconDatabase.mm:
3479         (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
3480         It was incorrect, and this responsibility has been moved to WebCore.
3481
3482 2011-01-24  Chris Marrin  <cmarrin@apple.com>
3483
3484         Reviewed by Eric Seidel.
3485
3486         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
3487         https://bugs.webkit.org/show_bug.cgi?id=53041
3488
3489         * Configurations/FeatureDefines.xcconfig:
3490
3491 2011-01-25  Yury Semikhatsky  <yurys@chromium.org>
3492
3493         Reviewed by Pavel Feldman.
3494
3495         Web Inspector: remove "attached" state related methods from InspectorAgent
3496         https://bugs.webkit.org/show_bug.cgi?id=53086
3497
3498         * WebCoreSupport/WebInspectorClient.h:
3499         * WebCoreSupport/WebInspectorClient.mm:
3500         (-[WebInspectorWindowController showWindow:]):
3501         (-[WebInspectorWindowController attach]):
3502         (-[WebInspectorWindowController detach]):
3503
3504 2011-01-23  Dan Bernstein  <mitz@apple.com>
3505
3506         Reviewed by John Sullivan.
3507
3508         <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
3509
3510         * WebCoreSupport/WebChromeClient.mm:
3511         (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
3512
3513 2011-01-22  Alexey Proskuryakov  <ap@apple.com>
3514
3515         Reviewed by Darin Adler.
3516
3517         https://bugs.webkit.org/show_bug.cgi?id=52473
3518         Auto-scaling to avoid orphans is broken, remove dysfunctional code
3519
3520         * WebView/WebHTMLView.mm:
3521         (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
3522         (-[WebHTMLView _scaleFactorForPrintOperation:]):
3523         (-[WebHTMLView knowsPageRange:]):
3524
3525 2011-01-21  Mark Rowe  <mrowe@apple.com>
3526
3527         Rubber-stamped by Jon Honeycutt.
3528
3529         Fix the build when using Clang by removing some unused variables.
3530
3531         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3532         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3533         * WebView/WebFullScreenController.mm:
3534         (-[WebFullScreenController enterFullscreen:]):
3535         (-[WebFullScreenController exitFullscreen]):
3536
3537 2011-01-21  Chris Rogers  <crogers@google.com>
3538
3539         Reviewed by Darin Fisher.
3540
3541         Add run-time enable support for the web audio API
3542         https://bugs.webkit.org/show_bug.cgi?id=52741
3543
3544         * WebView/WebPreferenceKeysPrivate.h:
3545         * WebView/WebPreferences.mm:
3546         (-[WebPreferences webAudioEnabled]):
3547         (-[WebPreferences setWebAudioEnabled:]):
3548         * WebView/WebPreferencesPrivate.h:
3549         * WebView/WebView.mm:
3550         (-[WebView _preferencesChangedNotification:]):
3551
3552 2011-01-20  John Sullivan  <sullivan@apple.com>
3553
3554         Reviewed by Mark Rowe.
3555
3556         Shift-tab doesn't cycle through fields in http authentication panel
3557         https://bugs.webkit.org/show_bug.cgi?id=52850
3558
3559         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
3560         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
3561         Re-wired the key loop so that there aren't two views with the same nextKeyView.
3562
3563 2011-01-20  Beth Dakin  <bdakin@apple.com>
3564
3565         Reviewed by Geoffrey Garen.
3566
3567         Fix for <rdar://problem/8890255>
3568
3569         Allow WebKitSystemInterface to draw scrollbars 
3570         when appropriate.
3571         * WebCoreSupport/WebSystemInterface.mm:
3572         (InitWebCoreSystemInterface):
3573
3574 2011-01-19  Simon Fraser  <simon.fraser@apple.com>
3575
3576         Reviewed by Sam Weinig.
3577
3578         GraphicsLayers in subframes can get sync'd multiple times
3579         https://bugs.webkit.org/show_bug.cgi?id=52489
3580
3581         * WebView/WebView.mm:
3582         (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
3583         was renamed to syncCompositingStateIncludingSubframes().
3584
3585 2011-01-19  Darin Adler  <darin@apple.com>
3586
3587         Reviewed by Sam Weinig.
3588
3589         Would like script debugging protocol method to differentiate between caught and uncaught exceptions
3590         https://bugs.webkit.org/show_bug.cgi?id=52104
3591         rdar://problem/8704226
3592
3593         * WebView/WebDelegateImplementationCaching.h:
3594         Fix type of second integer in CallScriptDebugDelegate function overload
3595         to be int to match the actual Objective-C method. Added a new overload
3596         that includes a BOOL in the right place. Added a boolean named
3597         exceptionWasRaisedExpectsHasHandlerFlag.
3598
3599         * WebView/WebDelegateImplementationCaching.mm:
3600         (CallDelegate): Added overloads as above.
3601         (CallScriptDebugDelegate): Ditto.
3602
3603         * WebView/WebScriptDebugDelegate.h: Added new method with the additional
3604         boolean argument. Marked the old method informally deprecated.
3605
3606         * WebView/WebScriptDebugger.mm:
3607         (WebScriptDebugger::exception): Added code to call with or without the
3608         boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
3609
3610         * WebView/WebView.mm:
3611         (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
3612         exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
3613         guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
3614
3615 2011-01-19  Tony Gentilcore  <tonyg@chromium.org>
3616
3617         Reviewed by Mihai Parparita.
3618
3619         Perform some forward declaration
3620         https://bugs.webkit.org/show_bug.cgi?id=52522
3621
3622         * Misc/WebKitNSStringExtras.mm:
3623
3624 2011-01-19  Pavel Podivilov  <podivilov@chromium.org>
3625
3626         Reviewed by Yury Semikhatsky.
3627
3628         Web Inspector: [JSC] scripts have incorrect starting line (always 1).
3629         https://bugs.webkit.org/show_bug.cgi?id=52721
3630
3631         * WebView/WebScriptDebugger.h:
3632         * WebView/WebScriptDebugger.mm:
3633         (toNSString):
3634         (WebScriptDebugger::sourceParsed):
3635
3636 2011-01-19  Levi Weintraub  <leviw@google.com>
3637
3638         Reviewed by Ryosuke Niwa.
3639
3640         Updating to use Position::parentAnchoredEquivalent instead of
3641         the old htmlediting rangeCompliantEquivalent.
3642
3643         remove rangeCompliantEquivalent and replace it with Position methods
3644         https://bugs.webkit.org/show_bug.cgi?id=25057
3645
3646         * WebView/WebFrame.mm:
3647         (-[WebFrame _smartDeleteRangeForProposedRange:]):
3648
3649 2011-01-18  Chris Fleizach  <cfleizach@apple.com>
3650
3651         Reviewed by Darin Adler.
3652
3653         REGRESSION: A problem with Voiceover and finding links
3654         https://bugs.webkit.org/show_bug.cgi?id=52324
3655
3656         * WebView/WebDynamicScrollBarsView.mm:
3657         (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
3658
3659 2011-01-17  David Kilzer  <ddkilzer@apple.com>
3660
3661         <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
3662
3663         Reviewed by Dan Bernstein.
3664
3665         * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
3666         DOMDocumentPrivate.h to the PrivateHeaders directory.
3667
3668 2011-01-17  Enrica Casucci  <enrica@apple.com>
3669
3670         Reviewed by Alexey Proskuryakov.
3671
3672         Drag and drop support: refactoring of image from link and image from selection
3673         https://bugs.webkit.org/show_bug.cgi?id=52496
3674
3675         This work cleans up the Mac code and makes it more similar to the Windows implementation,
3676         avoiding the use of an NSView when the FrameView can be used.
3677         The refactoring is a necessary step towards the complete support of drag and drop
3678         in WebKit2.
3679
3680         * WebCoreSupport/WebDragClient.mm:
3681         (WebDragClient::createDragImageForLink): Added.
3682         * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
3683         * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
3684
3685 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
3686
3687         Reviewed by Yury Semikhatsky.
3688
3689         Web Inspector: simplify debugger enabling routine.
3690         https://bugs.webkit.org/show_bug.cgi?id=52472
3691
3692         * WebInspector/WebInspector.mm:
3693         (-[WebInspector startDebuggingJavaScript:]):
3694
3695 2011-01-16  Dan Bernstein  <mitz@apple.com>
3696
3697         Reviewed by Simon Fraser.
3698
3699         Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
3700         https://bugs.webkit.org/show_bug.cgi?id=52550
3701
3702         * Plugins/WebNetscapePluginView.mm:
3703         (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
3704         that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
3705
3706 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
3707
3708         Reviewed by Dan Bernstein.
3709
3710         Issues with iframes and plugins when the WebView is scaled.
3711         <rdar://problem/6213380>
3712         
3713         When _scaleWebView has been called on a WebView, iframes
3714         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
3715         This is caused by AppKit NSViews not playing nicely with the scale
3716         applied through style.
3717         
3718         Work around most of these issues by adjusting the bounds size
3719         of widgets to allow iframe contents to paint with the correct scale,
3720         and fix various places in the code where we relied on coordinate
3721         transforms via NSViews (which ignore CSS transforms).
3722
3723         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3724         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3725         * WebView/WebFrameView.mm:
3726         (-[WebFrameView setBoundsSize:]):
3727
3728 2011-01-16  Beth Dakin  <bdakin@apple.com>
3729
3730         Reviewed by Kevin Decker.
3731
3732         Fix for <rdar://problem/8871204>
3733
3734         Don't try to save elasticity state. Just rely on
3735         NSScrollElasticityAutomatic to restore the correct state.
3736         * WebCoreSupport/WebFrameLoaderClient.h:
3737         * WebCoreSupport/WebFrameLoaderClient.mm:
3738         (WebFrameLoaderClient::WebFrameLoaderClient):
3739         (WebFrameLoaderClient::dispatchDidFirstLayout):
3740         (WebFrameLoaderClient::provisionalLoadStarted):
3741
3742 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
3743
3744         Reviewed by Dan Bernstein.
3745
3746         Plugins render incorrectly with transformed ancestors
3747         https://bugs.webkit.org/show_bug.cgi?id=52507
3748         
3749         -[NSView visibleRect] gives the wrong answer if there are CSS transforms
3750         in the ancestor chain of a plugin.
3751         
3752         So use of this method with calls to -actualVisibleRectInWindow, which
3753         maps rects through the render tree to compute the correct rect,
3754         clipping via windowClipRect() if necessary.
3755         
3756         Not testable, because doing so relies on the behavior of some
3757         plugins, which stop rendering if setWindow passes an empty rect.
3758
3759         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3760         (-[WebHostedNetscapePluginView updateAndSetWindow]):
3761         * Plugins/WebBaseNetscapePluginView.h:
3762         * Plugins/WebBaseNetscapePluginView.mm:
3763         (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
3764         * Plugins/WebNetscapePluginView.mm:
3765         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3766
3767 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
3768
3769         Reviewed by Antti Koivisto.
3770
3771         Rename cache() to memoryCache()
3772         https://bugs.webkit.org/show_bug.cgi?id=52433
3773
3774         * Misc/WebCache.mm:
3775         (+[WebCache statistics]):
3776         (+[WebCache setDisabled:]):
3777         (+[WebCache isDisabled]):
3778         * WebView/WebView.mm:
3779         (+[WebView _setCacheModel:]):
3780
3781 2011-01-13  Geoffrey Garen  <ggaren@apple.com>
3782
3783         Reviewed by Oliver Hunt.
3784
3785         Split out a MarkedSpace strategy object from Heap.
3786         https://bugs.webkit.org/show_bug.cgi?id=52421
3787
3788         * Misc/WebCoreStatistics.mm:
3789         (+[WebCoreStatistics memoryStatistics]): Updated for class move.
3790
3791 2011-01-14  Dan Bernstein  <mitz@apple.com>
3792
3793         Reviewed by Simon Fraser.
3794
3795         WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
3796
3797         * WebView/WebHTMLView.mm:
3798         (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
3799         to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
3800         that the NSView tree doesn’t change from under AppKit as it traverses it.
3801
3802 2011-01-14  Beth Dakin  <bdakin@apple.com>
3803
3804         Reviewed by Mark Rowe.
3805
3806         Fix for <rdar://problem/7793902> Artifacts when scrolling
3807         page in Safari while page is loading
3808
3809         Call setDrawsBackground:YES on the scrollView in 
3810         dispatchDidFirstLayout() rather than waiting until
3811         frameLoadCompleted(). Also suspend scrolling elasticity
3812         between provisionalLoadStarted() and dispatchDidFirstLayout()
3813         * WebCoreSupport/WebFrameLoaderClient.h:
3814         * WebCoreSupport/WebFrameLoaderClient.mm:
3815         (WebFrameLoaderClient::WebFrameLoaderClient):
3816         (WebFrameLoaderClient::dispatchDidFirstLayout):
3817         (WebFrameLoaderClient::provisionalLoadStarted):
3818
3819 2011-01-12  Enrica Casucci  <enrica@apple.com>
3820
3821         Reviewed by Darin Adler.
3822
3823         WebKit2: Add support for drag and drop
3824         https://bugs.webkit.org/show_bug.cgi?id=52343
3825         <rdar://problem/7660558>
3826         
3827         The DragData class has been extended to provide
3828         additional context from the application (keyboard state, modal windows, etc.)
3829         as well as information of the drag pasteboard being used.
3830         These are the changes to align the behavior for WebKit.
3831
3832         * WebView/WebView.mm:
3833         (-[WebView applicationFlags:]): Added.
3834         (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
3835         (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
3836         (-[WebView draggingExited:]): Added parameter to the DragData constructor.
3837         (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
3838
3839 2011-01-12  Beth Dakin  <bdakin@apple.com>
3840
3841         Reviewed by Anders Carlsson.
3842
3843         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 
3844         Expose fixed layout through WebKit SPI
3845         -and corresponding-
3846         <rdar://problem/8844464>
3847
3848         And now with getters!
3849         * WebView/WebView.mm:
3850         (-[WebView _useFixedLayout]):
3851         (-[WebView _fixedLayoutSize]):
3852         * WebView/WebViewPrivate.h:
3853
3854 2011-01-12  Beth Dakin  <bdakin@apple.com>
3855
3856         Reviewed by Anders Carlsson.
3857
3858         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
3859         fixed layout through WebKit SPI
3860         -and corresponding-
3861         <rdar://problem/8844464>
3862
3863         * WebView/WebView.mm:
3864         (-[WebView _setUseFixedLayout:]):
3865         (-[WebView _setFixedLayoutSize:]):
3866         * WebView/WebViewPrivate.h:
3867
3868 2011-01-07  Enrica Casucci  <enrica@apple.com>
3869
3870         Reviewed by Alexey Proskuryakov.
3871
3872         Paste and drag and drop use different code paths to interact with the pasteboard.
3873         https://bugs.webkit.org/show_bug.cgi?id=52093
3874         The change consists in a refactoring of the code to have only one class that
3875         deals with the pasteboard on Mac.
3876
3877         * WebCoreSupport/WebEditorClient.h:
3878         * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
3879         exposed by NSURLExtras.
3880         (WebEditorClient::canonicalizeURL):
3881         (WebEditorClient::canonicalizeURLString):
3882         * WebCoreSupport/WebPasteboardHelper.h: Removed.
3883         * WebCoreSupport/WebPasteboardHelper.mm: Removed.
3884         * WebView/WebHTMLView.mm: Removed comment.
3885         * WebView/WebView.mm: The following methods have been changed to use the new DragData
3886         constructor that doesn't use the WebPasteboardHelper reference.
3887         (-[WebView draggingEntered:]):
3888         (-[WebView draggingUpdated:]):
3889         (-[WebView draggingExited:]):
3890         (-[WebView performDragOperation:]):
3891
3892 2011-01-09  Tony Gentilcore  <tonyg@chromium.org>
3893
3894         Reviewed by Alexey Proskuryakov.
3895
3896         Forward declare some headers where possible
3897         https://bugs.webkit.org/show_bug.cgi?id=52133
3898
3899         * WebView/WebFrame.mm:
3900
3901 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3902
3903         Reviewed by Darin Fisher.
3904
3905         https://bugs.webkit.org/show_bug.cgi?id=41441
3906         createWindow method should only do window-creating without URL navigation
3907
3908         * WebCoreSupport/WebChromeClient.mm:
3909         (WebChromeClient::createWindow):
3910
3911 2011-01-08  Dan Bernstein  <mitz@apple.com>
3912
3913         Try to fix the Leopard build.
3914
3915         * WebView/WebFullScreenController.mm:
3916
3917 2011-01-07  Jer Noble  <jer.noble@apple.com>
3918
3919         Yet another Leopard build fix: NSRect and CGRect are not inter-
3920         changable in 32-bit.  
3921         
3922         * WebView/WebFullScreenController.mm:
3923         (-[WebFullScreenController exitFullscreen]):
3924
3925 2011-01-07  Jer Noble  <jer.noble@apple.com>
3926
3927         Fix the Leopard build: Replace CoreAnimation SL-only functions
3928         with Leopard equivalents.
3929
3930         * WebView/WebFullScreenController.mm:
3931         (+[CATransaction setDisableActions:]):
3932         (+[CATransaction setAnimationDuration:]):
3933         (-[WebFullScreenController _animationDuration]):
3934         (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
3935
3936 2010-12-21  Jer Noble  <jer.noble@apple.com>
3937
3938         Reviewed by Simon Fraser.
3939
3940         Implement WebKit Full Screen support.
3941         https://bugs.webkit.org/show_bug.cgi?id=49481
3942         rdar://problem/8247444
3943
3944         Support the new fullscreen Chrome client requests.  WebView will pass
3945         through these requests to a WebFullscreenController.
3946
3947         * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
3948         * WebView/WebView.mm:
3949         (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
3950         (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
3951         (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
3952         (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
3953         * WebView/WebViewData.h: Add ivar newFullscreenController.
3954
3955 2010-12-17  Jer Noble  <jer@kokode.apple.com>
3956
3957         Reviewed by Simon Fraser.
3958
3959         Implement WebKit Full Screen support.
3960         https://bugs.webkit.org/show_bug.cgi?id=49481
3961         rdar://problem/8247444
3962         
3963         This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
3964         Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
3965         window, and a custom CAAnimation animates that layer between the initial screen rect of the
3966         full screen element, to its final value. WebFullscreenController will swap the WebView out of
3967         its original window, and into the fullscreen window. The controller will replace the WebView
3968         with a placeholder view, so that if the placeholder moves or resized while the WebView is
3969         absent, the WebView will move back to the correct location when exiting fullscreen.
3970
3971         * WebView/WebFullscreenController.h: Added.
3972         * WebView/WebFullscreenController.mm: Added.
3973         (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
3974         (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window. 
3975         (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
3976         (-[WebFullscreenController applicationDidResignActive:]):
3977         (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
3978             the new screen parameters.
3979         (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
3980             from its original screen rect into fullscreen.
3981         (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
3982             Set up the animation that will take the fullscreen element back into its original screen
3983             rect.
3984         (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine 
3985             whether to disable screensaver and sleep.
3986         (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
3987             looking for HTMLVideoElements; returns whether any are found to be playing.
3988         (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
3989             and shift keys.
3990         (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
3991         (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
3992         (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
3993         (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
3994         (-[WebFullscreenWindow setRendererLayer:]): Ditto.
3995         (-[WebFullscreenWindow backgroundLayer]): Ditto.
3996         (-[WebFullscreenWindow animationView]): Ditto.
3997         (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
3998         (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
3999         
4000 2011-01-07  James Robinson  <jamesr@chromium.org>
4001
4002         Revert "Implement mozilla's animationTime property"
4003         https://bugs.webkit.org/show_bug.cgi?id=51952
4004
4005         This approach isn't quite right.
4006
4007         * WebView/WebHTMLView.mm:
4008         (-[WebHTMLView drawRect:]):
4009         * WebView/WebView.mm:
4010         (layerSyncRunLoopObserverCallBack):
4011
4012 2011-01-06  Gavin Barraclough  <barraclough@apple.com>
4013
4014         Reviewed by Geoff Garen.
4015
4016         Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
4017
4018         The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
4019         destructor early, in order to release wrappers once we know we no longer intend to use them.
4020         Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
4021         lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
4022         A sequence of events that triggers the bug would look like this:
4023
4024         (1) Create a DOMWrapperWorld.
4025         (2) Register a timer in the world.
4026         (3) Call unregisterWorld() on the world.
4027         (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
4028         (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
4029             called forgetWorld() none exists.
4030         (6) Attempt to add a wrapper to a NULL map.
4031
4032         Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
4033
4034         * WebView/WebScriptWorld.mm:
4035         (-[WebScriptWorld unregisterWorld]):
4036
4037 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4038
4039         Reviewed by Sam Weinig.
4040
4041         WK2: Support Accessibility
4042         https://bugs.webkit.org/show_bug.cgi?id=51859
4043
4044         Use rootObject() method to get top of AX tree.
4045
4046         * WebCoreSupport/WebFrameLoaderClient.h:
4047         (WebFrameLoaderClient::accessibilityRemoteObject):
4048         * WebView/WebFrame.mm:
4049         (-[WebFrame setAccessibleName:]):
4050         (-[WebFrame accessibilityRoot]):
4051         * WebView/WebFrameInternal.h:
4052         * WebView/WebFramePrivate.h:
4053         * WebView/WebHTMLView.mm:
4054         (-[WebHTMLView accessibilityAttributeValue:]):
4055         (-[WebHTMLView accessibilityFocusedUIElement]):
4056         (-[WebHTMLView accessibilityHitTest:]):
4057         (-[WebHTMLView _accessibilityParentForSubview:]):
4058
4059 2011-01-04  David Kilzer  <ddkilzer@apple.com>
4060
4061         <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
4062
4063         Reviewed by Eric Carlson.
4064
4065         This originally broke in r61581.  It is inside an
4066         ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
4067         build then.
4068
4069         * WebCoreSupport/WebFrameLoaderClient.mm: Call
4070         (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
4071         use WebCore::PluginInfo.name instead of
4072         -[WebBasePluginPackage name].
4073
4074 2011-01-02  Dan Bernstein  <mitz@apple.com>
4075
4076         Rubber-stamped by Simon Fraser.
4077
4078         <rdar://problem/8812159> Update copyright strings
4079
4080         * Info.plist:
4081
4082 2010-12-29  Dan Bernstein  <mitz@apple.com>
4083
4084         Reviewed by Ada Chan.
4085
4086         <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
4087         https://bugs.webkit.org/show_bug.cgi?id=51717
4088
4089         Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
4090         protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
4091
4092         * WebView/WebDocumentInternal.h:
4093         * WebView/WebHTMLView.mm:
4094         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
4095         (-[WebHTMLView _findString:options:]):
4096         * WebView/WebView.mm:
4097         (findString):
4098
4099 2010-12-28  Daniel Bates  <dbates@rim.com>
4100
4101         Reviewed by Sam Weinig.
4102
4103         Substitute // MARK: for compiler-specific #pragma mark
4104         https://bugs.webkit.org/show_bug.cgi?id=51657
4105
4106         For consistency, we should substitute "// MARK:" for compiler-
4107         specific "#pragma mark" in the source files for the Mac port.
4108
4109         * History/WebHistory.mm:
4110         * Plugins/WebBaseNetscapePluginView.mm:
4111         * Plugins/WebNetscapePluginView.mm:
4112         * WebCoreSupport/WebInspectorClient.mm:
4113         * WebCoreSupport/WebSecurityOrigin.mm:
4114         * WebView/WebPDFView.mm:
4115         * WebView/WebVideoFullscreenController.mm:
4116         * WebView/WebVideoFullscreenHUDWindowController.mm:
4117
4118 2010-12-23  Yongjun Zhang  <yongjun_zhang@apple.com>
4119
4120         Reviewed by Darin Adler.
4121
4122         WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
4123         https://bugs.webkit.org/show_bug.cgi?id=38535
4124
4125         WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram.  As a result,
4126         if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
4127         WebScriptDebugger's callframe stack is wrong from this point.  That could cause crash if we trying to access the top
4128         call frame from this stack when an exception throws because the saved top frame could be invalid.
4129
4130         To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
4131         callEvent and returnEvent.
4132
4133         * WebView/WebScriptDebugger.mm:
4134         (WebScriptDebugger::willExecuteProgram):
4135         (WebScriptDebugger::didExecuteProgram):
4136
4137 2010-12-22  Sam Weinig  <sam@webkit.org>
4138
4139         Reviewed by Darin Adler.
4140
4141         WebKit2 needs to mirror the frame tree in the UIProcess
4142         https://bugs.webkit.org/show_bug.cgi?id=51546
4143
4144         - Add client functions to notify that a frame has been added or
4145           removed from the page cache.
4146
4147         * WebCoreSupport/WebFrameLoaderClient.h:
4148         * WebCoreSupport/WebFrameLoaderClient.mm:
4149         (WebFrameLoaderClient::didSaveToPageCache):
4150         (WebFrameLoaderClient::didRestoreFromPageCache):
4151
4152 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
4153
4154         Reviewed by Eric Seidel.
4155
4156         Editor.h doesn't need to include SelectionController.h
4157         https://bugs.webkit.org/show_bug.cgi?id=51441
4158
4159         Renamed SelectionController::EDirection to SelectionDirection.
4160
4161         * WebView/WebFrame.mm:
4162         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
4163         Takes SelectionDirection instead of SelectionController::EDirection.
4164         * WebView/WebFrameInternal.h:
4165         * WebView/WebTextCompletionController.mm:
4166         (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
4167
4168 2010-12-22  Simon Fraser  <simon.fraser@apple.com>
4169
4170         Reviewed by Darin Adler.
4171
4172         Cache snapshots of plug-ins before painting, to avoid script running during painting
4173         https://bugs.webkit.org/show_bug.cgi?id=51493
4174
4175         When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
4176         or when printing), plug-ins which otherwise use the CA rendering model