[Mac] Allow popup menus to override default appearance
[WebKit-https.git] / Source / WebKit / mac / ChangeLog
1 2014-05-20  Dean Jackson  <dino@apple.com>
2
3         [Mac] Allow popup menus to override default appearance
4         https://bugs.webkit.org/show_bug.cgi?id=133129
5
6         Reviewed by Tim Horton.
7
8         Replace the call to wkPopupMenuWithSize with wkPopupMenu, now
9         with extra parameters to indicate the control size and whether
10         or not to draw the arrows at the end.
11
12         * WebCoreSupport/PopupMenuMac.mm:
13         (PopupMenuMac::show):
14
15 2014-05-20  Eric Carlson  <eric.carlson@apple.com>
16
17         [Mac] do not deactivate an audio session that has running I/O
18         https://bugs.webkit.org/show_bug.cgi?id=133127
19
20         Reviewed by Jer Noble.
21
22         * WebView/WebView.mm:
23         (-[WebView _commonInitializationWithFrameName:groupName:]): Settings::setShouldManageAudioSession
24             renamed to setShouldManageAudioSessionCategory, deal with it.
25
26 2014-05-19  Brady Eidson  <beidson@apple.com>
27
28         Use different AppKit API for image control menus.
29         <rdar://problem/16807828> and https://bugs.webkit.org/show_bug.cgi?id=133087
30
31         Reviewed by Tim Horton.
32
33         For image control menus, use popUpMenuPositioningItem: instead of popUpContextMenu:
34         
35         * WebCoreSupport/WebContextMenuClient.h:
36         * WebCoreSupport/WebContextMenuClient.mm:
37         (WebContextMenuClient::contextMenuForEvent):
38         (WebContextMenuClient::showContextMenu):
39
40 2014-05-19  Andy Estes  <aestes@apple.com>
41
42         Set WebKitSuppressesIncrementalRenderingKey to NO by default on both Mac and iOS
43         https://bugs.webkit.org/show_bug.cgi?id=133073
44
45         Reviewed by Simon Fraser.
46
47         * WebView/WebPreferences.mm:
48         (+[WebPreferences initialize]):
49
50 2014-05-18  Anders Carlsson  <andersca@apple.com>
51
52         Bring back two NSString category methods on iOS
53         https://bugs.webkit.org/show_bug.cgi?id=133055
54         <rdar://problem/16951983>
55
56         Reviewed by Adele Peterson.
57
58         * Misc/WebNSURLExtras.h:
59         * Misc/WebNSURLExtras.mm:
60         (-[NSString _webkit_unescapedQueryValue]):
61         (-[NSString _webkit_queryKeysAndValues]):
62
63 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
64
65         support for navigator.hardwareConcurrency
66         https://bugs.webkit.org/show_bug.cgi?id=132588
67
68         Reviewed by Filip Pizlo.
69
70         * Configurations/FeatureDefines.xcconfig:
71
72 2014-05-17  Zalan Bujtas  <zalan@apple.com>
73
74         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
75         https://bugs.webkit.org/show_bug.cgi?id=133029
76
77         Reviewed by Simon Fraser.
78
79         To match the WK2 preferences API.
80
81         * WebView/WebPreferenceKeysPrivate.h:
82         * WebView/WebPreferences.mm:
83         (+[WebPreferences initialize]):
84         (-[WebPreferences subpixelCSSOMElementMetricsEnabled]):
85         (-[WebPreferences setSubpixelCSSOMElementMetricsEnabled:]):
86         * WebView/WebPreferencesPrivate.h:
87         * WebView/WebView.mm:
88         (-[WebView _preferencesChanged:]):
89
90 2014-05-16  Simon Fraser  <simon.fraser@apple.com>
91
92         Remove "region-based columns" prefs
93         https://bugs.webkit.org/show_bug.cgi?id=133006
94         <rdar://problem/16945824>
95
96         Reviewed by Dave Hyatt.
97
98         Remove "region-based columns" prefs and related code, since this is only
99         way to render columns now.
100
101         * WebView/WebPreferenceKeysPrivate.h:
102         * WebView/WebPreferences.mm:
103         (+[WebPreferences initialize]):
104         (-[WebPreferences setRegionBasedColumnsEnabled:]): Deleted.
105         (-[WebPreferences regionBasedColumnsEnabled]): Deleted.
106         * WebView/WebPreferencesPrivate.h:
107         * WebView/WebView.mm:
108         (-[WebView _preferencesChanged:]):
109
110 2014-05-15  Brady Eidson  <beidson@apple.com>
111
112         Crash in [WebSharingServicePickerController clear]
113         <rdar://problem/16879073> and https://bugs.webkit.org/show_bug.cgi?id=132968
114
115         Reviewed by Tim Horton.
116
117         * Misc/WebSharingServicePickerController.mm:
118         (-[WebSharingServicePickerController clear]): Add a RetainPtr protector so this object
119           isn’t dealloc’ed partway through.
120
121 2014-05-15  Simon Fraser  <simon.fraser@apple.com>
122
123         Initialize the WebKitRegionBasedColumnsEnabled pref on iOS WK1
124         https://bugs.webkit.org/show_bug.cgi?id=132969
125
126         Reviewed by Dan Bernstein.
127         
128         Move this outside the #if !PLATFORM(IOS) block.
129
130         * WebView/WebPreferences.mm:
131         (+[WebPreferences initialize]):
132
133 2014-05-15  Simon Fraser  <simon.fraser@apple.com>
134
135         Clean up -[WebView _preferencesChanged]
136         https://bugs.webkit.org/show_bug.cgi?id=132967
137
138         Reviewed by Sam Weinig.
139         
140         -[WebView _preferencesChanged] was a horrible mess of #ifdefs. Clean this up by
141         moving all the #if PLATFORM() code together, and moving all the feature-define related
142         settings to the end.
143         
144         No behavior changes, checked by diffing the resulting Settings with and without
145         the patch, on OS X and iOS.
146
147         * WebView/WebView.mm:
148         (-[WebView _preferencesChanged:]):
149
150 2014-05-15  Alex Christensen  <achristensen@webkit.org>
151
152         Add pointer lock to features without enabling it.
153         https://bugs.webkit.org/show_bug.cgi?id=132961
154
155         Reviewed by Sam Weinig.
156
157         * Configurations/FeatureDefines.xcconfig:
158         Added ENABLE_POINTER_LOCK to list of features.
159         * WebView/WebPDFView.mm:
160         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
161         Added extra parameters needed when pointer lock is enabled.
162
163 2014-05-14  Brady Eidson  <beidson@apple.com>
164
165         Implement NSSharingServiceDelegate method "transitionImageForShareItem"
166         <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911
167
168         Reviewed by Tim Horton.
169
170         * Misc/WebSharingServicePickerController.mm:
171         (-[WebSharingServicePickerController sharingService:transitionImageForShareItem:contentRect:]):
172
173         * WebCoreSupport/WebContextMenuClient.h:
174         * WebCoreSupport/WebContextMenuClient.mm:
175         (WebContextMenuClient::renderedImageForControlledImage): Paint the entire content rect for the controlled image
176           into an ImageBuffer, then return the resulting NSImage. This only paints the image itself and not any
177           overlapping content by setting the selection and appropriate painting mode.
178
179 2014-05-14  Brady Eidson  <beidson@apple.com>
180
181         sourceFrameOnScreenForShareItem: can be off by a pixel
182         <rdar://problem/16878020> and https://bugs.webkit.org/show_bug.cgi?id=132911
183
184         Reviewed by Simon Fraser.
185
186         In a land of LayoutUnits and sub-pixel rendering, converting between IntRects and
187         FloatRects can be error prone. So we now try to minimize such conversions.
188
189         * Misc/WebSharingServicePickerController.mm:
190         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
191
192         * WebCoreSupport/WebContextMenuClient.h:
193         * WebCoreSupport/WebContextMenuClient.mm:
194         (WebContextMenuClient::clientFloatRectForNode): Split this into a separate utility method
195           as it will be shared with other code very soon. Instead of using absoluteBoundingBoxRect()
196           which does lossy float->int conversions, try to keep things in terms of FloatRects as
197           much as possible.
198         (WebContextMenuClient::screenRectForHitTestNode): Call clientFloatRectForNode to get the
199           FloatRect, then perform the lossy rounding conversion to an IntRect only once.
200
201 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
202
203         Remove CSS_STICKY_POSITION guards
204         https://bugs.webkit.org/show_bug.cgi?id=132676
205
206         Reviewed by Simon Fraser.
207
208         * Configurations/FeatureDefines.xcconfig:
209
210 2014-05-14  Antti Koivisto  <antti@apple.com>
211
212         GIF animations don't restart after scrolling with iOS WebKit1
213         https://bugs.webkit.org/show_bug.cgi?id=132900
214         <rdar://problem/16490858>
215
216         Reviewed by Andreas Kling.
217
218         * WebView/WebView.mm:
219         (-[WebView _didFinishScrollingOrZooming]):
220         
221             Check if the animations need to be restarted after scrolling finishes.
222
223 2014-05-09  Joseph Pecoraro  <pecoraro@apple.com>
224
225         Web Inspector: Allow Remote Inspector to entitlement check UIProcess through WebProcess
226         https://bugs.webkit.org/show_bug.cgi?id=132409
227
228         Reviewed by Timothy Hatcher.
229
230         Simplify the legacy iOS UIWebViewController case by passing on
231         the host process pid and audit_token.
232
233         * WebView/WebView.mm:
234         (-[WebView _setHostApplicationProcessIdentifier:auditToken:]):
235         (-[WebView setHostApplicationBundleId:name:]): Deleted.
236         (-[WebView hostApplicationBundleId]): Deleted.
237         (-[WebView hostApplicationName]): Deleted.
238         * WebView/WebViewData.h:
239         * WebView/WebViewData.mm:
240         (-[WebViewPrivate dealloc]):
241         * WebView/WebViewPrivate.h:
242
243 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
244
245         [iOS] Switch geolocation to an explicit authorization query model
246         https://bugs.webkit.org/show_bug.cgi?id=132717
247
248         Reviewed by Sam Weinig.
249
250         Since there is no warmup code, WebGeolocationPolicyListener no longer need to know about the provider,
251         which is awesome :)
252
253         * WebCoreSupport/WebGeolocationClient.mm:
254         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
255         (-[WebGeolocationPolicyListener deny]):
256         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
257         (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:]):
258         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:provider:]): Deleted.
259         (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:provider:]): Deleted.
260         (-[WebGeolocationProviderInitializationListener initializationDeniedWebView:provider:]): Deleted.
261         * WebView/WebViewPrivate.h:
262
263 2014-05-08  Jer Noble  <jer.noble@apple.com>
264
265         [Mac, iOS] Add source application accounting to AVURLAsset.
266         https://bugs.webkit.org/show_bug.cgi?id=132637
267
268         Reviewed by Eric Carlson.
269
270         Add accessor for sourceApplicationIdentifier.
271
272         * WebCoreSupport/WebFrameNetworkingContext.h:
273         * WebCoreSupport/WebFrameNetworkingContext.mm:
274         (WebFrameNetworkingContext::sourceApplicationIdentifier):
275
276 2014-05-08  Anders Carlsson  <andersca@apple.com>
277
278         Use a different install name for WebKitLegacy.framework for staged framework builds
279         https://bugs.webkit.org/show_bug.cgi?id=132711
280         <rdar://problem/16850620>
281
282         Reviewed by Dan Bernstein.
283
284         * Configurations/WebKitLegacy.xcconfig:
285
286 2014-05-08  Brady Eidson  <beidson@apple.com>
287
288         Wrap a new class definition with __has_include()
289         <rdar://problem/16852395> and https://bugs.webkit.org/show_bug.cgi?id=132694
290
291         Reviewed by Tim Horton.
292
293         * Misc/WebSharingServicePickerController.mm:
294
295 2014-05-07  Pratik Solanki  <psolanki@apple.com>
296
297         Use system defaults for hardware jpeg decoding
298         https://bugs.webkit.org/show_bug.cgi?id=132661
299         <rdar://problem/11348201>
300
301         Reviewed by Tim Horton.
302
303         Remove code that explicitly disabled hardware image decoding. Let the system decide what to do.
304
305         * WebView/WebView.mm:
306         (+[WebView _setAcceleratedImageDecoding:]):
307         (+[WebView _acceleratedImageDecoding]): Deleted.
308         * WebView/WebViewPrivate.h:
309
310 2014-05-07  Brent Fulgham  <bfulgham@apple.com>
311
312         [Mac, iOS] REGRESSION: WK2 YouTube support
313         https://bugs.webkit.org/show_bug.cgi?id=132568
314         <rdar://problem/11464344>
315
316         Reviewed by Darin Adler.
317
318         * Misc/WebNSURLExtras.h:
319         * Misc/WebNSURLExtras.mm: Remove code that has been converted to C++
320         and added to YouTubePluginReplacement.cpp.
321         (-[NSURL _webkit_youTubeURL]):
322         (-[NSString _webkit_queryKeysAndValues]):
323         (createYouTubeURL): Deleted.
324         (-[NSString _webkit_unescapedQueryValue]): Deleted.
325
326 2014-05-07  Jeremy Jones  <jeremyj@apple.com>
327
328         HTMLMediaElement should exitFullscreen when view is removed from the window.
329         https://bugs.webkit.org/show_bug.cgi?id=132506
330
331         Reviewed by Tim Horton.
332
333         * WebView/WebView.mm:
334         (-[WebView viewDidMoveToWindow]):
335         Request WebVideoFullscreenController to exitFullscreen when view is removed from the window.
336
337 2014-05-07  Brady Eidson  <beidson@apple.com>
338
339         Image menu is offset by the amount the view is scrolled
340         <rdar://problem/16818966> and https://bugs.webkit.org/show_bug.cgi?id=132663
341
342         Reviewed by Tim Horton.
343
344         * WebCoreSupport/WebContextMenuClient.mm:
345         (WebContextMenuClient::showContextMenu): Use FrameView::contentsToWindow instead of contentsToRoot, 
346           and skip the [NSView convertPoint:toView:] step.
347
348 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
349
350         WebKit1 is flashy when compositing layers come and go
351         https://bugs.webkit.org/show_bug.cgi?id=132655
352
353         Reviewed by Sam Weinig.
354         
355         In r166117 I removed code to flush compositing layers in FrameView::paintContents(),
356         which caused problems when painting iframes. However, this removed a flush
357         that WebKit1 relied on to flush compositing layers when painting, which caused
358         flashing when compositing layers come and go, and broke WebView snapshotting
359         in some cases.
360         
361         Fix by adding back compositing layer flushing, but this time in WebKit1's
362         -viewWillDraw code path. This allows removal of some flushing in DumpRenderTree.
363
364         * WebView/WebHTMLView.mm:
365         (-[WebHTMLView viewWillDraw]):
366         * WebView/WebView.mm:
367         (-[WebView _flushCompositingChanges]):
368         * WebView/WebViewInternal.h:
369         * WebView/WebViewPrivate.h:
370
371 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
372
373         [CSS Grid Layout] Remove runtime feature
374         https://bugs.webkit.org/show_bug.cgi?id=132382
375
376         Reviewed by Benjamin Poulain.
377
378         Remove cssGridLayoutEnabled setting usage.
379
380         * WebKit.order:
381         * WebView/WebPreferenceKeysPrivate.h:
382         * WebView/WebPreferences.mm:
383         (+[WebPreferences initialize]):
384         (-[WebPreferences cssGridLayoutEnabled]): Deleted.
385         (-[WebPreferences setCSSGridLayoutEnabled:]): Deleted.
386         * WebView/WebPreferencesPrivate.h:
387         * WebView/WebView.mm:
388         (-[WebView _preferencesChanged:]):
389
390 2014-05-06  Dean Jackson  <dino@apple.com>
391
392         [Mac] Allow focus rings to redraw themselves if necessary
393         https://bugs.webkit.org/show_bug.cgi?id=132593
394
395         Reviewed by Simon Fraser.
396
397         * WebCoreSupport/WebSystemInterface.mm:
398         (InitWebCoreSystemInterface): Add DrawFocusRingAtTime and DrawCellFocusRingWithFrameAtTime.
399
400 2014-05-06  Brady Eidson  <beidson@apple.com>
401
402         Don't select an image that is about to have its menu shown.
403         <rdar://problem/16807845> and https://bugs.webkit.org/show_bug.cgi?id=132579
404
405         Reviewed by Tim Horton.
406
407         * Misc/WebSharingServicePickerController.mm:
408         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
409           Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.
410
411 2014-05-06  Anders Carlsson  <andersca@apple.com>
412
413         Move the WebKitLegacy header check to the right file
414         https://bugs.webkit.org/show_bug.cgi?id=132620
415         <rdar://problem/16815716>
416
417         Reviewed by Dan Bernstein.
418
419         * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:
420         * WebKitLegacy/WebKit.h:
421
422 2014-05-06  Anders Carlsson  <andersca@apple.com>
423
424         Put WebKitPluginHost.app in WebKitLegacy.framework
425         https://bugs.webkit.org/show_bug.cgi?id=132592
426         <rdar://problem/15920046>
427
428         Reviewed by Dan Bernstein.
429
430         * Plugins/Hosted/NetscapePluginHostManager.mm:
431         (WebKit::NetscapePluginHostManager::spawnPluginHost):
432
433 2014-05-06  Darin Adler  <darin@apple.com>
434
435         [iOS] Fix two more AdoptCF I missed in my last patch.
436
437         * WebView/WebHTMLView.mm:
438         (imageFromRect): Use adoptCF instead of AdoptCF.
439
440 2014-05-05  Andreas Kling  <akling@apple.com>
441
442         Unreviewed, rolling out r168334.
443
444         Broke builds.
445
446         Reverted changeset:
447
448         "Put WebKitPluginHost.app in WebKitLegacy.framework"
449         https://bugs.webkit.org/show_bug.cgi?id=132592
450         http://trac.webkit.org/changeset/168334
451
452 2014-05-05  Anders Carlsson  <andersca@apple.com>
453
454         Put WebKitPluginHost.app in WebKitLegacy.framework
455         https://bugs.webkit.org/show_bug.cgi?id=132592
456         <rdar://problem/15920046>
457
458         Reviewed by Dan Bernstein.
459
460         * Plugins/Hosted/NetscapePluginHostManager.mm:
461         (WebKit::NetscapePluginHostManager::spawnPluginHost):
462
463 2014-05-02  Brady Eidson  <beidson@apple.com>
464
465         Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:.
466         <rdar://problem/16797425> and https://bugs.webkit.org/show_bug.cgi?id=132484
467
468         Reviewed by Tim Horton.
469
470         * Misc/WebSharingServicePickerController.mm:
471         (-[WebSharingServicePickerController sharingService:sourceFrameOnScreenForShareItem:]):
472
473         * WebCoreSupport/WebContextMenuClient.h:
474         * WebCoreSupport/WebContextMenuClient.mm:
475         (WebContextMenuClient::screenRectForHitTestNode):
476
477 2014-05-02  Brady Eidson  <beidson@apple.com>
478
479         Crash inside [WebSharingServicePickerController clear]
480         <rdar://problem/16791944> and https://bugs.webkit.org/show_bug.cgi?id=132477
481
482         Reviewed by Tim Horton.
483
484         * Misc/WebSharingServicePickerController.h:
485         * Misc/WebSharingServicePickerController.mm:
486         (-[WebSharingServicePickerController clear]): clear can be called twice, so null check _menuClient.
487
488         * WebCoreSupport/WebContextMenuClient.h:
489         * WebCoreSupport/WebContextMenuClient.mm:
490         (WebContextMenuClient::~WebContextMenuClient): For a sanity check, call clear on the picker here.
491
492 2014-05-01  Tim Horton  <timothy_horton@apple.com>
493
494         More 32-bit build fixes.
495
496         * Misc/WebSharingServicePickerController.mm:
497         (-[WebSharingServicePickerController sharingService:didShareItems:]):
498
499 2014-05-01  Tim Horton  <timothy_horton@apple.com>
500
501         Temporarily "fix" the 32-bit build.
502
503         * Misc/WebSharingServicePickerController.mm:
504         This will fail miserably at runtime, but we shouldn't ever get here in a 32-bit process.
505
506 2014-05-01  Brady Eidson  <beidson@apple.com>
507
508         Update service picker API usage.
509         <rdar://problem/16772674> and https://bugs.webkit.org/show_bug.cgi?id=132452
510
511         Reviewed by Tim Horton.
512
513         * Misc/WebSharingServicePickerController.h:
514         * Misc/WebSharingServicePickerController.mm:
515         (-[WebSharingServicePickerController didShareImageData:confirmDataIsValidTIFFData:]):
516           Factor out a common "didShare" handler that optionally validates whether the data represents an image.
517         (-[WebSharingServicePickerController sharingService:didShareItems:]): Update API usage, including marshalling
518           on off-main thread call back to the main thread.
519
520         * WebCoreSupport/WebContextMenuClient.mm:
521         (WebContextMenuClient::contextMenuForEvent): Update API usage.
522
523 2014-05-01  Anders Carlsson  <andersca@apple.com>
524
525         Support OS-version-specific install paths for WebKit.framework
526         https://bugs.webkit.org/show_bug.cgi?id=132448
527         <rdar://problem/16784932>
528
529         Reviewed by Dan Bernstein.
530
531         * WebKitLegacy/WebKit.m:
532         Add version specific install names.
533
534 2014-04-30  Alexey Proskuryakov  <ap@apple.com>
535
536         Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
537         Clean up unnecessary methods in the BackForwardClient interface
538
539         It broke a regression test and an API test.
540
541         * History/WebBackForwardList.mm:
542         (-[WebBackForwardList initWithBackForwardList:]):
543         (-[WebBackForwardList init]):
544         (-[WebBackForwardList dealloc]):
545         (-[WebBackForwardList finalize]):
546         (-[WebBackForwardList setPageCacheSize:]):
547         (-[WebBackForwardList pageCacheSize]):
548         * History/WebBackForwardListInternal.h:
549         * WebCoreSupport/WebFrameLoaderClient.mm:
550         (WebFrameLoaderClient::canCachePage):
551         * WebView/WebFrameView.mm:
552         (-[WebFrameView keyDown:keyDown:]):
553         * WebView/WebView.mm:
554         (-[WebView _loadBackForwardListFromOtherView:]):
555         (-[WebView initWithCoder:]):
556         (-[WebView encodeWithCoder:]):
557         (-[WebView backForwardList]):
558         (-[WebView setMaintainsBackForwardList:]):
559
560 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
561
562         Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
563         https://bugs.webkit.org/show_bug.cgi?id=132396
564
565         Reviewed by Eric Carlson.
566
567         Remove ENABLE_PLUGIN_PROXY_FOR_VIDEO and related code.
568
569         * Configurations/FeatureDefines.xcconfig:
570         * Plugins/WebPluginContainerPrivate.h:
571         * Plugins/WebPluginController.h:
572         * Plugins/WebPluginController.mm:
573         (-[WebPluginController dealloc]):
574         (-[WebPluginController plugInsAreRunning]):
575         (-[WebPluginController stopAllPlugins]):
576         (-[WebPluginController stopPluginsForPageCache]):
577         (-[WebPluginController restorePluginsFromCache]):
578         (-[WebPluginController addPlugin:]):
579         (-[WebPluginController destroyPlugin:]):
580         (-[WebPluginController destroyAllPlugins]):
581         (-[NSView isMediaPlugInProxyView]): Deleted.
582         (-[NSView setIsMediaPlugInProxyView:]): Deleted.
583         (-[WebPluginController mediaPlugInProxyViewCreated:]): Deleted.
584         (+[WebPluginController pluginViewHidden:]): Deleted.
585         (mediaProxyClient): Deleted.
586         (-[WebPluginController _webPluginContainerSetMediaPlayerProxy:forElement:]): Deleted.
587         (-[WebPluginController _webPluginContainerPostMediaPlayerNotification:forElement:]): Deleted.
588         * WebCoreSupport/WebFrameLoaderClient.h:
589         * WebCoreSupport/WebFrameLoaderClient.mm:
590         (pluginView):
591         * WebView/WebView.mm:
592         (-[WebView _preferencesChanged:]):
593         (-[WebView _videoProxyPluginForMIMEType:]): Deleted.
594         * WebView/WebViewInternal.h:
595
596 2014-04-30  Anders Carlsson  <andersca@apple.com>
597
598         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
599         https://bugs.webkit.org/show_bug.cgi?id=132399
600         <rdar://problem/15920046>
601
602         Reviewed by Dan Bernstein.
603
604         * Carbon/CarbonUtils.h:
605         * Carbon/HIViewAdapter.h:
606         * Carbon/HIWebView.h:
607         Import WebKitLegacy headers instead of WebKit headers.
608
609         * Configurations/WebKit.xcconfig:
610         Move the definitions needed for building WebKitLegacy.framework to WebKitLegacy.xcconfig and
611         add the relevant definitions needed for re-exporting WebKitLegacy.framework.
612
613         * Configurations/WebKitLegacy.xcconfig:
614         Add definitions needed for building the "old" WebKit API as WebKitLegacy.framework.
615
616         * DOM/WebDOMOperations.h:
617         * DOM/WebDOMOperations.mm:
618         * DOM/WebDOMOperationsInternal.h:
619         * DOM/WebDOMOperationsPrivate.h:
620         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
621         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
622         * DefaultDelegates/WebDefaultEditingDelegate.m:
623         * History/WebBackForwardListInternal.h:
624         * History/WebBackForwardListPrivate.h:
625         * History/WebHistoryItemPrivate.h:
626         * History/WebHistoryPrivate.h:
627         * History/WebURLsWithTitles.m:
628         Import WebKitLegacy headers instead of WebKit headers.
629
630         * MigrateHeaders.make:
631         Update header paths now that all WebKitLegacy headers are private.
632         Remove migration of WebKit2 headers, that is done by MigrateHeadersFromWebKitLegacy.make now.
633         
634         * Misc/WebCoreStatistics.h:
635         * Misc/WebDownload.h:
636         * Misc/WebDownload.mm:
637         * Misc/WebDownloadInternal.h:
638         * Misc/WebElementDictionary.mm:
639         * Misc/WebIconDatabasePrivate.h:
640         * Misc/WebKit.h:
641         * Misc/WebKitErrors.m:
642         * Misc/WebKitErrorsPrivate.h:
643         * Misc/WebKitNSStringExtras.mm:
644         * Misc/WebLocalizableStrings.mm:
645         * Misc/WebNSDataExtras.m:
646         * Misc/WebNSDictionaryExtras.m:
647         * Misc/WebNSEventExtras.m:
648         * Misc/WebNSFileManagerExtras.mm:
649         * Misc/WebNSImageExtras.m:
650         * Misc/WebNSPasteboardExtras.mm:
651         * Misc/WebNSViewExtras.h:
652         * Misc/WebNSViewExtras.m:
653         * Panels/WebAuthenticationPanel.m:
654         * Panels/WebPanelAuthenticationHandler.m:
655         * Plugins/Hosted/HostedNetscapePluginStream.h:
656         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
657         * Plugins/Hosted/WebKitPluginAgent.defs:
658         * Plugins/Hosted/WebKitPluginAgentReply.defs:
659         * Plugins/Hosted/WebKitPluginClient.defs:
660         * Plugins/Hosted/WebKitPluginHost.defs:
661         * Plugins/Hosted/WebKitPluginHostTypes.defs:
662         * Plugins/WebBaseNetscapePluginView.mm:
663         * Plugins/WebBasePluginPackage.h:
664         * Plugins/WebBasePluginPackage.mm:
665         * Plugins/WebNetscapeContainerCheckPrivate.h:
666         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
667         * Plugins/WebNetscapePluginStream.h:
668         * Plugins/WebNetscapePluginView.h:
669         * Plugins/WebNetscapePluginView.mm:
670         * Plugins/WebPlugin.h:
671         * Plugins/WebPluginController.h:
672         * Plugins/WebPluginDatabase.h:
673         * Plugins/WebPluginPackage.h:
674         * Plugins/WebPluginPackage.mm:
675         * Plugins/WebPluginViewFactory.h:
676         * Plugins/WebPluginViewFactoryPrivate.h:
677         * Plugins/npapi.mm:
678         * Storage/WebDatabaseManagerPrivate.h:
679         * WebCoreSupport/WebContextMenuClient.mm:
680         * WebCoreSupport/WebFrameLoaderClient.mm:
681         * WebCoreSupport/WebFrameNetworkingContext.mm:
682         * WebCoreSupport/WebGeolocationClient.mm:
683         * WebCoreSupport/WebInspectorClient.mm:
684         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
685         * WebCoreSupport/WebKeyGenerator.mm:
686         * WebInspector/WebInspectorPrivate.h:
687         * WebInspector/WebNodeHighlight.h:
688         * WebInspector/WebNodeHighlightView.h:
689         Import WebKitLegacy headers instead of WebKit headers.
690         
691         * WebKitLegacy/MigrateHeadersFromWebKitLegacy.make: Added.
692         New makefile that handles copying WebKitLegacy headers to the WebKit framework, rewriting WebKitLegacy
693         imports to WebKit imports. (On iOS the WebKit headers just forward to the relevant WebKitLegacy headers).
694         On OS X, this also handles copying WebKit2 headers to the WebKit framework, rewriting WebKit2 imports to WebKit imports
695         and getting rid of C SPI imports.
696         
697         * WebKitLegacy/MigrateHeadersToLegacy.make: Removed.
698         This is no longer needed.
699         
700         * WebKitLegacy/WebKit.h: Added.
701         New umbrella header that imports the modern API if available, as well as the legacy API (using WebKit/WebKitLegacy.h).
702
703         * WebKitLegacy/WebKit.m:
704         This is an empty file so we'll have something to link.
705
706         * WebKitLegacy/WebKitPrivate.h:
707         New SPI header that imports the private headers of the modern API.
708
709         * WebView/WebDataSource.h:
710         * WebView/WebDataSource.mm:
711         * WebView/WebDataSourcePrivate.h:
712         * WebView/WebDelegateImplementationCaching.h:
713         * WebView/WebDocument.h:
714         * WebView/WebDocumentInternal.h:
715         * WebView/WebDocumentPrivate.h:
716         * WebView/WebEditingDelegate.h:
717         * WebView/WebEditingDelegatePrivate.h:
718         * WebView/WebFrameLoadDelegate.h:
719         * WebView/WebFrameLoadDelegatePrivate.h:
720         * WebView/WebFramePrivate.h:
721         * WebView/WebFrameView.h:
722         * WebView/WebFrameViewInternal.h:
723         * WebView/WebFrameViewPrivate.h:
724         * WebView/WebHTMLRepresentation.h:
725         * WebView/WebHTMLRepresentation.mm:
726         * WebView/WebHTMLRepresentationPrivate.h:
727         * WebView/WebHTMLView.h:
728         * WebView/WebHTMLView.mm:
729         * WebView/WebHTMLViewPrivate.h:
730         * WebView/WebPDFView.h:
731         * WebView/WebPolicyDelegatePrivate.h:
732         * WebView/WebPreferencesPrivate.h:
733         * WebView/WebResourcePrivate.h:
734         * WebView/WebUIDelegate.h:
735         * WebView/WebUIDelegatePrivate.h:
736         * WebView/WebView.h:
737         * WebView/WebView.mm:
738         * WebView/WebViewPrivate.h:
739         Import WebKitLegacy headers instead of WebKit headers.
740
741         * migrate-headers.sh:
742         Derived sources are put in DerivedSources/WebKitLegacy now.
743
744 2014-04-30  David Hyatt  <hyatt@apple.com>
745
746         [New Multicolumn] Enable new multi-column mode
747         https://bugs.webkit.org/show_bug.cgi?id=131825
748
749         Reviewed by Simon Fraser.
750
751         * WebView/WebPreferences.mm:
752         (+[WebPreferences initialize]):
753
754 2014-04-30  Brian J. Burg  <burg@cs.washington.edu>
755
756         Clean up unnecessary methods in the BackForwardClient interface
757         https://bugs.webkit.org/show_bug.cgi?id=131637
758
759         Reviewed by Andreas Kling.
760
761         BackForwardClient instances now have ownership lifetime semantics, so
762         WebBackForwardList now explicitly deletes its inner BackForwardList.
763
764         Convert uses of WebCore::BackForwardList through backForward().client() to
765         accept references instead of pointers.
766
767         Use BackForwardController methods rather than directly operating with the
768         BackForwardClient where possible.
769
770         Remove page cache-related methods that are not used anywhere and that call
771         BackForwardClient::page(), which is removed by this change.
772
773         * History/WebBackForwardList.mm:
774         (-[WebBackForwardList initWithBackForwardList:]):
775         (-[WebBackForwardList init]):
776         (-[WebBackForwardList dealloc]):
777         (-[WebBackForwardList finalize]):
778         (-[WebBackForwardList setPageCacheSize]): Deleted.
779         (-[WebBackForwardList pageCacheSize]): Deleted.
780         (-[WebBackForwardList itemAtIndex:]): Deleted.
781         * History/WebBackForwardListInternal.h:
782         * WebCoreSupport/WebFrameLoaderClient.mm:
783         (WebFrameLoaderClient::canCachePage):
784         * WebView/WebFrameView.mm:
785         (-[WebFrameView keyDown:keyDown:]):
786         * WebView/WebView.mm:
787         (-[WebView _loadBackForwardListFromOtherView:]):
788         (-[WebView initWithCoder:]):
789         (-[WebView encodeWithCoder:]):
790         (-[WebView backForwardList]):
791         (-[WebView setMaintainsBackForwardList:]):
792
793 2014-04-29  Sam Weinig  <sam@webkit.org>
794
795         [iOS] -[WebHTMLView selectionImageForcingBlackText:] returns blank image on iOS
796         https://bugs.webkit.org/show_bug.cgi?id=132359
797
798         Reviewed by Darin Adler.
799
800         * WebView/WebHTMLView.mm:
801         (imageFromRect):
802         (selectionImage):
803         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
804         Bring back the old FrameSnapshottingMac code for drawing the selection image as drag code for this
805         is still unimplemented on iOS.
806
807         * WebView/WebView.mm:
808         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
809         Set the page scale for "simple HTML documents" (this is already done for the all other documents), 
810         to ensure that the snapshot is the correct size.
811
812 2014-04-30  Manuel Rego Casasnovas  <rego@igalia.com>
813
814         [CSS Grid Layout] Enable runtime feature by default
815         https://bugs.webkit.org/show_bug.cgi?id=132189
816
817         Reviewed by Benjamin Poulain.
818
819         * WebView/WebPreferences.mm:
820         (+[WebPreferences initialize]): Remove unneeded changes that
821         enable/disable the runtime feature depending on the compilation flag.
822         And set it to true by default.
823
824 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
825
826         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
827         https://bugs.webkit.org/show_bug.cgi?id=112840
828
829         Rubber stamped by Geoffrey Garen.
830
831         * Configurations/FeatureDefines.xcconfig:
832
833 2014-04-29  Brady Eidson  <beidson@apple.com>
834
835         Change Image Controls replacement to use selection and paste
836         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
837
838         Reviewed by Tim Horton.
839
840         * Misc/WebSharingServicePickerController.mm:
841         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
842           replacement data to a special pasteboard, then replace the current selection from
843           that pasteboard.
844
845 2014-04-27  Sam Weinig  <sam@webkit.org>
846
847         [iOS WebKit2] Add support for text autosizing
848         <rdar://problem/16545245>
849         https://bugs.webkit.org/show_bug.cgi?id=132237
850
851         Reviewed by Tim Horton.
852
853         * WebView/WebFrame.mm:
854         (-[WebFrame _setTextAutosizingWidth:]):
855         Forward setting of the text autosizing width to the Page.
856
857 2014-04-25  Dean Jackson  <dino@apple.com>
858
859         Allow a platform-specific size enumeration to be passed into popup-menu display
860         https://bugs.webkit.org/show_bug.cgi?id=132195
861
862         Reviewed by Brent Fulgham. With some in-person review comments from Sam Weinig.
863
864         Platforms like OS X use a set of predefined sizes for built-in controls
865         used for <select>: normal, small and mini. Expose that information to
866         the PopupMenuClient via the PopupMenuStyle, allowing it to be passed
867         into the platform code in WebKitSystemInterface.
868
869         * WebCoreSupport/PopupMenuMac.mm:
870         (PopupMenuMac::show): Convert the WebCore menu size type into the
871         WebCoreSystemInterface type.
872
873 2014-04-24  Commit Queue  <commit-queue@webkit.org>
874
875         Unreviewed, rolling out r167700.
876         https://bugs.webkit.org/show_bug.cgi?id=132142
877
878         Incorrectly reverted the change in r167547 for
879         webkit.org/b/131898 (Requested by rniwa on #webkit).
880
881         Reverted changeset:
882
883         "Cursor doesn't change back to pointer when leaving the Safari
884         window"
885         https://bugs.webkit.org/show_bug.cgi?id=132038
886         http://trac.webkit.org/changeset/167700
887
888 2014-04-24  Brady Eidson  <beidson@apple.com>
889
890         Rename "IMAGE_CONTROLS" feature to "SERVICE_CONTROLS"
891         https://bugs.webkit.org/show_bug.cgi?id=132155
892
893         Reviewed by Tim Horton.
894
895         * Configurations/FeatureDefines.xcconfig:
896         * Misc/WebSharingServicePickerController.h:
897         * Misc/WebSharingServicePickerController.mm:
898         * WebCoreSupport/WebContextMenuClient.h:
899         * WebCoreSupport/WebContextMenuClient.mm:
900         (WebContextMenuClient::contextMenuForEvent):
901         * WebView/WebPreferences.mm:
902         (+[WebPreferences initialize]):
903         * WebView/WebView.mm:
904         (-[WebView _preferencesChanged:]):
905
906 2014-04-24  Ryosuke Niwa  <rniwa@webkit.org>
907
908         Text caret disappears in Mail after returning from another application
909         https://bugs.webkit.org/show_bug.cgi?id=132111
910
911         Reviewed by Darin Adler.
912
913         The bug was caused by our SPI _windowChangedKeyState not getting called upon deminiaturization.
914
915         Fixed the bug by using the standard NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification
916         notifications as done in WebKit2 since they DO get called upon deminiaturization.
917
918         * WebView/WebView.mm:
919         (-[WebView addWindowObserversForWindow:]):
920         (-[WebView removeWindowObservers]):
921         (-[WebView _windowKeyStateChanged:]):
922         (-[WebView _windowChangedKeyState]): Deleted.
923
924 2014-04-24  Myles C. Maxfield  <mmaxfield@apple.com>
925
926         FontCache::fontCache() never returns nullptr so it can be made to return a reference instead
927         https://bugs.webkit.org/show_bug.cgi?id=132110
928
929         Reviewed by Tim Horton.
930
931         Updates callers to use '.' instead of '->'.
932
933         No new tests are necessary because there should be no behavior change.
934
935         * Misc/WebCoreStatistics.mm:
936         (+[WebCoreStatistics cachedFontDataCount]):
937         (+[WebCoreStatistics cachedFontDataInactiveCount]):
938         (+[WebCoreStatistics purgeInactiveFontData]):
939         * WebView/WebView.mm:
940         (+[WebView purgeInactiveFontData]):
941
942 2014-04-24  Eric Carlson  <eric.carlson@apple.com>
943
944         [iOS] Manage AudioSession category according to media type
945         https://bugs.webkit.org/show_bug.cgi?id=132096
946
947         Reviewed by Jer Noble.
948
949         * WebView/WebView.mm:
950         (-[WebView _commonInitializationWithFrameName:groupName:]): Tell 
951             WebCore to manage the AudioSession when running in MobileSafari.
952
953 2014-04-23  Andreas Kling  <akling@apple.com>
954
955         Remove Apple Dictionary workaround in WebFrameLoaderClient.
956         <https://webkit.org/b/132095>
957
958         Kill a hack to work around a WK1 client bug that got fixed years ago.
959         See <rdar://problem/6471058> for backstory.
960
961         Reviewed by Darin Adler.
962
963         * WebCoreSupport/WebFrameLoaderClient.mm:
964         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
965         (WebFrameLoaderClient::dispatchWillSendRequest):
966         (applyAppleDictionaryApplicationQuirkNonInlinePart): Deleted.
967         (applyAppleDictionaryApplicationQuirk): Deleted.
968
969 2014-04-23  Anders Carlsson  <andersca@apple.com>
970
971         Don't migrate the WKView.h header from WebCore to WebKit
972         https://bugs.webkit.org/show_bug.cgi?id=132086
973
974         Reviewed by Dan Bernstein.
975
976         * MigrateHeaders.make:
977         Remove WKView.h from the list of headers to migrate.
978
979         * WebView/WebView.mm:
980         Import WKView.h.
981
982 2014-04-22  Ryosuke Niwa  <rniwa@webkit.org>
983
984         Cursor doesn't change back to pointer when leaving the Safari window
985         https://bugs.webkit.org/show_bug.cgi?id=132038
986
987         Reviewed by Alexey Proskuryakov.
988
989         Since the cursor type is now updated asynchronously after r147739,
990         [window windowNumber] != [NSWindow windowNumberAtPoint:[NSEvent mouseLocation] belowWindowWithWindowNumber:0]
991         evalutes to false depending on how fast cursor is moving.
992
993         Instead, check whether the NSWindow of the WebView is the key window or not since
994         key window appears to control the cursor style in Cocoa as far as I've tested:
995         https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/WinPanel/Concepts/ChangingMainKeyWindow.html
996
997         * WebCoreSupport/WebChromeClient.mm:
998         (WebChromeClient::setCursor):
999
1000 2014-04-22  Commit Queue  <commit-queue@webkit.org>
1001
1002         Unreviewed, rolling out r167674.
1003         https://bugs.webkit.org/show_bug.cgi?id=132025
1004
1005         Going a different way with this (Requested by bradee-oh on
1006         #webkit).
1007
1008         Reverted changeset:
1009
1010         "Change Image Controls replacement to use selection and paste"
1011         https://bugs.webkit.org/show_bug.cgi?id=131992
1012         http://trac.webkit.org/changeset/167674
1013
1014 2014-04-22  Brady Eidson  <beidson@apple.com>
1015
1016         Change Image Controls replacement to use selection and paste
1017         <rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
1018
1019         Reviewed by Tim Horton.
1020
1021         * Misc/WebSharingServicePickerController.mm:
1022         (-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
1023           replacement data to a special pasteboard, then replace the current selection from
1024           that pasteboard.
1025
1026 2014-04-21  Eric Carlson  <eric.carlson@apple.com>
1027
1028         [Mac] implement WebKitDataCue
1029         https://bugs.webkit.org/show_bug.cgi?id=131799
1030
1031         Reviewed by Dean Jackson.
1032
1033         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
1034
1035 2014-04-21  Joseph Pecoraro  <pecoraro@apple.com>
1036
1037         Remove unused WebKitSystemInterface functions
1038         https://bugs.webkit.org/show_bug.cgi?id=131938
1039
1040         Reviewed by Alexey Proskuryakov.
1041
1042         * WebCoreSupport/WebSystemInterface.mm:
1043         (InitWebCoreSystemInterface):
1044
1045 2014-04-21  Zan Dobersek  <zdobersek@igalia.com>
1046
1047         Move cross-port Source/WebCore/page/ code to std::unique_ptr
1048         https://bugs.webkit.org/show_bug.cgi?id=130534
1049
1050         Reviewed by Darin Adler.
1051
1052         * WebView/WebHTMLRepresentation.mm:
1053         (searchForLabelsBeforeElement): Pass a RegExp reference to Frame::searchForLabelsAboveCell().
1054
1055 2014-04-19  Darin Adler  <darin@apple.com>
1056
1057         [Mac] WebView adjusts the cursor even when another window is in front
1058         https://bugs.webkit.org/show_bug.cgi?id=131898
1059         rdar://problem/14619911
1060
1061         Reviewed by Dan Bernstein.
1062
1063         * WebCoreSupport/WebChromeClient.mm:
1064         (WebChromeClient::setCursor): Added a check that the window is under the cursor
1065         and do nothing if it's not.
1066
1067 2014-04-18  Commit Queue  <commit-queue@webkit.org>
1068
1069         Unreviewed, rolling out r167527.
1070         https://bugs.webkit.org/show_bug.cgi?id=131883
1071
1072         Broke 32-bit build (Requested by ap on #webkit).
1073
1074         Reverted changeset:
1075
1076         "[Mac] implement WebKitDataCue"
1077         https://bugs.webkit.org/show_bug.cgi?id=131799
1078         http://trac.webkit.org/changeset/167527
1079
1080 2014-04-18  Eric Carlson  <eric.carlson@apple.com>
1081
1082         [Mac] implement WebKitDataCue
1083         https://bugs.webkit.org/show_bug.cgi?id=131799
1084
1085         Reviewed by Dean Jackson.
1086
1087         * Configurations/FeatureDefines.xcconfig: Define ENABLE_DATACUE_VALUE.
1088
1089 2014-04-17  Daniel Bates  <dabates@apple.com>
1090
1091         [iOS] Hook up screen.{availHeight, availWidth, height, width}
1092         https://bugs.webkit.org/show_bug.cgi?id=131821
1093         <rdar://problem/16413795>
1094
1095         Reviewed by Benjamin Poulain and Tim Horton.
1096
1097         Add declaration for WKGetViewportAvailableScreenSize() to return the available screen size.
1098
1099         Additionally substitute "ScreenSize" for "ViewportScreenSize" to make the code more understandable.
1100
1101         * WebCoreSupport/WebSystemInterface.mm:
1102         (InitWebCoreSystemInterface):
1103
1104 2014-04-17  Darin Adler  <darin@apple.com>
1105
1106         Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe
1107         https://bugs.webkit.org/show_bug.cgi?id=131785
1108         rdar://problem/16003108
1109
1110         Reviewed by Brady Eidson.
1111         
1112         * Configurations/FeatureDefines.xcconfig: Added INDEXED_DATABASE_IN_WORKERS.
1113
1114 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1115
1116         Images dragged from WebKit1 on 2x displays are too big
1117         https://bugs.webkit.org/show_bug.cgi?id=131775
1118         <rdar://problem/15933525>
1119
1120         Reviewed by Simon Fraser.
1121
1122         * WebCoreSupport/WebDragClient.mm:
1123         (WebDragClient::startDrag):
1124         Scale the drag image's logical size down by the device scale factor
1125         in WebKit1 just like we do in WebKit2.
1126
1127 2014-04-13  Andy Estes  <aestes@apple.com>
1128
1129         [QuickLook] Move file system-related code into WebKit
1130         https://bugs.webkit.org/show_bug.cgi?id=131597
1131
1132         Reviewed by Dan Bernstein.
1133
1134         Moved file system and WebKit1-only code from QuickLookHandle into a new
1135         QuickLookHandleClient subclass.
1136
1137         * WebCoreSupport/WebFrameLoaderClient.h:
1138         * WebCoreSupport/WebFrameLoaderClient.mm:
1139
1140 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1141
1142         Eliminate DragSession structure
1143         https://bugs.webkit.org/show_bug.cgi?id=131465
1144
1145         Reviewed by Benjamin Poulain.
1146
1147         * WebView/WebView.mm:
1148         (-[WebView draggingEntered:]):
1149         (-[WebView draggingUpdated:]):
1150
1151 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1152
1153         Rename some dragging functions
1154         https://bugs.webkit.org/show_bug.cgi?id=131460
1155
1156         Reviewed by Tim Horton.
1157
1158         Renamed performDrag to performDragOperation.
1159
1160         * WebView/WebView.mm: (-[WebView performDragOperation:]):
1161
1162 2014-04-08  Jon Lee  <jonlee@apple.com>
1163
1164         Turn MSE on by default
1165         https://bugs.webkit.org/show_bug.cgi?id=131313
1166         <rdar://problem/16525223>
1167
1168         Reviewed by Jer Noble.
1169
1170         * Configurations/FeatureDefines.xcconfig:
1171         * WebView/WebPreferences.mm:
1172         (+[WebPreferences initialize]): Set default to true.
1173
1174 2014-04-08  Alexey Proskuryakov  <ap@apple.com>
1175
1176         Rename Clipboard to DataTransfer
1177         https://bugs.webkit.org/show_bug.cgi?id=131371
1178
1179         Reviewed by Anders Carlsson.
1180
1181         * WebCoreSupport/WebDragClient.h:
1182         * WebCoreSupport/WebDragClient.mm:
1183         (WebDragClient::willPerformDragSourceAction):
1184         (WebDragClient::startDrag):
1185         * WebView/WebPDFView.mm:
1186
1187 2014-04-08  Dan Bernstein  <mitz@apple.com>
1188
1189         WebKit part of [Cocoa] Add WKFormDelegate
1190         https://bugs.webkit.org/show_bug.cgi?id=131343
1191
1192         Reviewed by Anders Carlsson.
1193
1194         * MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.
1195
1196 2014-04-08  Daniel Bates  <dabates@apple.com>
1197
1198         Fallback to default storage session when there isn't a valid session ID
1199         https://bugs.webkit.org/show_bug.cgi?id=131326
1200         <rdar://problem/16231679>
1201
1202         Reviewed by Alexey Proskuryakov.
1203
1204         Fixes and issue where we may use the wrong storage session after disabling
1205         a private browsing session.
1206
1207         Currently WebKit1 and WebKit2 without NetworkProcess assume that there
1208         is always a non-null private browsing storage session so long as the page
1209         has a non-default session ID. Instead we should only use the private browsing
1210         storage session when it's non-null and the page has a non-default session ID;
1211         otherwise, we should use the default storage session. This change will make
1212         the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
1213         the behavior in WebKit2 with NetworkProcess.
1214
1215         * WebCoreSupport/WebFrameNetworkingContext.mm:
1216         (WebFrameNetworkingContext::storageSession):
1217
1218 2014-04-06  Sam Weinig  <sam@webkit.org>
1219
1220         Document user content related APIs
1221
1222         Reviewed by Anders Carlsson.
1223
1224         * MigrateHeaders.make:
1225
1226 2014-04-06  Darin Adler  <darin@apple.com>
1227
1228         Refactor post-attach and HTMLObjectElement-related code
1229         https://bugs.webkit.org/show_bug.cgi?id=131282
1230
1231         Reviewed by Antti Koivisto.
1232
1233         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
1234         doing a static_cast.
1235
1236 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1237
1238         Enable WEB_REPLAY for PLATFORM(MAC)
1239         https://bugs.webkit.org/show_bug.cgi?id=130700
1240
1241         Reviewed by Timothy Hatcher.
1242
1243         * Configurations/FeatureDefines.xcconfig:
1244
1245 2014-04-03  Sam Weinig  <sam@webkit.org>
1246
1247         [WebKit2] Promote user script SPI to API
1248         https://bugs.webkit.org/show_bug.cgi?id=131181
1249
1250         Reviewed by Anders Carlsson.
1251
1252         * MigrateHeaders.make:
1253
1254 2014-04-02  Benjamin Poulain  <bpoulain@apple.com>
1255
1256         [iOS] Remove the legacy string drawing code
1257         https://bugs.webkit.org/show_bug.cgi?id=131088
1258
1259         Reviewed by Sam Weinig.
1260
1261         * Configurations/WebKit.xcconfig:
1262
1263 2014-04-02  Mark Rowe  <mrowe@apple.com>
1264
1265         <https://webkit.org/b/131135> Introduce LockHistory and LockBackForwardList enums to use in place of bools.
1266
1267         These arguments are often passed using literals at the call site, where the use of bools severely hinders
1268         the readability of the code.
1269
1270         Reviewed by Andreas Kling.
1271
1272         * WebView/WebPDFView.mm:
1273         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1274
1275 2014-04-02  Stephanie Lewis  <slewis@apple.com>
1276
1277         Roll out http://trac.webkit.org/changeset/166144
1278         <rdar://problem/16481284> PLT stops loading on news.google.com
1279         
1280         Unreviewed rollout.
1281
1282         Rollout 166144 since it prevents the PLT from completing.
1283
1284         * WebCoreSupport/WebFrameLoaderClient.mm:
1285
1286 2014-04-02  Daniel Bates  <dabates@apple.com>
1287
1288         Remove Settings::maximumDecodedImageSize()
1289         https://bugs.webkit.org/show_bug.cgi?id=131057
1290         <rdar://problem/15626368>
1291
1292         Reviewed by Darin Adler. 
1293
1294         Remove preferences key WebKitMaximumImageSize.
1295
1296         * WebView/WebPreferenceKeysPrivate.h:
1297         * WebView/WebPreferences.mm:
1298         (+[WebPreferences initialize]):
1299         (-[WebPreferences _maximumImageSize:]): Deleted.
1300         * WebView/WebPreferencesPrivate.h:
1301         * WebView/WebView.mm:
1302         (-[WebView _preferencesChanged:]):
1303
1304 2014-04-02  Martin Hock  <mhock@apple.com>
1305
1306         Unify private browsing with sessions.
1307         https://bugs.webkit.org/show_bug.cgi?id=130099
1308
1309         Reviewed by Alexey Proskuryakov.
1310
1311         * WebCoreSupport/WebFrameLoaderClient.mm: Change WebCore::Settings::privateBrowsingEnabled() to Page::sessionID().isEphemeral().
1312         (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
1313         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
1314         (WebFrameNetworkingContext::storageSession):
1315         * WebView/WebView.mm: Change WebCore::Settings::setPrivateBrowsingEnabled() to Page::enableLegacyPrivateBrowsing().
1316         (-[WebView _preferencesChanged:]):
1317
1318 2014-04-01  Anders Carlsson  <andersca@apple.com>
1319
1320         Migrate more headers
1321         https://bugs.webkit.org/show_bug.cgi?id=131068
1322
1323         Reviewed by Tim Horton.
1324
1325         * MigrateHeaders.make:
1326
1327 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1328
1329         [CSS Grid Layout] Enable runtime feature if feature flag is enabled
1330         https://bugs.webkit.org/show_bug.cgi?id=130013
1331
1332         Reviewed by Simon Fraser.
1333
1334         Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
1335
1336         * WebView/WebPreferences.mm:
1337         (+[WebPreferences initialize]):
1338
1339 2014-03-31  Simon Fraser  <simon.fraser@apple.com>
1340
1341         Enable WEB_TIMING on Mac and iOS
1342         https://bugs.webkit.org/show_bug.cgi?id=128064
1343
1344         Reviewed by Sam Weinig, Brent Fulgham.
1345
1346         Enable WEB_TIMING.
1347
1348         * Configurations/FeatureDefines.xcconfig:
1349
1350 2014-03-31  Dean Jackson  <dino@apple.com>
1351
1352         Remove WEB_ANIMATIONS
1353         https://bugs.webkit.org/show_bug.cgi?id=130989
1354
1355         Reviewed by Simon Fraser.
1356
1357         Remove this feature flag until we plan to implement.
1358
1359         * Configurations/FeatureDefines.xcconfig:
1360
1361 2014-03-31  Antti Koivisto  <antti@apple.com>
1362
1363         Rename TileCache to LegacyTileCache
1364         https://bugs.webkit.org/show_bug.cgi?id=130986
1365
1366         Reviewed by Simon Fraser.
1367
1368         * WebView/WebView.mm:
1369         (+[WebView drainLayerPool]):
1370         (+[WebView _setTileCacheLayerPoolCapacity:]):
1371
1372 2014-03-28  Darin Adler  <darin@apple.com>
1373
1374         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1375         https://bugs.webkit.org/show_bug.cgi?id=130889
1376
1377         Reviewed by Alexey Proskuryakov.
1378
1379         * Misc/WebStringTruncator.mm:
1380         (defaultMenuFont): Changed to use NeverDestroyed since I had to touch this file anyway.
1381         (fontFromNSFont): Ditto. Also improved variable names a bit.
1382         (+[WebStringTruncator initialize]): Added threading initialization, needed for main
1383         thread assertions in string truncator code.
1384
1385 2014-03-27  Commit Queue  <commit-queue@webkit.org>
1386
1387         Unreviewed, rolling out r166360.
1388         https://bugs.webkit.org/show_bug.cgi?id=130869
1389
1390         Seems to have broken PLT (Requested by ap on #webkit).
1391
1392         Reverted changeset:
1393
1394         "Connection::dispatchOneMessage() can be re-entered while
1395         handling Cmd-key menu"
1396         https://bugs.webkit.org/show_bug.cgi?id=130767
1397         http://trac.webkit.org/changeset/166360
1398
1399 2014-03-27  Alexey Proskuryakov  <ap@apple.com>
1400
1401         Connection::dispatchOneMessage() can be re-entered while handling Cmd-key menu
1402         equivalents, ASSERT(!_data->_keyDownEventBeingResent)
1403         https://bugs.webkit.org/show_bug.cgi?id=130767
1404         <rdar://problem/16307487>
1405
1406         Reviewed by Darin Adler.
1407
1408         Switched to a WebCore wrapper for RunLoop::initializeMainRunLoop that adds
1409         NSModalPanelRunLoopMode to RunLoop event source and timer modes.
1410
1411         * Carbon/CarbonWindowAdapter.mm: (+[CarbonWindowAdapter initialize]):
1412         * History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
1413         * History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
1414         * Misc/WebCache.mm: (+[WebCache initialize]):
1415         * Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
1416         * Misc/WebIconDatabase.mm: (+[WebIconDatabase initialize]):
1417         * Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
1418         * Plugins/WebBaseNetscapePluginView.mm:
1419         * Plugins/WebBasePluginPackage.mm:
1420         * Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
1421         * WebCoreSupport/WebEditorClient.mm: (+[WebUndoStep initialize]):
1422         * WebCoreSupport/WebFrameLoaderClient.mm:
1423         * WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
1424         * WebView/WebDataSource.mm: (+[WebDataSource initialize]):
1425         * WebView/WebHTMLView.mm:
1426         (+[WebHTMLViewPrivate initialize]):
1427         (+[WebHTMLView initialize]):
1428         * WebView/WebPreferences.mm: (+[WebPreferences initialize]):
1429         * WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
1430         * WebView/WebTextIterator.mm: (+[WebTextIteratorPrivate initialize]):
1431         * WebView/WebView.mm: (+[WebView initialize]):
1432         * WebView/WebViewData.mm: (+[WebViewPrivate initialize]):
1433
1434 2014-03-26  Timothy Hatcher  <timothy@apple.com>
1435
1436         Propagate the hiddenFromInspector flag on ResourceRequest in
1437         places when a new request a made or passed between processes.
1438
1439         https://bugs.webkit.org/show_bug.cgi?id=130741
1440
1441         Reviewed by Joseph Pecoraro.
1442
1443         * WebCoreSupport/WebFrameLoaderClient.mm:
1444         (WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
1445         the new request.
1446
1447 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
1448
1449         [CSS Shapes] Remove shape-inside support
1450         https://bugs.webkit.org/show_bug.cgi?id=130698
1451
1452         Reviewed by David Hyatt.
1453
1454         * Configurations/FeatureDefines.xcconfig:
1455
1456 2014-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1457
1458         [iOS] Inspector View Indication Support
1459         https://bugs.webkit.org/show_bug.cgi?id=130709
1460
1461         Reviewed by Simon Fraser.
1462
1463         * WebCoreSupport/WebInspectorClient.h:
1464         * WebCoreSupport/WebInspectorClient.mm:
1465         (WebInspectorClient::didSetSearchingForNode): Deleted.
1466         (WebInspectorClient::releaseFrontend): Deleted.
1467         * WebView/WebView.mm:
1468         (-[WebView setShowingInspectorIndication:]):
1469         * WebView/WebViewPrivate.h:
1470         Renamed methods.
1471
1472 2014-03-24  Brent Fulgham  <bfulgham@apple.com>
1473
1474         Activate WebVTT Tests Once Merging is Complete
1475         https://bugs.webkit.org/show_bug.cgi?id=130420
1476
1477         Reviewed by Eric Carlson.
1478
1479         * Configurations/FeatureDefines.xcconfig: Turn on ENABLE(WEBVTT_REGIONS)
1480
1481 2014-03-24  Andy Estes  <aestes@apple.com>
1482
1483         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
1484         https://bugs.webkit.org/show_bug.cgi?id=129322
1485
1486         Reviewed by Anders Carlsson.
1487
1488         * WebCoreSupport/WebFrameLoaderClient.mm:
1489         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Use the
1490         RetainPtr returned by releaseConnectionForDownload() rather than
1491         manually releasing.
1492
1493 2014-03-24  Jon Lee  <jonlee@apple.com>
1494
1495         Build fixes.
1496
1497         Unreviewed.
1498
1499         * WebInspector/WebNodeHighlightView.mm: Missing include to GeometryUtilities.
1500
1501 2014-03-23  Sam Weinig  <sam@webkit.org>
1502
1503         Remove some unnecessary .get()s that Darin noticed.
1504
1505         * WebView/WebHTMLRepresentation.mm:
1506         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1507         * WebView/WebHTMLView.mm:
1508         (-[WebHTMLView attributedString]):
1509
1510 2014-03-23  Sam Weinig  <sam@webkit.org>
1511
1512         Simplify the HTMLConverter interface (Part 2)
1513         https://bugs.webkit.org/show_bug.cgi?id=130654
1514
1515         Reviewed by Darin Adler.
1516
1517         * WebView/WebHTMLRepresentation.mm:
1518         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
1519         * WebView/WebHTMLView.mm:
1520         (-[WebHTMLView attributedSubstringFromRange:]):
1521         (-[WebHTMLView attributedString]):
1522         (-[WebHTMLView selectedAttributedString]):
1523
1524 2014-03-23  Darin Adler  <darin@apple.com>
1525
1526         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1527         https://bugs.webkit.org/show_bug.cgi?id=130653
1528
1529         Reviewed by Antti Koivisto.
1530
1531         * WebCoreSupport/WebFrameLoaderClient.mm: Call toHTMLPlugInImageElement instead of
1532         doing a static_cast.
1533
1534 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1535
1536         Don't flush compositing layers within FrameView::willPaintContents()
1537         https://bugs.webkit.org/show_bug.cgi?id=130627
1538
1539         Reviewed by Sam Weinig.
1540         
1541         Make _flushCompositingChanges private so DRT can call it;
1542         moved it into the Private category.
1543
1544         * WebView/WebView.mm:
1545         (-[WebView _flushCompositingChanges]):
1546         * WebView/WebViewPrivate.h:
1547
1548 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1549
1550         Remove duplicate line added during merging
1551         https://bugs.webkit.org/show_bug.cgi?id=130623
1552
1553         Reviewed by Beth Dakin.
1554         
1555         Remove a duplicate call to -_viewWillDrawInternal which
1556         was added during merges.
1557
1558         * WebView/WebView.mm:
1559         (LayerFlushController::flushLayers):
1560
1561 2014-03-21  Darin Adler  <darin@apple.com>
1562
1563         Improve idiom used for string building in a few places
1564         https://bugs.webkit.org/show_bug.cgi?id=130561
1565
1566         Reviewed by Andreas Kling.
1567
1568         * WebView/WebHTMLRepresentation.mm:
1569         (regExpForLabels): Use StringBuilder.
1570
1571 2014-03-21  Darin Adler  <darin@apple.com>
1572
1573         Add a combined decodeAndFlush to TextResourceDecoder
1574         https://bugs.webkit.org/show_bug.cgi?id=130560
1575
1576         Reviewed by Andreas Kling.
1577
1578         * WebView/WebView.mm:
1579         (+[WebView _decodeData:]): Use decodeAndFlush.
1580
1581 2014-03-20  Anders Carlsson  <andersca@apple.com>
1582
1583         Fix build.
1584
1585         * MigrateHeaders.make:
1586
1587 2014-03-20  Pratik Solanki  <psolanki@apple.com>
1588
1589         [iOS] Get code to compile on older iOS versions
1590         https://bugs.webkit.org/show_bug.cgi?id=130142
1591         <rdar://problem/16302908>
1592
1593         Reviewed by Darin Adler.
1594
1595         * History/WebHistory.mm:
1596         (getDayBoundaries):
1597         * Plugins/WebPluginController.h:
1598         * Plugins/WebPluginController.mm:
1599         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1600         * WebCoreSupport/WebFrameLoaderClient.mm:
1601         (pluginView):
1602         * WebView/WebPreferences.mm:
1603         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
1604         * WebView/WebPreferencesPrivate.h:
1605
1606 2014-03-20  Lucas Forschler  <lforschler@apple.com>
1607
1608     Rollout r165944.  Build break.
1609     
1610 2014-03-19  Pratik Solanki  <psolanki@apple.com>
1611
1612         [iOS] Get code to compile on older iOS versions
1613         https://bugs.webkit.org/show_bug.cgi?id=130142
1614         <rdar://problem/16302908>
1615
1616         Reviewed by Darin Adler.
1617
1618         * History/WebHistory.mm:
1619         (getDayBoundaries):
1620         * Plugins/WebPluginController.h:
1621         * Plugins/WebPluginController.mm:
1622         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1623         * WebCoreSupport/WebFrameLoaderClient.mm:
1624         (pluginView):
1625         * WebView/WebPreferences.mm:
1626         (-[WebPreferences _setAllowCompositingLayerVisualDegradation:]):
1627         * WebView/WebPreferencesPrivate.h:
1628
1629 2014-03-19  Jer Noble  <jer.noble@apple.com>
1630
1631         [Mac][EME] Query whether decoder support exists before creating a new MediaKeys object.
1632         https://bugs.webkit.org/show_bug.cgi?id=130459
1633
1634         Reviewed by Eric Carlson.
1635
1636         * WebCoreSupport/WebSystemInterface.mm:
1637         (InitWebCoreSystemInterface): Initialize the new WCSI method.
1638
1639 2014-03-19  Brady Eidson  <beidson@apple.com>
1640
1641         Filter out editable services from image menu for non-contenteditable images
1642         <rdar://problem/16319645> and https://bugs.webkit.org/show_bug.cgi?id=130437
1643
1644         Reviewed by Tim Horton.
1645
1646         * Misc/WebSharingServicePickerController.h:
1647         * Misc/WebSharingServicePickerController.mm:
1648         (-[WebSharingServicePickerController sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
1649           Filter out editing services based on the includeEditorServices flag.
1650         * WebCoreSupport/WebContextMenuClient.mm:
1651         (WebContextMenuClient::contextMenuForEvent):
1652
1653 2014-03-19  Jer Noble  <jer.noble@apple.com>
1654
1655         [iOS] Disable the video plugin proxy by default on WK1.
1656         https://bugs.webkit.org/show_bug.cgi?id=130460
1657
1658         Reviewed by Eric Carlson.
1659
1660         Update the defaults to universally enable the AVFoundationEnabled preference, disable the
1661         VideoPluginProxyEnabled preference, and on iOS only enable the AVKitEnabled preference.
1662
1663         * WebView/WebPreferences.mm:
1664         (+[WebPreferences initialize]):
1665
1666 2014-03-18  Samuel White  <samuel_white@apple.com>
1667
1668         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
1669         https://bugs.webkit.org/show_bug.cgi?id=130250
1670
1671         Reviewed by Chris Fleizach.
1672
1673         Added ability to toggle enhanced accessibility on and off to support tests that require it.
1674
1675         * WebView/WebFrame.mm:
1676         (-[WebFrame enhancedAccessibilityEnabled]):
1677         (-[WebFrame setEnhancedAccessibility:]):
1678         * WebView/WebFramePrivate.h:
1679
1680 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
1681
1682         More FTL enabling.
1683
1684         Rubber stamped by Dan Bernstein.
1685
1686         * Configurations/FeatureDefines.xcconfig:
1687
1688 2014-03-17  Andy Estes  <aestes@apple.com>
1689
1690         Remove staging code added for <http://webkit.org/b/129358> [iOS] Support network state notification using CPNetworkObserver
1691
1692         Reviewed by Enrica Casucci.
1693
1694         * WebView/WebView.mm:
1695
1696 2014-03-17  Anders Carlsson  <andersca@apple.com>
1697
1698         WebKitLegacy headers should #import the relevant WebKit headers
1699         https://bugs.webkit.org/show_bug.cgi?id=130372
1700         <rdar://problem/16349094>
1701
1702         Reviewed by Dan Bernstein.
1703
1704         Create forwarding headers instead.
1705
1706         * WebKitLegacy/MigrateHeadersToLegacy.make:
1707
1708 2014-03-17  Tim Horton  <timothy_horton@apple.com>
1709
1710         Rename WKThumbnailView to _WKThumbnailView
1711         https://bugs.webkit.org/show_bug.cgi?id=130361
1712
1713         Reviewed by Anders Carlsson.
1714
1715         * MigrateHeaders.make:
1716
1717 2014-03-17  David Farler  <dfarler@apple.com>
1718
1719         REGRESSION: WebKitLegacy causes ASan build to fail
1720         <rdar://problem/16344326>
1721
1722         Reviewed by David Kilzer.
1723
1724         * Configurations/DebugRelease.xcconfig: Remove $(inherited) from
1725         OTHER_CFLAGS, OTHER_CPLUSPLUSFLAGS, OTHER_LDFLAGS to prevent
1726         double complete ASAN flags.
1727
1728 2014-03-16  Brent Fulgham  <bfulgham@apple.com>
1729
1730         Provide preference to enable additional AVFoundation options
1731         https://bugs.webkit.org/show_bug.cgi?id=130275
1732
1733         Reviewed by Eric Carlson.
1734
1735         * WebView/WebPreferenceKeysPrivate.h: Added new preference.
1736         * WebView/WebPreferences.mm:
1737         (+[WebPreferences initialize]): Initialize preference to false.
1738         (-[WebPreferences isInheritURIQueryComponentEnabled]): Added.
1739         (-[WebPreferences setEnableInheritURIQueryComponent:]): Added.
1740         * WebView/WebPreferencesPrivate.h:
1741         * WebView/WebView.mm:
1742         (-[WebView _preferencesChanged:]): Handle new preference.
1743
1744 2014-03-16  Darin Adler  <darin@apple.com>
1745
1746         Remove all deprecatedCharacters use from WebKit directory
1747         https://bugs.webkit.org/show_bug.cgi?id=130305
1748
1749         Reviewed by Andreas Kling.
1750
1751         * History/BinaryPropertyList.cpp:
1752         (BinaryPropertyListSerializer::appendStringObject): Use operator[]
1753         instead of deprecatedCharacters.
1754
1755 2014-03-14  Mark Rowe  <mrowe@apple.com>
1756
1757         Fix the production build.
1758
1759         Don't rely on USE_INTERNAL_SDK being set for the Production configuration since UseInternalSDK.xcconfig won't
1760         be at the expected relative path when working from installed source.
1761
1762         * Configurations/Base.xcconfig:
1763
1764 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
1765
1766         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
1767         https://bugs.webkit.org/show_bug.cgi?id=130276
1768         <rdar://problem/16266927>
1769         
1770         Reviewed by Simon Fraser.
1771
1772         * Carbon/CarbonUtils.h:
1773         * Carbon/CarbonUtils.m:
1774         * Carbon/CarbonWindowAdapter.h:
1775         * Carbon/CarbonWindowAdapter.mm:
1776         * Carbon/CarbonWindowContentView.h:
1777         * Carbon/CarbonWindowContentView.m:
1778         * Carbon/CarbonWindowFrame.h:
1779         * Carbon/CarbonWindowFrame.m:
1780         * Carbon/HIViewAdapter.h:
1781         * Carbon/HIViewAdapter.m:
1782         * Carbon/HIWebView.h:
1783         * Carbon/HIWebView.mm:
1784         * DOM/WebDOMOperations.h:
1785         * DOM/WebDOMOperations.mm:
1786         * DOM/WebDOMOperationsInternal.h:
1787         * DOM/WebDOMOperationsPrivate.h:
1788         * DefaultDelegates/WebDefaultContextMenuDelegate.h:
1789         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1790         * DefaultDelegates/WebDefaultEditingDelegate.h:
1791         * DefaultDelegates/WebDefaultEditingDelegate.m:
1792         * DefaultDelegates/WebDefaultPolicyDelegate.h:
1793         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1794         * DefaultDelegates/WebDefaultUIDelegate.h:
1795         * DefaultDelegates/WebDefaultUIDelegate.m:
1796         * History/WebBackForwardList.h:
1797         * History/WebBackForwardList.mm:
1798         * History/WebBackForwardListInternal.h:
1799         * History/WebBackForwardListPrivate.h:
1800         * History/WebHistory.h:
1801         * History/WebHistory.mm:
1802         * History/WebHistoryInternal.h:
1803         * History/WebHistoryItem.h:
1804         * History/WebHistoryItem.mm:
1805         * History/WebHistoryItemInternal.h:
1806         * History/WebHistoryItemPrivate.h:
1807         * History/WebHistoryPrivate.h:
1808         * History/WebURLsWithTitles.h:
1809         * History/WebURLsWithTitles.m:
1810         * MigrateHeaders.make:
1811         * Misc/OldWebAssertions.c:
1812         * Misc/WebCache.h:
1813         * Misc/WebCache.mm:
1814         * Misc/WebCoreStatistics.h:
1815         * Misc/WebCoreStatistics.mm:
1816         * Misc/WebDownload.h:
1817         * Misc/WebDownload.mm:
1818         * Misc/WebDownloadInternal.h:
1819         * Misc/WebElementDictionary.h:
1820         * Misc/WebElementDictionary.mm:
1821         * Misc/WebIconDatabase.h:
1822         * Misc/WebIconDatabase.mm:
1823         * Misc/WebIconDatabaseDelegate.h:
1824         * Misc/WebIconDatabaseInternal.h:
1825         * Misc/WebIconDatabasePrivate.h:
1826         * Misc/WebKit.h:
1827         * Misc/WebKitErrors.h:
1828         * Misc/WebKitErrors.m:
1829         * Misc/WebKitErrorsPrivate.h:
1830         * Misc/WebKitLogging.h:
1831         * Misc/WebKitLogging.m:
1832         * Misc/WebKitNSStringExtras.h:
1833         * Misc/WebKitNSStringExtras.mm:
1834         * Misc/WebKitStatistics.h:
1835         * Misc/WebKitStatistics.m:
1836         * Misc/WebKitStatisticsPrivate.h:
1837         * Misc/WebKitSystemBits.h:
1838         * Misc/WebKitSystemBits.m:
1839         * Misc/WebKitVersionChecks.h:
1840         * Misc/WebKitVersionChecks.m:
1841         * Misc/WebLocalizableStrings.h:
1842         * Misc/WebLocalizableStrings.mm:
1843         * Misc/WebNSArrayExtras.h:
1844         * Misc/WebNSArrayExtras.m:
1845         * Misc/WebNSControlExtras.h:
1846         * Misc/WebNSControlExtras.m:
1847         * Misc/WebNSDataExtras.h:
1848         * Misc/WebNSDataExtras.m:
1849         * Misc/WebNSDataExtrasPrivate.h:
1850         * Misc/WebNSDictionaryExtras.h:
1851         * Misc/WebNSDictionaryExtras.m:
1852         * Misc/WebNSEventExtras.h:
1853         * Misc/WebNSEventExtras.m:
1854         * Misc/WebNSFileManagerExtras.h:
1855         * Misc/WebNSFileManagerExtras.mm:
1856         * Misc/WebNSImageExtras.h:
1857         * Misc/WebNSImageExtras.m:
1858         * Misc/WebNSObjectExtras.h:
1859         * Misc/WebNSObjectExtras.mm:
1860         * Misc/WebNSPasteboardExtras.h:
1861         * Misc/WebNSPasteboardExtras.mm:
1862         * Misc/WebNSPrintOperationExtras.h:
1863         * Misc/WebNSPrintOperationExtras.m:
1864         * Misc/WebNSURLExtras.h:
1865         * Misc/WebNSURLExtras.mm:
1866         * Misc/WebNSURLRequestExtras.h:
1867         * Misc/WebNSURLRequestExtras.m:
1868         * Misc/WebNSUserDefaultsExtras.h:
1869         * Misc/WebNSUserDefaultsExtras.mm:
1870         * Misc/WebNSViewExtras.h:
1871         * Misc/WebNSViewExtras.m:
1872         * Misc/WebNSWindowExtras.h:
1873         * Misc/WebNSWindowExtras.m:
1874         * Misc/WebStringTruncator.h:
1875         * Misc/WebStringTruncator.mm:
1876         * Misc/WebTypesInternal.h:
1877         * Panels/WebAuthenticationPanel.h:
1878         * Panels/WebAuthenticationPanel.m:
1879         * Panels/WebPanelAuthenticationHandler.h:
1880         * Panels/WebPanelAuthenticationHandler.m:
1881         * Plugins/Hosted/ProxyRuntimeObject.h:
1882         * Plugins/Hosted/ProxyRuntimeObject.mm:
1883         * Plugins/WebBaseNetscapePluginView.h:
1884         * Plugins/WebBaseNetscapePluginView.mm:
1885         * Plugins/WebBasePluginPackage.h:
1886         * Plugins/WebBasePluginPackage.mm:
1887         * Plugins/WebJavaPlugIn.h:
1888         * Plugins/WebNetscapeContainerCheckContextInfo.h:
1889         * Plugins/WebNetscapeContainerCheckPrivate.h:
1890         * Plugins/WebNetscapeContainerCheckPrivate.mm:
1891         * Plugins/WebNetscapePluginPackage.h:
1892         * Plugins/WebNetscapePluginPackage.mm:
1893         * Plugins/WebNetscapePluginStream.h:
1894         * Plugins/WebNetscapePluginStream.mm:
1895         * Plugins/WebNetscapePluginView.h:
1896         * Plugins/WebNetscapePluginView.mm:
1897         * Plugins/WebPlugin.h:
1898         * Plugins/WebPluginContainer.h:
1899         * Plugins/WebPluginContainerCheck.h:
1900         * Plugins/WebPluginContainerCheck.mm:
1901         * Plugins/WebPluginContainerPrivate.h:
1902         * Plugins/WebPluginController.h:
1903         * Plugins/WebPluginController.mm:
1904         * Plugins/WebPluginDatabase.h:
1905         * Plugins/WebPluginDatabase.mm:
1906         * Plugins/WebPluginPackage.h:
1907         * Plugins/WebPluginPackage.mm:
1908         * Plugins/WebPluginRequest.h:
1909         * Plugins/WebPluginRequest.m:
1910         * Plugins/WebPluginViewFactory.h:
1911         * Plugins/WebPluginViewFactoryPrivate.h:
1912         * Plugins/WebPluginsPrivate.h:
1913         * Plugins/WebPluginsPrivate.m:
1914         * Plugins/npapi.mm:
1915         * Storage/WebDatabaseManager.mm:
1916         * Storage/WebDatabaseManagerInternal.h:
1917         * Storage/WebDatabaseManagerPrivate.h:
1918         * WebCoreSupport/SearchPopupMenuMac.mm:
1919         * WebCoreSupport/WebAlternativeTextClient.h:
1920         * WebCoreSupport/WebAlternativeTextClient.mm:
1921         * WebCoreSupport/WebCachedFramePlatformData.h:
1922         * WebCoreSupport/WebChromeClient.h:
1923         * WebCoreSupport/WebChromeClient.mm:
1924         * WebCoreSupport/WebContextMenuClient.h:
1925         * WebCoreSupport/WebContextMenuClient.mm:
1926         * WebCoreSupport/WebDragClient.h:
1927         * WebCoreSupport/WebDragClient.mm:
1928         * WebCoreSupport/WebEditorClient.h:
1929         * WebCoreSupport/WebEditorClient.mm:
1930         * WebCoreSupport/WebFrameLoaderClient.h:
1931         * WebCoreSupport/WebFrameLoaderClient.mm:
1932         * WebCoreSupport/WebIconDatabaseClient.h:
1933         * WebCoreSupport/WebIconDatabaseClient.mm:
1934         * WebCoreSupport/WebInspectorClient.h:
1935         * WebCoreSupport/WebInspectorClient.mm:
1936         * WebCoreSupport/WebJavaScriptTextInputPanel.h:
1937         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1938         * WebCoreSupport/WebSecurityOrigin.mm:
1939         * WebCoreSupport/WebSecurityOriginInternal.h:
1940         * WebCoreSupport/WebSecurityOriginPrivate.h:
1941         * WebCoreSupport/WebSystemInterface.h:
1942         * WebCoreSupport/WebSystemInterface.mm:
1943         * WebInspector/WebInspector.h:
1944         * WebInspector/WebInspector.mm:
1945         * WebInspector/WebInspectorPrivate.h:
1946         * WebInspector/WebNodeHighlight.h:
1947         * WebInspector/WebNodeHighlight.mm:
1948         * WebInspector/WebNodeHighlightView.h:
1949         * WebInspector/WebNodeHighlightView.mm:
1950         * WebInspector/WebNodeHighlighter.h:
1951         * WebInspector/WebNodeHighlighter.mm:
1952         * WebKitLegacy/MigrateHeadersToLegacy.make:
1953         * WebKitPrefix.h:
1954         * WebView/WebArchive.h:
1955         * WebView/WebArchive.mm:
1956         * WebView/WebArchiveInternal.h:
1957         * WebView/WebClipView.h:
1958         * WebView/WebClipView.mm:
1959         * WebView/WebDashboardRegion.h:
1960         * WebView/WebDashboardRegion.mm:
1961         * WebView/WebDataSource.h:
1962         * WebView/WebDataSource.mm:
1963         * WebView/WebDataSourceInternal.h:
1964         * WebView/WebDataSourcePrivate.h:
1965         * WebView/WebDelegateImplementationCaching.h:
1966         * WebView/WebDelegateImplementationCaching.mm:
1967         * WebView/WebDocument.h:
1968         * WebView/WebDocumentInternal.h:
1969         * WebView/WebDocumentLoaderMac.h:
1970         * WebView/WebDocumentLoaderMac.mm:
1971         * WebView/WebDocumentPrivate.h:
1972         * WebView/WebDynamicScrollBarsViewInternal.h:
1973         * WebView/WebEditingDelegate.h:
1974         * WebView/WebEditingDelegatePrivate.h:
1975         * WebView/WebFormDelegate.h:
1976         * WebView/WebFormDelegate.m:
1977         * WebView/WebFormDelegatePrivate.h:
1978         * WebView/WebFrame.h:
1979         * WebView/WebFrame.mm:
1980         * WebView/WebFrameInternal.h:
1981         * WebView/WebFrameLoadDelegate.h:
1982         * WebView/WebFrameLoadDelegatePrivate.h:
1983         * WebView/WebFramePrivate.h:
1984         * WebView/WebFrameView.h:
1985         * WebView/WebFrameView.mm:
1986         * WebView/WebFrameViewInternal.h:
1987         * WebView/WebFrameViewPrivate.h:
1988         * WebView/WebHTMLRepresentation.h:
1989         * WebView/WebHTMLRepresentation.mm:
1990         * WebView/WebHTMLRepresentationPrivate.h:
1991         * WebView/WebHTMLView.h:
1992         * WebView/WebHTMLView.mm:
1993         * WebView/WebHTMLViewInternal.h:
1994         * WebView/WebHTMLViewPrivate.h:
1995         * WebView/WebNotification.h:
1996         * WebView/WebNotification.mm:
1997         * WebView/WebNotificationInternal.h:
1998         * WebView/WebPDFRepresentation.h:
1999         * WebView/WebPDFRepresentation.mm:
2000         * WebView/WebPDFView.h:
2001         * WebView/WebPDFView.mm:
2002         * WebView/WebPolicyDelegate.h:
2003         * WebView/WebPolicyDelegate.mm:
2004         * WebView/WebPolicyDelegatePrivate.h:
2005         * WebView/WebPreferenceKeysPrivate.h:
2006         * WebView/WebPreferences.h:
2007         * WebView/WebPreferences.mm:
2008         * WebView/WebPreferencesPrivate.h:
2009         * WebView/WebRenderLayer.h:
2010         * WebView/WebRenderLayer.mm:
2011         * WebView/WebRenderNode.h:
2012         * WebView/WebRenderNode.mm:
2013         * WebView/WebResource.h:
2014         * WebView/WebResource.mm:
2015         * WebView/WebResourceInternal.h:
2016         * WebView/WebResourceLoadDelegate.h:
2017         * WebView/WebResourceLoadDelegatePrivate.h:
2018         * WebView/WebResourcePrivate.h:
2019         * WebView/WebScriptDebugDelegate.h:
2020         * WebView/WebScriptDebugDelegate.mm:
2021         * WebView/WebScriptDebugger.h:
2022         * WebView/WebScriptDebugger.mm:
2023         * WebView/WebTextCompletionController.mm:
2024         * WebView/WebUIDelegate.h:
2025         * WebView/WebUIDelegatePrivate.h:
2026         * WebView/WebView.h:
2027         * WebView/WebView.mm:
2028         * WebView/WebViewData.h:
2029         * WebView/WebViewData.mm:
2030         * WebView/WebViewInternal.h:
2031         * WebView/WebViewPrivate.h:
2032
2033 2014-03-14  Ryosuke Niwa  <rniwa@webkit.org>
2034
2035         REGRESSION(r165385): [WebTextIterator currentRange] crashes
2036         https://bugs.webkit.org/show_bug.cgi?id=130271
2037
2038         Reviewed by Anders Carlsson.
2039
2040         After r165385, TextIterator::range no longer checked the nullity of m_positionNode. As a result,
2041         [WebTextIterator currentRange] which simply calls TextIterator::range crashes when an application
2042         that embeds WebKit doesn't check [WebTextIterator atEnd] first.
2043
2044         Preserve the old public API behavior by checking atEnd in [WebTextIterator currentRange].
2045
2046         * WebView/WebTextIterator.mm:
2047         (-[WebTextIterator currentRange]):
2048
2049 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
2050
2051         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
2052         https://bugs.webkit.org/show_bug.cgi?id=129612
2053
2054         Reviewed by Darin Adler.
2055
2056         For new code use static NeverDestroyed<T> instead.
2057
2058         * History/WebBackForwardList.mm:
2059         (backForwardLists):
2060         * History/WebHistoryItem.mm:
2061         (historyItemWrappers):
2062         * Misc/WebNSPasteboardExtras.mm:
2063         (+[NSPasteboard _web_writableTypesForURL]):
2064         (_writableTypesForImageWithoutArchive):
2065         (_writableTypesForImageWithArchive):
2066         * Misc/WebStringTruncator.mm:
2067         (fontFromNSFont):
2068         * Plugins/Hosted/NetscapePluginHostManager.mm:
2069         (WebKit::NetscapePluginHostManager::shared):
2070         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2071         (WebKit::pluginProxyMap):
2072         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2073         (WebKit::globalExceptionString):
2074         * Plugins/Hosted/ProxyInstance.mm:
2075         (WebKit::proxyClass):
2076         * Plugins/WebNetscapePluginStream.mm:
2077         (streams):
2078         * Storage/WebDatabaseManager.mm:
2079         (transactionBackgroundTaskIdentifierLock):
2080         * WebCoreSupport/WebUserMediaClient.mm:
2081         (userMediaRequestsMap):
2082         * WebView/WebHTMLRepresentation.mm:
2083         (regExpForLabels):
2084         * WebView/WebView.mm:
2085         (aeDescFromJSValue):
2086
2087 2014-03-13  Tim Horton  <timothy_horton@apple.com>
2088
2089         Fix relative paths to UseInternalSDK.xcconfig for ANGLE and WebKit/mac
2090
2091         Rubber-stamped by Mark Rowe.
2092
2093         One-too-few "..".
2094
2095         * Configurations/Base.xcconfig:
2096
2097 2014-03-13  Anders Carlsson  <andersca@apple.com>
2098
2099         Fix build.
2100
2101         * Misc/WebSharingServicePickerController.mm:
2102
2103 2014-03-13  Radu Stavila  <stavila@adobe.com>
2104
2105         Webkit not building on XCode 5.1 due to garbage collection no longer being supported
2106         https://bugs.webkit.org/show_bug.cgi?id=130087
2107
2108         Reviewed by Mark Rowe.
2109
2110         Disable garbage collection on macosx when not using internal SDK.
2111
2112         * Configurations/Base.xcconfig:
2113
2114 2014-03-10  Darin Adler  <darin@apple.com>
2115
2116         Avoid copy-prone idiom "for (auto item : collection)"
2117         https://bugs.webkit.org/show_bug.cgi?id=129990
2118
2119         Reviewed by Geoffrey Garen.
2120
2121         * WebView/WebFrame.mm:
2122         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
2123         Use auto*. Also removed uneeded ASSERT_NO_EXCEPTION, which is already
2124         the default without specifying it explicitly.
2125
2126 2014-03-12  Brian Burg  <bburg@apple.com>
2127
2128         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
2129         https://bugs.webkit.org/show_bug.cgi?id=129744
2130
2131         Reviewed by Timothy Hatcher.
2132
2133         * WebInspector/WebInspector.mm:
2134         (-[WebInspector evaluateInFrontend:script:]):
2135         * WebInspector/WebInspectorPrivate.h:
2136
2137 2014-03-12  Dean Jackson  <dino@apple.com>
2138
2139         [WebGL] WebKit1 + WebKit2 iOS clients should check load policy
2140         https://bugs.webkit.org/show_bug.cgi?id=130162
2141
2142         Reviewed by Simon Fraser.
2143
2144         Implement the webGLPolicyForURL methods, calling into WebKitSystemInterface.
2145
2146         * Configurations/WebKit.xcconfig: Add MobileAsset to iOS config.
2147         * WebCoreSupport/WebFrameLoaderClient.h:
2148         * WebCoreSupport/WebFrameLoaderClient.mm:
2149
2150 2014-03-12  Joseph Pecoraro  <pecoraro@apple.com>
2151
2152         Web Inspector: Disable REMOTE_INSPECTOR in earlier OS X releases
2153         https://bugs.webkit.org/show_bug.cgi?id=130118
2154
2155         Reviewed by Timothy Hatcher.
2156
2157         * Configurations/FeatureDefines.xcconfig:
2158
2159         * WebCoreSupport/WebInspectorClient.mm:
2160         (WebInspectorClient::indicate):
2161         (WebInspectorClient::hideIndication):
2162         Properly guard REMOTE_INSPECTOR only calls.
2163
2164 2014-03-12  Tim Horton  <timothy_horton@apple.com>
2165
2166         Build fix for ENABLE(IMAGE_CONTROLS) after 165479
2167
2168         * Misc/WebSharingServicePickerController.h:
2169         * Misc/WebSharingServicePickerController.mm:
2170         Don't use new-runtime features in code that has to build 32-bit.
2171
2172 2014-03-12  Anders Carlsson  <andersca@apple.com>
2173
2174         <rdar://problem/16307346> Add new WebKitLegacy.framework.
2175
2176         Reviewed by Dan Bernstein.
2177
2178         * Configurations/WebKitLegacy.xcconfig:
2179         Add xcconfig file for the new framework.
2180
2181         * WebKitLegacy/Info.plist:
2182         Add Info.plist for WebKitLegacy.framework.
2183
2184         * WebKitLegacy/MigrateHeadersToLegacy.make:
2185         Add makefile that copies headers from WebKit to WebKitLegacy and rewrites includes from WebKit/ to WebKitLegacy/
2186         * WebKitLegacy/WebKitLegacy.cpp:
2187         Add an empty file so we'll have something to link.
2188
2189 2014-03-12  Tim Horton  <timothy_horton@apple.com>
2190
2191         Hook up image controls for WebKit1
2192         https://bugs.webkit.org/show_bug.cgi?id=130062
2193         <rdar://problem/15964809>
2194
2195         Reviewed by Brady Eidson.
2196
2197         * Misc/WebSharingServicePickerController.h: Added.
2198         * Misc/WebSharingServicePickerController.mm: Added.
2199         (-[WebSharingServicePickerController initWithImage:menuClient:]):
2200         (-[WebSharingServicePickerController menu]):
2201         (-[WebSharingServicePickerController sharingServicePicker:delegateForSharingService:]):
2202         (-[WebSharingServicePickerController sharingServicePicker:didChooseSharingService:]):
2203         (-[WebSharingServicePickerController sharingService:didShareItems:]):
2204         (-[WebSharingServicePickerController sharingService:didFailToShareItems:error:]):
2205         (-[WebSharingServicePickerController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2206         Add a NSSharingServiceDelegate and NSSharingServicePickerDelegate, which will also
2207         provide a NSMenu instance for WebContextMenuClient to pop up when image controls are needed.
2208         When data is returned from the service, it is re-inserted into the image via replaceControlledImage.
2209
2210         * WebCoreSupport/WebContextMenuClient.h:
2211         * WebCoreSupport/WebContextMenuClient.mm:
2212         (WebContextMenuClient::contextMenuForEvent):
2213         Factor out code to decide which NSMenu to use, so that we can use early-returns to simplify it.
2214         If we hit an image with image controls, use the WebSharingServicePickerController's menu.
2215
2216         (WebContextMenuClient::showContextMenu):
2217         (WebContextMenuClient::clearSharingServicePickerController):
2218
2219 2014-03-10  Jer Noble  <jer.noble@apple.com>
2220
2221         [iOS][WK1] Crash in HTMLMediaElement::createElementRenderer() - "-[NSSet addObject:]: object cannot be nil"
2222         https://bugs.webkit.org/show_bug.cgi?id=129634
2223
2224         Reviewed by Eric Carlson.
2225
2226         If a plugin fails to create a NSView, a nil object is inserted into the WebPluginController's
2227         pluginViews set. This is an exceptional case, so add an ASSERT so that this error will continue
2228         to occur in debug builds, but also add an early return so as not to crash release builds.
2229
2230         * Plugins/WebPluginController.mm:
2231         (+[WebPluginController addPlugInView:]):
2232
2233 2014-03-06  Alexey Proskuryakov  <ap@apple.com>
2234
2235         [Mac] Don't perform a round-trip through WebProcess before interpreting key events
2236         https://bugs.webkit.org/show_bug.cgi?id=129812
2237
2238         Reviewed by Darin Adler.
2239
2240         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleInputMethodKeydown):
2241         Added a FIXME. WebKit1/mac is the only port that uses this roundabout way to
2242         interpret events, so it would simplify code if we switched it to WebKit2/mac model.
2243
2244 2014-03-08  Simon Fraser  <simon.fraser@apple.com>
2245
2246         [iOS Wk2] Can't scroll after going back to page in page cache
2247         https://bugs.webkit.org/show_bug.cgi?id=129989
2248         <rdar://problem/16217588>
2249
2250         Reviewed by Dan Bernstein.
2251
2252         iOS has a special FrameLoader::forceLayoutWithoutRecalculatingStyle()
2253         function that is called instead of FrameView::forceLayout(). This was unimplemented
2254         for the WK2 FrameLoaderClient, so no layout was forced, with the result
2255         that the contentSize was never updated and scrolling was broken.
2256         
2257         Fix by renaming the client function to forceLayoutOnRestoreFromPageCache()
2258         and having it return a bool to say whether the default forceLayout()
2259         should be done. WK1 can then continue to have its custom behavior,
2260         and Wk2 will simply do a forceLayout().
2261         
2262         Also remove FrameLaoderClient::forceLayout(), which was never called.
2263
2264         * WebCoreSupport/WebFrameLoaderClient.h:
2265         * WebCoreSupport/WebFrameLoaderClient.mm:
2266         (WebFrameLoaderClient::forceLayoutOnRestoreFromPageCache):
2267
2268 2014-03-07  Anders Carlsson  <andersca@apple.com>
2269
2270         Add the remaining WebKit2 headers to WEBKIT2_HEADERS
2271         https://bugs.webkit.org/show_bug.cgi?id=129942
2272         <rdar://problem/15920020>
2273
2274         Reviewed by Tim Horton.
2275
2276         * MigrateHeaders.make:
2277
2278 2014-03-07  Anders Carlsson  <andersca@apple.com>
2279
2280         MigrateHeaders.make should remove C SPI includes from WebKit2 headers
2281         https://bugs.webkit.org/show_bug.cgi?id=129937
2282         <rdar://problem/15920020>
2283
2284         Reviewed by Tim Horton.
2285
2286         * MigrateHeaders.make:
2287         Add WKPreferences.h to WEBKIT2_HEADERS. 
2288         Add a sed rule that deletes all lines that start with a # and contain <WebKit/*Ref.h>.
2289
2290 2014-03-07  Anders Carlsson  <andersca@apple.com>
2291
2292         Make it possible to copy WebKit2 headers to WebKit.framework
2293         https://bugs.webkit.org/show_bug.cgi?id=129935
2294         <rdar://problem/15920020>
2295
2296         Reviewed by Dan Bernstein.
2297
2298         * MigrateHeaders.make:
2299         Gather a list of public and private WebKit2 headers and filter them against the WEBKIT2_HEADERS list.
2300         The matching headers are copied to the respective Headers or PrivateHeaders directories under WebKit.framework,
2301         and also have their #imports rewritten to reference WebKit instead of WebKit2.
2302
2303         * migrate-headers.sh: Added.
2304         Set up the WEBKIT2_FRAMEWORKS_DIR if needed.
2305
2306 2014-03-07  Anders Carlsson  <andersca@apple.com>
2307
2308         Fix a typo
2309         <rdar://problem/15920020>
2310
2311         Rubber-stamped by Dan Bernstein.
2312
2313         * Configurations/WebKit.xcconfig:
2314
2315 2014-03-07  Anders Carlsson  <andersca@apple.com>
2316
2317         Tweak the WebKit2 frameworks directories
2318         https://bugs.webkit.org/show_bug.cgi?id=129910
2319         <rdar://problem/15920020>
2320
2321         Reviewed by Dan Bernstein.
2322
2323         Use an SDK relative directory for production builds.
2324
2325         * Configurations/WebKit.xcconfig:
2326
2327 2014-03-07  Anders Carlsson  <andersca@apple.com>
2328
2329         Link WebKit.framework against WebKit2.framework and re-export all WebKit2 symbols
2330         https://bugs.webkit.org/show_bug.cgi?id=129901
2331         <rdar://problem/15920020>
2332
2333         Reviewed by Andreas Kling.
2334
2335         * Configurations/WebKit.xcconfig:
2336
2337 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
2338
2339         Web Inspector: Expose the console object in JSContexts to interact with Web Inspector
2340         https://bugs.webkit.org/show_bug.cgi?id=127944
2341
2342         Reviewed by Geoffrey Garen.
2343
2344         * WebCoreSupport/WebChromeClient.h:
2345         * WebCoreSupport/WebChromeClient.mm:
2346         Update namespaces.
2347
2348 2014-03-05  Eric Carlson  <eric.carlson@apple.com>
2349
2350         [iOS] Show external device name/type in placeholder
2351         https://bugs.webkit.org/show_bug.cgi?id=129723
2352
2353         Reviewed by Jer Noble.
2354
2355         * WebCoreSupport/WebSystemInterface.mm:
2356         (InitWebCoreSystemInterface):
2357
2358 2014-03-05  Simon Fraser  <simon.fraser@apple.com>
2359
2360         ObjC exception when dropping files into a WKView: drag and drop uses code from WebKit.framework
2361         https://bugs.webkit.org/show_bug.cgi?id=129752
2362
2363         Reviewed by Enrica Casucci.
2364         
2365         Call URLByCanonicalizingURL() which is implemented in WebCore.
2366
2367         * Misc/WebNSURLExtras.mm:
2368         (-[NSURL _webkit_canonicalize]):
2369
2370 2014-03-04  Zalan Bujtas  <zalan@apple.com>
2371
2372         Enable device pixel repaint rect tracking.
2373         https://bugs.webkit.org/show_bug.cgi?id=129712
2374
2375         Reviewed by Simon Fraser.
2376
2377         Tracked repaint rects are device pixel snapped now to support hiDPI test cases.
2378
2379         * WebView/WebView.mm:
2380         (-[WebView trackedRepaintRects]): Keep existing behavior for now.
2381
2382 2014-03-04  Simon Fraser  <simon.fraser@apple.com>
2383
2384         Allow iOS DumpRenderTree crashes to show application-specific information
2385         https://bugs.webkit.org/show_bug.cgi?id=129705
2386
2387         Reviewed by David Kilzer.
2388
2389         Make the WKSI function SetCrashReportApplicationSpecificInformation available
2390         in iOS simulator builds.
2391
2392         * WebCoreSupport/WebSystemInterface.mm:
2393         (InitWebCoreSystemInterface):
2394
2395 2014-03-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2396
2397         Merge API shims and JSLock
2398         https://bugs.webkit.org/show_bug.cgi?id=129650
2399
2400         Reviewed by Mark Lam.
2401
2402         JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason 
2403         to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.
2404
2405         * WebView/WebFrame.mm:
2406         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2407
2408 2014-03-02  Darin Adler  <darin@apple.com>
2409
2410         Sort Mac platform export files so they merge better
2411         https://bugs.webkit.org/show_bug.cgi?id=129581
2412
2413         Reviewed by Sam Weinig.
2414
2415         * WebKit.exp: Ran the new sort-export-file on this.
2416
2417 2014-03-02  Darin Adler  <darin@apple.com>
2418
2419         Change public text iterator API implementations to not depend on 16-bit character pointers
2420         https://bugs.webkit.org/show_bug.cgi?id=129566
2421
2422         Reviewed by Anders Carlsson.
2423
2424         * WebView/WebTextIterator.mm:
2425         (-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
2426         (-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
2427         next text.
2428         (-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
2429         (-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
2430         probably be removing TextIterator::length eventually.
2431
2432 2014-03-01  Pratik Solanki  <psolanki@apple.com>
2433
2434         [iOS] selectionImageForcingBlackText should return autoreleased object
2435         https://bugs.webkit.org/show_bug.cgi?id=129437
2436         <rdar://problem/15810384>
2437
2438         Reviewed by Darin Adler.
2439
2440         * WebView/WebHTMLView.mm:
2441         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2442
2443 2014-02-28  Dan Bernstein  <mitz@apple.com>
2444
2445         [Mac] Remove MailQuirksUserScript.js
2446         https://bugs.webkit.org/show_bug.cgi?id=129536
2447
2448         Reviewed by Andy Estes.
2449
2450         * Configurations/WebKit.xcconfig: Removed from EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
2451         * Misc/MailQuirksUserScript.js: Removed. This file has been unused since r147447.
2452
2453 2014-02-28  Timothy Hatcher  <timothy@apple.com>
2454
2455         Properly handle when Test.html is not present in Production builds.
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=129506
2458
2459         Reviewed by Joseph Pecoraro.
2460
2461         * WebCoreSupport/WebInspectorClient.mm:
2462         (-[WebInspectorWindowController inspectorTestPagePath]):
2463         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2464
2465 2014-02-27  Brian Burg  <bburg@apple.com>
2466
2467         Web Inspector: model tests should use a special Test.html inspector page
2468         https://bugs.webkit.org/show_bug.cgi?id=129190
2469
2470         Reviewed by Timothy Hatcher.
2471
2472         Support creating a separate test inspector page, based on the value of
2473         InspectorController::isUnderTest(). Modify the navigation policy to check
2474         the URL against both normal and test inspector pages.
2475
2476         * WebCoreSupport/WebInspectorClient.mm:
2477         (WebInspectorClient::openInspectorFrontend):
2478         (-[WebInspectorWindowController init]):
2479         (-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
2480         Move the initial navigation of the inspector page to this method, and change
2481         the URL based on the value of InspectorController::isUnderTest().
2482
2483         (-[WebInspectorWindowController inspectorTestPagePath]): Added.
2484         (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2485
2486 2014-02-27  Pratik Solanki  <psolanki@apple.com>
2487
2488         Assertion failure at CachedResource.h:196: ASSERT(!m_purgeableData)
2489         https://bugs.webkit.org/show_bug.cgi?id=129349
2490         <rdar://problem/14871837>
2491
2492         Reviewed by Joseph Pecoraro.
2493
2494         The code for clearing out memory mapped notification callbacks is only needed when loading
2495         PDFs. And in such cases, we always have dataSourceDelegate object. So make this code
2496         conditional on its presence so that we don't trigger the assert for non-PDF main resources.
2497
2498         * WebView/WebDataSource.mm:
2499         (-[WebDataSource dealloc]):
2500
2501 2014-02-26  Andy Estes  <aestes@apple.com>
2502
2503         [iOS] Support network state notification using CPNetworkObserver
2504         https://bugs.webkit.org/show_bug.cgi?id=129358
2505
2506         Reviewed by Dan Bernstein.
2507
2508         * WebView/WebView.mm:
2509         (-[WebView _setNetworkStateIsOnline:]): Retained an empty
2510         implementation for binary compatibility for UIKit.
2511         (+[WebView _doNotStartObservingNetworkReachability]): Called
2512         Settings::setShouldOptOutOfNetworkStateObservation(true).
2513         * WebView/WebViewPrivate.h: Removed declaration of
2514         _setNetworkStateIsOnline: and declared
2515         _doNotStartObservingNetworkReachability.
2516
2517 2014-02-25  Anders Carlsson  <andersca@apple.com>
2518
2519         Get rid of VisitedLinkStrategy
2520         https://bugs.webkit.org/show_bug.cgi?id=129324
2521
2522         Reviewed by Dan Bernstein.
2523
2524         * WebCoreSupport/WebPlatformStrategies.h:
2525         * WebCoreSupport/WebPlatformStrategies.mm:
2526
2527 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2528
2529         [CSS Grid Layout] Add ENABLE flag
2530         https://bugs.webkit.org/show_bug.cgi?id=129153
2531
2532         Reviewed by Simon Fraser.
2533
2534         Added ENABLE_CSS_GRID_LAYOUT feature flag.
2535
2536         * Configurations/FeatureDefines.xcconfig:
2537
2538 2014-02-24  Anders Carlsson  <andersca@apple.com>
2539
2540         Add WebViewGroup
2541         https://bugs.webkit.org/show_bug.cgi?id=129280
2542
2543         Reviewed by Dan Bernstein.
2544
2545         This is a first step towards getting rid of page groups in WebCore. The idea is that
2546         everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
2547         WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.
2548
2549         * WebCoreSupport/WebViewGroup.h: Added.
2550         * WebCoreSupport/WebViewGroup.mm: Added.
2551         (webViewGroups):
2552         (WebViewGroup::getOrCreate):
2553         (WebViewGroup::WebViewGroup):
2554         (WebViewGroup::~WebViewGroup):
2555         (WebViewGroup::addWebView):
2556         (WebViewGroup::removeWebView):
2557         * WebView/WebView.mm:
2558         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2559         (-[WebView _close]):
2560         (-[WebView setGroupName:]):
2561         * WebView/WebViewData.h:
2562         * WebView/WebViewData.mm:
2563
2564 2014-02-24  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2565
2566         Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
2567         https://bugs.webkit.org/show_bug.cgi?id=129255
2568
2569         Reviewed by Csaba Osztrogonác.
2570
2571         ENABLE_WORKERS macro was removed in r159679.
2572         Support is now also removed from xcconfig files.
2573
2574         * Configurations/FeatureDefines.xcconfig:
2575
2576 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2577
2578         Remove redundant setting in FeatureDefines.xcconfig
2579
2580         * Configurations/FeatureDefines.xcconfig:
2581
2582 2014-02-23  Sam Weinig  <sam@webkit.org>
2583
2584         Update FeatureDefines.xcconfig
2585
2586         Rubber-stamped by Anders Carlsson.
2587
2588         * Configurations/FeatureDefines.xcconfig:
2589
2590 2014-02-23  Sam Weinig  <sam@webkit.org>
2591
2592         Move telephone number detection behind its own ENABLE macro
2593         https://bugs.webkit.org/show_bug.cgi?id=129236
2594
2595         Reviewed by Dean Jackson.
2596
2597         * Configurations/FeatureDefines.xcconfig:
2598         Add ENABLE_TELEPHONE_NUMBER_DETECTION.
2599
2600 2014-02-21  Sam Weinig  <sam@webkit.org>
2601
2602         Expose phase and momentum phase as SPI on DOMWheelEvent
2603         <rdar://problem/16110871>
2604         https://bugs.webkit.org/show_bug.cgi?id=129184
2605
2606         Reviewed by Anders Carlsson.
2607
2608         * DOM/WebDOMOperations.mm:
2609         (toNSEventPhase):
2610         (-[DOMWheelEvent _phase]):
2611         (-[DOMWheelEvent _momentumPhase]):
2612         * DOM/WebDOMOperationsPrivate.h:
2613         Expose _phase and _momentumPhase as SPI.
2614
2615         * MigrateHeaders.make:
2616         Make DOMWheelEventInternal.h to WebKit.
2617
2618 2014-02-22  David Kilzer  <ddkilzer@apple.com>
2619
2620         Revert r164434 since it actually broke ASan builds
2621         <http://webkit.org/b/128871>
2622
2623         * Configurations/WebKit.xcconfig: This caused -asan-blacklist to
2624         be included twice on every compiler command, which caused clang
2625         to error out.
2626
2627 2014-02-21  Brent Fulgham  <bfulgham@apple.com>
2628
2629         Extend media support for WebVTT sources
2630         https://bugs.webkit.org/show_bug.cgi?id=129156
2631
2632         Reviewed by Eric Carlson.
2633
2634         * Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
2635
2636 2014-02-20  Brady Eidson  <beidson@apple.com>
2637
2638         Add very basic image control rendering
2639         https://bugs.webkit.org/show_bug.cgi?id=129080
2640
2641         Reviewed by Tim Horton.
2642
2643         Expose the imageControlsEnabled setting to WebKit1 so DRT can use it.
2644
2645         * WebView/WebPreferenceKeysPrivate.h:
2646         * WebView/WebPreferences.mm:
2647         (+[WebPreferences initialize]):
2648         (-[WebPreferences imageControlsEnabled]):
2649         (-[WebPreferences setImageControlsEnabled:]):
2650         * WebView/WebPreferencesPrivate.h:
2651
2652         * WebView/WebView.mm:
2653         (-[WebView _preferencesChanged:]):
2654
2655 2014-02-20  David Kilzer  <ddkilzer@apple.com>
2656
2657         [ASan] WebKit1 sources are not compiled using ASAN macros
2658         <http://webkit.org/b/128871>
2659
2660         Reviewed by Brent Fulgham.
2661
2662         * Configurations/WebKit.xcconfig: Use $inherited for
2663         OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS so that ASAN_OTHER_CFLAGS
2664         and ASAN_OTHER_CPLUSPLUSFLAGS are inherited from
2665         DebugRelease.xcconfig.
2666
2667 2014-02-19  Brady Eidson  <beidson@apple.com>
2668
2669         Add FeatureDefines for image controls
2670         https://bugs.webkit.org/show_bug.cgi?id=129022
2671
2672         Reviewed by Jer Noble.
2673
2674         * Configurations/FeatureDefines.xcconfig:
2675
2676 2014-02-18  Sam Weinig  <sam@webkit.org>
2677
2678         Simplify HTML tokenizer parameterization down to what is used
2679         https://bugs.webkit.org/show_bug.cgi?id=128977
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         Remove unused _setCustomHTMLTokenizerTimeDelay and _setCustomHTMLTokenizerChunkSize SPI.
2684
2685         * WebView/WebView.mm:
2686         * WebView/WebViewPrivate.h:
2687
2688 2014-02-17  Anders Carlsson  <andersca@apple.com>
2689
2690         Remove view source code
2691         https://bugs.webkit.org/show_bug.cgi?id=127233
2692
2693         Reviewed by Antti Koivisto.
2694
2695         * WebView/WebView.mm:
2696         * WebView/WebViewPrivate.h:
2697
2698 2014-02-17  Sergio Correia  <sergio.correia@openbossa.org>
2699
2700         Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
2701         https://bugs.webkit.org/show_bug.cgi?id=128681
2702
2703         Reviewed by Timothy Hatcher.
2704
2705         Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
2706         WebCore/inspector/*. Besides files in there, a few other files in
2707         JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
2708         and WebCore/testing were touched.
2709
2710         * WebCoreSupport/WebInspectorClient.h:
2711         * WebCoreSupport/WebInspectorClient.mm:
2712
2713 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
2714
2715         [Mac] Remove WebSerializedJSValue SPI
2716         https://bugs.webkit.org/show_bug.cgi?id=128720
2717
2718         Reviewed by Anders Carlsson.
2719
2720         * WebKit.exp:
2721         * WebView/WebSerializedJSValue.h: Removed.
2722         * WebView/WebSerializedJSValue.mm: Removed.
2723         * WebView/WebSerializedJSValuePrivate.h: Removed.
2724
2725 2014-02-15  Alexey Proskuryakov  <ap@apple.com>
2726
2727         [Mac] All WebKit clients should encrypt WebCrypto keys automatically
2728         https://bugs.webkit.org/show_bug.cgi?id=128852
2729
2730         Reviewed by Oliver Hunt.
2731
2732         * WebCoreSupport/WebChromeClient.mm:
2733         (WebChromeClient::wrapCryptoKey):
2734         (WebChromeClient::unwrapCryptoKey):
2735         Call the default implementation if key is not provided by a client.
2736
2737 2014-02-14  Anders Carlsson  <andersca@apple.com>
2738
2739         Control tints don't update inside WebViews
2740         https://bugs.webkit.org/show_bug.cgi?id=128862
2741
2742         Reviewed by Ryosuke Niwa.
2743
2744         * WebView/WebView.mm:
2745         (-[WebView _windowChangedKeyState]):
2746         Call [super _windowChangedKeyState].
2747
2748 2014-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
2749
2750         During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected
2751         https://bugs.webkit.org/show_bug.cgi?id=128688
2752
2753         Reviewed by Ryosuke Niwa.
2754
2755         Renames the ConvertPositionStyleOnCopy setting to ShouldConvertPositionStyleOnCopy
2756
2757         * WebView/WebPreferenceKeysPrivate.h:
2758         * WebView/WebPreferences.mm:
2759         (-[WebPreferences shouldConvertPositionStyleOnCopy]):
2760         (-[WebPreferences setShouldConvertPositionStyleOnCopy:]):
2761         * WebView/WebPreferencesPrivate.h:
2762         * WebView/WebView.mm:
2763         (-[WebView _preferencesChanged:]):
2764
2765 2014-02-13  Alexey Proskuryakov  <ap@apple.com>
2766
2767         [Mac] Add a WebKit1 SPI to get WebCrypto master key from a client
2768         https://bugs.webkit.org/show_bug.cgi?id=128725
2769
2770         Reviewed by Anders Carlsson.
2771
2772         * WebCoreSupport/WebChromeClient.mm:
2773         (WebChromeClient::wrapCryptoKey):
2774         (WebChromeClient::unwrapCryptoKey):
2775         * WebView/WebUIDelegatePrivate.h:
2776         Looks like UIDelegate is the closest we have to a reasonable place.
2777
2778 2014-02-13  Dan Bernstein  <mitz@apple.com>
2779
2780         iOS build fix.
2781
2782         * WebView/WebView.mm:
2783         (+[WebView registerForMemoryNotifications]):
2784
2785 2014-02-12  Alexey Proskuryakov  <ap@apple.com>
2786
2787         Wrap WebCrypto keys in SerializedScriptValue
2788         https://bugs.webkit.org/show_bug.cgi?id=128680
2789
2790         Reviewed by Anders Carlsson.
2791
2792         Retrieve a master key (placeholder code for now), and use it to wrap key data.
2793
2794         * WebCoreSupport/WebChromeClient.mm:
2795         (WebChromeClient::wrapCryptoKey):
2796         (WebChromeClient::unwrapCryptoKey):
2797
2798 2014-02-11  Ryosuke Niwa  <rniwa@webkit.org>
2799
2800         Frame::rectForSelection shouldn't instantiate FrameSelection
2801         https://bugs.webkit.org/show_bug.cgi?id=128587
2802
2803         Reviewed by Enrica Casucci.
2804
2805         * WebCoreSupport/WebEditorClient.h:
2806         * WebCoreSupport/WebEditorClient.mm:
2807         (WebEditorClient::WebEditorClient):
2808         (WebEditorClient::respondToChangedSelection):
2809
2810 2014-02-10  Myles C. Maxfield  <mmaxfield@apple.com>
2811
2812         Convert position:sticky and position:fixed properties to position:static and position:absolute upon copy
2813         https://bugs.webkit.org/show_bug.cgi?id=128194
2814
2815         Reviewed by Simon Fraser.
2816
2817         * WebView/WebPreferenceKeysPrivate.h:
2818         * WebView/WebPreferences.mm:
2819         (-[WebPreferences convertPositionStyleOnCopy]):
2820         (-[WebPreferences setConvertPositionStyleOnCopy:]):
2821         * WebView/WebPreferencesPrivate.h: Opt-in to new behavior
2822         * WebView/WebView.mm:
2823         (-[WebView _preferencesChanged:]):
2824
2825 2014-02-11  Andy Estes  <aestes@apple.com>
2826
2827         [Mac] connection:willStopBufferingData: no longer exists in NSURLConnectionDelegate
2828         https://bugs.webkit.org/show_bug.cgi?id=128583
2829
2830         Reviewed by Anders Carlsson.
2831
2832         The delegate method was removed in Snow Leopard.
2833
2834         * Misc/WebDownload.mm:
2835
2836 2014-02-11  Alexey Proskuryakov  <ap@apple.com>
2837
2838         iOS build fix.
2839
2840         * WebCoreSupport/WebChromeClient.mm: Fixed incorrectly nested ifdefs.
2841
2842 2014-02-10  Alexey Proskuryakov  <ap@apple.com>
2843
2844         Add hooks for wrapping CryptoKeys in SerializedScriptValue
2845         https://bugs.webkit.org/show_bug.cgi?id=128567
2846
2847         Reviewed by Anders Carlsson.
2848
2849         * WebCoreSupport/WebChromeClient.h:
2850         * WebCoreSupport/WebChromeClient.mm:
2851         (WebChromeClient::wrapCryptoKey):
2852         (WebChromeClient::unwrapCryptoKey):
2853         Dummy implementation, to be filled in later.
2854
2855 2014-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2856
2857         Cleanup the interface of FrameSelection
2858         https://bugs.webkit.org/show_bug.cgi?id=128481
2859
2860         Reviewed by Andreas Kling.
2861
2862         * WebView/WebHTMLView.mm:
2863         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2864         (-[WebHTMLView selectionRect]):
2865         (-[WebHTMLView selectionImageRect]):
2866
2867 2014-02-08  Dan Bernstein  <mitz@apple.com>
2868
2869         Remove use of PLATFORM(MAC) from WebKit/mac
2870         https://bugs.webkit.org/show_bug.cgi?id=128476
2871
2872         Reviewed by Anders Carlsson.
2873
2874         * WebCoreSupport/WebFrameLoaderClient.h:
2875         * WebCoreSupport/WebSystemInterface.mm:
2876         (InitWebCoreSystemInterface):
2877
2878 2014-02-08  Dan Bernstein  <mitz@apple.com>
2879
2880         Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
2881         https://bugs.webkit.org/show_bug.cgi?id=128456
2882
2883         Reviewed by Anders Carlsson.
2884
2885         * WebCoreSupport/WebChromeClient.h:
2886         * WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
2887         * WebView/WebHTMLView.mm:
2888         (-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
2889         (-[WebHTMLViewPrivate clear]): Ditto.
2890         * WebView/WebHTMLViewInternal.h: Removed declaration.
2891         * WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.
2892
2893 2014-02-08  Dan Bernstein  <mitz@apple.com>
2894
2895         iOS build fix after r163712.
2896
2897         * WebCoreSupport/WebEditorClient.h:
2898         * WebCoreSupport/WebEditorClient.mm:
2899
2900 2014-02-08  Darin Adler  <darin@apple.com>
2901
2902         Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
2903         https://bugs.webkit.org/show_bug.cgi?id=128233
2904
2905         Reviewed by Anders Carlsson.
2906
2907         * WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines
2908         for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
2909         Changed interfaces to use StringView.
2910
2911         * WebCoreSupport/WebEditorClient.mm:
2912         (WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
2913         function instead of a similar function that was local in this file.
2914         (WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
2915         (WebEditorClient::checkSpellingOfString): Changed to take a StringView.
2916         (WebEditorClient::checkGrammarOfString): Ditto.
2917
2918         * WebView/WebTextIterator.mm:
2919         (-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
2920         (-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
2921         instead of with TextIterator::characters/length.
2922
2923 2014-02-07  Gavin Barraclough  <barraclough@apple.com>
2924
2925         Remove isInitialState flag from Page::setViewState
2926         https://bugs.webkit.org/show_bug.cgi?id=128428
2927
2928         Reviewed by Sam Weinig.
2929
2930         * WebView/WebView.mm:
2931         (-[WebView _commonInitializationWithFrameName:groupName:]):
2932         (-[WebView _updateVisibilityState]):
2933         (-[WebView _setIsVisible:]):
2934         (-[WebView _setVisibilityState:isInitialState:]):
2935         (-[WebView _windowWillOrderOnScreen:]):
2936         (-[WebView _windowWillOrderOffScreen:]):
2937             - don't pass isInitialState to setViewState.
2938
2939 2014-02-06  Filip Pizlo  <fpizlo@apple.com>
2940
2941         More FTL build scaffolding
2942         https://bugs.webkit.org/show_bug.cgi?id=128330
2943
2944         Reviewed by Geoffrey Garen.
2945
2946         * Configurations/FeatureDefines.xcconfig:
2947
2948 2014-02-07  Dan Bernstein  <mitz@apple.com>
2949
2950         iOS build fix.
2951
2952         * Misc/WebElementDictionary.mm:
2953         (+[WebElementDictionary initializeLookupTable]):
2954         (-[WebElementDictionary _image]):
2955         (-[WebElementDictionary _imageRect]):
2956
2957 2014-02-06  Joseph Pecoraro  <pecoraro@apple.com>
2958
2959         Web Inspector: Add Console support to JSContext Inspection
2960         https://bugs.webkit.org/show_bug.cgi?id=127941
2961
2962         Reviewed by Geoffrey Garen.
2963
2964         * WebCoreSupport/WebChromeClient.h:
2965         * WebCoreSupport/WebChromeClient.mm:
2966         (stringForMessageSource):
2967         (stringForMessageLevel):
2968         (WebChromeClient::addMessageToConsole):
2969
2970 2014-02-05  Gavin Barraclough  <barraclough@apple.com>
2971
2972         Change Page, FocusController to use ViewState
2973         https://bugs.webkit.org/show_bug.cgi?id=126533
2974
2975         Reviewed by Tim Horton.
2976
2977         These classes currently maintain a set of separate fields to represent the view state;
2978         combine these into a single field, and allow WebPage to send the combined update rather
2979         than individual changes.
2980
2981         Maintain existing interface for WebKit1 clients.
2982
2983         * WebView/WebView.mm:
2984         (-[WebView _windowWillOrderOnScreen:]):
2985         (-[WebView _windowWillOrderOffScreen:]):
2986             - remove calls to FocusController::setContentIsVisible, these are redundant
2987               (this is handled when page visibility is set).
2988
2989 2014-02-05  Andreas Kling  <akling@apple.com>
2990
2991         Remove ENABLE(DIRECTORY_UPLOAD).
2992         <https://webkit.org/b/128275>
2993
2994         Rubber-stamped by Ryosuke Niwa.
2995
2996         * Configurations/FeatureDefines.xcconfig:
2997
2998 2014-02-05  Csaba Osztrogonác  <ossy@webkit.org>
2999
3000         Remove ENABLE(SVG) guards
3001         https://bugs.webkit.org/show_bug.cgi?id=127991
3002
3003         Reviewed by Sam Weinig.
3004
3005         * Configurations/FeatureDefines.xcconfig:
3006
3007 2014-02-04  Andreas Kling  <akling@apple.com>
3008
3009         Remove <iframe seamless> support.
3010         <https://webkit.org/b/128213>
3011
3012         Rubber-stamped by Antti Koivisto.
3013
3014         * Configurations/FeatureDefines.xcconfig:
3015         * WebView/WebPreferenceKeysPrivate.h:
3016         * WebView/WebPreferences.mm:
3017         * WebView/WebPreferencesPrivate.h:
3018         * WebView/WebView.mm:
3019         (-[WebView _preferencesChanged:]):
3020
3021 2014-02-03  Dean Jackson  <dino@apple.com>
3022
3023         Feature flag for shape-inside
3024         https://bugs.webkit.org/show_bug.cgi?id=128001
3025
3026         Reviewed by Simon Fraser.
3027
3028         Add CSS_SHAPE_INSIDE flag.
3029
3030         * Configurations/FeatureDefines.xcconfig:
3031
3032 2014-01-31  Ryosuke Niwa  <rniwa@webkit.org>
3033
3034         Remove inline member functions of FrameSelection that access m_selection
3035         https://bugs.webkit.org/show_bug.cgi?id=127986
3036
3037         Reviewed by Enrica Casucci.
3038
3039         * WebView/WebFrame.mm:
3040         (-[WebFrame hasEditableSelection]):
3041         (-[WebFrame selectionAffinity]):
3042         (-[WebFrame getDictationResultRanges:andMetadatas:]):
3043         (-[WebFrame hasRichlyEditableSelection]):
3044         (-[WebFrame focusedNodeHasContent]):
3045         * WebView/WebHTMLView.mm:
3046         (-[WebHTMLView readSelectionFromPasteboard:]):
3047         (-[WebHTMLView _hasSelection]):
3048         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
3049         (-[WebHTMLView _hasInsertionPoint]):
3050         (-[WebHTMLView _isEditable]):
3051         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3052         (-[WebHTMLView maintainsInactiveSelection]):
3053         (isTextInput):
3054         (isInPasswordField):
3055         * WebView/WebView.mm:
3056         (-[WebView selectionAffinity]):
3057
3058 2014-01-31  Tim Horton  <timothy_horton@apple.com>
3059
3060         [wk2] PlatformCALayerRemoteCustom doesn't work on iOS
3061         https://bugs.webkit.org/show_bug.cgi?id=128025
3062         <rdar://problem/15950271>
3063
3064         Reviewed by Simon Fraser.
3065
3066         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3067         (-[WebHostedNetscapePluginView windowHostsLayersInWindowServer]):
3068         Use the new macro name.
3069
3070 2014-01-30  David Kilzer  <ddkilzer@apple.com>
3071
3072         Add security-checked cast for WebCore::CachedImage
3073         <http://webkit.org/b/127967>
3074
3075         Reviewed by Darin Adler.
3076
3077         * Misc/WebCache.mm:
3078         (+[WebCache imageForURL:]):
3079         - Use WebCore::toCachedImage().
3080
3081 2014-01-30  David Kilzer  <ddkilzer@apple.com>
3082
3083         De-virtual-ize CachedResource::isImage()
3084         <http://webkit.org/b/127936>
3085
3086         Reviewed by Andreas Kling.
3087
3088         Also replace explicit type() checks with isImage().
3089
3090         * Misc/WebCache.mm:
3091         (+[WebCache imageForURL:]): Use !isImage().
3092
3093 2014-01-30  Beth Dakin  <bdakin@apple.com>
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=127371
3096         Explore new API that could be used to help build infinitely scrolling websites
3097         -and corresponding-
3098         <rdar://problem/15244768>
3099
3100         Reviewed by Sam Weinig.
3101
3102         FrameView::scrollPositionChangedViaPlatformWidget() now take two parameters 
3103         representing the old scroll position and the new position.
3104         * WebView/WebHTMLView.mm:
3105         (-[WebHTMLView _frameOrBoundsChanged]):
3106
3107 2014-01-30  Andrei Bucur  <abucur@adobe.com>
3108
3109         Remove the ACCELERATED_COMPOSITING flag
3110         https://bugs.webkit.org/show_bug.cgi?id=127833
3111
3112         Reviewed by Antti Koivisto.
3113
3114         Remove the USE(ACCELERATED_COMPOSITING) conditionals from the code base and make AC
3115         mandatory.
3116
3117         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3118         (-[WebHostedNetscapePluginView createPlugin]):
3119         (-[WebHostedNetscapePluginView createPluginLayer]):
3120         * Plugins/WebNetscapePluginView.mm:
3121         (-[WebNetscapePluginView createPlugin]):
3122         (-[WebNetscapePluginView getVariable:value:]):
3123         * Plugins/WebPluginController.mm:
3124         (-[WebPluginController superlayerForPluginView:]):
3125         * WebCoreSupport/WebChromeClient.h:
3126         (WebChromeClient::allowedCompositingTriggers):
3127         * WebCoreSupport/WebChromeClient.mm:
3128         * WebCoreSupport/WebFrameLoaderClient.mm:
3129         (PluginWidgetIOS::detachPluginLayer):
3130         (NetscapePluginWidget::platformLayer):
3131         * WebView/WebClipView.mm:
3132         (-[WebClipView _immediateScrollToPoint:]):
3133         * WebView/WebHTMLView.mm:
3134         (setNeedsDisplayInRect):
3135         (+[WebHTMLViewPrivate initialize]):
3136         (-[WebHTMLViewPrivate clear]):
3137         (-[WebHTMLView _setAsideSubviews]):
3138         (-[WebHTMLView hitTest:]):
3139         (-[WebHTMLView _isUsingAcceleratedCompositing]):
3140         (-[WebHTMLView _compositingLayersHostingView]):
3141         (-[WebHTMLView viewDidMoveToSuperview]):
3142         (-[WebHTMLView drawRect:]):
3143         * WebView/WebHTMLViewInternal.h:
3144         * WebView/WebRenderLayer.mm:
3145         (+[WebRenderLayer compositingInfoForLayer:]):
3146         * WebView/WebView.mm:
3147         (-[WebView _close]):
3148         (-[WebView _setMediaLayer:forPluginView:]):
3149         (-[WebView _postsAcceleratedCompositingNotifications]):
3150         (-[WebView _setPostsAcceleratedCompositingNotifications:]):
3151         (-[WebView _isUsingAcceleratedCompositing]):
3152         (-[WebView _isSoftwareRenderable]):
3153         (-[WebView close]):
3154         * WebView/WebViewData.h:
3155         * WebView/WebViewData.mm:
3156         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
3157         * WebView/WebViewInternal.h:
3158
3159 2014-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3160
3161         Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
3162         https://bugs.webkit.org/show_bug.cgi?id=127845
3163
3164         Reviewed by Joseph Pecoraro.
3165
3166         * Configurations/FeatureDefines.xcconfig:
3167
3168 2014-01-29  Dan Bernstein  <mitz@apple.com>
3169
3170         Moved linking against common frameworks and a library from the .xcconfig file into the target.
3171
3172         Reviewed by Tim Horton.
3173
3174         * Configurations/WebKit.xcconfig:
3175
3176 2014-01-29  Ryosuke Niwa  <rniwa@webkit.org>
3177
3178         checkTextOfParagraph releases NSString twice
3179         https://bugs.webkit.org/show_bug.cgi?id=127881
3180         <rdar://problem/15937446>
3181
3182         Reviewed by Anders Carlsson.
3183
3184         textString is released once by an explicit call to release and again by it going out of scope.
3185         Don't do the explicit release.
3186
3187         The bug was spotted by Sam Weinig.
3188
3189         * WebCoreSupport/WebEditorClient.mm:
3190         (WebEditorClient::checkTextOfParagraph):
3191
3192 2014-01-29  Anders Carlsson  <andersca@apple.com>
3193
3194         Fix build.
3195
3196         * WebView/WebPDFView.mm:
3197         (_applicationInfoForMIMEType):
3198
3199 2014-01-28  Mark Rowe  <mrowe@apple.com>
3200
3201         <https://webkit.org/b/127767> Disable some deprecation warnings to fix the build.
3202
3203         Reviewed by Ryosuke Niwa.
3204
3205         * WebCoreSupport/PopupMenuMac.mm:
3206         (PopupMenuMac::populate):
3207
3208 2014-01-27  Joseph Pecoraro  <pecoraro@apple.com>
3209
3210         WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
3211         https://bugs.webkit.org/show_bug.cgi?id=127664
3212
3213         Reviewed by Darin Adler.
3214
3215         * Configurations/Base.xcconfig:
3216         * History/BinaryPropertyList.cpp:
3217         (BinaryPropertyListSerializer::appendObjectReference):
3218         (BinaryPropertyListSerializer::startObject):
3219         (BinaryPropertyListSerializer::addAggregateObjectReference):
3220         * WebView/WebPDFView.mm:
3221         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3222
3223 2014-01-27  Andy Estes  <aestes@apple.com>
3224
3225         Scrub WebKit API headers of WTF macros
3226         https://bugs.webkit.org/show_bug.cgi?id=127706
3227
3228         Reviewed by David Kilzer.
3229
3230         * Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
3231         * WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
3232         to !defined(ENABLE_REMOTE_INSPECTOR) || ENABLE_REMOTE_INSPECTOR. We are
3233         in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
3234         default on iOS, so include this block unless the feature is explicitly
3235         disabled.
3236         * postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS
3237         and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.
3238
3239 2014-01-27  Tim Horton  <timothy_horton@apple.com>
3240
3241         Another iOS build fix.
3242
3243         * Misc/WebElementDictionary.mm:
3244         (-[WebElementDictionary _image]):
3245         We were apparently depending on Image::getNSImage() being defined
3246         (yet always returning nullptr) on iOS.
3247
3248 2014-01-26  David Kilzer  <ddkilzer@apple.com>
3249
3250         Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
3251         <http://webkit.org/b/127669>
3252
3253         Reviewed by Joseph Pecoraro.
3254
3255         * WebView/WebPreferences.mm:
3256         (+[WebPreferences initialize]): Remove duplicate code.
3257
3258 2014-01-24  Andy Estes  <aestes@apple.com>
3259
3260         [iOS] Upstream changes in Tools/DumpRenderTree
3261         https://bugs.webkit.org/show_bug.cgi?id=127412
3262
3263         Reviewed by Simon Fraser.
3264
3265         * Misc/WebCoreStatistics.h: Included CGContext.h.
3266
3267 2014-01-26  Anders Carlsson  <andersca@apple.com>
3268
3269         Move history item visit count handling to WebKit
3270         https://bugs.webkit.org/show_bug.cgi?id=127659
3271
3272         Reviewed by Dan Bernstein.
3273
3274         Move code to deal with visit count and visit dates here from WebCore.
3275
3276         * History/HistoryPropertyList.mm:
3277         (HistoryPropertyListWriter::writeHistoryItem):
3278         * History/WebHistoryItem.mm:
3279         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
3280         (-[WebHistoryItem copyWithZone:]):
3281         (-[WebHistoryItem lastVisitedTimeInterval]):
3282         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
3283         (-[WebHistoryItem setVisitCount:]):
3284         (-[WebHistoryItem _mergeAutoCompleteHints:]):
3285         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3286         (-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
3287         (-[WebHistoryItem _recordInitialVisit]):
3288         (timeToDay):
3289         (-[WebHistoryItem _padDailyCountsForNewVisit:]):
3290         (-[WebHistoryItem _collapseDailyVisitsToWeekly]):
3291         (-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
3292         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
3293         * History/WebHistoryItemInternal.h:
3294
3295 2014-01-26  Anders Carlsson  <andersca@apple.com>
3296
3297         Fix build.
3298
3299         Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.
3300
3301         * History/HistoryPropertyList.h:
3302         * History/HistoryPropertyList.mm:
3303         (HistoryPropertyListWriter::HistoryPropertyListWriter):
3304         (HistoryPropertyListWriter::buffer):
3305         (HistoryPropertyListWriter::releaseData):
3306         (HistoryPropertyListWriter::writeObjects):
3307         (HistoryPropertyListWriter::writeHistoryItem):
3308         * History/WebHistory.mm:
3309         (WebHistoryWriter::writeHistoryItems):
3310         * History/WebHistoryItem.mm:
3311
3312 2014-01-26  Anders Carlsson  <andersca@apple.com>
3313
3314         Move lastVisitWasHTTPNonGet out to WebHistoryItem
3315         https://bugs.webkit.org/show_bug.cgi?id=127657
3316
3317         Reviewed by Dan Bernstein.
3318
3319         Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.
3320
3321         * History/WebHistory.mm:
3322         (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
3323         Set entry->_private->_lastVisitWasHTTPNonGet.
3324
3325         * History/WebHistoryItem.h:
3326         Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.
3327
3328         * History/WebHistoryItem.mm:
3329         (-[WebHistoryItem copyWithZone:]):
3330         Assign _private->_lastVisitWasHTTPNonGet.
3331
3332         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3333         Set _private->_lastVisitWasHTTPNonGet.
3334
3335         * History/WebHistoryItemInternal.h:
3336         Move WebHistoryItemPrivate interface here.
3337
3338 2014-01-26  Anders Carlsson  <andersca@apple.com>
3339
3340         Turn WebHistoryItemPrivate back into a real Objective-C class
3341         https://bugs.webkit.org/show_bug.cgi?id=127653
3342
3343         Reviewed by Sam Weinig.
3344
3345         This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.
3346
3347         * History/WebHistoryItem.mm:
3348         (-[WebHistoryItem dealloc]):
3349         (-[WebHistoryItem finalize]):
3350         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
3351
3352 2014-01-25  Sam Weinig  <sam@webkit.org>
3353
3354         Remove unused support for DRAGGABLE_REGION
3355         https://bugs.webkit.org/show_bug.cgi?id=127642
3356
3357         Reviewed by Simon Fraser.
3358
3359         * Configurations/FeatureDefines.xcconfig:
3360
3361 2014-01-25  Anders Carlsson  <andersca@apple.com>
3362
3363         Remove an unused FrameLoaderClient function
3364         https://bugs.webkit.org/show_bug.cgi?id=127628
3365
3366         Reviewed by Andreas Kling.
3367
3368         * WebCoreSupport/WebFrameLoaderClient.h:
3369         * WebCoreSupport/WebFrameLoaderClient.mm:
3370
3371 2014-01-25  Anders Carlsson  <andersca@apple.com>
3372
3373         Build fix.
3374
3375         * WebView/WebViewData.h:
3376
3377 2014-01-25  Anders Carlsson  <andersca@apple.com>
3378
3379         Get rid of BackForwardController::isActive()
3380         https://bugs.webkit.org/show_bug.cgi?id=127604
3381
3382         Reviewed by Sam Weinig.
3383
3384         * WebCoreSupport/WebFrameLoaderClient.mm:
3385         (WebFrameLoaderClient::canCachePage):
3386         Move isActive logic here.
3387
3388 2014-01-24  Anders Carlsson  <andersca@apple.com>
3389
3390         Remove back/forward list related functions from Page
3391         https://bugs.webkit.org/show_bug.cgi?id=127596
3392
3393         Reviewed by Andreas Kling.
3394
3395         * WebView/WebFrameView.mm:
3396         (-[WebFrameView keyDown:keyDown:]):
3397         * WebView/WebView.mm:
3398         (-[WebView _loadBackForwardListFromOtherView:]):
3399         (-[WebView initWithCoder:]):
3400         (-[WebView encodeWithCoder:]):
3401         (-[WebView backForwardList]):
3402         (-[WebView setMaintainsBackForwardList:]):
3403         (-[WebView goBack]):
3404         (-[WebView goForward]):
3405         (-[WebView canGoBack]):
3406         (-[WebView canGoForward]):
3407
3408 2014-01-24  Anders Carlsson  <andersca@apple.com>
3409
3410         Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead
3411         https://bugs.webkit.org/show_bug.cgi?id=127571
3412
3413         Reviewed by Antti Koivisto.
3414
3415         * WebView/WebView.mm:
3416         (-[WebView _preferencesChanged:]):
3417         Convert the layout interval to std::chrono::milliseconds.
3418
3419 2014-01-24  Zan Dobersek  <zdobersek@igalia.com>
3420
3421         Move HistoryItem to std::unique_ptr
3422         https://bugs.webkit.org/show_bug.cgi?id=127275
3423
3424         Reviewed by Darin Adler.
3425
3426         * History/WebHistoryItem.mm: The Vector object that's passed to HistoryItem::setRedirectURLs
3427         should now be handled by std::unique_ptr and passed on through move semantics.
3428         (-[WebHistoryItem initFromDictionaryRepresentation:]):
3429
3430 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
3431
3432         Move RegularExpression into JavaScriptCore for inspector
3433         https://bugs.webkit.org/show_bug.cgi?id=127526
3434
3435         Reviewed by Geoffrey Garen.
3436
3437         * WebView/WebHTMLRepresentation.mm:
3438
3439 2014-01-23  Benjamin Poulain  <bpoulain@apple.com>
3440
3441         Remote Inspector uses the Page pointer before the page is created on iOS
3442         https://bugs.webkit.org/show_bug.cgi?id=127534
3443
3444         Reviewed by Joseph Pecoraro.
3445
3446         * WebView/WebView.mm:
3447         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3448
3449 2014-01-23  Jon Honeycutt  <jhoneycutt@apple.com>
3450
3451         Assertion failure in WebCore::PseudoElement::didRecalcStyle()
3452         <https://bugs.webkit.org/show_bug.cgi?id=126761>
3453         <rdar://problem/15793540>
3454
3455         Some areas of code were erroneously checking the value of
3456         RenderObject::isImage() rather than RenderObject::isRenderImage()
3457         before casting the object to RenderImage.
3458
3459         This could lead to an assertion failure for RenderListMarkers, which
3460         may return true for isImage(), but are not RenderImages.
3461
3462         Reviewed by Andy Estes.
3463
3464         * Misc/WebNSPasteboardExtras.mm:
3465         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3466         Check isRenderImage() rather than isImage() before casting to
3467         RenderImage.
3468
3469 2014-01-23  Joseph Pecoraro  <pecoraro@apple.com>
3470
3471         Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
3472         https://bugs.webkit.org/show_bug.cgi?id=127409
3473
3474         Reviewed by Geoffrey Garen.
3475
3476         * WebCoreSupport/WebInspectorClient.mm:
3477         (-[WebInspectorWindowController destroyInspectorView:]):
3478         Include InspectorDisconnectReason.
3479
3480 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
3481
3482         Remove CSS Custom Filters code and tests
3483         https://bugs.webkit.org/show_bug.cgi?id=127382
3484
3485         Reviewed by Simon Fraser.
3486
3487         * Configurations/FeatureDefines.xcconfig:
3488         * WebView/WebPreferenceKeysPrivate.h:
3489         * WebView/WebPreferences.mm:
3490         (+[WebPreferences initialize]):
3491         * WebView/WebPreferencesPrivate.h:
3492         * WebView/WebView.mm:
3493         (-[WebView _preferencesChanged:]):
3494
3495 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
3496
3497         Remove CSS3_TEXT_DECORATION define
3498         https://bugs.webkit.org/show_bug.cgi?id=127333
3499
3500         Reviewed by Simon Fraser.
3501
3502         This is required for unprefixing the text-decoration-* CSS properties.
3503
3504         * Configurations/FeatureDefines.xcconfig:
3505
3506 2014-01-22  Dan Bernstein  <mitz@apple.com>
3507
3508         Build fix for iOS clients of WebUIDelegatePrivate.h.
3509
3510         * WebView/WebUIDelegatePrivate.h: Ensure that ENABLE_DASHBOARD_SUPPORT is defined on iOS.
3511
3512 2014-01-21  Dan Bernstein  <mitz@apple.com>
3513
3514         Added a method declaration that was missed in r161185.
3515
3516         Reviewed by Sam Weinig.
3517
3518         * WebView/WebViewPrivate.h: Declared -removeVisitedLink:.
3519
3520 2014-01-21  Commit Queue  <commit-queue@webkit.org>
3521
3522         Unreviewed, rolling out r162452.
3523         http://trac.webkit.org/changeset/162452
3524         https://bugs.webkit.org/show_bug.cgi?id=127366
3525
3526         broke a few tests on all Mac WebKit1 bots (Requested by
3527         thorton on #webkit).
3528
3529         * WebView/WebView.mm:
3530         (-[WebView _windowWillOrderOnScreen:]):
3531         (-[WebView _windowWillOrderOffScreen:]):
3532
3533 2014-01-21  Gavin Barraclough  <barraclough@apple.com>
3534
3535         Change Page, FocusController to use ViewState
3536         https://bugs.webkit.org/show_bug.cgi?id=126533
3537
3538         Reviewed by Tim Horton.
3539
3540         These classes currently maintain a set of separate fields to represent the view state;
3541         combine these into a single field, and allow WebPage to send the combined update rather
3542         than individual changes.
3543
3544         Maintain existing interface for WebKit1 clients.
3545
3546         * WebView/WebView.mm:
3547         (-[WebView _windowWillOrderOnScreen:]):
3548         (-[WebView _windowWillOrderOffScreen:]):
3549             - remove calls to FocusController::setContentIsVisible, these are redundant
3550               (this is handled when page visibility is set).
3551
3552 2014-01-20  Jeremy Jones  <jeremyj@apple.com>
3553
3554         Add AVKit fullscreen video interface.
3555         https://bugs.webkit.org/show_bug.cgi?id=126818
3556
3557         Reviewed by Eric Carlson.
3558
3559         * WebCoreSupport/WebChromeClient.h:
3560         * WebCoreSupport/WebChromeClient.mm:
3561         (WebChromeClient::supportsFullscreenForNode):
3562         Enable *FullscreenForNode for HTMLMediaElement for iOS
3563
3564         * WebView/WebPreferenceKeysPrivate.h:
3565         * WebView/WebPreferences.mm:
3566         (+[WebPreferences initialize]):
3567         (-[WebPreferences mediaPlaybackFullscreenAVKit]):
3568         (-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
3569         * WebView/WebPreferencesPrivate.h:
3570         * WebView/WebView.mm:
3571         (-[WebView _preferencesChanged:]):
3572         (-[WebView _enterFullscreenForNode:WebCore::]):
3573         * WebView/WebViewInternal.h:
3574         Add a disabled pref mediaPlaybackFullscreenAVKit.
3575         Use WebVideoFullscreenControllerAVKit on iOS
3576
3577 2014-01-18  Brian Burg  <bburg@apple.com>
3578
3579         Web Inspector: Page should use std::unique_ptr for InspectorController
3580         https://bugs.webkit.org/show_bug.cgi?id=127068
3581
3582         Reviewed by Joseph Pecoraro.
3583
3584         Convert call sites to use a InspectorController reference.
3585         Convert instantiations of InspectorFrontendClient to use std::unique_ptr.