1 2017-04-04 Megan Gardner <megan_gardner@apple.com>
3 Fix leaks in WebUITextIndicatorData
4 https://bugs.webkit.org/show_bug.cgi?id=170480
6 Reviewed by Wenson Hsieh.
8 Removes extraneous retains.
11 (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
13 2017-04-04 Tim Horton <timothy_horton@apple.com>
15 [Mac] -[WKWebView findMatchesForString:relativeToMatch:findOptions:maxResults:resultCollector:] invokes the resultCollector with didWrap = NO even when it wraps
16 https://bugs.webkit.org/show_bug.cgi?id=165801
17 <rdar://problem/29649535>
19 Reviewed by Wenson Hsieh.
23 Adjust to the new CanWrap enum.
25 2017-03-27 Joseph Pecoraro <pecoraro@apple.com>
27 Web Inspector: Saving files should not suggest the top level directory
28 https://bugs.webkit.org/show_bug.cgi?id=170085
29 <rdar://problem/30197794>
31 Reviewed by Matt Baker.
33 * WebCoreSupport/WebInspectorClient.mm:
34 (WebInspectorFrontendClient::save):
35 Don't set panel.directoryURL unless we have a good suggestion.
37 2017-03-24 Wenson Hsieh <wenson_hsieh@apple.com>
39 [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
40 https://bugs.webkit.org/show_bug.cgi?id=169168
41 <rdar://problem/30688374>
43 Reviewed by Tim Horton.
45 Refactors WebDragClient::actionMaskForDrag to take platform data only, rather than the entire DragData. See the
46 WebCore ChangeLog entry for more details. Also renames WebDefaultUIDelegate.m to WebDefaultUIDelegate.mm, since
47 we need to import a C++ header for linkedOnOrAfter().
49 The default delegate implementation of webView:dragDestinationActionMaskForDraggingInfo: now checks if the current
50 application is linking against 10.12 or earlier, and if so, will allow any drag destination action instead of
51 the new default value of everything but DragDestinationActionLoad.
53 * DefaultDelegates/WebDefaultUIDelegate.mm: Renamed from Source/WebKit/mac/DefaultDelegates/WebDefaultUIDelegate.m.
54 (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
55 * Misc/WebKitVersionChecks.h:
56 * WebCoreSupport/WebDragClient.h:
57 * WebCoreSupport/WebDragClient.mm:
58 (WebDragClient::actionMaskForDrag): Deleted.
60 (-[WebView draggingEntered:]):
61 (-[WebView draggingUpdated:]):
63 2017-03-21 Wenson Hsieh <wenson_hsieh@apple.com>
65 Add support for showing the platform data interaction caret
66 https://bugs.webkit.org/show_bug.cgi?id=169898
67 <rdar://problem/31146295>
69 Reviewed by Beth Dakin.
71 Plumb the dataInteractionCaretRect through WebView SPI to WebKit1 clients.
74 (-[WebView _dataInteractionCaretRect]):
75 * WebView/WebViewPrivate.h:
77 2017-03-22 Dan Bernstein <mitz@apple.com>
79 [iOS] downloadableBinaryFontsEnabled is set to false in -initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:
80 https://bugs.webkit.org/show_bug.cgi?id=169967
81 <rdar://problem/30406898>
83 Reviewed by Anders Carlsson.
86 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Removed call to
87 Settings::downloadableBinaryFontsEnabled. The default is true.
89 2017-03-22 Andy Estes <aestes@apple.com>
91 [QuickLook] Rename QuickLookHandle to PreviewLoader
92 https://bugs.webkit.org/show_bug.cgi?id=169961
94 Reviewed by Andreas Kling.
96 * WebCoreSupport/WebFrameLoaderClient.h:
97 * WebCoreSupport/WebFrameLoaderClient.mm:
98 (WebFrameLoaderClient::createPreviewLoaderClient):
99 (WebFrameLoaderClient::createQuickLookHandleClient): Deleted.
101 2017-03-21 Anders Carlsson <andersca@apple.com>
103 Remove bogus availability annotations from DOM SPI headers.
104 rdar://problem/31015675
106 Rubber-stamped by Dan Bernstein.
108 * DOM/DOMHTMLMediaElement.h:
109 * DOM/DOMHTMLVideoElement.h:
110 * DOM/DOMMediaError.h:
111 * DOM/DOMTextEvent.h:
112 * DOM/DOMTimeRanges.h:
113 * DOM/DOMTokenList.h:
115 2017-03-19 Wenson Hsieh <wenson_hsieh@apple.com>
117 Teach TextIndicator to estimate the background color of the given Range
118 https://bugs.webkit.org/show_bug.cgi?id=169869
119 <rdar://problem/31127272>
121 Reviewed by Anders Carlsson and Simon Fraser.
123 Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.
125 * WebView/WebView.mm:
126 (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
127 (-[WebUITextIndicatorData dealloc]):
128 * WebView/WebViewPrivate.h:
130 2017-03-20 Dan Bernstein <mitz@apple.com>
132 [Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
133 https://bugs.webkit.org/show_bug.cgi?id=169861
135 Reviewed by Sam Weinig.
137 * MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
138 * postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the
139 timestamp file used by the Xcode project to determine whether to run the script.
141 2017-03-19 Alexey Proskuryakov <ap@apple.com>
143 WebHTMLView is useless as WebResourceHandler
144 https://bugs.webkit.org/show_bug.cgi?id=169857
146 Reviewed by Dan Bernstein.
148 * WebView/WebHTMLView.mm:
149 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
150 WebHTMLView doesnt implement any of WebResourceHandler methods.
152 2017-03-17 Michael Saboff <msaboff@apple.com>
154 Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
155 https://bugs.webkit.org/show_bug.cgi?id=169817
157 Reviewed by Filip Pizlo.
159 * Configurations/FeatureDefines.xcconfig:
161 2017-03-17 Antti Koivisto <antti@apple.com>
163 Add a reload policy where only expired subresources are revalidated
164 https://bugs.webkit.org/show_bug.cgi?id=169756
166 Reviewed by Andreas Kling.
168 * WebView/WebFrame.mm:
169 (toWebFrameLoadType):
170 (-[WebFrame reload]):
171 (-[WebFrame reloadFromOrigin]):
173 2017-03-17 Wenson Hsieh <wenson_hsieh@apple.com>
175 [WK1] Support animated transitions when performing a data interaction operation
176 https://bugs.webkit.org/show_bug.cgi?id=169805
177 <rdar://problem/31045767>
179 Reviewed by Beth Dakin and Megan Gardner.
181 Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
186 (-[DOMElement boundsInRootViewSpace]):
188 Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
190 * WebCoreSupport/WebDragClient.h:
192 * WebCoreSupport/WebDragClient.mm:
193 (WebDragClient::didConcludeEditDrag):
195 Add boilerplate plumbing.
197 * WebView/WebView.mm:
198 (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
200 Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
202 (floatRectsForCGRectArray):
203 (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
205 Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
206 image of some text, as well as clipping rects to apply to the image.
208 (-[WebView _dataOperationTextIndicator]):
210 Add SPI to fetch the text indicator used to drive animations for the current data operation.
212 (-[WebView _didConcludeEditDataInteraction]):
213 * WebView/WebViewData.h:
214 * WebView/WebViewInternal.h:
215 * WebView/WebViewPrivate.h:
217 2017-03-16 Simon Fraser <simon.fraser@apple.com>
219 Improve the system tracing points
220 https://bugs.webkit.org/show_bug.cgi?id=169790
222 Reviewed by Zalan Bujtas.
224 Use a more cohesive set of system trace points that give a good overview of what
225 WebKit is doing. Added points for resource loading, render tree building, sync messages
226 to the web process, async image decode, WASM and fetching cookies.
228 * WebView/WebHTMLView.mm:
229 (-[WebHTMLView drawRect:]):
231 2017-03-16 Youenn Fablet <youenn@apple.com>
233 Wrap legacy WebRTC API in runtime flag
234 https://bugs.webkit.org/show_bug.cgi?id=169646
236 Reviewed by Alex Christensen.
238 * WebView/WebPreferenceKeysPrivate.h:
239 * WebView/WebPreferences.mm:
240 (+[WebPreferences initialize]):
241 (-[WebPreferences webRTCLegacyAPIEnabled]):
242 (-[WebPreferences setWebRTCLegacyAPIEnabled:]):
243 * WebView/WebPreferencesPrivate.h:
244 * WebView/WebView.mm:
245 (-[WebView _preferencesChanged:]):
247 2017-03-14 Megan Gardner <megan_gardner@apple.com>
249 Correctly export WebItemProviderPasteboard
250 https://bugs.webkit.org/show_bug.cgi?id=169578
252 Reviewed by Tim Horton.
254 * MigrateHeaders.make:
256 2017-03-14 Wenson Hsieh <wenson_hsieh@apple.com>
258 [WK2] Data interaction tests occasionally hit assertions in debug builds
259 https://bugs.webkit.org/show_bug.cgi?id=169002
260 <rdar://problem/30994806>
262 Reviewed by Tim Horton.
264 Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.
266 * WebView/WebHTMLView.mm:
267 (-[WebHTMLView _updateSelectionForInputManager]):
268 * WebView/WebView.mm:
269 (-[WebView updateTextTouchBar]):
271 2017-03-13 Anders Carlsson <andersca@apple.com>
275 * WebCoreSupport/WebInspectorClient.mm:
276 (WebInspectorFrontendClient::save):
277 (-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
279 2017-03-11 Brady Eidson <beidson@apple.com>
281 Cleanup "addCookie" and its sole user.
282 https://bugs.webkit.org/show_bug.cgi?id=169486
284 Reviewed by Brian Burg.
286 * WebCoreSupport/WebPlatformStrategies.h:
287 * WebCoreSupport/WebPlatformStrategies.mm:
288 (WebPlatformStrategies::addCookie): Deleted.
290 2017-03-10 Alex Christensen <achristensen@webkit.org>
292 Fix watch and tv builds after r213294
293 https://bugs.webkit.org/show_bug.cgi?id=169508
295 Reviewed by Dan Bernstein.
297 * Configurations/FeatureDefines.xcconfig:
299 2017-03-10 Alex Christensen <achristensen@webkit.org>
303 * WebView/WebNotification.h:
304 Don't assume we have already included something that includes NSObject.h.
306 2017-03-09 Daniel Bates <dabates@apple.com>
308 Guard Credential Management implementation behind a runtime enabled feature flag
309 https://bugs.webkit.org/show_bug.cgi?id=169364
310 <rdar://problem/30957425>
312 Reviewed by Brent Fulgham.
314 Add WebKit preference for Credential Management (disabled by default).
316 * WebView/WebPreferenceKeysPrivate.h:
317 * WebView/WebPreferences.mm:
318 (+[WebPreferences initialize]):
319 (-[WebPreferences credentialManagementEnabled]): Added.
320 (-[WebPreferences setCredentialManagementEnabled:]): Added.
321 * WebView/WebPreferencesPrivate.h:
322 * WebView/WebView.mm:
323 (-[WebView _preferencesChanged:]):
325 2017-03-09 Anders Carlsson <andersca@apple.com>
327 Add delegate support to WebCore
328 https://bugs.webkit.org/show_bug.cgi?id=169427
329 Part of rdar://problem/28880714.
331 Reviewed by Geoffrey Garen.
333 * Configurations/FeatureDefines.xcconfig:
336 2017-03-08 Megan Gardner <megan_gardner@apple.com>
338 Fix DataInteraction guards
339 https://bugs.webkit.org/show_bug.cgi?id=169404
341 Reviewed by Wenson Hsieh.
343 * WebCoreSupport/WebDragClient.mm:
345 2017-03-08 Wenson Hsieh <wenson_hsieh@apple.com>
347 Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
348 https://bugs.webkit.org/show_bug.cgi?id=169392
349 <rdar://problem/30882974>
351 Reviewed by Tim Horton.
353 Add a stub implementation of WebDragClient::didConcludeEditDrag.
355 * WebCoreSupport/WebDragClient.h:
357 2017-03-08 Anders Carlsson <andersca@apple.com>
359 Simplify the PaymentCoordinator interface
360 https://bugs.webkit.org/show_bug.cgi?id=169382
361 Part of rdar://problem/28880714.
363 Reviewed by Tim Horton.
365 Update for PaymentCoordinatorClient changes.
367 * WebCoreSupport/WebPaymentCoordinatorClient.h:
368 * WebCoreSupport/WebPaymentCoordinatorClient.mm:
369 (WebPaymentCoordinatorClient::completeShippingMethodSelection):
370 (WebPaymentCoordinatorClient::completeShippingContactSelection):
371 (WebPaymentCoordinatorClient::completePaymentMethodSelection):
372 (WebPaymentCoordinatorClient::completePaymentSession):
374 2017-03-08 Megan Gardner <megan_gardner@apple.com>
376 Fix for dependency fix
377 https://bugs.webkit.org/show_bug.cgi?id=169369
379 Reviewed by Beth Dakin.
381 * WebView/WebViewPrivate.h:
383 2017-03-07 Megan Gardner <megan_gardner@apple.com>
385 Fix Project Dependency
386 https://bugs.webkit.org/show_bug.cgi?id=169340
388 Unreviewed Dependency Fix.
390 * WebView/WebViewPrivate.h:
392 2017-03-07 Alexey Proskuryakov <ap@apple.com>
394 WebKitLegacy should re-export symbols from WebCore on watchos and tvos
395 https://bugs.webkit.org/show_bug.cgi?id=169341
396 <rdar://problem/30913788>
398 Reviewed by Dan Bernstein.
400 * MigrateHeaders.make:
402 2017-03-07 Simon Fraser <simon.fraser@apple.com>
404 Have fixedPositionCreatesStackingContext be on by default everywhere
405 https://bugs.webkit.org/show_bug.cgi?id=169334
407 Reviewed by Zalan Bujtas.
409 It makes no sense to have web-exposed CSS functionality be different based on setting,
410 and other browser are now aligned with having position:fixed create stacking context.
412 So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
413 always force stacking context for position:fixed.
415 * WebView/WebView.mm:
416 (-[WebView _preferencesChanged:]):
418 2017-03-06 Simon Fraser <simon.fraser@apple.com>
420 Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
421 https://bugs.webkit.org/show_bug.cgi?id=169230
423 Reviewed by Tim Horton.
425 * WebView/WebView.mm:
426 (-[WebView _preferencesChanged:]):
428 2017-03-07 Simon Fraser <simon.fraser@apple.com>
430 Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
431 https://bugs.webkit.org/show_bug.cgi?id=169329
433 Reviewed by Tim Horton.
435 If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.
437 * WebView/WebPreferences.mm:
438 (+[WebPreferences initialize]):
440 2017-03-07 Megan Gardner <megan_gardner@apple.com>
442 Additional DataInteraction Support
443 https://bugs.webkit.org/show_bug.cgi?id=169316
444 <rdar://problem/30884234>
446 Reviewed by Wenson Hsieh.
448 Add stub implementations to WebView for methods that handle data interaction
450 * WebView/WebView.mm:
451 (-[WebView _enteredDataInteraction:client:global:operation:]):
452 (-[WebView _updatedDataInteraction:client:global:operation:]):
453 (-[WebView _exitedDataInteraction:client:global:operation:]):
454 (-[WebView _performDataInteraction:client:global:operation:]):
455 (-[WebView _endedDataInteraction:global:]):
456 * WebView/WebViewPrivate.h:
458 2017-03-07 Dean Jackson <dino@apple.com>
460 Some platforms won't be able to create a GPUDevice
461 https://bugs.webkit.org/show_bug.cgi?id=169314
462 <rdar://problems/30907521>
466 Disable WEB_GPU on the iOS Simulator.
468 * Configurations/FeatureDefines.xcconfig:
470 2017-03-07 Maureen Daum <mdaum@apple.com>
472 Correctly check for an empty database file.
473 <rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
474 https://bugs.webkit.org/show_bug.cgi?id=169256
476 Reviewed by Brady Eidson.
478 Check if the folder for an origin's WebSQL databases is empty after trying to delete
479 all of its files. Currently we check if the deletedDatabaseFileCount matches the number
480 of files that were in the folder. However, when we delete the actual database file in
481 DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
482 the database file, but deletedDatabaseFileCount only gets incremented once.
484 * Storage/WebDatabaseManager.mm:
485 (+[WebDatabaseManager removeEmptyDatabaseFiles]):
486 Delete the folder if it is empty.
488 2017-03-06 Michael Saboff <msaboff@apple.com>
490 Unreviewed build fix to add
491 -isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
492 for objective C++ files.
494 * Configurations/WebKitLegacy.xcconfig:
496 2017-03-06 Michael Saboff <msaboff@apple.com>
498 Take advantage of fast permissions switching of JIT memory for devices that support it
499 https://bugs.webkit.org/show_bug.cgi?id=169155
501 Reviewed by Saam Barati.
503 Updated the Xcode config files to match what is in the JavaScriptCore ones.
505 * Configurations/FeatureDefines.xcconfig:
507 2017-03-06 Myles C. Maxfield <mmaxfield@apple.com>
509 Expand font-weight and font-stretch to take any number
510 https://bugs.webkit.org/show_bug.cgi?id=168889
512 Reviewed by Simon Fraser.
514 Migrate off old enum types.
516 * WebCoreSupport/PopupMenuMac.mm:
517 (PopupMenuMac::populate):
518 * WebView/WebHTMLView.mm:
519 (fontNameForDescription):
520 * WebView/WebView.mm:
521 (-[WebView updateTextTouchBar]):
523 2017-03-03 Dean Jackson <dino@apple.com>
525 Add WebGPU compile flag and experimental feature flag
526 https://bugs.webkit.org/show_bug.cgi?id=169161
527 <rdar://problem/30846689>
529 Reviewed by Tim Horton.
531 Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
532 and an InternalSetting.
534 * Configurations/FeatureDefines.xcconfig:
535 * WebView/WebPreferenceKeysPrivate.h:
536 * WebView/WebPreferences.mm:
537 (+[WebPreferences initialize]):
538 (-[WebPreferences webGPUEnabled]):
539 (-[WebPreferences setWebGPUEnabled:]):
540 * WebView/WebPreferencesPrivate.h:
541 * WebView/WebView.mm:
542 (-[WebView _preferencesChanged:]):
544 2017-03-03 Alexey Proskuryakov <ap@apple.com>
547 rdar://problem/30825660
549 Suggested by Dan Bernstein.
551 * Configurations/WebKitLegacy.xcconfig:
553 2017-03-02 Sam Weinig <sam@webkit.org>
555 Rename htmlediting.h/cpp to Editing.h/cpp
556 https://bugs.webkit.org/show_bug.cgi?id=169103
558 Reviewed by Alex Christensen.
560 * DOM/DOMUIKitExtensions.mm:
561 * WebView/WebFrame.mm:
562 * WebView/WebView.mm:
564 2017-03-02 Megan Gardner <megan_gardner@apple.com>
567 https://bugs.webkit.org/show_bug.cgi?id=169114
569 Reviewed by Alex Christensen.
571 * WebView/WebView.mm:
573 2017-03-02 Megan Gardner <megan_gardner@apple.com>
576 https://bugs.webkit.org/show_bug.cgi?id=169112
578 Reviewed by Alex Christensen.
580 Fixed an internal build.
582 * WebView/WebView.mm:
583 * WebView/WebViewPrivate.h:
585 2017-03-02 Megan Gardner <megan_gardner@apple.com>
587 Data Interaction build fixes
588 https://bugs.webkit.org/show_bug.cgi?id=169096
590 Reviewed by Tim Horton.
592 Guards weren't all correct, also missed a selector name change.
594 * WebView/WebView.mm:
595 (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
596 * WebView/WebViewData.h:
597 * WebView/WebViewData.mm:
598 (-[WebViewPrivate dealloc]):
600 2017-03-02 Alex Christensen <achristensen@webkit.org>
602 Continue enabling WebRTC
603 https://bugs.webkit.org/show_bug.cgi?id=169056
607 * Configurations/FeatureDefines.xcconfig:
609 2017-03-01 Megan Gardner <megan_gardner@apple.com>
611 Data interaction support for WK1
612 https://bugs.webkit.org/show_bug.cgi?id=169062
614 Reviewed by Wenson Hsieh.
616 Support for data interaction in WebKit1
618 * WebCoreSupport/WebDragClient.mm:
619 * WebView/WebView.mm:
620 (-[WebUITextIndicatorData initWithImage:TextIndicatorData:scale:]):
621 (-[WebUITextIndicatorData initWithImage:scale:]):
622 (-[WebUITextIndicatorData dealloc]):
623 (-[WebView _requestStartDataInteraction:globalPosition:]):
624 (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
625 (-[WebView _getDataInteractionData]):
626 * WebView/WebViewData.h:
627 * WebView/WebViewData.mm:
628 (-[WebViewPrivate dealloc]):
629 * WebView/WebViewInternal.h:
630 * WebView/WebViewPrivate.h:
632 2017-03-02 Youenn Fablet <youenn@apple.com>
634 [WebRTC] Activate ICE candidate privacy policy
635 https://bugs.webkit.org/show_bug.cgi?id=168975
637 Reviewed by Alex Christensen.
639 * WebView/WebPreferenceKeysPrivate.h:
640 * WebView/WebPreferences.mm:
641 (-[WebPreferences enumeratingAllNetworkInterfacesEnabled]):
642 (-[WebPreferences setEnumeratingAllNetworkInterfacesEnabled:]):
643 (-[WebPreferences iceCandidateFilteringEnabled]):
644 (-[WebPreferences setIceCandidateFilteringEnabled:]):
645 * WebView/WebPreferencesPrivate.h:
647 2017-03-01 Alex Christensen <achristensen@webkit.org>
649 Unreviewed, rolling out r213259.
651 Broke an internal build
655 "Continue enabling WebRTC"
656 https://bugs.webkit.org/show_bug.cgi?id=169056
657 http://trac.webkit.org/changeset/213259
659 2017-03-01 Alex Christensen <achristensen@webkit.org>
661 Continue enabling WebRTC
662 https://bugs.webkit.org/show_bug.cgi?id=169056
666 * Configurations/FeatureDefines.xcconfig:
668 2017-02-27 Alex Christensen <achristensen@webkit.org>
670 Begin enabling WebRTC on 64-bit
671 https://bugs.webkit.org/show_bug.cgi?id=168915
673 Reviewed by Eric Carlson.
675 * Configurations/FeatureDefines.xcconfig:
677 2017-02-27 Aakash Jain <aakash_jain@apple.com>
679 Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
680 https://bugs.webkit.org/show_bug.cgi?id=168919
682 Reviewed by Tim Horton.
684 * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
685 * migrate-headers.sh: Run the migrate-headers script for installapi phase.
687 2017-02-27 Alex Christensen <achristensen@webkit.org>
689 [libwebrtc] Enable WebRTC in some Production Builds
690 https://bugs.webkit.org/show_bug.cgi?id=168858
692 * Configurations/FeatureDefines.xcconfig:
694 2017-02-26 Alexey Proskuryakov <ap@apple.com>
696 Don't import RetainPtr in WebNotification.h
697 https://bugs.webkit.org/show_bug.cgi?id=168876
699 Reviewed by Dan Bernstein.
701 This is an Objective-C SPI header.
703 * WebView/WebNotification.h:
704 * WebView/WebNotification.mm:
705 (-[WebNotification initWithCoreNotification:notificationID:]):
706 (-[WebNotification dealloc]):
708 2017-02-26 Aakash Jain <aakash_jain@apple.com>
710 Simplify EXPORTED_SYMBOLS_FILE variables in WebKitLegacy.xcconfig
711 https://bugs.webkit.org/show_bug.cgi?id=168819
713 Reviewed by Dan Bernstein.
715 * Configurations/WebKitLegacy.xcconfig:
717 2017-02-22 Aakash Jain <aakash_jain@apple.com>
719 Export Objective-C symbols for variables in Webkit SPI
720 https://bugs.webkit.org/show_bug.cgi?id=168758
722 Reviewed by Alexey Proskuryakov.
724 * Configurations/WebKitLegacy.xcconfig: using separate .exp file for i386.
725 * WebKit.exp: Added various Objective-C symbols.
727 2017-02-22 Aakash Jain <aakash_jain@apple.com>
729 Move instance members from WKQuadObject to implementation file
730 https://bugs.webkit.org/show_bug.cgi?id=168740
732 Reviewed by Tim Horton.
734 * DOM/DOM.mm: Moving instance member to implementation file.
735 * DOM/DOMExtensions.h: Ditto.
737 2017-02-22 Aakash Jain <aakash_jain@apple.com>
739 Move iOS specific symbols to WebKit.ios.exp
740 https://bugs.webkit.org/show_bug.cgi?id=168726
742 Reviewed by Alexey Proskuryakov.
746 2017-02-21 Youenn Fablet <youenn@apple.com>
748 [WebRTC][Mac] Activate libwebrtc
749 https://bugs.webkit.org/show_bug.cgi?id=167293
750 <rdar://problem/30401864>
752 Reviewed by Alex Christensen.
754 * Configurations/FeatureDefines.xcconfig:
756 2017-02-21 Aakash Jain <aakash_jain@apple.com>
758 Export various NSString symbols from WebFramePrivate.h
759 https://bugs.webkit.org/show_bug.cgi?id=168702
761 Reviewed by Alexey Proskuryakov.
765 2017-02-21 Aakash Jain <aakash_jain@apple.com>
767 Export various NSString symbols from WebPreferencesPrivate.h
768 https://bugs.webkit.org/show_bug.cgi?id=168701
770 Reviewed by Alexey Proskuryakov.
774 2017-02-21 Joseph Pecoraro <pecoraro@apple.com>
776 Add missing WebConsoleMessage string key
777 https://bugs.webkit.org/show_bug.cgi?id=168690
779 Reviewed by Alexey Proskuryakov.
782 * WebView/WebUIDelegatePrivate.h:
783 This key has an implementation but was not extern / exported like the others.
785 2017-02-21 Aakash Jain <aakash_jain@apple.com>
787 Export various NSString symbols from WebViewPrivate.h
788 https://bugs.webkit.org/show_bug.cgi?id=168689
790 Reviewed by Alexey Proskuryakov.
794 2017-02-21 Commit Queue <commit-queue@webkit.org>
796 Unreviewed, rolling out r212768.
797 https://bugs.webkit.org/show_bug.cgi?id=168698
799 Rolling out since this would break other projects. (Requested
800 by aakashjain on #webkit).
804 "[iOS] Remove old WebKit1 MemoryMeasure helper."
805 https://bugs.webkit.org/show_bug.cgi?id=168675
806 http://trac.webkit.org/changeset/212768
808 2017-02-20 Simon Fraser <simon.fraser@apple.com>
810 Add support to PlatformCALayer/GraphicsLayerCA for subpixel-antialiased text, with a Setting and a MiniBrowser switch
811 https://bugs.webkit.org/show_bug.cgi?id=168620
812 <rdar://problem/30617772>
814 Reviewed by Tim Horton.
816 * WebView/WebPreferenceKeysPrivate.h:
817 * WebView/WebPreferences.mm:
818 (+[WebPreferences initialize]):
819 (-[WebPreferences subpixelAntialiasedLayerTextEnabled]):
820 (-[WebPreferences setSubpixelAntialiasedLayerTextEnabled:]):
821 * WebView/WebPreferencesPrivate.h:
823 2017-02-21 Aakash Jain <aakash_jain@apple.com>
825 Export various NSString symbols from WebUIDelegatePrivate.h
826 https://bugs.webkit.org/show_bug.cgi?id=168679
828 Reviewed by Joseph Pecoraro.
832 2017-02-21 Aakash Jain <aakash_jain@apple.com>
834 Export symbols for various classes present in webkit SPI
835 https://bugs.webkit.org/show_bug.cgi?id=168674
837 Reviewed by Dan Bernstein.
841 2017-02-21 Andreas Kling <akling@apple.com>
843 [iOS] Remove old WebKit1 MemoryMeasure helper.
844 <https://webkit.org/b/168675>
846 Reviewed by Sam Weinig.
848 * Configurations/WebKitLegacy.xcconfig:
850 (+[WebCache emptyInMemoryResources]):
851 * WebView/WebView.mm:
853 2017-02-21 Andreas Kling <akling@apple.com>
855 [iOS] WebKit1 should use shared memory pressure handler code.
856 <https://webkit.org/b/168653>
858 Reviewed by Antti Koivisto.
860 Register a WebThread-aware memory callback with the shared MemoryPressureHandler
861 and get rid of the old iOS WebKit1 specific implementation. Some of it was even
862 dead code since MobileSafari has been using WebKit2 for quite a while.
865 * WebView/WebView.mm:
866 (WebInstallMemoryPressureHandler):
867 (+[WebView _handleMemoryWarning]): Deleted.
868 (+[WebView registerForMemoryNotifications]): Deleted.
869 (+[WebView releaseFastMallocMemoryOnCurrentThread]): Deleted.
870 (+[WebView garbageCollectNow]): Deleted.
871 (+[WebView purgeInactiveFontData]): Deleted.
872 (+[WebView drainLayerPool]): Deleted.
873 (+[WebView discardAllCompiledCode]): Deleted.
874 (+[WebView _clearMemoryPressure]): Deleted.
875 (+[WebView _shouldWaitForMemoryClearMessage]): Deleted.
876 * WebView/WebViewPrivate.h:
878 2017-02-20 Aakash Jain <aakash_jain@apple.com>
880 Stop exporting interface WebCoreScrollView on iOS
881 https://bugs.webkit.org/show_bug.cgi?id=168536
883 Reviewed by Dan Bernstein.
885 * WebKit.exp: Moved symbol for WebCoreScrollView interface to mac specific file.
886 * WebKit.mac.exp: Ditto.
887 * WebView/WebHTMLView.mm: WebCoreScrollView shouldn't be defined for iOS platform.
889 2017-02-20 Aakash Jain <aakash_jain@apple.com>
891 Exclude various mac-specific header files from iOS build
892 https://bugs.webkit.org/show_bug.cgi?id=168621
894 Reviewed by Dan Bernstein.
896 * Configurations/WebKitLegacy.xcconfig:
898 2017-02-20 Wenson Hsieh <wenson_hsieh@apple.com>
900 Add plumbing to the UI process for TextIndicatorData when computing the drag image
901 https://bugs.webkit.org/show_bug.cgi?id=168583
902 Work towards <rdar://problem/30313681>
904 Accounts for changes in WebCore -- see Source/WebCore/ChangeLog for more details.
906 Reviewed by Tim Horton.
908 * WebView/WebHTMLView.mm:
909 (-[WebHTMLView _selectionDraggingImage]):
910 (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
912 2017-02-17 Anders Carlsson <andersca@apple.com>
914 Add a new drag code path and use it for dragging plain text
915 https://bugs.webkit.org/show_bug.cgi?id=168534
917 Reviewed by Geoffrey Garen.
919 * WebCoreSupport/WebDragClient.h:
922 * WebCoreSupport/WebDragClient.mm:
923 (WebDragClient::useLegacyDragClient):
926 (WebDragClient::beginDrag):
927 New client member function. Create an NSDraggingItem and use it to begin a dragging session.
929 * WebView/WebHTMLView.mm:
930 (-[WebHTMLView draggingSession:sourceOperationMaskForDraggingContext:]):
931 Get the source operation mask from WebCore.
933 (-[WebHTMLView draggingSession:endedAtPoint:operation:]):
934 Send a fake mouse up event.
936 * WebView/WebHTMLViewInternal.h:
937 Declare that WebHTMLView conforms to NSDraggingSource.
939 2017-02-20 Alexey Proskuryakov <ap@apple.com>
941 List of WebCore symbols to re-export from WebKitLegacy should be built automatically
942 https://bugs.webkit.org/show_bug.cgi?id=168342
943 rdar://problem/26182266
945 Reviewed by Tim Horton.
947 * MigrateHeaders.make: On iOS only, process re-exported headers to build a list of
948 symbols to re-export.
950 2017-02-20 Aakash Jain <aakash_jain@apple.com>
952 Stop exporting DOMTokenList from WebKit
953 https://bugs.webkit.org/show_bug.cgi?id=168544
955 Reviewed by Alexey Proskuryakov.
959 2017-02-20 Alexey Proskuryakov <ap@apple.com>
961 Clean up how WebKit exports _WebCreateFragment
962 https://bugs.webkit.org/show_bug.cgi?id=168579
964 Reviewed by Dan Bernstein.
966 * WebCoreSupport/WebCreateFragmentInternal.h: Added a private header.
967 * WebCoreSupport/WebEditorClient.mm: Include the new header that declares _WebCreateFragment.
969 2017-02-20 Aakash Jain <aakash_jain@apple.com>
971 Stop exporting DOMNodeFilter
972 https://bugs.webkit.org/show_bug.cgi?id=168542
974 Reviewed by Alexey Proskuryakov.
978 2017-02-20 Manuel Rego Casasnovas <rego@igalia.com>
980 [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
981 https://bugs.webkit.org/show_bug.cgi?id=167693
983 Reviewed by Sergio Villar Senin.
985 * Configurations/FeatureDefines.xcconfig:
986 * WebView/WebPreferences.mm:
987 (+[WebPreferences initialize]):
988 * WebView/WebView.mm:
989 (-[WebView _preferencesChanged:]):
991 2017-02-15 Brady Eidson <beidson@apple.com>
993 Stop backing up localStorage databases to iCloud by default.
994 <rdar://problem/29045531> and https://bugs.webkit.org/show_bug.cgi?id=168388
996 Reviewed by Geoffrey Garen.
998 * Misc/WebKitVersionChecks.h:
999 * Misc/WebKitVersionChecks.mm: Renamed from Source/WebKit/mac/Misc/WebKitVersionChecks.m.
1000 (WebKitLinkedOnOrAfter):
1001 (setWebKitLinkTimeVersion):
1002 (WebKitLinkTimeVersion):
1005 * Storage/WebStorageManager.mm:
1006 (WebKitInitializeStorageIfNecessary):
1008 2017-02-16 Daniel Bates <dabates@apple.com>
1010 Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
1011 https://bugs.webkit.org/show_bug.cgi?id=168417
1012 <rdar://problem/30541748>
1014 Reviewed by Brent Fulgham.
1016 Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
1017 Widget* as it is always called with a valid Widget.
1019 * WebCoreSupport/WebFrameLoaderClient.h:
1020 * WebCoreSupport/WebFrameLoaderClient.mm:
1021 (WebFrameLoaderClient::redirectDataToPlugin):
1022 * WebKit.order: Remove symbol for WebFrameLoaderClient::redirectDataToPlugin() that took a Widget*
1023 as it no longer exists. I am unclear if this file is still meaningful as it was last modified in
1024 r180570 (2 years ago) though Xcode still references this ordering file (why?).
1026 2017-02-16 Yusuke Suzuki <utatane.tea@gmail.com>
1028 [JSC] Drop PassRefPtr in inspector/
1029 https://bugs.webkit.org/show_bug.cgi?id=168420
1031 Reviewed by Alex Christensen.
1033 * WebView/WebScriptDebugger.mm:
1034 (WebScriptDebugger::handlePause):
1036 2017-02-16 Simon Fraser <simon.fraser@apple.com>
1038 Clean up use of some CALayer-related SPI
1039 https://bugs.webkit.org/show_bug.cgi?id=168401
1041 Reviewed by Tim Horton.
1043 Include CALayer.h not CATiledLayer.h.
1045 * WebInspector/WebNodeHighlight.h:
1047 2017-02-15 Wenson Hsieh <wenson_hsieh@apple.com>
1049 Fix the build after r212379
1051 Rubber-stamped by Anders Carlsson.
1053 * WebCoreSupport/WebDragClient.mm:
1054 (WebDragClient::startDrag):
1056 2017-02-15 Anders Carlsson <andersca@apple.com>
1058 Modernize DragClient::startDrag somewhat
1059 https://bugs.webkit.org/show_bug.cgi?id=168379
1061 Reviewed by Tim Horton.
1063 Update for WebCore changes.
1065 * WebCoreSupport/WebDragClient.h:
1066 * WebCoreSupport/WebDragClient.mm:
1067 (WebDragClient::startDrag):
1069 2017-02-14 Dean Jackson <dino@apple.com>
1071 Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
1072 https://bugs.webkit.org/show_bug.cgi?id=168339
1074 Reviewed by Simon Fraser.
1078 * WebView/WebPreferenceKeysPrivate.h:
1079 * WebView/WebPreferences.mm:
1080 (+[WebPreferences initialize]):
1081 (-[WebPreferences forceLowPowerGPUForWebGL]):
1082 (-[WebPreferences setForceLowPowerGPUForWebGL:]):
1083 (-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
1084 (-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.
1085 * WebView/WebPreferencesPrivate.h:
1086 * WebView/WebView.mm:
1087 (-[WebView _preferencesChanged:]):
1089 2017-02-14 Chris Dumez <cdumez@apple.com>
1091 HTML Form Validation bubble should take minimum font size setting into consideration
1092 https://bugs.webkit.org/show_bug.cgi?id=168271
1093 <rdar://problem/29869869>
1095 Reviewed by Simon Fraser.
1097 * WebView/WebView.mm:
1098 (-[WebView _contentsOfUserInterfaceItem:]):
1099 Return font size used in the validation bubble.
1101 (-[WebView showFormValidationMessage:withAnchorRect:]):
1102 Pass minimum font size setting when constructing the validation bubble.
1104 2017-02-14 Anders Carlsson <andersca@apple.com>
1106 Remove an unused delegate method
1107 https://bugs.webkit.org/show_bug.cgi?id=168328
1109 Reviewed by Wenson Hsieh.
1111 * DefaultDelegates/WebDefaultUIDelegate.m:
1112 (-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.
1114 2017-02-14 Alexey Proskuryakov <ap@apple.com>
1116 WebCore shouldn't export SystemMemory.h
1117 https://bugs.webkit.org/show_bug.cgi?id=168285
1119 Reviewed by Alex Christensen.
1121 * MigrateHeaders.make: And WebKit shouldn't re-export it.
1123 2017-02-13 Alexey Proskuryakov <ap@apple.com>
1125 WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
1126 https://bugs.webkit.org/show_bug.cgi?id=168282
1128 Reviewed by Dan Bernstein.
1130 * MigrateHeaders.make:
1132 2017-02-12 Dan Bernstein <mitz@apple.com>
1134 Tried to fix USE(APPLE_INTERNAL_SDK) builds after r212211.
1136 * WebView/WebHTMLView.mm:
1137 (createShareMenuItem): Use non-deprecated method.
1139 2017-02-12 Dan Bernstein <mitz@apple.com>
1141 [Cocoa] Some -respondsToSelector: checks are unnecessary
1142 https://bugs.webkit.org/show_bug.cgi?id=168183
1144 Reviewed by Tim Horton.
1146 * WebView/WebFullScreenController.mm:
1147 (-[WebFullScreenController applicationDidResignActive:]): Removed check whether NSWindow
1148 responds to -isOnActiveSpace.
1149 (-[WebFullScreenController exitFullScreen]): Ditto.
1150 (-[WebFullScreenController _updateMenuAndDockForFullScreen]): Removed check whether
1151 NSApplication responds to -setPresentationOptions.
1153 * WebView/WebHTMLView.mm:
1154 (createShareMenuItem): Removed unnecessary -respondsToSelector: check.
1155 (-[WebHTMLView otherMouseDown:]): Ditto.
1157 * WebView/WebImmediateActionController.mm:
1158 (-[WebImmediateActionController _clearImmediateActionState]): Ditto.
1159 (-[WebImmediateActionController _animationControllerForDataDetectedText]): Ditto.
1161 * WebView/WebView.mm:
1162 (-[WebView _didStartProvisionalLoadForFrame:]): Removed redundant nil check.
1163 (+[WebView _setCacheModel:]): Removed unnecessary -respondsToSelector: check.
1165 2017-02-10 Daniel Bates <dabates@apple.com>
1167 Detach frame from document when entering page cache
1168 https://bugs.webkit.org/show_bug.cgi?id=166774
1169 <rdar://problem/29904368>
1171 Reviewed by Chris Dumez.
1173 * WebView/WebPreferenceKeysPrivate.h:
1174 * WebView/WebPreferences.mm:
1175 (+[WebPreferences initialize]):
1176 (-[WebPreferences allowsPageCacheWithWindowOpener]): Deleted.
1177 (-[WebPreferences setAllowsPageCacheWithWindowOpener:]): Deleted.
1178 * WebView/WebPreferencesPrivate.h:
1179 * WebView/WebView.mm:
1180 (-[WebView _preferencesChanged:]):
1182 2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
1184 [Resource Timing] Enable Resource Timing by default in Tests
1185 https://bugs.webkit.org/show_bug.cgi?id=168145
1187 Reviewed by Ryosuke Niwa.
1189 * WebView/WebPreferenceKeysPrivate.h:
1190 * WebView/WebPreferences.mm:
1191 (+[WebPreferences initialize]):
1192 (-[WebPreferences resourceTimingEnabled]):
1193 (-[WebPreferences setResourceTimingEnabled:]):
1194 * WebView/WebPreferencesPrivate.h:
1195 * WebView/WebView.mm:
1196 (-[WebView _preferencesChanged:]):
1198 2017-02-10 Aakash Jain <aakash_jain@apple.com>
1200 cleanup WebLocalizableStrings.
1201 https://bugs.webkit.org/show_bug.cgi?id=168078
1203 Reviewed by Alexey Proskuryakov.
1205 * Misc/WebLocalizableStrings.h: Make visibility hidden for WebLocalizableStringsBundle
1206 as it's for each framework's own consumption, and never needs to be exported.
1208 2017-02-10 Aakash Jain <aakash_jain@apple.com>
1210 WebResourceLoadDelegatePrivate.h cannot be imported standalone
1211 https://bugs.webkit.org/show_bug.cgi?id=168096
1213 Reviewed by Alexey Proskuryakov.
1215 * WebView/WebResourceLoadDelegatePrivate.h: Change WebNSInteger to NSInteger.
1217 2017-02-09 Antti Koivisto <antti@apple.com>
1219 Remove most cases of #if ENABLE(CACHE_PARTITIONING)
1220 https://bugs.webkit.org/show_bug.cgi?id=167990
1222 Reviewed by Sam Weinig.
1225 (+[WebCache addImageToCache:forURL:forFrame:]):
1226 (+[WebCache removeImageFromCacheForURL:forFrame:]):
1227 * WebCoreSupport/WebSystemInterface.mm:
1228 (InitWebCoreSystemInterface):
1230 2017-02-07 Alexey Proskuryakov <ap@apple.com>
1232 Don't migrate WebKit DOM headers in MigrateHeaders.make
1233 https://bugs.webkit.org/show_bug.cgi?id=167608
1235 Reviewed by Darin Adler.
1237 Stop migrating DOM headers that are now in WebKit.
1239 * DOM/DOMDOMImplementation.h: Removed.
1240 * DOM/DOMDOMImplementation.mm: Removed.
1241 * DOM/DOMDOMImplementationInternal.h: Removed.
1242 * DOM/DOMDOMTokenList.h: Removed.
1243 * DOM/DOMDOMTokenList.mm: Removed.
1244 * DOM/DOMDOMTokenListInternal.h: Removed.
1245 * DOM/DOMImplementation.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.h.
1246 * DOM/DOMImplementation.mm: Copied from Source/WebKit/mac/DOM/DOMDOMImplementation.mm.
1247 * DOM/DOMImplementationInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMImplementationInternal.h.
1248 * DOM/DOMTokenList.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.h.
1249 * DOM/DOMTokenList.mm: Copied from Source/WebKit/mac/DOM/DOMDOMTokenList.mm.
1250 * DOM/DOMTokenListInternal.h: Copied from Source/WebKit/mac/DOM/DOMDOMTokenListInternal.h.
1251 As the files are not in WebCore any more, there is no need to differentiate from
1252 WebCore internal headers with the same name. This makes it possible to make these
1253 headers private using Xcode mechanisms, as opposed to copying with a shell script.
1255 * DOM/DOMElement.mm: Removed "using namespace WebCore". Other DOM implementation
1256 files don't have it.
1259 * DOM/DOMDocument.mm:
1260 * DOM/DOMHTMLAnchorElement.mm:
1261 * DOM/DOMHTMLAreaElement.mm:
1262 * DOM/DOMHTMLLinkElement.mm:
1263 * DOM/DOMUtility.mm:
1267 No more "DOMDOM". DOMDOMTokenList was not directly exposed via an SPI header, so
1268 renaming it is likely to be safe.
1270 * MigrateHeaders.make: Don't migrate WebKit headers.
1272 * Configurations/WebKitLegacy.xcconfig: Don't include two iOS specific SPI headers
1275 2017-02-08 Aakash Jain <aakash_jain@apple.com>
1277 Don't re-export PluginData.h from WebKit
1278 https://bugs.webkit.org/show_bug.cgi?id=168020
1280 Reviewed by Alexey Proskuryakov.
1282 * MigrateHeaders.make: Removed PluginData.h
1284 2017-02-08 Aakash Jain <aakash_jain@apple.com>
1286 Don't re-export WKUtilities.h from WebKit
1287 https://bugs.webkit.org/show_bug.cgi?id=167977
1289 Reviewed by Alexey Proskuryakov.
1291 * MigrateHeaders.make: Removed WKUtilities.h
1293 2017-02-06 Alex Christensen <achristensen@webkit.org>
1295 credentials should be partitioned by main document domain
1296 https://bugs.webkit.org/show_bug.cgi?id=166998
1297 rdar://problem/22901123
1299 Reviewed by Brady Eidson.
1301 * Misc/WebDownload.mm:
1302 * Plugins/WebBaseNetscapePluginView.mm:
1303 (WebKit::getAuthenticationInfo):
1304 Don't use partitioned credentials for WebKit1 plugins or downloads.
1305 Downloads should be authenticated before becoming a download anyways.
1307 2017-02-06 Said Abou-Hallawa <sabouhallawa@apple.com>
1309 Rename AnimationController to CSSAnimationController
1310 https://bugs.webkit.org/show_bug.cgi?id=167829
1312 Reviewed by Simon Fraser.
1314 * WebView/WebFrame.mm:
1315 * WebView/WebView.mm:
1317 2017-02-03 Chris Dumez <cdumez@apple.com>
1319 Dismiss HTML form validation popover when pressing Escape key
1320 https://bugs.webkit.org/show_bug.cgi?id=167716
1321 <rdar://problem/29872943>
1323 Reviewed by Simon Fraser.
1325 Override ValidationMessageClient::hideAnyValidationMessage().
1327 * WebCoreSupport/WebValidationMessageClient.h:
1328 * WebCoreSupport/WebValidationMessageClient.mm:
1329 (WebValidationMessageClient::hideAnyValidationMessage):
1331 2017-02-02 Wenson Hsieh <wenson_hsieh@apple.com>
1333 Drag images should be anchored to the mouse location
1334 https://bugs.webkit.org/show_bug.cgi?id=167690
1335 <rdar://problem/30295261>
1337 Reviewed by Enrica Casucci.
1339 Adds some plumbing for the anchor point in the WK1 client layer.
1341 * WebCoreSupport/WebDragClient.h:
1342 * WebCoreSupport/WebDragClient.mm:
1343 (WebDragClient::startDrag):
1345 2017-02-02 Chris Dumez <cdumez@apple.com>
1347 Rename Node::inDocument() to isConnected()
1348 https://bugs.webkit.org/show_bug.cgi?id=167743
1350 Reviewed by Sam Weinig.
1352 Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
1353 - https://dom.spec.whatwg.org/#connected
1356 (-[DOMNode isConnected]):
1357 * WebView/WebFrame.mm:
1358 (-[WebFrame selectNSRange:onElement:]):
1360 2017-02-02 Chris Dumez <cdumez@apple.com>
1362 [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
1363 https://bugs.webkit.org/show_bug.cgi?id=167738
1364 <rdar://problem/30229990>
1366 Reviewed by Andreas Kling.
1368 The BackForwardClient no longer needs to worry about removing HistoryItems
1369 from the PageCache now that WebCore takes care of it.
1371 * History/BackForwardList.mm:
1372 (BackForwardList::close):
1374 2017-02-02 Yongjun Zhang <yongjun_zhang@apple.com>
1376 In iOS, we should take background assertion when accessing localstorage databases.
1377 https://bugs.webkit.org/show_bug.cgi?id=165478
1379 Move database transaction background task handling code from WebDatabaseManager to
1380 WebCore's WebSQLiteDatabaseTrackerClient.
1382 Reviewed by Brady Eidson.
1384 * Storage/WebDatabaseManager.mm:
1385 * Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
1386 * WebCoreSupport/WebApplicationCache.mm:
1387 (+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
1388 * WebView/WebView.mm:
1389 (-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
1391 2017-02-01 Wenson Hsieh <wenson_hsieh@apple.com>
1393 [WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
1394 https://bugs.webkit.org/show_bug.cgi?id=167695
1395 <rdar://problem/30305390>
1397 Reviewed by Sam Weinig.
1399 Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
1400 exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
1403 * WebView/WebView.mm:
1404 (-[WebView _commonInitializationWithFrameName:groupName:]):
1406 2017-01-31 Joseph Pecoraro <pecoraro@apple.com>
1408 ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
1409 https://bugs.webkit.org/show_bug.cgi?id=167684
1411 Reviewed by Dan Bernstein.
1414 (-[DOMHTMLInputElement _isAutofilled]): Deleted.
1415 (-[DOMHTMLInputElement _setAutofilled:]): Deleted.
1416 Consolidate in the WebDOMOperationsPrivate category.
1419 Include WebDOMOperationsPrivate header to get other DOM Private categories.
1421 * DOM/WebDOMOperations.mm:
1422 (-[DOMHTMLInputElement _isAutofilled]):
1423 * DOM/WebDOMOperationsPrivate.h:
1424 Include getter alongside the setter.
1426 2017-01-31 Jessie Berlin <jberlin@webkit.org>
1430 * Misc/WebNSPasteboardExtras.mm:
1431 (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1432 (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1433 * WebView/WebHTMLView.mm:
1434 (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1435 (-[WebHTMLView copyFont:]):
1437 2017-01-30 Andy Estes <aestes@apple.com>
1439 [QuickLook] FrameLoaderClient should return the new QuickLookHandleClient it creates
1440 https://bugs.webkit.org/show_bug.cgi?id=167625
1442 Reviewed by Andreas Kling.
1444 * WebCoreSupport/WebFrameLoaderClient.h: Declared createQuickLookHandleClient().
1445 * WebCoreSupport/WebFrameLoaderClient.mm:
1446 (WebFrameLoaderClient::createQuickLookHandleClient): Renamed from didCreateQuickLookHandle().
1447 (WebFrameLoaderClient::didCreateQuickLookHandle): Renamed to createQuickLookHandleClient().
1449 2017-01-30 Chris Dumez <cdumez@apple.com>
1451 Drop legacy Attributes.isId attribute
1452 https://bugs.webkit.org/show_bug.cgi?id=167603
1454 Reviewed by Ryosuke Niwa.
1456 Keep Attr.isId in ObjC bindings.
1461 2017-01-30 Andreas Kling <akling@apple.com>
1463 [macOS] WebHTMLView has an internal retain cycle with its flagsChangedEventMonitor.
1464 <https://webkit.org/b/167580>
1466 Reviewed by Antti Koivisto.
1468 Avoid the implicit strong capture of self by keeping it in a __block variable.
1469 Also add code to dealloc to unregister the event monitor, since it will otherwise leak.
1470 This fixes huge WebHTMLView leaks seen on the leaks bot.
1472 * WebView/WebHTMLView.mm:
1473 (-[WebHTMLViewPrivate dealloc]):
1474 (-[WebHTMLView viewDidMoveToWindow]):
1476 2017-01-29 Andy Estes <aestes@apple.com>
1478 [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1479 https://bugs.webkit.org/show_bug.cgi?id=167563
1480 <rdar://problem/30253207>
1482 Reviewed by Andreas Kling.
1484 Instead of only saving QuickLook documents to a temporary file when the client is
1485 MobileSafari, base this decision on a WebPreference that clients can choose to enable.
1487 This also changes the SPI for accessing the temporary file path and UTI. Instead of
1488 -[WebView quickLookContentForURL:], which requires the client to pass the response URL of
1489 the frame that saved the QuickLook document, the content dictionary is now stored as a
1490 property of WebDataSource.
1492 This also removes the manual lifetime management of the QLPreviewConverter from
1493 QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
1494 which ensures it lives long enough to respond to subresource requests.
1496 New API test: QuickLook.LegacyQuickLookContent
1498 * WebCoreSupport/WebFrameLoaderClient.mm:
1499 (WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
1500 write a temporary file to here from the QuickLookDocumentWriter constructor.
1501 * WebView/WebDataSource.mm: Declared _quickLookContent.
1502 (-[WebDataSource _quickLookContent]):
1503 (-[WebDataSource _setQuickLookContent:]):
1504 * WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
1505 * WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
1506 * WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
1507 * WebView/WebPreferences.mm:
1508 (-[WebPreferences quickLookDocumentSavingEnabled]):
1509 (-[WebPreferences setQuickLookDocumentSavingEnabled:]):
1510 * WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
1511 * WebView/WebView.mm:
1512 (-[WebView quickLookContentForURL:]): Changed to always return nil.
1513 * WebView/WebViewPrivate.h: Added a comment stating that clients should use
1514 -[WebDataSource _quickLookContent] instead.
1516 2017-01-28 Yoav Weiss <yoav@yoav.ws>
1518 Add Link Preload as an off-by-default experimental feature menu item.
1519 https://bugs.webkit.org/show_bug.cgi?id=167201
1521 Reviewed by Ryosuke Niwa.
1523 * WebView/WebPreferenceKeysPrivate.h:
1524 * WebView/WebPreferences.mm:
1525 (-[WebPreferences linkPreloadEnabled]):
1526 (-[WebPreferences setLinkPreloadEnabled:]):
1527 * WebView/WebPreferencesPrivate.h:
1528 * WebView/WebView.mm:
1529 (-[WebView _preferencesChanged:]):
1531 2017-01-28 Joseph Pecoraro <pecoraro@apple.com>
1533 Add User Timing Experimental Feature
1534 https://bugs.webkit.org/show_bug.cgi?id=167542
1535 <rdar://problem/22746307>
1537 Reviewed by Ryosuke Niwa.
1539 * WebView/WebPreferenceKeysPrivate.h:
1540 * WebView/WebPreferences.mm:
1541 (+[WebPreferences initialize]):
1542 (-[WebPreferences userTimingEnabled]):
1543 (-[WebPreferences setUserTimingEnabled:]):
1544 * WebView/WebPreferencesPrivate.h:
1545 * WebView/WebView.mm:
1546 (-[WebView _preferencesChanged:]):
1547 Add setting for User Timing runtime enabled feature.
1549 2017-01-27 Wenson Hsieh <wenson_hsieh@apple.com>
1551 [WK1] Do not prevent the drag client from initializing on Mac
1552 https://bugs.webkit.org/show_bug.cgi?id=167541
1554 Reviewed by Dan Bernstein.
1556 Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
1557 initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
1558 This caused certain clients, such as Mail, to crash when a webView closes due to null dereference.
1560 * WebCoreSupport/WebDragClient.mm:
1561 (WebDragClient::WebDragClient):
1562 (WebDragClient::actionMaskForDrag):
1563 (WebDragClient::willPerformDragDestinationAction):
1564 (WebDragClient::dragSourceActionMaskForPoint):
1565 (WebDragClient::willPerformDragSourceAction):
1566 (WebDragClient::startDrag):
1567 (WebDragClient::declareAndWriteDragImage):
1568 (WebDragClient::declareAndWriteAttachment):
1569 * WebView/WebView.mm:
1570 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1572 2017-01-26 Chris Dumez <cdumez@apple.com>
1574 Crash when navigating back to a page in PacheCache when one of its frames has been removed
1575 https://bugs.webkit.org/show_bug.cgi?id=167421
1576 <rdar://problem/30188490>
1578 Reviewed by Darin Adler.
1580 Add a new setting allowing layout tests to enable PageCache in a window
1581 that has an opener, for convenience.
1583 * WebView/WebPreferenceKeysPrivate.h:
1584 * WebView/WebPreferences.mm:
1585 (+[WebPreferences initialize]):
1586 (-[WebPreferences allowsPageCacheWithWindowOpener]):
1587 (-[WebPreferences setAllowsPageCacheWithWindowOpener:]):
1588 * WebView/WebPreferencesPrivate.h:
1589 * WebView/WebView.mm:
1590 (-[WebView _preferencesChanged:]):
1592 2017-01-26 Keith Miller <keith_miller@apple.com>
1594 classInfo should take a VM so it is not materialized from the object on each call
1595 https://bugs.webkit.org/show_bug.cgi?id=167424
1597 Rubber Stamped by Michael Saboff.
1599 Previously, classInfo() would get the VM from the target's
1600 MarkedBlock. Most callers already have a VM on hand, so it is
1601 wasteful to compute the VM from the marked block every time. This
1602 patch refactors some of the most common callers of classInfo(),
1603 jsDynamicCast and inherits to take a VM as well.
1606 (+[DOMNode _nodeFromJSWrapper:]):
1607 * DOM/DOMUtility.mm:
1609 * DOM/WebDOMOperations.mm:
1610 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1611 (WebKit::getObjectID):
1612 (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
1613 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
1614 * Plugins/Hosted/ProxyInstance.mm:
1615 (WebKit::ProxyRuntimeMethod::finishCreation):
1616 (WebKit::ProxyInstance::invokeMethod):
1617 * Plugins/Hosted/ProxyRuntimeObject.mm:
1618 (WebKit::ProxyRuntimeObject::finishCreation):
1619 * WebView/WebFrame.mm:
1620 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1621 * WebView/WebView.mm:
1622 (+[WebView _reportException:inContext:]):
1623 (aeDescFromJSValue):
1624 (-[WebView _notificationIDForTesting:]):
1626 2017-01-26 Wenson Hsieh <wenson_hsieh@apple.com>
1628 REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes
1629 https://bugs.webkit.org/show_bug.cgi?id=167472
1630 <rdar://problem/30149809>
1632 Reviewed by Beth Dakin.
1634 Revision 207483 caused the touch bar to stop showing up in HTML Notes due to -updateTextTouchBar not
1635 initializing the text touch bar and causing -makeTouchBar to return nil while processing a mouse click. The
1636 purpose of bailing out of the update was to prevent the text touch bar from thrashing during a selection drag.
1637 If the text touch bar doesn't exist yet, we don't have to worry about its appearance flickering from a different
1638 previous state, so we should just allow the touch bar to update instead.
1640 * WebView/WebView.mm:
1641 (-[WebView updateTextTouchBar]):
1643 2017-01-26 Per Arne Vollan <pvollan@apple.com>
1645 Crash when setting custom scale factor.
1646 https://bugs.webkit.org/show_bug.cgi?id=167369
1648 Reviewed by Sam Weinig.
1650 Add null pointer check.
1652 * WebView/WebView.mm:
1653 (-[WebView _setCustomBackingScaleFactor:]):
1655 2017-01-25 Wenson Hsieh <wenson_hsieh@apple.com>
1657 Refactor drag and drop implementation on Mac
1658 https://bugs.webkit.org/show_bug.cgi?id=167427
1660 Reviewed by Enrica Casucci.
1662 Refactor some WebKit1 code on the Mac pertaining to drag and drop. See WebCore ChangeLog for more details.
1664 * Misc/WebNSPasteboardExtras.h:
1665 * WebCoreSupport/WebDragClient.mm:
1666 * WebView/WebFrame.mm:
1667 * WebView/WebFrameInternal.h:
1668 * WebView/WebHTMLView.mm:
1669 * WebView/WebView.mm:
1670 (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1672 2017-01-24 Youenn Fablet <youennf@gmail.com>
1674 [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
1675 https://bugs.webkit.org/show_bug.cgi?id=167294
1677 Reviewed by Alex Christensen.
1679 * WebView/WebView.mm:
1680 (-[WebView _commonInitializationWithFrameName:groupName:]):
1682 2017-01-25 Wenson Hsieh <wenson_hsieh@apple.com>
1684 Add support for named pasteboards, pasteboard strategies and platform pasteboards
1685 https://bugs.webkit.org/show_bug.cgi?id=167404
1687 Reviewed by Enrica Casucci.
1689 Adds pasteboard name as an argument to pasteboard-related WebPlatformStrategy methods.
1691 * WebCoreSupport/WebPlatformStrategies.h:
1692 * WebCoreSupport/WebPlatformStrategies.mm:
1693 (WebPlatformStrategies::writeToPasteboard):
1694 (WebPlatformStrategies::getPasteboardItemsCount):
1695 (WebPlatformStrategies::readBufferFromPasteboard):
1696 (WebPlatformStrategies::readURLFromPasteboard):
1697 (WebPlatformStrategies::readStringFromPasteboard):
1699 2017-01-25 Aakash Jain <aakash_jain@apple.com>
1701 LoadWebLocalizedStrings method should be moved in correct file
1702 https://bugs.webkit.org/show_bug.cgi?id=167393
1704 Reviewed by Alexey Proskuryakov.
1706 * Misc/WebLocalizableStrings.h: Deleted LoadWebLocalizedStrings method.
1707 * Misc/WebLocalizableStrings.mm:
1708 (LoadWebLocalizedStringsTimerCallback): Deleted, moved to WebUIKitSupport.mm
1709 (LoadWebLocalizedStrings): Deleted, moved to WebUIKitSupport.mm
1711 2017-01-24 Zalan Bujtas <zalan@apple.com>
1713 Add simple line layout toggle to MiniBrowser
1714 https://bugs.webkit.org/show_bug.cgi?id=167405
1716 Reviewed by Andreas Kling.
1718 * WebView/WebPreferenceKeysPrivate.h:
1719 * WebView/WebPreferences.mm:
1720 (+[WebPreferences initialize]):
1721 (-[WebPreferences simpleLineLayoutEnabled]):
1722 (-[WebPreferences setSimpleLineLayoutEnabled:]):
1723 * WebView/WebPreferencesPrivate.h:
1724 * WebView/WebView.mm:
1725 (-[WebView _preferencesChanged:]):
1727 2017-01-24 Joseph Pecoraro <pecoraro@apple.com>
1729 Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1730 https://bugs.webkit.org/show_bug.cgi?id=167394
1732 Reviewed by Ryosuke Niwa.
1734 * Configurations/FeatureDefines.xcconfig:
1736 2017-01-23 Chris Dumez <cdumez@apple.com>
1738 REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
1739 https://bugs.webkit.org/show_bug.cgi?id=167308
1740 <rdar://problem/30144964>
1742 Unreviewed, do a partial revert of r211033 to fix assertion.
1744 * WebCoreSupport/WebChromeClient.h:
1745 * WebCoreSupport/WebChromeClient.mm:
1746 (WebChromeClient::exitFullScreenForElement):
1748 2017-01-23 Joseph Pecoraro <pecoraro@apple.com>
1750 Remove allowWindowOpenWithoutUserGesture setting
1751 https://bugs.webkit.org/show_bug.cgi?id=167301
1753 Reviewed by Darin Adler.
1755 * WebView/WebView.mm:
1756 (-[WebView _preferencesChanged:]):
1757 Use the equivalent existing setting.
1759 2017-01-20 Darin Adler <darin@apple.com>
1761 Remove PassRefPtr from "page" directory of WebCore, also deploy references
1762 https://bugs.webkit.org/show_bug.cgi?id=167224
1764 Reviewed by Chris Dumez.
1766 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1767 (-[WebApplicationCacheQuotaManager quota]): Pass reference.
1769 * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1770 * WebCoreSupport/WebChromeClient.mm:
1771 (WebChromeClient::focusedElementChanged): Ditto.
1772 (WebChromeClient::createWindow): Ditto.
1773 (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
1774 (WebChromeClient::runJavaScriptAlert): Ditto.
1775 (WebChromeClient::runJavaScriptConfirm): Ditto.
1776 (WebChromeClient::runJavaScriptPrompt): Ditto.
1777 (WebChromeClient::contentsSizeChanged): Ditto.
1778 (WebChromeClient::unavailablePluginButtonClicked): Ditto.
1779 (WebChromeClient::print): Ditto.
1780 (WebChromeClient::exceededDatabaseQuota): Ditto.
1781 (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
1782 (WebChromeClient::createColorChooser): Ditto.
1783 (WebChromeClient::elementDidFocus): Ditto.
1784 (WebChromeClient::elementDidBlur): Ditto.
1785 (WebChromeClient::createPopupMenu): Ditto.
1786 (WebChromeClient::createSearchPopupMenu): Ditto.
1787 (WebChromeClient::attachRootGraphicsLayer): Ditto.
1788 (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
1789 (WebChromeClient::supportsFullScreenForElement): Ditto.
1790 (WebChromeClient::enterFullScreenForElement): Ditto.
1791 (WebChromeClient::exitFullScreenForElement): Ditto.
1793 * WebView/WebFrame.mm:
1794 (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1795 Updated for change to the appendChild function.
1797 2017-01-21 Simon Fraser <simon.fraser@apple.com>
1799 Remove -[WebFrame sendOrientationChangeEvent:] which is unused
1800 https://bugs.webkit.org/show_bug.cgi?id=167276
1802 Reviewed by Alex Christensen.
1804 It was usurped by -deviceOrientationChanged in 2014.
1806 * WebView/WebFrame.mm:
1807 (-[WebFrame sendOrientationChangeEvent:]): Deleted.
1808 * WebView/WebFramePrivate.h:
1810 2017-01-21 Simon Fraser <simon.fraser@apple.com>
1812 Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
1813 https://bugs.webkit.org/show_bug.cgi?id=167271
1815 Reviewed by Alex Christensen.
1817 -_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
1818 overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),
1820 * WebView/WebView.mm:
1821 (-[WebView _contentsSizeRespectingOverflow]): Deleted.
1822 * WebView/WebViewPrivate.h:
1824 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
1826 Remove never changing IndexedDB RuntimeEnabledFeature
1827 https://bugs.webkit.org/show_bug.cgi?id=167278
1829 Reviewed by Darin Adler.
1831 * WebView/WebView.mm:
1832 (-[WebView _preferencesChanged:]):
1834 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
1836 Cleanup RuntimeEnabledFeatures
1837 https://bugs.webkit.org/show_bug.cgi?id=167228
1839 Reviewed by Simon Fraser.
1841 * WebView/WebView.mm:
1842 (-[WebView _preferencesChanged:]):
1844 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
1846 Remove outdated ENABLE(CSP_NEXT) build flag
1847 https://bugs.webkit.org/show_bug.cgi?id=167252
1849 Reviewed by Brent Fulgham.
1851 * Configurations/FeatureDefines.xcconfig:
1853 2017-01-20 Antoine Quint <graouts@apple.com>
1855 [Modern Media Controls] Turn modern media controls on by default
1856 https://bugs.webkit.org/show_bug.cgi?id=165668
1858 Reviewed by Dean Jackson.
1860 Enabled modern media controls by default in WK1.
1862 * WebView/WebPreferences.mm:
1863 (+[WebPreferences initialize]):
1865 2017-01-19 Chris Dumez <cdumez@apple.com>
1867 iterable<> should be enabled on WK1
1868 https://bugs.webkit.org/show_bug.cgi?id=167221
1869 <rdar://problem/30108531>
1871 Reviewed by Youenn Fablet.
1873 * WebView/WebPreferenceKeysPrivate.h:
1874 * WebView/WebPreferences.mm:
1875 (-[WebPreferences setCustomElementsEnabled:]):
1876 (-[WebPreferences DOMIteratorEnabled]): Deleted.
1877 (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
1878 * WebView/WebPreferencesPrivate.h:
1879 * WebView/WebView.mm:
1880 (-[WebView _preferencesChanged:]):
1882 2017-01-19 Chris Dumez <cdumez@apple.com>
1884 Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
1885 https://bugs.webkit.org/show_bug.cgi?id=167215
1886 <rdar://problem/29885052>
1888 Reviewed by Andreas Kling.
1890 Make sure HTML validation bubble gets dismissed when its associated
1891 element's frame gets detached and that we do not crash.
1893 * WebCoreSupport/WebValidationMessageClient.h:
1894 * WebCoreSupport/WebValidationMessageClient.mm:
1895 (WebValidationMessageClient::documentDetached):
1897 2017-01-19 Myles C. Maxfield <mmaxfield@apple.com>
1899 [Cocoa] Variation fonts are erroneously disabled on iOS
1900 https://bugs.webkit.org/show_bug.cgi?id=167172
1902 Reviewed by Simon Fraser.
1904 OpenSource builders don't seem to understand sdk=embedded*.
1906 * Configurations/FeatureDefines.xcconfig:
1908 2017-01-19 Andreas Kling <akling@apple.com>
1910 ScriptExecutionContext::topOrigin() should return a reference.
1911 <https://webkit.org/b/167190>
1913 Reviewed by Sam Weinig.
1916 (+[WebCache addImageToCache:forURL:forFrame:]):
1917 (+[WebCache removeImageFromCacheForURL:forFrame:]):
1919 2017-01-18 Ryan Haddad <ryanhaddad@apple.com>
1921 Unreviewed fix for the macOS build.
1923 * Carbon/CarbonWindowAdapter.mm:
1924 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1926 2017-01-18 Ryan Haddad <ryanhaddad@apple.com>
1928 Unreviewed, rolling out r210848.
1930 This change introduced media-related LayoutTest failures and
1935 "[Modern Media Controls] Turn modern media controls on by
1937 https://bugs.webkit.org/show_bug.cgi?id=165668
1938 http://trac.webkit.org/changeset/210848
1940 2017-01-18 Andreas Kling <akling@apple.com>
1942 Document::securityOrigin() should return a reference.
1943 <https://webkit.org/b/167124>
1945 Reviewed by Sam Weinig.
1947 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1948 (WebKit::NetscapePluginInstanceProxy::loadRequest):
1949 * Plugins/WebNetscapePluginStream.mm:
1950 (WebNetscapePluginStream::WebNetscapePluginStream):
1951 * Plugins/WebNetscapePluginView.mm:
1952 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1953 * Plugins/WebPluginContainerCheck.mm:
1954 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1955 * WebCoreSupport/WebChromeClient.mm:
1956 (WebChromeClient::exceededDatabaseQuota):
1957 * WebCoreSupport/WebFrameLoaderClient.h:
1958 * WebCoreSupport/WebFrameLoaderClient.mm:
1959 (WebFrameLoaderClient::didRunInsecureContent):
1960 * WebCoreSupport/WebGeolocationClient.mm:
1961 (WebGeolocationClient::requestPermission):
1962 (-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
1963 * WebView/WebFrame.mm:
1964 (-[WebFrame _allowsFollowingLink:]):
1966 2017-01-18 Antoine Quint <graouts@apple.com>
1968 [Modern Media Controls] Turn modern media controls on by default
1969 https://bugs.webkit.org/show_bug.cgi?id=165668
1971 Reviewed by Dean Jackson.
1973 Enabled modern media controls by default in WK1.
1975 * WebView/WebPreferences.mm:
1976 (+[WebPreferences initialize]):
1978 2017-01-15 Darin Adler <darin@apple.com>
1980 Remove PassRefPtr from "loader" directory of WebCore
1981 https://bugs.webkit.org/show_bug.cgi?id=167055
1983 Reviewed by Alex Christensen.
1985 * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
1986 Also made class final and most functions private and final.
1987 * WebCoreSupport/WebChromeClient.mm:
1988 (WebChromeClient::runOpenPanel): Updated to take references.
1990 * WebCoreSupport/WebEditorClient.h: Updated for changes to EditorClient.
1991 * WebCoreSupport/WebEditorClient.mm:
1992 (-[WebUndoStep initWithUndoStep:]): Take reference instead of PassRefPtr.
1993 (+[WebUndoStep stepWithUndoStep:]): Ditto.
1994 (-[WebUndoStep step]): Return reference instead of pointer.
1995 (-[WebEditorUndoTarget undoEditing:]): Updated for the above.
1996 (-[WebEditorUndoTarget redoEditing:]): Ditto.
1997 (WebEditorClient::registerUndoOrRedoStep): Take reference instead of
1999 (WebEditorClient::registerUndoStep): Ditto.
2000 (WebEditorClient::registerRedoStep): Ditto.
2002 * WebCoreSupport/WebFrameLoaderClient.h: Updated for changes to
2003 FrameLoaderClient, marked functions final instead of override.
2004 * WebCoreSupport/WebFrameLoaderClient.mm:
2005 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Take
2006 pointer instead of PassRefPtr.
2007 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
2008 (makeFormFieldValuesDictionary): Take a reference.
2009 (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Take Ref&& instead
2011 (WebFrameLoaderClient::dispatchWillSubmitForm): Take a reference instead
2013 (WebFrameLoaderClient::actionDictionary): Take a pointer instead of PassRePtr.
2014 (WebFrameLoaderClient::createFrame): Take a reference instead of a pointer.
2015 (WebFrameLoaderClient::createPlugin): Ditto.
2016 (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
2017 (WebFrameLoaderClient::createNetworkingContext): Ditto.
2018 (WebFrameLoaderClient::didCreateQuickLookHandle): Pass a reference.
2020 * WebCoreSupport/WebFrameNetworkingContext.h: Use Ref instead of PassRefPtr.
2021 * WebCoreSupport/WebFrameNetworkingContext.mm: Tweak style a bit.
2023 * WebCoreSupport/WebOpenPanelResultListener.h: Take a reference instead of
2024 PassRefPtr. Use RefPtr for class field.
2025 * WebCoreSupport/WebOpenPanelResultListener.mm:
2026 (-[WebOpenPanelResultListener dealloc]): Deleted. Compiler will now do it
2027 correctly without us declaring anything explicitly.
2028 (-[WebOpenPanelResultListener cancel]): Get rid of hand-written deref code,
2029 and let RefPtr do the work.
2030 (-[WebOpenPanelResultListener chooseFilename:]): Ditto.
2031 (-[WebOpenPanelResultListener chooseFilenames:]): Ditto.
2032 (-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
2033 Rewrote to use a modern Objective-C for loop, reserveInitialCapacity,
2034 and uncheckedAppend.
2036 * WebView/WebArchive.mm:
2037 (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2038 Updated for changes to LegacyWebArchive.
2039 (-[WebArchive mainResource]): Ditto.
2040 (-[WebArchive subresources]): Ditto.
2041 (-[WebArchive subframeArchives]): Ditto.
2043 * WebView/WebDataSource.mm:
2044 (-[WebDataSource _addSubframeArchives:]): Use a modern Objective-C for loop
2045 instead of NSEnumerator.
2046 (-[WebDataSource _fileWrapperForURL:]): Use auto.
2047 (-[WebDataSource _documentFragmentWithArchive:]): Pass a reference.
2048 (-[WebDataSource mainResource]): Ditto.
2049 (-[WebDataSource subresources]): Ditto.
2050 (-[WebDataSource subresourceForURL:]): Ditto.
2051 (-[WebDataSource addSubresource:]): Ditto.
2053 * WebView/WebResource.mm:
2054 (-[WebResourcePrivate initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
2055 (-[WebResourcePrivate dealloc]): Remove explicit deref since RefPtr will now take
2057 (-[WebResource initWithCoder:]): Pass a reference.
2058 (-[WebResource encodeWithCoder:]): Updated since coreResource is now RefPtr.
2059 (-[WebResource _initWithCoreResource:]): Take Ref&& instead of PassRefPtr.
2060 (-[WebResource _coreResource]): Return reference rather than pointer.
2061 (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2062 Added code to handle the null case and pass a reference rather than a pointer.
2063 * WebView/WebResourceInternal.h: Updated for the above.
2065 2017-01-17 Michael Catanzaro <mcatanzaro@igalia.com>
2067 Unreviewed, rolling out r210834
2068 https://bugs.webkit.org/show_bug.cgi?id=165668
2070 It introduced dozens of test timeouts.
2073 "[Modern Media Controls] Turn modern media controls on by default"
2074 https://bugs.webkit.org/show_bug.cgi?id=165668
2075 http://trac.webkit.org/changeset/210834
2077 2017-01-17 Antoine Quint <graouts@apple.com>
2079 [Modern Media Controls] Turn modern media controls on by default
2080 https://bugs.webkit.org/show_bug.cgi?id=165668
2082 Reviewed by Dean Jackson.
2084 Enabled modern media controls by default in WK1.
2086 * WebView/WebPreferences.mm:
2087 (+[WebPreferences initialize]):
2089 2017-01-17 Joseph Pecoraro <pecoraro@apple.com>
2091 ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2092 https://bugs.webkit.org/show_bug.cgi?id=116551
2093 <rdar://problem/13949830>
2095 Reviewed by Alex Christensen.
2097 * Configurations/FeatureDefines.xcconfig:
2099 2017-01-17 Joseph Pecoraro <pecoraro@apple.com>
2101 Crash when closing tab with debugger paused
2102 https://bugs.webkit.org/show_bug.cgi?id=161746
2103 <rdar://problem/15607819>
2105 Reviewed by Brian Burg and Brent Fulgham.
2107 * WebView/WebView.mm:
2108 (WebKit::DeferredPageDestructor::createDeferredPageDestructor):
2109 (WebKit::DeferredPageDestructor::DeferredPageDestructor):
2110 (WebKit::DeferredPageDestructor::tryDestruction):
2111 (-[WebView _close]):
2112 Defer destruction of the Page if we are in a nested runloop.
2114 2017-01-16 Joseph Pecoraro <pecoraro@apple.com>
2116 Remove the REQUEST_ANIMATION_FRAME flag
2117 https://bugs.webkit.org/show_bug.cgi?id=156980
2118 <rdar://problem/25906849>
2120 Reviewed by Simon Fraser.
2122 * Configurations/FeatureDefines.xcconfig:
2124 2017-01-16 Andy Estes <aestes@apple.com>
2126 [QuickLook] Do some cleanup in QuickLookHandle
2127 https://bugs.webkit.org/show_bug.cgi?id=166864
2129 Reviewed by Darin Adler.
2131 * WebCoreSupport/WebFrameLoaderClient.mm:
2132 (WebFrameLoaderClient::didCreateQuickLookHandle): Changed to pass a
2133 Ref<QuickLookHandleClient>&& to QuickLookHandle::setClient().
2135 2017-01-15 Tim Horton <timothy_horton@apple.com>
2137 De-duplicate more (nearly) identical code in Editor(Mac|IOS).mm
2138 https://bugs.webkit.org/show_bug.cgi?id=167063
2140 Reviewed by Dan Bernstein.
2142 * WebView/WebHTMLView.mm:
2143 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2144 (-[WebHTMLView _updateFontPanel]):
2145 * WebView/WebView.mm:
2146 (-[WebView typingAttributes]):
2147 Adjust to fontAttributesForSelectionStart returning a RetainPtr.
2149 2017-01-13 Joseph Pecoraro <pecoraro@apple.com>
2151 Remove ENABLE(DETAILS_ELEMENT) guards
2152 https://bugs.webkit.org/show_bug.cgi?id=167042
2154 Reviewed by Alex Christensen.
2156 * Configurations/FeatureDefines.xcconfig:
2158 2017-01-11 Darin Adler <darin@apple.com>
2160 Remove PassRefPtr from more of "platform"
2161 https://bugs.webkit.org/show_bug.cgi?id=166809
2163 Reviewed by Sam Weinig.
2165 * WebCoreSupport/WebFrameLoaderClient.mm:
2166 (NetscapePluginWidget::handleEvent): Pass a reference.
2167 * WebView/WebView.mm:
2168 (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
2169 Updated since the children set now contains Ref instead of RefPtr.
2171 2017-01-13 Sam Weinig <sam@webkit.org>
2173 [WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
2174 https://bugs.webkit.org/show_bug.cgi?id=167006
2176 Reviewed by Geoffrey Garen.
2178 * WebView/WebDeviceOrientation.mm:
2180 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2181 Update for new use of std::optional.
2183 2017-01-12 Joseph Pecoraro <pecoraro@apple.com>
2185 Remove unnecessary includes of Page.h
2186 https://bugs.webkit.org/show_bug.cgi?id=166996
2188 Reviewed by Yusuke Suzuki.
2191 * History/WebBackForwardList.mm:
2192 * Plugins/WebPluginController.mm:
2193 * WebCoreSupport/WebNotificationClient.mm:
2194 * WebCoreSupport/WebPlatformStrategies.mm:
2195 * WebCoreSupport/WebUserMediaClient.mm:
2196 * WebView/WebFullScreenController.mm:
2198 2017-01-12 Chris Dumez <cdumez@apple.com>
2200 Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2201 https://bugs.webkit.org/show_bug.cgi?id=166995
2203 Reviewed by Jer Noble.
2205 Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2206 as some people are having trouble building without it.
2208 * Configurations/FeatureDefines.xcconfig:
2210 2017-01-12 Chris Dumez <cdumez@apple.com>
2212 HTML form validation popover sometimes does not go away
2213 https://bugs.webkit.org/show_bug.cgi?id=166990
2214 <rdar://problem/29985957>
2216 Reviewed by Tim Horton.
2218 Update code using ValidationBubble now that it is RefCounted.
2220 * WebView/WebView.mm:
2221 (-[WebView showFormValidationMessage:withAnchorRect:]):
2223 2017-01-10 Ryosuke Niwa <rniwa@webkit.org>
2225 Remove pointerLockElement from DOMDocumentPrivate.h
2226 https://bugs.webkit.org/show_bug.cgi?id=166882
2228 Reviewed by Simon Fraser.
2230 Removed pointerLockElement declaration that was supposed to be removed in r209637.
2232 * DOM/DOMDocumentPrivate.h:
2234 2017-01-06 Darin Adler <darin@apple.com>
2236 Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
2237 https://bugs.webkit.org/show_bug.cgi?id=166797
2239 Reviewed by Alex Christensen.
2241 * WebCoreSupport/WebEditorClient.h: Updated to take a reference.
2242 * WebCoreSupport/WebEditorClient.mm:
2243 (WebEditorClient::requestCheckingOfString): Take a reference
2244 instead of a PassRefPtr.
2246 2017-01-05 Chris Dumez <cdumez@apple.com>
2248 Turn preferLowPowerWebGLRendering setting on by default
2249 https://bugs.webkit.org/show_bug.cgi?id=166737
2250 <rdar://problem/29870033>
2252 Reviewed by Dean Jackson.
2254 Temporarily turn preferLowPowerWebGLRendering setting on by default until
2255 we deal better with WebGL content in background tabs.
2257 * WebView/WebPreferences.mm:
2258 (+[WebPreferences initialize]):
2260 2017-01-05 Enrica Casucci <enrica@apple.com>
2262 Support File Promise during drag for macOS.
2263 https://bugs.webkit.org/show_bug.cgi?id=165204
2264 rdar://problem/19595567
2266 Reviewed by Tim Horton.
2268 Adds support for dropping a File Promise in a WebView.
2269 The implementation uses new File Promise API available in Sierra.
2271 * Misc/WebNSPasteboardExtras.mm:
2272 (+[NSPasteboard _web_dragTypesForURL]):
2273 * WebView/WebView.mm:
2274 (-[WebView performDragOperation:]):
2276 2017-01-05 Andreas Kling <akling@apple.com>
2278 Remove ChromeClient::needTouchEvents().
2279 <https://webkit.org/b/166723>
2281 Rubber-stamped by Antti Koivisto.
2283 * WebCoreSupport/WebChromeClient.h:
2285 2017-01-04 Darin Adler <darin@apple.com>
2287 Remove PassRefPtr use from the "html" directory, other improvements
2288 https://bugs.webkit.org/show_bug.cgi?id=166635
2290 Reviewed by Alex Christensen.
2292 * WebCoreSupport/WebChromeClient.h:
2293 * WebCoreSupport/WebChromeClient.mm:
2294 (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
2296 2017-01-04 Ryan Haddad <ryanhaddad@apple.com>
2298 Unreviewed, rolling out r210287.
2300 This change caused editing test failures on macOS.
2304 "Support File Promise during drag for macOS."
2305 https://bugs.webkit.org/show_bug.cgi?id=165204
2306 http://trac.webkit.org/changeset/210287
2308 2017-01-04 Enrica Casucci <enrica@apple.com>
2310 Support File Promise during drag for macOS.
2311 https://bugs.webkit.org/show_bug.cgi?id=165204
2312 rdar://problem/19595567
2314 Reviewed by Tim Horton.
2316 Adds support for dropping a File Promise in a WebView.
2317 The implementation uses new File Promise API available in Sierra.
2319 * Misc/WebNSPasteboardExtras.mm:
2320 (+[NSPasteboard _web_dragTypesForURL]):
2321 * WebView/WebView.mm:
2322 (-[WebView performDragOperation:]):
2324 2017-01-04 Tim Horton <timothy_horton@apple.com>
2326 Provide a setting for clients to always prefer low-power WebGL
2327 https://bugs.webkit.org/show_bug.cgi?id=166675
2328 <rdar://problem/29834093>
2330 Reviewed by Dan Bernstein.
2332 * WebView/WebPreferenceKeysPrivate.h:
2333 * WebView/WebPreferences.mm:
2334 (+[WebPreferences initialize]):
2335 (-[WebPreferences preferLowPowerWebGLRendering]):
2336 (-[WebPreferences setPreferLowPowerWebGLRendering:]):
2337 * WebView/WebPreferencesPrivate.h:
2338 * WebView/WebView.mm:
2339 (-[WebView _preferencesChanged:]):
2340 Expose a new private preferLowPowerWebGLRendering WebKit1 preference.
2342 2017-01-03 Tim Horton <timothy_horton@apple.com>
2344 NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2345 https://bugs.webkit.org/show_bug.cgi?id=166450
2346 <rdar://problem/29447824>
2348 Reviewed by Darin Adler.
2350 * WebCoreSupport/CorrectionPanel.h:
2351 * WebCoreSupport/CorrectionPanel.mm:
2352 (CorrectionPanel::recordAutocorrectionResponse):
2353 (CorrectionPanel::handleAcceptedReplacement):
2354 * WebCoreSupport/WebAlternativeTextClient.mm:
2355 (toCorrectionResponse):
2356 (WebAlternativeTextClient::recordAutocorrectionResponse):
2357 Funnel all calls to recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2358 through recordAutocorrectionResponse, for debugging's sake.
2359 Drop the NSView parameter because we don't need it, just the tag.
2360 Convert the new AutocorrectionResponseType value to its corresponding
2361 NSCorrectionResponse value.
2363 2017-01-01 Jeff Miller <jeffm@apple.com>
2365 Update user-visible copyright strings to include 2017
2366 https://bugs.webkit.org/show_bug.cgi?id=166278
2368 Reviewed by Dan Bernstein.
2372 2016-12-30 Darin Adler <darin@apple.com>
2374 Remove PassRefPtr use from the "dom" directory, related cleanup
2375 https://bugs.webkit.org/show_bug.cgi?id=166569
2377 Reviewed by Alex Christensen.
2379 * WebCoreSupport/WebFrameLoaderClient.mm:
2380 (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated to use struct.
2381 (WebFrameLoaderClient::updateGlobalHistory): Ditto.
2382 (WebFrameLoaderClient::setTitle): Ditto.
2383 (WebFrameLoaderClient::transitionToCommittedForNewPage): Ditto.
2384 * WebView/WebFrame.mm:
2385 (-[WebFrame _dispatchDidReceiveTitle:]): Use aggregate-style syntax for StringWithDirection.
2386 Not needed now, but useful later if we ever can get rid of the explicit constructors.
2387 (-[WebFrame loadArchive:]): Pass a reference to loadArchive.
2388 * WebView/WebHTMLRepresentation.mm:
2389 (-[WebHTMLRepresentation title]): Updated to use struct.
2391 2016-12-25 Yusuke Suzuki <utatane.tea@gmail.com>
2393 Propagate the source origin as much as possible
2394 https://bugs.webkit.org/show_bug.cgi?id=166348
2396 Reviewed by Darin Adler.
2398 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2399 (WebKit::NetscapePluginInstanceProxy::evaluate):
2401 2016-12-23 Andy Estes <aestes@apple.com>
2403 [iOS] DumpRenderTree triggers an assertion failure when calling +[WebPreferences _switchNetworkLoaderToNewTestingSession]
2404 https://bugs.webkit.org/show_bug.cgi?id=166471
2406 Reviewed by Andreas Kling.
2408 When DumpRenderTree starts up, it calls
2409 +[WebPreferences _switchNetworkLoaderToNewTestingSession] from the main thread. In Debug
2410 builds, this triggers the ASSERT(isMainThread()) in
2411 NetworkStorageSession::defaultNetworkStorageSession() because the Web thread has already
2412 started, we are on the main thread, and we are not holding the Web thread lock. This is
2413 causing all layout tests to crash in the iOS WK1 Debug configuration.
2415 * WebView/WebPreferences.mm: (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2416 Take the Web thread lock before calling NetworkStorageSession::switchToNewTestingSession().
2418 2016-12-22 Andy Estes <aestes@apple.com>
2420 Make WebCore::EditorInsertAction an enum class
2421 https://bugs.webkit.org/show_bug.cgi?id=166424
2423 Reviewed by Brent Fulgham.
2425 * WebCoreSupport/WebEditorClient.mm:
2428 2016-12-21 Beth Dakin <bdakin@apple.com>
2430 Holding down on candidates in the TouchBar should show panel on screen
2431 https://bugs.webkit.org/show_bug.cgi?id=166367
2433 <rdar://problem/28479236>
2435 Reviewed by Tim Horton.
2438 * WebCoreSupport/WebEditorClient.mm:
2439 (WebEditorClient::handleRequestedCandidates):
2441 Call the version of setCandidates: that takes a rect. We need to keep the helper
2442 function in WK1 (unlike WK2) since we also use it for testing.
2443 * WebView/WebView.mm:
2444 (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
2446 2016-12-20 Dean Jackson <dino@apple.com>
2449 https://bugs.webkit.org/show_bug.cgi?id=165881
2450 <rdar://problem/29672532>
2452 Reviewed by Simon Fraser.
2454 The Indie UI work has been discontinued.
2456 * Configurations/FeatureDefines.xcconfig:
2458 2016-12-19 Yusuke Suzuki <utatane.tea@gmail.com>
2460 [ES6] Enable ES6 Modules
2461 https://bugs.webkit.org/show_bug.cgi?id=165849
2463 Reviewed by Geoffrey Garen.
2465 * WebView/WebPreferenceKeysPrivate.h:
2466 * WebView/WebPreferences.mm:
2467 (+[WebPreferences initialize]):
2468 (-[WebPreferences es6ModulesEnabled]): Deleted.
2469 (-[WebPreferences setES6ModulesEnabled:]): Deleted.
2470 * WebView/WebPreferencesPrivate.h:
2471 * WebView/WebView.mm:
2472 (-[WebView _preferencesChanged:]):
2474 2016-12-16 Dave Hyatt <hyatt@apple.com>
2476 [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
2477 https://bugs.webkit.org/show_bug.cgi?id=165968
2479 Reviewed by Andreas Kling.
2483 * DOM/DOMCSSPrimitiveValue.mm:
2484 (-[DOMCSSPrimitiveValue getCounterValue]):
2485 (-[DOMCSSPrimitiveValue getRectValue]):
2487 * DOM/DOMCSSPrimitiveValueInternal.h:
2488 * DOM/DOMCSSStyleDeclaration.mm:
2489 * DOM/DOMCSSValue.mm:
2491 * DOM/DOMCSSValueInternal.h:
2492 * DOM/DOMCSSValueList.mm:
2493 * DOM/DOMCounter.mm:
2495 * DOM/DOMCounterInternal.h:
2496 * DOM/DOMRGBColor.mm:
2498 * DOM/DOMRGBColorInternal.h:
2501 * DOM/DOMRectInternal.h:
2502 * DOM/DOMUtility.mm:
2505 2016-12-16 Chris Dumez <cdumez@apple.com>
2507 HTML form validation bubble should be dismissed on navigation
2508 https://bugs.webkit.org/show_bug.cgi?id=165960
2509 <rdar://problem/29668086>
2511 Reviewed by Simon Fraser.
2513 Dismiss HTML form validation bubble on top-level navigation on Mac WK1.
2515 * WebView/WebView.mm:
2516 (-[WebView _didStartProvisionalLoadForFrame:]):
2518 2016-12-15 Darin Adler <darin@apple.com>
2520 Use asString instead of toWTFString, toString, or getString when we already checked isString
2521 https://bugs.webkit.org/show_bug.cgi?id=165895
2523 Reviewed by Yusuke Suzuki.
2525 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2526 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
2528 * WebView/WebView.mm:
2529 (aeDescFromJSValue): Use asString/value instead of getString.
2531 2016-12-15 Chris Dumez <cdumez@apple.com>
2533 Make sure HTML validation bubble's state is updated after layout
2534 https://bugs.webkit.org/show_bug.cgi?id=165922
2535 <rdar://problem/29694730>
2537 Reviewed by Simon Fraser.
2539 Make sure HTML validation bubble's state is updated after layout.
2540 In particular, if the validation bubble's associated element has
2541 moved or is no longer visible, we now hide the bubble.
2543 * WebCoreSupport/WebValidationMessageClient.h:
2544 * WebCoreSupport/WebValidationMessageClient.mm:
2545 (WebValidationMessageClient::showValidationMessage):
2546 (WebValidationMessageClient::hideValidationMessage):
2547 (WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
2549 2016-12-15 Chris Dumez <cdumez@apple.com>
2551 Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
2552 https://bugs.webkit.org/show_bug.cgi?id=165904
2554 Reviewed by Sam Weinig.
2556 Update ObjC bindings so they keep building.
2558 * DOM/DOMUIEvent.mm:
2559 (-[DOMUIEvent keyCode]):
2560 (-[DOMUIEvent charCode]):
2562 2016-12-15 Andreas Kling <akling@apple.com>
2564 Always clear RenderLayer backing stores when going into page cache.
2565 <https://webkit.org/b/165901>
2567 Reviewed by Simon Fraser.
2569 * WebView/WebView.mm:
2570 (+[WebView _setCacheModel:]):
2572 2016-12-12 Alex Christensen <achristensen@webkit.org>
2574 Remove unused workaround for Silverlight
2575 https://bugs.webkit.org/show_bug.cgi?id=165773
2577 Reviewed by Dean Jackson.
2579 * Plugins/WebNetscapePluginView.mm:
2580 (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): Deleted.
2581 This code was introduced in January 2010. Microsoft fixed their bug shortly thereafter.
2582 Allowing 6 years for users to update Silverlight is more than enough.
2583 Safari doesn't even use WebKit1 for this any more.
2584 I need this to be removed because this is the only non-WebGL code that needs to link against
2585 the OpenGL framework, and I'm changing how that is done to link only through ANGLE instead.
2587 2016-12-12 Chris Dumez <cdumez@apple.com>
2589 Document.visibilityState should use an IDL string enumeration
2590 https://bugs.webkit.org/show_bug.cgi?id=165774
2592 Reviewed by Daniel Bates.
2594 * DOM/DOMDocument.mm:
2595 (-[DOMDocument visibilityState]):
2596 * WebView/WebView.mm:
2599 2016-12-12 Jer Noble <jer.noble@apple.com>
2601 Remove implementation of legacy Mozilla-based Fullscreen API.
2602 https://bugs.webkit.org/show_bug.cgi?id=165689
2603 <rdar://problem/29603053>
2605 Reviewed by Eric Carlson.
2607 * DOM/DOMElement.mm:
2608 (-[DOMElement webkitRequestFullScreen:]):
2610 2016-12-10 Filip Pizlo <fpizlo@apple.com>
2612 The DOM should have an advancing wavefront opaque root barrier
2613 https://bugs.webkit.org/show_bug.cgi?id=165712
2615 Reviewed by Yusuke Suzuki.
2617 Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
2619 * Misc/WebCoreStatistics.mm:
2620 (+[WebCoreStatistics javaScriptObjectsCount]):
2621 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2622 (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2623 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2624 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2625 (+[WebCoreStatistics javaScriptObjectTypeCounts]):
2626 (+[WebCoreStatistics shouldPrintExceptions]):
2627 (+[WebCoreStatistics setShouldPrintExceptions:]):
2628 (+[WebCoreStatistics memoryStatistics]):
2629 (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2630 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2631 (identifierFromIdentifierRep):
2632 * Plugins/Hosted/ProxyInstance.mm:
2633 (WebKit::ProxyInstance::getPropertyNames):
2634 * Plugins/WebNetscapePluginStream.mm:
2635 (WebNetscapePluginStream::wantsAllStreams):
2636 * Plugins/WebNetscapePluginView.mm:
2637 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2638 (-[WebNetscapePluginView privateBrowsingModeDidChange]):
2639 (-[WebNetscapePluginView setWindowIfNecessary]):
2640 (-[WebNetscapePluginView createPluginScriptableObject]):
2641 (-[WebNetscapePluginView getFormValue:]):
2642 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
2643 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
2644 (-[WebNetscapePluginView loadPluginRequest:]):
2645 (-[WebNetscapePluginView _printedPluginBitmap]):
2646 * Plugins/WebPluginController.mm:
2647 (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2648 (-[WebPluginController stopOnePlugin:]):
2649 (-[WebPluginController stopOnePluginForPageCache:]):
2650 (-[WebPluginController destroyOnePlugin:]):
2651 (-[WebPluginController startAllPlugins]):
2652 (-[WebPluginController addPlugin:]):
2654 2016-12-09 Dave Hyatt <hyatt@apple.com>
2656 [CSS Parser] Remove the old CSS Parser
2657 https://bugs.webkit.org/show_bug.cgi?id=165645
2659 Reviewed by Daniel Bates.
2665 2016-12-09 Eric Carlson <eric.carlson@apple.com>
2667 Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2668 https://bugs.webkit.org/show_bug.cgi?id=165251
2670 Reviewed by Dean Jackson.
2672 Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
2674 * WebView/WebPreferenceKeysPrivate.h: Add MediaStream and PeerConnection preferences.
2675 * WebView/WebPreferences.mm:
2676 (+[WebPreferences initialize]):
2677 (-[WebPreferences mediaStreamEnabled]):
2678 (-[WebPreferences setMediaStreamEnabled:]):
2679 (-[WebPreferences peerConnectionEnabled]):
2680 (-[WebPreferences setPeerConnectionEnabled:]):
2681 * WebView/WebPreferencesPrivate.h:
2682 * WebView/WebView.mm:
2683 (-[WebView _preferencesChanged:]):
2685 2016-12-09 Ryosuke Niwa <rniwa@webkit.org>
2687 Don’t expose pointer lock in WebKit1 Objective-C API
2688 https://bugs.webkit.org/show_bug.cgi?id=165692
2690 Reviewed by Simon Fraser.
2692 * DOM/DOMDocument.mm:
2693 (-[DOMDocument pointerLockElement]): Deleted.
2694 (-[DOMDocument exitPointerLock]): Deleted.
2695 * DOM/DOMElement.mm:
2696 (-[DOMElement requestPointerLock]): Deleted.
2697 * DOM/DOMMouseEvent.mm:
2698 (-[DOMMouseEvent movementX]): Deleted.
2699 (-[DOMMouseEvent movementY]): Deleted.
2701 2016-12-09 Ryosuke Niwa <rniwa@webkit.org>
2703 document.webkitFullscreenElement leaks elements inside a shadow tree
2704 https://bugs.webkit.org/show_bug.cgi?id=158471
2706 Reviewed by Chris Dumez.
2708 Use the API for bindings to avoid exposing nodes inside a shadow tree.
2710 * DOM/DOMDocument.mm:
2711 (-[DOMDocument webkitCurrentFullScreenElement]):
2712 (-[DOMDocument webkitFullscreenElement]):
2714 2016-12-09 Beth Dakin <bdakin@apple.com>
2716 Password fields should not show the emoji button in TouchBar
2717 https://bugs.webkit.org/show_bug.cgi?id=165673
2719 rdar://problem/29235739
2721 Reviewed by Wenson Hsieh.
2723 This patch adds a new ivar for the password touch bar and password
2724 candidateListTouchBarItem. Since this TouchBar will actually have a different set
2725 of identifiers than the plain text TouchBar, it should just have its own variable.
2727 The candidate list should be the only item for passwords.
2728 * WebView/WebView.mm:
2729 (-[WebView _passwordTextTouchBarDefaultItemIdentifiers]):
2731 Account for _passwordTextTouchBar.
2732 (-[WebView didChangeAutomaticTextCompletion:]):
2733 (-[WebView setUpTextTouchBar:]):
2734 (-[WebView textTouchBar]):
2736 The empty candidates array is not needed. We can just set @[ ] as the candidates
2737 for the _passwordTextCandidateListTouchBarItem. Safe guards already exist in the
2738 other parts of the code to prevent us from requesting or setting other candidates
2739 when in a password field.
2740 (-[WebView updateTextTouchBar]):
2742 Account for _passwordTextTouchBar.
2743 (-[WebView candidateList]):
2744 * WebView/WebViewData.h:
2746 2016-12-08 Filip Pizlo <fpizlo@apple.com>
2748 Enable SharedArrayBuffer, remove the flag
2749 https://bugs.webkit.org/show_bug.cgi?id=165614
2751 Rubber stamped by Geoffrey Garen.
2753 * WebView/WebPreferencesPrivate.h:
2755 2016-12-07 Dean Jackson <dino@apple.com>
2757 Remove runtime toggle for pointer-lock
2758 https://bugs.webkit.org/show_bug.cgi?id=165577
2759 <rdar://problems/29566996>
2761 Reviewed by Jon Lee.
2763 Remove any runtime calls to check if pointer-lock is enabled. It's
2764 either compiled in or out.
2766 * WebView/WebPreferenceKeysPrivate.h:
2767 * WebView/WebPreferences.mm:
2768 (-[WebPreferences pointerLockEnabled]): Deleted.
2769 (-[WebPreferences setPointerLockEnabled:]): Deleted.
2770 * WebView/WebPreferencesPrivate.h:
2771 * WebView/WebView.mm:
2772 (-[WebView _preferencesChanged:]):
2774 2016-12-06 Alexey Proskuryakov <ap@apple.com>
2776 Correct SDKROOT values in xcconfig files
2777 https://bugs.webkit.org/show_bug.cgi?id=165487
2778 rdar://problem/29539209
2780 Reviewed by Dan Bernstein.
2782 Fix suggested by Dan Bernstein.
2784 * Configurations/DebugRelease.xcconfig:
2786 2016-12-05 Simon Fraser <simon.fraser@apple.com>
2788 Improve the behavior of scroll-into-view when the target is inside position:fixed
2789 https://bugs.webkit.org/show_bug.cgi?id=165354
2791 Reviewed by Zalan Bujtas.
2793 Plumb through 'insideFixed'. We don't get compute it, so behavior from
2794 these call sites won't change.
2796 * WebView/WebFrame.mm:
2797 (-[WebFrame _scrollDOMRangeToVisible:]):
2798 (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2800 2016-12-06 Simon Fraser <simon.fraser@apple.com>
2802 Enable visual viewports by default on Mac, and iOS Wk2
2803 https://bugs.webkit.org/show_bug.cgi?id=165452
2805 Reviewed by Zalan Bujtas.
2807 Turn visual viewports on by default for WK1 on Mac.
2809 * WebView/WebPreferences.mm:
2810 (+[WebPreferences initialize]):
2812 2016-12-05 Dean Jackson <dino@apple.com>
2814 pointer lock needs to be feature detectable
2815 https://bugs.webkit.org/show_bug.cgi?id=165426
2816 <rdar://problem/29486715>
2818 Reviewed by Antoine Quint.
2820 Set the RuntimeEnabledFeature as preferences
2823 * WebView/WebView.mm:
2824 (-[WebView _preferencesChanged:]):
2826 2016-12-05 Ryan Haddad <ryanhaddad@apple.com>
2828 Unreviewed, rolling out r209299.
2830 This change appears to have caused LayoutTest failures on
2835 "Improve the behavior of scroll-into-view when the target is
2836 inside position:fixed"
2837 https://bugs.webkit.org/show_bug.cgi?id=165354
2838 http://trac.webkit.org/changeset/209299
2840 2016-12-02 Simon Fraser <simon.fraser@apple.com>
2842 Improve the behavior of scroll-into-view when the target is inside position:fixed
2843 https://bugs.webkit.org/show_bug.cgi?id=165354
2845 Reviewed by Zalan Bujtas.
2847 Plumb through 'insideFixed'. We don't get compute it, so behavior from
2848 these call sites won't change.
2850 * WebView/WebFrame.mm:
2851 (-[WebFrame _scrollDOMRangeToVisible:]):
2852 (-[WebFrame _scrollDOMRangeToVisible:withInset:]):
2854 2016-12-02 Andy Estes <aestes@apple.com>
2856 [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
2857 https://bugs.webkit.org/show_bug.cgi?id=164492
2859 Reviewed by Dan Bernstein.
2861 * Configurations/WebKitLegacy.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
2862 com.apple.$(PRODUCT_NAME:rfc1034identifier).
2863 * Info.plist: Changed CFBundleIdentifier's value from com.apple.${PRODUCT_NAME} to
2864 ${PRODUCT_BUNDLE_IDENTIFIER}.
2866 2016-12-02 Chris Dumez <cdumez@apple.com>
2868 Regression(r209252): HTML interactive validation should not be enabled on iOS WK1 yet
2869 https://bugs.webkit.org/show_bug.cgi?id=165328
2871 Reviewed by Simon Fraser.
2873 Only enable HTML interactive form validation on Mac WK1, not iOS WK1.
2875 * WebView/WebViewData.mm:
2876 (-[WebViewPrivate init]):
2878 2016-12-02 Chris Dumez <cdumez@apple.com>
2880 [Mac][WK1] Implement new HTML interactive form validation user interface
2881 https://bugs.webkit.org/show_bug.cgi?id=164483
2883 Reviewed by Simon Fraser.
2885 Implement new HTML interactive form validation user interface on Mac
2886 WK1 and enable it by default.
2888 * WebCoreSupport/WebValidationMessageClient.h: Added.
2889 * WebCoreSupport/WebValidationMessageClient.mm: Added.
2890 (WebValidationMessageClient::WebValidationMessageClient):
2891 (WebValidationMessageClient::~WebValidationMessageClient):
2892 (WebValidationMessageClient::showValidationMessage):
2893 (WebValidationMessageClient::hideValidationMessage):
2894 (WebValidationMessageClient::isValidationMessageVisible):
2895 * WebView/WebHTMLView.mm:
2896 (-[WebHTMLView _frameOrBoundsChanged]):
2897 * WebView/WebView.mm:
2898 (-[WebView _commonInitializationWithFrameName:groupName:]):
2899 (-[WebView _willStartScrollingOrZooming]):
2900 (-[WebView _contentsOfUserInterfaceItem:]):
2901 (-[WebView _scaleWebView:atOrigin:]):
2902 (-[WebView _didScrollDocumentInFrameView:]):
2903 (-[WebView _setZoomMultiplier:isTextOnly:]):
2904 (-[WebView showFormValidationMessage:withAnchorRect:]):
2905 (-[WebView hideFormValidationMessage]):
2906 * WebView/WebViewData.h:
2907 * WebView/WebViewData.mm:
2908 (-[WebViewPrivate init]):
2909 * WebView/WebViewInternal.h:
2910 * WebView/WebViewPrivate.h:
2912 2016-12-01 Jiewen Tan <jiewen_tan@apple.com>
2914 Add a runtime flag for SubtleCrypto
2915 https://bugs.webkit.org/show_bug.cgi?id=164982
2917 Reviewed by Brent Fulgham.
2919 * WebView/WebPreferenceKeysPrivate.h:
2920 * WebView/WebPreferences.mm:
2921 (+[WebPreferences initialize]):
2922 (-[WebPreferences subtleCryptoEnabled]):
2923 (-[WebPreferences setSubtleCryptoEnabled:]):
2924 * WebView/WebPreferencesPrivate.h:
2925 * WebView/WebView.mm:
2926 (-[WebView _preferencesChanged:]):
2928 2016-11-30 Said Abou-Hallawa <sabouhallawa@apple.com>
2930 Add separate settings and preferences to enable/disable async decoding for large images and animated images
2931 https://bugs.webkit.org/show_bug.cgi?id=165177
2933 Reviewed by Simon Fraser.
2935 Hook up the async image decoding settings for WebKit1.
2937 * WebView/WebPreferenceKeysPrivate.h:
2938 * WebView/WebPreferences.mm:
2939 (+[WebPreferences initialize]):
2940 (-[WebPreferences largeImageAsyncDecodingEnabled]):
2941 (-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
2942 (-[WebPreferences animatedImageAsyncDecodingEnabled]):
2943 (-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
2944 (-[WebPreferences asyncImageDecodingEnabled]): Deleted.
2945 (-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.
2946 * WebView/WebPreferencesPrivate.h:
2947 * WebView/WebView.mm:
2948 (-[WebView _preferencesChanged:]):
2950 2016-11-29 Andy Estes <aestes@apple.com>
2952 [Cocoa] Enable two clang warnings recommended by Xcode
2953 https://bugs.webkit.org/show_bug.cgi?id=164498
2955 Reviewed by Mark Lam.
2957 * Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
2959 2016-11-26 Yusuke Suzuki <utatane.tea@gmail.com>
2961 [WTF] Import std::optional reference implementation as WTF::Optional
2962 https://bugs.webkit.org/show_bug.cgi?id=164199
2964 Reviewed by Saam Barati and Sam Weinig.
2966 Use WTF::Optional::value_or.
2968 * DOM/DOMHTMLOptionsCollection.mm:
2969 (-[DOMHTMLOptionsCollection add:index:]):
2970 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2971 (WebKit::NetscapePluginInstanceProxy::evaluate):
2972 * Plugins/WebNetscapePluginView.mm:
2973 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
2974 * WebCoreSupport/WebFrameLoaderClient.h:
2975 * WebCoreSupport/WebFrameLoaderClient.mm:
2976 (WebFrameLoaderClient::dispatchDidCommitLoad):
2977 * WebCoreSupport/WebPaymentCoordinatorClient.h:
2978 * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2979 (WebPaymentCoordinatorClient::completeShippingMethodSelection):
2980 (WebPaymentCoordinatorClient::completeShippingContactSelection):
2981 (WebPaymentCoordinatorClient::completePaymentMethodSelection):
2982 * WebCoreSupport/WebSecurityOrigin.mm:
2983 (-[WebSecurityOrigin port]):
2984 * WebView/WebHTMLView.mm:
2988 2016-11-26 Sam Weinig <sam@webkit.org>
2990 Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
2991 https://bugs.webkit.org/show_bug.cgi?id=164965
2993 Reviewed by Simon Fraser.
2995 * WebView/WebPreferenceKeysPrivate.h:
2996 * WebView/WebPreferences.mm:
2997 (-[WebPreferences intersectionObserverEnabled]):
2998 (-[WebPreferences setIntersectionObserverEnabled:]):
2999 * WebView/WebPreferencesPrivate.h:
3000 * WebView/WebView.mm:
3001 (-[WebView _preferencesChanged:]):
3002 Add a preference, defaulting to off, for enabling IntersectionObserver.
3004 2016-11-22 Dan Bernstein <mitz@apple.com>
3006 [Mac] In Legacy WebKit, pressing an arrow key in editable content doesn’t hide the mouse cursor
3007 https://bugs.webkit.org/show_bug.cgi?id=165036
3008 <rdar://problem/5708580>
3010 Reviewed by Alexey Proskuryakov.
3012 * WebView/WebHTMLView.mm:
3013 (-[WebHTMLView performKeyEquivalent:]): Hide the cursor if WebCore handled the event,
3014 similarly to what we do in -keyDown: and to what WKWebView does with all key events.
3016 2016-11-21 Alex Christensen <achristensen@webkit.org>
3018 Fix Sierra CMake build after r208452
3019 https://bugs.webkit.org/show_bug.cgi?id=164437
3021 * WebView/WebView.mm:
3022 (-[WebView updateMediaTouchBar]):
3023 I haven't enabled VIDEO_PRESENTATION_MODE in the CMake build yet.
3024 It's needed for playbackSessionInterface to exist.
3026 2016-11-18 Enrica Casucci <enrica@apple.com>
3028 Refactor drag and drop for WebKit2 to encode DragData message exchange.
3029 https://bugs.webkit.org/show_bug.cgi?id=164945
3031 Reviewed by Tim Horton.
3033 * WebCoreSupport/WebDragClient.h:
3034 * WebCoreSupport/WebDragClient.mm:
3035 (WebDragClient::actionMaskForDrag):
3036 (WebDragClient::willPerformDragDestinationAction):
3038 2016-11-18 Jeremy Jones <jeremyj@apple.com>
3040 Add runtime flag to enable pointer lock. Enable pointer lock feature for mac.
3041 https://bugs.webkit.org/show_bug.cgi?id=163801
3043 Reviewed by Simon Fraser.
3045 Plumb through PointerLockEnabled setting.
3047 * Configurations/FeatureDefines.xcconfig:
3048 * WebCoreSupport/WebChromeClient.mm:
3049 (WebChromeClient::requestPointerUnlock):
3050 * WebView/WebPreferenceKeysPrivate.h:
3051 * WebView/WebPreferences.mm:
3052 (-[WebPreferences pointerLockEnabled]):
3053 (-[WebPreferences setPointerLockEnabled:]):
3054 * WebView/WebPreferencesPrivate.h:
3055 * WebView/WebView.mm:
3056 (-[WebView _preferencesChanged:]):
3058 2016-11-17 Dan Bernstein <mitz@apple.com>
3060 Try to fix some non-macOS builds.
3062 * WebView/WebView.mm:
3064 2016-11-16 Dave Hyatt <hyatt@apple.com>
3066 [CSS Parser] Add @supports, @keyframe and media query parsing options
3067 https://bugs.webkit.org/show_bug.cgi?id=164821
3069 Reviewed by Sam Weinig and Zalan Bujtas.
3071 Fix up the create call now that fallback descriptor syntax is gone.
3074 (-[DOMHTMLLinkElement _mediaQueryMatches]):
3076 2016-11-17 Saam Barati <sbarati@apple.com>
3078 Remove async/await compile time flag and enable tests
3079 https://bugs.webkit.org/show_bug.cgi?id=164828
3080 <rdar://problem/28639334>
3082 Reviewed by Yusuke Suzuki.
3084 * Configurations/FeatureDefines.xcconfig:
3086 2016-11-17 Yusuke Suzuki <utatane.tea@gmail.com>
3088 [JSC] WTF::TemporaryChange with WTF::SetForScope
3089 https://bugs.webkit.org/show_bug.cgi?id=164761
3091 Reviewed by Saam Barati.
3093 * WebView/WebView.mm:
3094 (-[WebView updateTextTouchBar]):
3096 2016-11-16 Yusuke Suzuki <utatane.tea@gmail.com>
3098 [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3099 https://bugs.webkit.org/show_bug.cgi?id=164827
3101 Reviewed by Ryosuke Niwa.
3103 * Configurations/FeatureDefines.xcconfig:
3104 * WebView/WebPreferenceKeysPrivate.h:
3105 * WebView/WebPreferences.mm:
3106 (+[WebPreferences initialize]):
3107 (-[WebPreferences es6ModulesEnabled]):
3108 (-[WebPreferences setES6ModulesEnabled:]):
3109 * WebView/WebPreferencesPrivate.h:
3110 * WebView/WebView.mm:
3111 (-[WebView _preferencesChanged:]):
3113 2016-11-14 Alex Christensen <achristensen@webkit.org>
3115 Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
3116 https://bugs.webkit.org/show_bug.cgi?id=164720
3118 Reviewed by Brady Eidson.
3120 * Storage/WebDatabaseManager.mm:
3121 (-[WebDatabaseManager origins]):
3122 (-[WebDatabaseManager databasesWithOrigin:]):
3123 (-[WebDatabaseManager deleteOrigin:]):
3124 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3125 * Storage/WebDatabaseManagerClient.h:
3126 * Storage/WebDatabaseManagerClient.mm:
3127 (DidModifyOriginData::dispatchToMainThread):
3128 (DidModifyOriginData::DidModifyOriginData):
3129 (WebDatabaseManagerClient::dispatchDidModifyOrigin):
3130 (WebDatabaseManagerClient::dispatchDidModifyDatabase):
3131 * Storage/WebDatabaseQuotaManager.mm:
3132 (-[WebDatabaseQuotaManager usage]):
3133 (-[WebDatabaseQuotaManager quota]):
3134 (-[WebDatabaseQuotaManager setQuota:]):
3135 * Storage/WebStorageManager.mm:
3136 (-[WebStorageManager origins]):
3137 (-[WebStorageManager deleteOrigin:]):
3138 * Storage/WebStorageTrackerClient.h:
3139 * Storage/WebStorageTrackerClient.mm:
3140 (WebStorageTrackerClient::dispatchDidModifyOrigin):
3141 * WebCoreSupport/WebSecurityOrigin.mm:
3142 (-[WebSecurityOrigin usage]):
3143 (-[WebSecurityOrigin quota]):
3144 (-[WebSecurityOrigin setQuota:]):
3146 2016-11-13 Darin Adler <darin@apple.com>
3148 Fix exception handling in SQL database code, streamline and update code
3149 https://bugs.webkit.org/show_bug.cgi?id=164685
3151 Reviewed by Sam Weinig.
3153 * Storage/WebDatabaseManager.mm:
3154 (-[WebDatabaseManager origins]): Updated to use DatabaseTracker and pass
3156 (-[WebDatabaseManager databasesWithOrigin:]): Ditto.
3157 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Pass reference,
3158 but continue to use DatabaseManager.
3159 (-[WebDatabaseManager deleteOrigin:]): Use DatabaseTracker and pass a
3161 (-[WebDatabaseManager deleteDatabase:withOrigin:]): Ditto.
3163 * Storage/WebDatabaseManagerClient.h: Updated to take references.
3164 * Storage/WebDatabaseManagerClient.mm:
3165 (WebDatabaseManagerClient::WebDatabaseManagerClient): Initialize data
3166 members in the class definition.
3167 (DidModifyOriginData::dispatchToMainThread): Take references.
3168 (DidModifyOriginData::DidModifyOriginData): Ditto.
3169 (WebDatabaseManagerClient::dispatchDidModifyOrigin): Ditto.
3170 (WebDatabaseManagerClient::dispatchDidModifyDatabase): Ditto.
3171 (WebDatabaseManagerClient::dispatchDidAddNewOrigin): Ditto. Also use
3172 DatabaseTracker::singleton instead of tracker.
3174 * Storage/WebDatabaseQuotaManager.mm:
3175 (-[WebDatabaseQuotaManager initWithOrigin:]): Reject nil pointer argument.
3176 (-[WebDatabaseQuotaManager usage]): Use reference instead of pointer.
3177 (-[WebDatabaseQuotaManager quota]): Ditto.
3178 (-[WebDatabaseQuotaManager setQuota:]): Ditto.
3179 * WebCoreSupport/WebSecurityOrigin.mm:
3180 (-[WebSecurityOrigin initWithURL:]): Tweaked code a bit.
3181 (-[WebSecurityOrigin usage]): Use DatabaseTracker and pass a reference.
3182 (-[WebSecurityOrigin quota]): Ditto.
3183 (-[WebSecurityOrigin setQuota:]): Ditto.
3184 * WebView/WebFrame.mm:
3185 (-[WebFrame _cacheabilityDictionary]): Pass a reference.
3187 2016-11-12 Darin Adler <darin@apple.com>
3189 Remove a few assorted uses of ExceptionCode
3190 https://bugs.webkit.org/show_bug.cgi?id=164683
3192 Reviewed by Chris Dumez.
3194 * DOM/DOMDOMImplementation.mm:
3195 (-[DOMImplementation createDocumentType:publicId:systemId:]):
3196 Use raiseOnDOMError instead of much longer hand written equivalent.
3197 (-[DOMImplementation createDocument:qualifiedName:doctype:]): Ditto.
3199 * DOM/DOMDocument.mm:
3200 (-[DOMDocument createEntityReference:]): Use raiseNotSupportedErrorException
3201 so we are not using a specific exception code.
3203 * DOM/DOMHTMLOptionsCollection.mm:
3204 (-[DOMHTMLOptionsCollection add:index:]): Use raiseOnDOMError instead of
3205 much longer hand written equivalent.
3206 * DOM/DOMHTMLSelectElement.mm:
3207 (-[DOMHTMLSelectElement add:before:]): Ditto. Also removed unneeded return
3208 statement after calling a "no return" function.
3210 * DOM/ExceptionHandlers.h: Removed overloads of raiseDOMException and
3211 raiseOnDOMError functions that take ExceptionCode; keep the ones that take
3212 Exception and ExceptionOr. Renamed the other overload of raiseDOMException
3213 to raiseDOMErrorException; it is only used as the non-inline implementation
3214 part of the inline raiseOnDOMError function.
3215 * DOM/ExceptionHandlers.mm:
3216 (raiseDOMErrorException): Renamed. Made the ExceptionCode overload be local
3217 to this source file instead of in the header.
3218 (raiseTypeErrorException): Updated for name change.
3219 (raiseNotSupportedErrorException): Added.
3221 2016-11-11 Ryosuke Niwa <rniwa@webkit.org>
3223 Hovering over a slotted Text node clears hover state
3224 https://bugs.webkit.org/show_bug.cgi?id=164002
3225 <rdar://problem/29040471>
3227 Reviewed by Simon Fraser.
3229 * WebView/WebImmediateActionController.mm:
3230 (-[WebImmediateActionController performHitTestAtPoint:]):
3232 2016-11-11 Wenson Hsieh <wenson_hsieh@apple.com>
3234 [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
3235 https://bugs.webkit.org/show_bug.cgi?id=164538
3236 <rdar://problem/8418711>
3238 Reviewed by Ryosuke Niwa.
3240 Account for renaming HTMLElement::autocorrect to HTMLElement::shouldAutocorrect, as well as moving
3241 WebAutocapitalizeType to WebKit from WebCore. Additionally, moves the -autocorrect and -autocapitalize SPIs out
3242 of HTML(Input|Form|TextArea)ElementPrivate.h and into HTMLElementPrivate.h. This also means removing redundant
3243 code for interfacing with the unwrapped HTMLElement's autocorrect and autocapitalize attributes.
3246 (webAutocapitalizeType):
3247 (-[DOMHTMLInputElement _autocapitalizeType]):
3248 (-[DOMHTMLTextAreaElement _autocapitalizeType]):
3249 * DOM/DOMHTMLElement.mm:
3250 (-[DOMHTMLElement autocorrect]):
3251 (-[DOMHTMLElement setAutocorrect:]):
3252 (-[DOMHTMLElement autocapitalize]):
3253 (-[DOMHTMLElement setAutocapitalize:]):
3254 * DOM/DOMHTMLElementPrivate.h: Copied from Source/WebCore/html/Autocapitalize.h.
3255 * DOM/DOMHTMLFormElement.mm:
3256 (-[DOMHTMLFormElement autocorrect]): Deleted.
3257 (-[DOMHTMLFormElement setAutocorrect:]): Deleted.
3258 (-[DOMHTMLFormElement autocapitalize]): Deleted.
3259 (-[DOMHTMLFormElement setAutocapitalize:]): Deleted.
3260 * DOM/DOMHTMLInputElement.mm:
3261 (-[DOMHTMLInputElement autocorrect]): Deleted.
3262 (-[DOMHTMLInputElement setAutocorrect:]): Deleted.
3263 (-[DOMHTMLInputElement autocapitalize]): Deleted.
3264 (-[DOMHTMLInputElement setAutocapitalize:]): Deleted.
3265 * DOM/DOMHTMLInputElementPrivate.h:
3266 * DOM/DOMHTMLTextAreaElement.mm:
3267 (-[DOMHTMLTextAreaElement autocorrect]): Deleted.
3268 (-[DOMHTMLTextAreaElement setAutocorrect:]): Deleted.
3269 (-[DOMHTMLTextAreaElement autocapitalize]): Deleted.
3270 (-[DOMHTMLTextAreaElement setAutocapitalize:]): Deleted.
3271 * DOM/DOMHTMLTextAreaElementPrivate.h:
3273 We need to import DOMHTMLElementPrivate.h here to avoid breaking UIKit. We should follow this up with a UIKit
3274 change to import DOMHTMLElementPrivate.h directly.
3277 * DOM/WebAutocapitalizeTypes.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h.
3278 * MigrateHeaders.make:
3280 2016-11-11 Beth Dakin <bdakin@apple.com>
3282 Move to modern TouchBar methods
3283 https://bugs.webkit.org/show_bug.cgi?id=164655
3285 rdar://problem/29226911
3287 Reviewed by Wenson Hsieh.
3289 customizationDefaultItemIdentifiers -> defaultItemIdentifiers
3290 itemIdentifiers -> defaultItemIdentifiers
3291 defaultItems -> templateItems
3293 * WebView/WebView.mm:
3294 (-[WebView _plainTextTouchBarDefaultItemIdentifiers]):
3295 (-[WebView _richTextTouchBarDefaultItemIdentifiers]):
3296 (-[WebView setUpTextTouchBar:]):
3297 (-[WebView updateTextTouchBar]):
3298 (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
3299 (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]): Deleted.
3301 2016-11-11 Darin Adler <darin@apple.com>
3303 Move Node from ExceptionCode to ExceptionOr
3304 https://bugs.webkit.org/show_bug.cgi?id=164515
3306 Reviewed by Sam Weinig.
3308 * DOM/DOMHTMLSelectElement.mm:
3309 (-[DOMHTMLSelectElement remove:]): Call remove instead of removeByIndex
3310 now that it was renamed.
3312 (-[DOMNode setNodeValue:]): Updated exception handling.
3313 (-[DOMNode setPrefix:]): Ditto.
3314 (-[DOMNode setTextContent:]): Ditto.
3315 (-[DOMNode insertBefore:refChild:]): Ditto.
3316 (-[DOMNode replaceChild:oldChild:]): Ditto.
3317 (-[DOMNode removeChild:]): Ditto.
3318 (-[DOMNode appendChild:]): Ditto.
3319 (-[DOMNode cloneNode:]): Ditto.
3321 2016-11-11 Beth Dakin <bdakin@apple.com>
3323 Get touch bar code building for open source builds
3324 https://bugs.webkit.org/show_bug.cgi?id=164610
3326 Reviewed by Wenson Hsieh.
3330 2016-11-10 Alex Christensen <achristensen@webkit.org>
3332 Fix assertion after r208534.
3333 https://bugs.webkit.org/show_bug.cgi?id=160497
3335 * WebView/WebView.mm:
3336 (-[WebView _commonInitializationWithFrameName:groupName:]):
3337 (WebInstallMemoryPressureHandler):
3338 WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
3339 When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
3340 only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
3342 2016-11-10 Alex Christensen <achristensen@webkit.org>
3344 Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
3345 https://bugs.webkit.org/show_bug.cgi?id=164573
3347 Reviewed by Brady Eidson.
3349 * WebCoreSupport/WebSecurityOrigin.mm:
3350 (-[WebSecurityOrigin databaseIdentifier]):
3352 2016-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
3354 MemoryPressureHandler shouldn't know how to release WebCore memory
3355 https://bugs.webkit.org/show_bug.cgi?id=160497
3357 Reviewed by Michael Catanzaro.
3359 Set the low memory handler before installing the memory pressure handler.
3361 * WebView/WebView.mm:
3362 (-[WebView _commonInitializationWithFrameName:groupName:]):
3364 2016-11-09 Ryosuke Niwa <rniwa@webkit.org>
3366 WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
3367 https://bugs.webkit.org/show_bug.cgi?id=164501
3368 <rdar://problem/29152282>
3370 Reviewed by Sam Weinig.
3372 Align what [WebHTMLView attributedString] returns to what would be used on copy & paste by using HTMLConverter
3373 instead of _initWithDOMRange in [WebHTMLView _attributeStringFromDOMRange].
3375 * WebView/WebHTMLView.mm:
3376 (-[WebHTMLView _attributedStringFromDOMRange:]): Renamed from _attributeStringFromDOMRange.
3377 (-[WebHTMLView attributedString]):
3378 (-[WebHTMLView selectedAttributedString]):
3379 (-[WebHTMLView selectedString]): Moved to reduce the number of occurrences of the if-defs.
3381 2016-11-04 Brent Fulgham <bfulgham@apple.com>
3383 Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
3384 https://bugs.webkit.org/show_bug.cgi?id=155185
3385 <rdar://problem/11101440>
3387 Reviewed by Brady Eidson.
3389 Provide SPI to access the new quirk for localStorage. The quirk defaults to 'on'. When active, this
3390 quirk says that localStorage access should be granted, without needing to grant universal file access.
3392 If the quirk is turned off, then localStorage is blocked unless the WebKit client explicitly
3393 grants universal file access.
3395 * WebView/WebPreferenceKeysPrivate.h:
3396 * WebView/WebPreferences.mm:
3397 (-[WebPreferences needsLocalStorageQuirk]): Added.
3398 (-[WebPreferences setNeedsLocalStorageQuirk:]): Added.
3399 * WebView/WebPreferencesPrivate.h:
3400 * WebView/WebView.mm:
3401 (-[WebView _preferencesChanged:]): Honor the new localStorage quirk.
3403 2016-11-09 Alex Christensen <achristensen@webkit.org>
3405 Clean up Storage code
3406 https://bugs.webkit.org/show_bug.cgi?id=164562
3408 Reviewed by Brady Eidson.
3410 * Storage/WebStorageManager.mm:
3411 (-[WebStorageManager origins]):
3412 (-[WebStorageManager deleteAllOrigins]):
3413 (-[WebStorageManager deleteOrigin:]):
3414 (-[WebStorageManager diskUsageForOrigin:]):
3415 (-[WebStorageManager syncLocalStorage]):
3416 (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
3417 (+[WebStorageManager setStorageDatabaseIdleInterval:]):
3418 (+[WebStorageManager closeIdleLocalStorageDatabases]):
3419 (WebKitInitializeStorageIfNecessary):
3420 * WebView/WebView.mm:
3421 (+[WebView _applicationWillTerminate]):
3423 2016-11-09 Beth Dakin <bdakin@apple.com>
3425 Another attempted build fix.
3427 * WebView/WebView.mm:
3429 2016-11-09 Beth Dakin <bdakin@apple.com>
3431 Attempted build fix.
3433 * WebView/WebView.mm:
3435 2016-11-09 Darin Adler <darin@apple.com>
3437 Move Range from ExceptionCode to ExceptionOr
3438 https://bugs.webkit.org/show_bug.cgi?id=164457
3440 Reviewed by Alex Christensen.
3443 (-[DOMRange setStart:offset:]): Updated exception handling.
3444 (-[DOMRange setEnd:offset:]): Ditto.
3445 (-[DOMRange setStartBefore:]): Ditto.
3446 (-[DOMRange setStartAfter:]): Ditto.
3447 (-[DOMRange setEndBefore:]): Ditto.
3448 (-[DOMRange setEndAfter:]): Ditto.
3449 (-[DOMRange selectNode:]): Ditto.
3450 (-[DOMRange selectNodeContents:]): Ditto.
3451 (-[DOMRange compareBoundaryPoints:sourceRange:]): Ditto.
3452 (-[DOMRange deleteContents]): Ditto.
3453 (-[DOMRange extractContents]): Ditto.
3454 (-[DOMRange cloneContents]): Ditto.
3455 (-[DOMRange insertNode:]): Ditto.
3456 (-[DOMRange surroundContents:]): Ditto.
3457 (-[DOMRange createContextualFragment:]): Ditto.
3458 (-[DOMRange compareNode:]): Ditto.
3459 (-[DOMRange intersectsNode:]): Ditto.
3460 (-[DOMRange comparePoint:offset:]): Ditto.
3461 (-[DOMRange isPointInRange:offset:]): Ditto.
3462 (-[DOMRange expand:]): Ditto.
3463 * WebView/WebFrame.mm:
3464 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3465 (-[WebFrame _smartDeleteRangeForProposedRange:]): Deleted.
3466 This function was incorrectly implemented (set both start and end of
3467 the range to the computed start), not declared in any header file,
3468 not used anywhere inside WebKit, and I also could not find a use of it
3469 in outside-WebKit Apple code.
3470 * mac/DOM/DOMUIKitExtensions.mm:
3471 (-[DOMRange move:inDirection:]): Ditto.
3472 (-[DOMRange extend:inDirection:]): Ditto.
3474 2016-11-09 Darin Adler <darin@apple.com>
3476 Move EventTarget from ExceptionCode to ExceptionOr
3477 https://bugs.webkit.org/show_bug.cgi?id=164465
3479 Reviewed by Youenn Fablet.
3482 (-[DOMNode dispatchEvent:]): Updated exception handling.
3484 2016-11-09 Chris Dumez <cdumez@apple.com>
3486 [Mac] Stop using deprecated AppKit enumeration values
3487 https://bugs.webkit.org/show_bug.cgi?id=164494
3489 Reviewed by Darin Adler.
3491 Stop using deprecated AppKit enumeration values.
3493 * Carbon/CarbonWindowAdapter.mm:
3494 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3495 (-[CarbonWindowAdapter sendSuperEvent:]):
3496 * Plugins/Hosted/NetscapePluginHostProxy.mm:
3497 (WebKit::NetscapePluginHostProxy::beginModal):
3498 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3499 (WebKit::NetscapePluginInstanceProxy::syntheticKeyDownWithCommandModifier):
3500 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3501 (-[WebHostedNetscapePluginView drawRect:]):
3502 * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3503 (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
3504 * WebCoreSupport/PopupMenuMac.mm:
3505 (PopupMenuMac::populate):
3506 (PopupMenuMac::show):
3507 * WebCoreSupport/WebContextMenuClient.mm:
3508 (WebContextMenuClient::showContextMenu):
3509 * WebCoreSupport/WebFrameLoaderClient.mm:
3510 (WebFrameLoaderClient::actionDictionary):
3511 * WebCoreSupport/WebInspectorClient.mm:
3512 (WebInspectorFrontendClient::canAttach):
3513 (-[WebInspectorWindowController window]):
3514 * WebInspector/WebNodeHighlight.mm:
3515 (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3516 * WebView/WebFrameView.mm:
3517 (-[WebFrameView keyDown:keyDown:]):
3518 * WebView/WebFullScreenController.mm:
3519 (-[WebFullScreenController init]):
3520 (createBackgroundFullscreenWindow):
3521 * WebView/WebHTMLView.mm:
3522 (-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
3523 (-[WebHTMLView _setMouseDownEvent:_setMouseDownEvent:]):
3524 (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3526 (-[WebHTMLView hitTest:]):
3527 (-[WebHTMLView _sendToolTipMouseExited]):
3528 (-[WebHTMLView _sendToolTipMouseEntered]):
3529 (mouseEventIsPartOfClickOrDrag):
3530 (-[WebHTMLView _updateMouseoverWithEvent:]):
3531 (-[WebHTMLView _autoscroll]):
3532 (-[WebHTMLView acceptsFirstResponder]):
3533 (-[WebHTMLView viewDidMoveToWindow]):
3534 (-[WebHTMLView mouseDown:mouseDown:]):
3535 (currentKeyboardEvent):
3536 (-[WebHTMLView _handleStyleKeyEquivalent:]):
3537 (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
3538 * WebView/WebPDFView.mm:
3539 (-[WebPDFView hitTest:]):
3540 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3541 (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
3542 * WebView/WebTextCompletionController.mm:
3543 (-[WebTextCompletionController _buildUI]):
3544 (-[WebTextCompletionController _placePopupWindow:]):
3545 * WebView/WebView.mm:
3546 (-[WebView applicationFlags:]):
3548 2016-11-09 Beth Dakin <bdakin@apple.com>
3550 Support TouchBar in WebKit
3551 https://bugs.webkit.org/show_bug.cgi?id=164437
3553 rdar://problem/28876524
3555 Reviewed by Darin Adler.
3557 * WebCoreSupport/WebEditorClient.mm:
3558 (WebEditorClient::respondToChangedSelection):
3559 (WebEditorClient::updateEditorStateAfterLayoutIfEditabilityChanged):
3560 * WebView/WebHTMLView.mm:
3561 (-[WebHTMLView candidateListTouchBarItem]):
3562 * WebView/WebView.mm:
3563 (-[_WebTextListTouchBarViewController initWithWebView:]):
3564 (-[_WebTextListTouchBarViewController _selectList:]):
3565 (-[_WebTextListTouchBarViewController setCurrentListType:]):
3566 (-[WebTextTouchBarItemController initWithWebView:]):
3567 (-[WebTextTouchBarItemController itemForIdentifier:]):
3568 (-[WebTextTouchBarItemController webTextListTouchBarViewController]):
3569 (-[WebTextTouchBarItemController setTextIsBold:]):
3570 (-[WebTextTouchBarItemController setTextIsItalic:]):
3571 (-[WebTextTouchBarItemController setTextIsUnderlined:]):
3572 (-[WebTextTouchBarItemController _webChangeTextStyle:]):
3573 (-[WebTextTouchBarItemController setCurrentTextAlignment:]):
3574 (-[WebTextTouchBarItemController _webChangeTextAlignment:]):
3575 (-[WebTextTouchBarItemController textColor]):
3576 (-[WebTextTouchBarItemController setTextColor:]):
3577 (-[WebTextTouchBarItemController _webChangeColor:]):
3578 (-[WebTextTouchBarItemController textListViewController]):
3579 (-[WebView _commonInitializationWithFrameName:groupName:]):
3580 (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
3581 (-[WebView shouldRequestCandidates]):
3582 (-[WebView forceRequestCandidatesForTesting]):
3583 (-[WebView makeTouchBar]):
3584 (-[WebView touchBar:makeItemForIdentifier:]):
3585 (textCheckingResultFromNSTextCheckingResult):
3586 (-[WebView candidateListTouchBarItem:endSelectingCandidateAtIndex:]):
3587 (-[WebView candidateListTouchBarItem:changedCandidateListVisibility:]):
3588 (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3589 (-[WebView _clearPlaybackControlsManager]):
3590 (-[WebView _dismissTextTouchBarPopoverItemWithIdentifier:]):
3591 (-[WebView _textTouchBarCustomizationAllowedIdentifiers]):
3592 (-[WebView _plainTextTouchBarCustomizationDefaultItemIdentifiers]):
3593 (-[WebView _richTextTouchBarCustomizationDefaultItemIdentifiers]):
3594 (-[WebView touchBarDidExitCustomization:]):
3595 (-[WebView touchBarWillEnterCustomization:]):
3596 (-[WebView didChangeAutomaticTextCompletion:]):
3597 (-[WebView setUpTextTouchBar:]):
3598 (-[WebView _isRichlyEditable]):
3599 (-[WebView textTouchBar]):
3600 (-[WebView updateTextTouchBar]):
3601 (-[WebView updateMediaTouchBar]):
3602 (-[WebView updateTouchBar]):
3603 (-[WebView prepareForMouseDown]):
3604 (-[WebView prepareForMouseUp]):
3605 (-[WebView webViewAdditionsWillDestroyView]):
3606 (-[WebView candidateList]):
3607 (-[WebView updateWebViewAdditions]): Deleted.
3608 * WebView/WebViewData.h:
3609 * WebView/WebViewInternal.h:
3610 * WebView/WebViewPrivate.h:
3612 2016-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
3614 Safari does not emit composition end if blurred for dead key / Japanese IME
3615 https://bugs.webkit.org/show_bug.cgi?id=164369
3616 <rdar://problem/29050439>
3618 Reviewed by Ryosuke Niwa.
3620 When canceling a composition, make sure that we clear the system IME state.
3622 * WebCoreSupport/WebEditorClient.h:
3623 * WebCoreSupport/WebEditorClient.mm:
3624 (WebEditorClient::canceledComposition):
3626 2016-11-04 Said Abou-Hallawa <sabouhallawa@apple.com>
3628 Add a setting and preferences to enable/disable async image decoding
3629 https://bugs.webkit.org/show_bug.cgi?id=164417
3631 Reviewed by Simon Fraser.
3633 Hook up the asyncImageDecodingEnabled setting for WebKit1.
3635 * WebView/WebPreferenceKeysPrivate.h:
3636 * WebView/WebPreferences.mm:
3637 (+[WebPreferences initialize]):
3638 (-[WebPreferences asyncImageDecodingEnabled]):
3639 (-[WebPreferences setAsyncImageDecodingEnabled:]):
3640 * WebView/WebPreferencesPrivate.h:
3641 * WebView/WebView.mm:
3642 (-[WebView _preferencesChanged:]):
3644 2016-11-01 Alex Christensen <achristensen@webkit.org>
3646 Remove PassRefPtr from DumpRenderTree
3647 https://bugs.webkit.org/show_bug.cgi?id=164307
3649 Reviewed by Sam Weinig.
3651 * WebView/WebGeolocationPosition.mm:
3652 (-[WebGeolocationPosition initWithGeolocationPosition:]):
3654 2016-11-02 Romain Bellessort <romain.bellessort@crf.canon.fr>
3656 [Readable Streams API] Enable creation of ReadableByteStreamController
3657 https://bugs.webkit.org/show_bug.cgi?id=164014
3659 Reviewed by Youenn Fablet.
3661 Added flag for the byte stream part of Readable Streams API.
3663 * Configurations/FeatureDefines.xcconfig:
3665 2016-11-01 Ryosuke Niwa <rniwa@webkit.org>
3667 Remove CUSTOM_ELEMENTS build flag
3668 https://bugs.webkit.org/show_bug.cgi?id=164267
3670 Reviewed by Antti Koivisto.
3672 Removed the build flag.
3674 * Configurations/FeatureDefines.xcconfig:
3675 * WebView/WebPreferences.mm:
3676 (+[WebPreferences initialize]):
3677 * WebView/WebView.mm:
3678 (-[WebView _preferencesChanged:]):
3680 2016-11-01 Eric Carlson <eric.carlson@apple.com>
3682 [MediaStream] restrict media capture secure connections
3683 https://bugs.webkit.org/show_bug.cgi?id=164234
3684 <rdar://problem/28944906>
3686 Reviewed by Alex Christensen.
3688 * WebView/WebPreferenceKeysPrivate.h:
3689 * WebView/WebPreferences.mm:
3690 (+[WebPreferences initialize]): Initialize WebKitMediaCaptureRequiresSecureConnectionPreferenceKey.
3691 (-[WebPreferences mediaCaptureRequiresSecureConnection]): New.
3692 (-[WebPreferences setMediaCaptureRequiresSecureConnection:]): New.
3693 * WebView/WebPreferencesPrivate.h:
3695 * WebView/WebView.mm:
3696 (-[WebView _preferencesChanged:]): Sync mediaCaptureRequiresSecureConnection.
3698 2016-10-29 Filip Pizlo <fpizlo@apple.com>
3700 JSC should support SharedArrayBuffer
3701 https://bugs.webkit.org/show_bug.cgi?id=163986
3703 Reviewed by Keith Miller.
3705 Support the RuntimeFlag.
3707 * WebView/WebPreferencesPrivate.h:
3709 2016-10-31 Wenson Hsieh <wenson_hsieh@apple.com>
3711 [WK1] Candidate visibility should not update as a result of selection during a dictionary lookup
3712 https://bugs.webkit.org/show_bug.cgi?id=164236
3713 <rdar://problem/28747712>
3715 Reviewed by Beth Dakin.
3717 See WebCore ChangeLog for more detail. Sets the Editor's isGettingDictionaryPopupInfo state to true during a
3720 * WebCoreSupport/WebEditorClient.mm:
3721 (WebEditorClient::respondToChangedSelection):
3722 * WebView/WebImmediateActionController.mm:
3723 (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3725 2016-10-31 Darin Adler <darin@apple.com>
3727 Move ChildNode and ParentNode from ExceptionCode to Exception, add support for ExceptionOr<T&>
3728 https://bugs.webkit.org/show_bug.cgi?id=164214
3730 Reviewed by Alex Christensen.
3732 * DOM/DOMCSSPrimitiveValue.mm:
3733 (-[DOMCSSPrimitiveValue getCounterValue]): Updated since return value
3735 (-[DOMCSSPrimitiveValue getRectValue]): Ditto.
3737 * DOM/DOMDocument.mm:
3738 (-[DOMDocument querySelector:]): Updated exception handling.
3739 (-[DOMDocument querySelectorAll:]): Ditto.
3740 * DOM/DOMDocumentFragment.mm:
3741 (-[DOMDocumentFragment querySelector:]): Ditto.
3742 (-[DOMDocumentFragment querySelectorAll:]): Ditto.
3743 * DOM/DOMElement.mm:
3744 (-[DOMElement querySelector:]): Ditto.
3745 (-[DOMElement querySelectorAll:]): Ditto.
3747 2016-10-31 Darin Adler <darin@apple.com>
3749 Convert Document from ExceptionCode to Exception
3750 https://bugs.webkit.org/show_bug.cgi?id=164212
3752 Reviewed by Alex Christensen.
3754 * DOM/DOMDocument.mm:
3755 (-[DOMDocument setXmlVersion:]): Updated exception handling.
3756 (-[DOMDocument cookie]): Ditto.
3757 (-[DOMDocument setCookie:]): Ditto.
3758 (-[DOMDocument setBody:]): Ditto.
3759 (-[DOMDocument createElement:]): Ditto.
3760 (-[DOMDocument createCDATASection:]): Ditto.
3761 (-[DOMDocument createProcessingInstruction:data:]): Ditto.
3762 (-[DOMDocument createAttribute:]): Ditto.
3763 (-[DOMDocument createEntityReference:]): Ditto.
3764 (-[DOMDocument importNode:deep:]): Ditto.
3765 (-[DOMDocument createElementNS:qualifiedName:]): Ditto.
3766 (-[DOMDocument createAttributeNS:qualifiedName:]): Ditto.
3767 (-[DOMDocument getElementsByTagNameNS:localName:]): Ditto.
3768 (-[DOMDocument adoptNode:]): Ditto.
3769 (-[DOMDocument createEvent:]): Ditto.
3771 2016-10-30 Darin Adler <darin@apple.com>
3773 Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
3774 https://bugs.webkit.org/show_bug.cgi?id=164206
3776 Reviewed by Chris Dumez.
3778 * DOM/DOMElement.mm:
3779 (-[DOMElement setInnerHTML:]): Updated exception handling.
3780 (-[DOMElement setOuterHTML:]): Ditto.
3781 (-[DOMElement setAttribute:value:]): Ditto.
3782 (-[DOMElement setAttributeNode:]): Ditto.
3783 (-[DOMElement removeAttributeNode:]): Ditto.
3784 (-[DOMElement setAttributeNS:qualifiedName:value:]): Ditto.
3785 (-[DOMElement setAttributeNodeNS:]): Ditto.
3786 (-[DOMElement matches:]): Ditto.
3787 (-[DOMElement closest:]): Ditto.
3788 (-[DOMElement webkitMatchesSelector:]): Ditto.
3789 * DOM/DOMHTMLElement.mm:
3790 (-[DOMHTMLElement insertAdjacentElement:element:]): Ditto.
3791 (-[DOMHTMLElement insertAdjacentHTML:html:]): Ditto.
3792 (-[DOMHTMLElement insertAdjacentText:text:]): Ditto.
3793 * DOM/DOMNamedNodeMap.mm:
3794 (-[DOMNamedNodeMap setNamedItem:]): Ditto.
3795 (-[DOMNamedNodeMap removeNamedItem:]): Ditto.
3796 (-[DOMNamedNodeMap setNamedItemNS:]): Ditto.
3797 (-[DOMNamedNodeMap removeNamedItemNS:localName:]): Ditto.
3799 2016-10-29 Darin Adler <darin@apple.com>
3801 Convert more of DOM from ExceptionCode to Exception
3802 https://bugs.webkit.org/show_bug.cgi?id=164173
3804 Reviewed by Ryosuke Niwa.
3806 * DOM/DOMCharacterData.mm:
3807 (-[DOMCharacterData substringData:length:]): Updated since this
3808 now uses ExceptionOr.
3809 (-[DOMCharacterData insertData:data:]): Ditto.
3810 (-[DOMCharacterData deleteData:length:]): Ditto.
3811 (-[DOMCharacterData replaceData:length:data:]): Ditto.
3813 (-[DOMText splitText:]): Ditto.
3814 (-[DOMText replaceWholeText:]): Removed unneeded exception code
3815 handling from function that does not throw an exception.
3817 2016-10-28 Darin Adler <darin@apple.com>
3819 Move all classes in the HTML directory from ExceptionCode to Exception
3820 https://bugs.webkit.org/show_bug.cgi?id=163876
3822 Reviewed by Sam Weinig.
3824 * DOM/DOMCharacterData.mm:
3825 (-[DOMCharacterData remove]): Updated exception handling.
3826 * DOM/DOMDOMTokenList.mm:
3827 (-[DOMDOMTokenList toggle:force:]): Ditto.
3828 * DOM/DOMDocumentType.mm:
3829 (-[DOMDocumentType remove]): Ditto.
3830 * DOM/DOMElement.mm:
3831 (-[DOMElement remove]): Ditto.
3833 (-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.
3834 * DOM/DOMHTMLCanvasElement.mm:
3835 (-[DOMHTMLCanvasElement toDataURL:]): Ditto.
3836 * DOM/DOMHTMLElement.mm:
3837 (-[DOMHTMLElement setInnerText:]): Ditto.
3838 (-[DOMHTMLElement setOuterText:]): Ditto.
3839 (-[DOMHTMLElement setContentEditable:]): Ditto.
3840 * DOM/DOMHTMLInputElement.mm:
3841 (-[DOMHTMLInputElement setMaxLength:]): Ditto.
3842 (-[DOMHTMLInputElement setValueAsDate:]): Ditto.
3843 (-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
3844 (-[DOMHTMLInputElement stepUp:]): Ditto.
3845 (-[DOMHTMLInputElement stepDown:]): Ditto.
3846 (-[DOMHTMLInputElement setRangeText:]): Ditto.
3847 (-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.
3848 * DOM/DOMHTMLMarqueeElement.mm:
3849 (-[DOMHTMLMarqueeElement setLoop:]): Ditto.
3850 * DOM/DOMHTMLMediaElement.mm:
3851 (-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
3852 (-[DOMHTMLMediaElement setVolume:]): Ditto.
3853 * DOM/DOMHTMLOptionsCollection.mm:
3854 (-[DOMHTMLOptionsCollection setLength:]): Ditto.
3855 * DOM/DOMHTMLTableElement.mm:
3856 (-[DOMHTMLTableElement setCaption:]): Ditto.
3857 (-[DOMHTMLTableElement setTHead:]): Ditto.
3858 (-[DOMHTMLTableElement setTFoot:]): Ditto.
3859 (-[DOMHTMLTableElement insertRow:]): Ditto.
3860 (-[DOMHTMLTableElement deleteRow:]): Ditto.
3861 * DOM/DOMHTMLTableRowElement.mm:
3862 (-[DOMHTMLTableRowElement insertCell:]): Ditto.
3863 (-[DOMHTMLTableRowElement deleteCell:]): Ditto.
3864 * DOM/DOMHTMLTableSectionElement.mm:
3865 (-[DOMHTMLTableSectionElement insertRow:]): Ditto.
3866 (-[DOMHTMLTableSectionElement deleteRow:]): Ditto.
3867 * DOM/DOMHTMLTextAreaElement.mm:
3868 (-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
3869 (-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
3870 (-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.
3871 * DOM/DOMHTMLVideoElement.mm:
3872 (-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
3873 (-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
3874 version (lowercase S) instead of repeating the logic from that method.
3875 (-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.
3876 * DOM/DOMTimeRanges.mm:
3877 (-[DOMTimeRanges start:]): Updated exception handling.
3878 (-[DOMTimeRanges end:]): Ditto.
3880 2016-10-27 Chris Dumez <cdumez@apple.com>
3882 Regression(r203601): Caused crashes in iBooks
3883 https://bugs.webkit.org/show_bug.cgi?id=164093
3884 <rdar://problem/28745634>
3886 Reviewed by Darin Adler.
3888 Restore pre-r203601 behavior when calling [DOMNode compareDocumentPosition:nil],
3889 which was to return Node::DOCUMENT_POSITION_DISCONNECTED.
3892 (-[DOMNode compareDocumentPosition:]):
3894 2016-10-27 Wenson Hsieh <wenson_hsieh@apple.com>
3896 Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
3897 https://bugs.webkit.org/show_bug.cgi?id=163948
3898 <rdar://problem/28921433>
3900 Reviewed by Darin Adler.
3902 Add support for new drag and drop-related EditAction enum values.
3904 * WebCoreSupport/WebEditorClient.mm:
3905 (undoNameForEditAction):
3907 2016-10-27 Dan Bernstein <mitz@apple.com>
3909 Reapplied the configuration changes from r207934 without breaking iOS builds.
3911 * Configurations/Base.xcconfig:
3912 * Configurations/WebKitLegacy.xcconfig:
3914 2016-10-27 Dan Bernstein <mitz@apple.com>
3916 Reverted the configuration changes from r207934 because they broke iOS builds not using the Apple-internal SDK.
3918 * Configurations/Base.xcconfig:
3919 * Configurations/WebKitLegacy.xcconfig:
3921 2016-10-26 Dan Bernstein <mitz@apple.com>
3923 [Xcode] WebKit fails to build when CLANG_WARN_DOCUMENTATION_COMMENTS is enabled
3924 https://bugs.webkit.org/show_bug.cgi?id=164048
3926 Reviewed by Tim Horton.
3928 * Configurations/Base.xcconfig: Enabled CLANG_WARN_DOCUMENTATION_COMMENTS.
3929 * Configurations/WebKitLegacy.xcconfig: Made the compiler treat the icu headers as system
3932 * History/WebBackForwardList.h: Fixed parameter name in @param entry.
3933 * Misc/WebDownload.h: Removed empty entries.
3934 * Misc/WebIconDatabase.h: Remove incorrect @param entries.
3935 * Misc/WebQuotaManager.h: Added missing parameter names in @param entries.
3936 * WebView/WebFrameLoadDelegate.h: Corrected parameter names in @param entries.
3937 * WebView/WebFrameViewPrivate.h: Changed incorrect @result to @abstract.
3938 * WebView/WebPolicyDelegate.h: Fixed parameter name and removed incorrect @param entries.
3939 * WebView/WebPreferences.h: Changed @method to @property in a couple of places.
3940 * WebView/WebResourceLoadDelegate.h: Fixed parameter names.
3941 * WebView/WebUIDelegate.h: Filled in two empty @param entries. Added missing parameter name,
3942 Fixed a typo and removed empty @discussion entry. Fixed some parameter names.
3943 * WebView/WebUIDelegatePrivate.h: Fixed parameter names.
3944 * WebView/WebView.h: Changed @method to @property in a couple of places.
3945 * WebView/WebViewPrivate.h: Fixed parameter names, changed incorrect @result to @abstract.
3947 2016-10-26 Brian Burg <bburg@apple.com>
3949 Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
3950 https://bugs.webkit.org/show_bug.cgi?id=164046
3952 Reviewed by Joseph Pecoraro.
3954 * WebCoreSupport/WebInspectorClient.h:
3956 2016-10-21 Alex Christensen <achristensen@webkit.org>
3958 URL::port should return Optional<uint16_t>
3959 https://bugs.webkit.org/show_bug.cgi?id=163806
3961 Reviewed by Darin Adler.
3963 * WebCoreSupport/WebSecurityOrigin.mm:
3964 (-[WebSecurityOrigin port]):
3966 2016-10-24 Dave Hyatt <hyatt@apple.com>
3968 Remove CSSCharsetRule from the CSS OM
3969 https://bugs.webkit.org/show_bug.cgi?id=163891
3971 Reviewed by Darin Adler.
3973 * DOM/DOMCSSCharsetRule.mm:
3974 (-[DOMCSSCharsetRule encoding]):
3976 2016-10-24 Youenn Fablet <youenn@apple.com>
3978 Activate WEB_RTC compilation flags for Mac bots
3979 https://bugs.webkit.org/show_bug.cgi?id=163886
3981 Reviewed by Eric Carlson.
3983 * Configurations/FeatureDefines.xcconfig:
3985 2016-10-23 Chris Dumez <cdumez@apple.com>
3987 addEventListener() / removeEventListener() should use a union for last parameter
3988 https://bugs.webkit.org/show_bug.cgi?id=163863
3990 Reviewed by Darin Adler.
3992 Cast BOOL to bool to help to compiler construct the new variant-type parameter.
3995 (-[DOMNode addEventListener:listener:useCapture:]):
3996 (-[DOMNode addEventListener:::]):
3997 (-[DOMNode removeEventListener:listener:useCapture:]):
3998 (-[DOMNode removeEventListener:::]):
4000 2016-10-21 Wenson Hsieh <wenson_hsieh@apple.com>
4002 Support (insertFrom|deleteBy)Composition and (insert|delete)CompositionText inputTypes for InputEvents
4003 https://bugs.webkit.org/show_bug.cgi?id=163460
4004 <rdar://problem/28784142>
4006 Reviewed by Darin Adler.
4008 Handle new EditAction types for inserting/deleting pending/final compositions.
4010 * WebCoreSupport/WebEditorClient.mm:
4011 (undoNameForEditAction):
4013 2016-10-21 Jeremy Jones <jeremyj@apple.com>
4015 Implement basic pointer lock behavior for WebKit and WebKit2.
4016 https://bugs.webkit.org/show_bug.cgi?id=162745
4018 Reviewed by Simon Fraser.
4020 Add basic pointer lock functionality. User permission is not yet implemented.
4022 * WebCoreSupport/WebChromeClient.h:
4023 * WebCoreSupport/WebChromeClient.mm:
4024 (WebChromeClient::requestPointerLock):
4025 (WebChromeClient::requestPointerUnlock):
4027 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
4029 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
4030 https://bugs.webkit.org/show_bug.cgi?id=163374
4032 Reviewed by Darin Adler.
4034 * Configurations/FeatureDefines.xcconfig:
4036 2016-10-19 Alex Christensen <achristensen@webkit.org>
4039 https://bugs.webkit.org/show_bug.cgi?id=163675
4041 Reviewed by Brent Fulgham.
4043 * Misc/WebDownload.mm:
4044 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
4045 * Misc/WebDownloadInternal.h:
4046 * WebCoreSupport/WebFrameLoaderClient.mm:
4047 (WebFrameLoaderClient::convertMainResourceLoadToDownload):
4048 * WebView/WebPreferences.mm:
4049 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
4050 * WebView/WebView.mm:
4051 (-[WebView scheduleInRunLoop:forMode:]):
4052 (-[WebView unscheduleFromRunLoop:forMode:]):
4054 2016-10-19 Ryan Haddad <ryanhaddad@apple.com>
4056 Unreviewed, rolling out r207557.
4058 This change caused animations/font-variations tests to time
4059 out on pre-Sierra Macs.
4063 "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
4065 https://bugs.webkit.org/show_bug.cgi?id=163374
4066 http://trac.webkit.org/changeset/207557
4068 2016-10-19 Chris Dumez <cdumez@apple.com>
4070 Move HTML Interactive Form Validation behind an experimental flag
4071 https://bugs.webkit.org/show_bug.cgi?id=163673
4073 Reviewed by Daniel Bates.
4075 Re-disable HTML Interactive Form Validation by default on Mac WK1.
4077 * WebView/WebViewData.mm:
4078 (-[WebViewPrivate init]):
4080 2016-10-19 Myles C. Maxfield <mmaxfield@apple.com>
4082 [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
4083 https://bugs.webkit.org/show_bug.cgi?id=163374
4085 Reviewed by Darin Adler.
4087 * Configurations/FeatureDefines.xcconfig:
4089 2016-10-19 Simon Fraser <simon.fraser@apple.com>
4091 WebView needs to initialize the visualViewportEnabled Setting from WebKit preferences
4092 https://bugs.webkit.org/show_bug.cgi?id=163680
4094 Reviewed by Dean Jackson.
4096 Add code to set the Setting from WebKit prefs. This code is a mess and needs to be autogenerated.
4098 * WebView/WebView.mm:
4099 (-[WebView _preferencesChanged:]):
4101 2016-10-19 Darin Adler <darin@apple.com>
4103 Move XPath from ExceptionCode to Exception
4104 https://bugs.webkit.org/show_bug.cgi?id=163656
4106 Reviewed by Chris Dumez.
4108 * DOM/DOMDocument.mm:
4109 (wrap): Added. Helper function for wrapping a resolver.
4110 (-[DOMDocument createExpression:resolver:]): Use raiseOnDOMError.
4111 (-[DOMDocument evaluate:contextNode:resolver:type:inResult:]): Ditto.
4112 * DOM/DOMXPathExpression.mm:
4113 (-[DOMXPathExpression evaluate:type:inResult:]): Ditto.
4114 * DOM/DOMXPathResult.mm:
4115 (-[DOMXPathResult numberValue]): Ditto.
4116 (-[DOMXPathResult stringValue]): Ditto.
4117 (-[DOMXPathResult booleanValue]): Ditto.
4118 (-[DOMXPathResult singleNodeValue]): Ditto.
4119 (-[DOMXPathResult snapshotLength]): Ditto.
4120 (-[DOMXPathResult iterateNext]): Ditto.
4121 (-[DOMXPathResult snapshotItem:]): Ditto.
4123 2016-10-18 Sam Weinig <sam@webkit.org>
4125 Replace std::experimental::variant with WTF::Variant (or similar)
4126 https://bugs.webkit.org/show_bug.cgi?id=163626
4128 Reviewed by Chris Dumez.
4130 Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
4131 into the WTF namespace.
4133 * DOM/DOMHTMLSelectElement.mm:
4134 (-[DOMHTMLSelectElement add:before:]):
4136 2016-10-18 Simon Fraser <simon.fraser@apple.com>
4138 Add a MiniBrowser menu item to apply page scale in WK1 and WK2
4139 https://bugs.webkit.org/show_bug.cgi?id=163627
4141 Reviewed by Dean Jackson.
4143 Add an explanatory comment about viewScaleFactor not really being viewScaleFactor.
4145 * WebView/WebViewPrivate.h:
4147 2016-10-18 Dean Jackson <dino@apple.com>
4149 Remove CSS_SHAPES feature definition. This should always be on.
4150 https://bugs.webkit.org/show_bug.cgi?id=163628
4151 <rdar://problem/28834613>
4153 Reviewed by Tim Horton.
4155 * Configurations/FeatureDefines.xcconfig:
4157 2016-10-18 Chris Dumez <cdumez@apple.com>
4159 Leverage new union type support for HTMLSelectElement.add() / HTMLOptionsCollection.add()
4160 https://bugs.webkit.org/show_bug.cgi?id=163608
4162 Reviewed by Ryosuke Niwa.
4164 Update add() call sites now that it takes std::variant types in.
4166 * DOM/DOMHTMLOptionsCollection.mm:
4167 (-[DOMHTMLOptionsCollection add:index:]):
4168 * DOM/DOMHTMLSelectElement.mm:
4169 (-[DOMHTMLSelectElement add:before:]):
4171 2016-10-18 Anders Carlsson <andersca@apple.com>
4173 Get rid of more WebHistoryItem cruft
4174 https://bugs.webkit.org/show_bug.cgi?id=163623
4176 Reviewed by Tim Horton.
4178 * History/WebHistoryItem.mm:
4179 (-[WebHistoryItem initFromDictionaryRepresentation:]):
4180 * History/WebHistoryItemPrivate.h:
4182 2016-10-18 Wenson Hsieh <wenson_hsieh@apple.com>
4184 Showing and hiding candidates list is very distracting after selecting word
4185 https://bugs.webkit.org/show_bug.cgi?id=163609
4186 <rdar://problem/28747712>
4188 Reviewed by Tim Horton.
4190 Introduce WebView hooks for mousedown and mouseup. See radar for more details.
4192 * WebView/WebHTMLView.mm:
4193 (-[WebHTMLView mouseDown:mouseDown:]):
4194 (-[WebHTMLView mouseUp:mouseUp:]):
4195 * WebView/WebView.mm:
4196 (-[WebView prepareForMouseDown]):
4197 (-[WebView prepareForMouseUp]):
4198 * WebView/WebViewInternal.h:
4200 2016-10-17 Anders Carlsson <andersca@apple.com>
4202 Move some history specific HistoryItem code to WebHistoryItem
4203 https://bugs.webkit.org/show_bug.cgi?id=163567
4205 Reviewed by Tim Horton.
4207 * History/HistoryPropertyList.mm: