Source/WebKit/gtk/ChangeLog

   1 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
   2
   3         [GTK] Reorganize header files
   4         https://bugs.webkit.org/show_bug.cgi?id=65616
   5
   6         Reviewed by Martin Robinson.
   7
   8         Install header files under $libwebkitgtkincludedir/webkit.
   9
  10         * GNUmakefile.am: Use $libwebkitgtkincludedir.
  11         * webkit.pc.in: Use webkitgtk-<api-version> as include dir.
  12
  13 2011-09-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
  14
  15         Fix documentation generation by specifying the sources
  16         directory with $(top_srcdir).
  17
  18         Reviewed by Xan Lopez.
  19
  20         * docs/GNUmakefile.am:
  21
  22 2011-09-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
  23
  24         REGRESSION: Empathy crashes when switching theme
  25         https://bugs.webkit.org/show_bug.cgi?id=68600
  26
  27         Reviewed by Martin Robinson.
  28
  29         * webkit/webkitwebview.cpp:
  30         (webkit_web_view_set_scroll_adjustments): use the existing
  31         set{Horizontal,Vertical}Adjustment functions, so the code is not
  32         duplicated
  33         (webkit_web_view_dispose): unset the adjustments during dispose,
  34         to avoid late adjustment change notifications hitting the
  35         adjustment watcher
  36
  37 2011-09-24  Adam Barth  <abarth@webkit.org>
  38
  39         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
  40         https://bugs.webkit.org/show_bug.cgi?id=68767
  41
  42         Reviewed by Eric Seidel.
  43
  44         * WebCoreSupport/ChromeClientGtk.cpp:
  45         (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
  46         * WebCoreSupport/ChromeClientGtk.h:
  47         * webkit/webkitapplicationcache.cpp:
  48         (webkit_application_cache_get_maximum_size):
  49         (webkit_application_cache_set_maximum_size):
  50         (webkit_application_cache_get_database_directory_path):
  51         * webkit/webkitglobals.cpp:
  52         (webkitInit):
  53
  54 2011-09-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
  55
  56         Remove useless empty WebKit namespace.
  57
  58         Reviewed by Xan Lopez.
  59
  60         * webkit/webkitglobals.cpp:
  61         (webkitInit):
  62
  63 2011-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
  64
  65         [GTK] WebProcess shouldn't use the GTK+ API
  66         https://bugs.webkit.org/show_bug.cgi?id=68062
  67
  68         Reviewed by Martin Robinson.
  69
  70         Use WebCore API to create errors in frame loader.
  71
  72         * WebCoreSupport/AssertMatchingEnums.cpp:
  73         * WebCoreSupport/FrameLoaderClientGtk.cpp:
  74         (WebKit::FrameLoaderClient::cancelledError):
  75         (WebKit::FrameLoaderClient::blockedError):
  76         (WebKit::FrameLoaderClient::cannotShowURLError):
  77         (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
  78         (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
  79         (WebKit::FrameLoaderClient::fileDoesNotExistError):
  80         (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
  81         * webkit/webkiterror.cpp:
  82         (webkit_network_error_quark):
  83         (webkit_policy_error_quark):
  84         (webkit_plugin_error_quark):
  85
  86 2011-09-20  Philippe Normand  <pnormand@igalia.com>
  87
  88         [GTK] Update NEWS and configure.ac for 1.5.90 release
  89
  90         Reviewed by Martin Robinson.
  91
  92         * NEWS:
  93
  94 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
  95
  96         GTK DRT leaks memory while comparing history items
  97         https://bugs.webkit.org/show_bug.cgi?id=68086
  98
  99         Reviewed by Martin Robinson.
 100
 101         webkit_web_history_item_get_target() function returns a g_strdup()'d
 102         string, so it should return "gchar*" instead of "const gchar*".
 103
 104         * webkit/webkitwebhistoryitem.cpp:
 105         (webkit_web_history_item_get_target): Change return type to "gchar*".
 106         * webkit/webkitwebhistoryitemprivate.h: Ditto.
 107
 108 2011-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 109
 110         [GTK] Fix distcheck build
 111         https://bugs.webkit.org/show_bug.cgi?id=68346
 112
 113         Reviewed by Philippe Normand.
 114
 115         * tests/testmimehandling.c: Remove ogg tests, since the behavious
 116         has changed in libsoup (https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8)
 117         (server_callback):
 118         (mime_type_policy_decision_requested_cb):
 119         (main):
 120         * webkit/webkitwebplugin.cpp: Fix introspection annotation.
 121
 122 2011-09-17  Mihai Parparita  <mihaip@chromium.org>
 123
 124         FrameLoaderClient BackForwardList-related methods are unsued
 125         https://bugs.webkit.org/show_bug.cgi?id=68293
 126
 127         Reviewed by Darin Adler.
 128
 129         Remove FrameLoaderClient methods that were added by r51629, since only
 130         the old (since-deleted) Android port needed them.
 131
 132         * WebCoreSupport/FrameLoaderClientGtk.cpp:
 133         * WebCoreSupport/FrameLoaderClientGtk.h:
 134
 135 2011-09-15  Adam Barth  <abarth@webkit.org>
 136
 137         Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
 138         https://bugs.webkit.org/show_bug.cgi?id=68205
 139
 140         Reviewed by Eric Seidel.
 141
 142         * WebCoreSupport/ChromeClientGtk.cpp:
 143         * WebCoreSupport/ChromeClientGtk.h:
 144         * webkit/webkitsecurityorigin.cpp:
 145         (webkit_security_origin_get_web_database_usage):
 146         (webkit_security_origin_get_web_database_quota):
 147         (webkit_security_origin_set_web_database_quota):
 148         (webkit_security_origin_get_all_web_databases):
 149         * webkit/webkitwebdatabase.cpp:
 150         (webkit_web_database_get_display_name):
 151         (webkit_web_database_get_expected_size):
 152         (webkit_web_database_get_size):
 153         (webkit_web_database_get_filename):
 154         (webkit_web_database_remove):
 155         (webkit_remove_all_web_databases):
 156         (webkit_get_web_database_directory_path):
 157         (webkit_set_web_database_directory_path):
 158         * webkit/webkitwebview.cpp:
 159         (webkit_web_view_update_settings):
 160         (webkit_web_view_settings_notify):
 161
 162 2011-09-10  Adam Barth  <abarth@webkit.org>
 163
 164         Fix build break.
 165
 166         * webkit/webkitwebview.cpp:
 167         (webkit_web_view_get_encoding):
 168
 169 2011-09-09  Fady Samuel  <fsamuel@chromium.org>
 170
 171         Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
 172         https://bugs.webkit.org/show_bug.cgi?id=67250
 173
 174         Reviewed by Simon Fraser.
 175
 176         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
 177         (DumpRenderTreeSupportGtk::scalePageBy):
 178
 179 2011-09-08  Daniel Bates  <dbates@webkit.org>
 180
 181         Fix the GTK build after <http://trac.webkit.org/changeset/94810>
 182         (https://bugs.webkit.org/show_bug.cgi?id=67807).
 183
 184         * webkit/webkitwebview.cpp:
 185         (webkit_web_view_get_encoding): Substitute DocumentWriter::deprecatedFrameEncoding() for
 186         DocumentWriter::encoding().
 187
 188 2011-09-06  Ryosuke Niwa  <rniwa@webkit.org>
 189
 190         Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
 191         https://bugs.webkit.org/show_bug.cgi?id=67569
 192
 193         Reviewed by Antonio Gomes.
 194
 195         * WebCoreSupport/EditorClientGtk.cpp:
 196         (WebKit::EditorClient::respondToChangedSelection):
 197
 198 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
 199
 200         Unreviewed, rolling out r94142, r94144, r94145, and r94148.
 201         http://trac.webkit.org/changeset/94142
 202         http://trac.webkit.org/changeset/94144
 203         http://trac.webkit.org/changeset/94145
 204         http://trac.webkit.org/changeset/94148
 205         https://bugs.webkit.org/show_bug.cgi?id=67262
 206
 207         Broke isindex element (Requested by rniwa on #webkit).
 208
 209         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
 210         (DumpRenderTreeSupportGtk::setAutofilled):
 211         (DumpRenderTreeSupportGtk::setValueForUser):
 212
 213 2011-08-30  Ryosuke Niwa  <rniwa@webkit.org>
 214
 215         GTK build fix after r94142.
 216
 217         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
 218         (DumpRenderTreeSupportGtk::setAutofilled):
 219         (DumpRenderTreeSupportGtk::setValueForUser):
 220
 221 2011-08-30  Kaustubh Atrawalkar  <kaustubh@motorola.com>
 222
 223         The unused ScrollView* argument can and should be removed from
 224         scrollRectIntoView.
 225         https://bugs.webkit.org/show_bug.cgi?id=67117
 226
 227         Reviewed by Darin Adler.
 228
 229         * WebCoreSupport/ChromeClientGtk.h:
 230         (WebKit::ChromeClient::scrollRectIntoView):
 231
 232 2011-08-26  Gustavo Noronha Silva  <gns@gnome.org>
 233
 234         Minor style fix in the sample code for WebKitWebFrame.
 235
 236         * webkit/webkitwebframe.cpp:
 237
 238 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
 239
 240         [GTK] Fix compilation problems with deprecations in gtk+
 241         https://bugs.webkit.org/show_bug.cgi?id=66073
 242
 243         Reviewed by Martin Robinson.
 244
 245         * WebCoreSupport/FullscreenVideoController.cpp:
 246         (FullscreenVideoController::createHud): Added gtk_box_new
 247         conditional compilation for gtk+-3.
 248
 249 2011-08-18  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 250
 251         [GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
 252         https://bugs.webkit.org/show_bug.cgi?id=66243
 253
 254         Reviewed by Martin Robinson.
 255
 256         The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
 257         call it only when the "load-status" change.
 258
 259         This change is important in the context of bug 28851, which aims to change the
 260         order in which "progress finished" and "load finished" callbacks are called. In
 261         this new scenario, at the progress callback the load will never be finished.
 262
 263         * tests/testwebview.c:
 264         (test_webkit_web_view_grab_focus):
 265
 266 2011-08-17  Adam Roben  <aroben@apple.com>
 267
 268         Make WebCore keep track of the current device scale factor
 269
 270         Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
 271         device scale factor
 272
 273         Reviewed by Darin Adler.
 274
 275         * WebCoreSupport/ChromeClientGtk.cpp:
 276         * WebCoreSupport/ChromeClientGtk.h:
 277         Removed deviceScaleFactor.
 278
 279 2011-08-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 280
 281         Add javascriptcoregtk to the introspection build, to fix it.
 282
 283         Reviewed by Xan Lopez.
 284
 285         * GNUmakefile.am:
 286
 287 2011-08-15  Dmitry Titov  <dimich@chromium.org>
 288
 289         FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
 290         https://bugs.webkit.org/show_bug.cgi?id=66165
 291
 292         Reviewed by Darin Fisher.
 293
 294         * WebCoreSupport/FrameLoaderClientGtk.cpp:
 295         (WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
 296         * WebCoreSupport/FrameLoaderClientGtk.h:
 297
 298 2011-08-10  Adam Roben  <aroben@apple.com>
 299
 300         Clear up scale factor terminology
 301
 302         WebKit by and large deals with two scale factors: one intrinsic to the device on which the
 303         software is running, and one that is per-Page and can be controlled via API calls. This
 304         patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
 305         code use those names. It should introduce no behavior changes.
 306
 307         Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
 308         device scale factor
 309
 310         Reviewed by Simon Fraser.
 311
 312         * WebCoreSupport/ChromeClientGtk.cpp:
 313         * WebCoreSupport/ChromeClientGtk.h:
 314
 315 2011-08-11  Gustavo Noronha Silva  <gns@gnome.org>
 316
 317         Add the javascript core dynamic library for gtk-doc's introspection helper.
 318
 319         Reviewed by Xan Lopez.
 320
 321         * docs/GNUmakefile.am:
 322
 323 2011-08-11  Xan Lopez  <xlopez@igalia.com>
 324
 325         [GTK] Update NEWS and configure.ac for 1.5.2 release
 326
 327         Reviewed by Gustavo Noronha.
 328
 329         * NEWS: update for release.
 330
 331 2011-08-10  Gustavo Noronha Silva  <gns@gnome.org>
 332
 333         [GTK] wrong annotation for the return value of webkit_web_view_get_hit_test_results()
 334         https://bugs.webkit.org/show_bug.cgi?id=65985
 335
 336         Reviewed by Xan Lopez.
 337
 338         * webkit/webkitwebview.cpp:
 339
 340 2011-08-03  Pavel Feldman  <pfeldman@google.com>
 341
 342         Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
 343         https://bugs.webkit.org/show_bug.cgi?id=65510
 344
 345         Reviewed by Yury Semikhatsky.
 346
 347         * webkit/webkitwebview.cpp:
 348         (paintWebView):
 349
 350 2011-08-03  Pavel Feldman  <pfeldman@chromium.org>
 351
 352         Web Inspector: remove Node parameter from the InspectorClient::highlight
 353         https://bugs.webkit.org/show_bug.cgi?id=65549
 354
 355         Reviewed by Yury Semikhatsky.
 356
 357         * WebCoreSupport/InspectorClientGtk.cpp:
 358         (WebKit::InspectorClient::highlight):
 359         * WebCoreSupport/InspectorClientGtk.h:
 360
 361 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 362
 363         [GTK] Reorganize pkg-config files
 364         https://bugs.webkit.org/show_bug.cgi?id=65548
 365
 366         Reviewed by Martin Robinson.
 367
 368         * GNUmakefile.am: Remove javascriptcore pc file references.
 369
 370 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
 371
 372         Remove inclusion of MainThread.h from Threading.h
 373         https://bugs.webkit.org/show_bug.cgi?id=65081
 374
 375         Reviewed by Darin Adler.
 376
 377         Add missing include statements for MainThread.
 378
 379         * webkit/webkitglobals.cpp:
 380
 381 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
 382
 383         Add support for download='filename' attribute in anchors.
 384         https://bugs.webkit.org/show_bug.cgi?id=64580
 385
 386         Reviewed by Adam Barth.
 387
 388         * WebCoreSupport/FrameLoaderClientGtk.cpp:
 389         (WebKit::FrameLoaderClient::startDownload):
 390         * WebCoreSupport/FrameLoaderClientGtk.h:
 391
 392 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 393
 394         [GTK] Remove header webkitwebviewcommon.h
 395         https://bugs.webkit.org/show_bug.cgi?id=65177
 396
 397         Reviewed by Martin Robinson.
 398
 399         Move webkitwebviewcommon.h contents back to webkitwebview.h.
 400
 401         * GNUmakefile.am: Remove webkitwebviewcommon.h
 402         * webkit/webkitwebview.h:
 403         * webkit/webkitwebviewcommon.h: Removed.
 404
 405 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
 406
 407         Reviewed by Gustavo Noronha Silva.
 408
 409         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
 410         https://bugs.webkit.org/show_bug.cgi?id=62252
 411
 412         Added an undocumented self-scrolling property to WebKitWebView which
 413         communicates to WebCore whether or not this widget is expected to draw
 414         its own main frame scrollbars or not.
 415
 416         * webkit/webkitwebview.cpp: Add the self-scrolling property.
 417         * webkit/webkitwebviewprivate.h: Add the selfScrolling private member.
 418
 419 2011-07-11  Gustavo Noronha Silva  <gns@gnome.org>
 420
 421         [GTK] Google Calendar thinks we're mobile
 422         https://bugs.webkit.org/show_bug.cgi?id=63994
 423
 424         Reviewed by Xan Lopez.
 425
 426         Further special-case Google Calendar, for it thinks WebKit+Linux
 427         means mobile, so we also have to spoof the OS.
 428
 429         * WebCoreSupport/FrameLoaderClientGtk.cpp:
 430         (WebKit::FrameLoaderClient::userAgent): use the new WebKitGTK+
 431         private API that centralizes the logic now.
 432         * tests/testwebsettings.c: Add tests to make sure the Google
 433         special-cases only apply for the expected domains and when quirks
 434         special-casing is enabled.
 435         (test_non_quirky_user_agents):
 436         (test_webkit_web_settings_user_agent):
 437         * webkit/webkitwebsettings.cpp:
 438         (webkitUserAgent): make it static.
 439         (safariUserAgent): returns a fake Safari in Mac OS X User-Agent.
 440         (initializeDomainsList): moved from FrameLoaderClientGtk.
 441         (isGoogleDomain):ditto.
 442         (isGoogleCalendar): ditto.
 443         (userAgentForURL): ditto.
 444         (webkitWebSettingsUserAgentForUri): centralize the whole
 445         user agent spoofing logic in this new private API that can be used
 446         by the browser to know what's going to happen for a specific URI
 447         and also allows our API testing.
 448         * webkit/webkitwebsettingsprivate.h:
 449
 450 2011-07-15  Dan Bernstein  <mitz@apple.com>
 451
 452         REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
 453         https://bugs.webkit.org/show_bug.cgi?id=64615
 454
 455         Reviewed by Anders Carlsson.
 456
 457         * WebCoreSupport/ChromeClientGtk.cpp:
 458         (WebKit::ChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
 459         * WebCoreSupport/ChromeClientGtk.h:
 460
 461 2011-07-15  Martin Robinson  <mrobinson@igalia.com>
 462
 463         Build fixes for WebKit2. Ensure that all generated sources are
 464         on nodist primaries, that they are on forward declared variables
 465         so that BUILT_SOURCES is calculated properly and that zlib is
 466         included during linking (for WOFF support).
 467
 468         * GNUmakefile.am:
 469
 470 2011-07-14  Lukasz Slachciak  <l.slachciak@samsung.com>
 471
 472         Reviewed by Gustavo Noronha.
 473
 474         [GTK] Fix GTK unit tests failures when WebKit is build outside repository directory.
 475         https://bugs.webkit.org/show_bug.cgi?id=62935
 476
 477         WebKit can be build with WEBKITOUTPUTDIR env variable set using build-webkit script.
 478         In this case WEBKITOUTPUDIR may be outside repository structure. This causes testmimehandling and testwebview
 479         to fail because they use external test files in WebKit Source directory.
 480         This bug fixes this issue introducing optional environment variable WEBKITREPODIR
 481         Also coding style in existing functions is fixed.
 482
 483
 484         * tests/test_utils.c: Coding style fixes.
 485         (testutils_relative_chdir): If WEBKITREPODIR is set, change current directory to it.
 486         * tests/test_utils.h: Coding style fixes.
 487
 488 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
 489
 490         ApplicationCache update should not immediately fail when reaching per-origin quota
 491         https://bugs.webkit.org/show_bug.cgi?id=64177
 492
 493         Reviewed by Alexey Proskuryakov.
 494
 495         * WebCoreSupport/ChromeClientGtk.cpp:
 496         (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
 497         * WebCoreSupport/ChromeClientGtk.h:
 498
 499 2011-06-14  Mike Stegeman  <mrstegeman@gmail.com>
 500
 501         Add API to WebKit-GTK to allow setting localStorage database path
 502         https://bugs.webkit.org/show_bug.cgi?id=62091
 503
 504         Reviewed by Martin Robinson and Gustavo Noronha.
 505
 506         Expose the path of the localStorage databases through a setting
 507         to allow HTML5 localStorage to be persistent. New setting is:
 508         html5-local-storage-database-path
 509
 510         * webkit/webkitwebsettings.cpp:
 511         (webkit_web_settings_class_init):
 512         (webkit_web_settings_set_property):
 513         (webkit_web_settings_get_property):
 514         * webkit/webkitwebsettingsprivate.h:
 515         * webkit/webkitwebview.cpp:
 516         (webkit_web_view_update_settings):
 517         (webkit_web_view_settings_notify):
 518
 519 2011-07-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
 520
 521         [GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
 522         https://bugs.webkit.org/show_bug.cgi?id=64159
 523
 524         Rework the icon-uri change test so that the condition for quitting
 525         the mainloop is the icon-uri change itself, along with a timeout
 526         to avoid taking too long in case of failure. Since the conditions
 527         for considering a page loaded were changed we can't rely on that
 528         for this test anymore.
 529
 530         Reviewed by Xan Lopez.
 531
 532         * tests/testwebview.c:
 533         (timeout_cb): error out if it takes too long for the icon-uri
 534         change to happen.
 535         (icon_uri_changed_cb): quit the loop here instead of waiting on
 536         the page being loaded.
 537         (test_webkit_web_view_icon_uri):
 538
 539 2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
 540
 541         Reviewed by Martin Robinson.
 542
 543         [GTK] Add DeviceOrientation feature
 544         https://bugs.webkit.org/show_bug.cgi?id=63720
 545
 546         Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
 547
 548         * GNUmakefile.am:
 549         * WebCoreSupport/DeviceMotionClientGtk.cpp: Added.
 550         (WebCore::DeviceMotionClientGtk::DeviceMotionClientGtk):
 551         (WebCore::DeviceMotionClientGtk::~DeviceMotionClientGtk):
 552         (WebCore::DeviceMotionClientGtk::deviceMotionControllerDestroyed):
 553         (WebCore::DeviceMotionClientGtk::setController):
 554         (WebCore::DeviceMotionClientGtk::startUpdating):
 555         (WebCore::DeviceMotionClientGtk::stopUpdating):
 556         (WebCore::DeviceMotionClientGtk::currentDeviceMotion):
 557         * WebCoreSupport/DeviceMotionClientGtk.h: Added.
 558         * WebCoreSupport/DeviceOrientationClientGtk.cpp: Added.
 559         (WebCore::DeviceOrientationClientGtk::DeviceOrientationClientGtk):
 560         (WebCore::DeviceOrientationClientGtk::~DeviceOrientationClientGtk):
 561         (WebCore::DeviceOrientationClientGtk::deviceOrientationControllerDestroyed):
 562         (WebCore::DeviceOrientationClientGtk::setController):
 563         (WebCore::DeviceOrientationClientGtk::startUpdating):
 564         (WebCore::DeviceOrientationClientGtk::stopUpdating):
 565         (WebCore::DeviceOrientationClientGtk::lastOrientation):
 566         * WebCoreSupport/DeviceOrientationClientGtk.h: Added.
 567         * webkit/webkitwebview.cpp:
 568         (webkit_web_view_init):
 569
 570 2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>
 571
 572         Reviewed by Martin Robinson.
 573
 574         [GTK] Allow to build WebKitGtk+ with accelerated compositing
 575         https://bugs.webkit.org/show_bug.cgi?id=63404
 576
 577         WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
 578         and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.
 579
 580         * WebCoreSupport/ChromeClientGtk.cpp:
 581         (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet.
 582         (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto.
 583         (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
 584         (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
 585         * WebCoreSupport/ChromeClientGtk.h:
 586
 587 2011-06-27  ChangSeok Oh  <shivamidow@gmail.com>
 588
 589         Reviewed by Martin Robinson.
 590
 591         [GTK] Fix build break to support webgl
 592         https://bugs.webkit.org/show_bug.cgi?id=63425
 593
 594         A member variable enableWebGL in WebKitWebSettingsPrivate is changed to enableWebgl
 595
 596         * webkit/webkitwebview.cpp:
 597         (webkit_web_view_update_settings):
 598
 599 2011-06-24  Dominic Cooney  <dominicc@chromium.org>
 600
 601         Reviewed by Dimitri Glazkov.
 602
 603         Convert shadow DOM-related tests to use window.internals
 604         https://bugs.webkit.org/show_bug.cgi?id=61671
 605
 606         Remove shadow-DOM related methods from GTK DRT API. These are not
 607         required any more.
 608
 609         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
 610         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
 611
 612 2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
 613
 614         Reviewed by Kent Tamura.
 615
 616         FileChooser should be only created when we need to choose files.
 617         https://bugs.webkit.org/show_bug.cgi?id=63039
 618
 619         * WebCoreSupport/ChromeClientGtk.cpp:
 620         (WebKit::ChromeClient::runOpenPanel): Changed to use settings.
 621
 622 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 623
 624         Reviewed by Xan Lopez.
 625
 626         [GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
 627         https://bugs.webkit.org/show_bug.cgi?id=63124
 628
 629         Fixes a crash when building with --enable-debug.
 630
 631         * webkit/webkitsoupauthdialog.h: Define
 632         LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY
 633         before including libsoup.h.
 634
 635 2011-06-10  Martin Robinson  <mrobinson@igalia.com>
 636
 637         Reviewed by Xan Lopez.
 638
 639         [GTK] webkit_web_settings_copy does not copy all settings
 640         https://bugs.webkit.org/show_bug.cgi?id=62424
 641
 642         Instead of trying to keep webkit_web_settings_copy up to date with
 643         property additions, create the object copy by dynamically initializing
 644         all webkit_web_settings properties at once.
 645
 646         * tests/testwebsettings.c:
 647         (test_webkit_web_settings_copy): Create a test for webkit_web_settings copy.
 648         (main): Run the new test.
 649         * webkit/webkitwebsettings.cpp:
 650         (webkit_web_settings_copy): Dynamically initialize all properties of the copy.
 651
 652 2011-06-20  Martin Robinson  <mrobinson@igalia.com>
 653
 654         Reviewed by Eric Seidel.
 655
 656         [GTK] Clean up unecessary boilerplate from WebKitWebSettings and make private members meet WebKit style guidelines
 657         https://bugs.webkit.org/show_bug.cgi?id=61972
 658
 659         Rename all private members of WebKitWebSettings to meet WebKit style guidelines and
 660         put the private struct definition in webkitwebsettingsprivate.h so it can be
 661         accessed from webkitwebview.cpp. This cuts down on the boilerplate immensely.
 662
 663         * webkit/webkitwebsettings.cpp: Rename private members to meet WebKit style guidelines
 664         and allocate the private section with new/delete. This allows for using CString and removes
 665         the need for manual string memory management.
 666         * webkit/webkitwebsettingsprivate.h: Move the private struct definition here.
 667         * webkit/webkitwebview.cpp: Update to reflect new struct names. Remove boilerplate
 668         and other very small code cleanups.
 669
 670 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 671
 672         Reviewed by Xan Lopez.
 673
 674         [GTK] Split libWebCore into two libWebCore and libWebCoreGtk
 675         https://bugs.webkit.org/show_bug.cgi?id=60539
 676
 677         * GNUmakefile.am: Link to libWebCoreGtk.la too.
 678
 679 2011-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
 680
 681         Reviewed by Darin Adler.
 682
 683         Separate concerns of loading file icons and choosing files.
 684         https://bugs.webkit.org/show_bug.cgi?id=62931
 685
 686         * WebCoreSupport/ChromeClientGtk.cpp:
 687         (WebKit::ChromeClient::loadIconForFiles): Renamed.
 688         * WebCoreSupport/ChromeClientGtk.h:
 689
 690 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
 691
 692         Reviewed by Martin Robinson.
 693
 694         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
 695         https://bugs.webkit.org/show_bug.cgi?id=60687
 696
 697         Replace GdkRectangle by cairo_rectangle_int_t.
 698
 699         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
 700         (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
 701         (DumpRenderTreeSupportGtk::rectangleForSelection):
 702         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.
 703
 704 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
 705
 706         Unreviewed, rolling out r89026.
 707         http://trac.webkit.org/changeset/89026
 708         https://bugs.webkit.org/show_bug.cgi?id=62804
 709
 710         These patches were likely correct.  I'll investigate the
 711         browser_test failures. (Requested by abarth on #webkit).
 712
 713         * WebCoreSupport/FullscreenVideoController.cpp:
 714         (FullscreenVideoController::play):
 715         (FullscreenVideoController::pause):
 716
 717 2011-06-16  Vitaly Repeshko  <vitalyr@chromium.org>
 718
 719         Unreviewed.
 720
 721         Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
 722         https://bugs.webkit.org/show_bug.cgi?id=62796
 723
 724         The patches broke chromium browser tests.
 725 2011-06-16  Adam Barth  <abarth@webkit.org>
 726
 727         Reviewed by Eric Seidel.
 728
 729         Remove HTMLVideoElement::processingUserGesture
 730         https://bugs.webkit.org/show_bug.cgi?id=62784
 731
 732         * WebCoreSupport/FullscreenVideoController.cpp:
 733         (FullscreenVideoController::play):
 734         (FullscreenVideoController::pause):
 735
 736 2011-06-15  Claudio Saavedra  <csaavedra@igalia.com>
 737
 738         Reviewed by Xan Lopez.
 739
 740         [GTK] Fix the build with introspection enabled
 741         https://bugs.webkit.org/show_bug.cgi?id=62705
 742
 743         * GNUmakefile.am: Remove include of *.c files, since
 744         there are no such files anymore.
 745
 746 2011-06-14  Xan Lopez  <xlopez@igalia.com>
 747
 748         Reviewed by Martin Robinson.
 749
 750         [GTK] Remove G_CONST_RETURN usage
 751         https://bugs.webkit.org/show_bug.cgi?id=62673
 752
 753         Change G_CONST_RETURN for a simple "const" throughout the
 754         codebase, since G_CONST_RETURN is deprecated now. This should be
 755         totally equivalent since for all practical purposes the macro is
 756         always expanded to const.
 757
 758         * webkit/webkitapplicationcache.cpp:
 759         (webkit_application_cache_get_database_directory_path): use const
 760         instead of G_CONST_RETURN.
 761         * webkit/webkitapplicationcache.h:
 762         * webkit/webkiticondatabase.cpp:
 763         (webkit_icon_database_get_path): ditto.
 764         * webkit/webkiticondatabase.h:
 765         * webkit/webkitnetworkrequest.cpp:
 766         (webkit_network_request_get_uri): ditto.
 767         * webkit/webkitnetworkrequest.h:
 768         * webkit/webkitnetworkresponse.cpp:
 769         (webkit_network_response_get_uri): ditto.
 770         * webkit/webkitnetworkresponse.h:
 771         * webkit/webkitsecurityorigin.cpp:
 772         (webkit_security_origin_get_protocol): ditto.
 773         (webkit_security_origin_get_host): ditto.
 774         * webkit/webkitsecurityorigin.h:
 775         * webkit/webkitwebdatabase.cpp:
 776         (webkit_web_database_get_name): ditto.
 777         (webkit_web_database_get_display_name): ditto.
 778         (webkit_web_database_get_filename): ditto.
 779         (webkit_get_web_database_directory_path): ditto.
 780         * webkit/webkitwebdatabase.h:
 781         * webkit/webkitwebdatasource.cpp:
 782         (webkit_web_data_source_get_encoding): ditto.
 783         (webkit_web_data_source_get_unreachable_uri): ditto.
 784         * webkit/webkitwebdatasource.h:
 785         * webkit/webkitwebframe.cpp:
 786         (webkit_web_frame_get_title): ditto.
 787         (webkit_web_frame_get_uri): ditto.
 788         (webkit_web_frame_get_name): ditto.
 789         * webkit/webkitwebframe.h:
 790         * webkit/webkitwebhistoryitem.cpp:
 791         (webkit_web_history_item_get_title): ditto.
 792         (webkit_web_history_item_get_alternate_title): ditto.
 793         (webkit_web_history_item_get_uri): ditto.
 794         (webkit_web_history_item_get_original_uri): ditto.
 795         (webkit_web_history_item_get_target): ditto.
 796         * webkit/webkitwebhistoryitem.h:
 797         * webkit/webkitwebhistoryitemprivate.h:
 798         * webkit/webkitwebnavigationaction.cpp:
 799         (webkit_web_navigation_action_get_target_frame): ditto.
 800         * webkit/webkitwebnavigationaction.h:
 801         * webkit/webkitwebresource.cpp:
 802         (webkit_web_resource_get_uri): ditto.
 803         (webkit_web_resource_get_mime_type): ditto.
 804         (webkit_web_resource_get_encoding): ditto.
 805         (webkit_web_resource_get_frame_name): ditto.
 806         * webkit/webkitwebresource.h:
 807         * webkit/webkitwebsettings.cpp:
 808         (webkit_web_settings_get_user_agent): ditto.
 809         * webkit/webkitwebsettings.h:
 810         * webkit/webkitwebview.cpp:
 811         (webkit_web_view_get_title): ditto.
 812         (webkit_web_view_get_uri): ditto.
 813         (webkit_web_view_get_icon_uri): ditto.
 814         * webkit/webkitwebview.h:
 815         * webkit/webkitwebviewcommon.h:
 816
 817 2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 818
 819         Reviewed by Martin Robinson.
 820
 821         [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
 822         https://bugs.webkit.org/show_bug.cgi?id=62626
 823
 824         * WebCoreSupport/ChromeClientGtk.cpp:
 825         (WebKit::ChromeClient::windowToScreen): Update to use
 826         convertWidgetPointToScreenPoint()
 827         (WebKit::ChromeClient::screenToWindow): Ditto.
 828         * webkit/webkitwebview.cpp: Remove globalPointForClientPoint()
 829         since it does the same than convertWidgetPointToScreenPoint().
 830         (webkit_web_view_popup_menu_handler): Use
 831         convertWidgetPointToScreenPoint() instead of globalPointForClientPoint().
 832         (doDragLeaveLater): Ditto.
 833         (webkit_web_view_drag_motion): Ditto.
 834         (webkit_web_view_drag_data_received): Ditto.
 835         (webkit_web_view_drag_drop): Ditto.
 836
 837 2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
 838
 839         Reviewed by Martin Robinson.
 840
 841         [GTK] Support authentication dialogs in WebKit2
 842         https://bugs.webkit.org/show_bug.cgi?id=62366
 843
 844         Move the common code of webkitsoupauthdialog to a common C++ class
 845         in WebCore so that it can be used by WebKit2 too. The file has
 846         been converted into a C++ file.
 847
 848         * GNUmakefile.am: Rename webkitsoupauthdialog.c to
 849         webkitsoupauthdialog.cpp.
 850         * webkit/webkitsoupauthdialog.c: Removed.
 851         * webkit/webkitsoupauthdialog.cpp: Added.
 852         (webkit_soup_auth_dialog_class_init):
 853         (webkit_soup_auth_dialog_init):
 854         (webkit_soup_auth_dialog_session_feature_init):
 855         (sessionAuthenticate): Use GtkAuthenticationDialog object from
 856         WebCore.
 857         (attach):
 858         (detach):
 859         * webkit/webkitsoupauthdialog.h:
 860
 861 2011-06-13  Joone Hur  <joone.hur@collabora.co.uk>
 862
 863         Reviewed by Martin Robinson.
 864
 865         [GTK] Add configure option to enable/disable register protocol handler
 866         https://bugs.webkit.org/show_bug.cgi?id=62534
 867
 868         * WebCoreSupport/ChromeClientGtk.cpp:
 869         (WebKit::ChromeClient::registerProtocolHandler): Added.
 870         * WebCoreSupport/ChromeClientGtk.h: Add the registerProtocolHandler method defintion.
 871
 872 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
 873
 874         Reviewed by Gustavo Noronha Silva.
 875
 876         Update gtkdoc files and inline documentation to reduce gtkdoc errors
 877         and ensure complete documentation output.
 878
 879         * docs/webkitgtk-sections.txt: Add missing sections to the list and remove
 880         unneeded sections.
 881         * docs/webkitgtk.types: Update the types list.
 882         * webkit/webkithittestresult.cpp: Fix inline documentation errors.
 883         (webkit_hit_test_result_class_init): Ditto.
 884         * webkit/webkiticondatabase.cpp: Ditto.
 885         * webkit/webkitwebsettings.cpp: Ditto.
 886         (webkit_web_settings_class_init): Ditto.
 887         * webkit/webkitwebview.cpp: Ditto.
 888         (webkit_web_view_class_init): Ditto.
 889
 890 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
 891
 892         Reviewed by Xan Lopez.
 893
 894         Update the list of ignored GTK+ header files for the documentation
 895         generation.
 896
 897         * docs/GNUmakefile.am: Update ignored header list.
 898
 899 2011-06-13  Xan Lopez  <xlopez@igalia.com>
 900
 901         Reviewed by Martin Robinson.
 902
 903         Update NEWS for 1.5.1 release.
 904
 905         * NEWS: update.
 906
 907 2011-06-13  Xan Lopez  <xlopez@igalia.com>
 908
 909         Reviewed by Martin Robinson.
 910
 911         Distcheck fixes.
 912
 913         * GNUmakefile.am:
 914
 915 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
 916
 917         Reviewed by Martin Robinson.
 918
 919         [GTK] Export an API similar to WebKit1
 920         https://bugs.webkit.org/show_bug.cgi?id=57820
 921
 922         * GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
 923         * webkit/webkitwebview.h: Move declarations common to WebKit2 to
 924         webkitwebviewcommon.h.
 925         * webkit/webkitwebviewcommon.h: Added.
 926
 927 2011-06-12  Adam Barth  <abarth@webkit.org>
 928
 929         Reviewed by Alexey Proskuryakov.
 930
 931         Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
 932         https://bugs.webkit.org/show_bug.cgi?id=62516
 933
 934         * WebCoreSupport/FrameLoaderClientGtk.cpp:
 935         (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
 936         * WebCoreSupport/FrameLoaderClientGtk.h:
 937
 938 2011-06-12  Xan Lopez  <xlopez@igalia.com>
 939
 940         Reviewed by Martin Robinson.
 941
 942         [GTK] Remove webkit_web_view_get_selected_text
 943         https://bugs.webkit.org/show_bug.cgi?id=62512
 944
 945         It's no longer used and it's a private method, so it can be
 946         removed.
 947
 948         * webkit/webkitwebview.cpp: kill it.
 949         * webkit/webkitwebviewprivate.h: ditto.
 950
 951 2011-06-12  Adam Barth  <abarth@webkit.org>
 952
 953         Reviewed by Alexey Proskuryakov.
 954
 955         Remove trival "forward-to-client" member functions from FrameLoader
 956         https://bugs.webkit.org/show_bug.cgi?id=62510
 957
 958         Update to call the FrameLoaderClient directly.  Also, remove cargo-cult
 959         code that checks whether FrameLoader is null.
 960
 961         * webkit/webkitwebview.cpp:
 962         (webkit_web_view_stop_loading):
 963         (webkit_web_view_can_show_mime_type):
 964
 965 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
 966
 967         Reviewed by Eric Seidel.
 968
 969         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
 970         https://bugs.webkit.org/show_bug.cgi?id=55603
 971
 972         Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.
 973
 974         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
 975         (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and
 976         end. This matches other ports. Only use GLib style early returns when checking the
 977         validity of GObjects.
 978         (DumpRenderTreeSupportGtk::hasComposition):  Added.
 979         (DumpRenderTreeSupportGtk::compositionRange): Added.
 980         (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above.
 981         (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above.
 982         (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
 983         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.
 984
 985 2011-06-08  Xan Lopez  <xlopez@igalia.com>
 986
 987         Reviewed by Martin Robinson.
 988
 989         [GTK] Add WebKitSpellChecker interface and implementations
 990         https://bugs.webkit.org/show_bug.cgi?id=61787
 991
 992         Expose the spell checking functionality to the UAs through a
 993         generic interface, and provide a default Enchant-based
 994         implementation. On top of allowing UAs to use this functionality
 995         this makes it possible to change the spell checking backend at
 996         runtime.
 997
 998         * GNUmakefile.am: add new files.
 999         * WebCoreSupport/EditorClientGtk.cpp:
1000         (WebKit::EditorClient::EditorClient): set the spell checker using
1001         the new classes.
1002         * WebCoreSupport/TextCheckerClientEnchant.cpp: Removed.
1003         * WebCoreSupport/TextCheckerClientGtk.cpp: Added
1004         (WebKit::TextCheckerClientGtk::TextCheckerClientGtk): just
1005         chain up to the WebKitSpellChecker.
1006         (WebKit::TextCheckerClientGtk::~TextCheckerClientGtk): ditto.
1007         (WebKit::TextCheckerClientGtk::ignoreWordInSpellDocument): ditto.
1008         (WebKit::TextCheckerClientGtk::learnWord): ditto.
1009         (WebKit::TextCheckerClientGtk::checkSpellingOfString): ditto.
1010         (WebKit::TextCheckerClientGtk::getAutoCorrectSuggestionForMisspelledWord): ditto.
1011         (WebKit::TextCheckerClientGtk::getGuessesForWord): ditto.
1012         (WebKit::TextCheckerClientGtk::updateSpellCheckingLanguage): ditto.
1013         * WebCoreSupport/TextCheckerClientGtk.h: store a reference to
1014         the WebKitSpellChecker.
1015         * webkit/webkit.h: the webkitspellchecker.h header is public.
1016         * webkit/webkitdefines.h: defines for spell checker interface.
1017         * webkit/webkitglobals.cpp: Add APIs to get and set the global
1018         spell checker.
1019         (webkit_get_spell_checker): get API.
1020         (webkit_set_spell_checker): set API.
1021         * webkit/webkitglobals.h:
1022         * webkit/webkitspellchecker.cpp: Added. Spell checking interface.
1023         * webkit/webkitspellchecker.h: Added.
1024         * webkit/webkitspellcheckerenchant.cpp: Added. Default
1025         implemention, uses Enchant library.
1026         * webkit/webkitspellcheckerenchant.h: Added.
1027
1028 2011-06-07  Xan Lopez  <xlopez@igalia.com>
1029
1030         Reviewed by Martin Robinson.
1031
1032         [GTK] "webkithittestresult.h" is malformed
1033         https://bugs.webkit.org/show_bug.cgi?id=62117
1034
1035         * webkit/webkithittestresult.h: fix typo in GET_CLASS macro.
1036
1037 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1038
1039         Reviewed by Ryosuke Niwa.
1040
1041         [GTK] Support smart replace for the pasteboard
1042         https://bugs.webkit.org/show_bug.cgi?id=61734
1043
1044         Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
1045         smart replace in the tests.
1046
1047         * WebCoreSupport/DragClientGtk.cpp:
1048         (WebKit::DragClient::startDrag): targeListForDataObject now takes another
1049         parameter determining whether or not to add smart paste support. Add it here.
1050         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1051         (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
1052         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
1053         * WebCoreSupport/EditorClientGtk.cpp:
1054         (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation.
1055         (WebKit::EditorClient::smartInsertDeleteEnabled): Added.
1056         (WebKit::EditorClient::EditorClient):
1057         * WebCoreSupport/EditorClientGtk.h: Add new method definition.
1058
1059 2011-06-03  Sergio Villar Senin  <svillar@igalia.com>
1060
1061         Reviewed by Martin Robinson.
1062
1063         [GTK] Unref the SoupSession used by WebKitGtk+ at exit
1064         https://bugs.webkit.org/show_bug.cgi?id=60165
1065
1066         WebKitGtk+ creates a SoupSession instance to handle network stuff
1067         that is never freed. We should unref that object at exit time.
1068
1069         * webkit/webkitglobals.cpp:
1070         (webkitExit):
1071         (webkitInit):
1072
1073 2011-05-28  Martin Robinson  <mrobinson@igalia.com>
1074
1075         Reviewed by Gustavo Noronha Silva.
1076
1077         [GTK] Remove PastboardHelperGtk
1078         https://bugs.webkit.org/show_bug.cgi?id=61690
1079
1080         Remove PasteboardHelperGtk and talk directly to WebCore for pasteboard
1081         activity. This change moves the PasteboardHelper singleton from WebKit
1082         to WebCore.
1083
1084         * GNUmakefile.am: Remove PasteboardHelperGtk from the source list.
1085         * WebCoreSupport/AssertMatchingEnums.cpp: Added assertions verifying that the
1086         WebCore versions of the GtkClipboard enums match those in the WebKit API.
1087         * WebCoreSupport/DragClientGtk.cpp:
1088         (WebKit::DragClient::startDrag): Access the pasteboard helper via a static method.
1089         * WebCoreSupport/EditorClientGtk.cpp:
1090         (WebKit::setSelectionPrimaryClipboardIfNeeded): Ditto. Call into the helper to specify
1091         that the current clipboard is selection primary now.
1092         * WebCoreSupport/PasteboardHelperGtk.cpp: Removed.
1093         * webkit/webkitglobals.cpp: Remove function to set and get the pasteboard helper.
1094         * webkit/webkitglobalsprivate.h: Ditto.
1095         * webkit/webkitwebview.cpp:
1096         (webkit_web_view_button_press_event): Access the pasteboard helper via a static method.
1097         (webkit_web_view_drag_data_get): Ditto.
1098         (webkit_web_view_drag_motion): Ditto.
1099         (webkit_web_view_drag_data_received): Ditto.
1100         (webkit_web_view_init): Ditto.
1101         (webkit_web_view_get_copy_target_list): Ditto.
1102         (webkit_web_view_get_paste_target_list): Ditto.
1103         * webkit/webkitwebviewprivate.h: Ditto.
1104
1105 2011-06-02  Joone Hur  <joone.hur@collabora.co.uk>
1106
1107         Reviewed by Martin Robinson.
1108
1109         [GTK] Only load dictionaries if spell check is enabled
1110         https://bugs.webkit.org/show_bug.cgi?id=32879
1111
1112         We don't need to call enchant if enable-spell-checking is false.
1113
1114         * webkit/webkitwebview.cpp:
1115         (webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false.
1116         (webkit_web_view_settings_notify): Ditto.
1117
1118 2011-06-01  Xan Lopez  <xlopez@igalia.com>
1119
1120         Reviewed by Martin Robinson.
1121
1122         Explictly request the size of a pointer in malloc. Otherwise this
1123         explodes in 64bit architectures, at least.
1124
1125         * webkit/webkitwebplugin.cpp:
1126         (webkit_web_plugin_get_mimetypes): ditto.
1127
1128 2011-06-01  Xan Lopez  <xlopez@igalia.com>
1129
1130         Reviewed by Martin Robinson.
1131
1132         [GTK] Utility methods for UA spellchecking
1133         https://bugs.webkit.org/show_bug.cgi?id=61788
1134
1135         Adds a couple of utility methods needed to implement some aspects
1136         of spell checking support in a browser.
1137
1138         * webkit/webkitwebframe.cpp:
1139         (webkit_web_frame_replace_selection): method to replace the current
1140         selection with a string of text.
1141         (webkit_web_frame_get_range_for_word_around_caret): returns the DOM
1142         range for the word where the caret/selection currently is.
1143         * webkit/webkitwebframe.h: declare new methods.
1144
1145 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
1146
1147         Reviewed by Gustavo Noronha Silva.
1148
1149         [GTK] gtkdoc run produces many warnings about missing declarations
1150         https://bugs.webkit.org/show_bug.cgi?id=61797
1151
1152         * docs/webkitgtk-sections.txt: Remove inexistent symbols from this file
1153         to reduce the number of gtkdoc warnings.
1154
1155 2011-05-31  Xan Lopez  <xlopez@igalia.com>
1156
1157         Reviewed by Martin Robinson.
1158
1159         [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
1160         https://bugs.webkit.org/show_bug.cgi?id=61791
1161
1162         * GNUmakefile.am: add new files.
1163
1164 2011-05-27  Philippe Normand  <pnormand@igalia.com>
1165
1166         Reviewed by Martin Robinson.
1167
1168         [GTK] Data directory is webkitgtk-x.y not webkit-x.y
1169         https://bugs.webkit.org/show_bug.cgi?id=61642
1170
1171         * GNUmakefile.am: updated data directory.
1172
1173 2011-05-28  Adam Barth  <abarth@webkit.org>
1174
1175         Reviewed by Alexey Proskuryakov.
1176
1177         Audit all uses of KURL::prettyURL
1178         https://bugs.webkit.org/show_bug.cgi?id=61201
1179
1180         Update callers of prettyURL to just call string.
1181
1182         * WebCoreSupport/ChromeClientGtk.cpp:
1183         (WebKit::ChromeClient::mouseDidMoveOverElement):
1184         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1185         (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
1186         (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
1187         * webkit/webkitwebview.cpp:
1188         (webkit_web_view_get_icon_uri):
1189
1190 2011-05-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1191
1192         Reviewed by Martin Robinson.
1193
1194         Cleanup postCommitFrameViewSetup parameters which are no longer
1195         necessary after the adjustments handling refactoring.
1196
1197         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1198         (WebKit::postCommitFrameViewSetup):
1199         (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
1200         (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
1201
1202 2011-05-22  Adam Barth  <abarth@webkit.org>
1203
1204         Build fix.  More public destructors needed to play nice with OwnPtr.
1205
1206         * WebCoreSupport/InspectorClientGtk.cpp:
1207
1208 2011-05-22  Adam Barth  <abarth@webkit.org>
1209
1210         Build fix.  InspectorFrontendClient needs a public destructor so that
1211         we can properly track ownership using OwnPtr.
1212
1213         * WebCoreSupport/InspectorClientGtk.h:
1214
1215 2011-05-22  Adam Barth  <abarth@webkit.org>
1216
1217         Strict PassOwnPtr build fix.
1218
1219         * WebCoreSupport/InspectorClientGtk.cpp:
1220         (WebKit::InspectorClient::openInspectorFrontend):
1221         (WebKit::InspectorFrontendClient::InspectorFrontendClient):
1222
1223 2011-05-22  Adam Barth  <abarth@webkit.org>
1224
1225         Strict PassOwnPtr build fix.
1226
1227         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1228         (DumpRenderTreeSupportGtk::addUserStyleSheet):
1229
1230 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1231
1232         Reviewed by Sam Weinig.
1233
1234         numberOfActiveAnimations() can include animations from documents in the page cache
1235         https://bugs.webkit.org/show_bug.cgi?id=53641
1236
1237         Pass the Frame's document as the one to count animations on.
1238
1239         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1240         (DumpRenderTreeSupportGtk::numberOfActiveAnimations):
1241
1242 2011-05-16  Martin Robinson  <mrobinson@igalia.com>
1243
1244         Reviewed by Xan Lopez.
1245
1246         [GTK] Scrolling in Twitter is broken after r86102
1247         https://bugs.webkit.org/show_bug.cgi?id=60922
1248
1249         Fix adjustment handling for pages that trigger the slow scrolling path.
1250         The slow scrolling path is triggered by WebCore when it determines that
1251         doing a simple invalidation is quicker than doing a normal scroll. This
1252         typically happens when there are large elements with fixed positions.
1253
1254         * WebCoreSupport/ChromeClientGtk.cpp:
1255         (WebKit::ChromeClient::invalidateContentsForSlowScroll): Poke the adjustment
1256         watcher to update its adjustments when a page triggers the slow scrolling path.
1257
1258 2011-05-13  Jon Lee  <jonlee@apple.com>
1259
1260         Reviewed by Simon Fraser.
1261
1262         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1263         https://bugs.webkit.org/show_bug.cgi?id=60779
1264
1265         * WebCoreSupport/ChromeClientGtk.h:
1266         (WebKit::ChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
1267         (WebKit::ChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
1268
1269 2011-05-13  Sam Weinig  <sam@webkit.org>
1270
1271         Reviewed by Anders Carlsson.
1272
1273         Prune #includes from FrameView.h (Part 2)
1274         https://bugs.webkit.org/show_bug.cgi?id=60748
1275
1276         - Update files that were depending on FrameView.h #including Frame.h or
1277           Page.h.
1278
1279         * WebCoreSupport/GtkAdjustmentWatcher.cpp:
1280
1281 2011-05-13  Martin Robinson  <mrobinson@igalia.com>
1282
1283         Reviewed by Eric Seidel.
1284
1285         [GTK] Share the GTK+ key binding code between WebKit1 and WebKit2
1286         https://bugs.webkit.org/show_bug.cgi?id=59765
1287
1288         Use the new KeyBindingTranslator class from WebCore/platform/gtk. With this utility
1289         class we can now share the code with WebKit2.
1290
1291         * WebCoreSupport/EditorClientGtk.cpp:
1292         (WebKit::EditorClient::executePendingEditorCommands): Updated to reflect the fact that
1293         the command vector now contains WTF::string.
1294         (WebKit::EditorClient::handleKeyboardEvent): Use the new helper utility class.
1295         (WebKit::EditorClient::EditorClient):
1296         * WebCoreSupport/EditorClientGtk.h: Remove unnecessary member. Add the utility class.
1297
1298 2011-05-12  Martin Robinson  <mrobinson@igalia.com>
1299
1300         Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
1301         bot which appears to be more sensitive to timing issues than the
1302         other bots.
1303
1304         * tests/testwebview.c: Add another short pause waiting for adjustments to update.
1305
1306 2011-05-09  Martin Robinson  <mrobinson@igalia.com>
1307
1308         Fix a test after r86102. Scrollbars update asynchronously, so we
1309         must check the adjustments after a short delay.
1310
1311         * tests/testwebview.c:
1312         (quit_after_short_delay_cb): Add a short delay before checking adjustments.
1313         (test_webkit_web_view_grab_focus): Ditto.
1314
1315 2011-05-09  Xan Lopez  <xlopez@igalia.com>
1316
1317         Unreviewed build fix.
1318
1319         Fix build, for real.
1320
1321         * webkit/webkitwebview.cpp:
1322         (getHorizontalAdjustment):
1323
1324 2011-05-09  Xan Lopez  <xlopez@igalia.com>
1325
1326         Unreviewed build fix..
1327
1328         Fix GTK+3.x build.
1329
1330         * webkit/webkitwebview.cpp:
1331         (getHorizontalAdjustment): the adjustment is in
1332         adjustmentWatcher() now.
1333         (getVerticalAdjustment): ditto.
1334
1335 2011-04-29  Martin Robinson  <mrobinson@igalia.com>
1336
1337         Reviewed by Gustavo Noronha Silva.
1338
1339         [GTK] Untangle GtkAdjustments from WebCore
1340         https://bugs.webkit.org/show_bug.cgi?id=59821
1341
1342         Have ChromeClient manage the GtkAdjustments of the parent widget instead of passing
1343         them to WebCore to manage. This simplifies the code quite a bit and should be less
1344         crash prone in the future.
1345
1346         * GNUmakefile.am: Added new GtkAdjustmentWatcher class to the sources list.
1347         * WebCoreSupport/ChromeClientGtk.cpp: Added new GtkAdjustmentWatcher member.
1348         (WebKit::ChromeClient::ChromeClient) Initialize the new member.
1349         (WebKit::ChromeClient::scroll): Poke the adjustment watcher to update the adjustments.
1350         (WebKit::ChromeClient::contentsSizeChanged): Ditto.
1351         (WebKit::ChromeClient::scrollbarsModeDidChange): This may now be called at a time when there
1352         is no main frame, so do an early return in that case.
1353         * WebCoreSupport/ChromeClientGtk.h: Add the new member.
1354         (WebKit::ChromeClient::adjustmentWatcher): Add this getter for WebKitWebView.
1355         * WebCoreSupport/FrameLoaderClientGtk.cpp: Remove calls which pushed the adjustments into
1356         WebCore.
1357         (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
1358         (WebKit::postCommitFrameViewSetup):
1359         * WebCoreSupport/GtkAdjustmentWatcher.cpp: Added.
1360         (WebKit::GtkAdjustmentWatcher::GtkAdjustmentWatcher):
1361         (WebKit::updateAdjustmentFromScrollbar):
1362         (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbars):
1363         (WebKit::updateAdjustmentCallback):
1364         (WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
1365         (WebKit::adjustmentValueChangedCallback):
1366         (WebKit::setAdjustment):
1367         (WebKit::GtkAdjustmentWatcher::setHorizontalAdjustment):
1368         (WebKit::GtkAdjustmentWatcher::setVerticalAdjustment):
1369         (WebKit::GtkAdjustmentWatcher::adjustmentValueChanged):
1370         * WebCoreSupport/GtkAdjustmentWatcher.h: Added.
1371         (WebKit::GtkAdjustmentWatcher::horizontalAdjustment):
1372         (WebKit::GtkAdjustmentWatcher::verticalAdjustment):
1373         * webkit/webkitwebview.cpp:
1374         (setHorizontalAdjustment):
1375         (setVerticalAdjustment): Remove the adjustment member. Call into the adjustment watcher.
1376         (getHorizontalAdjustment): Ditto.
1377         (getVerticalAdjustment): Ditto.
1378         (webkit_web_view_size_allocate): Ditto.
1379         (webkit_web_view_set_scroll_adjustments): Ditto.
1380         (webkit_web_view_dispose): Ditto.
1381         (webkit_web_view_init): Ditto.
1382         * webkit/webkitwebviewprivate.h: Ditto.
1383
1384 2011-05-06  Kent Tamura  <tkent@chromium.org>
1385
1386         Reviewed by Ryosuke Niwa.
1387
1388         Eliminate WebCore/dom/InputElement.{cpp,h}
1389         https://bugs.webkit.org/show_bug.cgi?id=60262
1390
1391         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1392         (DumpRenderTreeSupportGtk::setAutofilled):
1393           Follow the return type change of Node::toInputElement().
1394         (DumpRenderTreeSupportGtk::setValueForUser): ditto.
1395
1396 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
1397
1398         Reviewed by Xan Lopez.
1399
1400         [GTK] [WebKit2] WebView::windowToScreen needs an implementation
1401         https://bugs.webkit.org/show_bug.cgi?id=55960
1402
1403         Abstract the code to translate from widget space to screen space into
1404         a helper method in WebCore.
1405
1406         * WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities.
1407         (WebKit::ChromeClient::windowToScreen):
1408         (WebKit::ChromeClient::screenToWindow):
1409
1410 2011-05-04  Philippe Normand  <pnormand@igalia.com>
1411
1412         Reviewed by Dimitri Glazkov.
1413
1414         Implement LayoutTestController::pseudoShadowId()
1415         https://bugs.webkit.org/show_bug.cgi?id=60034
1416
1417         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1418         (DumpRenderTreeSupportGtk::shadowPseudoId):
1419         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1420
1421 2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>
1422
1423         Reviewed by Holger Freyther.
1424
1425         Fix build-webkit --minimal.
1426         https://bugs.webkit.org/show_bug.cgi?id=60257
1427
1428         * webkit/webkitglobals.cpp:
1429         (webkitInit):
1430
1431 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
1432
1433         Reviewed by Eric Seidel.
1434
1435         Rename SelectionController to FrameSelection
1436         https://bugs.webkit.org/show_bug.cgi?id=60234
1437
1438         * webkit/webkitwebview.cpp:
1439         (getLocationForKeyboardGeneratedContextMenu):
1440
1441 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
1442
1443         GTK build fix attempt after r85823
1444
1445         * WebCoreSupport/ChromeClientGtk.h:
1446         (WebKit::ChromeClient::webView):
1447         * WebCoreSupport/EditorClientGtk.cpp:
1448         (WebKit::imContextCommitted):
1449         (WebKit::imContextPreeditChanged):
1450         * webkit/webkitwebview.cpp:
1451         (WebKit::kit):
1452
1453 2011-05-04  Cris Neckar  <cdn@chromium.org>
1454
1455         Reviewed by Adam Barth.
1456
1457         Expose WebView directly through ChromeClient.
1458         https://bugs.webkit.org/show_bug.cgi?id=49902
1459
1460         * WebCoreSupport/ChromeClientGtk.h:
1461         (WebKit::ChromeClient::webView):
1462
1463 2011-05-04  Tao Bai  <michaelbai@chromium.org>
1464
1465         Reviewed by David Kilzer.
1466
1467         Populate touch-icon url to FrameLoaderClient
1468         https://bugs.webkit.org/show_bug.cgi?id=59143
1469
1470         Respect the interface change in FrameLoaderClient.
1471
1472         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1473         (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
1474         * WebCoreSupport/FrameLoaderClientGtk.h:
1475
1476 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
1477
1478         Reviewed by Dimitri Glazkov.
1479
1480         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
1481         https://bugs.webkit.org/show_bug.cgi?id=58703
1482
1483         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.
1484
1485 2011-04-29  Xan Lopez  <xlopez@igalia.com>
1486
1487         Reviewed by Martin Robinson.
1488
1489         [Gtk+] Crash when navigating back
1490         https://bugs.webkit.org/show_bug.cgi?id=59799
1491
1492         The innerNode management in WebKitHitTestResult was relying on the
1493         old DOM bindings behavior where every DOM objects had to be
1494         disposed by the caller. Now the objects are garbage collected by
1495         WebKit when either the parent frame or document dies, so this is
1496         not needed anymore. Update the code to simply take ownership of
1497         the node, which effectively correctly balances the reference
1498         count.
1499
1500         * webkit/webkithittestresult.cpp:
1501         (webkit_hit_test_result_dispose): call C++ dtors in private data.
1502         (webkit_hit_test_result_get_property): adatp to GRefPtr API.
1503         (webkit_hit_test_result_init): call C++ ctors in private data.
1504
1505 2011-04-28  Xan Lopez  <xlopez@igalia.com>
1506
1507         Unreviewed build fix.
1508
1509         * GNUmakefile.am:
1510
1511 2011-04-28  Xan Lopez  <xlopez@igalia.com>
1512
1513         Reviewed by Martin Robinson.
1514
1515         [Gtk] Split JSC and WebCore builds
1516         https://bugs.webkit.org/show_bug.cgi?id=19428
1517
1518         Add a pkg-config file for JavaScriptCoreGTK+.
1519
1520         * GNUmakefile.am: take care of the pkg-config file.
1521         * javascriptcoregtk.pc.in: Added.
1522
1523 2011-04-28  Xan Lopez  <xlopez@igalia.com>
1524
1525         Reviewed by Martin Robinson.
1526
1527         [Gtk] Split JSC and WebCore builds
1528         https://bugs.webkit.org/show_bug.cgi?id=19428
1529
1530         Build JavaScriptCore as a libtool shared library instead of a
1531         private convenience library.
1532
1533         * GNUmakefile.am: adapt to new name for javascriptcore target.
1534
1535 2011-04-28  ojab  <ojab@ojab.ru>
1536
1537         Reviewed by Martin Robinson.
1538
1539         Webkit-gtk build failure, no type/member 'Page' in namespace 'WebCore'
1540         https://bugs.webkit.org/show_bug.cgi?id=59585
1541
1542         * webkit/webkitwebviewprivate.h:
1543
1544 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1545
1546         Reviewed by Xan Lopez.
1547
1548         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1549         https://bugs.webkit.org/show_bug.cgi?id=59715
1550
1551         Switch WebKit1 to use the new GtkClickCounter for counting > 3 clicks in a row.
1552         This allows the code to be shared between WebKit1 and WebKit2.
1553
1554         * WebCoreSupport/DragClientGtk.cpp:
1555         (WebKit::DragClient::startDrag): Call GtkClickCounter::reset instead of fiddling
1556         the WebView private data directly.
1557         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1558         (WebKit::postCommitFrameViewSetup): Ditto.
1559         * webkit/webkitwebview.cpp:
1560         (webkit_web_view_button_press_event): Call into GtkClickCounter now.
1561         (webkit_web_view_init): Remove private member intialization.
1562         * webkit/webkitwebviewprivate.h: Remove unneeded private members.
1563
1564 2011-04-27  Martin Robinson  <mrobinson@igalia.com>
1565
1566         Reviewed by Eric Seidel.
1567
1568         [GTK] Menulists do not follow text direction when rendering options with right-to-left text
1569         https://bugs.webkit.org/show_bug.cgi?id=54038
1570
1571         Fix rendering of menulists that contain right-to-left text. Text direction
1572         inside a menulist now follows the alignment of its contents.
1573
1574         * WebCoreSupport/ChromeClientGtk.cpp:
1575         (WebKit::ChromeClient::selectItemWritingDirectionIsNatural): Return false instead of true.
1576         (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Return true instead of false.
1577
1578 2011-04-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1579
1580         Unreviewed, rolling out r84987.
1581         http://trac.webkit.org/changeset/84987
1582         https://bugs.webkit.org/show_bug.cgi?id=59618
1583
1584         Caused crashes on the GTK+ debug bots. (Requested by mrobinson
1585         on #webkit).
1586
1587         * WebCoreSupport/ChromeClientGtk.cpp:
1588         (WebKit::ChromeClient::exceededDatabaseQuota):
1589
1590 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
1591
1592         Reviewed by Xan Lopez.
1593
1594         [GTK] flaky crash  storage/open-database-set-empty-version.html
1595         https://bugs.webkit.org/show_bug.cgi?id=58988
1596
1597         Construct the security origin directly instead of getting it from the WebKitWebFrame object.
1598         This prevents failing to create the WebKitSecurityOrigin in cases where the frame is in
1599         some inconsistent state.
1600
1601         * WebCoreSupport/ChromeClientGtk.cpp:
1602         (WebKit::ChromeClient::exceededDatabaseQuota): Construct the origin directly.
1603
1604 2011-04-22  Martin Robinson  <mrobinson@igalia.com>
1605
1606         Reviewed by Xan Lopez.
1607
1608         [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
1609         https://bugs.webkit.org/show_bug.cgi?id=58976
1610
1611         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1612         (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement
1613         method of the document returns null.
1614
1615 2011-04-22  Sam Weinig  <sam@webkit.org>
1616
1617         Reviewed by Gavin Barraclough.
1618
1619         Remove remaining uses of deprecated version of toJS
1620         https://bugs.webkit.org/show_bug.cgi?id=59170
1621
1622         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1623         (DumpRenderTreeSupportGtk::shadowRoot):
1624         (DumpRenderTreeSupportGtk::ensureShadowRoot):
1625         Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
1626
1627 2011-04-22  Philippe Normand  <pnormand@igalia.com>
1628
1629         Reviewed by Martin Robinson.
1630
1631         [GTK] DRT: implement eventSender.scalePageBy
1632         https://bugs.webkit.org/show_bug.cgi?id=59082
1633
1634         Added support in DRT for webview scaling.
1635
1636         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1637         (DumpRenderTreeSupportGtk::scale):
1638         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1639
1640 2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>
1641
1642         Reviewed by Sam Weinig.
1643
1644         Add Frame* to the argument lists of canCopyCut and canPaste
1645         https://bugs.webkit.org/show_bug.cgi?id=59153
1646
1647         * WebCoreSupport/EditorClientGtk.cpp:
1648         (WebKit::EditorClient::canCopyCut):
1649         (WebKit::EditorClient::canPaste):
1650         * WebCoreSupport/EditorClientGtk.h:
1651
1652 2011-04-21  Martin Robinson  <mrobinson@igalia.com>
1653
1654         [GTK] DRT: implement eventSender.scalePageBy
1655         https://bugs.webkit.org/show_bug.cgi?id=59082
1656
1657         Rolling out r84507 since it broke many GTK+ tests.
1658
1659         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1660         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1661
1662 2011-04-21  Philippe Normand  <pnormand@igalia.com>
1663
1664         Reviewed by Martin Robinson.
1665
1666         [GTK] missing LayoutTestController::callShouldCloseOnWebView()
1667         https://bugs.webkit.org/show_bug.cgi?id=59086
1668
1669         DRT::shouldClose(), used by the LayoutController.
1670
1671         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1672         (DumpRenderTreeSupportGtk::shouldClose):
1673         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1674
1675 2011-04-21  Philippe Normand  <pnormand@igalia.com>
1676
1677         Reviewed by Martin Robinson.
1678
1679         [GTK] DRT: implement eventSender.scalePageBy
1680         https://bugs.webkit.org/show_bug.cgi?id=59082
1681
1682         Added support in DRT for webview scaling.
1683
1684         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1685         (DumpRenderTreeSupportGtk::scalePageBy):
1686         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1687
1688 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
1689
1690         Reviewed by Dimitri Glazkov.
1691
1692         layoutTestController can create and destroy shadow DOM
1693         https://bugs.webkit.org/show_bug.cgi?id=59058
1694
1695         Support for new methods in GTK DRT.
1696
1697         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1698         (DumpRenderTreeSupportGtk::ensureShadowRoot):
1699         (DumpRenderTreeSupportGtk::removeShadowRoot):
1700         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1701
1702 2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1703
1704         Reviewed by Martin Robinson.
1705
1706         [GTK] Build libWebCore with the gtk sources too
1707         https://bugs.webkit.org/show_bug.cgi?id=58968
1708
1709         In some cases webcore files are compiled twice, so it improves the
1710         build time.
1711
1712         * GNUmakefile.am: Remove webcore gtk sources from libwebkitgtk
1713         sources.
1714
1715 2011-04-19  Vsevolod Vlasov  <vsevik@chromium.org>
1716
1717         Reviewed by Pavel Feldman.
1718
1719         Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
1720         https://bugs.webkit.org/show_bug.cgi?id=58883
1721
1722         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1723         (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
1724         * WebCoreSupport/FrameLoaderClientGtk.h:
1725         * webkit/webkitdownload.cpp:
1726         (DownloadClient::didReceiveData):
1727
1728 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
1729
1730         Reviewed by Martin Robinson.
1731
1732         [GTK] Need support for dumping focus rectangles in pixel results
1733         https://bugs.webkit.org/show_bug.cgi?id=53647
1734
1735         Add a support function that returns the rectangle of the current
1736         selection in frame.
1737
1738         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1739         (DumpRenderTreeSupportGtk::rectangleForSelection):
1740         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1741
1742 2011-04-12  Xan Lopez  <xlopez@igalia.com>
1743
1744         Unreviewed build fix.
1745
1746         * webkit/webkitwebhistoryitem.cpp:
1747
1748 2011-04-12  Stephanie Lewis  <slewis@apple.com>
1749
1750         Reviewed by Oliver Hunt.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=58280
1753         <rdar://problem/9252824> javascript in an inconsistent state due to serialization returning an un-handled exception.
1754
1755         Add a header include.  Fallout from untangling some header files in WebCore.
1756
1757         * webkit/webkitwebhistoryitem.cpp:
1758
1759 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1760
1761         Reviewed by Eric Seidel.
1762
1763         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
1764         https://bugs.webkit.org/show_bug.cgi?id=53605
1765
1766         Added jsValueToDOMRange to DumpRenderTreeSupportGtk. This static method can convert
1767         a JSValueRef to a WebKitDOMRange. When it's possible to do this with the public
1768         API, we can remove this method.
1769
1770         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1771         (DumpRenderTreeSupportGtk::jsValueToDOMRange): Added.
1772         * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added declaration.
1773
1774 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
1775
1776         Reviewed by Chris Fleizach.
1777
1778         [Gtk] Implement support for Embedded Objects
1779         https://bugs.webkit.org/show_bug.cgi?id=52148
1780
1781         New accessibility unit test for embedded objects.
1782
1783         * tests/testatk.c:
1784         (testWebkitAtkEmbeddedObjects): New unit test.
1785         (main): Added the new unit test.
1786
1787 2011-04-08  Dominic Cooney  <dominicc@google.com>
1788
1789         Reviewed by Adam Roben.
1790
1791         Make layoutTestController.shadowRoot return null, not undefined,
1792         when its argument is invalid.
1793         https://bugs.webkit.org/show_bug.cgi?id=58121
1794
1795         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1796         (DumpRenderTreeSupportGtk::shadowRoot):
1797
1798 2011-04-08  Dominic Cooney  <dominicc@google.com>
1799
1800         Reviewed by Kent Tamura.
1801
1802         layoutTestController.shadowRoot should return undefined if its
1803         argument is not an element.
1804         https://bugs.webkit.org/show_bug.cgi?id=58119
1805
1806         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1807         (DumpRenderTreeSupportGtk::shadowRoot):
1808
1809 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1810
1811         Reviewed by Martin Robinson.
1812
1813         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1814         https://bugs.webkit.org/show_bug.cgi?id=58039
1815
1816         Implemented missing functions in GTK's DRT.
1817
1818         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1819         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1820         (modifyAccessibilityValue): Helper function to increment or decrement
1821         the current value for an object through the AccessibilityObject's API.
1822         (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
1823         to be used from GTK's DRT.
1824         (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
1825
1826 2011-04-06  Gustavo Noronha Silva  <gns@gnome.org>
1827
1828         Reviewed by Martin Robinson.
1829
1830         [GTK] Need a way to get the path to a WebKitWebPlugin
1831         https://bugs.webkit.org/show_bug.cgi?id=57968
1832
1833         Expose the path of the plugin through the WebKitWebPlugin object.
1834
1835         * webkit/webkitwebplugin.cpp:
1836         (webkit_web_plugin_get_path):
1837         * webkit/webkitwebplugin.h:
1838         * webkit/webkitwebpluginprivate.h:
1839
1840 2011-04-07  Alice Boxhall  <aboxhall@chromium.org>
1841
1842         Reviewed by Ryosuke Niwa.
1843
1844         Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
1845         https://bugs.webkit.org/show_bug.cgi?id=57921
1846
1847         * webkit/webkitwebview.cpp:
1848         (webkit_web_view_forward_context_menu_event):
1849         Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
1850         method has moved on to EventHandler.
1851
1852 2011-04-05  Martin Robinson  <mrobinson@igalia.com>
1853
1854         Reviewed by Eric Seidel.
1855
1856         [Cairo] Better separate the concerns of GraphicsContextCairo
1857         https://bugs.webkit.org/show_bug.cgi?id=55150
1858
1859         Add a PlatformContextCairo which right now stores the cairo_t* for a
1860         GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
1861         and image masking layers into this PlatformContextCairo class.
1862
1863         * webkit/webkitwebframe.cpp:
1864         (draw_page_callback):
1865         * webkit/webkitwebview.cpp:
1866         (webkit_web_view_expose_event):
1867         (webkit_web_view_draw):
1868
1869 2011-04-04  MORITA Hajime  <morrita@google.com>
1870
1871         Reviewed by Ryosuke Niwa.
1872
1873         [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1874         https://bugs.webkit.org/show_bug.cgi?id=56085
1875
1876         * WebCoreSupport/TextCheckerClientEnchant.h:
1877         (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
1878
1879 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1880
1881         Reviewed by Gustavo Noronha Silva.
1882
1883         [GTK] WebGL support
1884         https://bugs.webkit.org/show_bug.cgi?id=31517
1885
1886         Add support for toggling WebGL at runtime when it's enabled.
1887
1888         * webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL
1889         is not enabled, it's a no-op.
1890         (webkit_web_settings_class_init): Update to support enable-webgl.
1891         (webkit_web_settings_set_property): Ditto.
1892         (webkit_web_settings_get_property): Ditto.
1893         * webkit/webkitwebview.cpp:
1894         (webkit_web_view_update_settings): Ditto.
1895
1896 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
1897
1898         Reviewed by Dan Bernstein.
1899
1900         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1901         https://bugs.webkit.org/show_bug.cgi?id=51230
1902         <rdar://problem/8780989>
1903
1904         * webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Moved Caps Lock handling from
1905         WebKits to WebCore, because WebKit shouldn't be smart.
1906
1907 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1908
1909         Reviewed by Xan Lopez.
1910
1911         [Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
1912         https://bugs.webkit.org/show_bug.cgi?id=54633
1913
1914         Remove use of legacy editing positions when positioning keyboard-driven context
1915         menus. Simplify the code greatly.
1916
1917         * webkit/webkitwebview.cpp:
1918         (getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates
1919         the context menu position.
1920         (webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping
1921         into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.
1922
1923 2011-04-02  Dominic Cooney  <dominicc@google.com>
1924
1925         Reviewed by Martin Robinson.
1926
1927         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1928         https://bugs.webkit.org/show_bug.cgi?id=57551
1929
1930         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1931         (DumpRenderTreeSupportGtk::shadowRoot):
1932         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1933
1934 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1935
1936         Unreviewed, rolling out r82721.
1937         http://trac.webkit.org/changeset/82721
1938         https://bugs.webkit.org/show_bug.cgi?id=57687
1939
1940         This patch introduced assertion failures on the GTK+ bots.
1941         (Requested by mrobinson on #webkit).
1942
1943         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1944         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1945
1946 2011-04-01  Dominic Cooney  <dominicc@google.com>
1947
1948         Reviewed by Martin Robinson.
1949
1950         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1951         https://bugs.webkit.org/show_bug.cgi?id=57551
1952
1953         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1954         (DumpRenderTreeSupportGtk::shadowRoot):
1955         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
1956
1957 2011-03-31  Xan Lopez  <xlopez@igalia.com>
1958
1959         Reviewed by Martin Robinson.
1960
1961         [GTK] Link explicitly with XRender on Linux/Unix
1962         https://bugs.webkit.org/show_bug.cgi?id=57558
1963
1964         * GNUmakefile.am: add XRender LIBS.
1965
1966 2011-03-31  Evan Martin  <evan@chromium.org>
1967
1968         Build fix from previous change.
1969
1970         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1971         (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
1972
1973 2011-03-31  Evan Martin  <evan@chromium.org>
1974
1975         Reviewed by Eric Seidel.
1976
1977         <title> should support dir attribute
1978         https://bugs.webkit.org/show_bug.cgi?id=50961
1979
1980         Update to new FrameLoaderClient interface.
1981
1982         * WebCoreSupport/FrameLoaderClientGtk.cpp:
1983         (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
1984         (WebKit::FrameLoaderClient::setTitle):
1985         * WebCoreSupport/FrameLoaderClientGtk.h:
1986
1987 2011-03-29  Philippe Normand  <pnormand@igalia.com>
1988
1989         Unreviewed, disable an assert in testwebview due to
1990         https://bugs.webkit.org/show_bug.cgi?id=57315
1991
1992         * tests/testwebview.c:
1993
1994 2011-03-28  Adele Peterson  <adele@apple.com>
1995
1996         Build fix.
1997
1998         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
1999         (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
2000
2001 2011-03-28  Sergio Villar Senin  <svillar@igalia.com>
2002
2003         Reviewed by Martin Robinson.
2004
2005         [GTK] Fullscreen tests failing after r82084
2006         https://bugs.webkit.org/show_bug.cgi?id=57219
2007
2008         Added the withKeyboard parameter to supportsFullScreenForElement
2009         method in ChromeClient. Fullscreen will be disabled for keyboard
2010         access by default.
2011
2012         * WebCoreSupport/ChromeClientGtk.cpp:
2013         (WebKit::ChromeClient::supportsFullScreenForElement):
2014         * WebCoreSupport/ChromeClientGtk.h:
2015
2016 2011-03-25  Andy Estes  <aestes@apple.com>
2017
2018         Reviewed by Adele Peterson.
2019
2020         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2021         https://bugs.webkit.org/show_bug.cgi?id=49016
2022
2023         Update objectContentType() implementation to handle the
2024         shouldPreferPlugInsForImages flag.
2025
2026         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2027         (WebKit::FrameLoaderClient::objectContentType):
2028         * WebCoreSupport/FrameLoaderClientGtk.h:
2029
2030 2011-03-25  Priit Laes  <plaes@plaes.org>
2031
2032         Reviewed by Martin Robinson.
2033
2034         [GTK] [PATCH] Avoid critical warning when free-ing list of plugins
2035         https://bugs.webkit.org/show_bug.cgi?id=57025
2036
2037         * webkit/webkitwebplugindatabase.cpp:
2038         (webkit_web_plugin_database_plugins_list_free):
2039         Use regular check and return instead of g_return_if_fail.
2040
2041 2011-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2042
2043         Unreviewed, rolling out r81916 and r81917.
2044         http://trac.webkit.org/changeset/81916
2045         http://trac.webkit.org/changeset/81917
2046         https://bugs.webkit.org/show_bug.cgi?id=57071
2047
2048         broke a test on platforms that do not have QuickTime installed
2049         (Requested by estes on #webkit).
2050
2051         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2052         (WebKit::FrameLoaderClient::objectContentType):
2053         * WebCoreSupport/FrameLoaderClientGtk.h:
2054
2055 2011-03-24  Andy Estes  <aestes@apple.com>
2056
2057         Reviewed by Darin Adler.
2058
2059         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2060         https://bugs.webkit.org/show_bug.cgi?id=49016
2061
2062         Update objectContentType() implementation to handle the
2063         shouldPreferPlugInsForImages flag.
2064
2065         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2066         (WebKit::FrameLoaderClient::objectContentType):
2067         * WebCoreSupport/FrameLoaderClientGtk.h:
2068
2069 2011-03-23  Brady Eidson  <beidson@apple.com>
2070
2071         Reviewed by Sam Weinig.
2072
2073         Change IconDatabase opening to allow for arbitrary filenames
2074         https://bugs.webkit.org/show_bug.cgi?id=56977
2075
2076         * webkit/webkiticondatabase.cpp:
2077         (webkit_icon_database_set_path):
2078
2079 2011-03-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2080
2081         Rubber-stamped by Xan Lopez.
2082
2083         Applications that include WebKit headers fail to build when using strict warnings
2084         because the signature for webkit_application_cache_get_maximum_size is missing a
2085         'void' to make it explicit it takes no arguments.
2086
2087         * webkit/webkitapplicationcache.h:
2088
2089 2011-03-21  Alejandro G. Castro  <alex@igalia.com>
2090
2091         Reviewed by Martin Robinson.
2092
2093         [GTK] 1.3.13 release bump
2094         https://bugs.webkit.org/show_bug.cgi?id=56795
2095
2096         Version bump for 1.3.13 and updated NEWS file with release notes.
2097
2098         * NEWS:
2099
2100 2011-03-21  Chang Shu  <cshu@webkit.org>
2101
2102         Reviewed by Alexey Proskuryakov.
2103
2104         REGRESSION (r79953): Can't type in MS Outlook 2011
2105         https://bugs.webkit.org/show_bug.cgi?id=56665
2106
2107         r79953 removed the WebView level editablity which is persistent no matter whether
2108         underlying document itself is changed and editability gets lost. The resolution is to
2109         set this WebView editable value to WebCore. This avoids the callback from WebCore to
2110         WebKit which was the main goal in r79953 to improve performance.
2111
2112         * webkit/webkitwebview.cpp:
2113         (webkit_web_view_get_editable):
2114         (webkit_web_view_set_editable):
2115
2116 2011-03-21  Mario Sanchez Prada  <msanchez@igalia.com>
2117
2118         Reviewed by Martin Robinson.
2119
2120         [GTK] [Stable] AtkHypertext exposes wrong offsets for links placed inside <span> nodes
2121         https://bugs.webkit.org/show_bug.cgi?id=56737
2122
2123         * tests/testatk.c:
2124         (testWebkitAtkHypertextAndHyperlinks): Updated unit test to also
2125         check offsets for hyperlinks inside <span> nodes.
2126
2127 2011-03-18  David Keijser  <keijser@gmail.com> and Xan Lopez <xlopez@igalia.com>
2128
2129         Reviewed by Martin Robinson.
2130
2131         [GTK] On-demand event-listeners for DOM event signals
2132         https://bugs.webkit.org/show_bug.cgi?id=49649
2133
2134         * tests/testdomdomwindow.c: update unit tests for new APIs.
2135         (load_event_callback): ditto.
2136         (test_dom_domview_signals): ditto.
2137         (load_status_callback): ditto.
2138
2139 2011-03-17  Brady Eidson  <beidson@apple.com>
2140
2141         Reviewed by Sam Weinig.
2142
2143         https://bugs.webkit.org/show_bug.cgi?id=56425
2144         More groundwork for WebKit2 IconDatabase
2145
2146         Update already-used function names:
2147         * webkit/webkiticondatabase.cpp:
2148         (webkit_icon_database_get_icon_uri):
2149         (webkit_icon_database_get_icon_pixbuf):
2150         * webkit/webkitwebview.cpp:
2151         (webkit_web_view_get_icon_uri):
2152
2153 2011-03-16  Joseph Pecoraro  <joepeck@webkit.org>
2154
2155         Reviewed by Kenneth Rohde Christiansen.
2156
2157         Viewport no longer allows an auto value for "user-scalable"
2158         https://bugs.webkit.org/show_bug.cgi?id=55416
2159
2160         Make the default value for userScalable be true.
2161
2162         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2163         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): update test output to include userScalable.
2164         * webkit/webkitviewportattributes.cpp:
2165         (webkitViewportAttributesRecompute):
2166
2167 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2168
2169         Reviewed by Tony Chang.
2170
2171         Autofilled form elements are assigned fixed background color but not text color
2172         https://bugs.webkit.org/show_bug.cgi?id=48382
2173
2174         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2175         (DumpRenderTreeSupportGtk::setAutofilled): Added.
2176         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2177
2178 2011-03-14  Ryuan Choi  <ryuan.choi@samsung.com>
2179
2180         Reviewed by Martin Robinson.
2181
2182         [GTK] Possible leaks after splitting TextCheckerClientEnchant.
2183         https://bugs.webkit.org/show_bug.cgi?id=55989
2184
2185         Convert gchar* to GOwnPtr<gchar> and refactor the code.
2186
2187         * WebCoreSupport/TextCheckerClientEnchant.cpp:
2188         (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
2189
2190 2011-03-11  Marco Peereboom  <marco@peereboom.us>
2191
2192         Reviewed by Gustavo Noronha Silva.
2193
2194         Provide a knob to enable/disable DNS prefetching.
2195         DNS prefetching is enabled by default.
2196         https://bugs.webkit.org/show_bug.cgi?id=55973
2197
2198         * webkit/webkitwebsettings.cpp:
2199         (webkit_web_settings_class_init):
2200         (webkit_web_settings_set_property):
2201         (webkit_web_settings_get_property):
2202         (webkit_web_settings_copy):
2203         * webkit/webkitwebview.cpp:
2204         (webkit_web_view_update_settings):
2205         (webkit_web_view_settings_notify):
2206
2207 2011-03-08  Philippe Normand  <pnormand@igalia.com>
2208
2209         Reviewed by Martin Robinson.
2210
2211         [GTK] close-web-view emitted on disposed WebView
2212         https://bugs.webkit.org/show_bug.cgi?id=55932
2213
2214         * WebCoreSupport/ChromeClientGtk.cpp:
2215         (ChromeClient::chromeDestroyed): Remove the closeSoonTimer glib
2216         source before destruction of the ChromeClient.
2217
2218 2011-03-11  Roland Steiner  <rolandsteiner@chromium.org>
2219
2220         Reviewed by Ryosuke Niwa.
2221
2222         Bug 55570 - Remove dependency of dom/InputElement.cpp on html/ and wml/
2223         https://bugs.webkit.org/show_bug.cgi?id=55570
2224
2225         Add a virtual function toInputElement() to Node that has a default
2226         implementation of returning 0.
2227         For HTMLInputElement and WMLInputElement (which derive from InputElement)
2228         override this to return the object.
2229         Change all calling sites of the old toInputElement to use the new member
2230         function. This also allows us to save some casts.
2231
2232         No new tests (refactoring).
2233
2234         * src/WebInputElement.cpp:
2235         (WebKit::toWebInputElement):
2236
2237         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2238         (DumpRenderTreeSupportGtk::setValueForUser):
2239
2240 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2241
2242         Reviewed by Xan Lopez.
2243
2244         [GTK] unittests/testapplicationcache crashes
2245         https://bugs.webkit.org/show_bug.cgi?id=56083
2246
2247         Removed the webkit_application_cache_get_database_directory_path
2248         API as the underlying ApplicationCacheStorage doesn't allow
2249         setting the cache path multiple times.
2250
2251         * tests/testapplicationcache.c:
2252         (main):
2253         * webkit/webkitapplicationcache.cpp:
2254         (webkit_application_cache_get_database_directory_path):
2255         * webkit/webkitapplicationcache.h:
2256         * webkit/webkitglobals.cpp:
2257         (webkitInit):
2258
2259 2011-03-09  Peter Kasting  <pkasting@google.com>
2260
2261         Reviewed by Mihai Parparita.
2262
2263         Unify Windows version checks.
2264         https://bugs.webkit.org/show_bug.cgi?id=55979
2265
2266         * webkit/webkitwebsettings.cpp:
2267         (webkitOSVersion):
2268
2269 2011-03-08  Christian Dywan  <christian@lanedo.com>
2270
2271         Reviewed by Martin Robinson.
2272
2273         [GTK] provide an API to control the IconDatabase
2274         https://bugs.webkit.org/show_bug.cgi?id=32510
2275
2276         * GNUmakefile.am:
2277         * WebCoreSupport/FrameLoaderClientGtk.cpp: Emit signals on
2278             the icon database for new icons.
2279         * webkit/webkit.h:
2280         * webkit/webkitdefines.h:
2281         * webkit/webkitglobals.cpp:
2282         * webkit/webkitglobals.h: Add a function to obtain the global
2283             icon database.
2284         * webkit/webkiticondatabase.cpp:
2285         * webkit/webkiticondatabase.h: Implement public icon database
2286             object with methods for obtaining icon URLs, pixbufs, clearing
2287             waiting for new icons.
2288         * webkit/webkitwebview.cpp:
2289         * webkit/webkitwebview.h: Add a method to obtain an icon pixbuf
2290             for the web view.
2291 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2292
2293         Reviewed by Martin Robinson.
2294
2295         [GTK] Add layoutTestController.setValueForUser() after r80412
2296         https://bugs.webkit.org/show_bug.cgi?id=55862
2297
2298         Add setValueForUser method to DumpRenderTreeSupportGTK.
2299
2300         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2301         (DumpRenderTreeSupportGtk::setValueForUser):
2302         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2303
2304 2011-03-07  Sam Weinig  <sam@webkit.org>
2305
2306         Reviewed by Anders Carlsson.
2307
2308         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2309         https://bugs.webkit.org/show_bug.cgi?id=55827
2310
2311         Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2312         and pass the entire response, instead of just the MIMEType.
2313
2314         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2315         (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
2316         * WebCoreSupport/FrameLoaderClientGtk.h:
2317
2318 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
2319
2320         Reviewed by Xan Lopez.
2321
2322         [GTK] Windowless plugins override the view cursor
2323         https://bugs.webkit.org/show_bug.cgi?id=55531
2324
2325         * WebCoreSupport/ChromeClientGtk.cpp:
2326         (WebKit::ChromeClient::setCursor): Moved the implementation of setCursor here
2327         which is more fitting since it sets the cursor for the entire window.
2328
2329 2011-03-03  Brady Eidson  <beidson@apple.com>
2330
2331         Reviewed by Darin Adler.
2332
2333         https://bugs.webkit.org/show_bug.cgi?id=55721
2334         Global IconDatabase should be returned by reference, not as a pointer
2335
2336         * webkit/webkitglobals.cpp:
2337         (closeIconDatabaseOnExit):
2338         (WebKit::setIconDatabaseEnabled):
2339         * webkit/webkitwebview.cpp:
2340         (webkit_web_view_get_icon_uri):
2341
2342 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
2343
2344         Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2345         via ChromeClient.h
2346
2347         * WebCoreSupport/ChromeClientGtk.h:
2348
2349 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2350
2351         Reviewed by Darin Adler.
2352
2353         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2354         https://bugs.webkit.org/show_bug.cgi?id=55633
2355         <rdar://problem/8963023>
2356
2357         * WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::keyboardUIMode):
2358         * WebCoreSupport/ChromeClientGtk.h:
2359         Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2360         this platform doesn't observe or have full keyboard access state.
2361
2362 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2363
2364         Reviewed by Xan Lopez.
2365
2366         [GTK] Extended application cache database API and added unit tests file.
2367         https://bugs.webkit.org/show_bug.cgi?id=55335
2368
2369         * GNUmakefile.am: Add testapplicationcache.c and remove webkitapplicationcacheprivate.h.
2370         * tests/testapplicationcache.c: Added.
2371         (test_applicationcache_maximum_size): Tests if application cache storage is set/get correctly.
2372         (test_applicationcache_database_directory_path): Tests if application cache directory path is set/get correctly.
2373         (main):
2374         * webkit/webkitapplicationcache.cpp:
2375         (webkit_application_cache_get_maximum_size): New API for getting application cache maximum storage size.
2376         * webkit/webkitapplicationcache.h: Declaration of API for getting/setting application cache maximum storage size.
2377         * webkit/webkitapplicationcacheprivate.h: Removed.
2378 2011-03-03  Peter Kasting  <pkasting@google.com>
2379
2380         Reviewed by James Robinson.
2381
2382         Drop redundant "Windows; " from the Windows-specific User Agent string.
2383         https://bugs.webkit.org/show_bug.cgi?id=54567
2384
2385         * webkit/webkitwebsettings.cpp:
2386         (webkitPlatform):
2387         (webkitUserAgent):
2388
2389 2011-03-02  Martin Robinson  <mrobinson@igalia.com>
2390
2391         Reviewed by Xan Lopez.
2392
2393         Do a bit of cleanup in ChromeClientGtk. Instead of always fetching the
2394         WebKitWebView from the frame, simply get it from the member variable of
2395         the ChromeClientGtk instance itself.
2396
2397         * WebCoreSupport/ChromeClientGtk.cpp:
2398         (WebKit::ChromeClient::scrollbarsVisible):
2399         (WebKit::ChromeClient::exceededDatabaseQuota):
2400         (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
2401         (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
2402         (WebKit::ChromeClient::enterFullscreenForNode):
2403         (WebKit::ChromeClient::exitFullscreenForNode):
2404
2405 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
2406
2407         Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
2408
2409         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2410         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
2411         * webkit/webkitviewportattributes.cpp:
2412         (webkitViewportAttributesRecompute):
2413
2414 2011-03-01  Joseph Pecoraro  <joepeck@webkit.org>
2415
2416         Reviewed by Kenneth Rohde Christiansen.
2417
2418         Viewport Warning/Error Messages Are Now Inaccurate
2419         https://bugs.webkit.org/show_bug.cgi?id=53707
2420
2421         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2422         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): pass a Document into computeViewportAttributes for warnings to be reported to.
2423         * webkit/webkitviewportattributes.cpp:
2424         (webkitViewportAttributesRecompute): pass a Document into computeViewportAttributes for warnings to be reported to.
2425
2426 2011-03-01  Kamil Blank  <k.blank@samsung.com>
2427
2428         Reviewed by Martin Robinson.
2429
2430         [GTK] Fixing headers order in webkit.h.
2431         https://bugs.webkit.org/show_bug.cgi?id=55316
2432
2433         * webkit/webkit.h: Style fix.
2434
2435 2011-03-01  Joone Hur  <joone.hur@collabora.co.uk>
2436
2437         Reviewed by Martin Robinson.
2438
2439         [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
2440         https://bugs.webkit.org/show_bug.cgi?id=55437
2441
2442         * webkit/webkitwebview.cpp: Convert use of cairo_t to RefPtr<cairo_t>.
2443         (webkit_web_view_expose_event):
2444
2445 2011-02-28  Chang Shu  <cshu@webkit.org>
2446
2447         Reviewed by Ryosuke Niwa.
2448
2449         Remove the support of Frame::isContentEditable and its dependencies.
2450         https://bugs.webkit.org/show_bug.cgi?id=54292
2451
2452         Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
2453
2454         * WebCoreSupport/EditorClientGtk.cpp:
2455         * WebCoreSupport/EditorClientGtk.h:
2456         * webkit/webkitwebview.cpp:
2457         (webkit_web_view_init):
2458         (webkit_web_view_get_editable):
2459         (webkit_web_view_set_editable):
2460         * webkit/webkitwebviewprivate.h:
2461
2462 2011-02-26  Lukasz Slachciak  <l.slachciak@samsung.com>
2463
2464         Reviewed by Xan Lopez.
2465
2466         [GTK] Implemented API to set/get web application cache directory path database.
2467
2468         * GNUmakefile.am: Add webkitapplicationcache.h file.
2469         * webkit/webkit.h: Add webkitapplicationcache.h file.
2470         * webkit/webkitapplicationcache.cpp: definition of API setting and getting
2471         web application cache directory path database.
2472         (webkit_application_cache_get_database_directory_path):
2473         (webkit_application_cache_set_database_directory_path):
2474         * webkit/webkitapplicationcache.h: Added new API file for setting and getting
2475         web application cache directory path database.
2476         * webkit/webkitglobals.cpp:
2477         (webkitInit): use webkit_application_cache_set_database_directory_path
2478         to set default web application cache directory path database.
2479
2480 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2481
2482         Reviewed by Pavel Feldman.
2483
2484         DumpRenderTree should reset frame opener between tests.
2485         https://bugs.webkit.org/show_bug.cgi?id=54874
2486
2487         Added clearOpener method to DumpRenderTreeSupportGTK.
2488
2489         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2490         (DumpRenderTreeSupportGtk::clearOpener):
2491         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2492
2493 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2494
2495         Reviewed by Andreas Kling.
2496
2497         Make it possible to test the targetdensity-dpi support
2498         https://bugs.webkit.org/show_bug.cgi?id=55142
2499
2500         Test the viewport meta tag feature targetdensity-dpi by
2501         adding extra arguments to dumpConfigurationForViewport
2502
2503         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2504         (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
2505         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2506
2507 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2508
2509         Unreviewed, rolling out r79764.
2510         http://trac.webkit.org/changeset/79764
2511         https://bugs.webkit.org/show_bug.cgi?id=55295
2512
2513         "broke Chromium builds" (Requested by rniwa on #webkit).
2514
2515         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2516         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2517
2518 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
2519
2520         Reviewed by Pavel Feldman.
2521
2522         DumpRenderTree should reset frame opener between tests.
2523         https://bugs.webkit.org/show_bug.cgi?id=54874
2524
2525         Added clearOpener method to DumpRenderTreeSupportGTK.
2526
2527         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2528         (DumpRenderTreeSupportGtk::clearOpener):
2529         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2530
2531 2011-02-24  Peter Kasting  <pkasting@google.com>
2532
2533         Reviewed by Eric Seidel.
2534
2535         Drop the "U; " encryption level from the User Agent string.
2536         https://bugs.webkit.org/show_bug.cgi?id=54566
2537
2538         * webkit/webkitwebsettings.cpp:
2539         (webkitUserAgent):
2540
2541 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
2542
2543         Unreviewed, rolling out r79570.
2544         http://trac.webkit.org/changeset/79570
2545         https://bugs.webkit.org/show_bug.cgi?id=54874
2546
2547         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2548         was not updated
2549
2550         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2551         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2552
2553 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
2554
2555         Reviewed by Alexey Proskuryakov.
2556
2557         DumpRenderTree should reset frame opener between tests.
2558         https://bugs.webkit.org/show_bug.cgi?id=54874
2559
2560         Added clearOpener method to DumpRenderTreeSupportGTK.
2561
2562         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2563         (DumpRenderTreeSupportGtk::clearOpener):
2564         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2565
2566 2011-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2567
2568         Reviewed by Alexey Proskuryakov.
2569
2570         Drop the language tag part from the User Agent string
2571         https://bugs.webkit.org/show_bug.cgi?id=54560
2572
2573         * webkit/webkitwebsettings.cpp:
2574         (webkitUserAgent):
2575
2576 2011-02-22  Martin Robinson  <mrobinson@igalia.com>
2577
2578         Reviewed by Xan Lopez.
2579
2580         [GTK] position:fixed elements flicker while scrolling after r74196
2581         https://bugs.webkit.org/show_bug.cgi?id=54981
2582
2583         * WebCoreSupport/ChromeClientGtk.cpp:
2584         (WebKit::ChromeClient::ChromeClient): Initialize the new m_pendingScrollInvalidations
2585         boolean to false.
2586         (WebKit::ChromeClient::invalidateWindow): If this is an immediate invalidation and we
2587         having pending scrolling invalidations, instruct GDK to process updates now.
2588         (WebKit::ChromeClient::scroll): Remove the call to gdk_window_process_updates. Set
2589         m_pendingScrollInvalidations to true to force it to happen in invalidateWindow instead.
2590         * WebCoreSupport/ChromeClientGtk.h: Add new boolean member.
2591
2592 2011-02-02  Martin Robinson  <mrobinson@igalia.com>
2593
2594         Reviewed by Xan Lopez.
2595
2596         [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
2597         https://bugs.webkit.org/show_bug.cgi?id=53603
2598
2599         Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
2600         setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
2601         listens to this value during DRT runs. Perhaps later we can expose this to the public
2602         API.
2603
2604         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2605         (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added
2606         (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
2607         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2608         * WebCoreSupport/EditorClientGtk.cpp:
2609         (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk
2610         for the appropriate return value.
2611
2612 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
2613
2614         Reviewed by Xan Lopez.
2615
2616         [GTK] [REGRESSION] After r79130, spell tests did not work
2617         https://bugs.webkit.org/show_bug.cgi?id=54860
2618
2619         * WebCoreSupport/TextCheckerClientEnchant.cpp:
2620         (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided
2621         freeing the default PangoLanguage.
2622         * webkit/webkitwebview.cpp:
2623         (webkit_web_view_update_settings): Initialized list of dictionaries.
2624
2625 2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2626
2627         Reviewed by Kent Tamura.
2628
2629         Rename Position::node() to Position::deprecatedNode()
2630         https://bugs.webkit.org/show_bug.cgi?id=54622
2631
2632         Done the rename. All calls to node() are replaced by calls to deprecatedNode().
2633
2634         * webkit/webkitwebview.cpp:
2635         (webkit_web_view_popup_menu_handler):
2636
2637 2011-02-19  Ryuan Choi  <ryuan.choi@samsung.com>
2638
2639         Reviewed by Martin Robinson.
2640
2641         [GTK] Remove mandatory Enchant dependency
2642         https://bugs.webkit.org/show_bug.cgi?id=51587
2643
2644         Extract TextCheckerClientEnchant From EditorClientGtk and remove
2645         enchant dependency from other files.
2646
2647         * GNUmakefile.am:
2648         * WebCoreSupport/EditorClientGtk.cpp:
2649         (WebKit::EditorClient::EditorClient):
2650         * WebCoreSupport/EditorClientGtk.h:
2651         (WebKit::EditorClient::textChecker):
2652         * WebCoreSupport/TextCheckerClientEnchant.cpp: Added.
2653         (WebKit::TextCheckerClientEnchant::TextCheckerClientEnchant):
2654         (WebKit::TextCheckerClientEnchant::~TextCheckerClientEnchant):
2655         (WebKit::TextCheckerClientEnchant::ignoreWordInSpellDocument):
2656         (WebKit::TextCheckerClientEnchant::learnWord):
2657         (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
2658         (WebKit::TextCheckerClientEnchant::getAutoCorrectSuggestionForMisspelledWord):
2659         (WebKit::TextCheckerClientEnchant::checkGrammarOfString):
2660         (WebKit::TextCheckerClientEnchant::getGuessesForWord):
2661         (WebKit::getAvailableDictionariesCallback):
2662         (WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage):
2663         (WebKit::TextCheckerClientEnchant::freeSpellCheckingLanguage):
2664         * WebCoreSupport/TextCheckerClientEnchant.h: Added.
2665         (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
2666         * webkit/webkitwebsettings.cpp:
2667         (webkit_web_settings_finalize):
2668         (webkit_web_settings_set_property):
2669         * webkit/webkitwebview.cpp:
2670         (webkit_web_view_settings_notify):
2671
2672 2011-02-19  Charlie Reis  <creis@chromium.org>
2673
2674         Reviewed by Mihai Parparita.
2675
2676         Ensure loading has stopped in HistoryController::goToItem
2677         https://bugs.webkit.org/show_bug.cgi?id=54517
2678
2679         Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2680
2681         Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2682
2683         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2684         (WebKit::FrameLoaderClientGtk::shouldStopLoadingForHistoryItem): Added.
2685         * WebCoreSupport/FrameLoaderClientGtk.h:
2686
2687 2011-02-18  Mario Sanchez Prada  <msanchez@igalia.com>
2688
2689         Reviewed by Martin Robinson.
2690
2691         [Gtk] atk_text_get_selection/atk_text_set_selection fails for list items
2692         https://bugs.webkit.org/show_bug.cgi?id=53453
2693
2694         Update unit test to check the fix for this bug.
2695
2696         * tests/testatk.c:
2697         (testWebkitAtkTextSelections): Check that functions from AtkText
2698         interface to set and get text selections work with list items.
2699
2700 2011-02-17  Robert Ancell  <rober.ancell@gmail.com>
2701
2702         Reviewed by Martin Robinson.
2703
2704         [PATCH] GTK documentation fails to build due to changed paths
2705         https://bugs.webkit.org/show_bug.cgi?id=54600
2706
2707         * docs/GNUmakefile.am: Update the paths that have now moved the Source
2708         directory.
2709
2710 2011-02-16  Joone Hur  <joone.hur@collabora.co.uk>
2711
2712         Reviewed by Xan Lopez.
2713
2714         [GTK] Match more various WebKit API enum values with WebCore enum values
2715         https://bugs.webkit.org/show_bug.cgi?id=54352
2716
2717         AssertMatchingEnums.cpp was added to assert that various WebKit API enum values
2718         continue matching WebCore defined enum values in the following changeset.
2719         http://trac.webkit.org/changeset/77868
2720         However, there are already enum values that have been asserted in other files,
2721         so these assert macros defined need to be moved to AssertMatchingEnum.cpp.
2722
2723         * WebCoreSupport/AssertMatchingEnums.cpp: Add more enum values to be asserted.
2724         * webkit/webkitwebnavigationaction.cpp:
2725         (webkit_web_navigation_action_class_init): Move the assert macros of
2726         WEBKIT_WEB_NAVIGATION_REASON_* to AssertMatchingEnums.cpp.
2727         * webkit/webkitwebsettings.cpp:
2728         (webkit_web_settings_class_init): Move the assert macros of WEBKIT_EDITING_BEHAVIOR_*
2729         to AssertMatchingEnums.cpp.
2730
2731 2011-02-16  Mario Sanchez Prada  <msanchez@igalia.com>
2732
2733         Reviewed by Martin Robinson.
2734
2735         [GTK] events missing when a document is (re)loaded
2736         https://bugs.webkit.org/show_bug.cgi?id=25831
2737
2738         Emit the right signals when reloading a document.
2739
2740         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2741         (WebKit::notifyAccessibilityStatus): New function, to make sure
2742         the signals involved in reloading a document are properly emitted.
2743         (WebKit::notifyStatus): Also notify accessibility if enabled.
2744
2745 2011-02-15  Kenneth Russell  <kbr@google.com>
2746
2747         Reviewed by Darin Fisher.
2748
2749         Allow controlling minimum DOMTimer interval on a per-page basis
2750         https://bugs.webkit.org/show_bug.cgi?id=54312
2751
2752         Added needed methods to implement LayoutTestController's new
2753         setMinimumTimerInterval method.
2754
2755         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2756         (DumpRenderTreeSupportGtk::defaultMinimumTimerInterval):
2757         (DumpRenderTreeSupportGtk::setMinimumTimerInterval):
2758         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2759
2760 2011-02-15  Christian Dywan  <christian@lanedo.com>
2761
2762         Rubber-stamped by Gustavo Noronha Silva.
2763
2764         * webkit/webkitwebsettings.cpp: Correct a typo, it is
2765             acces*s*ibility with two s.
2766
2767 2011-01-26  MORITA Hajime  <morrita@google.com>
2768
2769         Reviewed by Ryosuke Niwa.
2770
2771         Refactoring: Extract TextCheckerClient from EditorClient
2772         https://bugs.webkit.org/show_bug.cgi?id=53213
2773
2774         * WebCoreSupport/EditorClientGtk.h:
2775         (WebKit::EditorClient::textChecker):
2776
2777 2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2778
2779         Reviewed by Adam Barth.
2780
2781         Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
2782         https://bugs.webkit.org/show_bug.cgi?id=52417
2783
2784         Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
2785         not implemented.
2786
2787         * WebCoreSupport/EditorClientGtk.cpp:
2788         (WebKit::EditorClient::canCopyCut): Added.
2789         (WebKit::EditorClient::canPaste): Added.
2790         * WebCoreSupport/EditorClientGtk.h:
2791
2792 2011-02-14  Alejandro G. Castro  <alex@igalia.com>
2793
2794         Reviewed by Xan Lopez.
2795
2796         [GTK] testwebdatasource test fails in the bots
2797         https://bugs.webkit.org/show_bug.cgi?id=54414
2798
2799         Changed the uri we check, added www to avoid the rewrite that we
2800         get when we as the uri to the request in case it finishes.
2801
2802         * tests/testwebdatasource.c:
2803         (notify_load_status_cb):
2804
2805 2011-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2806
2807         Unreviewed, rolling out r78331.
2808         http://trac.webkit.org/changeset/78331
2809         https://bugs.webkit.org/show_bug.cgi?id=54295
2810
2811         This patch broke 11 tests in GTK bots (Requested by svillar on
2812         #webkit).
2813
2814         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2815         (WebKit::notifyStatus):
2816
2817 2011-02-10  Nate Chapin  <japhet@chromium.org>
2818
2819         Reviewed by Adam Barth.
2820
2821         Update calls to DocumentWriter.
2822         https://bugs.webkit.org/show_bug.cgi?id=50489
2823
2824         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2825         (WebKit::FrameLoaderClient::FrameLoaderClient):
2826         (WebKit::FrameLoaderClient::didRunInsecureContent):
2827         (WebKit::FrameLoaderClient::dispatchDidLoadMainResource):
2828         (WebKit::FrameLoaderClient::finishedLoading):
2829         * WebCoreSupport/FrameLoaderClientGtk.h:
2830         * webkit/webkitwebview.cpp:
2831         (webkit_web_view_get_encoding):
2832
2833 2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>
2834
2835         Reviewed by Xan Lopez.
2836
2837         [GTK] events missing when a document is (re)loaded
2838         https://bugs.webkit.org/show_bug.cgi?id=25831
2839
2840         Emit the right signals when reloading a document.
2841
2842         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2843         (WebKit::notifyAccessibilityStatus): New function, to make sure
2844         the signals involved in reloading a document are properly emitted.
2845         (WebKit::notifyStatus): Also notify accessibility if enabled.
2846
2847 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
2848
2849         Reviewed by Xan Lopez.
2850
2851         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
2852         https://bugs.webkit.org/show_bug.cgi?id=54033
2853
2854         Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
2855         This is a likely candidate for a new API point.
2856
2857         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2858         (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
2859         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2860         * webkit/webkitglobals.cpp:
2861         (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead
2862         of initializing the database manually.
2863         (WebKit::setIconDatabaseEnabled): Added.
2864         * webkit/webkitglobalsprivate.h: Added declarations.
2865
2866 2011-02-08  Adam Barth  <abarth@webkit.org>
2867
2868         Reviewed by Eric Seidel.
2869
2870         Remove orphan code from old parser
2871         https://bugs.webkit.org/show_bug.cgi?id=53984
2872
2873         * WebCoreSupport/ChromeClientGtk.h:
2874
2875 2011-02-02  Ilya Tikhonovsky  <loislo@chromium.org>
2876
2877         Reviewed by Yury Semikhatsky.
2878
2879         Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2880
2881         https://bugs.webkit.org/show_bug.cgi?id=53169
2882
2883         Minor change enforced by major changes in WebCore/inspector/InspectorController.
2884
2885         * WebCoreSupport/InspectorClientGtk.cpp:
2886         * webkit/webkitwebinspector.cpp:
2887         (webkit_web_inspector_get_property):
2888
2889 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         Reviewed by Martin Robinson.
2892
2893         [GTK] DRT's TextInputController is unimplemented on GTK
2894         https://bugs.webkit.org/show_bug.cgi?id=52997
2895
2896         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2897         (DumpRenderTreeSupportGtk::setComposition):
2898         (DumpRenderTreeSupportGtk::confirmComposition):
2899         (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
2900         (DumpRenderTreeSupportGtk::selectedRange): New methods needed by
2901         TextInputController.
2902         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2903
2904 2011-02-07  Enrica Casucci  <enrica@apple.com>
2905
2906         Reviewed Adam Roben and Darin Adler.
2907
2908         WebKit2: drag and drop support on Windows.
2909         https://bugs.webkit.org/show_bug.cgi?id=52775
2910
2911         Removed createDragImageForLink from DragClient.
2912
2913         * WebCoreSupport/DragClientGtk.cpp:
2914         * WebCoreSupport/DragClientGtk.h:
2915
2916 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
2917
2918         Reviewed by Martin Robinson.
2919
2920         [Gtk] Implement layoutTestController.findString
2921         https://bugs.webkit.org/show_bug.cgi?id=50237
2922
2923         * GNUmakefile.am: Add AssertMatchingEnums.cpp.
2924         * WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various
2925         WebKit API enum values continue matching WebCore defined enum values.
2926         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
2927         (DumpRenderTreeSupportGtk::findString):
2928         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2929
2930 2011-02-07  Martin Robinson  <mrobinson@igalia.com>
2931
2932         Reviewed by Daniel Bates.
2933
2934         [GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
2935         https://bugs.webkit.org/show_bug.cgi?id=44784
2936
2937         Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's.
2938
2939         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2940         (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.
2941
2942 2011-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
2943
2944         Reviewed by Xan Lopez.
2945
2946         [Gtk] atk_text_get_caret_offset fails for list items
2947         https://bugs.webkit.org/show_bug.cgi?id=53436
2948
2949         Update unit test to check the fix for this bug.
2950
2951         * tests/testatk.c:
2952         (testWebkitAtkCaretOffsets): Check that the caret offset returned
2953         match the value previously set.
2954
2955 2011-02-04  Joone Hur  <joone.hur@collabora.co.uk>
2956
2957         Unreviewed, Fix compilation warning.
2958
2959         Constructor initialization list should follow the declaration order.
2960
2961         * WebCoreSupport/FrameLoaderClientGtk.cpp:
2962         (WebKit::FrameLoaderClient::FrameLoaderClient): m_hasRepresentation is moved to
2963         the last position in the initialization list.
2964
2965 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
2966
2967         Reviewed by Xan Lopez.
2968
2969         [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
2970         https://bugs.webkit.org/show_bug.cgi?id=53797
2971
2972         When the frame name changes between different calls to webkit_web_frame_get_name
2973         on the same frame, return the new frame name instead of the one valid during the
2974         previous call.
2975
2976         * webkit/webkitwebframe.cpp:
2977         (webkit_web_frame_init): Initialize the frame name to 0.
2978         (webkit_web_frame_get_name): Check the current frame name first before
2979         returning the cached value.
2980
2981 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
2982
2983         Reviewed by Gustavo Noronha Silva.
2984
2985         [GTK] fast/events/pagehide-timeout.html fails
2986         https://bugs.webkit.org/show_bug.cgi?id=53771
2987
2988         Add the document browser cache model. This model is optimized for viewing
2989         a series of local files, while the document viewer is optimized for only
2990         viewing one local file. Improve the documentation on the mapping of these
2991         enum values to actual cache settings.
2992
2993         * webkit/webkitglobals.cpp:
2994         (webkit_set_cache_model): Add support for the document browser cache model and
2995         improve comments in this section better explaining where the magic numbers come from.
2996         * webkit/webkitglobals.h: Added an enum value for the document browser cache model.
2997
2998 2011-02-03  Yury Semikhatsky  <yurys@chromium.org>
2999
3000         Reviewed by Pavel Feldman.
3001
3002         Web Inspector: remove settings related methods from InspectorClient
3003         https://bugs.webkit.org/show_bug.cgi?id=53686
3004
3005         * WebCoreSupport/InspectorClientGtk.cpp:
3006         (WebKit::InspectorFrontendClient::InspectorFrontendClient):
3007         * WebCoreSupport/InspectorClientGtk.h:
3008
3009 2011-02-03  Adam Langley  <agl@chromium.org>
3010
3011         Reviewed by Adam Barth.
3012
3013         Plumb mixed script URL to FrameLoaderClient
3014         https://bugs.webkit.org/show_bug.cgi?id=52384
3015
3016         Regressions covered by http/tests/security/mixedContent/*
3017
3018         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3019         (WebKit::FrameLoaderClient::didRunInsecureContent):
3020         * WebCoreSupport/FrameLoaderClientGtk.h:
3021
3022 2011-02-03  Joone Hur  <joone.hur@collabora.co.uk>
3023
3024         Reviewed by Martin Robinson.
3025
3026         [Gtk] No need to set text encoding in the provisional phase
3027         https://bugs.webkit.org/show_bug.cgi?id=53487
3028
3029         According to changeset 67253, setEncoding could be called multiple times from
3030         committedLoad, finishedLoading, dispatchDidFailLoading, and setMainDocumentError
3031         in FrameLoaderClient. To fix this, the relevant code was removed from
3032         FrameLoaderClient and moved to DocumentLoader::commitData. However, that
3033         code was not removed from FrameLoaderClient::finishedLoading in WebKitGtk+.
3034
3035         Due to this reason, after loading a html document, other ports initialize the
3036         text encoding from FrameLoaderClient::finishedLoading, but WebKitGtk+ sets
3037         the same encoding again, even tries to set encoding in the provisional phase.
3038         This causes unnecessary encoding setting.
3039
3040         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3041         (WebKit::FrameLoaderClient::FrameLoaderClient): Set m_hasRepresentation to false.
3042         (WebKit::FrameLoaderClient::makeRepresentation): Set m_hasRepresentation to true.
3043         (WebKit::FrameLoaderClient::revertToProvisionalState): Set m_hasRepresentation to true.
3044         (WebKit::FrameLoaderClient::finishedLoading): Skip the encoding setting when
3045         m_hasRepresentation is false.
3046         * WebCoreSupport/FrameLoaderClientGtk.h: Added m_hasRepresentation.
3047
3048 2011-02-02  Alejandro G. Castro  <alex@igalia.com>
3049
3050         Reviewed by Martin Robinson.
3051
3052         Update the NEWS file in preparation for the 1.3.11 release.
3053
3054         * NEWS: Update the NEWS.
3055
3056 2011-02-02  Dan Winship  <danw@gnome.org>
3057
3058         Reviewed by Martin Robinson.
3059
3060         [GTK] drop soup cache stuff, which has been moved to libsoup
3061         https://bugs.webkit.org/show_bug.cgi?id=50747
3062
3063         * GNUmakefile.am: Remove old cache files.
3064
3065 2011-02-02  David Hyatt  <hyatt@apple.com>
3066
3067         Reviewed by Darin Adler.
3068
3069         Removal of right()/bottom(), converting to maxX()/maxY().
3070
3071         * webkit/webkitwebview.cpp:
3072         (webkit_web_view_popup_menu_handler):
3073
3074 2011-02-01  Mario Sanchez Prada  <msanchez@igalia.com>
3075
3076         Reviewed by Martin Robinson.
3077
3078         [Gtk] atk_text_set_caret_offset fails for list items
3079         https://bugs.webkit.org/show_bug.cgi?id=53388
3080
3081         Update unit test to check the fix for this bug.
3082
3083         * tests/testatk.c:
3084         (testWebkitAtkCaretOffsets): Ensure setting the caret in a list
3085         item through the AtkText interface is possible.
3086
3087 2011-02-01  Mario Sanchez Prada  <msanchez@igalia.com>
3088
3089         Reviewed by Martin Robinson.
3090
3091         [GTK] character range extents is off when the end of a wrapped line is included
3092         https://bugs.webkit.org/show_bug.cgi?id=53323
3093
3094         Update unit test to check the fix for this bug.
3095
3096         * tests/testatk.c:
3097         (testWebkitAtkGetExtents): Check that the extent for a full line
3098         are the same height than for a partial section of the same line.
3099
3100 2011-02-01  Mario Sanchez Prada  <msanchez@igalia.com>
3101
3102         Reviewed by Martin Robinson.
3103
3104         [GTK] Caret Offset is one off at the end of wrapped lines
3105         https://bugs.webkit.org/show_bug.cgi?id=53300
3106
3107         Update unit test to check the fix for this bug.
3108
3109         * tests/testatk.c:
3110         (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get
3111         the caret offset at the edge of the line.
3112
3113 2011-01-31  Mario Sanchez Prada  <msanchez@igalia.com>
3114
3115         Reviewed by Martin Robinson.
3116
3117         [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
3118         https://bugs.webkit.org/show_bug.cgi?id=53389
3119
3120         New unit test to check the fix for this bug.
3121
3122         * tests/testatk.c:
3123         (testWebkitAtkCaretOffsets): New.
3124         (main): Add new test.
3125
3126 2011-01-29  Dan Winship  <danw@gnome.org>
3127
3128         Reviewed by Xan Lopez.
3129
3130         [GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals;
3131         we depend on glib 2.27.4 and libsoup 2.33.1 now.
3132         https://bugs.webkit.org/show_bug.cgi?id=50675
3133
3134         * GNUmakefile.am:
3135         * WebCoreSupport/InspectorClientGtk.cpp:
3136         (WebKit::InspectorClient::storeSetting):
3137         * webkit/webkitprivate.cpp:
3138         (inspectorGSettings):
3139         * webkit/webkitprivate.h:
3140
3141 2011-01-28  Dan Bernstein  <mitz@apple.com>
3142
3143         Reviewed by Sam Weinig.
3144
3145         <select> can't display right-to-left (rtl) languages
3146         https://bugs.webkit.org/show_bug.cgi?id=19785
3147
3148         * WebCoreSupport/ChromeClientGtk.cpp:
3149         (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
3150         * WebCoreSupport/ChromeClientGtk.h:
3151
3152 2011-01-28  Alejandro G. Castro  <alex@igalia.com>
3153
3154         Reviewed by Xan Lopez.
3155
3156         [GTK] Fix compilation warning
3157         https://bugs.webkit.org/show_bug.cgi?id=53292
3158
3159         * webkit/webkitwebframe.cpp:
3160         (draw_page_callback): Cast the pageCount from size_t to int, it
3161         should be safe considering page_nr is the number of pages,
3162         0-based.
3163
3164 2011-01-27  Nate Chapin  <japhet@chromium.org>
3165
3166         Reviewed by Adam Barth.
3167
3168         Use Document::url() instead of FrameLoader::url().
3169         https://bugs.webkit.org/show_bug.cgi?id=41165
3170
3171         * webkit/webkitwebview.cpp:
3172         (webkit_web_view_get_icon_uri):
3173
3174 2011-01-27  Mario Sanchez Prada  <msanchez@igalia.com>
3175
3176         Reviewed by Martin Robinson.
3177
3178         [GTK] Space characters in source document interfere with reported caret offset
3179         https://bugs.webkit.org/show_bug.cgi?id=53033
3180
3181         New unit test to check the fix for this bug.
3182
3183         * tests/testatk.c:
3184         (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): New.
3185         (main): Add new unit test.
3186
3187 2011-01-26  Mario Sanchez Prada  <msanchez@igalia.com>
3188
3189         Reviewed by Martin Robinson.
3190
3191         [GTK] Reliable crash with getTextAtOffset()
3192         https://bugs.webkit.org/show_bug.cgi?id=53131
3193
3194         New unit test to check the fix for this bug.
3195
3196         * tests/testatk.c:
3197         (testWebkitAtkGetTextAtOffsetWithSpecialCharacters): New.
3198         (main): Add new unit test.
3199
3200 2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3201
3202         Reviewed by Martin Robinson.
3203
3204         [GTK] Show caps lock indicator in password fields
3205         https://bugs.webkit.org/show_bug.cgi?id=52878
3206
3207         Test: manual-tests/password-caps-lock.html
3208
3209         * webkit/webkitwebview.cpp:
3210         (webkit_web_view_key_release_event): Call
3211         capsLockStateMayHaveChanged() when caps lock key is pressed.
3212
3213 2011-01-19  Joone Hur  <joone.hur@collabora.co.uk>
3214
3215         Reviewed by Andreas Kling.
3216
3217         [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow
3218         https://bugs.webkit.org/show_bug.cgi?id=52702
3219
3220         Don't call gdk_window_invalidate_rect if an updated rectangle is empty.
3221
3222         * WebCoreSupport/ChromeClientGtk.cpp:
3223         (WebKit::ChromeClient::invalidateContentsAndWindow):
3224
3225 2011-01-17  Philippe Normand  <pnormand@igalia.com>
3226
3227         Unreviewed, build fix for 2 GTK tests html file paths.
3228
3229         * tests/testmimehandling.c:
3230         (main):
3231         * tests/testwebview.c:
3232
3233 2011-01-16  Adam Barth  <abarth@webkit.org>
3234
3235         Rubber-stamped by Eric Seidel.
3236
3237         Move WebKit into Source
3238         https://bugs.webkit.org/show_bug.cgi?id=52530
3239
3240         * GNUmakefile.am:
3241
3242 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
3243
3244         Reviewed by Antti Koivisto.
3245
3246         Rename cache() to memoryCache()
3247         https://bugs.webkit.org/show_bug.cgi?id=52433
3248
3249         * webkit/webkitglobals.cpp:
3250         (webkit_set_cache_model):
3251
3252 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3253
3254         Not reviewed: gtk build fix (2).
3255
3256         * webkit/webkitwebview.cpp:
3257
3258 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
3259
3260         Not reviewed: gtk build fix.
3261
3262         * webkit/webkitwebinspector.cpp:
3263
3264 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
3265
3266         Reviewed by Martin Robinson.
3267
3268         [gtk] Zero-sized font does not yet work
3269         https://bugs.webkit.org/show_bug.cgi?id=49793
3270
3271         Allow 0 as a minimum-font-size value for the settings.
3272
3273         * webkit/webkitwebsettings.cpp:
3274         (webkit_web_settings_class_init):
3275
3276 2011-01-12  Philippe Normand  <pnormand@igalia.com>
3277
3278         Unreviewed build fix for 32-bits Release. Include GRefPtrGtk.h so
3279         the GdkCursor templates are found and used at runtime.
3280
3281         * WebCoreSupport/FullscreenVideoController.cpp:
3282
3283 2011-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3284
3285         Reviewed by Martin Robinson.
3286
3287         [GTK] GRefPtr should not be used with Gtk widgets
3288         https://bugs.webkit.org/show_bug.cgi?id=51241
3289
3290         GRefPtr breaks the widget life-cycle, the main problem is
3291         that GRefPtr calls g_object_unref() when it's destroyed,
3292         which is undesirable for widgets. In gtk+ widgets are created with
3293         a floating reference and when added to a container, the container
3294         takes the ownership of the widget consuming the floating
3295         reference. So you don't usually need to call g_object_ref/unref on
3296         widgets (only for some operations like reparent a widget) and
3297         toplevel widgets are destroyed with gtk_widget_destroy().
3298
3299         * WebCoreSupport/DragClientGtk.cpp:
3300         (WebKit::DragClient::DragClient):
3301         (WebKit::DragClient::~DragClient):
3302         (WebKit::DragClient::startDrag):
3303         * WebCoreSupport/DragClientGtk.h:
3304         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3305         (WebKit::postCommitFrameViewSetup):
3306         * webkit/webkitwebview.cpp:
3307         (webkit_web_view_dispose):
3308         * webkit/webkitwebviewprivate.h:
3309
3310 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3311
3312         Reviewed by Xan Lopez.
3313
3314         Update the NEWS file in preparation for the 1.3.10 release.
3315
3316         * NEWS: Update the NEWS.
3317
3318 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3319
3320         Reviewed by Xan Lopez.
3321
3322         [GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release
3323         https://bugs.webkit.org/show_bug.cgi?id=52173
3324
3325         * WebCoreSupport/FullscreenVideoController.cpp:
3326         (FullscreenVideoController::enterFullscreen): Use a GRefPtr here to avoid having to
3327         call either g_object_unref or gdk_cursor_unref.
3328         * webkit/webkitwebview.cpp: Guard use of deprecated methods.
3329         (webkit_web_view_realize): Ditto.
3330         (webkit_web_view_drag_end): Ditto.
3331
3332 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3333
3334         Reviewed by Xan Lopez.
3335
3336         [GTK] Fix gtk2 compilation for master
3337         https://bugs.webkit.org/show_bug.cgi?id=51885
3338
3339         * webkit/webkitsoupauthdialog.c:
3340         (show_auth_dialog): Removed the call to
3341         gtk_dialog_set_has_separator API to remove a warning.
3342
3343 2011-01-10  Xan Lopez  <xlopez@igalia.com>
3344
3345         Reviewed by Martin Robinson.
3346
3347         [GTK] Create intermediate libWebCore library
3348         https://bugs.webkit.org/show_bug.cgi?id=52116
3349
3350         * GNUmakefile.am: add libWebCore.la to LIBADD and remove webcore
3351         sources from the libwebkit library SOURCES.
3352
3353 2011-01-09  Xianzhu Wang <phnixwxz@gmail.com>
3354
3355         Reviewed by Darin Fisher.
3356
3357         https://bugs.webkit.org/show_bug.cgi?id=41441
3358         createWindow method should only do window-creating without URL navigation
3359
3360         * WebCoreSupport/ChromeClientGtk.cpp:
3361         (WebKit::ChromeClient::createWindow):
3362
3363 2011-01-08  Martin Robinson  <mrobinson@igalia.com>
3364
3365         GTK+ build fix. Adding missing headers to the source list, fixing make dist.
3366
3367         * GNUmakefile.am: Fix make dist.
3368
3369 2011-01-07  Adam Barth  <abarth@webkit.org>
3370
3371         Rubber-stamped by Eric Seidel.
3372
3373         Move WebCore to Source
3374         https://bugs.webkit.org/show_bug.cgi?id=52050
3375
3376         * GNUmakefile.am:
3377
3378 2011-01-07  Mario Sanchez Prada  <msanchez@igalia.com>
3379
3380         Reviewed by Chris Fleizach.
3381
3382         GTK: AX: atk tests need to be updated after recent changes
3383         https://bugs.webkit.org/show_bug.cgi?id=51932
3384
3385         Fix gtk_widget_get_accessible() in WebKitWebView to keep returning
3386         the AtkObject of role ATK_ROLE_DOCUMENT_FRAME.
3387
3388         With the change to support WK2 accessibility, the root object of
3389         the AX hierarchy is different from what GTK expects as the current
3390         hirarchy right now includes a new accessible object as the parent
3391         of the accessible web area (AXScrollView).
3392
3393         * webkit/webkitwebview.cpp:
3394         (webkit_web_view_get_accessible): Return the first child of the
3395         wrapper associated to the root accessible object in the document,
3396         to keep everything in the GTK port working as it used to be.
3397
3398         Re-enable skipped ATK unit tests now they are passing again.
3399
3400         * tests/testatk.c:
3401         (main): Re-enable skipped tests.
3402         * tests/testatkroles.c:
3403         (main): Ditto.
3404
3405 2011-01-06  Martin Robinson  <mrobinson@igalia.com>
3406
3407         Reviewed by Xan Lopez.
3408
3409         GTK: AX: atk tests need to be updated after recent changes
3410         https://bugs.webkit.org/show_bug.cgi?id=51932
3411
3412         Skip ATK unit tests until we can look into what is causing these failures.
3413
3414         * tests/testatk.c:
3415         (main): Skip all tests.
3416         * tests/testatkroles.c:
3417         (main): Ditto.
3418
3419 2011-01-06  Martin Robinson  <mrobinson@igalia.com>
3420
3421         Reviewed by Xan Lopez.
3422
3423         Include a new header in the static headers list. This is necessary
3424         so that "make install" installs the header.
3425
3426         * GNUmakefile.am: Include webkitglobals.h in the header list.
3427
3428 2011-01-05  Martin Robinson  <mrobinson@igalia.com>
3429
3430         Reviewed by Gustavo Noronha.
3431
3432         Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
3433         GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
3434         so this call is unnecessary.
3435
3436         * WebCoreSupport/FullscreenVideoController.cpp:
3437         (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().
3438
3439 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3440
3441         Reviewed by Martin Robinson.
3442
3443         GTK: AX: DRT needs to use correct root object method.
3444         https://bugs.webkit.org/show_bug.cgi?id=51911
3445
3446         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3447         (DumpRenderTreeSupportGtk::getRootAccessibleElement):
3448         (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
3449         * WebCoreSupport/DumpRenderTreeSupportGtk.h:
3450
3451 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3452
3453         Reviewed by Sam Weinig.
3454
3455         WK2: Support Accessibility
3456         https://bugs.webkit.org/show_bug.cgi?id=51859
3457
3458         Use rootObject() method to get top of ax tree.
3459
3460         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3461         (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
3462         * webkit/webkitwebview.cpp:
3463         (webkit_web_view_get_accessible):
3464
3465 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3466
3467         Reviewed by Darin Adler.
3468
3469         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3470         https://bugs.webkit.org/show_bug.cgi?id=51846
3471
3472         Changed all references to PlatformRefPtr in GTK+ code to GRefPtr.
3473
3474 2011-01-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3475
3476         Reviewed by Martin Robinson.
3477
3478         [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
3479         https://bugs.webkit.org/show_bug.cgi?id=50698
3480
3481         Final patch, removing webkitprivate.{cpp,h}, and adding a
3482         webkitglobals module to hold non-object-specific functions and
3483         definitions that do not make sense on their own.
3484
3485         * GNUmakefile.am:
3486         * WebCoreSupport/ChromeClientGtk.cpp:
3487         (WebKit::ChromeClient::createWindow):
3488         * WebCoreSupport/ContextMenuClientGtk.cpp:
3489         * WebCoreSupport/DocumentLoaderGtk.cpp:
3490         (WebKit::DocumentLoader::attachToFrame):
3491         * WebCoreSupport/DragClientGtk.cpp:
3492         * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
3493         * WebCoreSupport/EditorClientGtk.cpp:
3494         (WebKit::EditorClient::ignoreWordInSpellDocument):
3495         (WebKit::EditorClient::learnWord):
3496         (WebKit::EditorClient::checkSpellingOfString):
3497         (WebKit::EditorClient::getGuessesForWord):
3498         * WebCoreSupport/FrameLoaderClientGtk.cpp:
3499         (WebKit::FrameLoaderClient::createDocumentLoader):
3500         * WebCoreSupport/InspectorClientGtk.cpp:
3501         * webkit/webkit.h:
3502         * webkit/webkitapplicationcache.cpp:
3503         (webkit_application_cache_set_maximum_size):
3504         * webkit/webkitdownload.cpp:
3505         (webkit_download_class_init):
3506         * webkit/webkitgeolocationpolicydecision.cpp:
3507         * webkit/webkitglobals.cpp: Added.
3508         (webkit_get_default_session):
3509         (webkit_set_cache_model):
3510         (webkit_get_cache_model):
3511         (webkit_get_web_plugin_database):
3512         (currentToplevelCallback):
3513         (closeIconDatabaseOnExit):
3514         (webkitInit):
3515         (WebKit::pasteboardHelperInstance):
3516         * webkit/webkitglobals.h: Added.
3517         * webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h.
3518         * webkit/webkithittestresult.cpp:
3519         (webkit_hit_test_result_class_init):
3520         * webkit/webkitnetworkrequest.cpp:
3521         (webkit_network_request_class_init):
3522         * webkit/webkitnetworkresponse.cpp:
3523         (webkit_network_response_class_init):
3524         * webkit/webkitprivate.cpp: Removed.
3525         * webkit/webkitprivate.h: Removed.
3526         * webkit/webkitsecurityorigin.cpp:
3527         * webkit/webkitviewportattributes.cpp:
3528         * webkit/webkitwebbackforwardlist.cpp:
3529         (webkit_web_back_forward_list_class_init):
3530         * webkit/webkitwebdatabase.cpp:
3531         * webkit/webkitwebdatasource.cpp:
3532         (webkit_web_data_source_class_init):
3533         (webkit_web_data_source_new_with_request):
3534         (WebKit::kitNew):
3535         * webkit/webkitwebframe.cpp:
3536         (webkit_web_frame_class_init):
3537         * webkit/webkitwebframeprivate.h:
3538         * webkit/webkitwebhistoryitem.cpp:
3539         (webkit_web_history_item_class_init):
3540         * webkit/webkitwebinspector.cpp:
3541         * webkit/webkitwebnavigationaction.cpp:
3542         * webkit/webkitwebplugin.cpp:
3543         (webkit_web_plugin_class_init):
3544         * webkit/webkitwebplugindatabase.cpp:
3545         (webkit_web_plugin_database_class_init):
3546         * webkit/webkitwebpluginprivate.h:
3547         * webkit/webkitwebpolicydecision.cpp:
3548         * webkit/webkitwebresource.cpp:
3549         * webkit/webkitwebsettings.cpp:
3550         (webkit_web_settings_class_init):
3551         (webkitWebViewGetEnchantDicts):
3552         (WebKit::core):
3553         * webkit/webkitwebsettingsprivate.h:
3554         * webkit/webkitwebview.cpp:
3555         (webkit_web_view_class_init):
3556         (webkit_web_view_update_settings):
3557         (webkit_web_view_settings_notify):
3558         * webkit/webkitwebview.h:
3559         * webkit/webkitwebwindowfeatures.cpp:
3560         (webkit_web_window_features_class_init):
3561         (WebKit::kitNew):
3562
3563 2011-01-02  Xan Lopez  <xlopez@igalia.com>
3564
3565         Fix GTK+ build.
3566
3567         * GNUmakefile.am: tests do actually include JSC.
3568
3569 2011-01-02  Xan Lopez  <xlopez@igalia.com>
3570
3571         Fix GTK+ build.
3572
3573         * GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll
3574         already get them from javascriptcore_cppflags, and add it for the
3575         introspection build (which is not tested in the bots).
3576
3577 2011-01-02  Adam Barth  <abarth@webkit.org>
3578
3579         Speculative build fix for GTK.  Add Source to the include paths.
3580
3581         * GNUmakefile.am:
3582