1 2012-05-31 Sheriff Bot <webkit.review.bot@gmail.com>
3 Unreviewed, rolling out r119113.
4 http://trac.webkit.org/changeset/119113
5 https://bugs.webkit.org/show_bug.cgi?id=88016
7 This caused multiple regressions (Requested by mrobinson on
10 * WebCoreSupport/TextCheckerClientGtk.cpp:
11 (WebKit::TextCheckerClientGtk::checkSpellingOfString):
12 * webkit/webkitspellcheckerenchant.cpp:
13 (checkSpellingOfString):
15 2012-05-31 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
17 [GTK] Memory leak in webkit_web_view_init
18 https://bugs.webkit.org/show_bug.cgi?id=87943
20 Reviewed by Martin Robinson.
22 Fixed a memory leak in webkit_web_view_init by making the
23 UserMediaClientGtk to be owned by the WebView.
25 * webkit/webkitwebview.cpp:
26 (webkit_web_view_init):
27 * webkit/webkitwebviewprivate.h:
29 2012-05-31 Martin Robinson <mrobinson@igalia.com>
31 Spell checker doesn't recognize contractions (apostrophes)
32 https://bugs.webkit.org/show_bug.cgi?id=86118
34 Reviewed by Gustavo Noronha Silva.
36 The Enchant spell checker was breaking words on apostrophes, because
37 apparently they were always being detected as Pango word-end
38 characters. To know whether or not the apostrophe is a
39 word end character requires looking at a string with a larger
40 granularity than one character.
42 Simplify the way the we break strings, by search for non-graphable
43 character manually to find word starts and ends. This has the side
44 effect of removing the dependency on Pango and eliminating one copy.
46 This change also cleans up some misbehavior on the part of the
47 WebCoreSupport layer which was not converting from Unicode character
48 offsets to UTF-16. These offsets can be different if any of the
49 characters in the UTF-16 string are surrogate pairs (non BMP
52 * WebCoreSupport/TextCheckerClientGtk.cpp:
53 (WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
54 convert from Unicode offsets to UTF-16 offsets.
55 * webkit/webkitspellcheckerenchant.cpp:
56 (findByteOffsetToFirstNonGraphableCharacter): Added this helper.
57 (getExtentsOfNextWord): Ditto.
58 (wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
59 (checkSpellingOfString): Don't split words on apostrophes.
61 2012-05-30 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
63 [GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
64 https://bugs.webkit.org/show_bug.cgi?id=87756
66 Reviewed by Carlos Garcia Campos.
68 Fixed a memory leak in drag and drop by using adoptRef instead
69 of just getting a new reference of targetList.
71 * WebCoreSupport/DragClientGtk.cpp:
72 (WebKit::DragClient::startDrag):
74 2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
76 WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
77 https://bugs.webkit.org/show_bug.cgi?id=42328
79 Reviewed by Eric Seidel.
81 * webkit/webkitwebinspector.cpp:
82 (webkit_web_inspector_set_property):
84 2012-05-25 Lu Guanqun <guanqun.lu@intel.com>
86 [GTK] fix compilation for webkitwebview.cpp
87 https://bugs.webkit.org/show_bug.cgi?id=87473
89 Reviewed by Martin Robinson.
91 When ACCELERATED_COMPOSITING and TEXTURE_MAPPER_GL is not set,
92 the local variable 'priv' won't be used. Therefore the following warning:
94 ../../../Source/WebKit/gtk/webkit/webkitwebview.cpp: In function ‘void webkit_web_view_realize(GtkWidget*)’:
95 ../../../Source/WebKit/gtk/webkit/webkitwebview.cpp:971:27: warning: unused variable ‘priv’ [-Wunused-variable]
97 * webkit/webkitwebview.cpp:
98 (webkit_web_view_realize):
100 == Rolled over to ChangeLog-2012-05-22 ==