1 2012-04-23 Raphael Kubo da Costa <rakuco@webkit.org>
3 [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
4 https://bugs.webkit.org/show_bug.cgi?id=84634
6 Reviewed by Gustavo Noronha Silva.
8 Drop unnecessary const char* -> WTF::String conversions by
9 creating String objects directly in LayoutTestController out of
10 JSStringRef's and passing them to DumpRenderTreeSupportEfl.
12 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
13 (DumpRenderTreeSupportEfl::setValueForUser):
14 (DumpRenderTreeSupportEfl::addUserStyleSheet):
15 (DumpRenderTreeSupportEfl::findString):
16 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
18 2012-05-08 Krzysztof Czech <k.czech@samsung.com>
20 [EFL] Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
21 https://bugs.webkit.org/show_bug.cgi?id=84588
23 Reviewed by Eric Seidel.
25 In ewk_frame_contents_alternate_set, param unreachableUri is required, must not be 0.
26 In ewk_view_zoom_range_set, function returns EINA_FALSE only on failure,
27 not when zoom range is changed.
32 2012-05-07 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
34 [EFL] Page caching permission from EFL's FrameLoaderClient
35 https://bugs.webkit.org/show_bug.cgi?id=85620
37 Reviewed by Gustavo Noronha Silva.
39 FrameLoaderClientEfl::canCachePage() returns true.
41 * WebCoreSupport/FrameLoaderClientEfl.cpp:
42 (WebCore::FrameLoaderClientEfl::canCachePage):
44 2012-05-07 Grzegorz Czajkowski <g.czajkowski@samsung.com>
46 [EFL] Icon database path may be NULL when a new path was set.
47 https://bugs.webkit.org/show_bug.cgi?id=82456
49 Reviewed by Andreas Kling.
51 ewk_settings_icon_database_path_set calls asynchronous method WebCore::iconDatabase().open().
52 There is no notification when the new path is set by WebCore.
53 Moreover ewk_settings_icon_database_path_set keeps the new path in a local variable.
55 To retrieve path to icon database ewk_settings_icon_database_path_get can be called.
56 It first checks flags whether icon databse is opened and enabled. There is possibility
57 that icon database has been set through API but it hasn't been opened by WebCore yet.
58 So as a result ewk_settings_icon_database_path_get returns NULL because WebCore hasn't
59 set an appropriate flag yet.
61 It may happen while icon database set/get sequences.
62 Information whether icon database is opened/enabled should be exposed by separate API.
64 * ewk/ewk_settings.cpp:
65 (ewk_settings_icon_database_path_get): Skip checking whether icon database is opened, enabled.
68 2012-05-07 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
70 [EFL][DRT] Implement LayoutTestController::execCommand
71 https://bugs.webkit.org/show_bug.cgi?id=82286
73 Reviewed by Antonio Gomes.
75 Add missing implementation execCommand and isCommandEnabled to EFL's
76 DumpRenderTreeSupport to execute an internal command and check if the
79 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
80 (DumpRenderTreeSupportEfl::executeCoreCommandByName):
81 (DumpRenderTreeSupportEfl::isCommandEnabled):
82 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
84 2012-05-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
86 [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
87 https://bugs.webkit.org/show_bug.cgi?id=83687
89 Reviewed by Antonio Gomes.
92 (_Ewk_View_Private_Data):
94 (ewk_view_setting_scripts_can_access_clipboard_get):
95 (ewk_view_setting_scripts_can_access_clipboard_set):
98 2012-05-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
100 Convert isPageBoxVisible to use Internals interface.
101 https://bugs.webkit.org/show_bug.cgi?id=85692
103 Reviewed by Darin Adler.
105 Remove isPageBoxVisible functions, because it is able to work in the
106 cross-port way through the Internals interface.
108 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
109 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
111 2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
113 [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
114 https://bugs.webkit.org/show_bug.cgi?id=84941
116 Reviewed by Martin Robinson.
118 Extend Ewk_Frame_Resource_Response structure to pass resource MIME type
121 * WebCoreSupport/FrameLoaderClientEfl.cpp:
122 (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
123 (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
126 2012-05-04 Nate Chapin <japhet@chromium.org>
128 Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
129 https://bugs.webkit.org/show_bug.cgi?id=85533
131 Reviewed by Alexey Proskuryakov.
133 * WebCoreSupport/FrameLoaderClientEfl.cpp:
134 (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl):
136 (WebCore::FrameLoaderClientEfl::finishedLoading):
137 * WebCoreSupport/FrameLoaderClientEfl.h:
138 (WebCore::FrameLoaderClientEfl::makeRepresentation):
139 (WebCore::FrameLoaderClientEfl::revertToProvisionalState):
140 (FrameLoaderClientEfl):
142 2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
144 [EFL] Frame load callbacks output is missing for redirections
145 https://bugs.webkit.org/show_bug.cgi?id=85173
147 Reviewed by Antonio Gomes.
149 Add a few redirection-related signals on the ewk_frame so that EFL's
150 DumpRenderTree can print the expected output when
151 LayoutTestController's dumpFrameLoadCallbacks() returns true.
153 * WebCoreSupport/FrameLoaderClientEfl.cpp:
154 (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
155 (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
156 (WebCore::FrameLoaderClientEfl::dispatchDidReceiveServerRedirectForProvisionalLoad):
157 (WebCore::FrameLoaderClientEfl::dispatchWillPerformClientRedirect):
159 (ewk_frame_redirect_provisional_load):
160 (ewk_frame_redirect_requested):
164 2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
166 [EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
167 https://bugs.webkit.org/show_bug.cgi?id=85171
169 Reviewed by Andreas Kling.
171 Add a helper function to DumpRenderTreeSupportEfl to override the
172 "WebKitLoadSiteIconsKey" setting on the view page.
174 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
175 (DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
176 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
178 2012-05-03 Fady Samuel <fsamuel@chromium.org>
180 Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
181 https://bugs.webkit.org/show_bug.cgi?id=70609
183 Reviewed by Kenneth Rohde Christiansen.
185 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
186 (DumpRenderTreeSupportEfl::dumpConfigurationForViewport):
188 2012-04-18 Jon Honeycutt <jhoneycutt@apple.com>
190 FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
191 information about the form being submitted
192 https://bugs.webkit.org/show_bug.cgi?id=84297
194 Reviewed by Andy Estes.
196 * WebCoreSupport/FrameLoaderClientEfl.h:
197 (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):
198 Updated method declaration.
200 2012-05-02 Emil A Eklund <eae@chromium.org>
202 Fix usage of layout types in platform code
203 https://bugs.webkit.org/show_bug.cgi?id=85392
205 Reviewed by Eric Seidel.
208 (ewk_frame_focused_element_geometry_get):
210 (_Ewk_View_Private_Data):
211 (ewk_view_scale_set):
213 2012-05-02 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
215 [EFL] Hyperlink auditing ewk_view setting
216 https://bugs.webkit.org/show_bug.cgi?id=84451
218 Reviewed by Antonio Gomes.
220 Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing.
223 (_Ewk_View_Private_Data):
224 (_ewk_view_priv_new):
225 (ewk_view_setting_enable_hyperlink_auditing_get):
226 (ewk_view_setting_enable_hyperlink_auditing_set):
229 2012-05-02 Dongwoo Im <dw.im@samsung.com>
231 [EFL] Fix typo introduced in r115800.
232 https://bugs.webkit.org/show_bug.cgi?id=85354
234 Reviewed by Nikolas Zimmermann.
237 (_Ewk_View_Private_Data): Assign 1 bit to the boolean attribute, webAudio.
239 2012-05-02 Dongwoo Im <dw.im@samsung.com>
241 [EFL] Implement the Web Audio API feature.
242 https://bugs.webkit.org/show_bug.cgi?id=78688
244 Reviewed by Philippe Normand.
246 Implement the Web Audio API feature on the EFL port.
247 https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
249 * ewk/ewk_view.cpp: Add the setter/getter of the webaudio feature.
250 (_Ewk_View_Private_Data):
251 (_ewk_view_priv_new):
252 (ewk_view_setting_web_audio_get): Enable/disable the Web Audio API feature.
253 (ewk_view_setting_web_audio_set): Query if the Web Audio API feature is enabled.
254 * ewk/ewk_view.h: Add the prototypes.
256 2012-04-27 Christophe Dumez <christophe.dumez@intel.com>
258 [EFL] ResourceError domain needs to be properly set in FrameLoaderClient
259 https://bugs.webkit.org/show_bug.cgi?id=84129
261 Reviewed by Nate Chapin.
263 Properly set ResourceError objects' domain instead of using a generic
264 one. This allows WebKit and NSURL errors to be distinguished, which is
265 required to properly print out information in EFL's DumpRenderTree
266 when dumpResourceLoadCallbacks() returns true.
268 * WebCoreSupport/FrameLoaderClientEfl.cpp:
269 (WebCore::FrameLoaderClientEfl::cancelledError):
270 (WebCore::FrameLoaderClientEfl::blockedError):
271 (WebCore::FrameLoaderClientEfl::cannotShowURLError):
272 (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
273 (WebCore::FrameLoaderClientEfl::cannotShowMIMETypeError):
274 (WebCore::FrameLoaderClientEfl::fileDoesNotExistError):
275 (WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError):
277 2012-04-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
279 [EFL] tabsToLinks ewk_view setting
280 https://bugs.webkit.org/show_bug.cgi?id=84340
282 Exporting new ewk_view setting: tabsToLinks - enbles/disables tab key focusing of page elements.
284 Reviewed by Antonio Gomes.
286 * WebCoreSupport/ChromeClientEfl.cpp:
287 (WebCore::ChromeClientEfl::keyboardUIMode):
289 (_Ewk_View_Private_Data):
290 (_ewk_view_priv_new):
291 (ewk_view_setting_include_links_in_focus_chain_get):
292 (ewk_view_setting_include_links_in_focus_chain_set):
295 2012-04-27 Christophe Dumez <christophe.dumez@intel.com>
297 [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
298 https://bugs.webkit.org/show_bug.cgi?id=81891
300 Reviewed by Philippe Normand.
302 New "load,resource,finished", "load,resource,failed", and
303 "resource,response,received" signals were added to notify about different
304 resource load events. These additional signals are needed for proper
305 support of LayoutTestController's dumpResourceLoadCallbacks() in EFL's
308 * WebCoreSupport/FrameLoaderClientEfl.cpp:
309 (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
310 (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
311 (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoading):
312 (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading):
314 (ewk_frame_response_received):
315 (ewk_frame_load_finished):
316 (ewk_frame_load_resource_finished):
317 (ewk_frame_load_resource_failed):
318 (ewk_frame_load_error):
323 2012-04-26 Martin Robinson <mrobinson@igalia.com>
325 [Cairo] Wrap cairo surfaces in a class when storing native images
326 https://bugs.webkit.org/show_bug.cgi?id=83611
328 Reviewed by Alejandro G. Castro.
330 * ewk/ewk_history.cpp: Updated to reflect addition of NativeImageCario.
331 * ewk/ewk_settings.cpp: Ditto.
333 2012-04-26 Christophe Dumez <christophe.dumez@intel.com>
335 [EFL] Enable VIDEO_TRACK feature
336 https://bugs.webkit.org/show_bug.cgi?id=84830
338 Reviewed by Gustavo Noronha Silva.
340 Add functions on the ewk_view to toggle runtime support for text
341 tracks in HTML5 video.
344 (_Ewk_View_Private_Data):
345 (_ewk_view_priv_new):
346 (ewk_view_setting_should_display_subtitles_get):
347 (ewk_view_setting_should_display_subtitles_set):
348 (ewk_view_setting_should_display_captions_get):
349 (ewk_view_setting_should_display_captions_set):
350 (ewk_view_setting_should_display_text_descriptions_get):
351 (ewk_view_setting_should_display_text_descriptions_set):
354 2012-04-26 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
356 [EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
357 https://bugs.webkit.org/show_bug.cgi?id=84576
359 Reviewed by Martin Robinson.
361 Add missing implementation setJavaScriptProfilingEnabled to EFL's
362 DumpRenderTreeSupport. This setting allows layout tests to start
363 JavaScript profiling.
365 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
366 (DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled):
367 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
369 2012-04-26 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
371 [EFL] WebGL support ewk_view setting
372 https://bugs.webkit.org/show_bug.cgi?id=84534
374 Reviewed by Antonio Gomes.
376 Exporting new ewk_view setting: webGLEnabled - enbles/disables WebGL support.
379 (_Ewk_View_Private_Data):
380 (_ewk_view_priv_new):
381 (ewk_view_setting_enable_webgl_get):
382 (ewk_view_setting_enable_webgl_set):
385 2012-04-26 Christophe Dumez <christophe.dumez@intel.com>
387 [EFL][DRT] "resource,request,willsend" signal needs to provide more information
388 https://bugs.webkit.org/show_bug.cgi?id=84670
390 Reviewed by Andreas Kling.
392 The "resource,request,willsend" signal now provides more information
393 about the network request as well as information about the possible
394 redirect response. This extra information will be needed to support
395 LayoutTestController's dumpResourceLoadCallbacks() in EFL's
398 * WebCoreSupport/FrameLoaderClientEfl.cpp:
399 (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
400 (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
401 (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
403 (ewk_frame_request_will_send):
408 2012-04-23 Christophe Dumez <christophe.dumez@intel.com>
410 [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
411 https://bugs.webkit.org/show_bug.cgi?id=84425
413 Reviewed by Antonio Gomes.
415 Add a helper function to DumpRenderTreeSupportEfl, returning
416 whether or not an element does perform autocompletion.
418 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
419 (DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
420 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
422 2012-04-20 Thiago Marcos P. Santos <thiago.santos@intel.com>
424 [EFL] Add Security Origin API
425 https://bugs.webkit.org/show_bug.cgi?id=84023
427 Added an API to get a Security Origin handle from a Ewk_Frame. This is
428 needed for fine grained security policy. This new API will also allow
429 to define quota and get usage information of a Web Storage based on its
432 Reviewed by Antonio Gomes.
436 (ewk_frame_security_origin_get):
438 * ewk/ewk_security_origin.cpp: Added.
439 (ewk_security_origin_protocol_get):
440 (ewk_security_origin_host_get):
441 (ewk_security_origin_port_get):
442 (ewk_security_origin_web_database_usage_get):
443 (ewk_security_origin_web_database_quota_get):
444 (ewk_security_origin_web_database_quota_set):
445 (ewk_security_origin_free):
446 (ewk_security_origin_new):
447 * ewk/ewk_security_origin.h: Added.
449 2012-04-20 Kamil Blank <k.blank@samsung.com>
451 [EFL] Add setting API for author and user styles.
452 https://bugs.webkit.org/show_bug.cgi?id=82860
454 Reviewed by Daniel Bates.
456 Add missing implementation setAuthorAndUserStylesEnabled to EFL's
457 DumpRenderTreeSupport.
459 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
461 2012-04-19 Christophe Dumez <christophe.dumez@intel.com>
463 [EFL] dispatchDidCancelClientRedirect needs implementation
464 https://bugs.webkit.org/show_bug.cgi?id=83669
466 Reviewed by Antonio Gomes.
468 Emit a new "redirect,cancelled" signal on the ewk_frame when a
469 redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
470 frame load callbacks information.
472 * WebCoreSupport/FrameLoaderClientEfl.cpp:
473 (WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):
475 (ewk_frame_redirect_cancelled):
479 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
481 EFL's LayoutTestController does not implement callShouldCloseOnWebView
482 https://bugs.webkit.org/show_bug.cgi?id=82301
484 Reviewed by Martin Robinson.
486 Implement callShouldCloseOnWebView in EFL's LayoutTestController by
487 calling shouldClose() on the FrameLoader, allowing the related
488 test to be removed from the skip list.
490 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
491 (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
492 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
494 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
496 [EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one
497 https://bugs.webkit.org/show_bug.cgi?id=84052
499 Reviewed by Antonio Gomes.
501 Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
502 postProgressFinishedNotification() in order to send notifications all frames,
503 not just the main one.
505 * WebCoreSupport/FrameLoaderClientEfl.cpp:
506 (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
507 (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
508 (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
510 2012-04-17 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
512 [EFL] Add setting API to enable/disable XSSAuditor
513 https://bugs.webkit.org/show_bug.cgi?id=83281
515 Add setting API to enable or disable WebKit's XSSAuditor to protect
516 from reflective cross-site scripting attacks. Also, emit the signal
517 'xss,detected' and provide addition information received from
518 XSSAuditor when reflected XSS is encountered in the page.
520 Reviewed by Antonio Gomes.
522 * WebCoreSupport/FrameLoaderClientEfl.cpp:
523 (WebCore::FrameLoaderClientEfl::didDetectXSS):
525 (ewk_frame_xss_detected):
529 (_Ewk_View_Private_Data):
530 (_ewk_view_priv_new):
531 (ewk_view_setting_enable_xss_auditor_get):
532 (ewk_view_setting_enable_xss_auditor_set):
535 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
537 [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
538 https://bugs.webkit.org/show_bug.cgi?id=83030
540 Reviewed by Antonio Gomes.
542 Emit "load,started" and "onload,event" signals needed to support
543 LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.
545 * WebCoreSupport/FrameLoaderClientEfl.cpp:
546 (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
547 (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
548 (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
550 (ewk_frame_load_committed):
551 (ewk_frame_load_started):
555 (_Ewk_View_Private_Data):
556 (ewk_view_load_started):
557 (ewk_view_onload_event):
560 2012-04-17 Sheriff Bot <webkit.review.bot@gmail.com>
562 Unreviewed, rolling out r114376.
563 http://trac.webkit.org/changeset/114376
564 https://bugs.webkit.org/show_bug.cgi?id=84155
566 Wrong patch version committed, asked by the patch author.
567 (Requested by rakuco on #webkit).
569 * WebCoreSupport/FrameLoaderClientEfl.cpp:
570 (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
571 (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
572 (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
573 (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
574 (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
575 * WebCoreSupport/FrameLoaderClientEfl.h:
576 (FrameLoaderClientEfl):
581 (_Ewk_View_Private_Data):
584 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
586 [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
587 https://bugs.webkit.org/show_bug.cgi?id=83030
589 Reviewed by Antonio Gomes.
591 Implement support for LayoutTestController's dumpFrameLoadCallbacks()
592 in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
593 from postProgressFinishedNotification() since it is already emitted
594 from dispatchDidFinishLoad(). This avoids unwanted extra signals we
595 prevent some tests from passing (e.g.
596 http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).
598 * WebCoreSupport/FrameLoaderClientEfl.cpp:
599 (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
600 (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
601 (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
602 (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
603 (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
604 * WebCoreSupport/FrameLoaderClientEfl.h:
605 (FrameLoaderClientEfl):
607 (ewk_frame_load_committed):
611 (_Ewk_View_Private_Data):
612 (ewk_view_onload_event):
615 2012-04-17 Mariusz Grzegorczyk <mariusz.g@samsung.com>
617 [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
618 https://bugs.webkit.org/show_bug.cgi?id=83285
620 Reviewed by Ryosuke Niwa.
622 Remove WebCore namespace from PageClientEfl.
624 * WebCoreSupport/PageClientEfl.cpp:
626 * WebCoreSupport/PageClientEfl.h:
630 (_Ewk_View_Private_Data):
631 (_ewk_view_priv_new):
632 (EWKPrivate::corePageClient):
634 2012-04-13 Thiago Marcos P. Santos <thiago.santos@intel.com>
636 [EFL] Add API for color chooser
637 https://bugs.webkit.org/show_bug.cgi?id=83692
639 Added new API to enable browsers to display a custom color picker
640 when an input field of type "color" is activated.
642 Reviewed by Kenneth Rohde Christiansen.
644 * WebCoreSupport/ChromeClientEfl.cpp:
646 (WebCore::ChromeClientEfl::createColorChooser):
647 (WebCore::ChromeClientEfl::removeColorChooser):
648 (WebCore::ChromeClientEfl::updateColorChooser):
649 * WebCoreSupport/ChromeClientEfl.h:
654 (_Ewk_View_Private_Data):
655 (ewk_view_color_chooser_new):
656 (ewk_view_color_chooser_destroy):
657 (ewk_view_color_chooser_color_set):
658 (ewk_view_color_chooser_changed):
661 2012-04-11 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
663 [EFL] LayoutTestController needs implementation of pageProperty
664 https://bugs.webkit.org/show_bug.cgi?id=82449
666 Add missing implementation pageProperty to EFL's
667 DumpRenderTreeSupport.
669 Reviewed by Antonio Gomes.
671 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
672 (DumpRenderTreeSupportEfl::pageProperty):
673 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
675 2012-04-10 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
677 [EFL] LayoutTestController needs implementation of addUserStyleSheet
678 https://bugs.webkit.org/show_bug.cgi?id=82446
680 Add missing implementation addUserStyleSheet to EFL's
681 DumpRenderTreeSupport.
683 Reviewed by Antonio Gomes.
685 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
686 (DumpRenderTreeSupportEfl::addUserStyleSheet):
687 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
689 2012-04-04 Raphael Kubo da Costa <rakuco@webkit.org>
691 Another unreviewed attempt at getting the EFL build bot to a
692 healthy state by forcing a rebuild.
696 2012-04-04 Raphael Kubo da Costa <rakuco@webkit.org>
698 Unreviewed; touch a file to check if the EFL build bot is back to
703 2012-04-04 Christophe Dumez <christophe.dumez@intel.com>
705 [EFL][DRT] Catch the "resource,request,willsend" signal
706 https://bugs.webkit.org/show_bug.cgi?id=82192
708 Reviewed by Gustavo Noronha Silva.
710 EFL's FrameLoaderClient now emits the "resource,request,willsend"
711 signal on the view for all resources about to be loaded, not just the
712 main frame. Also adds a boolean flag to Ewk_Frame_Resource_Request to
713 distinguish the request for the main frame from those for
716 * WebCoreSupport/FrameLoaderClientEfl.cpp:
717 (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
718 (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
719 (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
723 2012-04-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
725 [EFL] DRT support for computedStyleIncludingVisitedInfo
726 https://bugs.webkit.org/show_bug.cgi?id=82190
728 Add missing implementation computedStyleIncludingVisitedInfo to EFL's
729 DumpRenderTreeSupport.
731 Reviewed by Antonio Gomes.
733 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
734 (DumpRenderTreeSupportEfl::computedStyleIncludingVisitedInfo):
735 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
737 2012-04-04 Dominik Röttsches <dominik.rottsches@linux.intel.com>
739 [EFL][DRT] FrameloaderClientEfl needs to handle media content correctly
740 https://bugs.webkit.org/show_bug.cgi?id=83020
742 Reviewed by Hajime Morita.
744 Implementing handling of media content type and media documents
745 in the respective FrameLoaderClientEfl callbacks.
747 * WebCoreSupport/FrameLoaderClientEfl.cpp:
748 (WebCore::FrameLoaderClientEfl::committedLoad): Cancel loading for media documents.
749 (WebCore::FrameLoaderClientEfl::canShowMIMEType): Let media content types through.
751 (WebCore::FrameLoaderClientEfl::pluginWillHandleLoadError): Returning appropriate error type.
752 (WebCore::FrameLoaderClientEfl::shouldFallBack): Falling back as well for media handled by media player.
754 2012-04-04 Grzegorz Czajkowski <g.czajkowski@samsung.com>
756 [EFL] Change ewk_settings_icon_database_icon_object_add to proper API name.
757 https://bugs.webkit.org/show_bug.cgi?id=82438
759 Reviewed by Andreas Kling.
761 The purpose of ewk_settings_icon_database_icon_object_add is to get icon
762 for the given URL. This function doesn't add anything to database.
763 Documentation and API name are adjusted.
765 * ewk/ewk_settings.cpp:
766 (ewk_settings_icon_database_icon_object_get):
767 * ewk/ewk_settings.h:
769 2012-04-03 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
771 [EFL] DRT support for setInteractiveFormValidationEnabled
772 https://bugs.webkit.org/show_bug.cgi?id=82050
774 Add a setting setInteractiveFormValidationEnabled to EFL's
775 DumpRenderTreeSupport.
777 Reviewed by Antonio Gomes.
779 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
780 (DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
781 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
783 2012-04-03 Christophe Dumez <christophe.dumez@intel.com>
785 [EFL] LayoutTestController needs implementation of setDefersLoading
786 https://bugs.webkit.org/show_bug.cgi?id=82890
788 Reviewed by Philippe Normand.
790 Implement setDefersLoading() in EFL's LayoutTestController so that the
791 corresponding test case can be removed from the skip list.
793 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
794 (DumpRenderTreeSupportEfl::setDefersLoading):
795 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
797 2012-04-03 Alexander Shalamov <alexander.shalamov@intel.com>
799 [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
800 https://bugs.webkit.org/show_bug.cgi?id=82589
802 Add missing implementation for pageSizeAndMarginsInPixels to EFL's
803 DumpRenderTreeSupport.
805 Reviewed by Philippe Normand.
807 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
808 (DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
809 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
811 2012-04-02 Alexander Shalamov <alexander.shalamov@intel.com>
813 [EFL] LayoutTestController needs implementation of isPageBoxVisible
814 https://bugs.webkit.org/show_bug.cgi?id=82591
816 Add missing implementation for isPageBoxVisible to EFL's
817 DumpRenderTreeSupport.
819 Reviewed by Hajime Morita.
821 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
822 (DumpRenderTreeSupportEfl::isPageBoxVisible):
823 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
825 2012-04-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
827 Support the Network Information API
828 https://bugs.webkit.org/show_bug.cgi?id=73528
830 Reviewed by Adam Barth.
832 Add NetworkInfoClientEfl to support network information API. However,
833 functions are not implemented yet.
835 * WebCoreSupport/NetworkInfoClientEfl.cpp: Added.
836 (WebCore::NetworkInfoClientEfl::NetworkInfoClientEfl):
838 (WebCore::NetworkInfoClientEfl::~NetworkInfoClientEfl):
839 (WebCore::NetworkInfoClientEfl::startUpdating):
840 (WebCore::NetworkInfoClientEfl::stopUpdating):
841 (WebCore::NetworkInfoClientEfl::bandwidth):
842 (WebCore::NetworkInfoClientEfl::metered):
843 * WebCoreSupport/NetworkInfoClientEfl.h: Added.
844 (NetworkInfoClientEfl):
846 (_Ewk_View_Private_Data):
847 (_ewk_view_priv_new):
849 2012-03-30 Patrick Gansterer <paroga@webkit.org>
851 [EFL] Correct <wtf/*.h> include paths.
852 https://bugs.webkit.org/show_bug.cgi?id=82741
854 Reviewed by Andreas Kling.
856 Modify the #include declarations for several EFL-related files
857 so that the wtf types are included using the full path.
860 * ewk/ewk_tiled_backing_store.cpp:
861 (_Ewk_Tiled_Backing_Store_Item):
862 * ewk/ewk_tiled_matrix.cpp:
864 2012-03-30 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
866 Add a "preview" state to Page Visibility API implementation
867 https://bugs.webkit.org/show_bug.cgi?id=81355
869 Reviewed by Adam Barth.
871 Updating the Page Visibility API implementation to the current spec version.
873 * WebCoreSupport/AssertMatchingEnums.cpp:
876 2012-03-28 Nate Chapin <japhet@chromium.org>
878 Remove dispatchDidLoadMainResource callback, since no
880 https://bugs.webkit.org/show_bug.cgi?id=82539
882 Reviewed by Alexey Proskuryakov.
884 * WebCoreSupport/FrameLoaderClientEfl.cpp:
886 * WebCoreSupport/FrameLoaderClientEfl.h:
887 (FrameLoaderClientEfl):
889 2012-03-27 Carlos Garcia Campos <cgarcia@igalia.com>
891 [SOUP] Implement missing methods in CookieJarSoup
892 https://bugs.webkit.org/show_bug.cgi?id=82082
894 Reviewed by Martin Robinson.
896 * ewk/ewk_cookies.cpp:
897 (ewk_cookies_clear): Use soupCookieJar() instead of
899 (ewk_cookies_get_all): Ditto.
900 (ewk_cookies_cookie_del): Ditto.
901 (ewk_cookies_policy_set): Ditto.
902 (ewk_cookies_policy_get): Ditto.
904 2012-03-23 Grzegorz Czajkowski <g.czajkowski@samsung.com>
906 [EFL][DRT] Implement LayoutTestController's methods related with editing.
907 https://bugs.webkit.org/show_bug.cgi?id=80136
909 Reviewed by Ryosuke Niwa.
911 Implements DumpRenderTreeSupportEfl's and EditorClientEfl's methods related with editing.
913 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
914 (DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled): New function.
915 (DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled): New function.
916 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
917 * WebCoreSupport/EditorClientEfl.cpp:
918 (WebCore::EditorClientEfl::setSmartInsertDeleteEnabled): New function.
920 (WebCore::EditorClientEfl::smartInsertDeleteEnabled): Add implementation.
921 (WebCore::EditorClientEfl::setSelectTrailingWhitespaceEnabled): New function.
922 (WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled): Add implementation.
923 (WebCore::EditorClientEfl::EditorClientEfl):
924 * WebCoreSupport/EditorClientEfl.h:
927 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
929 [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
930 https://bugs.webkit.org/show_bug.cgi?id=81512
932 Add missing implementation markerTextForListItem to EFL's
933 DumpRenderTreeSupport.
935 Reviewed by Antonio Gomes.
937 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
938 (DumpRenderTreeSupportEfl::markerTextForListItem):
939 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
941 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
943 [EFL] Implement LayoutTestController::setEditingBehavior
944 https://bugs.webkit.org/show_bug.cgi?id=81124
946 Add missing implementation setEditingBehavior to EFL's
947 DumpRenderTreeSupport. This setting controls various editing
948 behaviors that differ between platforms.
950 Reviewed by Martin Robinson.
952 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
953 (DumpRenderTreeSupportEfl::setEditingBehavior):
954 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
956 2012-03-22 Krzysztof Czech <k.czech@samsung.com>
958 [EFL] Change returned view mode in case of NULL of ewkView.
959 https://bugs.webkit.org/show_bug.cgi?id=81636
961 Reviewed by Eric Seidel.
963 Function ewk_view_mode_get returns wrong view mode in case of NULL of ewkView.
966 (_Ewk_View_Private_Data):
969 2012-03-22 Hyowon Kim <hw1008.kim@samsung.com>
971 [EFL] Add PageClientEfl to WebCoreSupport.
972 https://bugs.webkit.org/show_bug.cgi?id=80748
974 Reviewed by Noam Rosenthal.
976 This patch adds PageClientEfl for implementaion of accelerated compositing.
978 * WebCoreSupport/ChromeClientEfl.cpp:
979 (WebCore::ChromeClientEfl::platformPageClient):
980 * WebCoreSupport/PageClientEfl.cpp: Added.
982 (WebCore::PageClientEfl::PageClientEfl):
983 (WebCore::PageClientEfl::~PageClientEfl):
984 (WebCore::PageClientEfl::createEvasObjectForAcceleratedCompositing):
985 Just call ewk_view_accelerated_compositing_object_create().
986 (WebCore::PageClientEfl::acceleratedCompositingContext):
987 Just call ewk_view_accelerated_compositing_context_get().
988 * WebCoreSupport/PageClientEfl.h: Added.
991 (WebCore::PageClientEfl::view): Return ewkView.
996 (_Ewk_View_Private_Data): Add OwnPtr<PageClientEfl>.
997 (_ewk_view_priv_new): Create a new PageClientEfl.
998 (ewk_view_accelerated_compositing_object_create): Not implemented.
999 (ewk_view_accelerated_compositing_context_get): Not implemented.
1000 (EWKPrivate::corePageClient): Return the PageClientEfl pointer.
1003 2012-03-19 Adam Barth <abarth@webkit.org>
1005 Remove support for "magic" iframe
1006 https://bugs.webkit.org/show_bug.cgi?id=81590
1008 Reviewed by Eric Seidel.
1010 Remove FrameLoaderClient methods that no longer exist.
1012 * WebCoreSupport/FrameLoaderClientEfl.cpp:
1014 * WebCoreSupport/FrameLoaderClientEfl.h:
1015 (FrameLoaderClientEfl):
1017 2012-03-16 Kihong Kwon <kihong.kwon@samsung.com>
1019 Support for Battery Status API
1020 https://bugs.webkit.org/show_bug.cgi?id=62698
1022 Add BatteryClientEfl class implementation for the layout tests now.
1023 BatteryClientEfl class is not fully implemented in this patch.
1024 (It will be completed by other patch as necessary in the Efl port.)
1025 http://www.w3.org/TR/battery-status/
1027 Reviewed by Adam Barth.
1029 * WebCoreSupport/BatteryClientEfl.cpp: Added.
1031 (WebCore::BatteryClientEfl::BatteryClientEfl):
1032 (WebCore::BatteryClientEfl::setController):
1033 (WebCore::BatteryClientEfl::startUpdating):
1034 (WebCore::BatteryClientEfl::stopUpdating):
1035 (WebCore::BatteryClientEfl::batteryControllerDestroyed):
1036 (WebCore::BatteryClientEfl::setBatteryStatus):
1037 * WebCoreSupport/BatteryClientEfl.h: Added.
1040 (WebCore::BatteryClientEfl::~BatteryClientEfl):
1042 (_Ewk_View_Private_Data):
1043 (_ewk_view_priv_new):
1045 2012-03-13 Jon Lee <jonlee@apple.com>
1047 Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
1048 https://bugs.webkit.org/show_bug.cgi?id=80922
1049 <rdar://problem/11035082>
1051 Reviewed by Jian Li.
1053 You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
1054 LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
1055 new API. Therefore, APIs that are common between the two will have:
1056 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1058 This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
1059 the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
1061 Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1062 * WebCoreSupport/ChromeClientEfl.cpp:
1064 * WebCoreSupport/ChromeClientEfl.h:
1066 * WebCoreSupport/NotificationPresenterClientEfl.cpp:
1067 * WebCoreSupport/NotificationPresenterClientEfl.h:
1069 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
1071 Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
1072 https://bugs.webkit.org/show_bug.cgi?id=78853
1074 Reviewed by Adam Barth.
1076 * WebCoreSupport/ChromeClientEfl.cpp:
1078 * WebCoreSupport/ChromeClientEfl.h:
1081 2012-03-13 ChangSeok Oh <shivamidow@gmail.com>
1083 [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
1084 https://bugs.webkit.org/show_bug.cgi?id=79601
1086 Reviewed by Gustavo Noronha Silva.
1088 Added a new API to deliver all mutations explicitly.
1090 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
1091 (DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):
1092 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
1094 2012-03-13 JungJik Lee <jungjik.lee@samsung.com>
1096 [EFL] Remove a duplicate allocation of matrix entry.
1097 https://bugs.webkit.org/show_bug.cgi?id=79362
1099 Reviewed by Zoltan Herczeg.
1101 A matrix entry is created when calling ewk_matrix_new.
1102 Another matrix is created inside ewk_tile_matrix_zoom_level_set.
1103 This patch is for getting rid of a duplicated creation of the matrix.
1105 * ewk/ewk_tiled_backing_store.cpp:
1106 (_Ewk_Tiled_Backing_Store_Item):
1107 (_ewk_tiled_backing_store_zoom_set_internal):
1108 * ewk/ewk_tiled_matrix.cpp:
1109 (ewk_tile_matrix_new):
1110 (ewk_tile_matrix_zoom_level_set):
1111 (ewk_tile_matrix_entry_new):
1112 (ewk_tile_matrix_size_get):
1113 * ewk/ewk_tiled_matrix.h:
1115 2012-03-09 Jon Lee <jonlee@apple.com>
1117 Rename NotificationPresenter to NotificationClient
1118 https://bugs.webkit.org/show_bug.cgi?id=80488
1119 <rdar://problem/10965558>
1121 Reviewed by Kentaro Hara.
1123 Refactor to use renamed WebCore::NotificationClient.
1124 * WebCoreSupport/ChromeClientEfl.cpp:
1125 (WebCore::ChromeClientEfl::notificationPresenter):
1126 * WebCoreSupport/ChromeClientEfl.h:
1129 2012-03-08 Hyowon Kim <hw1008.kim@samsung.com>
1131 [Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
1132 https://bugs.webkit.org/show_bug.cgi?id=80266
1134 Reviewed by Noam Rosenthal.
1136 This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport.
1138 * WebCoreSupport/AcceleratedCompositingContextEfl.cpp: Added.
1140 (WebCore::AcceleratedCompositingContext::create):
1141 (WebCore::AcceleratedCompositingContext::AcceleratedCompositingContext):
1142 (WebCore::AcceleratedCompositingContext::~AcceleratedCompositingContext):
1143 (WebCore::AcceleratedCompositingContext::initialize):
1144 (WebCore::AcceleratedCompositingContext::syncLayersNow):
1145 (WebCore::AcceleratedCompositingContext::renderLayers):
1146 (WebCore::AcceleratedCompositingContext::attachRootGraphicsLayer):
1147 (WebCore::AcceleratedCompositingContext::context):
1148 * WebCoreSupport/AcceleratedCompositingContextEfl.h: Added.
1150 (AcceleratedCompositingContext):
1152 2012-03-02 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1154 [EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
1155 https://bugs.webkit.org/show_bug.cgi?id=79646
1157 Reviewed by Andreas Kling.
1159 INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
1160 As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement
1161 and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction
1162 with Ewk_Context_Menu_Action.
1163 To avoid similar case in the feature I added checks between WebCore and
1164 WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.
1166 * WebCoreSupport/AssertMatchingEnums.cpp:
1167 * ewk/ewk_contextmenu.h:
1169 2012-02-29 Tomasz Morawski <t.morawski@samsung.com>
1171 [EFL] Replace malloc/calloc/free to new/delete.
1172 https://bugs.webkit.org/show_bug.cgi?id=75848
1174 Reviewed by Hajime Morita.
1176 Replaced almost all malloc/calloc/free to new/delete operator and where it was possible smart pointers were also
1177 used. Left few c memory allocation by intention to not mix c and c++ memory managment. Left malloc for Ewk_Tile
1178 object due to const fields present in Ewk_tile structure.
1180 * ewk/ewk_auth_soup.cpp:
1181 * ewk/ewk_contextmenu.cpp:
1182 (ewk_context_menu_unref):
1183 (ewk_context_menu_item_new):
1184 (ewk_context_menu_item_free):
1185 (ewk_context_menu_new):
1186 * ewk/ewk_cookies.cpp:
1187 (ewk_cookies_get_all):
1188 (ewk_cookies_cookie_free):
1189 * ewk/ewk_frame.cpp:
1190 (ewk_frame_hit_test_free):
1191 (ewk_frame_hit_test_new):
1192 * ewk/ewk_history.cpp:
1193 (ewk_history_item_new_from_core):
1194 (_ewk_history_item_free):
1197 * ewk/ewk_tiled_backing_store.cpp:
1198 (_Ewk_Tiled_Backing_Store_Item):
1199 (_ewk_tiled_backing_store_pre_render_request_add):
1200 (_ewk_tiled_backing_store_pre_render_request_del):
1201 (_ewk_tiled_backing_store_pre_render_request_flush):
1202 (_ewk_tiled_backing_store_pre_render_request_clear):
1203 (_ewk_tiled_backing_store_item_add):
1204 (_ewk_tiled_backing_store_item_del):
1205 * ewk/ewk_tiled_matrix.cpp:
1206 (_ewk_tile_matrix_tile_free):
1207 (ewk_tile_matrix_new):
1208 (ewk_tile_matrix_zoom_level_set):
1209 (ewk_tile_matrix_invalidate):
1210 (ewk_tile_matrix_free):
1211 * ewk/ewk_tiled_model.cpp:
1213 (ewk_tile_unused_cache_new):
1214 (_ewk_tile_unused_cache_free):
1215 (ewk_tile_unused_cache_clear):
1216 (ewk_tile_unused_cache_flush):
1217 (ewk_tile_unused_cache_tile_get):
1218 (ewk_tile_unused_cache_tile_put):
1219 * ewk/ewk_tiled_private.h:
1221 (_Ewk_View_Private_Data):
1222 (_ewk_view_core_frame_new):
1223 (_ewk_view_priv_new):
1224 (_ewk_view_priv_del):
1225 (ewk_view_core_page_get):
1226 (ewk_view_popup_new):
1227 (ewk_view_popup_destroy):
1228 (EWKPrivate::corePage):
1229 * ewk/ewk_window_features.cpp:
1230 (ewk_window_features_unref):
1231 (ewk_window_features_new_from_core):
1233 2012-02-27 JungJik Lee <jungjik.lee@samsung.com>
1235 [EFL] Pairing up between evas_object_image_data_get and evas_object_image_data_set.
1236 https://bugs.webkit.org/show_bug.cgi?id=79031
1238 Reviewed by Zoltan Herczeg.
1240 - Get the pixel data when the cairo surface is created.
1241 - evas_object_image_data_get increases the reference count and returns the image buffer pointer.
1242 evas_object_image_data_set decreases the reference count and when the ref count become zero,
1243 the function releases the cached image inside evas engine.
1244 We should make a pair between evas_object_image_data_set/get to return evas resource.
1246 * ewk/ewk_tiled_backing_store.h:
1248 * ewk/ewk_tiled_model.cpp:
1251 * ewk/ewk_view_tiled.cpp:
1252 (_ewk_view_tiled_render_cb):
1254 2012-02-26 Hajime Morrita <morrita@chromium.org>
1256 Move ChromeClient::showContextMenu() to ContextMenuClient
1257 https://bugs.webkit.org/show_bug.cgi?id=79427
1259 Reviewed by Adam Barth.
1261 * WebCoreSupport/ChromeClientEfl.h:
1264 2012-02-24 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1266 [EFL][DRT] Implement setValueForUser and setAutofilled.
1267 https://bugs.webkit.org/show_bug.cgi?id=79237
1269 Reviewed by Andreas Kling.
1271 Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.
1273 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
1274 (DumpRenderTreeSupportEfl::setValueForUser):
1275 (DumpRenderTreeSupportEfl::setAutofilled):
1276 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
1278 2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
1280 SpellCheckRequest needs to know the context where the spellcheck happened.
1281 https://bugs.webkit.org/show_bug.cgi?id=79320
1283 Reviewed by Hajime Morita.
1285 * WebCoreSupport/EditorClientEfl.h:
1286 (WebCore::EditorClientEfl::requestCheckingOfString):
1288 2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
1290 Remove the remaining uses of CSSStyleDeclaration in Editor
1291 https://bugs.webkit.org/show_bug.cgi?id=78939
1293 Reviewed by Enrica Casucci.
1295 * WebCoreSupport/EditorClientEfl.cpp:
1296 (WebCore::EditorClientEfl::shouldApplyStyle):
1297 * WebCoreSupport/EditorClientEfl.h:
1300 2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
1302 Remove the remaining uses of CSSStyleDeclaration in Editor
1303 https://bugs.webkit.org/show_bug.cgi?id=78939
1305 Reviewed by Enrica Casucci.
1307 * WebCoreSupport/EditorClientEfl.cpp:
1308 (WebCore::EditorClientEfl::shouldApplyStyle):
1309 * WebCoreSupport/EditorClientEfl.h:
1312 2012-02-20 Kihong Kwon <kihong.kwon@samsung.com>
1314 Add a new API for the Vibration API(W3C).
1315 https://bugs.webkit.org/show_bug.cgi?id=72010
1317 Reviewed by Hajime Morita.
1319 Implementation for the Vibration API feature to the EFL-port layer.
1320 http://dev.w3.org/2009/dap/vibration/
1321 There are two methods for vibration API.
1322 - vibrate : Vibrate device for receiving as a parameter.
1323 - cancelVibrate : Cancel current vibration.
1325 * CMakeListsEfl.txt:
1326 * WebCoreSupport/VibrationClientEfl.cpp: Added.
1328 (WebCore::VibrationClientEfl::VibrationClientEfl):
1329 (WebCore::VibrationClientEfl::vibrate):
1330 (WebCore::VibrationClientEfl::cancelVibration):
1331 (WebCore::VibrationClientEfl::vibrationDestroyed):
1332 * WebCoreSupport/VibrationClientEfl.h: Added.
1334 (VibrationClientEfl):
1335 (WebCore::VibrationClientEfl::~VibrationClientEfl):
1337 (_Ewk_View_Private_Data):
1338 (_ewk_view_priv_new):
1340 2012-02-17 Raphael Kubo da Costa <kubo@profusion.mobi>
1342 [EFL] Unreviewed, adapt to the changes introduced in r107973.
1344 SVN r107973 moved some libsoup feature initialization code to
1345 WebCore, but only changed the GTK+ bits in WebKit.
1348 (_ewk_init_body): Do not initialize the content sniffer and the
1349 decoder here, the initialization is now done in WebCore.
1351 2012-02-17 Raphael Kubo da Costa <kubo@profusion.mobi>
1353 Unreviewed, fix the build with ENABLE(DEVICE_ORIENTATION) after
1354 r107518. The EFL EWS bot doesn't enable that flag, so the breakage
1355 was not spotted earlier.
1358 (_Ewk_View_Private_Data):
1359 (_ewk_view_priv_new):
1361 2012-01-31 Raphael Kubo da Costa <kubo@profusion.mobi>
1363 [soup] Add support for multiple SoupSessions.
1364 https://bugs.webkit.org/show_bug.cgi?id=77341
1366 Add the necessary infrastructure to support multiple SoupSessions. Each
1367 WebView now has a "session" property, which defaults to
1368 ResourceHandle::defaultSession() and can be changed to another
1369 SoupSession by the user.
1371 Some API in ewk_network and ewk_view which required SoupSession to be a
1372 valid type in the headers has now been moved inside #if USE(SOUP)
1373 ifdefs so we can actually the required Soup header and avoid build
1374 problems with duplicate typedefs.
1376 * CMakeListsEfl.txt:
1377 * WebCoreSupport/FrameLoaderClientEfl.cpp:
1378 (WebCore::FrameLoaderClientEfl::createNetworkingContext):
1379 * WebCoreSupport/FrameNetworkingContextEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/FrameNetworkingContextEfl.h.
1381 (WebCore::FrameNetworkingContextEfl::create):
1382 (WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
1383 (WebCore::FrameNetworkingContextEfl::soupSession):
1384 * WebCoreSupport/FrameNetworkingContextEfl.h:
1385 (FrameNetworkingContextEfl):
1386 * ewk/ewk_cookies.h: Mention this API is only valid with the
1387 default SoupSession.
1388 * ewk/ewk_network.cpp:
1389 (ewk_network_default_soup_session_get): Define only if USE(SOUP) is set.
1390 * ewk/ewk_network.h: Ditto, and mention this API is only valid with the
1391 default SoupSession.
1393 (_Ewk_View_Private_Data):
1394 (_ewk_view_priv_new):
1395 (ewk_view_soup_session_get):
1396 (ewk_view_soup_session_set):
1400 2012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
1402 Notify ChromeClient when touch-event handlers are installed/removed.
1403 https://bugs.webkit.org/show_bug.cgi?id=77440
1405 Reviewed by Darin Fisher and Ryosuke Niwa.
1407 * WebCoreSupport/ChromeClientEfl.h:
1408 (WebCore::ChromeClientEfl::numTouchEventHandlersChanged):
1410 2012-02-15 Gustavo Lima Chaves <glima@profusion.mobi>
1412 [EFL] Add missing libsoup to (pkgconfig) dependency requirements
1413 https://bugs.webkit.org/show_bug.cgi?id=78702
1415 Unreviewed build fix.
1417 * ewebkit.pc.in: Now that bug 77874 had its patch landed, we
1418 always require libsoup as a dependency for the EFL port. The
1419 'Require' session of this file has to contemplate that, otherwise
1420 code linking with ewebkit will fail to lookup to libsoup's header
1423 2012-02-13 Raphael Kubo da Costa <kubo@profusion.mobi>
1425 [CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
1426 https://bugs.webkit.org/show_bug.cgi?id=78566
1428 Reviewed by Daniel Bates.
1430 * CMakeListsEfl.txt: Do not include WebKitEfl.cmake.
1432 2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
1434 Convert svg/animations to use SMIL methods for driving the timeline
1435 https://bugs.webkit.org/show_bug.cgi?id=78422
1437 Reviewed by Dirk Schulze.
1439 Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
1440 Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1442 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
1443 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
1445 2012-02-06 Raphael Kubo da Costa <kubo@profusion.mobi>
1447 [EFL] Drop support for the Curl network backend.
1448 https://bugs.webkit.org/show_bug.cgi?id=77874
1450 Reviewed by Eric Seidel.
1452 Nobody seems to be maintaining the Curl backend in WebCore, the
1453 EFL port developers all seem to be using the Soup backend and the
1454 port itself has many features which are only implemented for the
1457 * CMakeListsEfl.txt: Unconditionally build soup-dependent files
1458 and always add the glib/soup include directories and libraries.
1459 * WebCoreSupport/FrameLoaderClientEfl.cpp:
1460 (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
1461 Remove USE(SOUP) checks.
1463 (ewk_auth_show_dialog_callback_set): Ditto.
1464 (ewk_auth_credentials_set): Ditto.
1465 * ewk/ewk_cookies.cpp:
1466 (ewk_cookies_file_set): Ditto.
1467 (ewk_cookies_clear): Ditto.
1468 (ewk_cookies_get_all): Ditto.
1469 (ewk_cookies_cookie_del): Ditto.
1470 (ewk_cookies_cookie_free): Ditto.
1471 (ewk_cookies_policy_set): Ditto.
1472 (ewk_cookies_policy_get): Ditto.
1473 * ewk/ewk_frame.cpp:
1474 (ewk_frame_certificate_status_get): Ditto.
1476 (_ewk_init_body): Ditto.
1477 * ewk/ewk_network.cpp:
1478 (ewk_network_proxy_uri_set): Ditto.
1479 (ewk_network_proxy_uri_get): Ditto.
1480 (ewk_network_tls_certificate_check_get): Ditto.
1481 (ewk_network_tls_certificate_check_set): Ditto.
1482 (ewk_network_tls_ca_certificates_path_get): Ditto.
1483 (ewk_network_tls_ca_certificates_path_set): Ditto.
1484 (ewk_network_default_soup_session_get): Ditto.
1485 * ewk/ewk_network.h: Update apidox for
1486 ewk_network_default_soup_session_get() now that libsoup is the
1487 only available backend.
1489 2012-02-09 Gustavo Lima Chaves <glima@profusion.mobi>
1491 [EFL] Introducing functions to set local storage db path and clear
1493 https://bugs.webkit.org/show_bug.cgi?id=77107
1495 This patch exposes the web local storage tracker database path
1496 setting cabability, introduced on bug 77006, to the EFL port of
1497 WebKit. Particularly, we have our own storage tracker client
1498 object, to initialize the storage tracker backend on ewk_init().
1500 Reviewed by Kenneth Rohde Christiansen.
1502 * CMakeListsEfl.txt:
1503 * WebCoreSupport/StorageTrackerClientEfl.cpp: Added.
1505 (WebCore::StorageTrackerClientEfl::dispatchDidModifyOrigin):
1506 (WebCore::StorageTrackerClientEfl::didFinishLoadingOrigins):
1507 * WebCoreSupport/StorageTrackerClientEfl.h: Added.
1509 (StorageTrackerClientEfl):
1513 * ewk/ewk_settings.cpp:
1514 (ewk_settings_local_storage_path_set):
1515 (ewk_settings_local_storage_path_get):
1516 (ewk_settings_local_storage_database_clear):
1517 (ewk_settings_local_storage_database_origin_clear):
1518 * ewk/ewk_settings.h:
1520 2012-02-07 Krzysztof Czech <k.czech@samsung.com>
1522 [EFL] Add missing initialization of editable variable.
1523 https://bugs.webkit.org/show_bug.cgi?id=77948
1525 Reviewed by Eric Seidel.
1527 The value of editable in Ewk_Frame_Smart_Data struct is not set.
1529 * ewk/ewk_frame.cpp:
1530 (ewk_frame_editable_set):
1532 2012-02-06 JungJik Lee <jungjik.lee@samsung.com>
1534 [EFL] Define to prevent a single backing-store application from calling the tiled view function.
1535 https://bugs.webkit.org/show_bug.cgi?id=77842
1537 Reviewed by Andreas Kling.
1539 The define prevents an application using single backing store from calling tiled cache function.
1540 The tiled APIs opened to outer should check the view type before being called.
1542 * ewk/ewk_private.h:
1544 (_Ewk_View_Private_Data):
1545 (ewk_view_frame_view_creation_notify):
1546 * ewk/ewk_view_tiled.cpp:
1547 (ewk_view_tiled_unused_cache_get):
1548 (ewk_view_tiled_unused_cache_set):
1550 2012-02-06 JungJik Lee <jungjik.lee@samsung.com>
1552 [EFL] Adopt C++ style using camelCase and full variable names.
1553 https://bugs.webkit.org/show_bug.cgi?id=76378
1555 Reviewed by Andreas Kling.
1557 Modify the code to use camelCase and spell out variable names instead of using abbreviations.
1558 Modify the comments which do not match with actual parameters and correct misspelled words.
1559 Adopt EFL Coding style in header files.
1560 The logic of the code is not changed.
1562 * ewk/ewk_cookies.h:
1563 * ewk/ewk_frame.cpp:
1564 (ewk_frame_selection_get):
1565 (ewk_frame_feed_focus_in):
1566 (EWKPrivate::coreFrame):
1568 * ewk/ewk_history.cpp:
1569 (ewk_history_item_new):
1570 (ewk_history_item_title_get):
1571 (ewk_history_item_title_alternate_get):
1572 (ewk_history_item_uri_get):
1573 (ewk_history_item_uri_original_get):
1574 * ewk/ewk_network.h:
1575 * ewk/ewk_tiled_backing_store.cpp:
1576 (_Ewk_Tiled_Backing_Store_Item):
1577 (_Ewk_Tiled_Backing_Store_Data):
1578 (_ewk_tiled_backing_store_tile_associate):
1579 (_ewk_tiled_backing_store_tile_dissociate):
1580 (_ewk_tiled_backing_store_pre_render_request_clear):
1581 (_ewk_tiled_backing_store_pre_render_request_process_single):
1582 (_ewk_tiled_backing_store_item_fill):
1583 (_ewk_tiled_backing_store_item_add):
1584 (_ewk_tiled_backing_store_item_smooth_scale_set):
1585 (_ewk_tiled_backing_store_view_cols_end_add):
1586 (_ewk_tiled_backing_store_view_rows_all_del):
1587 (_ewk_tiled_backing_store_render):
1588 (_ewk_tiled_backing_store_mem_dbg):
1589 (_ewk_tiled_backing_store_sig_usr):
1590 (_ewk_tiled_backing_store_smart_add):
1591 (_ewk_tiled_backing_store_smart_del):
1592 (_ewk_tiled_backing_store_smart_move):
1593 (_ewk_tiled_backing_store_smart_resize):
1594 (_ewk_tiled_backing_store_recalc_renderers):
1595 (_ewk_tiled_backing_store_view_dbg):
1596 (_ewk_tiled_backing_store_view_wrap_up):
1597 (_ewk_tiled_backing_store_view_wrap_down):
1598 (_ewk_tiled_backing_store_view_wrap_left):
1599 (_ewk_tiled_backing_store_view_refill):
1600 (_ewk_tiled_backing_store_view_pos_apply):
1601 (_ewk_tiled_backing_store_smart_calculate_offset_force):
1602 (_ewk_tiled_backing_store_smart_calculate_offset):
1603 (_ewk_tiled_backing_store_smart_calculate_pos):
1604 (_ewk_tiled_backing_store_smart_calculate):
1605 (_ewk_tiled_backing_store_scroll_full_offset_set_internal):
1606 (ewk_tiled_backing_store_scroll_full_offset_set):
1607 (ewk_tiled_backing_store_scroll_full_offset_add):
1608 (_ewk_tiled_backing_store_zoom_set_internal):
1609 (ewk_tiled_backing_store_zoom_set):
1610 (ewk_tiled_backing_store_zoom_weak_set):
1611 (ewk_tiled_backing_store_fix_offsets):
1612 (ewk_tiled_backing_store_flush):
1613 (ewk_tiled_backing_store_pre_render_region):
1614 (ewk_tiled_backing_store_pre_render_relative_radius):
1615 * ewk/ewk_tiled_backing_store.h:
1617 * ewk/ewk_tiled_matrix.cpp:
1619 (_ewk_tile_matrix_cell_free):
1620 (_ewk_tile_matrix_tile_free):
1621 (ewk_tile_matrix_new):
1622 (ewk_tile_matrix_free):
1623 (ewk_tile_matrix_unused_cache_get):
1624 (ewk_tile_matrix_tile_exact_get):
1625 (ewk_tile_matrix_tile_new):
1626 (ewk_tile_matrix_tile_put):
1627 (ewk_tile_matrix_dbg):
1628 (ewk_tile_matrix_freeze):
1629 (ewk_tile_matrix_thaw):
1630 * ewk/ewk_tiled_matrix.h:
1631 * ewk/ewk_tiled_model.cpp:
1633 (ewk_tile_updates_process):
1634 (ewk_tile_unused_cache_tile_put):
1635 (ewk_tile_unused_cache_dbg):
1636 * ewk/ewk_tiled_model.h:
1639 (_Ewk_View_Private_Data):
1640 (_ewk_view_smart_focus_in):
1641 (_ewk_view_smart_pre_render_region):
1642 (ewk_view_pre_render_region):
1643 (ewk_view_toolbars_visible_get):
1644 (ewk_view_statusbar_visible_get):
1645 (ewk_view_scrollbars_visible_get):
1646 (ewk_view_menubar_visible_get):
1647 (ewk_view_zoom_range_set):
1649 * ewk/ewk_view_single.cpp:
1650 (_ewk_view_single_smart_repaints_process):
1651 * ewk/ewk_view_tiled.cpp:
1652 (_ewk_view_tiled_smart_backing_store_add):
1653 (_ewk_view_tiled_smart_add):
1654 (ewk_view_tiled_unused_cache_get):
1655 (ewk_view_tiled_unused_cache_set):
1657 2012-02-05 ChangSeok Oh <shivamidow@gmail.com>
1659 [EFL] Enable WebGL with glx backend
1660 https://bugs.webkit.org/show_bug.cgi?id=77308
1662 Reviewed by Martin Robinson.
1664 Activated WebGL feature.
1667 (_Ewk_View_Private_Data):
1668 (_ewk_view_priv_new):
1670 2012-02-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1672 [EFL] Remove g_thread_init() calls
1673 https://bugs.webkit.org/show_bug.cgi?id=77828
1675 Reviewed by Andreas Kling.
1677 g_thread_init has been deprecated since glib 2.32. This function is no longer necessary.
1678 The GLib threading system is automatically initialized at the start of your program.
1683 2012-02-02 KwangHyuk Kim <hyuki.kim@samsung.com>
1685 [EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
1686 https://bugs.webkit.org/show_bug.cgi?id=77586
1688 Reviewed by Andreas Kling.
1690 As both zoom and content size change are identified by model flag,
1691 ewk_tiled_backing_store can not detect the conflict between them.
1692 In order to prevent conflict between zoom and contents size change,
1693 contentsSize flag is newly added.
1695 * ewk/ewk_tiled_backing_store.cpp:
1696 (_Ewk_Tiled_Backing_Store_Item):
1697 (_Ewk_Tiled_Backing_Store_Data):
1698 (_ewk_tiled_backing_store_smart_calculate):
1699 (ewk_tiled_backing_store_contents_resize):
1701 2012-02-02 Raphael Kubo da Costa <kubo@profusion.mobi>
1703 [EFL] Remove check for ENABLE_GTK_PLUGINS_SUPPORT
1704 https://bugs.webkit.org/show_bug.cgi?id=77647
1706 Reviewed by Martin Robinson.
1708 There is no clear reason why this check was in place (it came with the
1709 upstreaming of the port), but ENABLE_GTK_PLUGINS_SUPPORT is not set
1710 anywhere, and the build system does not even check for the presence of
1716 2012-01-31 Ryuan Choi <ryuan.choi@samsung.com>
1718 [EFL] Add basic DRT/Efl implementation to support viewport test.
1719 https://bugs.webkit.org/show_bug.cgi?id=77320
1721 Reviewed by Andreas Kling.
1723 Add dumpConfigurationForViewport.
1725 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
1726 (DumpRenderTreeSupportEfl::dumpConfigurationForViewport):
1727 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
1729 2012-01-31 KwangHyuk Kim <hyuki.kim@samsung.com>
1731 [EFL] Set content hint information for ewk_view_single.
1732 https://bugs.webkit.org/show_bug.cgi?id=77319
1734 Reviewed by Ryosuke Niwa.
1736 The content hint information corresponding to opengl_x11 engine is set
1737 for the image object which ewk_view_single owns when evas is based on
1740 * ewk/ewk_view_single.cpp:
1741 (_ewk_view_single_smart_backing_store_add):
1743 2012-01-30 Eunsol Park <eunsol47.park@samsung.com>
1745 [EFL] Define the names of view smart class
1746 https://bugs.webkit.org/show_bug.cgi?id=76370
1748 Reviewed by Andreas Kling.
1750 Strings of ewk_tiled_view's name were defined differently,
1751 so the definitions were modified to make users not confused.
1753 * ewk/ewk_private.h:
1755 * ewk/ewk_view_single.cpp:
1756 (_ewk_view_single_smart_class_new):
1757 * ewk/ewk_view_tiled.cpp:
1758 (ewk_view_tiled_smart_set):
1759 (_ewk_view_tiled_smart_class_new):
1761 2012-01-26 Tomasz Morawski <t.morawski@samsung.com>
1763 [EFL] Added missing NETSCAPE_PLUGIN_API macro.
1764 https://bugs.webkit.org/show_bug.cgi?id=77093
1766 Reviewed by Andreas Kling.
1768 The ewk_view_js_window_object_clear function should be inside ENABLE(NETSCAPE_PLUGIN_API) macro.
1772 2012-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1774 [EFL] Use static const insted of #define macro.
1775 https://bugs.webkit.org/show_bug.cgi?id=76499
1777 Reviewed by Hajime Morita.
1779 WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro.
1780 This patch replace global variables defined by #define with const.
1782 * ewk/ewk_tiled_backing_store.cpp:
1783 (_ewk_tiled_backing_store_smart_add):
1784 (_ewk_tiled_backing_store_zoom_set_internal):
1785 * ewk/ewk_tiled_backing_store.h:
1786 * ewk/ewk_tiled_matrix.cpp:
1787 (ewk_tile_matrix_new):
1789 (_ewk_view_repaint_add):
1790 (_ewk_view_repaints_flush):
1791 (_ewk_view_scroll_add):
1792 (_ewk_view_scrolls_flush):
1793 (_ewk_view_priv_new):
1794 (ewk_view_base_smart_set):
1795 * ewk/ewk_view_tiled.cpp:
1796 (_ewk_view_tiled_smart_pre_render_start):
1798 2012-01-13 Raphael Kubo da Costa <kubo@profusion.mobi>
1800 [EFL] Emit "resource,request,willsend" from ewk_view.
1801 https://bugs.webkit.org/show_bug.cgi?id=76292
1803 Reviewed by Andreas Kling.
1805 Make ewk_view dispatch the "resource,request,willsend" signal as well,
1806 so that it is possible to know whether the request is for the main
1807 frame itself or for anything else.
1809 * WebCoreSupport/FrameLoaderClientEfl.cpp:
1810 (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
1813 2012-01-16 Ryuan Choi <ryuan.choi@samsung.com>
1815 [EFL] Build fix when using pango as font backends.
1816 https://bugs.webkit.org/show_bug.cgi?id=76368
1818 Unreviewed build fix.
1820 * ewk/ewk_view.cpp: include RefPtrCairo.h
1822 2012-01-13 Leandro Pereira <leandro@profusion.mobi>
1824 [EFL] SecurityPolicy whitelist interface should be exposed to EWebKit
1825 https://bugs.webkit.org/show_bug.cgi?id=76082
1827 Reviewed by Andreas Kling.
1829 * CMakeListsEfl.txt: Added reference to ewk_security_policy.{cpp,h}.
1830 * ewk/EWebKit.h: Include ewk_security_policy.h.
1831 * ewk/ewk_security_policy.cpp: Added.
1832 (ewk_security_policy_whitelist_origin_add): Implemented thin layer around SecurityPolicy::addOriginAccessWhitelistEntry().
1833 (ewk_security_policy_whitelist_origin_del): Implemented thin layer around SecurityPolicy::removeOriginAccessWhitelistEntry().
1834 (ewk_security_policy_whitelist_origin_reset): Implemented thin layer around SecurityPolicy::resetOriginAccessWhitelists().
1835 * ewk/ewk_security_policy.h: Added.
1837 2012-01-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1839 [EFL] Remove extern "C" from ewk_private.h
1840 https://bugs.webkit.org/show_bug.cgi?id=76250
1842 Reviewed by Andreas Kling.
1844 ewk_private.h defines internal functions used by WebKit itself. There is no chance to be used by C application.
1845 So, extern "C" keyword is unneeded in ewk_private.h.
1847 * ewk/ewk_private.h:
1849 2012-01-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1851 [EFL] Add 'Copy Image Address' to context menu.
1852 https://bugs.webkit.org/show_bug.cgi?id=76153
1854 Reviewed by Andreas Kling.
1856 Adds EWK_CONTEXT_MENU_ITEM_TAG_COPY_IMAGE_URL_TO_CLIPBOARD to Ewk_Context_Menu_Action to synchronize it with ContextMenuItem.h
1858 * ewk/ewk_contextmenu.h:
1860 2012-01-13 KwangHyuk Kim <hyuki.kim@samsung.com>
1862 [EFL] Add visible field into ewk_tiled_backing_store's data.
1863 https://bugs.webkit.org/show_bug.cgi?id=76165
1865 Reviewed by Nikolas Zimmermann.
1867 Using of evas_object_visible_get() API can't gurantee the correctness of
1868 evas_object's visible status if it's called inside of evas_object's
1869 smart_show() method.
1870 So, a visible flag for the ewk_tiled_backing_store is added.
1871 In addition, as tiles are not visible, ewk_tiled_backing_store will push
1872 its own tiles into the cache when it disapear.
1874 * ewk/ewk_tiled_backing_store.cpp:
1875 (_ewk_tiled_backing_store_updates_process):
1876 (_ewk_tiled_backing_store_item_process_idler_start):
1877 (_ewk_tiled_backing_store_item_fill):
1878 (_ewk_tiled_backing_store_smart_member_add):
1879 (_ewk_tiled_backing_store_smart_show):
1880 (_ewk_tiled_backing_store_smart_hide):
1882 2012-01-13 KwangHyuk Kim <hyuki.kim@samsung.com>
1884 [EFL] Unused code cleanup on ewk_tiled_model.cpp.
1885 https://bugs.webkit.org/show_bug.cgi?id=76031
1887 Reviewed by Ryosuke Niwa.
1889 Remove unused code from ewk_tiled_model.cpp.
1891 * ewk/ewk_tiled_model.cpp:
1893 2012-01-12 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1895 [EFL] Move macro checking to functions' definition in ewk_js.cpp.
1896 https://bugs.webkit.org/show_bug.cgi?id=76037
1898 Reviewed by Andreas Kling.
1900 Moves macro checking to functions' definition instead of duplicate them in source depending on macro value.
1901 It's known practice in WebKit and EFL port.
1902 Duplicating functions in the same file whose return value is different may confuse user,
1903 especially if macro isn't included in a patch.
1906 (ewk_js_object_new):
1907 (ewk_js_object_free):
1908 (ewk_js_object_view_get):
1909 (ewk_js_object_properties_get):
1910 (ewk_js_object_name_get):
1911 (ewk_js_object_invoke):
1912 (ewk_js_object_type_get):
1913 (ewk_js_object_type_set):
1914 (ewk_js_variant_free):
1915 (ewk_js_variant_array_free):
1917 2012-01-12 KwangHyuk Kim <hyuki.kim@samsung.com>
1919 [EFL] Modify some API's implementation to let it directly pass Eina_Rectangle into IntRect.
1920 https://bugs.webkit.org/show_bug.cgi?id=75695
1922 Reviewed by Andreas Kling.
1924 Dereference Eina_Rectangle pointers so the shorter IntRect constructor can be used.
1927 (ewk_view_paint_context_clip):
1928 (ewk_view_paint_context_paint):
1929 (ewk_view_paint_context_paint_contents):
1931 (ewk_view_paint_contents):
1933 2012-01-11 JungJik Lee <jungjik.lee@samsung.com>
1935 [EFL] Refactor single backing store scroll code.
1936 https://bugs.webkit.org/show_bug.cgi?id=75243
1938 Reviewed by Zoltan Herczeg.
1940 Remove the duplicated code and refactor the scroll procedure.
1941 Wherever the page is scrolled, there are one screen copy and two updates.
1942 This patch optimises the scroll procedure by less calculation.
1944 * ewk/ewk_view_single.cpp:
1945 (_ewk_view_screen_move):
1946 (_ewk_view_single_scroll_process_single):
1948 2012-01-11 KwangHyuk Kim <hyuki.kim@samsung.com>
1950 [EFL] Fix page rendering issue on ewk_view_tiled.
1951 https://bugs.webkit.org/show_bug.cgi?id=75686
1953 Reviewed by Andreas Kling.
1955 As for now the discard of ewk_tiled_backing_store doesn't reset its own contents size information
1956 and ewk_tiled_backing_store just ignores the request if new contents size change request would contain
1957 the same size compared to the one that it owns,
1958 contents size change request coming from ChromeClientEfl::contentsSizeChanged() API can be skipped
1959 and therefore web page can't be presented properly.
1960 In order to resolve this, I just add code to reset contents size information which ewk_tiled_backing_store owns
1961 when it discards its own data.
1963 * ewk/ewk_tiled_backing_store.cpp:
1964 (ewk_tiled_backing_store_flush):
1966 2012-01-10 Tomasz Morawski <t.morawski@samsung.com>
1968 [EFL] Added smart pointers to Ewk_View_Paint_Context class and done minor refactoring.
1969 https://bugs.webkit.org/show_bug.cgi?id=75837
1971 Reviewed by Ryosuke Niwa.
1973 Changed graphicContext raw pointer to OwnPtr smart pointer.
1974 Renamed cr to cairo and made it a RefPtr.
1977 (ewk_view_paint_context_new): Adjust to auto pointers use.
1978 (ewk_view_paint_context_free): Removed explicit raw pointers delete.
1979 Adjust to auto pointers use:
1980 (ewk_view_paint_context_save):
1981 (ewk_view_paint_context_restore):
1982 (ewk_view_paint_context_clip):
1983 (ewk_view_paint_context_paint):
1984 (ewk_view_paint_context_paint_contents):
1986 2012-01-09 Raphael Kubo da Costa <kubo@profusion.mobi>
1988 [EFL] Add getter for Ewk_JS_Object::view.
1989 https://bugs.webkit.org/show_bug.cgi?id=75868
1991 Reviewed by Andreas Kling.
1993 So far the view associated with a given JS object was a private
1994 property only accessible to ewk itself. This does not make much sense,
1995 as one often needs to know which view a certain method was invoked
1999 (ewk_js_object_view_get):
2002 2012-01-06 JungJik Lee <jungjik.lee@samsung.com>
2004 [EFL] Add new pre-rendering code.
2005 https://bugs.webkit.org/show_bug.cgi?id=73430
2007 Reviewed by Zoltan Herczeg.
2009 Add new pre-rendering code to pre-render the view area more efficiently.
2010 At first find centered view position where backing store starts to queuing the render request from.
2011 And append the request into the tiled backing store in spiral order.
2013 * ewk/ewk_private.h:
2014 * ewk/ewk_tiled_backing_store.cpp:
2015 (ewk_tiled_backing_store_pre_render_tile_add):
2016 (ewk_tiled_backing_store_pre_render_spiral_queue):
2017 * ewk/ewk_tiled_backing_store.h:
2019 (_ewk_view_smart_pre_render_start):
2020 (ewk_view_base_smart_set):
2021 (ewk_view_pre_render_start):
2023 * ewk/ewk_view_tiled.cpp:
2024 (_ewk_view_tiled_rect_collision_check):
2025 (_ewk_view_tiled_rect_collision_resolve):
2026 (_ewk_view_tiled_smart_pre_render_start):
2027 (ewk_view_tiled_smart_set):
2029 2012-01-05 KwangHyuk Kim <hyuki.kim@samsung.com>
2031 [EFL] Invalidation request for ewk_view can be discarded without rendering.
2032 https://bugs.webkit.org/show_bug.cgi?id=71564
2034 Reviewed by Hajime Morita.
2036 As ewk_view discards a queue for invalidation requests
2037 as soon as it proceeds the repaint step, the newly produced invalidation requests
2038 from ewk_view_layout_if_needed_recursive API can be discarded
2039 and unpainted dirty area can occur.
2040 As this issue is just caused by use of flush API in repaint step,
2041 (internal API) ewk_view_repaints_get is replaced with ewk_view_repaints_pop
2042 in order to make sure that old invalidation requests are removed from queue.
2043 And in addition to that, ewk_view_repaint_add is modified
2044 in order to let queue of invalidation requests keep a proper size.
2045 As a result flush API won't be used for the repaint step.
2047 * ewk/ewk_private.h:
2049 (_ewk_view_repaint_add):
2050 (_ewk_view_smart_calculate):
2051 (ewk_view_repaints_pop):
2052 * ewk/ewk_view_single.cpp:
2053 (_ewk_view_single_smart_repaints_process):
2054 * ewk/ewk_view_tiled.cpp:
2055 (_ewk_view_tiled_smart_repaints_process):
2057 2012-01-04 KwangHyuk Kim <hyuki.kim@samsung.com>
2059 [EFL] Refactor the way using cairo in ewk_tiled_backing_store.
2060 https://bugs.webkit.org/show_bug.cgi?id=74993
2062 Reviewed by Nikolas Zimmermann.
2064 For now there are cairo related code scattered around the ewk_tiled_backing_store.
2065 From the point of code complexity view, it doesn't look good and I couldn't notice any benefit of it.
2066 So, this patch will let cairo related code be used only for painting operation.
2068 * ewk/ewk_tiled_backing_store.h:
2069 * ewk/ewk_tiled_matrix.cpp:
2070 (ewk_tile_matrix_tile_new):
2071 * ewk/ewk_tiled_model.cpp:
2074 * ewk/ewk_view_tiled.cpp:
2075 (_ewk_view_tiled_render_cb):
2077 2012-01-03 Jon Lee <jonlee@apple.com>
2079 Leak of WebNotificationClient when page is destroyed
2080 https://bugs.webkit.org/show_bug.cgi?id=74980
2081 <rdar://problem/10611231>
2083 Reviewed by Mark Rowe.
2085 * WebCoreSupport/NotificationPresenterClientEfl.cpp:
2086 (WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed): Stub implementation, because
2087 the notification presenter is unimplemented.
2088 * WebCoreSupport/NotificationPresenterClientEfl.h:
2090 2012-01-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2092 [EFL] Remove whitespace/declaration style exception
2093 https://bugs.webkit.org/show_bug.cgi?id=75424
2095 Reviewed by David Levin.
2097 EFL port doesn't need to avoid *whitespace/declaration* exception because of coding
2098 style change. However, EWebLauncher and MiniBrowser need to use EFL coding style because
2099 they are EFL application.
2101 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2102 * ewk/ewk_frame.cpp:
2103 (ewk_frame_feed_touch_event):
2104 * ewk/ewk_tiled_matrix.cpp:
2105 (ewk_tile_matrix_invalidate):
2108 2012-01-01 Eunmi Lee <eunmi15.lee@samsung.com>
2110 [EFL] Move function to get dpi to the WebCore/platform/efl/EflScreenUtilities.cpp.
2111 https://bugs.webkit.org/show_bug.cgi?id=75292
2113 Reviewed by Andreas Kling.
2115 Move ewk_util_dpi_get() function in the ewk_util.cpp to the
2116 WebCore/platform/efl/EflScreenUtilities.cpp in order to use it in the WebKit2.
2117 The function's name is changed to getDPI().
2119 * ewk/ewk_private.h:
2121 (ewk_util_image_from_cairo_surface_add):
2123 (_ewk_view_viewport_attributes_compute):
2125 2011-12-27 JungJik Lee <jungjik.lee@samsung.com>
2127 [EFL] Remove duplicate code and remove entry after freeing the matrix.
2128 https://bugs.webkit.org/show_bug.cgi?id=75073
2130 Reviewed by Ryosuke Niwa.
2132 Remove duplicate ewk_tile_unused_cache_freeze code.
2133 Entry matrix should free first before removing entry in inlist,
2134 because in eina_matrixsparce_free callback entry pointer is referenced to decrease the reference count.
2136 * ewk/ewk_tiled_matrix.cpp:
2137 (ewk_tile_matrix_free):
2139 2011-12-26 Ryuan Choi <ryuan.choi@samsung.com>
2141 [EFL] Last parameter of ewk_view_scroll is always true.
2142 https://bugs.webkit.org/show_bug.cgi?id=75157
2144 Reviewed by Andreas Kling.
2146 Remove unnecessary parameter in ewk_view_scroll and related code, because
2147 it's always true and ewk_view_tile can scroll when it is only true.
2149 * WebCoreSupport/ChromeClientEfl.cpp:
2150 (WebCore::ChromeClientEfl::scroll):
2151 * ewk/ewk_private.h:
2153 (_ewk_view_scroll_add):
2156 * ewk/ewk_view_tiled.cpp:
2157 (_ewk_view_tiled_smart_scrolls_process):
2159 2011-12-23 Raphael Kubo da Costa <kubo@profusion.mobi>
2161 Unreviewed; fix build with ENABLE(NETSCAPE_PLUGIN_API).
2163 * ewk/ewk_js.cpp: Include ewk_logging.h for ERR().
2165 2011-12-22 Mariusz Grzegorczyk <mariusz.g@samsung.com>
2167 [EFL] Missing plugins support for efl port
2168 https://bugs.webkit.org/show_bug.cgi?id=44505
2170 Reviewed by Anders Carlsson.
2172 Implementation of ewk_frame_plugin_create() - creating PluginView.
2174 * ewk/ewk_frame.cpp:
2175 (ewk_frame_plugin_create):
2177 2011-12-22 Eunmi Lee <eunmi15.lee@samsung.com>
2179 [EFL] Remove unused parameter names.
2180 https://bugs.webkit.org/show_bug.cgi?id=74702
2182 Reviewed by Eric Seidel.
2185 (_ewk_view_on_focus_in):
2186 (_ewk_view_on_focus_out):
2187 (_ewk_view_on_mouse_wheel):
2188 (_ewk_view_on_mouse_down):
2189 (_ewk_view_on_mouse_up):
2190 (_ewk_view_on_mouse_move):
2191 (_ewk_view_on_key_down):
2192 (_ewk_view_on_key_up):
2193 * ewk/ewk_view_single.cpp:
2194 (_ewk_view_single_on_del):
2196 2011-12-22 KwangHyuk Kim <hyuki.kim@samsung.com>
2198 [EFL] Invalidation request for outside of visible area doesn't seem to occur when tiled view is used.
2199 https://bugs.webkit.org/show_bug.cgi?id=70873
2201 Reviewed by Anders Carlsson.
2203 In order to guarantee the paint outside of viewport when ewk_view_tiled is used,
2204 ewk_frame_paint_full_set should be called by ewk_frame_view_create_for_view
2205 when frame is created because frame view can be created newly as soon as page is created.
2206 But for the ewk_view_single, as it doesn't need to paint outside of viewport,
2207 ewk_frame_paint_full_set must not be called for ewk_view_single.
2209 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2210 (WebCore::FrameLoaderClientEfl::transitionToCommittedForNewPage):
2211 * ewk/ewk_private.h:
2213 (ewk_view_frame_view_creation_notify):
2214 * ewk/ewk_view_tiled.cpp:
2215 (_ewk_view_tiled_smart_add):
2216 (ewk_view_tiled_smart_set):
2218 2011-12-21 Michał Pakuła vel Rutka <m.pakula@samsung.com>
2220 [EFL] Add 'Select All' option to context menus in WebKit-EFL.
2221 https://bugs.webkit.org/show_bug.cgi?id=74920
2223 Reviewed by Eric Seidel.
2225 Enable 'Select All' option to context menus called on input fields in WebKit-EFL
2226 as it is enabled in GTK and QT ports.
2228 * ewk/ewk_contextmenu.h: Add new context menu option 'Select All'.
2230 2011-12-19 Ryuan Choi <ryuan.choi@samsung.com>
2232 [EFL] Change the behavior of ewk_view_scale_set.
2233 https://bugs.webkit.org/show_bug.cgi?id=70078
2235 Reviewed by Eric Seidel.
2237 Remove center point basis zoom alignment from ewk_view_scale_set to call
2238 Page::setPageScaleFactor without any adjustment.
2241 (ewk_view_scale_set):
2244 2011-12-19 Raphael Kubo da Costa <kubo@profusion.mobi>
2246 Unreviewed; fix the build with ENABLE(TOUCH_EVENTS) after r103167.
2248 This partly reverts r102297: the Touch{Start,Move,End,Cancel} events
2249 are not in a separate enum anymore (they are part of
2250 WebCore::PlatformEvent), so the assertions in AssertMatchingEnums.cpp
2251 always fail. Setting EWK_TOUCH_START to TouchStart feels even more
2252 hackish, so we just convert the types manually again for now.
2254 * WebCoreSupport/AssertMatchingEnums.cpp:
2255 * ewk/ewk_frame.cpp:
2256 (ewk_frame_feed_touch_event):
2258 2011-12-17 Sam Weinig <sam@webkit.org>
2260 Make PlatformTouchEvent inherit from PlatformEvent
2261 https://bugs.webkit.org/show_bug.cgi?id=74777
2263 Reviewed by Andreas Kling.
2265 * ewk/ewk_frame.cpp:
2266 (ewk_frame_feed_touch_event):
2267 Rename TouchEventType to PlatformEvent::Type.
2269 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
2271 Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
2272 https://bugs.webkit.org/show_bug.cgi?id=74748
2274 Reviewed by Eric Seidel.
2276 * WebCoreSupport/EditorClientEfl.cpp:
2277 (WebCore::EditorClientEfl::registerUndoStep):
2278 (WebCore::EditorClientEfl::registerRedoStep):
2279 * WebCoreSupport/EditorClientEfl.h:
2281 2011-12-16 Sam Weinig <sam@webkit.org>
2283 Give PlatformEvents a base class
2284 https://bugs.webkit.org/show_bug.cgi?id=74685
2286 Reviewed by Anders Carlsson.
2288 Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
2289 and PlatformGestureEvent and move Type enumeration and modifiers down to it.
2291 * WebCoreSupport/EditorClientEfl.cpp:
2292 (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
2294 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
2296 Only EditCommandComposition should implement unapply and reapply
2297 https://bugs.webkit.org/show_bug.cgi?id=74490
2299 Reviewed by Eric Seidel.
2301 * WebCoreSupport/EditorClientEfl.cpp:
2302 (WebCore::EditorClientEfl::registerCommandForUndo):
2303 (WebCore::EditorClientEfl::registerCommandForRedo):
2304 (WebCore::EditorClientEfl::undo):
2305 (WebCore::EditorClientEfl::redo):
2306 * WebCoreSupport/EditorClientEfl.h:
2308 2011-12-15 Raphael Kubo da Costa <kubo@profusion.mobi>
2310 [EFL] Clean up and refactor the memory cache functions in ewk_settings.
2311 https://bugs.webkit.org/show_bug.cgi?id=72140
2313 Reviewed by Antonio Gomes.
2315 Use a better naming prefix, as "ewk_settings_cache" was too general,
2316 and make it possible to pass all parameters to
2317 MemoryCache::setCapacities().
2319 * ewk/ewk_settings.cpp:
2320 (ewk_settings_object_cache_capacity_set):
2321 (ewk_settings_object_cache_enable_get):
2322 (ewk_settings_object_cache_enable_set):
2323 * ewk/ewk_settings.h:
2325 2011-12-15 Raphael Kubo da Costa <kubo@profusion.mobi>
2327 [EFL] Add a few more web database functions to ewk_settings.
2328 https://bugs.webkit.org/show_bug.cgi?id=72148
2330 Reviewed by Antonio Gomes.
2332 Add code to change the default quota (there as only a getter so far)
2333 and one to clear the databases.
2335 * ewk/ewk_settings.cpp:
2336 (ewk_settings_web_database_default_quota_set):
2337 (ewk_settings_web_database_clear):
2338 * ewk/ewk_settings.h:
2340 2011-12-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2342 [EFL] Change efl style variable name with WebKit style for internal functions.
2343 https://bugs.webkit.org/show_bug.cgi?id=74474
2345 Reviewed by Ryosuke Niwa.
2347 In order to be more compliant with WebKit coding style, variable names of internal functions
2348 should be changed with WebKit coding style.
2350 * ewk/ewk_private.h:
2354 2011-12-14 Jing Zhao <jingzhao@chromium.org>
2356 Opening two popup menus by dispatchEvent() makes problems.
2357 https://bugs.webkit.org/show_bug.cgi?id=73304
2359 Reviewed by Kent Tamura.
2361 * WebCoreSupport/ChromeClientEfl.cpp:
2362 (WebCore::ChromeClientEfl::hasOpenedPopup): Not implemented.
2363 * WebCoreSupport/ChromeClientEfl.h: Overrides hasOpenedPopup().
2365 2011-12-12 Raphael Kubo da Costa <kubo@profusion.mobi>
2367 [EFL] Add API to query the validity of a frame's SSL certificate.
2368 https://bugs.webkit.org/show_bug.cgi?id=74302
2370 Reviewed by Gustavo Noronha Silva.
2372 * ewk/ewk_frame.cpp:
2373 (ewk_frame_certificate_status_get):
2376 2011-12-12 Raphael Kubo da Costa <kubo@profusion.mobi>
2378 [EFL] Add API to notify that mixed content has been loaded.
2379 https://bugs.webkit.org/show_bug.cgi?id=74301
2381 Reviewed by Gustavo Noronha Silva.
2383 When mixed content is displayed/run, both frames and views
2384 emit the proper signals to notify API users.
2386 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2387 (WebCore::FrameLoaderClientEfl::didDisplayInsecureContent):
2388 (WebCore::FrameLoaderClientEfl::didRunInsecureContent):
2389 * ewk/ewk_frame.cpp:
2390 (ewk_frame_view_create_for_view):
2391 (ewk_frame_mixed_content_displayed_get):
2392 (ewk_frame_mixed_content_run_get):
2393 (ewk_frame_mixed_content_displayed_set):
2394 (ewk_frame_mixed_content_run_set):
2396 * ewk/ewk_private.h:
2398 (ewk_view_frame_main_cleared):
2399 (ewk_view_mixed_content_displayed_get):
2400 (ewk_view_mixed_content_run_get):
2401 (ewk_view_mixed_content_displayed_set):
2402 (ewk_view_mixed_content_run_set):
2405 2011-12-12 Raphael Kubo da Costa <kubo@profusion.mobi>
2407 [EFL] Add API to manage root X.509 CA certificates.
2408 https://bugs.webkit.org/show_bug.cgi?id=74300
2410 Reviewed by Martin Robinson.
2412 * ewk/ewk_network.cpp:
2413 (ewk_network_tls_ca_certificates_path_get):
2414 (ewk_network_tls_ca_certificates_path_set):
2415 * ewk/ewk_network.h:
2417 2011-12-12 Raphael Kubo da Costa <kubo@profusion.mobi>
2419 [EFL] Add API to control whether SSL certificates should be checked.
2420 https://bugs.webkit.org/show_bug.cgi?id=74299
2422 Reviewed by Martin Robinson.
2425 (_ewk_init_body): Explicitly disable certificate checks by default.
2426 * ewk/ewk_network.cpp:
2427 (ewk_network_tls_certificate_check_get):
2428 (ewk_network_tls_certificate_check_set):
2429 * ewk/ewk_network.h:
2431 2011-12-07 Ryuan Choi <ryuan.choi@samsung.com>
2433 [EFL] Introduce AssertMatchingEnums.cpp.
2434 https://bugs.webkit.org/show_bug.cgi?id=65238
2436 Reviewed by Filip Pizlo.
2438 Add AssertMatchingEnums.cpp to assert that various WebKit API enum values
2439 match to WebCore defined enum values.
2441 * CMakeListsEfl.txt: add AssertMatchingEnums.cpp.
2442 * WebCoreSupport/AssertMatchingEnums.cpp: Added.
2443 * ewk/ewk_frame.cpp:
2444 (ewk_frame_feed_touch_event): remove switch statement wichi convert WebKit API enum value to WebCore defined enum values.
2445 (ewk_frame_text_selection_type_get): Ditto.
2447 (ewk_view_mode_set): Ditto.
2448 (ewk_view_mode_get): Ditto.
2449 (ewk_view_visibility_state_set): Ditto.
2450 (ewk_view_visibility_state_get): Ditto.
2451 * ewk/ewk_frame.h: fix order of enum values.
2452 * ewk/ewk_view.h: add missing enum value.
2454 2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
2456 Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
2457 https://bugs.webkit.org/show_bug.cgi?id=73986
2459 Reviewed by Kenneth Rohde Christiansen.
2464 2011-12-05 Raphael Kubo da Costa <kubo@profusion.mobi>
2466 [EFL] Do not lose message flags when converting to/from Soup Requests/Responses
2467 https://bugs.webkit.org/show_bug.cgi?id=73924
2469 Reviewed by Gustavo Noronha Silva.
2471 Apply the same change added to the GTK+ port in r55086 to prevent
2472 soup message flags from being lost by updating the request flags when
2473 a response is received.
2475 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2476 (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
2478 2011-12-04 Kangil Han <kangil.han@samsung.com>
2480 [EFL] Fix broken UTF-8 characters issue on editor command.
2481 https://bugs.webkit.org/show_bug.cgi?id=73516
2483 Reviewed by Ryosuke Niwa.
2485 The issue has been described that Korean character is broken on pasting copied text.
2486 In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
2487 Therefore, this patch will convert types to resolve the problem.
2490 (_ewk_view_editor_command):
2492 2011-12-03 ChangSeok Oh <shivamidow@gmail.com>
2494 [EFL] Revise ewk_view_fixed_layout_size_set
2495 https://bugs.webkit.org/show_bug.cgi?id=73401
2497 Reviewed by Eric Seidel.
2499 Improve readability and replace forceLayout to setNeedsLayout,
2500 since it sometimes causes double drawing.
2503 (ewk_view_fixed_layout_size_set):
2505 2011-12-02 JungJik Lee <jungjik.lee@samsung.com>
2507 [EFL] Remove entry pointer before freeing it from matrix.
2508 https://bugs.webkit.org/show_bug.cgi?id=73625
2510 Reviewed by Ryosuke Niwa.
2512 To prevent leaving dangling pointer on the matrix, remove the entry before freeing it.
2514 * ewk/ewk_tiled_matrix.cpp:
2515 (ewk_tile_matrix_free):
2517 2011-12-01 Ryuan Choi <ryuan.choi@samsung.com>
2519 [EFL] Cleanup includes to reduce code complexity.
2520 https://bugs.webkit.org/show_bug.cgi?id=73540
2522 Reviewed by Gustavo Noronha Silva.
2524 EWebKit.h is a list of public header files for application to use WebKit/Efl.
2525 This patch removes EWebKit.h in internal files to reduce unnecessary includes.
2526 In addition, reorders optional includes to fix style.
2528 * WebCoreSupport/ChromeClientEfl.cpp:
2529 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
2530 * WebCoreSupport/EditorClientEfl.cpp:
2531 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2532 * ewk/ewk_auth_soup.cpp:
2533 * ewk/ewk_contextmenu.cpp:
2534 * ewk/ewk_cookies.cpp:
2535 * ewk/ewk_frame.cpp:
2536 * ewk/ewk_history.cpp:
2538 * ewk/ewk_private.h:
2539 * ewk/ewk_settings.cpp:
2542 * ewk/ewk_view_single.cpp:
2543 * ewk/ewk_view_tiled.cpp:
2544 * ewk/ewk_window_features.cpp:
2546 2011-12-01 Raphael Kubo da Costa <kubo@profusion.mobi>
2548 [EFL] Remove the ewk_protocol_handler-related code
2549 https://bugs.webkit.org/show_bug.cgi?id=73018
2551 Reviewed by Martin Robinson.
2553 This functionality has been broken since r99364, which stopped setting
2554 the "webkit-resource" property needed by
2555 ewk_protocol_handler_soup.cpp.
2557 After giving it some thought, it looks clear that this code should not
2558 be in ewk at all: it is very backend-specific (even in the function
2559 signatures it expects), and it only allows callers to register schemes
2560 once and provide a single handler to all of them, which does not make
2563 Client code using WebKit-EFL with the soup backend should be
2564 responsible for creating their own request handlers (ie. subclass
2565 SoupRequest) instead.
2567 For that to be possible, a function which returns the default
2568 SoupSession used by WebKit has been added.
2570 * CMakeListsEfl.txt:
2571 * ewk/ewk_network.cpp:
2572 (ewk_network_default_soup_session_get):
2573 * ewk/ewk_network.h:
2574 * ewk/ewk_private.h:
2575 * ewk/ewk_protocol_handler.cpp: Removed.
2576 * ewk/ewk_protocol_handler.h: Removed.
2577 * ewk/ewk_protocol_handler_soup.cpp: Removed.
2578 * ewk/ewk_protocol_handler_soup.h: Removed.
2582 2011-11-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2584 Unreviewed. Fix build error when NOTIFICATIONS feature is enabled.
2586 * WebCoreSupport/ChromeClientEfl.h:
2588 2011-11-30 Alexey Proskuryakov <ap@apple.com>
2590 Remove an unneeded argument from FrameLoaderClient::download
2591 https://bugs.webkit.org/show_bug.cgi?id=73486
2593 Reviewed by Andreas Kling.
2595 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2596 (WebCore::FrameLoaderClientEfl::download):
2597 * WebCoreSupport/FrameLoaderClientEfl.h:
2598 Updated for the change.
2600 2011-11-30 JungJik Lee <jungjik.lee@samsung.com>
2602 [EFL] Apply alpha channel into ewk_tiled_backing_store's tile objects.
2603 https://bugs.webkit.org/show_bug.cgi?id=73015
2605 Reviewed by Chang Shu.
2607 Add alpha_set API to tiled backing store to apply alpha channel on tile objects.
2609 * ewk/ewk_tiled_backing_store.cpp:
2610 (_ewk_tiled_backing_store_tile_associate):
2611 (ewk_tiled_backing_store_alpha_set):
2612 * ewk/ewk_tiled_backing_store.h:
2614 * ewk/ewk_view_tiled.cpp:
2615 (_ewk_view_tiled_smart_bg_color_set):
2616 (ewk_view_tiled_smart_set):
2618 2011-11-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2620 [EFL] Remove duplicated UA information function.
2621 https://bugs.webkit.org/show_bug.cgi?id=73104
2623 Reviewed by Filip Pizlo.
2625 Though ewk_setting already implemented an internal function for UA(user agent) information,
2626 FrameLoaderClientEfl has used duplicated function for UA information. So, this patch removes
2627 the UA information function of FrameLoaderClientEfl and uses an internal UA information function
2628 of ewk_setting. In addition, UA infomation function is enhanced for other ports.
2630 * WebCoreSupport/FrameLoaderClientEfl.cpp:
2631 (WebCore::composeUserAgent):
2632 * ewk/ewk_settings.cpp:
2633 (ewk_settings_default_user_agent_get):
2635 2011-11-30 Tomasz Morawski <t.morawski@samsung.com>
2637 [EFL] Added DEFAULT_CACHE_SIZE define.
2638 https://bugs.webkit.org/show_bug.cgi?id=73120
2640 Reviewed by Filip Pizlo.
2642 Remove form code 40960000 value used in code directly and replaced it by DEFAULT_CACHE_SIZE define. The code
2645 * ewk/ewk_tiled_matrix.cpp:
2646 (ewk_tile_matrix_new):
2648 2011-11-28 JungJik Lee <jungjik.lee@samsung.com>
2650 [EFL] Rename abbreviated value names to cpp style names.
2651 https://bugs.webkit.org/show_bug.cgi?id=73193
2653 Reviewed by Andreas Kling.
2655 Rename abbreviated values name to cpp style names in ewk_single/tiled_view.cpp.
2657 * ewk/ewk_view_single.cpp:
2658 (_ewk_view_4b_move_region_up):
2659 (_ewk_view_4b_move_region_down):
2660 (_ewk_view_4b_move_line_left):
2661 (_ewk_view_4b_move_line_right):
2662 (_ewk_view_4b_move_region_left):
2663 (_ewk_view_4b_move_region_right):
2664 (_ewk_view_4b_move_region):
2665 (_ewk_view_single_scroll_process_single):
2666 (_ewk_view_single_smart_repaints_process):
2667 * ewk/ewk_view_tiled.cpp:
2668 (_ewk_view_tiled_smart_scrolls_process):
2669 (_ewk_view_tiled_smart_repaints_process):
2671 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
2673 Unreviewed, rolling out r101193.
2674 http://trac.webkit.org/changeset/101193
2675 https://bugs.webkit.org/show_bug.cgi?id=73158
2677 Breaks Windows and Qt minimal. (Requested by pfeldman on
2680 * WebCoreSupport/InspectorClientEfl.cpp:
2681 * WebCoreSupport/InspectorClientEfl.h:
2683 2011-11-24 KwangHyuk Kim <hyuki.kim@samsung.com>
2685 [EFL] Add implementation considering ewk_tiled_backing_store's visible status.
2686 https://bugs.webkit.org/show_bug.cgi?id=71791
2688 Reviewed by Gustavo Noronha Silva.
2690 In order to prevent rendering and pre-rendering while backing store is hidden,
2691 its visibility is checked and pre-rendering is handled whenever backing store is shown or hidden.
2693 * ewk/ewk_tiled_backing_store.cpp:
2694 (_ewk_tiled_backing_store_item_process_idler_start):
2695 (_ewk_tiled_backing_store_item_fill):
2696 (_ewk_tiled_backing_store_smart_show):
2697 (_ewk_tiled_backing_store_smart_hide):
2698 (ewk_tiled_backing_store_add):
2700 2011-11-22 Pavel Feldman <pfeldman@google.com>
2702 Web Inspector: remove Inspector::bringToFront from the protocol.
2703 https://bugs.webkit.org/show_bug.cgi?id=72937
2705 Reviewed by Yury Semikhatsky.
2707 * WebCoreSupport/InspectorClientEfl.cpp:
2708 (WebCore::InspectorClientEfl::bringFrontendToFront):
2709 * WebCoreSupport/InspectorClientEfl.h:
2711 2011-11-21 Raphael Kubo da Costa <kubo@profusion.mobi>
2713 [EFL] Add more appcache functions to ewk_settings.
2714 https://bugs.webkit.org/show_bug.cgi?id=72143
2716 Reviewed by Kenneth Rohde Christiansen.
2718 Add a few more functions to make it possible to have more control over
2719 the offline web application features.
2721 * ewk/ewk_settings.cpp:
2722 (ewk_settings_application_cache_max_quota_get):
2723 (ewk_settings_application_cache_max_quota_set):
2724 (ewk_settings_application_cache_clear):
2725 * ewk/ewk_settings.h:
2727 2011-10-17 Antonio Gomes <agomes@rim.com>
2729 Pass a Frame* parameter in EditorClient::respondToChangedSelection
2730 https://bugs.webkit.org/show_bug.cgi?id=70248
2732 Reviewed by Ryosuke Niwa.
2734 * WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter.
2735 (WebCore::EditorClientEfl::respondToChangedSelection):
2736 * WebCoreSupport/EditorClientEfl.h:
2738 2011-11-17 KwangHyuk Kim <hyuki.kim@samsung.com>
2740 [EFL] Add matrix list to reuse tile matrix for each different zoom level.
2741 https://bugs.webkit.org/show_bug.cgi?id=68595
2743 Reviewed by Kenneth Rohde Christiansen.
2745 Add matrix list to keep each tile matrix corresponding to each different zoom level when zoom level is changed.
2746 Then backing store can reuse tile matrix by getting it from this matrix list.
2748 * ewk/ewk_tiled_backing_store.cpp:
2749 (_ewk_tiled_backing_store_model_matrix_create):
2750 (_ewk_tiled_backing_store_smart_calculate):
2751 (_ewk_tiled_backing_store_zoom_set_internal):
2752 * ewk/ewk_tiled_matrix.cpp:
2753 (ewk_tile_matrix_entry_get):
2754 (_ewk_tile_matrix_cell_free):
2755 (_ewk_tile_matrix_tile_free):
2756 (ewk_tile_matrix_new):
2757 (ewk_tile_matrix_zoom_level_set):
2758 (ewk_tile_matrix_invalidate):
2759 (ewk_tile_matrix_free):
2760 (ewk_tile_matrix_tile_new):
2761 * ewk/ewk_tiled_matrix.h:
2763 2011-11-17 Raphael Kubo da Costa <kubo@profusion.mobi>
2765 [EFL] Clean up the use of DATA_DIR in the buildsystem
2766 https://bugs.webkit.org/show_bug.cgi?id=72681
2768 Reviewed by Daniel Bates.
2770 Instead of messing with BUILD_DATA_DIR and PARENT_SCOPE, just use
2771 THEME_BINARY_DIR as defined in OptionsEfl.cmake.
2773 * CMakeListsEfl.txt:
2775 2011-11-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2777 [EFL] Use standard booleand data type in struct.
2778 https://bugs.webkit.org/show_bug.cgi?id=72565
2780 Reviewed by Martin Robinson.
2782 Change *Eina_Bool* usages with *bool* in member variables of internal struct.
2784 * ewk/ewk_contextmenu.cpp:
2785 * ewk/ewk_frame.cpp:
2786 * ewk/ewk_tiled_backing_store.cpp:
2789 2011-11-16 Raphael Kubo da Costa <kubo@profusion.mobi>
2791 [EFL] Add ewk_settings_memory_cache_clear().
2792 https://bugs.webkit.org/show_bug.cgi?id=72141
2794 Reviewed by Kenneth Rohde Christiansen.
2796 This is the same as Qt's QWebSettings::clearMemoryCaches() and is
2797 responsible for clearing, among others, the page, memory and font
2800 * ewk/ewk_settings.cpp:
2801 (ewk_settings_memory_cache_clear):
2802 * ewk/ewk_settings.h:
2804 2011-11-16 Raphael Kubo da Costa <kubo@profusion.mobi>
2806 [EFL] Clean up the web database-related functions in ewk_settings.
2807 https://bugs.webkit.org/show_bug.cgi?id=72139
2809 Reviewed by Kenneth Rohde Christiansen.
2811 Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
2812 more standard naming scheme for the related static variables.
2814 * ewk/ewk_settings.cpp:
2815 (ewk_settings_web_database_default_quota_get):
2816 (ewk_settings_web_database_path_set):
2817 (ewk_settings_web_database_path_get):
2818 * ewk/ewk_settings.h: Document the default web database path on disk.
2820 2011-11-16 Raphael Kubo da Costa <kubo@profusion.mobi>
2822 [EFL] Clean up the offline apps-related functions in ewk_settings.
2823 https://bugs.webkit.org/show_bug.cgi?id=72132
2825 Reviewed by Kenneth Rohde Christiansen.
2827 `ewk_settings_cache' and `ewk_view_setting_cache' are too common
2828 prefixes for code that is related only to the HTML5 app cache
2831 Use `ewk_settings_application_cache' and
2832 `ewk_view_setting_application_cache' instead.
2834 While here, improve the documentation and use a more common naming
2835 scheme for the static variable which holds the cache path.
2839 * ewk/ewk_settings.cpp:
2840 (ewk_settings_application_cache_path_set):
2841 (ewk_settings_application_cache_path_get):
2842 * ewk/ewk_settings.h:
2844 (ewk_view_setting_application_cache_get):
2845 (ewk_view_setting_application_cache_set):
2848 2011-11-15 Anders Carlsson <andersca@apple.com>
2850 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
2851 https://bugs.webkit.org/show_bug.cgi?id=72397
2853 Reviewed by Dan Bernstein.
2855 * WebCoreSupport/ChromeClientEfl.cpp:
2856 (WebCore::ChromeClientEfl::rootViewToScreen):
2857 (WebCore::ChromeClientEfl::screenToRootView):
2858 * WebCoreSupport/ChromeClientEfl.h:
2860 2011-11-14 Anders Carlsson <andersca@apple.com>
2862 HostWindow invalidation functions should use root view coordinates
2863 https://bugs.webkit.org/show_bug.cgi?id=72338
2865 Reviewed by Dan Bernstein.
2867 * WebCoreSupport/ChromeClientEfl.cpp:
2868 (WebCore::ChromeClientEfl::invalidateRootView):
2869 (WebCore::ChromeClientEfl::invalidateContentsAndRootView):
2870 (WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):
2871 * WebCoreSupport/ChromeClientEfl.h:
2873 2011-11-15 Grzegorz Czajkowski <g.czajkowski@samsung.com>
2875 [EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL.
2876 https://bugs.webkit.org/show_bug.cgi?id=70091
2878 Reviewed by Filip Pizlo.
2880 Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance
2881 with WebKit-EFL functions.
2883 * ewk/ewk_frame.cpp:
2884 (ewk_frame_contents_set):
2885 (ewk_frame_contents_alternate_set):
2887 2011-11-14 Jongseok Yang <js45.yang@samsung.com>
2889 [EFL] Update ewk_frame_script_execute to return the result for JavaScript
2890 https://bugs.webkit.org/show_bug.cgi?id=65972
2892 Reviewed by Antonio Gomes.
2894 It executes the javascript and converts the result to a string using toString.
2895 And it returns the memory-allocated pointer for the value.
2897 * ewk/ewk_frame.cpp:
2898 (ewk_frame_script_execute):
2901 2011-11-13 Raphael Kubo da Costa <kubo@profusion.mobi>
2903 [EFL] Improve the documentation of ewk_view_setting_local_storage_*.
2904 https://bugs.webkit.org/show_bug.cgi?id=72135
2906 Reviewed by Kenneth Rohde Christiansen.
2908 Add some "see also" pointers, mention the default paths used for local
2909 storage and document how things will not be persisted to disk if a
2910 storage path is not set.
2914 2011-11-13 Raphael Kubo da Costa <kubo@profusion.mobi>
2916 [EFL] Simplify eina_stringshare usage in ewk_settings.
2917 https://bugs.webkit.org/show_bug.cgi?id=72127
2919 Reviewed by Kenneth Rohde Christiansen.
2921 Actually use the eina_stringshare functions in a sane way.
2923 * ewk/ewk_settings.cpp:
2924 (ewk_settings_web_database_path_set): Just use
2925 eina_stringshare_replace instead of doing needless checks and using
2926 eina_stringshare_add.
2927 (ewk_settings_cache_directory_path_set): Ditto.
2928 (ewk_settings_icon_database_path_set): Ditto and always call
2929 eina_stringshare_del, as passing NULL to it is just a NOP.
2931 2011-11-11 JungJik Lee <jungjik.lee@samsung.com>
2933 [EFL] Remove unused flags in pre-render implementation
2934 https://bugs.webkit.org/show_bug.cgi?id=65504
2936 The high priority pre-render flag was not used anywhere,
2937 so we can get rid of the whole concept and always consider the requests have low priority
2939 Reviewed by Daniel Bates.
2941 * ewk/ewk_tiled_backing_store.cpp:
2942 (_ewk_tiled_backing_store_pre_render_request_add):
2943 (ewk_tiled_backing_store_pre_render_region):
2944 (ewk_tiled_backing_store_pre_render_relative_radius):
2946 2011-11-09 Raphael Kubo da Costa <kubo@profusion.mobi>
2948 [EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
2949 https://bugs.webkit.org/show_bug.cgi?id=71891
2951 Reviewed by Antonio Gomes.
2953 This is C++ code, there is no need to cast the new objects to their
2954 parents when creating them.
2957 (_ewk_view_priv_new):
2959 2011-11-09 Tomasz Morawski <t.morawski@samsung.com>
2961 [EFL] Removed unused variable
2962 https://bugs.webkit.org/show_bug.cgi?id=71877
2964 Reviewed by Andreas Kling.
2966 Removed unused rect variable declaration and renamed rect1 variable to rect.
2968 * ewk/ewk_tiled_backing_store.cpp:
2969 (_ewk_tiled_backing_store_smart_calculate):
2971 2011-11-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2973 [EFL] Need to replace api's object parameter with proper name.
2974 https://bugs.webkit.org/show_bug.cgi?id=71553
2976 Fix wrong parameter names in tiled backing store functions and ewk_view_xxx files.
2978 Reviewed by Filip Pizlo.
2980 * ewk/ewk_tiled_backing_store.cpp:
2981 * ewk/ewk_view_single.cpp:
2982 * ewk/ewk_view_tiled.cpp:
2984 2011-11-07 Raphael Kubo da Costa <kubo@profusion.mobi>
2986 [EFL] Emit the "frame,created" signal earlier.
2987 https://bugs.webkit.org/show_bug.cgi?id=71696
2989 Reviewed by Kenneth Rohde Christiansen.
2991 FrameLoader::loadURLIntoChildFrame will trigger the machinery that will call
2992 FrameLoaderClientEfl::dispatchDidStartProvisionalLoad. However, since we were
2993 emitting the "frame,created" signal after that, applications would connect to
2994 it after some other frame signals had already been emitted. Should help tests
2995 such as http/tests/loading/empty-subframe.html pass.
2997 * ewk/ewk_frame.cpp:
2998 (ewk_frame_child_add):
3000 (ewk_view_frame_create):
3002 2011-11-04 Raphael Kubo da Costa <kubo@profusion.mobi>
3004 [EFL] DRT: Fix the order of the items in the dumped history list.
3005 https://bugs.webkit.org/show_bug.cgi?id=71562
3007 It did not make much sense to hold the history list in a map, as we do not need
3008 the keys. And the printed items must be sorted by target, which is more easily
3011 Should make tests such as http/tests/navigation/error404-frames.html pass.
3013 Reviewed by Antonio Gomes.
3015 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
3016 (DumpRenderTreeSupportEfl::childHistoryItems):
3017 * WebCoreSupport/DumpRenderTreeSupportEfl.h:
3019 2011-11-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3021 [EFL] Use standard booleand data type.
3022 https://bugs.webkit.org/show_bug.cgi?id=71433
3024 This is a fourth step in order to be more compliant with WebKit coding style.
3025 Use standard boolean data type instead of efl boolean data type. It makes efl port
3026 is more close to webkit coding style.
3028 Reviewed by Zoltan Herczeg.
3030 * WebCoreSupport/ChromeClientEfl.cpp:
3031 * WebCoreSupport/FrameLoaderClientEfl.cpp:
3032 * ewk/ewk_contextmenu.cpp:
3033 * ewk/ewk_cookies.cpp:
3034 * ewk/ewk_frame.cpp:
3035 * ewk/ewk_history.cpp:
3038 * ewk/ewk_network.cpp:
3039 * ewk/ewk_private.h:
3040 * ewk/ewk_protocol_handler.cpp:
3041 * ewk/ewk_protocol_handler_soup.cpp:
3042 * ewk/ewk_settings.cpp:
3043 * ewk/ewk_tiled_backing_store.cpp:
3044 * ewk/ewk_tiled_matrix.cpp:
3045 * ewk/ewk_tiled_model.cpp:
3048 * ewk/ewk_view_single.cpp:
3049 * ewk/ewk_view_tiled.cpp:
3051 2011-11-03 Tomasz Morawski <t.morawski@samsung.com>
3053 [EFL] Added ewk_tile_memory_size_get function
3054 https://bugs.webkit.org/show_bug.cgi?id=71213
3056 Reviewed by Anders Carlsson.
3058 Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup
3061 * ewk/ewk_tiled_model.cpp:
3062 (ewk_tile_memory_size_get):
3063 (ewk_tile_unused_cache_flush):
3064 (ewk_tile_unused_cache_tile_get):
3065 (ewk_tile_unused_cache_tile_put):
3066 * ewk/ewk_tiled_model.h:
3068 2011-11-03 Darin Adler <darin@apple.com>
3070 Change remaining callers of releaseRef to call leakRef
3071 https://bugs.webkit.org/show_bug.cgi?id=71422
3073 Reviewed by Darin Fisher.
3075 * ewk/ewk_history.cpp:
3076 (ewk_history_item_new): Use leakRef.
3078 2011-11-02 Darin Adler <darin@apple.com>
3080 Change remaining callers of releaseRef to call leakRef
3081 https://bugs.webkit.org/show_bug.cgi?id=71422
3083 Reviewed by Darin Fisher.
3085 * ewk/ewk_history.cpp:
3086 (ewk_history_item_new): Use leakRef.
3088 2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
3090 De-virtualize JSObject::className
3091 https://bugs.webkit.org/show_bug.cgi?id=71428
3093 Reviewed by Sam Weinig.
3095 Added className to the MethodTable, changed all the virtual
3096 implementations of className to static ones, and replaced
3097 all call sites with corresponding lookups in the MethodTable.
3100 (ewk_js_npobject_to_object):
3102 2011-11-03 Fady Samuel <fsamuel@chromium.org>
3104 Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
3105 https://bugs.webkit.org/show_bug.cgi?id=70609
3107 Reviewed by Kenneth Rohde Christiansen.
3110 (_ewk_view_viewport_attributes_compute):
3112 2011-11-03 Dongwoo Im <dw.im@samsung.com>
3114 [EFL] Enable the Page Visibility API.
3115 https://bugs.webkit.org/show_bug.cgi?id=69127
3117 Reviewed by Adam Barth.
3119 Implement methods to enable the Page Visibility API on EFL port.
3120 (http://www.w3.org/TR/page-visibility)
3122 When the visibility status of the page is changed, browser could
3123 inform the status to WebKit using the APIs below.
3125 * ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.
3126 (ewk_view_visibility_state_set): Sets the page visibility status.
3127 (ewk_view_visibility_state_get): Gets the page visibility status.
3128 * ewk/ewk_view.h: Add public prototypes.
3130 2011-11-02 Tom Sepez <tsepez@chromium.org>
3132 XSSAuditor is silent
3133 https://bugs.webkit.org/show_bug.cgi?id=70973
3135 Reviewed by Adam Barth.
3137 * WebCoreSupport/FrameLoaderClientEfl.cpp:
3138 (WebCore::FrameLoaderClientEfl::didDetectXSS):
3139 * WebCoreSupport/FrameLoaderClientEfl.h:
3141 2011-11-02 Ryuan Choi <ryuan.choi@samsung.com>
3143 [EFL] Fix build break when DEBUG_MEM_LEAKS is enabled.
3144 https://bugs.webkit.org/show_bug.cgi?id=71349
3146 Unreviewed build fix.
3148 * ewk/ewk_tiled_backing_store.cpp:
3149 (_ewk_tiled_backing_store_smart_del): remove wrong assignment
3150 * ewk/ewk_tiled_matrix.cpp: define __STDC_FORMAT_MACROS to use PRIu64
3151 (ewk_tile_matrix_free): s/tileMatrixm/tileMatrix
3152 (ewk_tile_matrix_dbg): s/tm/tileMatrix
3153 * ewk/ewk_tiled_model.cpp: define __STDC_FORMAT_MACROS to use PRIu64
3154 (_ewk_tile_account_get): remove REALLOC_OR_OOM_RET
3156 2011-11-02 ChangSeok Oh <shivamidow@gmail.com>
3158 [EFL] Dirty area is not updated with requestAnimationFrame.
3159 https://bugs.webkit.org/show_bug.cgi?id=70170
3161 Some additional dirty areas caused by re-layout have ignored
3162 since updateLayoutAndSytleIfNeedeRecursive is called after gathering dirty area to repaint.
3163 So ewk_view_layout_if_needed_recursive is relocated before getting dirty areas.
3165 Reviewed by Eric Seidel.
3167 * ewk/ewk_view_single.cpp:
3168 (_ewk_view_single_smart_repaints_process):
3170 2011-10-31 Raphael Kubo da Costa <kubo@profusion.mobi>
3172 [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
3173 https://bugs.webkit.org/show_bug.cgi?id=71228
3175 Reviewed by Antonio Gomes.
3177 r93833 has introduced
3178 ewk_view_setting_scripts_can_close_windows_{get,set}, but its
3179 counterpart to allow scripts to open windows kept its weird name.
3181 This makes the functions to allow windows to open and close windows to
3182 have confusingly different name patterns.
3185 (_ewk_view_priv_new):
3186 (ewk_view_setting_scripts_can_open_windows_get):
3187 (ewk_view_setting_scripts_can_open_windows_set):
3190 2011-10-31 Tomasz Morawski <t.morawski@samsung.com>
3192 [EFL] Make cache flush when max size of cache has been changed
3193 https://bugs.webkit.org/show_bug.cgi?id=70805
3195 Reviewed by Ryosuke Niwa.
3197 Calls the ewk_tile_unused_cache_auto_flush function after changing max
3198 size of cache when ewk_tile_unused_cache_max_set is called. Without
3199 this change when new value is lower than the old one the cache may use
3200 more memory than max value set. This situation is not expected by the
3203 * ewk/ewk_tiled_model.cpp:
3204 (ewk_tile_unused_cache_max_set):
3206 2011-10-28 Jochen Eisinger <jochen@chromium.org>
3208 Rename a number of methods mentioning JavaScript to just Script instead
3209 https://bugs.webkit.org/show_bug.cgi?id=71105
3211 Reviewed by Adam Barth.
3213 * WebCoreSupport/FrameLoaderClientEfl.cpp:
3214 (WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
3216 (_ewk_view_priv_new):
3217 (ewk_view_setting_enable_scripts_set):
3219 2011-10-27 Gustavo Lima Chaves <glima@profusion.mobi>
3221 [EFL] Fix variable renaming issue inside ewk_view.cpp
3222 https://bugs.webkit.org/show_bug.cgi?id=71020
3224 Unreviewed build fix.
3227 (ewk_view_js_object_add):
3229 2011-10-26 Zalan Bujtas <zbujtas@gmail.com>
3231 Name viewport change event consistently.
3232 https://bugs.webkit.org/show_bug.cgi?id=70901
3234 Reviewed by Kenneth Rohde Christiansen.
3236 Use ViewportPropertiesDidChange term consistently throughout WebKit.
3238 * WebCoreSupport/ChromeClientEfl.cpp:
3239 (WebCore::ChromeClientEfl::dispatchViewportPropertiesDidChange):
3240 * WebCoreSupport/ChromeClientEfl.h:
3242 2011-10-26 Grzegorz Czajkowski <g.czajkowski@samsung.com>
3244 [EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view.
3245 https://bugs.webkit.org/show_bug.cgi?id=66366
3247 Reviewed by Ryosuke Niwa.
3249 Passes to _ewk_view_viewport_attributes_compute an internal data of ewk_view instead of the view object.
3250 Adds to ewk_view_viewport_attributes_get NULL checks to avoid unexpected results since this is API.
3253 (_ewk_view_viewport_attributes_compute):
3254 (ewk_view_viewport_attributes_get):
3256 2011-10-25 KwangHyuk Kim <hyuki.kim@samsung.com>
3258 Fix occurrence of unpainted tiles while scrolling and zooming.
3259 https://bugs.webkit.org/show_bug.cgi?id=70711
3261 Reviewed by Adam Barth.
3263 Cast one of operatees to float type when ewk_tiled_backing_store calculate tiles list on viewport.
3264 For the proper calculation to generate a float number, at least one of operatees must be a float type.
3265 But, currently both two operatees to calculate the number of tiles on viewport routine aren't float type,
3266 so it generates smaller result than expected result when it is using ceil API.
3267 As a result, it can lose a line of tiles which should be displayed in viewport area while scrolling and zooming.
3269 * ewk/ewk_tiled_backing_store.cpp:
3270 (_ewk_tiled_backing_store_recalc_renderers):
3271 (ewk_tiled_backing_store_zoom_weak_set):
3273 2011-10-25 KwangHyuk Kim <hyuki.kim@samsung.com>
3275 [EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store.
3276 https://bugs.webkit.org/show_bug.cgi?id=67588
3278 Some of variables which aren't related with loop count or other variables
3279 inside of loop are moved out of loop.
3281 Reviewed by Adam Barth.
3283 * ewk/ewk_tiled_backing_store.cpp:
3284 (_ewk_tiled_backing_store_view_wrap_up):
3285 (_ewk_tiled_backing_store_view_wrap_down):
3286 (_ewk_tiled_backing_store_view_wrap_left):
3287 (_ewk_tiled_backing_store_view_wrap_right):
3289 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
3292 https://bugs.webkit.org/show_bug.cgi?id=70740
3294 Reviewed by Geoffrey Garen.
3296 Removed all declarations and definitions of putVirtual.
3297 Also replaced all call sites to putVirtual with a
3298 corresponding lookup in the MethodTable.
3301 (ewk_view_js_object_add):
3303 2011-10-25 Ivan Briano <ivan@profusion.mobi>
3305 [EFL] Add function to get geometry of focused element
3306 https://bugs.webkit.org/show_bug.cgi?id=70728
3308 Reviewed by Antonio Gomes.
3310 Added function to ewk_frame to get the geometry of the focused
3311 element within the frame object.
3313 * ewk/ewk_frame.cpp:
3314 (ewk_frame_focused_element_geometry_get): Retrieves the geometry of
3315 the focused element within the given frame object.
3318 2011-10-25 Ivan Briano <ivan@profusion.mobi>
3320 [EFL] Add necessary information for callback instropection
3321 https://bugs.webkit.org/show_bug.cgi?id=70735
3323 Reviewed by Antonio Gomes.
3325 Provide the information about smart callbacks emitted by the ewk_view
3326 object, so that these can be easily forwarded by other objects or used
3327 by bindings in other languages without having to keep track of all of
3331 (ewk_view_base_smart_set):
3333 2011-10-24 Ivan Briano <ivan@profusion.mobi>
3335 [EFL] Build fix. Rename all instances of a variable when it gets changed
3336 https://bugs.webkit.org/show_bug.cgi?id=70732
3338 Unreviewed build fix.
3341 (ewk_js_property_set): s/obj/object/
3343 (ewk_view_js_object_add): s/exec/executeState/
3345 2011-10-21 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3347 [EFL] Change efl style local variables with WebKit coding Style.
3348 https://bugs.webkit.org/show_bug.cgi?id=69988
3350 Reviewed by Antonio Gomes.
3352 Change *sd* variable name with *smartData*. Some variables were changed by Bug 69988.
3354 * ewk/ewk_frame.cpp:
3355 (ewk_frame_view_get):
3356 (ewk_frame_uri_set):
3357 (ewk_frame_uri_get):
3358 (ewk_frame_contents_size_get):
3359 (ewk_frame_load_document_finished):
3360 (ewk_frame_load_error):
3361 (ewk_frame_title_set):
3362 (ewk_frame_uri_changed):
3363 (ewk_frame_editor_client_selection_changed):
3364 (ewk_frame_editor_client_contents_changed):
3365 (EWKPrivate::coreFrame):
3367 (_ewk_view_smart_pre_render_region):
3368 (_ewk_view_smart_pre_render_relative_radius):
3369 (_ewk_view_smart_pre_render_cancel):
3370 (_ewk_view_smart_disable_render):
3371 (_ewk_view_smart_enable_render):
3372 (EWKPrivate::corePage):
3373 * ewk/ewk_view_single.cpp:
3374 (_ewk_view_single_smart_add):
3375 (_ewk_view_single_smart_resize):
3377 2011-10-21 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3379 [EFL] Change efl style local variables with WebKit coding Style.
3380 https://bugs.webkit.org/show_bug.cgi?id=69988
3382 Reviewed by Antonio Gomes.
3384 In common with Bug 69073, this is a third step in order to be more compliant with WebKit coding style.
3385 We have used one-letter| two-letter local variable according to efl style. However, it's
3386 more difficult for other reviewers to review EFL patches. So, this patch changes efl style
3387 local variable with meaningful one.
3389 - Use *menu* instead of *o* in comment of ewk_contextmenu.cpp.
3390 - Use *list* instead of *l* local variable
3391 - Use *ewkPolicy* instead of *ewk_policy* in ewk_cookies.cpp
3392 - Use *smartData* instead of *sd* local variable for Ewk_XXXX_Smart_Data struct.
3393 - Use *width*, *height* instead of *w*, *h* local variables.
3394 - Use *scrollX*, *scrollY*, *scrollWidth*, *scrollHeight*, *centerX*, *centerY*, *deltaX*, *deltaY*,
3395 *baseX*, *baseY* instead of *sx*, *sy*, *sw*, *sh*, *cx*, *cy*, *dx*, *dy*, *bx*, *by*.
3396 - Use *red*, *green*, *blue*, *alpha*, *contentRed*, *contentGreen*, *contentBlue* and *contentAlpha*
3397 instead of *r*,*g*,*b*,*a*,*cr*,*cg*,*cb*,*ca*.
3398 - Use *tilePositionX*, *tilePositionY* instead of *ox*,*oy* in tiled backingstore files.
3399 - Use *object* instead of *obj*
3400 - Use *length* instead of *len*
3401 - Use *coreFrame* instead of *cf*
3402 - Use *buffer* instead of *buf*
3403 - Use *item* instead of *i*
3404 - Use *currentColumn*, *currentRow* instead of *m_col*, *m_row*
3405 - Remove "_" in local variable.
3408 * ewk/ewk_auth_soup.cpp:
3409 * ewk/ewk_contextmenu.cpp:
3410 * ewk/ewk_cookies.cpp:
3411 * ewk/ewk_frame.cpp:
3412 * ewk/ewk_history.cpp:
3415 * ewk/ewk_settings.cpp:
3416 * ewk/ewk_tiled_backing_store.cpp:
3417 * ewk/ewk_tiled_matrix.cpp:
3418 * ewk/ewk_tiled_model.cpp:
3421 2011-10-21 Grzegorz Czajkowski <g.czajkowski@samsung.com>
3423 [EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
3424 https://bugs.webkit.org/show_bug.cgi?id=65680
3426 Reviewed by Ryosuke Niwa.
3428 Generally API methods using macros NULL checking in WebKit-EFL.
3429 The macros ensure that code is smaller, version of view object
3430 is checked and error message is displayed if NULL is passed.
3433 (ewk_view_mode_get):
3435 2011-10-19 Rafael Antognolli <antognolli@profusion.mobi>
3437 [EFL] Fix typos on ewk_view and ewk_js.
3438 https://bugs.webkit.org/show_bug.cgi?id=70430
3440 Unreviewed build fix.
3442 Fixes for typos that were introduced when renaming variables to follow
3443 webkit coding style.
3446 (ewk_js_property_set):
3448 (ewk_js_npobject_to_object):
3449 (ewk_js_object_new):
3450 (ewk_js_object_invoke):
3451 (ewk_js_object_type_get):
3452 (ewk_js_object_type_set):
3453 (ewk_js_variant_free):
3455 (ewk_view_js_object_add):
3457 2011-10-18 Raphael Kubo da Costa <kubo@profusion.mobi>
3459 [EFL] DRT: Clear list of visited pages before each test.
3460 https://bugs.webkit.org/show_bug.cgi?id=70355
3462 Reviewed by Antonio Gomes.
3464 Add ewk_history_clear as a way to clear the list of visited pages in a
3465 Ewk_History, in a similar fashion to Qt's QWebHistory::clear().
3467 * ewk/ewk_history.cpp:
3468 (ewk_history_clear):
3469 * ewk/ewk_history.h:
3471 2011-10-18 Grzegorz Czajkowski <g.czajkowski@samsung.com>
3473 [EFL] Remove const modifier from ctx_menu functions.
3474 https://bugs.webkit.org/show_bug.cgi?id=70090
3476 Reviewed by Andreas Kling.
3478 Functions ewk_context_menu_show and ewk_context_menu_custom_get
3479 have got const modifer to ensure that Ewk_Context_Menu won't be
3480 changed. The methods emit events through
3481 evas_object_smart_callback_call with Ewk_Context_Menu as parameter
3482 which is converted to void *. In this case an application which
3483 receives those events may change Ewk_Context_Menu.
3485 Additionaly the name of ewk_context_menu_custom_get has been changed
3486 to ewk_context_menu_customize because an application is able to
3487 modify the items of context menu.
3489 * ewk/ewk_contextmenu.cpp:
3490 (ewk_context_menu_customize):
3491 (ewk_context_menu_show):
3492 * ewk/ewk_private.h:
3494 2011-10-17 Raphael Kubo da Costa <kubo@profusion.mobi>
3496 [EFL] Expose the kit() frame function to the rest of ewk.
3497 https://bugs.webkit.org/show_bug.cgi?id=70253
3499 Reviewed by Antonio Gomes.
3501 Now that we have the EWKPrivate namespace, it makes sense to make the
3502 kit() function accessible there instead of having it as a static local
3503 function in ewk_frame.
3505 While on it, get rid of ewk_frame_core_get, which is obsolete after
3506 EWKPrivate::coreFrame.
3508 * WebCoreSupport/EditorClientEfl.cpp:
3509 (WebCore::EditorClientEfl::respondToChangedSelection):
3510 * WebCoreSupport/FrameLoaderClientEfl.cpp:
3511 (WebCore::FrameLoaderClientEfl::callPolicyFunction):
3512 (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
3513 (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
3514 (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
3515 (WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
3516 (WebCore::FrameLoaderClientEfl::dispatchCreatePage):
3517 (WebCore::FrameLoaderClientEfl::createNetworkingContext):
3518 * ewk/ewk_frame.cpp:
3519 (_ewk_frame_loader_efl_get):
3520 (_ewk_frame_children_iterator_next):
3521 (ewk_frame_child_find):
3522 (ewk_frame_hit_test_new):
3523 (EWKPrivate::kitFrame):
3524 * ewk/ewk_private.h:
3526 (ewk_view_setting_encoding_custom_get):
3527 (ewk_view_setting_encoding_custom_set):
3529 2011-10-17 Raphael Kubo da Costa <kubo@profusion.mobi>
3531 [EFL] Do not check for Frame::contentRenderer() in ewk_view_repaint.
3532 https://bugs.webkit.org/show_bug.cgi?id=70118
3534 Reviewed by Kenneth Rohde Christiansen.
3536 When we have a scrollbar with an actual width, there might be a call
3537 to ChromeClientEfl::invalidateContentsAndWindow() after
3538 Document::detach() was called, making the call to contentRenderer()
3539 return 0 even though everything is fine.
3541 Example test case: animations/animation-shorthand.html.
3546 2011-10-17 Raphael Kubo da Costa <kubo@profusion.mobi>
3548 [EFL] Set a default charset when creating a view.
3549 https://bugs.webkit.org/show_bug.cgi?id=69771
3551 Reviewed by Antonio Gomes.
3553 Most (or all) ports default to iso-8859-1 when creating a view (or their
3554 equivalent of a view), so we should do that too.
3556 This makes fast/dom/Document/document-charset.html pass.
3559 (_ewk_view_priv_new):
3561 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
3563 Rename virtual put to putVirtual
3564 https://bugs.webkit.org/show_bug.cgi?id=69851
3566 Reviewed by Darin Adler.
3568 Renamed virtual versions of put to putVirtual in prepration for
3569 adding the static put to the MethodTable in ClassInfo since the
3570 compiler gets mad if the virtual and static versions have the same
3574 (ewk_view_js_object_add):
3576 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
3578 Rename virtual put to putVirtual
3579 https://bugs.webkit.org/show_bug.cgi?id=69851
3581 Reviewed by Darin Adler.
3583 Renamed virtual versions of put to putVirtual in prepration for
3584 adding the static put to the MethodTable in ClassInfo since the
3585 compiler gets mad if the virtual and static versions have the same
3589 (ewk_view_js_object_add):
3591 2011-10-14 Raphael Kubo da Costa <kubo@profusion.mobi>
3593 [EFL] Bump class version after r97421.
3594 https://bugs.webkit.org/show_bug.cgi?id=70102
3596 Reviewed by Joseph Pecoraro.
3598 r97421 changed the signature of the run_open_panel virtual method in
3599 Ewk_Smart_Class, so we need to bump the class version.
3603 2011-10-14 Raphael Kubo da Costa <kubo@profusion.mobi>
3605 [EFL] Add DumpRenderTreeSupportEfl
3606 https://bugs.webkit.org/show_bug.cgi?id=68458
3608 Reviewed by Kenneth Rohde Christiansen.
3610 This class is similar to their counterparts present in the Qt and GTK+
3611 ports, and it is responsible for providing an interface to certain
3612 WebCore methods needed by DumpRenderTree.
3614 * CMakeListsEfl.txt: Conditionally add the svg directories to the
3616 * WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Added.
3617 (DumpRenderTreeSupportEfl::DumpRenderTreeSupportEfl):
3618 (DumpRenderTreeSupportEfl::~DumpRenderTreeSupportEfl):
3619 (DumpRenderTreeSupportEfl::activeAnimationsCount):
3620 (DumpRenderTreeSupportEfl::clearFrameName):
3621 (DumpRenderTreeSupportEfl::clearOpener):
3622 (DumpRenderTreeSupportEfl::counterValueByElementId):
3623 (DumpRenderTreeSupportEfl::frameChildren):
3624 (DumpRenderTreeSupportEfl::frameParent):
3625 (DumpRenderTreeSupportEfl::layoutFrame):
3626 (DumpRenderTreeSupportEfl::numberOfPages):
3627 (DumpRenderTreeSupportEfl::numberOfPagesForElementId):
3628 (DumpRenderTreeSupportEfl::pauseAnimation):
3629 (DumpRenderTreeSupportEfl::pauseSVGAnimation):
3630 (DumpRenderTreeSupportEfl::pauseTransition):
3631 (DumpRenderTreeSupportEfl::pendingUnloadEventCount):
3632 (DumpRenderTreeSupportEfl::renderTreeDump):
3633 (DumpRenderTreeSupportEfl::responseMimeType):
3634 (DumpRenderTreeSupportEfl::resumeAnimations):
3635 (DumpRenderTreeSupportEfl::selectionRectangle):
3636 (DumpRenderTreeSupportEfl::suitableDRTFrameName):
3637 (DumpRenderTreeSupportEfl::suspendAnimations):
3638 (DumpRenderTreeSupportEfl::findString):
3639 (DumpRenderTreeSupportEfl::garbageCollectorCollect):
3640 (DumpRenderTreeSupportEfl::garbageCollectorCollectOnAlternateThread):
3641 (DumpRenderTreeSupportEfl::javaScriptObjectsCount):
3642 (DumpRenderTreeSupportEfl::workerThreadCount):
3643 (DumpRenderTreeSupportEfl::childHistoryItems):
3644 (DumpRenderTreeSupportEfl::historyItemTarget):
3645 (DumpRenderTreeSupportEfl::isTargetItem):
3646 (DumpRenderTreeSupportEfl::setMockScrollbarsEnabled):
3647 * WebCoreSupport/DumpRenderTreeSupportEfl.h: Added.
3648 * ewk/ewk_frame.cpp:
3649 (EWKPrivate::coreFrame): Export the WebCore::Frame* related to an
3651 * ewk/ewk_history.cpp: Remove functions which have been moved to
3652 DumpRenderTreeSupportEfl.
3653 (_ewk_history_item_list_get): _ewk_history_item_new ->
3654 ewk_history_item_new_from_core.
3655 (ewk_history_history_item_back_get): Ditto.
3656 (ewk_history_history_item_current_get): Ditto.
3657 (ewk_history_history_item_forward_get): Ditto.
3658 (ewk_history_history_item_nth_get): Ditto.
3659 (ewk_history_item_new): Ditto.
3660 (ewk_history_item_new_from_core): Rename from _ewk_history_item_new.
3661 (EWKPrivate::coreHistoryItem): Export the WebCore::HistoryItem*
3662 related to an Ewk_History_Item.
3663 * ewk/ewk_private.h: Create the EWKPrivate namespace, remove functions
3664 which have been moved to DumpRenderTreeSupportEfl.
3665 * ewk/ewk_util.cpp: Remove functions which have been moved to
3666 DumpRenderTreeSupportEfl.
3668 (EWKPrivate::corePage): Export the WebCore::Page* related to an
3671 2011-10-13 Raphael Kubo da Costa <kubo@profusion.mobi>
3673 [EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
3674 https://bugs.webkit.org/show_bug.cgi?id=70002
3676 Reviewed by Joseph Pecoraro.
3678 Adapt to the changes introduced in r97336 and r97338 by using a vector
3679 of strings instead of a single string in runOpenPanel().
3681 * WebCoreSupport/ChromeClientEfl.cpp:
3682 (WebCore::ChromeClientEfl::runOpenPanel):
3683 * ewk/ewk_private.h:
3685 (ewk_view_run_open_panel): Change signature; accept a Vector<String>
3686 instead of a char*. Build an Eina_List to pass for child classes.
3689 2011-10-13 Leandro Pereira <leandro@profusion.mobi>
3691 Unreviewed; revert some changes introduced in r97329 which are
3692 unrelated to the patch and reverted other patches themselves.
3694 * ewk/ewk_frame.cpp:
3695 (_ewk_frame_smart_del): Remove warning again.
3696 (ewk_frame_contents_size_get): Check for Frame and FrameView again.
3698 (_ewk_view_priv_new): Revert back default font size change.
3700 2011-10-12 Joseph Pecoraro <joepeck@webkit.org>
3702 Pass Parsed Accept Attribute MIME Types to WebKit Clients
3703 https://bugs.webkit.org/show_bug.cgi?id=69598
3705 Reviewed by Kent Tamura.
3707 EFL uses the deprecated accept string. They can switch
3708 to an Eina_List if they want to update their API.
3710 * src/ChromeClientImpl.cpp:
3711 (WebKit::ChromeClientImpl::runOpenPanel):
3713 2011-10-12 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3715 [EFL] Change efl style parameter variables with WebKit coding Style
3716 https://bugs.webkit.org/show_bug.cgi?id=69073
3718 Reviewed by Antonio Gomes.
3720 This is a third step in order to be more compliant with WebKit coding style.
3721 We have used one-letter| two-letter parameter according to efl style. However, it's more difficult
3722 for other reviewers to review EFL patches. So, this patch changes efl style parameters
3723 with meaningful one.
3725 Majors changes are listed below,
3727 - Use ewkFrame instead of o parameter in ewk_frame.cpp.
3728 - Use ewkView instead of o parameter in ewk_view.cpp.
3729 - Use menu and item instead of o parameter in ewk_contextmenu.cpp.
3730 - Use ewkTile instead of o parameter in ewk_tile_xxx.cpp.
3731 - Use tile parameter name instead of t parameter in ewk_tile_xxx.cpp.
3732 - Use smartData instead of sd parameter for Ewk_XXXX_Smart_Data struct.
3733 - Use width, height instead of w, h parameter.
3734 - Use xxxEvent instead of ev parameter for event. (e.g. downEvent, upEvent, wheelEvent)
3735 - Use scrollX, scrollY, scrollWidth, scrollHeight, centerX, centerY, deltaX, deltaY instead of sx, xy, sw,
3737 - Use tileUnusedCache instead of tuc parameter in tiled backing store.
3738 - Use red, green, blue and alpha instead of r,g,b,a.
3739 - Remove "_" from parameter variable.
3740 - Run demarchi's coding style script for ewk_tile_xxx.cpp files.
3741 - Remove *void* parameter in ewk_tile_xxx.cpp's internal functions.
3743 * ewk/ewk_auth_soup.cpp:
3744 * ewk/ewk_contextmenu.cpp:
3745 * ewk/ewk_cookies.cpp:
3746 * ewk/ewk_frame.cpp:
3747 * ewk/ewk_history.cpp:
3749 * ewk/ewk_protocol_handler_soup.cpp:
3750 * ewk/ewk_settings.cpp:
3751 * ewk/ewk_tiled_backing_store.cpp:
3752 * ewk/ewk_tiled_backing_store.h:
3753 * ewk/ewk_tiled_matrix.cpp:
3754 * ewk/ewk_tiled_matrix.h:
3755 * ewk/ewk_tiled_model.cpp:
3756 * ewk/ewk_tiled_model.h:
3758 * ewk/ewk_view_single.cpp:
3759 * ewk/ewk_view_tiled.cpp:
3760 * ewk/ewk_window_features.cpp:
3762 2011-10-10 Raphael Kubo da Costa <kubo@profusion.mobi>
3764 [EFL] Do not cache a frame's contents size.
3765 https://bugs.webkit.org/show_bug.cgi?id=69772
3767 Reviewed by Antonio Gomes.
3769 As part of the process of experimenting with having scrollbars with
3770 an actual size, it became clear that setting the contents size via
3771 ChromeClient::contentsSizeChanged() and keeping the value around does
3774 Case in point: FrameView::adjustViewSize() can result in nested
3775 ScrollView::updateScrollbars() calls in which the innermost ones run
3776 ChromeClient::contentsSizeChanged() before the outermost ones. This
3777 means the ewk_frame's smart data will store an old value.
3779 * ewk/ewk_frame.cpp:
3780 (ewk_frame_contents_size_get):
3781 (ewk_frame_contents_size_changed):
3783 2011-10-09 Ryuan Choi <ryuan.choi@samsung.com>
3785 [EFL] Refactor zoom related APIs.
3786 https://bugs.webkit.org/show_bug.cgi?id=62842
3788 Current zoom apis can't support the case of using both page zoom and text
3791 As a first step to refactor, this split ewk_{view|frame}_zoom_{get|set}
3792 to use both page_zoom and text zoom individually.
3793 In addition, introduce ewk_view_scale_{get|set} to support proportional scaling.
3795 ewk_view_zoom_{get|set} will remain unchanged until the behavior of smart_zoom
3798 Reviewed by Antonio Gomes.
3800 * ewk/ewk_frame.cpp: Remove ewk_frame_zoom_text_only_{get|set}.
3801 (ewk_frame_page_zoom_get): Renamed from ewk_frame_zoom_get().
3802 (ewk_frame_page_zoom_set): Renamed from ewk_frame_zoom_set().
3803 (ewk_frame_text_zoom_get): Extracted from ewk_frame_zoom_get().
3804 (ewk_frame_text_zoom_set): Extracted from ewk_frame_zoom_set().
3806 * ewk/ewk_view.cpp: Remove ewk_view_zoom_text_only_{get|set}
3807 (_ewk_view_smart_zoom_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
3808 (ewk_view_zoom_get): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
3809 (ewk_view_page_zoom_get): Extracted from ewk_view_zoom_get().
3810 (ewk_view_page_zoom_set): Extracted from ewk_view_zoom_set().
3811 (ewk_view_scale_get): Added.
3812 (ewk_view_scale_set): Added.
3813 (ewk_view_text_zoom_get): Extracted from ewk_view_zoom_get().
3814 (ewk_view_text_zoom_set): Extracted from ewk_view_zoom_set().
3815 (ewk_view_zoom_weak_set): Change ewk_frame_zoom_get to ewk_frame_page_zoom_get().
3816 (ewk_view_zoom_animated_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
3817 (ewk_view_pre_render_region): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
3818 (ewk_view_pre_render_relative_radius): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
3821 2011-10-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3823 [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
3824 https://bugs.webkit.org/show_bug.cgi?id=69505
3826 Reviewed by Andreas Kling.
3828 ewk_view_viewport_attributes_get() has used implicit casting for width and height of viewport.
3829 However, it is better to use *int* data type as parameter data type instead of *float* casting.
3832 (ewk_view_viewport_attributes_get):
3835 2011-10-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3837 [EFL] Only set when the custom encoding is different from existing value
3838 https://bugs.webkit.org/show_bug.cgi?id=69061
3840 Reviewed by Hajime Morita.
3842 Only set the custom encoding value if it is different from the current value, to avoid
3846 (ewk_view_setting_encoding_custom_set):
3848 2011-10-04 Rémi Duraffort <remi.duraffort@st.com>
3850 [EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
3851 https://bugs.webkit.org/show_bug.cgi?id=69338
3853 Unreviewed build fix
3855 * CMakeListsEfl.txt:
3857 2011-10-03 Ryuan Choi <ryuan.choi@samsung.com>
3859 [EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
3860 https://bugs.webkit.org/show_bug.cgi?id=68599
3862 Use a C++ compiler for these files and fix compile issues and coding style.
3864 Reviewed by Hajime Morita.
3866 * CMakeListsEfl.txt:
3867 * ewk/ewk_tiled_backing_store.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.c.
3868 * ewk/ewk_tiled_backing_store.h:
3869 * ewk/ewk_tiled_matrix.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.c.
3870 * ewk/ewk_tiled_model.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.c.
3872 2011-09-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3874 [EFL] Use C++ type cast instead of C style type cast
3875 https://bugs.webkit.org/show_bug.cgi?id=68321
3877 Reviewed by Martin Robinson.
3879 This is a second step in order to be more compliant with WebKit coding style.
3880 The second step is to change C-type casting with C++-type casting in .cpp files.
3882 In addition, remained efl style '*' pointer placements are moved to the right place as well.
3884 * ewk/ewk_auth_soup.cpp:
3885 * ewk/ewk_contextmenu.cpp:
3886 * ewk/ewk_frame.cpp:
3887 * ewk/ewk_history.cpp:
3889 * ewk/ewk_view_single.cpp:
3890 * ewk/ewk_view_tiled.cpp:
3892 2011-09-29 Raphael Kubo da Costa <kubo@profusion.mobi>
3894 [EFL] API to get plain text of the frame
3895 https://bugs.webkit.org/show_bug.cgi?id=67114
3897 Reviewed by Ryosuke Niwa.
3899 Add a function to return a frame's contents converted to plain text,
3900 as already exposed by other ports and needed by DRT when dumping a
3903 * ewk/ewk_frame.cpp:
3904 (ewk_frame_plain_text_get):
3907 2011-09-28 KwangHyuk Kim <hyuki.kim@samsung.com>
3909 [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
3910 https://bugs.webkit.org/show_bug.cgi?id=68594
3912 As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
3913 isn't effective at all, this patch just removes it.
3915 Reviewed by Ryosuke Niwa.
3917 * ewk/ewk_tiled_backing_store.c:
3918 (_ewk_tiled_backing_store_zoom_set_internal):
3920 2011-09-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3922 [EFL] Remove *void* parameter in internal functions
3923 https://bugs.webkit.org/show_bug.cgi?id=68867
3925 Reviewed by Andreas Kling.
3927 As a step to let ewk be compliant with webkit coding style,
3928 we need to remove *void* parameter in internal functions.
3930 * ewk/ewk_private.h:
3931 * ewk/ewk_settings.cpp:
3932 (ewk_settings_web_database_default_quota_get):
3936 2011-09-28 Grzegorz Czajkowski <g.czajkowski@samsung.com>
3938 [EFL] Allow to skip count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get.
3939 https://bugs.webkit.org/show_bug.cgi?id=65842
3941 Reviewed by Ryosuke Niwa.
3943 Makes the count parameter in ewk_view_repaints_get and ewk_view_scroll_requests_get
3944 as an optional parameter. Developer may pass NULL to skip returning the number of elements
3945 of the requested array.
3948 (ewk_view_repaints_get):
3949 (ewk_view_scroll_requests_get):
3951 2011-09-28 Grzegorz Czajkowski <g.czajkowski@samsung.com>
3953 [EFL] URL of resources are not decoded.
3954 https://bugs.webkit.org/show_bug.cgi?id=66540
3956 Reviewed by Ryosuke Niwa.
3958 Fix ewk_frame_resources_location_get which was returning the encoded URL of resources.
3959 As a result characters for instance, %20 occurred. For now returned strings are decoded.
3961 * ewk/ewk_frame.cpp:
3962 (ewk_frame_resources_location_get):
3964 2011-09-27 Raphael Kubo da Costa <kubo@profusion.mobi>
3966 [EFL] Make ewk_view emit the "load,document,finished" signal.
3967 https://bugs.webkit.org/show_bug.cgi?id=66782
3969 Reviewed by Antonio Gomes.
3971 Currently, only ewk_frame emits the "load,document,finished" signal
3972 when FrameLoaderClientEfl::dispatchDidFinishDocumentLoad() calls
3973 ewk_frame_load_document_finished().
3975 However, in some cases it is not even possible to connect to the
3976 "frame,created" signal to properly monitor the
3977 "load,document,finished" signal, as the former is not emitted.
3978 fast/frames/frame-unload-crash.html, for example, has a page with an
3979 iframe inside an iframe, and this innermost iframe does not seem to be
3980 loaded via FrameLoaderClientEfl::createFrame (which calls all the
3981 machinery which then emits the "frame,created" signal).
3983 We now make ewk_frame_load_document_finished() call the newly-created
3984 ewk_view_load_document_finished() function, whose job is to emit the
3985 "load,document,signal" with the frame as its parameter. This way, one
3986 can just connect to the view and make sure all the signals will get
3989 * ewk/ewk_frame.cpp:
3990 (ewk_frame_load_document_finished):
3991 * ewk/ewk_private.h:
3993 (ewk_view_load_document_finished):
3996 2011-09-26 Raphael Kubo da Costa <kubo@profusion.mobi>
3998 [CMake] Remove FindFreetype.cmake
3999 https://bugs.webkit.org/show_bug.cgi?id=68778
4001 Reviewed by Adam Barth.
4003 CMake has provided its own FindFreetype.cmake forever, so there is no
4004 need to have another implementation in WebKit.
4006 * CMakeListsEfl.txt: Use FREETYPE_{LIBRARIES,INCLUDE_DIRS} instead of
4007 Freetype_{LIBRARIES,INCLUDE_DIRS}.
4009 2011-09-26 Lucas De Marchi <lucas.demarchi@profusion.mobi>
4011 [EFL] Add virtual method to notify user when wrapping focus
4012 https://bugs.webkit.org/show_bug.cgi?id=68699
4014 Reviewed by Antonio Gomes.
4016 Add a virtual method to ewk_view, so the Chrome gets notified if we
4017 finished focusing all the items and would start over. This way the
4018 browser can decide to handle the subsequent focus changes among its
4021 * WebCoreSupport/ChromeClientEfl.cpp: call ewk_view's virtual method to
4022 give it a chance to grab focus
4023 (WebCore::ChromeClientEfl::canTakeFocus):
4024 * ewk/ewk_private.h:
4025 * ewk/ewk_view.cpp: add virtual method
4026 (ewk_view_focus_can_cycle):
4027 * ewk/ewk_view.h: add focus direction enum and virtual method
4029 2011-09-24 Adam Barth <abarth@webkit.org>
4031 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
4032 https://bugs.webkit.org/show_bug.cgi?id=68767
4034 Reviewed by Eric Seidel.
4036 * WebCoreSupport/ChromeClientEfl.cpp:
4037 (WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
4038 * WebCoreSupport/ChromeClientEfl.h:
4041 * ewk/ewk_settings.cpp:
4042 (ewk_settings_cache_directory_path_set):
4043 (ewk_settings_cache_directory_path_get):
4045 2011-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
4047 [EFL] Revert pointer operator coding style in ewk
4048 https://bugs.webkit.org/show_bug.cgi?id=68231
4050 Reviewed by Antonio Gomes.
4052 The WebKit coding style mandates that "(...) in C++ code - Both pointer
4053 types and reference types should be written with no space between the
4054 type name and the * or &.". Until now EFL port was using the
4055 coding-style of the library for platform code instead of WebKit's.
4057 We are now trying to be more compliant with WebKit coding-style so it's
4058 easier for other reviewers to review EFL code. The first step in this
4059 direction is to move the '*' and '&' of pointers and references to the
4062 This patch was generated with 'uncrustify' with the configure file
4063 attached to the respective but report. There was one fix that had to be
4064 manually made in order to keep the 'check-webkit-style' happy: a
4065 function definition with a meaningless name. Other functions like this
4066 exist but they will be fixed by a later patch.
4068 Some nice side-effects of using uncrustify:
4070 - Whitespace cleanup on comments
4071 - Function parameters are aligned to the open parenthesis
4072 - Remove tab characters
4074 2011-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
4076 [EFL] Don't try to free user-provided list
4077 https://bugs.webkit.org/show_bug.cgi?id=68356
4079 Reviewed by Antonio Gomes.
4081 A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
4082 wrong manner. If we intended to free the data, we should call free()
4083 (or whatever function is required to destroy it). However not only did
4084 it use the wrong EFL api but it also introduced a change in behavior,
4085 freeing user-provided data.
4087 * ewk/ewk_frame.cpp:
4088 (ewk_frame_feed_touch_event): do not free user-provided data.
4090 2011-09-21 Gyuyoung Kim <gyuyoung.kim@samsung.com>
4092 [EFL] Fix alphabetical sorting problem
4093 https://bugs.webkit.org/show_bug.cgi?id=68505
4095 Reviewed by Philippe Normand.
4097 * ewk/ewk_util.cpp: Fix wrong alphabetical sorting problem.
4099 2011-09-20 Raphael Kubo da Costa <kubo@profusion.mobi>
4101 [EFL] Call FrameLoader::detachFromParent() when destroying a frame.
4102 https://bugs.webkit.org/show_bug.cgi?id=66855
4104 Reviewed by Antonio Gomes.
4106 Most other ports call this method somewhere when the frame is being
4107 removed, as it performs some destruction calls which, in our case, at
4108 least makes sure onunload events get delivered properly in
4109 fast/frames/iframe-reparenting-adopt-node.html.
4111 * ewk/ewk_frame.cpp:
4112 (_ewk_frame_smart_del): Call FrameLoader::detachFromParent()
4114 2011-09-17 Mihai Parparita <mihaip@chromium.org>
4116 FrameLoaderClient BackForwardList-related methods are unsued
4117 https://bugs.webkit.org/show_bug.cgi?id=68293
4119 Reviewed by Darin Adler.
4121 Remove FrameLoaderClient methods that were added by r51629, since only
4122 the old (since-deleted) Android port needed them.
4124 * WebCoreSupport/FrameLoaderClientEfl.cpp:
4125 * WebCoreSupport/FrameLoaderClientEfl.h:
4127 2011-09-15 Adam Barth <abarth@webkit.org>
4129 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
4130 https://bugs.webkit.org/show_bug.cgi?id=68205
4132 Reviewed by Eric Seidel.
4134 * WebCoreSupport/ChromeClientEfl.cpp:
4135 * WebCoreSupport/ChromeClientEfl.h:
4136 * ewk/ewk_settings.cpp:
4137 (ewk_settings_web_database_default_quota_get):
4138 (ewk_settings_web_database_path_set):
4139 (ewk_settings_web_database_path_get):
4141 2011-09-14 Grzegorz Czajkowski <g.czajkowski@samsung.com>
4143 [EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
4144 https://bugs.webkit.org/show_bug.cgi?id=64932
4146 Reviewed by Eric Seidel.
4148 It prevents the crash while allocating memory for the new window.
4151 (ewk_view_window_create):
4152 * ewk/ewk_window_features.cpp:
4153 (ewk_window_features_new_from_core):
4155 2011-09-13 Raphael Kubo da Costa <kubo@profusion.mobi>
4157 [EFL] Do not always return the cached frame name.
4158 https://bugs.webkit.org/show_bug.cgi?id=66856
4160 Reviewed by Antonio Gomes.