fc60ff15c9e936896768fc015a23f8d8b6ca0767
[WebKit-https.git] / Source / WebKit / chromium / ChangeLog
1 2012-09-13  Taiju Tsuiki  <tzik@chromium.org>
2
3         Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call.
4         https://bugs.webkit.org/show_bug.cgi?id=96601
5
6         Reviewed by Kent Tamura.
7
8         m_webFrame might be already deleted after terminateWorkerContext call.
9         This patch ensure it be NULL and change to avoid using it.
10
11         Test: fast/filesystem/workers/detached-frame-crash.html
12
13         * src/WebWorkerClientImpl.cpp:
14         (WebKit::WebWorkerClientImpl::terminateWorkerContext):
15         (WebKit::WebWorkerClientImpl::openFileSystem):
16
17 2012-09-12  Leandro Gracia Gil  <leandrogracia@chromium.org>
18
19         [Chromium] Fix cases where find-in-page doesn't send a final update
20         https://bugs.webkit.org/show_bug.cgi?id=96402
21
22         Fix some issues in the WebKit implementation that prevented to send a final
23         reportFindInPageMatchCount message.
24
25         Reviewed by Adam Barth.
26
27         * src/WebFrameImpl.cpp:
28         (WebKit::WebFrameImpl::scopeStringMatches):
29         (WebKit::WebFrameImpl::shouldScopeMatches):
30
31 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
32
33         Unreviewed, rolling out r127876.
34         http://trac.webkit.org/changeset/127876
35         https://bugs.webkit.org/show_bug.cgi?id=96600
36
37         mouse click doesn't work for spin button if spin button in
38         iframe (Requested by yosin on #webkit).
39
40         * src/ContextMenuClientImpl.cpp:
41         (WebKit::selectMisspelledWord):
42         * src/FrameLoaderClientImpl.cpp:
43         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
44         * src/WebFrameImpl.cpp:
45         (WebKit::WebFrameImpl::characterIndexForPoint):
46         * src/WebPluginContainerImpl.cpp:
47         (WebKit::WebPluginContainerImpl::isRectTopmost):
48         * src/WebViewImpl.cpp:
49         (WebKit::WebViewImpl::handleMouseUp):
50         (WebKit::WebViewImpl::computeBlockBounds):
51
52 2012-09-12  Rick Byers  <rbyers@chromium.org>
53
54         [chromium] Remove unused WebGestureEvent fields
55         https://bugs.webkit.org/show_bug.cgi?id=95496
56
57         Reviewed by Adam Barth.
58
59         Remove the no-longer used fields from WebGestureEvent, now that
60         chromium has been updated to use the per-event-type fields instead.
61         This depends on crrev.com/156346 in chromium.
62
63         * public/WebInputEvent.h:
64         (WebKit::WebGestureEvent::WebGestureEvent):
65         * public/android/WebInputEventFactory.h:
66         * src/WebInputEvent.cpp:
67         (SameSizeAsWebGestureEvent):
68         * src/android/WebInputEventFactory.cpp:
69         (WebKit):
70         (WebKit::WebInputEventFactory::gestureEvent):
71
72 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
73
74         Unreviewed, rolling out r128351.
75         http://trac.webkit.org/changeset/128351
76         https://bugs.webkit.org/show_bug.cgi?id=96573
77
78         Broke FindInPage browser_tests (Requested by jamesr_ on
79         #webkit).
80
81         * src/WebFrameImpl.cpp:
82         (WebKit::WebFrameImpl::scopeStringMatches):
83         (WebKit::WebFrameImpl::cancelPendingScopingEffort):
84         (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
85         (WebKit::WebFrameImpl::shouldScopeMatches):
86
87 2012-09-12  Adrienne Walker  <enne@google.com>
88
89         [chromium] Fix search tickmarks not disappearing when compositing is enabled
90         https://bugs.webkit.org/show_bug.cgi?id=96536
91
92         Reviewed by James Robinson.
93
94         view->invalidateRect() on the root frame just invalidates the
95         contents, since WebViewImpl doesn't know anything about scrollbar
96         layers. This causes an "InvalidateAll" to not actually invalidate the
97         scrollbars.
98
99         To fix this, make WebFrameImpl explicitly invalidate the
100         scrollbars when required.
101
102         * src/WebFrameImpl.cpp:
103         (WebKit::WebFrameImpl::invalidateArea):
104
105 2012-09-12  Leandro Gracia Gil  <leandrogracia@chromium.org>
106
107         [Chromium] Fix cases where find-in-page doesn't send a final update
108         https://bugs.webkit.org/show_bug.cgi?id=96402
109
110         Fix some issues in the WebKit implementation that prevented to send a final
111         reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
112         when calling the stopFinding method.
113
114         Reviewed by Adam Barth.
115
116         * src/WebFrameImpl.cpp:
117         (WebKit::WebFrameImpl::scopeStringMatches):
118         (WebKit::WebFrameImpl::cancelPendingScopingEffort):
119         (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
120         (WebKit::WebFrameImpl::shouldScopeMatches):
121
122 2012-09-12  Sami Kyostila  <skyostil@google.com>
123
124         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
125         https://bugs.webkit.org/show_bug.cgi?id=96251
126
127         Reviewed by Simon Fraser.
128
129         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
130         the feature it controls.
131
132         * features.gypi:
133
134 2012-09-12  Christopher Cameron  <ccameron@chromium.org>
135
136         [chromium] Evict textures through the texture manager instead of the resource provider
137         https://bugs.webkit.org/show_bug.cgi?id=96463
138
139         Reviewed by James Robinson.
140
141         Update layer tree host impl test to include the extra interface functions
142         added to CCLayerTreeHostImplClient.
143
144         * tests/CCLayerTreeHostImplTest.cpp:
145
146 2012-09-12  Ilya Tikhonovsky  <loislo@chromium.org>
147
148         Web Inspector: NMI move String* instrumentation to wtf.
149         https://bugs.webkit.org/show_bug.cgi?id=96405
150
151         Reviewed by Yury Semikhatsky.
152
153         This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
154
155         Tested by webkit_unit_tests.
156
157         * tests/MemoryInstrumentationTest.cpp:
158         (WebCore::TEST):
159
160 2012-09-12  Philippe Liard  <pliard@google.com>
161
162         Depend on {base,net} GYP targets rather than {base,net}_java.
163         https://bugs.webkit.org/show_bug.cgi?id=95690
164
165         Reviewed by Adam Barth.
166
167         {base,net}_java became 'private' targets on the Chromium side that
168         clients should not depend on (see
169         https://chromiumcodereview.appspot.com/10913083/).
170         This also adds the missing 'chromium_net.jar' to |input_jars_paths|
171         that was magically included in Chrome for Android downstream but not
172         upstream. It's needed to register JNI for 'net' in webkit_unit_tests.
173
174
175         * WebKitUnitTests.gyp:
176
177 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
178
179         Unreviewed, rolling out r128279.
180         http://trac.webkit.org/changeset/128279
181         https://bugs.webkit.org/show_bug.cgi?id=96487
182
183         "Snow Leopard compilation broken" (Requested by yurys on
184         #webkit).
185
186         * tests/MemoryInstrumentationTest.cpp:
187         (WebCore::InstrumentedUndefined::reportMemoryUsage):
188         (WebCore::TEST):
189
190 2012-09-12  Ilya Tikhonovsky  <loislo@chromium.org>
191
192         Web Inspector: NMI move String* instrumentation to wtf.
193         https://bugs.webkit.org/show_bug.cgi?id=96405
194
195         Reviewed by Yury Semikhatsky.
196
197         This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
198
199         Tested by webkit_unit_tests.
200
201         * tests/MemoryInstrumentationTest.cpp:
202         (WebCore::InstrumentedUndefined::reportMemoryUsage):
203         (WebCore::TEST):
204
205 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
206
207         [chromium] consumable user gesture count off for input events
208         https://bugs.webkit.org/show_bug.cgi?id=96373
209
210         Reviewed by Adam Barth.
211
212         Don't create a UserGestureIndicator in the chromium layer, as it will
213         already be created by webcore's event handler. Creating multiple
214         UserGestureIndicator objects for the same object would allow to execute
215         multiple user-gesture-gated actions per user gesture such as opening a
216         new window.
217
218         * public/WebInputEvent.h:
219         * src/WebViewImpl.cpp:
220         (WebKit::WebViewImpl::handleInputEvent):
221
222 2012-09-12  Alexandre Elias  <aelias@chromium.org>
223
224         [chromium] Flip Y and swizzle inside compositeAndReadback implementation
225         https://bugs.webkit.org/show_bug.cgi?id=96458
226
227         Reviewed by James Robinson.
228
229         Currently, compositeAndReadback API assumes a GL-style texture
230         and is converted to the normal software format in WebViewImpl.
231         For the software implementation, this API would result in two
232         redundant conversions.  This patch makes the conversion inside
233         CCRendererGL instead.  I rolled my own for loop as I didn't find the
234         appropriate function within raw Skia.
235
236         No new tests (covered by existing layout tests).
237
238         * src/WebViewImpl.cpp:
239         (WebKit::WebViewImpl::doPixelReadbackToCanvas):
240
241 2012-09-11  Taiju Tsuiki  <tzik@chromium.org>
242
243         WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem
244         https://bugs.webkit.org/show_bug.cgi?id=96354
245
246         Reviewed by Kent Tamura.
247
248         Ensure non-NULL before using WebFrameImpl::client().
249
250         Test: fast/filesystem/workers/detached-frame-crash.html
251
252         * src/WebWorkerClientImpl.cpp:
253         (WebKit::WebWorkerClientImpl::openFileSystem):
254
255 2012-09-11  Keishi Hattori  <keishi@webkit.org>
256
257         Create Localizer factory method for LocaleICU
258         https://bugs.webkit.org/show_bug.cgi?id=96363
259
260         Reviewed by Kent Tamura.
261
262         * tests/LocalizedNumberICUTest.cpp:
263         (testNumberIsReversible):
264         (testDecimalSeparator):
265
266 2012-09-11  Christopher Cameron  <ccameron@chromium.org>
267
268         [chromium] Make prioritized texture manager not touch backings array on the main thread
269         https://bugs.webkit.org/show_bug.cgi?id=96114
270
271         Reviewed by James Robinson.
272
273         Take a snapshot of the textures' priorities from the main thread,
274         and save it in their backings for access by the impl thread.
275         Update functions that access the sorted backings array to use the
276         snapshotted values instead of the values that the main thread may
277         have computed for the next frame.
278
279         Make the main thread not touch the m_backings array.  Split
280         prioritizeTextures into a updateBackingsPriorities function.
281         In places where the main thread would have touched m_backings,
282         set a flag specifying that m_backings needs to be re-sorted
283         before any function that requires it be sorted by priority be
284         executed.
285
286         Update the two functions that require sorted order (acquireBacking
287         and reduceMemory) to sort the backings array (if needed) before
288         traversing it.
289
290         Updated tests to set correct thread during asserts. Add a test to
291         verify that requestLate is correctly incorporated into the backing
292         sorting.
293
294         * tests/CCPrioritizedTextureTest.cpp:
295         (WTF::CCPrioritizedTextureTest::validateTexture):
296
297 2012-09-11  Sheriff Bot  <webkit.review.bot@gmail.com>
298
299         Unreviewed.  Rolled DEPS.
300
301         * DEPS:
302
303 2012-09-11  Iain Merrick  <husky@chromium.org>
304
305         [chromium] Fix double call to scrollBegin() when handling scroll gesture
306         https://bugs.webkit.org/show_bug.cgi?id=95322
307
308         Reviewed by James Robinson.
309
310         WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its
311         client, then if the result is ScrollStarted, it creates a PlatformGestureCurve
312         object to handle the fling animation. This patch adds a matching scrollEnd()
313         before the animation starts.
314
315         Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all
316         unexpected calls into test failures. This ensures that scrollBegin / scrollEnd
317         happen exactly when we want and at no other times.
318
319         * src/WebCompositorInputHandlerImpl.cpp:
320         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
321         * tests/WebCompositorInputHandlerImplTest.cpp:
322         (WebCompositorInputHandlerImplTest):
323         (WebKit::TEST_F):
324
325 2012-09-11  Peter Beverloo  <peter@chromium.org>
326
327         Unreviewed.  Rolled DEPS.
328
329         * DEPS:
330
331 2012-09-11  Keishi Hattori  <keishi@webkit.org>
332
333         Create Localizer factory method for LocaleMac
334         https://bugs.webkit.org/show_bug.cgi?id=96355
335
336         Reviewed by Kent Tamura.
337
338         * tests/LocaleMacTest.cpp:
339         (testNumberIsReversible): Use Localizer::create.
340         (testNumbers):
341
342 2012-09-11  Sheriff Bot  <webkit.review.bot@gmail.com>
343
344         Unreviewed, rolling out r128150.
345         http://trac.webkit.org/changeset/128150
346         https://bugs.webkit.org/show_bug.cgi?id=96357
347
348         it broke chromium compilation (Requested by loislo on
349         #webkit).
350
351         * DEPS:
352
353 2012-09-10  Sheriff Bot  <webkit.review.bot@gmail.com>
354
355         Unreviewed.  Rolled DEPS.
356
357         * DEPS:
358
359 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
360
361         Properly expose <legend> elements to ATs
362         https://bugs.webkit.org/show_bug.cgi?id=84137
363
364         Reviewed by Chris Fleizach.
365
366         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
367         the expected platform role, ATK_ROLE_LABEL. Also established the needed
368         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
369
370         * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend
371         * src/AssertMatchingEnums.cpp: added the assert matching rule for
372         WebAccessibilityRoleLegend and LegendRole
373
374 2012-09-10  Beth Dakin  <bdakin@apple.com>
375
376         https://bugs.webkit.org/show_bug.cgi?id=96158
377         Need API to suppress scrollbar animations
378         -and corresponding-
379         <rdar://problem/12210972>
380
381         Reviewed by Sam Weinig.
382
383         ScrollableArea::isOnActivePage() has been re-named to
384         ScrollableArea:: scrollbarsCanBeActive().
385         * src/ScrollbarGroup.cpp:
386         (WebKit::ScrollbarGroup::scrollbarsCanBeActive):
387         * src/ScrollbarGroup.h:
388         * tests/GraphicsLayerChromiumTest.cpp:
389         * tests/ScrollAnimatorNoneTest.cpp:
390         (MockScrollableArea):
391
392 2012-09-10  Dan Alcantara  <dfalcantara@chromium.org>
393
394         [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in
395         https://bugs.webkit.org/show_bug.cgi?id=90222
396
397         Reviewed by Adam Barth.
398
399         When reloading a page with an overridden URL, the page's scroll and zoom
400         state will be restored once the reload is complete.  This is problematic
401         in situations when switching between mobile and desktop versions of the
402         same site because it will zoom back in on a random part of alternate page.
403         This CL just avoids that situation by resetting the zoom and scale whenever
404         this type of reload occurs.
405
406         Chromium half: https://chromiumcodereview.appspot.com/10889019
407
408         * public/WebView.h:
409         (WebView):
410         * src/WebViewImpl.cpp:
411         (WebKit::WebViewImpl::resetScrollAndScaleState):
412         (WebKit):
413         * src/WebViewImpl.h:
414         (WebViewImpl):
415
416 2012-09-10  Adam Barth  <abarth@chromium.org>
417
418         [V8] V8AuxiliaryContext used by IDB leaks memory
419         https://bugs.webkit.org/show_bug.cgi?id=96317
420
421         Reviewed by Tony Chang.
422
423         Call the V8 APIs directly instead of using a helper class.
424
425         * tests/IDBBindingUtilitiesTest.cpp:
426         (WebCore::TEST):
427
428 2012-09-10  Adam Barth  <abarth@chromium.org>
429
430         [V8] Inline firstFrame and currentFrame into their unique callers
431         https://bugs.webkit.org/show_bug.cgi?id=96309
432
433         Reviewed by Eric Seidel.
434
435         This patch just lines these WebCore functions because we only call them
436         from here.
437
438         * src/WebFrameImpl.cpp:
439         (WebKit::WebFrame::frameForEnteredContext):
440         (WebKit::WebFrame::frameForCurrentContext):
441
442 2012-09-10  Rick Byers  <rbyers@chromium.org>
443
444         [chromium] Add unused GestureTapCancel
445         https://bugs.webkit.org/show_bug.cgi?id=96183
446
447         Reviewed by Adam Barth.
448
449         This adds a new 'tap cancel' gesture type.  This is temporarily unused,
450         so that we can change chromium to start sending the gesture type
451         without breaking anything.
452
453         * public/WebInputEvent.h:
454         * src/PageWidgetDelegate.cpp:
455         (WebKit::PageWidgetDelegate::handleInputEvent):
456         * src/WebInputEventConversion.cpp:
457         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
458         * src/WebPopupMenuImpl.cpp:
459         (WebKit::WebPopupMenuImpl::handleInputEvent):
460         * src/WebViewImpl.cpp:
461         (WebKit::WebViewImpl::handleGestureEvent):
462
463 2012-09-10  Mark Pilgrim  <pilgrim@chromium.org>
464
465         [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
466         https://bugs.webkit.org/show_bug.cgi?id=95861
467
468         Reviewed by Adam Barth.
469
470         Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport.
471
472         * public/WebSharedWorkerRepository.h:
473         (WebKit):
474         * src/SharedWorkerRepository.cpp:
475         (WebKit):
476         (WebKit::setSharedWorkerRepository):
477         (WebKit::sharedWorkerRepository):
478         (WebCore::SharedWorkerRepository::isAvailable):
479         (WebCore::SharedWorkerRepository::connect):
480         (WebCore::SharedWorkerRepository::documentDetached):
481         (WebCore::SharedWorkerRepository::hasSharedWorkers):
482
483 2012-09-10  Catalin Badea  <badea@adobe.com>
484
485         webkit build for 64-bit Mac chromium
486         https://bugs.webkit.org/show_bug.cgi?id=95977
487
488         Reviewed by Eric Seidel.
489
490         Ensure header completeness and use the correct include order. This fixes a compilation issues noticeable when building chromium for 64-bit Mac. 
491
492         * public/mac/WebSubstringUtil.h:
493         * src/mac/WebSubstringUtil.mm:
494
495 2012-09-10  Adrienne Walker  <enne@google.com>
496
497         [chromium] Fix deadlock between WebMediaPlayerClientImpl dtor and PutCurrentFrame
498         https://bugs.webkit.org/show_bug.cgi?id=96010
499
500         Reviewed by James Robinson.
501
502         The key fix here is that the destructor no longer has a mutex.
503         The m_compositingMutex was supposedly protecting races between
504         ~WebMediaPlayerClientImpl and setVideoFrameProviderClient. The
505         former is only called from the main thread and the latter is called
506         from the compositor thread only when the main thread is blocked (and
507         it already asserts that this is the case).
508
509         In addition, the m_providerMutex in CCVideoLayerImpl prevents the
510         destruction of WebMediaPlayerClientImpl, thus keeping the frame
511         acquired via getCurrentFrame alive until putCurrentFrame is called.
512         These functions are only called by the client, and comments are added
513         to the interface to better document this.
514
515         To prevent a race between load() and getCurrentFrame/putCurrentFrame
516         (which are called from different threads) a new m_webMediaPlayerMutex
517         to replace part of what the old m_compositingMutex was doing.
518
519         * src/WebMediaPlayerClientImpl.cpp:
520         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
521         (WebKit::WebMediaPlayerClientImpl::load):
522         (WebKit::WebMediaPlayerClientImpl::loadInternal):
523         (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
524         (WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
525         (WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
526         * src/WebMediaPlayerClientImpl.h:
527         (WebMediaPlayerClientImpl):
528
529 2012-09-10  Rick Byers  <rbyers@chromium.org>
530
531         [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment
532         https://bugs.webkit.org/show_bug.cgi?id=95996
533
534         Reviewed by Adam Barth.
535
536         Switch from WebGestureEvent.boundingBox to new gesture-type specific
537         data fields.
538         * src/WebViewImpl.cpp:
539         (WebKit::WebViewImpl::handleGestureEvent):
540
541 2012-09-09  Keishi Hattori  <keishi@webkit.org>
542
543         REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup
544         https://bugs.webkit.org/show_bug.cgi?id=96222
545
546         Reviewed by Kent Tamura.
547
548         DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser()
549         so we shouldn't be changing the members after that.
550
551         Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html.
552
553         * src/DateTimeChooserImpl.cpp:
554         (WebKit::DateTimeChooserImpl::didClosePopup):
555
556 2012-09-09  Kenichi Ishibashi  <bashi@chromium.org>
557
558         [Chromium] Unreviewed gardening after r127907
559
560         Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads
561
562         * tests/CCRenderPassTest.cpp:
563         (CCRenderPassSize): Changed type of m_id
564
565 2012-09-09  Emil A Eklund  <eae@chromium.org>
566
567         Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
568         https://bugs.webkit.org/show_bug.cgi?id=81413
569
570         Reviewed by David Hyatt.
571
572         Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.
573
574         * src/WebViewImpl.cpp:
575         (WebKit::WebViewImpl::computeBlockBounds):
576         (WebKit::WebViewImpl::applyAutofillSuggestions):
577         (WebKit::WebViewImpl::refreshAutofillPopup):
578
579 2012-09-09  James Robinson  <jamesr@chromium.org>
580
581         [chromium] webkit_platform should only be linked into the webkit target
582         https://bugs.webkit.org/show_bug.cgi?id=96213
583
584         Reviewed by Adrienne Walker.
585
586         The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
587         makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.
588
589         * WebKit.gyp:
590
591 2012-09-09  James Robinson  <jamesr@chromium.org>
592
593         [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
594         https://bugs.webkit.org/show_bug.cgi?id=96212
595
596         Reviewed by Adrienne Walker.
597
598         The static ::create()s the test references currently are going away soon.
599
600         * tests/GraphicsLayerChromiumTest.cpp:
601         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
602         (WebKit::TEST_F):
603
604 2012-09-07  Benjamin Poulain  <benjamin@webkit.org>
605
606         Unreviewed prospective build fix.
607
608         * tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.
609         Remove the using directive from r127959.
610
611 2012-09-07  Simon Hausmann  <simon.hausmann@nokia.com>
612
613         Unreviewed prospective build fix.
614
615         Use WTF namespace like in other files in the same directory to resolve unqualified
616         adoptPtr correctly.
617
618         * tests/WebCompositorInputHandlerImplTest.cpp:
619
620 2012-09-07  James Robinson  <jamesr@chromium.org>
621
622         [chromium] Remove transitional WebCompositorSupport fallback code
623         https://bugs.webkit.org/show_bug.cgi?id=96155
624
625         Reviewed by Adrienne Walker.
626
627         * src/LinkHighlight.cpp:
628         (WebKit::LinkHighlight::LinkHighlight):
629         (WebKit::LinkHighlight::startHighlightAnimation):
630         * src/WebMediaPlayerClientImpl.cpp:
631         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
632         * src/WebPluginContainerImpl.cpp:
633         (WebKit::WebPluginContainerImpl::setBackingTextureId):
634         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
635         * src/WebViewImpl.cpp:
636         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
637         (WebKit):
638
639 2012-09-07  James Robinson  <jamesr@chromium.org>
640
641         [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
642         https://bugs.webkit.org/show_bug.cgi?id=96151
643
644         Reviewed by Adrienne Walker.
645
646         Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
647         WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
648         provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.
649
650         WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
651         and storing its identifier for the didActivateCompositor call.  From this point on the setup is the same as
652         before.
653
654         WCIHI changes covered by unit tests, overall scrolling behavior manually tested.
655
656         * WebKit.gypi:
657         * src/WebCompositorInputHandlerImpl.cpp:
658         (WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
659         (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
660         (WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
661         (WebKit::WebCompositorInputHandlerImpl::setClient):
662         (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
663         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
664         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
665         (WebKit::WebCompositorInputHandlerImpl::bindToClient):
666         * src/WebCompositorInputHandlerImpl.h:
667         (WebCompositorInputHandlerImpl):
668         (WebKit::WebCompositorInputHandlerImpl::identifier):
669         * src/WebLayerTreeViewImpl.cpp:
670         (WebKit::WebLayerTreeViewImpl::createInputHandler):
671         (WebKit):
672         * src/WebLayerTreeViewImpl.h:
673         (WebLayerTreeViewImpl):
674         * src/WebToCCInputHandlerAdapter.cpp: Added.
675         (WebKit):
676         (WebKit::WebToCCInputHandlerAdapter::create):
677         (WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
678         (WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
679         (WebToCCInputHandlerAdapter::ClientAdapter):
680         (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
681         (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
682         (WebKit::WebToCCInputHandlerAdapter::bindToClient):
683         (WebKit::WebToCCInputHandlerAdapter::animate):
684         * src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.
685         (WebKit):
686         (WebToCCInputHandlerAdapter):
687         * src/WebViewImpl.cpp:
688         (WebKit::WebViewImpl::WebViewImpl):
689         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
690         (WebKit):
691         (WebKit::WebViewImpl::createInputHandler):
692         * src/WebViewImpl.h:
693         (WebViewImpl):
694         * tests/CCThreadedTest.cpp:
695         * tests/FakeCCLayerTreeHostClient.h:
696         * tests/WebCompositorInputHandlerImplTest.cpp:
697         (MockWebInputHandlerClient):
698         (WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
699         (WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
700         (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
701         (WebCompositorInputHandlerImplTest):
702         (WebKit::TEST_F):
703
704 2012-09-07  David Reveman  <reveman@chromium.org>
705
706         [Chromium] Multiple commits without invalidation allowed per redraw.
707         https://bugs.webkit.org/show_bug.cgi?id=95661
708
709         Reviewed by James Robinson.
710
711         * tests/CCLayerTreeHostTest.cpp:
712         (CCLayerTreeHostTestContinuousCommit):
713         (WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
714         (WebKitTests):
715         (WebKitTests::TEST_F):
716         (CCLayerTreeHostTestContinuousInvalidate):
717         (WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
718         (CCLayerTreeHostTestContinuousAnimate):
719         (WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):
720         * tests/CCSchedulerStateMachineTest.cpp:
721         (WebCore::TEST):
722
723 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
724
725         AX: WebCore accessibility roles should be cross-platform
726         https://bugs.webkit.org/show_bug.cgi?id=94870
727
728         Reviewed by Chris Fleizach.
729
730         Add a new accessibility role.
731
732         * public/WebAccessibilityRole.h:
733         * src/AssertMatchingEnums.cpp:
734
735 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
736
737         AX: Chromium needs access to canvasHasFallbackContent
738         https://bugs.webkit.org/show_bug.cgi?id=96124
739
740         Reviewed by Chris Fleizach.
741
742         Expose canvasHasFallbackContent on Chromium.
743
744         * public/WebAccessibilityObject.h:
745         (WebAccessibilityObject):
746         * src/WebAccessibilityObject.cpp:
747         (WebKit::WebAccessibilityObject::canvasHasFallbackContent):
748         (WebKit):
749
750 2012-09-07  Robert Kroeger  <rjkroege@chromium.org>
751
752         [chromium] Add touchscreen specific fling curve parametrization
753         https://bugs.webkit.org/show_bug.cgi?id=95997
754
755         Reviewed by James Robinson.
756
757         Added a new set of fling curve parameters with a good feel for touchscreen
758         initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
759         TouchFlingPlatformGestureCurve to better reflect that the class
760         can serve for both touchscreen and touchpad flings when appropriately
761         parametrized. Updated build files as necessary for the rename.
762
763         No new tests - existing tests apply.
764
765
766         * tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.
767
768 2012-09-07  Dana Jansens  <danakj@chromium.org>
769
770         [chromium] Make RenderPass ids hold both generating layer id and an index
771         https://bugs.webkit.org/show_bug.cgi?id=95500
772
773         Reviewed by Adrienne Walker.
774
775         * tests/CCLayerTreeHostImplTest.cpp:
776         * tests/CCLayerTreeHostTest.cpp:
777         * tests/CCRenderSurfaceTest.cpp:
778         * tests/CCRendererGLTest.cpp:
779         (FakeCCRendererClient::FakeCCRendererClient):
780
781 2012-09-07  Joshua Bell  <jsbell@chromium.org>
782
783         [Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
784         https://bugs.webkit.org/show_bug.cgi?id=96122
785
786         Reviewed by Adam Barth.
787
788         Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
789         open() method now takes the "database callbacks", rather than being sent through
790         in a later call.
791
792         Also, delete an obsolete method.
793
794         * public/WebIDBFactory.h:
795         (WebKit):
796         (WebIDBFactory): Delete pre-version overload of open().
797         (WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.
798
799 2012-09-07  Sami Kyostila  <skyostil@google.com>
800
801         [Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
802         https://bugs.webkit.org/show_bug.cgi?id=95932
803
804         Reviewed by James Robinson.
805
806         Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
807         properly scroll it.
808
809         * tests/GraphicsLayerChromiumTest.cpp:
810         (WebKit::TEST_F): Re-enable the test.
811
812 2012-09-07  James Robinson  <jamesr@chromium.org>
813
814         [chromium] Move some CC unit tests into correct gyp variable
815         https://bugs.webkit.org/show_bug.cgi?id=96048
816
817         Reviewed by Adrienne Walker.
818
819         These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.
820
821         * WebKit.gypi:
822
823 2012-09-07  James Robinson  <jamesr@chromium.org>
824
825         [chromium] Remove dead CCActiveGestureAnimation code and related classes
826         https://bugs.webkit.org/show_bug.cgi?id=96075
827
828         Reviewed by Adrienne Walker.
829
830         Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
831         evaluate the curve itself without intermediate classes.
832
833         * src/WebCompositorInputHandlerImpl.cpp:
834         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
835         (WebKit::WebCompositorInputHandlerImpl::animate):
836         (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
837         * src/WebCompositorInputHandlerImpl.h:
838         (WebCore):
839         (WebCompositorInputHandlerImpl):
840         * tests/PlatformGestureCurveTest.cpp:
841         * tests/WebCompositorInputHandlerImplTest.cpp:
842
843 2012-09-07  James Robinson  <jamesr@chromium.org>
844
845         [chromium] Clean up dependencies in ScrollbarLayerChromiumTest
846         https://bugs.webkit.org/show_bug.cgi?id=96052
847
848         Reviewed by Adrienne Walker.
849
850         Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
851         *) WebScrollbarImpl.h is #included, but not use
852         *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
853             WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
854
855         * tests/ScrollbarLayerChromiumTest.cpp:
856         (WebCore::TEST):
857
858 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
859
860         AX: ARIA spin button should support range value attributes
861         https://bugs.webkit.org/show_bug.cgi?id=96076
862
863         Reviewed by Chris Fleizach.
864
865         Expose supportsRangeValue to simplify Chromium logic for when to
866         extract a value from a range.
867
868         * public/WebAccessibilityObject.h:
869         (WebAccessibilityObject):
870         * src/WebAccessibilityObject.cpp:
871         (WebKit::WebAccessibilityObject::supportsRangeValue):
872         (WebKit):
873
874 2012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
875
876         Simplify hitTestResultAtPoint and nodesFromRect APIs
877         https://bugs.webkit.org/show_bug.cgi?id=95720
878
879         Reviewed by Antonio Gomes.
880
881         Update calls to new API.
882
883         * src/ContextMenuClientImpl.cpp:
884         (WebKit::selectMisspelledWord):
885         * src/FrameLoaderClientImpl.cpp:
886         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
887         * src/WebFrameImpl.cpp:
888         (WebKit::WebFrameImpl::characterIndexForPoint):
889         * src/WebPluginContainerImpl.cpp:
890         (WebKit::WebPluginContainerImpl::isRectTopmost):
891         * src/WebViewImpl.cpp:
892         (WebKit::WebViewImpl::handleMouseUp):
893         (WebKit::WebViewImpl::computeBlockBounds):
894
895 2012-09-07  Ilya Tikhonovsky  <loislo@chromium.org>
896
897         Web Inspector: NMI: move WebCore specific code to separate header
898         https://bugs.webkit.org/show_bug.cgi?id=96101
899
900         Reviewed by Yury Semikhatsky.
901
902         I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h
903
904         * tests/MemoryInstrumentationTest.cpp:
905
906 2012-09-07  Ian Vollick  <vollick@chromium.org>
907
908         [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
909         https://bugs.webkit.org/show_bug.cgi?id=95855
910
911         Reviewed by James Robinson.
912
913         Added the following unit tests:
914           AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
915           AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform
916
917         * tests/AnimationTranslationUtilTest.cpp:
918         (WebKit::TEST):
919         (WebKit):
920
921 2012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
922
923         X11 Global Selection
924         https://bugs.webkit.org/show_bug.cgi?id=88238
925
926         Reviewed by Tony Chang.
927
928         Use new editor command for pasting global selection.
929
930         * src/EditorClientImpl.cpp:
931         (WebKit::EditorClientImpl::supportsGlobalSelection):
932         * src/EditorClientImpl.h:
933         (EditorClientImpl):
934         * src/WebViewImpl.cpp:
935         (WebKit::WebViewImpl::handleMouseUp):
936
937 2012-09-07  Yoshifumi Inoue  <yosin@chromium.org>
938
939         We should have a localized string of empty for date time field
940         https://bugs.webkit.org/show_bug.cgi?id=96081
941
942         Reviewed by Kent Tamura.
943
944         This patch add a function for getting localized string of empty field
945         value of date time fields for accessibility inside
946         ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
947
948         These functions will be used by derived classes of DateTimeFieldElement.
949
950         Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
951         to support "date", "datetime", "month" and "week" multiple fields input
952         UI.
953
954         * src/LocalizedStrings.cpp:
955         (WebCore::AXDateTimeFieldEmptyValueText): Added.
956
957 2012-09-06  Sheriff Bot  <webkit.review.bot@gmail.com>
958
959         Unreviewed, rolling out r127822.
960         http://trac.webkit.org/changeset/127822
961         https://bugs.webkit.org/show_bug.cgi?id=96073
962
963         It broke compilation on chromium debug bots (Requested by
964         loislo on #webkit).
965
966         * tests/CCDrawQuadTest.cpp:
967         (WebCore::TEST):
968         * tests/CCLayerTreeHostImplTest.cpp:
969         * tests/CCLayerTreeHostTest.cpp:
970         * tests/CCRenderPassTest.cpp:
971         (WebCore::TEST):
972         * tests/CCRenderSurfaceTest.cpp:
973         * tests/CCRendererGLTest.cpp:
974         (FakeCCRendererClient::FakeCCRendererClient):
975
976 2012-09-06  Dana Jansens  <danakj@chromium.org>
977
978         [chromium] Make RenderPass ids hold both generating layer id and an index
979         https://bugs.webkit.org/show_bug.cgi?id=95500
980
981         Reviewed by Adrienne Walker.
982
983         * tests/CCLayerTreeHostImplTest.cpp:
984         * tests/CCLayerTreeHostTest.cpp:
985         * tests/CCRenderSurfaceTest.cpp:
986         * tests/CCRendererGLTest.cpp:
987         (FakeCCRendererClient::FakeCCRendererClient):
988
989 2012-09-06  Yoshifumi Inoue  <yosin@chromium.org>
990
991         We should have localized strings of date time fields for accessibility
992         https://bugs.webkit.org/show_bug.cgi?id=96050
993
994         Reviewed by Kent Tamura.
995
996         This patch adds functions for getting localized strings of date time
997         fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
998
999         These functions will be used by derived classes of DateTimeFieldElement.
1000
1001         Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
1002         to support "date", "datetime", "month" and "week" multiple fields input
1003         UI.
1004
1005         * src/LocalizedStrings.cpp:
1006         (WebCore::AXAMPMFieldText): Added.
1007         (WebCore::AXDayOfMonthFieldText): Added.
1008         (WebCore::AXHourFieldText): Added.
1009         (WebCore::AXMillisecondFieldText): Added.
1010         (WebCore::AXMinuteFieldText): Added.
1011         (WebCore::AXMonthFieldText): Added.
1012         (WebCore::AXSecondFieldText): Added.
1013         (WebCore::AXWeekOfYearFieldText): Added.
1014         (WebCore::AXYearFieldText): Added.
1015
1016 2012-09-06  James Robinson  <jamesr@chromium.org>
1017
1018         [chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
1019         https://bugs.webkit.org/show_bug.cgi?id=96024
1020
1021         Reviewed by Adam Barth.
1022
1023         When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
1024         We don't need to link anything in to WebKit.dll.
1025
1026         * WebKit.gyp:
1027
1028 2012-09-06  James Robinson  <jamesr@chromium.org>
1029
1030         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
1031         https://bugs.webkit.org/show_bug.cgi?id=96007
1032
1033         Reviewed by Adrienne Walker.
1034
1035         Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
1036         WebCompositorInitializer RAII class to simplify this somewhat tedious process.
1037
1038         * WebKit.gypi:
1039         * public/WebCompositorInputHandlerClient.h:
1040         (WebCompositorInputHandlerClient):
1041         * src/WebCompositorInputHandlerImpl.h:
1042         * src/WebViewImpl.cpp:
1043         (WebKit::WebViewImpl::composite):
1044         (WebKit::WebViewImpl::scheduleAnimation):
1045         (WebKit::WebViewImpl::scheduleComposite):
1046         * tests/CCPrioritizedTextureTest.cpp:
1047         (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
1048         (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
1049         (CCPrioritizedTextureTest):
1050         * tests/CCRendererGLTest.cpp:
1051         (CCRendererGLTest::CCRendererGLTest):
1052         (CCRendererGLTest::SetUp):
1053         (CCRendererGLTest):
1054         * tests/CCTextureUpdateControllerTest.cpp:
1055         * tests/CCThreadedTest.cpp:
1056         (WebKitTests::CCThreadedTest::runTest):
1057         * tests/Canvas2DLayerBridgeTest.cpp:
1058         (Canvas2DLayerBridgeTest::fullLifecycleTest):
1059         * tests/GraphicsLayerChromiumTest.cpp:
1060         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1061         (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
1062         * tests/LayerChromiumTest.cpp:
1063         * tests/LinkHighlightTest.cpp:
1064         (WebCore::TEST):
1065         * tests/TextureLayerChromiumTest.cpp:
1066         * tests/TiledLayerChromiumTest.cpp:
1067         * tests/WebCompositorInitializer.h: Added.
1068         (WebKit):
1069         (WebKitTests):
1070         (WebCompositorInitializer):
1071         (WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
1072         (WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):
1073         * tests/WebCompositorInputHandlerImplTest.cpp:
1074         (WebKit::TEST):
1075         (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
1076         (WebCompositorInputHandlerImplTest):
1077         * tests/WebLayerTest.cpp:
1078         * tests/WebLayerTreeViewTest.cpp:
1079
1080 2012-09-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1081
1082         Unreviewed.  Rolled DEPS.
1083
1084         * DEPS:
1085
1086 2012-09-06  Alec Flett  <alecflett@chromium.org>
1087
1088         IndexedDB: make IDBKeyPath's string and array constructors explicit
1089         https://bugs.webkit.org/show_bug.cgi?id=96004
1090
1091         Reviewed by Tony Chang.
1092
1093         Fix test to use explicit constructor for IDBKeyPath.
1094
1095         * tests/IDBDatabaseBackendTest.cpp:
1096
1097 2012-09-06  Adrienne Walker  <enne@google.com>
1098
1099         [chromium] Remove GraphicsContext references from ContentLayerChromiumTest
1100         https://bugs.webkit.org/show_bug.cgi?id=96002
1101
1102         Reviewed by James Robinson.
1103
1104         This is a compositor unit test, so it shouldn't reference things
1105         outside of the compositor like GraphicsContext. The
1106         OpaqueRectTrackingContentLayerDelegateTest already tests opaque
1107         tracking right at the time of paint. This test is about verifying that
1108         transformed canvases work properly, so can just fake the opaque rect
1109         coming back from the paint.
1110
1111         * tests/ContentLayerChromiumTest.cpp:
1112         (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
1113         (WebKit::TEST):
1114
1115 2012-09-06  Jeff Timanus  <twiz@chromium.org>
1116
1117         [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
1118         https://bugs.webkit.org/show_bug.cgi?id=95094
1119
1120         Reviewed by Adrienne Walker.
1121
1122         In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
1123         try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
1124         contentsScale behaviour.
1125         This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.
1126
1127         * src/NonCompositedContentHost.cpp:
1128         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
1129             Inform the layer associated with the NCCH that it is to disregard the page scale factor.
1130             Also remove now unused m_deviceScaleFactor and associated routines.
1131         (WebKit::NonCompositedContentHost::setViewport):
1132         * src/NonCompositedContentHost.h:
1133         (NonCompositedContentHost):
1134         * src/WebContentLayerImpl.cpp:
1135         (WebKit::WebContentLayerImpl::setBoundsContainPageScale):
1136         (WebKit):
1137         (WebKit::WebContentLayerImpl::boundsContainPageScale):
1138         * src/WebContentLayerImpl.h:
1139         (WebContentLayerImpl):
1140         * src/WebViewImpl.cpp:
1141         (WebKit::WebViewImpl::updateLayerTreeViewport):
1142         * tests/CCLayerTreeHostTest.cpp:
1143         (NoScaleContentLayerChromium):
1144         (WebKitTests::NoScaleContentLayerChromium::create):
1145         (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
1146         (WebKitTests):
1147         (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
1148             Rebaselined to correspond to the new behaviour.  Because the layers are now assigned a contentsScale, the
1149             scale on the draw transforms remain identity.
1150         * tests/GraphicsLayerChromiumTest.cpp:
1151         (WebKit): Remove now obsolete unit-test.
1152
1153 2012-09-06  Adrienne Walker  <enne@google.com>
1154
1155         [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
1156         https://bugs.webkit.org/show_bug.cgi?id=95994
1157
1158         Reviewed by James Robinson.
1159
1160         This compositor test shouldn't depend on code outside the compositor.
1161
1162         * tests/ScrollbarLayerChromiumTest.cpp:
1163         (WebCore::FakeWebScrollbar::create):
1164         (FakeWebScrollbar):
1165         (WebCore::TEST):
1166
1167 2012-09-06  James Robinson  <jamesr@chromium.org>
1168
1169         [chromium] Put chromium implementations of WTF symbols in separate static library
1170         https://bugs.webkit.org/show_bug.cgi?id=95933
1171
1172         Reviewed by Adam Barth.
1173
1174         A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
1175         implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
1176         component build is a DLL. This moves these files into a static library that webkit depends on so targets can
1177         statically link in wtf and these support files without depending directly on webkit.
1178
1179         * WebKit.gyp:
1180
1181 2012-09-06  Iain Merrick  <husky@chromium.org>
1182
1183         [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
1184         https://bugs.webkit.org/show_bug.cgi?id=93998
1185
1186         Reviewed by Adam Barth.
1187
1188         These provide the same functionality selectRange(WebPoint, WebPoint),
1189         with finer-grained control needed on the Android platform. By passing
1190         allowCollapsedSelection=false, we can ensure the selection stays at
1191         least one character wide.
1192
1193         I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
1194         calling the new methods. The existing test passes, and I've added new
1195         tests for the new methods.
1196
1197         * public/WebFrame.h:
1198         (WebFrame):
1199         * src/WebFrameImpl.cpp:
1200         (WebKit::WebFrameImpl::selectRange):
1201         (WebKit):
1202         (WebKit::WebFrameImpl::moveSelectionStart):
1203         (WebKit::WebFrameImpl::moveSelectionEnd):
1204         (WebKit::WebFrameImpl::moveCaret):
1205         * src/WebFrameImpl.h:
1206         (WebFrameImpl):
1207         * tests/WebFrameTest.cpp:
1208         * tests/data/text_selection.html: Added.
1209
1210 2012-09-06  Robert Kroeger  <rjkroege@chromium.org>
1211
1212         [chromium] Enable different fling behaviour for touchscreen and touchpad
1213         https://bugs.webkit.org/show_bug.cgi?id=95756
1214
1215         Reviewed by James Robinson.
1216
1217         Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
1218         events by their originating device and pass this flag to a factory that produces
1219         different device  specific fling curves based on the value of the flag.
1220
1221         * public/WebActiveWheelFlingParameters.h:
1222         (WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
1223         (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
1224         * public/WebInputEvent.h: Added source device flag to WebGestureEvent.
1225         * src/WebCompositorInputHandlerImpl.cpp:
1226         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):  Use factory to
1227         obtain device-appropriate fling curve.
1228         * src/WebViewImpl.cpp:
1229         (WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
1230         fling curve.
1231         (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
1232
1233 2012-09-05  Sam Weinig  <sam@webkit.org>
1234
1235         Part 2 of removing PlatformString.h, remove PlatformString.h
1236         https://bugs.webkit.org/show_bug.cgi?id=95931
1237
1238         Reviewed by Adam Barth.
1239
1240         Remove PlatformString.h
1241
1242         * src/ContextMenuClientImpl.cpp:
1243         * src/EditorClientImpl.cpp:
1244         * src/InspectorFrontendClientImpl.cpp:
1245         * src/LocalFileSystemChromium.cpp:
1246         * src/SpeechInputClientImpl.cpp:
1247         * src/SpeechRecognitionClientProxy.h:
1248         * src/WebDevToolsAgentImpl.cpp:
1249         * src/WebDevToolsFrontendImpl.cpp:
1250         * src/WebDevToolsFrontendImpl.h:
1251         * src/WebEntities.h:
1252         * src/WebFrameImpl.h:
1253         * src/WorkerFileSystemCallbacksBridge.h:
1254         * tests/UniscribeHelperTest.cpp:
1255
1256 2012-09-06  Dana Jansens  <danakj@chromium.org>
1257
1258         [chromium] Add a customized copy() method to CCRenderPassDrawQuad
1259         https://bugs.webkit.org/show_bug.cgi?id=95871
1260
1261         Reviewed by Adrienne Walker.
1262
1263         * tests/CCDrawQuadTest.cpp:
1264         (WebCore):
1265         (WebCore::TEST):
1266
1267 2012-09-06  Ilya Tikhonovsky  <loislo@chromium.org>
1268
1269         Unreviewed Web Inspector: test fix.
1270
1271         * tests/MemoryInstrumentationTest.cpp:
1272         (StringOwnerInstrumented):
1273         (WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
1274         (WebCore::StringOwnerInstrumented::reportMemoryUsage):
1275         (WebCore):
1276         (WebCore::TEST):
1277
1278 2012-09-06  Ilya Tikhonovsky  <loislo@chromium.org>
1279
1280         Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
1281         https://bugs.webkit.org/show_bug.cgi?id=95957
1282
1283         Reviewed by Yury Semikhatsky.
1284
1285         Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
1286         instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
1287         At a later stage, when each memory type is counted in MemoryInstrumentation
1288         we will build the blocks hierarchy for the front-end automatically.
1289
1290         * tests/MemoryInstrumentationTest.cpp:
1291         (WebCore::InstrumentedUndefined::InstrumentedUndefined):
1292         (WebCore::InstrumentedUndefined::reportMemoryUsage):
1293         (WebCore::InstrumentedDOM::InstrumentedDOM):
1294         (WebCore::InstrumentedDOM::reportMemoryUsage):
1295         (InstrumentedDOM):
1296         (WebCore::TEST):
1297
1298 2012-09-06  Kenichi Ishibashi  <bashi@chromium.org>
1299
1300         [Chromium] Win build fix attempt after r127715
1301
1302         * tests/CCRenderPassTest.cpp:
1303         (WebCore::TEST):
1304
1305 2012-09-06  Peter Beverloo  <peter@chromium.org>
1306
1307         Unreviewed.  Rolled DEPS.
1308
1309         * DEPS:
1310
1311 2012-09-06  Dana Jansens  <danakj@chromium.org>
1312
1313         [chromium] Add a copy() method to CCRenderPass
1314         https://bugs.webkit.org/show_bug.cgi?id=95485
1315
1316         Reviewed by Adrienne Walker.
1317
1318         * WebKit.gypi:
1319         * tests/CCRenderPassTest.cpp: Added.
1320         (CCTestRenderPass):
1321         (CCTestRenderPass::quadList):
1322         (CCTestRenderPass::sharedQuadStateList):
1323         (CCRenderPassSize):
1324         (TEST):
1325
1326 2012-09-06  Peter Beverloo  <peter@chromium.org>
1327
1328         [Chromium] Chromium Mac build fix after revision r127711
1329         https://bugs.webkit.org/show_bug.cgi?id=95958
1330
1331         Unreviewed build fix.
1332
1333         This is a clear typo in the source file, so changing the function to
1334         call locationModifiersFromWindowsKeyCode instead.
1335
1336         * src/mac/WebInputEventFactory.mm:
1337         (WebKit::WebInputEventFactory::keyboardEvent):
1338
1339 2012-09-06  Raymes Khoury  <raymes@chromium.org>
1340
1341         Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
1342         https://bugs.webkit.org/show_bug.cgi?id=94142
1343
1344         Reviewed by Tony Chang.
1345
1346         Previously we distinguished between left/right Shift/Ctrl/Alt in
1347         WebInputEvents by using the location-specific virtual keycodes (e.g.
1348         VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
1349         always returns the non-locational version (e.g. VK_SHIFT).
1350         Furthermore, KeyboardEvent also returns
1351         non-locational keycodes and separates the location information which
1352         matches the behavior described in the DOM3
1353         spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
1354         should be consistent with this in our representation of key events.
1355         This patch changes WebInputEvents so they always store the
1356         non-locational keycode and location information is stored in
1357         modifiers. Since this only changes internal representation, no new
1358         tests are added.
1359
1360         This patch also ensures that when KeyboardEvents are converted back to
1361         WebInputEvents location information is preserved (which was not
1362         happening before). This is important so that key location information
1363         is passed on to plugins. A unittest is added for this.
1364
1365         * WebKit.gypi:
1366         * public/WebInputEvent.h:
1367         (WebKeyboardEvent):
1368         * src/WebInputEvent.cpp:
1369         (WebKit):
1370         (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
1371         (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):
1372         * src/WebInputEventConversion.cpp:
1373         (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
1374         (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1375         * src/android/WebInputEventFactory.cpp:
1376         (WebKit::WebInputEventFactory::keyboardEvent):
1377         * src/gtk/WebInputEventFactory.cpp:
1378         (WebKit::WebInputEventFactory::keyboardEvent):
1379         * src/mac/WebInputEventFactory.mm:
1380         (WebKit::WebInputEventFactory::keyboardEvent):
1381         * src/win/WebInputEventFactory.cpp:
1382         (WebKit::getLocationModifier):
1383         (WebKit::WebInputEventFactory::keyboardEvent):
1384         * tests/WebInputEventConversionTest.cpp: Added.
1385
1386 2012-09-06  Adam Barth  <abarth@webkit.org>
1387
1388         Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
1389         https://bugs.webkit.org/show_bug.cgi?id=91110
1390
1391         Reviewed by Tony Chang.
1392
1393         Prior to this patch, we were ignoring the user-scalable property of
1394         viewport meta tags. This patch enforces the user-scalable property by
1395         claming the minimum-scale and maximum-scale values, effectively
1396         preventing user scaling. This approach isn't perfect, as discussed in
1397         https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
1398         over the status quo.
1399
1400         This approach is also used by EFL, GTK, and Qt.
1401
1402         * src/ChromeClientImpl.cpp:
1403         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1404
1405 2012-09-05  Dana Jansens  <danakj@chromium.org>
1406
1407         [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
1408         https://bugs.webkit.org/show_bug.cgi?id=95374
1409
1410         Reviewed by Adrienne Walker.
1411
1412         * WebKit.gypi:
1413         * tests/CCDrawQuadTest.cpp: Added.
1414         (TEST):
1415         (createSharedQuadState):
1416         (compareDrawQuad):
1417
1418 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1419
1420         [Chromium] Unreviewed gardening
1421
1422         * tests/GraphicsLayerChromiumTest.cpp:
1423         (WebKit::TEST_F): Disabled applyScrollToScrollableArea()
1424
1425 2012-09-05  Tony Chang  <tony@chromium.org>
1426
1427         [chromium] Remove dependency on webkit_user_agent
1428         https://bugs.webkit.org/show_bug.cgi?id=95886
1429
1430         Reviewed by Adam Barth.
1431
1432         The code isn't used by webkit_unit_tests.
1433
1434         * WebKitUnitTests.gyp:
1435
1436 2012-09-05  Nate Chapin  <japhet@chromium.org>
1437
1438         Test for https://bugs.webkit.org/show_bug.cgi?id=91685
1439
1440         Reviewed by Adam Barth.
1441
1442         * tests/WebFrameTest.cpp:
1443
1444 2012-09-05  Rick Byers  <rbyers@chromium.org>
1445
1446         Use new type-specific WebGestureEvent fields
1447         https://bugs.webkit.org/show_bug.cgi?id=95573
1448
1449         Reviewed by James Robinson.
1450
1451         Chromium has been updated to store gesture-type specific details in the
1452         new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
1453         crrev.com/154959), so we can now rely on them.
1454
1455         * src/WebCompositorInputHandlerImpl.cpp:
1456         Update the compositor scroll, pinch and fling handling to use these new fields.
1457         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
1458         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1459         * src/WebInputEventConversion.cpp:
1460         Update PlatformGestureEvent/WebGestureEvent conversion to use the new
1461         fields, storing into the existing overloaded PlatformGestureEvent
1462         fields (which will be cleaned up in my next CL).
1463         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1464         (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
1465         * src/WebViewImpl.cpp:
1466         (WebKit::WebViewImpl::handleGestureEvent):
1467         Update fling scrolling implementation for correct location of velocity.
1468         * tests/WebCompositorInputHandlerImplTest.cpp:
1469         (WebKit::TEST_F):
1470         Update tests to use the new fields.
1471
1472
1473 2012-09-05  James Robinson  <jamesr@chromium.org>
1474
1475         [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
1476         https://bugs.webkit.org/show_bug.cgi?id=95819
1477
1478         Reviewed by Adam Barth.
1479
1480         This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
1481         upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
1482         webkit.dll in the component build.
1483
1484         * tests/WebLayerTest.cpp:
1485
1486 2012-09-05  Victoria Kirst  <vrk@chromium.org>
1487
1488         Add the duration attribute to MediaSource
1489         https://bugs.webkit.org/show_bug.cgi?id=95149
1490
1491         Reviewed by Eric Carlson.
1492
1493         Add support for the duration attribute recently added to the MediaSource spec.
1494         http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration
1495
1496         * public/WebMediaPlayer.h:
1497         (WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.
1498         * src/WebMediaPlayerClientImpl.cpp:
1499         (WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
1500         (WebKit):
1501         * src/WebMediaPlayerClientImpl.h:
1502         (WebMediaPlayerClientImpl):
1503
1504 2012-09-05  Mihai Parparita  <mihaip@chromium.org>
1505
1506         [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
1507         https://bugs.webkit.org/show_bug.cgi?id=95865
1508
1509         Reviewed by Darin Fisher.
1510
1511         Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
1512         no-ops.
1513
1514         * public/WebRuntimeFeatures.h:
1515         (WebRuntimeFeatures):
1516         * src/WebRuntimeFeatures.cpp:
1517         (WebKit::WebRuntimeFeatures::enablePushState):
1518         (WebKit::WebRuntimeFeatures::isPushStateEnabled):
1519
1520 2012-09-05  Mark Pilgrim  <pilgrim@chromium.org>
1521
1522         [Chromium] Remove getRenderStyleForStrike from PlatformSupport
1523         https://bugs.webkit.org/show_bug.cgi?id=95363
1524
1525         Reviewed by Adam Barth.
1526
1527         Part of a refactoring series. See tracking bug 82948.
1528
1529         * public/linux/WebFontInfo.h:
1530         * public/linux/WebFontRenderStyle.h:
1531         * src/PlatformSupport.cpp:
1532         (WebCore):
1533
1534 2012-09-05  Ilya Tikhonovsky  <loislo@chromium.org>
1535
1536         Unreviewed: WebInspector: remove accidentally committed speed test.
1537
1538         * tests/MemoryInstrumentationTest.cpp:
1539
1540 2012-09-05  Sami Kyostila  <skyostil@chromium.org>
1541
1542         [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
1543         https://bugs.webkit.org/show_bug.cgi?id=95679
1544
1545         Reviewed by James Robinson.
1546
1547         Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
1548
1549         * src/WebLayerImpl.cpp:
1550         (WebKit::WebLayerImpl::setMaxScrollPosition):
1551         (WebKit):
1552         (WebKit::WebLayerImpl::setScrollClient):
1553         (WebKit::WebLayerImpl::scrollBy):
1554         * src/WebLayerImpl.h:
1555         (WebLayerImpl):
1556         * tests/CCLayerTreeHostTest.cpp:
1557         * tests/GraphicsLayerChromiumTest.cpp:
1558         (MockScrollableArea):
1559         (WebKit):
1560         (WebKit::TEST_F):
1561         * tests/WebLayerTest.cpp:
1562
1563 2012-09-05  Ilya Tikhonovsky  <loislo@chromium.org>
1564
1565         Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
1566         https://bugs.webkit.org/show_bug.cgi?id=95850
1567
1568         Reviewed by Yury Semikhatsky.
1569
1570         I'd like to extract MemoryObjectTypes into separate classes.
1571         After that we will be able to move core NMI instrumentation code to WTF.
1572
1573         * tests/MemoryInstrumentationTest.cpp:
1574         (WebCore::Instrumented::reportMemoryUsage):
1575         (WebCore::InstrumentedRefPtr::reportMemoryUsage):
1576         (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
1577         (WebCore::InstrumentedOther::reportMemoryUsage):
1578         (WebCore::InstrumentedDOM::reportMemoryUsage):
1579         (WebCore::TEST):
1580         (WebCore::NonVirtualInstrumented::reportMemoryUsage):
1581
1582 2012-09-05  Peter Beverloo  <peter@chromium.org>
1583
1584         Unreviewed, rolling out r127590.
1585         http://trac.webkit.org/changeset/127590
1586
1587         Broke the Chromium bots because of a compile error in the compositor.
1588
1589         * DEPS:
1590
1591 2012-09-05  Peter Beverloo  <peter@chromium.org>
1592
1593         Unreviewed.  Rolled DEPS.
1594
1595         * DEPS:
1596
1597 2012-09-04  Ilya Tikhonovsky  <loislo@chromium.org>
1598
1599         Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
1600         https://bugs.webkit.org/show_bug.cgi?id=95739
1601
1602         Reviewed by Yury Semikhatsky.
1603
1604         When we go deeper into different parts of browser like skia, chromium itself etc.
1605         we can't use a single enum for all reported object types.
1606         The current idea is to use plain simple strings as ObjectType identifiers.
1607         In the future patches we will extract these identifiers into separate class or namespace
1608         and and split it between components.
1609
1610         * tests/MemoryInstrumentationTest.cpp:
1611         (WebCore::TEST):
1612         (WebCore):
1613
1614 2012-09-04  Keishi Hattori  <keishi@webkit.org>
1615
1616         Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
1617         https://bugs.webkit.org/show_bug.cgi?id=95681
1618
1619         Reviewed by Kent Tamura.
1620
1621         * WebKit.gyp:
1622         * src/ChromeClientImpl.cpp:
1623         (WebKit):
1624         (WebKit::ChromeClientImpl::openDateTimeChooser):
1625         * src/ChromeClientImpl.h:
1626         (WebCore):
1627         (ChromeClientImpl):
1628         * src/DateTimeChooserImpl.cpp: Added.
1629         (WebKit):
1630         (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
1631         (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
1632         (WebKit::DateTimeChooserImpl::endChooser):
1633         (WebKit::DateTimeChooserImpl::contentSize):
1634         (WebKit::DateTimeChooserImpl::writeDocument):
1635         (WebKit::DateTimeChooserImpl::setValueAndClosePopup):
1636         (WebKit::DateTimeChooserImpl::didClosePopup):
1637         * src/DateTimeChooserImpl.h:
1638         (WebCore):
1639         (WebKit):
1640         (DateTimeChooserImpl):
1641
1642 2012-09-04  Adam Barth  <abarth@chromium.org>
1643
1644         Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
1645         https://bugs.webkit.org/show_bug.cgi?id=95798
1646
1647         Reviewed by Eric Seidel.
1648
1649         * src/WebAccessibilityObject.cpp:
1650         (WebKit::WebAccessibilityObject::keyboardShortcut):
1651           - Remove use of WTF::String::operator+=
1652         * src/WebPageSerializerImpl.cpp:
1653           - Whitelist use of WTF::String::operator+=. Remove this use will take
1654             some more careful thought.
1655
1656 2012-09-04  Alec Flett  <alecflett@chromium.org>
1657
1658         IndexedDB: remove final createIndex backend glue
1659         https://bugs.webkit.org/show_bug.cgi?id=95385
1660
1661         Reviewed by Adam Barth.
1662
1663         Remove chromium glue for old key-generation code.
1664
1665         * public/WebIDBKey.h:
1666         (WebIDBKey):
1667         * src/WebIDBKey.cpp:
1668
1669 2012-09-04  Tien-Ren Chen  <trchen@chromium.org>
1670
1671         [chromium] Rename WebViewClient::handleDisambiguationPopup
1672         https://bugs.webkit.org/show_bug.cgi?id=95529
1673
1674         Reviewed by Adam Barth.
1675
1676         Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
1677
1678         * public/WebViewClient.h:
1679         (WebKit::WebViewClient::didTapMultipleTargets):
1680         * src/WebViewImpl.cpp:
1681         (WebKit::WebViewImpl::handleGestureEvent):
1682         * tests/WebFrameTest.cpp:
1683
1684 2012-09-03  Tao Bai  <michaelbai@chromium.org>
1685
1686         Added ANDROID_GDBSERVER definition for Ant
1687         https://bugs.webkit.org/show_bug.cgi?id=95265
1688
1689         Reviewed by Adam Barth.
1690
1691         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
1692         is only used for finding the gdbserver.
1693
1694         * WebKitUnitTests.gyp:
1695
1696 2012-09-03  Peter Beverloo  <peter@chromium.org>
1697
1698         Unreviewed.  Rolled DEPS.
1699
1700         * DEPS:
1701
1702 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
1703
1704         MediaStream API: Add Ice-related functionality to RTCPeerConnection
1705         https://bugs.webkit.org/show_bug.cgi?id=95565
1706
1707         Reviewed by Adam Barth.
1708
1709         * src/AssertMatchingEnums.cpp:
1710
1711 2012-09-01  James Robinson  <jamesr@chromium.org>
1712
1713         Unreviewed chromium buildfix when use_libcc_for_compositor=1
1714
1715         This gyp target was renamed downstream.
1716
1717         * WebKit.gyp:
1718
1719 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
1720
1721         MediaStream API: Add MediaStream management to RTCPeerConnection
1722         https://bugs.webkit.org/show_bug.cgi?id=95543
1723
1724         Reviewed by Adam Barth.
1725
1726         * src/AssertMatchingEnums.cpp:
1727
1728 2012-08-31  Koji Ishii  <kojiishi@gmail.com>
1729
1730         Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
1731         https://bugs.webkit.org/show_bug.cgi?id=51450
1732
1733         Reviewed by Tony Chang.
1734
1735         When writing-mode is vertical-*, Chromium Win does not render glyphs correctly.
1736         http://dev.w3.org/csswg/css3-writing-modes/#writing-mode
1737         Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name,
1738         and vertical alternate glyphs (OpenType 'vert' feature) is not enabled.
1739         CJK characters drawn at wrong baseline position is also fixed.
1740         In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty
1741         in Chromium Win but they were implemented because they were needed to draw vertical flow correctly.
1742
1743         Note that this patch does not address issues in vertical flow for complex code path.
1744         The issue is under discussion with Google people and it will not be fixed in short term.
1745
1746         Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations.
1747
1748         * features.gypi: ENABLE_OPENTYPE_VERTICAL=1.
1749
1750 2012-08-31  W. James MacLean  <wjmaclean@chromium.org>
1751
1752         [chromium] Make link highlighter use same node selection criteria as Chromium for Android.
1753         https://bugs.webkit.org/show_bug.cgi?id=95371
1754
1755         Reviewed by James Robinson.
1756
1757         This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.
1758
1759         * src/WebViewImpl.cpp:
1760         (WebKit::highlightConditions):
1761         (WebKit::WebViewImpl::bestTouchLinkNode):
1762         * tests/data/test_touch_link_highlight.html:
1763
1764 2012-08-31  James Robinson  <jamesr@chromium.org>
1765
1766         [chromium] Consolidate geometry unit testing functions for cc
1767         https://bugs.webkit.org/show_bug.cgi?id=95526
1768
1769         Reviewed by Julien Chaffraix.
1770
1771         This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
1772         testing rect equality.
1773
1774         * WebKit.gypi:
1775         * tests/CCDamageTrackerTest.cpp:
1776         (WebKitTests::TEST_F):
1777         * tests/CCGeometryTestUtils.cpp: Added.
1778         (WebKitTests):
1779         (WebKitTests::ExpectTransformationMatrixEq):
1780         * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
1781         (WebKit):
1782         (WebKitTests):
1783         * tests/CCLayerTreeHostTest.cpp:
1784         * tests/CCMathUtilTest.cpp:
1785         (WebKit::TEST):
1786         * tests/TiledLayerChromiumTest.cpp:
1787
1788 2012-08-31  James Robinson  <jamesr@chromium.org>
1789
1790         [chromium] Clean up Web*Layer initialization paths
1791         https://bugs.webkit.org/show_bug.cgi?id=95523
1792
1793         Reviewed by Darin Fisher.
1794
1795         Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
1796         implementation. Also normalizes naming conventions in these files.
1797
1798         * src/WebAnimationImpl.cpp:
1799         (WebKit::WebAnimation::create):
1800         (WebKit::WebAnimationImpl::WebAnimationImpl):
1801         * src/WebAnimationImpl.h:
1802         (WebAnimationImpl):
1803         * src/WebContentLayerImpl.cpp:
1804         (WebKit::WebContentLayerImpl::WebContentLayerImpl):
1805         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
1806         (WebKit::WebContentLayerImpl::layer):
1807         (WebKit::WebContentLayerImpl::setDoubleSided):
1808         (WebKit::WebContentLayerImpl::setContentsScale):
1809         (WebKit::WebContentLayerImpl::setUseLCDText):
1810         (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
1811         * src/WebContentLayerImpl.h:
1812         (WebContentLayerImpl):
1813         * src/WebFloatAnimationCurveImpl.cpp:
1814         (WebKit::WebFloatAnimationCurve::create):
1815         (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
1816         * src/WebFloatAnimationCurveImpl.h:
1817         (WebFloatAnimationCurveImpl):
1818         * src/WebIOSurfaceLayerImpl.cpp:
1819         (WebKit::WebIOSurfaceLayer::create):
1820         (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
1821         * src/WebIOSurfaceLayerImpl.h:
1822         (WebIOSurfaceLayerImpl):
1823         * src/WebImageLayerImpl.cpp:
1824         (WebKit::WebImageLayer::create):
1825         (WebKit::WebImageLayerImpl::WebImageLayerImpl):
1826         * src/WebImageLayerImpl.h:
1827         (WebImageLayerImpl):
1828         * src/WebLayerImpl.cpp:
1829         (WebKit::WebLayer::create):
1830         (WebKit):
1831         (WebKit::WebLayerImpl::WebLayerImpl):
1832         * src/WebLayerImpl.h:
1833         (WebLayerImpl):
1834         * src/WebScrollbarLayerImpl.cpp:
1835         (WebKit::WebScrollbarLayer::create):
1836         (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
1837         * src/WebScrollbarLayerImpl.h:
1838         (WebScrollbarLayerImpl):
1839         * src/WebSolidColorLayerImpl.cpp:
1840         (WebKit::WebSolidColorLayer::create):
1841         (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
1842         * src/WebSolidColorLayerImpl.h:
1843         (WebSolidColorLayerImpl):
1844         * src/WebTransformAnimationCurveImpl.cpp:
1845         (WebKit::WebTransformAnimationCurve::create):
1846         (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
1847         * src/WebTransformAnimationCurveImpl.h:
1848         (WebTransformAnimationCurveImpl):
1849         * src/WebVideoLayerImpl.cpp:
1850         (WebKit::WebVideoLayer::create):
1851         (WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
1852         * src/WebVideoLayerImpl.h:
1853         (WebVideoLayerImpl):
1854
1855 2012-08-31  Tony Chang  <tony@chromium.org>
1856
1857         Remove ENABLE_CSS3_FLEXBOX compile time flag
1858         https://bugs.webkit.org/show_bug.cgi?id=95382
1859
1860         Reviewed by Ojan Vafai.
1861
1862         Everyone is already enabling this by default and the spec has stablized.
1863
1864         * features.gypi:
1865
1866 2012-08-31  Christopher Cameron  <ccameron@chromium.org>
1867
1868         [chromium] Add main versus impl thread asserts
1869         https://bugs.webkit.org/show_bug.cgi?id=95596
1870
1871         Reviewed by James Robinson.
1872
1873         Add asserts to prioritized texture manager that specify that a
1874         function be called on the main or impl thread.
1875
1876         Add debug signs that the main thread is blocked to the threaded
1877         proxy.
1878
1879         Add a mechanism to simultaneously set the thread to the impl thread
1880         and indicate that the main thread is blocked.
1881
1882         Update tests that hit asserts in the prioritized texture manager to
1883         set their impl thread and main thread blocked state correctly.
1884
1885         * tests/CCPrioritizedTextureTest.cpp:
1886         (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
1887         (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
1888         (WTF::CCPrioritizedTextureTest::validateTexture):
1889         (WTF::TEST_F):
1890         * tests/TiledLayerChromiumTest.cpp:
1891
1892 2012-08-30  James Robinson  <jamesr@chromium.org>
1893
1894         [chromium] Put compositor client interfaces in separate headers, normalize naming
1895         https://bugs.webkit.org/show_bug.cgi?id=95522
1896
1897         Reviewed by Adam Barth.
1898
1899         * src/WebContentLayerImpl.cpp:
1900         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
1901         * src/WebContentLayerImpl.h:
1902         (WebContentLayerImpl):
1903         * src/WebExternalTextureLayerImpl.h:
1904         * src/WebLayerTreeViewImpl.h:
1905         (WebCore):
1906         * tests/CCLayerTreeHostCommonTest.cpp:
1907         * tests/CCLayerTreeHostTest.cpp:
1908         (WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
1909         (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
1910         (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
1911         (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
1912         (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
1913         (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
1914         (CCLayerTreeHostTestLostContextWhileUpdatingResources):
1915         * tests/ContentLayerChromiumTest.cpp:
1916         (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
1917         (WebKit::TEST):
1918
1919 2012-08-31  Gavin Peters  <gavinp@chromium.org>
1920
1921         [chromium] DEPS roll with a test skip.
1922         https://bugs.webkit.org/show_bug.cgi?id=95601
1923
1924         Unreviewed gardening & DEPS roll.
1925
1926
1927         fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)
1928
1929         * DEPS:
1930
1931 2012-08-31  Gavin Peters  <gavinp@chromium.org>
1932
1933         [chromium] Disable WebViewTest.AutoResizeMinimumSize
1934         https://bugs.webkit.org/show_bug.cgi?id=95571
1935
1936         Unreviewed gardening.
1937
1938         Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this.
1939
1940         * tests/WebViewTest.cpp:
1941
1942 2012-08-30  James Robinson  <jamesr@chromium.org>
1943
1944         [chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
1945         https://bugs.webkit.org/show_bug.cgi?id=95520
1946
1947         Reviewed by Darin Fisher.
1948
1949         Adopt the return value of WebCompositorSupport explicitly.
1950
1951         * src/LinkHighlight.cpp:
1952         (WebKit::LinkHighlight::LinkHighlight):
1953         (WebKit::LinkHighlight::startHighlightAnimation):
1954         * src/WebMediaPlayerClientImpl.cpp:
1955         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
1956         * src/WebPluginContainerImpl.cpp:
1957         (WebKit::WebPluginContainerImpl::setBackingTextureId):
1958         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
1959
1960 2012-08-30  James Robinson  <jamesr@chromium.org>
1961
1962         [chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
1963         https://bugs.webkit.org/show_bug.cgi?id=95401
1964
1965         Reviewed by Dirk Pranke.
1966
1967         If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere.
1968
1969         * WebKit.gyp:
1970         * WebKit.gypi:
1971         * WebKitUnitTests.gyp:
1972
1973 2012-08-27  James Robinson  <jamesr@chromium.org>
1974
1975         [chromium] Add CompositorSupport interface for constructing compositor classes
1976         https://bugs.webkit.org/show_bug.cgi?id=95040
1977
1978         Reviewed by Darin Fisher.
1979
1980         * src/LinkHighlight.cpp:
1981         (WebKit::LinkHighlight::LinkHighlight):
1982         (WebKit::LinkHighlight::startHighlightAnimation):
1983         * src/WebMediaPlayerClientImpl.cpp:
1984         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
1985         * src/WebMediaPlayerClientImpl.h:
1986         (WebKit):
1987         * src/WebPluginContainerImpl.cpp:
1988         (WebKit::WebPluginContainerImpl::setBackingTextureId):
1989         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
1990         * src/WebPluginContainerImpl.h:
1991         (WebKit):
1992
1993 2012-08-30  Gavin Peters  <gavinp@chromium.org>
1994
1995         [chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
1996         https://bugs.webkit.org/show_bug.cgi?id=95472
1997
1998         Unreviewed gardening.
1999
2000         When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue.
2001
2002         * tests/CCLayerTreeHostTest.cpp:
2003         (WebKitTests::TEST_F):
2004
2005 2012-08-30  James Robinson  <jamesr@chromium.org>
2006
2007         [chromium] Clean up some webkit compositor unit tests
2008         https://bugs.webkit.org/show_bug.cgi?id=95410
2009
2010         Reviewed by Adrienne Walker.
2011
2012         This adds includes that were implicitly being picked up, removes ones that weren't being used, removes
2013         dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style
2014         plugin is unhappy about.
2015
2016         * tests/CCAnimationTestCommon.cpp:
2017         (WebKitTests::FakeFloatAnimationCurve::duration):
2018         (WebKitTests):
2019         (WebKitTests::FakeFloatAnimationCurve::getValue):
2020         (WebKitTests::FakeTransformTransition::duration):
2021         (WebKitTests::FakeFloatTransition::duration):
2022         (WebKitTests::FakeLayerAnimationControllerClient::id):
2023         (WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
2024         (WebKitTests::FakeLayerAnimationControllerClient::opacity):
2025         (WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):
2026         (WebKitTests::FakeLayerAnimationControllerClient::transform):
2027         * tests/CCAnimationTestCommon.h:
2028         (FakeFloatAnimationCurve):
2029         (FakeTransformTransition):
2030         (FakeFloatTransition):
2031         (FakeLayerAnimationControllerClient):
2032         * tests/CCTiledLayerTestCommon.cpp:
2033         (WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
2034         (WebKitTests):
2035         (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
2036         (WebKitTests::FakeTiledLayerChromium::textureManager):
2037         (WebKitTests::FakeTiledLayerChromium::textureUpdater):
2038         (WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
2039         (WebKitTests::FakeTextureUploader::isBusy):
2040         (WebKitTests::FakeTextureUploader::uploadTexture):
2041         * tests/CCTiledLayerTestCommon.h:
2042         (FakeLayerTextureUpdater):
2043         (FakeTiledLayerChromium):
2044         (FakeTiledLayerWithScaledBounds):
2045         (FakeTextureUploader):
2046         * tests/FakeWebCompositorOutputSurface.h:
2047         * tests/TextureCopierTest.cpp:
2048         (MockContext):
2049         (TEST):
2050         * tests/ThrottledTextureUploaderTest.cpp:
2051         (WebKit::TEST):
2052         * tests/WebLayerTreeViewTest.cpp:
2053
2054 2012-08-29  Hironori Bono  <hbono@chromium.org>
2055
2056         Fix Chromium builds (Win and Mac)
2057         https://bugs.webkit.org/show_bug.cgi?id=95421
2058
2059         Reviewed by James Robinson.
2060
2061         This change replaces 'class WebRect' with 'struct WebRect' to fix build breaks
2062         on the "Chromium Mac Release" and the "Chromium Win Release" bot caused by
2063         r127095.
2064
2065         * public/WebViewClient.h:
2066         (WebKit):
2067
2068 2012-08-29  Nat Duca  <nduca@chromium.org>
2069
2070         [chromium] setNeedsAnimate should not cause commitRequested to become true
2071         https://bugs.webkit.org/show_bug.cgi?id=95393
2072
2073         Reviewed by James Robinson.
2074
2075         * tests/CCLayerTreeHostTest.cpp:
2076         (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
2077         (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
2078
2079 2012-08-29  Tien-Ren Chen  <trchen@chromium.org>
2080
2081         [chromium] Implement disambiguation popup (a.k.a. Link Preview)
2082         https://bugs.webkit.org/show_bug.cgi?id=94182
2083
2084         Reviewed by Adam Barth.
2085
2086         In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate.
2087         The disambiguation sequence will be initiated by the gesture event handler
2088         in WebViewImpl if an ambiguous tap is detected, then
2089         m_client->handleDisambiguationPopup will be called, so the embedder can
2090         decide whether to swallow the touch event and show a popup.
2091
2092         New test: WebFrameTest.DisambiguationPopupTest
2093
2094         * WebKit.gyp:
2095         * features.gypi:
2096         * public/WebInputEvent.h:
2097         (WebGestureEvent):
2098         (WebKit::WebGestureEvent::WebGestureEvent):
2099         * public/WebTouchCandidatesInfo.h: Removed.
2100         * public/WebView.h:
2101         (WebKit):
2102         * public/WebViewClient.h:
2103         (WebKit):
2104         (WebViewClient):
2105         (WebKit::WebViewClient::triggersLinkPreview):
2106         * src/WebInputEvent.cpp:
2107         (SameSizeAsWebGestureEvent):
2108         * src/WebViewImpl.cpp:
2109         (WebKit):
2110         (WebKit::WebViewImpl::handleGestureEventWithLinkPreview):
2111         (WebKit::WebViewImpl::handleGestureEvent):
2112         * src/WebViewImpl.h:
2113         (WebViewImpl):
2114
2115 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2116
2117         AX: Canvas should have a distinct role
2118         https://bugs.webkit.org/show_bug.cgi?id=95248
2119
2120         Reviewed by Chris Fleizach.
2121
2122         Add support for canvas accessibility role.
2123
2124         * public/WebAccessibilityRole.h:
2125         * src/AssertMatchingEnums.cpp:
2126
2127 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
2128
2129         [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order
2130         https://bugs.webkit.org/show_bug.cgi?id=94828
2131
2132         Reviewed by Adrienne Walker.
2133
2134         Testing that setDeviceScaleFactor properly changes maxScrollPosition
2135
2136         * tests/CCLayerTreeHostImplTest.cpp:
2137
2138 2012-08-29  James Robinson  <jamesr@chromium.org>
2139
2140         Unreviewed, rolling out r126956.
2141         http://trac.webkit.org/changeset/126956
2142         https://bugs.webkit.org/show_bug.cgi?id=94721
2143
2144         Breaks several unit tests
2145
2146         * tests/CCSchedulerTest.cpp:
2147         (WebKitTests::FakeCCSchedulerClient::reset):
2148         (WebKitTests::FakeCCSchedulerClient::setHasMoreResourceUpdates):
2149         (WebKitTests::TEST):
2150         * tests/CCTextureUpdateControllerTest.cpp:
2151
2152 2012-08-29  James Robinson  <jamesr@chromium.org>
2153
2154         [chromium] Register/unregister contents layers with GraphicsLayerChromium
2155         https://bugs.webkit.org/show_bug.cgi?id=95379
2156
2157         Reviewed by Adrienne Walker.
2158
2159         * src/WebMediaPlayerClientImpl.cpp:
2160         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
2161         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
2162         * src/WebPluginContainerImpl.cpp:
2163         (WebKit::WebPluginContainerImpl::setBackingTextureId):
2164         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
2165         (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
2166
2167 2012-08-29  W. James MacLean  <wjmaclean@chromium.org>
2168
2169         [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.
2170         https://bugs.webkit.org/show_bug.cgi?id=95119
2171
2172         Reviewed by Adam Barth.
2173
2174         Add support to WebSettings for flag to enable/disable gesture tap highlights. Relies on existing tests.
2175
2176         * public/WebSettings.h:
2177         * src/WebSettingsImpl.cpp:
2178         (WebKit::WebSettingsImpl::WebSettingsImpl):
2179         (WebKit::WebSettingsImpl::setGestureTapHighlightEnabled):
2180         (WebKit):
2181         * src/WebSettingsImpl.h:
2182         (WebSettingsImpl):
2183         (WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
2184         * src/WebViewImpl.cpp:
2185         (WebKit::WebViewImpl::handleGestureEvent):
2186
2187 2012-08-29  Dana Jansens  <danakj@chromium.org>
2188
2189         [chromium] Remove HUD layer when rootLayer is set to null
2190         https://bugs.webkit.org/show_bug.cgi?id=95257
2191
2192         Reviewed by James Robinson.
2193
2194         * WebKit.gypi:
2195         * tests/CCHeadsUpDisplayTest.cpp: Added.
2196         (CCHeadsUpDisplayTest):
2197         (DrawsContentLayerChromium):
2198         (DrawsContentLayerChromium::create):
2199         (DrawsContentLayerChromium::DrawsContentLayerChromium):
2200         (CCHudWithRootLayerChange):
2201         (CCHudWithRootLayerChange::CCHudWithRootLayerChange):
2202         (TEST_F):
2203         * tests/CCLayerTreeHostTest.cpp:
2204         * tests/CCThreadedTest.cpp:
2205         (WebKitTests::CCThreadedTest::runTest):
2206         * tests/CCThreadedTest.h:
2207         (WebKitTests::CCThreadedTest::initializeSettings):
2208         (CCThreadedTest):
2209
2210 2012-08-29  Shawn Singh  <shawnsingh@chromium.org>
2211
2212         [chromium] Add more unit test coverage for semantics of drawableContentRect and visibleContentRect
2213         https://bugs.webkit.org/show_bug.cgi?id=94542
2214
2215         Reviewed by Adrienne Walker.
2216
2217         To make upcoming refactors safer, it was appropriate to (finally)
2218         add unit tests that check the behavior of drawableContentRect and
2219         visibleContentRect computations in calculateDrawTransforms.
2220
2221         * tests/CCLayerTreeHostCommonTest.cpp:
2222
2223 2012-08-29  W. James MacLean  <wjmaclean@chromium.org>
2224
2225         [chromium] Link highlight should clear on page navigation.
2226         https://bugs.webkit.org/show_bug.cgi?id=95129
2227
2228         Reviewed by James Robinson.
2229
2230         Modified WebViewImpl to clear link highlight when navigating to new url.
2231
2232         * src/WebViewImpl.cpp:
2233         (WebKit::WebViewImpl::didCommitLoad):
2234
2235 2012-08-29  James Robinson  <jamesr@chromium.org>
2236
2237         [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
2238         https://bugs.webkit.org/show_bug.cgi?id=94995
2239
2240         Reviewed by Adam Barth.
2241
2242         * WebKit.gyp:
2243
2244 2012-08-28  Shawn Singh  <shawnsingh@chromium.org>
2245
2246         [chromium] Do not clip root layer's subtree to viewport
2247         https://bugs.webkit.org/show_bug.cgi?id=95235
2248
2249         Reviewed by Adrienne Walker.
2250
2251         Existing tests updated, and otherwise this change is already
2252         covered by layout and unit tests.
2253
2254         * tests/CCLayerTreeHostCommonTest.cpp:
2255         * tests/CCOcclusionTrackerTest.cpp:
2256         (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
2257         (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
2258         (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
2259         (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
2260         (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
2261         (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
2262         (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
2263         (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
2264         (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
2265         (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
2266
2267 2012-08-29  Julien Chaffraix  <jchaffraix@webkit.org>
2268
2269         [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions
2270         https://bugs.webkit.org/show_bug.cgi?id=95358
2271
2272         Unreviewed gardening.
2273
2274         * tests/CCLayerTreeHostTest.cpp:
2275         Disabled the test until it is fixed.
2276
2277 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2278
2279         Unreviewed, rolling out r126972.
2280         http://trac.webkit.org/changeset/126972
2281         https://bugs.webkit.org/show_bug.cgi?id=95349
2282
2283         accessibility/canvas-description-and-role.html has been
2284         failing consistently on several bots and Dominic needs some
2285         time to investigate why (Requested by jchaffraix on #webkit).
2286
2287         * public/WebAccessibilityRole.h:
2288         * src/AssertMatchingEnums.cpp:
2289
2290 2012-08-29  Peter Beverloo  <peter@chromium.org>
2291
2292         Unreviewed.  Rolled DEPS.
2293
2294         * DEPS:
2295
2296 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2297
2298         AX: Canvas should have a distinct role
2299         https://bugs.webkit.org/show_bug.cgi?id=95248
2300
2301         Reviewed by Chris Fleizach.
2302
2303         Add support for canvas accessibility role.
2304
2305         * public/WebAccessibilityRole.h:
2306         * src/AssertMatchingEnums.cpp:
2307
2308 2012-08-28  David Reveman  <reveman@chromium.org>
2309
2310         [Chromium] Scheduler will never process a commit until it receives a vsync tick.
2311         https://bugs.webkit.org/show_bug.cgi?id=94721
2312
2313         Reviewed by James Robinson.
2314
2315         * tests/CCSchedulerTest.cpp:
2316         (WebKitTests::FakeCCSchedulerClient::reset):
2317         (WebKitTests::TEST):
2318         * tests/CCTextureUpdateControllerTest.cpp:
2319
2320 2012-08-28  Adam Barth  <abarth@webkit.org>
2321
2322         Fix ASSERT in fast/events/touch/gesture/context-menu-on-two-finger-tap.html
2323
2324         * src/WebViewImpl.cpp:
2325         (WebKit::WebViewImpl::detectContentOnTouch):
2326
2327 2012-08-28  Leandro Gracia Gil  <leandrogracia@chromium.org>
2328
2329         Content detection should not disrupt the page behaviour
2330         https://bugs.webkit.org/show_bug.cgi?id=94727
2331
2332         Reviewed by Adam Barth.
2333
2334         Triggers content detection in the embedder on tap gestures and
2335         add checks for the appropriate event listeners in order to prevent
2336         triggering content detection when it would disrupt the page's behaviour.
2337
2338         * src/WebViewImpl.cpp:
2339         (WebKit::WebViewImpl::handleGestureEvent):
2340         (WebKit::WebViewImpl::detectContentOnTouch):
2341         * tests/WebViewTest.cpp:
2342         * tests/data/content_listeners.html: Added.
2343
2344 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2345
2346         Unreviewed, rolling out r126933.
2347         http://trac.webkit.org/changeset/126933
2348         https://bugs.webkit.org/show_bug.cgi?id=95261
2349
2350         Turns out we do need this! (Requested by abarth on #webkit).
2351
2352         * public/WebWidget.h:
2353         (WebKit::WebWidget::paint):
2354         * src/WebPagePopupImpl.cpp:
2355         (WebKit::WebPagePopupImpl::paint):
2356         * src/WebPagePopupImpl.h:
2357         (WebPagePopupImpl):
2358         * src/WebPopupMenuImpl.cpp:
2359         (WebKit::WebPopupMenuImpl::paint):
2360         * src/WebPopupMenuImpl.h:
2361         * src/WebViewImpl.cpp:
2362         (WebKit::WebViewImpl::paint):
2363         * src/WebViewImpl.h:
2364         (WebViewImpl):
2365
2366 2012-08-28  Mark Pilgrim  <pilgrim@chromium.org>
2367
2368         [Chromium] Remove decodeAudioFileData from PlatformSupport
2369         https://bugs.webkit.org/show_bug.cgi?id=95250
2370
2371         Reviewed by Adam Barth.
2372
2373         Part of a refactoring series. See tracking bug 82948.
2374
2375         * src/PlatformSupport.cpp:
2376         (WebCore):
2377
2378 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2379
2380         Unreviewed, rolling out r126344.
2381         http://trac.webkit.org/changeset/126344
2382         https://bugs.webkit.org/show_bug.cgi?id=95253
2383
2384         This change is no longer needed (Requested by abarth on
2385         #webkit).
2386
2387         * public/WebWidget.h:
2388         (WebKit::WebWidget::paint):
2389         * src/WebPagePopupImpl.cpp:
2390         (WebKit::WebPagePopupImpl::paint):
2391         * src/WebPagePopupImpl.h:
2392         (WebPagePopupImpl):
2393         * src/WebPopupMenuImpl.cpp:
2394         (WebKit::WebPopupMenuImpl::paint):
2395         * src/WebPopupMenuImpl.h:
2396         * src/WebViewImpl.cpp:
2397         (WebKit::WebViewImpl::paint):
2398         * src/WebViewImpl.h:
2399         (WebViewImpl):
2400
2401 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
2402
2403         AX: Crash due to object getting deleted inside updateBackingStore
2404         https://bugs.webkit.org/show_bug.cgi?id=94619
2405
2406         Reviewed by Chris Fleizach.
2407
2408         Chromium now calls updateBackingStoreAndCheckValidity explicitly,
2409         so we can now get rid of calls to updateBackingStore in the
2410         method implementations, and just make sure we're checking isDetached.
2411
2412         * public/WebAccessibilityObject.h:
2413         (WebAccessibilityObject):
2414         * src/WebAccessibilityObject.cpp:
2415         (WebKit::WebAccessibilityObject::axID):
2416         (WebKit::WebAccessibilityObject::accessibilityDescription):
2417         (WebKit::WebAccessibilityObject::actionVerb):
2418         (WebKit::WebAccessibilityObject::canSetFocusAttribute):
2419         (WebKit::WebAccessibilityObject::canSetValueAttribute):
2420         (WebKit::WebAccessibilityObject::childCount):
2421         (WebKit::WebAccessibilityObject::childAt):
2422         (WebKit::WebAccessibilityObject::firstChild):
2423         (WebKit::WebAccessibilityObject::focusedChild):
2424         (WebKit::WebAccessibilityObject::lastChild):
2425         (WebKit::WebAccessibilityObject::nextSibling):
2426         (WebKit::WebAccessibilityObject::parentObject):
2427         (WebKit::WebAccessibilityObject::previousSibling):
2428         (WebKit::WebAccessibilityObject::canSetSelectedAttribute):
2429         (WebKit::WebAccessibilityObject::isAnchor):
2430         (WebKit::WebAccessibilityObject::isAriaReadOnly):
2431         (WebKit::WebAccessibilityObject::isButtonStateMixed):
2432         (WebKit::WebAccessibilityObject::isChecked):
2433         (WebKit::WebAccessibilityObject::isCollapsed):
2434         (WebKit::WebAccessibilityObject::isControl):
2435         (WebKit::WebAccessibilityObject::isEnabled):
2436         (WebKit::WebAccessibilityObject::isFocused):
2437         (WebKit::WebAccessibilityObject::isHovered):
2438         (WebKit::WebAccessibilityObject::isIndeterminate):
2439         (WebKit::WebAccessibilityObject::isLinked):
2440         (WebKit::WebAccessibilityObject::isLoaded):
2441         (WebKit::WebAccessibilityObject::isMultiSelectable):
2442         (WebKit::WebAccessibilityObject::isOffScreen):
2443         (WebKit::WebAccessibilityObject::isPasswordField):
2444         (WebKit::WebAccessibilityObject::isPressed):
2445         (WebKit::WebAccessibilityObject::isReadOnly):
2446         (WebKit::WebAccessibilityObject::isRequired):
2447         (WebKit::WebAccessibilityObject::isSelected):
2448         (WebKit::WebAccessibilityObject::isSelectedOptionActive):
2449         (WebKit::WebAccessibilityObject::isVertical):
2450         (WebKit::WebAccessibilityObject::isVisible):
2451         (WebKit::WebAccessibilityObject::isVisited):
2452         (WebKit::WebAccessibilityObject::accessKey):
2453         (WebKit::WebAccessibilityObject::ariaHasPopup):
2454         (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
2455         (WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
2456         (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
2457         (WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
2458         (WebKit::WebAccessibilityObject::boundingBoxRect):
2459         (WebKit::WebAccessibilityObject::estimatedLoadingProgress):
2460         (WebKit::WebAccessibilityObject::helpText):
2461         (WebKit::WebAccessibilityObject::headingLevel):
2462         (WebKit::WebAccessibilityObject::hierarchicalLevel):
2463         (WebKit::WebAccessibilityObject::hitTest):
2464         (WebKit::WebAccessibilityObject::keyboardShortcut):
2465         (WebKit::WebAccessibilityObject::performDefaultAction):
2466         (WebKit::WebAccessibilityObject::roleValue):
2467         (WebKit::WebAccessibilityObject::selectionEnd):
2468         (WebKit::WebAccessibilityObject::selectionStart):
2469         (WebKit::WebAccessibilityObject::stringValue):
2470         (WebKit::WebAccessibilityObject::title):
2471         (WebKit::WebAccessibilityObject::titleUIElement):
2472         (WebKit::WebAccessibilityObject::url):
2473         (WebKit::WebAccessibilityObject::valueDescription):
2474         (WebKit::WebAccessibilityObject::valueForRange):
2475         (WebKit::WebAccessibilityObject::maxValueForRange):
2476         (WebKit::WebAccessibilityObject::minValueForRange):
2477         (WebKit::WebAccessibilityObject::node):
2478         (WebKit::WebAccessibilityObject::document):
2479         (WebKit::WebAccessibilityObject::accessibilityIsIgnored):
2480         (WebKit::WebAccessibilityObject::lineBreaks):
2481         (WebKit::WebAccessibilityObject::columnCount):
2482         (WebKit::WebAccessibilityObject::rowCount):
2483         (WebKit::WebAccessibilityObject::cellForColumnAndRow):
2484         (WebKit::WebAccessibilityObject::cellColumnIndex):
2485         (WebKit::WebAccessibilityObject::cellColumnSpan):
2486         (WebKit::WebAccessibilityObject::cellRowIndex):
2487         (WebKit::WebAccessibilityObject::cellRowSpan):
2488         (WebKit::WebAccessibilityObject::scrollToMakeVisible):
2489         (WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
2490         (WebKit::WebAccessibilityObject::scrollToGlobalPoint):
2491
2492 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2493
2494         Unreviewed, rolling out r126914.
2495         http://trac.webkit.org/changeset/126914
2496         https://bugs.webkit.org/show_bug.cgi?id=95239
2497
2498         it breaks everything and fixes nothing (Requested by pizlo on
2499         #webkit).
2500
2501         * src/WebGeolocationPermissionRequestManager.cpp:
2502         (WebGeolocationPermissionRequestManager::remove):
2503         * src/WebIDBMetadata.cpp:
2504         (WebKit::WebIDBMetadata::WebIDBMetadata):
2505         * src/WebIntent.cpp:
2506         (WebKit::WebIntent::extrasValue):
2507         * tests/WebSocketExtensionDispatcherTest.cpp:
2508         (WebCore::TEST_F):
2509
2510 2012-08-28  W. James MacLean  <wjmaclean@chromium.org>
2511
2512         [unreviewed] Compile fix: windows compiler expects float but find double.
2513  
2514         Need to specify a float literal when initialising the highlight animation duration.
2515  
2516         * src/LinkHighlight.cpp:
2517         (WebKit::LinkHighlight::startHighlightAnimation):
2518
2519 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2520
2521         Rename first/second to key/value in HashMap iterators
2522         https://bugs.webkit.org/show_bug.cgi?id=82784
2523
2524         Reviewed by Eric Seidel.
2525
2526         * src/WebGeolocationPermissionRequestManager.cpp:
2527         (WebGeolocationPermissionRequestManager::remove):
2528         * src/WebIDBMetadata.cpp:
2529         (WebKit::WebIDBMetadata::WebIDBMetadata):
2530         * src/WebIntent.cpp:
2531         (WebKit::WebIntent::extrasValue):
2532         * tests/WebSocketExtensionDispatcherTest.cpp:
2533         (WebCore::TEST_F):
2534
2535 2012-08-28  W. James MacLean  <wjmaclean@chromium.org>
2536
2537         [chromium] Drastically shorten the link highlight duration.
2538         https://bugs.webkit.org/show_bug.cgi?id=95216
2539
2540         Reviewed by James Robinson.
2541
2542         Parameter change; covered by existing layout tests.
2543
2544         * src/LinkHighlight.cpp:
2545         (WebKit::LinkHighlight::startHighlightAnimation):
2546
2547 2012-08-27  Tien-Ren Chen  <trchen@chromium.org>
2548
2549         [Chromium] Remove stub for WebView::getTouchHighlightQuads()
2550         https://bugs.webkit.org/show_bug.cgi?id=95164
2551
2552         Reviewed by Adam Barth.
2553
2554         Reverts https://bugs.webkit.org/show_bug.cgi?id=92997
2555         We're uploading a new implementation that no longer uses this API.
2556         See https://bugs.webkit.org/show_bug.cgi?id=94182
2557
2558         * WebKit.gyp:
2559         * public/WebTouchCandidatesInfo.h: Removed.
2560         * public/WebView.h:
2561         (WebKit):
2562         * src/WebViewImpl.cpp:
2563         * src/WebViewImpl.h:
2564         (WebViewImpl):
2565
2566 2012-08-27  Ian Vollick  <vollick@chromium.org>
2567
2568         [chromium] Should accelerate rotations of >= 180 degrees
2569         https://bugs.webkit.org/show_bug.cgi?id=94860
2570
2571         Reviewed by James Robinson.
2572
2573         Added new unit tests:
2574           WebTransformOperationTest.transformTypesAreUnique
2575           WebTransformOperationTest.matchTypesSameLength
2576           WebTransformOperationTest.identityAlwaysMatches
2577           WebTransformOperationTest.largeRotationsWithSameAxis
2578           WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection
2579           WebTransformOperationTest.largeRotationsWithDifferentAxes
2580           WebTransformOperationTest.blendRotationFromIdentity
2581           WebTransformOperationTest.blendTranslationFromIdentity
2582           WebTransformOperationTest.blendScaleFromIdentity
2583           WebTransformOperationTest.blendSkewFromIdentity
2584           WebTransformOperationTest.blendPerspectiveFromIdentity
2585           WebTransformOperationTest.blendRotationToIdentity
2586           WebTransformOperationTest.blendTranslationToIdentity
2587           WebTransformOperationTest.blendScaleToIdentity
2588           WebTransformOperationTest.blendSkewToIdentity
2589           WebTransformOperationTest.blendPerspectiveToIdentity
2590           AnimationTranslationUtilTest.createTransformAnimationWithBigRotation
2591           AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList
2592
2593         * tests/AnimationTranslationUtilTest.cpp:
2594         (WebKit::TEST):
2595         * tests/WebTransformOperationsTest.cpp:
2596         (TEST):
2597         (getIdentityOperations):
2598
2599 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2600
2601         Unreviewed, rolling out r126836.
2602         http://trac.webkit.org/changeset/126836
2603         https://bugs.webkit.org/show_bug.cgi?id=95163
2604
2605         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
2606         #webkit).
2607
2608         * src/WebGeolocationPermissionRequestManager.cpp:
2609         (WebGeolocationPermissionRequestManager::remove):
2610         * src/WebIDBMetadata.cpp:
2611         (WebKit::WebIDBMetadata::WebIDBMetadata):
2612         * src/WebIntent.cpp:
2613         (WebKit::WebIntent::extrasValue):
2614         * tests/WebSocketExtensionDispatcherTest.cpp:
2615         (WebCore::TEST_F):
2616
2617 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2618
2619         Rename first/second to key/value in HashMap iterators
2620         https://bugs.webkit.org/show_bug.cgi?id=82784
2621
2622         Reviewed by Eric Seidel.
2623
2624         * src/WebGeolocationPermissionRequestManager.cpp:
2625         (WebGeolocationPermissionRequestManager::remove):
2626         * src/WebIDBMetadata.cpp:
2627         (WebKit::WebIDBMetadata::WebIDBMetadata):
2628         * src/WebIntent.cpp:
2629         (WebKit::WebIntent::extrasValue):
2630         * tests/WebSocketExtensionDispatcherTest.cpp:
2631         (WebCore::TEST_F):
2632
2633 2012-08-27  David Reveman  <reveman@chromium.org>
2634
2635         [Chromium] Stop texture updates when context is lost.
2636         https://bugs.webkit.org/show_bug.cgi?id=94983
2637
2638         Reviewed by James Robinson.
2639
2640         * tests/CCLayerTreeHostTest.cpp:
2641         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
2642         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create):
2643         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::setContextLostCallback):
2644         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::isContextLost):
2645         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::beginQueryEXT):
2646         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::endQueryEXT):
2647         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::getQueryObjectuivEXT):
2648         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
2649         (CCLayerTreeHostTestLostContextWhileUpdatingResources):
2650         (CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
2651         (CCLayerTreeHostTestLostContextWhileUpdatingResources::createOutputSurface):
2652         (CCLayerTreeHostTestLostContextWhileUpdatingResources::beginTest):
2653         (CCLayerTreeHostTestLostContextWhileUpdatingResources::commitCompleteOnCCThread):
2654         (CCLayerTreeHostTestLostContextWhileUpdatingResources::layout):
2655         (CCLayerTreeHostTestLostContextWhileUpdatingResources::afterTest):
2656         (TEST_F):
2657
2658 2012-08-27  Dana Jansens  <danakj@chromium.org>
2659
2660         [chromium] A general mechanism for passing data into and out of appendQuads and quadCuller via CCAppendQuadsData
2661         https://bugs.webkit.org/show_bug.cgi?id=95109
2662
2663         Reviewed by Adrienne Walker.
2664
2665         Update tests to use the new data structure.
2666
2667         * tests/CCLayerTreeHostImplTest.cpp:
2668         * tests/CCLayerTreeHostTest.cpp:
2669         * tests/CCQuadCullerTest.cpp:
2670         * tests/CCRenderSurfaceTest.cpp:
2671         * tests/CCSolidColorLayerImplTest.cpp:
2672         (CCLayerTestCommon::TEST):
2673         * tests/CCTiledLayerImplTest.cpp:
2674         (CCLayerTestCommon::TEST):
2675         (CCLayerTestCommon::getQuads):
2676         * tests/MockCCQuadCuller.h:
2677
2678 2012-08-24  James Robinson  <jamesr@chromium.org>
2679
2680         [chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
2681         https://bugs.webkit.org/show_bug.cgi?id=94996
2682
2683         Reviewed by Adrienne Walker.
2684
2685         Fix up tests for API changes.
2686
2687         * WebKit.gyp:
2688         * src/WebScrollbarLayerImpl.cpp:
2689         (WebKit::WebScrollbarLayer::create):
2690         * tests/ScrollbarLayerChromiumTest.cpp:
2691         (WebCore::TEST):
2692
2693 2012-08-27  Adrienne Walker  <enne@google.com>
2694
2695         [chromium] Prevent scrollbar thumb size from changing during compositor zoom
2696         https://bugs.webkit.org/show_bug.cgi?id=94859
2697
2698         Reviewed by James Robinson.
2699
2700         Update test.
2701
2702         * tests/CCLayerTreeHostImplTest.cpp:
2703
2704 2012-08-27  Dana Jansens  <danakj@chromium.org>
2705
2706         [chromium] Have RenderSurface create and add its own generated RenderPass
2707         https://bugs.webkit.org/show_bug.cgi?id=94957
2708
2709         Reviewed by Adrienne Walker.
2710
2711         Test that a RenderSurface generates the RenderPass that we expect.
2712
2713         * tests/CCRenderSurfaceTest.cpp:
2714
2715 2012-08-27  Justin Novosad  <junov@chromium.org>
2716
2717         [Chromium] Fixing infinite recursion in Canvas2DLayerManager
2718         https://bugs.webkit.org/show_bug.cgi?id=95110
2719
2720         Reviewed by Stephen White.
2721
2722         Breaking recursion cycle by not reporting a change in memory allocation
2723         when no memory is freed in FakeCanvas2DLayer::freeMemoryIfPossible.
2724
2725         * tests/Canvas2DLayerManagerTest.cpp:
2726
2727 2012-08-27  Justin Novosad  <junov@chromium.org>
2728
2729         [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
2730         https://bugs.webkit.org/show_bug.cgi?id=94386
2731
2732         Reviewed by Stephen White.
2733
2734         Adding unit tests for WebCore::Canvas2DLayerManager
2735
2736         * WebKit.gypi:
2737
2738 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2739
2740         Unreviewed.  Rolled DEPS.
2741
2742         * DEPS:
2743
2744 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2745
2746         Rename RegisterProtocolHandler API to NavigatorContentUtils
2747         https://bugs.webkit.org/show_bug.cgi?id=94920
2748
2749         Reviewed by Adam Barth.
2750
2751         Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
2752         RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl.
2753
2754         * features.gypi:
2755         * src/ChromeClientImpl.cpp:
2756         (WebKit):
2757         (WebKit::NavigatorContentUtilsClientImpl::create):
2758         (WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl):
2759         (WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler):
2760         * src/ChromeClientImpl.h:
2761         (NavigatorContentUtilsClientImpl):
2762         (WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl):
2763         * src/WebViewImpl.cpp:
2764         (WebKit::WebViewImpl::WebViewImpl):
2765         * src/WebViewImpl.h:
2766
2767 2012-08-27  Johnny Ding  <jnd@chromium.org>
2768
2769         [Chromium-Android]Move webkit_unit_tests_apk and TestWebKitAPI_apk into a
2770         condition block:['OS=="android" and gtest_target_type == "shared_library"'].
2771         https://bugs.webkit.org/show_bug.cgi?id=95049
2772
2773         Reviewed by Adam Barth.
2774
2775         Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"
2776
2777         * All.gyp:
2778
2779 2012-08-24  Dominic Mazzoni  <dmazzoni@google.com>
2780
2781         Chromium: WebAccessibilityObject should expose updateBackingStore
2782         https://bugs.webkit.org/show_bug.cgi?id=94611
2783
2784         Reviewed by Chris Fleizach.
2785
2786         This change just exposes a method, with no new tests. Next, Chromium
2787         will be modified to call this new method, and this will be followed
2788         by a change that gets rid of calls to updateBackingStore under the
2789         hood. That last change may add a test or update an existing test.
2790
2791         * public/WebAccessibilityObject.h:
2792         (WebAccessibilityObject):
2793         * src/WebAccessibilityObject.cpp:
2794         (WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity):
2795         (WebKit):
2796
2797 2012-08-24  W. James MacLean  <wjmaclean@chromium.org>
2798
2799         [chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked.
2800         https://bugs.webkit.org/show_bug.cgi?id=94978
2801
2802         Reviewed by James Robinson.
2803
2804         Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new
2805         highlight target is found.
2806
2807         * src/WebViewImpl.cpp:
2808         (WebKit::WebViewImpl::enableTouchHighlight):
2809
2810 2012-08-23  James Robinson  <jamesr@chromium.org>
2811
2812         [chromium] Convert WebLayerTreeView interface into pure virtual
2813         https://bugs.webkit.org/show_bug.cgi?id=94866
2814
2815         Reviewed by Adrienne Walker.
2816
2817         Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper
2818         stuff can just go away now since downstream has updated to createOutputSurface().
2819
2820         * WebKit.gypi:
2821         * src/WebLayerTreeView.cpp: Removed.
2822         * src/WebLayerTreeViewImpl.cpp:
2823         (WebKit::WebLayerTreeView::create):
2824         (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
2825         (WebKit::WebLayerTreeViewImpl::initialize):
2826         (WebKit):
2827         (WebKit::WebLayerTreeViewImpl::setSurfaceReady):
2828         (WebKit::WebLayerTreeViewImpl::setRootLayer):
2829         (WebKit::WebLayerTreeViewImpl::clearRootLayer):
2830         (WebKit::WebLayerTreeViewImpl::compositorIdentifier):
2831         (WebKit::WebLayerTreeViewImpl::setViewportSize):
2832         (WebKit::WebLayerTreeViewImpl::layoutViewportSize):
2833         (WebKit::WebLayerTreeViewImpl::deviceViewportSize):
2834         (WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor):
2835         (WebKit::WebLayerTreeViewImpl::deviceScaleFactor):
2836         (WebKit::WebLayerTreeViewImpl::setBackgroundColor):
2837         (WebKit::WebLayerTreeViewImpl::setHasTransparentBackground):
2838         (WebKit::WebLayerTreeViewImpl::setVisible):
2839         (WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits):
2840         (WebKit::WebLayerTreeViewImpl::startPageScaleAnimation):
2841         (WebKit::WebLayerTreeViewImpl::setNeedsAnimate):
2842         (WebKit::WebLayerTreeViewImpl::setNeedsRedraw):
2843         (WebKit::WebLayerTreeViewImpl::commitRequested):
2844         (WebKit::WebLayerTreeViewImpl::composite):
2845         (WebKit::WebLayerTreeViewImpl::updateAnimations):
2846         (WebKit::WebLayerTreeViewImpl::compositeAndReadback):
2847         (WebKit::WebLayerTreeViewImpl::finishAllRendering):
2848         (WebKit::WebLayerTreeViewImpl::renderingStats):
2849         (WebKit::WebLayerTreeViewImpl::setFontAtlas):
2850         (WebKit::WebLayerTreeViewImpl::loseCompositorContext):
2851         (WebKit::WebLayerTreeViewImpl::willBeginFrame):
2852         (WebKit::WebLayerTreeViewImpl::didBeginFrame):
2853         (WebKit::WebLayerTreeViewImpl::animate):
2854         (WebKit::WebLayerTreeViewImpl::layout):
2855         (WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
2856         (WebKit::WebLayerTreeViewImpl::createOutputSurface):
2857         (WebKit::WebLayerTreeViewImpl::didRecreateOutputSurface):
2858         (WebKit::WebLayerTreeViewImpl::willCommit):
2859         (WebKit::WebLayerTreeViewImpl::didCommit):
2860         (WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
2861         (WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
2862         (WebKit::WebLayerTreeViewImpl::scheduleComposite):
2863         * src/WebLayerTreeViewImpl.h:
2864         (WebLayerTreeViewImpl):
2865         * src/WebViewImpl.cpp:
2866         (WebKit::WebViewImpl::renderingStats):
2867         (WebKit::WebViewImpl::startPageScaleAnimation):
2868         (WebKit::WebViewImpl::setCompositorSurfaceReady):
2869         (WebKit::WebViewImpl::animate):
2870         (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2871         (WebKit::WebViewImpl::paint):
2872         (WebKit::WebViewImpl::composite):
2873         (WebKit::WebViewImpl::setNeedsRedraw):
2874         (WebKit::WebViewImpl::isInputThrottled):
2875         (WebKit::WebViewImpl::loseCompositorContext):
2876         (WebKit::WebViewImpl::setDeviceScaleFactor):
2877         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2878         (WebKit::WebViewImpl::setIsTransparent):
2879         (WebKit::WebViewImpl::setRootGraphicsLayer):
2880         (WebKit::WebViewImpl::scheduleCompositingLayerSync):
2881         (WebKit::WebViewImpl::invalidateRootLayerRect):
2882         (WebKit::WebViewImpl::setBackgroundColor):
2883         (WebKit::WebViewImpl::scheduleAnimation):
2884         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2885         (WebKit):
2886         (WebKit::WebViewImpl::updateLayerTreeViewport):
2887         (WebKit::WebViewImpl::setVisibilityState):
2888         * src/WebViewImpl.h:
2889         (WebKit):
2890         * tests/CCLayerTreeHostTest.cpp:
2891         * tests/CCThreadedTest.cpp:
2892         * tests/CCThreadedTest.h:
2893         (WebKitTests::TestHooks::animate):
2894         * tests/FakeCCLayerTreeHostClient.h:
2895         * tests/GraphicsLayerChromiumTest.cpp:
2896         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2897         (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
2898         (GraphicsLayerChromiumTest):
2899         * tests/WebLayerTest.cpp:
2900         * tests/WebLayerTreeViewTest.cpp:
2901         * tests/WebLayerTreeViewTestCommon.h:
2902         (MockWebLayerTreeViewClient):
2903
2904 2012-08-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2905
2906         Unreviewed.  Rolled DEPS.
2907
2908         * DEPS:
2909
2910 2012-08-24  James Robinson  <jamesr@chromium.org>
2911
2912         [chromium] Clean up WebAnimation animationId/groupId generation
2913         https://bugs.webkit.org/show_bug.cgi?id=94973
2914
2915         Reviewed by Adrienne Walker.
2916
2917         * src/WebAnimationImpl.cpp:
2918         (WebKit::WebAnimation::create):
2919         (WebKit::WebAnimationImpl::WebAnimationImpl):
2920         (WebKit::WebAnimationImpl::id):
2921         (WebKit):
2922         * src/WebAnimationImpl.h:
2923         (WebAnimationImpl):
2924         * tests/AnimationTranslationUtilTest.cpp:
2925         (WebKit::animationCanBeTranslated):
2926         * tests/GraphicsLayerChromiumTest.cpp:
2927         (WebKit::TEST_F):
2928
2929 2012-08-24  Mark Pilgrim  <pilgrim@chromium.org>
2930
2931         [Chromium] Remove visitedLinkHash from PlatformSupport
2932         https://bugs.webkit.org/show_bug.cgi?id=94965
2933
2934         Reviewed by Adam Barth.
2935
2936         Part of a refactoring series. See tracking bug 82948.
2937
2938         * src/PlatformSupport.cpp:
2939         (WebCore):
2940
2941 2012-08-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2942
2943         Unreviewed, rolling out r126620.
2944         http://trac.webkit.org/changeset/126620
2945         https://bugs.webkit.org/show_bug.cgi?id=94976
2946
2947         ASSERT((intptr_t)m_bytesAllocated + deltaBytes > 0) is
2948         triggering on the bots (Requested by jchaffraix on #webkit).
2949
2950         * WebKit.gypi:
2951         * tests/Canvas2DLayerManagerTest.cpp: Removed.
2952
2953 2012-08-24  Justin Novosad  <junov@chromium.org>
2954
2955         [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
2956         https://bugs.webkit.org/show_bug.cgi?id=94386
2957
2958         Reviewed by Stephen White.
2959
2960         Adding unit tests for WebCore::Canvas2DLayerManager
2961
2962         * WebKit.gypi:
2963         * tests/Canvas2DLayerManagerTest.cpp: Added.
2964         (FakeCanvas2DLayerBridge):
2965         (FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
2966         (FakeCanvas2DLayerBridge::fakeFreeableBytes):
2967         (Canvas2DLayerManagerTest):
2968         (Canvas2DLayerManagerTest::storageAllocationTrackingTest):
2969         (Canvas2DLayerManagerTest::evictionTest):
2970         (Canvas2DLayerManagerTest::flushEvictionTest):
2971
2972 2012-08-24  Cris Neckar  <cdn@chromium.org>
2973
2974         Plumb consumeUserGesture() to the chromium platform layer.
2975         https://bugs.webkit.org/show_bug.cgi?id=9475294867
2976
2977         Reviewed by Adam Barth.
2978
2979         * public/WebFrame.h:
2980         (WebFrame):
2981         * src/WebFrameImpl.cpp:
2982         (WebKit::WebFrameImpl::consumeUserGesture):
2983         (WebKit):
2984         * src/WebFrameImpl.h:
2985         (WebFrameImpl):
2986
2987 2012-08-24  W. James MacLean  <wjmaclean@chromium.org>
2988
2989         [chromium] gestureTapDown should not select a RenderView node as target.
2990         https://bugs.webkit.org/show_bug.cgi?id=94956
2991
2992         Reviewed by James Robinson.
2993
2994         Add check to prevent selecting a RenderView node as a highlight target.
2995
2996         * src/WebViewImpl.cpp:
2997         (WebKit::WebViewImpl::bestTouchLinkNode):
2998
2999 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
3000
3001         MediaStream API: Add readyState functionality to RTCPeerConnection
3002         https://bugs.webkit.org/show_bug.cgi?id=94813
3003
3004         Reviewed by Adam Barth.
3005
3006         * src/AssertMatchingEnums.cpp:
3007
3008 2012-08-24  Dan Carney  <dcarney@google.com>
3009
3010         [V8] Refactor away IsolatedWorld
3011         https://bugs.webkit.org/show_bug.cgi?id=93971
3012
3013         Reviewed by Kentaro Hara.
3014
3015         Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
3016
3017         * src/WebViewImpl.cpp:
3018         (WebKit::WebView::addUserScript):
3019         (WebKit::WebView::addUserStyleSheet):
3020
3021 2012-08-23  Antoine Labour  <piman@chromium.org>
3022
3023         [chromium] Fix lost context when textures are evicted
3024         https://bugs.webkit.org/show_bug.cgi?id=94892
3025
3026         Reviewed by James Robinson.
3027
3028         After eviction, the CCPrioritizedTextureManager is in a limbo state
3029         where all its resources are invalid. If we try to release them we will
3030         double-destroy them.
3031
3032         New test: CCLayerTreeHostTestLostContextAfterEvictTextures.
3033
3034         * tests/CCLayerTreeHostTest.cpp:
3035         (CCLayerTreeHostTestLostContextAfterEvictTextures):
3036         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures):
3037         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest):
3038         (EvictTexturesAndLoseContextTask):
3039         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask):
3040         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask):
3041         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run):
3042         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext):
3043         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame):
3044         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread):
3045         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface):
3046         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest):
3047         (WTF):
3048         (WTF::TEST_F):
3049
3050 2012-08-23  Antoine Labour  <piman@chromium.org>
3051
3052         [chromium] Add OVERRIDEs in test code
3053         https://bugs.webkit.org/show_bug.cgi?id=94894
3054
3055         Reviewed by James Robinson.
3056
3057         * tests/CCLayerTreeHostTest.cpp:
3058
3059 2012-08-23  Joshua Bell  <jsbell@chromium.org>
3060
3061         IndexedDB: Expose mechanism for database to force a connection to close
3062         https://bugs.webkit.org/show_bug.cgi?id=91010
3063
3064         Reviewed by Tony Chang.
3065
3066         In Chromium, the browsing data deleter has a WebIDBDatabase handle which
3067         it can use to terminate a connection. This handles forcefully closing
3068         the front end connections and the back end, to unblock disk cleanup.
3069
3070         * public/WebIDBDatabase.h:
3071         (WebKit::WebIDBDatabase::forceClose): Entry point.
3072         * public/WebIDBDatabaseCallbacks.h:
3073         (WebKit::WebIDBDatabaseCallbacks::onForcedClose): Plumbing back to front.
3074         * src/IDBDatabaseCallbacksProxy.cpp:
3075         (WebKit::IDBDatabaseCallbacksProxy::onForcedClose): Plumbing back to front.
3076         (WebKit):
3077         * src/IDBDatabaseCallbacksProxy.h:
3078         (IDBDatabaseCallbacksProxy): Plumbing.
3079         * src/WebIDBDatabaseCallbacksImpl.cpp:
3080         (WebKit::WebIDBDatabaseCallbacksImpl::onForcedClose): Plumbing back to front.
3081         (WebKit):
3082         * src/WebIDBDatabaseCallbacksImpl.h:
3083         (WebIDBDatabaseCallbacksImpl): Plumbing back to front.
3084         * src/WebIDBDatabaseImpl.cpp:
3085         (WebKit::WebIDBDatabaseImpl::close): Tidy up dropping the callback reference.
3086         (WebKit):
3087         (WebKit::WebIDBDatabaseImpl::forceClose): Terminate the connection by notifying
3088         the back end and the front end, while avoid re-entrant badness.
3089         * src/WebIDBDatabaseImpl.h: Header tweak for unit test.
3090         (WebIDBDatabaseImpl):
3091         * tests/IDBDatabaseBackendTest.cpp: Added unit test to exercise connections.
3092
3093 2012-08-23  James Robinson  <jamesr@chromium.org>
3094
3095         [chromium] Convert WebAnimationCurve subtypes into pure virtual
3096         https://bugs.webkit.org/show_bug.cgi?id=94068
3097
3098         Reviewed by Adrienne Walker.
3099
3100         Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface.
3101
3102         * WebKit.gyp:
3103         * src/WebAnimation.cpp:
3104         (WebKit::WebAnimation::initialize):
3105         * src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp.
3106         (WebKit):
3107         (WebKit::WebFloatAnimationCurve::create):
3108         (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
3109         (WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl):
3110         (WebKit::WebFloatAnimationCurveImpl::type):
3111         (WebKit::WebFloatAnimationCurveImpl::add):
3112         (WebKit::WebFloatAnimationCurveImpl::getValue):
3113         (WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve):
3114         * src/WebTransformAnimationCurve.cpp: Removed.
3115         * tests/WebAnimationTest.cpp:
3116         (WebKit::TEST):
3117         * tests/WebFloatAnimationCurveTest.cpp:
3118         (WebKit::TEST):
3119         * tests/WebTransformAnimationCurveTest.cpp:
3120         (WebKit::TEST):
3121
3122 2012-08-23  Kentaro Hara  <haraken@chromium.org>
3123
3124         [V8] Remove V8Proxy.{h,cpp}
3125         https://bugs.webkit.org/show_bug.cgi?id=94794
3126
3127         Reviewed by Dimitri Glazkov.
3128
3129         Now V8Proxy is no longer used. We can completely remove V8Proxy from the codebase.
3130
3131         No tests. No change in behavior.
3132
3133         * src/ChromeClientImpl.cpp:
3134         * src/WebBindings.cpp:
3135         * src/WebDOMMessageEvent.cpp:
3136         * src/WebDevToolsAgentImpl.cpp:
3137         * src/WebMediaPlayerClientImpl.cpp:
3138
3139 2012-08-23  Dana Jansens  <danakj@chromium.org>
3140
3141         [chromium] Don't require a RenderSurface* in order to create a RenderPass
3142         https://bugs.webkit.org/show_bug.cgi?id=94862
3143
3144         Reviewed by Adrienne Walker.
3145
3146         * tests/CCLayerTreeHostImplTest.cpp:
3147         * tests/CCRendererGLTest.cpp:
3148         (FakeCCRendererClient::FakeCCRendererClient):
3149
3150 2012-08-22  James Robinson  <jamesr@chromium.org>
3151
3152         [chromium] Remove WebLayer::setChildren API
3153         https://bugs.webkit.org/show_bug.cgi?id=94749
3154
3155         Reviewed by Adrienne Walker.
3156
3157         * src/WebLayer.cpp:
3158
3159 2012-08-23  Dana Jansens  <danakj@chromium.org>
3160
3161         [chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink
3162         https://bugs.webkit.org/show_bug.cgi?id=94752
3163
3164         Reviewed by Adrienne Walker.
3165
3166         * tests/CCLayerTreeHostImplTest.cpp:
3167         * tests/CCLayerTreeHostTest.cpp:
3168         (WTF::EvictionTestLayerImpl::appendQuads):
3169         * tests/CCQuadCullerTest.cpp:
3170         * tests/CCRenderSurfaceTest.cpp:
3171         * tests/CCSolidColorLayerImplTest.cpp:
3172         (CCLayerTestCommon::TEST):
3173         * tests/CCTiledLayerImplTest.cpp:
3174         (CCLayerTestCommon::TEST):
3175         (CCLayerTestCommon::getQuads):
3176         (CCLayerTestCommon::coverageVisibleRectOnTileBoundaries):
3177         (CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
3178         (CCLayerTestCommon::coverageVisibleRectIntersectsBounds):
3179         * tests/MockCCQuadCuller.h:
3180         (WebCore::MockCCQuadCuller::MockCCQuadCuller):
3181         (MockCCQuadCuller):
3182         (WebCore::MockCCQuadCuller::quadList):
3183         (WebCore::MockCCQuadCuller::sharedQuadStateList):
3184
3185 2012-08-23  Pavel Feldman  <pfeldman@chromium.org>
3186
3187         Not reviewed - fixing input list for timeline inspector module.
3188         https://bugs.webkit.org/show_bug.cgi?id=94829
3189
3190         * WebKit.gyp:
3191
3192 2012-08-23  Alexandre Elias  <aelias@chromium.org>
3193
3194         [chromium] Rename LayerRendererChromium to GL-specific name
3195         https://bugs.webkit.org/show_bug.cgi?id=94835
3196
3197         Reviewed by James Robinson.
3198
3199         Over time, LayerRendererChromium has evolved to be a GL-specific
3200         subclass of CCRenderer that has no awareness of layers (as it operates
3201         only with drawQuads).
3202
3203         This patch renames LayerRendererChromium to CCRendererGL, replaces all
3204         instances of "layerRenderer" with just "renderer", and removes a
3205         few unnecessary includes of LayerRendererChromium.h.
3206
3207         * WebKit.gypi:
3208         * tests/CCLayerTreeHostImplTest.cpp:
3209         * tests/CCLayerTreeHostTest.cpp:
3210         (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
3211         (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
3212         (WTF::CCLayerTreeHostTestManySurfaces::beginTest):
3213         (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread):
3214         * tests/CCRendererGLTest.cpp: Renamed from Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp.
3215         (FrameCountingMemoryAllocationSettingContext):
3216         (FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext):
3217         (FrameCountingMemoryAllocationSettingContext::prepareTexture):
3218         (FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM):
3219         (FrameCountingMemoryAllocationSettingContext::getString):
3220         (FrameCountingMemoryAllocationSettingContext::frameCount):
3221         (FrameCountingMemoryAllocationSettingContext::setMemoryAllocation):
3222         (FakeCCRendererClient):
3223         (FakeCCRendererClient::FakeCCRendererClient):
3224         (FakeCCRendererClient::setFullRootLayerDamageCount):
3225         (FakeCCRendererClient::rootRenderPass):
3226         (FakeCCRendererClient::renderPassesInDrawOrder):
3227         (FakeCCRendererClient::renderPasses):
3228         (FakeCCRendererClient::memoryAllocationLimitBytes):
3229         (FakeCCRendererGL):
3230         (FakeCCRendererGL::FakeCCRendererGL):
3231         (CCRendererGLTest):
3232         (CCRendererGLTest::CCRendererGLTest):
3233         (CCRendererGLTest::SetUp):
3234         (CCRendererGLTest::TearDown):
3235         (CCRendererGLTest::swapBuffers):
3236         (CCRendererGLTest::context):
3237         (TEST_F):
3238         (ForbidSynchronousCallContext):
3239         (ForbidSynchronousCallContext::ForbidSynchronousCallContext):
3240         (ForbidSynchronousCallContext::getActiveAttrib):
3241         (ForbidSynchronousCallContext::getActiveUniform):
3242         (ForbidSynchronousCallContext::getAttachedShaders):
3243         (ForbidSynchronousCallContext::getAttribLocation):
3244         (ForbidSynchronousCallContext::getBooleanv):
3245         (ForbidSynchronousCallContext::getBufferParameteriv):
3246         (ForbidSynchronousCallContext::getContextAttributes):
3247         (ForbidSynchronousCallContext::getError):
3248         (ForbidSynchronousCallContext::getFloatv):
3249         (ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
3250         (ForbidSynchronousCallContext::getIntegerv):
3251         (ForbidSynchronousCallContext::getProgramiv):
3252         (ForbidSynchronousCallContext::getShaderiv):
3253         (ForbidSynchronousCallContext::getString):
3254         (ForbidSynchronousCallContext::getProgramInfoLog):
3255         (ForbidSynchronousCallContext::getRenderbufferParameteriv):
3256         (ForbidSynchronousCallContext::getShaderInfoLog):
3257         (ForbidSynchronousCallContext::getShaderPrecisionFormat):
3258         (ForbidSynchronousCallContext::getShaderSource):
3259         (ForbidSynchronousCallContext::getTexParameterfv):
3260         (ForbidSynchronousCallContext::getTexParameteriv):
3261         (ForbidSynchronousCallContext::getUniformfv):
3262         (ForbidSynchronousCallContext::getUniformiv):
3263         (ForbidSynchronousCallContext::getUniformLocation):
3264         (ForbidSynchronousCallContext::getVertexAttribfv):
3265         (ForbidSynchronousCallContext::getVertexAttribiv):
3266         (ForbidSynchronousCallContext::getVertexAttribOffset):
3267         (TEST):
3268         (LoseContextOnFirstGetContext):
3269         (LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
3270         (ContextThatDoesNotSupportMemoryManagmentExtensions):
3271         (ContextThatDoesNotSupportMemoryManagmentExtensions::ContextThatDoesNotSupportMemoryManagmentExtensions):
3272         (ContextThatDoesNotSupportMemoryManagmentExtensions::prepareTexture):
3273         (ContextThatDoesNotSupportMemoryManagmentExtensions::setMemoryAllocationChangedCallbackCHROMIUM):
3274         (ContextThatDoesNotSupportMemoryManagmentExtensions::getString):
3275         (ClearCountingContext):
3276         (ClearCountingContext::ClearCountingContext):
3277         (ClearCountingContext::clear):
3278         (ClearCountingContext::clearCount):
3279         * tests/TiledLayerChromiumTest.cpp:
3280
3281 2012-08-23  Stephen White  <senorblanco@chromium.org>
3282
3283         Unreviewed.  Rolled DEPS.
3284
3285         * DEPS:
3286
3287 2012-08-23  Wei Jia  <wjia@chromium.org>
3288
3289         create different WebKit::WebMediaPlayer based on URL
3290         https://bugs.webkit.org/show_bug.cgi?id=91301
3291
3292         Reviewed by Adam Barth.
3293
3294         Pass URL to WebFrameClient::createMediaPlayer(). This allows creation
3295         of different WebMediaPlayer implementations based on the URL.
3296
3297         * public/WebFrameClient.h:
3298         (WebKit::WebFrameClient::createMediaPlayer): add URL as additional argument.
3299         * src/WebMediaPlayerClientImpl.cpp:
3300         (WebKit::createWebMediaPlayer): add URL as additional argument.
3301         (WebKit::WebMediaPlayerClientImpl::loadInternal):
3302
3303 2012-08-23  Joshua Bell  <jsbell@chromium.org>
3304
3305         IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
3306         https://bugs.webkit.org/show_bug.cgi?id=94757
3307
3308         Reviewed by Tony Chang.
3309
3310         Drop onSuccess(IDBDatabaseBackendImpl) overload from test, as it is no longer
3311         implemented by IDBRequest.
3312
3313         * tests/IDBRequestTest.cpp:
3314         (WebCore::TEST):
3315
3316 2012-08-23  Kenneth Russell  <kbr@google.com>
3317
3318         Convert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals
3319         https://bugs.webkit.org/show_bug.cgi?id=93306
3320
3321         Unreviewed build fix.
3322
3323         * src/ScrollbarGroup.h:
3324
3325 2012-08-23  Adrienne Walker  <enne@google.com>
3326
3327         Convert ScrollableArea ASSERT_NOT_REACHED virtuals
3328         https://bugs.webkit.org/show_bug.cgi?id=93306
3329
3330         Reviewed by Darin Adler.
3331
3332         Add implementations where necessary to make derived classes concrete.
3333         Add OVERRIDE for ScrollableArea functions.
3334
3335         * src/ScrollbarGroup.h:
3336         (ScrollbarGroup):
3337         (WebKit::ScrollbarGroup::scrollCornerRect):
3338         * tests/ScrollAnimatorNoneTest.cpp:
3339         (MockScrollableArea):
3340
3341 2012-08-23  David Reveman  <reveman@chromium.org>
3342
3343         [Chromium] Unnecessary delay when starting to update resources with an inactive vsync timer.
3344         https://bugs.webkit.org/show_bug.cgi?id=94719
3345
3346         Reviewed by James Robinson.
3347
3348         * tests/CCSchedulerTestCommon.h:
3349
3350 2012-08-23  Peter Beverloo  <peter@chromium.org>
3351
3352         Unreviewed.  Rolled DEPS.
3353
3354         * DEPS:
3355
3356 2012-08-22  Alec Flett  <alecflett@chromium.org>
3357
3358         IndexedDB: tests for injection/extraction of idb keys
3359         https://bugs.webkit.org/show_bug.cgi?id=94653
3360
3361         Reviewed by Tony Chang.
3362
3363         Added unit tests for key injection/extraction using
3364         SerializedScriptValue. These were moved from chromium, now
3365         that all uses of the API are through WebKit.
3366
3367         * tests/IDBKeyPathTest.cpp:
3368         (WebCore):
3369         (WebCore::TEST):
3370
3371 2012-08-22  James Robinson  <jamesr@chromium.org>
3372
3373         [chromium] Change WebLayer from a concrete type to a pure virtual interface
3374         https://bugs.webkit.org/show_bug.cgi?id=94174
3375
3376         Reviewed by Adrienne Walker.
3377
3378         This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl /
3379         NonCompositedContentHost / LinkHighlight.
3380
3381         * WebKit.gypi:
3382         * src/LinkHighlight.cpp:
3383         (WebKit::LinkHighlight::LinkHighlight):
3384         (WebKit::LinkHighlight::contentLayer):
3385         (WebKit::LinkHighlight::clipLayer):
3386         (WebKit::LinkHighlight::releaseResources):
3387         (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition):
3388         (WebKit::LinkHighlight::startHighlightAnimation):
3389         (WebKit::LinkHighlight::updateGeometry):
3390         * src/LinkHighlight.h:
3391         (LinkHighlight):
3392         * src/NonCompositedContentHost.cpp:
3393         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
3394         (WebKit::NonCompositedContentHost::setScrollLayer):
3395         (WebKit::NonCompositedContentHost::setViewport):
3396         (WebKit::NonCompositedContentHost::scrollLayer):
3397         * src/NonCompositedContentHost.h:
3398         * src/WebContentLayer.cpp: Removed.
3399         * src/WebContentLayerImpl.cpp:
3400         (WebKit::WebContentLayer::create):
3401         (WebKit::WebContentLayerImpl::WebContentLayerImpl):
3402         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
3403         (WebKit::WebContentLayerImpl::layer):
3404         (WebKit):
3405         (WebKit::WebContentLayerImpl::setDoubleSided):
3406         (WebKit::WebContentLayerImpl::setContentsScale):
3407         (WebKit::WebContentLayerImpl::setUseLCDText):
3408         (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
3409         (WebKit::WebContentLayerImpl::paintContents):
3410         * src/WebContentLayerImpl.h:
3411         (WebContentLayerImpl):
3412         * src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
3413         (WebKit):
3414         (WebKit::WebExternalTextureLayer::create):
3415         (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
3416         (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
3417         (WebKit::WebExternalTextureLayerImpl::layer):
3418         (WebKit::WebExternalTextureLayerImpl::setTextureId):
3419         (WebKit::WebExternalTextureLayerImpl::setFlipped):
3420         (WebKit::WebExternalTextureLayerImpl::setUVRect):
3421         (WebKit::WebExternalTextureLayerImpl::setOpaque):
3422         (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
3423         (WebKit::WebExternalTextureLayerImpl::willModifyTexture):
3424         (WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
3425         (WebTextureUpdaterImpl):
3426         (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
3427         (WebKit::WebExternalTextureLayerImpl::prepareTexture):
3428         (WebKit::WebExternalTextureLayerImpl::context):
3429         * src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.
3430         (WebKit):
3431         (WebExternalTextureLayerImpl):
3432         * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
3433         (WebKit):
3434         (WebKit::WebIOSurfaceLayer::create):
3435         (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
3436         (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
3437         (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
3438         (WebKit::WebIOSurfaceLayerImpl::layer):
3439         * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
3440         (WebCore):
3441         (WebKit):
3442         (WebIOSurfaceLayerImpl):
3443         * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
3444         (WebKit):
3445         (WebKit::WebImageLayer::create):
3446         (WebKit::WebImageLayerImpl::WebImageLayerImpl):
3447         (WebKit::WebImageLayerImpl::~WebImageLayerImpl):
3448         (WebKit::WebImageLayerImpl::layer):
3449         (WebKit::WebImageLayerImpl::setBitmap):
3450         * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
3451         (WebCore):
3452         (WebKit):
3453         (WebImageLayerImpl):
3454         * src/WebLayer.cpp: Removed.
3455         * src/WebLayerImpl.cpp:
3456         (WebKit::WebLayer::create):
3457         (WebKit::WebLayerImpl::WebLayerImpl):
3458         (WebKit::WebLayerImpl::~WebLayerImpl):
3459         (WebKit):
3460         (WebKit::WebLayerImpl::id):
3461         (WebKit::WebLayerImpl::invalidateRect):
3462         (WebKit::WebLayerImpl::invalidate):
3463         (WebKit::WebLayerImpl::addChild):
3464         (WebKit::WebLayerImpl::insertChild):
3465         (WebKit::WebLayerImpl::replaceChild):
3466         (WebKit::WebLayerImpl::setChildren):
3467         (WebKit::WebLayerImpl::removeFromParent):
3468         (WebKit::WebLayerImpl::removeAllChildren):
3469         (WebKit::WebLayerImpl::setAnchorPoint):
3470         (WebKit::WebLayerImpl::anchorPoint):
3471         (WebKit::WebLayerImpl::setAnchorPointZ):
3472         (WebKit::WebLayerImpl::anchorPointZ):
3473         (WebKit::WebLayerImpl::setBounds):
3474         (WebKit::WebLayerImpl::bounds):
3475         (WebKit::WebLayerImpl::setMasksToBounds):
3476         (WebKit::WebLayerImpl::masksToBounds):
3477         (WebKit::WebLayerImpl::setMaskLayer):
3478         (WebKit::WebLayerImpl::setReplicaLayer):
3479         (WebKit::WebLayerImpl::setOpacity):
3480         (WebKit::WebLayerImpl::opacity):
3481         (WebKit::WebLayerImpl::setOpaque):
3482         (WebKit::WebLayerImpl::opaque):
3483         (WebKit::WebLayerImpl::setPosition):
3484         (WebKit::WebLayerImpl::position):
3485         (WebKit::WebLayerImpl::setSublayerTransform):
3486         (WebKit::WebLayerImpl::sublayerTransform):
3487         (WebKit::WebLayerImpl::setTransform):
3488         (WebKit::WebLayerImpl::transform):
3489         (WebKit::WebLayerImpl::setDrawsContent):
3490         (WebKit::WebLayerImpl::drawsContent):
3491         (WebKit::WebLayerImpl::setPreserves3D):
3492         (WebKit::WebLayerImpl::setUseParentBackfaceVisibility):
3493         (WebKit::WebLayerImpl::setBackgroundColor):
3494         (WebKit::WebLayerImpl::setFilters):
3495         (WebKit::WebLayerImpl::setBackgroundFilters):
3496         (WebKit::WebLayerImpl::setDebugBorderColor):
3497         (WebKit::WebLayerImpl::setDebugBorderWidth):
3498         (WebKit::WebLayerImpl::setDebugName):
3499         (WebKit::WebLayerImpl::setAnimationDelegate):
3500         (WebKit::WebLayerImpl::addAnimation):
3501         (WebKit::WebLayerImpl::removeAnimation):
3502         (WebKit::WebLayerImpl::pauseAnimation):
3503         (WebKit::WebLayerImpl::suspendAnimations):
3504         (WebKit::WebLayerImpl::resumeAnimations):
3505         (WebKit::WebLayerImpl::hasActiveAnimation):
3506         (WebKit::WebLayerImpl::transferAnimationsTo):
3507         (WebKit::WebLayerImpl::setForceRenderSurface):
3508         (WebKit::WebLayerImpl::setScrollPosition):
3509         (WebKit::WebLayerImpl::setScrollable):
3510         (WebKit::WebLayerImpl::setHaveWheelEventHandlers):
3511         (WebKit::WebLayerImpl::setShouldScrollOnMainThread):
3512         (WebKit::WebLayerImpl::setNonFastScrollableRegion):
3513         (WebKit::WebLayerImpl::setIsContainerForFixedPositionLayers):
3514         (WebKit::WebLayerImpl::setFixedToContainerLayer):
3515         (WebKit::WebLayerImpl::layer):
3516         * src/WebLayerImpl.h:
3517         (WebCore):
3518         (WebLayerImpl):
3519         * src/WebLayerTreeView.cpp:
3520         (WebKit::WebLayerTreeView::setRootLayer):
3521         * src/WebLayerTreeViewImpl.cpp:
3522         (WebKit::WebLayerTreeViewImpl::create):
3523         * src/WebMediaPlayerClientImpl.cpp:
3524         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3525         (WebKit::WebMediaPlayerClientImpl::repaint):
3526         (WebKit::WebMediaPlayerClientImpl::setOpaque):
3527         (WebKit::WebMediaPlayerClientImpl::platformLayer):
3528         (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
3529         * src/WebMediaPlayerClientImpl.h:
3530         (WebMediaPlayerClientImpl):
3531         * src/WebPluginContainerImpl.cpp:
3532         (WebKit::WebPluginContainerImpl::setBackingTextureId):
3533         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3534         (WebKit::WebPluginContainerImpl::commitBackingTexture):
3535         (WebKit::WebPluginContainerImpl::setOpaque):
3536         (WebKit::WebPluginContainerImpl::platformLayer):
3537         * src/WebPluginContainerImpl.h:
3538         (WebPluginContainerImpl):
3539         * src/WebScrollableLayer.cpp: Removed.
3540         * src/WebScrollbarLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebScrollbarLayer.cpp.
3541         (WebKit):
3542         (WebKit::WebScrollbarLayer::create):
3543         (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
3544         (WebKit::WebScrollbarLayerImpl::~WebScrollbarLayerImpl):
3545         (WebKit::WebScrollbarLayerImpl::layer):
3546         (WebKit::WebScrollbarLayerImpl::setScrollLayer):
3547         * src/WebScrollbarLayerImpl.h: Copied from Source/WebKit/chromium/src/WebSolidColorLayerImpl.h.
3548         (WebCore):
3549         (WebKit):
3550         (WebScrollbarLayerImpl):
3551         * src/WebSolidColorLayerImpl.cpp:
3552         (WebKit::WebSolidColorLayer::create):
3553         (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
3554         (WebKit::WebSolidColorLayerImpl::layer):
3555         (WebKit):
3556         (WebKit::WebSolidColorLayerImpl::setBackgroundColor):
3557         * src/WebSolidColorLayerImpl.h:
3558         (WebCore):
3559         (WebKit):
3560         (WebSolidColorLayerImpl):
3561         * src/WebVideoLayerImpl.cpp: Copied from Source/WebKit/chromium/src/WebVideoLayer.cpp.
3562         (WebKit):
3563         (WebKit::WebVideoLayer::create):
3564         (WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
3565         (WebKit::WebVideoLayerImpl::~WebVideoLayerImpl):
3566         (WebKit::WebVideoLayerImpl::layer):
3567         (WebKit::WebVideoLayerImpl::active):
3568         * src/WebVideoLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebVideoLayer.cpp.
3569         (WebCore):
3570         (WebKit):
3571         (WebVideoLayerImpl):
3572         * src/WebViewImpl.cpp:
3573         (WebKit::WebViewImpl::WebViewImpl):
3574         (WebKit::WebViewImpl::setRootGraphicsLayer):
3575         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3576         (WebKit):
3577         * src/WebViewImpl.h:
3578         * tests/ImageLayerChromiumTest.cpp:
3579         (WebCore::TEST):
3580         * tests/WebLayerTest.cpp:
3581         * tests/WebLayerTreeViewTest.cpp:
3582
3583 2012-08-22  Alejandro PiƱeiro  <apinheiro@igalia.com>
3584
3585         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
3586         https://bugs.webkit.org/show_bug.cgi?id=73819
3587
3588         Reviewed by Chris Fleizach.
3589
3590         Added a new role, Toggle Button, based on whether aria-pressed is present.
3591         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
3592
3593         * public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that
3594         matchs with WebCore ToggleButtonRole
3595         * src/AssertMatchingEnums.cpp: added the assert matching rule for
3596         WebAccessibilityRoleToggleButton and ToggleButtonRole
3597
3598 2012-08-17  Jeffrey Pfau  <jpfau@apple.com>
3599
3600         Allow blocking of Web SQL databases in third-party web workers
3601         https://bugs.webkit.org/show_bug.cgi?id=94170
3602
3603         Reviewed by Adam Barth.
3604
3605         Web workers did not previously know anything about the document that
3606         spawned them. This is undefined for shared workers, but for dedicated
3607         workers, we now pipe the information through.
3608
3609
3610         * src/WebWorkerClientImpl.cpp:
3611         (WebKit::WebWorkerClientImpl::startWorkerContext): Pass top document's origin
3612
3613 2012-08-22  Kentaro Hara  <haraken@chromium.org>
3614
3615         [V8] Move context() from V8Proxy to ScriptController
3616         https://bugs.webkit.org/show_bug.cgi?id=94593
3617
3618         Reviewed by Adam Barth.
3619
3620         To kill V8Proxy, we can move context() from V8Proxy to ScriptController.
3621
3622         No tests. No change in behavior.
3623
3624         * src/InspectorFrontendClientImpl.cpp:
3625         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3626         * src/WebDevToolsFrontendImpl.cpp:
3627         (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
3628
3629 2012-08-22  Nikhil Bhargava  <nbhargava@google.com>
3630
3631         Reduce Font.h includes across project -- improves RenderObject.h compile time
3632         https://bugs.webkit.org/show_bug.cgi?id=93629
3633
3634         Reviewed by Eric Seidel.
3635
3636         Adds includes due to change in RenderStyle.h
3637
3638         * src/WebFrameImpl.cpp:
3639         * src/mac/WebSubstringUtil.mm:
3640
3641 2012-08-22  Nikhil Bhargava  <nbhargava@google.com>
3642
3643         Speed up compilation of tests involving WebTransformationMatrix
3644         https://bugs.webkit.org/show_bug.cgi?id=94639
3645
3646         Reviewed by James Robinson.
3647
3648         EXPECT_TRANSFORMATION_MATRIX_EQ was changed to become mainly a function.
3649         As a macro that expanded into 16 other macros, it caused an unneeded
3650         slow down of close to 45s in the compile time of CCLayerTreeHostCommonTest
3651         Bugs have been filed to clang and gcc noting the errant behavior:
3652         http://llvm.org/bugs/show_bug.cgi?id=13651 and http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54337
3653
3654         * tests/CCLayerTreeHostCommonTest.cpp:
3655         * tests/CCLayerTreeTestCommon.h:
3656         (WebKitTests):
3657         (WebKitTests::ExpectTransformationMatrixEq):
3658         * tests/WebTransformOperationsTest.cpp:
3659         (TEST):
3660         (checkProgress):
3661         * tests/WebTransformationMatrixTest.cpp:
3662         (WebKit::TEST):
3663
3664 2012-08-22  Alexandre Elias  <aelias@google.com>
3665
3666         [chromium] Add software bitmap resources to CCResourceProvider
3667         https://bugs.webkit.org/show_bug.cgi?id=93677
3668
3669         Reviewed by Adrienne Walker.
3670
3671         Second commit after revert.
3672
3673         This adds the ability to CCResourceProvider to use software bitmaps.
3674         They are allocated as plain-old-memory, and exposed as Skia objects.
3675
3676         We want the ResourceProvider to be able to handle different resource
3677         types at the same time.  In practice, a default resource type is
3678         desired for most uses within a single compositor instance, which is
3679         specified by the default resource type.  Default resource types are
3680         expected to be mostly 1-to-1 with CCRenderer types.
3681
3682         New tests added by parametrizing existing CCResourceProvider tests.
3683
3684         * tests/CCResourceProviderTest.cpp:
3685         (WebKit::CCResourceProviderTest::getResourcePixels):
3686
3687 2012-08-22  W. James MacLean  <wjmaclean@chromium.org>
3688
3689         [chromium] Add touch link highlight animation layers.
3690         https://bugs.webkit.org/show_bug.cgi?id=84487
3691
3692         Reviewed by James Robinson.
3693
3694         Adds support for creating composited touch link highlights in renderer thread. Clipping not yet
3695         implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported.
3696         Transform support currently limited to translation.
3697
3698         Unit tests for LinkHighlight revised.
3699
3700         * WebKit.gyp:
3701         * src/LinkHighlight.cpp: Added.
3702         (WebKit):
3703         (WebKit::LinkHighlight::create):
3704         (WebKit::LinkHighlight::LinkHighlight):
3705         (WebKit::LinkHighlight::~LinkHighlight):
3706         (WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight.
3707         (WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight.
3708         (WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers.
3709         (WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to.
3710         (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates.
3711         (WebKit::LinkHighlight::paintContents): If highlight active, paints highlight.
3712         (WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation.
3713         (WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium.
3714         (WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate.
3715         (WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes.
3716         (WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position.
3717             Computations proceed only if preceded by call to invalidate().
3718         (WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid.
3719         (WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout().
3720         (WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium.
3721         * src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.
3722         (WebCore):
3723         (WebKit):
3724         (LinkHighlight):
3725         * src/WebViewImpl.cpp:
3726         (WebKit::WebViewImpl::handleGestureEvent):
3727         (WebKit):
3728         (WebKit::highlightConditions):
3729         (WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location.
3730         (WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location.
3731         (WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry().
3732         * src/WebViewImpl.h:
3733         (WebKit):
3734         (WebViewImpl):
3735         (WebKit::WebViewImpl::linkHighlight):
3736         * tests/LinkHighlightTest.cpp:
3737         (WebCore):
3738         (WebCore::TEST):
3739         * tests/data/test_touch_link_highlight.html: Added.
3740
3741 2012-08-22  Adam Barth  <abarth@webkit.org>
3742
3743         WebWidget should be able to paint into a zoomed canvas without aliasing
3744         https://bugs.webkit.org/show_bug.cgi?id=92043
3745
3746         Reviewed by James Robinson.
3747
3748         If accelerated compositing is enabled, WebWidget::paint reads back from
3749         the compositor rather than re-painting the widget. That approach works
3750         well if the canvas we're rendering into is at a similar resolution to
3751         the pixels in the compositor, but if the canvas has been scaled (e.g.,
3752         to help the user disambiguate links), then reading back from the
3753         compositor will cause aliasing artifacts.
3754
3755         This patch adds an option to paint to let the embedder request a
3756         software re-rendering of the widget to avoid these aliasing artifacts.
3757
3758         * public/WebWidget.h:
3759         (WebKit::WebWidget::paint):
3760         * src/WebPagePopupImpl.cpp:
3761         (WebKit::WebPagePopupImpl::paint):
3762         * src/WebPagePopupImpl.h:
3763         (WebPagePopupImpl):
3764         * src/WebPopupMenuImpl.cpp:
3765         (WebKit::WebPopupMenuImpl::paint):
3766         * src/WebPopupMenuImpl.h:
3767         * src/WebViewImpl.cpp:
3768         (WebKit::canvasBackgroundForTransparencey):
3769         (WebKit):
3770         (WebKit::WebViewImpl::paint):
3771         * src/WebViewImpl.h:
3772         (WebViewImpl):
3773
3774 2012-08-22  Eric Penner  <epenner@google.com>
3775
3776         [chromium] Simplify updateContentRect, removing rect parameter, refactor unit tests.
3777         https://bugs.webkit.org/show_bug.cgi?id=94165
3778
3779         Reviewed by Adrienne Walker.
3780
3781         Refactored tests to remove lots of boilerplate code.
3782
3783         * tests/CCTiledLayerTestCommon.cpp:
3784         * tests/CCTiledLayerTestCommon.h:
3785         (FakeTiledLayerChromium):
3786         * tests/TiledLayerChromiumTest.cpp:
3787
3788 2012-08-22  Iain Merrick  <husky@chromium.org>
3789
3790         [chromium] Remove WebFrame::setSelectionToRange
3791         https://bugs.webkit.org/show_bug.cgi?id=94685
3792
3793         Reviewed by Adam Barth.
3794
3795         It has basically the same functionality as WebFrame::selectRange.
3796         The calling code was removed in Chromium patch 152608.
3797
3798         * public/WebFrame.h:
3799         (WebFrame):
3800         * src/WebFrameImpl.cpp:
3801         * src/WebFrameImpl.h:
3802         (WebFrameImpl):
3803
3804 2012-08-22  Kenneth Russell  <kbr@google.com>
3805
3806         Unreviewed, rolling out r126319.
3807         http://trac.webkit.org/changeset/126319
3808         https://bugs.webkit.org/show_bug.cgi?id=84487
3809
3810         Broke Chromium Mac build
3811
3812         * WebKit.gyp:
3813         * src/LinkHighlight.cpp: Removed.
3814         * src/WebViewImpl.cpp:
3815         (WebKit::WebViewImpl::handleGestureEvent):
3816         (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
3817         (WebKit::WebViewImpl::layout):
3818         * src/WebViewImpl.h:
3819         (WebKit):
3820         (WebViewImpl):
3821         * tests/LinkHighlightTest.cpp:
3822         * tests/data/test_touch_link_highlight.html: Removed.
3823
3824 2012-08-22  W. James MacLean  <wjmaclean@chromium.org>
3825
3826         [chromium] Add touch link highlight animation layers.
3827         https://bugs.webkit.org/show_bug.cgi?id=84487
3828
3829         Reviewed by James Robinson.
3830
3831         Adds support for creating composited touch link highlights in renderer thread. Clipping not yet
3832         implemented for non-composited frames/overflow divs, but scrolling and layout changes are supported.
3833         Transform support currently limited to translation.
3834
3835         Unit tests for LinkHighlight revised.
3836
3837         * WebKit.gyp:
3838         * src/LinkHighlight.cpp: Added.
3839         (WebKit):
3840         (WebKit::LinkHighlight::create):
3841         (WebKit::LinkHighlight::LinkHighlight):
3842         (WebKit::LinkHighlight::~LinkHighlight):
3843         (WebKit::LinkHighlight::contentLayer): Accessor for layer containing highlight.
3844         (WebKit::LinkHighlight::clipLayer): Accessor for layer that provides clipping for highlight.
3845         (WebKit::LinkHighlight::releaseResources): Releases Node* for highlight target, clears client/delegate pointers.
3846         (WebKit::LinkHighlight::computeEnclosingCompositingLayer): Determines which GraphicsLayerChromium to attach highlight to.
3847         (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Determines coordinates of highlight in owning GraphicsLayerChromium's coordinates.
3848         (WebKit::LinkHighlight::paintContents): If highlight active, paints highlight.
3849         (WebKit::LinkHighlight::startHighlightAnimation): Called to start highlight animation.
3850         (WebKit::LinkHighlight::clearGraphicsLayerLinkHighlightPointer): Removes this LinkHighlight's pointer from owning GraphicsLayerChromium.
3851         (WebKit::LinkHighlight::notifyAnimationStarted): Implements WebAnimationDelegate.
3852         (WebKit::LinkHighlight::notifyAnimationFinished): Implements WebAnimationDelegate, releases resources when animation completes.
3853         (WebKit::LinkHighlight::updateGeometry): Invokes computation of which GraphicsLayerChromium to attach to, and highlight shape & position.
3854             Computations proceed only if preceded by call to invalidate().
3855         (WebKit::LinkHighlight::clearCurrentGraphicsLayer): Handles notification that current GraphicsLayerChromium* is no longer valid.
3856         (WebKit::LinkHighlight::invalidate): Sets flag to allow geometry update on next call from WebViewImpl::layout().
3857         (WebKit::LinkHighlight::layer): Exports WebLayer* for use in GraphicsLayerChromium.
3858         * src/LinkHighlight.h: Renamed from Source/WebCore/platform/graphics/chromium/LinkHighlight.h.
3859         (WebCore):
3860         (WebKit):
3861         (LinkHighlight):
3862         * src/WebViewImpl.cpp:
3863         (WebKit::WebViewImpl::handleGestureEvent):
3864         (WebKit):
3865         (WebKit::highlightConditions):
3866         (WebKit::WebViewImpl::bestTouchLinkNode): Find highlight target node for touch event location.
3867         (WebKit::WebViewImpl::enableTouchHighlight): Invokes highlight for node at current touch event location.
3868         (WebKit::WebViewImpl::layout): Adds call to LinkHighlight::updateGeometry().
3869         * src/WebViewImpl.h:
3870         (WebKit):
3871         (WebViewImpl):
3872         (WebKit::WebViewImpl::linkHighlight):
3873         * tests/LinkHighlightTest.cpp:
3874         (WebCore):
3875         (WebCore::TEST):
3876         * tests/data/test_touch_link_highlight.html: Added.
3877
3878 2012-08-22  Sheriff Bot  <webkit.review.bot@gmail.com>
3879
3880         Unreviewed.  Rolled DEPS.
3881
3882         * DEPS:
3883
3884 2012-08-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3885
3886         Unreviewed, rolling out r126202.
3887         http://trac.webkit.org/changeset/126202
3888         https://bugs.webkit.org/show_bug.cgi?id=94657
3889
3890         Causes assertion failures on Chromium Linux dbg compositing
3891         layout tests (Requested by dominicc on #webkit).
3892
3893         * tests/CCResourceProviderTest.cpp:
3894         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
3895         (WebKit::CCResourceProviderTest::getResourcePixels):
3896         (WebKit::TEST_F):
3897
3898 2012-08-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3899
3900         [Chromium] Find-in-page coordinates should use containingBlock
3901         https://bugs.webkit.org/show_bug.cgi?id=94343
3902
3903         Reviewed by Julien Chaffraix.
3904
3905         The current implementation uses the container method to climb the render tree.
3906         However, it would be more correct and convenient to use containingBlock instead.
3907         Also, this patch introduces new tests for find-in-page coordinates in tables.
3908
3909         * src/FindInPageCoordinates.cpp:
3910         (WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now.
3911         (WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications.
3912         * tests/WebFrameTest.cpp: add new tests for tables.
3913         * tests/data/find_in_page.html:
3914         * tests/data/find_in_page_frame.html: new tests for tables.
3915
3916 2012-08-21  Alexandre Elias  <aelias@google.com>
3917
3918         [chromium] Add software bitmap resources to CCResourceProvider
3919         https://bugs.webkit.org/show_bug.cgi?id=93677
3920
3921         Reviewed by Adrienne Walker.
3922
3923         This adds the ability to CCResourceProvider to use software bitmaps.
3924         They are allocated as plain-old-memory, and exposed as Skia objects.
3925
3926         We want the ResourceProvider to be able to handle different resource
3927         types at the same time.  In practice, a default resource type is
3928         desired for most uses within a single compositor instance, which is
3929         specified by the default resource type.  Default resource types are
3930         expected to be mostly 1-to-1 with CCRenderer types.
3931
3932         New tests added by parametrizing existing CCResourceProvider tests.
3933
3934         * tests/CCResourceProviderTest.cpp:
3935         (WebKit::CCResourceProviderTest::getResourcePixels):
3936
3937 2012-08-21  Oli Lan  <olilan@chromium.org>
3938
3939         [chromium] Add WebView methods setCompositionFromExistingText and extendSelectionAndDelete.
3940         https://bugs.webkit.org/show_bug.cgi?id=93724
3941
3942         Reviewed by Ryosuke Niwa.
3943
3944         This adds two new methods to WebViewImpl.
3945
3946         1) setCompositionFromExistingText creates a new composition from the existing text
3947         in the currently focused input field. The new composition is between the two offsets
3948         provided, relative to the rootEditableElement. The current selection is left unchanged.
3949         
3950         2) extendSelectionAndDelete extends the selection by the specified number of characters
3951         before and after, and then deletes the selection. If the selection is just a caret, the effect
3952         is to delete the specified number of characters before and after the current editing point.
3953
3954         These methods will be used e.g. by the Android port to implement IME functionality.
3955
3956         New tests WebViewTest.ExtendSelectionAndDelete and WebViewTest.SetCompositionFromExistingText
3957         test the two new methods.       
3958
3959         * public/WebView.h:
3960         (WebView):
3961         * src/WebViewImpl.cpp:
3962         (WebKit::WebViewImpl::setComposingRegion):
3963         (WebKit):
3964         (WebKit::extendSelectionAndDelete):
3965         * src/WebViewImpl.h:
3966         (WebViewImpl):
3967         * tests/WebViewTest.cpp:
3968
3969 2012-08-21  Alec Flett  <alecflett@chromium.org>
3970
3971         IndexedDB: remove old update/openCursor glue
3972         https://bugs.webkit.org/show_bug.cgi?id=94378
3973
3974         Reviewed by Tony Chang.
3975
3976         Remove Chromium/WebKit API for old methods that have now been
3977         removed from chromium proper.
3978
3979         * public/WebIDBObjectStore.h:
3980         * src/IDBObjectStoreBackendProxy.cpp:
3981         * src/IDBObjectStoreBackendProxy.h:
3982         (IDBObjectStoreBackendProxy):
3983         * src/WebIDBObjectStoreImpl.h:
3984         (WebIDBObjectStoreImpl):
3985
3986 2012-08-21  James Robinson  <jamesr@chromium.org>
3987
3988         [chromium] Should be able to destroy a CCLayerTreeHost without manually setting the root layer
3989         https://bugs.webkit.org/show_bug.cgi?id=94631
3990
3991         Reviewed by Adrienne Walker.
3992
3993         Tests that destroying a CCLayerTreeHost that still points to a non-null root doesn't crash.
3994
3995         * tests/LayerChromiumTest.cpp:
3996
3997 2012-08-21  James Robinson  <jamesr@chromium.org>
3998
3999         Unreviewed, rolling out r126170.
4000         http://trac.webkit.org/changeset/126170
4001         https://bugs.webkit.org/show_bug.cgi?id=94614
4002
4003         I spoke too soon
4004
4005         * WebKit.gypi:
4006         * src/NonCompositedContentHost.cpp:
4007         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
4008         (WebKit::NonCompositedContentHost::setScrollLayer):
4009         (WebKit::NonCompositedContentHost::setViewport):
4010         (WebKit::NonCompositedContentHost::scrollLayer):
4011         * src/NonCompositedContentHost.h:
4012         * src/WebContentLayer.cpp: Renamed from Source/WebKit/chromium/src/WebVideoLayerImpl.cpp.
4013         (WebKit):
4014         (WebKit::WebContentLayer::create):
4015         (WebKit::WebContentLayer::clearClient):
4016         (WebKit::WebContentLayer::setDoubleSided):
4017         (WebKit::WebContentLayer::setContentsScale):
4018         (WebKit::WebContentLayer::setUseLCDText):
4019         (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
4020         (WebKit::WebContentLayer::WebContentLayer):
4021         (WebKit::WebContentLayer::operator=):
4022         (WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
4023         * src/WebContentLayerImpl.cpp:
4024         (WebKit::WebContentLayerImpl::create):
4025         (WebKit::WebContentLayerImpl::WebContentLayerImpl):
4026         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
4027         (WebKit::WebContentLayerImpl::paintContents):
4028         * src/WebContentLayerImpl.h:
4029         (WebContentLayerImpl):
4030         * src/WebExternalTextureLayer.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.
4031         (WebKit):
4032         (WebTextureUpdaterImpl):
4033         (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
4034         (WebExternalTextureLayerImpl):
4035         (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
4036         (WebKit::WebExternalTextureLayer::create):
4037         (WebKit::WebExternalTextureLayer::clearClient):
4038         (WebKit::WebExternalTextureLayer::setTextureId):
4039         (WebKit::WebExternalTextureLayer::setFlipped):
4040         (WebKit::WebExternalTextureLayer::setUVRect):
4041         (WebKit::WebExternalTextureLayer::setOpaque):
4042         (WebKit::WebExternalTextureLayer::setPremultipliedAlpha):
4043         (WebKit::WebExternalTextureLayer::willModifyTexture):
4044         (WebKit::WebExternalTextureLayer::setRateLimitContext):
4045         (WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
4046         * src/WebExternalTextureLayerImpl.h: Removed.
4047         * src/WebIOSurfaceLayer.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayerImpl.cpp.
4048         (WebKit):
4049         (WebKit::WebIOSurfaceLayer::create):
4050         (WebKit::WebIOSurfaceLayer::setIOSurfaceProperties):
4051         (WebKit::WebIOSurfaceLayer::WebIOSurfaceLayer):
4052         * src/WebIOSurfaceLayerImpl.h: Removed.
4053         * src/WebImageLayer.cpp: Renamed from Source/WebKit/chromium/src/WebImageLayerImpl.h.
4054         (WebKit):
4055         (WebKit::WebImageLayer::create):
4056         (WebKit::WebImageLayer::WebImageLayer):
4057         (WebKit::WebImageLayer::setBitmap):
4058         *