1 2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
7 2011-06-10 Tony Chang <tony@chromium.org>
9 Reviewed by Dimitri Glazkov.
11 [chromium] make features.gypi the same as features_override.gypi
12 https://bugs.webkit.org/show_bug.cgi?id=62399
14 Make the file the same as chromium's features_override.gypi so we
15 can remove features_override.gypi in chromium.
17 Remove ENABLE_DATAGRID=0 since the define is gone and remove
18 ENABLE_FULLSCREEN_API=1 since we want to disable it.
22 2011-06-09 Yury Semikhatsky <yurys@chromium.org>
24 Reviewed by Dmitry Titov.
26 [Chromium] Worker object may be garbage collected even if it has message handlers
27 https://bugs.webkit.org/show_bug.cgi?id=62292
29 I'd like to convert the test case into a layout test but I don't see yet
30 how to do this so that the test isn't too slow and reliable. The problem
31 with test is that full-GC needs to be triggered right after
32 WebWorkerClientImpl::confirmMessageFromWorkerObject is called and there
33 is no way to hook WebWorkerClientImpl::confirmMessageFromWorkerObject from JavaScript.
36 * src/WebWorkerClientImpl.cpp:
37 (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
38 (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): update worker context pending
39 activity state every time a message is confirmed since the message may have created a new activity.
40 * src/WebWorkerClientImpl.h:
42 2011-06-09 James Kozianski <koz@chromium.org>
44 Unreviewed, rolling out r88466.
45 http://trac.webkit.org/changeset/88466
46 https://bugs.webkit.org/show_bug.cgi?id=60059
48 Broke PPAPITest.URLLoader test on the chromium bots
52 * src/AssociatedURLLoader.cpp:
53 (WebKit::AssociatedURLLoader::ClientAdapter::clearClient):
54 (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
55 (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
56 (WebKit::AssociatedURLLoader::ClientAdapter::didFail):
57 (WebKit::AssociatedURLLoader::loadAsynchronously):
58 * tests/AssociatedURLLoaderTest.cpp: Removed.
60 2011-06-09 James Robinson <jamesr@chromium.org>
62 Reviewed by Eric Seidel.
64 [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
65 https://bugs.webkit.org/show_bug.cgi?id=62397
67 Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
68 even when the runtime setting was disabled.
72 2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
74 Unreviewed, rolling out r88486.
75 http://trac.webkit.org/changeset/88486
76 https://bugs.webkit.org/show_bug.cgi?id=62409
78 Broke chromium-win compile (Requested by jamesr on #webkit).
81 * public/WebPageSerializer.h:
83 * src/WebPageSerializer.cpp:
84 (WebKit::WebPageSerializer::serialize):
85 (WebKit::WebPageSerializer::serializeToMHTML):
87 2011-06-09 Jay Civelli <jcivelli@chromium.org>
89 Reviewed by Darin Fisher.
91 Page serializer APIs now use WebData instead of fetching the entire
93 https://bugs.webkit.org/show_bug.cgi?id=61908
96 * public/WebPageSerializer.h:
98 (WebKit::WebData::getSomeData):
99 * src/WebPageSerializer.cpp:
100 (WebKit::WebPageSerializer::serialize):
101 (WebKit::WebPageSerializer::serializeToMHTML):
103 2011-06-09 Bill Budge <bbudge@chromium.org>
105 Reviewed by Adam Barth.
107 The AssociatedURLLoader returns URL access errors synchronously. Use a timer to return such errors asynchronously. Also add unit tests for successful loads, same-origin restriction by default, and successful cross-origin loads.
108 https://bugs.webkit.org/show_bug.cgi?id=60059
112 * src/AssociatedURLLoader.cpp:
113 (WebKit::AssociatedURLLoader::ClientAdapter::clearClient):
114 (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
115 (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
116 (WebKit::AssociatedURLLoader::ClientAdapter::didFail):
117 (WebKit::AssociatedURLLoader::ClientAdapter::enableErrorNotifications):
118 (WebKit::AssociatedURLLoader::ClientAdapter::notifyError):
119 (WebKit::AssociatedURLLoader::loadAsynchronously):
120 * tests/AssociatedURLLoaderTest.cpp: Added.
121 (WebKit::TestWebFrameClient::cancelledError):
122 (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
123 (WebKit::AssociatedURLLoaderTest::SetUp):
124 (WebKit::AssociatedURLLoaderTest::TearDown):
125 (WebKit::AssociatedURLLoaderTest::serveRequests):
126 (WebKit::AssociatedURLLoaderTest::createAssociatedURLLoader):
127 (WebKit::AssociatedURLLoaderTest::willSendRequest):
128 (WebKit::AssociatedURLLoaderTest::didSendData):
129 (WebKit::AssociatedURLLoaderTest::didReceiveResponse):
130 (WebKit::AssociatedURLLoaderTest::didDownloadData):
131 (WebKit::AssociatedURLLoaderTest::didReceiveData):
132 (WebKit::AssociatedURLLoaderTest::didReceiveCachedMetadata):
133 (WebKit::AssociatedURLLoaderTest::didFinishLoading):
134 (WebKit::AssociatedURLLoaderTest::didFail):
137 2011-06-09 Nico Weber <thakis@chromium.org>
139 Reviewed by Darin Fisher.
141 [chromium] Make a few destructors private.
142 https://bugs.webkit.org/show_bug.cgi?id=62341
144 No intended functionality change.
146 * src/NotificationPresenterImpl.cpp:
147 (WebKit::VoidCallbackClient::~VoidCallbackClient):
148 * src/WebTextCheckingCompletionImpl.h:
149 (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
150 * src/WebURLRequest.cpp:
151 (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
152 * src/WebURLResponse.cpp:
153 (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
155 2011-06-09 James Robinson <jamesr@chromium.org>
157 Fix chromium build on build.webkit.org builders.
161 2011-06-08 Justin Novosad <junov@chromium.org>
163 Reviewed by James Robinson.
165 [Chromium] Crash when closing a tab with accelerated 2d canvas
166 https://bugs.webkit.org/show_bug.cgi?id=62324
167 In GraphicsContext3DInternal::setContextLostCallback we are passing a
168 non-refcounted ptr to a refcounted member. this can cause an access
169 violation after the destruction of GraphicsContext3D. Upon destruction
170 a null callback is sent to setContextLostCallback, which is good
171 except that it gets placed in a non-null adapter object. This fix
172 prevents the creation of the adapter when the callback is null, thus
173 preventing a later crash.
175 * src/GraphicsContext3DChromium.cpp:
176 (WebCore::GraphicsContextLostCallbackAdapter::create):
178 2011-06-08 James Robinson <jamesr@chromium.org>
180 Hopefully last change to features.gypi - set ENABLE_REGISTER_PROTOCOL_HANDLER based off of the the variable set
181 in chromium's common.gypi. Should green up the chromium linux tester on build.webkit.org.
185 2011-06-08 James Robinson <jamesr@chromium.org>
187 Set ENABLE_REGISTER_PROTOCOL_HANDLER=1 for chromium. I didn't mean to turn that off...
191 2011-06-08 James Robinson <jamesr@chromium.org>
193 [chromium] Update the chromium-within-WebKit revision to r88481
194 https://bugs.webkit.org/show_bug.cgi?id=62353
198 2011-06-08 Sailesh Agrawal <sail@chromium.org>
200 Reviewed by Darin Fisher.
202 [Chromium] Add stubs to WebWidget
203 https://bugs.webkit.org/show_bug.cgi?id=62263
205 This change add stub implementations for all WebWidget functions. Having stub methods should make it easier to add new functions to the class without breaking Chromium.
207 * public/WebWidget.h:
208 (WebKit::WebWidget::close):
209 (WebKit::WebWidget::size):
210 (WebKit::WebWidget::resize):
211 (WebKit::WebWidget::animate):
212 (WebKit::WebWidget::layout):
213 (WebKit::WebWidget::paint):
214 (WebKit::WebWidget::composite):
215 (WebKit::WebWidget::themeChanged):
216 (WebKit::WebWidget::handleInputEvent):
217 (WebKit::WebWidget::mouseCaptureLost):
218 (WebKit::WebWidget::setFocus):
219 (WebKit::WebWidget::setComposition):
220 (WebKit::WebWidget::confirmComposition):
221 (WebKit::WebWidget::compositionRange):
222 (WebKit::WebWidget::textInputType):
223 (WebKit::WebWidget::caretOrSelectionBounds):
224 (WebKit::WebWidget::selectionRange):
225 (WebKit::WebWidget::caretOrSelectionRange):
226 (WebKit::WebWidget::setTextDirection):
227 (WebKit::WebWidget::isAcceleratedCompositingActive):
229 2011-06-08 Tom Sepez <tsepez@chromium.org>
231 Reviewed by Adam Barth.
233 Add new permission callbacks for mixed content blocking.
234 https://bugs.webkit.org/show_bug.cgi?id=61946
236 * public/WebPermissionClient.h:
237 (WebKit::WebPermissionClient::allowDisplayingInsecureContent):
238 (WebKit::WebPermissionClient::allowRunningInsecureContent):
239 * src/FrameLoaderClientImpl.cpp:
240 (WebKit::FrameLoaderClientImpl::allowDisplayingInsecureContent):
241 (WebKit::FrameLoaderClientImpl::allowRunningInsecureContent):
242 * src/FrameLoaderClientImpl.h:
244 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
246 Added new entries for skia/third_party/glu.
250 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
256 2011-06-08 Ryan Sleevi <rsleevi@chromium.org>
258 Reviewed by Tony Chang.
260 Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
262 Compiling Chromium port under GCC 4.6 produces warnings about nullptr
263 https://bugs.webkit.org/show_bug.cgi?id=62242
267 2011-06-08 Greg Simon <gregsimon@chromium.org>
269 Reviewed by Dimitri Glazkov.
271 Control Indexeddb backends from LayoutTestController
272 https://bugs.webkit.org/show_bug.cgi?id=61000
274 * public/WebIDBFactory.h:
275 * src/AssertMatchingEnums.cpp:
276 * src/WebIDBFactoryImpl.cpp:
277 (WebKit::WebIDBFactory::setOverrideBackingStoreType):
278 (WebKit::WebIDBFactory::setTemporaryDatabaseFolder):
279 (WebKit::WebIDBFactoryImpl::open):
281 2011-06-08 Dominic Mazzoni <dmazzoni@google.com>
283 Reviewed by Dimitri Glazkov.
285 Add a method to return the line breaks for any element with
286 multiline text content.
287 https://bugs.webkit.org/show_bug.cgi?id=62236
289 * public/WebAccessibilityObject.h:
290 * src/WebAccessibilityObject.cpp:
291 (WebKit::WebAccessibilityObject::lineBreaks):
293 2011-06-08 Ilya Tikhonovsky <loislo@chromium.org>
295 Unreviewed chromium build fix for r88332.
297 * src/WebRuntimeFeatures.cpp:
299 2011-06-08 Hironori Bono <hbono@chromium.org>
301 Reviewed by Brent Fulgham.
304 https://bugs.webkit.org/show_bug.cgi?id=59693
306 This change adds two SpellCheck API functions (addSpellcheckRange and
307 removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
308 the public-webapps ML. This change is currently available only on Chromium.
311 * public/WebRuntimeFeatures.h:
312 * src/ContextMenuClientImpl.cpp:
313 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
314 * src/WebRuntimeFeatures.cpp:
315 (WebKit::WebRuntimeFeatures::enableSpellCheckAPI):
316 (WebKit::WebRuntimeFeatures::isSpellCheckAPIEnabled):
318 2011-06-07 James Kozianski <koz@chromium.org>
320 [Chromium] Unreviewed. Disable SelectItemEvenFire that fails on
323 * tests/PopupMenuTest.cpp:
326 2011-06-07 Robert Kroeger <rjkroege@chromium.org>
328 Reviewed by Adam Barth.
330 [chromium] Add a basic gesture recognizer to the Chromium platform
331 https://bugs.webkit.org/show_bug.cgi?id=54417
333 Added unit tests for the basic chromium platform gesture recognizer.
335 * tests/InnerGestureRecognizerTest.cpp: Added.
336 (WebCore::InspectableInnerGestureRecognizer::InspectableInnerGestureRecognizer):
337 (WebCore::InspectableInnerGestureRecognizer::signature):
338 (WebCore::InspectableInnerGestureRecognizer::firstTouchPosition):
339 (WebCore::InspectableInnerGestureRecognizer::setFirstTouchTime):
340 (WebCore::InspectableInnerGestureRecognizer::firstTouchTime):
341 (WebCore::InspectableInnerGestureRecognizer::setLastTouchTime):
342 (WebCore::InspectableInnerGestureRecognizer::lastTouchTime):
343 (WebCore::InspectableInnerGestureRecognizer::edgeFunction):
344 (WebCore::InspectableInnerGestureRecognizer::updateValues):
345 (WebCore::InspectableInnerGestureRecognizer::addEdgeFunction):
346 (WebCore::BuildablePlatformTouchPoint::setX):
347 (WebCore::BuildablePlatformTouchPoint::setY):
348 (WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
349 (WebCore::TestGestureRecognizer::TestGestureRecognizer):
350 (WebCore::TestGestureRecognizer::SetUp):
351 (WebCore::TestGestureRecognizer::TearDown):
354 2011-06-07 Vangelis Kokkevis <vangelis@chromium.org>
356 Reviewed by James Robinson.
358 Disable compositing for RTL pages in the RenderLayerCompositor rather
359 than later on in the WebViewImpl.
360 https://bugs.webkit.org/show_bug.cgi?id=62246
362 * src/ChromeClientImpl.cpp:
363 (WebKit::ChromeClientImpl::allowedCompositingTriggers):
364 * src/WebViewImpl.cpp:
365 (WebKit::WebViewImpl::layout):
366 (WebKit::WebViewImpl::setRootGraphicsLayer):
368 2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com>
370 Unreviewed, rolling out r88254, r88262, and r88268.
371 http://trac.webkit.org/changeset/88254
372 http://trac.webkit.org/changeset/88262
373 http://trac.webkit.org/changeset/88268
374 https://bugs.webkit.org/show_bug.cgi?id=62234
376 I fail at changing features.gypi (Requested by abarth on
381 2011-06-07 Adam Barth <abarth@webkit.org>
383 Reviewed by Tony Chang.
385 Fix "branding" issue in features.gypi
386 https://bugs.webkit.org/show_bug.cgi?id=62229
388 Apparently we need to move the conditional block further out of the
389 nesting in order to see the branding variable. This patch also remove
390 the dummy branding variable I added to get the buildbot building again.
394 2011-06-07 Adam Barth <abarth@webkit.org>
396 Attempt to fix the cr-win build.
400 2011-06-07 Adam Barth <abarth@webkit.org>
402 Reviewed by Dimitri Glazkov.
404 Synchronize features.gypi and features_override.gypi in preparation for removing features_override.gypi
405 https://bugs.webkit.org/show_bug.cgi?id=62135
407 After this patch is rolled into Chromium, we should be able to delete
408 features_override.gyp downstream. Once we do that, we can simplify
409 this file somewhat by removing at least on level of nesting.
413 2011-06-03 Yury Semikhatsky <yurys@chromium.org>
415 Reviewed by Pavel Feldman.
417 [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
418 https://bugs.webkit.org/show_bug.cgi?id=62019
420 Dispatch disconnecFrontend message in debugger task mode to make sure
421 it is processed even if execution is paused.
423 * src/WebWorkerImpl.cpp:
424 (WebKit::WebWorkerImpl::detachDevTools):
425 (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
427 2011-06-07 Naoki Takano <takano.naoki@gmail.com>
429 Reviewed by Kent Tamura.
431 [Chromium] Click event is not fired for a menulist <select>
432 https://bugs.webkit.org/show_bug.cgi?id=60563
434 * tests/PopupMenuTest.cpp:
435 (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node.
436 (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList.
437 (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not.
438 (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item.
439 (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event.
440 (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL.
441 (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call.
442 (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL().
443 (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests().
444 (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string.
445 (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
446 * tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
447 * tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
448 * tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
449 * WebKit.gyp: Added PopupMenuTest.cpp. Because webkit_support dependency is added, we can't build PopupMenuTest.cpp with Chromium-win (shared) configuration.
451 2011-06-06 Nico Weber <thakis@chromium.org>
453 Reviewed by James Robinson.
455 [chromium] Make WebViewImpl's destructor virtual
456 https://bugs.webkit.org/show_bug.cgi?id=62155
458 This is _not_ to fix a real bug, just to make clang's
459 -Wdelete-non-virtual-dtor happy. As discussed at
460 http://codereview.chromium.org/7094005/, we prefer making leaf class
461 destructors virtual over making the leaf classes final.
465 2011-06-06 Daniel Cheng <dcheng@chromium.org>
467 Reviewed by Tony Chang.
469 [chromium] Delete dead clipboard code.
470 https://bugs.webkit.org/show_bug.cgi?id=62113
472 * src/WebDragData.cpp:
474 2011-06-06 Nico Weber <thakis@chromium.org>
476 Reviewed by James Robinson.
478 [chromium] Make WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's destructors virtual
479 https://bugs.webkit.org/show_bug.cgi?id=62148
481 This is _not_ to fix a real bug, just to make clang's
482 -Wdelete-non-virtual-dtor happy. As discussed at
483 http://codereview.chromium.org/7094005/, we prefer making leaf class
484 destructors virtual over making the leaf classes final.
486 * src/WebURLRequest.cpp:
487 (WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
488 * src/WebURLResponse.cpp:
489 (WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
491 2011-06-06 Shishir Agrawal <shishir@chromium.org>
493 Reviewed by Tony Gentilcore.
495 Add a "prerender" state for page visibility.
496 https://bugs.webkit.org/show_bug.cgi?id=62062
498 * public/WebPageVisibilityState.h:
499 * src/AssertMatchingEnums.cpp:
500 * src/WebViewImpl.cpp:
501 (WebKit::WebViewImpl::setVisibilityState):
503 2011-06-06 Nico Weber <thakis@chromium.org>
505 Reviewed by Dimitri Glazkov.
507 webkit/glue/webmediaplayer_impl.cc deletes an object of type
508 WebVideoFrame, which means this patch fixes a real bug, not just
511 [chromium] Give WebVideoFrame a virtual destructor
512 https://bugs.webkit.org/show_bug.cgi?id=61742
514 * public/WebVideoFrame.h:
515 (WebKit::WebVideoFrame::~WebVideoFrame):
517 2011-06-04 Nico Weber <thakis@chromium.org>
519 Reviewed by James Robinson.
521 [chromium] Make ResourceHandleInternal's destructor virtual
522 https://bugs.webkit.org/show_bug.cgi?id=62073
524 This is _not_ to fix a real bug, just to make clang's
525 -Wdelete-non-virtual-dtor happy. As discussed at
526 http://codereview.chromium.org/7094005/, we prefer making leaf class
527 destructors virtual over making the leaf classes final.
529 * src/ResourceHandle.cpp:
530 (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
532 2011-06-04 Nico Weber <thakis@chromium.org>
534 Reviewed by James Robinson.
536 [chromium] Make ChromePrintContext's destructor virtual
537 https://bugs.webkit.org/show_bug.cgi?id=62076
539 Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
540 that is dynamically set to either a ChromePrintContext or a
541 ChromePluginPrintContext, this fixes an actual bug.
543 * src/WebFrameImpl.cpp:
544 (WebKit::ChromePrintContext::~ChromePrintContext):
545 (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
547 2011-06-04 Nico Weber <thakis@chromium.org>
549 Reviewed by James Robinson.
551 [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
552 https://bugs.webkit.org/show_bug.cgi?id=62074
554 This is _not_ to fix a real bug, just to make clang's
555 -Wdelete-non-virtual-dtor happy. As discussed at
556 http://codereview.chromium.org/7094005/, we prefer making leaf class
557 destructors virtual over making the leaf classes final.
559 * src/WebTextCheckingCompletionImpl.h:
560 (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
562 2011-06-04 Nico Weber <thakis@chromium.org>
564 Reviewed by James Robinson.
566 [chromium] Make PlatformMessagePortChannel's destructor virtual
567 https://bugs.webkit.org/show_bug.cgi?id=62072
569 This is _not_ to fix a real bug, just to make clang's
570 -Wdelete-non-virtual-dtor happy. As discussed at
571 http://codereview.chromium.org/7094005/, we prefer making leaf class
572 destructors virtual over making the leaf classes final.
574 * src/PlatformMessagePortChannel.h:
576 2011-06-04 Nico Weber <thakis@chromium.org>
578 Reviewed by James Robinson.
580 [chromium] Give VoidCallbackClient a virtual destructor
581 https://bugs.webkit.org/show_bug.cgi?id=62067
583 This is _not_ to fix a real bug, just to make clang's
584 -Wdelete-non-virtual-dtor happy. As discussed at
585 http://codereview.chromium.org/7094005/, we prefer making leaf class
586 destructors virtual over making the leaf classes final.
588 * src/NotificationPresenterImpl.cpp:
589 (WebKit::VoidCallbackClient::~VoidCallbackClient):
591 2011-06-04 Nico Weber <thakis@chromium.org>
593 Reviewed by James Robinson.
595 [chromium] Make WebFrameImpl destructor virtual
596 https://bugs.webkit.org/show_bug.cgi?id=62065
598 This is _not_ to fix a real bug, just to make clang's
599 -Wdelete-non-virtual-dtor happy. As discussed at
600 http://codereview.chromium.org/7094005/, we prefer making leaf class
601 destructors virtual over making the leaf classes final.
603 * src/WebFrameImpl.h:
605 2011-06-03 Philippe Beauchamp <philippe.beauchamp@gmail.com>
607 Reviewed by Dimitri Glazkov.
609 Add the feature "Add as search engine..." in a search text field context menu for chromium
610 https://bugs.webkit.org/show_bug.cgi?id=47980
612 * public/WebContextMenuData.h:
613 * public/WebSearchableFormData.h:
614 * src/ContextMenuClientImpl.cpp:
615 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
616 * src/WebSearchableFormData.cpp:
617 (WebKit::WebSearchableFormData::WebSearchableFormData):
619 2011-06-03 Naoki Takano <takano.naoki@gmail.com>
621 Reviewed by Eric Seidel.
623 [Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
624 https://bugs.webkit.org/show_bug.cgi?id=61260
625 http://code.google.com/p/chromium/issues/detail?id=12721
627 * public/WebMenuItemInfo.h: Add toolTip.
628 * public/WebViewClient.h: Remove setToolTipText().
629 * public/WebWidgetClient.h: Add setTooTipText().
630 (WebKit::WebWidgetClient::setToolTipText):
631 * src/ExternalPopupMenu.cpp:
632 (WebKit::ExternalPopupMenu::getPopupMenuInfo): Add popupItem.toolTip set.
633 * src/WebPopupMenuImpl.cpp:
634 (WebKit::WebPopupMenuImpl::MouseMove): Call setToolTipText().
636 2011-06-03 Hans Wennborg <hans@chromium.org>
638 Reviewed by Steve Block.
640 IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
641 https://bugs.webkit.org/show_bug.cgi?id=62009
643 Don't use INT64_MAX, use the various encodeMaxKey() functions instead.
645 * tests/IDBLevelDBCodingTest.cpp:
646 (IDBLevelDBCoding::TEST):
648 2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
650 Reviewed by Yury Semikhatsky.
652 Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
653 https://bugs.webkit.org/show_bug.cgi?id=61533
655 Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
657 * public/WebDevToolsAgent.h:
658 * src/WebDevToolsAgentImpl.cpp:
659 (WebKit::WebDevToolsAgentImpl::setJavaScriptProfilingEnabled):
660 * src/WebDevToolsAgentImpl.h:
662 2011-06-02 Yury Semikhatsky <yurys@chromium.org>
664 Reviewed by Pavel Feldman.
666 Web Inspector: add an option for automatically attaching to new workers
667 https://bugs.webkit.org/show_bug.cgi?id=61930
669 Notification about worker context termination are now sent to the inspector.
671 * src/WebWorkerClientImpl.cpp:
672 (WebKit::WebWorkerClientImpl::terminateWorkerContext):
673 (WebKit::WebWorkerClientImpl::disconnectFromInspector):
674 (WebKit::WebWorkerClientImpl::workerContextDestroyed):
676 2011-06-02 Aaron Colwell <acolwell@chromium.org>
678 Reviewed by David Levin.
680 Add mediaTimeForTimeValue() implementation.
681 https://bugs.webkit.org/show_bug.cgi?id=61555
683 * public/WebMediaPlayer.h:
684 * src/WebMediaPlayerClientImpl.cpp:
685 (WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
686 * src/WebMediaPlayerClientImpl.h:
688 2011-06-02 Jay Civelli <jcivelli@chromium.org>
690 Reviewed by Adam Barth.
692 Adding MHTML generation support to MHTMLArchive.
693 https://bugs.webkit.org/show_bug.cgi?id=7169
695 * public/WebPageSerializer.h:
696 * src/WebPageSerializer.cpp:
697 (WebKit::WebPageSerializer::serializeToMHTML):
699 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
701 Reviewed by Darin Adler.
703 Add build logistics and plumbing for window.internals object.
704 https://bugs.webkit.org/show_bug.cgi?id=60313
706 * WebKit.gyp: Added linking new webkit_test_support library.
707 * public/WebTestingSupport.h: Added.
708 * src/WebTestingSupport.cpp: Added.
710 2011-06-02 Aaron Colwell <acolwell@chromium.org>
712 Reviewed by David Levin.
714 Update chromium version
715 https://bugs.webkit.org/show_bug.cgi?id=61555
719 2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
721 Unreviewed, rolling out r87920.
722 http://trac.webkit.org/changeset/87920
723 https://bugs.webkit.org/show_bug.cgi?id=61943
725 This patch does not build in Win Builder (dbg)(shared)
726 downstream (Requested by abarth|gardener on #webkit).
728 * tests/PopupMenuTest.cpp:
729 (WebKit::TestPopupMenuClient::TestPopupMenuClient):
730 (WebKit::TestPopupMenuClient::valueChanged):
731 (WebKit::TestPopupMenuClient::itemIsEnabled):
732 (WebKit::SelectPopupMenuTest::TearDown):
733 * tests/data/popup/select_event.html: Removed.
734 * tests/data/popup/select_event_remove_on_change.html: Removed.
735 * tests/data/popup/select_event_remove_on_click.html: Removed.
737 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
739 Unreviewed, rolling out r87926.
740 http://trac.webkit.org/changeset/87926
741 https://bugs.webkit.org/show_bug.cgi?id=60313
743 Fails to find WebCoreTestSupport.dylib on bots.
746 * public/WebTestingSupport.h: Removed.
747 * src/WebTestingSupport.cpp: Removed.
749 2011-06-02 Aaron Colwell <acolwell@chromium.org>
751 Reviewed by Dimitri Glazkov.
753 Bring gyp_webkit up to date with changes made to
754 gyp_chromium so chromium_rev can be advanced past
756 https://bugs.webkit.org/show_bug.cgi?id=61881
760 2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
762 Reviewed by Darin Adler.
764 Add build logistics and plumbing for window.internals object.
765 https://bugs.webkit.org/show_bug.cgi?id=60313
767 * WebKit.gyp: Added linking new webkit_test_support library.
768 * public/WebTestingSupport.h: Added.
769 * src/WebTestingSupport.cpp: Added.
771 2011-06-02 Naoki Takano <takano.naoki@gmail.com>
773 Reviewed by Dimitri Glazkov.
775 [Chromium] Click event is not fired for a menulist <select>
776 https://bugs.webkit.org/show_bug.cgi?id=60563
778 * tests/PopupMenuTest.cpp:
779 (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node.
780 (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList.
781 (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not.
782 (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item.
783 (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event.
784 (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL.
785 (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call.
786 (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL().
787 (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests().
788 (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string.
789 (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
790 * tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
791 * tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
792 * tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
794 2011-06-01 Adrienne Walker <enne@google.com>
796 Reviewed by James Robinson.
798 [chromium] Fix syncing of removed mask and replica layers
799 https://bugs.webkit.org/show_bug.cgi?id=61895
801 * tests/TreeSynchronizerTest.cpp:
804 2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
806 Unreviewed, rolling out r87788.
807 http://trac.webkit.org/changeset/87788
808 https://bugs.webkit.org/show_bug.cgi?id=61856
810 breaks windows chromium canary (Requested by jknotten on
813 * public/WebPageSerializer.h:
814 * src/WebPageSerializer.cpp:
816 2011-06-01 Jay Civelli <jcivelli@chromium.org>
818 Reviewed by Adam Barth.
820 Adding MHTML generation support to MHTMLArchive.
821 https://bugs.webkit.org/show_bug.cgi?id=7169
823 * public/WebPageSerializer.h:
824 * src/WebPageSerializer.cpp:
825 (WebKit::WebPageSerializer::serializeToMHTML):
827 2011-06-01 Mikhail Naganov <mnaganov@chromium.org>
829 Reviewed by Yury Semikhatsky.
831 Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
832 https://bugs.webkit.org/show_bug.cgi?id=61803
835 * scripts/generate_devtools_zip.py:
837 2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>
839 Unreviewed, rolling out r87781.
840 http://trac.webkit.org/changeset/87781
841 https://bugs.webkit.org/show_bug.cgi?id=61842
843 breaks chromium linux release (Requested by mnaganov on
847 * scripts/generate_devtools_zip.py:
849 2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
851 Reviewed by Pavel Feldman.
853 Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
854 https://bugs.webkit.org/show_bug.cgi?id=61803
857 * scripts/generate_devtools_zip.py:
859 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>
861 Reviewed by Kent Tamura.
863 [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
864 https://bugs.webkit.org/show_bug.cgi?id=61823
866 Fixed assertion on errorCallback parameter.
868 Test: storage/quotainfo-no-callbacks.html
870 * src/StorageInfoChromium.cpp:
871 (WebCore::StorageInfo::queryUsageAndQuota):
872 (WebCore::StorageInfo::requestQuota):
874 2011-05-31 Daniel Erat <derat@chromium.org>
876 Reviewed by Tony Chang.
878 Make WebScreenInfoFactory return fresh screen dimensions.
879 https://bugs.webkit.org/show_bug.cgi?id=61679
881 * public/x11/WebScreenInfoFactory.h:
882 * src/x11/WebScreenInfoFactory.cpp:
883 (WebKit::WebScreenInfoFactory::screenInfo):
885 2011-05-31 Cary Clark <caryclark@google.com>
887 Reviewed by Eric Seidel.
889 Allow Chromium porting layer to use Skia on Mac.
890 https://bugs.webkit.org/show_bug.cgi?id=61548
892 * public/WebCommon.h:
893 Don't allow WebKit to use CG if it is already using Skia.
895 * src/PlatformBridge.cpp:
896 (WebCore::PlatformBridge::paintScrollbarThumb):
897 Allow scrollbar thumb draw to take WebCanvas.
899 2011-05-27 Jochen Eisinger <jochen@chromium.org>
901 Reviewed by Adam Barth.
903 Check access policy on all storage operations
904 https://bugs.webkit.org/show_bug.cgi?id=61581
906 * src/StorageAreaProxy.cpp:
907 (WebCore::StorageAreaProxy::length):
908 (WebCore::StorageAreaProxy::key):
909 (WebCore::StorageAreaProxy::getItem):
910 (WebCore::StorageAreaProxy::setItem):
911 (WebCore::StorageAreaProxy::removeItem):
912 (WebCore::StorageAreaProxy::clear):
913 (WebCore::StorageAreaProxy::contains):
914 (WebCore::StorageAreaProxy::canAccessStorage):
915 * src/StorageAreaProxy.h:
916 * src/WebStorageAreaImpl.cpp:
917 (WebKit::WebStorageAreaImpl::length):
918 (WebKit::WebStorageAreaImpl::key):
919 (WebKit::WebStorageAreaImpl::getItem):
921 2011-05-27 Jochen Eisinger <jochen@chromium.org>
923 Reviewed by Darin Fisher.
925 [chromium] drop unused WebFrame parameter to WebStorageArea::setItem
926 https://bugs.webkit.org/show_bug.cgi?id=61583
928 * public/WebStorageArea.h:
929 * src/StorageAreaProxy.cpp:
930 (WebCore::StorageAreaProxy::setItem):
931 * src/WebStorageAreaImpl.cpp:
932 (WebKit::WebStorageAreaImpl::setItem):
933 * src/WebStorageAreaImpl.h:
935 2011-05-27 David Levin <levin@chromium.org>
937 Reviewed by Darin Fisher.
939 Need a callback for when the preferred rendered size may have changed.
940 https://bugs.webkit.org/show_bug.cgi?id=61309
942 * public/WebFrameClient.h:
943 (WebKit::WebFrameClient::didUpdateLayout): Added stub.
944 * src/ChromeClientImpl.cpp:
945 (WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.
946 * src/ChromeClientImpl.h: Added declaration.
948 2011-05-27 Shishir Agrawal <shishir@chromium.org>
950 Reviewed by Tony Gentilcore.
952 Enable Page Visibility API in the chromium port.
953 https://bugs.webkit.org/show_bug.cgi?id=61397
957 2011-05-26 Mihai Parparita <mihaip@chromium.org>
959 Reviewed by Adam Barth.
961 Fix worldID and destinationDomain argument names
962 https://bugs.webkit.org/show_bug.cgi?id=61571
964 As part of working on r87423, I noticed a couple of inconsistencies in
966 - We would use worldId in .h files but worldID in .cpp files.
967 Standardize on the latter
968 - SecurityOrigin::addOriginAccessWhitelistEntry would take a
969 destinationDomains argument, even though the actual parameter was for
970 a single domain (renamed to be singular).
973 * src/WebFrameImpl.cpp:
974 (WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
975 (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
976 * src/WebFrameImpl.h:
978 2011-05-26 Leandro Gracia Gil <leandrogracia@chromium.org>
980 Reviewed by Dmitry Titov.
982 Add missing compile guards for WebWorkers in WebKit.
983 https://bugs.webkit.org/show_bug.cgi?id=61536
985 * src/DatabaseObserver.cpp:
986 (WebCore::DatabaseObserver::canEstablishDatabase):
987 * src/LocalFileSystemChromium.cpp:
988 (WebCore::openFileSystemHelper):
989 * src/PlatformBridge.cpp:
990 * src/WebFileSystemCallbacksImpl.cpp:
991 (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem):
992 * src/WorkerAsyncFileSystemChromium.cpp:
993 * src/WorkerAsyncFileSystemChromium.h:
994 * src/WorkerAsyncFileWriterChromium.cpp:
995 * src/WorkerAsyncFileWriterChromium.h:
996 * src/WorkerFileSystemCallbacksBridge.cpp:
997 * src/WorkerFileSystemCallbacksBridge.h:
998 * src/WorkerFileWriterCallbacksBridge.cpp:
999 * src/WorkerFileWriterCallbacksBridge.h:
1001 2011-05-26 Evan Martin <evan@chromium.org>
1003 Reviewed by Tony Chang.
1005 [chromium] simplify TestNetscapePlugIn naming logic
1006 https://bugs.webkit.org/show_bug.cgi?id=61577
1008 * WebKit.gyp: drop use of product_prefix, just use the name
1011 2011-05-26 Sheriff Bot <webkit.review.bot@gmail.com>
1013 Unreviewed, rolling out r87444.
1014 http://trac.webkit.org/changeset/87444
1015 https://bugs.webkit.org/show_bug.cgi?id=61582
1017 Layout test regressions in Chromium/WebKit: fast/css/first-
1018 letter-text-fragment-crash.html, fast/css/first-letter-
1019 visibility.html (Requested by aklein on #webkit).
1021 * public/WebFrameClient.h:
1022 * src/ChromeClientImpl.cpp:
1023 * src/ChromeClientImpl.h:
1025 2011-05-26 David Levin <levin@chromium.org>
1027 Reviewed by Darin Fisher.
1029 Need a callback for when the preferred rendered size changed.
1030 https://bugs.webkit.org/show_bug.cgi?id=61309
1032 * public/WebFrameClient.h
1033 (WebKit::WebFrameClient::didChangeContentsPreferredSize): Added stub.
1034 * src/ChromeClientImpl.h:
1035 (WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added declaration.
1036 * src/ChromeClientImpl.cpp:
1037 (WebKit::ChromeClientImpl::contentsPreferredSizeChanged): Added call to WebFrameClient::didChangeContentsPreferredSize.
1039 2011-05-26 Mihai Parparita <mihaip@chromium.org>
1041 Reviewed by Adam Barth.
1043 Support cross-origin XMLHttpRequest in isolated worlds
1044 https://bugs.webkit.org/show_bug.cgi?id=59843
1046 Expose setIsolatedWorldSecurityOrigin in the WebFrame API.
1048 * public/WebFrame.h:
1049 * src/WebFrameImpl.cpp:
1050 (WebKit::WebFrameImpl::setIsolatedWorldSecurityOrigin):
1051 * src/WebFrameImpl.h:
1053 2011-05-26 Michael Nordman <michaeln@google.com>
1055 Reviewed by Darin Fisher.
1057 [Chromium] Use SecurityOrigin produced databaseIdentifier strings, instead of
1058 SecurityOrigin RefPtrs, as the top level key into the DatabaseTracker's
1059 collection of open databases. Otherwise we can fail to lookup databases when
1060 trying to forceably close them via WebDatabase::closeDatabaseImmediately.
1061 https://bugs.webkit.org/show_bug.cgi?id=61417
1063 * src/WebDatabase.cpp:
1064 (WebKit::WebDatabase::closeDatabaseImmediately):
1066 2011-05-26 Sailesh Agrawal <sail@chromium.org>
1068 Reviewed by Tony Chang.
1070 Expose willStartLiveResize and willEndLiveResize in WebWidget
1071 https://bugs.webkit.org/show_bug.cgi?id=60518
1073 * public/WebWidget.h:
1074 * src/WebPopupMenuImpl.cpp:
1075 (WebKit::WebPopupMenuImpl::willStartLiveResize):
1076 (WebKit::WebPopupMenuImpl::willEndLiveResize):
1077 * src/WebPopupMenuImpl.h:
1078 * src/WebViewImpl.cpp:
1079 (WebKit::WebViewImpl::willStartLiveResize):
1080 (WebKit::WebViewImpl::willEndLiveResize):
1081 * src/WebViewImpl.h:
1083 2011-05-25 Shishir Agrawal <shishir@chromium.org>
1085 Reviewed by Dimitri Glazkov.
1087 Fix crash in Chromium memory test.
1088 https://bugs.webkit.org/show_bug.cgi?id=61451
1090 * src/WebViewImpl.cpp:
1091 (WebKit::WebViewImpl::WebViewImpl):
1093 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
1095 Unreviewed, rolling out r87333.
1096 http://trac.webkit.org/changeset/87333
1097 https://bugs.webkit.org/show_bug.cgi?id=61488
1099 Breaks Chromium build due to pure virtual methods. (Requested
1100 by aklein on #webkit).
1102 * public/WebWidget.h:
1103 * src/WebPopupMenuImpl.cpp:
1104 * src/WebPopupMenuImpl.h:
1105 * src/WebViewImpl.cpp:
1106 * src/WebViewImpl.h:
1108 2011-05-25 Sailesh Agrawal <sail@chromium.org>
1110 Reviewed by Darin Fisher.
1112 Expose willStartLiveResize and willEndLiveResize in WebWidget
1113 https://bugs.webkit.org/show_bug.cgi?id=60518
1115 * public/WebWidget.h:
1116 * src/WebPopupMenuImpl.cpp:
1117 (WebKit::WebPopupMenuImpl::willStartLiveResize):
1118 (WebKit::WebPopupMenuImpl::willEndLiveResize):
1119 * src/WebPopupMenuImpl.h:
1120 * src/WebViewImpl.cpp:
1121 (WebKit::WebViewImpl::willStartLiveResize):
1122 (WebKit::WebViewImpl::willEndLiveResize):
1123 * src/WebViewImpl.h:
1125 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
1127 Unreviewed, rolling out r87257.
1128 http://trac.webkit.org/changeset/87257
1129 https://bugs.webkit.org/show_bug.cgi?id=61457
1131 This broke layout tests, see bug 61431. (Requested by
1132 hwennborg on #webkit).
1134 * public/WebIDBFactory.h:
1135 * src/AssertMatchingEnums.cpp:
1136 * src/IDBFactoryBackendProxy.cpp:
1137 * src/IDBFactoryBackendProxy.h:
1138 * src/WebIDBFactoryImpl.cpp:
1139 (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
1140 (WebKit::WebIDBFactoryImpl::open):
1141 * src/WebIDBFactoryImpl.h:
1143 2011-05-24 Keishi Hattori <keishi@webkit.org>
1145 Reviewed by Kent Tamura.
1147 Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1148 https://bugs.webkit.org/show_bug.cgi?id=61273
1150 * features.gypi: Added INPUT_COLOR feature flag.
1152 2011-05-24 Adam Barth <abarth@webkit.org>
1154 Reviewed by Eric Seidel.
1156 Add FIXME comments about removing FrameLoader::isProcessingUserGesture
1157 https://bugs.webkit.org/show_bug.cgi?id=61395
1159 * src/FrameLoaderClientImpl.cpp:
1160 (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
1161 * src/WebFrameImpl.cpp:
1162 (WebKit::WebFrameImpl::isProcessingUserGesture):
1164 2011-05-24 Greg Simon <gregsimon@chromium.org>
1166 Reviewed by Dimitri Glazkov.
1168 Control Indexeddb backends from LayoutTestController
1169 https://bugs.webkit.org/show_bug.cgi?id=61000
1171 * public/WebIDBFactory.h:
1172 (WebKit::WebIDBFactory::setEnableMigration):
1173 * src/AssertMatchingEnums.cpp:
1174 * src/IDBFactoryBackendProxy.cpp:
1175 (WebKit::IDBFactoryBackendProxy::setEnableMigration):
1176 * src/IDBFactoryBackendProxy.h:
1177 * src/WebIDBFactoryImpl.cpp:
1178 (WebKit::WebIDBFactory::setOverrideBackingStoreType):
1179 (WebKit::WebIDBFactory::setTemporaryDatabaseFolder):
1180 (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
1181 (WebKit::WebIDBFactoryImpl::open):
1182 (WebKit::WebIDBFactoryImpl::setEnableMigration):
1183 * src/WebIDBFactoryImpl.h:
1185 2011-05-24 Jay Civelli <jcivelli@chromium.org>
1187 Reviewed by Adam Barth.
1189 Adding MHTML reading support to WebCore.
1190 https://bugs.webkit.org/show_bug.cgi?id=7168
1194 2011-05-24 Alok Priyadarshi <alokp@chromium.org>
1196 Reviewed by James Robinson.
1198 Enable skia gpu rendering for content layers
1199 https://bugs.webkit.org/show_bug.cgi?id=56749
1201 * src/WebViewImpl.cpp:
1202 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1203 (WebKit::WebViewImpl::reallocateRenderer):
1205 2011-05-24 Mikhail Naganov <mnaganov@chromium.org>
1207 Reviewed by Yury Semikhatsky.
1209 Web Inspector: Reorganize InspectorBackendDispatch code to eliminate duplication
1210 https://bugs.webkit.org/show_bug.cgi?id=61300
1212 * src/WebDevToolsAgentImpl.cpp:
1213 (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
1215 2011-05-23 Gavin Peters <gavinp@chromium.org>
1217 Reviewed by Adam Barth.
1219 fix rel=prerender target types
1220 https://bugs.webkit.org/show_bug.cgi?id=61297
1222 The original fix in https://bugs.webkit.org/show_bug.cgi?id=61079
1223 didn't properly map the target type, and didn't carry the target
1224 types through to chromium properly. Fixed.
1226 No new tests; it's very hard to catch these with a layout test, however
1227 all of the chromium Prerender browser tests will test this functionality
1228 when I land an upcoming chromium CL.
1230 * public/WebURLRequest.h:
1232 2011-05-23 Tony Chang <tony@chromium.org>
1234 Reviewed by James Robinson.
1236 [chromium] Link tcmalloc to DRT so we can use the heap checker
1237 https://bugs.webkit.org/show_bug.cgi?id=61292
1241 2011-05-23 Adrienne Walker <enne@google.com>
1243 Reviewed by James Robinson.
1245 [chromium] Fix division by zero in TilingData for boundary case texture sizes
1246 https://bugs.webkit.org/show_bug.cgi?id=61164
1248 Add additional tests for small max texture sizes.
1250 * tests/TilingDataTest.cpp:
1253 2011-05-23 Ruben <chromium@hybridsource.org>
1255 Reviewed by Tony Chang.
1257 Chromium gyp patch to use new POSIX defines toolkit_uses_gtk and os_posix
1258 https://bugs.webkit.org/show_bug.cgi?id=61219
1263 2011-05-23 Yury Semikhatsky <yurys@chromium.org>
1265 Reviewed by Pavel Feldman.
1267 [Chromium] Web Inspector: provide initial implementation of worker inspector transport
1268 https://bugs.webkit.org/show_bug.cgi?id=60267
1270 WebWorker and WebWorkerClient are extended with methods for passing
1271 DevTools messages between worker context inspector and page inspector.
1273 * public/WebWorker.h:
1274 (WebKit::WebWorker::attachDevTools):
1275 (WebKit::WebWorker::detachDevTools):
1276 (WebKit::WebWorker::dispatchDevToolsMessage):
1277 * public/WebWorkerClient.h:
1278 (WebKit::WebWorkerClient::dispatchDevToolsMessage):
1279 * src/WebWorkerBase.cpp:
1280 (WebKit::WebWorkerBase::postMessageToPageInspector):
1281 (WebKit::WebWorkerBase::postMessageToPageInspectorTask):
1282 * src/WebWorkerBase.h:
1283 * src/WebWorkerClientImpl.cpp:
1284 (WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
1285 (WebKit::WebWorkerClientImpl::connectToInspector):
1286 (WebKit::WebWorkerClientImpl::disconnectFromInspector):
1287 (WebKit::WebWorkerClientImpl::sendMessageToInspector):
1288 (WebKit::WebWorkerClientImpl::dispatchDevToolsMessage):
1289 * src/WebWorkerClientImpl.h:
1290 * src/WebWorkerImpl.cpp:
1291 (WebKit::WebWorkerImpl::startWorkerContext):
1292 (WebKit::connectToWorkerContextInspectorTask):
1293 (WebKit::WebWorkerImpl::attachDevTools):
1294 (WebKit::disconnectFromWorkerContextInspectorTask):
1295 (WebKit::WebWorkerImpl::detachDevTools):
1296 (WebKit::dispatchOnInspectorBackendTask):
1297 (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
1298 * src/WebWorkerImpl.h:
1300 2011-05-22 Greg Simon <gregsimon@chromium.org>
1302 Reviewed by Darin Fisher.
1304 [chromium] Updating chromium DEPS
1306 https://bugs.webkit.org/show_bug.cgi?id=61236
1310 2011-05-21 Jochen Eisinger <jochen@chromium.org>
1312 Reviewed by Darin Fisher.
1314 [chromium] add extraData field to resource requests
1315 https://bugs.webkit.org/show_bug.cgi?id=61033
1318 * public/WebURLRequest.h:
1319 (WebKit::WebURLRequest::ExtraData::~ExtraData):
1320 * src/WebURLRequest.cpp:
1321 (WebKit::WebURLRequest::extraData):
1322 (WebKit::WebURLRequest::setExtraData):
1323 * tests/WebURLRequestTest.cpp: Added.
1324 (WebKit::TestExtraData::TestExtraData):
1325 (WebKit::TestExtraData::~TestExtraData):
1328 2011-05-20 Michael Nordman <michaeln@google.com>
1330 Reviewed by Darin Fisher.
1332 Changes to allow the WebDatabase system to participate in Chrome's unified quota
1333 management system. Now that changes outside of the database system affect the space
1334 available to the database system, we need new ways of getting the limit to renderers.
1336 Split WebDatabase::updateDatabaseSizeAndSpaceAvailable() into three methods.
1337 - WebDatabase::updateDatababaseSize()
1338 - WebDatabase::updateSpaceAvailable()
1339 - WebDatabase::resetSpaceAvailable()
1340 The WebDatabase methods are used to 'push' size and space available info into renderers.
1341 The space available can change independently of a database having changed size.
1343 Also provide a means for the renderer to 'pull' the space available from the main
1344 process if that value has not been pushed into it.
1345 - WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin()
1346 - WebKit::WebKitClient::databaseGetSpaceAvailableForOrigin()
1348 https://bugs.webkit.org/show_bug.cgi?id=60985
1350 * public/WebDatabase.h:
1351 * public/WebKitClient.h:
1352 (WebKit::WebKitClient::databaseGetSpaceAvailableForOrigin):
1353 * src/PlatformBridge.cpp:
1354 (WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin):
1355 * src/WebDatabase.cpp:
1356 (WebKit::WebDatabase::updateDatabaseSize):
1357 (WebKit::WebDatabase::updateSpaceAvailable):
1358 (WebKit::WebDatabase::resetSpaceAvailable):
1360 2011-05-20 Simon Fraser <simon.fraser@apple.com>
1362 Reviewed by Sam Weinig.
1364 numberOfActiveAnimations() can include animations from documents in the page cache
1365 https://bugs.webkit.org/show_bug.cgi?id=53641
1367 Pass the Frame's document as the one to count animations on.
1369 * src/WebAnimationControllerImpl.cpp:
1370 (WebKit::WebAnimationControllerImpl::numberOfActiveAnimations):
1372 2011-05-19 Evan Martin <evan@chromium.org>
1374 Reviewed by Tony Chang.
1376 [chromium] remove <(library) variable
1377 https://bugs.webkit.org/show_bug.cgi?id=61158
1379 This was for a build experiment; we can just use the correct value now.
1383 2011-05-20 Vitaly Repeshko <vitalyr@chromium.org>
1387 [chromium] Updating chromium DEPS.
1391 2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
1393 Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1394 http://trac.webkit.org/changeset/86869
1395 http://trac.webkit.org/changeset/86873
1396 http://trac.webkit.org/changeset/86875
1397 http://trac.webkit.org/changeset/86877
1398 https://bugs.webkit.org/show_bug.cgi?id=61139
1400 broke builds and debug DRT (Requested by rniwa on #webkit).
1403 * public/WebTestingSupport.h: Removed.
1404 * src/WebTestingSupport.cpp: Removed.
1406 2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
1408 Reviewed by Darin Adler.
1410 Add build logistics and plumbing for window.internals object.
1411 https://bugs.webkit.org/show_bug.cgi?id=60313
1413 * WebKit.gyp: Added linking new webkit_test_support library.
1414 * public/WebTestingSupport.h: Added.
1415 * src/WebTestingSupport.cpp: Added.
1417 2011-05-19 Kenichi Ishibashi <bashi@chromium.org>
1419 Reviewed by Kent Tamura.
1421 [Chromium] IME candidate window appears wrong position in an iframe
1422 https://bugs.webkit.org/show_bug.cgi?id=61023
1424 Always adjusts the range to window relative coordinates.
1426 * src/WebFrameImpl.cpp:
1427 (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition
1428 which excludes editable selectionRoot from adjusting.
1430 2011-05-18 Nat Duca <nduca@chromium.org>
1432 Reviewed by James Robinson.
1434 [chromium] Add histograms for paint times
1435 https://bugs.webkit.org/show_bug.cgi?id=61010
1437 * src/WebViewImpl.cpp:
1438 (WebKit::WebViewImpl::animate):
1439 (WebKit::WebViewImpl::layout):
1440 (WebKit::WebViewImpl::paint):
1441 (WebKit::WebViewImplContentPainter::paint):
1443 2011-05-17 MORITA Hajime <morrita@google.com>
1445 Reviewed by Tony Chang.
1447 [Refactoring] Member variables of DocumentMarker should be encapsulated.
1448 https://bugs.webkit.org/show_bug.cgi?id=56814
1450 Moved addMarker() implementation to
1451 WebCore::DocumentMarkerController::addTextMatchMarker().
1453 * src/WebFrameImpl.cpp:
1454 (WebKit::WebFrameImpl::addMarker):
1456 2011-05-18 Alok Priyadarshi <alokp@chromium.org> and Adrienne Walker <enne@google.com>
1458 Reviewed by James Robinson.
1460 Split canvas from LayerTilerChromium
1461 https://bugs.webkit.org/show_bug.cgi?id=60719
1463 * src/WebViewImpl.cpp:
1465 2011-05-18 Brett Wilson <brettw@chromium.org>
1467 Reviewed by Adam Barth.
1469 Don't create empty file objects if no download file path is specified.
1470 https://bugs.webkit.org/show_bug.cgi?id=60798
1472 * src/WebURLResponse.cpp:
1473 (WebKit::WebURLResponse::setDownloadFilePath):
1475 2011-05-17 Mikhail Naganov <mnaganov@chromium.org>
1477 Reviewed by Pavel Feldman.
1479 Web Inspector: [Chromium] Enable detailed heap snapshots by default.
1480 https://bugs.webkit.org/show_bug.cgi?id=60286
1482 * src/js/DevTools.js:
1485 2011-05-17 Tao Bai <michaelbai@chromium.org>
1487 Reviewed by Darin Fisher.
1489 Clear deprecated icon APIs from chromium port.
1490 https://bugs.webkit.org/show_bug.cgi?id=60989
1492 * public/WebFrame.h: Removed faviconURL()
1493 * public/WebFrameClient.h: Removed didChangeIcons()
1494 * src/FrameLoaderClientImpl.cpp:
1495 Removed the code to support deprecated API
1496 (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
1497 * src/WebFrameImpl.cpp: Removed faviconURL()
1498 * src/WebFrameImpl.h: Removed faviconURL()
1500 2011-05-17 Daniel Cheng <dcheng@chromium.org>
1502 Reviewed by Ryosuke Niwa.
1504 [chromium] Clipboard policy callbacks from EditorClientImpl are reversed
1505 https://bugs.webkit.org/show_bug.cgi?id=60994
1507 * src/EditorClientImpl.cpp:
1508 (WebKit::EditorClientImpl::canCopyCut):
1509 (WebKit::EditorClientImpl::canPaste):
1511 2011-05-17 Andrew Wilson <atwilson@chromium.org>
1513 Unreviewed, rolling out r86647.
1514 http://trac.webkit.org/changeset/86647
1515 https://bugs.webkit.org/show_bug.cgi?id=56814
1517 Broke tests downstream in Chromium
1519 * src/WebFrameImpl.cpp:
1520 (WebKit::WebFrameImpl::addMarker):
1522 2011-05-17 Yufeng Shen <miletus@chromium.org>
1524 Reviewed by Darin Fisher.
1526 Make WebKit expose extra touch information
1527 https://bugs.webkit.org/show_bug.cgi?id=59030
1529 * public/WebTouchPoint.h:
1530 (WebKit::WebTouchPoint::WebTouchPoint):
1531 * src/WebInputEventConversion.cpp:
1532 (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
1534 2011-05-16 James Robinson <jamesr@chromium.org>
1536 Reviewed by Kenneth Russell.
1537 https://bugs.webkit.org/show_bug.cgi?id=58830
1539 Add unit tests for the compositor's TreeSynchronizer.
1542 * tests/TreeSynchronizerTest.cpp: Added.
1543 (WebCore::MockCCLayerImpl::create):
1544 (WebCore::MockCCLayerImpl::~MockCCLayerImpl):
1545 (WebCore::MockCCLayerImpl::setCCLayerDestructionList):
1546 (WebCore::MockCCLayerImpl::MockCCLayerImpl):
1547 (WebCore::MockLayerChromium::create):
1548 (WebCore::MockLayerChromium::~MockLayerChromium):
1549 (WebCore::MockLayerChromium::createCCLayerImpl):
1550 (WebCore::MockLayerChromium::pushPropertiesTo):
1551 (WebCore::MockLayerChromium::MockLayerChromium):
1552 (WebCore::expectTreesAreIdentical):
1555 2011-05-16 MORITA Hajime <morrita@google.com>
1557 Reviewed by Tony Chang.
1559 [Refactoring] Member variables of DocumentMarker should be encapsulated.
1560 https://bugs.webkit.org/show_bug.cgi?id=56814
1562 Moved addMarker() implementation to
1563 WebCore::DocumentMarkerController::addTextMatchMarker().
1565 * src/WebFrameImpl.cpp:
1566 (WebKit::WebFrameImpl::addMarker):
1568 2011-05-16 Andrew Wilson <atwilson@chromium.org>
1570 Unreviewed, rolling out r86625.
1571 http://trac.webkit.org/changeset/86625
1572 https://bugs.webkit.org/show_bug.cgi?id=60719
1574 Caused failed assertion on Chromium gpu canary bots
1576 * src/WebViewImpl.cpp:
1578 2011-05-16 Alok Priyadarshi <alokp@chromium.org>
1580 Reviewed by James Robinson.
1582 Split canvas from LayerTilerChromium
1583 https://bugs.webkit.org/show_bug.cgi?id=60719
1585 * src/WebViewImpl.cpp:
1587 2011-05-13 Jon Lee <jonlee@apple.com>
1589 Reviewed by Simon Fraser.
1591 Can't horizontally scroll iframes and overflow because wheel events are always accepted
1592 https://bugs.webkit.org/show_bug.cgi?id=60779
1594 * src/ChromeClientImpl.h:
1595 (WebKit::ChromeClientImpl::shouldRubberBandInDirection): Default impl of new ChromeClient method
1596 (WebKit::ChromeClientImpl::numWheelEventHandlersChanged): Default impl of new ChromeClient method
1598 2011-05-13 Tao Bai <michaelbai@chromium.org>
1600 Reviewed by Darin Fisher.
1602 Handle the touch icon.
1603 https://bugs.webkit.org/show_bug.cgi?id=60247
1605 Added WebIconURL for the corresponding IconURL.
1606 Added method iconURLs() to specify the type of icon need to return.
1607 The favIconURL() is deprecated and will be removed later.
1611 * public/WebFrame.h:
1612 * public/WebFrameClient.h:
1613 (WebKit::WebFrameClient::didChangeIcons):
1614 * public/WebIconURL.h: Added.
1615 (WebKit::WebIconURL::WebIconURL):
1616 (WebKit::WebIconURL::iconType):
1617 (WebKit::WebIconURL::iconURL):
1618 * src/AssertMatchingEnums.cpp:
1619 * src/FrameLoaderClientImpl.cpp:
1620 (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
1621 * src/WebFrameImpl.cpp:
1622 (WebKit::WebFrameImpl::favIconURL):
1623 * src/WebFrameImpl.h:
1625 2011-05-13 Sam Weinig <sam@webkit.org>
1627 Reviewed by Anders Carlsson.
1629 Prune #includes from FrameView.h (Part 2)
1630 https://bugs.webkit.org/show_bug.cgi?id=60748
1632 - Update files that were depending on FrameView.h #including Frame.h or
1635 * src/AutoFillPopupMenuClient.cpp:
1636 * src/PlatformBridge.cpp:
1637 * src/WebPopupMenuImpl.cpp:
1639 2011-05-13 Brett Wilson <brettw@chromium.org>
1641 Reviewed by Adam Barth.
1643 Don't destroy a null FcPattern when failing to do a FontConfig match.
1644 This crashes, and there's nothing FcDestroy could do with a null
1645 pointer even if it didn't crash.
1646 https://bugs.webkit.org/show_bug.cgi?id=60777
1648 * src/gtk/WebFontInfo.cpp:
1649 (WebKit::WebFontInfo::renderStyleForStrike):
1651 2011-05-11 Hans Wennborg <hans@chromium.org>
1653 Reviewed by Tony Gentilcore.
1655 IndexedDB: Fix integer comparison bug in LevelDB coding routines
1656 https://bugs.webkit.org/show_bug.cgi?id=60623
1658 Unit test for comparison of encoded keys.
1660 * tests/IDBLevelDBCodingTest.cpp:
1661 (IDBLevelDBCoding::TEST):
1663 2011-05-05 Hans Wennborg <hans@chromium.org>
1665 Reviewed by Steve Block.
1667 IndexedDB: Transaction rollback prevented by open SQLite statement
1668 https://bugs.webkit.org/show_bug.cgi?id=60032
1670 Implement two new methods in IDBTransactionBackendInterface.
1672 * src/IDBTransactionBackendProxy.cpp:
1673 (WebKit::IDBTransactionBackendProxy::registerOpenCursor):
1674 (WebKit::IDBTransactionBackendProxy::unregisterOpenCursor):
1675 * src/IDBTransactionBackendProxy.h:
1677 2011-05-13 Patrick Gansterer <paroga@webkit.org>
1679 Reviewed by Adam Barth.
1681 Enable OwnPtr strict mode in MediaPlayer
1682 https://bugs.webkit.org/show_bug.cgi?id=59466
1684 Let the CreateMediaEnginePlayer function return a PassOwnPtr instead of a raw pointer.
1685 Also fix the templete argument of OwnPtr for the m_private member variable.
1687 * src/WebMediaPlayerClientImpl.cpp:
1688 (WebKit::WebMediaPlayerClientImpl::create):
1689 * src/WebMediaPlayerClientImpl.h:
1691 2011-05-12 Adam Barth <abarth@webkit.org>
1693 Reviewed by Eric Seidel.
1695 [Chromium] Add a WebSetting to control DNS prefetch
1696 https://bugs.webkit.org/show_bug.cgi?id=60736
1698 DNS prefetch got disabled in Chrome accidentially in
1699 http://trac.webkit.org/changeset/74041. This patch adds a WebSettings
1700 API so we can enable it again.
1702 * public/WebSettings.h:
1703 * src/WebSettingsImpl.cpp:
1704 (WebKit::WebSettingsImpl::setDNSPrefetchingEnabled):
1705 * src/WebSettingsImpl.h:
1707 2011-05-11 John Abd-El-Malek <jam@chromium.org>
1709 Reviewed by James Robinson.
1711 [chromium] Make openFileSystem check for permission first
1712 https://bugs.webkit.org/show_bug.cgi?id=60683
1714 * public/WebCommonWorkerClient.h:
1715 (WebKit::WebCommonWorkerClient::allowFileSystem):
1716 * public/WebPermissionClient.h:
1717 (WebKit::WebPermissionClient::allowFileSystem):
1718 * src/LocalFileSystemChromium.cpp:
1719 (WebCore::openFileSystemNotAllowed):
1720 (WebCore::openFileSystemHelper):
1721 * src/WebWorkerBase.cpp:
1722 (WebKit::WebWorkerBase::allowFileSystem):
1723 * src/WebWorkerBase.h:
1724 * src/WebWorkerClientImpl.h:
1725 (WebKit::WebWorkerClientImpl::allowFileSystem):
1727 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
1729 Reviewed by Darin Adler.
1731 String operator+ reallocates unnecessarily when concatting > 2 strings
1732 https://bugs.webkit.org/show_bug.cgi?id=58420
1734 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
1736 * src/WebAccessibilityObject.cpp:
1737 (WebKit::WebAccessibilityObject::keyboardShortcut): Cast to String first, before trying to convert to platform dependant type.
1738 * src/WebHTTPLoadInfo.cpp:
1739 (WebKit::addHeader): Don't pass WebString to makeString, explicit cast to String first.
1740 * tests/IDBLevelDBCodingTest.cpp: Cast to String first, to avoid conflicting with gtests global templatified operator+.
1741 (IDBLevelDBCoding::TEST):
1743 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
1745 Reviewed by Darin Adler.
1747 Perform some forward declarations suggested by include-what-you-use
1748 https://bugs.webkit.org/show_bug.cgi?id=60545
1750 * src/WebHistoryItem.cpp:
1751 * src/WebNotification.cpp:
1752 * src/WebTextCheckingCompletionImpl.cpp:
1753 * src/mac/WebSubstringUtil.mm:
1755 2011-05-11 Levi Weintraub <leviw@chromium.org>
1757 Reviewed by Eric Seidel.
1759 Rename Widget::pos()
1760 https://bugs.webkit.org/show_bug.cgi?id=60575
1762 Renaming Widget::pos() to the more-descriptive location().
1764 * src/WebInputEventConversion.cpp:
1765 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
1766 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
1768 2011-05-11 Antoine Labour <piman@chromium.org>
1770 Reviewed by David Levin.
1772 Don't buffer data for resources loaded by AssociatedURLLoader.
1773 https://bugs.webkit.org/show_bug.cgi?id=60656
1775 * src/AssociatedURLLoader.cpp:
1776 (WebKit::AssociatedURLLoader::loadAsynchronously): set shouldBufferData to false in ThreadableLoaderOptions
1778 2011-05-11 Nat Duca <nduca@chromium.org>
1780 Reviewed by Kenneth Russell.
1782 [chromium] Make throttling of WebGL based on webgl frames, not compositor frames
1783 https://bugs.webkit.org/show_bug.cgi?id=60508
1785 Tell LayerRendererChromium when the requestAnimFrame-callbacks are running.
1787 * public/WebGraphicsContext3D.h:
1788 (WebKit::WebGraphicsContext3D::rateLimitOffscreenContextCHROMIUM):
1789 * src/Extensions3DChromium.cpp:
1790 (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
1791 * src/GraphicsContext3DChromium.cpp:
1792 * src/GraphicsContext3DInternal.h:
1793 * src/WebViewImpl.cpp:
1794 (WebKit::WebViewImpl::animate):
1796 2011-05-11 John Bauman <jbauman@chromium.org>
1798 Reviewed by Kenneth Russell.
1800 Don't send zeros in TexImage if GL implementation handles that
1801 https://bugs.webkit.org/show_bug.cgi?id=60581
1803 Chromium already handles zeroing textures upon creation, so don't
1804 bother zeroing them in WebKit, as that causes some unnecessary memcpys
1807 * src/GraphicsContext3DChromium.cpp:
1808 (WebCore::GraphicsContext3D::create):
1810 2011-05-10 Kent Tamura <tkent@chromium.org>
1812 Reviewed by Hajime Morita.
1814 [Chromium] Fix a bug of WebFrameImpl::forms()
1815 https://bugs.webkit.org/show_bug.cgi?id=60606
1817 If document()->forms() contained non-HTML element, the second for
1820 * src/WebFrameImpl.cpp:
1821 (WebKit::WebFrameImpl::forms): Simplify the function by wtf::Vector().
1823 2011-05-10 Ilya Tikhonovsky <loislo@chromium.org>
1825 Unreviewed buildfix for strict OwnPtr patch.
1827 * src/PlatformBridge.cpp:
1828 (WebCore::PlatformBridge::loadPlatformAudioResource):
1829 (WebCore::PlatformBridge::decodeAudioFileData):
1831 2011-05-06 Brett Wilson <brettw@chromium.org>
1833 Reviewed by Adam Barth.
1835 Use a File object to store the downloaded file reference rather than
1836 just the path. This keeps the file and permissions in scope (using the
1837 already-existing blob system) so the browser won't delete the file
1838 when the load is complete. Instead, the file will be cleaned up when
1839 the request objects are deleted.
1840 https://bugs.webkit.org/show_bug.cgi?id=60281
1842 * src/WebURLResponse.cpp:
1843 (WebKit::WebURLResponse::downloadFilePath):
1844 (WebKit::WebURLResponse::setDownloadFilePath):
1846 2011-05-10 Mikhail Naganov <mnaganov@chromium.org>
1848 Reviewed by Yury Semikhatsky.
1850 Web Inspector: [Chromium] Drop obsolete test code for the Profiles panel.
1851 https://bugs.webkit.org/show_bug.cgi?id=60471
1855 2011-05-10 Adam Barth <abarth@webkit.org>
1857 Attempt to fix the clang build.
1859 * src/WebDevToolsAgentImpl.cpp:
1861 2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
1863 Unreviewed, rolling out r86091.
1864 http://trac.webkit.org/changeset/86091
1865 https://bugs.webkit.org/show_bug.cgi?id=60510
1867 Broke Chromium win release build. (Requested by dave_levin on
1872 * public/WebFrame.h:
1873 * public/WebFrameClient.h:
1874 (WebKit::WebFrameClient::didChangeIcons):
1875 * public/WebIconURL.h: Removed.
1876 * src/AssertMatchingEnums.cpp:
1877 * src/FrameLoaderClientImpl.cpp:
1878 (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
1879 * src/WebFrameImpl.cpp:
1880 (WebKit::WebFrameImpl::favIconURL):
1881 * src/WebFrameImpl.h:
1883 2011-05-09 Tao Bai <michaelbai@chromium.org>
1885 Reviewed by David Levin.
1887 Handle the touch icon.
1888 https://bugs.webkit.org/show_bug.cgi?id=60247
1890 Added WebIconURL for the corresponding IconURL.
1891 Added method iconURLs() to specify the type of icon need to return.
1892 The favIconURL() is deprecated.
1896 * public/WebFrame.h:
1897 * public/WebFrameClient.h:
1898 (WebKit::WebFrameClient::didChangeIcons):
1899 * public/WebIconURL.h: Added.
1900 (WebKit::WebIconURL::WebIconURL):
1901 * src/AssertMatchingEnums.cpp:
1902 * src/FrameLoaderClientImpl.cpp:
1903 (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
1904 * src/WebFrameImpl.cpp:
1905 (WebKit::WebFrameImpl::favIconURL):
1906 * src/WebFrameImpl.h:
1908 2011-05-09 Evan Martin <evan@chromium.org>
1910 Reviewed by Tony Chang.
1912 [chromium] make DumpRenderTree build in components for linux
1913 https://bugs.webkit.org/show_bug.cgi?id=60491
1915 * WebKit.gyp: move some code that was in a Windows-only block to be used
1918 2011-05-09 Adam Barth <abarth@webkit.org>
1920 Reviewed by Tony Gentilcore.
1922 Make Chromium build with strict PassOwnPtr
1923 https://bugs.webkit.org/show_bug.cgi?id=60461
1925 Fixed many, many PassOwnPtr nits.
1927 * src/EditorClientImpl.cpp:
1928 (WebKit::EditorClientImpl::autofill):
1929 * src/IDBDatabaseBackendProxy.cpp:
1930 (WebKit::IDBDatabaseBackendProxy::createObjectStore):
1931 (WebKit::IDBDatabaseBackendProxy::transaction):
1932 * src/IDBObjectStoreBackendProxy.cpp:
1933 (WebKit::IDBObjectStoreBackendProxy::createIndex):
1934 (WebKit::IDBObjectStoreBackendProxy::index):
1935 * src/IDBTransactionBackendProxy.cpp:
1936 (WebKit::IDBTransactionBackendProxy::objectStore):
1937 * src/PlatformMessagePortChannel.cpp:
1938 (WebCore::MessagePortChannel::create):
1939 (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
1940 * src/SharedWorkerRepository.cpp:
1941 (WebCore::SharedWorkerRepository::connect):
1942 * src/SocketStreamHandle.cpp:
1943 (WebCore::SocketStreamHandleInternal::create):
1944 * src/WebDevToolsAgentImpl.cpp:
1945 (WebKit::DebuggerTask::DebuggerTask):
1946 (WebKit::DebuggerTask::~DebuggerTask):
1947 (WebKit::DebuggerTask::run):
1948 (WebKit::WebDevToolsAgent::interruptAndDispatch):
1949 * src/WebDevToolsFrontendImpl.cpp:
1950 (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1951 * src/WebIDBCallbacksImpl.cpp:
1952 (WebKit::WebIDBCallbacksImpl::onSuccess):
1953 * src/WebIDBCursorImpl.cpp:
1954 (WebKit::WebIDBCursorImpl::update):
1955 (WebKit::WebIDBCursorImpl::continueFunction):
1956 (WebKit::WebIDBCursorImpl::deleteFunction):
1957 * src/WebIDBDatabaseImpl.cpp:
1958 (WebKit::WebIDBDatabaseImpl::setVersion):
1959 (WebKit::WebIDBDatabaseImpl::open):
1960 * src/WebIDBFactoryImpl.cpp:
1961 (WebKit::WebIDBFactoryImpl::open):
1962 * src/WebIDBIndexImpl.cpp:
1963 (WebKit::WebIDBIndexImpl::openObjectCursor):
1964 (WebKit::WebIDBIndexImpl::openKeyCursor):
1965 (WebKit::WebIDBIndexImpl::getObject):
1966 (WebKit::WebIDBIndexImpl::getKey):
1967 * src/WebIDBObjectStoreImpl.cpp:
1968 (WebKit::WebIDBObjectStoreImpl::get):
1969 (WebKit::WebIDBObjectStoreImpl::put):
1970 (WebKit::WebIDBObjectStoreImpl::deleteFunction):
1971 (WebKit::WebIDBObjectStoreImpl::clear):
1972 (WebKit::WebIDBObjectStoreImpl::openCursor):
1973 * src/WebIDBTransactionImpl.cpp:
1974 (WebKit::WebIDBTransactionImpl::setCallbacks):
1975 * src/WebPluginContainerImpl.cpp:
1976 (WebKit::WebPluginContainerImpl::loadFrameRequest):
1977 * src/WebViewImpl.cpp:
1978 (WebKit::WebViewImpl::setDevToolsAgentClient):
1979 * src/WebWorkerClientImpl.cpp:
1980 (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
1981 * src/WebWorkerImpl.cpp:
1982 (WebKit::WebWorkerImpl::postMessageToWorkerContext):
1983 * src/WorkerFileWriterCallbacksBridge.cpp:
1984 (WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):
1985 (WebKit::WorkerFileWriterCallbacksBridge::didWrite):
1986 (WebKit::WorkerFileWriterCallbacksBridge::didFail):
1987 (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
1989 2011-05-09 Shishir Agrawal <shishir@chromium.org>
1991 Reviewed by Tony Gentilcore.
1993 Implement Page Visibility API.
1994 https://bugs.webkit.org/show_bug.cgi?id=54181
1997 * public/WebPageVisibilityState.h: Added.
1999 (WebKit::WebView::setVisibilityState):
2000 * public/WebViewClient.h:
2001 (WebKit::WebViewClient::visibilityState):
2002 * src/AssertMatchingEnums.cpp:
2003 * src/WebViewImpl.cpp:
2004 (WebKit::WebViewImpl::WebViewImpl):
2005 (WebKit::WebViewImpl::setVisibilityState):
2006 * src/WebViewImpl.h:
2008 2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
2010 Unreviewed, rolling out r85974.
2011 http://trac.webkit.org/changeset/85974
2012 https://bugs.webkit.org/show_bug.cgi?id=60444
2014 broke browser tests (Requested by inferno-sec on #webkit).
2016 * src/WebURLResponse.cpp:
2017 (WebKit::WebURLResponse::downloadFilePath):
2018 (WebKit::WebURLResponse::setDownloadFilePath):
2020 2011-05-06 Kent Tamura <tkent@chromium.org>
2022 Reviewed by Ryosuke Niwa.
2024 Eliminate WebCore/dom/InputElement.{cpp,h}
2025 https://bugs.webkit.org/show_bug.cgi?id=60262
2027 * src/WebInputElement.cpp:
2028 (WebKit::WebInputElement::defaultMaxLength):
2029 Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
2030 (WebKit::toWebInputElement):
2031 Follow the return type change of Node::toInputElement().
2033 2011-05-06 Justin Schuh <jschuh@chromium.org>
2035 Reviewed by Adam Barth.
2037 [Chromium] Whitelist input events interpreted as user gestures
2038 https://bugs.webkit.org/show_bug.cgi?id=60213
2040 * public/WebInputEvent.h:
2041 (WebKit::WebInputEvent::isUserGestureEventType):
2042 * src/WebViewImpl.cpp:
2043 (WebKit::WebViewImpl::handleInputEvent):
2045 2011-05-06 Brett Wilson <brettw@chromium.org>
2047 Reviewed by Adam Barth.
2049 Use a File object to store the downloaded file reference rather than
2050 just the path. This keeps the file and permissions in scope (using the
2051 already-existing blob system) so the browser won't delete the file
2052 when the load is complete. Instead, the file will be cleaned up when
2053 the request objects are deleted.
2054 https://bugs.webkit.org/show_bug.cgi?id=60281
2056 * src/WebURLResponse.cpp:
2057 (WebKit::WebURLResponse::downloadFilePath):
2058 (WebKit::WebURLResponse::setDownloadFilePath):
2060 2011-05-06 John Abd-El-Malek <jam@chromium.org>
2062 Reviewed by James Robinson.
2064 [chromium]: Reland using WebPermissionClient for checking indexed db usage
2065 https://bugs.webkit.org/show_bug.cgi?id=60386
2067 * public/WebPermissionClient.h:
2068 (WebKit::WebPermissionClient::allowIndexedDB):
2069 * src/IDBFactoryBackendProxy.cpp:
2070 (WebKit::IDBFactoryBackendProxy::open):
2072 2011-05-06 Sheriff Bot <webkit.review.bot@gmail.com>
2074 Unreviewed, rolling out r85919.
2075 http://trac.webkit.org/changeset/85919
2076 https://bugs.webkit.org/show_bug.cgi?id=60378
2078 broke chromium database tests (Requested by inferno-sec on
2081 * public/WebPermissionClient.h:
2082 * src/IDBFactoryBackendProxy.cpp:
2083 (WebKit::IDBFactoryBackendProxy::open):
2085 2011-05-04 Philippe Normand <pnormand@igalia.com>
2087 Reviewed by Dimitri Glazkov.
2089 Implement LayoutTestController::pseudoShadowId()
2090 https://bugs.webkit.org/show_bug.cgi?id=60034
2092 * public/WebElement.h:
2093 * src/WebElement.cpp:
2094 (WebKit::WebElement::shadowPseudoId):
2096 2011-05-05 John Abd-El-Malek <jam@chromium.org>
2098 Reviewed by James Robinson.
2100 [chromium] Make IndexedDB code use WebPermissionClient API
2101 https://bugs.webkit.org/show_bug.cgi?id=60340
2103 * public/WebPermissionClient.h:
2104 (WebKit::WebPermissionClient::allowIndexedDB):
2105 * src/IDBFactoryBackendProxy.cpp:
2106 (WebKit::IDBFactoryBackendProxy::open):
2108 2011-05-05 Adam Barth <abarth@webkit.org>
2114 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
2116 Reviewed by Eric Seidel.
2118 Rename SelectionController to FrameSelection
2119 https://bugs.webkit.org/show_bug.cgi?id=60234
2121 * src/WebFrameImpl.cpp:
2122 (WebKit::WebFrameImpl::selectWordAroundCaret):
2123 * src/WebViewImpl.cpp:
2124 (WebKit::WebViewImpl::textInputType):
2125 (WebKit::WebViewImpl::caretOrSelectionBounds):
2126 (WebKit::WebViewImpl::caretOrSelectionRange):
2127 (WebKit::WebViewImpl::clearFocusedNode):
2129 2011-05-03 Hans Wennborg <hans@chromium.org>
2131 Reviewed by Steve Block.
2133 IndexedDB: Unit tests for LevelDB key coding functions
2134 https://bugs.webkit.org/show_bug.cgi?id=59692
2136 Add unit tests for the basic key coding functions used by the LevelDB back-end.
2139 * tests/IDBLevelDBCodingTest.cpp: Added.
2140 (IDBLevelDBCoding::TEST):
2142 2011-05-04 MORITA Hajime <morrita@google.com>
2144 Unreviewed unit test skip (startPostAndWaitOnCondition)
2145 which fails on Windows 7. See bug 60248 for tracking.
2147 * tests/CCThreadTest.cpp:
2150 2011-05-04 Cris Neckar <cdn@chromium.org>
2152 Reviewed by Adam Barth.
2154 Expose WebView directly through ChromeClient.
2155 https://bugs.webkit.org/show_bug.cgi?id=49902
2157 * src/AutoFillPopupMenuClient.cpp:
2158 (WebKit::AutoFillPopupMenuClient::getWebView):
2159 * src/ChromeClientImpl.cpp:
2160 (WebKit::ChromeClientImpl::webView):
2161 * src/ChromeClientImpl.h:
2162 * src/GraphicsContext3DChromium.cpp:
2163 (WebCore::GraphicsContext3DInternal::initialize):
2164 * src/PlatformBridge.cpp:
2165 (WebCore::toWebWidgetClient):
2166 * src/StorageNamespaceProxy.cpp:
2167 (WebCore::StorageNamespace::sessionStorageNamespace):
2168 * src/WebViewImpl.cpp:
2169 (WebKit::WebViewImpl::fromPage):
2171 2011-05-04 Nate Chapin <japhet@chromium.org>
2173 Reviewed by Mihai Parparita.
2175 Ensure we don't overwrite user-specified scroll positions
2176 on same document HistoryItem navigations.
2177 https://bugs.webkit.org/show_bug.cgi?id=59877
2179 * src/WebFrameImpl.cpp:
2180 (WebKit::WebFrameImpl::loadHistoryItem):
2181 (WebKit::WebFrameImpl::currentHistoryItem):
2182 (WebKit::WebFrameImpl::WebFrameImpl):
2183 * src/WebFrameImpl.h:
2185 2011-05-04 Tao Bai <michaelbai@chromium.org>
2187 Reviewed by David Kilzer.
2189 Populate touch-icon url to FrameLoaderClient
2190 https://bugs.webkit.org/show_bug.cgi?id=59143
2192 Respected the change of FrameLoaderClient.
2194 * src/FrameLoaderClientImpl.cpp:
2195 (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
2196 * src/FrameLoaderClientImpl.h:
2198 2011-05-04 Jay Civelli <jcivelli@chromium.org>
2200 Reviewed by Ojan Vafai.
2202 Send the char events to the select popup if one is showing to fix
2203 a bug were pressing a letter would not select the matching option.
2204 https://bugs.webkit.org/show_bug.cgi?id=47769
2206 * src/WebViewImpl.cpp:
2207 (WebKit::WebViewImpl::keyEvent):
2208 (WebKit::WebViewImpl::charEvent):
2209 * src/WebViewImpl.h:
2211 2011-05-03 Justin Novosad <junov@chromium.org>
2213 Reviewed by Kenneth Russell.
2215 [Chromium] Make accelerated 2d canvas enabled by default with skia
2216 https://bugs.webkit.org/show_bug.cgi?id=59929
2217 Added new flag for enabling the legacy accelerated 2d canvas
2218 The flag is not yet functional with this change.
2220 * public/WebSettings.h:
2221 * src/WebSettingsImpl.cpp:
2222 (WebKit::WebSettingsImpl::setLegacyAccelerated2dCanvasEnabled):
2223 * src/WebSettingsImpl.h:
2225 2011-05-03 Alpha Lam <hclam@chromium.org>
2227 Not reviewed. Build fix.
2231 * src/FrameLoaderClientImpl.cpp:
2232 (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
2233 * src/GraphicsContext3DChromium.cpp:
2234 (WebCore::GraphicsContext3D::~GraphicsContext3D):
2235 * src/WebAudioBus.cpp:
2236 (WebKit::WebAudioBus::release):
2237 * src/WebBlobData.cpp:
2238 (WebKit::WebBlobData::reset):
2239 * src/WebViewImpl.cpp:
2240 (WebKit::WebView::addUserScript):
2241 (WebKit::WebView::addUserStyleSheet):
2243 2011-05-03 John Abd-El-Malek <jam@chromium.org>
2245 Reviewed by James Robinson.
2247 [chromium] Go through WebPermissionClient for local storage access. Also cleanup left over code from previous WebPermissionClient change.
2248 https://bugs.webkit.org/show_bug.cgi?id=60066
2250 * public/WebFrameClient.h:
2251 * public/WebPermissionClient.h:
2252 (WebKit::WebPermissionClient::allowLocalStorage):
2253 * src/DatabaseObserver.cpp:
2254 (WebCore::DatabaseObserver::canEstablishDatabase):
2255 * src/FrameLoaderClientImpl.cpp:
2256 (WebKit::FrameLoaderClientImpl::allowScriptExtension):
2257 (WebKit::FrameLoaderClientImpl::allowJavaScript):
2258 (WebKit::FrameLoaderClientImpl::allowPlugins):
2259 (WebKit::FrameLoaderClientImpl::allowImages):
2260 (WebKit::FrameLoaderClientImpl::didNotAllowScript):
2261 (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
2262 * src/StorageAreaProxy.cpp:
2263 (WebCore::StorageAreaProxy::setItem):
2265 2011-05-03 Tony Chang <tony@chromium.org>
2267 Unreviewed, rolling the version of chromium to r83922.
2271 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
2273 Reviewed by Dimitri Glazkov.
2275 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
2276 https://bugs.webkit.org/show_bug.cgi?id=58703
2278 * src/WebElement.cpp: Added #include for ShadowRoot.h.
2280 2011-05-02 Adam Klein <adamk@chromium.org>
2282 Reviewed by Tony Chang.
2284 Roll chromium DEPS to r83722, add new crypto directory to DEPS
2285 https://bugs.webkit.org/show_bug.cgi?id=59992
2289 2011-05-02 Adam Roben <aroben@apple.com>
2291 Take advantage of implicit conversion from nullptr_t to PassOwnPtr
2293 Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
2294 doesn't work, but should
2296 Reviewed by Adam Barth.
2298 * src/WebMediaPlayerClientImpl.cpp:
2300 2011-05-03 Pavel Feldman <pfeldman@google.com>
2302 Not reviewed: re-applied r85589.
2304 * src/js/DevTools.js:
2305 (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
2307 2011-05-03 Pavel Feldman <pfeldman@google.com>
2309 Reviewed by Yury Semikhatsky.
2311 Web Inspector: [remote debugging] use document.title to set window name.
2312 https://bugs.webkit.org/show_bug.cgi?id=60012
2314 * src/js/DevTools.js:
2315 (WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
2317 2011-05-02 Alok Priyadarshi <alokp@chromium.org>
2319 Reviewed by Dimitri Glazkov.
2321 Chromium windows build is broken due to r85395
2322 https://bugs.webkit.org/show_bug.cgi?id=59945
2324 Include SecurityOrigin.h in IDBFactoryBackendProxy.cpp
2326 * src/IDBFactoryBackendProxy.cpp:
2328 2011-04-30 Mihai Parparita <mihaip@chromium.org>
2330 Reviewed by Eric Seidel.
2332 V8Proxy.h shouldn't include SecurityOrigin.h
2333 https://bugs.webkit.org/show_bug.cgi?id=59859
2335 Add SecurityOrigin.h includes to places that were relying on transitive
2338 * src/ApplicationCacheHost.cpp:
2339 * src/WebGeolocationPermissionRequest.cpp:
2341 2011-04-29 Chris Evans <cevans@chromium.org>
2343 Reviewed by Adam Barth.
2345 Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2346 https://bugs.webkit.org/show_bug.cgi?id=58378
2348 * public/WebSettings.h:
2349 * src/WebSettingsImpl.cpp:
2350 (WebKit::WebSettingsImpl::setAllowDisplayOfInsecureContent):
2351 (WebKit::WebSettingsImpl::setAllowRunningOfInsecureContent):
2352 * src/WebSettingsImpl.h:
2353 Simple plumbing for the new boolean settings.
2355 2011-04-29 Kenneth Russell <kbr@google.com>
2357 Unreviewed build fix. Skip WebPageNewSerializerTest.cpp in Windows multi-DLL build.
2361 2011-04-28 Evan Martin <evan@chromium.org>
2363 Reviewed by Tony Chang.
2365 [chromium] support components build on Linux
2366 https://bugs.webkit.org/show_bug.cgi?id=59748
2368 * WebKit.gyp: adjust tests to not be Windows-specific.
2369 * public/WebCommon.h: add #defines to support Linux.
2370 * public/linux/WebFontRenderStyle.h: expose Linux-specific API.
2371 * tests/RunAllTests.cpp: adjust ifdefs to not be Windows-specific.
2373 2011-04-29 Vsevolod Vlasov <vsevik@chromium.org>
2375 Reviewed by Pavel Feldman.
2377 Chromium DevTools: Fix network panel timing/size/headers tests.
2378 https://bugs.webkit.org/show_bug.cgi?id=59696
2381 (.TestSuite.prototype.testNetworkSize.finishResource):
2382 (.TestSuite.prototype.testNetworkSyncSize.finishResource):
2383 (.TestSuite.prototype.testNetworkRawHeadersText.finishResource):
2384 (.TestSuite.prototype.testNetworkTiming.finishResource):
2386 2011-04-29 Pavel Feldman <pfeldman@google.com>
2388 Reviewed by Yury Semikhatsky.
2390 Web Inspector: add "open link in new tab" action into the network and resources panels.
2391 https://bugs.webkit.org/show_bug.cgi?id=59788
2393 This change also distinguishes context menu items case between platforms.
2395 * src/js/DevTools.js:
2397 2011-04-28 Nat Duca <nduca@chromium.org>
2399 Reviewed by Kenneth Russell.
2401 [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
2402 https://bugs.webkit.org/show_bug.cgi?id=59626
2404 * public/WebGraphicsContext3D.h:
2405 (WebKit::WebGraphicsContext3D::WebGraphicsSwapBuffersCompleteCallbackCHROMIUM::~WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
2406 (WebKit::WebGraphicsContext3D::setSwapBuffersCompleteCallbackCHROMIUM):
2407 * src/Extensions3DChromium.cpp:
2408 (WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
2409 * src/GraphicsContext3DChromium.cpp:
2410 (WebCore::SwapBuffersCompleteCallbackAdapter::~SwapBuffersCompleteCallbackAdapter):
2411 (WebCore::SwapBuffersCompleteCallbackAdapter::SwapBuffersCompleteCallbackAdapter):
2412 (WebCore::SwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
2413 (WebCore::SwapBuffersCompleteCallbackAdapter::create):
2414 (WebCore::GraphicsContext3DInternal::setSwapBuffersCompleteCallbackCHROMIUM):
2415 * src/GraphicsContext3DInternal.h:
2416 * src/WebViewImpl.cpp:
2418 2011-04-28 John Abd-El-Malek <jam@chromium.org>
2420 Reviewed by Tony Chang.
2422 [chromium] Fix silly bug with WebPermissionClient
2423 https://bugs.webkit.org/show_bug.cgi?id=59769
2425 * src/FrameLoaderClientImpl.cpp:
2426 (WebKit::FrameLoaderClientImpl::allowJavaScript):
2427 (WebKit::FrameLoaderClientImpl::allowPlugins):
2428 (WebKit::FrameLoaderClientImpl::allowImages):
2430 2011-04-28 Jay Civelli <jcivelli@chromium.org>
2432 Reviewed by Adam Barth.
2434 Introducing a new API to serialize a WebView back to HTML.
2435 https://bugs.webkit.org/show_bug.cgi?id=58947
2438 * public/WebPageSerializer.h:
2439 * src/WebPageSerializer.cpp:
2440 (WebKit::WebPageSerializer::serialize):
2441 * tests/WebPageNewSerializerTest.cpp: Added.
2442 * tests/data/pageserializer: Added.
2443 * tests/data/pageserializer/blank_frames.html: Added.
2444 * tests/data/pageserializer/blue_background.png: Added.
2445 * tests/data/pageserializer/css_test_page.html: Added.
2446 * tests/data/pageserializer/green_background.png: Added.
2447 * tests/data/pageserializer/iframe.html: Added.
2448 * tests/data/pageserializer/iframe2.html: Added.
2449 * tests/data/pageserializer/import_style_from_link.css: Added.
2450 * tests/data/pageserializer/import_styles.css: Added.
2451 * tests/data/pageserializer/link_styles.css: Added.
2452 * tests/data/pageserializer/ol-dot.png: Added.
2453 * tests/data/pageserializer/orange_background.png: Added.
2454 * tests/data/pageserializer/purple_background.png: Added.
2455 * tests/data/pageserializer/red_background.png: Added.
2456 * tests/data/pageserializer/simple.xhtml: Added.
2457 * tests/data/pageserializer/top_frame.html: Added.
2458 * tests/data/pageserializer/ul-dot.png: Added.
2459 * tests/data/pageserializer/yellow_background.png: Added.
2461 2011-04-28 John Abd-El-Malek <jam@chromium.org>
2463 Reviewed by Darin Fisher.
2465 [chromium] Add a WebPermissionClient to be used for checking permissions of features
2466 https://bugs.webkit.org/show_bug.cgi?id=59720
2468 * public/WebFrameClient.h:
2469 (WebKit::WebFrameClient::allowPlugins):
2470 (WebKit::WebFrameClient::didNotAllowPlugins):
2471 (WebKit::WebFrameClient::allowImages):
2472 (WebKit::WebFrameClient::allowScript):
2473 (WebKit::WebFrameClient::allowDatabase):
2474 (WebKit::WebFrameClient::didNotAllowScript):
2475 * public/WebPermissionClient.h: Added.
2476 (WebKit::WebPermissionClient::allowDatabase):
2477 (WebKit::WebPermissionClient::allowImages):
2478 (WebKit::WebPermissionClient::allowPlugins):
2479 (WebKit::WebPermissionClient::allowScript):
2480 (WebKit::WebPermissionClient::allowScriptExtension):
2481 (WebKit::WebPermissionClient::allowReadFromClipboard):
2482 (WebKit::WebPermissionClient::allowWriteToClipboard):
2483 (WebKit::WebPermissionClient::didNotAllowPlugins):
2484 (WebKit::WebPermissionClient::didNotAllowScript):
2485 (WebKit::WebPermissionClient::~WebPermissionClient):
2487 * public/WebViewClient.h:
2488 (WebKit::WebViewClient::didEndEditing):
2489 * src/DatabaseObserver.cpp:
2490 (WebCore::DatabaseObserver::canEstablishDatabase):
2491 * src/EditorClientImpl.cpp:
2492 (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
2493 (WebKit::EditorClientImpl::canCopyCut):
2494 (WebKit::EditorClientImpl::canPaste):
2495 * src/FrameLoaderClientImpl.cpp:
2496 (WebKit::FrameLoaderClientImpl::allowScriptExtension):
2497 (WebKit::FrameLoaderClientImpl::allowJavaScript):
2498 (WebKit::FrameLoaderClientImpl::allowPlugins):
2499 (WebKit::FrameLoaderClientImpl::allowImages):
2500 (WebKit::FrameLoaderClientImpl::didNotAllowScript):
2501 (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
2502 * src/WebFrameImpl.cpp:
2503 (WebKit::WebFrameImpl::enableContinuousSpellChecking):
2504 * src/WebViewImpl.cpp:
2505 (WebKit::WebViewImpl::setAutoFillClient):
2506 (WebKit::WebViewImpl::setPermissionClient):
2507 (WebKit::WebViewImpl::WebViewImpl):
2508 * src/WebViewImpl.h:
2509 (WebKit::WebViewImpl::permissionClient):
2511 2011-04-28 Kenneth Russell <kbr@google.com>
2513 Unreviewed fix for Windows multi-DLL build.
2517 2011-04-27 Dmitry Lomov <dslomov@google.com>
2519 Reviewed by David Levin.
2521 CrossThreadCopier should not have a default specialization for raw pointers
2522 https://bugs.webkit.org/show_bug.cgi?id=59234
2523 Removed the ablity to pass raw pointers cross-thread
2524 Added and applied annotations for doing that
2526 * src/WebSharedWorkerImpl.cpp:
2527 (WebKit::WebSharedWorkerImpl::connect):
2528 (WebKit::WebSharedWorkerImpl::connectTask):
2529 * src/WebSharedWorkerImpl.h:
2530 * src/WebWorkerBase.cpp:
2531 (WebKit::WebWorkerBase::postMessageToWorkerObject):
2532 (WebKit::WebWorkerBase::postExceptionToWorkerObject):
2533 (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
2534 (WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
2535 (WebKit::WebWorkerBase::reportPendingActivity):
2536 (WebKit::WebWorkerBase::workerContextClosed):
2537 (WebKit::WebWorkerBase::workerContextDestroyed):
2538 * src/WebWorkerClientImpl.cpp:
2539 (WebKit::WebWorkerClientImpl::startWorkerContext):
2540 (WebKit::WebWorkerClientImpl::terminateWorkerContext):
2541 (WebKit::WebWorkerClientImpl::postMessageToWorkerContext):
2542 (WebKit::WebWorkerClientImpl::workerObjectDestroyed):
2543 (WebKit::WebWorkerClientImpl::postMessageToWorkerObject):
2544 (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
2545 (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
2546 (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
2547 (WebKit::WebWorkerClientImpl::reportPendingActivity):
2548 * src/WebWorkerImpl.cpp:
2549 (WebKit::WebWorkerImpl::postMessageToWorkerContext):
2550 * src/WorkerFileSystemCallbacksBridge.cpp:
2551 (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
2552 (WebKit::WorkerFileSystemCallbacksBridge::postMoveToMainThread):
2553 (WebKit::WorkerFileSystemCallbacksBridge::postCopyToMainThread):
2554 (WebKit::WorkerFileSystemCallbacksBridge::postRemoveToMainThread):
2555 (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread):
2556 (WebKit::WorkerFileSystemCallbacksBridge::postReadMetadataToMainThread):
2557 (WebKit::WorkerFileSystemCallbacksBridge::postCreateFileToMainThread):
2558 (WebKit::WorkerFileSystemCallbacksBridge::postCreateDirectoryToMainThread):
2559 (WebKit::WorkerFileSystemCallbacksBridge::postFileExistsToMainThread):
2560 (WebKit::WorkerFileSystemCallbacksBridge::postDirectoryExistsToMainThread):
2561 (WebKit::WorkerFileSystemCallbacksBridge::postReadDirectoryToMainThread):
2562 (WebKit::WorkerFileSystemCallbacksBridge::didFailOnMainThread):
2563 (WebKit::WorkerFileSystemCallbacksBridge::didOpenFileSystemOnMainThread):
2564 (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread):
2565 (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread):
2566 (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread):
2567 * src/WorkerFileWriterCallbacksBridge.cpp:
2568 (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
2569 (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
2570 (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
2571 (WebKit::WorkerFileWriterCallbacksBridge::didWrite):
2572 (WebKit::WorkerFileWriterCallbacksBridge::didFail):
2573 (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
2574 (WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
2575 (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
2576 (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
2577 * tests/CCThreadTest.cpp:
2580 2011-04-27 James Robinson <jamesr@chromium.org>
2582 Reviewed by Kenneth Russell.
2584 [chromium] Ensure compositing layers are up to date before entering doComposite
2585 https://bugs.webkit.org/show_bug.cgi?id=59159
2587 Explicitly update and sync the compositing layer data structures for all frames in the tree before entering the
2588 composite operation so that lazily updated state doesn't mutate the GraphicsLayer tree while compositing.
2590 * src/WebViewImpl.cpp:
2591 (WebKit::WebViewImpl::composite):
2593 2011-04-27 James Robinson <jamesr@chromium.org>
2595 Reviewed by Adam Barth.
2597 Fix OwnPtr strict issues in chromium linux build
2598 https://bugs.webkit.org/show_bug.cgi?id=59664
2600 * src/WebImageDecoder.cpp:
2601 (WebKit::WebImageDecoder::getFrameAtIndex):
2602 * src/WebImageSkia.cpp:
2603 (WebKit::WebImage::fromData):
2605 2011-04-27 Adam Barth <abarth@webkit.org>
2607 Reviewed by David Levin.
2609 Make GraphicsContext3DChromium play nice with strict OwnPtrs
2610 https://bugs.webkit.org/show_bug.cgi?id=59659
2612 Attempt #2. Hopefully this time I won't make everything crash.
2614 * src/GraphicsContext3DChromium.cpp:
2615 (WebCore::GraphicsContext3DInternal::initialize):
2617 2011-04-27 Dirk Pranke <dpranke@chromium.org>
2619 Reviewed by Darin Fisher.
2621 remove unneeded TestWebWidget class
2622 https://bugs.webkit.org/show_bug.cgi?id=59573
2624 * tests/PopupMenuTest.cpp:
2626 2011-04-27 Tony Chang <tony@chromium.org>
2628 Reviewed by Ojan Vafai.
2630 [chromium] add a build target to make a zip file with the inspector debug files
2631 https://bugs.webkit.org/show_bug.cgi?id=56656
2633 * WebKit.gyp: Add target
2634 * scripts/concatenate_css_files.py: Pass in a string of html rather
2636 * scripts/concatenate_js_files.py: Same as above
2637 * scripts/generate_devtools_html.py: Refactor main into a helper function
2638 * scripts/generate_devtools_zip.py: Added.
2640 2011-04-27 Mihai Parparita <mihaip@chromium.org>
2642 Reviewed by Eric Seidel.
2644 Frame.h shouldn't include Document.h
2645 https://bugs.webkit.org/show_bug.cgi?id=59560
2647 Add Document.h #includes for files that were relying on transitive
2648 #includes via Frame.h.
2650 * src/LocalFileSystemChromium.cpp:
2651 * src/StorageEventDispatcherImpl.cpp:
2652 * src/WebFrameImpl.h:
2653 * src/WebWorkerBase.cpp:
2655 2011-04-26 Jay Civelli <jcivelli@chromium.org>
2657 Reviewed by Eric Seidel.
2659 Typedefing the shared timer function.
2660 https://bugs.webkit.org/show_bug.cgi?id=59564
2662 * public/WebKitClient.h:
2663 (WebKit::WebKitClient::setSharedTimerFiredFunction):
2665 2011-04-26 Dirk Pranke <dpranke@chromium.org>
2667 Unreviewed, rolling out r84982.
2668 http://trac.webkit.org/changeset/84982
2669 https://bugs.webkit.org/show_bug.cgi?id=59558
2674 * public/WebFrame.h:
2675 * public/WebWidget.h:
2676 * public/mac/WebSubstringUtil.h: Added.
2677 * src/WebFrameImpl.cpp:
2678 (WebKit::WebFrameImpl::firstRectForCharacterRange):
2679 (WebKit::WebFrameImpl::characterIndexForPoint):
2680 * src/WebFrameImpl.h:
2681 * src/WebPopupMenuImpl.cpp:
2682 (WebKit::WebPopupMenuImpl::compositionRange):
2683 (WebKit::WebPopupMenuImpl::caretOrSelectionRange):
2684 * src/WebPopupMenuImpl.h:
2685 * src/WebViewImpl.cpp:
2686 (WebKit::WebViewImpl::compositionRange):
2687 (WebKit::WebViewImpl::caretOrSelectionRange):
2688 * src/WebViewImpl.h:
2689 * src/mac/WebSubstringUtil.mm: Added.
2690 (WebKit::WebSubstringUtil::attributedSubstringInRange):
2692 2011-04-26 Sam Weinig <sam@webkit.org>
2694 Reviewed by David Hyatt.
2696 Remove Datagrid from the tree
2697 https://bugs.webkit.org/show_bug.cgi?id=59543
2702 2011-04-26 Sheriff Bot <webkit.review.bot@gmail.com>
2704 Unreviewed, rolling out r84951.
2705 http://trac.webkit.org/changeset/84951
2706 https://bugs.webkit.org/show_bug.cgi?id=59558
2708 "breaks chromium compile" (Requested by dpranke on #webkit).
2711 * public/WebFrame.h:
2712 * public/WebWidget.h:
2713 * public/mac/WebSubstringUtil.h: Removed.
2714 * src/WebFrameImpl.cpp:
2715 (WebKit::WebFrameImpl::firstRectForCharacterRange):
2716 * src/WebFrameImpl.h:
2717 * src/WebPopupMenuImpl.cpp:
2718 * src/WebPopupMenuImpl.h:
2719 * src/WebViewImpl.cpp:
2720 * src/WebViewImpl.h:
2721 * src/mac/WebSubstringUtil.mm: Removed.
2723 2011-04-26 Daniel Cheng <dcheng@chromium.org>
2725 Reviewed by Eric Seidel.
2727 [chromium] Implement EditorClient::canCopyCut and EditorClient::canPaste
2728 https://bugs.webkit.org/show_bug.cgi?id=59264
2730 * public/WebViewClient.h:
2731 (WebKit::WebViewClient::canTriggerClipboardRead):
2732 (WebKit::WebViewClient::canTriggerClipboardWrite):
2733 * src/EditorClientImpl.cpp:
2734 (WebKit::EditorClientImpl::canCopyCut):
2735 (WebKit::EditorClientImpl::canPaste):
2737 2011-04-26 Evan Martin <evan@chromium.org>
2739 Unreviewed, Chrome/Mac build fix.
2741 * WebKit.gypi: Remove extra file. (I removed a subtraction, but
2742 forgot to remove the corresponding addition that the subtraction
2745 2011-04-26 Evan Martin <evan@chromium.org>
2747 Reviewed by Tony Chang.
2749 [chromium] refactor duplicated list of test source files
2750 https://bugs.webkit.org/show_bug.cgi?id=59478
2752 The platform-specific unit test files were listed twice in
2753 WebKit.gyp: once for the components build, once for the normal
2754 build. Refactor this into the unified webkit_unittest_files
2755 variable. (It appears the omission of WebPageSerializerTest
2756 in one instance was an oversight.)
2761 2011-04-26 Robert Sesek <rsesek@chromium.org>
2763 Reviewed by Dimitri Glazkov.
2765 [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation
2766 https://bugs.webkit.org/show_bug.cgi?id=54969
2769 * public/WebFrame.h:
2770 * public/WebWidget.h:
2771 * public/mac/WebSubstringUtil.h: Added.
2772 * src/WebFrameImpl.cpp:
2773 (WebKit::WebFrameImpl::firstRectForCharacterRange): Return the result rect in window coordinates
2774 (WebKit::WebFrameImpl::characterIndexForPoint): New method on WebFrame
2775 * src/WebFrameImpl.h:
2776 * src/WebPopupMenuImpl.cpp:
2777 (WebKit::WebPopupMenuImpl::compositionRange): New method on WebWidget; empty impl
2778 (WebKit::WebPopupMenuImpl::caretOrSelectionRange): New method on WebWidget; empty impl
2779 * src/WebPopupMenuImpl.h:
2780 * src/WebViewImpl.cpp:
2781 (WebKit::WebViewImpl::compositionRange): New method on WebWidget
2782 (WebKit::WebViewImpl::caretOrSelectionRange): New method on WebWidget
2783 * src/WebViewImpl.h:
2784 * src/mac/WebSubstringUtil.mm: Added.
2785 (WebKit::WebSubstringUtil::attributedSubstringInRange):
2787 2011-04-26 Adam Barth <abarth@webkit.org>
2789 Reviewed by David Levin.
2791 Moar strict OwnPtr fixes for WebKit/chromium
2792 https://bugs.webkit.org/show_bug.cgi?id=59437
2794 This patch fixes all but two strict OwnPtr issues in WebKit/chromium.
2796 * src/WebDataSourceImpl.cpp:
2797 (WebKit::WebDataSourceImpl::setExtraData):
2798 (WebKit::WebDataSourceImpl::setNextPluginLoadObserver):
2799 (WebKit::WebDataSourceImpl::WebDataSourceImpl):
2800 * src/WebDataSourceImpl.h:
2801 * src/WebDevToolsAgentImpl.cpp:
2802 (WebKit::WebDevToolsAgentImpl::attach):
2803 (WebKit::WebDevToolsAgentImpl::detach):
2804 (WebKit::WebDevToolsAgent::interruptAndDispatch):
2805 * src/WebFrameImpl.cpp:
2806 (WebKit::WebFrameImpl::printBegin):
2807 * src/WebMediaPlayerClientImpl.cpp:
2808 (WebKit::createWebMediaPlayer):
2809 (WebKit::WebMediaPlayerClientImpl::loadInternal):
2810 * src/WebSpeechInputControllerMockImpl.cpp:
2811 (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl):
2812 * src/WebStorageEventDispatcherImpl.cpp:
2813 (WebKit::WebStorageEventDispatcherImpl::WebStorageEventDispatcherImpl):
2814 * src/WebViewImpl.cpp:
2815 (WebKit::WebViewImpl::WebViewImpl):
2816 (WebKit::WebViewImpl::settings):
2817 (WebKit::WebViewImpl::applyAutoFillSuggestions):
2818 (WebKit::WebView::addUserScript):
2819 (WebKit::WebView::addUserStyleSheet):
2821 2011-04-26 Ruben <chromium@hybridsource.org>
2823 Reviewed by Tony Chang.
2825 Change linux ifdefs for Chromium to Unix instead, allowing
2826 new Unix ports to be enabled by default
2827 https://bugs.webkit.org/show_bug.cgi?id=59297
2829 * src/PlatformBridge.cpp:
2830 * src/WebFrameImpl.cpp:
2831 * src/WebViewImpl.cpp:
2833 2011-04-26 Stephen White <senorblanco@chromium.org>
2835 Reviewed by Kenneth Russell.
2837 Partial revert of http://trac.webkit.org/changeset/84893, since it
2838 triggered a large number of layout test failures.
2839 https://bugs.webkit.org/show_bug.cgi?id=59459
2841 * src/GraphicsContext3DChromium.cpp:
2842 (WebCore::GraphicsContext3DInternal::initialize):
2844 2011-04-26 Hans Wennborg <hans@chromium.org>
2846 Reviewed by Tony Gentilcore.
2848 IndexedDB: Enable compile-time flag for LevelDB
2849 https://bugs.webkit.org/show_bug.cgi?id=59457
2851 Set ENABLE_LEVELDB=1 in features.gypi.
2855 2011-04-26 Pavel Feldman <pfeldman@google.com>
2857 Reviewed by Yury Semikhatsky.
2859 Chromium DevTools: recognize WebP as a valid mimetype in the Chromium port.
2860 https://bugs.webkit.org/show_bug.cgi?id=59332
2862 * src/js/DevTools.js:
2864 2011-04-26 Adam Barth <abarth@webkit.org>
2866 Reviewed by David Levin.
2868 WebKit/chromium should play nice with strict OwnPtrs
2869 https://bugs.webkit.org/show_bug.cgi?id=59434
2871 This fixes about half the issues.
2873 * src/ApplicationCacheHost.cpp:
2874 (WebCore::ApplicationCacheHost::maybeLoadMainResource):
2875 * src/ApplicationCacheHostInternal.h:
2876 (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
2877 * src/AutoFillPopupMenuClient.cpp:
2878 (WebKit::AutoFillPopupMenuClient::initialize):
2879 * src/GraphicsContext3DChromium.cpp:
2880 (WebCore::GraphicsContext3DInternal::initialize):
2881 * src/ResourceHandle.cpp:
2882 (WebCore::ResourceHandleInternal::start):
2883 (WebCore::ResourceHandle::ResourceHandle):
2884 (WebCore::ResourceHandle::loadResourceSynchronously):
2885 * src/SocketStreamHandle.cpp:
2886 (WebCore::SocketStreamHandleInternal::connect):
2888 2011-04-25 Dirk Pranke <dpranke@chromium.org>
2890 Unreviewed, build fix.
2892 Change FAILS_ to DISABLED_ in r84813.
2894 * tests/TransparencyWinTest.cpp:
2897 2011-04-25 Dirk Pranke <dpranke@chromium.org>
2899 Reviewed by James Robinson.
2901 Suppress test failure in Chromium webkit_unit_tests.
2902 https://bugs.webkit.org/show_bug.cgi?id=59358
2904 Looks like this started failing after
2905 http://trac.webkit.org/changeset/84631.
2907 * tests/TransparencyWinTest.cpp:
2910 2011-04-22 Mikhail Naganov <mnaganov@chromium.org>
2912 Reviewed by Pavel Feldman.
2914 Web Inspector: [Chromium] Move detailed heap snapshots storage and processing into workers.
2915 https://bugs.webkit.org/show_bug.cgi?id=59094
2919 2011-04-22 Andrey Kosyakov <caseq@chromium.org>
2921 Reviewed by Pavel Feldman.
2923 Web Inspector: [Extensions API] misc API cleanup
2924 https://bugs.webkit.org/show_bug.cgi?id=59194
2926 * src/js/DevTools.js:
2927 (WebInspector.platformExtensionAPI):
2929 2011-04-21 Chris Fleizach <cfleizach@apple.com>
2931 Reviewed by Beth Dakin.
2933 AX: order AccessibilityRole alphabetically
2934 https://bugs.webkit.org/show_bug.cgi?id=31524
2936 * public/WebAccessibilityRole.h:
2938 2011-04-21 Maciej Stachowiak <mjs@apple.com>
2940 Reviewed by Adam Roben.
2942 Add a feature define to allow <details> and <summary> to be disabled
2943 https://bugs.webkit.org/show_bug.cgi?id=59118
2944 <rdar://problem/9257045>
2948 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
2950 Reviewed by Sam Weinig.
2952 Add Frame* to the argument lists of canCopyCut and canPaste
2953 https://bugs.webkit.org/show_bug.cgi?id=59153
2955 * src/EditorClientImpl.cpp:
2956 (WebKit::EditorClientImpl::canCopyCut):
2957 (WebKit::EditorClientImpl::canPaste):
2958 * src/EditorClientImpl.h:
2960 2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
2962 Reviewed by Dimitri Glazkov.
2964 Bug 58704 - Decide on node type for ShadowRoot
2965 https://bugs.webkit.org/show_bug.cgi?id=58704
2967 Add a new enum entry to WebNode::NodeType for shadow roots.
2968 Adapt calling sites for new SHADOW_ROOT_NODE node type.
2971 * src/WebPageSerializerImpl.cpp:
2972 (WebKit::WebPageSerializerImpl::buildContentForNode):
2974 2011-04-20 Dominic Cooney <dominicc@chromium.org>
2976 Reviewed by Dimitri Glazkov.
2978 layoutTestController can create and destroy shadow DOM
2979 https://bugs.webkit.org/show_bug.cgi?id=59058
2981 Chromium DRT relies on the Chromium WebKit API
2983 * public/WebElement.h:
2984 * src/WebElement.cpp:
2985 (WebKit::WebElement::shadowRoot): don't steal a zero refcount
2986 (WebKit::WebElement::ensureShadowRoot): added
2987 (WebKit::WebElement::removeShadowRoot): added
2989 2011-04-20 Alexey Marinichev <amarinichev@chromium.org>
2991 Reviewed by Kenneth Russell.
2993 Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
2994 https://bugs.webkit.org/show_bug.cgi?id=59045
2996 * src/GraphicsContext3DChromium.cpp:
2997 (WebCore::GraphicsContext3D::~GraphicsContext3D): call into platform
2998 layer and unregister itself.
3000 2011-04-20 Yuzhu Shen <yzshen@chromium.org>
3002 Reviewed by Tony Chang.
3004 [chromium] linux chromium doesn't set click count for mouse up events.
3005 https://bugs.webkit.org/show_bug.cgi?id=58921
3007 The reason why we need such a fix is that the Pepper API passes this information to plugins,
3008 and some consumers (e.g., Flash) need it to detect double-clicks.
3010 * src/gtk/WebInputEventFactory.cpp: set click count for mouse up events.
3011 * tests/WebInputEventFactoryTestGtk.cpp: added test case MouseUpClickCount.
3013 2011-04-20 Evan Martin <evan@chromium.org>
3015 Reviewed by Tony Chang.
3017 [chromium] expose title text direction on WebDataSource
3018 https://bugs.webkit.org/show_bug.cgi?id=59010
3020 * public/WebDataSource.h:
3021 * src/WebDataSourceImpl.cpp:
3022 (WebKit::WebDataSourceImpl::pageTitle):
3023 (WebKit::WebDataSourceImpl::pageTitleDirection):
3024 * src/WebDataSourceImpl.h:
3026 2011-04-20 Pavel Feldman <pfeldman@google.com>
3028 Reviewed by Yury Semikhatsky.
3030 Web Inspector: add saveAs into the InspectorFrontendHost binding.
3031 https://bugs.webkit.org/show_bug.cgi?id=58979
3033 * public/WebDevToolsFrontendClient.h:
3034 (WebKit::WebDevToolsFrontendClient::saveAs):
3035 * src/InspectorFrontendClientImpl.cpp:
3036 (WebKit::InspectorFrontendClientImpl::saveAs):
3037 * src/InspectorFrontendClientImpl.h:
3038 * src/js/DevTools.js:
3040 2011-04-19 Naoki Takano <takano.naoki@gmail.com>
3042 Reviewed by Kent Tamura.
3044 [Chromium]UI polishes and tweaks to Autofill dropdown menu.
3045 https://bugs.webkit.org/show_bug.cgi?id=58505
3047 * src/AutoFillPopupMenuClient.cpp:
3048 (WebKit::AutoFillPopupMenuClient::initialize): Set AutofillPopup for menuStyle.
3050 2011-04-19 Dirk Pranke <dpranke@chromium.org>
3052 Unreviewed, attempting build fix.
3054 Disable leveldb to work around
3055 http://code.google.com/p/leveldb/issues/detail?id=1.
3059 2011-04-19 Dominic Cooney <dominicc@chromium.org>
3061 Reviewed by Dimitri Glazkov.
3063 Check the type of the wrapper when unwrapping NPObjects to native
3065 https://bugs.webkit.org/show_bug.cgi?id=58957
3067 * src/WebBindings.cpp:
3068 (WebKit::getRangeImpl): check HasInstance
3069 (WebKit::getElementImpl): check HasInstance
3071 2011-04-19 Evan Martin <evan@chromium.org>
3073 Reviewed by Darin Fisher.
3075 [chromium] didReceiveTitle API signature should not change
3076 https://bugs.webkit.org/show_bug.cgi?id=58909
3078 My previous attempt at a temporary shim was wrong.
3079 This second try should correctly work with older clients.
3081 * public/WebFrameClient.h:
3082 (WebKit::WebFrameClient::didReceiveTitle):
3084 2011-04-19 Jungshik Shin <jshin@chromium.org>
3086 Reviewed by Adam Barth
3088 Fix the compile failure in UniscribeHelperTest.cpp due to
3089 a change in UniscribeHelper made by the CL for bug 48860
3092 http://bugs.webkit.org/show_bug.cgi?id=48860
3094 * tests/UniscribeHelperTest.cpp:
3097 2011-04-19 Stuart Morgan <stuartmorgan@chromium.org>
3099 Reviewed by Tony Chang.
3101 [chromium] Clicking on plugin for first time blocks focus shift
3102 https://bugs.webkit.org/show_bug.cgi?id=58419
3104 Switched to using FocusController when moving focus to a plugin
3105 so that cross-frame focus changes are handled correctly.
3107 * src/WebPluginContainerImpl.cpp:
3108 (WebKit::WebPluginContainerImpl::handleMouseEvent):
3110 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
3112 Reviewed by Pavel Feldman.
3114 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
3115 https://bugs.webkit.org/show_bug.cgi?id=58883
3117 Renamed lengthReceived to encodedDataLength/dataLength.
3119 * public/WebURLLoaderClient.h:
3120 (WebKit::WebURLLoaderClient::didReceiveData):
3121 * src/AssociatedURLLoader.cpp:
3122 (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata):
3123 * src/FrameLoaderClientImpl.cpp:
3124 (WebKit::FrameLoaderClientImpl::dispatchDidReceiveContentLength):
3125 * src/FrameLoaderClientImpl.h:
3126 * src/ResourceHandle.cpp:
3127 (WebCore::ResourceHandleInternal::didReceiveData):
3129 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
3131 Reviewed by Pavel Feldman.
3133 Chromium DevTools: Network panel timing test is flaky
3134 https://bugs.webkit.org/show_bug.cgi?id=58699
3136 Fixed network timing test flakiness.
3139 (.TestSuite.prototype.testNetworkTiming.finishResource):
3141 2011-04-19 Andrey Kosyakov <caseq@chromium.org>
3143 Reviewed by Pavel Feldman.
3145 Web Inspector: add chrome.devTools alias to webInspector namespace for chromium port
3146 https://bugs.webkit.org/show_bug.cgi?id=58894
3148 * src/js/DevTools.js:
3149 (WebInspector.platformExtensionAPI):
3151 2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
3153 Not reviewed; another build fix attempt.
3155 * src/StorageInfoChromium.cpp:
3156 (WebCore::StorageInfo::queryUsageAndQuota):
3157 (WebCore::StorageInfo::requestQuota):
3158 * src/WebStorageQuotaCallbacksImpl.cpp:
3159 (WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):
3160 * src/WebStorageQuotaCallbacksImpl.h:
3162 2011-04-19 Kinuko Yasuda <kinuko@chromium.org>
3164 Reviewed by David Levin.
3166 [Chromium] Enable QUOTA API at runtime if enable-quota flag is given
3167 https://bugs.webkit.org/show_bug.cgi?id=58784
3169 * features.gypi: Added ENABLE_QUOTA=1.
3170 * public/WebRuntimeFeatures.h:
3171 * src/WebRuntimeFeatures.cpp:
3172 (WebKit::WebRuntimeFeatures::enableQuota): Added.
3173 (WebKit::WebRuntimeFeatures::isQuotaEnabled): Added.
3175 2011-04-19 John Gregg <johnnyg@google.com>
3177 Reviewed by Darin Fisher.
3179 Enable folder drag-n-drop when using a "webkitdirectory" file input
3180 https://bugs.webkit.org/show_bug.cgi?id=58401
3182 This uses a new ChromeClient API to enumerate the directory and
3183 return all the files, as if the user had selected that directory
3184 by clicking the control in the normal way.
3186 * public/WebViewClient.h:
3187 (WebKit::WebViewClient::enumerateChosenDirectory):
3188 * src/ChromeClientImpl.cpp:
3189 (WebKit::ChromeClientImpl::enumerateChosenDirectory):
3190 * src/ChromeClientImpl.h:
3192 2011-04-18 Evan Martin <evan@chromium.org>
3194 Reviewed by Eric Seidel.
3196 [chromium] expose title direction to webkit client
3197 https://bugs.webkit.org/show_bug.cgi?id=58823
3199 * public/WebFrameClient.h:
3200 (WebKit::WebFrameClient::didReceiveTitle):
3201 Add new param to API.
3203 * src/FrameLoaderClientImpl.cpp:
3204 (WebKit::FrameLoaderClientImpl::dispatchDidReceiveTitle):
3205 Pass new param in API.
3207 2011-04-17 Patrick Gansterer <paroga@webkit.org>
3209 Reviewed by Adam Barth.
3211 Rename PLATFORM(CG) to USE(CG)
3212 https://bugs.webkit.org/show_bug.cgi?id=58729
3214 * src/GraphicsContext3DChromium.cpp:
3215 (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
3216 (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
3217 (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
3218 (WebCore::GraphicsContext3DInternal::reshape):
3219 * src/GraphicsContext3DInternal.h:
3220 * src/PlatformBridge.cpp:
3221 * src/WebViewImpl.cpp:
3222 (WebKit::WebViewImpl::doPixelReadbackToCanvas):
3224 2011-04-15 John Bates <jbates@google.com>
3226 Reviewed by Kenneth Russell.
3228 Change WebGraphicsContext3D virtuals to pure virtuals as intended
3229 https://bugs.webkit.org/show_bug.cgi?id=58479
3231 * public/WebGraphicsContext3D.h:
3233 2011-04-15 Shishir Agrawal <shishir@chromium.org>
3235 Reviewed by James Robinson.
3237 Add a flag to guard Page Visibility API changes.
3238 https://bugs.webkit.org/show_bug.cgi?id=58464
3242 2011-04-15 Charlie Reis <creis@chromium.org>
3244 Reviewed by Darin Fisher.
3246 [Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
3247 https://bugs.webkit.org/show_bug.cgi?id=44079
3249 Remove an assert whose invariant doesn't hold.
3251 * src/FrameLoaderClientImpl.cpp:
3253 2011-04-15 Kinuko Yasuda <kinuko@chromium.org>
3255 Reviewed by David Levin.
3257 Expose unified Quota API if QUOTA build flag is enabled
3258 https://bugs.webkit.org/show_bug.cgi?id=58648
3260 * src/AssertMatchingEnums.cpp: Added enum assertions.
3261 * src/StorageInfoChromium.cpp: Made a build fix.
3263 2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
3265 Reviewed by Pavel Feldman.
3267 Web Inspector: Rename rawRequestHeadersText and RawResponseHeadersText to requestHeadersText and responseHeadersText
3268 https://bugs.webkit.org/show_bug.cgi?id=58650
3270 * public/WebHTTPLoadInfo.h:
3271 * src/WebHTTPLoadInfo.cpp:
3272 (WebKit::WebHTTPLoadInfo::requestHeadersText):
3273 (WebKit::WebHTTPLoadInfo::setRequestHeadersText):
3274 (WebKit::WebHTTPLoadInfo::responseHeadersText):
3275 (WebKit::WebHTTPLoadInfo::setResponseHeadersText):
3277 2011-04-15 Zelidrag Hornung <zelidrag@chromium.org>
3279 Reviewed by Darin Fisher.
3281 Added enums for external file system type and exposed factory function
3282 for creating File- and DirectoryEntry objects from Chromium side.
3283 https://bugs.webkit.org/show_bug.cgi?id=58456
3285 * public/WebFileSystem.h:
3286 * public/WebFrame.h:
3287 * src/AssertMatchingEnums.cpp:
3288 * src/WebFrameImpl.cpp:
3289 (WebKit::WebFrameImpl::createFileSystem):
3290 (WebKit::WebFrameImpl::createFileEntry):
3291 * src/WebFrameImpl.h:
3293 2011-04-15 Vsevolod Vlasov <vsevik@chromium.org>
3295 Reviewed by Pavel Feldman.
3297 Web Inspector: [Chromium] Create tests for network panel timing, size and raw headers text
3298 https://bugs.webkit.org/show_bug.cgi?id=58566
3300 Added network timing, size and raw headers tests for Inspector
3301 Since chromium used different version of network stack for layout
3302 tests, these are interactive ui tests (DevToolsSanityTest.TestNetwork*)
3305 (.TestSuite.prototype.testNetworkSize.finishResource):
3306 (.TestSuite.prototype.testNetworkSyncSize.finishResource):
3307 (.TestSuite.prototype.testNetworkRawHeadersText.finishResource):
3308 (.TestSuite.prototype.testNetworkTiming.finishResource):
3310 2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
3312 Reviewed by Pavel Feldman.
3314 Web Inspector: Enable raw HTTP headers support
3315 https://bugs.webkit.org/show_bug.cgi?id=58259
3317 Added raw headers text support to inspector.
3319 * public/WebHTTPLoadInfo.h:
3320 * src/WebHTTPLoadInfo.cpp:
3321 (WebKit::WebHTTPLoadInfo::rawRequestHeadersText):
3322 (WebKit::WebHTTPLoadInfo::setRawRequestHeadersText):
3323 (WebKit::WebHTTPLoadInfo::rawResponseHeadersText):
3324 (WebKit::WebHTTPLoadInfo::setRawResponseHeadersText):
3326 2011-04-14 Vsevolod Vlasov <vsevik@chromium.org>
3328 Reviewed by Pavel Feldman.
3330 Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size
3331 https://bugs.webkit.org/show_bug.cgi?id=58447
3333 FrameLoader now takes encoded data length for synchronous requests from the field with the same name.
3335 * public/WebHTTPLoadInfo.h:
3336 * src/WebHTTPLoadInfo.cpp:
3337 (WebKit::WebHTTPLoadInfo::encodedDataLength):
3338 (WebKit::WebHTTPLoadInfo::setEncodedDataLength):
3340 2011-04-14 Alok Priyadarshi <alokp@chromium.org>
3342 Reviewed by James Robinson.
3344 Remove dependency on chromium skia::PlatformCanvas
3345 https://bugs.webkit.org/show_bug.cgi?id=57563
3347 * public/WebCanvas.h:
3348 * src/WebFrameImpl.cpp:
3349 (WebKit::WebFrameImpl::printPage):
3350 * tests/TransparencyWinTest.cpp:
3351 (WebCore::drawNativeRect):
3352 (WebCore::getPixelAt):
3353 (WebCore::clearTopLayerAlphaChannel):
3354 (WebCore::clearTopLayerAlphaPixel):
3357 2011-04-14 Brian Salomon <bsalomon@google.com>
3359 Reviewed by Kenneth Russell.
3361 In skia platform call SkBitmap::notifyPixelsChanged on WebGL readback
3362 https://bugs.webkit.org/show_bug.cgi?id=58543
3364 No new tests. Tested by fast/canvas/webgl/canvas-test.html
3366 * src/GraphicsContext3DChromium.cpp:
3367 (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
3369 2011-04-14 Adrienne Walker <enne@google.com>
3371 Reviewed by James Robinson.
3373 [chromium] TilingData should return 1 tile if tile size is texture size.
3374 https://bugs.webkit.org/show_bug.cgi?id=58364
3376 Update test to properly handle this case.
3378 * tests/TilingDataTest.cpp:
3381 2011-04-14 Bill Budge <bbudge@chromium.org>
3383 Reviewed by Darin Fisher.
3385 Make WebURLLoaderOptions disallow cross origin requests by default.
3386 https://bugs.webkit.org/show_bug.cgi?id=58475
3388 No new tests. Exposes no new functionality.
3390 * public/WebURLLoaderOptions.h:
3391 (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
3393 2011-04-13 James Robinson <jamesr@chromium.org>
3395 Reviewed by Simon Fraser.
3397 Allow setting composited backing stores for scrollbars and scroll corners
3398 https://bugs.webkit.org/show_bug.cgi?id=57202
3400 Remove a lot of scrollbar hacks from the chromium compositor implementation now that
3401 scrollbars go to real layers.
3403 * src/WebScrollbarImpl.cpp:
3404 (WebKit::WebScrollbarImpl::invalidateScrollCornerRect):
3405 (WebKit::WebScrollbarImpl::scrollCornerPresent):
3406 * src/WebScrollbarImpl.h:
3407 (WebKit::WebScrollbarImpl::scrollCornerRect):
3408 * src/WebViewImpl.cpp:
3409 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3410 (WebKit::WebViewImpl::reallocateRenderer):
3412 2011-04-13 John Abd-El-Malek <jam@chromium.org>
3414 Reviewed by Jian Li.
3416 [chromium] Remove unnecessary #define now that chrome has rolled to the latest WebKit
3417 https://bugs.webkit.org/show_bug.cgi?id=58474
3420 * public/WebSpellCheckClient.h:
3422 2011-04-13 Zhenyao Mo <zmo@google.com>
3424 Reviewed by Kenneth Russell.
3426 Extension3D needs to provide a way to check if an extension is enabled
3427 https://bugs.webkit.org/show_bug.cgi?id=58410
3429 Implement isEnabled() in chromium port.
3431 * src/Extensions3DChromium.cpp:
3432 (WebCore::Extensions3DChromium::isEnabled):
3433 * src/GraphicsContext3DChromium.cpp:
3434 (WebCore::GraphicsContext3DInternal::isExtensionEnabled):
3435 * src/GraphicsContext3DInternal.h:
3437 2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
3439 Reviewed by David Levin.
3441 Add mock implementation and plumbing code for unified Quota API
3442 https://bugs.webkit.org/show_bug.cgi?id=57927
3444 Added plumbing code for the quota API, that is based on the
3445 discussion on public-webapps:
3446 http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
3448 * WebKit.gyp: Added new file entries.
3449 * src/StorageInfoChromium.cpp: Added.
3450 * src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of
3451 WebStorageQuotaCallbacks.
3452 * src/WebStorageQuotaCallbacksImpl.h: Added.
3454 2011-04-12 Hans Wennborg <hans@chromium.org>
3456 Reviewed by Jeremy Orlow.
3458 Chromium: Set ENABLE_LEVELDB=1 and add leveldb and snappy to DEPS
3459 https://bugs.webkit.org/show_bug.cgi?id=58343
3461 Set ENABLE_LEVELDB=1 so that code gets compiled by the EWS bots.
3462 Add the necessary dependencies to the DEPS file.
3467 2011-04-12 Kent Tamura <tkent@chromium.org>
3469 Reviewed by Dimitri Glazkov.
3471 [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
3472 https://bugs.webkit.org/show_bug.cgi?id=57426
3474 * public/WebSettings.h: Declare new function.
3475 * src/WebSettingsImpl.cpp:
3476 (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
3477 Passing the specified value to WebCore::Settings.
3478 * src/WebSettingsImpl.h: Declare new function.
3480 2011-04-12 Antoine Labour <piman@chromium.org>
3482 Reviewed by Kenneth Russell.
3484 Allow WebView users to recreate dependent contexts after a context lost
3485 event. Similarly to the startup case, a temporary context gets created,
3486 that gets used by the layer renderer once it itself gets recreated.
3487 https://bugs.webkit.org/show_bug.cgi?id=58385
3489 * src/WebViewImpl.cpp:
3490 (WebKit::WebViewImpl::reallocateRenderer): use the temporary context to
3491 recreate the layer renderer if it's valid.
3492 (WebKit::WebViewImpl::graphicsContext3D): create a temporary context if
3493 the layer renderer's context is lost.
3495 2011-04-12 Adrienne Walker <enne@google.com>
3497 Reviewed by James Robinson.
3499 [chromium] TilingData mishandles very small texture sizes
3500 https://bugs.webkit.org/show_bug.cgi?id=58364
3502 Update test to properly handle texture sizes of 0-3.
3504 * tests/TilingDataTest.cpp:
3507 2011-04-12 Jian Li <jianli@chromium.org>
3509 Unreviewed, rolling out r83649.
3510 http://trac.webkit.org/changeset/83649
3511 https://bugs.webkit.org/show_bug.cgi?id=57563
3513 This patch causes compiling errors for chromium
3515 * public/WebCanvas.h:
3516 * src/WebFrameImpl.cpp:
3517 (WebKit::WebFrameImpl::printPage):
3518 * tests/TransparencyWinTest.cpp:
3519 (WebCore::drawNativeRect):
3520 (WebCore::getPixelAt):
3521 (WebCore::clearTopLayerAlphaChannel):
3522 (WebCore::clearTopLayerAlphaPixel):
3525 2011-04-12 John Abd-El-Malek <jam@chromium.org>
3527 Reviewed by Jian Li.
3529 [chromium] Fix spellcheck regression in context menus
3530 https://bugs.webkit.org/show_bug.cgi?id=58386
3532 * src/ContextMenuClientImpl.cpp:
3533 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
3535 2011-04-12 Noel Gordon <noel.gordon@gmail.com>
3537 Reviewed by Tony Chang.
3539 [chromium] Use new dragTargetDragEnter() function signature
3540 https://bugs.webkit.org/show_bug.cgi?id=58303
3542 After WebKit/chromium/DEPS rolls to chromium r80907, the drag identity
3543 based version of dragTargetDragEnter() is no longer used; remove it.
3546 * src/WebViewImpl.cpp:
3547 * src/WebViewImpl.h:
3549 2011-04-12 Alok Priyadarshi <alokp@chromium.org>
3551 Reviewed by James Robinson.
3553 Remove dependency on chromium skia::PlatformCanvas
3554 https://bugs.webkit.org/show_bug.cgi?id=57563
3556 * public/WebCanvas.h:
3557 * src/WebFrameImpl.cpp:
3558 (WebKit::WebFrameImpl::printPage):
3559 * tests/TransparencyWinTest.cpp:
3560 (WebCore::drawNativeRect):
3561 (WebCore::getPixelAt):
3562 (WebCore::clearTopLayerAlphaChannel):
3563 (WebCore::clearTopLayerAlphaPixel):
3566 2011-04-12 Adam Barth <abarth@webkit.org>
3568 Revert unintentional changes to WebKit.
3570 * public/WebSettings.h:
3571 * src/WebSettingsImpl.cpp:
3572 * src/WebSettingsImpl.h:
3574 2011-04-11 John Abd-El-Malek <jam@chromium.org>
3576 Reviewed by Darin Fisher.
3578 [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
3579 https://bugs.webkit.org/show_bug.cgi?id=58260
3581 * public/WebContextMenuData.h:
3582 * public/WebSpellCheckClient.h:
3583 (WebKit::WebSpellCheckClient::spellCheck):
3584 * src/ContextMenuClientImpl.cpp:
3585 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
3586 * src/EditorClientImpl.cpp:
3587 (WebKit::EditorClientImpl::checkSpellingOfString):
3589 2011-04-12 Bill Budge <bbudge@chromium.org>
3591 Reviewed by Darin Fisher.
3593 Move the WebURLLoaderOptions struct into its own file and rename the CrossOriginRequestPolicy enum to conform to the WebKit coding standard.
3594 https://bugs.webkit.org/show_bug.cgi?id=58287
3596 No new tests. No new functionality exposed.
3599 * public/WebURLLoader.h:
3600 * public/WebURLLoaderOptions.h: Added.
3601 (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
3602 * src/AssociatedURLLoader.cpp:
3603 (WebKit::AssociatedURLLoader::AssociatedURLLoader):
3604 * src/AssociatedURLLoader.h:
3606 2011-04-11 Pavel Podivilov <podivilov@chromium.org>
3608 Reviewed by Pavel Feldman.
3610 Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
3611 https://bugs.webkit.org/show_bug.cgi?id=58232
3615 2011-04-11 John Bates <jbates@google.com>
3617 Reviewed by Kenneth Russell.
3619 chromium support for glSetLatch and glWaitLatch between 3D contexts
3620 https://bugs.webkit.org/show_bug.cgi?id=58003
3622 * public/WebGraphicsContext3D.h:
3623 (WebKit::WebGraphicsContext3D::getParentToChildLatchCHROMIUM):
3624 (WebKit::WebGraphicsContext3D::getChildToParentLatchCHROMIUM):
3625 (WebKit::WebGraphicsContext3D::waitLatchCHROMIUM):
3626 (WebKit::WebGraphicsContext3D::setLatchCHROMIUM):
3627 * src/Extensions3DChromium.cpp:
3628 (WebCore::Extensions3DChromium::waitLatchCHROMIUM):
3629 (WebCore::Extensions3DChromium::setLatchCHROMIUM):
3630 * src/GraphicsContext3DChromium.cpp:
3631 * src/GraphicsContext3DInternal.h:
3633 2011-04-11 Ryosuke Niwa <rniwa@webkit.org>
3635 Reviewed by Tony Chang.
3637 [chromium] Crash in WebViewImpl::caretOrSelectionBounds
3638 https://bugs.webkit.org/show_bug.cgi?id=58269
3640 The bug was caused by caretOrSelectionBounds's incorrectly assuming
3641 SelectionController::toNormalizedRange to always return a non-null Range.
3643 Fixed the bug by adding a null pointer check. Also replaced calls to deprecatedNode
3644 by containerNode() and calls to SelectionController::start() and SelectionController::end()
3645 by calls to SelectionController::base() and SelectionController::extent() because
3646 selection extends from base to extent, not from start to end.
3648 Test: editing/selection/extend-over-file-input-by-drag-crash.html
3650 * src/WebViewImpl.cpp:
3651 (WebKit::WebViewImpl::caretOrSelectionBounds):
3653 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
3655 Reviewed by Eric Carlson.
3657 Rename MediaControls to MediaControlRootElement.
3658 https://bugs.webkit.org/show_bug.cgi?id=58250
3660 Mechanical move using do-webcore-rename.
3662 2011-04-11 Daniel Cheng <dcheng@chromium.org>
3664 Reviewed by Dmitry Titov.
3666 [chromium] Implement image/png support in DataTransferItems
3667 https://bugs.webkit.org/show_bug.cgi?id=58106
3669 Add glue for reading image data from clipboard.
3672 * src/PlatformBridge.cpp:
3673 (WebCore::PlatformBridge::clipboardReadImage):
3675 2011-04-05 Hans Wennborg <hans@chromium.org>
3677 Reviewed by Steve Block.
3679 IndexedDB: Introduce skeleton for LevelDB backend
3680 https://bugs.webkit.org/show_bug.cgi?id=57827
3683 Add ENABLE_LEVELDB=0.
3684 * public/WebIDBFactory.h:
3685 (WebKit::WebIDBFactory::open):
3686 Remove pre-roll open() function.
3688 2011-04-10 Kent Tamura <tkent@chromium.org>
3690 [Chromium] Fix build errors on "Win Shared Builder (dbg)"
3692 * WebKit.gyp: Exclude WebFrameTest.cpp for WEBKIT_DLL.
3694 2011-04-10 Kent Tamura <tkent@chromium.org>
3696 Unreviewed, rolling out r83353.
3697 http://trac.webkit.org/changeset/83353
3698 https://bugs.webkit.org/show_bug.cgi?id=58106
3700 The new test doesn't pass on all Chromium platforms.
3703 * src/PlatformBridge.cpp:
3705 2011-04-09 Sreeram Ramachandran <sreeram@google.com>
3707 Reviewed by Ryosuke Niwa.
3709 Gather data on modal dialogs shown during unload events
3710 https://bugs.webkit.org/show_bug.cgi?id=58115
3712 Implementation of the new API to receive notifications of modal dialogs
3713 dispatched during unload events. Count the notifications through a histogram.
3715 No tests because it's not clear how to test chromium histograms from webkit.
3717 * src/ChromeClientImpl.cpp:
3718 (WebKit::ChromeClientImpl::willRunModalDialogDuringPageDismissal):
3719 * src/ChromeClientImpl.h:
3721 2011-04-08 Aaron Boodman <aa@chromium.org>
3723 Reviewed by Dmitry Titov.
3725 Re-land http://trac.webkit.org/changeset/83007. This works
3726 without changes after https://bugs.webkit.org/show_bug.cgi?id=58110.
3728 https://bugs.webkit.org/show_bug.cgi?id=58096
3732 * public/WebFrame.h:
3733 * src/WebFrameImpl.cpp:
3734 (WebKit::WebFrame::frameForContext):
3735 * tests/WebFrameTest.cpp:
3736 (WebKit::WebFrameTest::WebFrameTest):
3737 (WebKit::WebFrameTest::registerMockedURLLoad):
3738 (WebKit::WebFrameTest::loadFrame):
3741 2011-04-08 Daniel Cheng <dcheng@chromium.org>
3743 Reviewed by Dmitry Titov.
3745 [chromium] Implement image/png support in DataTransferItems
3746 https://bugs.webkit.org/show_bug.cgi?id=58106
3748 Add glue for reading image data from clipboard.
3751 * src/PlatformBridge.cpp:
3752 (WebCore::PlatformBridge::clipboardReadImage):
3754 2011-04-08 Alpha Lam <hclam@chromium.org>
3756 Unreviewed, rolling out r83335.
3757 http://trac.webkit.org/changeset/83335
3758 https://bugs.webkit.org/show_bug.cgi?id=53556
3760 GTK and QT bots are broken
3764 2011-04-07 Anna Cavender <annacc@chromium.org>
3766 Reviewed by Eric Carlson.
3768 Setup ENABLE(TRACK) feature define
3769 https://bugs.webkit.org/show_bug.cgi?id=53556
3773 2011-04-08 Dmitry Titov <dimich@chromium.org>
3775 Reviewed by Adam Barth.
3777 [Chromium] Remove unneeded usage of V8::Lockers in IDB tests.
3778 https://bugs.webkit.org/show_bug.cgi?id=58110
3779 Since they are simple one-thread tests.
3780 This code parallels the code in Chromium's idb bindings that uses v8 Lockers in utility process,
3781 which is equally not needed since there is only one thread running v8 in that process.
3783 * tests/IDBBindingUtilitiesTest.cpp:
3785 2011-04-07 Pavel Podivilov <podivilov@chromium.org>
3787 Reviewed by Pavel Feldman.
3789 Web Inspector: add test for script formatter worker.
3790 https://bugs.webkit.org/show_bug.cgi?id=57447
3794 2011-04-08 Kent Tamura <tkent@chromium.org>
3796 [Chromium] The second attempt of fixing for Windows (dbg)(shared) build.
3798 * WebKit.gyp: webkit should not depend on webkit_support.
3800 2011-04-08 Kent Tamura <tkent@chromium.org>
3802 [Chromium] Build fix for Windows (dbg)(shared).
3804 * WebKit.gyp: Add webkit_support dependency, which is required for webkit_unittest_files.
3806 2011-04-07 Kinuko Yasuda <kinuko@chromium.org>
3808 Reviewed by Darin Fisher.
3810 [Chromium] Add WebKit API to query and request unified offline-storage quota
3811 https://bugs.webkit.org/show_bug.cgi?id=57849
3812 Just adding the API, this does not do anything yet.
3814 The API is based on the public discussion for unified quota API:
3815 http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
3816 (The detail is not yet fully specified and might be subject to change.)
3818 * public/WebFrameClient.h:
3819 (WebKit::WebFrameClient::queryStorageUsageAndQuota): Added.
3820 (WebKit::WebFrameClient::requestStorageQuota): Added.
3821 * public/WebStorageQuotaCallbacks.h: Added.
3822 (WebKit::WebStorageQuotaCallbacks::~WebStorageQuotaCallbacks):
3823 * public/WebStorageQuotaType.h: Added.
3825 2011-04-07 Dominic Cooney <dominicc@google.com>
3827 Reviewed by Dimitri Glazkov.
3829 Let shadow DOM have a list of nodes at the top level of a shadow.
3830 https://bugs.webkit.org/show_bug.cgi?id=57813
3832 * src/WebElement.cpp:
3833 (WebKit::WebElement::shadowRoot): shadow roots are ContainerNodes now
3835 2011-04-07 Magnus Danielsson <public@fuzzac.com>
3837 Reviewed by Darin Fisher.
3839 [chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly
3840 https://bugs.webkit.org/show_bug.cgi?id=53897
3842 When serializing a web page using 'save page as', sub-frames and resources gets
3843 saved in a sub-directory. However, frame elements didn't get updated to reference
3844 these saved sub-frames, but were still referencing the original url. So when opening
3845 a saved web page, any sub-frames would get pulled in from the original url rather than
3848 In addition to this, sub-frames in the sub-directory erroneously had the name of the
3849 sub-directory prepended to the path of resources located in the same sub-directory.
3851 * src/WebPageSerializerImpl.cpp:
3852 (WebKit::WebPageSerializerImpl::openTagToStrne: Fixed resource paths in sub-frames.
3853 Also made sure sub-frames are referenced correctly from parent frame.
3854 (WebKit::WebPageSerializerImpl::endTagToString): Removed constness from argument.
3855 (WebKit::WebPageSerializerImpl::buildContentForNode): Ditto.
3856 * src/WebPageSerializerImpl.h:
3858 2011-04-07 Nat Duca <nduca@chromium.org>
3860 Reviewed by David Levin.
3862 [chromium] Compositor thread infrastructure
3863 https://bugs.webkit.org/show_bug.cgi?id=56131
3865 Tests for chrome compositor thread and related infrastructure.
3869 * tests/CCThreadTaskTest.cpp: Added.
3871 * tests/CCThreadTest.cpp: Added.
3873 (WebCore::PingPongUsingCondition::ping):
3874 (WebCore::PingPongTestUsingTasks::ping):
3875 (WebCore::PingPongTestUsingTasks::pong):
3876 * tests/RunAllTests.cpp:
3879 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
3881 Revert ENABLE_TRACK patch due to compile failures.
3885 2011-04-07 Pavel Feldman <pfeldman@google.com>
3887 Not reviewed: rolling chromium DEPS 80421:80767.
3891 2011-04-07 Vsevolod Vlasov <vsevik@chromium.org>
3893 Reviewed by Pavel Feldman.
3895 Web Inspector: [Chromium] Rename didReceiveData2 to didReceiveData as part of enabling transfer size support.
3896 https://bugs.webkit.org/show_bug.cgi?id=58036
3898 Renamed didReceiveData2 to didReceiveData.
3900 * public/WebURLLoaderClient.h:
3901 (WebKit::WebURLLoaderClient::didReceiveData):
3902 * src/AssociatedURLLoader.cpp:
3903 (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
3904 * src/ResourceHandle.cpp:
3905 (WebCore::ResourceHandleInternal::didReceiveData):
3907 2011-04-07 Vsevolod Vlasov <vsevik@chromium.org>
3909 Reviewed by Pavel Feldman.
3911 Web Inspector: [Chromium] Migrate didReceiveData in upstream for plugins as part of enabling transfer size support.
3912 https://bugs.webkit.org/show_bug.cgi?id=58034
3914 Migrated didReceiveData to support new lengthReceived parameter.
3916 * src/AssociatedURLLoader.cpp:
3917 (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
3919 2011-04-06 Asanka Herath <asanka@chromium.org>
3921 Reviewed by Darin Fisher.
3923 Add new TargetType: TargetIsFavicon
3925 https://bugs.webkit.org/show_bug.cgi?id=57659
3927 * public/WebURLRequest.h:
3929 2011-04-06 Alok Priyadarshi <alokp@chromium.org>
3931 Reviewed by Eric Seidel.
3933 [chromium] Add settings API to enable accelerated drawing
3934 https://bugs.webkit.org/show_bug.cgi?id=57863
3936 If accelerated drawing is enabled we try to render content and
3937 root layers using GPU. Please note that this setting is ignored if
3938 accelerated compositing is disabled.
3940 * public/WebSettings.h:
3941 * src/WebSettingsImpl.cpp:
3942 (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
3943 * src/WebSettingsImpl.h:
3945 2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>
3947 Reviewed by David Levin.
3949 Added MediaTypeFile enum value to WebContextMenuData::MediaType.
3950 https://bugs.webkit.org/show_bug.cgi?id=57566
3952 * public/WebContextMenuData.h:
3954 2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
3956 Unreviewed, rolling out r83007.
3957 http://trac.webkit.org/changeset/83007
3958 https://bugs.webkit.org/show_bug.cgi?id=57920
3960 Broke WebFrameTest.FrameForEnteredContext on Chromium-win and
3961 Chromium-mac (Requested by tkent on #webkit).
3965 * public/WebFrame.h:
3966 * src/WebFrameImpl.cpp:
3967 * tests/WebFrameTest.cpp:
3968 (WebKit::WebFrameTest::WebFrameTest):
3969 (WebKit::WebFrameTest::registerMockedURLLoad):
3970 (WebKit::WebFrameTest::serveRequests):
3973 2011-04-05 James Kozianski <koz@chromium.org>
3975 Unreviewed, rolling out r82976.
3976 http://trac.webkit.org/changeset/82976
3977 https://bugs.webkit.org/show_bug.cgi?id=57566
3979 Breaks chromium canary build
3981 * public/WebContextMenuData.h:
3983 2011-04-05 Aaron Boodman <aa@chromium.org>
3985 Reviewed by Adam Barth.
3987 Add ability to get frame from v8 context to chromium WebKit API
3988 https://bugs.webkit.org/show_bug.cgi?id=57516
3990 * public/WebFrame.h:
3991 * src/WebFrameImpl.cpp:
3992 (WebKit::WebFrame::frameForV8Context):
3994 2011-04-05 Nico Weber <thakis@chromium.org>
3996 Reviewed by Dimitri Glazkov.
3998 [chromium] Don't have 'using namespace' declarations in header files
3999 https://bugs.webkit.org/show_bug.cgi?id=57882
4001 * src/EventListenerWrapper.cpp:
4002 * src/EventListenerWrapper.h:
4003 * src/VideoFrameChromiumImpl.h:
4004 * src/WebDOMEventListener.cpp:
4005 * src/WebDOMEventListenerPrivate.cpp:
4006 * src/WebDOMEventListenerPrivate.h:
4007 (WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
4009 2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>
4011 Reviewed by David Levin.
4013 Added MediaTypeFile enum value to WebContextMenuData::MediaType.
4014 https://bugs.webkit.org/show_bug.cgi?id=57566
4016 * public/WebContextMenuData.h:
4018 2011-04-04 MORITA Hajime <morrita@google.com>
4020 Reviewed by Ryosuke Niwa.
4022 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
4023 https://bugs.webkit.org/show_bug.cgi?id=56085
4025 Followed the signature change.
4027 * src/EditorClientImpl.h:
4028 * src/EditorClientImpl.cpp:
4029 * src/WebTextCheckingCompletionImpl.cpp
4031 2011-04-05 Hans Wennborg <hans@chromium.org>
4033 Reviewed by Adam Barth
4035 Clean up IndexedDB WebKit API
4036 https://bugs.webkit.org/show_bug.cgi?id=57507
4038 Rename the backend proxy files that didn't have Backend in their name.
4039 Everything in WebKit should be in the WebKit namespace.
4040 Put everything behind the feature flag so we're consistient.
4041 Put the feature flag #if above includes.
4044 * src/IDBCallbacksProxy.cpp:
4045 (WebKit::IDBCallbacksProxy::create):
4046 (WebKit::IDBCallbacksProxy::IDBCallbacksProxy):
4047 (WebKit::IDBCallbacksProxy::onError):
4048 (WebKit::IDBCallbacksProxy::onSuccess):
4049 * src/IDBCallbacksProxy.h:
4050 * src/IDBCursorBackendProxy.cpp:
4051 (WebKit::IDBCursorBackendProxy::create):
4052 (WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
4053 * src/IDBCursorBackendProxy.h:
4054 * src/IDBDatabaseBackendProxy.cpp:
4055 (WebKit::IDBDatabaseBackendProxy::create):
4056 (WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy):
4057 (WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy):
4058 (WebKit::IDBDatabaseBackendProxy::name):
4059 (WebKit::IDBDatabaseBackendProxy::version):
4060 (WebKit::IDBDatabaseBackendProxy::objectStoreNames):
4061 (WebKit::IDBDatabaseBackendProxy::createObjectStore):
4062 (WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
4063 (WebKit::IDBDatabaseBackendProxy::setVersion):
4064 (WebKit::IDBDatabaseBackendProxy::transaction):
4065 (WebKit::IDBDatabaseBackendProxy::close):
4066 (WebKit::IDBDatabaseBackendProxy::open):
4067 * src/IDBDatabaseCallbacksProxy.cpp:
4068 (WebKit::IDBDatabaseCallbacksProxy::create):
4069 (WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
4070 * src/IDBDatabaseCallbacksProxy.h:
4071 * src/IDBFactoryBackendProxy.cpp:
4072 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
4073 (WebKit::IDBFactoryBackendProxy::open):
4074 * src/IDBFactoryBackendProxy.h:
4075 * src/IDBIndexBackendProxy.cpp:
4076 (WebKit::IDBIndexBackendProxy::create):
4077 (WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
4078 * src/IDBIndexBackendProxy.h:
4079 * src/IDBObjectStoreBackendProxy.cpp:
4080 (WebKit::IDBObjectStoreBackendProxy::create):
4081 (WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy):
4082 (WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy):
4083 (WebKit::IDBObjectStoreBackendProxy::name):
4084 (WebKit::IDBObjectStoreBackendProxy::keyPath):
4085 (WebKit::IDBObjectStoreBackendProxy::indexNames):
4086 (WebKit::IDBObjectStoreBackendProxy::get):
4087 (WebKit::IDBObjectStoreBackendProxy::put):
4088 (WebKit::IDBObjectStoreBackendProxy::deleteFunction):
4089 (WebKit::IDBObjectStoreBackendProxy::clear):
4090 (WebKit::IDBObjectStoreBackendProxy::createIndex):
4091 (WebKit::IDBObjectStoreBackendProxy::index):
4092 (WebKit::IDBObjectStoreBackendProxy::deleteIndex):
4093 (WebKit::IDBObjectStoreBackendProxy::openCursor):
4094 * src/IDBObjectStoreBackendProxy.h: Added.
4095 * src/IDBObjectStoreProxy.h: Removed.
4096 * src/IDBTransactionBackendProxy.cpp:
4097 (WebKit::IDBTransactionBackendProxy::create):
4098 (WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
4099 (WebKit::IDBTransactionBackendProxy::objectStore):
4100 * src/IDBTransactionBackendProxy.h:
4101 (WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
4102 * src/IDBTransactionCallbacksProxy.cpp:
4103 (WebKit::IDBTransactionCallbacksProxy::create):
4104 (WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
4105 * src/IDBTransactionCallbacksProxy.h:
4106 * src/WebIDBCallbacksImpl.cpp:
4107 (WebKit::WebIDBCallbacksImpl::onError):
4108 (WebKit::WebIDBCallbacksImpl::onSuccess):
4109 * src/WebIDBCallbacksImpl.h:
4110 * src/WebIDBCursorImpl.cpp:
4111 * src/WebIDBCursorImpl.h:
4112 * src/WebIDBDatabaseCallbacksImpl.cpp:
4113 (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
4114 * src/WebIDBDatabaseCallbacksImpl.h:
4115 * src/WebIDBDatabaseError.cpp:
4116 * src/WebIDBDatabaseImpl.cpp:
4117 * src/WebIDBDatabaseImpl.h:
4118 * src/WebIDBFactoryImpl.cpp:
4119 (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
4120 * src/WebIDBFactoryImpl.h:
4121 * src/WebIDBIndexImpl.cpp:
4122 * src/WebIDBIndexImpl.h:
4123 * src/WebIDBKey.cpp:
4124 (WebKit::WebIDBKey::createFromValueAndKeyPath):
4125 (WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
4126 * src/WebIDBKeyPath.cpp:
4127 (WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
4128 * src/WebIDBKeyRange.cpp:
4129 * src/WebIDBObjectStoreImpl.cpp:
4130 * src/WebIDBObjectStoreImpl.h:
4131 * src/WebIDBTransactionCallbacksImpl.cpp:
4132 * src/WebIDBTransactionCallbacksImpl.h:
4133 * src/WebIDBTransactionImpl.cpp:
4134 * src/WebIDBTransactionImpl.h:
4136 2011-04-05 Sailesh Agrawal <sail@chromium.org>
4138 Reviewed by Darin Fisher.
4140 Don't clear existing files if the user cancels the file chooser dialog.
4141 https://bugs.webkit.org/show_bug.cgi?id=55200
4143 * src/WebFileChooserCompletionImpl.cpp:
4144 (WebKit::WebFileChooserCompletionImpl::didChooseFile):
4146 2011-04-05 John Mellor <johnme@chromium.org>
4148 Reviewed by Darin Fisher.
4150 [chromium] Minor cleanup: simplify WebFrameImpl by using contentsToWindow instead of convertToContainingWindow.
4151 https://bugs.webkit.org/show_bug.cgi?id=55681
4153 * src/WebFrameImpl.cpp:
4154 (WebKit::WebFrameImpl::find):
4155 (WebKit::WebFrameImpl::scopeStringMatches):
4157 2011-04-05 Adam Barth <abarth@webkit.org>
4163 2011-04-04 Chang Shu <cshu@webkit.org>
4165 Reviewed by Ryosuke Niwa.
4167 setContentEditable with true/false/inherit string is not working properly