1 2012-09-24 Dana Jansens <danakj@chromium.org>
3 [chromium] Add setters to WebFilterOperation for IPC pickling
4 https://bugs.webkit.org/show_bug.cgi?id=97147
6 Reviewed by James Robinson.
8 * tests/FilterOperationsTest.cpp:
12 2012-09-24 Patrick Gansterer <paroga@webkit.org>
14 Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
15 https://bugs.webkit.org/show_bug.cgi?id=97412
17 Reviewed by Adam Barth.
19 * src/WebPageSerializerImpl.cpp:
20 (WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
21 (WebKit::WebPageSerializerImpl::endTagToString): Ditto.
23 2012-09-24 Yury Semikhatsky <yurys@chromium.org>
25 Unreviewed, rolling out r122243.
26 http://trac.webkit.org/changeset/129243
27 https://bugs.webkit.org/show_bug.cgi?id=97441
29 WebFilterOperationsTest.saveAndRestore added in the change is failing.
31 * tests/FilterOperationsTest.cpp:
33 2012-09-23 Keishi Hattori <keishi@webkit.org>
35 Add suggestionPicker to CalendarPicker
36 https://bugs.webkit.org/show_bug.cgi?id=97201
38 Reviewed by Kent Tamura.
40 * src/DateTimeChooserImpl.cpp:
41 (WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args.
43 2012-09-21 Kenichi Ishibashi <bashi@chromium.org>
45 [Chromium] Use OpenTypeVerticalData on Linux
46 https://bugs.webkit.org/show_bug.cgi?id=97277
48 Reviewed by Tony Chang.
50 * features.gypi: Enable OPENTYPE_VERTICAL on linux and android.
52 2012-09-21 Dirk Pranke <dpranke@chromium.org>
54 Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt
56 Unreviewed, rolled DEPS.
60 2012-09-21 Dirk Pranke <dpranke@chromium.org>
62 Roll Chromium DEPS to r158060
64 Unreviewed, rolled DEPS.
68 2012-09-21 Chris Rogers <crogers@google.com>
70 Add Web Audio support for deprecated/legacy APIs
71 https://bugs.webkit.org/show_bug.cgi?id=97050
73 Reviewed by Eric Carlson.
77 2012-09-21 Mark Pilgrim <pilgrim@chromium.org>
79 [Chromium] remove getFontFamilyForCharacters from PlatformSupport
80 https://bugs.webkit.org/show_bug.cgi?id=96282
82 Reviewed by Tony Chang.
84 Migrating away from PlatformSupport. getFontFamilyForCharacters is
85 moved to FontCache.h and overridden by the two platforms that
86 need it (Chromium Linux and Blackberry). New files for the overrides.
87 Part of a larger refactoring series. See tracking bug 82948.
89 * src/PlatformSupport.cpp:
92 2012-09-21 Dana Jansens <danakj@chromium.org>
94 [chromium] Add setters to WebFilterOperation for IPC pickling
95 https://bugs.webkit.org/show_bug.cgi?id=97147
97 Reviewed by James Robinson.
99 * tests/FilterOperationsTest.cpp:
103 2012-09-21 Tony Chang <tony@chromium.org>
105 [chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.
109 2012-09-21 Sheriff Bot <webkit.review.bot@gmail.com>
111 Unreviewed. Rolled DEPS.
115 2012-09-21 Sami Kyostila <skyostil@chromium.org>
117 [chromium] Add test for ScrollingCoordinatorChromium
118 https://bugs.webkit.org/show_bug.cgi?id=96657
120 Reviewed by James Robinson.
122 Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
123 fast (non-main thread) scrolling is enabled when necessary and that a proper
124 compositing layer structure is created for fixed position and accelerated
127 Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault
128 ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
129 ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
130 ScrollingCoordinatorChromiumTest.wheelEventHandler
131 ScrollingCoordinatorChromiumTest.touchOverflowScrolling
134 * tests/ScrollingCoordinatorChromiumTest.cpp: Added.
137 (ScrollingCoordinatorChromiumTest):
138 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
139 (WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
140 (WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
141 (WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
143 * tests/data/fixed_position.html: Added.
144 * tests/data/non_fast_scrollable.html: Added.
145 * tests/data/touch_overflow_scrolling.html: Added.
146 * tests/data/wheel_event_handler.html: Added.
148 2012-09-20 Peter Beverloo <peter@chromium.org>
150 Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
151 https://bugs.webkit.org/show_bug.cgi?id=97227
153 Reviewed by Tony Chang.
155 Remove all fifo-related code together with the io_stream_forwarder_android
156 target defined in WebKitUnitTests.gyp.
158 * WebKitUnitTests.gyp:
159 * tests/ForwardIOStreamsAndroid.cpp: Removed.
160 * tests/ForwardIOStreamsAndroid.h: Removed.
161 * tests/RunAllTests.cpp:
164 2012-09-21 Peter Beverloo <peter@chromium.org>
166 Unreviewed. Rolled DEPS.
170 2012-09-21 Keishi Hattori <keishi@webkit.org>
172 Add datalist suggestions into DateTimeChooserParameters
173 https://bugs.webkit.org/show_bug.cgi?id=97292
175 Reviewed by Kent Tamura.
177 * src/DateTimeChooserImpl.cpp:
178 (WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.
180 2012-09-20 Tony Chang <tony@chromium.org>
182 [chromium] Unreviewed build fix. webkit_unit_tests have global constructors.
184 * WebKitUnitTests.gyp: Remove -Wglobal-constructors.
186 2012-09-20 Tony Chang <tony@chromium.org>
188 [chromium] Enable more clang warnings
189 https://bugs.webkit.org/show_bug.cgi?id=97257
191 Reviewed by James Robinson.
193 * WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
194 * WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.
196 2012-09-20 David Grogan <dgrogan@chromium.org>
198 Fix IndexedDB unit tests
199 https://bugs.webkit.org/show_bug.cgi?id=97149
201 Reviewed by Tony Chang.
203 * tests/IDBDatabaseBackendTest.cpp:
204 Specify a desired version of -1 so that no version change transaction
207 2012-09-20 Dirk Pranke <dpranke@chromium.org>
209 roll Chromium to r157829.
211 Unreviewed, deps change.
215 2012-09-20 Nate Chapin <japhet@chromium.org>
217 Unreviewed, chromium win build fix.
218 Remove spurious reference to the non-existent
219 tests/LayerPainterChromium.h in WebKit.gypi.
223 2012-09-20 James Robinson <jamesr@chromium.org>
225 [chromium] Remove unused copy of chromium compositor implementation files
226 https://bugs.webkit.org/show_bug.cgi?id=97255
228 Reviewed by Adam Barth.
232 * WebKitUnitTests.gyp:
233 * src/WebAnimationCurveCommon.cpp: Removed.
234 * src/WebAnimationCurveCommon.h: Removed.
235 * src/WebAnimationImpl.cpp: Removed.
236 * src/WebAnimationImpl.h: Removed.
237 * src/WebContentLayerImpl.cpp: Removed.
238 * src/WebContentLayerImpl.h: Removed.
239 * src/WebExternalTextureLayerImpl.cpp: Removed.
240 * src/WebExternalTextureLayerImpl.h: Removed.
241 * src/WebFloatAnimationCurveImpl.cpp: Removed.
242 * src/WebFloatAnimationCurveImpl.h: Removed.
243 * src/WebIOSurfaceLayerImpl.cpp: Removed.
244 * src/WebIOSurfaceLayerImpl.h: Removed.
245 * src/WebImageLayerImpl.cpp: Removed.
246 * src/WebImageLayerImpl.h: Removed.
247 * src/WebLayerImpl.cpp: Removed.
248 * src/WebLayerImpl.h: Removed.
249 * src/WebLayerTreeViewImpl.cpp: Removed.
250 * src/WebLayerTreeViewImpl.h: Removed.
251 * src/WebScrollbarLayerImpl.cpp: Removed.
252 * src/WebScrollbarLayerImpl.h: Removed.
253 * src/WebSolidColorLayerImpl.cpp: Removed.
254 * src/WebSolidColorLayerImpl.h: Removed.
255 * src/WebToCCInputHandlerAdapter.cpp: Removed.
256 * src/WebToCCInputHandlerAdapter.h: Removed.
257 * src/WebTransformAnimationCurveImpl.cpp: Removed.
258 * src/WebTransformAnimationCurveImpl.h: Removed.
259 * src/WebVideoLayerImpl.cpp: Removed.
260 * src/WebVideoLayerImpl.h: Removed.
261 * tests/CCActiveAnimationTest.cpp: Removed.
262 * tests/CCAnimationTestCommon.cpp: Removed.
263 * tests/CCAnimationTestCommon.h: Removed.
264 * tests/CCDamageTrackerTest.cpp: Removed.
265 * tests/CCDelayBasedTimeSourceTest.cpp: Removed.
266 * tests/CCDrawQuadTest.cpp: Removed.
267 * tests/CCFrameRateControllerTest.cpp: Removed.
268 * tests/CCGeometryTestUtils.cpp: Removed.
269 * tests/CCGeometryTestUtils.h: Removed.
270 * tests/CCHeadsUpDisplayTest.cpp: Removed.
271 * tests/CCKeyframedAnimationCurveTest.cpp: Removed.
272 * tests/CCLayerAnimationControllerTest.cpp: Removed.
273 * tests/CCLayerImplTest.cpp: Removed.
274 * tests/CCLayerIteratorTest.cpp: Removed.
275 * tests/CCLayerQuadTest.cpp: Removed.
276 * tests/CCLayerSorterTest.cpp: Removed.
277 * tests/CCLayerTestCommon.cpp: Removed.
278 * tests/CCLayerTestCommon.h: Removed.
279 * tests/CCLayerTreeHostCommonTest.cpp: Removed.
280 * tests/CCLayerTreeHostImplTest.cpp: Removed.
281 * tests/CCLayerTreeHostTest.cpp: Removed.
282 * tests/CCMathUtilTest.cpp: Removed.
283 * tests/CCOcclusionTrackerTest.cpp: Removed.
284 * tests/CCOcclusionTrackerTestCommon.h: Removed.
285 * tests/CCPrioritizedTextureTest.cpp: Removed.
286 * tests/CCQuadCullerTest.cpp: Removed.
287 * tests/CCRenderPassTest.cpp: Removed.
288 * tests/CCRenderSurfaceFiltersTest.cpp: Removed.
289 * tests/CCRenderSurfaceTest.cpp: Removed.
290 * tests/CCRendererGLTest.cpp: Removed.
291 * tests/CCResourceProviderTest.cpp: Removed.
292 * tests/CCSchedulerStateMachineTest.cpp: Removed.
293 * tests/CCSchedulerTest.cpp: Removed.
294 * tests/CCSchedulerTestCommon.h: Removed.
295 * tests/CCScopedTextureTest.cpp: Removed.
296 * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed.
297 * tests/CCSolidColorLayerImplTest.cpp: Removed.
298 * tests/CCTestCommon.h: Removed.
299 * tests/CCTextureUpdateControllerTest.cpp: Removed.
300 * tests/CCThreadTaskTest.cpp: Removed.
301 * tests/CCThreadedTest.cpp: Removed.
302 * tests/CCThreadedTest.h: Removed.
303 * tests/CCTiledLayerImplTest.cpp: Removed.
304 * tests/CCTiledLayerTestCommon.cpp: Removed.
305 * tests/CCTiledLayerTestCommon.h: Removed.
306 * tests/CCTimerTest.cpp: Removed.
307 * tests/ContentLayerChromiumTest.cpp: Removed.
308 * tests/FakeCCLayerTreeHostClient.h: Removed.
309 * tests/FakeGraphicsContext3DTest.cpp: Removed.
310 * tests/FakeWebScrollbarThemeGeometry.h: Removed.
311 * tests/FloatQuadTest.cpp: Removed.
312 * tests/GraphicsLayerChromiumTest.cpp:
313 * tests/ImageLayerChromiumTest.cpp:
314 * tests/LayerChromiumTest.cpp: Removed.
315 * tests/MockCCQuadCuller.h: Removed.
316 * tests/ScrollbarLayerChromiumTest.cpp: Removed.
317 * tests/TextureCopierTest.cpp: Removed.
318 * tests/TextureLayerChromiumTest.cpp: Removed.
319 * tests/ThrottledTextureUploaderTest.cpp: Removed.
320 * tests/TiledLayerChromiumTest.cpp: Removed.
321 * tests/TreeSynchronizerTest.cpp: Removed.
322 * tests/WebAnimationTest.cpp: Removed.
323 * tests/WebFloatAnimationCurveTest.cpp: Removed.
324 * tests/WebLayerTest.cpp: Removed.
325 * tests/WebLayerTreeViewTest.cpp: Removed.
326 * tests/WebTransformAnimationCurveTest.cpp: Removed.
327 * tests/WebTransformOperationsTest.cpp: Removed.
328 * tests/WebTransformationMatrixTest.cpp: Removed.
330 2012-09-20 Tommy Widenflycht <tommyw@google.com>
332 MediaStream API: Extend UserMediaRequest with a ownerDocument method
333 https://bugs.webkit.org/show_bug.cgi?id=97095
335 Reviewed by Adam Barth.
337 Chromium need to know exactly which frame called getUserMedia so that it can clean
338 away the stream when the frame goes away.
339 Since that information is available in webkit add an accessor method.
341 Also taking the opportunity to remove an unused deprecated method,
342 and adding asserts in case the object is empty.
344 * public/WebUserMediaRequest.h:
346 (WebUserMediaRequest):
347 * src/WebUserMediaRequest.cpp:
348 (WebKit::WebUserMediaRequest::ownerDocument):
350 2012-09-20 Mike West <mkwst@google.com>
352 [chromium] Adding the 'google_apis' directory to .gitignore.
353 https://bugs.webkit.org/show_bug.cgi?id=97187
355 Reviewed by Jochen Eisinger.
357 'chromium/google_apis' should be ignored, as it's not in the git repo.
361 2012-09-19 Adam Barth <abarth@webkit.org>
363 Remove webkitPostMessage
364 https://bugs.webkit.org/show_bug.cgi?id=96577
366 Reviewed by Ojan Vafai.
368 Actually disable webkitPostMessage. See
369 http://trac.webkit.org/changeset/128658 for more information.
373 2012-09-19 Joshua Bell <jsbell@chromium.org>
375 IndexedDB: Remove "current transaction" concept from backing store
376 https://bugs.webkit.org/show_bug.cgi?id=96663
378 Reviewed by Tony Chang.
380 Update fake class with new method signatures.
382 * tests/IDBFakeBackingStore.h:
384 2012-09-19 Terry Anderson <tdanderson@chromium.org>
386 [chromium] Store the contents scale factor in PlatformContextSkia on initialization
387 https://bugs.webkit.org/show_bug.cgi?id=96137
389 Reviewed by Stephen White.
391 Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
392 for the skia patch here: https://codereview.appspot.com/6506099/.
393 Also added two new unit tests.
396 * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
398 (WebCore::HintingScaleCallback::HintingScaleCallback):
399 (HintingScaleCallback):
400 (WebCore::HintingScaleCallback::operator()):
402 * tests/PlatformContextSkiaTest.cpp:
406 2012-09-19 David Grogan <dgrogan@chromium.org>
408 Disable some failing IDB tests
409 https://bugs.webkit.org/show_bug.cgi?id=97135
411 Reviewed by Nate Chapin.
413 They were broken in r129037.
415 * tests/IDBDatabaseBackendTest.cpp:
417 2012-09-19 Alpha Lam <hclam@chromium.org>
419 [chromium] Unreviewed. Build fix.
421 Not building WebImageTest.cpp for component build.
425 2012-09-19 Alpha Lam <hclam@chromium.org>
427 [chromium] WebImage should use ImageDecoder directly
428 https://bugs.webkit.org/show_bug.cgi?id=96135
430 Reviewed by Adam Barth.
432 This patch is for preparation of deferred image decoding.
433 ImageSource will be used as a portal to access deferred image decoder
434 by BitmapImage, it should not be accessible through WebKit APIs.
436 WebImage now calls ImageDecoder directly which is the actual
437 implementation of an image decoder.
439 Tests: WebImageTest.PNGImage
440 WebImageTest.ICOImage
441 WebImageTest.BadImage
444 * src/WebImageSkia.cpp:
445 (WebKit::WebImage::fromData):
446 (WebKit::WebImage::framesFromData):
447 * tests/WebImageTest.cpp: Added.
451 * tests/data/black-and-white.ico: Added.
452 * tests/data/white-1x1.png: Added.
454 2012-09-19 Oli Lan <olilan@chromium.org>
456 [chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
457 https://bugs.webkit.org/show_bug.cgi?id=96112
459 Reviewed by Adam Barth.
461 Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
463 This will be used by the Android port to implement platform-specific gesture behaviour.
465 This is tested by the new test WebViewTest.ClientTapHandlers.
467 * public/WebViewClient.h:
469 (WebKit::WebViewClient::didHandleGestureEvent):
470 * src/WebViewImpl.cpp:
471 (WebKit::WebViewImpl::handleGestureEvent):
472 * tests/WebViewTest.cpp:
474 2012-09-19 Robert Flack <flackr@chromium.org>
476 [chromium] Support high DPI scroll bar on top level web frame.
477 https://bugs.webkit.org/show_bug.cgi?id=95134
479 Reviewed by Adrienne Walker.
481 Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.
483 * src/NonCompositedContentHost.cpp:
484 (WebKit::setScrollbarBoundsContainPageScale):
486 (WebKit::NonCompositedContentHost::setViewport):
488 2012-09-19 Mark Pilgrim <pilgrim@chromium.org>
490 [Chromium] Move notifyJSOutOfMemory out of PlatformSupport
491 https://bugs.webkit.org/show_bug.cgi?id=97116
493 Reviewed by Adam Barth.
495 Part of a refactoring series. See tracking bug 82948.
497 * src/FrameLoaderClientImpl.cpp:
498 (WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
500 * src/FrameLoaderClientImpl.h:
501 (FrameLoaderClientImpl):
502 * src/PlatformSupport.cpp:
505 2012-09-19 Mark Pilgrim <pilgrim@chromium.org>
507 [Chromium] Remove unused popupsAllowed function from PlatformSupport
508 https://bugs.webkit.org/show_bug.cgi?id=96521
510 Reviewed by Eric Seidel.
512 Part of a refactoring series. See tracking bug 82948.
514 * src/PlatformSupport.cpp:
517 2012-09-19 Kent Tamura <tkent@chromium.org>
519 [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
520 https://bugs.webkit.org/show_bug.cgi?id=96352
522 Reviewed by Adam Barth.
524 We have some crash reports with the following stack:
525 - HistoryItem::shouldDoSameDocumentNavigationTo.
526 - WebFrameImpl::loadHistoryItem
529 We don't have reproducible steps, and not sure what's the root
530 cause. Anyway we should check nullness of currentItem because
531 HistoryController::m_currentItem can be 0.
533 * src/WebFrameImpl.cpp:
534 (WebKit::WebFrameImpl::loadHistoryItem):
535 Check nullness of currentItem.
537 2012-09-18 Sailesh Agrawal <sail@chromium.org>
539 Chromium: Scrollbar with tickmarks doesn't respond to clicks
540 https://bugs.webkit.org/show_bug.cgi?id=96049
542 Reviewed by Beth Dakin.
544 Pipe isAlphaLocked and setIsAlphaLocked.
546 * src/WebPluginScrollbarImpl.cpp:
547 (WebKit::WebPluginScrollbarImpl::isAlphaLocked):
549 (WebKit::WebPluginScrollbarImpl::setIsAlphaLocked):
550 * src/WebPluginScrollbarImpl.h:
551 (WebPluginScrollbarImpl):
552 * src/WebScrollbarThemeClientImpl.cpp:
553 (WebKit::WebScrollbarThemeClientImpl::isAlphaLocked):
555 (WebKit::WebScrollbarThemeClientImpl::setIsAlphaLocked):
556 * src/WebScrollbarThemeClientImpl.h:
557 (WebScrollbarThemeClientImpl):
558 * tests/ScrollbarLayerChromiumTest.cpp:
560 2012-09-18 Alpha Lam <hclam@chromium.org>
562 Unreviewed, rolling out r128939.
563 http://trac.webkit.org/changeset/128939
564 https://bugs.webkit.org/show_bug.cgi?id=96135
566 Failing test_shell_tests.
569 * src/WebImageSkia.cpp:
570 (WebKit::WebImage::fromData):
571 (WebKit::WebImage::framesFromData):
572 * tests/WebImageTest.cpp: Removed.
573 * tests/data/black-and-white.ico: Removed.
574 * tests/data/white-1x1.png: Removed.
576 2012-09-18 Alpha Lam <hclam@chromium.org>
578 [chromium] WebImage should use ImageDecoder directly
579 https://bugs.webkit.org/show_bug.cgi?id=96135
581 Reviewed by Adam Barth.
583 This patch is for preparation of deferred image decoding.
584 ImageSource will be used as a portal to access deferred image decoder
585 by BitmapImage, it should not be accessible through WebKit APIs.
587 WebImage now calls ImageDecoder directly which is the actual
588 implementation of an image decoder.
590 Tests: WebImageTest.PNGImage
591 WebImageTest.ICOImage
594 * src/WebImageSkia.cpp:
595 (WebKit::WebImage::fromData):
596 (WebKit::WebImage::framesFromData):
597 * tests/WebImageTest.cpp: Added.
601 * tests/data/black-and-white.ico: Added.
602 * tests/data/white-1x1.png: Added.
604 2012-09-18 Tommy Widenflycht <tommyw@google.com>
606 MediaStream API: Create a flag to enable PeerConnection00
607 https://bugs.webkit.org/show_bug.cgi?id=96989
609 Reviewed by Adam Barth.
611 Adding the functionality to separately enable/disable PeerConnection00.
612 For now it is enabled by default.
614 * public/WebRuntimeFeatures.h:
615 (WebRuntimeFeatures):
616 * src/WebRuntimeFeatures.cpp:
617 (WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection):
619 (WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled):
621 2012-09-18 Iain Merrick <husky@google.com>
623 [Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange
624 https://bugs.webkit.org/show_bug.cgi?id=96508
626 Reviewed by Ryosuke Niwa.
628 These methods had "start" and "end" parameters, but this is incorrect.
629 selectRange() actually takes base and extent (where the user actually
630 touched), and selectionBounds() returns anchor and focus (base and extent
631 expanded to account for the selection granularity).
633 This patch fixes the parameter names, and updates selectRange, its test
634 and its documentation to reflect the correct usage. It also removes
635 moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used
636 yet), and updates WebFrameTest to show how these can be implemented via
641 * public/WebWidget.h:
643 (WebKit::WebWidget::selectionBounds):
644 * src/WebFrameImpl.cpp:
645 (WebKit::WebFrameImpl::selectRange):
646 * src/WebFrameImpl.h:
648 * src/WebViewImpl.cpp:
649 (WebKit::WebViewImpl::selectionBounds):
652 * tests/WebFrameTest.cpp:
654 2012-09-18 Terry Anderson <tdanderson@chromium.org>
656 Roll chromium DEPS to r157342
657 https://bugs.webkit.org/show_bug.cgi?id=96963
659 Reviewed by Stephen White.
661 Roll chromium DEPS to r157342. Also include the top-level directory
662 google_apis as a dependency, which was required for r157130.
666 2012-09-17 Brian Anderson <brianderson@chromium.org>
668 [chromium] Add rendering commit statistics
669 https://bugs.webkit.org/show_bug.cgi?id=96938
671 Reviewed by James Robinson.
673 Adds total commit time and total commit count to WebRenderingStats.
674 Allows us to caculate average commit time in performance tests.
676 * src/WebLayerTreeViewImpl.cpp:
677 (WebKit::WebLayerTreeViewImpl::renderingStats):
679 2012-09-17 James Robinson <jamesr@chromium.org>
681 [chromium] Move a FilterOperationsTest and WebInputEventConversionTest back to webkit_unittest_files variable
682 https://bugs.webkit.org/show_bug.cgi?id=96964
684 Reviewed by Adrienne Walker.
686 These targets are really webkit unit tests and shouldn't be guarded by use_libcc_for_compositor.
690 2012-09-17 Rick Byers <rbyers@chromium.org>
692 Send GestureTapDownCancel to WebCore
693 https://bugs.webkit.org/show_bug.cgi?id=96060
695 Reviewed by Antonio Gomes.
697 Plumb WebInputEvent::GetsureTapCancel to
698 PlatformInputEvent::GestureTapDownCancel. After all the chromium code
699 was landed, it was suggested that 'TapDownCancel' was a better name
700 than 'TapCancel' since you can't cancel a Tap. I'm not changing the
701 WebInputEvent definition here because that would be a breaking change
702 to chromium, but I can do that as a series of follow-up CLs.
703 * src/WebInputEventConversion.cpp:
704 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
705 * src/WebPopupMenuImpl.cpp:
706 (WebKit::WebPopupMenuImpl::handleInputEvent):
707 * src/WebViewImpl.cpp:
708 (WebKit::WebViewImpl::handleGestureEvent):
710 2012-09-17 Alec Flett <alecflett@chromium.org>
712 IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor
713 https://bugs.webkit.org/show_bug.cgi?id=95409
715 Reviewed by Kentaro Hara.
717 This removes a bunch of tests that have been migrated to
718 LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818.
720 * tests/IDBBindingUtilitiesTest.cpp:
721 (WebCore::checkKeyFromValueAndKeyPathInternal):
722 (WebCore::checkKeyPathNullValue):
723 (WebCore::injectKey):
724 (WebCore::checkInjection):
725 (WebCore::checkInjectionFails):
726 (WebCore::checkKeyPathStringValue):
727 (WebCore::checkKeyPathNumberValue):
729 * tests/IDBKeyPathTest.cpp:
731 2012-09-17 Leandro Gracia Gil <leandrogracia@chromium.org>
733 [Chromium] Fix cases where find-in-page doesn't send a final update
734 https://bugs.webkit.org/show_bug.cgi?id=96402
736 Fix some issues in the WebKit implementation that prevented to send a final
737 reportFindInPageMatchCount message.
739 Reviewed by Adam Barth.
741 * src/WebFrameImpl.cpp:
742 (WebKit::WebFrameImpl::scopeStringMatches):
744 (WebKit::WebFrameImpl::finishCurrentScopingEffort):
745 (WebKit::WebFrameImpl::cancelPendingScopingEffort):
746 (WebKit::WebFrameImpl::WebFrameImpl):
747 (WebKit::WebFrameImpl::shouldScopeMatches):
748 * src/WebFrameImpl.h:
750 2012-09-17 Joshua Bell <jsbell@chromium.org>
752 [Chromium] IndexedDB: Remove legacy two-phase open() API members
753 https://bugs.webkit.org/show_bug.cgi?id=96802
755 Reviewed by Tony Chang.
757 Following http://webkit.org/b/90411 and subsequent cleanup on the Chromium side,
758 these entry points are no longer needed.
760 * public/WebIDBDatabase.h: Delete old second-phase open(db-callbacks)
761 * public/WebIDBFactory.h: Delete old first-phase open() w/o db-callbacks
762 * src/WebIDBDatabaseImpl.cpp: No longer need to account for a close between phases.
763 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
764 (WebKit::WebIDBDatabaseImpl::close):
765 (WebKit::WebIDBDatabaseImpl::forceClose):
766 * src/WebIDBDatabaseImpl.h:
767 (WebIDBDatabaseImpl):
769 2012-09-17 Ilya Tikhonovsky <loislo@chromium.org>
771 Unreviewed. Temporary disable visited set counter check.
773 * tests/MemoryInstrumentationTest.cpp:
776 2012-09-17 Ilya Tikhonovsky <loislo@chromium.org>
778 Web Inspector: NMI: now when we can detect instrumented classes we can
779 remove addInstrumentedMember and use addMember for everything.
780 https://bugs.webkit.org/show_bug.cgi?id=96913
782 Reviewed by Yury Semikhatsky.
784 * tests/MemoryInstrumentationTest.cpp:
785 (WebCore::InstrumentedDOM::reportMemoryUsage):
786 (WebCore::NonVirtualInstrumented::reportMemoryUsage):
787 (WebCore::InstrumentedOwner::reportMemoryUsage):
789 2012-09-17 Ilya Tikhonovsky <loislo@chromium.org>
791 Unreviewed single line fix for mac chromium canary bot.
793 * tests/MemoryInstrumentationTest.cpp:
796 2012-09-15 Yury Semikhatsky <yurys@chromium.org>
798 Web Inspector: automatically detect if class has reportMemoryUsage method
799 https://bugs.webkit.org/show_bug.cgi?id=96756
801 Reviewed by Alexander Pavlov.
803 Test that reportMemoryUsage method will be called on the instrumented object
804 even if it is a template.
806 * tests/MemoryInstrumentationTest.cpp:
808 (InstrumentedTemplate):
809 (WebCore::InstrumentedTemplate::InstrumentedTemplate):
810 (WebCore::InstrumentedTemplate::reportMemoryUsage):
813 2012-09-14 Yury Semikhatsky <yurys@chromium.org>
815 Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation
816 https://bugs.webkit.org/show_bug.cgi?id=96791
818 Reviewed by Alexander Pavlov.
820 Test that pointers to RefPtr and OwnPtr won't be double counted by
821 the memory instrumentation.
823 * tests/MemoryInstrumentationTest.cpp:
825 (TwoPointersToRefPtr):
826 (WebCore::TwoPointersToRefPtr::TwoPointersToRefPtr):
827 (WebCore::TwoPointersToRefPtr::reportMemoryUsage):
829 (TwoPointersToOwnPtr):
830 (WebCore::TwoPointersToOwnPtr::TwoPointersToOwnPtr):
831 (WebCore::TwoPointersToOwnPtr::reportMemoryUsage):
833 2012-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
835 Unreviewed. Rolled DEPS.
839 2012-09-14 Julien Chaffraix <jchaffraix@webkit.org>
841 Revert r127457 and following fixes due to several hit-testing regressions
842 https://bugs.webkit.org/show_bug.cgi?id=96830
844 Reviewed by Antonio Gomes.
846 This change reverts r127457, r127863 and r128505.
848 * src/ContextMenuClientImpl.cpp:
849 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
851 2012-09-14 Ojan Vafai <ojan@chromium.org>
853 Provide a runtime setting to disable position:sticky
854 https://bugs.webkit.org/show_bug.cgi?id=96827
856 Reviewed by James Robinson.
858 * public/WebSettings.h:
859 * src/WebSettingsImpl.cpp:
860 (WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
862 * src/WebSettingsImpl.h:
865 2012-09-14 Adam Barth <abarth@webkit.org>
867 Remove webkitPostMessage
868 https://bugs.webkit.org/show_bug.cgi?id=96577
870 Reviewed by Ojan Vafai.
872 Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
876 2012-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
878 Unreviewed. Rolled DEPS.
882 2012-09-14 Rick Byers <rbyers@chromium.org>
884 [chromium] add touch area to gestureTapDown data
885 https://bugs.webkit.org/show_bug.cgi?id=96806
887 Reviewed by Adam Barth.
889 Add width/height for GestureTapDown as for GestureTap/LongPress so that
890 we can eventually do fuzzing on it.
891 * public/WebInputEvent.h:
892 * src/WebInputEventConversion.cpp:
893 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
895 2012-09-14 Peter Beverloo <peter@chromium.org>
897 [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
898 https://bugs.webkit.org/show_bug.cgi?id=96687
900 Reviewed by Tony Chang.
902 Android's DumpRenderTree currently supports these arguments, implemented
903 as part of TestShellAndroid:
904 http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
906 They're used by the layout test runner to get the STDOUT and STDERR while
907 a layout test run is in process, which is a safer alternative to parsing
908 all the logcat output manually. The implementation can be seen here:
909 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
911 This patch generalizes parsing of and applying the effects of these arguments
912 so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
913 After this patch, this will make it possible to pull out the output-reading
914 code from Android's layout test port and generalize it so it can be re-used
915 in the new test-runner for the other two test suites.
917 This has no effect when compiling and running these tests as part of Chromium
918 code, which has a much more advanced test-runner that does parse complete log
919 output, but also directly depends on code licensed under Apache 2.
922 * tests/ForwardIOStreamsAndroid.cpp: Added.
924 (WebKit::maybeInitIOStreamForwardingForAndroid):
925 * tests/ForwardIOStreamsAndroid.h: Added.
927 * tests/RunAllTests.cpp:
930 2012-09-14 Keishi Hattori <keishi@webkit.org>
932 Make time input lang attribute aware for testing
933 https://bugs.webkit.org/show_bug.cgi?id=96728
935 Reviewed by Kent Tamura.
937 * tests/LocalizedDateICUTest.cpp:
938 (LocalizedDateICUTest::localizedDateFormatText):
939 (LocalizedDateICUTest::localizedShortDateFormatText):
941 2012-09-14 Keishi Hattori <keishi@webkit.org>
943 Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods
944 https://bugs.webkit.org/show_bug.cgi?id=96726
946 Reviewed by Kent Tamura.
948 * tests/LocaleMacTest.cpp:
949 (LocaleMacTest::timeFormat):
950 (LocaleMacTest::shortTimeFormat):
952 * tests/LocaleWinTest.cpp:
953 (LocaleWinTest::timeFormat):
954 (LocaleWinTest::shortTimeFormat):
956 * tests/LocalizedDateICUTest.cpp:
957 (LocalizedDateICUTest::localizedDateFormatText):
958 (LocalizedDateICUTest::localizedShortDateFormatText):
960 2012-09-14 Keishi Hattori <keishi@webkit.org>
962 LocaleMac should fallback to defaultLanguage for an invalid locale
963 https://bugs.webkit.org/show_bug.cgi?id=96744
965 Reviewed by Kent Tamura.
967 * tests/LocaleMacTest.cpp:
970 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
972 Unreviewed, rolling out r128543.
973 http://trac.webkit.org/changeset/128543
974 https://bugs.webkit.org/show_bug.cgi?id=96722
976 Caused LocaleWinTest.localizedNumberRoundTrip to fail
977 (Requested by keishi on #webkit).
979 * tests/LocaleWinTest.cpp:
980 (testNumberIsReversible):
984 2012-09-13 Keishi Hattori <keishi@webkit.org>
986 Create Localizer factory method for LocaleWin
987 https://bugs.webkit.org/show_bug.cgi?id=96667
989 Reviewed by Kent Tamura.
991 * tests/LocaleWinTest.cpp:
992 (testNumberIsReversible):
995 2012-09-13 Joshua Bell <jsbell@chromium.org>
997 IndexedDB: Consolidate two-phase connection to avoid race conditions
998 https://bugs.webkit.org/show_bug.cgi?id=90411
1000 Reviewed by Tony Chang.
1002 API plumbing for simplified single-phase connection opening, and tests updated
1003 to exercise the new APIs.
1005 * public/WebIDBDatabase.h:
1006 (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
1007 * public/WebIDBFactory.h:
1010 (WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
1011 * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
1012 (WebKit::IDBCallbacksProxy::onSuccess):
1013 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1015 (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
1016 the db-callbacks and hook it up when the onSuccess callback comes through.
1017 * src/IDBCallbacksProxy.h:
1019 (IDBCallbacksProxy):
1020 * src/IDBDatabaseBackendProxy.cpp:
1021 * src/IDBDatabaseBackendProxy.h:
1022 (IDBDatabaseBackendProxy):
1023 * src/IDBFactoryBackendProxy.cpp:
1024 (WebKit::IDBFactoryBackendProxy::open):
1025 * src/IDBFactoryBackendProxy.h:
1026 (IDBFactoryBackendProxy):
1027 * src/WebIDBDatabaseImpl.cpp:
1028 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1029 (WebKit::WebIDBDatabaseImpl::close):
1030 * src/WebIDBDatabaseImpl.h:
1031 (WebIDBDatabaseImpl):
1032 * src/WebIDBFactoryImpl.cpp:
1033 (WebKit::WebIDBFactoryImpl::open):
1034 * src/WebIDBFactoryImpl.h:
1035 (WebIDBFactoryImpl):
1036 * tests/IDBAbortOnCorruptTest.cpp:
1037 (FakeIDBDatabaseCallbacks):
1038 (WebCore::FakeIDBDatabaseCallbacks::create):
1039 (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
1040 (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
1042 (WebCore::TEST): Updated connection sequence.
1043 * tests/IDBDatabaseBackendTest.cpp: Ditto.
1045 2012-09-13 James Robinson <jamesr@chromium.org>
1047 PlatformGestureCurveTest compile fix pt 2
1049 * tests/PlatformGestureCurveTest.cpp:
1051 2012-09-13 James Robinson <jamesr@chromium.org>
1053 Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix.
1055 * tests/PlatformGestureCurveTest.cpp:
1057 2012-09-13 Julien Chaffraix <jchaffraix@webkit.org>
1059 [Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place
1060 https://bugs.webkit.org/show_bug.cgi?id=96593
1062 Reviewed by Adam Barth.
1064 After r127457, the HitTestResult stored in ContextMenuController is in window coordinates.
1065 Trying to convert it again to window coordinates will result in adding the containing frame's
1066 position twice, thus the wrong placing.
1068 Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac.
1070 Unfortunately, no test as I don't think we have a way of testing context menu position.
1072 * src/ContextMenuClientImpl.cpp:
1073 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1075 2012-09-13 Robert Kroeger <rjkroege@chromium.org>
1077 [chromium] alter fling animation parameters.
1078 https://bugs.webkit.org/show_bug.cgi?id=96666
1080 Reviewed by Adrienne Walker.
1082 Corrected the test to be non-fragile in the presence of altered fling
1085 * tests/PlatformGestureCurveTest.cpp:
1087 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
1089 Unreviewed, rolling out r128489.
1090 http://trac.webkit.org/changeset/128489
1091 https://bugs.webkit.org/show_bug.cgi?id=96686
1093 Does not compile on windows (Requested by jamesr on #webkit).
1095 * public/WebIDBDatabase.h:
1096 * public/WebIDBFactory.h:
1098 * src/IDBCallbacksProxy.cpp:
1099 (WebKit::IDBCallbacksProxy::onSuccess):
1100 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1101 * src/IDBCallbacksProxy.h:
1103 (IDBCallbacksProxy):
1104 * src/IDBDatabaseBackendProxy.cpp:
1105 (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
1107 * src/IDBDatabaseBackendProxy.h:
1108 (IDBDatabaseBackendProxy):
1109 * src/IDBFactoryBackendProxy.cpp:
1110 (WebKit::IDBFactoryBackendProxy::open):
1111 * src/IDBFactoryBackendProxy.h:
1112 (IDBFactoryBackendProxy):
1113 * src/WebIDBDatabaseImpl.cpp:
1114 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1115 (WebKit::WebIDBDatabaseImpl::close):
1116 (WebKit::WebIDBDatabaseImpl::open):
1118 * src/WebIDBDatabaseImpl.h:
1119 (WebIDBDatabaseImpl):
1120 * src/WebIDBFactoryImpl.cpp:
1121 (WebKit::WebIDBFactoryImpl::open):
1122 * src/WebIDBFactoryImpl.h:
1123 (WebIDBFactoryImpl):
1124 * tests/IDBAbortOnCorruptTest.cpp:
1126 * tests/IDBDatabaseBackendTest.cpp:
1128 2012-09-13 Glenn Hartmann <hartmanng@chromium.org>
1130 Add new accelerated compositing for overflow scroll setting.
1131 https://bugs.webkit.org/show_bug.cgi?id=95885
1133 Reviewed by James Robinson.
1135 wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which
1136 currently returns true if we're overflow scrolling and the element has
1137 been styled with '-webkit-overflow-scrolling: touch'. If this is true,
1138 we get promoted to a composited layer, the associated RenderLayerBacking
1139 gets special scrolling layers and in response to RenderLayer::scrollTo()
1140 we no longer have to invalidate everything to get the scrolled content
1141 in the right spot, thereby avoiding very expensive repaints. It's
1142 unfortunate that we require -webkit-overflow-scrolling: touch, though.
1143 It would be nice if RenderLayer::usesCompositedScrolling() returned true
1144 if the page would continue to behave correctly. This is what
1145 wkb.ug/94743 is intended to do. Unfortunately, when we become a
1146 composited layer, we switch from subpixel to grayscale anti-aliasing. We
1147 only want to auto-opt into composited scrolling if we don't mind the
1148 change in anti-aliasing, so we need a flag to enable/disable this
1151 * public/WebSettings.h:
1152 * src/WebSettingsImpl.cpp:
1153 (WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled):
1155 * src/WebSettingsImpl.h:
1158 2012-09-13 Joshua Bell <jsbell@chromium.org>
1160 IndexedDB: Consolidate two-phase connection to avoid race conditions
1161 https://bugs.webkit.org/show_bug.cgi?id=90411
1163 Reviewed by Tony Chang.
1165 API plumbing for simplified single-phase connection opening, and tests updated
1166 to exercise the new APIs.
1168 * public/WebIDBDatabase.h:
1169 (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
1170 * public/WebIDBFactory.h:
1173 (WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
1174 * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
1175 (WebKit::IDBCallbacksProxy::onSuccess):
1176 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1178 (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
1179 the db-callbacks and hook it up when the onSuccess callback comes through.
1180 * src/IDBCallbacksProxy.h:
1182 (IDBCallbacksProxy):
1183 * src/IDBDatabaseBackendProxy.cpp:
1184 * src/IDBDatabaseBackendProxy.h:
1185 (IDBDatabaseBackendProxy):
1186 * src/IDBFactoryBackendProxy.cpp:
1187 (WebKit::IDBFactoryBackendProxy::open):
1188 * src/IDBFactoryBackendProxy.h:
1189 (IDBFactoryBackendProxy):
1190 * src/WebIDBDatabaseImpl.cpp:
1191 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1192 (WebKit::WebIDBDatabaseImpl::close):
1193 * src/WebIDBDatabaseImpl.h:
1194 (WebIDBDatabaseImpl):
1195 * src/WebIDBFactoryImpl.cpp:
1196 (WebKit::WebIDBFactoryImpl::open):
1197 * src/WebIDBFactoryImpl.h:
1198 (WebIDBFactoryImpl):
1199 * tests/IDBAbortOnCorruptTest.cpp:
1200 (FakeIDBDatabaseCallbacks):
1201 (WebCore::FakeIDBDatabaseCallbacks::create):
1202 (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
1203 (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
1205 (WebCore::TEST): Updated connection sequence.
1206 * tests/IDBDatabaseBackendTest.cpp: Ditto.
1208 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
1210 Unreviewed. Rolled DEPS.
1214 2012-09-13 Ilya Tikhonovsky <loislo@chromium.org>
1216 Web Inspector: NMI: instrument KURL directly.
1217 https://bugs.webkit.org/show_bug.cgi?id=96624
1219 Reviewed by Yury Semikhatsky.
1221 I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
1222 CString* were also instrumented.
1224 Drive by fix: Instrumentation code in QualifiedName was moved to cpp.
1226 * tests/MemoryInstrumentationTest.cpp:
1228 (InstrumentedOwner):
1229 (WebCore::InstrumentedOwner::InstrumentedOwner):
1230 (WebCore::InstrumentedOwner::reportMemoryUsage):
1233 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
1235 Unreviewed, rolling out r128409.
1236 http://trac.webkit.org/changeset/128409
1237 https://bugs.webkit.org/show_bug.cgi?id=96622
1239 It broke Chromium browser_tests (Requested by tkent on
1242 * src/WebFrameImpl.cpp:
1243 (WebKit::WebFrameImpl::scopeStringMatches):
1244 (WebKit::WebFrameImpl::shouldScopeMatches):
1246 2012-09-13 Taiju Tsuiki <tzik@chromium.org>
1248 Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call.
1249 https://bugs.webkit.org/show_bug.cgi?id=96601
1251 Reviewed by Kent Tamura.
1253 m_webFrame might be already deleted after terminateWorkerContext call.
1254 This patch ensure it be NULL and change to avoid using it.
1256 Test: fast/filesystem/workers/detached-frame-crash.html
1258 * src/WebWorkerClientImpl.cpp:
1259 (WebKit::WebWorkerClientImpl::terminateWorkerContext):
1260 (WebKit::WebWorkerClientImpl::openFileSystem):
1262 2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org>
1264 [Chromium] Fix cases where find-in-page doesn't send a final update
1265 https://bugs.webkit.org/show_bug.cgi?id=96402
1267 Fix some issues in the WebKit implementation that prevented to send a final
1268 reportFindInPageMatchCount message.
1270 Reviewed by Adam Barth.
1272 * src/WebFrameImpl.cpp:
1273 (WebKit::WebFrameImpl::scopeStringMatches):
1274 (WebKit::WebFrameImpl::shouldScopeMatches):
1276 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1278 Unreviewed, rolling out r127876.
1279 http://trac.webkit.org/changeset/127876
1280 https://bugs.webkit.org/show_bug.cgi?id=96600
1282 mouse click doesn't work for spin button if spin button in
1283 iframe (Requested by yosin on #webkit).
1285 * src/ContextMenuClientImpl.cpp:
1286 (WebKit::selectMisspelledWord):
1287 * src/FrameLoaderClientImpl.cpp:
1288 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
1289 * src/WebFrameImpl.cpp:
1290 (WebKit::WebFrameImpl::characterIndexForPoint):
1291 * src/WebPluginContainerImpl.cpp:
1292 (WebKit::WebPluginContainerImpl::isRectTopmost):
1293 * src/WebViewImpl.cpp:
1294 (WebKit::WebViewImpl::handleMouseUp):
1295 (WebKit::WebViewImpl::computeBlockBounds):
1297 2012-09-12 Rick Byers <rbyers@chromium.org>
1299 [chromium] Remove unused WebGestureEvent fields
1300 https://bugs.webkit.org/show_bug.cgi?id=95496
1302 Reviewed by Adam Barth.
1304 Remove the no-longer used fields from WebGestureEvent, now that
1305 chromium has been updated to use the per-event-type fields instead.
1306 This depends on crrev.com/156346 in chromium.
1308 * public/WebInputEvent.h:
1309 (WebKit::WebGestureEvent::WebGestureEvent):
1310 * public/android/WebInputEventFactory.h:
1311 * src/WebInputEvent.cpp:
1312 (SameSizeAsWebGestureEvent):
1313 * src/android/WebInputEventFactory.cpp:
1315 (WebKit::WebInputEventFactory::gestureEvent):
1317 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1319 Unreviewed, rolling out r128351.
1320 http://trac.webkit.org/changeset/128351
1321 https://bugs.webkit.org/show_bug.cgi?id=96573
1323 Broke FindInPage browser_tests (Requested by jamesr_ on
1326 * src/WebFrameImpl.cpp:
1327 (WebKit::WebFrameImpl::scopeStringMatches):
1328 (WebKit::WebFrameImpl::cancelPendingScopingEffort):
1329 (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
1330 (WebKit::WebFrameImpl::shouldScopeMatches):
1332 2012-09-12 Adrienne Walker <enne@google.com>
1334 [chromium] Fix search tickmarks not disappearing when compositing is enabled
1335 https://bugs.webkit.org/show_bug.cgi?id=96536
1337 Reviewed by James Robinson.
1339 view->invalidateRect() on the root frame just invalidates the
1340 contents, since WebViewImpl doesn't know anything about scrollbar
1341 layers. This causes an "InvalidateAll" to not actually invalidate the
1344 To fix this, make WebFrameImpl explicitly invalidate the
1345 scrollbars when required.
1347 * src/WebFrameImpl.cpp:
1348 (WebKit::WebFrameImpl::invalidateArea):
1350 2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org>
1352 [Chromium] Fix cases where find-in-page doesn't send a final update
1353 https://bugs.webkit.org/show_bug.cgi?id=96402
1355 Fix some issues in the WebKit implementation that prevented to send a final
1356 reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
1357 when calling the stopFinding method.
1359 Reviewed by Adam Barth.
1361 * src/WebFrameImpl.cpp:
1362 (WebKit::WebFrameImpl::scopeStringMatches):
1363 (WebKit::WebFrameImpl::cancelPendingScopingEffort):
1364 (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
1365 (WebKit::WebFrameImpl::shouldScopeMatches):
1367 2012-09-12 Sami Kyostila <skyostil@google.com>
1369 Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
1370 https://bugs.webkit.org/show_bug.cgi?id=96251
1372 Reviewed by Simon Fraser.
1374 Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
1375 the feature it controls.
1379 2012-09-12 Christopher Cameron <ccameron@chromium.org>
1381 [chromium] Evict textures through the texture manager instead of the resource provider
1382 https://bugs.webkit.org/show_bug.cgi?id=96463
1384 Reviewed by James Robinson.
1386 Update layer tree host impl test to include the extra interface functions
1387 added to CCLayerTreeHostImplClient.
1389 * tests/CCLayerTreeHostImplTest.cpp:
1391 2012-09-12 Ilya Tikhonovsky <loislo@chromium.org>
1393 Web Inspector: NMI move String* instrumentation to wtf.
1394 https://bugs.webkit.org/show_bug.cgi?id=96405
1396 Reviewed by Yury Semikhatsky.
1398 This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
1400 Tested by webkit_unit_tests.
1402 * tests/MemoryInstrumentationTest.cpp:
1405 2012-09-12 Philippe Liard <pliard@google.com>
1407 Depend on {base,net} GYP targets rather than {base,net}_java.
1408 https://bugs.webkit.org/show_bug.cgi?id=95690
1410 Reviewed by Adam Barth.
1412 {base,net}_java became 'private' targets on the Chromium side that
1413 clients should not depend on (see
1414 https://chromiumcodereview.appspot.com/10913083/).
1415 This also adds the missing 'chromium_net.jar' to |input_jars_paths|
1416 that was magically included in Chrome for Android downstream but not
1417 upstream. It's needed to register JNI for 'net' in webkit_unit_tests.
1420 * WebKitUnitTests.gyp:
1422 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1424 Unreviewed, rolling out r128279.
1425 http://trac.webkit.org/changeset/128279
1426 https://bugs.webkit.org/show_bug.cgi?id=96487
1428 "Snow Leopard compilation broken" (Requested by yurys on
1431 * tests/MemoryInstrumentationTest.cpp:
1432 (WebCore::InstrumentedUndefined::reportMemoryUsage):
1435 2012-09-12 Ilya Tikhonovsky <loislo@chromium.org>
1437 Web Inspector: NMI move String* instrumentation to wtf.
1438 https://bugs.webkit.org/show_bug.cgi?id=96405
1440 Reviewed by Yury Semikhatsky.
1442 This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
1444 Tested by webkit_unit_tests.
1446 * tests/MemoryInstrumentationTest.cpp:
1447 (WebCore::InstrumentedUndefined::reportMemoryUsage):
1450 2012-09-12 Jochen Eisinger <jochen@chromium.org>
1452 [chromium] consumable user gesture count off for input events
1453 https://bugs.webkit.org/show_bug.cgi?id=96373
1455 Reviewed by Adam Barth.
1457 Don't create a UserGestureIndicator in the chromium layer, as it will
1458 already be created by webcore's event handler. Creating multiple
1459 UserGestureIndicator objects for the same object would allow to execute
1460 multiple user-gesture-gated actions per user gesture such as opening a
1463 * public/WebInputEvent.h:
1464 * src/WebViewImpl.cpp:
1465 (WebKit::WebViewImpl::handleInputEvent):
1467 2012-09-12 Alexandre Elias <aelias@chromium.org>
1469 [chromium] Flip Y and swizzle inside compositeAndReadback implementation
1470 https://bugs.webkit.org/show_bug.cgi?id=96458
1472 Reviewed by James Robinson.
1474 Currently, compositeAndReadback API assumes a GL-style texture
1475 and is converted to the normal software format in WebViewImpl.
1476 For the software implementation, this API would result in two
1477 redundant conversions. This patch makes the conversion inside
1478 CCRendererGL instead. I rolled my own for loop as I didn't find the
1479 appropriate function within raw Skia.
1481 No new tests (covered by existing layout tests).
1483 * src/WebViewImpl.cpp:
1484 (WebKit::WebViewImpl::doPixelReadbackToCanvas):
1486 2012-09-11 Taiju Tsuiki <tzik@chromium.org>
1488 WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem
1489 https://bugs.webkit.org/show_bug.cgi?id=96354
1491 Reviewed by Kent Tamura.
1493 Ensure non-NULL before using WebFrameImpl::client().
1495 Test: fast/filesystem/workers/detached-frame-crash.html
1497 * src/WebWorkerClientImpl.cpp:
1498 (WebKit::WebWorkerClientImpl::openFileSystem):
1500 2012-09-11 Keishi Hattori <keishi@webkit.org>
1502 Create Localizer factory method for LocaleICU
1503 https://bugs.webkit.org/show_bug.cgi?id=96363
1505 Reviewed by Kent Tamura.
1507 * tests/LocalizedNumberICUTest.cpp:
1508 (testNumberIsReversible):
1509 (testDecimalSeparator):
1511 2012-09-11 Christopher Cameron <ccameron@chromium.org>
1513 [chromium] Make prioritized texture manager not touch backings array on the main thread
1514 https://bugs.webkit.org/show_bug.cgi?id=96114
1516 Reviewed by James Robinson.
1518 Take a snapshot of the textures' priorities from the main thread,
1519 and save it in their backings for access by the impl thread.
1520 Update functions that access the sorted backings array to use the
1521 snapshotted values instead of the values that the main thread may
1522 have computed for the next frame.
1524 Make the main thread not touch the m_backings array. Split
1525 prioritizeTextures into a updateBackingsPriorities function.
1526 In places where the main thread would have touched m_backings,
1527 set a flag specifying that m_backings needs to be re-sorted
1528 before any function that requires it be sorted by priority be
1531 Update the two functions that require sorted order (acquireBacking
1532 and reduceMemory) to sort the backings array (if needed) before
1535 Updated tests to set correct thread during asserts. Add a test to
1536 verify that requestLate is correctly incorporated into the backing
1539 * tests/CCPrioritizedTextureTest.cpp:
1540 (WTF::CCPrioritizedTextureTest::validateTexture):
1542 2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com>
1544 Unreviewed. Rolled DEPS.
1548 2012-09-11 Iain Merrick <husky@chromium.org>
1550 [chromium] Fix double call to scrollBegin() when handling scroll gesture
1551 https://bugs.webkit.org/show_bug.cgi?id=95322
1553 Reviewed by James Robinson.
1555 WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its
1556 client, then if the result is ScrollStarted, it creates a PlatformGestureCurve
1557 object to handle the fling animation. This patch adds a matching scrollEnd()
1558 before the animation starts.
1560 Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all
1561 unexpected calls into test failures. This ensures that scrollBegin / scrollEnd
1562 happen exactly when we want and at no other times.
1564 * src/WebCompositorInputHandlerImpl.cpp:
1565 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1566 * tests/WebCompositorInputHandlerImplTest.cpp:
1567 (WebCompositorInputHandlerImplTest):
1570 2012-09-11 Peter Beverloo <peter@chromium.org>
1572 Unreviewed. Rolled DEPS.
1576 2012-09-11 Keishi Hattori <keishi@webkit.org>
1578 Create Localizer factory method for LocaleMac
1579 https://bugs.webkit.org/show_bug.cgi?id=96355
1581 Reviewed by Kent Tamura.
1583 * tests/LocaleMacTest.cpp:
1584 (testNumberIsReversible): Use Localizer::create.
1587 2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com>
1589 Unreviewed, rolling out r128150.
1590 http://trac.webkit.org/changeset/128150
1591 https://bugs.webkit.org/show_bug.cgi?id=96357
1593 it broke chromium compilation (Requested by loislo on
1598 2012-09-10 Sheriff Bot <webkit.review.bot@gmail.com>
1600 Unreviewed. Rolled DEPS.
1604 2012-09-10 Joanmarie Diggs <jdiggs@igalia.com>
1606 Properly expose <legend> elements to ATs
1607 https://bugs.webkit.org/show_bug.cgi?id=84137
1609 Reviewed by Chris Fleizach.
1611 Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1612 the expected platform role, ATK_ROLE_LABEL. Also established the needed
1613 AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1615 * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend
1616 * src/AssertMatchingEnums.cpp: added the assert matching rule for
1617 WebAccessibilityRoleLegend and LegendRole
1619 2012-09-10 Beth Dakin <bdakin@apple.com>
1621 https://bugs.webkit.org/show_bug.cgi?id=96158
1622 Need API to suppress scrollbar animations
1624 <rdar://problem/12210972>
1626 Reviewed by Sam Weinig.
1628 ScrollableArea::isOnActivePage() has been re-named to
1629 ScrollableArea:: scrollbarsCanBeActive().
1630 * src/ScrollbarGroup.cpp:
1631 (WebKit::ScrollbarGroup::scrollbarsCanBeActive):
1632 * src/ScrollbarGroup.h:
1633 * tests/GraphicsLayerChromiumTest.cpp:
1634 * tests/ScrollAnimatorNoneTest.cpp:
1635 (MockScrollableArea):
1637 2012-09-10 Dan Alcantara <dfalcantara@chromium.org>
1639 [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in
1640 https://bugs.webkit.org/show_bug.cgi?id=90222
1642 Reviewed by Adam Barth.
1644 When reloading a page with an overridden URL, the page's scroll and zoom
1645 state will be restored once the reload is complete. This is problematic
1646 in situations when switching between mobile and desktop versions of the
1647 same site because it will zoom back in on a random part of alternate page.
1648 This CL just avoids that situation by resetting the zoom and scale whenever
1649 this type of reload occurs.
1651 Chromium half: https://chromiumcodereview.appspot.com/10889019
1655 * src/WebViewImpl.cpp:
1656 (WebKit::WebViewImpl::resetScrollAndScaleState):
1658 * src/WebViewImpl.h:
1661 2012-09-10 Adam Barth <abarth@chromium.org>
1663 [V8] V8AuxiliaryContext used by IDB leaks memory
1664 https://bugs.webkit.org/show_bug.cgi?id=96317
1666 Reviewed by Tony Chang.
1668 Call the V8 APIs directly instead of using a helper class.
1670 * tests/IDBBindingUtilitiesTest.cpp:
1673 2012-09-10 Adam Barth <abarth@chromium.org>
1675 [V8] Inline firstFrame and currentFrame into their unique callers
1676 https://bugs.webkit.org/show_bug.cgi?id=96309
1678 Reviewed by Eric Seidel.
1680 This patch just lines these WebCore functions because we only call them
1683 * src/WebFrameImpl.cpp:
1684 (WebKit::WebFrame::frameForEnteredContext):
1685 (WebKit::WebFrame::frameForCurrentContext):
1687 2012-09-10 Rick Byers <rbyers@chromium.org>
1689 [chromium] Add unused GestureTapCancel
1690 https://bugs.webkit.org/show_bug.cgi?id=96183
1692 Reviewed by Adam Barth.
1694 This adds a new 'tap cancel' gesture type. This is temporarily unused,
1695 so that we can change chromium to start sending the gesture type
1696 without breaking anything.
1698 * public/WebInputEvent.h:
1699 * src/PageWidgetDelegate.cpp:
1700 (WebKit::PageWidgetDelegate::handleInputEvent):
1701 * src/WebInputEventConversion.cpp:
1702 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1703 * src/WebPopupMenuImpl.cpp:
1704 (WebKit::WebPopupMenuImpl::handleInputEvent):
1705 * src/WebViewImpl.cpp:
1706 (WebKit::WebViewImpl::handleGestureEvent):
1708 2012-09-10 Mark Pilgrim <pilgrim@chromium.org>
1710 [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
1711 https://bugs.webkit.org/show_bug.cgi?id=95861
1713 Reviewed by Adam Barth.
1715 Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport.
1717 * public/WebSharedWorkerRepository.h:
1719 * src/SharedWorkerRepository.cpp:
1721 (WebKit::setSharedWorkerRepository):
1722 (WebKit::sharedWorkerRepository):
1723 (WebCore::SharedWorkerRepository::isAvailable):
1724 (WebCore::SharedWorkerRepository::connect):
1725 (WebCore::SharedWorkerRepository::documentDetached):
1726 (WebCore::SharedWorkerRepository::hasSharedWorkers):
1728 2012-09-10 Catalin Badea <badea@adobe.com>
1730 webkit build for 64-bit Mac chromium
1731 https://bugs.webkit.org/show_bug.cgi?id=95977
1733 Reviewed by Eric Seidel.
1735 Ensure header completeness and use the correct include order. This fixes a compilation issues noticeable when building chromium for 64-bit Mac.
1737 * public/mac/WebSubstringUtil.h:
1738 * src/mac/WebSubstringUtil.mm:
1740 2012-09-10 Adrienne Walker <enne@google.com>
1742 [chromium] Fix deadlock between WebMediaPlayerClientImpl dtor and PutCurrentFrame
1743 https://bugs.webkit.org/show_bug.cgi?id=96010
1745 Reviewed by James Robinson.
1747 The key fix here is that the destructor no longer has a mutex.
1748 The m_compositingMutex was supposedly protecting races between
1749 ~WebMediaPlayerClientImpl and setVideoFrameProviderClient. The
1750 former is only called from the main thread and the latter is called
1751 from the compositor thread only when the main thread is blocked (and
1752 it already asserts that this is the case).
1754 In addition, the m_providerMutex in CCVideoLayerImpl prevents the
1755 destruction of WebMediaPlayerClientImpl, thus keeping the frame
1756 acquired via getCurrentFrame alive until putCurrentFrame is called.
1757 These functions are only called by the client, and comments are added
1758 to the interface to better document this.
1760 To prevent a race between load() and getCurrentFrame/putCurrentFrame
1761 (which are called from different threads) a new m_webMediaPlayerMutex
1762 to replace part of what the old m_compositingMutex was doing.
1764 * src/WebMediaPlayerClientImpl.cpp:
1765 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
1766 (WebKit::WebMediaPlayerClientImpl::load):
1767 (WebKit::WebMediaPlayerClientImpl::loadInternal):
1768 (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
1769 (WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
1770 (WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
1771 * src/WebMediaPlayerClientImpl.h:
1772 (WebMediaPlayerClientImpl):
1774 2012-09-10 Rick Byers <rbyers@chromium.org>
1776 [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment
1777 https://bugs.webkit.org/show_bug.cgi?id=95996
1779 Reviewed by Adam Barth.
1781 Switch from WebGestureEvent.boundingBox to new gesture-type specific
1783 * src/WebViewImpl.cpp:
1784 (WebKit::WebViewImpl::handleGestureEvent):
1786 2012-09-09 Keishi Hattori <keishi@webkit.org>
1788 REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup
1789 https://bugs.webkit.org/show_bug.cgi?id=96222
1791 Reviewed by Kent Tamura.
1793 DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser()
1794 so we shouldn't be changing the members after that.
1796 Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html.
1798 * src/DateTimeChooserImpl.cpp:
1799 (WebKit::DateTimeChooserImpl::didClosePopup):
1801 2012-09-09 Kenichi Ishibashi <bashi@chromium.org>
1803 [Chromium] Unreviewed gardening after r127907
1805 Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads
1807 * tests/CCRenderPassTest.cpp:
1808 (CCRenderPassSize): Changed type of m_id
1810 2012-09-09 Emil A Eklund <eae@chromium.org>
1812 Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
1813 https://bugs.webkit.org/show_bug.cgi?id=81413
1815 Reviewed by David Hyatt.
1817 Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.
1819 * src/WebViewImpl.cpp:
1820 (WebKit::WebViewImpl::computeBlockBounds):
1821 (WebKit::WebViewImpl::applyAutofillSuggestions):
1822 (WebKit::WebViewImpl::refreshAutofillPopup):
1824 2012-09-09 James Robinson <jamesr@chromium.org>
1826 [chromium] webkit_platform should only be linked into the webkit target
1827 https://bugs.webkit.org/show_bug.cgi?id=96213
1829 Reviewed by Adrienne Walker.
1831 The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
1832 makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.
1836 2012-09-09 James Robinson <jamesr@chromium.org>
1838 [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
1839 https://bugs.webkit.org/show_bug.cgi?id=96212
1841 Reviewed by Adrienne Walker.
1843 The static ::create()s the test references currently are going away soon.
1845 * tests/GraphicsLayerChromiumTest.cpp:
1846 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1849 2012-09-07 Benjamin Poulain <benjamin@webkit.org>
1851 Unreviewed prospective build fix.
1853 * tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.
1854 Remove the using directive from r127959.
1856 2012-09-07 Simon Hausmann <simon.hausmann@nokia.com>
1858 Unreviewed prospective build fix.
1860 Use WTF namespace like in other files in the same directory to resolve unqualified
1863 * tests/WebCompositorInputHandlerImplTest.cpp:
1865 2012-09-07 James Robinson <jamesr@chromium.org>
1867 [chromium] Remove transitional WebCompositorSupport fallback code
1868 https://bugs.webkit.org/show_bug.cgi?id=96155
1870 Reviewed by Adrienne Walker.
1872 * src/LinkHighlight.cpp:
1873 (WebKit::LinkHighlight::LinkHighlight):
1874 (WebKit::LinkHighlight::startHighlightAnimation):
1875 * src/WebMediaPlayerClientImpl.cpp:
1876 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
1877 * src/WebPluginContainerImpl.cpp:
1878 (WebKit::WebPluginContainerImpl::setBackingTextureId):
1879 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
1880 * src/WebViewImpl.cpp:
1881 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1884 2012-09-07 James Robinson <jamesr@chromium.org>
1886 [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
1887 https://bugs.webkit.org/show_bug.cgi?id=96151
1889 Reviewed by Adrienne Walker.
1891 Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
1892 WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
1893 provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.
1895 WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
1896 and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as
1899 WCIHI changes covered by unit tests, overall scrolling behavior manually tested.
1902 * src/WebCompositorInputHandlerImpl.cpp:
1903 (WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
1904 (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
1905 (WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
1906 (WebKit::WebCompositorInputHandlerImpl::setClient):
1907 (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
1908 (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
1909 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1910 (WebKit::WebCompositorInputHandlerImpl::bindToClient):
1911 * src/WebCompositorInputHandlerImpl.h:
1912 (WebCompositorInputHandlerImpl):
1913 (WebKit::WebCompositorInputHandlerImpl::identifier):
1914 * src/WebLayerTreeViewImpl.cpp:
1915 (WebKit::WebLayerTreeViewImpl::createInputHandler):
1917 * src/WebLayerTreeViewImpl.h:
1918 (WebLayerTreeViewImpl):
1919 * src/WebToCCInputHandlerAdapter.cpp: Added.
1921 (WebKit::WebToCCInputHandlerAdapter::create):
1922 (WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
1923 (WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
1924 (WebToCCInputHandlerAdapter::ClientAdapter):
1925 (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
1926 (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
1927 (WebKit::WebToCCInputHandlerAdapter::bindToClient):
1928 (WebKit::WebToCCInputHandlerAdapter::animate):
1929 * src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.
1931 (WebToCCInputHandlerAdapter):
1932 * src/WebViewImpl.cpp:
1933 (WebKit::WebViewImpl::WebViewImpl):
1934 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1936 (WebKit::WebViewImpl::createInputHandler):
1937 * src/WebViewImpl.h:
1939 * tests/CCThreadedTest.cpp:
1940 * tests/FakeCCLayerTreeHostClient.h:
1941 * tests/WebCompositorInputHandlerImplTest.cpp:
1942 (MockWebInputHandlerClient):
1943 (WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
1944 (WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
1945 (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
1946 (WebCompositorInputHandlerImplTest):
1949 2012-09-07 David Reveman <reveman@chromium.org>
1951 [Chromium] Multiple commits without invalidation allowed per redraw.
1952 https://bugs.webkit.org/show_bug.cgi?id=95661
1954 Reviewed by James Robinson.
1956 * tests/CCLayerTreeHostTest.cpp:
1957 (CCLayerTreeHostTestContinuousCommit):
1958 (WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
1960 (WebKitTests::TEST_F):
1961 (CCLayerTreeHostTestContinuousInvalidate):
1962 (WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
1963 (CCLayerTreeHostTestContinuousAnimate):
1964 (WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):
1965 * tests/CCSchedulerStateMachineTest.cpp:
1968 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
1970 AX: WebCore accessibility roles should be cross-platform
1971 https://bugs.webkit.org/show_bug.cgi?id=94870
1973 Reviewed by Chris Fleizach.
1975 Add a new accessibility role.
1977 * public/WebAccessibilityRole.h:
1978 * src/AssertMatchingEnums.cpp:
1980 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
1982 AX: Chromium needs access to canvasHasFallbackContent
1983 https://bugs.webkit.org/show_bug.cgi?id=96124
1985 Reviewed by Chris Fleizach.
1987 Expose canvasHasFallbackContent on Chromium.
1989 * public/WebAccessibilityObject.h:
1990 (WebAccessibilityObject):
1991 * src/WebAccessibilityObject.cpp:
1992 (WebKit::WebAccessibilityObject::canvasHasFallbackContent):
1995 2012-09-07 Robert Kroeger <rjkroege@chromium.org>
1997 [chromium] Add touchscreen specific fling curve parametrization
1998 https://bugs.webkit.org/show_bug.cgi?id=95997
2000 Reviewed by James Robinson.
2002 Added a new set of fling curve parameters with a good feel for touchscreen
2003 initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
2004 TouchFlingPlatformGestureCurve to better reflect that the class
2005 can serve for both touchscreen and touchpad flings when appropriately
2006 parametrized. Updated build files as necessary for the rename.
2008 No new tests - existing tests apply.
2011 * tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.
2013 2012-09-07 Dana Jansens <danakj@chromium.org>
2015 [chromium] Make RenderPass ids hold both generating layer id and an index
2016 https://bugs.webkit.org/show_bug.cgi?id=95500
2018 Reviewed by Adrienne Walker.
2020 * tests/CCLayerTreeHostImplTest.cpp:
2021 * tests/CCLayerTreeHostTest.cpp:
2022 * tests/CCRenderSurfaceTest.cpp:
2023 * tests/CCRendererGLTest.cpp:
2024 (FakeCCRendererClient::FakeCCRendererClient):
2026 2012-09-07 Joshua Bell <jsbell@chromium.org>
2028 [Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
2029 https://bugs.webkit.org/show_bug.cgi?id=96122
2031 Reviewed by Adam Barth.
2033 Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
2034 open() method now takes the "database callbacks", rather than being sent through
2037 Also, delete an obsolete method.
2039 * public/WebIDBFactory.h:
2041 (WebIDBFactory): Delete pre-version overload of open().
2042 (WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.
2044 2012-09-07 Sami Kyostila <skyostil@google.com>
2046 [Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
2047 https://bugs.webkit.org/show_bug.cgi?id=95932
2049 Reviewed by James Robinson.
2051 Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
2054 * tests/GraphicsLayerChromiumTest.cpp:
2055 (WebKit::TEST_F): Re-enable the test.
2057 2012-09-07 James Robinson <jamesr@chromium.org>
2059 [chromium] Move some CC unit tests into correct gyp variable
2060 https://bugs.webkit.org/show_bug.cgi?id=96048
2062 Reviewed by Adrienne Walker.
2064 These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.
2068 2012-09-07 James Robinson <jamesr@chromium.org>
2070 [chromium] Remove dead CCActiveGestureAnimation code and related classes
2071 https://bugs.webkit.org/show_bug.cgi?id=96075
2073 Reviewed by Adrienne Walker.
2075 Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
2076 evaluate the curve itself without intermediate classes.
2078 * src/WebCompositorInputHandlerImpl.cpp:
2079 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
2080 (WebKit::WebCompositorInputHandlerImpl::animate):
2081 (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
2082 * src/WebCompositorInputHandlerImpl.h:
2084 (WebCompositorInputHandlerImpl):
2085 * tests/PlatformGestureCurveTest.cpp:
2086 * tests/WebCompositorInputHandlerImplTest.cpp:
2088 2012-09-07 James Robinson <jamesr@chromium.org>
2090 [chromium] Clean up dependencies in ScrollbarLayerChromiumTest
2091 https://bugs.webkit.org/show_bug.cgi?id=96052
2093 Reviewed by Adrienne Walker.
2095 Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
2096 *) WebScrollbarImpl.h is #included, but not use
2097 *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
2098 WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
2100 * tests/ScrollbarLayerChromiumTest.cpp:
2103 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
2105 AX: ARIA spin button should support range value attributes
2106 https://bugs.webkit.org/show_bug.cgi?id=96076
2108 Reviewed by Chris Fleizach.
2110 Expose supportsRangeValue to simplify Chromium logic for when to
2111 extract a value from a range.
2113 * public/WebAccessibilityObject.h:
2114 (WebAccessibilityObject):
2115 * src/WebAccessibilityObject.cpp:
2116 (WebKit::WebAccessibilityObject::supportsRangeValue):
2119 2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
2121 Simplify hitTestResultAtPoint and nodesFromRect APIs
2122 https://bugs.webkit.org/show_bug.cgi?id=95720
2124 Reviewed by Antonio Gomes.
2126 Update calls to new API.
2128 * src/ContextMenuClientImpl.cpp:
2129 (WebKit::selectMisspelledWord):
2130 * src/FrameLoaderClientImpl.cpp:
2131 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
2132 * src/WebFrameImpl.cpp:
2133 (WebKit::WebFrameImpl::characterIndexForPoint):
2134 * src/WebPluginContainerImpl.cpp:
2135 (WebKit::WebPluginContainerImpl::isRectTopmost):
2136 * src/WebViewImpl.cpp:
2137 (WebKit::WebViewImpl::handleMouseUp):
2138 (WebKit::WebViewImpl::computeBlockBounds):
2140 2012-09-07 Ilya Tikhonovsky <loislo@chromium.org>
2142 Web Inspector: NMI: move WebCore specific code to separate header
2143 https://bugs.webkit.org/show_bug.cgi?id=96101
2145 Reviewed by Yury Semikhatsky.
2147 I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h
2149 * tests/MemoryInstrumentationTest.cpp:
2151 2012-09-07 Ian Vollick <vollick@chromium.org>
2153 [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
2154 https://bugs.webkit.org/show_bug.cgi?id=95855
2156 Reviewed by James Robinson.
2158 Added the following unit tests:
2159 AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
2160 AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform
2162 * tests/AnimationTranslationUtilTest.cpp:
2166 2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
2168 X11 Global Selection
2169 https://bugs.webkit.org/show_bug.cgi?id=88238
2171 Reviewed by Tony Chang.
2173 Use new editor command for pasting global selection.
2175 * src/EditorClientImpl.cpp:
2176 (WebKit::EditorClientImpl::supportsGlobalSelection):
2177 * src/EditorClientImpl.h:
2179 * src/WebViewImpl.cpp:
2180 (WebKit::WebViewImpl::handleMouseUp):
2182 2012-09-07 Yoshifumi Inoue <yosin@chromium.org>
2184 We should have a localized string of empty for date time field
2185 https://bugs.webkit.org/show_bug.cgi?id=96081
2187 Reviewed by Kent Tamura.
2189 This patch add a function for getting localized string of empty field
2190 value of date time fields for accessibility inside
2191 ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
2193 These functions will be used by derived classes of DateTimeFieldElement.
2195 Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
2196 to support "date", "datetime", "month" and "week" multiple fields input
2199 * src/LocalizedStrings.cpp:
2200 (WebCore::AXDateTimeFieldEmptyValueText): Added.
2202 2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com>
2204 Unreviewed, rolling out r127822.
2205 http://trac.webkit.org/changeset/127822
2206 https://bugs.webkit.org/show_bug.cgi?id=96073
2208 It broke compilation on chromium debug bots (Requested by
2211 * tests/CCDrawQuadTest.cpp:
2213 * tests/CCLayerTreeHostImplTest.cpp:
2214 * tests/CCLayerTreeHostTest.cpp:
2215 * tests/CCRenderPassTest.cpp:
2217 * tests/CCRenderSurfaceTest.cpp:
2218 * tests/CCRendererGLTest.cpp:
2219 (FakeCCRendererClient::FakeCCRendererClient):
2221 2012-09-06 Dana Jansens <danakj@chromium.org>
2223 [chromium] Make RenderPass ids hold both generating layer id and an index
2224 https://bugs.webkit.org/show_bug.cgi?id=95500
2226 Reviewed by Adrienne Walker.
2228 * tests/CCLayerTreeHostImplTest.cpp:
2229 * tests/CCLayerTreeHostTest.cpp:
2230 * tests/CCRenderSurfaceTest.cpp:
2231 * tests/CCRendererGLTest.cpp:
2232 (FakeCCRendererClient::FakeCCRendererClient):
2234 2012-09-06 Yoshifumi Inoue <yosin@chromium.org>
2236 We should have localized strings of date time fields for accessibility
2237 https://bugs.webkit.org/show_bug.cgi?id=96050
2239 Reviewed by Kent Tamura.
2241 This patch adds functions for getting localized strings of date time
2242 fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
2244 These functions will be used by derived classes of DateTimeFieldElement.
2246 Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
2247 to support "date", "datetime", "month" and "week" multiple fields input
2250 * src/LocalizedStrings.cpp:
2251 (WebCore::AXAMPMFieldText): Added.
2252 (WebCore::AXDayOfMonthFieldText): Added.
2253 (WebCore::AXHourFieldText): Added.
2254 (WebCore::AXMillisecondFieldText): Added.
2255 (WebCore::AXMinuteFieldText): Added.
2256 (WebCore::AXMonthFieldText): Added.
2257 (WebCore::AXSecondFieldText): Added.
2258 (WebCore::AXWeekOfYearFieldText): Added.
2259 (WebCore::AXYearFieldText): Added.
2261 2012-09-06 James Robinson <jamesr@chromium.org>
2263 [chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
2264 https://bugs.webkit.org/show_bug.cgi?id=96024
2266 Reviewed by Adam Barth.
2268 When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
2269 We don't need to link anything in to WebKit.dll.
2273 2012-09-06 James Robinson <jamesr@chromium.org>
2275 [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2276 https://bugs.webkit.org/show_bug.cgi?id=96007
2278 Reviewed by Adrienne Walker.
2280 Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
2281 WebCompositorInitializer RAII class to simplify this somewhat tedious process.
2284 * public/WebCompositorInputHandlerClient.h:
2285 (WebCompositorInputHandlerClient):
2286 * src/WebCompositorInputHandlerImpl.h:
2287 * src/WebViewImpl.cpp:
2288 (WebKit::WebViewImpl::composite):
2289 (WebKit::WebViewImpl::scheduleAnimation):
2290 (WebKit::WebViewImpl::scheduleComposite):
2291 * tests/CCPrioritizedTextureTest.cpp:
2292 (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
2293 (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
2294 (CCPrioritizedTextureTest):
2295 * tests/CCRendererGLTest.cpp:
2296 (CCRendererGLTest::CCRendererGLTest):
2297 (CCRendererGLTest::SetUp):
2299 * tests/CCTextureUpdateControllerTest.cpp:
2300 * tests/CCThreadedTest.cpp:
2301 (WebKitTests::CCThreadedTest::runTest):
2302 * tests/Canvas2DLayerBridgeTest.cpp:
2303 (Canvas2DLayerBridgeTest::fullLifecycleTest):
2304 * tests/GraphicsLayerChromiumTest.cpp:
2305 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2306 (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
2307 * tests/LayerChromiumTest.cpp:
2308 * tests/LinkHighlightTest.cpp:
2310 * tests/TextureLayerChromiumTest.cpp:
2311 * tests/TiledLayerChromiumTest.cpp:
2312 * tests/WebCompositorInitializer.h: Added.
2315 (WebCompositorInitializer):
2316 (WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
2317 (WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):
2318 * tests/WebCompositorInputHandlerImplTest.cpp:
2320 (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
2321 (WebCompositorInputHandlerImplTest):
2322 * tests/WebLayerTest.cpp:
2323 * tests/WebLayerTreeViewTest.cpp:
2325 2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com>
2327 Unreviewed. Rolled DEPS.
2331 2012-09-06 Alec Flett <alecflett@chromium.org>
2333 IndexedDB: make IDBKeyPath's string and array constructors explicit
2334 https://bugs.webkit.org/show_bug.cgi?id=96004
2336 Reviewed by Tony Chang.
2338 Fix test to use explicit constructor for IDBKeyPath.
2340 * tests/IDBDatabaseBackendTest.cpp:
2342 2012-09-06 Adrienne Walker <enne@google.com>
2344 [chromium] Remove GraphicsContext references from ContentLayerChromiumTest
2345 https://bugs.webkit.org/show_bug.cgi?id=96002
2347 Reviewed by James Robinson.
2349 This is a compositor unit test, so it shouldn't reference things
2350 outside of the compositor like GraphicsContext. The
2351 OpaqueRectTrackingContentLayerDelegateTest already tests opaque
2352 tracking right at the time of paint. This test is about verifying that
2353 transformed canvases work properly, so can just fake the opaque rect
2354 coming back from the paint.
2356 * tests/ContentLayerChromiumTest.cpp:
2357 (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
2360 2012-09-06 Jeff Timanus <twiz@chromium.org>
2362 [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
2363 https://bugs.webkit.org/show_bug.cgi?id=95094
2365 Reviewed by Adrienne Walker.
2367 In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
2368 try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
2369 contentsScale behaviour.
2370 This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.
2372 * src/NonCompositedContentHost.cpp:
2373 (WebKit::NonCompositedContentHost::NonCompositedContentHost):
2374 Inform the layer associated with the NCCH that it is to disregard the page scale factor.
2375 Also remove now unused m_deviceScaleFactor and associated routines.
2376 (WebKit::NonCompositedContentHost::setViewport):
2377 * src/NonCompositedContentHost.h:
2378 (NonCompositedContentHost):
2379 * src/WebContentLayerImpl.cpp:
2380 (WebKit::WebContentLayerImpl::setBoundsContainPageScale):
2382 (WebKit::WebContentLayerImpl::boundsContainPageScale):
2383 * src/WebContentLayerImpl.h:
2384 (WebContentLayerImpl):
2385 * src/WebViewImpl.cpp:
2386 (WebKit::WebViewImpl::updateLayerTreeViewport):
2387 * tests/CCLayerTreeHostTest.cpp:
2388 (NoScaleContentLayerChromium):
2389 (WebKitTests::NoScaleContentLayerChromium::create):
2390 (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
2392 (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
2393 Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the
2394 scale on the draw transforms remain identity.
2395 * tests/GraphicsLayerChromiumTest.cpp:
2396 (WebKit): Remove now obsolete unit-test.
2398 2012-09-06 Adrienne Walker <enne@google.com>
2400 [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
2401 https://bugs.webkit.org/show_bug.cgi?id=95994
2403 Reviewed by James Robinson.
2405 This compositor test shouldn't depend on code outside the compositor.
2407 * tests/ScrollbarLayerChromiumTest.cpp:
2408 (WebCore::FakeWebScrollbar::create):
2412 2012-09-06 James Robinson <jamesr@chromium.org>
2414 [chromium] Put chromium implementations of WTF symbols in separate static library
2415 https://bugs.webkit.org/show_bug.cgi?id=95933
2417 Reviewed by Adam Barth.
2419 A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
2420 implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
2421 component build is a DLL. This moves these files into a static library that webkit depends on so targets can
2422 statically link in wtf and these support files without depending directly on webkit.
2426 2012-09-06 Iain Merrick <husky@chromium.org>
2428 [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
2429 https://bugs.webkit.org/show_bug.cgi?id=93998
2431 Reviewed by Adam Barth.
2433 These provide the same functionality selectRange(WebPoint, WebPoint),
2434 with finer-grained control needed on the Android platform. By passing
2435 allowCollapsedSelection=false, we can ensure the selection stays at
2436 least one character wide.
2438 I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
2439 calling the new methods. The existing test passes, and I've added new
2440 tests for the new methods.
2442 * public/WebFrame.h:
2444 * src/WebFrameImpl.cpp:
2445 (WebKit::WebFrameImpl::selectRange):
2447 (WebKit::WebFrameImpl::moveSelectionStart):
2448 (WebKit::WebFrameImpl::moveSelectionEnd):
2449 (WebKit::WebFrameImpl::moveCaret):
2450 * src/WebFrameImpl.h:
2452 * tests/WebFrameTest.cpp:
2453 * tests/data/text_selection.html: Added.
2455 2012-09-06 Robert Kroeger <rjkroege@chromium.org>
2457 [chromium] Enable different fling behaviour for touchscreen and touchpad
2458 https://bugs.webkit.org/show_bug.cgi?id=95756
2460 Reviewed by James Robinson.
2462 Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
2463 events by their originating device and pass this flag to a factory that produces
2464 different device specific fling curves based on the value of the flag.
2466 * public/WebActiveWheelFlingParameters.h:
2467 (WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
2468 (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
2469 * public/WebInputEvent.h: Added source device flag to WebGestureEvent.
2470 * src/WebCompositorInputHandlerImpl.cpp:
2471 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to
2472 obtain device-appropriate fling curve.
2473 * src/WebViewImpl.cpp:
2474 (WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
2476 (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
2478 2012-09-05 Sam Weinig <sam@webkit.org>
2480 Part 2 of removing PlatformString.h, remove PlatformString.h
2481 https://bugs.webkit.org/show_bug.cgi?id=95931
2483 Reviewed by Adam Barth.
2485 Remove PlatformString.h
2487 * src/ContextMenuClientImpl.cpp:
2488 * src/EditorClientImpl.cpp:
2489 * src/InspectorFrontendClientImpl.cpp:
2490 * src/LocalFileSystemChromium.cpp:
2491 * src/SpeechInputClientImpl.cpp:
2492 * src/SpeechRecognitionClientProxy.h:
2493 * src/WebDevToolsAgentImpl.cpp:
2494 * src/WebDevToolsFrontendImpl.cpp:
2495 * src/WebDevToolsFrontendImpl.h:
2496 * src/WebEntities.h:
2497 * src/WebFrameImpl.h:
2498 * src/WorkerFileSystemCallbacksBridge.h:
2499 * tests/UniscribeHelperTest.cpp:
2501 2012-09-06 Dana Jansens <danakj@chromium.org>
2503 [chromium] Add a customized copy() method to CCRenderPassDrawQuad
2504 https://bugs.webkit.org/show_bug.cgi?id=95871
2506 Reviewed by Adrienne Walker.
2508 * tests/CCDrawQuadTest.cpp:
2512 2012-09-06 Ilya Tikhonovsky <loislo@chromium.org>
2514 Unreviewed Web Inspector: test fix.
2516 * tests/MemoryInstrumentationTest.cpp:
2517 (StringOwnerInstrumented):
2518 (WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
2519 (WebCore::StringOwnerInstrumented::reportMemoryUsage):
2523 2012-09-06 Ilya Tikhonovsky <loislo@chromium.org>
2525 Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
2526 https://bugs.webkit.org/show_bug.cgi?id=95957
2528 Reviewed by Yury Semikhatsky.
2530 Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
2531 instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
2532 At a later stage, when each memory type is counted in MemoryInstrumentation
2533 we will build the blocks hierarchy for the front-end automatically.
2535 * tests/MemoryInstrumentationTest.cpp:
2536 (WebCore::InstrumentedUndefined::InstrumentedUndefined):
2537 (WebCore::InstrumentedUndefined::reportMemoryUsage):
2538 (WebCore::InstrumentedDOM::InstrumentedDOM):
2539 (WebCore::InstrumentedDOM::reportMemoryUsage):
2543 2012-09-06 Kenichi Ishibashi <bashi@chromium.org>
2545 [Chromium] Win build fix attempt after r127715
2547 * tests/CCRenderPassTest.cpp:
2550 2012-09-06 Peter Beverloo <peter@chromium.org>
2552 Unreviewed. Rolled DEPS.
2556 2012-09-06 Dana Jansens <danakj@chromium.org>
2558 [chromium] Add a copy() method to CCRenderPass
2559 https://bugs.webkit.org/show_bug.cgi?id=95485
2561 Reviewed by Adrienne Walker.
2564 * tests/CCRenderPassTest.cpp: Added.
2566 (CCTestRenderPass::quadList):
2567 (CCTestRenderPass::sharedQuadStateList):
2571 2012-09-06 Peter Beverloo <peter@chromium.org>
2573 [Chromium] Chromium Mac build fix after revision r127711
2574 https://bugs.webkit.org/show_bug.cgi?id=95958
2576 Unreviewed build fix.
2578 This is a clear typo in the source file, so changing the function to
2579 call locationModifiersFromWindowsKeyCode instead.
2581 * src/mac/WebInputEventFactory.mm:
2582 (WebKit::WebInputEventFactory::keyboardEvent):
2584 2012-09-06 Raymes Khoury <raymes@chromium.org>
2586 Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
2587 https://bugs.webkit.org/show_bug.cgi?id=94142
2589 Reviewed by Tony Chang.
2591 Previously we distinguished between left/right Shift/Ctrl/Alt in
2592 WebInputEvents by using the location-specific virtual keycodes (e.g.
2593 VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
2594 always returns the non-locational version (e.g. VK_SHIFT).
2595 Furthermore, KeyboardEvent also returns
2596 non-locational keycodes and separates the location information which
2597 matches the behavior described in the DOM3
2598 spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
2599 should be consistent with this in our representation of key events.
2600 This patch changes WebInputEvents so they always store the
2601 non-locational keycode and location information is stored in
2602 modifiers. Since this only changes internal representation, no new
2605 This patch also ensures that when KeyboardEvents are converted back to
2606 WebInputEvents location information is preserved (which was not
2607 happening before). This is important so that key location information
2608 is passed on to plugins. A unittest is added for this.
2611 * public/WebInputEvent.h:
2613 * src/WebInputEvent.cpp:
2615 (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
2616 (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):
2617 * src/WebInputEventConversion.cpp:
2618 (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
2619 (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
2620 * src/android/WebInputEventFactory.cpp:
2621 (WebKit::WebInputEventFactory::keyboardEvent):
2622 * src/gtk/WebInputEventFactory.cpp:
2623 (WebKit::WebInputEventFactory::keyboardEvent):
2624 * src/mac/WebInputEventFactory.mm:
2625 (WebKit::WebInputEventFactory::keyboardEvent):
2626 * src/win/WebInputEventFactory.cpp:
2627 (WebKit::getLocationModifier):
2628 (WebKit::WebInputEventFactory::keyboardEvent):
2629 * tests/WebInputEventConversionTest.cpp: Added.
2631 2012-09-06 Adam Barth <abarth@webkit.org>
2633 Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
2634 https://bugs.webkit.org/show_bug.cgi?id=91110
2636 Reviewed by Tony Chang.
2638 Prior to this patch, we were ignoring the user-scalable property of
2639 viewport meta tags. This patch enforces the user-scalable property by
2640 claming the minimum-scale and maximum-scale values, effectively
2641 preventing user scaling. This approach isn't perfect, as discussed in
2642 https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
2643 over the status quo.
2645 This approach is also used by EFL, GTK, and Qt.
2647 * src/ChromeClientImpl.cpp:
2648 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
2650 2012-09-05 Dana Jansens <danakj@chromium.org>
2652 [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
2653 https://bugs.webkit.org/show_bug.cgi?id=95374
2655 Reviewed by Adrienne Walker.
2658 * tests/CCDrawQuadTest.cpp: Added.
2660 (createSharedQuadState):
2663 2012-09-05 Kenichi Ishibashi <bashi@chromium.org>
2665 [Chromium] Unreviewed gardening
2667 * tests/GraphicsLayerChromiumTest.cpp:
2668 (WebKit::TEST_F): Disabled applyScrollToScrollableArea()
2670 2012-09-05 Tony Chang <tony@chromium.org>
2672 [chromium] Remove dependency on webkit_user_agent
2673 https://bugs.webkit.org/show_bug.cgi?id=95886
2675 Reviewed by Adam Barth.
2677 The code isn't used by webkit_unit_tests.
2679 * WebKitUnitTests.gyp:
2681 2012-09-05 Nate Chapin <japhet@chromium.org>
2683 Test for https://bugs.webkit.org/show_bug.cgi?id=91685
2685 Reviewed by Adam Barth.
2687 * tests/WebFrameTest.cpp:
2689 2012-09-05 Rick Byers <rbyers@chromium.org>
2691 Use new type-specific WebGestureEvent fields
2692 https://bugs.webkit.org/show_bug.cgi?id=95573
2694 Reviewed by James Robinson.
2696 Chromium has been updated to store gesture-type specific details in the
2697 new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
2698 crrev.com/154959), so we can now rely on them.
2700 * src/WebCompositorInputHandlerImpl.cpp:
2701 Update the compositor scroll, pinch and fling handling to use these new fields.
2702 (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
2703 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
2704 * src/WebInputEventConversion.cpp:
2705 Update PlatformGestureEvent/WebGestureEvent conversion to use the new
2706 fields, storing into the existing overloaded PlatformGestureEvent
2707 fields (which will be cleaned up in my next CL).
2708 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2709 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
2710 * src/WebViewImpl.cpp:
2711 (WebKit::WebViewImpl::handleGestureEvent):
2712 Update fling scrolling implementation for correct location of velocity.
2713 * tests/WebCompositorInputHandlerImplTest.cpp:
2715 Update tests to use the new fields.
2718 2012-09-05 James Robinson <jamesr@chromium.org>
2720 [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
2721 https://bugs.webkit.org/show_bug.cgi?id=95819
2723 Reviewed by Adam Barth.
2725 This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
2726 upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
2727 webkit.dll in the component build.
2729 * tests/WebLayerTest.cpp:
2731 2012-09-05 Victoria Kirst <vrk@chromium.org>
2733 Add the duration attribute to MediaSource
2734 https://bugs.webkit.org/show_bug.cgi?id=95149
2736 Reviewed by Eric Carlson.
2738 Add support for the duration attribute recently added to the MediaSource spec.
2739 http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration
2741 * public/WebMediaPlayer.h:
2742 (WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.
2743 * src/WebMediaPlayerClientImpl.cpp:
2744 (WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
2746 * src/WebMediaPlayerClientImpl.h:
2747 (WebMediaPlayerClientImpl):
2749 2012-09-05 Mihai Parparita <mihaip@chromium.org>
2751 [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
2752 https://bugs.webkit.org/show_bug.cgi?id=95865
2754 Reviewed by Darin Fisher.
2756 Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
2759 * public/WebRuntimeFeatures.h:
2760 (WebRuntimeFeatures):
2761 * src/WebRuntimeFeatures.cpp:
2762 (WebKit::WebRuntimeFeatures::enablePushState):
2763 (WebKit::WebRuntimeFeatures::isPushStateEnabled):
2765 2012-09-05 Mark Pilgrim <pilgrim@chromium.org>
2767 [Chromium] Remove getRenderStyleForStrike from PlatformSupport
2768 https://bugs.webkit.org/show_bug.cgi?id=95363
2770 Reviewed by Adam Barth.
2772 Part of a refactoring series. See tracking bug 82948.
2774 * public/linux/WebFontInfo.h:
2775 * public/linux/WebFontRenderStyle.h:
2776 * src/PlatformSupport.cpp:
2779 2012-09-05 Ilya Tikhonovsky <loislo@chromium.org>
2781 Unreviewed: WebInspector: remove accidentally committed speed test.
2783 * tests/MemoryInstrumentationTest.cpp:
2785 2012-09-05 Sami Kyostila <skyostil@chromium.org>
2787 [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
2788 https://bugs.webkit.org/show_bug.cgi?id=95679
2790 Reviewed by James Robinson.
2792 Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
2794 * src/WebLayerImpl.cpp:
2795 (WebKit::WebLayerImpl::setMaxScrollPosition):
2797 (WebKit::WebLayerImpl::setScrollClient):
2798 (WebKit::WebLayerImpl::scrollBy):
2799 * src/WebLayerImpl.h:
2801 * tests/CCLayerTreeHostTest.cpp:
2802 * tests/GraphicsLayerChromiumTest.cpp:
2803 (MockScrollableArea):
2806 * tests/WebLayerTest.cpp:
2808 2012-09-05 Ilya Tikhonovsky <loislo@chromium.org>
2810 Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
2811 https://bugs.webkit.org/show_bug.cgi?id=95850
2813 Reviewed by Yury Semikhatsky.
2815 I'd like to extract MemoryObjectTypes into separate classes.
2816 After that we will be able to move core NMI instrumentation code to WTF.
2818 * tests/MemoryInstrumentationTest.cpp:
2819 (WebCore::Instrumented::reportMemoryUsage):
2820 (WebCore::InstrumentedRefPtr::reportMemoryUsage):
2821 (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
2822 (WebCore::InstrumentedOther::reportMemoryUsage):
2823 (WebCore::InstrumentedDOM::reportMemoryUsage):
2825 (WebCore::NonVirtualInstrumented::reportMemoryUsage):
2827 2012-09-05 Peter Beverloo <peter@chromium.org>
2829 Unreviewed, rolling out r127590.
2830 http://trac.webkit.org/changeset/127590
2832 Broke the Chromium bots because of a compile error in the compositor.
2836 2012-09-05 Peter Beverloo <peter@chromium.org>
2838 Unreviewed. Rolled DEPS.
2842 2012-09-04 Ilya Tikhonovsky <loislo@chromium.org>
2844 Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
2845 https://bugs.webkit.org/show_bug.cgi?id=95739
2847 Reviewed by Yury Semikhatsky.
2849 When we go deeper into different parts of browser like skia, chromium itself etc.
2850 we can't use a single enum for all reported object types.
2851 The current idea is to use plain simple strings as ObjectType identifiers.
2852 In the future patches we will extract these identifiers into separate class or namespace
2853 and and split it between components.
2855 * tests/MemoryInstrumentationTest.cpp:
2859 2012-09-04 Keishi Hattori <keishi@webkit.org>
2861 Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
2862 https://bugs.webkit.org/show_bug.cgi?id=95681
2864 Reviewed by Kent Tamura.
2867 * src/ChromeClientImpl.cpp:
2869 (WebKit::ChromeClientImpl::openDateTimeChooser):
2870 * src/ChromeClientImpl.h:
2873 * src/DateTimeChooserImpl.cpp: Added.
2875 (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
2876 (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
2877 (WebKit::DateTimeChooserImpl::endChooser):
2878 (WebKit::DateTimeChooserImpl::contentSize):
2879 (WebKit::DateTimeChooserImpl::writeDocument):
2880 (WebKit::DateTimeChooserImpl::setValueAndClosePopup):
2881 (WebKit::DateTimeChooserImpl::didClosePopup):
2882 * src/DateTimeChooserImpl.h:
2885 (DateTimeChooserImpl):
2887 2012-09-04 Adam Barth <abarth@chromium.org>
2889 Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
2890 https://bugs.webkit.org/show_bug.cgi?id=95798
2892 Reviewed by Eric Seidel.
2894 * src/WebAccessibilityObject.cpp:
2895 (WebKit::WebAccessibilityObject::keyboardShortcut):
2896 - Remove use of WTF::String::operator+=
2897 * src/WebPageSerializerImpl.cpp:
2898 - Whitelist use of WTF::String::operator+=. Remove this use will take
2899 some more careful thought.
2901 2012-09-04 Alec Flett <alecflett@chromium.org>
2903 IndexedDB: remove final createIndex backend glue
2904 https://bugs.webkit.org/show_bug.cgi?id=95385
2906 Reviewed by Adam Barth.
2908 Remove chromium glue for old key-generation code.
2910 * public/WebIDBKey.h:
2912 * src/WebIDBKey.cpp:
2914 2012-09-04 Tien-Ren Chen <trchen@chromium.org>
2916 [chromium] Rename WebViewClient::handleDisambiguationPopup
2917 https://bugs.webkit.org/show_bug.cgi?id=95529
2919 Reviewed by Adam Barth.
2921 Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
2923 * public/WebViewClient.h:
2924 (WebKit::WebViewClient::didTapMultipleTargets):
2925 * src/WebViewImpl.cpp:
2926 (WebKit::WebViewImpl::handleGestureEvent):
2927 * tests/WebFrameTest.cpp:
2929 2012-09-03 Tao Bai <michaelbai@chromium.org>
2931 Added ANDROID_GDBSERVER definition for Ant
2932 https://bugs.webkit.org/show_bug.cgi?id=95265
2934 Reviewed by Adam Barth.
2936 ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
2937 is only used for finding the gdbserver.
2939 * WebKitUnitTests.gyp:
2941 2012-09-03 Peter Beverloo <peter@chromium.org>
2943 Unreviewed. Rolled DEPS.
2947 2012-09-03 Tommy Widenflycht <tommyw@google.com>
2949 MediaStream API: Add Ice-related functionality to RTCPeerConnection
2950 https://bugs.webkit.org/show_bug.cgi?id=95565
2952 Reviewed by Adam Barth.
2954 * src/AssertMatchingEnums.cpp:
2956 2012-09-01 James Robinson <jamesr@chromium.org>
2958 Unreviewed chromium buildfix when use_libcc_for_compositor=1
2960 This gyp target was renamed downstream.
2964 2012-09-01 Tommy Widenflycht <tommyw@google.com>
2966 MediaStream API: Add MediaStream management to RTCPeerConnection
2967 https://bugs.webkit.org/show_bug.cgi?id=95543
2969 Reviewed by Adam Barth.
2971 * src/AssertMatchingEnums.cpp:
2973 2012-08-31 Koji Ishii <kojiishi@gmail.com>
2975 Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
2976 https://bugs.webkit.org/show_bug.cgi?id=51450
2978 Reviewed by Tony Chang.
2980 When writing-mode is vertical-*, Chromium Win does not render glyphs correctly.
2981 http://dev.w3.org/csswg/css3-writing-modes/#writing-mode
2982 Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name,
2983 and vertical alternate glyphs (OpenType 'vert' feature) is not enabled.
2984 CJK characters drawn at wrong baseline position is also fixed.
2985 In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty
2986 in Chromium Win but they were implemented because they were needed to draw vertical flow correctly.
2988 Note that this patch does not address issues in vertical flow for complex code path.
2989 The issue is under discussion with Google people and it will not be fixed in short term.
2991 Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations.
2993 * features.gypi: ENABLE_OPENTYPE_VERTICAL=1.
2995 2012-08-31 W. James MacLean <wjmaclean@chromium.org>
2997 [chromium] Make link highlighter use same node selection criteria as Chromium for Android.
2998 https://bugs.webkit.org/show_bug.cgi?id=95371
3000 Reviewed by James Robinson.
3002 This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.
3004 * src/WebViewImpl.cpp:
3005 (WebKit::highlightConditions):
3006 (WebKit::WebViewImpl::bestTouchLinkNode):
3007 * tests/data/test_touch_link_highlight.html:
3009 2012-08-31 James Robinson <jamesr@chromium.org>
3011 [chromium] Consolidate geometry unit testing functions for cc
3012 https://bugs.webkit.org/show_bug.cgi?id=95526
3014 Reviewed by Julien Chaffraix.
3016 This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
3017 testing rect equality.
3020 * tests/CCDamageTrackerTest.cpp:
3021 (WebKitTests::TEST_F):
3022 * tests/CCGeometryTestUtils.cpp: Added.
3024 (WebKitTests::ExpectTransformationMatrixEq):
3025 * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
3028 * tests/CCLayerTreeHostTest.cpp:
3029 * tests/CCMathUtilTest.cpp:
3031 * tests/TiledLayerChromiumTest.cpp:
3033 2012-08-31 James Robinson <jamesr@chromium.org>
3035 [chromium] Clean up Web*Layer initialization paths
3036 https://bugs.webkit.org/show_bug.cgi?id=95523
3038 Reviewed by Darin Fisher.
3040 Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
3041 implementation. Also normalizes naming conventions in these files.
3043 * src/WebAnimationImpl.cpp:
3044 (WebKit::WebAnimation::create):
3045 (WebKit::WebAnimationImpl::WebAnimationImpl):
3046 * src/WebAnimationImpl.h:
3048 * src/WebContentLayerImpl.cpp:
3049 (WebKit::WebContentLayerImpl::WebContentLayerImpl):
3050 (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
3051 (WebKit::WebContentLayerImpl::layer):
3052 (WebKit::WebContentLayerImpl::setDoubleSided):
3053 (WebKit::WebContentLayerImpl::setContentsScale):
3054 (WebKit::WebContentLayerImpl::setUseLCDText):
3055 (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
3056 * src/WebContentLayerImpl.h:
3057 (WebContentLayerImpl):
3058 * src/WebFloatAnimationCurveImpl.cpp:
3059 (WebKit::WebFloatAnimationCurve::create):
3060 (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
3061 * src/WebFloatAnimationCurveImpl.h:
3062 (WebFloatAnimationCurveImpl):
3063 * src/WebIOSurfaceLayerImpl.cpp:
3064 (WebKit::WebIOSurfaceLayer::create):
3065 (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
3066 * src/WebIOSurfaceLayerImpl.h:
3067 (WebIOSurfaceLayerImpl):
3068 * src/WebImageLayerImpl.cpp:
3069 (WebKit::WebImageLayer::create):
3070 (WebKit::WebImageLayerImpl::WebImageLayerImpl):
3071 * src/WebImageLayerImpl.h:
3072 (WebImageLayerImpl):
3073 * src/WebLayerImpl.cpp:
3074 (WebKit::WebLayer::create):
3076 (WebKit::WebLayerImpl::WebLayerImpl):
3077 * src/WebLayerImpl.h:
3079 * src/WebScrollbarLayerImpl.cpp:
3080 (WebKit::WebScrollbarLayer::create):
3081 (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
3082 * src/WebScrollbarLayerImpl.h:
3083 (WebScrollbarLayerImpl):
3084 * src/WebSolidColorLayerImpl.cpp:
3085 (WebKit::WebSolidColorLayer::create):
3086 (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
3087 * src/WebSolidColorLayerImpl.h:
3088 (WebSolidColorLayerImpl):
3089 * src/WebTransformAnimationCurveImpl.cpp:
3090 (WebKit::WebTransformAnimationCurve::create):
3091 (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
3092 * src/WebTransformAnimationCurveImpl.h:
3093 (WebTransformAnimationCurveImpl):
3094 * src/WebVideoLayerImpl.cpp:
3095 (WebKit::WebVideoLayer::create):
3096 (WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
3097 * src/WebVideoLayerImpl.h:
3098 (WebVideoLayerImpl):
3100 2012-08-31 Tony Chang <tony@chromium.org>
3102 Remove ENABLE_CSS3_FLEXBOX compile time flag
3103 https://bugs.webkit.org/show_bug.cgi?id=95382
3105 Reviewed by Ojan Vafai.
3107 Everyone is already enabling this by default and the spec has stablized.
3111 2012-08-31 Christopher Cameron <ccameron@chromium.org>
3113 [chromium] Add main versus impl thread asserts
3114 https://bugs.webkit.org/show_bug.cgi?id=95596
3116 Reviewed by James Robinson.
3118 Add asserts to prioritized texture manager that specify that a
3119 function be called on the main or impl thread.
3121 Add debug signs that the main thread is blocked to the threaded
3124 Add a mechanism to simultaneously set the thread to the impl thread
3125 and indicate that the main thread is blocked.
3127 Update tests that hit asserts in the prioritized texture manager to
3128 set their impl thread and main thread blocked state correctly.
3130 * tests/CCPrioritizedTextureTest.cpp:
3131 (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
3132 (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
3133 (WTF::CCPrioritizedTextureTest::validateTexture):
3135 * tests/TiledLayerChromiumTest.cpp:
3137 2012-08-30 James Robinson <jamesr@chromium.org>
3139 [chromium] Put compositor client interfaces in separate headers, normalize naming
3140 https://bugs.webkit.org/show_bug.cgi?id=95522
3142 Reviewed by Adam Barth.
3144 * src/WebContentLayerImpl.cpp:
3145 (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
3146 * src/WebContentLayerImpl.h:
3147 (WebContentLayerImpl):
3148 * src/WebExternalTextureLayerImpl.h:
3149 * src/WebLayerTreeViewImpl.h:
3151 * tests/CCLayerTreeHostCommonTest.cpp:
3152 * tests/CCLayerTreeHostTest.cpp:
3153 (WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
3154 (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
3155 (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
3156 (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
3157 (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
3158 (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
3159 (CCLayerTreeHostTestLostContextWhileUpdatingResources):
3160 * tests/ContentLayerChromiumTest.cpp:
3161 (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
3164 2012-08-31 Gavin Peters <gavinp@chromium.org>
3166 [chromium] DEPS roll with a test skip.
3167 https://bugs.webkit.org/show_bug.cgi?id=95601
3169 Unreviewed gardening & DEPS roll.
3172 fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)
3176 2012-08-31 Gavin Peters <gavinp@chromium.org>
3178 [chromium] Disable WebViewTest.AutoResizeMinimumSize
3179 https://bugs.webkit.org/show_bug.cgi?id=95571
3181 Unreviewed gardening.
3183 Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this.
3185 * tests/WebViewTest.cpp:
3187 2012-08-30 James Robinson <jamesr@chromium.org>
3189 [chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
3190 https://bugs.webkit.org/show_bug.cgi?id=95520
3192 Reviewed by Darin Fisher.
3194 Adopt the return value of WebCompositorSupport explicitly.
3196 * src/LinkHighlight.cpp:
3197 (WebKit::LinkHighlight::LinkHighlight):
3198 (WebKit::LinkHighlight::startHighlightAnimation):
3199 * src/WebMediaPlayerClientImpl.cpp:
3200 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3201 * src/WebPluginContainerImpl.cpp:
3202 (WebKit::WebPluginContainerImpl::setBackingTextureId):
3203 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3205 2012-08-30 James Robinson <jamesr@chromium.org>
3207 [chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
3208 https://bugs.webkit.org/show_bug.cgi?id=95401
3210 Reviewed by Dirk Pranke.
3212 If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere.
3216 * WebKitUnitTests.gyp:
3218 2012-08-27 James Robinson <jamesr@chromium.org>
3220 [chromium] Add CompositorSupport interface for constructing compositor classes
3221 https://bugs.webkit.org/show_bug.cgi?id=95040
3223 Reviewed by Darin Fisher.
3225 * src/LinkHighlight.cpp:
3226 (WebKit::LinkHighlight::LinkHighlight):
3227 (WebKit::LinkHighlight::startHighlightAnimation):
3228 * src/WebMediaPlayerClientImpl.cpp:
3229 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3230 * src/WebMediaPlayerClientImpl.h:
3232 * src/WebPluginContainerImpl.cpp:
3233 (WebKit::WebPluginContainerImpl::setBackingTextureId):
3234 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3235 * src/WebPluginContainerImpl.h:
3238 2012-08-30 Gavin Peters <gavinp@chromium.org>
3240 [chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
3241 https://bugs.webkit.org/show_bug.cgi?id=95472
3243 Unreviewed gardening.
3245 When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue.
3247 * tests/CCLayerTreeHostTest.cpp:
3248 (WebKitTests::TEST_F):
3250 2012-08-30 James Robinson <jamesr@chromium.org>
3252 [chromium] Clean up some webkit compositor unit tests
3253 https://bugs.webkit.org/show_bug.cgi?id=95410
3255 Reviewed by Adrienne Walker.
3257 This adds includes that were implicitly being picked up, removes ones that weren't being used, removes
3258 dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style
3259 plugin is unhappy about.
3261 * tests/CCAnimationTestCommon.cpp:
3262 (WebKitTests::FakeFloatAnimationCurve::duration):
3264 (WebKitTests::FakeFloatAnimationCurve::getValue):
3265 (WebKitTests::FakeTransformTransition::duration):
3266 (WebKitTests::FakeFloatTransition::duration):
3267 (WebKitTests::FakeLayerAnimationControllerClient::id):
3268 (WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
3269 (WebKitTests::FakeLayerAnimationControllerClient::opacity):
3270 (WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):
3271 (WebKitTests::FakeLayerAnimationControllerClient::transform):
3272 * tests/CCAnimationTestCommon.h:
3273 (FakeFloatAnimationCurve):
3274 (FakeTransformTransition):
3275 (FakeFloatTransition):
3276 (FakeLayerAnimationControllerClient):
3277 * tests/CCTiledLayerTestCommon.cpp:
3278 (WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
3280 (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
3281 (WebKitTests::FakeTiledLayerChromium::textureManager):
3282 (WebKitTests::FakeTiledLayerChromium::textureUpdater):
3283 (WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
3284 (WebKitTests::FakeTextureUploader::isBusy):
3285 (WebKitTests::FakeTextureUploader::uploadTexture):
3286 * tests/CCTiledLayerTestCommon.h:
3287 (FakeLayerTextureUpdater):
3288 (FakeTiledLayerChromium):
3289 (FakeTiledLayerWithScaledBounds):
3290 (FakeTextureUploader):
3291 * tests/FakeWebCompositorOutputSurface.h:
3292 * tests/TextureCopierTest.cpp:
3295 * tests/ThrottledTextureUploaderTest.cpp:
3297 * tests/WebLayerTreeViewTest.cpp:
3299 2012-08-29 Hironori Bono <hbono@chromium.org>
3301 Fix Chromium builds (Win and Mac)
3302 https://bugs.webkit.org/show_bug.cgi?id=95421
3304 Reviewed by James Robinson.
3306 This change replaces 'class WebRect' with 'struct WebRect' to fix build breaks
3307 on the "Chromium Mac Release" and the "Chromium Win Release" bot caused by
3310 * public/WebViewClient.h:
3313 2012-08-29 Nat Duca <nduca@chromium.org>
3315 [chromium] setNeedsAnimate should not cause commitRequested to become true
3316 https://bugs.webkit.org/show_bug.cgi?id=95393
3318 Reviewed by James Robinson.
3320 * tests/CCLayerTreeHostTest.cpp:
3321 (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
3322 (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
3324 2012-08-29 Tien-Ren Chen <trchen@chromium.org>
3326 [chromium] Implement disambiguation popup (a.k.a. Link Preview)
3327 https://bugs.webkit.org/show_bug.cgi?id=94182
3329 Reviewed by Adam Barth.
3331 In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate.
3332 The disambiguation sequence will be initiated by the gesture event handler
3333 in WebViewImpl if an ambiguous tap is detected, then
3334 m_client->handleDisambiguationPopup will be called, so the embedder can
3335 decide whether to swallow the touch event and show a popup.
3337 New test: WebFrameTest.DisambiguationPopupTest
3341 * public/WebInputEvent.h:
3343 (WebKit::WebGestureEvent::WebGestureEvent):
3344 * public/WebTouchCandidatesInfo.h: Removed.
3347 * public/WebViewClient.h:
3350 (WebKit::WebViewClient::triggersLinkPreview):
3351 * src/WebInputEvent.cpp:
3352 (SameSizeAsWebGestureEvent):
3353 * src/WebViewImpl.cpp:
3355 (WebKit::WebViewImpl::handleGestureEventWithLinkPreview):
3356 (WebKit::WebViewImpl::handleGestureEvent):
3357 * src/WebViewImpl.h:
3360 2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
3362 AX: Canvas should have a distinct role
3363 https://bugs.webkit.org/show_bug.cgi?id=95248
3365 Reviewed by Chris Fleizach.
3367 Add support for canvas accessibility role.
3369 * public/WebAccessibilityRole.h:
3370 * src/AssertMatchingEnums.cpp:
3372 2012-08-29 Alex Sakhartchouk <alexst@chromium.org>
3374 [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order
3375 https://bugs.webkit.org/show_bug.cgi?id=94828
3377 Reviewed by Adrienne Walker.
3379 Testing that setDeviceScaleFactor properly changes maxScrollPosition
3381 * tests/CCLayerTreeHostImplTest.cpp:
3383 2012-08-29 James Robinson <jamesr@chromium.org>
3385 Unreviewed, rolling out r126956.
3386 http://trac.webkit.org/changeset/126956
3387 https://bugs.webkit.org/show_bug.cgi?id=94721
3389 Breaks several unit tests
3391 * tests/CCSchedulerTest.cpp:
3392 (WebKitTests::FakeCCSchedulerClient::reset):
3393 (WebKitTests::FakeCCSchedulerClient::setHasMoreResourceUpdates):
3394 (WebKitTests::TEST):
3395 * tests/CCTextureUpdateControllerTest.cpp:
3397 2012-08-29 James Robinson <jamesr@chromium.org>
3399 [chromium] Register/unregister contents layers with GraphicsLayerChromium
3400 https://bugs.webkit.org/show_bug.cgi?id=95379
3402 Reviewed by Adrienne Walker.
3404 * src/WebMediaPlayerClientImpl.cpp:
3405 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
3406 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3407 * src/WebPluginContainerImpl.cpp:
3408 (WebKit::WebPluginContainerImpl::setBackingTextureId):
3409 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3410 (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
3412 2012-08-29 W. James MacLean <wjmaclean@chromium.org>
3414 [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.
3415 https://bugs.webkit.org/show_bug.cgi?id=95119
3417 Reviewed by Adam Barth.
3419 Add support to WebSettings for flag to enable/disable gesture tap highlights. Relies on existing tests.
3421 * public/WebSettings.h:
3422 * src/WebSettingsImpl.cpp:
3423 (WebKit::WebSettingsImpl::WebSettingsImpl):
3424 (WebKit::WebSettingsImpl::setGestureTapHighlightEnabled):
3426 * src/WebSettingsImpl.h:
3428 (WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
3429 * src/WebViewImpl.cpp:
3430 (WebKit::WebViewImpl::handleGestureEvent):
3432 2012-08-29 Dana Jansens <danakj@chromium.org>
3434 [chromium] Remove HUD layer when rootLayer is set to null
3435 https://bugs.webkit.org/show_bug.cgi?id=95257
3437 Reviewed by James Robinson.
3440 * tests/CCHeadsUpDisplayTest.cpp: Added.
3441 (CCHeadsUpDisplayTest):
3442 (DrawsContentLayerChromium):
3443 (DrawsContentLayerChromium::create):
3444 (DrawsContentLayerChromium::DrawsContentLayerChromium):
3445 (CCHudWithRootLayerChange):
3446 (CCHudWithRootLayerChange::CCHudWithRootLayerChange):
3448 * tests/CCLayerTreeHostTest.cpp:
3449 * tests/CCThreadedTest.cpp:
3450 (WebKitTests::CCThreadedTest::runTest):
3451 * tests/CCThreadedTest.h:
3452 (WebKitTests::CCThreadedTest::initializeSettings):
3455 2012-08-29 Shawn Singh <shawnsingh@chromium.org>
3457 [chromium] Add more unit test coverage for semantics of drawableContentRect and visibleContentRect
3458 https://bugs.webkit.org/show_bug.cgi?id=94542
3460 Reviewed by Adrienne Walker.
3462 To make upcoming refactors safer, it was appropriate to (finally)
3463 add unit tests that check the behavior of drawableContentRect and
3464 visibleContentRect computations in calculateDrawTransforms.
3466 * tests/CCLayerTreeHostCommonTest.cpp:
3468 2012-08-29 W. James MacLean <wjmaclean@chromium.org>
3470 [chromium] Link highlight should clear on page navigation.
3471 https://bugs.webkit.org/show_bug.cgi?id=95129
3473 Reviewed by James Robinson.
3475 Modified WebViewImpl to clear link highlight when navigating to new url.
3477 * src/WebViewImpl.cpp:
3478 (WebKit::WebViewImpl::didCommitLoad):
3480 2012-08-29 James Robinson <jamesr@chromium.org>
3482 [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
3483 https://bugs.webkit.org/show_bug.cgi?id=94995
3485 Reviewed by Adam Barth.
3489 2012-08-28 Shawn Singh <shawnsingh@chromium.org>
3491 [chromium] Do not clip root layer's subtree to viewport
3492 https://bugs.webkit.org/show_bug.cgi?id=95235
3494 Reviewed by Adrienne Walker.
3496 Existing tests updated, and otherwise this change is already
3497 covered by layout and unit tests.
3499 * tests/CCLayerTreeHostCommonTest.cpp:
3500 * tests/CCOcclusionTrackerTest.cpp:
3501 (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
3502 (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
3503 (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
3504 (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
3505 (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
3506 (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
3507 (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
3508 (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
3509 (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
3510 (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
3512 2012-08-29 Julien Chaffraix <jchaffraix@webkit.org>
3514 [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions
3515 https://bugs.webkit.org/show_bug.cgi?id=95358
3517 Unreviewed gardening.
3519 * tests/CCLayerTreeHostTest.cpp:
3520 Disabled the test until it is fixed.
3522 2012-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
3524 Unreviewed, rolling out r126972.
3525 http://trac.webkit.org/changeset/126972
3526 https://bugs.webkit.org/show_bug.cgi?id=95349
3528 accessibility/canvas-description-and-role.html has been
3529 failing consistently on several bots and Dominic needs some
3530 time to investigate why (Requested by jchaffraix on #webkit).
3532 * public/WebAccessibilityRole.h:
3533 * src/AssertMatchingEnums.cpp:
3535 2012-08-29 Peter Beverloo <peter@chromium.org>
3537 Unreviewed. Rolled DEPS.
3541 2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
3543 AX: Canvas should have a distinct role
3544 https://bugs.webkit.org/show_bug.cgi?id=95248
3546 Reviewed by Chris Fleizach.
3548 Add support for canvas accessibility role.
3550 * public/WebAccessibilityRole.h:
3551 * src/AssertMatchingEnums.cpp:
3553 2012-08-28 David Reveman <reveman@chromium.org>
3555 [Chromium] Scheduler will never process a commit until it receives a vsync tick.
3556 https://bugs.webkit.org/show_bug.cgi?id=94721
3558 Reviewed by James Robinson.
3560 * tests/CCSchedulerTest.cpp:
3561 (WebKitTests::FakeCCSchedulerClient::reset):
3562 (WebKitTests::TEST):
3563 * tests/CCTextureUpdateControllerTest.cpp:
3565 2012-08-28 Adam Barth <abarth@webkit.org>
3567 Fix ASSERT in fast/events/touch/gesture/context-menu-on-two-finger-tap.html
3569 * src/WebViewImpl.cpp:
3570 (WebKit::WebViewImpl::detectContentOnTouch):
3572 2012-08-28 Leandro Gracia Gil <leandrogracia@chromium.org>
3574 Content detection should not disrupt the page behaviour
3575 https://bugs.webkit.org/show_bug.cgi?id=94727
3577 Reviewed by Adam Barth.
3579 Triggers content detection in the embedder on tap gestures and
3580 add checks for the appropriate event listeners in order to prevent
3581 triggering content detection when it would disrupt the page's behaviour.
3583 * src/WebViewImpl.cpp:
3584 (WebKit::WebViewImpl::handleGestureEvent):
3585 (WebKit::WebViewImpl::detectContentOnTouch):
3586 * tests/WebViewTest.cpp:
3587 * tests/data/content_listeners.html: Added.
3589 2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
3591 Unreviewed, rolling out r126933.
3592 http://trac.webkit.org/changeset/126933
3593 https://bugs.webkit.org/show_bug.cgi?id=95261
3595 Turns out we do need this! (Requested by abarth on #webkit).
3597 * public/WebWidget.h:
3598 (WebKit::WebWidget::paint):
3599 * src/WebPagePopupImpl.cpp:
3600 (WebKit::WebPagePopupImpl::paint):
3601 * src/WebPagePopupImpl.h:
3603 * src/WebPopupMenuImpl.cpp:
3604 (WebKit::WebPopupMenuImpl::paint):
3605 * src/WebPopupMenuImpl.h:
3606 * src/WebViewImpl.cpp:
3607 (WebKit::WebViewImpl::paint):
3608 * src/WebViewImpl.h:
3611 2012-08-28 Mark Pilgrim <pilgrim@chromium.org>
3613 [Chromium] Remove decodeAudioFileData from PlatformSupport
3614 https://bugs.webkit.org/show_bug.cgi?id=95250
3616 Reviewed by Adam Barth.
3618 Part of a refactoring series. See tracking bug 82948.
3620 * src/PlatformSupport.cpp:
3623 2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
3625 Unreviewed, rolling out r126344.
3626 http://trac.webkit.org/changeset/126344
3627 https://bugs.webkit.org/show_bug.cgi?id=95253
3629 This change is no longer needed (Requested by abarth on
3632 * public/WebWidget.h:
3633 (WebKit::WebWidget::paint):
3634 * src/WebPagePopupImpl.cpp:
3635 (WebKit::WebPagePopupImpl::paint):
3636 * src/WebPagePopupImpl.h:
3638 * src/WebPopupMenuImpl.cpp:
3639 (WebKit::WebPopupMenuImpl::paint):
3640 * src/WebPopupMenuImpl.h:
3641 * src/WebViewImpl.cpp:
3642 (WebKit::WebViewImpl::paint):
3643 * src/WebViewImpl.h:
3646 2012-08-28 Dominic Mazzoni <dmazzoni@google.com>
3648 AX: Crash due to object getting deleted inside updateBackingStore
3649 https://bugs.webkit.org/show_bug.cgi?id=94619
3651 Reviewed by Chris Fleizach.
3653 Chromium now calls updateBackingStoreAndCheckValidity explicitly,
3654 so we can now get rid of calls to updateBackingStore in the
3655 method implementations, and just make sure we're checking isDetached.
3657 * public/WebAccessibilityObject.h:
3658 (WebAccessibilityObject):
3659 * src/WebAccessibilityObject.cpp:
3660 (WebKit::WebAccessibilityObject::axID):
3661 (WebKit::WebAccessibilityObject::accessibilityDescription):
3662 (WebKit::WebAccessibilityObject::actionVerb):
3663 (WebKit::WebAccessibilityObject::canSetFocusAttribute):
3664 (WebKit::WebAccessibilityObject::canSetValueAttribute):
3665 (WebKit::WebAccessibilityObject::childCount):
3666 (WebKit::WebAccessibilityObject::childAt):
3667 (WebKit::WebAccessibilityObject::firstChild):
3668 (WebKit::WebAccessibilityObject::focusedChild):
3669 (WebKit::WebAccessibilityObject::lastChild):
3670 (WebKit::WebAccessibilityObject::nextSibling):
3671 (WebKit::WebAccessibilityObject::parentObject):
3672 (WebKit::WebAccessibilityObject::previousSibling):
3673 (WebKit::WebAccessibilityObject::canSetSelectedAttribute):
3674 (WebKit::WebAccessibilityObject::isAnchor):
3675 (WebKit::WebAccessibilityObject::isAriaReadOnly):
3676 (WebKit::WebAccessibilityObject::isButtonStateMixed):
3677 (WebKit::WebAccessibilityObject::isChecked):
3678 (WebKit::WebAccessibilityObject::isCollapsed):
3679 (WebKit::WebAccessibilityObject::isControl):
3680 (WebKit::WebAccessibilityObject::isEnabled):
3681 (WebKit::WebAccessibilityObject::isFocused):
3682 (WebKit::WebAccessibilityObject::isHovered):
3683 (WebKit::WebAccessibilityObject::isIndeterminate):
3684 (WebKit::WebAccessibilityObject::isLinked):
3685 (WebKit::WebAccessibilityObject::isLoaded):
3686 (WebKit::WebAccessibilityObject::isMultiSelectable):
3687 (WebKit::WebAccessibilityObject::isOffScreen):
3688 (WebKit::WebAccessibilityObject::isPasswordField):
3689 (WebKit::WebAccessibilityObject::isPressed):
3690 (WebKit::WebAccessibilityObject::isReadOnly):
3691 (WebKit::WebAccessibilityObject::isRequired):
3692 (WebKit::WebAccessibilityObject::isSelected):
3693 (WebKit::WebAccessibilityObject::isSelectedOptionActive):
3694 (WebKit::WebAccessibilityObject::isVertical):
3695 (WebKit::WebAccessibilityObject::isVisible):
3696 (WebKit::WebAccessibilityObject::isVisited):
3697 (WebKit::WebAccessibilityObject::accessKey):
3698 (WebKit::WebAccessibilityObject::ariaHasPopup):
3699 (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
3700 (WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
3701 (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
3702 (WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
3703 (WebKit::WebAccessibilityObject::boundingBoxRect):
3704 (WebKit::WebAccessibilityObject::estimatedLoadingProgress):
3705 (WebKit::WebAccessibilityObject::helpText):
3706 (WebKit::WebAccessibilityObject::headingLevel):
3707 (WebKit::WebAccessibilityObject::hierarchicalLevel):
3708 (WebKit::WebAccessibilityObject::hitTest):
3709 (WebKit::WebAccessibilityObject::keyboardShortcut):
3710 (WebKit::WebAccessibilityObject::performDefaultAction):
3711 (WebKit::WebAccessibilityObject::roleValue):
3712 (WebKit::WebAccessibilityObject::selectionEnd):
3713 (WebKit::WebAccessibilityObject::selectionStart):
3714 (WebKit::WebAccessibilityObject::stringValue):
3715 (WebKit::WebAccessibilityObject::title):
3716 (WebKit::WebAccessibilityObject::titleUIElement):
3717 (WebKit::WebAccessibilityObject::url):
3718 (WebKit::WebAccessibilityObject::valueDescription):
3719 (WebKit::WebAccessibilityObject::valueForRange):
3720 (WebKit::WebAccessibilityObject::maxValueForRange):
3721 (WebKit::WebAccessibilityObject::minValueForRange):
3722 (WebKit::WebAccessibilityObject::node):
3723 (WebKit::WebAccessibilityObject::document):
3724 (WebKit::WebAccessibilityObject::accessibilityIsIgnored):
3725 (WebKit::WebAccessibilityObject::lineBreaks):
3726 (WebKit::WebAccessibilityObject::columnCount):
3727 (WebKit::WebAccessibilityObject::rowCount):
3728 (WebKit::WebAccessibilityObject::cellForColumnAndRow):
3729 (WebKit::WebAccessibilityObject::cellColumnIndex):
3730 (WebKit::WebAccessibilityObject::cellColumnSpan):
3731 (WebKit::WebAccessibilityObject::cellRowIndex):
3732 (WebKit::WebAccessibilityObject::cellRowSpan):
3733 (WebKit::WebAccessibilityObject::scrollToMakeVisible):
3734 (WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
3735 (WebKit::WebAccessibilityObject::scrollToGlobalPoint):
3737 2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
3739 Unreviewed, rolling out r126914.
3740 http://trac.webkit.org/changeset/126914
3741 https://bugs.webkit.org/show_bug.cgi?id=95239
3743 it breaks everything and fixes nothing (Requested by pizlo on
3746 * src/WebGeolocationPermissionRequestManager.cpp:
3747 (WebGeolocationPermissionRequestManager::remove):
3748 * src/WebIDBMetadata.cpp:
3749 (WebKit::WebIDBMetadata::WebIDBMetadata):
3750 * src/WebIntent.cpp:
3751 (WebKit::WebIntent::extrasValue):
3752 * tests/WebSocketExtensionDispatcherTest.cpp:
3755 2012-08-28 W. James MacLean <wjmaclean@chromium.org>
3757 [unreviewed] Compile fix: windows compiler expects float but find double.
3759 Need to specify a float literal when initialising the highlight animation duration.
3761 * src/LinkHighlight.cpp:
3762 (WebKit::LinkHighlight::startHighlightAnimation):
3764 2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
3766 Rename first/second to key/value in HashMap iterators
3767 https://bugs.webkit.org/show_bug.cgi?id=82784
3769 Reviewed by Eric Seidel.
3771 * src/WebGeolocationPermissionRequestManager.cpp:
3772 (WebGeolocationPermissionRequestManager::remove):
3773 * src/WebIDBMetadata.cpp:
3774 (WebKit::WebIDBMetadata::WebIDBMetadata):
3775 * src/WebIntent.cpp:
3776 (WebKit::WebIntent::extrasValue):
3777 * tests/WebSocketExtensionDispatcherTest.cpp:
3780 2012-08-28 W. James MacLean <wjmaclean@chromium.org>
3782 [chromium] Drastically shorten the link highlight duration.
3783 https://bugs.webkit.org/show_bug.cgi?id=95216
3785 Reviewed by James Robinson.
3787 Parameter change; covered by existing layout tests.
3789 * src/LinkHighlight.cpp:
3790 (WebKit::LinkHighlight::startHighlightAnimation):
3792 2012-08-27 Tien-Ren Chen <trchen@chromium.org>
3794 [Chromium] Remove stub for WebView::getTouchHighlightQuads()
3795 https://bugs.webkit.org/show_bug.cgi?id=95164
3797 Reviewed by Adam Barth.
3799 Reverts https://bugs.webkit.org/show_bug.cgi?id=92997
3800 We're uploading a new implementation that no longer uses this API.
3801 See https://bugs.webkit.org/show_bug.cgi?id=94182
3804 * public/WebTouchCandidatesInfo.h: Removed.
3807 * src/WebViewImpl.cpp:
3808 * src/WebViewImpl.h:
3811 2012-08-27 Ian Vollick <vollick@chromium.org>
3813 [chromium] Should accelerate rotations of >= 180 degrees
3814 https://bugs.webkit.org/show_bug.cgi?id=94860
3816 Reviewed by James Robinson.
3818 Added new unit tests:
3819 WebTransformOperationTest.transformTypesAreUnique
3820 WebTransformOperationTest.matchTypesSameLength
3821 WebTransformOperationTest.identityAlwaysMatches
3822 WebTransformOperationTest.largeRotationsWithSameAxis
3823 WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection
3824 WebTransformOperationTest.largeRotationsWithDifferentAxes
3825 WebTransformOperationTest.blendRotationFromIdentity
3826 WebTransformOperationTest.blendTranslationFromIdentity
3827 WebTransformOperationTest.blendScaleFromIdentity
3828 WebTransformOperationTest.blendSkewFromIdentity
3829 WebTransformOperationTest.blendPerspectiveFromIdentity
3830 WebTransformOperationTest.blendRotationToIdentity
3831 WebTransformOperationTest.blendTranslationToIdentity
3832 WebTransformOperationTest.blendScaleToIdentity
3833 WebTransformOperationTest.blendSkewToIdentity
3834 WebTransformOperationTest.blendPerspectiveToIdentity
3835 AnimationTranslationUtilTest.createTransformAnimationWithBigRotation
3836 AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList
3838 * tests/AnimationTranslationUtilTest.cpp:
3840 * tests/WebTransformOperationsTest.cpp:
3842 (getIdentityOperations):
3844 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
3846 Unreviewed, rolling out r126836.
3847 http://trac.webkit.org/changeset/126836
3848 https://bugs.webkit.org/show_bug.cgi?id=95163
3850 Broke all Apple ports, EFL, and Qt. (Requested by tkent on
3853 * src/WebGeolocationPermissionRequestManager.cpp:
3854 (WebGeolocationPermissionRequestManager::remove):
3855 * src/WebIDBMetadata.cpp:
3856 (WebKit::WebIDBMetadata::WebIDBMetadata):
3857 * src/WebIntent.cpp:
3858 (WebKit::WebIntent::extrasValue):
3859 * tests/WebSocketExtensionDispatcherTest.cpp:
3862 2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
3864 Rename first/second to key/value in HashMap iterators
3865 https://bugs.webkit.org/show_bug.cgi?id=82784
3867 Reviewed by Eric Seidel.
3869 * src/WebGeolocationPermissionRequestManager.cpp:
3870 (WebGeolocationPermissionRequestManager::remove):
3871 * src/WebIDBMetadata.cpp:
3872 (WebKit::WebIDBMetadata::WebIDBMetadata):
3873 * src/WebIntent.cpp:
3874 (WebKit::WebIntent::extrasValue):
3875 * tests/WebSocketExtensionDispatcherTest.cpp:
3878 2012-08-27 David Reveman <reveman@chromium.org>
3880 [Chromium] Stop texture updates when context is lost.
3881 https://bugs.webkit.org/show_bug.cgi?id=94983
3883 Reviewed by James Robinson.
3885 * tests/CCLayerTreeHostTest.cpp:
3886 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
3887 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create):
3888 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::setContextLostCallback):
3889 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::isContextLost):
3890 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::beginQueryEXT):
3891 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::endQueryEXT):
3892 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::getQueryObjectuivEXT):
3893 (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
3894 (CCLayerTreeHostTestLostContextWhileUpdatingResources):
3895 (CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
3896 (CCLayerTreeHostTestLostContextWhileUpdatingResources::createOutputSurface):
3897 (CCLayerTreeHostTestLostContextWhileUpdatingResources::beginTest):
3898 (CCLayerTreeHostTestLostContextWhileUpdatingResources::commitCompleteOnCCThread):
3899 (CCLayerTreeHostTestLostContextWhileUpdatingResources::layout):
3900 (CCLayerTreeHostTestLostContextWhileUpdatingResources::afterTest):
3903 2012-08-27 Dana Jansens <danakj@chromium.org>
3905 [chromium] A general mechanism for passing data into and out of appendQuads and quadCuller via CCAppendQuadsData
3906 https://bugs.webkit.org/show_bug.cgi?id=95109
3908 Reviewed by Adrienne Walker.
3910 Update tests to use the new data structure.
3912 * tests/CCLayerTreeHostImplTest.cpp:
3913 * tests/CCLayerTreeHostTest.cpp:
3914 * tests/CCQuadCullerTest.cpp:
3915 * tests/CCRenderSurfaceTest.cpp:
3916 * tests/CCSolidColorLayerImplTest.cpp:
3917 (CCLayerTestCommon::TEST):
3918 * tests/CCTiledLayerImplTest.cpp:
3919 (CCLayerTestCommon::TEST):
3920 (CCLayerTestCommon::getQuads):
3921 * tests/MockCCQuadCuller.h:
3923 2012-08-24 James Robinson <jamesr@chromium.org>
3925 [chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
3926 https://bugs.webkit.org/show_bug.cgi?id=94996
3928 Reviewed by Adrienne Walker.
3930 Fix up tests for API changes.
3933 * src/WebScrollbarLayerImpl.cpp:
3934 (WebKit::WebScrollbarLayer::create):
3935 * tests/ScrollbarLayerChromiumTest.cpp:
3938 2012-08-27 Adrienne Walker <enne@google.com>
3940 [chromium] Prevent scrollbar thumb size from changing during compositor zoom
3941 https://bugs.webkit.org/show_bug.cgi?id=94859
3943 Reviewed by James Robinson.
3947 * tests/CCLayerTreeHostImplTest.cpp:
3949 2012-08-27 Dana Jansens <danakj@chromium.org>
3951 [chromium] Have RenderSurface create and add its own generated RenderPass
3952 https://bugs.webkit.org/show_bug.cgi?id=94957
3954 Reviewed by Adrienne Walker.
3956 Test that a RenderSurface generates the RenderPass that we expect.
3958 * tests/CCRenderSurfaceTest.cpp:
3960 2012-08-27 Justin Novosad <junov@chromium.org>
3962 [Chromium] Fixing infinite recursion in Canvas2DLayerManager
3963 https://bugs.webkit.org/show_bug.cgi?id=95110
3965 Reviewed by Stephen White.
3967 Breaking recursion cycle by not reporting a change in memory allocation
3968 when no memory is freed in FakeCanvas2DLayer::freeMemoryIfPossible.
3970 * tests/Canvas2DLayerManagerTest.cpp:
3972 2012-08-27 Justin Novosad <junov@chromium.org>
3974 [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
3975 https://bugs.webkit.org/show_bug.cgi?id=94386
3977 Reviewed by Stephen White.
3979 Adding unit tests for WebCore::Canvas2DLayerManager
3983 2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
3985 Unreviewed. Rolled DEPS.
3989 2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
3991 Rename RegisterProtocolHandler API to NavigatorContentUtils
3992 https://bugs.webkit.org/show_bug.cgi?id=94920
3994 Reviewed by Adam Barth.
3996 Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
3997 RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl.
4000 * src/ChromeClientImpl.cpp:
4002 (WebKit::NavigatorContentUtilsClientImpl::create):
4003 (WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl):
4004 (WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler):
4005 * src/ChromeClientImpl.h:
4006 (NavigatorContentUtilsClientImpl):
4007 (WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl):
4008 * src/WebViewImpl.cpp:
4009 (WebKit::WebViewImpl::WebViewImpl):
4010 * src/WebViewImpl.h:
4012 2012-08-27 Johnny Ding <jnd@chromium.org>
4014 [Chromium-Android]Move webkit_unit_tests_apk and TestWebKitAPI_apk into a
4015 condition block:['OS=="android" and gtest_target_type == "shared_library"'].
4016 https://bugs.webkit.org/show_bug.cgi?id=95049
4018 Reviewed by Adam Barth.
4020 Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"
4024 2012-08-24 Dominic Mazzoni <dmazzoni@google.com>
4026 Chromium: WebAccessibilityObject should expose updateBackingStore
4027 https://bugs.webkit.org/show_bug.cgi?id=94611
4029 Reviewed by Chris Fleizach.
4031 This change just exposes a method, with no new tests. Next, Chromium
4032 will be modified to call this new method, and this will be followed
4033 by a change that gets rid of calls to updateBackingStore under the
4034 hood. That last change may add a test or update an existing test.
4036 * public/WebAccessibilityObject.h:
4037 (WebAccessibilityObject):
4038 * src/WebAccessibilityObject.cpp:
4039 (WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity):
4042 2012-08-24 W. James MacLean <wjmaclean@chromium.org>
4044 [chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked.
4045 https://bugs.webkit.org/show_bug.cgi?id=94978
4047 Reviewed by James Robinson.
4049 Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new
4050 highlight target is found.
4052 * src/WebViewImpl.cpp:
4053 (WebKit::WebViewImpl::enableTouchHighlight):
4055 2012-08-23 James Robinson <jamesr@chromium.org>
4057 [chromium] Convert WebLayerTreeView interface into pure virtual
4058 https://bugs.webkit.org/show_bug.cgi?id=94866
4060 Reviewed by Adrienne Walker.
4062 Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper
4063 stuff can just go away now since downstream has updated to createOutputSurface().
4066 * src/WebLayerTreeView.cpp: Removed.
4067 * src/WebLayerTreeViewImpl.cpp:
4068 (WebKit::WebLayerTreeView::create):
4069 (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
4070 (WebKit::WebLayerTreeViewImpl::initialize):
4072 (WebKit::WebLayerTreeViewImpl::setSurfaceReady):
4073 (WebKit::WebLayerTreeViewImpl::setRootLayer):
4074 (WebKit::WebLayerTreeViewImpl::clearRootLayer):
4075 (WebKit::WebLayerTreeViewImpl::compositorIdentifier):
4076 (WebKit::WebLayerTreeViewImpl::setViewportSize):
4077 (WebKit::WebLayerTreeViewImpl::layoutViewportSize):
4078 (WebKit::WebLayerTreeViewImpl::deviceViewportSize):
4079 (WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor):
4080 (WebKit::WebLayerTreeViewImpl::deviceScaleFactor):
4081 (WebKit::WebLayerTreeViewImpl::setBackgroundColor):
4082 (WebKit::WebLayerTreeViewImpl::setHasTransparentBackground):
4083 (WebKit::WebLayerTreeViewImpl::setVisible):
4084 (WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits):
4085 (WebKit::WebLayerTreeViewImpl::startPageScaleAnimation):
4086 (WebKit::WebLayerTreeViewImpl::setNeedsAnimate):
4087 (WebKit::WebLayerTreeViewImpl::setNeedsRedraw):
4088 (WebKit::WebLayerTreeViewImpl::commitRequested):
4089 (WebKit::WebLayerTreeViewImpl::composite):
4090 (WebKit::WebLayerTreeViewImpl::updateAnimations):
4091 (WebKit::WebLayerTreeViewImpl::compositeAndReadback):
4092 (WebKit::WebLayerTreeViewImpl::finishAllRendering):
4093 (WebKit::WebLayerTreeViewImpl::renderingStats):
4094 (WebKit::WebLayerTreeViewImpl::setFontAtlas):
4095 (WebKit::WebLayerTreeViewImpl::loseCompositorContext):
4096 (WebKit::WebLayerTreeViewImpl::willBeginFrame):
4097 (WebKit::WebLayerTreeViewImpl::didBeginFrame):
4098 (WebKit::WebLayerTreeViewImpl::animate):
4099 (WebKit::WebLayerTreeViewImpl::layout):
4100 (WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
4101 (WebKit::WebLayerTreeViewImpl::createOutputSurface):