[chromium] Convert screen space scroll gestures to layer space
[WebKit-https.git] / Source / WebKit / chromium / ChangeLog
1 2012-08-20  Sami Kyostila  <skyostil@chromium.org>
2
3         [chromium] Convert screen space scroll gestures to layer space
4         https://bugs.webkit.org/show_bug.cgi?id=92499
5
6         Reviewed by James Robinson.
7
8         Added new tests for verifying transformed layer scrolling:
9
10             CCLayerTreeHostImplTest.scrollAxisAlignedRotatedLayer
11             CCLayerTreeHostImplTest.scrollNonAxisAlignedRotatedLayer
12             CCLayerTreeHostImplTest.scrollScaledLayer
13
14         Also some tests for the introduced math utilities:
15
16             CCMathUtilTest.smallestAngleBetweenVectors
17             CCMathUtilTest.vectorProjection
18
19         * src/WebCompositorInputHandlerImpl.cpp:
20         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
21         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
22         * tests/CCLayerTreeHostImplTest.cpp: Adjusted scroll delta in scrollChildBeyondLimit to avoid triggering the 45 degree rule.
23         * tests/CCLayerTreeHostTest.cpp:
24         * tests/CCMathUtilTest.cpp:
25         * tests/WebCompositorInputHandlerImplTest.cpp:
26         (MockCCInputHandlerClient):
27         (WebKit::TEST_F):
28
29 2012-08-20  Pavel Feldman  <pfeldman@chromium.org>
30
31         Web Inspector: load scripts panel lazily
32         https://bugs.webkit.org/show_bug.cgi?id=94416
33
34         Reviewed by Vsevolod Vlasov.
35
36         * WebKit.gyp:
37
38 2012-08-19  Kentaro Hara  <haraken@chromium.org>
39
40         [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController
41         https://bugs.webkit.org/show_bug.cgi?id=94446
42
43         Reviewed by Adam Barth.
44
45         To kill V8Proxy, we can move contextDebugId() and setContextDebugId()
46         from V8Proxy to ScriptController.
47
48         No tests. No change in behavior.
49
50         * src/WebDevToolsAgentImpl.cpp:
51         (WebKit::WebDevToolsAgentImpl::didCreateScriptContext):
52
53 2012-08-20  Kentaro Hara  <haraken@chromium.org>
54
55         [V8] Move V8Proxy::m_extensions to ScriptController
56         https://bugs.webkit.org/show_bug.cgi?id=94444
57
58         Reviewed by Adam Barth.
59
60         To kill V8Proxy, this patch moves V8Proxy::m_extensions to ScriptController.
61
62         No tests. No change in behavior.
63
64         * src/WebScriptController.cpp:
65         (WebKit::WebScriptController::registerExtension):
66
67 2012-08-19  James Robinson  <jamesr@chromium.org>
68
69         [chromium] Put webkit compositor binding files in separate conditionally included gyp section
70         https://bugs.webkit.org/show_bug.cgi?id=94392
71
72         Reviewed by Dirk Pranke.
73
74         This allows the use_libcc_for_compositor gyp variable to control whether the webkit bindings are pulled from the
75         WebKit repository or an external target.
76
77         * WebKit.gyp:
78         * WebKit.gypi:
79
80 2012-08-19  Rick Byers  <rbyers@chromium.org>
81
82         [chromium] Add additional fields to WebGestureEvent
83         https://bugs.webkit.org/show_bug.cgi?id=94238
84
85         Reviewed by James Robinson.
86
87         Add a union to WebGestureEvent with per-event-type data, as a first
88         step to eliminating the overloaded delta fields.
89
90         * public/WebInputEvent.h:
91         (WebGestureEvent):
92         (WebKit::WebGestureEvent::WebGestureEvent):
93         * src/WebInputEvent.cpp:
94         (SameSizeAsWebGestureEvent):
95
96 2012-08-19  Pavel Feldman  <pfeldman@chromium.org>
97
98         Web Inspector: load network panel lazily
99         https://bugs.webkit.org/show_bug.cgi?id=94414
100
101         Reviewed by Vsevolod Vlasov.
102
103         * WebKit.gyp:
104
105 2012-08-18  Pavel Feldman  <pfeldman@chromium.org>
106
107         Web Inspector: make profiles panel a lazily loaded module.
108         https://bugs.webkit.org/show_bug.cgi?id=94351
109
110         Reviewed by Yury Semikhatsky.
111
112         * WebKit.gyp:
113
114 2012-08-18  Pavel Feldman  <pfeldman@chromium.org>
115
116         Web Inspector: load panels code on demand
117         https://bugs.webkit.org/show_bug.cgi?id=94326
118
119         Reviewed by Vsevolod Vlasov.
120
121         * WebKit.gyp:
122         * scripts/concatenate_js_files.py:
123         (OrderedJSFilesExtractor.handle_starttag):
124         * scripts/inline_js_imports.py:
125         (main):
126
127 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
128
129         Unreviewed, rolling out r125897.
130         http://trac.webkit.org/changeset/125897
131         https://bugs.webkit.org/show_bug.cgi?id=94326
132
133         this patch seems to have broken the inspector on the apple mac bots.
134
135         * WebKit.gyp:
136         * scripts/concatenate_js_files.py:
137         (OrderedJSFilesExtractor.handle_starttag):
138         * scripts/inline_js_imports.py:
139         (main):
140
141 2012-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>
142
143         Unreviewed, rolling out r125922.
144         http://trac.webkit.org/changeset/125922
145         https://bugs.webkit.org/show_bug.cgi?id=94389
146
147         "Causing failing/crashing tests on Mac bots" (Requested by
148         bradee-oh on #webkit).
149
150         * WebKit.gyp:
151
152 2012-08-16  James Robinson  <jamesr@chromium.org>
153
154         [chromium] Add Source/WebCore/platform/graphics/chromium/cc/ to include path and remove cc/ prefix from includes
155         https://bugs.webkit.org/show_bug.cgi?id=94279
156
157         Reviewed by Adam Barth.
158
159         * src/WebAnimationCurveCommon.cpp:
160         * src/WebAnimationImpl.cpp:
161         * src/WebCompositorInputHandlerImpl.cpp:
162         * src/WebCompositorInputHandlerImpl.h:
163         * src/WebExternalTextureLayer.cpp:
164         * src/WebFloatAnimationCurve.cpp:
165         * src/WebLayerTreeView.cpp:
166         * src/WebLayerTreeViewImpl.cpp:
167         * src/WebTransformAnimationCurve.cpp:
168         * tests/CCActiveAnimationTest.cpp:
169         * tests/CCAnimationTestCommon.cpp:
170         * tests/CCAnimationTestCommon.h:
171         * tests/CCDamageTrackerTest.cpp:
172         * tests/CCDelayBasedTimeSourceTest.cpp:
173         * tests/CCFrameRateControllerTest.cpp:
174         * tests/CCKeyframedAnimationCurveTest.cpp:
175         * tests/CCLayerAnimationControllerTest.cpp:
176         * tests/CCLayerImplTest.cpp:
177         * tests/CCLayerIteratorTest.cpp:
178         * tests/CCLayerQuadTest.cpp:
179         * tests/CCLayerSorterTest.cpp:
180         * tests/CCLayerTestCommon.cpp:
181         * tests/CCLayerTestCommon.h:
182         * tests/CCLayerTreeHostCommonTest.cpp:
183         * tests/CCLayerTreeHostImplTest.cpp:
184         * tests/CCLayerTreeHostTest.cpp:
185         * tests/CCMathUtilTest.cpp:
186         * tests/CCOcclusionTrackerTest.cpp:
187         * tests/CCOcclusionTrackerTestCommon.h:
188         * tests/CCPrioritizedTextureTest.cpp:
189         * tests/CCQuadCullerTest.cpp:
190         * tests/CCRenderSurfaceFiltersTest.cpp:
191         * tests/CCRenderSurfaceTest.cpp:
192         * tests/CCResourceProviderTest.cpp:
193         * tests/CCSchedulerStateMachineTest.cpp:
194         * tests/CCSchedulerTest.cpp:
195         * tests/CCSchedulerTestCommon.h:
196         * tests/CCScopedTextureTest.cpp:
197         * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:
198         * tests/CCSolidColorLayerImplTest.cpp:
199         * tests/CCTestCommon.h:
200         * tests/CCTextureUpdateControllerTest.cpp:
201         * tests/CCThreadTaskTest.cpp:
202         * tests/CCThreadedTest.cpp:
203         * tests/CCThreadedTest.h:
204         * tests/CCTiledLayerImplTest.cpp:
205         * tests/CCTiledLayerTestCommon.h:
206         * tests/CCTimerTest.cpp:
207         * tests/ContentLayerChromiumTest.cpp:
208         * tests/FakeCCGraphicsContext.h:
209         * tests/FakeCCLayerTreeHostClient.h:
210         * tests/FloatQuadTest.cpp:
211         * tests/GraphicsLayerChromiumTest.cpp:
212         * tests/LayerChromiumTest.cpp:
213         * tests/LayerRendererChromiumTest.cpp:
214         * tests/MockCCQuadCuller.h:
215         * tests/PlatformGestureCurveTest.cpp:
216         * tests/ScrollbarLayerChromiumTest.cpp:
217         * tests/TextureLayerChromiumTest.cpp:
218         * tests/TiledLayerChromiumTest.cpp:
219         * tests/TreeSynchronizerTest.cpp:
220         * tests/WebCompositorInputHandlerImplTest.cpp:
221         * tests/WebFloatAnimationCurveTest.cpp:
222         * tests/WebTransformAnimationCurveTest.cpp:
223
224 2012-08-17  Pavel Feldman  <pfeldman@chromium.org>
225
226         Web Inspector: make profiles panel a lazily loaded module.
227         https://bugs.webkit.org/show_bug.cgi?id=94351
228
229         Reviewed by Yury Semikhatsky.
230
231         * WebKit.gyp:
232
233 2012-08-17  Keishi Hattori  <keishi@webkit.org>
234
235         [Chromium] Turn off ENABLE_DATALIST_ELEMENT for Android
236         https://bugs.webkit.org/show_bug.cgi?id=94337
237
238         Reviewed by Kent Tamura.
239
240         We shouldn't have turned ENABLE_DATALIST_ELEMENT on for Android.
241
242         * features.gypi:
243
244 2012-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>
245
246         Unreviewed, rolling out r125892.
247         http://trac.webkit.org/changeset/125892
248         https://bugs.webkit.org/show_bug.cgi?id=94350
249
250         Broke windows build (Requested by vollick on #webkit).
251
252         * src/WebAnimationImpl.cpp:
253         (WebKit::WebAnimationImpl::cloneToCCAnimation):
254
255 2012-08-17  Peter Beverloo  <peter@chromium.org>
256
257         Unreviewed.  Rolled DEPS.
258
259         * DEPS:
260
261 2012-08-17  Pavel Feldman  <pfeldman@chromium.org>
262
263         Web Inspector: load panels code on demand
264         https://bugs.webkit.org/show_bug.cgi?id=94326
265
266         Reviewed by Vsevolod Vlasov.
267
268         * WebKit.gyp:
269         * scripts/concatenate_js_files.py:
270         (OrderedJSFilesExtractor.handle_starttag):
271         * scripts/inline_js_imports.py:
272         (main):
273
274 2012-08-17  Ian Vollick  <vollick@chromium.org>
275
276         [chromium] Add tracing for active composited animations
277         https://bugs.webkit.org/show_bug.cgi?id=84210
278
279         Reviewed by James Robinson.
280
281         This patch issues the trace events from the animations. Animations will
282         report when they start and finish on the main and impl threads (via
283         TRACE_EVENT_ASYNC*), and also issues instant trace events whenever they
284         change state.
285
286         * src/WebAnimationImpl.cpp:
287         (WebKit::WebAnimationImpl::cloneToCCAnimation):
288
289 2012-08-16  Antoine Labour  <piman@chromium.org>
290
291         [chromium] Add resource transfer functions to CCResourceProvider
292         https://bugs.webkit.org/show_bug.cgi?id=93524
293
294         Reviewed by James Robinson.
295
296         This adds methods to CCResourceProvider to be able to transport
297         resources from a child to a parent.
298
299         Added test to CCResourceProviderTest.
300
301         * tests/CCResourceProviderTest.cpp:
302         (WebKit::textureSize):
303         (WebKit):
304         (WebKit::Texture::Texture):
305         (Texture):
306         (ContextSharedData):
307         (WebKit::ContextSharedData::create):
308         (WebKit::ContextSharedData::insertSyncPoint):
309         (WebKit::ContextSharedData::genMailbox):
310         (WebKit::ContextSharedData::produceTexture):
311         (WebKit::ContextSharedData::consumeTexture):
312         (WebKit::ContextSharedData::ContextSharedData):
313         (WebKit::ResourceProviderContext::create):
314         (ResourceProviderContext):
315         (WebKit::ResourceProviderContext::insertSyncPoint):
316         (WebKit::ResourceProviderContext::waitSyncPoint):
317         (WebKit::ResourceProviderContext::genMailboxCHROMIUM):
318         (WebKit::ResourceProviderContext::produceTextureCHROMIUM):
319         (WebKit::ResourceProviderContext::consumeTextureCHROMIUM):
320         (WebKit::ResourceProviderContext::ResourceProviderContext):
321         (PendingProduceTexture):
322         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
323         (CCResourceProviderTest):
324         (WebKit::TEST_F):
325
326 2012-08-16  David Grogan  <dgrogan@chromium.org>
327
328         IndexedDB: Frontend and plumbing for integer versions
329         https://bugs.webkit.org/show_bug.cgi?id=92897
330
331         Reviewed by Tony Chang.
332
333         * src/IDBCallbacksProxy.cpp:
334         (WebKit::IDBCallbacksProxy::onBlocked):
335         (WebKit):
336         (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
337         * src/IDBCallbacksProxy.h:
338         (IDBCallbacksProxy):
339         * src/IDBDatabaseBackendProxy.cpp:
340         (WebKit::IDBDatabaseBackendProxy::setVersion):
341         * src/IDBDatabaseCallbacksProxy.cpp:
342         (WebKit::IDBDatabaseCallbacksProxy::onVersionChange):
343         (WebKit):
344         * src/IDBDatabaseCallbacksProxy.h:
345         (IDBDatabaseCallbacksProxy):
346         * src/IDBFactoryBackendProxy.cpp:
347         (WebKit::IDBFactoryBackendProxy::open):
348         * src/IDBFactoryBackendProxy.h:
349         (IDBFactoryBackendProxy):
350         * src/IDBTransactionCallbacksProxy.cpp:
351         (WebKit::IDBTransactionCallbacksProxy::onComplete):
352         * src/WebIDBCallbacksImpl.cpp:
353         (WebKit::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
354         (WebKit::WebIDBCallbacksImpl::onSuccess):
355         We don't want to create IDBDatabaseBackendProxy again if we've already
356         created it during upgradeNeeded.  This makes
357         IDBRequest::onSuccess(IDBDatabaseBackend) reuse its previous
358         IDBDatabaseBackendInterface if it has one.
359
360         (WebKit::WebIDBCallbacksImpl::onBlocked):
361         (WebKit):
362         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
363         * src/WebIDBCallbacksImpl.h:
364         (WebIDBCallbacksImpl):
365         * src/WebIDBDatabaseCallbacksImpl.cpp:
366         (WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
367         (WebKit):
368         * src/WebIDBDatabaseCallbacksImpl.h:
369         (WebIDBDatabaseCallbacksImpl):
370         * src/WebIDBDatabaseImpl.cpp:
371         (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
372         (WebKit::WebIDBDatabaseImpl::close):
373         (WebKit::WebIDBDatabaseImpl::open):
374         * src/WebIDBDatabaseImpl.h:
375         (WebIDBDatabaseImpl):
376         * src/WebIDBFactoryImpl.cpp:
377         (WebKit::WebIDBFactoryImpl::open):
378         * src/WebIDBFactoryImpl.h:
379         (WebIDBFactoryImpl):
380         * src/WebIDBTransactionCallbacksImpl.cpp:
381         (WebKit::WebIDBTransactionCallbacksImpl::onComplete):
382         * tests/IDBAbortOnCorruptTest.cpp:
383         (WebCore::TEST):
384         * tests/IDBDatabaseBackendTest.cpp:
385
386 2012-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
387
388         Unreviewed, rolling out r125838.
389         http://trac.webkit.org/changeset/125838
390         https://bugs.webkit.org/show_bug.cgi?id=94283
391
392         Breaks Mac compile due to bug 74625 (Requested by enne on
393         #webkit).
394
395         * tests/CCResourceProviderTest.cpp:
396         (WebKit::ResourceProviderContext::create):
397         (WebKit::ResourceProviderContext::textureSize):
398         (ResourceProviderContext):
399         (WebKit::ResourceProviderContext::ResourceProviderContext):
400         (WebKit::ResourceProviderContext::Texture::Texture):
401         (Texture):
402         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
403         (CCResourceProviderTest):
404         (WebKit::TEST_F):
405
406 2012-08-16  Kenneth Russell  <kbr@google.com>
407
408         Unreviewed, rolling out r125800.
409         http://trac.webkit.org/changeset/125800
410         https://bugs.webkit.org/show_bug.cgi?id=84281
411
412         Hypothesis that this change caused gpu_throughput_tests to
413         start timing out on all platforms on the Chromium GPU
414         canaries.
415
416         * tests/CCSchedulerTest.cpp:
417         (WebKitTests::TEST):
418         * tests/CCSchedulerTestCommon.h:
419         (WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
420         (FakeCCTimeSource):
421         * tests/CCTextureUpdateControllerTest.cpp:
422
423 2012-08-16  Antoine Labour  <piman@chromium.org>
424
425         [chromium] Add resource transfer functions to CCResourceProvider
426         https://bugs.webkit.org/show_bug.cgi?id=93524
427
428         Reviewed by James Robinson.
429
430         This adds methods to CCResourceProvider to be able to transport
431         resources from a child to a parent.
432
433         Added test to CCResourceProviderTest.
434
435         * tests/CCResourceProviderTest.cpp:
436         (WebKit::textureSize):
437         (WebKit):
438         (WebKit::Texture::Texture):
439         (Texture):
440         (ContextSharedData):
441         (WebKit::ContextSharedData::create):
442         (WebKit::ContextSharedData::insertSyncPoint):
443         (WebKit::ContextSharedData::genMailbox):
444         (WebKit::ContextSharedData::produceTexture):
445         (WebKit::ContextSharedData::consumeTexture):
446         (WebKit::ContextSharedData::ContextSharedData):
447         (WebKit::ResourceProviderContext::create):
448         (ResourceProviderContext):
449         (WebKit::ResourceProviderContext::insertSyncPoint):
450         (WebKit::ResourceProviderContext::waitSyncPoint):
451         (WebKit::ResourceProviderContext::genMailboxCHROMIUM):
452         (WebKit::ResourceProviderContext::produceTextureCHROMIUM):
453         (WebKit::ResourceProviderContext::consumeTextureCHROMIUM):
454         (WebKit::ResourceProviderContext::ResourceProviderContext):
455         (PendingProduceTexture):
456         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
457         (CCResourceProviderTest):
458         (WebKit::TEST_F):
459
460 2012-08-16  Alexandre Elias  <aelias@google.com>
461
462         [chromium] Replace destRect with destOffset in texture upload
463         https://bugs.webkit.org/show_bug.cgi?id=94154
464
465         Reviewed by James Robinson.
466
467         Previously, texture upload code implicitly assumed that sourceRect and
468         destRect have the same size. The behavior is undefined if they are
469         different, since they are used interchangeably and there's no support
470         for scaling from one rect to the other. This patch enforces that
471         constraint at the interface level by replacing all instances of
472         "IntRect destRect" by "IntSize destOffset".
473
474         * tests/CCResourceProviderTest.cpp:
475         (WebKit::TEST_F):
476         * tests/CCTextureUpdateControllerTest.cpp:
477         * tests/CCTiledLayerTestCommon.cpp:
478         (WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):
479         * tests/CCTiledLayerTestCommon.h:
480         (Texture):
481         (WebKitTests::FakeTextureUploader::uploadTexture):
482
483 2012-08-16  James Robinson  <jamesr@chromium.org>
484
485         [chromium] Remove unnecessary tree hierarchy inspection APIs from WebLayer
486         https://bugs.webkit.org/show_bug.cgi?id=94229
487
488         Reviewed by Adrienne Walker.
489
490         Remove dead WebLayer function implementations and tests of same.
491
492         * src/WebLayer.cpp:
493         * tests/WebLayerTest.cpp:
494
495 2012-08-16  David Reveman  <reveman@chromium.org>
496
497         [Chromium] Avoid aliasing global symbol monotonicallyIncreasingTime().
498         https://bugs.webkit.org/show_bug.cgi?id=94233
499
500         Reviewed by James Robinson.
501
502         * tests/CCDelayBasedTimeSourceTest.cpp:
503         (WebKitTests::TEST):
504         * tests/CCFrameRateControllerTest.cpp:
505         (WebKitTests::TEST):
506         * tests/CCSchedulerTestCommon.h:
507         (WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicTimeNow):
508         (WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
509         (FakeCCDelayBasedTimeSource):
510
511 2012-08-16  David Reveman  <reveman@chromium.org>
512
513         [Chromium] Schedule texture uploads based on hard-coded timer and vsync.
514         https://bugs.webkit.org/show_bug.cgi?id=84281
515
516         Reviewed by James Robinson.
517
518         * tests/CCSchedulerTest.cpp:
519         (WebKitTests::TEST):
520         * tests/CCSchedulerTestCommon.h:
521         (WebKitTests::FakeCCTimeSource::FakeCCTimeSource):
522         (WebKitTests::FakeCCTimeSource::setNextTickTime):
523         (FakeCCTimeSource):
524         * tests/CCTextureUpdateControllerTest.cpp:
525
526 2012-08-16  Dana Jansens  <danakj@chromium.org>
527
528         [chromium] Impl scrolling crashes when the renderer's initialization failed
529         https://bugs.webkit.org/show_bug.cgi?id=94232
530
531         Reviewed by James Robinson.
532
533         Also updated the finishAllRenderingAfterContextLost to properly fail
534         renderer initialization.
535
536         * tests/CCLayerTreeHostImplTest.cpp:
537
538 2012-08-16  Peter Beverloo  <peter@chromium.org>
539
540         [Chromium] Pass the --strip-binary argument to the apk test generator
541         https://bugs.webkit.org/show_bug.cgi?id=94224
542
543         Reviewed by Adam Barth.
544
545         The native test generator currently relies on the $STRIP environment
546         variable to be available, which it shouldn't do. Instead, pass it as an
547         argument to the script. The $STRIP variable is being deprecated.
548
549         * WebKitUnitTests.gyp:
550
551 2012-08-16  James Robinson  <jamesr@chromium.org>
552
553         [chromium] Remove alwaysReserveTextures code - it doesn't do anything
554         https://bugs.webkit.org/show_bug.cgi?id=94183
555
556         Reviewed by Dimitri Glazkov.
557
558         Stops attempting to find the scrollbar layers and call setAlwaysReserveTextures() on them since the call doesn't
559         do anything.
560
561         * src/NonCompositedContentHost.cpp:
562         (WebKit::NonCompositedContentHost::setViewport):
563         * src/WebLayer.cpp:
564
565 2012-08-16  Peter Beverloo  <peter@chromium.org>
566
567         Unreviewed.  Rolled DEPS.
568
569         * DEPS:
570
571 2012-08-16  Keishi Hattori  <keishi@webkit.org>
572
573         DOMWindowPagePopup needs to be installed before loading the html inside the page popup
574         https://bugs.webkit.org/show_bug.cgi?id=94193
575
576         Reviewed by Kent Tamura.
577
578         We are using window.pagePopupController.localizeNumberString while loading so we need to install DOMWindowPagePopup before loading the html.
579
580         * src/WebPagePopupImpl.cpp:
581         (WebKit::WebPagePopupImpl::initPage):
582
583 2012-08-16  Marja Hölttä  <marja@chromium.org>
584
585         WebHistoryItem: Enable reading selected file names from document state
586         https://bugs.webkit.org/show_bug.cgi?id=91231
587
588         Reviewed by Jochen Eisinger.
589
590         This change enables Chromium to set up file permissions properly when
591         the session restore feature restores a page with selected files.
592
593         * public/WebHistoryItem.h:
594         (WebHistoryItem): Added getReferencedFilePaths.
595         * src/WebHistoryItem.cpp:
596         (WebKit::WebHistoryItem::getReferencedFilePaths): Extracts selected and posted file paths from a document state.
597         (WebKit):
598
599 2012-08-15  Shawn Singh  <shawnsingh@chromium.org>
600
601         [chromium] set scissorRect per quad so that quads are correctly clipped
602         https://bugs.webkit.org/show_bug.cgi?id=94050
603
604         Reviewed by Adrienne Walker.
605
606         Updated two unit tests to reflect that we need to always scissor,
607         until we refactor so that quads do not depend on scissoring.
608
609         * tests/CCLayerTreeHostImplTest.cpp:
610
611 2012-08-16  Hironori Bono  <hbono@chromium.org>
612
613         Prevent showing suggestions when right-clicking a selection range.
614         https://bugs.webkit.org/show_bug.cgi?id=94189
615
616         Reviewed by Hajime Morita.
617
618         To emulate Safari, my r120810 changes selection when right-clicking a misspelled
619         word. Unfortunately, this change somehow uses VisibleSelection::isCaretOrRange
620         and it changes the existing selection when right-clicking a selection which
621         includes a misspelled word. This change uses VisibleSelection::isCaret to
622         prevent showing suggestions when right-clicking a selection range. (Neither does
623         Safari show suggestions when there is a selection range.)
624
625         * src/ContextMenuClientImpl.cpp:
626         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
627
628 2012-08-15  Sheriff Bot  <webkit.review.bot@gmail.com>
629
630         Unreviewed.  Rolled DEPS.
631
632         * DEPS:
633
634 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
635
636         Update manual tests and comments to refer to TestRunner instead of LayoutTestController
637         https://bugs.webkit.org/show_bug.cgi?id=94168
638
639         Reviewed by Kent Tamura.
640
641         * public/WebDevToolsAgent.h:
642         (WebDevToolsAgent):
643         * public/WebView.h:
644         (WebView):
645
646 2012-08-15  Alec Flett  <alecflett@chromium.org>
647
648         IndexedDB: generate index keys for existing data in createIndex in front end
649         https://bugs.webkit.org/show_bug.cgi?id=91125
650
651         Reviewed by Tony Chang.
652
653         Add Chromium API methods to let the renderer process tell the
654         browser process about indexing progress.
655
656         * public/WebIDBObjectStore.h:
657         (WebKit::WebIDBObjectStore::openCursor):
658         * src/IDBObjectStoreBackendProxy.cpp:
659         (WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
660         (WebKit):
661         (WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
662         (WebKit::IDBObjectStoreBackendProxy::openCursor):
663         * src/IDBObjectStoreBackendProxy.h:
664         (IDBObjectStoreBackendProxy):
665         * src/WebIDBObjectStoreImpl.cpp:
666         (WebKit::WebIDBObjectStoreImpl::setIndexKeys):
667         (WebKit):
668         (WebKit::WebIDBObjectStoreImpl::setIndexesReady):
669         (WebKit::WebIDBObjectStoreImpl::openCursor):
670         * src/WebIDBObjectStoreImpl.h:
671         (WebIDBObjectStoreImpl):
672
673 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
674
675         [css3-text] Add CSS3 Text decoration compile flag
676         https://bugs.webkit.org/show_bug.cgi?id=93863
677
678         Reviewed by Julien Chaffraix.
679
680         This patch handles the compile flag implementation, which will come disabled by
681         default, thus not exposing the CSS3 text decoration features to the web, unless
682         when explicitly enabling it with "--css3-text-decoration" build parameter.
683
684         * features.gypi:
685
686 2012-08-15  Iain Merrick  <husky@chromium.org>
687
688         Refactoring: move EventHandler::targetNode into HitTestResult
689         https://bugs.webkit.org/show_bug.cgi?id=94107
690
691         Reviewed by Dimitri Glazkov.
692
693         This static helper method in EventHandler was made public so that
694         WebFrameImpl can call it. That's untidy because EventHandler isn't
695         really involved. This patch turns it into an instance method of
696         HitTestResult (with a wrapper in MouseEventWithHitTestResult for
697         convenience).
698
699         Pure refactoring, no behavior change, no new test needed.
700
701         * src/WebFrameImpl.cpp:
702         (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
703
704 2012-08-15  David Grogan  <dgrogan@chromium.org>
705
706         IndexedDB: Add some ASSERTs
707         https://bugs.webkit.org/show_bug.cgi?id=94055
708
709         Reviewed by Ojan Vafai.
710
711         * src/IDBDatabaseBackendProxy.cpp:
712         (WebKit::IDBDatabaseBackendProxy::setVersion):
713
714 2012-08-15  Ian Vollick  <vollick@chromium.org>
715
716         [chromium] Must account for empty transformation lists when checking for big rotations.
717         https://bugs.webkit.org/show_bug.cgi?id=93975
718
719         Reviewed by James Robinson.
720
721         Adds a test to check that creating an animation with a big (> 180
722         degree) rotation, where the transform operations list in the 1st
723         keyframe is empty fails as expected.
724
725         * tests/AnimationTranslationUtilTest.cpp:
726         (WebKit::TEST):
727         (WebKit):
728
729 2012-08-15  Joshua Bell  <jsbell@chromium.org>
730
731         [chromium] IndexedDB: Delete unused WebKit API cursor accessors
732         https://bugs.webkit.org/show_bug.cgi?id=94134
733
734         Reviewed by Adam Barth.
735
736         Last bit of refactor work from http://webkit.org/b/92278 that ships the
737         cursor key/primaryKey/value to the front end via success messages, eliminating
738         the need for these accessors and the old success messages.
739
740         * public/WebIDBCallbacks.h:
741         * public/WebIDBCursor.h:
742
743 2012-08-15  Anna Cavender  <annacc@chromium.org>
744
745         Add the timestampOffset attribute to SourceBuffer.
746         https://bugs.webkit.org/show_bug.cgi?id=93303
747
748         Reviewed by Dimitri Glazkov.
749
750         On the 30 July 2012 version of the Media Source Extensions spec, a timestampOffset 
751         attribute was added to the SourceBuffer object:
752         http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#dom-timestampoffset
753
754         * public/WebMediaPlayer.h:
755         (WebKit::WebMediaPlayer::sourceSetTimestampOffset): Add the new method.
756         * src/WebMediaPlayerClientImpl.cpp:
757         (WebKit):
758         (WebKit::WebMediaPlayerClientImpl::sourceSetTimestampOffset): Forward the call.
759         * src/WebMediaPlayerClientImpl.h:
760         (WebMediaPlayerClientImpl):
761
762 2012-08-15  Peter Beverloo  <peter@chromium.org>
763
764         [Chromium] Roll WebKit Chromium DEPS to r151672
765         https://bugs.webkit.org/show_bug.cgi?id=94091
766
767         Unreviewed DEPS roll.
768
769         This also adds the new dependency on third_party/skia/gyp/, as was
770         introduced in Chromium's revision 151463.
771
772         * DEPS:
773
774 2012-08-14  Keishi Hattori  <keishi@webkit.org>
775
776         Share common code between calendar picker and color suggestion picker
777         https://bugs.webkit.org/show_bug.cgi?id=93802
778
779         Reviewed by Kent Tamura.
780
781         * src/ColorChooserUIController.cpp:
782         (WebKit::ColorChooserUIController::writeDocument):
783
784 2012-08-14  Scott Graham  <scottmg@chromium.org>
785
786         [Chromium] Fix warnings on Windows build
787         https://bugs.webkit.org/show_bug.cgi?id=93997
788
789         Reviewed by Kentaro Hara.
790
791         Fixes truncation from 'double' to 'float' warnings on Chromium Windows
792         build.
793
794         * tests/CCRenderSurfaceFiltersTest.cpp:
795         (WebKit::TEST):
796         * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp:
797         (WebCore::TEST_F):
798
799 2012-08-14  Chris Rogers  <crogers@google.com>
800
801         Implement new synchronized audio I/O render method in chromium
802         https://bugs.webkit.org/show_bug.cgi?id=93510
803
804         Reviewed by Kenneth Russell.
805
806         The chromium implementation of AudioDestination is being upgraded to
807         support synchronized audio I/O.  Other changes on the chromium-side
808         can then be tested against something that works in WebKit.
809
810         * src/AudioDestinationChromium.cpp:
811         (WebCore::AudioDestinationChromium::AudioDestinationChromium):
812         (WebCore::AudioDestinationChromium::render):
813         (WebCore):
814         (WebCore::AudioDestinationChromium::provideInput):
815         * src/AudioDestinationChromium.h:
816         (WebCore):
817         (AudioDestinationChromium):
818
819 2012-08-14  Adam Barth  <abarth@webkit.org>
820
821         Delete Frame::domWindow() and Frame::existingDOMWindow()
822         https://bugs.webkit.org/show_bug.cgi?id=93990
823
824         Reviewed by Eric Seidel.
825
826         * src/StorageAreaProxy.cpp:
827         (WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
828         (WebCore::StorageAreaProxy::dispatchSessionStorageEvent):
829         * src/WebDOMMessageEvent.cpp:
830         (WebKit::WebDOMMessageEvent::initMessageEvent):
831         * src/WebFrameImpl.cpp:
832         (WebKit::WebFrameImpl::performance):
833         (WebKit::WebFrameImpl::addMessageToConsole):
834         (WebKit::WebFrameImpl::unloadListenerCount):
835         (WebKit::WebFrameImpl::addEventListener):
836         (WebKit::WebFrameImpl::removeEventListener):
837         (WebKit::WebFrameImpl::dispatchEvent):
838         (WebKit::WebFrameImpl::dispatchMessageEventWithOriginCheck):
839         (WebKit::WebFrameImpl::deliverIntent):
840         * src/WebPagePopupImpl.cpp:
841         (WebKit::WebPagePopupImpl::initPage):
842
843 2012-08-14  Iain Merrick  <husky@chromium.org>
844
845         [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
846         https://bugs.webkit.org/show_bug.cgi?id=93108
847
848         Reviewed by Adam Barth.
849
850         Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange,
851         and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is
852         used by selectRange.
853
854         The test uses sample files that contain selected text on load. The test uses
855         WebViewImpl::selectionBounds to get the coordinates, deselects all, then
856         calls WebFrameImpl::selectRange to attempt to reselect the same text.
857
858         Four cases are tested:
859         - the basic case
860         - the case where the selected text is offscreen due to a scroll
861         - the case where the selected text is in an iframe
862         - the case where the selected text is in an editable element
863
864         * tests/WebFrameTest.cpp:
865         * tests/data/select_range_basic.html: Added.
866         * tests/data/select_range_editable.html: Added.
867         * tests/data/select_range_iframe.html: Added.
868         * tests/data/select_range_scroll.html: Added.
869
870 2012-08-14  Joshua Bell  <jsbell@chromium.org>
871
872         IndexedDB: Pass cursor continue results back in callback
873         https://bugs.webkit.org/show_bug.cgi?id=92278
874
875         Reviewed by Tony Chang.
876
877         Supply the updated cursor key/primaryKey/value in the success callback,
878         rather than forcing the callee to make three calls into the back end to
879         fetch them. Callbacks onSuccess(cursor) and onSuccessWithContinuation()
880         are given the three new payload parameters (and the latter is renamed.)
881
882         * public/WebIDBCallbacks.h:
883         (WebIDBCallbacks):
884         (WebKit::WebIDBCallbacks::onSuccess): Replace with no-op stub.
885         (WebKit::WebIDBCallbacks::onSuccessWithContinuation): Ditto.
886         * public/WebIDBCursor.h:
887         (WebIDBCursor): Methods can be removed once Chromium is cleaned up.
888         * src/IDBCallbacksProxy.cpp: Updated callbacks.
889         (WebKit::IDBCallbacksProxy::onSuccess):
890         (WebKit):
891         * src/IDBCallbacksProxy.h: Updated callbacks.
892         (IDBCallbacksProxy):
893         * src/IDBCursorBackendProxy.cpp: Remove back end accessors.
894         * src/IDBCursorBackendProxy.h:
895         (IDBCursorBackendProxy):
896         * src/WebIDBCallbacksImpl.cpp: Updated callbacks.
897         (WebKit::WebIDBCallbacksImpl::onSuccess):
898         * src/WebIDBCallbacksImpl.h: Updated callbacks.
899         (WebIDBCallbacksImpl):
900         * src/WebIDBCursorImpl.cpp: Remove back end accessors.
901         * src/WebIDBCursorImpl.h: Remove back end accessors.
902         (WebIDBCursorImpl):
903         * tests/IDBAbortOnCorruptTest.cpp: Update test stubs.
904         (WebCore::MockIDBCallbacks::onSuccess):
905         * tests/IDBDatabaseBackendTest.cpp: Ditto.
906         * tests/IDBRequestTest.cpp: Ditto.
907
908 2012-08-14  Peter Beverloo  <peter@chromium.org>
909
910         [Chromium] Remove unneeded build logic for Android
911         https://bugs.webkit.org/show_bug.cgi?id=93962
912
913         Reviewed by Dimitri Glazkov.
914
915         The Android SDK and NDK have been checked in to the Chromium tree, which
916         allows WebKit to leverage those as well. They will already be pulled in
917         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
918         environment variable, the envsetup.sh will set the project files up
919         appropriately for us.
920
921         * DEPS:
922
923 2012-08-14  Peter Beverloo  <peter@chromium.org>
924
925         Unreviewed.  Rolled DEPS.
926
927         * DEPS:
928
929 2012-08-14  Peter Beverloo  <peter@chromium.org>
930
931         [Chromium] Fix apk generation for the Android platform
932         https://bugs.webkit.org/show_bug.cgi?id=93841
933
934         Unreviewed build fix (step 2).
935
936         The path from webkit_unit_tests isn't robust enough. Use the same
937         convention as the Chromium side, i.e. walk up from the ant_build_out path.
938         One-line Android-only gyp change.
939
940         * WebKitUnitTests.gyp:
941
942 2012-08-14  Peter Beverloo  <peter@chromium.org>
943
944         [Chromium] Fix apk generation for the Android platform
945         https://bugs.webkit.org/show_bug.cgi?id=93841
946
947         Unreviewed build fix.
948
949         APK generation was broken as the configuration file assumed compilation
950         would only occur in the Chromium tree. Pass the path to Chromium's source
951         base directory as a property to ant.
952
953         * WebKitUnitTests.gyp:
954
955 2012-08-13  Tom Sepez  <tsepez@chromium.org>
956
957         [chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
958         https://bugs.webkit.org/show_bug.cgi?id=93283
959
960         Reviewed by Eric Seidel.
961
962         Change the client redirectDataToPlugin method(s) to expect the possibility of
963         a NULL argument, NULLing Chromium's refptr that needs to be NULLed.
964
965         * src/FrameLoaderClientImpl.cpp:
966         (WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
967
968 2012-08-13  Eric Penner  <epenner@google.com>
969
970         [chromium] Paint animated layers immediately to avoid animation hiccups.
971         https://bugs.webkit.org/show_bug.cgi?id=93028
972
973         Reviewed by Adrienne Walker.
974
975         Replaced one test. Test painting full animated layer.
976
977         * tests/TiledLayerChromiumTest.cpp:
978
979 2012-08-12  Shawn Singh  <shawnsingh@chromium.org>
980
981         [chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds
982         https://bugs.webkit.org/show_bug.cgi?id=93795
983
984         Reviewed by Adrienne Walker.
985
986         * tests/CCLayerTreeHostCommonTest.cpp:
987
988 2012-08-13  James Robinson  <jamesr@chromium.org>
989
990         [chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols
991         https://bugs.webkit.org/show_bug.cgi?id=93907
992
993         Reviewed by Darin Fisher.
994
995         Adds a WebAnimationImpl implementation of the WebAnimation interface.
996
997         * WebKit.gyp:
998         * src/WebAnimationImpl.cpp: Renamed from Source/WebKit/chromium/src/WebAnimation.cpp.
999         (WebKit):
1000         (WebKit::WebAnimation::create):
1001         (WebKit::WebAnimationImpl::targetProperty):
1002         (WebKit::WebAnimationImpl::iterations):
1003         (WebKit::WebAnimationImpl::setIterations):
1004         (WebKit::WebAnimationImpl::startTime):
1005         (WebKit::WebAnimationImpl::setStartTime):
1006         (WebKit::WebAnimationImpl::timeOffset):
1007         (WebKit::WebAnimationImpl::setTimeOffset):
1008         (WebKit::WebAnimationImpl::alternatesDirection):
1009         (WebKit::WebAnimationImpl::setAlternatesDirection):
1010         (WebKit::WebAnimationImpl::cloneToCCAnimation):
1011         * src/WebAnimationImpl.h: Added.
1012         (WebCore):
1013         (WebKit):
1014         (WebAnimationImpl):
1015         (WebKit::WebAnimationImpl::WebAnimationImpl):
1016         (WebKit::WebAnimationImpl::~WebAnimationImpl):
1017         * src/WebLayer.cpp:
1018         (WebKit::WebLayer::addAnimation):
1019         * tests/WebAnimationTest.cpp:
1020         (WebKit::TEST):
1021
1022 2012-08-10  James Robinson  <jamesr@chromium.org>
1023
1024         [chromium] Clean up dependencies for Canvas2DLayerBridgeTest and GraphicsLayerChromiumTest unit tests
1025         https://bugs.webkit.org/show_bug.cgi?id=93757
1026
1027         Reviewed by Adrienne Walker.
1028
1029         Breaks up some unit tests and removes unused code to avoid unit tests depending on both non-compositor WebCore
1030         logic and compositor internals. Canvas2DLayerBridgeTest had some vestigal includes and local variables that
1031         weren't being used, those are removed. GraphicsLayerChromiumTest was reaching into CC types, but could mostly
1032         use Platform API types for testing.
1033
1034         GraphicsLayerChromiumTest had some tests that were verifying that we could correctly translate WebCore
1035         animation lists into CCAnimation types - these have been moved into AnimationTranslationUtilTest.cpp, since the
1036         logic under test is in AnimationTranslationUtil. Currently these only test that we accept / reject animations as
1037         expected. They could be expanded to verify that the animation was translated faithfully, but that would require
1038         expanding the information exposed on WebAnimation.
1039
1040         * WebKit.gypi:
1041         * src/WebLayer.cpp:
1042         (WebKit::WebLayer::hasActiveAnimation):
1043         (WebKit):
1044         * tests/Canvas2DLayerBridgeTest.cpp:
1045         (Canvas2DLayerBridgeTest::fullLifecycleTest):
1046         * tests/GraphicsLayerChromiumTest.cpp:
1047         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1048         (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
1049         (GraphicsLayerChromiumTest):
1050         (WebKit::TEST_F):
1051         * tests/WebLayerTreeViewTest.cpp:
1052         * tests/WebLayerTreeViewTestCommon.h: Added.
1053         (WebKit):
1054         (MockWebLayerTreeViewClient):
1055
1056 2012-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1057
1058         Unreviewed, rolling out r125422.
1059         http://trac.webkit.org/changeset/125422
1060         https://bugs.webkit.org/show_bug.cgi?id=93902
1061
1062         Broke the Android canary build (Requested by fmalita on
1063         #webkit).
1064
1065         * WebKitUnitTests.gyp:
1066
1067 2012-08-13  Leandro Gracia Gil  <leandrogracia@chromium.org>
1068
1069         [Chromium] Fix nits in the find-in-page match rects API
1070         https://bugs.webkit.org/show_bug.cgi?id=93817
1071
1072         Reviewed by Adam Barth.
1073
1074         This patch fixes a few pending nits from 93111.
1075
1076         * src/FindInPageCoordinates.cpp: replace a pointer by a reference in an output argument.
1077         (WebKit::toNormalizedRect):
1078         (WebKit::findInPageRectFromAbsoluteRect):
1079
1080 2012-08-13  Peter Beverloo  <peter@chromium.org>
1081
1082         [Chromium] Fix apk generation for the Android platform
1083         https://bugs.webkit.org/show_bug.cgi?id=93841
1084
1085         Reviewed by Dimitri Glazkov.
1086
1087         APK generation was broken as the configuration file assumed compilation
1088         would only occur in the Chromium tree. Pass the path to Chromium's source
1089         base directory as a property to ant.
1090
1091         * WebKitUnitTests.gyp:
1092
1093 2012-08-13  Peter Beverloo  <peter@chromium.org>
1094
1095         Unreviewed.  Rolled DEPS.
1096
1097         * DEPS:
1098
1099 2012-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1100
1101         Unreviewed.  Rolled DEPS.
1102
1103         * DEPS:
1104
1105 2012-08-13  Peter Beverloo  <peter@chromium.org>
1106
1107         Unreviewed.  Rolled DEPS.
1108
1109         * DEPS:
1110
1111 2012-08-10  Kinuko Yasuda  <kinuko@chromium.org>
1112
1113         Support creating File object from FileSystem URL for files in FileSystem API
1114         https://bugs.webkit.org/show_bug.cgi?id=93706
1115
1116         Reviewed by Darin Fisher.
1117
1118         * src/WebBlobData.cpp:
1119         (WebKit::WebBlobData::itemAt):
1120
1121 2012-08-12  Yuta Kitamura  <yutak@google.com>
1122
1123         Unreviewed. Fix Chromium's Android build.
1124
1125         * src/WebFrameImpl.cpp:
1126         (WebKit::WebFrameImpl::find): Needs parentheses for a function call.
1127
1128 2012-08-12  Leandro Gracia Gil  <leandrogracia@chromium.org>
1129
1130         [Chromium] Implement the find-in-page match rects API
1131         https://bugs.webkit.org/show_bug.cgi?id=93111
1132
1133         Reviewed by Adam Barth.
1134
1135         Implement the funcionality of the find-in-page match rects API in WebFrame.
1136         These methods keep a cache of the match rects in a special coordinate system
1137         (find-in-page coordinates) and update them on size changes. They also allow
1138         to recover the match closest to a given point, therefore enabling to move
1139         to find matches when tapping on their corresponding tickmarks.
1140
1141         * WebKit.gyp: add FindInPageCoordinates.h / cpp.
1142         * src/ChromeClientImpl.cpp:
1143         (WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl.
1144         * src/FindInPageCoordinates.cpp: Added.
1145         (WebKit):
1146         (WebKit::toNormalizedRect): auxiliary internal function.
1147         (WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function.
1148         (WebKit::findInPageRectFromRange): convenience conversion function for Ranges.
1149         * src/FindInPageCoordinates.h: Added.
1150         (WebCore):
1151         (WebKit):
1152         * src/WebFrameImpl.cpp:
1153         (WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor.
1154         (WebKit):
1155         (WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port.
1156         (WebKit::WebFrameImpl::stopFinding): clear matches cache.
1157         (WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache.
1158         (WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version.
1159         (WebKit::WebFrameImpl::resetMatchCount): update the matches cache version.
1160         (WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version.
1161         (WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache.
1162         (WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree.
1163         (WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required.
1164         (WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates.
1165         (WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates.
1166         (WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames.
1167         (WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates.
1168         (WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame.
1169         (WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache.
1170         (WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables.
1171         (WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes.
1172         * src/WebFrameImpl.h:
1173         (WebCore):
1174         (WebFrameImpl):
1175         (WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const.
1176         (WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing.
1177         (FindMatch): cache structure for find matches.
1178         * tests/WebFrameTest.cpp: new test case for find-in-page match rects.
1179         * tests/data/find_in_page.html: Added. Test case layout.
1180         * tests/data/find_in_page_frame.html: Added. Test case layout.
1181
1182 2012-08-09  James Robinson  <jamesr@chromium.org>
1183
1184         [chromium] Remove forwarding headers for compositor-related WebKit API and update includes
1185         https://bugs.webkit.org/show_bug.cgi?id=93669
1186
1187         Reviewed by Adam Barth.
1188
1189         This updates all includes for compositor-related headers to refer consistently to the Platform API location and
1190         removes the now-unneeded forwarding headers in the client API location. I also updated and resorted other
1191         platform API includes in modified header blocks.
1192
1193         * WebKit.gyp:
1194         * public/WebCompositor.h: Removed.
1195         * public/platform/WebContentLayer.h: Removed.
1196         * public/platform/WebContentLayerClient.h: Removed.
1197         * public/platform/WebExternalTextureLayer.h: Removed.
1198         * public/platform/WebLayer.h: Removed.
1199         * public/platform/WebLayerTreeView.h: Removed.
1200         * public/platform/WebLayerTreeViewClient.h: Removed.
1201         * public/platform/WebSolidColorLayer.h: Removed.
1202         * src/WebCompositorInputHandlerImpl.h:
1203         * src/WebContentLayerImpl.cpp:
1204         * src/WebLayer.cpp:
1205         * src/WebLayerTreeView.cpp:
1206         * src/WebLayerTreeViewImpl.cpp:
1207         * src/WebLayerTreeViewImpl.h:
1208         * src/WebSolidColorLayer.cpp:
1209         * src/WebViewImpl.h:
1210         * tests/Canvas2DLayerBridgeTest.cpp:
1211         * tests/GraphicsLayerChromiumTest.cpp:
1212         * tests/TextureLayerChromiumTest.cpp:
1213
1214 2012-08-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1215
1216         Unreviewed.  Rolled DEPS.
1217
1218         * DEPS:
1219
1220 2012-08-10  Iain Merrick  <husky@google.com>
1221
1222         [chromium] Upstream Android changes to WebFrameImpl::selectRange
1223         https://bugs.webkit.org/show_bug.cgi?id=92513
1224
1225         Reviewed by Ryosuke Niwa.
1226
1227         This change is driven by the Chromium port on the Android platform,
1228         but it should be suitable for other touch-based platforms. We reuse
1229         selectionExtentRespectingEditingBoundary (extracted from EventHandler
1230         into VisibleSelection).
1231
1232         * src/WebFrameImpl.cpp:
1233         (WebKit::WebFrameImpl::selectRange):
1234         (WebKit::WebFrameImpl::visiblePositionForWindowPoint):
1235
1236 2012-08-10  Dana Jansens  <danakj@chromium.org>
1237
1238         [chromium] Remove targetSurface pointer from CCRenderPass
1239         https://bugs.webkit.org/show_bug.cgi?id=93734
1240
1241         Reviewed by Adrienne Walker.
1242
1243         Use the RenderPass's damageRect instead of the surface's damageRect
1244         directly to test the same things without requiring a pointer to
1245         the surface that generated the RenderPass.
1246
1247         * tests/CCLayerTreeHostImplTest.cpp:
1248
1249 2012-08-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1250
1251         Unreviewed, rolling out r125310.
1252         http://trac.webkit.org/changeset/125310
1253         https://bugs.webkit.org/show_bug.cgi?id=93739
1254
1255         The DEPS roll broke Android. One does not simply break
1256         Android. (Requested by fmalita_ on #webkit).
1257
1258         * DEPS:
1259
1260 2012-08-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1261
1262         Unreviewed.  Rolled DEPS.
1263
1264         * DEPS:
1265
1266 2012-08-10  Dana Jansens  <danakj@chromium.org>
1267
1268         [chromium] Remove scissor from the namings in CCOcclusionTracker
1269         https://bugs.webkit.org/show_bug.cgi?id=93630
1270
1271         Reviewed by Adrienne Walker.
1272
1273         * tests/CCOcclusionTrackerTest.cpp:
1274         (WebKitTests::TestCCOcclusionTrackerWithClip::TestCCOcclusionTrackerWithClip):
1275         (WebKitTests::TestCCOcclusionTrackerWithClip::setLayerClipRect):
1276         (WebKitTests::TestCCOcclusionTrackerWithClip::useDefaultLayerClipRect):
1277         (WebKitTests::TestCCOcclusionTrackerWithClip::layerClipRectInTarget):
1278         (TestCCOcclusionTrackerWithClip):
1279         (WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
1280         (WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
1281         (WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
1282         (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
1283         (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
1284         (WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
1285         (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
1286         (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
1287         (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
1288         (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
1289         (WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
1290         (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
1291         (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
1292         (WebKitTests::CCOcclusionTrackerTestLayerClipRectOutsideChild::runMyTest):
1293         (WebKitTests):
1294         (WebKitTests::CCOcclusionTrackerTestViewportRectOutsideChild::runMyTest):
1295         (WebKitTests::CCOcclusionTrackerTestLayerClipRectOverChild::runMyTest):
1296         (WebKitTests::CCOcclusionTrackerTestViewportRectOverChild::runMyTest):
1297         (WebKitTests::CCOcclusionTrackerTestLayerClipRectPartlyOverChild::runMyTest):
1298         (WebKitTests::CCOcclusionTrackerTestViewportRectPartlyOverChild::runMyTest):
1299         (WebKitTests::CCOcclusionTrackerTestLayerClipRectOverNothing::runMyTest):
1300         (WebKitTests::CCOcclusionTrackerTestViewportRectOverNothing::runMyTest):
1301         (WebKitTests::CCOcclusionTrackerTestLayerClipRectForLayerOffOrigin::runMyTest):
1302         (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
1303         (WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
1304         (WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
1305         (WebKitTests::CCOcclusionTrackerTestUnsorted3dLayers::runMyTest):
1306         (WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
1307         (WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
1308         (WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
1309         (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
1310         (WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
1311         (WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
1312         (WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
1313         (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
1314         (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
1315         (WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
1316         (WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
1317         (WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
1318         (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
1319         (WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToViewport::runMyTest):
1320         (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
1321         (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
1322         (WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
1323         (WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilterWithClip::runMyTest):
1324         (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
1325         (WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
1326         (WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):
1327         (WebKitTests::CCOcclusionTrackerTestMinimumTrackingSize::runMyTest):
1328         * tests/TiledLayerChromiumTest.cpp:
1329
1330 2012-08-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1331
1332         Unreviewed, rolling out r125230 and r125238.
1333         http://trac.webkit.org/changeset/125230
1334         http://trac.webkit.org/changeset/125238
1335         https://bugs.webkit.org/show_bug.cgi?id=93698
1336
1337         Broke ChromiumOS browser tests. (Requested by yutak on
1338         #webkit).
1339
1340         * tests/TiledLayerChromiumTest.cpp:
1341
1342 2012-08-09  Eric Penner  <epenner@google.com>
1343
1344         [chromium] Paint animated layers immediately to avoid animation hiccups.
1345         https://bugs.webkit.org/show_bug.cgi?id=93028
1346
1347         Reviewed by Adrienne Walker.
1348
1349         Replaced one test. Test painting full animated layer.
1350
1351         * tests/TiledLayerChromiumTest.cpp:
1352
1353 2012-08-09  Nat Duca  <nduca@chromium.org>
1354
1355         [chromium] Remove missing files from WebKit.gyp introduced by r125219
1356         https://bugs.webkit.org/show_bug.cgi?id=93671
1357
1358         Unreviewed. Fixing windows build.
1359
1360         * WebKit.gyp:
1361
1362 2012-08-09  Alec Flett  <alecflett@chromium.org>
1363
1364         IndexedDB: add AssertMatchingEnums for Direction and TaskType
1365         https://bugs.webkit.org/show_bug.cgi?id=93618
1366
1367         Reviewed by Tony Chang.
1368
1369         These chromium enums were introduced in a separate patch.
1370
1371         * src/AssertMatchingEnums.cpp:
1372
1373 2012-08-06  Nat Duca  <nduca@chromium.org>
1374
1375         [chromium] Expose CCGraphicsContext as WebCompositorOutputSurface
1376         https://bugs.webkit.org/show_bug.cgi?id=92890
1377
1378         Reviewed by James Robinson.
1379
1380         * WebKit.gyp:
1381         * WebKit.gypi:
1382         * public/WebSettings.h:
1383         * public/WebViewClient.h:
1384         (WebKit):
1385         (WebViewClient):
1386         (WebKit::WebViewClient::createOutputSurface):
1387         * src/WebLayerTreeView.cpp:
1388         (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
1389         * src/WebLayerTreeViewImpl.cpp:
1390         (WebKit):
1391         (WebGraphicsContextToOutputSurfaceAdapter):
1392         (WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter):
1393         (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
1394         * src/WebSettingsImpl.cpp:
1395         (WebKit::WebSettingsImpl::WebSettingsImpl):
1396         * src/WebSettingsImpl.h:
1397         (WebSettingsImpl):
1398         * src/WebViewImpl.cpp:
1399         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1400         (WebKit::WebViewImpl::createOutputSurface):
1401         (WebKit):
1402         (WebKit::WebViewImpl::didRebindGraphicsContext):
1403         (WebKit::WebViewImpl::didRecreateOutputSurface):
1404         * src/WebViewImpl.h:
1405         (WebViewImpl):
1406         * tests/CCLayerTreeHostImplTest.cpp:
1407         * tests/CCLayerTreeHostTest.cpp:
1408         (WTF):
1409         (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface):
1410         (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface):
1411         * tests/CCResourceProviderTest.cpp:
1412         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
1413         * tests/CCTextureUpdateControllerTest.cpp:
1414         * tests/CCThreadedTest.cpp:
1415         (WebKitTests::TestHooks::createOutputSurface):
1416         * tests/CCThreadedTest.h:
1417         (WebKitTests::TestHooks::didRecreateOutputSurface):
1418         * tests/Canvas2DLayerBridgeTest.cpp:
1419         (Canvas2DLayerBridgeTest::fullLifecycleTest):
1420         * tests/FakeCCGraphicsContext.h:
1421         (WebKit::createFakeCCGraphicsContext):
1422         * tests/FakeCCLayerTreeHostClient.h:
1423         * tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h.
1424         (WebKit):
1425         (FakeWebCompositorOutputSurface):
1426         (WebKit::FakeWebCompositorOutputSurface::create):
1427         (WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface):
1428         * tests/LayerRendererChromiumTest.cpp:
1429         (LayerRendererChromiumTest::LayerRendererChromiumTest):
1430         (TEST):
1431         * tests/WebLayerTest.cpp:
1432         * tests/WebLayerTreeViewTest.cpp:
1433
1434 2012-08-09  Nat Duca  <nduca@chromium.org>
1435
1436         Unreviewed, rolling out r125212.
1437         http://trac.webkit.org/changeset/125212
1438         https://bugs.webkit.org/show_bug.cgi?id=92890
1439
1440         Compile failure on mac dbg builder
1441
1442         * WebKit.gyp:
1443         * WebKit.gypi:
1444         * public/WebSettings.h:
1445         * public/WebViewClient.h:
1446         (WebKit):
1447         (WebViewClient):
1448         * src/WebLayerTreeView.cpp:
1449         (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
1450         * src/WebLayerTreeViewImpl.cpp:
1451         (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
1452         * src/WebSettingsImpl.cpp:
1453         (WebKit::WebSettingsImpl::WebSettingsImpl):
1454         (WebKit::WebSettingsImpl::setForceSoftwareCompositing):
1455         (WebKit):
1456         * src/WebSettingsImpl.h:
1457         (WebKit::WebSettingsImpl::forceSoftwareCompositing):
1458         (WebSettingsImpl):
1459         * src/WebViewImpl.cpp:
1460         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1461         (WebKit::WebViewImpl::createCompositorGraphicsContext3D):
1462         (WebKit::WebViewImpl::createContext3D):
1463         (WebKit::WebViewImpl::didRebindGraphicsContext):
1464         * src/WebViewImpl.h:
1465         (WebViewImpl):
1466         * tests/CCLayerTreeHostImplTest.cpp:
1467         * tests/CCLayerTreeHostTest.cpp:
1468         (WTF):
1469         (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateContext):
1470         (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateContext):
1471         * tests/CCResourceProviderTest.cpp:
1472         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
1473         * tests/CCTextureUpdateControllerTest.cpp:
1474         * tests/CCThreadedTest.cpp:
1475         (WebKitTests::TestHooks::createContext):
1476         * tests/CCThreadedTest.h:
1477         (WebKitTests::TestHooks::didRecreateContext):
1478         * tests/Canvas2DLayerBridgeTest.cpp:
1479         (Canvas2DLayerBridgeTest::fullLifecycleTest):
1480         * tests/FakeCCGraphicsContext.h:
1481         (WebKit::createFakeCCGraphicsContext):
1482         * tests/FakeCCLayerTreeHostClient.h:
1483         * tests/FakeWebCompositorOutputSurface.h: Removed.
1484         * tests/LayerRendererChromiumTest.cpp:
1485         (LayerRendererChromiumTest::LayerRendererChromiumTest):
1486         (TEST):
1487         * tests/WebLayerTest.cpp:
1488         * tests/WebLayerTreeViewTest.cpp:
1489
1490 2012-08-09  Kentaro Hara  <haraken@chromium.org>
1491
1492         [V8] Rename V8BindingPerIsolateData to V8PerIsolateData
1493         https://bugs.webkit.org/show_bug.cgi?id=93592
1494
1495         Reviewed by Adam Barth.
1496
1497         For a better name. See discussion in bug 93333.
1498
1499         No tests. No change in behavior.
1500
1501         * src/WebKit.cpp:
1502         (WebKit::initialize):
1503
1504 2012-08-06  Nat Duca  <nduca@chromium.org>
1505
1506         [chromium] Expose CCGraphicsContext as WebCompositorOutputSurface
1507         https://bugs.webkit.org/show_bug.cgi?id=92890
1508
1509         Reviewed by James Robinson.
1510
1511         * WebKit.gyp:
1512         * WebKit.gypi:
1513         * public/WebSettings.h:
1514         * public/WebViewClient.h:
1515         (WebKit):
1516         (WebViewClient):
1517         (WebKit::WebViewClient::createOutputSurface):
1518         * src/WebLayerTreeView.cpp:
1519         (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
1520         * src/WebLayerTreeViewImpl.cpp:
1521         (WebKit):
1522         (WebGraphicsContextToOutputSurfaceAdapter):
1523         (WebKit::WebGraphicsContextToOutputSurfaceAdapter::WebGraphicsContextToOutputSurfaceAdapter):
1524         (WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
1525         * src/WebSettingsImpl.cpp:
1526         (WebKit::WebSettingsImpl::WebSettingsImpl):
1527         * src/WebSettingsImpl.h:
1528         (WebSettingsImpl):
1529         * src/WebViewImpl.cpp:
1530         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1531         (WebKit::WebViewImpl::createOutputSurface):
1532         (WebKit):
1533         (WebKit::WebViewImpl::didRebindGraphicsContext):
1534         (WebKit::WebViewImpl::didRecreateOutputSurface):
1535         * src/WebViewImpl.h:
1536         (WebViewImpl):
1537         * tests/CCLayerTreeHostImplTest.cpp:
1538         * tests/CCLayerTreeHostTest.cpp:
1539         (WTF):
1540         (WTF::CCLayerTreeHostTestSetSingleLostContext::didRecreateOutputSurface):
1541         (WTF::CCLayerTreeHostTestSetRepeatedLostContext::didRecreateOutputSurface):
1542         * tests/CCResourceProviderTest.cpp:
1543         (WebKit::CCResourceProviderTest::CCResourceProviderTest):
1544         * tests/CCTextureUpdateControllerTest.cpp:
1545         * tests/CCThreadedTest.cpp:
1546         (WebKitTests::TestHooks::createOutputSurface):
1547         * tests/CCThreadedTest.h:
1548         (WebKitTests::TestHooks::didRecreateOutputSurface):
1549         * tests/Canvas2DLayerBridgeTest.cpp:
1550         (Canvas2DLayerBridgeTest::fullLifecycleTest):
1551         * tests/FakeCCGraphicsContext.h:
1552         (WebKit::createFakeCCGraphicsContext):
1553         * tests/FakeCCLayerTreeHostClient.h:
1554         * tests/FakeWebCompositorOutputSurface.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCGraphicsContext.h.
1555         (WebKit):
1556         (FakeWebCompositorOutputSurface):
1557         (WebKit::FakeWebCompositorOutputSurface::create):
1558         (WebKit::FakeWebCompositorOutputSurface::FakeWebCompositorOutputSurface):
1559         * tests/LayerRendererChromiumTest.cpp:
1560         (LayerRendererChromiumTest::LayerRendererChromiumTest):
1561         (TEST):
1562         * tests/WebLayerTest.cpp:
1563         * tests/WebLayerTreeViewTest.cpp:
1564
1565 2012-08-09  Alec Flett  <alecflett@chromium.org>
1566
1567         IndexedDB: additional chromium signature for openCursor
1568         https://bugs.webkit.org/show_bug.cgi?id=93637
1569
1570         Reviewed by Adam Barth.
1571
1572         Stub out the TaskType-based openCursor in the chromium API.
1573
1574         * src/WebIDBObjectStoreImpl.cpp:
1575         (WebKit::WebIDBObjectStoreImpl::openCursor):
1576         * src/WebIDBObjectStoreImpl.h:
1577         (WebKit::WebIDBObjectStoreImpl::openCursor):
1578         (WebIDBObjectStoreImpl):
1579
1580 2012-08-09  Dana Jansens  <danakj@chromium.org>
1581
1582         [chromium] Do partial-swap scissoring on quads during draw instead of on layers
1583         https://bugs.webkit.org/show_bug.cgi?id=91800
1584
1585         Reviewed by Adrienne Walker.
1586
1587         * tests/CCDamageTrackerTest.cpp:
1588         (WebKitTests::executeCalculateDrawTransformsAndVisibility):
1589         * tests/CCLayerIteratorTest.cpp:
1590         * tests/CCLayerTreeHostCommonTest.cpp:
1591         Removed tests of the scissor rect here, as they are no longer
1592         computed within CCLayerTreeHostCommon. Verify that the scissor
1593         does not affect texture caching in CCLayerTreeHostImplTest now.
1594         Previous scissor would affect the texture cache decisions, but
1595         this was incorrect, as damaged areas are always inside the
1596         scissor rect, and anything outside the scissor rect should
1597         be considered as valid and complete (assuming no external
1598         occlusion, which is computed outside the scissor rect now also).
1599
1600         * tests/CCLayerTreeHostImplTest.cpp:
1601         Removed didDrawNotCalledOnScissoredLayer test, as this no longer
1602         applies. didDraw will be called on layers that are outside the
1603         partial swap rect, regardless.
1604
1605         Removed partialSwapNoUpdate test, and merged its functionality into
1606         the partialSwap test while updating its expectations.
1607
1608         Added textureCachingWithScissor, which is loosely based on the
1609         CCLayerTreeHostCommonTest.scissorRectWithClip test.
1610
1611         * tests/CCOcclusionTrackerTest.cpp:
1612         (WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
1613         (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
1614         (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
1615         * tests/CCQuadCullerTest.cpp:
1616         * tests/CCRenderSurfaceTest.cpp:
1617         * tests/CCSolidColorLayerImplTest.cpp:
1618         (CCLayerTestCommon::TEST):
1619         * tests/CCTiledLayerImplTest.cpp:
1620         (CCLayerTestCommon::createLayer):
1621         * tests/LayerRendererChromiumTest.cpp:
1622         (LayerRendererChromiumTest::swapBuffers):
1623         (TEST_F):
1624         (TEST):
1625         * tests/TiledLayerChromiumTest.cpp:
1626
1627 2012-08-09  Shawn Singh  <shawnsingh@chromium.org>
1628
1629         [chromium] Pass mask scale and offset to shaders for correct masking
1630         https://bugs.webkit.org/show_bug.cgi?id=93558
1631
1632         Reviewed by Adrienne Walker.
1633
1634         Updated one unit test that needed additional args in a
1635         constructor, but no change in behavior of the test.
1636
1637         * tests/CCLayerTreeHostImplTest.cpp:
1638
1639 2012-08-09  Pavel Feldman  <pfeldman@chromium.org>
1640
1641         Web Inspector: add codemirror library as an experiment
1642         https://bugs.webkit.org/show_bug.cgi?id=93620
1643
1644         Reviewed by Vsevolod Vlasov.
1645
1646         * WebKit.gyp:
1647
1648 2012-08-09  Peter Beverloo  <peter@chromium.org>
1649
1650         Unreviewed, rolling out r125171.
1651         http://trac.webkit.org/changeset/125171
1652
1653         Broke the Chromium Android build.
1654
1655         * DEPS:
1656
1657 2012-08-09  Peter Beverloo  <peter@chromium.org>
1658
1659         Unreviewed.  Rolled DEPS.
1660
1661         * DEPS:
1662
1663 2012-08-09  Keishi Hattori  <keishi@webkit.org>
1664
1665         Page popups can show up at wrong locations
1666         https://bugs.webkit.org/show_bug.cgi?id=93556
1667
1668         Reviewed by Kent Tamura.
1669
1670         We were showing the popup at wrong positions. When there isn't enough
1671         room below and above the element it adjusts the position but we weren't
1672         resetting the adjustment when we resize the popup. This patch will make
1673         the popup adjust the popup position each time we resize.
1674
1675         * src/ColorChooserUIController.cpp:
1676         (WebKit::ColorChooserUIController::contentSize):
1677         * src/WebPagePopupImpl.cpp:
1678         (WevKit::PagePopupChromeClient::setWindowRect):
1679         (WebKit::WebPagePopupImpl::init): Use reposition().
1680         (WebKit::WebPagePopupImpl::reposition): Repositions the page popup based on the popup size.
1681         (WebKit):
1682         (WebKit::WebPagePopupImpl::resize): Use reposition().
1683         * src/WebPagePopupImpl.h:
1684         (WebPagePopupImpl):
1685
1686 2012-08-09  Peter Beverloo  <peter@chromium.org>
1687
1688         [Chromium] Pull in the android_tools directory for Android
1689         https://bugs.webkit.org/show_bug.cgi?id=84843
1690
1691         Reviewed by Jochen Eisinger.
1692
1693         Pull in the android_tools directory for Chromium Android checkouts. This
1694         repository, living in Chromium's, contains checked in versions of the
1695         Android NDK and SDK meant to make builds and updates easier.
1696
1697         * DEPS:
1698
1699 2012-08-08  Shane Stephens  <shanestephens@google.com>
1700
1701         Compile flag for CSS Hierarchies
1702         https://bugs.webkit.org/show_bug.cgi?id=92433
1703
1704         Reviewed by Tony Chang.
1705
1706         * features.gypi:
1707
1708 2012-08-08  Kent Tamura  <tkent@chromium.org>
1709
1710         [Chromium-mac] Switch to LocalizedNumberMac from LocalizedNumberICU
1711         https://bugs.webkit.org/show_bug.cgi?id=93432
1712
1713         Reviewed by Hajime Morita.
1714
1715         * tests/LocaleMacTest.cpp:
1716         Add some tests for number localization. They are similar to tests in
1717         LocaleWinTest and LocalizedNumberICUTest.cpp
1718         (LocaleMacTest):
1719         (LocaleMacTest::decimalSeparator):
1720         (TEST_F):
1721         (testNumberIsReversible):
1722         (testNumbers):
1723
1724 2012-08-08  Adrienne Walker  <enne@google.com>
1725
1726         [chromium] Move scrollbar pointer into WebScrollbarThemePainter
1727         https://bugs.webkit.org/show_bug.cgi?id=93541
1728
1729         Reviewed by James Robinson.
1730
1731         Fix WebScrollbarThemePainter implementation to make direct calls on
1732         the scrollbar rather than through the WebScrollbarThemeClientImpl
1733         adapter.
1734
1735         * src/WebScrollbarThemePainter.cpp:
1736         (WebKit::WebScrollbarThemePainter::assign):
1737         (WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
1738         (WebKit::WebScrollbarThemePainter::paintTrackBackground):
1739         (WebKit::WebScrollbarThemePainter::paintBackTrackPart):
1740         (WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
1741         (WebKit::WebScrollbarThemePainter::paintBackButtonStart):
1742         (WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
1743         (WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
1744         (WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
1745         (WebKit::WebScrollbarThemePainter::paintTickmarks):
1746         (WebKit::WebScrollbarThemePainter::paintThumb):
1747         (WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
1748         * tests/ScrollbarLayerChromiumTest.cpp:
1749         (WebCore::TEST):
1750
1751 2012-08-08  Alexei Svitkine  <asvitkine@chromium.org>
1752
1753         [chromium/mac] Map NSEventPhaseMayBegin appropriately on 10.8
1754         https://bugs.webkit.org/show_bug.cgi?id=93535
1755
1756         Reviewed by Dimitri Glazkov.
1757
1758         This enables putting two fingers on the track pad to show overlay scroll bars on 10.8+.
1759
1760         * src/mac/WebInputEventFactory.mm:
1761         (WebKit::phaseForNSEventPhase):
1762
1763 2012-08-08  James Robinson  <jamesr@chromium.org>
1764
1765         [chromium] Fix up includes and types in chromium compositor unit tests
1766         https://bugs.webkit.org/show_bug.cgi?id=93553
1767
1768         Reviewed by Adrienne Walker.
1769
1770         This removes some unused GraphicsContext3DPrivate.h includes and adds some includes that were being implicitely
1771         depending upon - mostly for wtf/PassOwnPtr.h.
1772
1773         * tests/CCLayerTreeHostTest.cpp:
1774         (::CCLayerTreeHostTestCommit::beginTest):
1775         (::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
1776         * tests/CCRenderSurfaceFiltersTest.cpp:
1777         * tests/CompositorFakeWebGraphicsContext3D.h:
1778         * tests/FakeGraphicsContext3DTest.cpp:
1779         * tests/FakeWebScrollbarThemeGeometry.h:
1780         * tests/TextureCopierTest.cpp:
1781         * tests/ThrottledTextureUploaderTest.cpp:
1782
1783 2012-08-08  Eric Penner  <epenner@google.com>
1784
1785         [chromium] Refactor tile flags.
1786         https://bugs.webkit.org/show_bug.cgi?id=93059
1787
1788         Reviewed by Adrienne Walker.
1789
1790         Minor fixes to existing tests.
1791
1792         * tests/TiledLayerChromiumTest.cpp:
1793
1794 2012-08-08  James Robinson  <jamesr@chromium.org>
1795
1796         [chromium] Clean up WebKit.h and WebKitPlatformSupport.h includes in chromium/src
1797         https://bugs.webkit.org/show_bug.cgi?id=93539
1798
1799         Reviewed by Adam Barth.
1800
1801         Most of these files don't need either WebKit.h or WebKitPlatformSupport.h. Some need <public/Platform.h>, and
1802         some are relying on the forwarding headers. This updates includes to what is actually needed and points platform
1803         includes at <public/Foo.h> instead of "platform/Foo.h" where possible.
1804
1805         * src/ApplicationCacheHostInternal.h:
1806         * src/AssociatedURLLoader.cpp:
1807         * src/AsyncFileSystemChromium.cpp:
1808         (WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
1809         * src/BlobRegistryProxy.cpp:
1810         * src/ChromiumCurrentTime.cpp:
1811         * src/ChromiumOSRandomSource.cpp:
1812         * src/ChromiumThreading.cpp:
1813         * src/EditorClientImpl.cpp:
1814         * src/FrameLoaderClientImpl.cpp:
1815         * src/IDBFactoryBackendProxy.cpp:
1816         * src/LocalizedStrings.cpp:
1817         * src/PlatformMessagePortChannel.cpp:
1818         * src/WebCompositorInputHandlerImpl.cpp:
1819         * src/WebMediaPlayerClientImpl.cpp:
1820         * src/WebPluginContainerImpl.cpp:
1821         * src/WebViewImpl.cpp:
1822         * src/WebWorkerClientImpl.cpp:
1823         * src/WorkerAsyncFileSystemChromium.cpp:
1824         * src/WorkerFileWriterCallbacksBridge.cpp:
1825
1826 2012-08-08  James Robinson  <jamesr@chromium.org>
1827
1828         [chromium] Clean up includes in compositor unit tests
1829         https://bugs.webkit.org/show_bug.cgi?id=93531
1830
1831         Reviewed by Adrienne Walker.
1832
1833         This removes unused includes and updates Platform API headers to use the <public/Web...> style paths.
1834
1835         * tests/CCAnimationTestCommon.cpp:
1836         * tests/CCKeyframedAnimationCurveTest.cpp:
1837         * tests/CCLayerAnimationControllerTest.cpp:
1838         * tests/CCLayerTreeHostCommonTest.cpp:
1839         * tests/CCLayerTreeHostTest.cpp:
1840         (WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
1841         * tests/CCOcclusionTrackerTest.cpp:
1842         * tests/CCTextureUpdateControllerTest.cpp:
1843         * tests/CCThreadedTest.cpp:
1844         * tests/FakeWebGraphicsContext3D.h:
1845         * tests/LayerChromiumTest.cpp:
1846         * tests/LayerRendererChromiumTest.cpp:
1847         * tests/TiledLayerChromiumTest.cpp:
1848         * tests/WebCompositorInputHandlerImplTest.cpp:
1849         * tests/WebLayerTest.cpp:
1850         * tests/WebLayerTreeViewTest.cpp:
1851
1852 2012-08-07  James Robinson  <jamesr@chromium.org>
1853
1854         [chromium] Only use public Platform API in NonCompositedContentHost
1855         https://bugs.webkit.org/show_bug.cgi?id=93423
1856
1857         Reviewed by Adrienne Walker.
1858
1859         Switches to using Web*Layer APIs in NonCompositedContentHost instead of reaching in to the LayerChromium and
1860         updates unit tests for the nonCompositedContent->useLCDText flag rename.
1861
1862         * src/NonCompositedContentHost.cpp:
1863         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
1864         * src/WebContentLayer.cpp:
1865         (WebKit::WebContentLayer::setUseLCDText):
1866         (WebKit):
1867         (WebKit::WebContentLayer::setDrawCheckerboardForMissingTiles):
1868         * src/WebViewImpl.cpp:
1869         * tests/CCLayerImplTest.cpp:
1870         (WebCore::TEST):
1871         * tests/CCLayerTreeHostImplTest.cpp:
1872         * tests/LayerChromiumTest.cpp:
1873
1874 2012-08-08  Alec Flett  <alecflett@chromium.org>
1875
1876         IndexedDB: new enums and openCursor stub
1877         https://bugs.webkit.org/show_bug.cgi?id=93410
1878
1879         Reviewed by Adam Barth.
1880
1881         This stubs out the TaskType and Direction enums that will be
1882         required to land the chromium side of
1883         https://bugs.webkit.org/show_bug.cgi?id=91125.
1884
1885         * public/WebIDBCursor.h:
1886         * public/WebIDBObjectStore.h:
1887         (WebKit::WebIDBObjectStore::setIndexKeys):
1888         (WebKit::WebIDBObjectStore::setIndexesReady):
1889         (WebIDBObjectStore):
1890         (WebKit::WebIDBObjectStore::openCursor):
1891         * public/WebIDBTransaction.h:
1892
1893 2012-08-08  Dana Jansens  <danakj@chromium.org>
1894
1895         [chromium] Enable occlusion tracker in the occlusion tests for surface cacheing
1896         https://bugs.webkit.org/show_bug.cgi?id=93500
1897
1898         Reviewed by Adrienne Walker.
1899
1900         The occlusion tracker is not being used in these tests except to do
1901         scissoring. We want to test occlusion with these occlusion tests,
1902         and when scissoring is not part of occlusion tracker, these
1903         tests would become useless otherwise.
1904
1905         * tests/CCLayerTreeHostImplTest.cpp:
1906
1907 2012-08-08  Adam Barth  <abarth@webkit.org>
1908
1909         Crash when reloading a Chromium "platform" app
1910         https://bugs.webkit.org/show_bug.cgi?id=93497
1911
1912         Reviewed by Eric Seidel.
1913
1914         Test that we don't crash when executing script during the
1915         didCreateScriptContext callback.
1916
1917         * tests/WebFrameTest.cpp:
1918         * tests/data/hello_world.html: Added.
1919
1920 2012-08-07  Joshua Bell  <jsbell@chromium.org>
1921
1922         Layout Test storage/indexeddb/intversion-omit-parameter.html is flaky
1923         https://bugs.webkit.org/show_bug.cgi?id=92952
1924
1925         Reviewed by Tony Chang.
1926
1927         Added test to exercise WebCore::IDBRequest event callbacks after
1928         the script context has stopped and ensure no asserts are hit.
1929
1930         * WebKit.gypi:
1931         * tests/IDBRequestTest.cpp: Added.
1932         (WebCore):
1933         (WebCore::TEST):
1934
1935 2012-08-07  Fady Samuel  <fsamuel@chromium.org>
1936
1937         Allow plugins to decide whether they are keyboard focusable
1938         https://bugs.webkit.org/show_bug.cgi?id=88958
1939
1940         Reviewed by Anders Carlsson.
1941
1942         * public/WebPlugin.h:
1943         (WebKit::WebPlugin::supportsKeyboardFocus):
1944         * src/WebInputEventConversion.cpp:
1945         (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1946         * src/WebPluginContainerImpl.cpp:
1947         (WebKit::WebPluginContainerImpl::supportsKeyboardFocus):
1948         (WebKit):
1949         * src/WebPluginContainerImpl.h:
1950         (WebPluginContainerImpl):
1951
1952 2012-08-07  Kentaro Hara  <haraken@chromium.org>
1953
1954         [V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods
1955         https://bugs.webkit.org/show_bug.cgi?id=93209
1956
1957         Reviewed by Adam Barth.
1958
1959         By implementing V8Proxy::registerExtensionIfNeeded(), we can remove
1960         registeredExtensionWithV8() and registerExtension().
1961
1962         No tests. No change in behavior.
1963
1964         * src/WebScriptController.cpp:
1965         (WebKit::WebScriptController::registerExtension):
1966
1967 2012-08-07  James Robinson  <jamesr@chromium.org>
1968
1969         [chromium] Add new gclient-managed cc directory to Source/WebKit/chromium/.gitignore
1970         https://bugs.webkit.org/show_bug.cgi?id=93403
1971
1972         Reviewed by Eric Seidel.
1973
1974         * .gitignore:
1975
1976 2012-08-07  Mihai Parparita  <mihaip@chromium.org>
1977
1978         [Chromium] Clean up WebScriptController.h comments
1979         https://bugs.webkit.org/show_bug.cgi?id=93399
1980
1981         Reviewed by Adam Barth.
1982
1983         Remove references to overloaded WebScriptController::registerExtension
1984         variants. They were removed in r68666.
1985
1986         * public/WebScriptController.h:
1987         (WebScriptController):
1988
1989 2012-08-07  Kentaro Hara  <haraken@chromium.org>
1990
1991         [V8] Remove #include Frame.h from V8Binding.h
1992         https://bugs.webkit.org/show_bug.cgi?id=93326
1993
1994         Reviewed by Adam Barth.
1995
1996         We want to remove unnecessary #include in V8Binding.h
1997         to avoid circular include dependency.
1998
1999         No tests. No change in behavior.
2000
2001         * src/WebBindings.cpp:
2002
2003 2012-08-07  James Robinson  <jamesr@chromium.org>
2004
2005         [chromium] Switch PlatformLayer typedef to Platform API type for PLATFORM(CHROMIUM)
2006         https://bugs.webkit.org/show_bug.cgi?id=93335
2007
2008         Reviewed by Adrienne Walker.
2009
2010         Update for new PlatformLayer typedef. This removes knowledge of WebCore::LayerChromium from all classes
2011         except for NonCompositedContentHost, which still punches through for a few minor APIs that I'll address
2012         in a separate patch.
2013
2014         * src/NonCompositedContentHost.cpp:
2015         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
2016         (WebKit::NonCompositedContentHost::setScrollLayer):
2017         (WebKit::NonCompositedContentHost::scrollLayer):
2018         (WebKit::NonCompositedContentHost::notifySyncRequired):
2019         * src/WebMediaPlayerClientImpl.cpp:
2020         (WebKit::WebMediaPlayerClientImpl::platformLayer):
2021         * src/WebMediaPlayerClientImpl.h:
2022         (WebMediaPlayerClientImpl):
2023         * src/WebPluginContainerImpl.cpp:
2024         (WebKit::WebPluginContainerImpl::platformLayer):
2025         * src/WebPluginContainerImpl.h:
2026         (WebCore):
2027         (WebPluginContainerImpl):
2028         * src/WebScrollableLayer.cpp:
2029         (WebKit::WebScrollableLayer::setNonFastScrollableRegion):
2030         (WebKit):
2031         (WebKit::WebScrollableLayer::setIsContainerForFixedPositionLayers):
2032         (WebKit::WebScrollableLayer::setFixedToContainerLayer):
2033         * src/WebViewImpl.cpp:
2034         (WebKit::WebViewImpl::setRootGraphicsLayer):
2035         * tests/Canvas2DLayerBridgeTest.cpp:
2036         * tests/GraphicsLayerChromiumTest.cpp:
2037         (WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2038         (WebKitTests::TEST_F):
2039
2040 2012-08-07  James Robinson  <jamesr@chromium.org>
2041
2042         [chromium] Use WebCompositor interface in Platform API instead of CCProxy to query threaded compositor status
2043         https://bugs.webkit.org/show_bug.cgi?id=93398
2044
2045         Reviewed by Adam Barth.
2046
2047         Converts non-compositor code that cares about threaded compositing status over to query WebCompositor instead of
2048         CCProxy.
2049
2050         * src/WebMediaPlayerClientImpl.cpp:
2051         (WebKit::WebMediaPlayerClientImpl::supportsType):
2052         * src/WebViewImpl.cpp:
2053         (WebKit::WebViewImpl::composite):
2054         (WebKit::WebViewImpl::scheduleAnimation):
2055         (WebKit::WebViewImpl::scheduleComposite):
2056
2057 2012-08-07  James Robinson  <jamesr@chromium.org>
2058
2059         [chromium] Move WebCompositor interface into Platform AP
2060         https://bugs.webkit.org/show_bug.cgi?id=93391
2061
2062         Reviewed by Adam Barth.
2063
2064         * WebKit.gyp:
2065         * public/WebCompositor.h:
2066         * src/WebLayerTreeViewImpl.cpp:
2067
2068 2012-08-07  Joshua Bell  <jsbell@chromium.org>
2069
2070         REGRESSION(r124865): It broke the ARM Chromium build
2071         https://bugs.webkit.org/show_bug.cgi?id=93364
2072
2073         Reviewed by Csaba Osztrogonác.
2074
2075         Mark large constant with LL to satisfy a picky compiler.
2076
2077         * tests/IDBLevelDBCodingTest.cpp:
2078         (IDBLevelDBCoding::TEST):
2079
2080 2012-08-07  Alexei Filippov  <alexeif@chromium.org>
2081
2082         Web Inspector: make the MemoryClassInfo class a not-template
2083         https://bugs.webkit.org/show_bug.cgi?id=93265
2084
2085         Reviewed by Yury Semikhatsky.
2086
2087         * tests/MemoryInstrumentationTest.cpp:
2088         (WebCore::Instrumented::reportMemoryUsage):
2089         (WebCore::InstrumentedRefPtr::reportMemoryUsage):
2090         (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
2091         (WebCore::InstrumentedOther::reportMemoryUsage):
2092         (WebCore::InstrumentedDOM::reportMemoryUsage):
2093         (WebCore::NonVirtualInstrumented::reportMemoryUsage):
2094
2095 2012-08-06  Yuta Kitamura  <yutak@chromium.org>
2096
2097         WebSocket.send() should accept ArrayBufferView
2098         https://bugs.webkit.org/show_bug.cgi?id=90877
2099
2100         Reviewed by Kent Tamura.
2101
2102         * src/WebSocketImpl.cpp:
2103         (WebKit::WebSocketImpl::sendArrayBuffer):
2104         Apply change in function signature of WebSocketChannel::send().
2105
2106 2012-08-06  James Robinson  <jamesr@chromium.org>
2107
2108         [chromium] Remove lingering unwrap<>() calls in GraphicsLayerChromium.cpp
2109         https://bugs.webkit.org/show_bug.cgi?id=93319
2110
2111         Reviewed by Adrienne Walker.
2112
2113         * src/WebLayer.cpp:
2114         (WebKit::WebLayer::setChildren):
2115         (WebKit):
2116         (WebKit::WebLayer::setReplicaLayer):
2117         (WebKit::WebLayer::setDebugName):
2118         (WebKit::WebLayer::clearRenderSurface):
2119
2120 2012-08-06  Adrienne Walker  <enne@google.com>
2121
2122         [chromium] Convert WebScrollbarThemeGeometry from a concrete class to an interface
2123         https://bugs.webkit.org/show_bug.cgi?id=93308
2124
2125         Reviewed by James Robinson.
2126
2127         Now that WebScrollbarThemeGeometry can have different implementations,
2128         create a FakeWebScrollbarThemeGeometry for testing purposes rather
2129         than just overriding a geometry-related virtual.
2130
2131         * WebKit.gyp:
2132         * WebKit.gypi:
2133         * src/WebScrollbarLayer.cpp:
2134         (WebKit::WebScrollbarLayer::create):
2135         * tests/CCLayerTreeHostImplTest.cpp:
2136         * tests/FakeWebScrollbarThemeGeometry.h: Added.
2137         (WebKit):
2138         (FakeWebScrollbarThemeGeometry):
2139         (WebKit::FakeWebScrollbarThemeGeometry::create):
2140         * tests/ScrollbarLayerChromiumTest.cpp:
2141         (WebCore::TEST):
2142
2143 2012-08-06  James Robinson  <jamesr@chromium.org>
2144
2145         [chromium] Update chromium DEPS r150037 -> r150169
2146         https://bugs.webkit.org/show_bug.cgi?id=93309
2147
2148         As the title says. Unreviewed.
2149
2150         * DEPS:
2151
2152 2012-08-06  David Reveman  <reveman@chromium.org>
2153
2154         [Chromium] Rename CCTextureUpdater to CCTextureUpdateQueue.
2155         https://bugs.webkit.org/show_bug.cgi?id=93293
2156
2157         Reviewed by Adrienne Walker.
2158
2159         * src/WebExternalTextureLayer.cpp:
2160         (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
2161         * tests/CCLayerTreeHostTest.cpp:
2162         (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
2163         (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
2164         (WTF::CCLayerTreeHostTestManySurfaces::beginTest):
2165         * tests/CCTextureUpdateControllerTest.cpp:
2166         * tests/CCThreadedTest.cpp:
2167         * tests/CCTiledLayerTestCommon.cpp:
2168         (WebKitTests::FakeTiledLayerChromium::update):
2169         * tests/CCTiledLayerTestCommon.h:
2170         (FakeTiledLayerChromium):
2171         * tests/Canvas2DLayerBridgeTest.cpp:
2172         * tests/TiledLayerChromiumTest.cpp:
2173
2174 2012-08-06  Bear Travis  <betravis@adobe.com>
2175
2176         [CSS Exclusions] Add a command-line flag to enable / disable exclusions
2177         https://bugs.webkit.org/show_bug.cgi?id=91420
2178
2179         Reviewed by Dimitri Glazkov.
2180
2181         Adding the interface code to expose the css exclusions runtime flag to
2182         Chromium.
2183
2184         * public/WebRuntimeFeatures.h:
2185         (WebRuntimeFeatures): Adding getters/setters for cssExclusions
2186         * src/WebRuntimeFeatures.cpp:
2187         (WebKit::WebRuntimeFeatures::enableCSSExclusions):
2188         (WebKit):
2189         (WebKit::WebRuntimeFeatures::isCSSExclusionsEnabled):
2190
2191 2012-08-06  Adam Barth  <abarth@webkit.org>
2192
2193         [Chromium] WebTouchCandidatesInfo should be part of the Client API
2194         https://bugs.webkit.org/show_bug.cgi?id=93088
2195
2196         Reviewed by Eric Seidel.
2197
2198         * WebKit.gyp:
2199         * public/WebTouchCandidatesInfo.h: Copied from Source/Platform/chromium/public/WebTouchCandidatesInfo.h.
2200         * src/WebViewImpl.cpp:
2201
2202 2012-08-06  Adrienne Walker  <enne@google.com>
2203
2204         [chromium] REGRESSION(r124714): webkit_unit_tests asserts in Debug
2205         https://bugs.webkit.org/show_bug.cgi?id=93297
2206
2207         Reviewed by James Robinson.
2208
2209         This is a quick fix to get debug unit tests working again by
2210         implementing a virtual function that has ASSERT_NOT_REACHED in the
2211         base class version.
2212
2213         * tests/ScrollAnimatorNoneTest.cpp:
2214         (MockScrollableArea::scrollPosition):
2215
2216 2012-08-06  Nasko Oskov  <nasko@chromium.org>
2217
2218         Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.
2219         https://bugs.webkit.org/show_bug.cgi?id=93127
2220
2221         Reviewed by Adam Barth.
2222
2223         Add support in the API to monitor and create frame hierarchy to allow replicating it
2224         across different instances of WebKit.
2225
2226         * public/WebDocument.h:
2227         (WebDocument): Added createElement.
2228         * public/WebFrame.h: Added assignedName.
2229         * public/WebFrameClient.h:
2230         (WebFrameClient):
2231         (WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created.
2232         (WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter.
2233         * public/WebNode.h:
2234         * src/FrameLoaderClientImpl.cpp:
2235         (WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
2236         * src/WebDocument.cpp:
2237         (WebKit::WebDocument::createElement): Added to allow for creating frame elements.
2238         (WebKit):
2239         * src/WebFrameImpl.cpp:
2240         (WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API.
2241         (WebKit):
2242         (WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed 
2243         to the unique name, generated by WebKit.
2244         (WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame.
2245         * src/WebFrameImpl.h:
2246         (WebFrameImpl):
2247         * src/WebNode.cpp:
2248         (WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM.
2249         (WebKit):
2250         * tests/WebFrameTest.cpp:
2251
2252 2012-08-06  David Reveman  <reveman@chromium.org>
2253
2254         [Chromium] Refactor CCTextureUpdater into CCTextureUpdater and CCTextureUpdateController.
2255         https://bugs.webkit.org/show_bug.cgi?id=92596
2256
2257         Reviewed by Adrienne Walker.
2258
2259         * WebKit.gypi:
2260         * src/WebExternalTextureLayer.cpp:
2261         * tests/CCTextureUpdateControllerTest.cpp: Renamed from Source/WebKit/chromium/tests/CCTextureUpdaterTest.cpp.
2262         * tests/CCTiledLayerTestCommon.h:
2263         (WebKitTests::FakeTextureCopier::copyTexture):
2264         (WebKitTests::FakeTextureUploader::uploadTexture):
2265         * tests/TextureCopierTest.cpp:
2266         (TEST):
2267         * tests/TiledLayerChromiumTest.cpp:
2268
2269 2012-08-06  Shawn Singh  <shawnsingh@chromium.org>
2270
2271         [chromium] Non-preserves-3d requires explicit flattening of screen-space transform.
2272         https://bugs.webkit.org/show_bug.cgi?id=85808
2273
2274         Reviewed by Adrienne Walker.
2275
2276         * tests/CCLayerTreeHostCommonTest.cpp:
2277
2278 2012-08-06  Yury Semikhatsky  <yurys@chromium.org>
2279
2280         Web Inspector: rename WorkerAgent.setWorkerInspectionEnabled to WorkerAgent.enable and make it return error
2281         https://bugs.webkit.org/show_bug.cgi?id=92545
2282
2283         Reviewed by Pavel Feldman.
2284
2285         Replaced Preferences.exposeWorkersInspection with InspectorFrontendHost.canInspectWorkers()
2286         that tells if inspector front-end on the given platform can launch dedicated worker
2287         front-end.
2288
2289         * src/InspectorFrontendClientImpl.cpp:
2290         (WebKit::InspectorFrontendClientImpl::canInspectWorkers):
2291         (WebKit):
2292         * src/InspectorFrontendClientImpl.h:
2293         (InspectorFrontendClientImpl):
2294         * src/js/DevTools.js:
2295
2296 2012-08-06  Keishi Hattori  <keishi@webkit.org>
2297
2298         Remove minimum window size for PagePopup
2299         https://bugs.webkit.org/show_bug.cgi?id=93100
2300
2301         Reviewed by Kent Tamura.
2302
2303         * src/WebPagePopupImpl.cpp: Returns 0x0 so the page popup can be smaller than 100x100.
2304
2305 2012-08-05  Kent Tamura  <tkent@chromium.org>
2306
2307         [Chromium-win] Use system locale for number representation
2308         https://bugs.webkit.org/show_bug.cgi?id=93085
2309
2310         Reviewed by Hajime Morita.
2311
2312         * WebKit.gypi:
2313         Don't include Localized*ICUTest.cpp in Windows and OSX. They are unnecessary.
2314         * tests/LocaleWinTest.cpp:
2315         (LocaleWinTest): Add some LCID symbols.
2316         (LocaleWinTest::decimalSeparator):
2317         A helper for LocaleWinTest.decimalSeparator.
2318         (TEST_F(LocaleWinTest, decimalSeparator)):
2319         A test for LocaleWin::localizedDecimalSeparator(). This is a copy of the
2320         corresponding test in LocalizedNumberICUTest.cpp.
2321         (testNumberIsReversible):
2322         A test helper LocaleWinTest.localizedNumberRoundTrip. This is a copy of
2323         the corresponding test in LocalizedNumberICUTest.cpp.
2324         (testNumbers): ditto.
2325         (TEST_F(LocaleWinTest, localizedNumberRoundTrip)):
2326         Tests for LocaleWin changes. This is a copy of the corresponding tests
2327         in LocalizedNumberICUTest.cpp.
2328
2329 2012-08-04  Sheriff Bot  <webkit.review.bot@gmail.com>
2330
2331         Unreviewed.  Rolled DEPS.
2332
2333         * DEPS:
2334
2335 2012-08-03  Nico Weber  <thakis@chromium.org>
2336
2337         [chromium] Add API to make it possible to request all variants of a WebImage
2338         https://bugs.webkit.org/show_bug.cgi?id=92933
2339
2340         Reviewed by Adam Barth.
2341
2342         Part of http://crbug.com/138550
2343
2344         * src/WebImageSkia.cpp:
2345         (WebKit::WebImage::framesFromData):
2346         (WebKit):
2347
2348 2012-08-03  Yaron Friedman  <yfriedman@chromium.org>
2349
2350         [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
2351         https://bugs.webkit.org/show_bug.cgi?id=92931
2352
2353         Reviewed by Adam Barth.
2354
2355         Pass Android-specific gyp variables to the native test generator
2356         avoiding any dependencies on environment variables during build time.
2357
2358         * WebKitUnitTests.gyp:
2359
2360 2012-08-03  David Grogan  <dgrogan@chromium.org>
2361
2362         IndexedDB: Core upgradeneeded logic
2363         https://bugs.webkit.org/show_bug.cgi?id=92558
2364
2365         Reviewed by Ojan Vafai.
2366
2367         Update overridden methods to match new signatures.
2368
2369         * tests/IDBAbortOnCorruptTest.cpp:
2370         (WebCore::FailingBackingStore::createIDBDatabaseMetaData):
2371         * tests/IDBFakeBackingStore.h:
2372
2373 2012-08-03  Rick Byers  <rbyers@chromium.org>
2374
2375         Double tap gesture should send dblclick event
2376         https://bugs.webkit.org/show_bug.cgi?id=92412
2377
2378         Reviewed by Adam Barth.
2379
2380         Tweak comment to more completely describe the (lame) overloaded use
2381         of deltaX in WebGestureEvent, and add a FIXME with the bug to track
2382         cleaning it up.
2383         * public/WebInputEvent.h:
2384         (WebGestureEvent):
2385
2386 2012-08-03  Dave Tu  <dtu@chromium.org>
2387
2388         [chromium] Remove assert when getting hardware renderingStats in software mode.
2389         https://bugs.webkit.org/show_bug.cgi?id=92325
2390
2391         Reviewed by Adrienne Walker.
2392
2393         If a page caused hardware mode to be turned on, then off, the hardware stats are still valid, so we don't need to assert that we're in hardware mode. Checking if the LayerTreeView is null should be sufficient.
2394
2395         * public/WebWidget.h:
2396         (WebWidget):
2397         * src/WebViewImpl.cpp:
2398         (WebKit::WebViewImpl::WebViewImpl):
2399         (WebKit::WebViewImpl::renderingStats):
2400         (WebKit::WebViewImpl::paint):
2401         * src/WebViewImpl.h:
2402
2403 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2404
2405         Unreviewed.  Rolled DEPS.
2406
2407         * DEPS:
2408
2409 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2410
2411         Unreviewed, rolling out r124632.
2412         http://trac.webkit.org/changeset/124632
2413         https://bugs.webkit.org/show_bug.cgi?id=93154
2414
2415         Added new WebFrameTest.SelectRange which fails on bots
2416         (Requested by dimich on #webkit).
2417
2418         * tests/WebFrameTest.cpp:
2419         * tests/data/select_range_basic.html: Removed.
2420         * tests/data/select_range_iframe.html: Removed.
2421         * tests/data/select_range_scroll.html: Removed.
2422
2423 2012-08-03  Terry Anderson  <tdanderson@chromium.org>
2424
2425         Apply target fuzzing when sending a context menu event
2426         https://bugs.webkit.org/show_bug.cgi?id=92914
2427
2428         Reviewed by Antonio Gomes.
2429
2430         When constructing a PlatformEvent::GestureLongPress in WebInputEventConversion.cpp,
2431         use |boundingBox| to specify |m_area|.
2432
2433         * src/WebInputEventConversion.cpp:
2434         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2435
2436 2012-08-03  Leandro Gracia Gil  <leandrogracia@chromium.org>
2437
2438         [Chromium] Add stubs for the find-in-page match rects API
2439         https://bugs.webkit.org/show_bug.cgi?id=93110
2440
2441         Reviewed by Adam Barth.
2442
2443         The Android port allows tapping on the find-in-page result tickmarks taking
2444         the user to the corresponding matches. This patch introduces stubs for the
2445         new required methods in order to achieve WebKit API compatibility for this
2446         port as soon as possible. The implementation of these methods will be added
2447         later in https://bugs.webkit.org/show_bug.cgi?id=93111.
2448
2449         * public/WebFrame.h:
2450         (WebKit):
2451         (WebFrame):
2452         * src/WebFrameImpl.cpp:
2453         (WebKit::WebFrameImpl::findMatchMarkersVersion):
2454         (WebKit):
2455         (WebKit::WebFrameImpl::activeFindMatchRect):
2456         (WebKit::WebFrameImpl::findMatchRects):
2457         (WebKit::WebFrameImpl::selectNearestFindMatch):
2458         * src/WebFrameImpl.h:
2459         (WebFrameImpl):
2460
2461 2012-08-03  Mike West  <mkwst@chromium.org>
2462
2463         Blocking a plugin via CSP should result in one (and only one) console message.
2464         https://bugs.webkit.org/show_bug.cgi?id=92649
2465
2466         Reviewed by Adam Barth.
2467
2468         * src/LocalizedStrings.cpp:
2469         (WebCore::blockedPluginByContentSecurityPolicyText):
2470         (WebCore):
2471             Adding a stub for the newly added string.
2472
2473 2012-08-03  Oli Lan  <olilan@chromium.org>
2474
2475         [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint.
2476         https://bugs.webkit.org/show_bug.cgi?id=93108
2477
2478         Reviewed by Adam Barth.
2479
2480         Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange, and also
2481         serves to test WebFrameImpl::visiblePositionForWindowPoint as it is used by selectRange.
2482
2483         The test uses sample files that contain selected text on load. The test uses
2484         WebViewImpl::selectionBounds to retrieve the ends of the selection, then unselects
2485         and calls WebFrameImpl::selectRange to attempt to reselect the same text.
2486
2487         Three cases are tested: the normal case, the case where the selected text is offscreen
2488         due to a scroll, and the case where the selected text is in an iframe. This allows the
2489         problem cases and fix in https://bugs.webkit.org/show_bug.cgi?id=79117 to be tested.
2490
2491         * tests/WebFrameTest.cpp:
2492         * tests/data/select_range_basic.html: Added.
2493         * tests/data/select_range_iframe.html: Added.
2494         * tests/data/select_range_scroll.html: Added.
2495
2496 2012-08-03  Ilya Tikhonovsky  <loislo@chromium.org>
2497
2498         Web Inspector: eliminate visitBaseClass method from NMI. It introduces unnecessary complexity.
2499         https://bugs.webkit.org/show_bug.cgi?id=93129
2500
2501         Reviewed by Yury Semikhatsky.
2502
2503         * tests/MemoryInstrumentationTest.cpp:
2504         (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
2505
2506 2012-08-03  Adam Barth  <abarth@webkit.org>
2507
2508         V8Proxy::retrieve(*) leads to really obfuscated code and should be removed
2509         https://bugs.webkit.org/show_bug.cgi?id=93072
2510
2511         Reviewed by Eric Seidel.
2512
2513         * src/WebDevToolsAgentImpl.cpp:
2514         (WebKit::WebDevToolsAgentImpl::didCreateScriptContext):
2515
2516 2012-08-02  Ilya Tikhonovsky  <loislo@chromium.org>
2517
2518         Web Inspector: extend test coverage for nmi code and fix 2 bugs.
2519         https://bugs.webkit.org/show_bug.cgi?id=92994
2520
2521         Reviewed by Yury Semikhatsky.
2522
2523         1) owner object type propagation.
2524         If a class with object-type DOM has an instrumented member with object-type Other then it has to be recorded as DOM.
2525         Sample: We have SharedBuffer class and we don't know the object-type for it but we know that it is owned by an object with object-type CachedResourceImage.
2526
2527         2) the first member of an instrumented non virtual class was skipped even if it was reported properly.
2528         it happened because the first member has the same address as it's owner
2529
2530         * tests/MemoryInstrumentationTest.cpp:
2531         (WebCore::TEST):
2532         (WebCore):
2533         (InstrumentedOther):
2534         (WebCore::InstrumentedOther::InstrumentedOther):
2535         (WebCore::InstrumentedOther::reportMemoryUsage):
2536         (InstrumentedDOM):
2537         (WebCore::InstrumentedDOM::InstrumentedDOM):
2538         (WebCore::InstrumentedDOM::reportMemoryUsage):
2539         (NonVirtualInstrumented):
2540         (WebCore::NonVirtualInstrumented::reportMemoryUsage):
2541
2542 2012-08-02  Alec Flett  <alecflett@chromium.org>
2543
2544         IndexedDB: remove leftover chromium stubs from putIndexWithKeys
2545         https://bugs.webkit.org/show_bug.cgi?id=93032
2546
2547         Reviewed by Darin Fisher.
2548
2549         Remove old chromium APIs that are no longer called by chrome.
2550
2551         * public/WebIDBCursor.h:
2552         * public/WebIDBObjectStore.h:
2553         * public/WebIDBTransaction.h:
2554
2555 2012-08-02  Antoine Labour  <piman@chromium.org>
2556
2557         [chromium] add lost context test case for HW video decoder
2558         https://bugs.webkit.org/show_bug.cgi?id=93057
2559
2560         Reviewed by Adrienne Walker.
2561
2562         We check that we don't use resources after a lost context (assuming
2563         proper WebVideoFrameProvider behavior).
2564
2565         * tests/CCLayerTreeHostImplTest.cpp:
2566
2567 2012-08-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2568
2569         Unreviewed, rolling out r124540.
2570         http://trac.webkit.org/changeset/124540
2571         https://bugs.webkit.org/show_bug.cgi?id=93055
2572
2573         Broke compile on Chromium Win bot (Requested by dimich on
2574         #webkit).
2575
2576         * tests/IDBAbortOnCorruptTest.cpp:
2577         (WebCore::FailingBackingStore::createIDBDatabaseMetaData):
2578         * tests/IDBFakeBackingStore.h:
2579
2580 2012-08-02  Alexandre Elias  <aelias@google.com>
2581
2582         [chromium] deviceViewportSize cleanup
2583         https://bugs.webkit.org/show_bug.cgi?id=92794
2584
2585         Reviewed by Adrienne Walker.
2586
2587         In the future, CSS layout size will become increasingly disassociated
2588         from physical device size, and it will become impossible to infer one
2589         from the other inside the compositor.  Therefore, this patch allows
2590         deviceViewportSize to be explicitly passed in by the outside client.
2591
2592         I also renamed the existing viewportSize field to "layoutViewportSize"
2593         for clarity, and converted its uses to deviceViewportSize since
2594         that is more appropriate.
2595
2596         I had to add some default-value scaffolding to WebLayerTreeView in
2597         order to avoid breaking ui/compositor.  We can delete it once that's
2598         updated.
2599
2600         * src/WebLayerTreeView.cpp:
2601         (WebKit::WebLayerTreeView::setViewportSize):
2602         (WebKit::WebLayerTreeView::layoutViewportSize):
2603         (WebKit):
2604         (WebKit::WebLayerTreeView::deviceViewportSize):
2605         (WebKit::WebLayerTreeView::setDeviceScaleFactor):
2606         * src/WebViewImpl.cpp:
2607         (WebKit::WebViewImpl::paint):
2608         (WebKit::WebViewImpl::updateLayerTreeViewport):
2609
2610 2012-08-02  Adam Barth  <abarth@webkit.org>
2611
2612         V8Proxy::currentContext() doesn't do anything and should be removed
2613         https://bugs.webkit.org/show_bug.cgi?id=93041
2614
2615         Reviewed by Eric Seidel.
2616
2617         * src/WebBindings.cpp:
2618         (WebKit::makeIntArrayImpl):
2619         (WebKit::makeStringArrayImpl):
2620
2621 2012-08-02  David Grogan  <dgrogan@chromium.org>
2622
2623         IndexedDB: Core upgradeneeded logic
2624         https://bugs.webkit.org/show_bug.cgi?id=92558
2625
2626         Reviewed by Ojan Vafai.
2627
2628         Update overridden methods to match new signatures.
2629
2630         * tests/IDBAbortOnCorruptTest.cpp:
2631         (WebCore::FailingBackingStore::createIDBDatabaseMetaData):
2632         * tests/IDBFakeBackingStore.h:
2633
2634 2012-08-02  Vincent Scheib  <scheib@chromium.org>
2635
2636         Remove old Pointer Lock API.
2637         https://bugs.webkit.org/show_bug.cgi?id=88892
2638
2639         Reviewed by Adam Barth.
2640
2641         * src/WebViewImpl.cpp:
2642             Removed #include to old API header.
2643
2644 2012-08-02  Tien-Ren Chen  <trchen@chromium.org>
2645
2646         [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation
2647         https://bugs.webkit.org/show_bug.cgi?id=91688
2648
2649         Reviewed by Adrienne Walker.
2650
2651         New unit test ScrollbarLayerChromiumTest.scrollOffsetSynchronization to verify
2652         scroll offset is updated during tree synchronization and threaded scrolling.
2653         Another new unit test CCScrollbarAnimationControllerLinearFadeTest to verify
2654         opacity animates as intended.
2655
2656         * tests/ScrollbarLayerChromiumTest.cpp:
2657
2658 2012-08-02  Adrienne Walker  <enne@google.com>
2659
2660         [chromium] Make CCScrollbarLayerImpl handle lost contexts properly
2661         https://bugs.webkit.org/show_bug.cgi?id=93021
2662
2663         Reviewed by James Robinson.
2664
2665         Add CCScrollbarLayerImpl to the dontUseOldResourceAfterLostContext
2666         test. Additionally, modify this test so that stale resource ids
2667         properly point at invalid texture ids so that the test actually tests
2668         what it is supposed to be testing.
2669
2670         * tests/CCLayerTreeHostImplTest.cpp:
2671
2672 2012-08-02  Adam Barth  <abarth@webkit.org>
2673
2674         The generic bindings shouldn't use templates
2675         https://bugs.webkit.org/show_bug.cgi?id=93016
2676
2677         Reviewed by Eric Seidel.
2678
2679         Update #include.
2680
2681         * src/WebBindings.cpp:
2682
2683 2012-08-02  Peter Beverloo  <peter@chromium.org>
2684
2685         [Chromium] Add a stub for WebView::getTouchHighlightQuads()
2686         https://bugs.webkit.org/show_bug.cgi?id=92997
2687
2688         Reviewed by Adam Barth.
2689
2690         Chrome on Android will be using this method for the link preview
2691         implementation, discussion about which is available in Bug 79150. Since
2692         that system is fairly big, will require refactoring, and the unavailable
2693         APIs are blocking API compatibility, add a stub for now.
2694
2695         Together with the WebView API, also add the "WebTouchCandidatesInfo"
2696         structure which is being used by it.
2697
2698         * public/WebView.h:
2699         (WebKit):
2700         (WebView):
2701         * src/WebViewImpl.cpp:
2702         (WebKit):
2703         (WebKit::WebViewImpl::getTouchHighlightQuads):
2704         * src/WebViewImpl.h:
2705         (WebViewImpl):
2706
2707 2012-08-02  Hans Wennborg  <hans@chromium.org>
2708
2709         Speech JavaScript API: Fire speech start event at the same time as sound start event
2710         https://bugs.webkit.org/show_bug.cgi?id=92971
2711
2712         Reviewed by Adam Barth.
2713
2714         Chromium's speech recognizer doesn't differentiate between "sound
2715         started" and "speech started". Just fire those events at the same
2716         time, and don't provide functions for them in
2717         WebSpeechRecognizerClient.
2718
2719         * public/WebSpeechRecognizerClient.h:
2720         * src/SpeechRecognitionClientProxy.cpp:
2721         (WebKit::SpeechRecognitionClientProxy::didStartSound):
2722         (WebKit::SpeechRecognitionClientProxy::didEndSound):
2723         * src/SpeechRecognitionClientProxy.h:
2724         (SpeechRecognitionClientProxy):
2725
2726 2012-08-02  Adam Barth  <abarth@webkit.org>
2727
2728         [Chromium] WebViewImpl::showTouchHighlightQuads isn't needed for Android
2729         https://bugs.webkit.org/show_bug.cgi?id=92921
2730
2731         Reviewed by Nate Chapin.
2732
2733         We originally added a stub implementation of this function to make
2734         merging detectContentOnTouch easier, but showTouchHighlightQuads is
2735         being removed from the chromium-android branch in favor of the code in
2736         https://bugs.webkit.org/show_bug.cgi?id=84487. This patch removes the
2737         stub.
2738
2739         * src/WebViewImpl.cpp:
2740         (WebKit::WebViewImpl::detectContentIntentOnTouch):
2741         * src/WebViewImpl.h:
2742         (WebViewImpl):
2743
2744 2012-08-02  Peter Beverloo  <peter@chromium.org>
2745
2746         [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
2747         https://bugs.webkit.org/show_bug.cgi?id=92858
2748
2749         Reviewed by Adam Barth.
2750
2751         Now that the sdk_build variable is available, we can remove these two differences
2752         as well. This goes together with Adam's bug 90920.
2753
2754         After this patch, the whole Tools/ directory will be unforked :-).
2755
2756         * WebKitUnitTests.gyp:
2757
2758 2012-08-02  Alexei Filippov  <alexeif@chromium.org>
2759
2760         Web Inspector: count RenderStyle objects in the native memory profiler
2761         https://bugs.webkit.org/show_bug.cgi?id=91759
2762
2763         Reviewed by Yury Semikhatsky.
2764
2765         Add a test for DataRef<T> wrapped member instrumentation.
2766
2767         * tests/MemoryInstrumentationTest.cpp:
2768         (WebCore::InstrumentedRefPtr::create):
2769         (WebCore::TEST):
2770         (WebCore):
2771
2772 2012-08-02  Peter Beverloo  <peter@chromium.org>
2773
2774         Unreviewed.  Rolled DEPS.
2775
2776         * DEPS:
2777
2778 2012-08-01  Ilya Tikhonovsky  <loislo@chromium.org>
2779
2780         Web Inspector: test native memory instrumentation code with help of unittests
2781         https://bugs.webkit.org/show_bug.cgi?id=92743
2782
2783         Reviewed by Yury Semikhatsky.
2784
2785         Test a part of existing Native Memory Instrumentation code with help of unit tests.
2786         6 tests were added and two bugs were fixed.
2787         a drive-by improvement: the method MemoryInstrumentation::addInstrumentedObject
2788         was marked as private and addRootObject was introduced instead of it.
2789         The new function also calls processDeferedPointers.
2790
2791         * WebKit.gypi:
2792         * tests/MemoryInstrumentationTest.cpp: Added.
2793         (WebCore):
2794         (NotInstrumented):
2795         (Instrumented):
2796         (WebCore::Instrumented::Instrumented):
2797         (WebCore::Instrumented::~Instrumented):
2798         (WebCore::Instrumented::reportMemoryUsage):
2799         (WebCore::TEST):
2800         (InstrumentedWithOwnPtr):
2801         (WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr):
2802         (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
2803
2804 2012-08-01  Xingnan Wang  <xingnan.wang@intel.com>
2805
2806         IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type
2807         https://bugs.webkit.org/show_bug.cgi?id=92725
2808
2809         Reviewed by Kentaro Hara.
2810
2811         Add two new tests in IDBLevelDBCodingTest.cpp. One for an added function decodeByte() and 
2812         another for verifying that encodeByte() and encodeVarInt() are indentical when the encoded 
2813         values are <= 127.
2814
2815         * tests/IDBLevelDBCodingTest.cpp:
2816         (IDBLevelDBCoding::TEST):
2817         (IDBLevelDBCoding):
2818
2819 2012-08-01  James Robinson  <jamesr@chromium.org>
2820
2821         [chromium] Use new-style tracing macros with explicit category
2822         https://bugs.webkit.org/show_bug.cgi?id=92928
2823
2824         Reviewed by Adam Barth.
2825
2826         Set the category explicitly in traces.
2827
2828         * src/WebViewImpl.cpp:
2829         (WebKit::WebViewImpl::updateAnimations):
2830         (WebKit::WebViewImpl::layout):
2831         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2832
2833 2012-08-01  James Robinson  <jamesr@chromium.org>
2834
2835         [chromium] Move compositor HUD font atlas initialization code out of compositor core
2836         https://bugs.webkit.org/show_bug.cgi?id=92924
2837
2838         Reviewed by Adrienne Walker.
2839
2840         This initializes the compositor's font atlas when initialization the compositor if the "Show FPS counter" or
2841         "Show layer tree" settings are true.
2842
2843         * src/WebLayerTreeView.cpp:
2844         (WebKit::WebLayerTreeView::setFontAtlas):
2845         (WebKit):
2846         * src/WebViewImpl.cpp:
2847         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2848
2849 2012-08-01  Jian Li  <jianli@chromium.org>
2850
2851         [chromium] Make WebKit API support draggable region change update
2852         https://bugs.webkit.org/show_bug.cgi?id=92813
2853
2854         Reviewed by Adam Barth.
2855
2856         Introduce WebDraggableRegion and delegate the draggable region update
2857         call to the new method draggableRegionsChanged in WebViewClient.
2858
2859         * public/WebDocument.h:
2860         (WebDocument):
2861         * public/WebDraggableRegion.h: Added.
2862         (WebKit):
2863         (WebDraggableRegion):
2864         * public/WebViewClient.h:
2865         (WebViewClient):
2866         (WebKit::WebViewClient::draggableRegionsChanged):
2867         * src/ChromeClientImpl.cpp:
2868         (WebKit):
2869         (WebKit::ChromeClientImpl::dashboardRegionsChanged):
2870         * src/ChromeClientImpl.h:
2871         (ChromeClientImpl):
2872         * src/WebDocument.cpp:
2873         (WebKit::WebDocument::draggableRegions):
2874         (WebKit):
2875
2876 2012-08-01  Antoine Labour  <piman@chromium.org>
2877
2878         [chromium] factor out the optimization pass in CCRenderSurfaceFilters::apply
2879         https://bugs.webkit.org/show_bug.cgi?id=92453
2880
2881         Reviewed by James Robinson.
2882
2883         This separates the "optimization" pass in CCRenderSurfaceFilters::apply
2884         to resolve a succession of color matrix filters into a single operation.
2885         This allows testing of that code.
2886         This introduces a new generic color matrix WebFilterOperation, which can
2887         also be used on its own.
2888
2889         * WebKit.gypi:
2890         * tests/CCRenderSurfaceFiltersTest.cpp: Added.
2891         (WebKit):
2892         (WebKit::isCombined):
2893         (WebKit::TEST):
2894
2895 2012-08-01  Daniel Murphy  <dmurph@chromium.org>
2896
2897         Fix for drawing invalid layers in WebViewBenchmarkSupportImpl
2898         https://bugs.webkit.org/show_bug.cgi?id=92920
2899
2900         Reviewed by Adrienne Walker.
2901
2902         The GraphicsLayers without content needed to be skipped.
2903
2904         * src/WebViewBenchmarkSupportImpl.cpp:
2905         (WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):
2906
2907 2012-08-01  Jian Li  <jianli@chromium.org>
2908
2909         Add new CSS property "-webkit-widget-region" to expose dashboard region support for other port
2910         https://bugs.webkit.org/show_bug.cgi?id=90298
2911
2912         Reviewed by Adam Barth.
2913
2914         * features.gypi: Add ENABLE_WIDGET_REGION define.
2915
2916 2012-08-01  Antoine Labour  <piman@chromium.org>
2917
2918         [chromium] Fix lost context handling on hud layer
2919         https://bugs.webkit.org/show_bug.cgi?id=92915
2920
2921         Reviewed by Adrienne Walker.
2922
2923         On lost context we need to release CCScopedTextures, otherwise later on
2924         we will try to re-allocate it using a stale CCResourceProvider.
2925
2926         Test CCLayerTreeHostImplTest.dontUseOldResourcesAfterLostContext
2927         extended.
2928
2929         * tests/CCLayerTreeHostImplTest.cpp:
2930
2931 2012-08-01  Nico Weber  <thakis@chromium.org>
2932
2933         [chromium/mac] Delete WebImageCG.cpp
2934         https://bugs.webkit.org/show_bug.cgi?id=92910
2935
2936         Reviewed by James Robinson.
2937
2938         It's been unused since the switch to skia.
2939         Also remove now-unneeded *CG.cpp exclusion rule.
2940
2941         * WebKit.gyp:
2942         * src/WebImageCG.cpp: Removed.
2943
2944 2012-08-01  Joshua Bell  <jsbell@chromium.org>
2945
2946         [Chromium] IndexedDB: API stubs to simplify WebIDBCursor API
2947         https://bugs.webkit.org/show_bug.cgi?id=92414
2948
2949         Reviewed by Adam Barth.
2950
2951         Prep work to unblock Chromium changes so that http://webkit.org/b/92278 can land.
2952         Adds no-op methods which will later be implemented; during the landing sequence,
2953         Chromium will call both the new methods and the old ones. The end goal is that
2954         the success callbacks for cursors will include the new key/primaryKey/value rather
2955         than requiring the callee to call back into the cursor backend to fetch them.
2956
2957         * public/WebIDBCallbacks.h:
2958         (WebIDBCallbacks):
2959         (WebKit::WebIDBCallbacks::onSuccess):
2960
2961 2012-08-01  Peter Beverloo  <peter@chromium.org>
2962
2963         [Text Autosizing] Provide an API for influencing the font scale factor
2964         https://bugs.webkit.org/show_bug.cgi?id=92882
2965
2966         Reviewed by Adam Barth.
2967
2968         Add an API to change Text Autosizing's font scale factor.
2969
2970         The font scale factor applied to Text Autosizing influences the sizing
2971         of text, and will influence the scaling of boosted blocks once the
2972         implementation progresses. For Android, it will be set to the font size
2973         chosen in the user's system-wide preferences.
2974
2975         * public/WebSettings.h:
2976         * src/WebSettingsImpl.cpp:
2977         (WebKit::WebSettingsImpl::setTextAutosizingFontScaleFactor):
2978         (WebKit):
2979         * src/WebSettingsImpl.h:
2980         (WebSettingsImpl):
2981
2982 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
2983
2984         Roll chromium DEPS to 149416.
2985
2986         Unreviewed.
2987
2988         * DEPS:
2989
2990 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2991
2992         Unreviewed, rolling out r124334.
2993         http://trac.webkit.org/changeset/124334
2994         https://bugs.webkit.org/show_bug.cgi?id=92879
2995
2996         Broke MemoryInstrumentationTest.sizeOf from webkit_unit_tests
2997         on Chromium canaries (Requested by apavlov1 on #webkit).
2998
2999         * WebKit.gypi:
3000         * tests/MemoryInstrumentationTest.cpp: Removed.
3001
3002 2012-08-01  Ilya Tikhonovsky  <loislo@chromium.org>
3003
3004         Web Inspector: test native memory instrumentation code with help of unittests
3005         https://bugs.webkit.org/show_bug.cgi?id=92743
3006
3007         Reviewed by Yury Semikhatsky.
3008
3009         Test a part of existing Native Memory Instrumentation code with help of unit tests.
3010         6 tests were added and two bugs were fixed.
3011
3012         * WebKit.gypi:
3013         * tests/MemoryInstrumentationTest.cpp: Added.
3014         (WebCore):
3015         (MemoryInstrumentationImpl):
3016         (WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
3017         (WebCore::MemoryInstrumentationImpl::reportedSize):
3018         (WebCore::MemoryInstrumentationImpl::countObjectSize):
3019         (WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
3020         (NotInstrumented):
3021         (Instrumented):
3022         (WebCore::Instrumented::Instrumented):
3023         (WebCore::Instrumented::~Instrumented):
3024         (WebCore::Instrumented::reportMemoryUsage):
3025         (WebCore::TEST):
3026         (InstrumentedWithOwnPtr):
3027         (WebCore::InstrumentedWithOwnPtr::InstrumentedWithOwnPtr):
3028         (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
3029
3030 2012-08-01  Alexei Filippov  <alexeif@chromium.org>
3031
3032         Web Inspector: count DOM storage cache memory for native snapshot
3033         https://bugs.webkit.org/show_bug.cgi?id=91617
3034
3035         Reviewed by Yury Semikhatsky.
3036
3037         Add memory size used for DOM storage cache reporting interface.
3038
3039         * src/StorageAreaProxy.cpp:
3040         (WebCore::StorageAreaProxy::memoryBytesUsedByCache):
3041         (WebCore):
3042         * src/StorageAreaProxy.h:
3043         (StorageAreaProxy):
3044
3045 2012-07-31  Yoshifumi Inoue  <yosin@chromium.org>
3046
3047         [Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
3048         https://bugs.webkit.org/show_bug.cgi?id=92822
3049
3050         Reviewed by Kent Tamura.
3051
3052         This patch enables ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS for Chromium
3053         port except for Android.
3054
3055         * features.gypi: Add ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS=1 to "feature_defines"
3056         block of OS != "android".
3057
3058 2012-07-31  Yusuf Ozuysal  <yusufo@google.com>
3059
3060         [chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android
3061         https://bugs.webkit.org/show_bug.cgi?id=92698
3062
3063         Reviewed by Adam Barth.
3064
3065         Enforce the maximum and minimum scroll positions after the scale has changed.
3066
3067         * src/WebViewImpl.cpp:
3068         (WebKit::WebViewImpl::startPageScaleAnimation):
3069         * src/WebViewImpl.h:
3070         (WebViewImpl):
3071
3072 2012-07-31  Terry Anderson  <tdanderson@chromium.org>
3073
3074         [chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap
3075         https://bugs.webkit.org/show_bug.cgi?id=92151
3076
3077         Reviewed by Darin Fisher.
3078
3079         Now that gesture events store a bounding box, use |boundingBox| instead of
3080         |deltaX| and |deltaY| when specifying |m_area|.
3081
3082         * public/WebInputEvent.h:
3083         (WebGestureEvent):
3084         * src/WebInputEventConversion.cpp:
3085         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
3086
3087 2012-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3088
3089         Unreviewed.  Rolled DEPS.
3090
3091         * DEPS:
3092
3093 2012-07-31  Shawn Singh  <shawnsingh@chromium.org>
3094
3095         [chromium] Hit test points are being clipped by layers that should not clip
3096         https://bugs.webkit.org/show_bug.cgi?id=92786
3097
3098         Reviewed by James Robinson.
3099
3100         * tests/CCLayerTreeHostCommonTest.cpp: adds a test where the
3101           hit-testable layer does not overlap its parent. The parent does
3102           not clip, so the layer should still be hittable.
3103
3104 2012-07-31  Chris Rogers  <crogers@google.com>
3105
3106         Allow AudioDestination to support local/live audio input
3107         https://bugs.webkit.org/show_bug.cgi?id=90318
3108
3109         Reviewed by Kenneth Russell.
3110
3111         * src/AudioDestinationChromium.cpp:
3112         (WebCore::AudioDestination::create):
3113         (WebCore::AudioDestinationChromium::AudioDestinationChromium):
3114         (WebCore::AudioDestinationChromium::provideInput):
3115         (WebCore):
3116         * src/AudioDestinationChromium.h:
3117         (AudioDestinationChromium):
3118
3119 2012-07-31  Adam Barth  <abarth@webkit.org>
3120
3121         [Chromium-Android] We should hueristically detect content intents on touch
3122         https://bugs.webkit.org/show_bug.cgi?id=92346
3123
3124         Reviewed by Nate Chapin.
3125
3126         On Android, when the user touches a block of text, we run a bunch of
3127         OS-provided hueristics to detect content intents, such as telephone
3128         numbers and mailing addresses.
3129
3130         This patch introduces the WebViewClient functions and the
3131         detectContentIntentOnTouch function, but does not wire the code into
3132         the event system. There are some decisions to make about how to wire it
3133         into the event system, we'll tackle in the next patch.
3134
3135         * public/WebViewClient.h:
3136         (WebKit::WebViewClient::detectContentIntentAround):
3137         (WebViewClient):
3138         (WebKit::WebViewClient::scheduleContentIntent):
3139         (WebKit::WebViewClient::cancelScheduledContentIntents):
3140         * src/WebViewImpl.cpp:
3141         (WebKit):
3142         (WebKit::tapHighlightColorForNode):
3143         (WebKit::WebViewImpl::showTouchHighlightQuads):
3144         (WebKit::WebViewImpl::detectContentIntentOnTouch):
3145         * src/WebViewImpl.h:
3146         (WebViewImpl):
3147
3148 2012-07-31  Ian Vollick  <vollick@chromium.org>
3149
3150         [chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil
3151         https://bugs.webkit.org/show_bug.cgi?id=90468
3152
3153         Reviewed by James Robinson.
3154
3155         * src/WebAnimation.cpp:
3156         (WebKit::WebAnimation::targetProperty):
3157         (WebKit):
3158         (WebKit::WebAnimation::initialize):
3159         * src/WebLayer.cpp:
3160         (WebKit::WebLayer::setAnimationDelegate):
3161         (WebKit):
3162         (WebKit::WebLayer::addAnimation):
3163         (WebKit::WebLayer::removeAnimation):
3164         (WebKit::WebLayer::pauseAnimation):
3165         (WebKit::WebLayer::suspendAnimations):
3166         (WebKit::WebLayer::resumeAnimations):
3167         (WebKit::WebLayer::transferAnimationsTo):
3168         * tests/CCThreadedTest.cpp:
3169         * tests/CCThreadedTest.h:
3170         (TestHooks):
3171         * tests/WebAnimationTest.cpp:
3172         (WebKit::TEST):
3173
3174 2012-07-30  Adam Barth  <abarth@webkit.org>
3175
3176         Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
3177         https://bugs.webkit.org/show_bug.cgi?id=92135
3178
3179         Reviewed by Kentaro Hara.
3180
3181         This patch fixes a typo.
3182
3183         * src/WebViewImpl.cpp:
3184         (WebKit::WebViewImpl::animateZoomAroundPoint):
3185
3186 2012-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3187
3188         Unreviewed, rolling out r124179.
3189         http://trac.webkit.org/changeset/124179
3190         https://bugs.webkit.org/show_bug.cgi?id=92730
3191
3192         Breaks Chromium Linux 32 bots with "error: integer constant is
3193         too large for 'long' type" in IDBLevelDBCodingTest.cpp
3194         (Requested by apavlov on #webkit).
3195
3196         * tests/IDBLevelDBCodingTest.cpp:
3197         (IDBLevelDBCoding::TEST):
3198
3199 2012-07-30  Keishi Hattori  <keishi@webkit.org>
3200
3201         Implement datalist UI for input type color for Chromium
3202         https://bugs.webkit.org/show_bug.cgi?id=92075
3203
3204         Reviewed by Kent Tamura.
3205
3206         Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
3207         ColorChooserUIController can control whether to open the color suggestion picker
3208         popup or the color chooser depending on the responses from ColorChooserClient.
3209
3210         * WebKit.gyp:
3211         * src/ChromeClientImpl.cpp:
3212         (WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
3213         (WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
3214         * src/ChromeClientImpl.h:
3215         (WebKit):
3216         (ChromeClientImpl):
3217         * src/ColorChooserProxy.cpp: Removed.
3218         * src/ColorChooserProxy.h: Removed.
3219         * src/ColorChooserUIController.cpp: Added.
3220         (WebKit):
3221         (WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
3222         (WebKit::ColorChooserUIController::~ColorChooserUIController):
3223         (WebKit::ColorChooserUIController::setSelectedColor):
3224         (WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
3225         (WebKit::ColorChooserUIController::didChooseColor):
3226         (WebKit::ColorChooserUIController::didEndChooser):
3227         (WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
3228         (WebKit::ColorChooserUIController::writeDocument):
3229         (WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
3230         (WebKit::ColorChooserUIController::didClosePopup):
3231         (WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
3232         (WebKit::ColorChooserUIController::closePopup):
3233         (WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
3234         * src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
3235         (WebCore):
3236         (WebKit):
3237         (ColorChooserUIController):
3238         * src/WebColorChooserClientImpl.cpp: Removed.
3239
3240 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
3241
3242         Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.
3243
3244         * DEPS:
3245
3246 2012-07-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3247
3248         Unreviewed.  Rolled DEPS.
3249
3250         * DEPS:
3251
3252 2012-07-30  Adrienne Walker  <enne@google.com>
3253
3254         [chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
3255         https://bugs.webkit.org/show_bug.cgi?id=91032
3256
3257         Reviewed by James Robinson.
3258
3259         Add implementation of WebScrollbarLayer to the client API.
3260
3261         * WebKit.gyp:
3262         * src/WebScrollbarLayer.cpp: Added.
3263         (WebKit):
3264         (WebKit::WebScrollbarLayer::setScrollLayer):
3265         (WebKit::WebScrollbarLayer::create):
3266         (WebKit::WebScrollbarLayer::WebScrollbarLayer):
3267         (WebKit::WebScrollbarLayer::operator=):
3268         (WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
3269
3270 2012-07-30  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3271
3272         Propagate gesture events to plugins.
3273         https://bugs.webkit.org/show_bug.cgi?id=92281
3274
3275         Reviewed by Adam Barth.
3276
3277         Propagate gesture events to plugins.
3278
3279         * src/WebInputEventConversion.cpp:
3280         (WebKit):
3281         (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
3282         * src/WebInputEventConversion.h:
3283         (WebCore):
3284         (WebKit):
3285         (WebGestureEventBuilder):
3286         * src/WebPluginContainerImpl.cpp:
3287         (WebKit::WebPluginContainerImpl::handleEvent):
3288         * src/WebPluginContainerImpl.h:
3289         (WebCore):
3290         (WebPluginContainerImpl):
3291
3292 2012-07-30  John Bates  <jbates@google.com>
3293
3294         Plumb vsync-enabled flag up to compositor thread and support disable-vsync
3295         https://bugs.webkit.org/show_bug.cgi?id=92323
3296
3297         Reviewed by James Robinson.
3298
3299         * public/WebSettings.h:
3300         * tests/CCFrameRateControllerTest.cpp:
3301         * src/WebLayerTreeView.cpp:
3302         (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
3303         * src/WebSettingsImpl.cpp:
3304         (WebKit::WebSettingsImpl::WebSettingsImpl):
3305         (WebKit::WebSettingsImpl::setRenderVSyncEnabled):
3306         (WebKit):
3307         * src/WebSettingsImpl.h:
3308         (WebSettingsImpl):
3309         (WebKit::WebSettingsImpl::renderVSyncEnabled):
3310         * src/WebViewImpl.cpp:
3311         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3312
3313 2012-07-30  Adrienne Walker  <enne@google.com>
3314
3315         [chromium] Remove dependency on ScrollbarTheme from the compositor
3316         https://bugs.webkit.org/show_bug.cgi?id=90528
3317
3318         Reviewed by James Robinson.
3319
3320         Add implementations for WebScrollbarThemeGeometry and
3321         WebScrollbarThemePainter. Fill out additional API calls for
3322         WebPluginScrollbarImpl since it derives from WebScrollbar.
3323
3324         Add WebScrollbarImpl to the client API to wrap and own an existing
3325         WebCore Scrollbar object and provide the WebScrollbar interface.
3326
3327         By keeping WebScrollbar separate from WebScrollbarThemeGeometry, the
3328         compositor thread can create its own thread-safe data bag version of a
3329         WebScrollbar (CCScrollbarLayerImpl::CCScrollbar), but this requires
3330         WebScrollbarThemeClientImpl.
3331
3332         WebScrollbarThemeClientImpl does the reverse of WebScrollbarImpl; it
3333         wraps a WebScrollbar and provides the ScrollbarThemeClient interface.
3334         This is so that a WebScrollbar can be passed to the geometry and
3335         painter functions. Then, internally the WebScrollbarThemeClientImpl
3336         can be used to adapt the WebScrollbar to the ScrollbarThemeClient
3337         interface so the geometry and painter functions can call direct
3338         functions on ScrollbarThemeComposite.
3339
3340         * WebKit.gyp:
3341         * src/AssertMatchingEnums.cpp:
3342         * src/ExternalPopupMenu.h:
3343         (WebKit):
3344         * src/WebPluginScrollbarImpl.cpp:
3345         (WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl):
3346         (WebKit::WebPluginScrollbarImpl::location):
3347         (WebKit):
3348         (WebKit::WebPluginScrollbarImpl::size):
3349         (WebKit::WebPluginScrollbarImpl::enabled):
3350         (WebKit::WebPluginScrollbarImpl::maximum):
3351         (WebKit::WebPluginScrollbarImpl::totalSize):
3352         (WebKit::WebPluginScrollbarImpl::isScrollViewScrollbar):
3353         (WebKit::WebPluginScrollbarImpl::isScrollableAreaActive):
3354         (WebKit::WebPluginScrollbarImpl::getTickmarks):
3355         (WebKit::WebPluginScrollbarImpl::controlSize):
3356         (WebKit::WebPluginScrollbarImpl::pressedPart):
3357         (WebKit::WebPluginScrollbarImpl::hoveredPart):
3358         (WebKit::WebPluginScrollbarImpl::scrollbarOverlayStyle):
3359         (WebKit::WebPluginScrollbarImpl::orientation):
3360         (WebKit::WebPluginScrollbarImpl::isCustomScrollbar):
3361         (WebKit::WebPluginScrollbarImpl::onMouseUp):
3362         (WebKit::WebPluginScrollbarImpl::onMouseMove):
3363         (WebKit::WebPluginScrollbarImpl::onMouseLeave):
3364         * src/WebPluginScrollbarImpl.h:
3365         (WebPluginScrollbarImpl):
3366         * src/WebScrollbarImpl.cpp: Added.
3367         (WebKit):
3368         (WebKit::WebScrollbar::create):
3369         (WebKit::WebScrollbarImpl::WebScrollbarImpl):
3370         (WebKit::WebScrollbarImpl::isOverlay):
3371         (WebKit::WebScrollbarImpl::value):
3372         (WebKit::WebScrollbarImpl::location):
3373         (WebKit::WebScrollbarImpl::size):
3374         (WebKit::WebScrollbarImpl::enabled):
3375         (WebKit::WebScrollbarImpl::maximum):
3376         (WebKit::WebScrollbarImpl::totalSize):
3377         (WebKit::WebScrollbarImpl::isScrollViewScrollbar):
3378         (WebKit::WebScrollbarImpl::isScrollableAreaActive):
3379         (WebKit::WebScrollbarImpl::getTickmarks):
3380         (WebKit::WebScrollbarImpl::controlSize):
3381         (WebKit::WebScrollbarImpl::pressedPart):
3382         (WebKit::WebScrollbarImpl::hoveredPart):
3383         (WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
3384         (WebKit::WebScrollbarImpl::orientation):
3385         (WebKit::WebScrollbarImpl::isCustomScrollbar):
3386         * src/WebScrollbarImpl.h: Copied from Source/Platform/chromium/public/WebScrollbar.h.
3387         (WebCore):
3388         (WebKit):
3389         (WebScrollbarImpl):
3390         * src/WebScrollbarThemeClientImpl.cpp: Added.
3391         (WebKit):
3392         (WebKit::WebScrollbarThemeClientImpl::WebScrollbarThemeClientImpl):
3393         (WebKit::WebScrollbarThemeClientImpl::x):
3394         (WebKit::WebScrollbarThemeClientImpl::y):
3395         (WebKit::WebScrollbarThemeClientImpl::width):
3396         (WebKit::WebScrollbarThemeClientImpl::height):
3397         (WebKit::WebScrollbarThemeClientImpl::size):
3398         (WebKit::WebScrollbarThemeClientImpl::location):
3399         (WebKit::WebScrollbarThemeClientImpl::parent):
3400         (WebKit::WebScrollbarThemeClientImpl::root):
3401         (WebKit::WebScrollbarThemeClientImpl::setFrameRect):
3402         (WebKit::WebScrollbarThemeClientImpl::frameRect):
3403         (WebKit::WebScrollbarThemeClientImpl::invalidate):
3404         (WebKit::WebScrollbarThemeClientImpl::invalidateRect):
3405         (WebKit::WebScrollbarThemeClientImpl::scrollbarOverlayStyle):
3406         (WebKit::WebScrollbarThemeClientImpl::getTickmarks):
3407         (WebKit::WebScrollbarThemeClientImpl::isScrollableAreaActive):
3408         (WebKit::WebScrollbarThemeClientImpl::isScrollViewScrollbar):
3409         (WebKit::WebScrollbarThemeClientImpl::convertFromContainingWindow):
3410         (WebKit::WebScrollbarThemeClientImpl::isCustomScrollbar):
3411         (WebKit::WebScrollbarThemeClientImpl::orientation):
3412         (WebKit::WebScrollbarThemeClientImpl::value):
3413         (WebKit::WebScrollbarThemeClientImpl::currentPos):
3414         (WebKit::WebScrollbarThemeClientImpl::visibleSize):
3415         (WebKit::WebScrollbarThemeClientImpl::totalSize):
3416         (WebKit::WebScrollbarThemeClientImpl::maximum):
3417         (WebKit::WebScrollbarThemeClientImpl::controlSize):
3418         (WebKit::WebScrollbarThemeClientImpl::lineStep):
3419         (WebKit::WebScrollbarThemeClientImpl::pageStep):
3420         (WebKit::WebScrollbarThemeClientImpl::pressedPart):
3421         (WebKit::WebScrollbarThemeClientImpl::hoveredPart):
3422         (WebKit::WebScrollbarThemeClientImpl::styleChanged):
3423         (WebKit::WebScrollbarThemeClientImpl::enabled):
3424         (WebKit::WebScrollbarThemeClientImpl::setEnabled):
3425         (WebKit::WebScrollbarThemeClientImpl::isOverlayScrollbar):
3426         * src/WebScrollbarThemeClientImpl.h: Added.
3427         (WebCore):
3428         (WebKit):
3429         (WebScrollbarThemeClientImpl):
3430         * src/WebScrollbarThemeGeometry.cpp: Added.
3431         (WebKit):
3432         (WebKit::WebScrollbarThemeGeometry::assign):
3433         (WebKit::WebScrollbarThemeGeometry::thumbPosition):
3434         (WebKit::WebScrollbarThemeGeometry::thumbLength):
3435         (WebKit::WebScrollbarThemeGeometry::trackPosition):
3436         (WebKit::WebScrollbarThemeGeometry::trackLength):
3437         (WebKit::WebScrollbarThemeGeometry::hasButtons):
3438         (WebKit::WebScrollbarThemeGeometry::hasThumb):
3439         (WebKit::WebScrollbarThemeGeometry::trackRect):
3440         (WebKit::WebScrollbarThemeGeometry::thumbRect):
3441         (WebKit::WebScrollbarThemeGeometry::minimumThumbLength):
3442         (WebKit::WebScrollbarThemeGeometry::scrollbarThickness):
3443         (WebKit::WebScrollbarThemeGeometry::backButtonStartRect):
3444         (WebKit::WebScrollbarThemeGeometry::backButtonEndRect):
3445         (WebKit::WebScrollbarThemeGeometry::forwardButtonStartRect):
3446         (WebKit::WebScrollbarThemeGeometry::forwardButtonEndRect):
3447         (WebKit::WebScrollbarThemeGeometry::constrainTrackRectToTrackPieces):
3448         (WebKit::WebScrollbarThemeGeometry::splitTrack):
3449         (WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):
3450         * src/WebScrollbarThemePainter.cpp: Added.
3451         (WebKit):
3452         (WebKit::WebScrollbarThemePainter::assign):
3453         (WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
3454         (WebKit::WebScrollbarThemePainter::paintTrackBackground):
3455         (WebKit::WebScrollbarThemePainter::paintBackTrackPart):
3456         (WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
3457         (WebKit::WebScrollbarThemePainter::paintBackButtonStart):
3458         (WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
3459         (WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
3460         (WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
3461         (WebKit::WebScrollbarThemePainter::paintTickmarks):
3462         (WebKit::WebScrollbarThemePainter::paintThumb):
3463         (WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
3464         * tests/ScrollbarLayerChromiumTest.cpp:
3465         (WebCore::MockScrollbar::convertFromContainingWindow):
3466         (WebCore::MockScrollbar::isOverlayScrollbar):
3467         (MockScrollbar):
3468         (WebCore::TEST):
3469
3470 2012-07-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3471
3472         Unreviewed, rolling out r124025.
3473         http://trac.webkit.org/changeset/124025
3474         https://bugs.webkit.org/show_bug.cgi?id=92658
3475
3476         Causes color-suggestion-picker-appearance layout test to time
3477         out on all Chromium platforms (Requested by tomhudson_ on