Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
[WebKit-https.git] / Source / WebKit / chromium / ChangeLog
1 2013-02-11  Abhishek Arya  <inferno@chromium.org>
2
3         Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
4         https://bugs.webkit.org/show_bug.cgi?id=108981
5
6         Reviewed by Eric Seidel.
7
8         * src/AutofillPopupMenuClient.cpp:
9         (WebKit::AutofillPopupMenuClient::getSuggestion):
10         (WebKit::AutofillPopupMenuClient::getLabel):
11         (WebKit::AutofillPopupMenuClient::getIcon):
12         (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
13         (WebKit::AutofillPopupMenuClient::valueChanged):
14         (WebKit::AutofillPopupMenuClient::selectionChanged):
15         * src/ChromeClientImpl.cpp:
16         (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
17
18 2013-02-10  James Robinson  <jamesr@chromium.org>
19
20         [chromium] Enable more of webkit_unit_tests in component builds
21         https://bugs.webkit.org/show_bug.cgi?id=109369
22
23         Reviewed by Darin Fisher.
24
25         Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
26         calling into webkit_support so they work in component builds.
27
28         * WebKit.gyp:
29         * tests/AssociatedURLLoaderTest.cpp:
30         * tests/EventListenerTest.cpp:
31         * tests/FrameTestHelpers.cpp:
32         (WebKit::FrameTestHelpers::createWebViewAndLoad):
33         (QuitTask):
34         (WebKit::FrameTestHelpers::QuitTask::run):
35         (FrameTestHelpers):
36         (WebKit::FrameTestHelpers::runPendingTasks):
37         * tests/FrameTestHelpers.h:
38         (FrameTestHelpers):
39         * tests/ListenerLeakTest.cpp:
40         * tests/PopupMenuTest.cpp:
41         * tests/PrerenderingTest.cpp:
42         * tests/ScrollingCoordinatorChromiumTest.cpp:
43         (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
44         (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
45         * tests/URLTestHelpers.cpp:
46         (WebKit::URLTestHelpers::registerMockedURLLoad):
47         * tests/WebFrameTest.cpp:
48         * tests/WebImageTest.cpp:
49         (WebKit::readFile):
50         * tests/WebPageNewSerializerTest.cpp:
51         * tests/WebPageSerializerTest.cpp:
52         * tests/WebPluginContainerTest.cpp:
53         (WebKit::WebPluginContainerTest::TearDown):
54         (WebKit::TEST_F):
55         * tests/WebViewTest.cpp:
56
57 2013-02-10  Sheriff Bot  <webkit.review.bot@gmail.com>
58
59         Unreviewed.  Rolled Chromium DEPS to r181645.  Requested by
60         "James Robinson" <jamesr@chromium.org> via sheriffbot.
61
62         * DEPS:
63
64 2013-02-09  Stephen Chenney  <schenney@chromium.org>
65
66         Unreviewed.  Rolled Chromium DEPS to last-known good revision. Really this time.
67
68         * DEPS: 181594
69
70 2013-02-09  Sheriff Bot  <webkit.review.bot@gmail.com>
71
72         Unreviewed.  Rolled Chromium DEPS to last-known good revision.
73         Requested by "Stephen Chenney" <schenney@chromium.org> via
74         sheriffbot.
75
76         * DEPS:
77
78 2013-02-08  Kent Tamura  <tkent@chromium.org>
79
80         [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
81         https://bugs.webkit.org/show_bug.cgi?id=109272
82
83         Reviewed by Kentaro Hara.
84
85         We enabled this flag for desktop Chromium, but disabled the feature by a
86         runtime flag. We disables the compile flag too because we have no plan
87         to ship it in near future.
88
89         * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
90
91 2013-02-08  Stephen Chenney  <schenney@chromium.org>
92
93         Remove Skia code suppressions
94
95         Unreviewed enabling of existing optimizations
96
97         Removing all skia_webkit.gyp code suppressions and adding expectations
98         for the failures.
99
100         * skia_webkit.gyp:
101
102 2013-02-08  Dan Carney  <dcarney@google.com>
103
104         [v8] isolate parameter added to all v8::peristent calls
105         https://bugs.webkit.org/show_bug.cgi?id=109268
106
107         Reviewed by Kentaro Hara.
108
109         * tests/WebFrameTest.cpp:
110
111 2013-02-07  Kent Tamura  <tkent@chromium.org>
112
113         [Chromium-Android] Disable input[type=datetime]
114         https://bugs.webkit.org/show_bug.cgi?id=107614
115
116         Reviewed by Kentaro Hara.
117
118         Reason:
119         http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
120
121         * features.gypi:
122         Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
123         We enable it for non-Android ports but the runtime flag for it is
124         disabled by default. The runtime flag is enabled only in DumpRenderTree.
125
126 2013-02-07  Terry Anderson  <tdanderson@chromium.org>
127
128         [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
129         https://bugs.webkit.org/show_bug.cgi?id=108719
130
131         Reviewed by Eric Seidel.
132
133         In the event of a main-thread touch fling, dispatch a series of
134         GestureScrollUpdateWithoutPropagation events defined in
135         https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
136         GestureScrollUpdate events) so that the fling does not
137         propagate to enclosing scrollables.
138
139         * src/WebViewImpl.cpp:
140         (WebKit::WebViewImpl::scrollBy):
141
142 2013-02-07  Kent Tamura  <tkent@chromium.org>
143
144         [Chromium] Add a flag to enable native form validation message
145         https://bugs.webkit.org/show_bug.cgi?id=109134
146
147         Reviewed by Adam Barth.
148
149         * public/WebRuntimeFeatures.h:
150         (WebRuntimeFeatures): Add enableNativeValidationMessage and
151         isNativeValidationMessageEnabled.
152         * src/WebRuntimeFeatures.cpp:
153         (WebKit): Add nativeValidationMessageEnabled.
154         (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
155         (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
156         * src/WebViewImpl.cpp:
157         (WebKit::WebViewImpl::WebViewImpl):
158         Fill Page::PageClients::validationMessageClient if the flag is true.
159
160 2013-02-07  Eberhard Graether  <egraether@google.com>
161
162         Web Inspector: Add settings checkbox for composited layer borders
163         https://bugs.webkit.org/show_bug.cgi?id=109096
164
165         Reviewed by Pavel Feldman.
166
167         This change adds a checkbox to show composited layer borders to the WebInspector's
168         rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
169         is visible if InspectorClient::canShowDebugBorders() returns true.
170
171         * src/InspectorClientImpl.cpp:
172         (WebKit::InspectorClientImpl::canShowDebugBorders):
173         (WebKit):
174         (WebKit::InspectorClientImpl::setShowDebugBorders):
175         * src/InspectorClientImpl.h:
176         (InspectorClientImpl):
177         * src/WebViewImpl.cpp:
178         (WebKit::WebViewImpl::WebViewImpl):
179         (WebKit::WebViewImpl::setShowDebugBorders):
180         (WebKit):
181         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
182         * src/WebViewImpl.h:
183
184 2013-02-07  Stephen White  <senorblanco@chromium.org>
185
186         Unreviewed.  Rolled DEPS.
187
188         * DEPS:
189
190 2013-02-07  David Trainor  <dtrainor@chromium.org>
191
192         Add null check to editable in moveCaretSelectionTowardsWindowPoint
193         https://bugs.webkit.org/show_bug.cgi?id=108962
194
195         Reviewed by Eric Seidel.
196
197         * src/WebFrameImpl.cpp:
198         (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
199         * tests/WebFrameTest.cpp:
200
201 2013-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>
202
203         Unreviewed.  Rolled Chromium DEPS to r180752.  Requested by
204         thakis_ via sheriffbot.
205
206         * DEPS:
207
208 2013-02-06  Terry Anderson  <tdanderson@chromium.org>
209
210         Add support for gesture scroll events that do not propagate to enclosing scrollables
211         https://bugs.webkit.org/show_bug.cgi?id=108849
212
213         Reviewed by Antonio Gomes.
214
215         Define the new event type GestureScrollUpdateWithoutPropagation.
216
217         * public/WebInputEvent.h:
218         (WebKit::WebInputEvent::isGestureEventType):
219         * src/PageWidgetDelegate.cpp:
220         (WebKit::PageWidgetDelegate::handleInputEvent):
221         * src/WebInputEventConversion.cpp:
222         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
223         * src/WebPluginContainerImpl.cpp:
224         * src/WebPopupMenuImpl.cpp:
225         (WebKit::WebPopupMenuImpl::handleInputEvent):
226         * src/WebViewImpl.cpp:
227         (WebKit::WebViewImpl::handleGestureEvent):
228
229 2013-02-06  Alexandre Elias  <aelias@chromium.org>
230
231         Make ScrollView::paint() clip by visibleContentRect
232         https://bugs.webkit.org/show_bug.cgi?id=108888
233
234         Reviewed by Levi Weintraub.
235
236         When applyPageScaleFactorInCompositor or fixedVisibleContentRect
237         are used, frameRect() and visibleContentRect(true).size() are
238         no longer synonyms, and the latter is the one that should be
239         used for clipping paints.
240
241         New WebFrameTest: pageScaleFactorScalesPaintClip.
242
243         * tests/WebFrameTest.cpp:
244
245 2013-02-06  Sheriff Bot  <webkit.review.bot@gmail.com>
246
247         Unreviewed, rolling out r142025.
248         http://trac.webkit.org/changeset/142025
249         https://bugs.webkit.org/show_bug.cgi?id=109091
250
251         broke the build (Requested by tdanderson on #webkit).
252
253         * public/WebInputEvent.h:
254         (WebKit::WebInputEvent::isGestureEventType):
255         * src/PageWidgetDelegate.cpp:
256         (WebKit::PageWidgetDelegate::handleInputEvent):
257         * src/WebInputEventConversion.cpp:
258         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
259         * src/WebPluginContainerImpl.cpp:
260         * src/WebPopupMenuImpl.cpp:
261         (WebKit::WebPopupMenuImpl::handleInputEvent):
262         * src/WebViewImpl.cpp:
263         (WebKit::WebViewImpl::handleGestureEvent):
264
265 2013-02-06  Daniel Cheng  <dcheng@google.com>
266
267         [chromium] Remove "config.h" header from WebUnitTests.cpp
268         https://bugs.webkit.org/show_bug.cgi?id=108966
269
270         Reviewed by Tony Chang.
271
272         This file includes headers from base/ in Chromium, and config.h
273         conflicts with base/logging.h. Rather than teaching certain files in
274         base/ not to #include base/logging.h, remove the config.h include
275         here. The ASSERT isn't really necessary, as attempting to run a null
276         test suite won't go very far anyway.
277
278         * tests/WebUnitTests.cpp:
279         (WebKit::RunAllUnitTests):
280
281 2013-02-06  Terry Anderson  <tdanderson@chromium.org>
282
283         Add support for gesture scroll events that do not propagate to enclosing scrollables
284         https://bugs.webkit.org/show_bug.cgi?id=108849
285
286         Reviewed by Antonio Gomes.
287
288         Define the new event type GestureScrollUpdateWithoutPropagation.
289
290         * public/WebInputEvent.h:
291         (WebKit::WebInputEvent::isGestureEventType):
292         * src/PageWidgetDelegate.cpp:
293         (WebKit::PageWidgetDelegate::handleInputEvent):
294         * src/WebInputEventConversion.cpp:
295         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
296         * src/WebPluginContainerImpl.cpp:
297         * src/WebPopupMenuImpl.cpp:
298         (WebKit::WebPopupMenuImpl::handleInputEvent):
299         * src/WebViewImpl.cpp:
300         (WebKit::WebViewImpl::handleGestureEvent):
301
302 2013-02-06  Chris Hopman  <cjhopman@chromium.org>
303
304         [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
305         https://bugs.webkit.org/show_bug.cgi?id=108667
306
307         Reviewed by Darin Fisher.
308
309         WebWidget::selectionBounds() returns the anchor and focus of the
310         selection. This matches the arguments to WebFrame::selectRange().
311         Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
312         anchor/focus to start/end.
313
314         * public/WebWidget.h:
315         (WebWidget):
316         (WebKit::WebWidget::isSelectionAnchorFirst):
317         * src/WebViewImpl.cpp:
318         (WebKit::WebViewImpl::isSelectionAnchorFirst):
319         (WebKit):
320         * src/WebViewImpl.h:
321         * tests/WebViewTest.cpp:
322
323 2013-02-06  Alec Flett  <alecflett@chromium.org>
324
325         IndexedDB: Stub out SharedBuffer version of put()
326         https://bugs.webkit.org/show_bug.cgi?id=108986
327
328         Reviewed by Darin Fisher.
329
330         This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
331
332         * public/WebIDBDatabase.h:
333         (WebKit):
334         (WebKit::WebIDBDatabase::put):
335
336 2013-02-06  Stephen Chenney  <schenney@chromium.org>
337
338         Add Skia code suppression flags to WebKit skia.gyp
339
340         Unreviewed.
341
342         This is step one in removing these flags. First we get them into
343         WebKit, then we can remove them from Chrome.
344
345         * skia_webkit.gyp:
346
347 2013-02-06  Mike West  <mkwst@chromium.org>
348
349         Add an ENABLE_NOSNIFF feature flag.
350         https://bugs.webkit.org/show_bug.cgi?id=109029
351
352         Reviewed by Jochen Eisinger.
353
354         This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
355         when processing script and other resource types.
356
357         * features.gypi:
358
359 2013-02-05  David Dorwin  <ddorwin@chromium.org>
360
361         [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
362         https://bugs.webkit.org/show_bug.cgi?id=108989
363
364         Reviewed by Kent Tamura.
365
366         * src/WebMediaPlayerClientImpl.cpp:
367         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
368
369 2013-02-04  Kentaro Hara  <haraken@chromium.org>
370
371         [V8] Reduce usage of deprecatedString() and deprecatedInteger()
372         https://bugs.webkit.org/show_bug.cgi?id=108909
373
374         Reviewed by Adam Barth.
375
376         No tests. No change in behavior.
377
378         * src/WebBindings.cpp:
379         (WebKit::WebBindings::toV8Value):
380
381 2013-02-05  Kentaro Hara  <haraken@chromium.org>
382
383         [V8] Make an Isolate parameter mandatory in HasInstance()
384         https://bugs.webkit.org/show_bug.cgi?id=108917
385
386         Reviewed by Adam Barth.
387
388         Because these methods do not have an Isolate, we have to call
389         v8::Isolate::GetCurrent().
390
391         No tests. No change in behavior.
392
393         * src/WebArrayBuffer.cpp:
394         (WebKit::WebArrayBuffer::createFromV8Value):
395         * src/WebArrayBufferView.cpp:
396         (WebKit::WebArrayBufferView::createFromV8Value):
397         * src/WebBindings.cpp:
398         (WebKit::getRangeImpl):
399         (WebKit::getNodeImpl):
400         (WebKit::getElementImpl):
401         (WebKit::getArrayBufferImpl):
402         (WebKit::getArrayBufferViewImpl):
403         (WebKit::WebBindings::getRange):
404         (WebKit::WebBindings::getArrayBuffer):
405         (WebKit::WebBindings::getArrayBufferView):
406         (WebKit::WebBindings::getNode):
407         (WebKit::WebBindings::getElement):
408
409 2013-02-05  Dana Jansens  <danakj@chromium.org>
410
411         [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
412         https://bugs.webkit.org/show_bug.cgi?id=107776
413
414         Reviewed by James Robinson.
415
416         * WebKit.gyp:
417         * src/WebGraphicsContext3D.cpp: Removed.
418
419 2013-02-05  Mark Lam  <mark.lam@apple.com>
420
421         Introduced back-end database classes + a few small fixes.
422         https://bugs.webkit.org/show_bug.cgi?id=108759.
423
424         Reviewed by Brady Eidson.
425
426         * src/DatabaseObserver.cpp:
427         (WebCore::DatabaseObserver::databaseOpened):
428         (WebCore::DatabaseObserver::databaseModified):
429         (WebCore::DatabaseObserver::databaseClosed):
430
431 2013-02-05  Adam Barth  <abarth@webkit.org>
432
433         DumpRenderTree should be able to enable the threaded parser
434         https://bugs.webkit.org/show_bug.cgi?id=108970
435
436         Reviewed by Eric Seidel.
437
438         * public/WebSettings.h:
439         * src/WebSettingsImpl.cpp:
440         (WebKit::WebSettingsImpl::setThreadedHTMLParser):
441         (WebKit):
442         * src/WebSettingsImpl.h:
443         (WebSettingsImpl):
444
445 2013-02-05  Sami Kyostila  <skyostil@chromium.org>
446
447         [chromium] Make overlay layers slow-scrolling
448         https://bugs.webkit.org/show_bug.cgi?id=108957
449
450         Reviewed by James Robinson.
451
452         Since overlay layers get inserted on top of everything else, we must
453         mark them slow-scrolling to prevent all scroll input events to the rest
454         of the page from getting blocked. This is also more correct because
455         generally the overlay contents need to be repainted whenever the scroll
456         offset changes, and with this patch the painting happens in sync with
457         page scrolling.
458
459 2013-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
460
461         Unreviewed, rolling out r141896.
462         http://trac.webkit.org/changeset/141896
463         https://bugs.webkit.org/show_bug.cgi?id=108956
464
465         crashes indexdb security tests (Requested by gavinp on
466         #webkit).
467
468         * public/platform/WebKitPlatformSupport.h:
469         (WebKit):
470         (WebKitPlatformSupport):
471         (WebKit::WebKitPlatformSupport::idbFactory):
472         * src/IDBFactoryBackendProxy.cpp:
473         (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
474
475 2013-02-05  Mark Pilgrim  <pilgrim@chromium.org>
476
477         [Chromium] Remove idbFactory from WebKitPlatformSupport
478         https://bugs.webkit.org/show_bug.cgi?id=106457
479
480         Reviewed by Adam Barth.
481
482         Now that https://codereview.chromium.org/12181010/ has landed, the
483         idbFactory method is no longer needed. (Embedders must now call
484         the new setIDBFactory method upon initialization.) Part of a
485         larger refactoring series; see tracking bug 82948.
486
487         * public/platform/WebKitPlatformSupport.h:
488         (WebKit):
489         * src/IDBFactoryBackendProxy.cpp:
490         (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
491
492 2013-02-05  Kentaro Hara  <haraken@chromium.org>
493
494         Unreviewed, rolling out r141865.
495         http://trac.webkit.org/changeset/141865
496         https://bugs.webkit.org/show_bug.cgi?id=108909
497
498         webkit unit tests are broken
499
500         * src/WebBindings.cpp:
501         (WebKit::WebBindings::toV8Value):
502
503 2013-02-05  Kentaro Hara  <haraken@chromium.org>
504
505         [V8] Reduce usage of deprecatedString() and deprecatedInteger()
506         https://bugs.webkit.org/show_bug.cgi?id=108909
507
508         Reviewed by Adam Barth.
509
510         No tests. No change in behavior.
511
512         * src/WebBindings.cpp:
513         (WebKit::WebBindings::toV8Value):
514
515 2013-02-04  Sheriff Bot  <webkit.review.bot@gmail.com>
516
517         Unreviewed.  Rolled Chromium DEPS to r180583.  Requested by
518         "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
519
520         * DEPS:
521
522 2013-02-04  James Simonsen  <simonjam@chromium.org>
523
524         [Chromium] Add a signal for when the body is inserted in the document
525         https://bugs.webkit.org/show_bug.cgi?id=108725
526
527         Reviewed by Adam Barth.
528
529         * public/WebFrameClient.h:
530         (WebFrameClient):
531         (WebKit::WebFrameClient::willInsertBody):
532         * src/FrameLoaderClientImpl.cpp:
533         (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
534         (WebKit):
535         * src/FrameLoaderClientImpl.h:
536         (FrameLoaderClientImpl):
537         * tests/WebFrameTest.cpp:
538
539 2013-02-04  Chris Hopman  <cjhopman@chromium.org>
540
541         Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
542         https://bugs.webkit.org/show_bug.cgi?id=107850
543
544         Reviewed by Ojan Vafai.
545
546         On Android, EditingBehavior::shouldMoveCaret[...] controls the
547         behavior of insertion handles. This change adds a new Android specific
548         editing behavior type so that we can change these settings independent
549         of behavior for other platforms.
550
551         * public/WebSettings.h:
552         * src/AssertMatchingEnums.cpp:
553         Just add the corresponding assertion for the new editing behavior.
554
555         * public/WebSettings.h:
556         * src/AssertMatchingEnums.cpp:
557
558         * tests/WebFrameTest.cpp:
559         * tests/data/move_caret.html: Added.
560         Add a test that moveCaretTowardsWindowPoint works as expected on
561         Android.
562
563 2013-01-31  Kentaro Hara  <haraken@chromium.org>
564
565         Implement WheelEvent::deltaMode
566         https://bugs.webkit.org/show_bug.cgi?id=108455
567
568         Reviewed by Adam Barth.
569
570         * src/WebInputEventConversion.cpp:
571         (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
572
573 2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>
574
575         [Chromium] Move WorkerContextProxy to WebCore
576         https://bugs.webkit.org/show_bug.cgi?id=108847
577
578         Reviewed by Adam Barth.
579
580         Part of a larger refactoring series; see tracking bug 106829.
581
582         * WebKit.gyp:
583         * src/WebKit.cpp:
584         (WebKit::initializeWithoutV8):
585         * src/WorkerContextProxy.cpp: Removed.
586
587 2013-02-04  Abhishek Arya  <inferno@chromium.org>
588
589         Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
590         https://bugs.webkit.org/show_bug.cgi?id=108668
591
592         Reviewed by Eric Seidel.
593
594         * src/ContextFeaturesClientImpl.cpp:
595         (WebKit::ContextFeaturesCache::entryFor):
596         * src/WebFrameImpl.cpp:
597         (WebKit::WebFrameImpl::selectFindMatch):
598
599 2013-02-04  Mark Pilgrim  <pilgrim@chromium.org>
600
601         [Chromium] Move IDBFactoryBackendInterface to WebCore
602         https://bugs.webkit.org/show_bug.cgi?id=108638
603
604         Reviewed by Adam Barth.
605
606         Part of a larger refactoring series; see tracking bug 106829.
607
608         * WebKit.gyp:
609         * src/AssertMatchingEnums.cpp:
610         * src/IDBFactoryBackendInterface.cpp: Removed.
611         * src/IDBFactoryBackendProxy.h:
612         * src/WebKit.cpp:
613         (WebKit::initializeWithoutV8):
614
615 2013-02-04  Abhishek Arya  <inferno@chromium.org>
616
617         Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
618         https://bugs.webkit.org/show_bug.cgi?id=108688
619
620         Reviewed by Eric Seidel.
621
622         * src/IDBFactoryBackendProxy.cpp:
623         (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
624         (WebKit::getWebFrame):
625         * src/LocalFileSystemChromium.cpp:
626         (WebCore::LocalFileSystem::deleteFileSystem):
627         * src/WebSharedWorkerImpl.cpp:
628         (WebKit::WebSharedWorkerImpl::connectTask):
629         (WebKit::resumeWorkerContextTask):
630         (WebKit::connectToWorkerContextInspectorTask):
631         (WebKit::reconnectToWorkerContextInspectorTask):
632         (WebKit::disconnectFromWorkerContextInspectorTask):
633         (WebKit::dispatchOnInspectorBackendTask):
634
635 2013-02-04  Sami Kyostila  <skyostil@chromium.org>
636
637         Disable -webkit-overflow-scrolling CSS attribute on Chromium
638         https://bugs.webkit.org/show_bug.cgi?id=108020
639
640         Reviewed by James Robinson.
641
642         Now that we can automatically promote overflow elements to accelerated
643         scrolling layers there is no use for the -webkit-overflow-scrolling CSS
644         attribute any longer on Chromium.
645
646         This patch enables composited overflow scrolling in
647         ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
648         in non-fast-scrollable.html to become composited, we also need to modify that
649         test to opt it out of composited scrolling.
650
651         * features.gypi:
652         * tests/ScrollingCoordinatorChromiumTest.cpp:
653         (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
654         (WebKit::TEST_F):
655         * tests/data/non-fast-scrollable.html:
656         * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
657
658 2013-02-03  KwangYong Choi  <ky0.choi@samsung.com>
659
660         Fix build warning after r141473
661         https://bugs.webkit.org/show_bug.cgi?id=108782
662
663         Reviewed by Kentaro Hara.
664
665         Fix -Wunused-parameter build warning.
666
667         * src/EditorClientImpl.cpp:
668         (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
669
670 2013-02-03  David Dorwin  <ddorwin@chromium.org>
671
672         [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
673         https://bugs.webkit.org/show_bug.cgi?id=108740
674
675         Reviewed by Kent Tamura.
676
677         The calls to m_widgetClient->show() and setFocus() do not appear to be
678         necessary, and the former causes problems on at least on platform.
679
680         * src/WebHelperPluginImpl.cpp:
681         (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
682         (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
683
684 2013-02-02  Michael Nordman  <michaeln@google.com>
685
686         [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
687         This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
688         sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
689         in place and in use.
690         https://bugs.webkit.org/show_bug.cgi?id=108736
691
692         Reviewed by Darin Fisher.
693
694         * public/WebFileSystemCallbacks.h:
695         (WebFileSystemCallbacks):
696         (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
697
698 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
699
700         Unreviewed.  Rolled Chromium DEPS to r180221.  Requested by
701         "Nico Weber" <thakis@chromium.org> via sheriffbot.
702
703         * DEPS:
704
705 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
706
707         Unreviewed.  Rolled Chromium DEPS to r180186.  Requested by
708         "Nico Weber" <thakis@chromium.org> via sheriffbot.
709
710         * DEPS:
711
712 2013-02-01  Chris Hopman  <cjhopman@chromium.org>
713
714         [Chromium] WebWidget::selectionBounds should return the bounds in document space
715         https://bugs.webkit.org/show_bug.cgi?id=108386
716
717         Reviewed by James Robinson.
718
719         When in applyPageScaleFactorInCompositor mode, selectionBounds needs
720         to scale the anchor/focus window points by the pageScaleFactor.
721
722         * src/WebViewImpl.cpp:
723         (WebKit::WebViewImpl::selectionBounds):
724         (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
725
726 2013-02-01  Dominic Mazzoni  <dmazzoni@google.com>
727
728         AX: memoize expensive computation during blocks where tree doesn't change
729         https://bugs.webkit.org/show_bug.cgi?id=106497
730
731         Reviewed by Ryosuke Niwa.
732
733         Expose two methods to enable and disable caching of
734         computed WebAccessibilityObject attributes, to speed up
735         batch read-only operations.
736
737         * public/WebAccessibilityObject.h:
738         (WebAccessibilityObject):
739         * src/WebAccessibilityObject.cpp:
740         (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
741         (WebKit):
742         (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
743
744 2013-02-01  Fady Samuel  <fsamuel@chromium.org>
745
746         [Chromium] Expose WebNode::shadowHost()
747         https://bugs.webkit.org/show_bug.cgi?id=108681
748
749         Reviewed by Dimitri Glazkov.
750
751         BrowserPlugin needs to be able to check the event listeners attached to
752         <webview> and so we expose shadowHost to permit it to poke at the webview
753         node.
754
755         * public/WebNode.h:
756         * src/WebNode.cpp:
757         (WebKit::WebNode::shadowHost):
758         (WebKit):
759
760 2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
761
762         [Chromium] Ignore punctuation in spellcheck
763         https://bugs.webkit.org/show_bug.cgi?id=108511
764
765         Reviewed by Tony Chang.
766
767         * src/ContextMenuClientImpl.cpp:
768         (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
769         (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
770
771 2013-02-01  Philip Rogers  <pdr@google.com>
772
773         Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
774         https://bugs.webkit.org/show_bug.cgi?id=106966
775
776         Reviewed by Stephen White.
777
778         * tests/DragImageTest.cpp:
779         (WebCore::TestImage::currentFrameKnownToBeOpaque):
780         (TestImage):
781         * tests/ImageLayerChromiumTest.cpp:
782         (WebCore::TestImage::currentFrameKnownToBeOpaque):
783         * tests/PlatformContextSkiaTest.cpp:
784         (WebCore::TEST):
785
786 2013-02-01  Nico Weber  <thakis@chromium.org>
787
788         [chromium] Build webkit with enable_web_intents set to 0.
789         https://bugs.webkit.org/show_bug.cgi?id=108408
790
791         Reviewed by Tony Chang.
792
793         I'll then make chromium build fine with that, then switch
794         enable_web_intents to 0, roll that into webkit, and then
795         actually remove the code hidden behind this flag.
796
797         The features.gypi bit depends on https://codereview.chromium.org/12143002/
798         and will disable web intents support on android. Since common.gypi
799         sets enable_web_intents to 0 explicitly, it seems this is currently on
800         by accident anyway.
801
802         While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
803         features.gypi completely, it's still set further down the file if
804         enable_web_intents is on.
805
806         * WebKit.gyp:
807         * features.gypi:
808         * src/WebFrameImpl.cpp:
809
810 2013-02-01  Rouslan Solomakhin  <rouslan@chromium.org>
811
812         [Chromium] Ignore whitespace in spellcheck
813         https://bugs.webkit.org/show_bug.cgi?id=108510
814
815         Reviewed by Ryosuke Niwa.
816
817         * src/ContextMenuClientImpl.cpp:
818         (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
819
820 2013-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
821
822         Unreviewed.  Rolled Chromium DEPS to r180131.  Requested by
823         "Florin Malita" <fmalita@chromium.org> via sheriffbot.
824
825         * DEPS:
826
827 2013-02-01  Alexis Menard  <alexis@webkit.org>
828
829         Enable unprefixed CSS transitions by default.
830         https://bugs.webkit.org/show_bug.cgi?id=108216
831
832         Reviewed by Dean Jackson.
833
834         Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
835         to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to 
836         guard the unprefixing work for CSS Transforms and animations.
837
838         * features.gypi:
839
840 2013-02-01  Ken Kania  <kkania@chromium.org>
841
842         Web Inspector: Add support for handling modal dialogs
843         https://bugs.webkit.org/show_bug.cgi?id=107883
844
845         Reviewed by Pavel Feldman.
846
847         Introduce support for being notified when a JavaScript modal dialog
848         is opening and closing, as well as a new command for accepting or
849         dismissing the dialog.
850
851         * public/WebDevToolsAgent.h:
852         * src/InspectorClientImpl.cpp:
853         (WebKit::InspectorClientImpl::handleJavaScriptDialog):
854         (WebKit):
855         * src/InspectorClientImpl.h:
856         (InspectorClientImpl):
857         * src/WebDevToolsAgentImpl.cpp:
858         (BrowserDataHintStringValues):
859         (WebKit::WebDevToolsAgentImpl::captureScreenshot):
860         (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
861         (WebKit):
862         (WebKit::browserHintToString):
863         (WebKit::browserHintFromString):
864         (WebKit::WebDevToolsAgent::patchWithBrowserData):
865         * src/WebDevToolsAgentImpl.h:
866         (WebDevToolsAgentImpl):
867
868 2013-02-01  Dan Alcantara  <dfalcantara@chromium.org>
869
870         Touch disambiguation blacklist is not being queried properly
871         https://bugs.webkit.org/show_bug.cgi?id=108222
872
873         Reviewed by Adam Barth.
874
875         TEST=WebFrameTest::DisambiguationPopupBlacklist
876
877         Fix the blacklist so that we check it for the right nodes.
878         Add a test to check that the blacklist is being built and used
879         correctly.  Also update the other DisambiguationPopup tests to
880         use the new page scale method.
881
882         * tests/WebFrameTest.cpp:
883         * tests/data/disambiguation_popup_blacklist.html: Added.
884
885 2013-02-01  Eberhard Graether  <egraether@google.com>
886
887         [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
888         https://bugs.webkit.org/show_bug.cgi?id=108236
889
890         Reviewed by Pavel Feldman.
891
892         This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
893         This way the checkboxes only show up for users that can make use of these features.
894
895         * src/InspectorClientImpl.cpp:
896         (WebKit::InspectorClientImpl::canShowFPSCounter):
897         (WebKit::InspectorClientImpl::canContinuouslyPaint):
898
899 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
900
901         Editor::m_compositionNode not updated on HTMLInputElement::setValue()
902         https://bugs.webkit.org/show_bug.cgi?id=107737
903
904         Reviewed by Ryosuke Niwa.
905
906         * public/WebViewClient.h:
907         (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
908             Adding a callback to let the WebViewClient know that the composition has been cancelled.
909         * src/EditorClientImpl.cpp:
910         (WebKit::EditorClientImpl::respondToChangedSelection):
911             Adding a call composition if it is no longer valid.
912
913 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
914
915         [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
916         https://bugs.webkit.org/show_bug.cgi?id=108543
917
918         Reviewed by Ryosuke Niwa.
919
920         Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
921
922         * src/WebViewImpl.cpp:
923         (WebKit::WebViewImpl::setCompositionFromExistingText):
924         * tests/WebViewTest.cpp:
925             Re-enabling the test
926
927 2013-01-31  Hajime Morrita  <morrita@google.com> 
928
929         Unreviewed, followup fix for r141535.
930
931         * tests/WebFrameTest.cpp:
932
933 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
934
935         Unreviewed.  Rolled Chromium DEPS to r180023.  Requested by
936         thakis_ via sheriffbot.
937
938         * DEPS:
939
940 2013-01-31  Hajime Morrita  <morrita@google.com>
941
942         Unreviewed, disabling failing test.
943
944         * tests/WebFrameTest.cpp:
945
946 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
947
948         Unreviewed, rolling out r141479.
949         http://trac.webkit.org/changeset/141479
950         https://bugs.webkit.org/show_bug.cgi?id=108564
951
952         breaks chromium test (Requested by morrita on #webkit).
953
954         * public/WebViewClient.h:
955         * src/EditorClientImpl.cpp:
956         (WebKit::EditorClientImpl::respondToChangedSelection):
957
958 2013-01-31  Alec Flett  <alecflett@chromium.org>
959
960         IndexedDB: remove old transaction backend bootstrap code
961         https://bugs.webkit.org/show_bug.cgi?id=103923
962
963         Reviewed by Dimitri Glazkov.
964
965         Remove all deprecated WebKit APIs from
966         the IDB backend.
967
968         * WebKit.gyp:
969         * public/WebIDBCallbacks.h:
970         (WebKit):
971         * public/WebIDBDatabase.h:
972         (WebKit):
973         * public/WebIDBTransaction.h: Removed.
974         * public/WebIDBTransactionCallbacks.h: Removed.
975         * src/AssertMatchingEnums.cpp:
976         * src/IDBCallbacksProxy.cpp:
977         * src/IDBDatabaseBackendProxy.cpp:
978         * src/IDBDatabaseBackendProxy.h:
979         (IDBDatabaseBackendProxy):
980         * src/IDBTransactionBackendProxy.cpp: Removed.
981         * src/IDBTransactionBackendProxy.h: Removed.
982         * src/IDBTransactionCallbacksProxy.cpp: Removed.
983         * src/IDBTransactionCallbacksProxy.h: Removed.
984         * src/WebIDBCallbacksImpl.cpp:
985         * src/WebIDBDatabaseImpl.cpp:
986         (WebKit):
987         * src/WebIDBDatabaseImpl.h:
988         (WebKit):
989         (WebIDBDatabaseImpl):
990         * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
991         * src/WebIDBTransactionCallbacksImpl.h: Removed.
992         * src/WebIDBTransactionImpl.cpp: Removed.
993         * src/WebIDBTransactionImpl.h: Removed.
994         * tests/IDBAbortOnCorruptTest.cpp:
995         * tests/IDBDatabaseBackendTest.cpp:
996
997 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
998
999         [Chromium] Select multi-word misspelling on context click
1000         https://bugs.webkit.org/show_bug.cgi?id=108509
1001
1002         Reviewed by Tony Chang.
1003
1004         * src/ContextMenuClientImpl.cpp:
1005         (WebKit):
1006         (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
1007         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
1008
1009 2013-01-31  Florin Malita  <fmalita@chromium.org>
1010
1011         [Chromium] Unreviewed gardening.
1012
1013         WebViewTest.SetCompositionFromExistingText failing after r141479.
1014
1015         * tests/WebViewTest.cpp:
1016
1017 2013-01-31  Alexandre Elias  <aelias@chromium.org>
1018
1019         [chromium] Rework page scale factor limits initialization
1020         https://bugs.webkit.org/show_bug.cgi?id=108446
1021
1022         Reviewed by James Robinson.
1023
1024         When loading a page with viewportEnabled, both the limits
1025         specified by the viewport tag and the content width need to be
1026         considered before we initialize the minimum page scale (and
1027         pageScaleFactor itself usually to the same value). The timing has
1028         proven tricky to get correct.
1029
1030         This patch simplifies the flow by computing the
1031         limits only at the end of layouts and at no other time. In combination
1032         with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
1033         needsLayout() appropriately, this results in a more robust and easy
1034         to understand sequence.
1035
1036         Fixes FixedLayoutInitializeAtMinimumPageScale test.
1037
1038         * src/ChromeClientImpl.cpp:
1039         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1040         * src/WebViewImpl.cpp:
1041         (WebKit::WebViewImpl::WebViewImpl):
1042         (WebKit::WebViewImpl::resize):
1043         (WebKit::WebViewImpl::setPageScaleFactorLimits):
1044         (WebKit::WebViewImpl::computePageScaleFactorLimits):
1045         (WebKit::WebViewImpl::layoutUpdated):
1046         (WebKit::WebViewImpl::didChangeContentsSize):
1047         * src/WebViewImpl.h:
1048         (WebKit::WebViewImpl::setInitialPageScaleFactor):
1049         (WebViewImpl):
1050         * tests/WebFrameTest.cpp:
1051
1052 2013-01-31  Aurimas Liutikas  <aurimas@chromium.org>
1053
1054         Editor::m_compositionNode not updated on HTMLInputElement::setValue()
1055         https://bugs.webkit.org/show_bug.cgi?id=107737
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         * public/WebViewClient.h:
1060         (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
1061             Adding a callback to let the WebViewClient know that the composition has been cancelled.
1062         * src/EditorClientImpl.cpp:
1063         (WebKit::EditorClientImpl::respondToChangedSelection):
1064             Adding a call composition if it is no longer valid.
1065
1066 2013-01-31  Mark Pilgrim  <pilgrim@chromium.org>
1067
1068         [Chromium] Move LocalizedStrings to WebCore
1069         https://bugs.webkit.org/show_bug.cgi?id=108488
1070
1071         Reviewed by Adam Barth.
1072
1073         Part of a larger refactoring series; see tracking bug 106829.
1074
1075         * WebKit.gyp:
1076         * src/LocalizedStrings.cpp: Removed.
1077
1078 2013-01-31  Enrica Casucci  <enrica@apple.com>
1079
1080         WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
1081         https://bugs.webkit.org/show_bug.cgi?id=108396.
1082         <rdar://problem/12920461>
1083
1084         Reviewed by Alexey Proskuryakov.
1085
1086         Adds stub implementation for WebKit of the new EditorClient methods.
1087
1088         * src/EditorClientImpl.cpp:
1089         (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
1090         (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
1091         * src/EditorClientImpl.h:
1092
1093 2013-01-31  Chris Hopman  <cjhopman@chromium.org>
1094
1095         [chromium] Make selection handling work in applyPageScaleInCompositor mode
1096         https://bugs.webkit.org/show_bug.cgi?id=107831
1097
1098         Reviewed by Ryosuke Niwa.
1099
1100         These functions expect a window point. When in
1101         applyPageScaleFactorInCompositor mode, the points need to be unscaled
1102         by the page scale factor.
1103
1104         * src/WebFrameImpl.cpp:
1105         (WebKit::WebFrameImpl::selectRange):
1106         (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
1107
1108 2013-01-31  Tom Sepez  <tsepez@chromium.org>
1109
1110         [v8] Enable binding integrity on mac
1111         https://bugs.webkit.org/show_bug.cgi?id=108500
1112
1113         Reviewed by Adam Barth.
1114
1115         Patch is correct if existing tests pass without new crashes.
1116         
1117         * features.gypi:
1118         Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
1119
1120 2013-01-31  Dan Alcantara  <dfalcantara@chromium.org>
1121
1122         WebFrameTest.DisambiguationPopup is failing
1123         https://bugs.webkit.org/show_bug.cgi?id=108160
1124
1125         Reviewed by Adam Barth.
1126
1127         Fix the unit test so that it is using the right HTML file.
1128
1129         * tests/WebFrameTest.cpp:
1130
1131 2013-01-31  Tony Chang  <tony@chromium.org>
1132
1133         [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
1134         https://bugs.webkit.org/show_bug.cgi?id=108497
1135
1136         Reviewed by James Robinson.
1137
1138         * WebKitUnitTests.gyp:
1139
1140 2013-01-31  Alexandre Elias  <aelias@chromium.org>
1141
1142         Call FrameView::contentsResized() when setting fixed layout size
1143         https://bugs.webkit.org/show_bug.cgi?id=107922
1144
1145         Reviewed by James Robinson.
1146
1147         In fixed layout mode, we should be calling contentsResized() when the
1148         fixed layout size is changed, but not laying out when the visible
1149         content rect changes.
1150
1151         Previously landed as r140869 but was reverted due to a bug in bundled
1152         Chromium-specific code. This patch includes just the minimum needed in
1153         WebCore.
1154
1155         New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize.  Some
1156         flaky and obsolete tests for the old page scale mode are also deleted.
1157
1158         * tests/WebFrameTest.cpp:
1159
1160 2013-01-31  Tommy Widenflycht  <tommyw@google.com>
1161
1162         [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
1163         https://bugs.webkit.org/show_bug.cgi?id=108458
1164
1165         Reviewed by Adam Barth.
1166
1167         Only renames, no other code changes.
1168
1169         * public/WebMediaStreamRegistry.h:
1170         (WebKit):
1171         (WebMediaStreamRegistry):
1172         * public/WebUserMediaRequest.h:
1173         (WebKit):
1174         (WebUserMediaRequest):
1175         * src/WebMediaStreamRegistry.cpp:
1176         (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
1177         * src/WebUserMediaRequest.cpp:
1178         (WebKit::WebUserMediaRequest::requestSucceeded):
1179
1180 2013-01-31  Alec Flett  <alecflett@chromium.org>
1181
1182         IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
1183         https://bugs.webkit.org/show_bug.cgi?id=108399
1184
1185         Reviewed by Dimitri Glazkov.
1186
1187         Cleanup now that chromium proxies the new signatures through.
1188
1189         * src/IDBCallbacksProxy.cpp:
1190         (WebKit::IDBCallbacksProxy::onSuccess):
1191         (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1192         * src/IDBCallbacksProxy.h:
1193         (IDBCallbacksProxy):
1194         * src/WebIDBCallbacksImpl.cpp:
1195         * src/WebIDBCallbacksImpl.h:
1196         (WebIDBCallbacksImpl):
1197
1198 2013-01-31  James Robinson  <jamesr@chromium.org>
1199
1200         [chromium] Remove dead transitional code from WebViewImpl
1201         https://bugs.webkit.org/show_bug.cgi?id=107889
1202
1203         Reviewed by Adam Barth.
1204
1205         The chromium side of this landed at r178256 and seems stable.
1206
1207         * public/WebWidget.h:
1208         (WebKit::WebWidget::setCompositorSurfaceReady):
1209         * src/WebViewImpl.cpp:
1210         (WebKit::WebViewImpl::WebViewImpl):
1211         (WebKit::WebViewImpl::~WebViewImpl):
1212         (WebKit):
1213         (WebKit::WebViewImpl::setIsTransparent):
1214         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1215         * src/WebViewImpl.h:
1216         * tests/ScrollingCoordinatorChromiumTest.cpp:
1217         (WebKit::FakeWebViewClient::initializeLayerTreeView):
1218         (FakeWebViewClient):
1219         (WebKit::FakeWebViewClient::layerTreeView):
1220         (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
1221         (ScrollingCoordinatorChromiumTest):
1222
1223 2013-01-31  Kentaro Hara  <haraken@chromium.org>
1224
1225         Rename WheelEvent::Granularity to WheelEvent::DeltaMode
1226         https://bugs.webkit.org/show_bug.cgi?id=108434
1227
1228         Reviewed by Ryosuke Niwa.
1229
1230         Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.
1231
1232         Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
1233         https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
1234
1235         No tests. No change in behavior.
1236
1237         * src/WebInputEventConversion.cpp:
1238         (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1239         (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
1240
1241 2013-01-31  Yury Semikhatsky  <yurys@chromium.org>
1242
1243         Unreviewed. Bump Chromium dependency to 179332
1244
1245         * DEPS:
1246
1247 2013-01-31  Mark Pilgrim  <pilgrim@chromium.org>
1248
1249         [Chromium] Move MediaPlayerPrivateChromium to WebCore
1250         https://bugs.webkit.org/show_bug.cgi?id=108415
1251
1252         Reviewed by Adam Barth.
1253
1254         Part of a larger refactoring series; see tracking bug 106829.
1255
1256         * WebKit.gyp:
1257         * src/MediaPlayerPrivateChromium.cpp: Removed.
1258         * src/WebKit.cpp:
1259         (WebKit::initializeWithoutV8): call new setter function in
1260         WebCore::MediaPlayerPrivate
1261
1262 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1263
1264         Unreviewed, rolling out r141358.
1265         http://trac.webkit.org/changeset/141358
1266         https://bugs.webkit.org/show_bug.cgi?id=108421
1267
1268         breaks android builder (Requested by morrita on #webkit).
1269
1270         * WebKit.gyp:
1271         * features.gypi:
1272         * src/WebFrameImpl.cpp:
1273
1274 2013-01-30  Nico Weber  <thakis@chromium.org>
1275
1276         [chromium] Build webkit with enable_web_intents set to 0.
1277         https://bugs.webkit.org/show_bug.cgi?id=108408
1278
1279         Reviewed by Kentaro Hara.
1280
1281         I'll then make chromium build fine with that, then switch
1282         enable_web_intents to 0, roll that into webkit, and then
1283         actually remove the code hidden behind this flag.
1284
1285         * WebKit.gyp:
1286         * features.gypi:
1287         * src/WebFrameImpl.cpp:
1288
1289 2013-01-30  Levi Weintraub  <leviw@chromium.org>
1290
1291         [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
1292         https://bugs.webkit.org/show_bug.cgi?id=108381
1293
1294         Reviewed by James Robinson.
1295
1296         WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
1297         touch events. Some plugins make this request more than once, leading to an imbalance in Document's
1298         touch event handler map, and a stale node pointer when the plugin is destroyed. This change
1299         has WebPluginContainerImpl only add one ref for the plugin at a time.
1300
1301         * src/WebPluginContainerImpl.cpp:
1302         (WebKit::WebPluginContainerImpl::requestTouchEventType):
1303
1304 2013-01-30  Yusuf Ozuysal  <yusufo@google.com>
1305
1306         Start sending scrollType as NonBubblingGesture for flings
1307         https://bugs.webkit.org/show_bug.cgi?id=108372
1308
1309         Reviewed by James Robinson.
1310
1311         * src/WebCompositorInputHandlerImpl.cpp:
1312         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1313
1314 2013-01-30  Tien-Ren Chen  <trchen@chromium.org>
1315
1316         [chromium] Add WebFrame::visibleContentRect()
1317         https://bugs.webkit.org/show_bug.cgi?id=108311
1318
1319         Reviewed by James Robinson.
1320
1321         * public/WebFrame.h:
1322         * src/WebFrameImpl.cpp:
1323         (WebKit::WebFrameImpl::visibleContentRect):
1324         (WebKit):
1325         * src/WebFrameImpl.h:
1326         (WebFrameImpl):
1327
1328 2013-01-30  Kentaro Hara  <haraken@chromium.org>
1329
1330         Implement KeyboardEvent constructor
1331         https://bugs.webkit.org/show_bug.cgi?id=108320
1332
1333         Reviewed by Adam Barth.
1334
1335         Renamed keyboard event constant variables to avoid style errors.
1336
1337         * src/WebInputEventConversion.cpp:
1338         (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1339         * tests/WebInputEventConversionTest.cpp:
1340         * tests/WebInputEventFactoryTestGtk.cpp:
1341
1342 2013-01-30  Kentaro Hara  <haraken@chromium.org>
1343
1344         Implement WheelEvent constructor
1345         https://bugs.webkit.org/show_bug.cgi?id=108303
1346
1347         Reviewed by Adam Barth.
1348
1349         This patch just renames an enum value to avoid style check error.
1350
1351         * src/WebViewImpl.cpp:
1352         (WebKit::WebViewImpl::scrollBy):
1353
1354 2013-01-30  Dana Jansens  <danakj@chromium.org>
1355
1356         [chromium] Add recordRenderingStats to WebSettings
1357         https://bugs.webkit.org/show_bug.cgi?id=108358
1358
1359         Reviewed by James Robinson.
1360
1361         * public/WebSettings.h:
1362         * src/WebSettingsImpl.cpp:
1363         (WebKit::WebSettingsImpl::setRecordRenderingStats):
1364         (WebKit):
1365         * src/WebSettingsImpl.h:
1366         (WebSettingsImpl):
1367         (WebKit::WebSettingsImpl::recordRenderingStats):
1368         * src/WebViewImpl.cpp:
1369         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1370
1371 2013-01-30  Tony Gentilcore  <tonyg@chromium.org>
1372
1373         Fix compile error in WebFrameTest
1374         https://bugs.webkit.org/show_bug.cgi?id=108360
1375
1376         Unreviewed build fix.
1377
1378         Fixes compile error:
1379         ../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
1380
1381         * tests/WebFrameTest.cpp:
1382
1383 2013-01-30  John Knottenbelt  <jknotten@chromium.org>
1384
1385         [Chromium] Fix find in page rects for overflowing content.
1386         https://bugs.webkit.org/show_bug.cgi?id=104924
1387
1388         Reviewed by Julien Chaffraix.
1389
1390         If a div has overflowing content, we should only normalise its
1391         coordinates against the renderview or the containing scrollable block.
1392
1393         TEST=WebFrameTest.FindInPageMatchRects
1394
1395         * src/FindInPageCoordinates.cpp:
1396         (WebKit::enclosingScrollableAncestor):
1397             Helper function to find the enclosing containing block with an overflow clip.
1398         (WebKit::toNormalizedRect):
1399             Pass in the container as an argument.
1400         (WebKit::findInPageRectFromAbsoluteRect):
1401             Compute the container for toNormalizedRect using enclosingScrollableAncestor.
1402         * tests/WebFrameTest.cpp:
1403             Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
1404         * tests/data/find.html:
1405             Add test case for <select> element.
1406         * tests/data/find_in_page_frame.html:
1407             Add test cases:
1408               - Result 15, 16 tests that containing <div> with style float:left and
1409                 height:0px does not impact coordinate normalization.
1410               - Result 17, 18 tests that matches with absolute positioning are normalized containing
1411                 relative positioned block, even if there is a closer parent block with overflow clip.
1412               - Result 19 adds a test case for <select> element.
1413
1414 2013-01-30  Dominik Röttsches  <dominik.rottsches@intel.com>
1415
1416         [HarfBuzz] Remove the HarfBuzz-old code
1417         https://bugs.webkit.org/show_bug.cgi?id=108077
1418
1419         Reviewed by Benjamin Poulain.
1420
1421         Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
1422         won't be a distinction between ng and non-ng HarfBuzz after
1423         removing the old code.
1424
1425         * features.gypi:
1426
1427 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
1428
1429         [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
1430         https://bugs.webkit.org/show_bug.cgi?id=108004
1431         http://code.google.com/p/chromium/issues/detail?id=172416
1432
1433         console.debug triggers a NOTREACHED() assertation in Chromium. This
1434         is because WebCore::MessageLevel contains 5 levels, including debug,
1435         where WebConsoleMessage::Level is missing a "debug" level. Add a
1436         WebConsoleMessage::LevelDebug so that it can get passed up to the
1437         renderer even if it doesn't make use of that now.
1438
1439         Requires another patch to chromium itself to fix chromium bug 172416
1440         but this is a prerequisite.
1441
1442         Also add an enum compile time check to AssertMatchingEnums.cpp,
1443
1444         Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
1445         Reviewed by Jochen Eisinger.
1446
1447         * public/WebConsoleMessage.h:
1448         * src/AssertMatchingEnums.cpp:
1449         * src/WebFrameImpl.cpp:
1450         (WebKit::WebFrameImpl::addMessageToConsole):
1451
1452 2013-01-30  Xianzhu Wang  <wangxianzhu@chromium.org>
1453
1454         [Chromium] Correct zoom for focused node when using compositor scaling
1455         https://bugs.webkit.org/show_bug.cgi?id=107599
1456
1457         Reviewed by Adam Barth.
1458
1459         When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1460         When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1461
1462         Reapply r141153. Added font-size in html to ensure same caret size across platforms.
1463
1464         * src/WebViewImpl.cpp:
1465         (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1466         (WebKit):
1467         (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1468         * src/WebViewImpl.h:
1469         (WebViewImpl):
1470         * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1471         * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1472
1473 2013-01-29  Mark Lam  <mark.lam@apple.com>
1474
1475         Rename AbstractDatabase to DatabaseBackend.
1476         https://bugs.webkit.org/show_bug.cgi?id=108275.
1477
1478         Reviewed by Sam Weinig.
1479
1480         This is a pure rename operation as part of the webdatabase refactoring
1481         effort. There is no semantic change in this patch.
1482
1483         * public/WebDatabase.h:
1484         (WebDatabase):
1485         * src/DatabaseObserver.cpp:
1486         (WebCore::DatabaseObserver::databaseOpened):
1487         (WebCore::DatabaseObserver::databaseModified):
1488         (WebCore::DatabaseObserver::databaseClosed):
1489         (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1490         (WebCore::DatabaseObserver::reportChangeVersionResult):
1491         (WebCore::DatabaseObserver::reportStartTransactionResult):
1492         (WebCore::DatabaseObserver::reportCommitTransactionResult):
1493         (WebCore::DatabaseObserver::reportExecuteStatementResult):
1494         (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1495         * src/WebDatabase.cpp:
1496         (WebKit::WebDatabase::WebDatabase):
1497
1498 2013-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1499
1500         Unreviewed, rolling out r141153.
1501         http://trac.webkit.org/changeset/141153
1502         https://bugs.webkit.org/show_bug.cgi?id=108280
1503
1504         Caused WebFrameTest.DivScrollIntoEditableTest to fail on Mac.
1505         (Requested by keishi on #webkit).
1506
1507         * src/WebViewImpl.cpp:
1508         (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1509         * src/WebViewImpl.h:
1510         (WebViewImpl):
1511         * tests/WebFrameTest.cpp:
1512         * tests/data/get_scale_for_zoom_into_editable_test.html:
1513
1514 2013-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1515
1516         Unreviewed, rolling out r140983.
1517         http://trac.webkit.org/changeset/140983
1518         https://bugs.webkit.org/show_bug.cgi?id=108277
1519
1520         Unfortunately, this API has one last client (Requested by
1521         abarth on #webkit).
1522
1523         * src/WebNotification.cpp:
1524         (WebKit::WebNotification::isHTML):
1525         (WebKit::WebNotification::url):
1526         (WebKit::WebNotification::iconURL):
1527         (WebKit::WebNotification::title):
1528         (WebKit::WebNotification::body):
1529
1530 2013-01-29  Shinya Kawanaka  <shinyak@chromium.org>
1531
1532         [Chromium] Cannot copy text when selecting readonly (or disabled) input elements
1533         https://bugs.webkit.org/show_bug.cgi?id=106287
1534
1535         Reviewed by Hajime Morita.
1536
1537         When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
1538         does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
1539         a document element. However, the inner element and document element have a different tree scope, selection range
1540         cannot be gotten correctly.
1541
1542         We should use ShadowRoot instead of document so that we can stay in the same tree scope.
1543
1544         * src/WebViewImpl.cpp:
1545         (WebKit::WebViewImpl::caretOrSelectionRange):
1546         * tests/WebViewTest.cpp:
1547         * tests/data/selection_disabled.html: Added.
1548         * tests/data/selection_readonly.html: Added.
1549
1550 2013-01-29  Tom Sepez  <tsepez@chromium.org>
1551
1552         [v8] Enable binding integrity on linux
1553         https://bugs.webkit.org/show_bug.cgi?id=108242
1554
1555         Reviewed by Adam Barth.
1556
1557         * features.gypi:
1558
1559 2013-01-29  Xianzhu Wang  <wangxianzhu@chromium.org>
1560
1561         [Chromium] Correct zoom for focused node when using compositor scaling
1562         https://bugs.webkit.org/show_bug.cgi?id=107599
1563
1564         Reviewed by Adam Barth.
1565
1566         When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
1567         When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
1568
1569         * src/WebViewImpl.cpp:
1570         (WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
1571         (WebKit):
1572         (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
1573         * src/WebViewImpl.h:
1574         (WebViewImpl):
1575         * tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
1576         * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1577
1578 2013-01-29  Alec Flett  <alecflett@chromium.org>
1579
1580         IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
1581         https://bugs.webkit.org/show_bug.cgi?id=103920
1582
1583         Reviewed by Dimitri Glazkov.
1584
1585         Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
1586         while maintaining chromium compatibility by shimming in the old API
1587         in the WebKit side. Future code will clean this up so that it is just a
1588         pass-through as it was before.
1589
1590         * public/WebIDBCallbacks.h:
1591         (WebKit):
1592         (WebKit::WebIDBCallbacks::onSuccess): new method signature.
1593         (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
1594         * src/IDBCallbacksProxy.cpp:
1595         (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
1596         (WebKit):
1597         (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
1598         * src/IDBCallbacksProxy.h:
1599         (IDBCallbacksProxy):
1600         * src/WebIDBCallbacksImpl.cpp:
1601         (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
1602         (WebKit):
1603         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
1604         * src/WebIDBCallbacksImpl.h:
1605         (WebIDBCallbacksImpl):
1606         * tests/IDBAbortOnCorruptTest.cpp: new method signature.
1607         (WebCore::MockIDBCallbacks::onSuccess):
1608         * tests/IDBDatabaseBackendTest.cpp: new method signature.
1609
1610 2013-01-29  Alexandre Elias  <aelias@chromium.org>
1611
1612         [chromium] Fix contents size calculation for page scale initialization
1613         https://bugs.webkit.org/show_bug.cgi?id=108204
1614
1615         Reviewed by enne.
1616
1617         My previous patch http://webk.it/107424 had a few issues that are
1618         blocking WebKit roll.
1619
1620         - We still need the layout in resize() given that
1621         http://webk.it/107922 was reverted.
1622
1623         - I deleted code used only for the old page-scale mode in
1624         contentsSize(), but this needs to wait until WebKit roll since it's
1625         making bots fail in this short term.
1626
1627         * src/WebViewImpl.cpp:
1628         (WebKit::WebViewImpl::resize):
1629         (WebKit::WebViewImpl::contentsSize):
1630
1631 2013-01-29  Alpha Lam  <hclam@chromium.org>
1632
1633         [chromium] Unreviewed DEPS roll.
1634
1635         Roll Chromium DEPS to 179332.
1636
1637         * DEPS:
1638
1639 2013-01-29  Joshua Bell  <jsbell@chromium.org>
1640
1641         [Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
1642         https://bugs.webkit.org/show_bug.cgi?id=107851
1643
1644         Reviewed by Tony Chang.
1645
1646         Let Chromium call abort() on a transaction and specify a reason, specifically for
1647         QuotaExceededError.
1648
1649         * public/WebIDBDatabase.h:
1650         (WebKit::WebIDBDatabase::abort): New overload for abort() that takes an error.
1651         * public/WebIDBDatabaseError.h:
1652         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): Overloaded constructor/assign that takes error.
1653         * src/IDBDatabaseBackendProxy.cpp:
1654         (WebKit::IDBDatabaseBackendProxy::abort): New overload for abort() that takes an error.
1655         * src/IDBDatabaseBackendProxy.h:
1656         (IDBDatabaseBackendProxy): Ditto.
1657         * src/WebIDBDatabaseError.cpp: Implementation of overload ctor/assign.
1658         * src/WebIDBDatabaseImpl.cpp:
1659         (WebKit::WebIDBDatabaseImpl::abort): New overload for abort() that takes an error.
1660         * src/WebIDBDatabaseImpl.h: Ditto.
1661         * tests/IDBDatabaseBackendTest.cpp: Overload stubs for Mock class.
1662
1663 2013-01-29  Florin Malita  <fmalita@chromium.org>
1664
1665         [Chromium] Unreviewed gardening.
1666
1667         Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
1668
1669         * tests/WebFrameTest.cpp:
1670
1671 2013-01-29  Keishi Hattori  <keishi@webkit.org>
1672
1673         [Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
1674
1675         Unreviewed. Gardening.
1676
1677         * tests/WebFrameTest.cpp:
1678
1679 2013-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1680
1681         Unreviewed, rolling out r141064.
1682         http://trac.webkit.org/changeset/141064
1683         https://bugs.webkit.org/show_bug.cgi?id=108166
1684
1685         [Chromium] WebFrameTest.DivScrollIntoEditableTest is failing
1686         on WinXP. (Requested by keishi on #webkit).
1687
1688         * tests/WebFrameTest.cpp:
1689         * tests/data/get_scale_for_zoom_into_editable_test.html:
1690
1691 2013-01-29  Keishi Hattori  <keishi@webkit.org>
1692
1693         [Chromium] Disabling WebFrameTest.DisambiguationPopup because it is failing.
1694
1695         Unreviewed. Gardening.
1696
1697         * tests/WebFrameTest.cpp:
1698
1699 2013-01-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1700
1701         Re-enable WebFrameTest.DivScrollIntoEditableTest
1702         https://bugs.webkit.org/show_bug.cgi?id=98558
1703
1704         Reviewed by Adam Barth.
1705
1706         * tests/WebFrameTest.cpp: Fixed several issues (onload script, the maximum scale factor, etc.) of WebFrameTest.DivScrollIntoEditableTest and enable it.
1707         * tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
1708
1709 2013-01-28  Tien-Ren Chen  <trchen@chromium.org>
1710
1711         Fix disambiguation popup for new-style page scale
1712         https://bugs.webkit.org/show_bug.cgi?id=107391
1713
1714         Reviewed by Adam Barth.
1715
1716         This patch corrects various coordinate conversion for disambiguation
1717         popup for the new-style page scale mode.
1718
1719         * src/WebViewImpl.cpp:
1720         (WebKit::WebViewImpl::handleGestureEvent):
1721         (WebKit::WebViewImpl::handleInputEvent):
1722         * tests/WebFrameTest.cpp:
1723         * tests/data/disambiguation_popup_page_scale.html: Added.
1724
1725 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1726
1727         Unreviewed, rolling out r141049.
1728         http://trac.webkit.org/changeset/141049
1729         https://bugs.webkit.org/show_bug.cgi?id=108151
1730
1731         Caused some indexed tests to crash. (Requested by keishi on
1732         #webkit).
1733
1734         * public/WebIDBCallbacks.h:
1735         (WebKit):
1736         * src/IDBCallbacksProxy.cpp:
1737         (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1738         * src/IDBCallbacksProxy.h:
1739         (IDBCallbacksProxy):
1740         * src/WebIDBCallbacksImpl.cpp:
1741         (WebKit::WebIDBCallbacksImpl::onSuccess):
1742         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
1743         * src/WebIDBCallbacksImpl.h:
1744         (WebIDBCallbacksImpl):
1745         * tests/IDBAbortOnCorruptTest.cpp:
1746         (WebCore::MockIDBCallbacks::onSuccess):
1747         * tests/IDBDatabaseBackendTest.cpp:
1748
1749 2013-01-28  Raman Kumar  <ramankk@chromium.org>
1750
1751         Expose isRadioButton and isCheckbox API in chromium-webkit glue layer.
1752         https://bugs.webkit.org/show_bug.cgi?id=108031
1753
1754         Reviewed by Adam Barth.
1755
1756         In chromium, to know if an InputElement is radiobutton or a checkbox,
1757         we are checking for formControlType (a string comparision), which is
1758         very slow. Exposing these API to chromium will make them faster.
1759
1760         * public/WebInputElement.h:
1761         (WebInputElement):
1762         * src/WebInputElement.cpp:
1763         (WebKit::WebInputElement::isRadioButton):
1764         (WebKit):
1765         (WebKit::WebInputElement::isCheckbox):
1766
1767 2013-01-28  Alexandre Elias  <aelias@chromium.org>
1768
1769         Make page scale shrink FrameView in applyPageScaleInCompositor mode
1770         https://bugs.webkit.org/show_bug.cgi?id=107424
1771
1772         Reviewed by Levi Weintraub.
1773
1774         If applyPageScaleFactorInCompositor is enabled (Chromium-only setting),
1775         instead of the entire document expanding as the user pinch zooms, the
1776         viewport shrinks instead. This patch applies the pageScaleFactor to
1777         visibleContentRect to get this behavior, and simplifies Chromium's
1778         resize logic to stop hiding the true viewport size from WebCore.
1779
1780         I verified that the scaling makes sense for all the callers of
1781         visibleContentRect. The exceptions are clip-layer size,
1782         layout size in non-fixed-layout mode, and text autosizing, which need
1783         the original unscaled size. Therefore I added a new method
1784         unscaledVisibleContentSize() to ScrollView/FrameView.
1785
1786         This patch also modifies Page::setPageScaleFactor to perform no
1787         invalidates or layout when applyPageScaleFactorInCompositor is true,
1788         and also writes pageScaleFactor into HistoryItems instead of using
1789         frameScaleFactor.
1790
1791         Since all behavior changes are tied to applyPageScaleFactorInCompositor,
1792         this patch should be a no-op for non-Chromium ports.
1793
1794         * src/WebViewImpl.cpp:
1795         (WebKit::WebViewImpl::scaledSize): Returns the post page-scale size
1796         similar to what visibleContentRect() now returns, except that it may
1797         be at a different scale than the current one.
1798         (WebKit::WebViewImpl::size): Back to returning density-independent
1799         size without any tricks, not the "layoutSize()" fake viewport.
1800         (WebKit::WebViewImpl::resize):
1801         (WebKit::WebViewImpl::handleInputEvent): No need to apply
1802         implTransform anymore as WebKit knows the true scroll offset; just
1803         divide event coords by pageScaleFactor.
1804         (WebKit::WebViewImpl::clampOffsetAtScale): Make this method support
1805         applyPageScaleFactorInCompositor.  This is used to pre-clamp scroll
1806         offsets at a given viewport size.
1807         (WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset): Make
1808         this method support applyPageScaleFactorInCompositor (don't scale
1809         scroll offsets as they are now scale-independent).
1810         (WebKit::WebViewImpl::setPageScaleFactor): Make this method always use
1811         clampOffsetAtScale instead of bypassing it, since it's now supported.
1812         Also notify the compositor to update its state.
1813         (WebKit::WebViewImpl::contentsSize): Convenience method, removed
1814         difference between scaled and unscaled.
1815         (WebKit::WebViewImpl::layoutSize): This method returned the "fake"
1816         size we used to give FrameView.  Now no longer used for much.
1817         (WebKit::WebViewImpl::computePageScaleFactorLimits):
1818         (WebKit::WebViewImpl::didChangeContentsSize): Remove unnecessary
1819         resize() now that we can give the true size to FrameView.
1820         (WebKit::WebViewImpl::updateLayerTreeViewport): Use layoutSize()
1821         directly now that FrameView no longer uses it.
1822         * src/WebViewImpl.h:
1823         (WebViewImpl):
1824         * tests/WebFrameTest.cpp:
1825
1826 2013-01-28  Alec Flett  <alecflett@chromium.org>
1827
1828         IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
1829         https://bugs.webkit.org/show_bug.cgi?id=103920
1830
1831         Reviewed by Dimitri Glazkov.
1832
1833         Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
1834         while maintaining chromium compatibility by shimming in the old API
1835         in the WebKit side. Future code will clean this up so that it is just a
1836         pass-through as it was before.
1837
1838         * public/WebIDBCallbacks.h:
1839         (WebKit):
1840         (WebKit::WebIDBCallbacks::onSuccess): new method signature.
1841         (WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
1842         * src/IDBCallbacksProxy.cpp:
1843         (WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
1844         (WebKit):
1845         (WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
1846         * src/IDBCallbacksProxy.h:
1847         (IDBCallbacksProxy):
1848         * src/WebIDBCallbacksImpl.cpp:
1849         (WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
1850         (WebKit):
1851         (WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
1852         * src/WebIDBCallbacksImpl.h:
1853         (WebIDBCallbacksImpl):
1854         * tests/IDBAbortOnCorruptTest.cpp: new method signature.
1855         (WebCore::MockIDBCallbacks::onSuccess):
1856         * tests/IDBDatabaseBackendTest.cpp: new method signature.
1857
1858 2013-01-28  Tom Sepez  <tsepez@chromium.org>
1859
1860         [v8] Security feature: JavaScript Bindings hardening
1861         https://bugs.webkit.org/show_bug.cgi?id=106608
1862
1863         Reviewed by Adam Barth.
1864
1865         * features.gypi:
1866         Added ENABLE_BINDING_INTEGRITY option.
1867
1868 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1869
1870         Unreviewed, rolling out r141006.
1871         http://trac.webkit.org/changeset/141006
1872         https://bugs.webkit.org/show_bug.cgi?id=108123
1873
1874         Broke chromium build (Requested by arv on #webkit).
1875
1876         * public/WebConsoleMessage.h:
1877         * src/AssertMatchingEnums.cpp:
1878         * src/WebFrameImpl.cpp:
1879         (WebKit::WebFrameImpl::addMessageToConsole):
1880
1881 2013-01-28  Min Qin  <qinmin@chromium.org>
1882
1883         adding support for DiscardablePixelRef for caching lazily decoded images
1884         https://bugs.webkit.org/show_bug.cgi?id=106842
1885
1886         Reviewed by Stephen White.
1887
1888         Adding new tests for ImageDecodingStore
1889
1890         * WebKit.gypi:
1891         * tests/ImageDecodingStoreTest.cpp:
1892         (WebCore::ImageDecodingStoreTest::createCompleteImage):
1893         (WebCore::ImageDecodingStoreTest::createIncompleteImage):
1894         (WebCore::TEST_F):
1895         (WebCore):
1896         * tests/MockDiscardablePixelRef.h: Added.
1897         (WebCore):
1898         (MockDiscardablePixelRef):
1899         (WebCore::MockDiscardablePixelRef::MockDiscardablePixelRef):
1900         (WebCore::MockDiscardablePixelRef::~MockDiscardablePixelRef):
1901         (WebCore::MockDiscardablePixelRef::discard):
1902         (WebCore::MockDiscardablePixelRef::onLockPixels):
1903         (WebCore::MockDiscardablePixelRef::onUnlockPixels):
1904
1905 2013-01-28  Stephen Chenney  <schenney@chromium.org>
1906
1907         [Chromium] Fix the build.
1908
1909         Unreviewed build fix.
1910
1911         * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
1912
1913 2013-01-28  Dan Alcantara  <dfalcantara@chromium.org>
1914
1915         [Chromium, Mobile] Do not show disambiguation pop up in mobile sites
1916         https://bugs.webkit.org/show_bug.cgi?id=107607
1917
1918         Reviewed by Adam Barth.
1919
1920         Add a check before showing the disambiguation popup to prevent it from appearing
1921         on mobile sites.  Makes a similar test to the current disambiguation popup test
1922         that expects the popup to never appear.
1923
1924         * src/WebViewImpl.cpp:
1925         (WebKit::WebViewImpl::handleGestureEvent):
1926         (WebKit):
1927         (WebKit::WebViewImpl::isLikelyMobileSite):
1928         * src/WebViewImpl.h:
1929         (WebViewImpl):
1930         * tests/WebFrameTest.cpp:
1931         * tests/data/disambiguation_popup_mobile_site.html: Added.
1932
1933         * src/WebViewImpl.cpp:
1934         (WebKit::WebViewImpl::handleGestureEvent):
1935         (WebKit):
1936         (WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):
1937         * src/WebViewImpl.h:
1938         (WebViewImpl):
1939         * tests/WebFrameTest.cpp:
1940         * tests/data/disambiguation_popup_mobile_site.html: Added.
1941
1942 2013-01-28  Stephen Chenney  <schenney@chromium.org>
1943
1944         [Chromium] Fix the build.
1945
1946         Unreviewed build fix.
1947
1948         * src/AssertMatchingEnums.cpp: Move the include to the right place and remove the bad directory prefix.
1949
1950 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1951
1952         Unreviewed, rolling out r140869.
1953         http://trac.webkit.org/changeset/140869
1954         https://bugs.webkit.org/show_bug.cgi?id=108120
1955
1956         "Crashes on http://en.wikipedia.org/wiki/Wikipedia" (Requested
1957         by tonyg-cr on #webkit).
1958
1959         * src/WebViewImpl.cpp:
1960         (WebKit::WebViewImpl::resize):
1961         (WebKit::WebViewImpl::computePageScaleFactorLimits):
1962         * tests/WebFrameTest.cpp:
1963
1964 2013-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1965
1966         Unreviewed, rolling out r140934, r140935, and r140937.
1967         http://trac.webkit.org/changeset/140934
1968         http://trac.webkit.org/changeset/140935
1969         http://trac.webkit.org/changeset/140937
1970         https://bugs.webkit.org/show_bug.cgi?id=108117
1971
1972         Re-land some speculative rollouts - see wkbug.com/108048 for
1973         context (Requested by jsbell on #webkit).
1974
1975         * public/WebIDBCallbacks.h:
1976         (WebIDBCallbacks):
1977         * src/AssertMatchingEnums.cpp:
1978         * src/IDBCallbacksProxy.cpp:
1979         * src/IDBCallbacksProxy.h:
1980         (IDBCallbacksProxy):
1981         * src/WebIDBCallbacksImpl.cpp:
1982         * src/WebIDBCallbacksImpl.h:
1983         (WebIDBCallbacksImpl):
1984         * tests/IDBAbortOnCorruptTest.cpp:
1985         * tests/IDBDatabaseBackendTest.cpp:
1986
1987 2013-01-28  Kevin Day  <kevinday@gmail.com>
1988
1989         [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
1990         https://bugs.webkit.org/show_bug.cgi?id=108004
1991         http://code.google.com/p/chromium/issues/detail?id=172416
1992
1993         console.debug triggers a NOTREACHED() assertation in Chromium. This
1994         is because WebCore::MessageLevel contains 5 levels, including debug,
1995         where WebConsoleMessage::Level is missing a "debug" level. Add a
1996         WebConsoleMessage::LevelDebug so that it can get passed up to the
1997         renderer even if it doesn't make use of that now.
1998
1999         Requires another patch to chromium itself to fix chromium bug 172416
2000         but this is a prerequisite.
2001
2002         Also add an enum compile time check to AssertMatchingEnums.cpp,
2003
2004         Reviewed by Jochen Eisinger.
2005
2006         * public/WebConsoleMessage.h:
2007         * src/AssertMatchingEnums.cpp:
2008         * src/WebFrameImpl.cpp:
2009         (WebKit::WebFrameImpl::addMessageToConsole):
2010
2011 2013-01-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2012
2013         [Chromium] Correct auto-zoom when using compositor scaling
2014         https://bugs.webkit.org/show_bug.cgi?id=107592
2015
2016         Reviewed by Adam Barth.
2017
2018         1. The scale of auto-zoom should exclude deviceScaleFactor because the compositor will handle the scaling;
2019         2. Scroll location needs to be calculated differently when pageScaleFactor is handled by the compositor.
2020
2021         * src/WebViewImpl.cpp:
2022         (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
2023         * tests/WebFrameTest.cpp: Updated tests DivAutoZoomParamsTest, DivAutoZoomMultipleDivsTest, DivAutoZoomScaleBoundsTest and DivAutoZoomScaleFontScaleFactorTest, to make two versions of them (WebKitScaling and CompositorScaling).
2024
2025 2013-01-28  Laszlo Gombos  <l.gombos@samsung.com>
2026
2027         Collapse OS(UNIX)||OS(ANDROID) to OS(UNIX)
2028         https://bugs.webkit.org/show_bug.cgi?id=108091
2029
2030         Reviewed by Adam Barth.
2031
2032         OS(UNIX) is defined when OS(ANDROID) is defined.
2033
2034         * src/WebViewImpl.cpp:
2035         (WebKit::WebViewImpl::handleMouseDown):
2036
2037 2013-01-28  Adam Barth  <abarth@webkit.org>
2038
2039         Remove webkitNotifications.createHTMLNotification
2040         https://bugs.webkit.org/show_bug.cgi?id=107598
2041
2042         Reviewed by Benjamin Poulain.
2043
2044         We can remove these stubs once we've removed the Chromium-side code
2045         that depends on them.
2046
2047         * src/WebNotification.cpp:
2048         (WebKit::WebNotification::isHTML):
2049         (WebKit::WebNotification::url):
2050         (WebKit::WebNotification::iconURL):
2051         (WebKit::WebNotification::title):
2052         (WebKit::WebNotification::body):
2053
2054 2013-01-28  James Craig  <james@cookiecrook.com>
2055
2056         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
2057         https://bugs.webkit.org/show_bug.cgi?id=107650
2058
2059         Reviewed by Chris Fleizach.
2060
2061         Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
2062
2063         * public/WebAccessibilityRole.h:
2064         * src/AssertMatchingEnums.cpp:
2065         * src/LocalizedStrings.cpp:
2066         (WebCore::AXDefinitionText):
2067         (WebCore):
2068         (WebCore::AXDescriptionListTermText):
2069         (WebCore::AXDescriptionListDetailText):
2070
2071 2013-01-28  Mike West  <mkwst@chromium.org>
2072
2073         [chromium] Unreviewed build fix, missing include in AssertMatchingEnums.cpp
2074         https://bugs.webkit.org/show_bug.cgi?id=108086
2075
2076         Disabling SVG exposed a missing include in AssertMatchingEnums. This
2077         patch adds it in.
2078
2079         * src/AssertMatchingEnums.cpp:
2080             Include 'ResourceLoadPriority.h'.
2081
2082 2013-01-28  Marja Hölttä  <marja@chromium.org>
2083
2084         Add an API for retrieving native memory information without going through the remote inspecting protocol
2085         https://bugs.webkit.org/show_bug.cgi?id=107651
2086
2087         Reviewed by Adam Barth.
2088
2089         * WebKit.gyp:
2090         * public/WebDevToolsAgent.h:
2091         (WebKit):
2092         (WebDevToolsAgent):
2093         * public/WebMemoryUsageInfo.h: Added.
2094         (WebKit):
2095         (WebKit::WebMemoryUsageInfo::WebMemoryUsageInfo):
2096         (WebMemoryUsageInfo):
2097         * src/WebDevToolsAgentImpl.cpp:
2098         (WebKit::WebDevToolsAgentImpl::processMemoryDistribution):
2099         (WebKit):
2100         * src/WebDevToolsAgentImpl.h:
2101         (WebKit):
2102         (WebDevToolsAgentImpl):
2103
2104 2013-01-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2105
2106         Unreviewed, rolling out r140602.
2107         http://trac.webkit.org/changeset/140602
2108         https://bugs.webkit.org/show_bug.cgi?id=108045
2109
2110         Caused 8 indexed tests to crash. (Requested by keishi on
2111         #webkit).
2112
2113         * public/WebIDBCallbacks.h:
2114         * src/IDBCallbacksProxy.cpp:
2115         (WebKit::IDBCallbacksProxy::onBlocked):
2116         (WebKit):
2117         * src/IDBCallbacksProxy.h:
2118         (IDBCallbacksProxy):
2119         * src/WebIDBCallbacksImpl.cpp:
2120         (WebKit::WebIDBCallbacksImpl::onBlocked):
2121         (WebKit):
2122         * src/WebIDBCallbacksImpl.h:
2123         (WebIDBCallbacksImpl):
2124         * tests/IDBAbortOnCorruptTest.cpp:
2125         (WebCore::MockIDBCallbacks::onBlocked):
2126         * tests/IDBDatabaseBackendTest.cpp:
2127
2128 2013-01-27  Keishi Hattori  <keishi@webkit.org>
2129
2130         Unreviewed, rolling out r140850.
2131         http://trac.webkit.org/changeset/140850
2132         https://bugs.webkit.org/show_bug.cgi?id=107960
2133
2134         r14602 caused 8 indexed tests to crash.
2135
2136         * src/AssertMatchingEnums.cpp:
2137
2138 2013-01-27  Jochen Eisinger  <jochen@chromium.org>
2139
2140         [chromium] add missing plumbing for Notification.requestPermission
2141         https://bugs.webkit.org/show_bug.cgi?id=108012
2142
2143         Reviewed by Adam Barth.
2144
2145         * src/NotificationPresenterImpl.cpp:
2146         (WebKit):
2147         (WebKit::VoidCallbackClient::VoidCallbackClient):
2148         (NotificationPermissionCallbackClient):
2149         (WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
2150         (WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
2151         (WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
2152         (WebKit::NotificationPresenterImpl::requestPermission):
2153         * src/NotificationPresenterImpl.h:
2154         (NotificationPresenterImpl):
2155
2156 2013-01-26  James Simonsen  <simonjam@chromium.org>
2157
2158         [chromium] Export ResourceRequest's priority through WebURLRequest
2159         https://bugs.webkit.org/show_bug.cgi?id=107985
2160
2161         Reviewed by Adam Barth.
2162
2163         * src/AssertMatchingEnums.cpp:
2164
2165 2013-01-25  Alexandre Elias  <aelias@chromium.org>
2166
2167         Call FrameView::contentsResized() when setting fixed layout size
2168         https://bugs.webkit.org/show_bug.cgi?id=107922
2169
2170         Reviewed by James Robinson.
2171
2172         In fixed layout mode, we should be calling contentsResized() when the
2173         fixed layout size is changed; on the other hand, we don't need to layout
2174         when the visible contents size changes.
2175
2176         This fixes test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.
2177
2178         * src/WebViewImpl.cpp:
2179         (WebKit::WebViewImpl::resize):
2180         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2181         * tests/WebFrameTest.cpp:
2182
2183 2013-01-25  Alec Flett  <alecflett@chromium.org>
2184
2185         IndexedDB: Move TaskType enum to IDBDatabaseBackendInterface
2186         https://bugs.webkit.org/show_bug.cgi?id=107960
2187
2188         Reviewed by Tony Chang.
2189
2190         Update asserts to reflect new enum location.
2191
2192         * src/AssertMatchingEnums.cpp:
2193
2194 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2195
2196         Unreviewed, rolling out r140774.
2197         http://trac.webkit.org/changeset/140774
2198         https://bugs.webkit.org/show_bug.cgi?id=107932
2199
2200          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
2201         and fastScrollingForFixedPosition are failing (Requested by
2202         keishi on #webkit).
2203
2204         * public/WebWidget.h:
2205         (WebWidget):
2206         (WebKit::WebWidget::isInputThrottled):
2207         (WebKit::WebWidget::renderingStats):
2208         * src/WebViewImpl.cpp:
2209         (WebKit::WebViewImpl::WebViewImpl):
2210         (WebKit::WebViewImpl::~WebViewImpl):
2211         (WebKit::WebViewImpl::renderingStats):
2212         (WebKit):
2213         (WebKit::WebViewImpl::setCompositorSurfaceReady):
2214         (WebKit::WebViewImpl::isInputThrottled):
2215         (WebKit::WebViewImpl::setIsTransparent):
2216         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2217         * src/WebViewImpl.h:
2218
2219 2013-01-25  Eberhard Graether  <egraether@google.com>
2220
2221         Web Inspector: add checkbox for continuous painting to the inspector's settings
2222         https://bugs.webkit.org/show_bug.cgi?id=107352
2223
2224         Reviewed by Pavel Feldman.
2225
2226         This change adds a checkbox to activate continuous painting to the WebInspector's
2227         rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The
2228         setting is visible if InspectorClient::canContinuouslyPaint() returns true.
2229
2230         * public/WebView.h:
2231         (WebView):
2232         * src/InspectorClientImpl.cpp:
2233         (WebKit::InspectorClientImpl::canContinuouslyPaint):
2234         (WebKit):
2235         (WebKit::InspectorClientImpl::setContinuousPaintingEnabled):
2236         * src/InspectorClientImpl.h:
2237         (InspectorClientImpl):
2238         * src/WebViewImpl.cpp:
2239         (WebKit::WebViewImpl::setContinuousPaintingEnabled):
2240         (WebKit):
2241         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2242         * src/WebViewImpl.h:
2243
2244 2013-01-24  Keishi Hattori  <keishi@webkit.org>
2245
2246         Adjust design of the Calendar Picker
2247         https://bugs.webkit.org/show_bug.cgi?id=107507
2248
2249         Reviewed by Kent Tamura.
2250
2251         * src/DateTimeChooserImpl.cpp:
2252         (WebKit::DateTimeChooserImpl::writeDocument):  Include pickerCommonChromium.css and calendarPickerChromium.css.
2253
2254 2013-01-24  James Robinson  <jamesr@chromium.org>
2255
2256         [chromium] Remove dead transitional code from WebViewImpl
2257         https://bugs.webkit.org/show_bug.cgi?id=107889
2258
2259         Reviewed by Adrienne Walker.
2260
2261         The chromium side of this landed at r178256 and seems stable.
2262
2263         * public/WebWidget.h:
2264         (WebKit::WebWidget::setCompositorSurfaceReady):
2265         * src/WebViewImpl.cpp:
2266         (WebKit::WebViewImpl::WebViewImpl):
2267         (WebKit::WebViewImpl::~WebViewImpl):
2268         (WebKit):
2269         (WebKit::WebViewImpl::setIsTransparent):
2270         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2271         * src/WebViewImpl.h:
2272
2273 2013-01-24  James Robinson  <jamesr@chromium.org>
2274
2275         [chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect
2276         https://bugs.webkit.org/show_bug.cgi?id=107855
2277
2278         Reviewed by Adrienne Walker.
2279
2280         During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
2281         may get invalidateRect() calls before shutdown completes.
2282
2283         * src/WebViewImpl.cpp:
2284         (WebKit::WebViewImpl::invalidateRect):
2285
2286 2013-01-24  Mihai Maerean  <mmaerean@adobe.com>
2287
2288         [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in Source/WebKit/chromium/public/WebSettings.h
2289         https://bugs.webkit.org/show_bug.cgi?id=104564
2290
2291         Reviewed by Adam Barth.
2292
2293         Fixing bug 101192 has deprecated the use of setExperimentalCSSRegionsEnabled.
2294         After http://code.google.com/p/chromium/issues/detail?id=164162 , setExperimentalCSSRegionsEnabled is no longer used anywhere.
2295
2296         * public/WebSettings.h:
2297         removed setExperimentalCSSRegionsEnabled.
2298
2299 2013-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2300
2301         Unreviewed.  Rolled Chromium DEPS to r178434.  Requested by
2302         "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2303
2304         * DEPS:
2305
2306 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2307
2308         [Chromium] Remove unused header files in chromium/public/platform/
2309         https://bugs.webkit.org/show_bug.cgi?id=107741
2310
2311         Reviewed by James Robinson.
2312
2313         These header files have migrated to the new Platform directory.
2314         This patch updates the remaining #include references and removes
2315         the old files that did nothing but redirect to the new ones.
2316
2317         * WebKit.gyp:
2318         * public/WebAccessibilityObject.h:
2319         * public/WebAccessibilityRole.h:
2320         * public/WebActiveWheelFlingParameters.h:
2321         * public/WebAnimationController.h:
2322         * public/WebApplicationCacheHost.h:
2323         * public/WebApplicationCacheHostClient.h:
2324         * public/WebArrayBuffer.h:
2325         * public/WebArrayBufferView.h:
2326         * public/WebAudioSourceProvider.h:
2327         * public/WebBatteryStatus.h:
2328         * public/WebBindings.h:
2329         * public/WebBlob.h:
2330         * public/WebCache.h:
2331         * public/WebCachedURLRequest.h:
2332         * public/WebColorChooser.h:
2333         * public/WebColorChooserClient.h:
2334         * public/WebColorName.h:
2335         * public/WebCommonWorkerClient.h:
2336         * public/WebCompositionUnderline.h:
2337         * public/WebCompositorInputHandler.h:
2338         * public/WebConsoleMessage.h:
2339         * public/WebContentDetectionResult.h:
2340         * public/WebContextMenuData.h:
2341         * public/WebCrossOriginPreflightResultCache.h:
2342         * public/WebCursorInfo.h:
2343         * public/WebDOMEvent.h:
2344         * public/WebDOMEventListener.h:
2345         * public/WebDOMStringList.h:
2346         * public/WebDataSource.h:
2347         * public/WebDatabase.h:
2348         * public/WebDateTimeChooserCompletion.h:
2349         * public/WebDateTimeChooserParams.h:
2350         * public/WebDeliveredIntentClient.h:
2351         * public/WebDevToolsAgent.h:
2352         * public/WebDevToolsAgentClient.h:
2353         * public/WebDevToolsFrontend.h:
2354         * public/WebDeviceOrientationClient.h:
2355         * public/WebDeviceOrientationClientMock.h:
2356         * public/WebDeviceOrientationController.h:
2357         * public/WebDocument.h:
2358         * public/WebDraggableRegion.h:
2359         * public/WebExternalPopupMenuClient.h:
2360         * public/WebFileChooserCompletion.h:
2361         * public/WebFileChooserParams.h:
2362         * public/WebFileSystemCallbacks.h:
2363         * public/WebFileSystemEntry.h:
2364         * public/WebFileWriter.h:
2365         * public/WebFileWriterClient.h:
2366         * public/WebFindOptions.h:
2367         * public/WebFont.h:
2368         * public/WebFontCache.h:
2369         * public/WebFontDescription.h:
2370         * public/WebFormControlElement.h:
2371         * public/WebFormElement.h:
2372         * public/WebFrame.h:
2373         * public/WebFrameClient.h:
2374         * public/WebGeolocationClientMock.h:
2375         * public/WebGeolocationController.h:
2376         * public/WebGeolocationError.h:
2377         * public/WebGeolocationPermissionRequest.h:
2378         * public/WebGeolocationPermissionRequestManager.h:
2379         * public/WebGeolocationPosition.h:
2380         * public/WebGlyphCache.h:
2381         * public/WebHelperPlugin.h:
2382         * public/WebHistoryItem.h:
2383         * public/WebHitTestResult.h:
2384         * public/WebIDBCallbacks.h:
2385         * public/WebIDBCursor.h:
2386         * public/WebIDBDatabase.h:
2387         * public/WebIDBDatabaseCallbacks.h:
2388         * public/WebIDBDatabaseError.h:
2389         * public/WebIDBFactory.h:
2390         * public/WebIDBKey.h:
2391         * public/WebIDBKeyPath.h:
2392         * public/WebIDBKeyRange.h:
2393         * public/WebIDBMetadata.h:
2394         * public/WebIDBTransaction.h:
2395         * public/WebIDBTransactionCallbacks.h:
2396         * public/WebIconURL.h:
2397         * public/WebImageDecoder.h:
2398         * public/WebInputEvent.h:
2399         * public/WebIntent.h:
2400         * public/WebIntentRequest.h:
2401         * public/WebIntentServiceInfo.h:
2402         * public/WebKit.h:
2403         * public/WebMediaPlayer.h:
2404         * public/WebMediaStreamRegistry.h:
2405         * public/WebMenuItemInfo.h:
2406         * public/WebNetworkStateNotifier.h:
2407         * public/WebNode.h:
2408         * public/WebNodeCollection.h:
2409         * public/WebNodeList.h:
2410         * public/WebNotification.h:
2411         * public/WebNotificationPresenter.h:
2412         * public/WebOptionElement.h:
2413         * public/WebPageOverlay.h:
2414         * public/WebPagePopup.h:
2415         * public/WebPageSerializer.h:
2416         * public/WebPasswordFormData.h:
2417         * public/WebPerformance.h:
2418         * public/WebPlugin.h:
2419         * public/WebPluginContainer.h:
2420         * public/WebPluginParams.h:
2421         * public/WebPopupMenu.h:
2422         * public/WebPopupMenuInfo.h:
2423         * public/WebPrerendererClient.h:
2424         * public/WebPrintParams.h:
2425         * public/WebRange.h:
2426         * public/WebRegularExpression.h:
2427         * public/WebRuntimeFeatures.h:
2428         * public/WebScopedMicrotaskSuppression.h:
2429         * public/WebScopedUserGesture.h:
2430         * public/WebScriptController.h:
2431         * public/WebScriptSource.h:
2432         * public/WebSearchableFormData.h:
2433         * public/WebSecurityOrigin.h:
2434         * public/WebSecurityPolicy.h:
2435         * public/WebSelectElement.h:
2436         * public/WebSerializedScriptValue.h:
2437         * public/WebSettings.h:
2438         * public/WebSharedWorker.h:
2439         * public/WebSharedWorkerRepository.h:
2440         * public/WebSocket.h:
2441         * public/WebSocketClient.h:
2442         * public/WebSpeechGrammar.h:
2443         * public/WebSpeechInputController.h:
2444         * public/WebSpeechInputResult.h:
2445         * public/WebSpeechRecognitionHandle.h:
2446         * public/WebSpeechRecognitionParams.h:
2447         * public/WebSpeechRecognitionResult.h:
2448         * public/WebSpeechRecognizer.h:
2449         * public/WebSpeechRecognizerClient.h:
2450         * public/WebSpellCheckClient.h:
2451         * public/WebStorageEventDispatcher.h:
2452         * public/WebSurroundingText.h:
2453         * public/WebTestingSupport.h:
2454         * public/WebTextCheckingCompletion.h:
2455         * public/WebTextCheckingResult.h:
2456         * public/WebTextFieldDecoratorClient.h:
2457         * public/WebTextInputInfo.h:
2458         * public/WebTextRun.h:
2459         * public/WebTimeRange.h:
2460         * public/WebTouchPoint.h:
2461         * public/WebUserMediaRequest.h:
2462         * public/WebView.h:
2463         * public/WebViewBenchmarkSupport.h:
2464         * public/WebViewClient.h:
2465         * public/WebWidget.h:
2466         * public/WebWidgetClient.h:
2467         * public/WebWindowFeatures.h:
2468         * public/WebWorkerInfo.h:
2469         * public/android/WebInputEventFactory.h:
2470         * public/android/WebSandboxSupport.h:
2471         * public/default/WebRenderTheme.h:
2472         * public/gtk/WebInputEventFactory.h:
2473         * public/linux/WebFontRendering.h:
2474         * public/linux/WebSandboxSupport.h:
2475         * public/mac/WebInputEventFactory.h:
2476         * public/mac/WebSandboxSupport.h:
2477         * public/mac/WebScreenInfoFactory.h:
2478         * public/mac/WebSubstringUtil.h:
2479         * public/platform/WebAudioBus.h: Removed.
2480         * public/platform/WebAudioDevice.h: Removed.
2481         * public/platform/WebBlobData.h: Removed.
2482         * public/platform/WebBlobRegistry.h: Removed.
2483         * public/platform/WebCString.h: Removed.
2484         * public/platform/WebCanvas.h: Removed.
2485         * public/platform/WebClipboard.h: Removed.
2486         * public/platform/WebColor.h: Removed.
2487         * public/platform/WebCommon.h: Removed.
2488         * public/platform/WebCookie.h: Removed.
2489         * public/platform/WebCookieJar.h: Removed.
2490         * public/platform/WebData.h: Removed.
2491         * public/platform/WebDragData.h: Removed.
2492         * public/platform/WebFileSystem.h: Removed.
2493         * public/platform/WebFloatPoint.h: Removed.
2494         * public/platform/WebFloatQuad.h: Removed.
2495         * public/platform/WebFloatRect.h: Removed.
2496         * public/platform/WebGamepad.h: Removed.
2497         * public/platform/WebGamepads.h: Removed.
2498         * public/platform/WebGraphicsContext3D.h: Removed.
2499         * public/platform/WebHTTPBody.h: Removed.
2500         * public/platform/WebHTTPHeaderVisitor.h: Removed.
2501         * public/platform/WebHTTPLoadInfo.h: Removed.
2502         * public/platform/WebImage.h: Removed.
2503         * public/platform/WebLocalizedString.h: Removed.
2504         * public/platform/WebMediaStreamCenter.h: Removed.
2505         * public/platform/WebMediaStreamCenterClient.h: Removed.
2506         * public/platform/WebMediaStreamComponent.h: Removed.
2507         * public/platform/WebMediaStreamDescriptor.h: Removed.
2508         * public/platform/WebMediaStreamSource.h: Removed.
2509         * public/platform/WebMediaStreamSourcesRequest.h: Removed.
2510         * public/platform/WebNonCopyable.h: Removed.
2511         * public/platform/WebPoint.h: Removed.
2512         * public/platform/WebPrivateOwnPtr.h: Removed.
2513         * public/platform/WebPrivatePtr.h: Removed.
2514         * public/platform/WebRect.h: Removed.
2515         * public/platform/WebReferrerPolicy.h: Removed.
2516         * public/platform/WebSize.h: Removed.
2517         * public/platform/WebSocketStreamError.h: Removed.
2518         * public/platform/WebSocketStreamHandle.h: Removed.
2519         * public/platform/WebSocketStreamHandleClient.h: Removed.
2520         * public/platform/WebString.h: Removed.
2521         * public/platform/WebThread.h: Removed.
2522         * public/platform/WebThreadSafeData.h: Removed.
2523         * public/platform/WebURL.h: Removed.
2524         * public/platform/WebURLError.h: Removed.
2525         * public/platform/WebURLLoadTiming.h: Removed.
2526         * public/platform/WebURLLoader.h: Removed.
2527         * public/platform/WebURLLoaderClient.h: Removed.
2528         * public/platform/WebURLRequest.h: Removed.
2529         * public/platform/WebURLResponse.h: Removed.
2530         * public/platform/WebVector.h: Removed.
2531         * public/platform/android/WebSandboxSupport.h: Removed.
2532         * public/platform/android/WebThemeEngine.h: Removed.
2533         * public/platform/default/WebThemeEngine.h: Removed.
2534         * public/platform/linux/WebFontFamily.h: Removed.
2535         * public/platform/linux/WebSandboxSupport.h: Removed.
2536         * public/platform/mac/WebSandboxSupport.h: Removed.
2537         * public/platform/mac/WebThemeEngine.h: Removed.
2538         * public/platform/win/WebSandboxSupport.h: Removed.
2539         * public/platform/win/WebThemeEngine.h: Removed.
2540         * public/win/WebInputEventFactory.h:
2541         * public/win/WebSandboxSupport.h:
2542         * public/win/WebScreenInfoFactory.h:
2543         * public/x11/WebScreenInfoFactory.h:
2544
2545 2013-01-23  Joshua Bell  <jsbell@chromium.org>
2546
2547         IndexedDB: Remove IDBVersionChangeRequest
2548         https://bugs.webkit.org/show_bug.cgi?id=107711
2549
2550         Reviewed by Tony Chang.
2551
2552         * public/WebIDBCallbacks.h: Note to delete onBlocked() once Chromium is cleaned up.
2553         * src/IDBCallbacksProxy.cpp: Remove unused onBlocked() overload.
2554         * src/IDBCallbacksProxy.h: Ditto.
2555         * src/WebIDBCallbacksImpl.cpp: Ditto.
2556         * src/WebIDBCallbacksImpl.h: Ditto.
2557         * tests/IDBAbortOnCorruptTest.cpp: Ditto.
2558         * tests/IDBDatabaseBackendTest.cpp: Ditto.
2559
2560 2013-01-23  Tien-Ren Chen  <trchen@chromium.org>
2561
2562         Partially revert 104427, change WebWidgetClient::didHandleGestureEvent semantics.
2563         https://bugs.webkit.org/show_bug.cgi?id=107605
2564
2565         Reviewed by Darin Fisher.
2566
2567         Per discussion in https://codereview.chromium.org/11473027/ we decided
2568         not to introduce an enum to WebWidgetClient::didHandleGestureEvent().
2569         Instead, change the semantics of the bool flag to indicate whether the
2570         gesture event is cancelled for disambiguation.
2571
2572         * public/WebWidgetClient.h:
2573         (WebKit::WebWidgetClient::didHandleGestureEvent):
2574         * src/WebViewImpl.cpp:
2575         (WebKit::WebViewImpl::handleGestureEvent):
2576         * tests/WebViewTest.cpp:
2577
2578 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2579
2580         [Chromium] Remove WebArrayBufferView and WebSerializedScriptValue from chromium/public/platform/
2581         https://bugs.webkit.org/show_bug.cgi?id=107720
2582
2583         Reviewed by Darin Fisher.
2584
2585         These headers have been moved to chromium/public/ and all
2586         references downstream were changed in
2587         https://codereview.chromium.org/11946050/.
2588         No DEPS roll necessary because it's already above 177695.
2589
2590         * WebKit.gyp:
2591         * public/platform/WebArrayBufferView.h: Removed.
2592         * public/platform/WebSerializedScriptValue.h: Removed.
2593         * src/DeliveredIntentClientImpl.cpp:
2594         * src/IDBCallbacksProxy.cpp:
2595         * src/IDBCursorBackendProxy.cpp:
2596         * src/WebArrayBufferView.cpp:
2597         * src/WebBindings.cpp:
2598         * src/WebDOMCustomEvent.cpp:
2599         * src/WebDOMMessageEvent.cpp:
2600         * src/WebFrameImpl.cpp:
2601         * src/WebHistoryItem.cpp:
2602         * src/WebIDBCallbacksImpl.cpp:
2603         * src/WebIntent.cpp:
2604         * src/WebIntentRequest.cpp:
2605         * src/WebSerializedScriptValue.cpp:
2606
2607 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2608
2609         [Chromium] Fix some #includes to headers in chromium/public/platform/ that have been moved to the new Platform directory
2610         https://bugs.webkit.org/show_bug.cgi?id=107722
2611
2612         Reviewed by Darin Fisher.
2613
2614         These headers just redirect to the new versions, so call the new
2615         versions directly.
2616
2617         * src/linux/WebFontInfo.cpp:
2618         * src/mac/WebSubstringUtil.mm:
2619
2620 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
2621
2622         [Chromium] Fix some #includes for WebSerializedScriptValue
2623         https://bugs.webkit.org/show_bug.cgi?id=107697
2624
2625         Reviewed by Adam Barth.
2626
2627         WebSerializedScriptValue has been moved to chromium/public/.
2628
2629         * public/WebDOMCustomEvent.h:
2630         * public/WebDOMMessageEvent.h:
2631         * public/WebIDBCursor.h:
2632
2633 2013-01-23  Dmitry Gozman  <dgozman@chromium.org>
2634
2635         Added changeAttachedWindowHeight method to inspector frontend API, which
2636         allows to change inspector window height from inside.
2637         https://bugs.webkit.org/show_bug.cgi?id=107648
2638
2639         Reviewed by Pavel Feldman.
2640
2641         * public/WebDevToolsFrontendClient.h:
2642         (WebKit::WebDevToolsFrontendClient::changeAttachedWindowHeight):
2643         * src/InspectorFrontendClientImpl.cpp:
2644         (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
2645
2646 2013-01-23  Shinya Kawanaka  <shinyak@chromium.org>
2647
2648         shadowAncestorNode() should be renamed to deprecatedShadowAncestorNode()
2649         https://bugs.webkit.org/show_bug.cgi?id=107624
2650
2651         Reviewed by Dimitri Glazkov.
2652
2653         Since Node::shadowAncestorNode() is deprecated, we would like to rename it to prevent from further use.
2654
2655         * src/WebFrameImpl.cpp:
2656         (WebKit::WebFrameImpl::scopeStringMatches):
2657         (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
2658
2659 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
2660
2661         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
2662         https://bugs.webkit.org/show_bug.cgi?id=107523
2663
2664         Reviewed by Yury Semikhatsky.
2665
2666         * public/WebDevToolsFrontendClient.h:
2667         (WebKit::WebDevToolsFrontendClient::isUnderTest):
2668         (WebDevToolsFrontendClient):
2669         * src/InspectorFrontendClientImpl.cpp:
2670         (WebKit::InspectorFrontendClientImpl::isUnderTest):
2671         * src/InspectorFrontendClientImpl.h:
2672         (InspectorFrontendClientImpl):
2673
2674 2013-01-22  Mark Lam  <mark.lam@apple.com>
2675
2676         Change the Supplementable class to not use AtomicString.
2677         https://bugs.webkit.org/show_bug.cgi?id=107535.
2678
2679         Reviewed by Adam Barth.
2680
2681         Replaced the use of AtomicString keys with literal const char* keys.
2682         This simplifies the SupplementMap and makes it slightly leaner and faster.
2683
2684         * src/ContextFeaturesClientImpl.cpp:
2685         (ContextFeaturesCache):
2686         (WebKit::ContextFeaturesCache::supplementName):
2687
2688 2013-01-22  Leandro Gracia Gil  <leandrogracia@chromium.org>
2689
2690         [Chromium] Expose didCommitCompositorFrame in WebWidgetClient.
2691         https://bugs.webkit.org/show_bug.cgi?id=107325
2692
2693         Reviewed by James Robinson.
2694
2695         Add a notification on WebWidgetClient called when the compositor commits a frame.
2696
2697         * public/WebWidgetClient.h:
2698         (WebWidgetClient):
2699         (WebKit::WebWidgetClient::didCommitCompositorFrame):
2700         * src/WebViewImpl.cpp:
2701         (WebKit::WebViewImpl::didCommit):
2702
2703 2013-01-21  Kentaro Hara  <haraken@chromium.org>
2704
2705         Implement UIEvent constructor
2706         https://bugs.webkit.org/show_bug.cgi?id=107430
2707
2708         Reviewed by Adam Barth.
2709
2710         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
2711
2712         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
2713         which is enabled on Safari and Chromium for now.
2714
2715         * features.gypi:
2716
2717 2013-01-22  Alpha Lam  <hclam@chromium.org>
2718
2719         REGRESSION(r140392): InjectIDBKeyTest.TopLevelPropertyStringValue is crashing
2720         https://bugs.webkit.org/show_bug.cgi?id=107578
2721
2722         Unreviewed build fix. Disabled 2 tests that are crashing after r140392.
2723
2724         * tests/IDBBindingUtilitiesTest.cpp:
2725         (WebKit::TEST_F):
2726
2727 2013-01-22  Eric Seidel  <eric@webkit.org>
2728
2729         Turn on ENABLE_THREADED_HTML_PARSER for Chromium (it's still disabled at runtime)
2730         https://bugs.webkit.org/show_bug.cgi?id=107519
2731
2732         Reviewed by Adam Barth.
2733
2734         This makes our development lives easier, and makes it possible for the bots
2735         to run threaded-parser-only tests by toggling the runtime enable
2736         via window.internals.settings.
2737
2738         * features.gypi:
2739
2740 2013-01-22  Kentaro Hara  <haraken@chromium.org>
2741
2742         [V8] Make an Isolate parameter mandatory in toV8()
2743         https://bugs.webkit.org/show_bug.cgi?id=107520
2744
2745         Reviewed by Adam Barth.
2746
2747         Now it's safe to remove an optional Isolate parameter.
2748
2749         No tests. No change in behavior.
2750
2751         * src/InspectorFrontendClientImpl.cpp:
2752         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
2753         * src/WebArrayBuffer.cpp:
2754         (WebKit::WebArrayBuffer::toV8Value):
2755         * src/WebBlob.cpp:
2756         (WebKit::WebBlob::toV8Value):
2757         * src/WebFrameImpl.cpp:
2758         (WebKit::WebFrameImpl::createFileSystem):
2759         (WebKit::WebFrameImpl::createSerializableFileSystem):
2760         (WebKit::WebFrameImpl::createFileEntry):
2761
2762 2013-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2763
2764         Unreviewed.  Rolled Chromium DEPS to r177962.  Requested by
2765         "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
2766
2767         * DEPS:
2768
2769 2013-01-21  Noel Gordon  <noel.gordon@gmail.com>
2770
2771         [chromium] REGRESSION(r139347) roll chromium deps broke webkit-unit-tests
2772         https://bugs.webkit.org/show_bug.cgi?id=106631
2773
2774         Reviewed by Kent Tamura.
2775
2776         Fixed in http://crrev.com/177931 and rolled. Renable these tests.
2777
2778         * tests/WebImageTest.cpp:
2779
2780 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
2781
2782         Add build flag for Canvas's Path object (disabled by default)
2783         https://bugs.webkit.org/show_bug.cgi?id=107473
2784
2785         Reviewed by Dean Jackson.
2786
2787         Add CANVAS_PATH build flag to build systems.
2788
2789         * features.gypi:
2790
2791 2013-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2792
2793         Unreviewed.  Rolled Chromium DEPS to r177956.  Requested by
2794         thakis_ via sheriffbot.
2795
2796         * DEPS:
2797
2798 2013-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2799
2800         Unreviewed.  Rolled Chromium DEPS to r177953.  Requested by
2801         thakis_ via sheriffbot.
2802
2803         * DEPS:
2804
2805 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
2806
2807         MediaStream API: Update the RTCPeerConnection states to match the latest specification
2808         https://bugs.webkit.org/show_bug.cgi?id=107120
2809
2810         Reviewed by Adam Barth.
2811
2812         * src/AssertMatchingEnums.cpp:
2813
2814 2013-01-20  Dominic Mazzoni  <dmazzoni@google.com>
2815
2816         Make SpeechSynthesis compile in the Chromium port
2817         https://bugs.webkit.org/show_bug.cgi?id=107382
2818
2819         Reviewed by Adam Barth.
2820
2821         Add ENABLE_SPEECH_SYNTHESIS to features.gypi, off by default.
2822
2823         * features.gypi:
2824
2825 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
2826
2827         Dragging over an element with scrollbars should scroll the element when dragging near edges
2828         https://bugs.webkit.org/show_bug.cgi?id=39725
2829
2830         Reviewed by Hajime Morita.
2831
2832         This patch removes DragScrollTimer used for automatic scrolling of main
2833         frame drag-and-drop which is now implemented in EventHandler.
2834
2835         Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
2836         make patch size small.
2837
2838         No tests. Existing test covers this change.
2839
2840         * src/ChromeClientImpl.cpp:
2841         (WebKit::ChromeClientImpl::shouldAutoscrollForDragAndDrop): Added.
2842         * src/ChromeClientImpl.h:
2843         (ChromeClientImpl): Changed to add shouldAutoscrollForDragAndDrop().
2844         * src/WebViewImpl.cpp:
2845         (WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
2846         (WebKit::WebViewImpl::dragSourceEndedAt): ditto
2847         (WebKit::WebViewImpl::dragSourceMovedTo): ditto
2848         (WebKit::WebViewImpl::dragTargetDrop): ditto
2849         (WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto
2850         * src/WebViewImpl.h:
2851         (WebKit): Chagned to remove DragScrollTimer.
2852
2853 2013-01-18  Alec Flett  <alecflett@chromium.org>
2854
2855         IndexedDB: Switch to new createTransaction call
2856         https://bugs.webkit.org/show_bug.cgi?id=107311
2857
2858         Reviewed by Tony Chang.
2859
2860         * public/WebIDBTransaction.h:
2861
2862         Remove an old method that nobody calls.
2863
2864 2013-01-18  Alpha Lam  <hclam@chromium.org>
2865
2866         [chromium] Roll Chromium DEPS to 177676
2867
2868         Unreviewed DEPS roll.
2869
2870         * DEPS:
2871
2872 2013-01-18  Robert Kroeger  <rjkroege@chromium.org>
2873
2874         [chromium] Use new-style gesture scrolling events for fling and
2875         for plugin scrolling: https://bugs.webkit.org/show_bug.cgi?id=106589
2876
2877         Reviewed by James Robinson.
2878
2879         https://bugs.webkit.org/show_bug.cgi?id=103952 modified touchscreen
2880         scrolling to not use synthetic mouse wheel events. Update the fling facility
2881         in WebViewImpl to use these events for touchscreen-initiated flings. Also
2882         modify the WebPluginContainerImpl to scroll in response to touchscreen
2883         scroll gestures if the plugin does not itself implement gesture events. 
2884
2885         * src/WebPluginContainerImpl.cpp:
2886         * src/WebViewImpl.cpp:
2887         (WebKit::WebViewImpl::WebViewImpl):
2888         (WebKit::WebViewImpl::scrollBy): Handle fling callback conditionally based
2889         on initiating device. Touchpad flings generate wheels. Touchscreen flings
2890         use gesture events.
2891         (WebKit::WebViewImpl::handleGestureEvent):
2892         (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
2893         * src/WebViewImpl.h:
2894
2895 2013-01-18  Seokju Kwon  <seokju.kwon@gmail.com>
2896
2897         Add explicit keyword to constructors in platform-specific InspectorClient
2898         https://bugs.webkit.org/show_bug.cgi?id=107255
2899
2900         Reviewed by Kentaro Hara.
2901
2902         Add explicit keyword to constructors that take one argument
2903         in platform-specific implementation of InspectorClient.
2904
2905         * src/InspectorClientImpl.h:
2906         (InspectorClientImpl):
2907
2908 2013-01-17  Dominic Cooney  <dominicc@chromium.org>
2909
2910         [Chromium] Unreviewed gardening.
2911
2912         Roll Chromium to 177561.
2913
2914         * DEPS:
2915
2916 2013-01-17  Alpha Lam  <hclam@chromium.org>
2917
2918         [chromium] Disable a unit test
2919         https://bugs.webkit.org/show_bug.cgi?id=107206
2920
2921         Unreviewed. Disable a failing test due to 140025.
2922
2923         * tests/WebFrameTest.cpp:
2924
2925 2013-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2926
2927         Unreviewed, rolling out r140023.
2928         http://trac.webkit.org/changeset/140023
2929         https://bugs.webkit.org/show_bug.cgi?id=107176
2930
2931         Broke some tests (Requested by anttik on #webkit).
2932
2933         * tests/RenderTableCellTest.cpp:
2934         * tests/RenderTableRowTest.cpp:
2935
2936 2013-01-17  John Mellor  <johnme@chromium.org>
2937
2938         [chromium] Double-tap zoom should take into account accessibility fontScaleFactor
2939         https://bugs.webkit.org/show_bug.cgi?id=107123
2940
2941         Reviewed by Adam Barth.
2942
2943         Platforms which support Text Autosizing (currently just Chrome for
2944         Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0).
2945
2946         This value is intended to be chosen by the user to indicate how large
2947         they want text to appear, for example Chrome for Android has a "Text
2948         scaling" slider in Settings > Accessibility that lets you choose a value
2949         in the range 50% - 200% (defaults to 100%*).
2950
2951         For text in wide columns that typically gets autosized, this value is
2952         applied by multiplying the textAutosizingMultiplier computed for each
2953         cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit
2954         the column to the screen (ignoring the textAutosizingFontScaleFactor)
2955         since the column is wide. This part already works.
2956
2957         For text in narrow columns that doesn't get autosized, the
2958         textAutosizingFontScaleFactor is not applied through Text Autosizing,
2959         and instead needs to be applied by adjusting the double-tap zoom level.
2960         When double-tapping on narrow columns, instead of fitting the column to
2961         the screen (which would often zoom in excessively far), the existing
2962         logic in computeScaleAndScrollForHitRect applies a maximum zoom level
2963         called the legibleScale. This value needs to be multiplied by the
2964         textAutosizingFontScaleFactor, so that we zoom in proportionately
2965         further on non-autosized narrow columns, hence the effective text size
2966         (taking into account zoom) will have increased in proportion to the
2967         textAutosizingFontScaleFactor as expected.
2968
2969         * src/WebViewImpl.cpp:
2970         (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
2971             Multiplies legibleScale (the maximum zoom level) by the
2972             textAutosizingFontScaleFactor.
2973         * tests/WebFrameTest.cpp:
2974             Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on
2975             WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction
2976             between textAutosizingFontScaleFactor and the double-tap zoom logic.
2977             Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest.
2978
2979 2013-01-17  Alexandre Elias  <aelias@chromium.org>
2980
2981         [chromium] Make new-style page scale work with fixed layout
2982         https://bugs.webkit.org/show_bug.cgi?id=106951
2983
2984         Reviewed by Adam Barth.
2985
2986         This makes non-CSS-transform page scaling work with fixed-layout mode,
2987         including viewport tag support.
2988
2989         - dispatchViewportPropertiesDidChange() now works entirely with DIP
2990         pixels instead of physical pixels, and is made compatible with
2991         separating deviceScaleFactor from pageScaleFactor.
2992
2993         - In this mode, the "layout viewport" size in the pinch-zoom model is
2994         made a first-class concept separate from the device size.  This
2995         is a viewport with the same aspect ratio as the device but with the
2996         layout width of the page.  This viewport is used:
2997           - As FrameView::visibleContentRect.
2998           - Returned from WebView::size().
2999           - Given to the compositor as layoutViewportSize.
3000
3001         - m_deviceScaleInCompositor is deleted as it's clearer to use the
3002         applyDeviceScaleInCompositor setting directly.
3003
3004         * src/ChromeClientImpl.cpp:
3005         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3006         * src/WebViewImpl.cpp:
3007         (WebKit::WebViewImpl::WebViewImpl):
3008         (WebKit::WebViewImpl::size):
3009         (WebKit):
3010         (WebKit::WebViewImpl::resize):
3011         (WebKit::WebViewImpl::setPageScaleFactor):
3012         (WebKit::WebViewImpl::setDeviceScaleFactor):
3013         (WebKit::WebViewImpl::layoutSize):
3014         (WebKit::WebViewImpl::computePageScaleFactorLimits):
3015         (WebKit::WebViewImpl::dipSize):
3016         (WebKit::WebViewImpl::didChangeContentsSize):
3017         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3018         (WebKit::WebViewImpl::updateLayerTreeViewport):
3019         * src/WebViewImpl.h:
3020         (WebViewImpl):
3021
3022 2013-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3023
3024         Unreviewed.  Rolled Chromium DEPS to r177369.  Requested by
3025         ajuma via sheriffbot.
3026
3027         * DEPS:
3028
3029 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
3030
3031         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3032         https://bugs.webkit.org/show_bug.cgi?id=104545
3033
3034         Reviewed by Yury Semikhatsky.
3035
3036         Adopt changes: mimic old behavior.
3037
3038         * src/WebDevToolsAgentImpl.cpp: Adopt signature changes.
3039
3040 2013-01-17  Yury Semikhatsky  <yurys@chromium.org>
3041
3042         Web Inspector: add WebDeToolsAgentImpl as task observer on reattach
3043         https://bugs.webkit.org/show_bug.cgi?id=107106
3044
3045         Reviewed by Pavel Feldman.
3046
3047         Register WebDevToolsAgentImpl as task observer when it client is reattached.
3048
3049         * src/WebDevToolsAgentImpl.cpp:
3050         (WebKit::WebDevToolsAgentImpl::reattach):
3051
3052 2013-01-16  Dominic Cooney   <dominicc@chromium.org>
3053
3054         [Chromium] Unreviewed gardening.
3055
3056         Roll Chromium to 177350.
3057
3058         * DEPS:
3059
3060 2013-01-16  Kristian Monsen  <kristianm@google.com>
3061
3062         Fix build break for Android webview.
3063         https://bugs.webkit.org/show_bug.cgi?id=107072
3064
3065         Reviewed by Steve Block.
3066
3067         Add extra guards when checking for OS=="Android" to make sure it is not included
3068         for webview.
3069
3070         * WebKitUnitTests.gyp:
3071
3072 2013-01-16  Dominic Cooney  <dominicc@chromium.org>
3073
3074         [Chromium] Unreviewed gardening.
3075
3076         Roll Chromium to 177310.
3077
3078         * DEPS:
3079
3080 2013-01-16  W. James MacLean  <wjmaclean@chromium.org>
3081
3082         LinkHighlight should use touch adjustment to match active state on GestureTapDown.
3083         https://bugs.webkit.org/show_bug.cgi?id=107032
3084
3085         Reviewed by Adam Barth.
3086
3087         LinkHighlight node selection should produce results that match the node marked
3088         active during GestureTapDown.
3089
3090         * src/WebViewImpl.cpp:
3091         (WebKit::WebViewImpl::bestTouchLinkNode):
3092         * tests/LinkHighlightTest.cpp:
3093         (WebCore::TEST):
3094
3095 2013-01-16  Kentaro Hara  <haraken@chromium.org>
3096
3097         [V8] Make a creationContext parameter of toV8() mandatory
3098         https://bugs.webkit.org/show_bug.cgi?id=107020
3099
3100         Reviewed by Adam Barth.
3101
3102         We pass Handle<Object>() to a creationContext parameter of
3103         toV8() when we do not have a creationContext.
3104
3105         No tests. No change in behavior.
3106
3107         * src/InspectorFrontendClientImpl.cpp:
3108         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3109         * src/WebArrayBuffer.cpp:
3110         (WebKit::WebArrayBuffer::toV8Value):
3111         * src/WebBlob.cpp:
3112         (WebKit::WebBlob::toV8Value):
3113         * src/WebFrameImpl.cpp:
3114         (WebKit::WebFrameImpl::createFileSystem):
3115         (WebKit::WebFrameImpl::createSerializableFileSystem):
3116         (WebKit::WebFrameImpl::createFileEntry):
3117
3118 2013-01-16  Mark Pilgrim  <pilgrim@chromium.org>
3119
3120         [Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
3121         https://bugs.webkit.org/show_bug.cgi?id=106863
3122
3123         Reviewed by Adam Barth.
3124
3125         These are not being moved into the new top-level Platform
3126         directory, so into public they go.
3127
3128         * WebKit.gyp:
3129         * public/WebArrayBufferView.h: Added.
3130         (v8):
3131         (WebKit):
3132         (WebArrayBufferView):
3133         (WebKit::WebArrayBufferView::~WebArrayBufferView):
3134         (WebKit::WebArrayBufferView::WebArrayBufferView):
3135         * public/WebSerializedScriptValue.h: Added.
3136         (v8):
3137         (WebKit):
3138         (WebSerializedScriptValue):
3139         (WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
3140         (WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
3141         (WebKit::WebSerializedScriptValue::operator=):
3142         (WebKit::WebSerializedScriptValue::isNull):
3143         * public/platform/WebArrayBufferView.h:
3144         * public/platform/WebSerializedScriptValue.h:
3145
3146 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
3147
3148         [Chromium] Remove hardcoded chromium_*.jar in gyp files
3149         https://bugs.webkit.org/show_bug.cgi?id=104049
3150
3151         Reviewed by Eric Seidel.
3152
3153         Targets with dependencies (direct/indirect) on a java target receive
3154         the chromium_*.jar paths in the variable input_jars_paths. Targets
3155         should use that rather than hardcoding where they think the jar will
3156         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
3157         than as --jars to generate_native_test.py.
3158
3159         * WebKitUnitTests.gyp:
3160
3161 2013-01-16  Dominic Cooney   <dominicc@chromium.org>
3162
3163         [Chromium] Unreviewed gardening.
3164
3165         Roll Chromium to 177117.
3166
3167         * DEPS:
3168
3169 2013-01-16  Dominic Cooney  <dominicc@chromium.org>
3170
3171         [Chromium] Unreviewed gardening.
3172
3173         Roll Chromium to r177080.
3174
3175         * DEPS:
3176
3177 2013-01-15  Ian Vollick  <vollick@chromium.org>
3178
3179         [chromium] Create GraphicsLayerChromiums using a factory
3180         https://bugs.webkit.org/show_bug.cgi?id=103635
3181
3182         Reviewed by James Robinson.
3183
3184         Refactor graphics layer creation for chromium to go through a factory.
3185
3186         * src/ChromeClientImpl.cpp:
3187         (WebCore):
3188         (GraphicsLayerFactoryChromium):
3189         (WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
3190         (WebKit::ChromeClientImpl::ChromeClientImpl):
3191         (WebKit::ChromeClientImpl::graphicsLayerFactory):
3192         (WebKit):
3193         * src/ChromeClientImpl.h:
3194         (WebCore):
3195         (ChromeClientImpl):
3196         * src/NonCompositedContentHost.cpp:
3197         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
3198         * src/NonCompositedContentHost.h:
3199         (WebCore):
3200         (WebKit::NonCompositedContentHost::create):
3201         (NonCompositedContentHost):
3202         * src/PageOverlay.cpp:
3203         (WebKit::PageOverlay::update):
3204         * src/WebViewImpl.cpp:
3205         (WebKit::WebViewImpl::graphicsLayerFactory):
3206         (WebKit):
3207         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3208         * src/WebViewImpl.h:
3209         (WebCore):
3210         (WebViewImpl):
3211         * tests/GraphicsLayerChromiumTest.cpp:
3212         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
3213         * tests/ImageLayerChromiumTest.cpp:
3214         (WebCore::TEST):
3215
3216 2013-01-15  Mark Pilgrim  <pilgrim@chromium.org>
3217
3218         [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform
3219         https://bugs.webkit.org/show_bug.cgi?id=106899
3220
3221         Reviewed by Adam Barth.
3222
3223         Part of a larger refactoring series; see tracking bug 106829.
3224
3225         * WebKit.gyp:
3226         * src/SocketStreamHandle.cpp: Removed.
3227         * src/SocketStreamHandleInternal.h: Removed.
3228
3229 2013-01-15  Florin Malita  <fmalita@chromium.org>
3230
3231         [Chromium] Incorrect opaque region tracking for PlatformContextSkia::drawRRect
3232         https://bugs.webkit.org/show_bug.cgi?id=106898
3233
3234         Reviewed by Stephen White.
3235
3236         * tests/PlatformContextSkiaTest.cpp:
3237         (WebCore::TEST):
3238         (WebCore):
3239
3240 2012-12-28  Vsevolod Vlasov  <vsevik@chromium.org>
3241
3242         Web Inspector: Support inspector file system access with isolated file system through InspectorFrontendHost.
3243         https://bugs.webkit.org/show_bug.cgi?id=105727
3244
3245         Reviewed by Pavel Feldman.
3246
3247         File system access methods plumbing made for Chromium.
3248
3249         * public/WebDevToolsFrontendClient.h:
3250         (WebKit::WebDevToolsFrontendClient::requestFileSystems):
3251         (WebKit::WebDevToolsFrontendClient::addFileSystem):
3252         (WebKit::WebDevToolsFrontendClient::removeFileSystem):
3253         (WebDevToolsFrontendClient):
3254         * src/InspectorFrontendClientImpl.cpp:
3255         (WebKit::InspectorFrontendClientImpl::supportsFileSystems):
3256         (WebKit):
3257         (WebKit::InspectorFrontendClientImpl::requestFileSystems):
3258         (WebKit::InspectorFrontendClientImpl::addFileSystem):
3259         (WebKit::InspectorFrontendClientImpl::removeFileSystem):
3260         * src/InspectorFrontendClientImpl.h:
3261         (InspectorFrontendClientImpl):
3262
3263 2013-01-14  Dominic Cooney  <dominicc@chromium.org>
3264
3265         [Chromium] Unreviewed gardening.
3266
3267         Roll Chromium to r176801.
3268
3269         * DEPS: Rollin' on the river.
3270
3271 2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
3272
3273         [Chromium] Remove unused public/platform/WebColorName.h
3274         https://bugs.webkit.org/show_bug.cgi?id=106865
3275
3276         Reviewed by Adam Barth.
3277
3278         This file is no longer referenced anywhere in WebKit or Chromium.
3279
3280         * public/platform/WebColorName.h: Removed.
3281
3282 2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
3283
3284         [Chromium] Move BlobRegistryProxy into WebCore
3285         https://bugs.webkit.org/show_bug.cgi?id=106831
3286
3287         Reviewed by Adam Barth.
3288
3289         Part of a larger refactoring series to remove layering violations
3290         in Chromium. See tracking bug 106829.
3291
3292         * WebKit.gyp:
3293         * src/BlobRegistryProxy.cpp: Removed.
3294         * src/BlobRegistryProxy.h: Removed.
3295
3296 2013-01-14  Alec Flett  <alecflett@chromium.org>
3297
3298         IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
3299         https://bugs.webkit.org/show_bug.cgi?id=106605
3300
3301         Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
3302         as they no longer exist in WebCore.
3303
3304         Reviewed by Darin Fisher.
3305
3306         * WebKit.gyp:
3307         * public/WebIDBCallbacks.h:
3308         (WebKit):
3309         * public/WebIDBDatabase.h:
3310         (WebKit):
3311         (WebKit::WebIDBDatabase::metadata):
3312         * public/WebIDBFactory.h:
3313         (WebIDBFactory):
3314         * public/WebIDBIndex.h: Removed.
3315         * public/WebIDBObjectStore.h: Removed.
3316         * public/WebIDBTransaction.h:
3317         * src/IDBCallbacksProxy.cpp:
3318         * src/IDBDatabaseBackendProxy.cpp:
3319         * src/IDBDatabaseBackendProxy.h:
3320         (IDBDatabaseBackendProxy):
3321         * src/IDBFactoryBackendProxy.cpp:
3322         * src/IDBFactoryBackendProxy.h:
3323         (IDBFactoryBackendProxy):
3324         * src/IDBIndexBackendProxy.cpp: Removed.
3325         * src/IDBIndexBackendProxy.h: Removed.
3326         * src/IDBObjectStoreBackendProxy.cpp: Removed.
3327         * src/IDBObjectStoreBackendProxy.h: Removed.
3328         * src/IDBTransactionBackendProxy.cpp:
3329         * src/IDBTransactionBackendProxy.h:
3330         (IDBTransactionBackendProxy):
3331         * src/WebIDBDatabaseImpl.cpp:
3332         (WebKit::WebIDBDatabaseImpl::put):
3333         (WebKit::WebIDBDatabaseImpl::setIndexKeys):
3334         * src/WebIDBDatabaseImpl.h:
3335         (WebKit):
3336         (WebIDBDatabaseImpl):
3337         * src/WebIDBFactoryImpl.cpp:
3338         (WebKit::WebIDBFactoryImpl::getDatabaseNames):
3339         * src/WebIDBFactoryImpl.h:
3340         (WebIDBFactoryImpl):
3341         * src/WebIDBIndexImpl.cpp: Removed.
3342         * src/WebIDBIndexImpl.h: Removed.
3343         * src/WebIDBObjectStoreImpl.cpp: Removed.
3344         * src/WebIDBObjectStoreImpl.h: Removed.
3345         * src/WebIDBTransactionImpl.cpp:
3346         * src/WebIDBTransactionImpl.h:
3347         * tests/IDBAbortOnCorruptTest.cpp:
3348         (WebCore::TEST):
3349         * tests/IDBDatabaseBackendTest.cpp:
3350
3351 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3352
3353         AX: Need to implement ColorWellRole
3354         https://bugs.webkit.org/show_bug.cgi?id=106756
3355
3356         Reviewed by Chris Fleizach.
3357
3358         Adds an accessibility interface to access the value of a
3359         color control.
3360
3361         * public/WebAccessibilityObject.h:
3362         (WebAccessibilityObject):
3363         * src/WebAccessibilityObject.cpp:
3364         (WebKit::WebAccessibilityObject::colorValue):
3365         (WebKit):
3366
3367 2013-01-14  Mark Pilgrim  <pilgrim@chromium.org>
3368
3369         [Chromium] Move AudioDestinationChromium into WebCore
3370         https://bugs.webkit.org/show_bug.cgi?id=106803
3371
3372         Reviewed by Adam Barth.
3373
3374         This doesn't really belong in WebKit/chromium/src since it defines
3375         things directly in the WebCore namespace.
3376
3377         * WebKit.gyp:
3378         * src/AudioDestinationChromium.cpp: Removed.
3379         * src/AudioDestinationChromium.h: Removed.
3380
3381 2013-01-14  Stephen Chenney  <schenney@chromium.org>
3382
3383         Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia
3384
3385         Unreviewed build fix.
3386
3387         It turns out that the change behind this flag causes crashes and image errors.
3388
3389         * skia_webkit.gyp:
3390
3391 2013-01-14  Kentaro Hara  <haraken@chromium.org>
3392
3393         [V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
3394         https://bugs.webkit.org/show_bug.cgi?id=106779
3395
3396         Reviewed by Adam Barth.
3397
3398         This is one of steps to make an Isolate parameter mandatory.
3399
3400         No tests. No change in behavior.
3401
3402         * src/WebDevToolsAgentImpl.cpp:
3403         (WebKit::WebDevToolsAgent::interruptAndDispatch):
3404
3405 2013-01-13  Vsevolod Vlasov  <vsevik@chromium.org>
3406
3407         Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
3408         https://bugs.webkit.org/show_bug.cgi?id=106755
3409
3410         Reviewed by Alexander Pavlov.
3411
3412         * src/js/Tests.js:
3413         (.TestSuite.prototype.nonAnonymousUISourceCodes_.filterOutService):
3414         (.TestSuite.prototype.nonAnonymousUISourceCodes_):
3415
3416 2013-01-12  David Grogan  <dgrogan@chromium.org>
3417
3418         Unreviewed.  Roll chromium DEPS to 176595.
3419         https://bugs.webkit.org/show_bug.cgi?id=106730
3420
3421         * DEPS:
3422
3423 2013-01-11  Dan Beam  <dbeam@chromium.org>
3424
3425         [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
3426         https://bugs.webkit.org/show_bug.cgi?id=106610
3427
3428         Reviewed by Darin Fisher.
3429
3430         * public/WebFormElement.h: Removed WebFormElement::AutocompleteResultError in favor of more specific error reasons.
3431         * src/AssertMatchingEnums.cpp: Removed enum value from compile-time asserts.
3432
3433 2013-01-11  Tien-Ren Chen  <trchen@chromium.org>
3434
3435         WebWidgetClient::didHandleGestureEvent needs to distinguish the case if the event is processed or swallowed
3436         https://bugs.webkit.org/show_bug.cgi?id=104427
3437
3438         Reviewed by Adam Barth.
3439
3440         When a gesture needs to be disambiguated, WebKit doesn't update cursor focus.
3441         We added an extra status for didHandleGestureEvent(), so we can distinguish
3442         the case whether the event is actually delivered to the web page or cancelled.
3443
3444         * public/WebViewClient.h:
3445         * public/WebWidgetClient.h:
3446         (WebKit):
3447         (WebWidgetClient):
3448         (WebKit::WebWidgetClient::didHandleGestureEvent):
3449         * src/WebViewImpl.cpp:
3450         (WebKit::WebViewImpl::handleGestureEvent):
3451         * tests/WebViewTest.cpp:
3452
3453 2013-01-11  Eberhard Graether  <egraether@google.com>
3454
3455         [chromium] Add ContinuousPainter to call setNeedsDisplay on all layers recursively in continuous painting mode
3456         https://bugs.webkit.org/show_bug.cgi?id=105458
3457
3458         Reviewed by James Robinson.
3459
3460         In continuous painting mode all layers are constantly repainted to allow for life measurements of page paint time,
3461         while changing HTML and CSS using the WebInspector. This change adds the ContinuousPainter helper object, which
3462         calls setNeedsDisplay() on all GraphicsLayers recursively in order to force all layers to repaint. PageOverlay
3463         layers get excluded from being repainted, because their extra paint time is altering the page paint time metric.
3464
3465         * WebKit.gyp:
3466         * src/PageOverlay.h:
3467         (WebKit::PageOverlay::graphicsLayer):
3468         (PageOverlay):
3469         * src/PageOverlayList.cpp:
3470         (WebKit::PageOverlayList::findGraphicsLayer):
3471         (WebKit):
3472         * src/PageOverlayList.h:
3473         (WebCore):
3474         (PageOverlayList):
3475         * src/WebViewImpl.cpp:
3476         (WebKit::WebViewImpl::WebViewImpl):
3477         (WebKit::WebViewImpl::didBeginFrame):
3478         * src/WebViewImpl.h:
3479         * src/painting/ContinuousPainter.cpp: Copied from Source/WebKit/chromium/src/PageOverlay.h.
3480         (WebKit):
3481         (WebKit::ContinuousPainter::setNeedsDisplayRecursive):
3482         * src/painting/ContinuousPainter.h: Copied from Source/WebKit/chromium/src/PageOverlay.h.
3483         (WebCore):
3484         (WebKit):
3485         (ContinuousPainter):
3486
3487 2013-01-11  Tony Chang  <tony@chromium.org>
3488
3489         Unreviewed, revert r139157 to fix the chromium build.
3490         These files were deleted in a follow up and since r139044 was reverted, we need to
3491         add back these files.
3492
3493         * WebKit.gyp:
3494         * src/DragScrollTimer.cpp: Added.
3495         (WebKit):
3496         (WebKit::distanceToRect):
3497         (WebKit::DragScrollTimer::DragScrollTimer):
3498         (WebKit::DragScrollTimer::~DragScrollTimer):