1 2013-03-04 Andrey Lushnikov <lushnikov@chromium.org>
3 Web Inspector: add runtime flag to determine if inspector's source files were flattened.
4 https://bugs.webkit.org/show_bug.cgi?id=111184
6 Reviewed by Pavel Feldman.
8 Included "buildSystemOnly.js" in devtools.html by generate_devtools_html.py script.
11 * scripts/generate_devtools_html.py: Add script tag to include buildSystemOnly.js
12 (write_devtools_html):
14 2013-03-03 Alexandre Elias <aelias@chromium.org>
16 [chromium] Remove WebLayerTreeView::setViewportSize call
17 https://bugs.webkit.org/show_bug.cgi?id=110727
19 Reviewed by James Robinson.
21 After https://codereview.chromium.org/12328080 lands,
22 setViewportSize is called from the Chromium side. The multiplication
23 by deviceScaleFactor here was prone to off-by-one errors.
24 The layoutSize() function was only used here so delete it as well.
26 DumpRenderTree WebViewHost must now call this method as well.
28 * src/WebViewImpl.cpp:
29 (WebKit::WebViewImpl::updateLayerTreeViewport):
33 2013-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
35 Unreviewed, rolling out r144567.
36 http://trac.webkit.org/changeset/144567
37 https://bugs.webkit.org/show_bug.cgi?id=111266
39 Does not compile on apple-win (Requested by abarth on
43 * src/WebFrameImpl.cpp:
44 (WebKit::WebFrameImpl::iconURLs):
48 2013-03-03 Mike West <mkwst@chromium.org>
50 CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
51 https://bugs.webkit.org/show_bug.cgi?id=111254
53 Reviewed by Adam Barth.
55 The enum names no longer made sense: the difference between the
56 canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
57 prefix, not the functionality. This patch renames them for clarity.
59 * public/WebContentSecurityPolicy.h:
60 * src/AssertMatchingEnums.cpp:
61 Rename the Chromium side of the enums.
63 2013-03-03 Adam Barth <abarth@webkit.org>
65 Unreviewed attempted build fix. Adds back some includes removed in
66 http://trac.webkit.org/changeset/144565.
68 * src/ApplicationCacheHost.cpp:
69 * src/AssociatedURLLoader.cpp:
70 * src/EditorClientImpl.cpp:
71 * src/SharedWorkerRepository.cpp:
72 * src/WebDataSourceImpl.cpp:
76 * src/WebSharedWorkerImpl.cpp:
77 * tests/FrameLoaderClientImplTest.cpp:
79 2013-03-03 Adam Barth <abarth@webkit.org>
81 Unreviewed rollout of http://trac.webkit.org/r144530
82 As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
83 https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
84 large number of ASSERTs in chromium-win.
86 * src/ApplicationCacheHost.cpp:
87 * src/AssociatedURLLoader.cpp:
88 * src/EditorClientImpl.cpp:
89 * src/SharedWorkerRepository.cpp:
90 * src/WebDataSourceImpl.cpp:
94 * src/WebSharedWorkerImpl.cpp:
95 * tests/FrameLoaderClientImplTest.cpp:
97 2013-03-03 Ankur Taly <ataly@google.com>
99 WebKit API for enabling DOM logging for certain worlds
100 https://bugs.webkit.org/show_bug.cgi?id=110779
102 Reviewed by Kentaro Hara.
106 2013-03-03 James Weatherall <wez@chromium.org>
108 keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
109 https://bugs.webkit.org/show_bug.cgi?id=85642
111 Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.
113 Reviewed by Adam Barth.
116 * tests/KeyCodeConversionTestGtk.cpp: Added.
120 2013-02-18 Darin Adler <darin@apple.com>
122 Cut down the number of source files that depend on Clipboard.h
123 https://bugs.webkit.org/show_bug.cgi?id=110030
125 Reviewed by Ryosuke Niwa.
127 * src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h
128 here. We used to get this indirectly through Clipboard.h.
130 2013-02-28 Alexey Proskuryakov <ap@apple.com>
132 Reduce amount of rebuilding when touching networking headers
133 https://bugs.webkit.org/show_bug.cgi?id=111035
135 Reviewed by Eric Seidel.
137 Adding includes that are now necessary because WebCore headers don't have them
140 * src/ApplicationCacheHost.cpp:
141 * src/AssociatedURLLoader.cpp:
142 * src/EditorClientImpl.cpp:
143 * src/SharedWorkerRepository.cpp:
144 * src/WebDataSourceImpl.cpp:
145 * src/WebFrameImpl.h:
147 * src/WebSharedWorkerImpl.cpp:
148 * tests/FrameLoaderClientImplTest.cpp:
150 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
152 Unreviewed. Rolled Chromium DEPS to r185662. Requested by
153 "James Robinson" <jamesr@chromium.org> via sheriffbot.
157 2013-03-01 Terry Anderson <tdanderson@chromium.org>
159 EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
160 so its behavior matches other user-initiated scrolls
161 https://bugs.webkit.org/show_bug.cgi?id=109769
163 Reviewed by James Robinson.
165 Clear the nodes corresponding to a fling scroll event when the event ends.
167 * src/WebViewImpl.cpp:
168 (WebKit::WebViewImpl::updateAnimations):
170 2013-03-01 David Dorwin <ddorwin@chromium.org>
172 [chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
173 https://bugs.webkit.org/show_bug.cgi?id=111232
175 Reviewed by Adam Barth.
177 This patch reverts r143827, which causes a crash in failure conditions:
178 http://crbug.com/178848
180 * src/WebHelperPluginImpl.cpp:
181 (WebKit::WebHelperPluginImpl::destoryPage):
183 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
185 Unreviewed, rolling out r144422 and r144424.
186 http://trac.webkit.org/changeset/144422
187 http://trac.webkit.org/changeset/144424
188 https://bugs.webkit.org/show_bug.cgi?id=111167
190 Caused over 20 tests to fail assertion on Chromium Win port as
191 ASSERTION FAILED: m_platformRequestUpdated (Requested by
192 toyoshim on #webkit).
194 * src/ApplicationCacheHost.cpp:
195 * src/AssociatedURLLoader.cpp:
196 * src/EditorClientImpl.cpp:
197 * src/SharedWorkerRepository.cpp:
198 * src/WebDataSourceImpl.cpp:
199 * src/WebFrameImpl.h:
202 * src/WebSharedWorkerImpl.cpp:
203 * tests/FrameLoaderClientImplTest.cpp:
205 2013-03-01 Jochen Eisinger <jochen@chromium.org>
207 REGRESSION(r144422): Broke compilation on chromium-mac
208 https://bugs.webkit.org/show_bug.cgi?id=111150
210 Unreviewed build fix.
212 * src/WebFrameImpl.h:
215 2013-02-28 Alexey Proskuryakov <ap@apple.com>
217 Reduce amount of rebuilding when touching networking headers
218 https://bugs.webkit.org/show_bug.cgi?id=111035
220 Reviewed by Eric Seidel.
222 Adding includes that are now necessary because WebCore headers don't have them
225 * src/ApplicationCacheHost.cpp:
226 * src/AssociatedURLLoader.cpp:
227 * src/EditorClientImpl.cpp:
228 * src/SharedWorkerRepository.cpp:
229 * src/WebDataSourceImpl.cpp:
230 * src/WebFrameImpl.h:
232 * src/WebSharedWorkerImpl.cpp:
233 * tests/FrameLoaderClientImplTest.cpp:
235 2013-02-28 Ankur Taly <ataly@google.com>
237 WebKit API for enabling DOM logging for certain worlds
238 https://bugs.webkit.org/show_bug.cgi?id=110779
240 Reviewed by Adam Barth.
242 This patch adds initial plumbing for enabling logging of DOM
243 activity by JavaScript code running withing v8, on a
244 per-world basis. In particular it adds methods to the chromium
245 WebKit API for associating a logger object with world ids for which
246 DOM activity logging is enabled.
250 * public/WebDOMActivityLogger.h: Added.
253 (WebDOMActivityLogger):
254 (WebKit::WebDOMActivityLogger::~WebDOMActivityLogger):
255 (WebKit::WebDOMActivityLogger::log):
256 * src/WebDOMActivityLogger.cpp: Added.
258 (DOMActivityLoggerContainer):
259 (WebKit::DOMActivityLoggerContainer::DOMActivityLoggerContainer):
260 (WebKit::DOMActivityLoggerContainer::~DOMActivityLoggerContainer):
261 (WebKit::DOMActivityLoggerContainer::log):
262 (WebKit::hasDOMActivityLogger):
263 (WebKit::setDOMActivityLogger):
265 2013-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
267 Unreviewed. Rolled Chromium DEPS to r185341. Requested by
268 "James Robinson" <jamesr@chromium.org> via sheriffbot.
272 2013-02-28 Varun Jain <varunjain@chromium.org>
274 Add new webkit API to invoke a context menu.
275 https://bugs.webkit.org/show_bug.cgi?id=111040
277 Reviewed by Adam Barth.
281 * src/WebViewImpl.cpp:
282 (WebKit::WebViewImpl::showContextMenu):
286 2013-02-28 Aaron Colwell <acolwell@chromium.org>
288 Factor SourceBuffer methods out of MediaSourcePrivate & WebMediaSource
289 into SourceBufferPrivate & WebSourceBuffer respectively.
290 https://bugs.webkit.org/show_bug.cgi?id=110798
292 Reviewed by Adam Barth, Jer Noble.
295 * public/WebMediaSourceClient.h:
297 (WebMediaSourceClient):
298 * public/WebSourceBuffer.h:
300 (WebSourceBuffer): Contains SourceBuffer methods extracted from WebMediaSource.
301 (WebKit::WebSourceBuffer::~WebSourceBuffer):
302 * src/AssertMatchingEnums.cpp:
303 * src/MediaSourcePrivateImpl.cpp:
305 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
306 (WebKit::MediaSourcePrivateImpl::addSourceBuffer):
307 (WebKit::MediaSourcePrivateImpl::duration):
308 (WebKit::MediaSourcePrivateImpl::setDuration):
309 (WebKit::MediaSourcePrivateImpl::endOfStream):
310 * src/MediaSourcePrivateImpl.h:
312 (MediaSourcePrivateImpl): Adapts MediaSourcePrivate interface to WebMediaSourceClient.
313 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
314 * src/SourceBufferPrivateImpl.cpp:
316 (WebKit::SourceBufferPrivateImpl::SourceBufferPrivateImpl):
317 (WebKit::SourceBufferPrivateImpl::buffered):
318 (WebKit::SourceBufferPrivateImpl::append):
319 (WebKit::SourceBufferPrivateImpl::abort):
320 (WebKit::SourceBufferPrivateImpl::setTimestampOffset):
321 (WebKit::SourceBufferPrivateImpl::removedFromMediaSource):
322 * src/SourceBufferPrivateImpl.h:
324 (SourceBufferPrivateImpl): Adapts SourceBufferPrivate interface to WebSourceBuffer.
325 (WebKit::SourceBufferPrivateImpl::~SourceBufferPrivateImpl):
326 * src/WebMediaPlayerClientImpl.cpp:
327 (WebMediaSourceClientImpl):
329 (WebSourceBufferImpl): Temporary implementation of WebSourceBuffer to keep things working
330 until the Chromium side changes land.
331 (WebKit::WebMediaSourceClientImpl::addSourceBuffer):
332 (WebKit::WebMediaSourceClientImpl::duration):
333 (WebKit::WebMediaSourceClientImpl::setDuration):
334 (WebKit::WebMediaSourceClientImpl::endOfStream):
335 (WebKit::WebSourceBufferImpl::WebSourceBufferImpl):
336 (WebKit::WebSourceBufferImpl::buffered):
337 (WebKit::WebSourceBufferImpl::append):
338 (WebKit::WebSourceBufferImpl::abort):
339 (WebKit::WebSourceBufferImpl::setTimestampOffset):
340 (WebKit::WebSourceBufferImpl::removedFromMediaSource):
341 * src/WebMediaSourceImpl.cpp:
343 2013-02-28 David Grogan <dgrogan@chromium.org>
345 IndexedDB: IO error when checking schema should destroy LevelDB directory
346 https://bugs.webkit.org/show_bug.cgi?id=110675
348 Reviewed by Adam Barth.
351 This was cargo-culted. The component build wouldn't run otherwise.
354 * tests/IDBCleanupOnIOErrorTest.cpp: Added.
356 2013-02-28 Stephen Chenney <schenney@chromium.org>
358 RenderTableCellDeathTest unit test fails on mac
359 https://bugs.webkit.org/show_bug.cgi?id=110992
361 Unreviewed revert of all changes. The problem seems to have resolved.
363 * tests/RenderTableCellTest.cpp: Remove Mac disable code.
365 2013-02-28 Takashi Toyoshima <toyoshim@chromium.org>
367 Unreviewed, quick test breakage fix for android
368 https://bugs.webkit.org/show_bug.cgi?id=110740
370 Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
372 * src/WebViewImpl.cpp:
373 (WebKit::WebViewImpl::textInputInfo): Reconstruct condition check order
375 2013-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
377 Unreviewed. Rolled Chromium DEPS to r184931. Requested by
378 "Takashi Toyoshima" <toyoshim@chromium.org> via sheriffbot.
382 2013-02-27 Seigo Nonaka <nona@chromium.org>
384 [Chromium] Should not return WebTextInputTypeNone for date input element.
385 https://bugs.webkit.org/show_bug.cgi?id=110740
387 Reviewed by Kent Tamura.
389 In the case of Windows 8, text input state including on-screen keyboard is controlled by the
390 value of WebTextInputType returned from WebViewImpl::textInputType().
391 In past, it returned WebTextInputTypeDate for date text input but now it returns
392 WebTextInputTypeNone.
393 WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
394 the date text input is focused. So there is no way to input on Windows 8 tablet without
395 physical keyboard except tapping small up/down arrow.
397 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
398 * src/WebViewImpl.cpp:
399 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
400 safe because textInputType returns editable type only for known editable element.
401 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
404 2013-02-27 James Simonsen <simonjam@chromium.org>
406 [chromium] Lower priority of preloaded images
407 https://bugs.webkit.org/show_bug.cgi?id=110527
409 Plumb the didChangePriority signal into DRT so it can be tested.
411 Reviewed by Nate Chapin.
413 * public/WebFrameClient.h:
415 (WebKit::WebFrameClient::didChangeResourcePriority):
417 * src/FrameLoaderClientImpl.cpp:
418 (WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
420 * src/FrameLoaderClientImpl.h:
421 (FrameLoaderClientImpl):
423 2013-02-27 Min Qin <qinmin@chromium.org>
425 Unlock partially decoded images after passing them to the ImageDecodingStore
426 https://bugs.webkit.org/show_bug.cgi?id=110778
428 Reviewed by Stephen White.
430 Test for testing that image frames are unlocked after passing to ImageDecodingStore.
432 * tests/ImageFrameGeneratorTest.cpp:
433 (WebCore::ImageFrameGeneratorTest::SetUp):
434 (WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
435 (ImageFrameGeneratorTest):
436 (WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
438 * tests/MockImageDecoder.h:
439 (WebCore::MockImageDecoderClient::frameBuffersLocked):
440 (WebCore::MockImageDecoderClient::frameBuffersUnlocked):
441 (WebCore::MockImageDecoder::unlockFrameBuffers):
442 (WebCore::MockImageDecoder::lockFrameBuffers):
445 2013-02-27 John Bauman <jbauman@chromium.org>
447 Plugin in iframe may not display
448 https://bugs.webkit.org/show_bug.cgi?id=109879
450 Reviewed by Simon Fraser.
452 Use clipRectChanged to update the geometry.
454 * src/WebPluginContainerImpl.cpp:
455 (WebKit::WebPluginContainerImpl::clipRectChanged):
456 * src/WebPluginContainerImpl.h:
458 2013-02-27 Stephen Chenney <schenney@chromium.org>
460 RenderTableCellDeathTest unit test fails on mac
461 https://bugs.webkit.org/show_bug.cgi?id=110992
463 Unreviewed second attempt. Trying to get the right define for the OS.
465 * tests/RenderTableCellTest.cpp:
467 2013-02-27 Stephen Chenney <schenney@chromium.org>
469 RenderTableCellDeathTest unit test fails on mac
470 https://bugs.webkit.org/show_bug.cgi?id=110992
472 Unreviewed disabling of test that is hanging or crashing on Mac.
474 * tests/RenderTableCellTest.cpp:
476 2013-02-27 James Robinson <jamesr@chromium.org>
478 [chromium] Remove suppression invalidation logic from WebViewImpl
479 https://bugs.webkit.org/show_bug.cgi?id=110999
481 Reviewed by Adrienne Walker.
483 This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
486 * src/WebViewImpl.cpp:
487 (WebKit::WebViewImpl::WebViewImpl):
488 (WebKit::WebViewImpl::suppressInvalidations):
489 (WebKit::WebViewImpl::scheduleComposite):
492 2013-02-27 Glenn Adams <glenn@skynav.com>
494 Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
495 https://bugs.webkit.org/show_bug.cgi?id=110944
497 Reviewed by Dean Jackson.
501 2013-02-26 James Robinson <jamesr@chromium.org>
503 [chromium] Remove WebViewImpl::animate shimmy out through compositor
504 https://bugs.webkit.org/show_bug.cgi?id=110935
506 Reviewed by Adrienne Walker.
508 WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
509 the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
510 the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
511 important part of this indirection is that whenever the compositor is active, all animation calls must
512 route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
513 can set the appropriate rate limiting state. Animations may originate from
514 content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
515 cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
516 idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
517 redirect to the compositor when appropriate.
519 Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
520 calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
521 follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
524 * src/WebViewImpl.cpp:
525 (WebKit::WebViewImpl::animate):
526 (WebKit::WebViewImpl::updateAnimations):
528 2013-02-27 Sheriff Bot <webkit.review.bot@gmail.com>
530 Unreviewed, rolling out r144179.
531 http://trac.webkit.org/changeset/144179
532 https://bugs.webkit.org/show_bug.cgi?id=110980
534 Breaks compilation (Requested by vsevik on #webkit).
536 * public/WebTextInputType.h:
537 * src/WebViewImpl.cpp:
538 (WebKit::WebViewImpl::textInputInfo):
539 (WebKit::WebViewImpl::textInputType):
541 2013-02-27 Stephen Chenney <schenney@chromium.org>
543 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
544 https://bugs.webkit.org/show_bug.cgi?id=110922
546 Unreviewed build fix.
548 * tests/GIFImageDecoderTest.cpp:
550 (WebKit::TEST): Disable the entire test on Android.
552 2013-02-27 Seigo Nonaka <nona@chromium.org>
554 [Chromium] Should not return WebTextInputTypeNone for date input element.
555 https://bugs.webkit.org/show_bug.cgi?id=110740
557 Reviewed by Kent Tamura.
559 In the case of Windows 8, text input state including on-screen keyboard is controlled by the
560 value of WebTextInputType returned from WebViewImpl::textInputType().
561 In past, it returned WebTextInputTypeDate for date text input but now it returns
562 WebTextInputTypeNone.
563 WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
564 the date text input is focused. So there is no way to input on Windows 8 tablet without
565 physical keyboard except tapping small up/down arrow.
567 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
568 * src/WebViewImpl.cpp:
569 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
570 safe because textInputType returns editable type only for known editable element.
571 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
574 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
576 Unreviewed, rolling out r144129.
577 http://trac.webkit.org/changeset/144129
578 https://bugs.webkit.org/show_bug.cgi?id=110947
580 Breaks compilation on chromium mac and win (Requested by
583 * src/WebViewImpl.cpp:
584 (WebKit::WebViewImpl::willBeginFrame):
586 (WebKit::WebViewImpl::didBeginFrame):
588 * tests/WebLayerTreeViewTestCommon.h:
590 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
592 Unreviewed. Rolled Chromium DEPS to r184829. Requested by
593 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
597 2013-02-26 James Robinson <jamesr@chromium.org>
599 [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
600 https://bugs.webkit.org/show_bug.cgi?id=110928
602 Reviewed by Adrienne Walker.
604 * src/WebViewImpl.cpp:
606 * tests/WebLayerTreeViewTestCommon.h:
608 2013-02-26 Alpha Lam <hclam@chromium.org>
610 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
611 https://bugs.webkit.org/show_bug.cgi?id=110922
613 Unreviewed. Build fix.
615 * tests/GIFImageDecoderTest.cpp:
618 2013-02-26 James Robinson <jamesr@chromium.org>
620 [chromium] Remove unused WebLayerTreeViewClient calls
621 https://bugs.webkit.org/show_bug.cgi?id=110923
623 Reviewed by Adrienne Walker.
625 These notifications existed for instrumentation, but now the instrumentation routes
626 through WebDevToolsAgent.
628 * src/WebViewImpl.cpp:
630 * tests/WebLayerTreeViewTestCommon.h:
632 2013-02-26 Dirk Pranke <dpranke@chromium.org>
634 Roll Chromium DEPS from r183905 -> r184646.
640 2013-02-26 James Robinson <jamesr@chromium.org>
642 [chromium] Remove unused WebWidget::instrument calls
643 https://bugs.webkit.org/show_bug.cgi?id=110906
645 Reviewed by Jochen Eisinger.
647 These calls are now routed through WebDevToolsAgent.
649 * public/WebWidget.h:
650 * src/WebViewImpl.cpp:
651 (WebKit::WebViewImpl::willBeginFrame):
654 2013-02-20 Alpha Lam <hclam@chromium.org>
656 GIFImageReader to read from source data directly
657 https://bugs.webkit.org/show_bug.cgi?id=109662
659 Reviewed by Stephen White.
661 Added the following unit tests to test new logic in GIFImageDecoder:
663 GIFImageDecoderTest.decodeTwoFrames
664 Test that it can decode a multi-frame GIF image correctly.
666 GIFImageDecoderTest.parseAndDecode
667 First perform a parse operation and then a decode operation. Expect
668 that parse and decode operates correctly.
670 GIFImageDecoderTest.parseByteByByte
671 Test that multi-frame GIF image can be parsed correctly byte by byte.
673 GIFImageDecoderTest.parseAndDecodeByteByByte
674 Run a loop to feed decoder byte by byte, perform a parse and then
675 decode operation and make sure frames are decoded correctly.
677 GIFImageDecoderTest.brokenSecondFrame
678 Decode a GIF image with second frame broken. Expect that the first
679 frame can be decoded correctly.
682 * tests/GIFImageDecoderTest.cpp: Added.
686 * tests/data/broken.gif: Added.
688 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
690 Unreviewed, rolling out r144065.
691 http://trac.webkit.org/changeset/144065
692 https://bugs.webkit.org/show_bug.cgi?id=110896
694 Causing failures and crashes on Chromium Win7 and Win XP
695 (Requested by schenney on #webkit).
699 2013-02-26 Levi Weintraub <leviw@chromium.org>
701 Add support for 8 bit TextRuns for Chromium/HarfBuzz
702 https://bugs.webkit.org/show_bug.cgi?id=99393
704 Reviewed by Eric Seidel.
706 Enabling 8 bit text runs for Chromium.
710 2013-02-26 Dmitry Zvorygin <zvorygin@chromium.org>
712 Merged Tip and Debug log levels for web console.
713 https://bugs.webkit.org/show_bug.cgi?id=109919
715 Reviewed by Pavel Feldman.
717 In every component either TIP or DEBUG level was used for reporting,
718 but not both. This patch is prerequisite for Web Inspector console log filtering.
720 * public/WebConsoleMessage.h:
721 * src/AssertMatchingEnums.cpp:
722 * src/WebFrameImpl.cpp:
723 (WebKit::WebFrameImpl::addMessageToConsole):
725 2013-02-26 Andrey Kosyakov <caseq@chromium.org>
727 Plumbing trace events to Timeline
729 Web Inspector: plumb trace events to Timeline agent
730 https://bugs.webkit.org/show_bug.cgi?id=105796
732 Reviewed by Pavel Feldman.
734 * public/WebDevToolsAgentClient.h:
735 (WebDevToolsAgentClient):
736 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
737 * src/InspectorClientImpl.cpp:
738 (WebKit::InspectorClientImpl::setTraceEventCallback):
740 * src/InspectorClientImpl.h:
741 (InspectorClientImpl):
742 * src/WebDevToolsAgentImpl.cpp:
743 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
745 * src/WebDevToolsAgentImpl.h:
746 (WebDevToolsAgentImpl):
748 2013-02-01 Andrey Kosyakov <caseq@chromium.org>
750 Web Inspector: plumb trace events to Timeline agent
751 https://bugs.webkit.org/show_bug.cgi?id=105796
753 Reviewed by Pavel Feldman.
755 Plumb trace events to Inspector.
757 * public/WebDevToolsAgentClient.h:
758 (WebDevToolsAgentClient):
759 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
760 * src/InspectorClientImpl.cpp:
761 (WebKit::InspectorClientImpl::setTraceEventCallback):
763 * src/InspectorClientImpl.h:
764 (InspectorClientImpl):
765 * src/WebDevToolsAgentImpl.cpp:
766 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
768 * src/WebDevToolsAgentImpl.h:
769 (WebDevToolsAgentImpl):
771 2013-02-26 Andrey Kosyakov <caseq@chromium.org>
773 Unreviewed, rolling out r144041, r144044, and r144048.
774 http://trac.webkit.org/changeset/144041
775 http://trac.webkit.org/changeset/144044
776 http://trac.webkit.org/changeset/144048
777 https://bugs.webkit.org/show_bug.cgi?id=105796
781 * public/WebDevToolsAgentClient.h:
782 * src/InspectorClientImpl.cpp:
783 * src/InspectorClientImpl.h:
784 (InspectorClientImpl):
785 * src/WebDevToolsAgentImpl.cpp:
786 * src/WebDevToolsAgentImpl.h:
787 (WebDevToolsAgentImpl):
789 2013-02-01 Andrey Kosyakov <caseq@chromium.org>
791 Web Inspector: plumb trace events to Timeline agent
792 https://bugs.webkit.org/show_bug.cgi?id=105796
794 Reviewed by Pavel Feldman.
796 Plumb trace events to Inspector.
798 * public/WebDevToolsAgentClient.h:
799 (WebDevToolsAgentClient):
800 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
801 * src/InspectorClientImpl.cpp:
802 (WebKit::InspectorClientImpl::setTraceEventCallback):
804 * src/InspectorClientImpl.h:
805 (InspectorClientImpl):
806 * src/WebDevToolsAgentImpl.cpp:
807 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
809 * src/WebDevToolsAgentImpl.h:
810 (WebDevToolsAgentImpl):
812 2013-02-26 Tien-Ren Chen <trchen@chromium.org>
814 Implement coordinated scrollbar for subframes and overflow:scroll
815 https://bugs.webkit.org/show_bug.cgi?id=109560
817 Reviewed by James Robinson.
819 Added ScrollingCoordinatorChromiumTest.iframeScrolling to verify
820 impl-side scrolling and impl-side scrollbars for frames.
822 Update ScrollingCoordinatorChromiumTest.overflowScrolling to verify
823 impl-side scrollbars.
825 * tests/ScrollingCoordinatorChromiumTest.cpp:
826 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
829 * tests/data/iframe-scrolling-inner.html: Added.
830 * tests/data/iframe-scrolling.html: Added.
832 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
834 Unreviewed, rolling out r144016.
835 http://trac.webkit.org/changeset/144016
836 https://bugs.webkit.org/show_bug.cgi?id=110856
838 Breaks compilation on chromium mac (Requested by vsevik on
842 * tests/KeyCodeConversionTest.cpp: Removed.
844 2013-02-26 James Robinson <jamesr@chromium.org>
846 [chromium] Fix continuous painting mode
847 https://bugs.webkit.org/show_bug.cgi?id=110788
849 Reviewed by Adrienne Walker.
851 Recent instrumentation shuffling caused WebViewImpl::didBeginFrame to no longer be called, which
852 broke continuous painting. Since continuous painting mode is meant to simply invalidate layers
853 on each frame, it's a better fit for the animation system. This moves the invalidation calls
854 into WebViewImpl::updateAnimations along with other animation type things.
856 Tested manually by enabling continuous painting mode in the inspector. There aren't any automated
857 tests in WebKit for this feature.
859 * src/WebViewImpl.cpp:
860 (WebKit::WebViewImpl::setContinuousPaintingEnabled):
861 (WebKit::WebViewImpl::didBeginFrame):
862 (WebKit::WebViewImpl::updateAnimations):
863 * src/painting/ContinuousPainter.cpp:
864 (WebKit::ContinuousPainter::setNeedsDisplayRecursive):
866 2013-02-26 James Weatherall <wez@chromium.org>
868 keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
869 https://bugs.webkit.org/show_bug.cgi?id=85642
871 Add tests to verify that the fixed keys generate the same keyCode values
872 as their equivalents.
874 Reviewed by Ojan Vafai.
877 * tests/KeyCodeConversionTest.cpp: Added.
881 2013-02-25 Rouslan Solomakhin <rouslan@chromium.org>
883 Add expandedToParagraph() method to WebRange
884 https://bugs.webkit.org/show_bug.cgi?id=110618
886 Reviewed by Adam Barth.
888 Add a method expandedToParagraph() to WebRange to return a copy of the
889 range expanded to paragraph boundaries. This method is to be used to
890 query the spelling context around the misspelled word under cursor.
893 (WebRange): Added expandedToParagraph() method declaration.
895 (WebKit::WebRange::expandedToParagraph): Added method to copy range, expand the copied range to paragraph boundaries, and return the resulting range.
896 (WebKit): Added expandedToParagraph() method definition.
898 2013-02-25 James Robinson <jamesr@chromium.org>
900 [chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
901 https://bugs.webkit.org/show_bug.cgi?id=110834
903 Reviewed by Adrienne Walker.
905 * src/WebViewImpl.cpp:
906 (WebKit::WebViewImpl::suppressInvalidations):
907 (WebKit::WebViewImpl::setRootGraphicsLayer):
909 2013-02-25 Ken Kania <kkania@chromium.org>
911 Remove browser patching mechanism for handling javascript dialogs in chromium port
912 https://bugs.webkit.org/show_bug.cgi?id=110531
914 Reviewed by Pavel Feldman.
916 * public/WebDevToolsAgent.h:
917 * src/WebDevToolsAgentImpl.cpp:
918 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
919 (WebKit::browserHintToString):
920 (WebKit::browserHintFromString):
921 (WebKit::WebDevToolsAgent::patchWithBrowserData):
923 2013-02-25 James Robinson <jamesr@chromium.org>
925 [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
926 https://bugs.webkit.org/show_bug.cgi?id=110640
928 Reviewed by Adrienne Walker.
930 This plumbs the WebViewImpl::m_suppressInvalidations logic out to the WebWidgetClient so
931 it can be implemented by the embedder. The existing logic is left in place for now,
932 once the embedder side has landed WebViewImpl will be purely a pass-through.
934 * public/WebWidgetClient.h:
936 (WebKit::WebWidgetClient::suppressCompositorScheduling):
937 * src/WebViewImpl.cpp:
938 (WebKit::WebViewImpl::suppressInvalidations):
939 (WebKit::WebViewImpl::setRootGraphicsLayer):
941 2013-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
943 Unreviewed, rolling out r143936.
944 http://trac.webkit.org/changeset/143936
945 https://bugs.webkit.org/show_bug.cgi?id=110789
947 Causes webkit_unit_tests failures on android dbg (Requested by
952 * tests/GIFImageDecoderTest.cpp: Removed.
953 * tests/data/broken.gif: Removed.
955 2013-02-25 Alpha Lam <hclam@chromium.org>
957 GIFImageReader to read from source data directly
958 https://bugs.webkit.org/show_bug.cgi?id=109662
960 Reviewed by Stephen White.
962 Added the following unit tests to test new logic in GIFImageDecoder:
964 GIFImageDecoderTest.decodeTwoFrames
965 Test that it can decode a multi-frame GIF image correctly.
967 GIFImageDecoderTest.parseAndDecode
968 First perform a parse operation and then a decode operation. Expect
969 that parse and decode operates correctly.
971 GIFImageDecoderTest.parseByteByByte
972 Test that multi-frame GIF image can be parsed correctly byte by byte.
974 GIFImageDecoderTest.parseAndDecodeByteByByte
975 Run a loop to feed decoder byte by byte, perform a parse and then
976 decode operation and make sure frames are decoded correctly.
978 GIFImageDecoderTest.brokenSecondFrame
979 Decode a GIF image with second frame broken. Expect that the first
980 frame can be decoded correctly.
984 * tests/GIFImageDecoderTest.cpp: Added.
988 * tests/data/broken.gif: Added.
990 2013-02-25 Andrey Kosyakov <caseq@chromium.org>
992 Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.
995 (.TestSuite.prototype.testPageOverlayUpdate.step2):
997 2013-02-25 Anton Vayvod <avayvod@chromium.org>
999 [Chromium] Disable registerProtocolHandler on Android
1000 https://bugs.webkit.org/show_bug.cgi?id=110481
1002 Reviewed by Julien Chaffraix.
1004 Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
1005 actually wired up internally. Disable the feature to avoid breaking feature detection until
1006 we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
1007 See the discussion of the future implementation at http://crbug.com/156386
1009 * features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
1011 * src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
1013 2013-02-24 Hajime Morrita <morrita@google.com>
1015 [Custom Elements] Implement bare-bone document.register()
1016 https://bugs.webkit.org/show_bug.cgi?id=100229
1018 Reviewed by Adam Barth.
1020 Added enableCustomDOMElements flag.
1023 * public/WebRuntimeFeatures.h:
1024 (WebRuntimeFeatures):
1025 * src/WebRuntimeFeatures.cpp:
1026 (WebKit::WebRuntimeFeatures::enableCustomDOMElements):
1028 (WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):
1030 2013-02-23 Mark Pilgrim <pilgrim@chromium.org>
1032 [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
1033 https://bugs.webkit.org/show_bug.cgi?id=110605
1035 Reviewed by Adam Barth.
1037 Part of a larger refactoring series; see tracking bug 82948.
1042 (WebKit::initialize):
1043 (WebKit::initializeWithoutV8):
1044 (WebKit::webKitPlatformSupport):
1046 2013-02-22 David Dorwin <ddorwin@chromium.org>
1048 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
1049 https://bugs.webkit.org/show_bug.cgi?id=110668
1051 Reviewed by Adam Barth.
1053 This fixes http://crbug.com/172764
1055 * src/WebHelperPluginImpl.cpp:
1056 (WebKit::WebHelperPluginImpl::destoryPage):
1058 2013-02-22 Aaron Colwell <acolwell@chromium.org>
1060 Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
1061 https://bugs.webkit.org/show_bug.cgi?id=109857
1063 Reviewed by Adam Barth.
1065 WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
1066 WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
1067 media player interfaces.
1070 * public/WebMediaPlayer.h:
1072 (WebKit::WebMediaPlayer::load):
1073 * public/WebMediaPlayerClient.h:
1075 * public/WebMediaSource.h: Added.
1078 (WebKit::WebMediaSource::~WebMediaSource):
1079 * public/WebMediaSourceClient.h: Added.
1081 (WebMediaSourceClient):
1082 (WebKit::WebMediaSourceClient::~WebMediaSourceClient):
1083 * src/AssertMatchingEnums.cpp:
1084 * src/WebMediaPlayerClientImpl.cpp:
1086 (WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium
1088 (WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
1089 (WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
1090 (WebKit::WebMediaSourceClientImpl::addId):
1091 (WebKit::WebMediaSourceClientImpl::removeId):
1092 (WebKit::WebMediaSourceClientImpl::buffered):
1093 (WebKit::WebMediaSourceClientImpl::append):
1094 (WebKit::WebMediaSourceClientImpl::abort):
1095 (WebKit::WebMediaSourceClientImpl::duration):
1096 (WebKit::WebMediaSourceClientImpl::setDuration):
1097 (WebKit::WebMediaSourceClientImpl::endOfStream):
1098 (WebKit::WebMediaSourceClientImpl::setTimestampOffset):
1099 (WebKit::WebMediaPlayerClientImpl::sourceOpened):
1100 (WebKit::WebMediaPlayerClientImpl::sourceURL):
1101 (WebKit::WebMediaPlayerClientImpl::load):
1102 (WebKit::WebMediaPlayerClientImpl::loadRequested):
1103 (WebKit::WebMediaPlayerClientImpl::loadInternal):
1104 * src/WebMediaPlayerClientImpl.h:
1105 (WebMediaPlayerClientImpl):
1106 * src/WebMediaSourceImpl.cpp: Added.
1108 (MediaSourcePrivateImpl):
1109 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
1110 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
1111 (WebKit::MediaSourcePrivateImpl::addId):
1112 (WebKit::MediaSourcePrivateImpl::removeId):
1113 (WebKit::MediaSourcePrivateImpl::buffered):
1114 (WebKit::MediaSourcePrivateImpl::append):
1115 (WebKit::MediaSourcePrivateImpl::abort):
1116 (WebKit::MediaSourcePrivateImpl::duration):
1117 (WebKit::MediaSourcePrivateImpl::setDuration):
1118 (WebKit::MediaSourcePrivateImpl::endOfStream):
1119 (WebKit::MediaSourcePrivateImpl::setTimestampOffset):
1120 (WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
1121 (WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
1122 (WebKit::WebMediaSourceImpl::open):
1123 * src/WebMediaSourceImpl.h: Added.
1125 (WebMediaSourceImpl):
1127 2013-02-22 Alec Flett <alecflett@chromium.org>
1129 IndexedDB: Remove old SerializedScriptValue-based get() callbacks
1130 https://bugs.webkit.org/show_bug.cgi?id=110626
1132 Reviewed by James Robinson.
1134 Removal now that refactoring is complete.
1136 * public/WebIDBCallbacks.h:
1139 2013-02-22 Ali Juma <ajuma@chromium.org>
1141 [chromium] Register newly-created layers for animation
1142 https://bugs.webkit.org/show_bug.cgi?id=106594
1144 Reviewed by James Robinson.
1147 * src/ChromeClientImpl.cpp:
1148 (WebKit::ChromeClientImpl::ChromeClientImpl):
1149 (WebKit::ChromeClientImpl::graphicsLayerFactory):
1150 * src/ChromeClientImpl.h:
1152 * src/GraphicsLayerFactoryChromium.cpp: Added.
1154 (WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium):
1155 (WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
1156 (WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer):
1157 * src/GraphicsLayerFactoryChromium.h: Added.
1159 (GraphicsLayerFactoryChromium):
1160 * src/WebViewImpl.cpp:
1161 (WebKit::WebViewImpl::WebViewImpl):
1162 (WebKit::WebViewImpl::graphicsLayerFactory):
1164 (WebKit::WebViewImpl::registerForAnimations):
1165 * src/WebViewImpl.h:
1168 2013-02-22 Fady Samuel <fsamuel@chromium.org>
1170 [Chromium] Expose shadowRoot to the WebKit API
1171 https://bugs.webkit.org/show_bug.cgi?id=110522
1173 Reviewed by Dimitri Glazkov.
1175 * public/WebElement.h:
1177 * src/WebElement.cpp:
1178 (WebKit::WebElement::shadowRoot):
1181 2013-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
1183 Unreviewed, rolling out r143734.
1184 http://trac.webkit.org/changeset/143734
1185 https://bugs.webkit.org/show_bug.cgi?id=110615
1187 Causes linux build failures. (Requested by vollick on
1193 (WebKit::initialize):
1194 (WebKit::initializeWithoutV8):
1195 (WebKit::webKitPlatformSupport):
1197 2013-02-22 Mikhail Naganov <mnaganov@chromium.org>
1199 [Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method
1200 https://bugs.webkit.org/show_bug.cgi?id=109946
1202 Adding a WebView method for permanently setting initial page scale.
1203 This override has higher priority than any calculated page scale
1204 and viewport meta tag value.
1206 Also, this patch eliminates a dubious "fixed layout enabled, viewport disabled" mode
1207 previously used by Android WebView.
1209 Reviewed by Adam Barth.
1213 * src/ChromeClientImpl.cpp:
1214 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1215 * src/WebViewImpl.cpp:
1216 (WebKit::WebViewImpl::WebViewImpl):
1217 (WebKit::WebViewImpl::setInitialPageScaleOverride):
1219 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1220 * src/WebViewImpl.h:
1221 * tests/WebFrameTest.cpp:
1223 2013-02-22 Mark Pilgrim <pilgrim@chromium.org>
1225 [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
1226 https://bugs.webkit.org/show_bug.cgi?id=110605
1228 Reviewed by Adam Barth.
1230 Part of a larger refactoring series; see tracking bug 82948.
1235 (WebKit::initialize):
1236 (WebKit::initializeWithoutV8):
1237 (WebKit::webKitPlatformSupport):
1239 2013-02-22 Andrey Kosyakov <caseq@chromium.org>
1241 Web Inspector: [Chromium] add a browser test for frames on timeline
1242 https://bugs.webkit.org/show_bug.cgi?id=110592
1244 - factor out timeline recording logic from testPageOverlayUpdate for reuse;
1245 - record timeline while running a simple DOM-based animation;
1246 - assure we have frames and Style Recalc/Layout/Paint events in between.
1248 Reviewed by Yury Semikhatsky.
1251 (.TestSuite.prototype.assertHasKey):
1252 (.TestSuite.prototype.testTimelineFrames.step1):
1253 (.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
1254 (.TestSuite.prototype.testTimelineFrames):
1255 (.TestSuite.prototype.testPageOverlayUpdate.step4):
1256 (.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
1257 (.TestSuite.prototype.recordTimeline.addRecord):
1258 (.TestSuite.prototype.recordTimeline.innerAddRecord):
1259 (.TestSuite.prototype.recordTimeline.done):
1260 (.TestSuite.prototype.recordTimeline):
1261 (.TestSuite.prototype.stopTimeline):
1263 2013-02-21 Alec Flett <alecflett@chromium.org>
1265 IndexedDB: Implement SharedBuffer version of put() / onSuccess()
1266 https://bugs.webkit.org/show_bug.cgi?id=110398
1268 Reviewed by Tony Chang.
1270 Proxy new SharedBuffer calls to WebIDBCallbacks through
1271 to the new SharedBuffer-based IDBCallbacks.
1273 * public/WebIDBCursor.h:
1274 * src/IDBCallbacksProxy.cpp:
1275 (WebKit::IDBCallbacksProxy::onSuccess):
1276 (WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):
1277 * src/IDBCallbacksProxy.h:
1278 (IDBCallbacksProxy):
1279 * src/WebIDBCallbacksImpl.cpp:
1280 (WebKit::WebIDBCallbacksImpl::onSuccess):
1281 * src/WebIDBCallbacksImpl.h:
1282 (WebIDBCallbacksImpl):
1283 * tests/IDBAbortOnCorruptTest.cpp:
1284 (WebCore::MockIDBCallbacks::onSuccess):
1285 (WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
1286 * tests/IDBDatabaseBackendTest.cpp:
1287 * tests/IDBRequestTest.cpp:
1290 2013-02-21 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1292 Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
1293 https://bugs.webkit.org/show_bug.cgi?id=110208
1295 Reviewed by Hajime Morrita.
1297 * src/EditorClientImpl.cpp:
1298 (WebKit::EditorClientImpl::requestCheckingOfString):
1299 Extract the request data as it is the member of 'TextCheckingRequest'.
1301 2013-02-21 Mark Pilgrim <pilgrim@chromium.org>
1303 [Chromium] Remove chromium/public/platform directory
1304 https://bugs.webkit.org/show_bug.cgi?id=110471
1306 Reviewed by Adam Barth.
1308 Part of a larger refactoring series; see tracking bug 82948.
1311 * public/platform: Removed.
1312 * public/platform/WebKitPlatformSupport.h: Removed.
1313 * public/platform/android: Removed.
1314 * public/platform/default: Removed.
1315 * public/platform/linux: Removed.
1316 * public/platform/mac: Removed.
1317 * public/platform/win: Removed.
1320 2013-02-21 Dirk Pranke <dpranke@chromium.org>
1322 [chromium] support the lucid version of freetype on precise in DRT
1323 https://bugs.webkit.org/show_bug.cgi?id=107338
1325 Reviewed by Tony Chang.
1327 Add in a linux-only dependency on Freetype2 so that we can
1328 match the version shipped in Ubuntu Lucid.
1332 2013-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
1334 Unreviewed. Rolled Chromium DEPS to r183905. Requested by
1335 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1339 2013-02-21 Alec Flett <alecflett@chromium.org>
1341 IndexedDB: Remove copying WebIDBDatabase::put() stub
1342 https://bugs.webkit.org/show_bug.cgi?id=109967
1344 Reviewed by Darin Fisher.
1346 Now that the chromium call to this method has
1347 been removed, we can remove the stub.
1349 * public/WebIDBDatabase.h:
1351 2013-02-21 Dirk Pranke <dpranke@chromium.org>
1353 Unreviewed, roll chromium deps 183552 -> 183788
1357 2013-02-21 John Mellor <johnme@chromium.org>
1359 [chromium] Simplify computation of screenRect/windowRect.
1360 https://bugs.webkit.org/show_bug.cgi?id=110456
1362 Reviewed by Adam Barth.
1364 This patch removes applyDeviceScaleFactorInCompositor checks
1365 added by http://trac.webkit.org/changeset/139356 because
1366 Chrome for Android now sizes its screen and window in DIP
1367 units (like other platforms), so they are no longer necessary.
1369 * src/ChromeClientImpl.cpp:
1370 (WebKit::ChromeClientImpl::windowRect):
1372 2013-02-21 Vsevolod Vlasov <vsevik@chromium.org>
1374 Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
1375 https://bugs.webkit.org/show_bug.cgi?id=110335
1377 Reviewed by Alexander Pavlov.
1380 (.TestSuite.prototype._scriptsAreParsed):
1382 2013-02-21 Ken Kania <kkania@chromium.org>
1384 Web Inspector: Add command for selecting files for file input element
1385 https://bugs.webkit.org/show_bug.cgi?id=109308
1387 Reviewed by Pavel Feldman.
1389 * src/InspectorClientImpl.cpp:
1390 (WebKit::InspectorClientImpl::canSetFileInputFiles):
1392 * src/InspectorClientImpl.h:
1393 (InspectorClientImpl):
1395 2013-02-20 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
1397 Add gyp option to switch ENABLE(SQL_DATABASE)
1398 https://bugs.webkit.org/show_bug.cgi?id=109303
1399 http://code.google.com/p/chromium/issues/detail?id=22208
1401 Reviewed by Tony Chang.
1403 This will be useful to implement build with system sqlite.
1406 * src/ChromeClientImpl.cpp:
1408 * src/ChromeClientImpl.h:
1411 2013-02-20 Dirk Schulze <krit@webkit.org>
1413 Enable CANVAS_PATH flag
1414 https://bugs.webkit.org/show_bug.cgi?id=108508
1416 Reviewed by Simon Fraser.
1418 Enable CANVAS_PATH flag on trunk.
1422 2013-02-15 Dirk Schulze <krit@webkit.org>
1424 [Chromium] Add runtime flag for CanvasPath
1425 https://bugs.webkit.org/show_bug.cgi?id=109997
1427 Reviewed by Adam Barth.
1429 Add runtime flag for Chromium.
1431 * public/WebRuntimeFeatures.h:
1432 (WebRuntimeFeatures):
1433 * src/WebRuntimeFeatures.cpp:
1434 (WebKit::WebRuntimeFeatures::enableCanvasPath):
1436 (WebKit::WebRuntimeFeatures::isCanvasPathEnabled):
1438 2013-02-20 Mark Pilgrim <pilgrim@chromium.org>
1440 [Chromium] Move WebKitPlatformSupport declaration to Platform.h
1441 https://bugs.webkit.org/show_bug.cgi?id=110262
1443 Reviewed by Adam Barth.
1445 In preparation for removing WebKitPlatformSupport.h entirely (once
1446 downstream references to that file have been updated). Part of a
1447 larger refactoring series; see tracking bug 82948.
1449 * public/platform/WebKitPlatformSupport.h:
1451 2013-02-20 Mark Pilgrim <pilgrim@chromium.org>
1453 [Chromium] Remove idbFactory from WebKitPlatformSupport
1454 https://bugs.webkit.org/show_bug.cgi?id=106457
1456 Reviewed by Adam Barth.
1458 Now that https://codereview.chromium.org/12230054 has landed, the
1459 idbFactory method is no longer needed. (Embedders must now call
1460 the new setIDBFactory method upon initialization.) Part of a
1461 larger refactoring series; see tracking bug 82948.
1463 * public/platform/WebKitPlatformSupport.h:
1465 * src/IDBFactoryBackendProxy.cpp:
1466 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1468 2013-02-20 Mark Lam <mark.lam@apple.com>
1470 Rename DatabaseBackend to DatabaseBackendBase.
1471 https://bugs.webkit.org/show_bug.cgi?id=110303.
1473 Rubber stamped by Alexey Proskuryakov.
1475 * public/WebDatabase.h:
1477 * src/DatabaseObserver.cpp:
1478 (WebCore::DatabaseObserver::databaseOpened):
1479 (WebCore::DatabaseObserver::databaseModified):
1480 (WebCore::DatabaseObserver::databaseClosed):
1481 (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1482 (WebCore::DatabaseObserver::reportChangeVersionResult):
1483 (WebCore::DatabaseObserver::reportStartTransactionResult):
1484 (WebCore::DatabaseObserver::reportCommitTransactionResult):
1485 (WebCore::DatabaseObserver::reportExecuteStatementResult):
1486 (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1487 * src/WebDatabase.cpp:
1488 (WebKit::WebDatabase::WebDatabase):
1490 2013-02-20 Rouslan Solomakhin <rouslan@chromium.org>
1492 Fix use after free in ContextMenuClientImpl.cpp
1493 https://bugs.webkit.org/show_bug.cgi?id=109220
1495 Reviewed by Tony Chang.
1497 ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
1498 by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
1499 to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
1500 causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
1501 spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
1502 ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
1503 use after free. The fix is to save a copy of the DocumentMarker before changing selection.
1505 * src/ContextMenuClientImpl.cpp:
1506 (WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
1507 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.
1509 2013-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
1511 Unreviewed. Rolled Chromium DEPS to r183552. Requested by
1512 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1516 2013-02-19 Adrienne Walker <enne@chromium.org>
1518 Unreviewed, rolling out r143382 and r143401.
1519 http://trac.webkit.org/changeset/143382
1520 http://trac.webkit.org/changeset/143401
1521 https://bugs.webkit.org/show_bug.cgi?id=106457
1523 Breaks Chromium win/mac canary compilation
1525 * public/platform/WebKitPlatformSupport.h:
1527 (WebKitPlatformSupport):
1528 (WebKit::WebKitPlatformSupport::idbFactory):
1529 (WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
1530 * src/IDBFactoryBackendProxy.cpp:
1531 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1533 2013-02-19 Mark Pilgrim <pilgrim@chromium.org>
1535 [Chromium] Move WebKitPlatformSupport declaration to Platform.h
1536 https://bugs.webkit.org/show_bug.cgi?id=110262
1538 Reviewed by Adam Barth.
1540 In preparation for removing WebKitPlatformSupport.h entirely (once
1541 downstream references to that file have been updated). Part of a
1542 larger refactoring series; see tracking bug 82948.
1544 * public/platform/WebKitPlatformSupport.h:
1546 2013-02-19 Mark Pilgrim <pilgrim@chromium.org>
1548 [Chromium] Remove idbFactory from WebKitPlatformSupport
1549 https://bugs.webkit.org/show_bug.cgi?id=106457
1551 Reviewed by Kentaro Hara.
1553 Now that https://codereview.chromium.org/12230054 has landed, the
1554 idbFactory method is no longer needed. (Embedders must now call
1555 the new setIDBFactory method upon initialization.) Part of a
1556 larger refactoring series; see tracking bug 82948.
1558 * public/platform/WebKitPlatformSupport.h:
1560 * src/IDBFactoryBackendProxy.cpp:
1561 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1563 2013-02-19 Alexandre Elias <aelias@chromium.org>
1565 [chromium] Fix races in double-tap zoom minimum scale policy
1566 https://bugs.webkit.org/show_bug.cgi?id=110183
1568 Reviewed by Adam Barth.
1570 Double-tap zoom on Android is supposed to return to minimum scale
1571 if no pinch zoom occurred since the last double-tap. Because both
1572 pinch zoom and the result of double-tap zoom gets passed in from CC
1573 via applyScrollAndScale, this logic was brittle and prone to races
1574 depending on when the animation update was received. This patch
1575 keeps track of what the target double-tap scale is to make it more
1578 I also fixed double-tap zoom test mocking to exercise the entire
1579 page scale animation flow (our previous way of testing was hiding the
1580 raciness), and added a new test case in DivAutoZoomMultipleParamsTest.
1582 * src/WebViewImpl.cpp:
1583 (WebKit::WebViewImpl::WebViewImpl):
1584 (WebKit::WebViewImpl::startPageScaleAnimation):
1586 (WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
1587 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
1588 (WebKit::WebViewImpl::animateZoomAroundPoint):
1589 (WebKit::WebViewImpl::didCommitLoad):
1590 (WebKit::WebViewImpl::applyScrollAndScale):
1591 * src/WebViewImpl.h:
1593 (WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
1594 (WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
1595 (WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
1596 (WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
1597 * tests/WebFrameTest.cpp:
1599 2013-02-19 Joshua Bell <jsbell@chromium.org>
1601 IndexedDB: additional checks on LevelDB decoding
1602 https://bugs.webkit.org/show_bug.cgi?id=109711
1604 Reviewed by Tony Chang.
1606 * tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
1608 2013-02-19 Jochen Eisinger <jochen@chromium.org>
1610 [chromium] fix ScrollAnimatorNoneTest after r143295
1611 https://bugs.webkit.org/show_bug.cgi?id=110189
1613 Reviewed by Nico Weber.
1615 * tests/ScrollAnimatorNoneTest.cpp:
1616 (MockScrollableArea):
1618 2013-02-18 Simon Fraser <simon.fraser@apple.com>
1620 Clean up the boolean argument to visibleContentRect
1621 https://bugs.webkit.org/show_bug.cgi?id=110167
1623 Reviewed by Simon Fraser.
1625 Replace the boolean argument to visibleContentRect() with
1628 * src/ChromeClientImpl.cpp:
1629 (WebKit::ChromeClientImpl::popupOpened):
1631 2013-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
1633 Unreviewed. Rolled Chromium DEPS to r183105. Requested by
1634 thakis_ via sheriffbot.
1638 2013-02-18 Nico Weber <thakis@chromium.org>
1640 [chromium] Remove ahem_path from WebKit.gyp
1641 https://bugs.webkit.org/show_bug.cgi?id=110111
1643 Reviewed by Jochen Eisinger.
1645 It's only used in DumpRenderTree.gyp, and that file defines its own
1646 copy of this variable.
1650 2013-02-18 Laszlo Gombos <l.gombos@samsung.com>
1652 Move ENABLE macros for WebCore out from Platform.h
1653 https://bugs.webkit.org/show_bug.cgi?id=105735
1655 Move the chromium specific WebCore ENABLE macro definitions
1656 from Platform.h to features.gypi.
1658 Reviewed by Darin Adler and Benjamin Poulain.
1660 * features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1.
1662 2013-02-15 Alec Flett <alecflett@chromium.org>
1664 IndexedDB: Stub out SharedBuffer version of get()
1665 https://bugs.webkit.org/show_bug.cgi?id=108993
1667 Reviewed by Darin Fisher.
1669 All asynchronous get()-like calls go through WebIDBCallbacks,
1670 so this includes both get() and cursor callbacks.
1672 * public/WebIDBCallbacks.h:
1673 (WebKit::WebIDBCallbacks::onSuccess):
1674 (WebKit::WebIDBCallbacks::onSuccessWithPrefetch):
1676 2013-02-15 Alec Flett <alecflett@chromium.org>
1678 IndexedDB: fix chromium windows bustage
1679 https://bugs.webkit.org/show_bug.cgi?id=109970
1681 Unreviewed build fix for Chromium Windows.
1683 * tests/IDBDatabaseBackendTest.cpp:
1685 2013-02-15 Alec Flett <alecflett@chromium.org>
1687 IndexedDB: Implement SharedBuffer version of put()
1688 https://bugs.webkit.org/show_bug.cgi?id=109092
1690 Reviewed by Adam Barth.
1692 Implement SharedBuffer/WebData version of
1693 IDBDatabaseBackendInterface::put, and put
1694 temporary scaffolding in until chrome is ready.
1696 * src/IDBDatabaseBackendProxy.cpp:
1697 (WebKit::IDBDatabaseBackendProxy::put):
1698 * src/IDBDatabaseBackendProxy.h:
1699 (IDBDatabaseBackendProxy):
1700 * src/WebIDBDatabaseImpl.cpp:
1701 (WebKit::WebIDBDatabaseImpl::put):
1703 * src/WebIDBDatabaseImpl.h:
1704 (WebIDBDatabaseImpl):
1705 * tests/IDBDatabaseBackendTest.cpp:
1707 2013-02-15 Alexandre Elias <aelias@chromium.org>
1709 [chromium] WebInputEventBuilders should not reverse page scale
1710 https://bugs.webkit.org/show_bug.cgi?id=109901
1712 Reviewed by James Robinson.
1714 Though in theory logical that if WebInputEvent -> PlatformEvent
1715 conversions divide by page scale, then the reverse builders should
1716 multiply, in reality the only user of the reverse builders is
1717 plugins which expect the same coordinate space as WebCore.
1719 * src/WebInputEventConversion.cpp:
1720 (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
1721 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
1722 (WebKit::addTouchPoints):
1723 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
1724 * tests/WebInputEventConversionTest.cpp:
1727 2013-02-15 Anders Carlsson <andersca@apple.com>
1729 Remove const from a bunch of StorageArea member functions
1730 https://bugs.webkit.org/show_bug.cgi?id=109957
1732 Reviewed by Beth Dakin.
1734 Update for WebCore changes.
1736 * src/StorageAreaProxy.cpp:
1737 (WebCore::StorageAreaProxy::length):
1738 (WebCore::StorageAreaProxy::key):
1739 (WebCore::StorageAreaProxy::getItem):
1740 (WebCore::StorageAreaProxy::contains):
1741 (WebCore::StorageAreaProxy::canAccessStorage):
1742 (WebCore::StorageAreaProxy::memoryBytesUsedByCache):
1743 * src/StorageAreaProxy.h:
1746 2013-02-15 Keishi Hattori <keishi@webkit.org>
1748 PagePopupController.formatMonth should support short month format
1749 https://bugs.webkit.org/show_bug.cgi?id=109530
1751 Reviewed by Kent Tamura.
1753 * tests/LocaleMacTest.cpp:
1754 (LocaleMacTest::formatMonth):
1757 2013-02-15 Keishi Hattori <keishi@webkit.org>
1759 Add setValue and closePopup methods to PagePopupController
1760 https://bugs.webkit.org/show_bug.cgi?id=109897
1762 Reviewed by Kent Tamura.
1764 * src/ColorChooserPopupUIController.cpp:
1765 (WebKit::ColorChooserPopupUIController::setValue):
1767 * src/ColorChooserPopupUIController.h:
1768 (ColorChooserPopupUIController):
1769 * src/DateTimeChooserImpl.cpp:
1770 (WebKit::DateTimeChooserImpl::setValueAndClosePopup): Use setValue and closePopup.
1772 (WebKit::DateTimeChooserImpl::setValue):
1773 (WebKit::DateTimeChooserImpl::closePopup):
1774 * src/DateTimeChooserImpl.h:
1775 (DateTimeChooserImpl):
1777 2013-02-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
1779 Simplify hitTestResultAtPoint and nodesFromRect APIs
1780 https://bugs.webkit.org/show_bug.cgi?id=95720
1782 Reviewed by Julien Chaffraix.
1784 Update calls to new API.
1786 * src/ContextMenuClientImpl.cpp:
1787 (WebKit::selectMisspelledWord):
1788 * src/FrameLoaderClientImpl.cpp:
1789 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
1790 * src/WebFrameImpl.cpp:
1791 (WebKit::WebFrameImpl::characterIndexForPoint):
1792 * src/WebPluginContainerImpl.cpp:
1793 (WebKit::WebPluginContainerImpl::isRectTopmost):
1794 * src/WebViewImpl.cpp:
1795 (WebKit::WebViewImpl::handleMouseDown):
1796 (WebKit::WebViewImpl::computeBlockBounds):
1797 (WebKit::WebViewImpl::bestTouchLinkNode):
1798 (WebKit::WebViewImpl::hitTestResultForWindowPos):
1800 2013-02-14 Vsevolod Vlasov <vsevik@chromium.org>
1802 Unreviewed chromium test fix: incorrect field was used for UISourceCode url.
1805 (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
1806 (.TestSuite.prototype.uiSourceCodesToString_):
1808 2013-02-14 David Trainor <dtrainor@chromium.org>
1810 [chromium] No triggering autofill on unfocus
1811 https://bugs.webkit.org/show_bug.cgi?id=109735
1813 Reviewed by James Robinson.
1815 Need to notify the autofill client to not process text changes when we're setting
1816 focus to false and are trying to commit a composition.
1818 * public/WebAutofillClient.h:
1819 (WebAutofillClient):
1820 (WebKit::WebAutofillClient::setIgnoreTextChanges):
1821 (WebKit::WebAutofillClient::~WebAutofillClient):
1822 * src/WebViewImpl.cpp:
1823 (WebKit::WebViewImpl::setFocus):
1824 * tests/WebViewTest.cpp:
1826 2013-02-14 Alexandre Elias <aelias@chromium.org>
1828 [chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
1829 https://bugs.webkit.org/show_bug.cgi?id=109671
1831 Reviewed by James Robinson.
1833 My patch 142571 broke a bunch of things in handleGestureEvent that
1834 assumed the event came in scaled, most notably tap highlight and
1835 double-tap zoom. Switch those to PlatformGestureEvent.
1837 142808 was an earlier version of this patch that was reverted
1838 due to fling events asserting they can't be converted to
1839 PlatformGestureEvent. This version moves fling earlier in the
1840 function to avoid that.
1842 * src/WebViewImpl.cpp:
1843 (WebKit::WebViewImpl::handleGestureEvent):
1844 (WebKit::WebViewImpl::bestTapNode):
1845 (WebKit::WebViewImpl::enableTapHighlight):
1846 * src/WebViewImpl.h:
1848 * tests/LinkHighlightTest.cpp:
1851 2013-02-14 Dirk Pranke <dpranke@chromium.org>
1853 Unreviewed, rolling out r142901.
1854 http://trac.webkit.org/changeset/142901
1856 r182258 introduces a dependency on chrome.gyp that breaks the win
1857 build. Rolling back to r182150 until I can work up a workaround.
1861 2013-02-14 Dirk Pranke <dpranke@chromium.org>
1863 Unreviewed, chromium roll 182150 -> 182448
1867 2013-02-14 Mark Pilgrim <pilgrim@chromium.org>
1869 [Chromium] Move PlatformMessagePortChannel to WebCore
1870 https://bugs.webkit.org/show_bug.cgi?id=109845
1872 Reviewed by Adam Barth.
1874 Part of a larger refactoring series; see tracking bug 106829.
1877 * src/PlatformMessagePortChannel.cpp: Removed.
1878 * src/PlatformMessagePortChannel.h: Removed.
1879 * src/SharedWorkerRepository.cpp:
1880 * src/WebDOMMessageEvent.cpp:
1881 * src/WebFrameImpl.cpp:
1882 * src/WebSharedWorkerImpl.cpp:
1883 * src/WebWorkerClientImpl.cpp:
1885 2013-02-14 Min Qin <qinmin@chromium.org>
1887 Passing alpha to DeferredImageDecoder once decoding completes
1888 https://bugs.webkit.org/show_bug.cgi?id=108892
1890 Reviewed by Stephen White.
1892 Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.
1894 * tests/ImageFrameGeneratorTest.cpp:
1895 (WebCore::MockImageDecoderFactory::create):
1897 * tests/MockImageDecoder.h:
1898 (WebCore::MockImageDecoder::MockImageDecoder):
1899 (WebCore::MockImageDecoder::setFrameHasAlpha):
1901 (WebCore::MockImageDecoder::frameHasAlphaAtIndex):
1903 2013-02-08 Andrey Kosyakov <caseq@chromium.org>
1905 Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
1906 https://bugs.webkit.org/show_bug.cgi?id=109192
1908 Reviewed by Pavel Feldman.
1910 - expose frame and compositing insturmentation methods on WebDevToolsAgent;
1911 - temporarily route them from WebViewImpl to WebDevToolsAgent;
1913 * public/WebDevToolsAgent.h:
1915 * src/WebDevToolsAgentImpl.cpp:
1916 (WebKit::WebDevToolsAgentImpl::didBeginFrame):
1918 (WebKit::WebDevToolsAgentImpl::didCancelFrame):
1919 (WebKit::WebDevToolsAgentImpl::willComposite):
1920 (WebKit::WebDevToolsAgentImpl::didComposite):
1921 * src/WebDevToolsAgentImpl.h:
1922 (WebDevToolsAgentImpl):
1923 * src/WebViewImpl.cpp:
1924 (WebKit::WebViewImpl::instrumentBeginFrame):
1925 (WebKit::WebViewImpl::instrumentCancelFrame):
1926 (WebKit::WebViewImpl::didBeginFrame):
1927 (WebKit::WebViewImpl::willCommit):
1929 2013-02-14 Mikhail Naganov <mnaganov@chromium.org>
1931 [Chromium] Add a setting to control scaling content to fit viewport
1932 https://bugs.webkit.org/show_bug.cgi?id=109584
1934 Adds a setting called 'initializeAtMinimumPageScale'. By default,
1935 it is set to 'true' which corresponds to Chrome on Android behavior--
1936 adjust the page scale to make the content fit into the viewport
1937 by width. When set to false, the setting instructs ChromeClientImpl to
1938 set page scale to 1.0, unless the scale value is set by the page
1939 in the viewport meta-tag.
1941 Reviewed by Adam Barth.
1943 * public/WebSettings.h:
1944 * src/ChromeClientImpl.cpp:
1945 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1946 * src/WebSettingsImpl.cpp:
1947 (WebKit::WebSettingsImpl::WebSettingsImpl):
1948 (WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
1950 * src/WebSettingsImpl.h:
1952 (WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
1953 * tests/WebFrameTest.cpp:
1954 * tests/data/viewport-2x-initial-scale.html: Added.
1955 * tests/data/viewport-auto-initial-scale.html: Added.
1957 2013-02-14 Sheriff Bot <webkit.review.bot@gmail.com>
1959 Unreviewed, rolling out r142808.
1960 http://trac.webkit.org/changeset/142808
1961 https://bugs.webkit.org/show_bug.cgi?id=109816
1963 Crashes on chromium webkit canary bots (Requested by atwilson_
1966 * src/WebViewImpl.cpp:
1967 (WebKit::WebViewImpl::handleGestureEvent):
1968 (WebKit::WebViewImpl::bestTouchLinkNode):
1969 (WebKit::WebViewImpl::enableTouchHighlight):
1970 * src/WebViewImpl.h:
1972 * tests/LinkHighlightTest.cpp:
1975 2013-02-14 Sheriff Bot <webkit.review.bot@gmail.com>
1977 Unreviewed, rolling out r142841.
1978 http://trac.webkit.org/changeset/142841
1979 https://bugs.webkit.org/show_bug.cgi?id=109791
1981 Caused webkit_unit_tests to crash on chromium bots. (Requested
1982 by atwilson_ on #webkit).
1984 * tests/GraphicsLayerChromiumTest.cpp:
1985 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1986 * tests/ScrollingCoordinatorChromiumTest.cpp:
1987 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1989 2013-02-13 Max Vujovic <mvujovic@adobe.com>
1991 [CSS Filters] Refactor filter outsets into a class
1992 https://bugs.webkit.org/show_bug.cgi?id=109330
1994 Update FilterOperations unit tests to use new interface for getting filter outsets.
1996 Reviewed by Dean Jackson.
1998 * tests/FilterOperationsTest.cpp:
2001 2013-02-13 Zan Dobersek <zdobersek@igalia.com>
2003 The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
2004 https://bugs.webkit.org/show_bug.cgi?id=109325
2006 Reviewed by Anders Carlsson.
2008 Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
2009 two methods as they're provided by the C++ standard library being used.
2011 * tests/DecimalTest.cpp:
2014 2013-02-13 Alexandre Elias <aelias@chromium.org>
2016 [chromium] Fix scaling in WebViewImpl::handleGestureEvent
2017 https://bugs.webkit.org/show_bug.cgi?id=109671
2019 Reviewed by James Robinson.
2021 My last patch broke a bunch of things in handleGestureEvent that
2022 assumed the event came in scaled, most notably tap highlight and
2023 double-tap zoom. Switch those to PlatformGestureEvent.
2025 * src/WebViewImpl.cpp:
2026 (WebKit::WebViewImpl::handleGestureEvent):
2027 (WebKit::WebViewImpl::bestTapNode):
2028 (WebKit::WebViewImpl::enableTapHighlight):
2029 * src/WebViewImpl.h:
2031 * tests/LinkHighlightTest.cpp:
2034 2013-02-13 Eberhard Graether <egraether@google.com>
2036 chromium: remove CompositorHUDFontAtlas
2037 https://bugs.webkit.org/show_bug.cgi?id=109328
2039 Reviewed by James Robinson.
2041 After switching the HudLayer to use skia's font rendering the
2042 CompositorHUDFontAtlas has become obsolete. This change removes
2043 this class and the related WebLayerTreeView API.
2045 * src/WebViewImpl.cpp:
2046 * src/WebViewImpl.h:
2048 2013-02-13 Sheriff Bot <webkit.review.bot@gmail.com>
2050 Unreviewed. Rolled Chromium DEPS to r182150. Requested by
2051 jamesr_ via sheriffbot.
2055 2013-02-13 Sadrul Habib Chowdhury <sadrul@chromium.org>
2057 [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
2058 https://bugs.webkit.org/show_bug.cgi?id=109611
2060 The deltas in mousewheel events generated by track can be accelerated (e.g. when
2061 scrolling repeatedly). Keep track of the ratio of the acceleration since that is
2062 useful for some tasks (e.g. overflow navigation gesture).
2064 Reviewed by Adam Barth.
2066 * public/WebInputEvent.h:
2067 (WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
2068 * src/WebInputEvent.cpp:
2069 (SameSizeAsWebMouseWheelEvent):
2071 2013-02-12 Yoshifumi Inoue <yosin@chromium.org>
2073 Unreviewed. Build fix for Chromium-Win.
2074 Add #include <functional> for std::bind1st.
2076 * tests/PrerenderingTest.cpp:
2078 2013-02-12 Joshua Bell <jsbell@chromium.org>
2080 [Chromium] IndexedDB/Worker crash during shutdown
2081 https://bugs.webkit.org/show_bug.cgi?id=109467
2083 Reviewed by Tony Chang.
2085 If the message queue has already been terminated, don't bother scheduling
2086 a new error event that will never be delivered. Speculative fix for the
2087 issue, which only repros in multiprocess ports and so far only on some
2090 * src/IDBFactoryBackendProxy.cpp:
2091 (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.
2093 2013-02-12 Zan Dobersek <zdobersek@igalia.com>
2095 Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
2096 https://bugs.webkit.org/show_bug.cgi?id=109481
2098 Reviewed by Daniel Bates.
2100 The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
2101 back in r120574. There are still occurrences of it in various build systems
2102 which should all be removed as they are useless.
2106 2013-02-12 Jochen Eisinger <jochen@chromium.org>
2108 Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
2109 https://bugs.webkit.org/show_bug.cgi?id=109548
2111 Unreviewed gardening.
2113 * tests/WebFrameTest.cpp:
2115 2013-02-11 James Robinson <jamesr@chromium.org>
2117 [Chromium] Get rid of WebAnimationController
2118 https://bugs.webkit.org/show_bug.cgi?id=109235
2120 Reviewed by Benjamin Poulain.
2122 * public/WebAnimationController.h: Removed.
2123 * public/WebFrame.h:
2125 * src/WebAnimationControllerImpl.cpp: Removed.
2126 * src/WebAnimationControllerImpl.h: Removed.
2127 * src/WebFrameImpl.cpp:
2128 * src/WebFrameImpl.h:
2131 2013-02-11 James Robinson <jamesr@chromium.org>
2133 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
2134 https://bugs.webkit.org/show_bug.cgi?id=109403
2136 Reviewed by Adam Barth.
2138 * tests/GraphicsLayerChromiumTest.cpp:
2139 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2140 * tests/ScrollingCoordinatorChromiumTest.cpp:
2141 (WebKit::FakeWebViewClient::initializeLayerTreeView):
2143 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2145 Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
2146 https://bugs.webkit.org/show_bug.cgi?id=109534
2148 Reviewed by Anders Carlsson.
2150 * src/EditorClientImpl.cpp:
2152 * src/EditorClientImpl.h:
2155 2013-02-11 Alexandre Elias <aelias@chromium.org>
2157 [chromium] Apply page scale to all WebInputEvent types
2158 https://bugs.webkit.org/show_bug.cgi?id=109370
2160 Reviewed by James Robinson.
2162 Previously we only adjusted a few common input event types by page
2163 scale, but in fact almost every position and size in WebInputEvents
2166 I also took the opportunity to change some WebGestureEvent members to
2167 floats (which I checked causes no warnings in Chromium-side code with
2170 New WebInputEventConversionTest: InputEventsScaling
2172 * public/WebInputEvent.h:
2173 (WebKit::WebGestureEvent::WebGestureEvent):
2174 * src/WebInputEventConversion.cpp:
2175 (WebKit::widgetScaleFactor):
2177 (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
2178 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
2179 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2180 (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
2181 (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
2182 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
2183 (WebKit::addTouchPoints):
2184 (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
2185 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
2186 * src/WebViewImpl.cpp:
2187 (WebKit::WebViewImpl::handleGestureEvent):
2188 (WebKit::WebViewImpl::hasTouchEventHandlersAt):
2189 (WebKit::WebViewImpl::handleInputEvent):
2190 * tests/WebInputEventConversionTest.cpp:
2194 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2196 Unreviewed, rolling out r142568.
2197 http://trac.webkit.org/changeset/142568
2198 https://bugs.webkit.org/show_bug.cgi?id=109541
2200 Broke the build, won't compile. (Requested by alancutter on
2203 * tests/GraphicsLayerChromiumTest.cpp:
2204 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2205 * tests/ScrollingCoordinatorChromiumTest.cpp:
2206 (WebKit::FakeWebViewClient::initializeLayerTreeView):
2208 2013-02-11 James Robinson <jamesr@chromium.org>
2210 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
2211 https://bugs.webkit.org/show_bug.cgi?id=109403
2213 Reviewed by Adam Barth.
2215 * tests/GraphicsLayerChromiumTest.cpp:
2216 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2217 * tests/ScrollingCoordinatorChromiumTest.cpp:
2218 (WebKit::FakeWebViewClient::initializeLayerTreeView):
2220 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2222 Unreviewed. Rolled Chromium DEPS to r181817. Requested by
2223 "James Robinson" <jamesr@chromium.org> via sheriffbot.
2227 2013-02-11 David Grogan <dgrogan@chromium.org>
2229 IndexedDB: Add UnknownError to WebIDBDatabaseException
2230 https://bugs.webkit.org/show_bug.cgi?id=109519
2232 Reviewed by Adam Barth.
2234 * public/WebIDBDatabaseException.h:
2235 * src/AssertMatchingEnums.cpp:
2237 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2239 Unreviewed. Rolled Chromium DEPS to r181787. Requested by
2240 thakis_ via sheriffbot.
2244 2013-02-11 Nico Weber <thakis@chromium.org>
2246 Remove web intents code
2247 https://bugs.webkit.org/show_bug.cgi?id=109501
2249 Reviewed by Eric Seidel.
2251 See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
2255 * public/WebDeliveredIntentClient.h: Removed.
2256 * public/WebFrame.h:
2259 * public/WebFrameClient.h:
2261 * public/WebIntent.h: Removed.
2262 * public/WebIntentRequest.h: Removed.
2263 * public/WebIntentServiceInfo.h: Removed.
2264 * public/WebRuntimeFeatures.h:
2265 (WebRuntimeFeatures):
2266 * src/DeliveredIntentClientImpl.cpp: Removed.
2267 * src/DeliveredIntentClientImpl.h: Removed.
2268 * src/FrameLoaderClientImpl.cpp:
2269 * src/FrameLoaderClientImpl.h:
2270 (FrameLoaderClientImpl):
2271 * src/WebFrameImpl.cpp:
2272 * src/WebFrameImpl.h:
2275 * src/WebIntent.cpp: Removed.
2276 * src/WebIntentRequest.cpp: Removed.
2277 * src/WebIntentServiceInfo.cpp: Removed.
2278 * src/WebRuntimeFeatures.cpp:
2280 2013-02-11 Florin Malita <fmalita@chromium.org>
2282 Unreviewed. Rolled Chromium DEPS to r181770.
2286 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2288 Unreviewed. Rolled Chromium DEPS to r181742. Requested by
2289 fmalita_ via sheriffbot.
2293 2013-02-11 Rouslan Solomakhin <rouslan@chromium.org>
2295 [Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
2296 https://bugs.webkit.org/show_bug.cgi?id=108513
2298 Reviewed by Tony Chang.
2300 WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
2301 WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
2302 of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
2303 uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
2304 range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
2305 to avoid introducing spaces around misspellings.
2307 * src/WebFrameImpl.cpp:
2308 (WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
2309 * tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
2311 2013-02-11 Alexei Filippov <alph@chromium.org>
2313 Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
2314 https://bugs.webkit.org/show_bug.cgi?id=108653
2316 Reviewed by Yury Semikhatsky.
2318 Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
2319 In fact these two profile types have not too much in common. So put each into its own domain.
2320 It should also help when Profiles panel gets split into several tools.
2321 This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
2322 change the original InspectorProfilerAgent.
2324 * src/WebDevToolsAgentImpl.cpp:
2325 (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
2327 2013-02-11 Abhishek Arya <inferno@chromium.org>
2329 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
2330 https://bugs.webkit.org/show_bug.cgi?id=108981
2332 Reviewed by Eric Seidel.
2334 * src/AutofillPopupMenuClient.cpp:
2335 (WebKit::AutofillPopupMenuClient::getSuggestion):
2336 (WebKit::AutofillPopupMenuClient::getLabel):
2337 (WebKit::AutofillPopupMenuClient::getIcon):
2338 (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
2339 (WebKit::AutofillPopupMenuClient::valueChanged):
2340 (WebKit::AutofillPopupMenuClient::selectionChanged):
2341 * src/ChromeClientImpl.cpp:
2342 (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
2344 2013-02-10 James Robinson <jamesr@chromium.org>
2346 [chromium] Enable more of webkit_unit_tests in component builds
2347 https://bugs.webkit.org/show_bug.cgi?id=109369
2349 Reviewed by Darin Fisher.
2351 Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
2352 calling into webkit_support so they work in component builds.
2355 * tests/AssociatedURLLoaderTest.cpp:
2356 * tests/EventListenerTest.cpp:
2357 * tests/FrameTestHelpers.cpp:
2358 (WebKit::FrameTestHelpers::createWebViewAndLoad):
2360 (WebKit::FrameTestHelpers::QuitTask::run):
2362 (WebKit::FrameTestHelpers::runPendingTasks):
2363 * tests/FrameTestHelpers.h:
2365 * tests/ListenerLeakTest.cpp:
2366 * tests/PopupMenuTest.cpp:
2367 * tests/PrerenderingTest.cpp:
2368 * tests/ScrollingCoordinatorChromiumTest.cpp:
2369 (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
2370 (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
2371 * tests/URLTestHelpers.cpp:
2372 (WebKit::URLTestHelpers::registerMockedURLLoad):
2373 * tests/WebFrameTest.cpp:
2374 * tests/WebImageTest.cpp:
2376 * tests/WebPageNewSerializerTest.cpp:
2377 * tests/WebPageSerializerTest.cpp:
2378 * tests/WebPluginContainerTest.cpp:
2379 (WebKit::WebPluginContainerTest::TearDown):
2381 * tests/WebViewTest.cpp:
2383 2013-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
2385 Unreviewed. Rolled Chromium DEPS to r181645. Requested by
2386 "James Robinson" <jamesr@chromium.org> via sheriffbot.
2390 2013-02-09 Stephen Chenney <schenney@chromium.org>
2392 Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
2396 2013-02-09 Sheriff Bot <webkit.review.bot@gmail.com>
2398 Unreviewed. Rolled Chromium DEPS to last-known good revision.
2399 Requested by "Stephen Chenney" <schenney@chromium.org> via
2404 2013-02-08 Kent Tamura <tkent@chromium.org>
2406 [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
2407 https://bugs.webkit.org/show_bug.cgi?id=109272
2409 Reviewed by Kentaro Hara.
2411 We enabled this flag for desktop Chromium, but disabled the feature by a
2412 runtime flag. We disables the compile flag too because we have no plan
2413 to ship it in near future.
2415 * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
2417 2013-02-08 Stephen Chenney <schenney@chromium.org>
2419 Remove Skia code suppressions
2421 Unreviewed enabling of existing optimizations
2423 Removing all skia_webkit.gyp code suppressions and adding expectations
2428 2013-02-08 Dan Carney <dcarney@google.com>
2430 [v8] isolate parameter added to all v8::peristent calls
2431 https://bugs.webkit.org/show_bug.cgi?id=109268
2433 Reviewed by Kentaro Hara.
2435 * tests/WebFrameTest.cpp:
2437 2013-02-07 Kent Tamura <tkent@chromium.org>
2439 [Chromium-Android] Disable input[type=datetime]
2440 https://bugs.webkit.org/show_bug.cgi?id=107614
2442 Reviewed by Kentaro Hara.
2445 http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
2448 Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
2449 We enable it for non-Android ports but the runtime flag for it is
2450 disabled by default. The runtime flag is enabled only in DumpRenderTree.
2452 2013-02-07 Terry Anderson <tdanderson@chromium.org>
2454 [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
2455 https://bugs.webkit.org/show_bug.cgi?id=108719
2457 Reviewed by Eric Seidel.
2459 In the event of a main-thread touch fling, dispatch a series of
2460 GestureScrollUpdateWithoutPropagation events defined in
2461 https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
2462 GestureScrollUpdate events) so that the fling does not
2463 propagate to enclosing scrollables.
2465 * src/WebViewImpl.cpp:
2466 (WebKit::WebViewImpl::scrollBy):
2468 2013-02-07 Kent Tamura <tkent@chromium.org>
2470 [Chromium] Add a flag to enable native form validation message
2471 https://bugs.webkit.org/show_bug.cgi?id=109134
2473 Reviewed by Adam Barth.
2475 * public/WebRuntimeFeatures.h:
2476 (WebRuntimeFeatures): Add enableNativeValidationMessage and
2477 isNativeValidationMessageEnabled.
2478 * src/WebRuntimeFeatures.cpp:
2479 (WebKit): Add nativeValidationMessageEnabled.
2480 (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
2481 (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
2482 * src/WebViewImpl.cpp:
2483 (WebKit::WebViewImpl::WebViewImpl):
2484 Fill Page::PageClients::validationMessageClient if the flag is true.
2486 2013-02-07 Eberhard Graether <egraether@google.com>
2488 Web Inspector: Add settings checkbox for composited layer borders
2489 https://bugs.webkit.org/show_bug.cgi?id=109096
2491 Reviewed by Pavel Feldman.
2493 This change adds a checkbox to show composited layer borders to the WebInspector's
2494 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
2495 is visible if InspectorClient::canShowDebugBorders() returns true.
2497 * src/InspectorClientImpl.cpp:
2498 (WebKit::InspectorClientImpl::canShowDebugBorders):
2500 (WebKit::InspectorClientImpl::setShowDebugBorders):
2501 * src/InspectorClientImpl.h:
2502 (InspectorClientImpl):
2503 * src/WebViewImpl.cpp:
2504 (WebKit::WebViewImpl::WebViewImpl):
2505 (WebKit::WebViewImpl::setShowDebugBorders):
2507 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2508 * src/WebViewImpl.h:
2510 2013-02-07 Stephen White <senorblanco@chromium.org>
2512 Unreviewed. Rolled DEPS.
2516 2013-02-07 David Trainor <dtrainor@chromium.org>
2518 Add null check to editable in moveCaretSelectionTowardsWindowPoint
2519 https://bugs.webkit.org/show_bug.cgi?id=108962
2521 Reviewed by Eric Seidel.
2523 * src/WebFrameImpl.cpp:
2524 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
2525 * tests/WebFrameTest.cpp:
2527 2013-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
2529 Unreviewed. Rolled Chromium DEPS to r180752. Requested by
2530 thakis_ via sheriffbot.
2534 2013-02-06 Terry Anderson <tdanderson@chromium.org>
2536 Add support for gesture scroll events that do not propagate to enclosing scrollables
2537 https://bugs.webkit.org/show_bug.cgi?id=108849
2539 Reviewed by Antonio Gomes.
2541 Define the new event type GestureScrollUpdateWithoutPropagation.
2543 * public/WebInputEvent.h:
2544 (WebKit::WebInputEvent::isGestureEventType):
2545 * src/PageWidgetDelegate.cpp:
2546 (WebKit::PageWidgetDelegate::handleInputEvent):
2547 * src/WebInputEventConversion.cpp:
2548 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2549 * src/WebPluginContainerImpl.cpp:
2550 * src/WebPopupMenuImpl.cpp:
2551 (WebKit::WebPopupMenuImpl::handleInputEvent):
2552 * src/WebViewImpl.cpp:
2553 (WebKit::WebViewImpl::handleGestureEvent):
2555 2013-02-06 Alexandre Elias <aelias@chromium.org>
2557 Make ScrollView::paint() clip by visibleContentRect
2558 https://bugs.webkit.org/show_bug.cgi?id=108888
2560 Reviewed by Levi Weintraub.
2562 When applyPageScaleFactorInCompositor or fixedVisibleContentRect
2563 are used, frameRect() and visibleContentRect(true).size() are
2564 no longer synonyms, and the latter is the one that should be
2565 used for clipping paints.
2567 New WebFrameTest: pageScaleFactorScalesPaintClip.
2569 * tests/WebFrameTest.cpp:
2571 2013-02-06 Sheriff Bot <webkit.review.bot@gmail.com>
2573 Unreviewed, rolling out r142025.
2574 http://trac.webkit.org/changeset/142025
2575 https://bugs.webkit.org/show_bug.cgi?id=109091
2577 broke the build (Requested by tdanderson on #webkit).
2579 * public/WebInputEvent.h:
2580 (WebKit::WebInputEvent::isGestureEventType):
2581 * src/PageWidgetDelegate.cpp:
2582 (WebKit::PageWidgetDelegate::handleInputEvent):
2583 * src/WebInputEventConversion.cpp:
2584 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2585 * src/WebPluginContainerImpl.cpp:
2586 * src/WebPopupMenuImpl.cpp:
2587 (WebKit::WebPopupMenuImpl::handleInputEvent):
2588 * src/WebViewImpl.cpp:
2589 (WebKit::WebViewImpl::handleGestureEvent):
2591 2013-02-06 Daniel Cheng <dcheng@google.com>
2593 [chromium] Remove "config.h" header from WebUnitTests.cpp
2594 https://bugs.webkit.org/show_bug.cgi?id=108966
2596 Reviewed by Tony Chang.
2598 This file includes headers from base/ in Chromium, and config.h
2599 conflicts with base/logging.h. Rather than teaching certain files in
2600 base/ not to #include base/logging.h, remove the config.h include
2601 here. The ASSERT isn't really necessary, as attempting to run a null
2602 test suite won't go very far anyway.
2604 * tests/WebUnitTests.cpp:
2605 (WebKit::RunAllUnitTests):
2607 2013-02-06 Terry Anderson <tdanderson@chromium.org>
2609 Add support for gesture scroll events that do not propagate to enclosing scrollables
2610 https://bugs.webkit.org/show_bug.cgi?id=108849
2612 Reviewed by Antonio Gomes.
2614 Define the new event type GestureScrollUpdateWithoutPropagation.
2616 * public/WebInputEvent.h:
2617 (WebKit::WebInputEvent::isGestureEventType):
2618 * src/PageWidgetDelegate.cpp:
2619 (WebKit::PageWidgetDelegate::handleInputEvent):
2620 * src/WebInputEventConversion.cpp:
2621 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2622 * src/WebPluginContainerImpl.cpp:
2623 * src/WebPopupMenuImpl.cpp:
2624 (WebKit::WebPopupMenuImpl::handleInputEvent):
2625 * src/WebViewImpl.cpp:
2626 (WebKit::WebViewImpl::handleGestureEvent):
2628 2013-02-06 Chris Hopman <cjhopman@chromium.org>
2630 [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
2631 https://bugs.webkit.org/show_bug.cgi?id=108667
2633 Reviewed by Darin Fisher.
2635 WebWidget::selectionBounds() returns the anchor and focus of the
2636 selection. This matches the arguments to WebFrame::selectRange().
2637 Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
2638 anchor/focus to start/end.
2640 * public/WebWidget.h:
2642 (WebKit::WebWidget::isSelectionAnchorFirst):
2643 * src/WebViewImpl.cpp:
2644 (WebKit::WebViewImpl::isSelectionAnchorFirst):
2646 * src/WebViewImpl.h:
2647 * tests/WebViewTest.cpp:
2649 2013-02-06 Alec Flett <alecflett@chromium.org>
2651 IndexedDB: Stub out SharedBuffer version of put()
2652 https://bugs.webkit.org/show_bug.cgi?id=108986
2654 Reviewed by Darin Fisher.
2656 This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
2658 * public/WebIDBDatabase.h:
2660 (WebKit::WebIDBDatabase::put):
2662 2013-02-06 Stephen Chenney <schenney@chromium.org>
2664 Add Skia code suppression flags to WebKit skia.gyp
2668 This is step one in removing these flags. First we get them into
2669 WebKit, then we can remove them from Chrome.
2673 2013-02-06 Mike West <mkwst@chromium.org>
2675 Add an ENABLE_NOSNIFF feature flag.
2676 https://bugs.webkit.org/show_bug.cgi?id=109029
2678 Reviewed by Jochen Eisinger.
2680 This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
2681 when processing script and other resource types.
2685 2013-02-05 David Dorwin <ddorwin@chromium.org>
2687 [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
2688 https://bugs.webkit.org/show_bug.cgi?id=108989
2690 Reviewed by Kent Tamura.
2692 * src/WebMediaPlayerClientImpl.cpp:
2693 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
2695 2013-02-04 Kentaro Hara <haraken@chromium.org>
2697 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
2698 https://bugs.webkit.org/show_bug.cgi?id=108909
2700 Reviewed by Adam Barth.
2702 No tests. No change in behavior.
2704 * src/WebBindings.cpp:
2705 (WebKit::WebBindings::toV8Value):
2707 2013-02-05 Kentaro Hara <haraken@chromium.org>
2709 [V8] Make an Isolate parameter mandatory in HasInstance()
2710 https://bugs.webkit.org/show_bug.cgi?id=108917
2712 Reviewed by Adam Barth.
2714 Because these methods do not have an Isolate, we have to call
2715 v8::Isolate::GetCurrent().
2717 No tests. No change in behavior.
2719 * src/WebArrayBuffer.cpp:
2720 (WebKit::WebArrayBuffer::createFromV8Value):
2721 * src/WebArrayBufferView.cpp:
2722 (WebKit::WebArrayBufferView::createFromV8Value):
2723 * src/WebBindings.cpp:
2724 (WebKit::getRangeImpl):
2725 (WebKit::getNodeImpl):
2726 (WebKit::getElementImpl):
2727 (WebKit::getArrayBufferImpl):
2728 (WebKit::getArrayBufferViewImpl):
2729 (WebKit::WebBindings::getRange):
2730 (WebKit::WebBindings::getArrayBuffer):
2731 (WebKit::WebBindings::getArrayBufferView):
2732 (WebKit::WebBindings::getNode):
2733 (WebKit::WebBindings::getElement):
2735 2013-02-05 Dana Jansens <danakj@chromium.org>
2737 [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
2738 https://bugs.webkit.org/show_bug.cgi?id=107776
2740 Reviewed by James Robinson.
2743 * src/WebGraphicsContext3D.cpp: Removed.
2745 2013-02-05 Mark Lam <mark.lam@apple.com>
2747 Introduced back-end database classes + a few small fixes.
2748 https://bugs.webkit.org/show_bug.cgi?id=108759.
2750 Reviewed by Brady Eidson.
2752 * src/DatabaseObserver.cpp:
2753 (WebCore::DatabaseObserver::databaseOpened):
2754 (WebCore::DatabaseObserver::databaseModified):
2755 (WebCore::DatabaseObserver::databaseClosed):
2757 2013-02-05 Adam Barth <abarth@webkit.org>
2759 DumpRenderTree should be able to enable the threaded parser
2760 https://bugs.webkit.org/show_bug.cgi?id=108970
2762 Reviewed by Eric Seidel.
2764 * public/WebSettings.h:
2765 * src/WebSettingsImpl.cpp:
2766 (WebKit::WebSettingsImpl::setThreadedHTMLParser):
2768 * src/WebSettingsImpl.h:
2771 2013-02-05 Sami Kyostila <skyostil@chromium.org>
2773 [chromium] Make overlay layers slow-scrolling
2774 https://bugs.webkit.org/show_bug.cgi?id=108957
2776 Reviewed by James Robinson.
2778 Since overlay layers get inserted on top of everything else, we must
2779 mark them slow-scrolling to prevent all scroll input events to the rest
2780 of the page from getting blocked. This is also more correct because
2781 generally the overlay contents need to be repainted whenever the scroll
2782 offset changes, and with this patch the painting happens in sync with
2785 2013-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
2787 Unreviewed, rolling out r141896.
2788 http://trac.webkit.org/changeset/141896
2789 https://bugs.webkit.org/show_bug.cgi?id=108956
2791 crashes indexdb security tests (Requested by gavinp on
2794 * public/platform/WebKitPlatformSupport.h:
2796 (WebKitPlatformSupport):
2797 (WebKit::WebKitPlatformSupport::idbFactory):
2798 * src/IDBFactoryBackendProxy.cpp:
2799 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
2801 2013-02-05 Mark Pilgrim <pilgrim@chromium.org>
2803 [Chromium] Remove idbFactory from WebKitPlatformSupport
2804 https://bugs.webkit.org/show_bug.cgi?id=106457
2806 Reviewed by Adam Barth.
2808 Now that https://codereview.chromium.org/12181010/ has landed, the
2809 idbFactory method is no longer needed. (Embedders must now call
2810 the new setIDBFactory method upon initialization.) Part of a
2811 larger refactoring series; see tracking bug 82948.
2813 * public/platform/WebKitPlatformSupport.h:
2815 * src/IDBFactoryBackendProxy.cpp:
2816 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
2818 2013-02-05 Kentaro Hara <haraken@chromium.org>
2820 Unreviewed, rolling out r141865.
2821 http://trac.webkit.org/changeset/141865
2822 https://bugs.webkit.org/show_bug.cgi?id=108909
2824 webkit unit tests are broken
2826 * src/WebBindings.cpp:
2827 (WebKit::WebBindings::toV8Value):
2829 2013-02-05 Kentaro Hara <haraken@chromium.org>
2831 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
2832 https://bugs.webkit.org/show_bug.cgi?id=108909
2834 Reviewed by Adam Barth.
2836 No tests. No change in behavior.
2838 * src/WebBindings.cpp:
2839 (WebKit::WebBindings::toV8Value):
2841 2013-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
2843 Unreviewed. Rolled Chromium DEPS to r180583. Requested by
2844 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
2848 2013-02-04 James Simonsen <simonjam@chromium.org>
2850 [Chromium] Add a signal for when the body is inserted in the document
2851 https://bugs.webkit.org/show_bug.cgi?id=108725
2853 Reviewed by Adam Barth.
2855 * public/WebFrameClient.h:
2857 (WebKit::WebFrameClient::willInsertBody):
2858 * src/FrameLoaderClientImpl.cpp:
2859 (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
2861 * src/FrameLoaderClientImpl.h:
2862 (FrameLoaderClientImpl):
2863 * tests/WebFrameTest.cpp:
2865 2013-02-04 Chris Hopman <cjhopman@chromium.org>
2867 Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
2868 https://bugs.webkit.org/show_bug.cgi?id=107850
2870 Reviewed by Ojan Vafai.
2872 On Android, EditingBehavior::shouldMoveCaret[...] controls the
2873 behavior of insertion handles. This change adds a new Android specific
2874 editing behavior type so that we can change these settings independent
2875 of behavior for other platforms.
2877 * public/WebSettings.h:
2878 * src/AssertMatchingEnums.cpp:
2879 Just add the corresponding assertion for the new editing behavior.
2881 * public/WebSettings.h:
2882 * src/AssertMatchingEnums.cpp:
2884 * tests/WebFrameTest.cpp:
2885 * tests/data/move_caret.html: Added.
2886 Add a test that moveCaretTowardsWindowPoint works as expected on
2889 2013-01-31 Kentaro Hara <haraken@chromium.org>
2891 Implement WheelEvent::deltaMode
2892 https://bugs.webkit.org/show_bug.cgi?id=108455
2894 Reviewed by Adam Barth.
2896 * src/WebInputEventConversion.cpp:
2897 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
2899 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
2901 [Chromium] Move WorkerContextProxy to WebCore
2902 https://bugs.webkit.org/show_bug.cgi?id=108847
2904 Reviewed by Adam Barth.
2906 Part of a larger refactoring series; see tracking bug 106829.
2910 (WebKit::initializeWithoutV8):
2911 * src/WorkerContextProxy.cpp: Removed.
2913 2013-02-04 Abhishek Arya <inferno@chromium.org>
2915 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
2916 https://bugs.webkit.org/show_bug.cgi?id=108668
2918 Reviewed by Eric Seidel.
2920 * src/ContextFeaturesClientImpl.cpp:
2921 (WebKit::ContextFeaturesCache::entryFor):
2922 * src/WebFrameImpl.cpp:
2923 (WebKit::WebFrameImpl::selectFindMatch):
2925 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
2927 [Chromium] Move IDBFactoryBackendInterface to WebCore
2928 https://bugs.webkit.org/show_bug.cgi?id=108638
2930 Reviewed by Adam Barth.
2932 Part of a larger refactoring series; see tracking bug 106829.
2935 * src/AssertMatchingEnums.cpp:
2936 * src/IDBFactoryBackendInterface.cpp: Removed.
2937 * src/IDBFactoryBackendProxy.h:
2939 (WebKit::initializeWithoutV8):
2941 2013-02-04 Abhishek Arya <inferno@chromium.org>
2943 Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
2944 https://bugs.webkit.org/show_bug.cgi?id=108688
2946 Reviewed by Eric Seidel.
2948 * src/IDBFactoryBackendProxy.cpp:
2949 (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
2950 (WebKit::getWebFrame):
2951 * src/LocalFileSystemChromium.cpp:
2952 (WebCore::LocalFileSystem::deleteFileSystem):
2953 * src/WebSharedWorkerImpl.cpp:
2954 (WebKit::WebSharedWorkerImpl::connectTask):
2955 (WebKit::resumeWorkerContextTask):
2956 (WebKit::connectToWorkerContextInspectorTask):
2957 (WebKit::reconnectToWorkerContextInspectorTask):
2958 (WebKit::disconnectFromWorkerContextInspectorTask):
2959 (WebKit::dispatchOnInspectorBackendTask):
2961 2013-02-04 Sami Kyostila <skyostil@chromium.org>
2963 Disable -webkit-overflow-scrolling CSS attribute on Chromium
2964 https://bugs.webkit.org/show_bug.cgi?id=108020
2966 Reviewed by James Robinson.
2968 Now that we can automatically promote overflow elements to accelerated
2969 scrolling layers there is no use for the -webkit-overflow-scrolling CSS
2970 attribute any longer on Chromium.
2972 This patch enables composited overflow scrolling in
2973 ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
2974 in non-fast-scrollable.html to become composited, we also need to modify that
2975 test to opt it out of composited scrolling.
2978 * tests/ScrollingCoordinatorChromiumTest.cpp:
2979 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
2981 * tests/data/non-fast-scrollable.html:
2982 * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
2984 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
2986 Fix build warning after r141473
2987 https://bugs.webkit.org/show_bug.cgi?id=108782
2989 Reviewed by Kentaro Hara.
2991 Fix -Wunused-parameter build warning.
2993 * src/EditorClientImpl.cpp:
2994 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
2996 2013-02-03 David Dorwin <ddorwin@chromium.org>
2998 [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
2999 https://bugs.webkit.org/show_bug.cgi?id=108740
3001 Reviewed by Kent Tamura.
3003 The calls to m_widgetClient->show() and setFocus() do not appear to be
3004 necessary, and the former causes problems on at least on platform.
3006 * src/WebHelperPluginImpl.cpp:
3007 (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
3008 (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
3010 2013-02-02 Michael Nordman <michaeln@google.com>
3012 [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
3013 This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
3014 sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
3015 in place and in use.
3016 https://bugs.webkit.org/show_bug.cgi?id=108736
3018 Reviewed by Darin Fisher.
3020 * public/WebFileSystemCallbacks.h:
3021 (WebFileSystemCallbacks):
3022 (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
3024 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
3026 Unreviewed. Rolled Chromium DEPS to r180221. Requested by
3027 "Nico Weber" <thakis@chromium.org> via sheriffbot.
3031 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
3033 Unreviewed. Rolled Chromium DEPS to r180186. Requested by
3034 "Nico Weber" <thakis@chromium.org> via sheriffbot.
3038 2013-02-01 Chris Hopman <cjhopman@chromium.org>
3040 [Chromium] WebWidget::selectionBounds should return the bounds in document space
3041 https://bugs.webkit.org/show_bug.cgi?id=108386
3043 Reviewed by James Robinson.
3045 When in applyPageScaleFactorInCompositor mode, selectionBounds needs
3046 to scale the anchor/focus window points by the pageScaleFactor.
3048 * src/WebViewImpl.cpp:
3049 (WebKit::WebViewImpl::selectionBounds):
3050 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
3052 2013-02-01 Dominic Mazzoni <dmazzoni@google.com>
3054 AX: memoize expensive computation during blocks where tree doesn't change
3055 https://bugs.webkit.org/show_bug.cgi?id=106497
3057 Reviewed by Ryosuke Niwa.
3059 Expose two methods to enable and disable caching of
3060 computed WebAccessibilityObject attributes, to speed up
3061 batch read-only operations.
3063 * public/WebAccessibilityObject.h:
3064 (WebAccessibilityObject):
3065 * src/WebAccessibilityObject.cpp:
3066 (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
3068 (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
3070 2013-02-01 Fady Samuel <fsamuel@chromium.org>
3072 [Chromium] Expose WebNode::shadowHost()
3073 https://bugs.webkit.org/show_bug.cgi?id=108681
3075 Reviewed by Dimitri Glazkov.
3077 BrowserPlugin needs to be able to check the event listeners attached to
3078 <webview> and so we expose shadowHost to permit it to poke at the webview
3083 (WebKit::WebNode::shadowHost):
3086 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
3088 [Chromium] Ignore punctuation in spellcheck
3089 https://bugs.webkit.org/show_bug.cgi?id=108511
3091 Reviewed by Tony Chang.
3093 * src/ContextMenuClientImpl.cpp:
3094 (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
3095 (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
3097 2013-02-01 Philip Rogers <pdr@google.com>
3099 Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
3100 https://bugs.webkit.org/show_bug.cgi?id=106966
3102 Reviewed by Stephen White.
3104 * tests/DragImageTest.cpp:
3105 (WebCore::TestImage::currentFrameKnownToBeOpaque):
3107 * tests/ImageLayerChromiumTest.cpp:
3108 (WebCore::TestImage::currentFrameKnownToBeOpaque):
3109 * tests/PlatformContextSkiaTest.cpp:
3112 2013-02-01 Nico Weber <thakis@chromium.org>
3114 [chromium] Build webkit with enable_web_intents set to 0.
3115 https://bugs.webkit.org/show_bug.cgi?id=108408
3117 Reviewed by Tony Chang.
3119 I'll then make chromium build fine with that, then switch
3120 enable_web_intents to 0, roll that into webkit, and then
3121 actually remove the code hidden behind this flag.
3123 The features.gypi bit depends on https://codereview.chromium.org/12143002/
3124 and will disable web intents support on android. Since common.gypi
3125 sets enable_web_intents to 0 explicitly, it seems this is currently on
3128 While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
3129 features.gypi completely, it's still set further down the file if
3130 enable_web_intents is on.
3134 * src/WebFrameImpl.cpp:
3136 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
3138 [Chromium] Ignore whitespace in spellcheck
3139 https://bugs.webkit.org/show_bug.cgi?id=108510
3141 Reviewed by Ryosuke Niwa.
3143 * src/ContextMenuClientImpl.cpp:
3144 (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
3146 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
3148 Unreviewed. Rolled Chromium DEPS to r180131. Requested by
3149 "Florin Malita" <fmalita@chromium.org> via sheriffbot.
3153 2013-02-01 Alexis Menard <alexis@webkit.org>
3155 Enable unprefixed CSS transitions by default.
3156 https://bugs.webkit.org/show_bug.cgi?id=108216
3158 Reviewed by Dean Jackson.
3160 Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
3161 to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
3162 guard the unprefixing work for CSS Transforms and animations.
3166 2013-02-01 Ken Kania <kkania@chromium.org>
3168 Web Inspector: Add support for handling modal dialogs
3169 https://bugs.webkit.org/show_bug.cgi?id=107883
3171 Reviewed by Pavel Feldman.
3173 Introduce support for being notified when a JavaScript modal dialog
3174 is opening and closing, as well as a new command for accepting or
3175 dismissing the dialog.
3177 * public/WebDevToolsAgent.h:
3178 * src/InspectorClientImpl.cpp:
3179 (WebKit::InspectorClientImpl::handleJavaScriptDialog):
3181 * src/InspectorClientImpl.h:
3182 (InspectorClientImpl):
3183 * src/WebDevToolsAgentImpl.cpp:
3184 (BrowserDataHintStringValues):
3185 (WebKit::WebDevToolsAgentImpl::captureScreenshot):
3186 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
3188 (WebKit::browserHintToString):
3189 (WebKit::browserHintFromString):
3190 (WebKit::WebDevToolsAgent::patchWithBrowserData):
3191 * src/WebDevToolsAgentImpl.h:
3192 (WebDevToolsAgentImpl):
3194 2013-02-01 Dan Alcantara <dfalcantara@chromium.org>
3196 Touch disambiguation blacklist is not being queried properly
3197 https://bugs.webkit.org/show_bug.cgi?id=108222
3199 Reviewed by Adam Barth.
3201 TEST=WebFrameTest::DisambiguationPopupBlacklist
3203 Fix the blacklist so that we check it for the right nodes.
3204 Add a test to check that the blacklist is being built and used
3205 correctly. Also update the other DisambiguationPopup tests to
3206 use the new page scale method.
3208 * tests/WebFrameTest.cpp:
3209 * tests/data/disambiguation_popup_blacklist.html: Added.
3211 2013-02-01 Eberhard Graether <egraether@google.com>
3213 [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
3214 https://bugs.webkit.org/show_bug.cgi?id=108236
3216 Reviewed by Pavel Feldman.
3218 This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
3219 This way the checkboxes only show up for users that can make use of these features.
3221 * src/InspectorClientImpl.cpp:
3222 (WebKit::InspectorClientImpl::canShowFPSCounter):
3223 (WebKit::InspectorClientImpl::canContinuouslyPaint):
3225 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3227 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
3228 https://bugs.webkit.org/show_bug.cgi?id=107737
3230 Reviewed by Ryosuke Niwa.
3232 * public/WebViewClient.h:
3233 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
3234 Adding a callback to let the WebViewClient know that the composition has been cancelled.
3235 * src/EditorClientImpl.cpp:
3236 (WebKit::EditorClientImpl::respondToChangedSelection):
3237 Adding a call composition if it is no longer valid.
3239 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3241 [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
3242 https://bugs.webkit.org/show_bug.cgi?id=108543
3244 Reviewed by Ryosuke Niwa.
3246 Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
3248 * src/WebViewImpl.cpp:
3249 (WebKit::WebViewImpl::setCompositionFromExistingText):
3250 * tests/WebViewTest.cpp:
3251 Re-enabling the test
3253 2013-01-31 Hajime Morrita <morrita@google.com>
3255 Unreviewed, followup fix for r141535.
3257 * tests/WebFrameTest.cpp:
3259 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
3261 Unreviewed. Rolled Chromium DEPS to r180023. Requested by
3262 thakis_ via sheriffbot.
3266 2013-01-31 Hajime Morrita <morrita@google.com>
3268 Unreviewed, disabling failing test.
3270 * tests/WebFrameTest.cpp:
3272 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
3274 Unreviewed, rolling out r141479.
3275 http://trac.webkit.org/changeset/141479
3276 https://bugs.webkit.org/show_bug.cgi?id=108564
3278 breaks chromium test (Requested by morrita on #webkit).
3280 * public/WebViewClient.h:
3281 * src/EditorClientImpl.cpp:
3282 (WebKit::EditorClientImpl::respondToChangedSelection):
3284 2013-01-31 Alec Flett <alecflett@chromium.org>
3286 IndexedDB: remove old transaction backend bootstrap code
3287 https://bugs.webkit.org/show_bug.cgi?id=103923
3289 Reviewed by Dimitri Glazkov.
3291 Remove all deprecated WebKit APIs from
3295 * public/WebIDBCallbacks.h:
3297 * public/WebIDBDatabase.h:
3299 * public/WebIDBTransaction.h: Removed.
3300 * public/WebIDBTransactionCallbacks.h: Removed.
3301 * src/AssertMatchingEnums.cpp:
3302 * src/IDBCallbacksProxy.cpp:
3303 * src/IDBDatabaseBackendProxy.cpp:
3304 * src/IDBDatabaseBackendProxy.h:
3305 (IDBDatabaseBackendProxy):
3306 * src/IDBTransactionBackendProxy.cpp: Removed.
3307 * src/IDBTransactionBackendProxy.h: Removed.
3308 * src/IDBTransactionCallbacksProxy.cpp: Removed.
3309 * src/IDBTransactionCallbacksProxy.h: Removed.
3310 * src/WebIDBCallbacksImpl.cpp:
3311 * src/WebIDBDatabaseImpl.cpp:
3313 * src/WebIDBDatabaseImpl.h:
3315 (WebIDBDatabaseImpl):
3316 * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
3317 * src/WebIDBTransactionCallbacksImpl.h: Removed.
3318 * src/WebIDBTransactionImpl.cpp: Removed.
3319 * src/WebIDBTransactionImpl.h: Removed.
3320 * tests/IDBAbortOnCorruptTest.cpp:
3321 * tests/IDBDatabaseBackendTest.cpp:
3323 2013-01-31 Rouslan Solomakhin <rouslan@chromium.org>
3325 [Chromium] Select multi-word misspelling on context click
3326 https://bugs.webkit.org/show_bug.cgi?id=108509
3328 Reviewed by Tony Chang.
3330 * src/ContextMenuClientImpl.cpp:
3332 (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
3333 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
3335 2013-01-31 Florin Malita <fmalita@chromium.org>
3337 [Chromium] Unreviewed gardening.
3339 WebViewTest.SetCompositionFromExistingText failing after r141479.
3341 * tests/WebViewTest.cpp:
3343 2013-01-31 Alexandre Elias <aelias@chromium.org>
3345 [chromium] Rework page scale factor limits initialization
3346 https://bugs.webkit.org/show_bug.cgi?id=108446
3348 Reviewed by James Robinson.
3350 When loading a page with viewportEnabled, both the limits
3351 specified by the viewport tag and the content width need to be
3352 considered before we initialize the minimum page scale (and
3353 pageScaleFactor itself usually to the same value). The timing has
3354 proven tricky to get correct.
3356 This patch simplifies the flow by computing the
3357 limits only at the end of layouts and at no other time. In combination
3358 with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
3359 needsLayout() appropriately, this results in a more robust and easy
3360 to understand sequence.
3362 Fixes FixedLayoutInitializeAtMinimumPageScale test.
3364 * src/ChromeClientImpl.cpp:
3365 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3366 * src/WebViewImpl.cpp:
3367 (WebKit::WebViewImpl::WebViewImpl):
3368 (WebKit::WebViewImpl::resize):
3369 (WebKit::WebViewImpl::setPageScaleFactorLimits):
3370 (WebKit::WebViewImpl::computePageScaleFactorLimits):
3371 (WebKit::WebViewImpl::layoutUpdated):
3372 (WebKit::WebViewImpl::didChangeContentsSize):
3373 * src/WebViewImpl.h:
3374 (WebKit::WebViewImpl::setInitialPageScaleFactor):
3376 * tests/WebFrameTest.cpp:
3378 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3380 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
3381 https://bugs.webkit.org/show_bug.cgi?id=107737
3383 Reviewed by Ryosuke Niwa.
3385 * public/WebViewClient.h:
3386 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
3387 Adding a callback to let the WebViewClient know that the composition has been cancelled.
3388 * src/EditorClientImpl.cpp:
3389 (WebKit::EditorClientImpl::respondToChangedSelection):
3390 Adding a call composition if it is no longer valid.
3392 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
3394 [Chromium] Move LocalizedStrings to WebCore
3395 https://bugs.webkit.org/show_bug.cgi?id=108488
3397 Reviewed by Adam Barth.
3399 Part of a larger refactoring series; see tracking bug 106829.
3402 * src/LocalizedStrings.cpp: Removed.
3404 2013-01-31 Enrica Casucci <enrica@apple.com>
3406 WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
3407 https://bugs.webkit.org/show_bug.cgi?id=108396.
3408 <rdar://problem/12920461>
3410 Reviewed by Alexey Proskuryakov.
3412 Adds stub implementation for WebKit of the new EditorClient methods.
3414 * src/EditorClientImpl.cpp:
3415 (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
3416 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
3417 * src/EditorClientImpl.h:
3419 2013-01-31 Chris Hopman <cjhopman@chromium.org>
3421 [chromium] Make selection handling work in applyPageScaleInCompositor mode
3422 https://bugs.webkit.org/show_bug.cgi?id=107831
3424 Reviewed by Ryosuke Niwa.
3426 These functions expect a window point. When in
3427 applyPageScaleFactorInCompositor mode, the points need to be unscaled
3428 by the page scale factor.
3430 * src/WebFrameImpl.cpp:
3431 (WebKit::WebFrameImpl::selectRange):
3432 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
3434 2013-01-31 Tom Sepez <tsepez@chromium.org>
3436 [v8] Enable binding integrity on mac
3437 https://bugs.webkit.org/show_bug.cgi?id=108500
3439 Reviewed by Adam Barth.
3441 Patch is correct if existing tests pass without new crashes.
3444 Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
3446 2013-01-31 Dan Alcantara <dfalcantara@chromium.org>
3448 WebFrameTest.DisambiguationPopup is failing
3449 https://bugs.webkit.org/show_bug.cgi?id=108160
3451 Reviewed by Adam Barth.
3453 Fix the unit test so that it is using the right HTML file.
3455 * tests/WebFrameTest.cpp:
3457 2013-01-31 Tony Chang <tony@chromium.org>
3459 [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
3460 https://bugs.webkit.org/show_bug.cgi?id=108497
3462 Reviewed by James Robinson.
3464 * WebKitUnitTests.gyp:
3466 2013-01-31 Alexandre Elias <aelias@chromium.org>
3468 Call FrameView::contentsResized() when setting fixed layout size
3469 https://bugs.webkit.org/show_bug.cgi?id=107922
3471 Reviewed by James Robinson.
3473 In fixed layout mode, we should be calling contentsResized() when the
3474 fixed layout size is changed, but not laying out when the visible
3475 content rect changes.
3477 Previously landed as r140869 but was reverted due to a bug in bundled
3478 Chromium-specific code. This patch includes just the minimum needed in
3481 New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
3482 flaky and obsolete tests for the old page scale mode are also deleted.
3484 * tests/WebFrameTest.cpp:
3486 2013-01-31 Tommy Widenflycht <tommyw@google.com>
3488 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
3489 https://bugs.webkit.org/show_bug.cgi?id=108458
3491 Reviewed by Adam Barth.
3493 Only renames, no other code changes.
3495 * public/WebMediaStreamRegistry.h:
3497 (WebMediaStreamRegistry):
3498 * public/WebUserMediaRequest.h:
3500 (WebUserMediaRequest):
3501 * src/WebMediaStreamRegistry.cpp:
3502 (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
3503 * src/WebUserMediaRequest.cpp:
3504 (WebKit::WebUserMediaRequest::requestSucceeded):
3506 2013-01-31 Alec Flett <alecflett@chromium.org>
3508 IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
3509 https://bugs.webkit.org/show_bug.cgi?id=108399
3511 Reviewed by Dimitri Glazkov.
3513 Cleanup now that chromium proxies the new signatures through.
3515 * src/IDBCallbacksProxy.cpp:
3516 (WebKit::IDBCallbacksProxy::onSuccess):
3517 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
3518 * src/IDBCallbacksProxy.h:
3519 (IDBCallbacksProxy):
3520 * src/WebIDBCallbacksImpl.cpp:
3521 * src/WebIDBCallbacksImpl.h:
3522 (WebIDBCallbacksImpl):
3524 2013-01-31 James Robinson <jamesr@chromium.org>