1 2013-03-03 Alexandre Elias <aelias@chromium.org>
3 [chromium] Remove WebLayerTreeView::setViewportSize call
4 https://bugs.webkit.org/show_bug.cgi?id=110727
6 Reviewed by James Robinson.
8 After https://codereview.chromium.org/12328080 lands,
9 setViewportSize is called from the Chromium side. The multiplication
10 by deviceScaleFactor here was prone to off-by-one errors.
11 The layoutSize() function was only used here so delete it as well.
13 DumpRenderTree WebViewHost must now call this method as well.
15 * src/WebViewImpl.cpp:
16 (WebKit::WebViewImpl::updateLayerTreeViewport):
20 2013-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
22 Unreviewed, rolling out r144567.
23 http://trac.webkit.org/changeset/144567
24 https://bugs.webkit.org/show_bug.cgi?id=111266
26 Does not compile on apple-win (Requested by abarth on
30 * src/WebFrameImpl.cpp:
31 (WebKit::WebFrameImpl::iconURLs):
35 2013-03-03 Mike West <mkwst@chromium.org>
37 CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
38 https://bugs.webkit.org/show_bug.cgi?id=111254
40 Reviewed by Adam Barth.
42 The enum names no longer made sense: the difference between the
43 canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
44 prefix, not the functionality. This patch renames them for clarity.
46 * public/WebContentSecurityPolicy.h:
47 * src/AssertMatchingEnums.cpp:
48 Rename the Chromium side of the enums.
50 2013-03-03 Adam Barth <abarth@webkit.org>
52 Unreviewed attempted build fix. Adds back some includes removed in
53 http://trac.webkit.org/changeset/144565.
55 * src/ApplicationCacheHost.cpp:
56 * src/AssociatedURLLoader.cpp:
57 * src/EditorClientImpl.cpp:
58 * src/SharedWorkerRepository.cpp:
59 * src/WebDataSourceImpl.cpp:
63 * src/WebSharedWorkerImpl.cpp:
64 * tests/FrameLoaderClientImplTest.cpp:
66 2013-03-03 Adam Barth <abarth@webkit.org>
68 Unreviewed rollout of http://trac.webkit.org/r144530
69 As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
70 https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
71 large number of ASSERTs in chromium-win.
73 * src/ApplicationCacheHost.cpp:
74 * src/AssociatedURLLoader.cpp:
75 * src/EditorClientImpl.cpp:
76 * src/SharedWorkerRepository.cpp:
77 * src/WebDataSourceImpl.cpp:
81 * src/WebSharedWorkerImpl.cpp:
82 * tests/FrameLoaderClientImplTest.cpp:
84 2013-03-03 Ankur Taly <ataly@google.com>
86 WebKit API for enabling DOM logging for certain worlds
87 https://bugs.webkit.org/show_bug.cgi?id=110779
89 Reviewed by Kentaro Hara.
93 2013-03-03 James Weatherall <wez@chromium.org>
95 keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
96 https://bugs.webkit.org/show_bug.cgi?id=85642
98 Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.
100 Reviewed by Adam Barth.
103 * tests/KeyCodeConversionTestGtk.cpp: Added.
107 2013-02-18 Darin Adler <darin@apple.com>
109 Cut down the number of source files that depend on Clipboard.h
110 https://bugs.webkit.org/show_bug.cgi?id=110030
112 Reviewed by Ryosuke Niwa.
114 * src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h
115 here. We used to get this indirectly through Clipboard.h.
117 2013-02-28 Alexey Proskuryakov <ap@apple.com>
119 Reduce amount of rebuilding when touching networking headers
120 https://bugs.webkit.org/show_bug.cgi?id=111035
122 Reviewed by Eric Seidel.
124 Adding includes that are now necessary because WebCore headers don't have them
127 * src/ApplicationCacheHost.cpp:
128 * src/AssociatedURLLoader.cpp:
129 * src/EditorClientImpl.cpp:
130 * src/SharedWorkerRepository.cpp:
131 * src/WebDataSourceImpl.cpp:
132 * src/WebFrameImpl.h:
134 * src/WebSharedWorkerImpl.cpp:
135 * tests/FrameLoaderClientImplTest.cpp:
137 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
139 Unreviewed. Rolled Chromium DEPS to r185662. Requested by
140 "James Robinson" <jamesr@chromium.org> via sheriffbot.
144 2013-03-01 Terry Anderson <tdanderson@chromium.org>
146 EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
147 so its behavior matches other user-initiated scrolls
148 https://bugs.webkit.org/show_bug.cgi?id=109769
150 Reviewed by James Robinson.
152 Clear the nodes corresponding to a fling scroll event when the event ends.
154 * src/WebViewImpl.cpp:
155 (WebKit::WebViewImpl::updateAnimations):
157 2013-03-01 David Dorwin <ddorwin@chromium.org>
159 [chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
160 https://bugs.webkit.org/show_bug.cgi?id=111232
162 Reviewed by Adam Barth.
164 This patch reverts r143827, which causes a crash in failure conditions:
165 http://crbug.com/178848
167 * src/WebHelperPluginImpl.cpp:
168 (WebKit::WebHelperPluginImpl::destoryPage):
170 2013-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
172 Unreviewed, rolling out r144422 and r144424.
173 http://trac.webkit.org/changeset/144422
174 http://trac.webkit.org/changeset/144424
175 https://bugs.webkit.org/show_bug.cgi?id=111167
177 Caused over 20 tests to fail assertion on Chromium Win port as
178 ASSERTION FAILED: m_platformRequestUpdated (Requested by
179 toyoshim on #webkit).
181 * src/ApplicationCacheHost.cpp:
182 * src/AssociatedURLLoader.cpp:
183 * src/EditorClientImpl.cpp:
184 * src/SharedWorkerRepository.cpp:
185 * src/WebDataSourceImpl.cpp:
186 * src/WebFrameImpl.h:
189 * src/WebSharedWorkerImpl.cpp:
190 * tests/FrameLoaderClientImplTest.cpp:
192 2013-03-01 Jochen Eisinger <jochen@chromium.org>
194 REGRESSION(r144422): Broke compilation on chromium-mac
195 https://bugs.webkit.org/show_bug.cgi?id=111150
197 Unreviewed build fix.
199 * src/WebFrameImpl.h:
202 2013-02-28 Alexey Proskuryakov <ap@apple.com>
204 Reduce amount of rebuilding when touching networking headers
205 https://bugs.webkit.org/show_bug.cgi?id=111035
207 Reviewed by Eric Seidel.
209 Adding includes that are now necessary because WebCore headers don't have them
212 * src/ApplicationCacheHost.cpp:
213 * src/AssociatedURLLoader.cpp:
214 * src/EditorClientImpl.cpp:
215 * src/SharedWorkerRepository.cpp:
216 * src/WebDataSourceImpl.cpp:
217 * src/WebFrameImpl.h:
219 * src/WebSharedWorkerImpl.cpp:
220 * tests/FrameLoaderClientImplTest.cpp:
222 2013-02-28 Ankur Taly <ataly@google.com>
224 WebKit API for enabling DOM logging for certain worlds
225 https://bugs.webkit.org/show_bug.cgi?id=110779
227 Reviewed by Adam Barth.
229 This patch adds initial plumbing for enabling logging of DOM
230 activity by JavaScript code running withing v8, on a
231 per-world basis. In particular it adds methods to the chromium
232 WebKit API for associating a logger object with world ids for which
233 DOM activity logging is enabled.
237 * public/WebDOMActivityLogger.h: Added.
240 (WebDOMActivityLogger):
241 (WebKit::WebDOMActivityLogger::~WebDOMActivityLogger):
242 (WebKit::WebDOMActivityLogger::log):
243 * src/WebDOMActivityLogger.cpp: Added.
245 (DOMActivityLoggerContainer):
246 (WebKit::DOMActivityLoggerContainer::DOMActivityLoggerContainer):
247 (WebKit::DOMActivityLoggerContainer::~DOMActivityLoggerContainer):
248 (WebKit::DOMActivityLoggerContainer::log):
249 (WebKit::hasDOMActivityLogger):
250 (WebKit::setDOMActivityLogger):
252 2013-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
254 Unreviewed. Rolled Chromium DEPS to r185341. Requested by
255 "James Robinson" <jamesr@chromium.org> via sheriffbot.
259 2013-02-28 Varun Jain <varunjain@chromium.org>
261 Add new webkit API to invoke a context menu.
262 https://bugs.webkit.org/show_bug.cgi?id=111040
264 Reviewed by Adam Barth.
268 * src/WebViewImpl.cpp:
269 (WebKit::WebViewImpl::showContextMenu):
273 2013-02-28 Aaron Colwell <acolwell@chromium.org>
275 Factor SourceBuffer methods out of MediaSourcePrivate & WebMediaSource
276 into SourceBufferPrivate & WebSourceBuffer respectively.
277 https://bugs.webkit.org/show_bug.cgi?id=110798
279 Reviewed by Adam Barth, Jer Noble.
282 * public/WebMediaSourceClient.h:
284 (WebMediaSourceClient):
285 * public/WebSourceBuffer.h:
287 (WebSourceBuffer): Contains SourceBuffer methods extracted from WebMediaSource.
288 (WebKit::WebSourceBuffer::~WebSourceBuffer):
289 * src/AssertMatchingEnums.cpp:
290 * src/MediaSourcePrivateImpl.cpp:
292 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
293 (WebKit::MediaSourcePrivateImpl::addSourceBuffer):
294 (WebKit::MediaSourcePrivateImpl::duration):
295 (WebKit::MediaSourcePrivateImpl::setDuration):
296 (WebKit::MediaSourcePrivateImpl::endOfStream):
297 * src/MediaSourcePrivateImpl.h:
299 (MediaSourcePrivateImpl): Adapts MediaSourcePrivate interface to WebMediaSourceClient.
300 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
301 * src/SourceBufferPrivateImpl.cpp:
303 (WebKit::SourceBufferPrivateImpl::SourceBufferPrivateImpl):
304 (WebKit::SourceBufferPrivateImpl::buffered):
305 (WebKit::SourceBufferPrivateImpl::append):
306 (WebKit::SourceBufferPrivateImpl::abort):
307 (WebKit::SourceBufferPrivateImpl::setTimestampOffset):
308 (WebKit::SourceBufferPrivateImpl::removedFromMediaSource):
309 * src/SourceBufferPrivateImpl.h:
311 (SourceBufferPrivateImpl): Adapts SourceBufferPrivate interface to WebSourceBuffer.
312 (WebKit::SourceBufferPrivateImpl::~SourceBufferPrivateImpl):
313 * src/WebMediaPlayerClientImpl.cpp:
314 (WebMediaSourceClientImpl):
316 (WebSourceBufferImpl): Temporary implementation of WebSourceBuffer to keep things working
317 until the Chromium side changes land.
318 (WebKit::WebMediaSourceClientImpl::addSourceBuffer):
319 (WebKit::WebMediaSourceClientImpl::duration):
320 (WebKit::WebMediaSourceClientImpl::setDuration):
321 (WebKit::WebMediaSourceClientImpl::endOfStream):
322 (WebKit::WebSourceBufferImpl::WebSourceBufferImpl):
323 (WebKit::WebSourceBufferImpl::buffered):
324 (WebKit::WebSourceBufferImpl::append):
325 (WebKit::WebSourceBufferImpl::abort):
326 (WebKit::WebSourceBufferImpl::setTimestampOffset):
327 (WebKit::WebSourceBufferImpl::removedFromMediaSource):
328 * src/WebMediaSourceImpl.cpp:
330 2013-02-28 David Grogan <dgrogan@chromium.org>
332 IndexedDB: IO error when checking schema should destroy LevelDB directory
333 https://bugs.webkit.org/show_bug.cgi?id=110675
335 Reviewed by Adam Barth.
338 This was cargo-culted. The component build wouldn't run otherwise.
341 * tests/IDBCleanupOnIOErrorTest.cpp: Added.
343 2013-02-28 Stephen Chenney <schenney@chromium.org>
345 RenderTableCellDeathTest unit test fails on mac
346 https://bugs.webkit.org/show_bug.cgi?id=110992
348 Unreviewed revert of all changes. The problem seems to have resolved.
350 * tests/RenderTableCellTest.cpp: Remove Mac disable code.
352 2013-02-28 Takashi Toyoshima <toyoshim@chromium.org>
354 Unreviewed, quick test breakage fix for android
355 https://bugs.webkit.org/show_bug.cgi?id=110740
357 Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
359 * src/WebViewImpl.cpp:
360 (WebKit::WebViewImpl::textInputInfo): Reconstruct condition check order
362 2013-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
364 Unreviewed. Rolled Chromium DEPS to r184931. Requested by
365 "Takashi Toyoshima" <toyoshim@chromium.org> via sheriffbot.
369 2013-02-27 Seigo Nonaka <nona@chromium.org>
371 [Chromium] Should not return WebTextInputTypeNone for date input element.
372 https://bugs.webkit.org/show_bug.cgi?id=110740
374 Reviewed by Kent Tamura.
376 In the case of Windows 8, text input state including on-screen keyboard is controlled by the
377 value of WebTextInputType returned from WebViewImpl::textInputType().
378 In past, it returned WebTextInputTypeDate for date text input but now it returns
379 WebTextInputTypeNone.
380 WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
381 the date text input is focused. So there is no way to input on Windows 8 tablet without
382 physical keyboard except tapping small up/down arrow.
384 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
385 * src/WebViewImpl.cpp:
386 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
387 safe because textInputType returns editable type only for known editable element.
388 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
391 2013-02-27 James Simonsen <simonjam@chromium.org>
393 [chromium] Lower priority of preloaded images
394 https://bugs.webkit.org/show_bug.cgi?id=110527
396 Plumb the didChangePriority signal into DRT so it can be tested.
398 Reviewed by Nate Chapin.
400 * public/WebFrameClient.h:
402 (WebKit::WebFrameClient::didChangeResourcePriority):
404 * src/FrameLoaderClientImpl.cpp:
405 (WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
407 * src/FrameLoaderClientImpl.h:
408 (FrameLoaderClientImpl):
410 2013-02-27 Min Qin <qinmin@chromium.org>
412 Unlock partially decoded images after passing them to the ImageDecodingStore
413 https://bugs.webkit.org/show_bug.cgi?id=110778
415 Reviewed by Stephen White.
417 Test for testing that image frames are unlocked after passing to ImageDecodingStore.
419 * tests/ImageFrameGeneratorTest.cpp:
420 (WebCore::ImageFrameGeneratorTest::SetUp):
421 (WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
422 (ImageFrameGeneratorTest):
423 (WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
425 * tests/MockImageDecoder.h:
426 (WebCore::MockImageDecoderClient::frameBuffersLocked):
427 (WebCore::MockImageDecoderClient::frameBuffersUnlocked):
428 (WebCore::MockImageDecoder::unlockFrameBuffers):
429 (WebCore::MockImageDecoder::lockFrameBuffers):
432 2013-02-27 John Bauman <jbauman@chromium.org>
434 Plugin in iframe may not display
435 https://bugs.webkit.org/show_bug.cgi?id=109879
437 Reviewed by Simon Fraser.
439 Use clipRectChanged to update the geometry.
441 * src/WebPluginContainerImpl.cpp:
442 (WebKit::WebPluginContainerImpl::clipRectChanged):
443 * src/WebPluginContainerImpl.h:
445 2013-02-27 Stephen Chenney <schenney@chromium.org>
447 RenderTableCellDeathTest unit test fails on mac
448 https://bugs.webkit.org/show_bug.cgi?id=110992
450 Unreviewed second attempt. Trying to get the right define for the OS.
452 * tests/RenderTableCellTest.cpp:
454 2013-02-27 Stephen Chenney <schenney@chromium.org>
456 RenderTableCellDeathTest unit test fails on mac
457 https://bugs.webkit.org/show_bug.cgi?id=110992
459 Unreviewed disabling of test that is hanging or crashing on Mac.
461 * tests/RenderTableCellTest.cpp:
463 2013-02-27 James Robinson <jamesr@chromium.org>
465 [chromium] Remove suppression invalidation logic from WebViewImpl
466 https://bugs.webkit.org/show_bug.cgi?id=110999
468 Reviewed by Adrienne Walker.
470 This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
473 * src/WebViewImpl.cpp:
474 (WebKit::WebViewImpl::WebViewImpl):
475 (WebKit::WebViewImpl::suppressInvalidations):
476 (WebKit::WebViewImpl::scheduleComposite):
479 2013-02-27 Glenn Adams <glenn@skynav.com>
481 Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
482 https://bugs.webkit.org/show_bug.cgi?id=110944
484 Reviewed by Dean Jackson.
488 2013-02-26 James Robinson <jamesr@chromium.org>
490 [chromium] Remove WebViewImpl::animate shimmy out through compositor
491 https://bugs.webkit.org/show_bug.cgi?id=110935
493 Reviewed by Adrienne Walker.
495 WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
496 the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
497 the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
498 important part of this indirection is that whenever the compositor is active, all animation calls must
499 route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
500 can set the appropriate rate limiting state. Animations may originate from
501 content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
502 cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
503 idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
504 redirect to the compositor when appropriate.
506 Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
507 calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
508 follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
511 * src/WebViewImpl.cpp:
512 (WebKit::WebViewImpl::animate):
513 (WebKit::WebViewImpl::updateAnimations):
515 2013-02-27 Sheriff Bot <webkit.review.bot@gmail.com>
517 Unreviewed, rolling out r144179.
518 http://trac.webkit.org/changeset/144179
519 https://bugs.webkit.org/show_bug.cgi?id=110980
521 Breaks compilation (Requested by vsevik on #webkit).
523 * public/WebTextInputType.h:
524 * src/WebViewImpl.cpp:
525 (WebKit::WebViewImpl::textInputInfo):
526 (WebKit::WebViewImpl::textInputType):
528 2013-02-27 Stephen Chenney <schenney@chromium.org>
530 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
531 https://bugs.webkit.org/show_bug.cgi?id=110922
533 Unreviewed build fix.
535 * tests/GIFImageDecoderTest.cpp:
537 (WebKit::TEST): Disable the entire test on Android.
539 2013-02-27 Seigo Nonaka <nona@chromium.org>
541 [Chromium] Should not return WebTextInputTypeNone for date input element.
542 https://bugs.webkit.org/show_bug.cgi?id=110740
544 Reviewed by Kent Tamura.
546 In the case of Windows 8, text input state including on-screen keyboard is controlled by the
547 value of WebTextInputType returned from WebViewImpl::textInputType().
548 In past, it returned WebTextInputTypeDate for date text input but now it returns
549 WebTextInputTypeNone.
550 WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
551 the date text input is focused. So there is no way to input on Windows 8 tablet without
552 physical keyboard except tapping small up/down arrow.
554 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
555 * src/WebViewImpl.cpp:
556 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
557 safe because textInputType returns editable type only for known editable element.
558 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
561 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
563 Unreviewed, rolling out r144129.
564 http://trac.webkit.org/changeset/144129
565 https://bugs.webkit.org/show_bug.cgi?id=110947
567 Breaks compilation on chromium mac and win (Requested by
570 * src/WebViewImpl.cpp:
571 (WebKit::WebViewImpl::willBeginFrame):
573 (WebKit::WebViewImpl::didBeginFrame):
575 * tests/WebLayerTreeViewTestCommon.h:
577 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
579 Unreviewed. Rolled Chromium DEPS to r184829. Requested by
580 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
584 2013-02-26 James Robinson <jamesr@chromium.org>
586 [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
587 https://bugs.webkit.org/show_bug.cgi?id=110928
589 Reviewed by Adrienne Walker.
591 * src/WebViewImpl.cpp:
593 * tests/WebLayerTreeViewTestCommon.h:
595 2013-02-26 Alpha Lam <hclam@chromium.org>
597 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
598 https://bugs.webkit.org/show_bug.cgi?id=110922
600 Unreviewed. Build fix.
602 * tests/GIFImageDecoderTest.cpp:
605 2013-02-26 James Robinson <jamesr@chromium.org>
607 [chromium] Remove unused WebLayerTreeViewClient calls
608 https://bugs.webkit.org/show_bug.cgi?id=110923
610 Reviewed by Adrienne Walker.
612 These notifications existed for instrumentation, but now the instrumentation routes
613 through WebDevToolsAgent.
615 * src/WebViewImpl.cpp:
617 * tests/WebLayerTreeViewTestCommon.h:
619 2013-02-26 Dirk Pranke <dpranke@chromium.org>
621 Roll Chromium DEPS from r183905 -> r184646.
627 2013-02-26 James Robinson <jamesr@chromium.org>
629 [chromium] Remove unused WebWidget::instrument calls
630 https://bugs.webkit.org/show_bug.cgi?id=110906
632 Reviewed by Jochen Eisinger.
634 These calls are now routed through WebDevToolsAgent.
636 * public/WebWidget.h:
637 * src/WebViewImpl.cpp:
638 (WebKit::WebViewImpl::willBeginFrame):
641 2013-02-20 Alpha Lam <hclam@chromium.org>
643 GIFImageReader to read from source data directly
644 https://bugs.webkit.org/show_bug.cgi?id=109662
646 Reviewed by Stephen White.
648 Added the following unit tests to test new logic in GIFImageDecoder:
650 GIFImageDecoderTest.decodeTwoFrames
651 Test that it can decode a multi-frame GIF image correctly.
653 GIFImageDecoderTest.parseAndDecode
654 First perform a parse operation and then a decode operation. Expect
655 that parse and decode operates correctly.
657 GIFImageDecoderTest.parseByteByByte
658 Test that multi-frame GIF image can be parsed correctly byte by byte.
660 GIFImageDecoderTest.parseAndDecodeByteByByte
661 Run a loop to feed decoder byte by byte, perform a parse and then
662 decode operation and make sure frames are decoded correctly.
664 GIFImageDecoderTest.brokenSecondFrame
665 Decode a GIF image with second frame broken. Expect that the first
666 frame can be decoded correctly.
669 * tests/GIFImageDecoderTest.cpp: Added.
673 * tests/data/broken.gif: Added.
675 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
677 Unreviewed, rolling out r144065.
678 http://trac.webkit.org/changeset/144065
679 https://bugs.webkit.org/show_bug.cgi?id=110896
681 Causing failures and crashes on Chromium Win7 and Win XP
682 (Requested by schenney on #webkit).
686 2013-02-26 Levi Weintraub <leviw@chromium.org>
688 Add support for 8 bit TextRuns for Chromium/HarfBuzz
689 https://bugs.webkit.org/show_bug.cgi?id=99393
691 Reviewed by Eric Seidel.
693 Enabling 8 bit text runs for Chromium.
697 2013-02-26 Dmitry Zvorygin <zvorygin@chromium.org>
699 Merged Tip and Debug log levels for web console.
700 https://bugs.webkit.org/show_bug.cgi?id=109919
702 Reviewed by Pavel Feldman.
704 In every component either TIP or DEBUG level was used for reporting,
705 but not both. This patch is prerequisite for Web Inspector console log filtering.
707 * public/WebConsoleMessage.h:
708 * src/AssertMatchingEnums.cpp:
709 * src/WebFrameImpl.cpp:
710 (WebKit::WebFrameImpl::addMessageToConsole):
712 2013-02-26 Andrey Kosyakov <caseq@chromium.org>
714 Plumbing trace events to Timeline
716 Web Inspector: plumb trace events to Timeline agent
717 https://bugs.webkit.org/show_bug.cgi?id=105796
719 Reviewed by Pavel Feldman.
721 * public/WebDevToolsAgentClient.h:
722 (WebDevToolsAgentClient):
723 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
724 * src/InspectorClientImpl.cpp:
725 (WebKit::InspectorClientImpl::setTraceEventCallback):
727 * src/InspectorClientImpl.h:
728 (InspectorClientImpl):
729 * src/WebDevToolsAgentImpl.cpp:
730 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
732 * src/WebDevToolsAgentImpl.h:
733 (WebDevToolsAgentImpl):
735 2013-02-01 Andrey Kosyakov <caseq@chromium.org>
737 Web Inspector: plumb trace events to Timeline agent
738 https://bugs.webkit.org/show_bug.cgi?id=105796
740 Reviewed by Pavel Feldman.
742 Plumb trace events to Inspector.
744 * public/WebDevToolsAgentClient.h:
745 (WebDevToolsAgentClient):
746 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
747 * src/InspectorClientImpl.cpp:
748 (WebKit::InspectorClientImpl::setTraceEventCallback):
750 * src/InspectorClientImpl.h:
751 (InspectorClientImpl):
752 * src/WebDevToolsAgentImpl.cpp:
753 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
755 * src/WebDevToolsAgentImpl.h:
756 (WebDevToolsAgentImpl):
758 2013-02-26 Andrey Kosyakov <caseq@chromium.org>
760 Unreviewed, rolling out r144041, r144044, and r144048.
761 http://trac.webkit.org/changeset/144041
762 http://trac.webkit.org/changeset/144044
763 http://trac.webkit.org/changeset/144048
764 https://bugs.webkit.org/show_bug.cgi?id=105796
768 * public/WebDevToolsAgentClient.h:
769 * src/InspectorClientImpl.cpp:
770 * src/InspectorClientImpl.h:
771 (InspectorClientImpl):
772 * src/WebDevToolsAgentImpl.cpp:
773 * src/WebDevToolsAgentImpl.h:
774 (WebDevToolsAgentImpl):
776 2013-02-01 Andrey Kosyakov <caseq@chromium.org>
778 Web Inspector: plumb trace events to Timeline agent
779 https://bugs.webkit.org/show_bug.cgi?id=105796
781 Reviewed by Pavel Feldman.
783 Plumb trace events to Inspector.
785 * public/WebDevToolsAgentClient.h:
786 (WebDevToolsAgentClient):
787 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
788 * src/InspectorClientImpl.cpp:
789 (WebKit::InspectorClientImpl::setTraceEventCallback):
791 * src/InspectorClientImpl.h:
792 (InspectorClientImpl):
793 * src/WebDevToolsAgentImpl.cpp:
794 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
796 * src/WebDevToolsAgentImpl.h:
797 (WebDevToolsAgentImpl):
799 2013-02-26 Tien-Ren Chen <trchen@chromium.org>
801 Implement coordinated scrollbar for subframes and overflow:scroll
802 https://bugs.webkit.org/show_bug.cgi?id=109560
804 Reviewed by James Robinson.
806 Added ScrollingCoordinatorChromiumTest.iframeScrolling to verify
807 impl-side scrolling and impl-side scrollbars for frames.
809 Update ScrollingCoordinatorChromiumTest.overflowScrolling to verify
810 impl-side scrollbars.
812 * tests/ScrollingCoordinatorChromiumTest.cpp:
813 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
816 * tests/data/iframe-scrolling-inner.html: Added.
817 * tests/data/iframe-scrolling.html: Added.
819 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
821 Unreviewed, rolling out r144016.
822 http://trac.webkit.org/changeset/144016
823 https://bugs.webkit.org/show_bug.cgi?id=110856
825 Breaks compilation on chromium mac (Requested by vsevik on
829 * tests/KeyCodeConversionTest.cpp: Removed.
831 2013-02-26 James Robinson <jamesr@chromium.org>
833 [chromium] Fix continuous painting mode
834 https://bugs.webkit.org/show_bug.cgi?id=110788
836 Reviewed by Adrienne Walker.
838 Recent instrumentation shuffling caused WebViewImpl::didBeginFrame to no longer be called, which
839 broke continuous painting. Since continuous painting mode is meant to simply invalidate layers
840 on each frame, it's a better fit for the animation system. This moves the invalidation calls
841 into WebViewImpl::updateAnimations along with other animation type things.
843 Tested manually by enabling continuous painting mode in the inspector. There aren't any automated
844 tests in WebKit for this feature.
846 * src/WebViewImpl.cpp:
847 (WebKit::WebViewImpl::setContinuousPaintingEnabled):
848 (WebKit::WebViewImpl::didBeginFrame):
849 (WebKit::WebViewImpl::updateAnimations):
850 * src/painting/ContinuousPainter.cpp:
851 (WebKit::ContinuousPainter::setNeedsDisplayRecursive):
853 2013-02-26 James Weatherall <wez@chromium.org>
855 keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
856 https://bugs.webkit.org/show_bug.cgi?id=85642
858 Add tests to verify that the fixed keys generate the same keyCode values
859 as their equivalents.
861 Reviewed by Ojan Vafai.
864 * tests/KeyCodeConversionTest.cpp: Added.
868 2013-02-25 Rouslan Solomakhin <rouslan@chromium.org>
870 Add expandedToParagraph() method to WebRange
871 https://bugs.webkit.org/show_bug.cgi?id=110618
873 Reviewed by Adam Barth.
875 Add a method expandedToParagraph() to WebRange to return a copy of the
876 range expanded to paragraph boundaries. This method is to be used to
877 query the spelling context around the misspelled word under cursor.
880 (WebRange): Added expandedToParagraph() method declaration.
882 (WebKit::WebRange::expandedToParagraph): Added method to copy range, expand the copied range to paragraph boundaries, and return the resulting range.
883 (WebKit): Added expandedToParagraph() method definition.
885 2013-02-25 James Robinson <jamesr@chromium.org>
887 [chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
888 https://bugs.webkit.org/show_bug.cgi?id=110834
890 Reviewed by Adrienne Walker.
892 * src/WebViewImpl.cpp:
893 (WebKit::WebViewImpl::suppressInvalidations):
894 (WebKit::WebViewImpl::setRootGraphicsLayer):
896 2013-02-25 Ken Kania <kkania@chromium.org>
898 Remove browser patching mechanism for handling javascript dialogs in chromium port
899 https://bugs.webkit.org/show_bug.cgi?id=110531
901 Reviewed by Pavel Feldman.
903 * public/WebDevToolsAgent.h:
904 * src/WebDevToolsAgentImpl.cpp:
905 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
906 (WebKit::browserHintToString):
907 (WebKit::browserHintFromString):
908 (WebKit::WebDevToolsAgent::patchWithBrowserData):
910 2013-02-25 James Robinson <jamesr@chromium.org>
912 [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
913 https://bugs.webkit.org/show_bug.cgi?id=110640
915 Reviewed by Adrienne Walker.
917 This plumbs the WebViewImpl::m_suppressInvalidations logic out to the WebWidgetClient so
918 it can be implemented by the embedder. The existing logic is left in place for now,
919 once the embedder side has landed WebViewImpl will be purely a pass-through.
921 * public/WebWidgetClient.h:
923 (WebKit::WebWidgetClient::suppressCompositorScheduling):
924 * src/WebViewImpl.cpp:
925 (WebKit::WebViewImpl::suppressInvalidations):
926 (WebKit::WebViewImpl::setRootGraphicsLayer):
928 2013-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
930 Unreviewed, rolling out r143936.
931 http://trac.webkit.org/changeset/143936
932 https://bugs.webkit.org/show_bug.cgi?id=110789
934 Causes webkit_unit_tests failures on android dbg (Requested by
939 * tests/GIFImageDecoderTest.cpp: Removed.
940 * tests/data/broken.gif: Removed.
942 2013-02-25 Alpha Lam <hclam@chromium.org>
944 GIFImageReader to read from source data directly
945 https://bugs.webkit.org/show_bug.cgi?id=109662
947 Reviewed by Stephen White.
949 Added the following unit tests to test new logic in GIFImageDecoder:
951 GIFImageDecoderTest.decodeTwoFrames
952 Test that it can decode a multi-frame GIF image correctly.
954 GIFImageDecoderTest.parseAndDecode
955 First perform a parse operation and then a decode operation. Expect
956 that parse and decode operates correctly.
958 GIFImageDecoderTest.parseByteByByte
959 Test that multi-frame GIF image can be parsed correctly byte by byte.
961 GIFImageDecoderTest.parseAndDecodeByteByByte
962 Run a loop to feed decoder byte by byte, perform a parse and then
963 decode operation and make sure frames are decoded correctly.
965 GIFImageDecoderTest.brokenSecondFrame
966 Decode a GIF image with second frame broken. Expect that the first
967 frame can be decoded correctly.
971 * tests/GIFImageDecoderTest.cpp: Added.
975 * tests/data/broken.gif: Added.
977 2013-02-25 Andrey Kosyakov <caseq@chromium.org>
979 Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.
982 (.TestSuite.prototype.testPageOverlayUpdate.step2):
984 2013-02-25 Anton Vayvod <avayvod@chromium.org>
986 [Chromium] Disable registerProtocolHandler on Android
987 https://bugs.webkit.org/show_bug.cgi?id=110481
989 Reviewed by Julien Chaffraix.
991 Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
992 actually wired up internally. Disable the feature to avoid breaking feature detection until
993 we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
994 See the discussion of the future implementation at http://crbug.com/156386
996 * features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
998 * src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
1000 2013-02-24 Hajime Morrita <morrita@google.com>
1002 [Custom Elements] Implement bare-bone document.register()
1003 https://bugs.webkit.org/show_bug.cgi?id=100229
1005 Reviewed by Adam Barth.
1007 Added enableCustomDOMElements flag.
1010 * public/WebRuntimeFeatures.h:
1011 (WebRuntimeFeatures):
1012 * src/WebRuntimeFeatures.cpp:
1013 (WebKit::WebRuntimeFeatures::enableCustomDOMElements):
1015 (WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):
1017 2013-02-23 Mark Pilgrim <pilgrim@chromium.org>
1019 [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
1020 https://bugs.webkit.org/show_bug.cgi?id=110605
1022 Reviewed by Adam Barth.
1024 Part of a larger refactoring series; see tracking bug 82948.
1029 (WebKit::initialize):
1030 (WebKit::initializeWithoutV8):
1031 (WebKit::webKitPlatformSupport):
1033 2013-02-22 David Dorwin <ddorwin@chromium.org>
1035 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
1036 https://bugs.webkit.org/show_bug.cgi?id=110668
1038 Reviewed by Adam Barth.
1040 This fixes http://crbug.com/172764
1042 * src/WebHelperPluginImpl.cpp:
1043 (WebKit::WebHelperPluginImpl::destoryPage):
1045 2013-02-22 Aaron Colwell <acolwell@chromium.org>
1047 Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
1048 https://bugs.webkit.org/show_bug.cgi?id=109857
1050 Reviewed by Adam Barth.
1052 WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
1053 WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
1054 media player interfaces.
1057 * public/WebMediaPlayer.h:
1059 (WebKit::WebMediaPlayer::load):
1060 * public/WebMediaPlayerClient.h:
1062 * public/WebMediaSource.h: Added.
1065 (WebKit::WebMediaSource::~WebMediaSource):
1066 * public/WebMediaSourceClient.h: Added.
1068 (WebMediaSourceClient):
1069 (WebKit::WebMediaSourceClient::~WebMediaSourceClient):
1070 * src/AssertMatchingEnums.cpp:
1071 * src/WebMediaPlayerClientImpl.cpp:
1073 (WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium
1075 (WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
1076 (WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
1077 (WebKit::WebMediaSourceClientImpl::addId):
1078 (WebKit::WebMediaSourceClientImpl::removeId):
1079 (WebKit::WebMediaSourceClientImpl::buffered):
1080 (WebKit::WebMediaSourceClientImpl::append):
1081 (WebKit::WebMediaSourceClientImpl::abort):
1082 (WebKit::WebMediaSourceClientImpl::duration):
1083 (WebKit::WebMediaSourceClientImpl::setDuration):
1084 (WebKit::WebMediaSourceClientImpl::endOfStream):
1085 (WebKit::WebMediaSourceClientImpl::setTimestampOffset):
1086 (WebKit::WebMediaPlayerClientImpl::sourceOpened):
1087 (WebKit::WebMediaPlayerClientImpl::sourceURL):
1088 (WebKit::WebMediaPlayerClientImpl::load):
1089 (WebKit::WebMediaPlayerClientImpl::loadRequested):
1090 (WebKit::WebMediaPlayerClientImpl::loadInternal):
1091 * src/WebMediaPlayerClientImpl.h:
1092 (WebMediaPlayerClientImpl):
1093 * src/WebMediaSourceImpl.cpp: Added.
1095 (MediaSourcePrivateImpl):
1096 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
1097 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
1098 (WebKit::MediaSourcePrivateImpl::addId):
1099 (WebKit::MediaSourcePrivateImpl::removeId):
1100 (WebKit::MediaSourcePrivateImpl::buffered):
1101 (WebKit::MediaSourcePrivateImpl::append):
1102 (WebKit::MediaSourcePrivateImpl::abort):
1103 (WebKit::MediaSourcePrivateImpl::duration):
1104 (WebKit::MediaSourcePrivateImpl::setDuration):
1105 (WebKit::MediaSourcePrivateImpl::endOfStream):
1106 (WebKit::MediaSourcePrivateImpl::setTimestampOffset):
1107 (WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
1108 (WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
1109 (WebKit::WebMediaSourceImpl::open):
1110 * src/WebMediaSourceImpl.h: Added.
1112 (WebMediaSourceImpl):
1114 2013-02-22 Alec Flett <alecflett@chromium.org>
1116 IndexedDB: Remove old SerializedScriptValue-based get() callbacks
1117 https://bugs.webkit.org/show_bug.cgi?id=110626
1119 Reviewed by James Robinson.
1121 Removal now that refactoring is complete.
1123 * public/WebIDBCallbacks.h:
1126 2013-02-22 Ali Juma <ajuma@chromium.org>
1128 [chromium] Register newly-created layers for animation
1129 https://bugs.webkit.org/show_bug.cgi?id=106594
1131 Reviewed by James Robinson.
1134 * src/ChromeClientImpl.cpp:
1135 (WebKit::ChromeClientImpl::ChromeClientImpl):
1136 (WebKit::ChromeClientImpl::graphicsLayerFactory):
1137 * src/ChromeClientImpl.h:
1139 * src/GraphicsLayerFactoryChromium.cpp: Added.
1141 (WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium):
1142 (WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
1143 (WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer):
1144 * src/GraphicsLayerFactoryChromium.h: Added.
1146 (GraphicsLayerFactoryChromium):
1147 * src/WebViewImpl.cpp:
1148 (WebKit::WebViewImpl::WebViewImpl):
1149 (WebKit::WebViewImpl::graphicsLayerFactory):
1151 (WebKit::WebViewImpl::registerForAnimations):
1152 * src/WebViewImpl.h:
1155 2013-02-22 Fady Samuel <fsamuel@chromium.org>
1157 [Chromium] Expose shadowRoot to the WebKit API
1158 https://bugs.webkit.org/show_bug.cgi?id=110522
1160 Reviewed by Dimitri Glazkov.
1162 * public/WebElement.h:
1164 * src/WebElement.cpp:
1165 (WebKit::WebElement::shadowRoot):
1168 2013-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
1170 Unreviewed, rolling out r143734.
1171 http://trac.webkit.org/changeset/143734
1172 https://bugs.webkit.org/show_bug.cgi?id=110615
1174 Causes linux build failures. (Requested by vollick on
1180 (WebKit::initialize):
1181 (WebKit::initializeWithoutV8):
1182 (WebKit::webKitPlatformSupport):
1184 2013-02-22 Mikhail Naganov <mnaganov@chromium.org>
1186 [Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method
1187 https://bugs.webkit.org/show_bug.cgi?id=109946
1189 Adding a WebView method for permanently setting initial page scale.
1190 This override has higher priority than any calculated page scale
1191 and viewport meta tag value.
1193 Also, this patch eliminates a dubious "fixed layout enabled, viewport disabled" mode
1194 previously used by Android WebView.
1196 Reviewed by Adam Barth.
1200 * src/ChromeClientImpl.cpp:
1201 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1202 * src/WebViewImpl.cpp:
1203 (WebKit::WebViewImpl::WebViewImpl):
1204 (WebKit::WebViewImpl::setInitialPageScaleOverride):
1206 (WebKit::WebViewImpl::computePageScaleFactorLimits):
1207 * src/WebViewImpl.h:
1208 * tests/WebFrameTest.cpp:
1210 2013-02-22 Mark Pilgrim <pilgrim@chromium.org>
1212 [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
1213 https://bugs.webkit.org/show_bug.cgi?id=110605
1215 Reviewed by Adam Barth.
1217 Part of a larger refactoring series; see tracking bug 82948.
1222 (WebKit::initialize):
1223 (WebKit::initializeWithoutV8):
1224 (WebKit::webKitPlatformSupport):
1226 2013-02-22 Andrey Kosyakov <caseq@chromium.org>
1228 Web Inspector: [Chromium] add a browser test for frames on timeline
1229 https://bugs.webkit.org/show_bug.cgi?id=110592
1231 - factor out timeline recording logic from testPageOverlayUpdate for reuse;
1232 - record timeline while running a simple DOM-based animation;
1233 - assure we have frames and Style Recalc/Layout/Paint events in between.
1235 Reviewed by Yury Semikhatsky.
1238 (.TestSuite.prototype.assertHasKey):
1239 (.TestSuite.prototype.testTimelineFrames.step1):
1240 (.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
1241 (.TestSuite.prototype.testTimelineFrames):
1242 (.TestSuite.prototype.testPageOverlayUpdate.step4):
1243 (.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
1244 (.TestSuite.prototype.recordTimeline.addRecord):
1245 (.TestSuite.prototype.recordTimeline.innerAddRecord):
1246 (.TestSuite.prototype.recordTimeline.done):
1247 (.TestSuite.prototype.recordTimeline):
1248 (.TestSuite.prototype.stopTimeline):
1250 2013-02-21 Alec Flett <alecflett@chromium.org>
1252 IndexedDB: Implement SharedBuffer version of put() / onSuccess()
1253 https://bugs.webkit.org/show_bug.cgi?id=110398
1255 Reviewed by Tony Chang.
1257 Proxy new SharedBuffer calls to WebIDBCallbacks through
1258 to the new SharedBuffer-based IDBCallbacks.
1260 * public/WebIDBCursor.h:
1261 * src/IDBCallbacksProxy.cpp:
1262 (WebKit::IDBCallbacksProxy::onSuccess):
1263 (WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):
1264 * src/IDBCallbacksProxy.h:
1265 (IDBCallbacksProxy):
1266 * src/WebIDBCallbacksImpl.cpp:
1267 (WebKit::WebIDBCallbacksImpl::onSuccess):
1268 * src/WebIDBCallbacksImpl.h:
1269 (WebIDBCallbacksImpl):
1270 * tests/IDBAbortOnCorruptTest.cpp:
1271 (WebCore::MockIDBCallbacks::onSuccess):
1272 (WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
1273 * tests/IDBDatabaseBackendTest.cpp:
1274 * tests/IDBRequestTest.cpp:
1277 2013-02-21 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1279 Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
1280 https://bugs.webkit.org/show_bug.cgi?id=110208
1282 Reviewed by Hajime Morrita.
1284 * src/EditorClientImpl.cpp:
1285 (WebKit::EditorClientImpl::requestCheckingOfString):
1286 Extract the request data as it is the member of 'TextCheckingRequest'.
1288 2013-02-21 Mark Pilgrim <pilgrim@chromium.org>
1290 [Chromium] Remove chromium/public/platform directory
1291 https://bugs.webkit.org/show_bug.cgi?id=110471
1293 Reviewed by Adam Barth.
1295 Part of a larger refactoring series; see tracking bug 82948.
1298 * public/platform: Removed.
1299 * public/platform/WebKitPlatformSupport.h: Removed.
1300 * public/platform/android: Removed.
1301 * public/platform/default: Removed.
1302 * public/platform/linux: Removed.
1303 * public/platform/mac: Removed.
1304 * public/platform/win: Removed.
1307 2013-02-21 Dirk Pranke <dpranke@chromium.org>
1309 [chromium] support the lucid version of freetype on precise in DRT
1310 https://bugs.webkit.org/show_bug.cgi?id=107338
1312 Reviewed by Tony Chang.
1314 Add in a linux-only dependency on Freetype2 so that we can
1315 match the version shipped in Ubuntu Lucid.
1319 2013-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
1321 Unreviewed. Rolled Chromium DEPS to r183905. Requested by
1322 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1326 2013-02-21 Alec Flett <alecflett@chromium.org>
1328 IndexedDB: Remove copying WebIDBDatabase::put() stub
1329 https://bugs.webkit.org/show_bug.cgi?id=109967
1331 Reviewed by Darin Fisher.
1333 Now that the chromium call to this method has
1334 been removed, we can remove the stub.
1336 * public/WebIDBDatabase.h:
1338 2013-02-21 Dirk Pranke <dpranke@chromium.org>
1340 Unreviewed, roll chromium deps 183552 -> 183788
1344 2013-02-21 John Mellor <johnme@chromium.org>
1346 [chromium] Simplify computation of screenRect/windowRect.
1347 https://bugs.webkit.org/show_bug.cgi?id=110456
1349 Reviewed by Adam Barth.
1351 This patch removes applyDeviceScaleFactorInCompositor checks
1352 added by http://trac.webkit.org/changeset/139356 because
1353 Chrome for Android now sizes its screen and window in DIP
1354 units (like other platforms), so they are no longer necessary.
1356 * src/ChromeClientImpl.cpp:
1357 (WebKit::ChromeClientImpl::windowRect):
1359 2013-02-21 Vsevolod Vlasov <vsevik@chromium.org>
1361 Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
1362 https://bugs.webkit.org/show_bug.cgi?id=110335
1364 Reviewed by Alexander Pavlov.
1367 (.TestSuite.prototype._scriptsAreParsed):
1369 2013-02-21 Ken Kania <kkania@chromium.org>
1371 Web Inspector: Add command for selecting files for file input element
1372 https://bugs.webkit.org/show_bug.cgi?id=109308
1374 Reviewed by Pavel Feldman.
1376 * src/InspectorClientImpl.cpp:
1377 (WebKit::InspectorClientImpl::canSetFileInputFiles):
1379 * src/InspectorClientImpl.h:
1380 (InspectorClientImpl):
1382 2013-02-20 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
1384 Add gyp option to switch ENABLE(SQL_DATABASE)
1385 https://bugs.webkit.org/show_bug.cgi?id=109303
1386 http://code.google.com/p/chromium/issues/detail?id=22208
1388 Reviewed by Tony Chang.
1390 This will be useful to implement build with system sqlite.
1393 * src/ChromeClientImpl.cpp:
1395 * src/ChromeClientImpl.h:
1398 2013-02-20 Dirk Schulze <krit@webkit.org>
1400 Enable CANVAS_PATH flag
1401 https://bugs.webkit.org/show_bug.cgi?id=108508
1403 Reviewed by Simon Fraser.
1405 Enable CANVAS_PATH flag on trunk.
1409 2013-02-15 Dirk Schulze <krit@webkit.org>
1411 [Chromium] Add runtime flag for CanvasPath
1412 https://bugs.webkit.org/show_bug.cgi?id=109997
1414 Reviewed by Adam Barth.
1416 Add runtime flag for Chromium.
1418 * public/WebRuntimeFeatures.h:
1419 (WebRuntimeFeatures):
1420 * src/WebRuntimeFeatures.cpp:
1421 (WebKit::WebRuntimeFeatures::enableCanvasPath):
1423 (WebKit::WebRuntimeFeatures::isCanvasPathEnabled):
1425 2013-02-20 Mark Pilgrim <pilgrim@chromium.org>
1427 [Chromium] Move WebKitPlatformSupport declaration to Platform.h
1428 https://bugs.webkit.org/show_bug.cgi?id=110262
1430 Reviewed by Adam Barth.
1432 In preparation for removing WebKitPlatformSupport.h entirely (once
1433 downstream references to that file have been updated). Part of a
1434 larger refactoring series; see tracking bug 82948.
1436 * public/platform/WebKitPlatformSupport.h:
1438 2013-02-20 Mark Pilgrim <pilgrim@chromium.org>
1440 [Chromium] Remove idbFactory from WebKitPlatformSupport
1441 https://bugs.webkit.org/show_bug.cgi?id=106457
1443 Reviewed by Adam Barth.
1445 Now that https://codereview.chromium.org/12230054 has landed, the
1446 idbFactory method is no longer needed. (Embedders must now call
1447 the new setIDBFactory method upon initialization.) Part of a
1448 larger refactoring series; see tracking bug 82948.
1450 * public/platform/WebKitPlatformSupport.h:
1452 * src/IDBFactoryBackendProxy.cpp:
1453 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1455 2013-02-20 Mark Lam <mark.lam@apple.com>
1457 Rename DatabaseBackend to DatabaseBackendBase.
1458 https://bugs.webkit.org/show_bug.cgi?id=110303.
1460 Rubber stamped by Alexey Proskuryakov.
1462 * public/WebDatabase.h:
1464 * src/DatabaseObserver.cpp:
1465 (WebCore::DatabaseObserver::databaseOpened):
1466 (WebCore::DatabaseObserver::databaseModified):
1467 (WebCore::DatabaseObserver::databaseClosed):
1468 (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1469 (WebCore::DatabaseObserver::reportChangeVersionResult):
1470 (WebCore::DatabaseObserver::reportStartTransactionResult):
1471 (WebCore::DatabaseObserver::reportCommitTransactionResult):
1472 (WebCore::DatabaseObserver::reportExecuteStatementResult):
1473 (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1474 * src/WebDatabase.cpp:
1475 (WebKit::WebDatabase::WebDatabase):
1477 2013-02-20 Rouslan Solomakhin <rouslan@chromium.org>
1479 Fix use after free in ContextMenuClientImpl.cpp
1480 https://bugs.webkit.org/show_bug.cgi?id=109220
1482 Reviewed by Tony Chang.
1484 ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
1485 by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
1486 to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
1487 causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
1488 spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
1489 ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
1490 use after free. The fix is to save a copy of the DocumentMarker before changing selection.
1492 * src/ContextMenuClientImpl.cpp:
1493 (WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
1494 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.
1496 2013-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
1498 Unreviewed. Rolled Chromium DEPS to r183552. Requested by
1499 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1503 2013-02-19 Adrienne Walker <enne@chromium.org>
1505 Unreviewed, rolling out r143382 and r143401.
1506 http://trac.webkit.org/changeset/143382
1507 http://trac.webkit.org/changeset/143401
1508 https://bugs.webkit.org/show_bug.cgi?id=106457
1510 Breaks Chromium win/mac canary compilation
1512 * public/platform/WebKitPlatformSupport.h:
1514 (WebKitPlatformSupport):
1515 (WebKit::WebKitPlatformSupport::idbFactory):
1516 (WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
1517 * src/IDBFactoryBackendProxy.cpp:
1518 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1520 2013-02-19 Mark Pilgrim <pilgrim@chromium.org>
1522 [Chromium] Move WebKitPlatformSupport declaration to Platform.h
1523 https://bugs.webkit.org/show_bug.cgi?id=110262
1525 Reviewed by Adam Barth.
1527 In preparation for removing WebKitPlatformSupport.h entirely (once
1528 downstream references to that file have been updated). Part of a
1529 larger refactoring series; see tracking bug 82948.
1531 * public/platform/WebKitPlatformSupport.h:
1533 2013-02-19 Mark Pilgrim <pilgrim@chromium.org>
1535 [Chromium] Remove idbFactory from WebKitPlatformSupport
1536 https://bugs.webkit.org/show_bug.cgi?id=106457
1538 Reviewed by Kentaro Hara.
1540 Now that https://codereview.chromium.org/12230054 has landed, the
1541 idbFactory method is no longer needed. (Embedders must now call
1542 the new setIDBFactory method upon initialization.) Part of a
1543 larger refactoring series; see tracking bug 82948.
1545 * public/platform/WebKitPlatformSupport.h:
1547 * src/IDBFactoryBackendProxy.cpp:
1548 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1550 2013-02-19 Alexandre Elias <aelias@chromium.org>
1552 [chromium] Fix races in double-tap zoom minimum scale policy
1553 https://bugs.webkit.org/show_bug.cgi?id=110183
1555 Reviewed by Adam Barth.
1557 Double-tap zoom on Android is supposed to return to minimum scale
1558 if no pinch zoom occurred since the last double-tap. Because both
1559 pinch zoom and the result of double-tap zoom gets passed in from CC
1560 via applyScrollAndScale, this logic was brittle and prone to races
1561 depending on when the animation update was received. This patch
1562 keeps track of what the target double-tap scale is to make it more
1565 I also fixed double-tap zoom test mocking to exercise the entire
1566 page scale animation flow (our previous way of testing was hiding the
1567 raciness), and added a new test case in DivAutoZoomMultipleParamsTest.
1569 * src/WebViewImpl.cpp:
1570 (WebKit::WebViewImpl::WebViewImpl):
1571 (WebKit::WebViewImpl::startPageScaleAnimation):
1573 (WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
1574 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
1575 (WebKit::WebViewImpl::animateZoomAroundPoint):
1576 (WebKit::WebViewImpl::didCommitLoad):
1577 (WebKit::WebViewImpl::applyScrollAndScale):
1578 * src/WebViewImpl.h:
1580 (WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
1581 (WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
1582 (WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
1583 (WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
1584 * tests/WebFrameTest.cpp:
1586 2013-02-19 Joshua Bell <jsbell@chromium.org>
1588 IndexedDB: additional checks on LevelDB decoding
1589 https://bugs.webkit.org/show_bug.cgi?id=109711
1591 Reviewed by Tony Chang.
1593 * tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
1595 2013-02-19 Jochen Eisinger <jochen@chromium.org>
1597 [chromium] fix ScrollAnimatorNoneTest after r143295
1598 https://bugs.webkit.org/show_bug.cgi?id=110189
1600 Reviewed by Nico Weber.
1602 * tests/ScrollAnimatorNoneTest.cpp:
1603 (MockScrollableArea):
1605 2013-02-18 Simon Fraser <simon.fraser@apple.com>
1607 Clean up the boolean argument to visibleContentRect
1608 https://bugs.webkit.org/show_bug.cgi?id=110167
1610 Reviewed by Simon Fraser.
1612 Replace the boolean argument to visibleContentRect() with
1615 * src/ChromeClientImpl.cpp:
1616 (WebKit::ChromeClientImpl::popupOpened):
1618 2013-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
1620 Unreviewed. Rolled Chromium DEPS to r183105. Requested by
1621 thakis_ via sheriffbot.
1625 2013-02-18 Nico Weber <thakis@chromium.org>
1627 [chromium] Remove ahem_path from WebKit.gyp
1628 https://bugs.webkit.org/show_bug.cgi?id=110111
1630 Reviewed by Jochen Eisinger.
1632 It's only used in DumpRenderTree.gyp, and that file defines its own
1633 copy of this variable.
1637 2013-02-18 Laszlo Gombos <l.gombos@samsung.com>
1639 Move ENABLE macros for WebCore out from Platform.h
1640 https://bugs.webkit.org/show_bug.cgi?id=105735
1642 Move the chromium specific WebCore ENABLE macro definitions
1643 from Platform.h to features.gypi.
1645 Reviewed by Darin Adler and Benjamin Poulain.
1647 * features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1.
1649 2013-02-15 Alec Flett <alecflett@chromium.org>
1651 IndexedDB: Stub out SharedBuffer version of get()
1652 https://bugs.webkit.org/show_bug.cgi?id=108993
1654 Reviewed by Darin Fisher.
1656 All asynchronous get()-like calls go through WebIDBCallbacks,
1657 so this includes both get() and cursor callbacks.
1659 * public/WebIDBCallbacks.h:
1660 (WebKit::WebIDBCallbacks::onSuccess):
1661 (WebKit::WebIDBCallbacks::onSuccessWithPrefetch):
1663 2013-02-15 Alec Flett <alecflett@chromium.org>
1665 IndexedDB: fix chromium windows bustage
1666 https://bugs.webkit.org/show_bug.cgi?id=109970
1668 Unreviewed build fix for Chromium Windows.
1670 * tests/IDBDatabaseBackendTest.cpp:
1672 2013-02-15 Alec Flett <alecflett@chromium.org>
1674 IndexedDB: Implement SharedBuffer version of put()
1675 https://bugs.webkit.org/show_bug.cgi?id=109092
1677 Reviewed by Adam Barth.
1679 Implement SharedBuffer/WebData version of
1680 IDBDatabaseBackendInterface::put, and put
1681 temporary scaffolding in until chrome is ready.
1683 * src/IDBDatabaseBackendProxy.cpp:
1684 (WebKit::IDBDatabaseBackendProxy::put):
1685 * src/IDBDatabaseBackendProxy.h:
1686 (IDBDatabaseBackendProxy):
1687 * src/WebIDBDatabaseImpl.cpp:
1688 (WebKit::WebIDBDatabaseImpl::put):
1690 * src/WebIDBDatabaseImpl.h:
1691 (WebIDBDatabaseImpl):
1692 * tests/IDBDatabaseBackendTest.cpp:
1694 2013-02-15 Alexandre Elias <aelias@chromium.org>
1696 [chromium] WebInputEventBuilders should not reverse page scale
1697 https://bugs.webkit.org/show_bug.cgi?id=109901
1699 Reviewed by James Robinson.
1701 Though in theory logical that if WebInputEvent -> PlatformEvent
1702 conversions divide by page scale, then the reverse builders should
1703 multiply, in reality the only user of the reverse builders is
1704 plugins which expect the same coordinate space as WebCore.
1706 * src/WebInputEventConversion.cpp:
1707 (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
1708 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
1709 (WebKit::addTouchPoints):
1710 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
1711 * tests/WebInputEventConversionTest.cpp:
1714 2013-02-15 Anders Carlsson <andersca@apple.com>
1716 Remove const from a bunch of StorageArea member functions
1717 https://bugs.webkit.org/show_bug.cgi?id=109957
1719 Reviewed by Beth Dakin.
1721 Update for WebCore changes.
1723 * src/StorageAreaProxy.cpp:
1724 (WebCore::StorageAreaProxy::length):
1725 (WebCore::StorageAreaProxy::key):
1726 (WebCore::StorageAreaProxy::getItem):
1727 (WebCore::StorageAreaProxy::contains):
1728 (WebCore::StorageAreaProxy::canAccessStorage):
1729 (WebCore::StorageAreaProxy::memoryBytesUsedByCache):
1730 * src/StorageAreaProxy.h:
1733 2013-02-15 Keishi Hattori <keishi@webkit.org>
1735 PagePopupController.formatMonth should support short month format
1736 https://bugs.webkit.org/show_bug.cgi?id=109530
1738 Reviewed by Kent Tamura.
1740 * tests/LocaleMacTest.cpp:
1741 (LocaleMacTest::formatMonth):
1744 2013-02-15 Keishi Hattori <keishi@webkit.org>
1746 Add setValue and closePopup methods to PagePopupController
1747 https://bugs.webkit.org/show_bug.cgi?id=109897
1749 Reviewed by Kent Tamura.
1751 * src/ColorChooserPopupUIController.cpp:
1752 (WebKit::ColorChooserPopupUIController::setValue):
1754 * src/ColorChooserPopupUIController.h:
1755 (ColorChooserPopupUIController):
1756 * src/DateTimeChooserImpl.cpp:
1757 (WebKit::DateTimeChooserImpl::setValueAndClosePopup): Use setValue and closePopup.
1759 (WebKit::DateTimeChooserImpl::setValue):
1760 (WebKit::DateTimeChooserImpl::closePopup):
1761 * src/DateTimeChooserImpl.h:
1762 (DateTimeChooserImpl):
1764 2013-02-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
1766 Simplify hitTestResultAtPoint and nodesFromRect APIs
1767 https://bugs.webkit.org/show_bug.cgi?id=95720
1769 Reviewed by Julien Chaffraix.
1771 Update calls to new API.
1773 * src/ContextMenuClientImpl.cpp:
1774 (WebKit::selectMisspelledWord):
1775 * src/FrameLoaderClientImpl.cpp:
1776 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
1777 * src/WebFrameImpl.cpp:
1778 (WebKit::WebFrameImpl::characterIndexForPoint):
1779 * src/WebPluginContainerImpl.cpp:
1780 (WebKit::WebPluginContainerImpl::isRectTopmost):
1781 * src/WebViewImpl.cpp:
1782 (WebKit::WebViewImpl::handleMouseDown):
1783 (WebKit::WebViewImpl::computeBlockBounds):
1784 (WebKit::WebViewImpl::bestTouchLinkNode):
1785 (WebKit::WebViewImpl::hitTestResultForWindowPos):
1787 2013-02-14 Vsevolod Vlasov <vsevik@chromium.org>
1789 Unreviewed chromium test fix: incorrect field was used for UISourceCode url.
1792 (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
1793 (.TestSuite.prototype.uiSourceCodesToString_):
1795 2013-02-14 David Trainor <dtrainor@chromium.org>
1797 [chromium] No triggering autofill on unfocus
1798 https://bugs.webkit.org/show_bug.cgi?id=109735
1800 Reviewed by James Robinson.
1802 Need to notify the autofill client to not process text changes when we're setting
1803 focus to false and are trying to commit a composition.
1805 * public/WebAutofillClient.h:
1806 (WebAutofillClient):
1807 (WebKit::WebAutofillClient::setIgnoreTextChanges):
1808 (WebKit::WebAutofillClient::~WebAutofillClient):
1809 * src/WebViewImpl.cpp:
1810 (WebKit::WebViewImpl::setFocus):
1811 * tests/WebViewTest.cpp:
1813 2013-02-14 Alexandre Elias <aelias@chromium.org>
1815 [chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
1816 https://bugs.webkit.org/show_bug.cgi?id=109671
1818 Reviewed by James Robinson.
1820 My patch 142571 broke a bunch of things in handleGestureEvent that
1821 assumed the event came in scaled, most notably tap highlight and
1822 double-tap zoom. Switch those to PlatformGestureEvent.
1824 142808 was an earlier version of this patch that was reverted
1825 due to fling events asserting they can't be converted to
1826 PlatformGestureEvent. This version moves fling earlier in the
1827 function to avoid that.
1829 * src/WebViewImpl.cpp:
1830 (WebKit::WebViewImpl::handleGestureEvent):
1831 (WebKit::WebViewImpl::bestTapNode):
1832 (WebKit::WebViewImpl::enableTapHighlight):
1833 * src/WebViewImpl.h:
1835 * tests/LinkHighlightTest.cpp:
1838 2013-02-14 Dirk Pranke <dpranke@chromium.org>
1840 Unreviewed, rolling out r142901.
1841 http://trac.webkit.org/changeset/142901
1843 r182258 introduces a dependency on chrome.gyp that breaks the win
1844 build. Rolling back to r182150 until I can work up a workaround.
1848 2013-02-14 Dirk Pranke <dpranke@chromium.org>
1850 Unreviewed, chromium roll 182150 -> 182448
1854 2013-02-14 Mark Pilgrim <pilgrim@chromium.org>
1856 [Chromium] Move PlatformMessagePortChannel to WebCore
1857 https://bugs.webkit.org/show_bug.cgi?id=109845
1859 Reviewed by Adam Barth.
1861 Part of a larger refactoring series; see tracking bug 106829.
1864 * src/PlatformMessagePortChannel.cpp: Removed.
1865 * src/PlatformMessagePortChannel.h: Removed.
1866 * src/SharedWorkerRepository.cpp:
1867 * src/WebDOMMessageEvent.cpp:
1868 * src/WebFrameImpl.cpp:
1869 * src/WebSharedWorkerImpl.cpp:
1870 * src/WebWorkerClientImpl.cpp:
1872 2013-02-14 Min Qin <qinmin@chromium.org>
1874 Passing alpha to DeferredImageDecoder once decoding completes
1875 https://bugs.webkit.org/show_bug.cgi?id=108892
1877 Reviewed by Stephen White.
1879 Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.
1881 * tests/ImageFrameGeneratorTest.cpp:
1882 (WebCore::MockImageDecoderFactory::create):
1884 * tests/MockImageDecoder.h:
1885 (WebCore::MockImageDecoder::MockImageDecoder):
1886 (WebCore::MockImageDecoder::setFrameHasAlpha):
1888 (WebCore::MockImageDecoder::frameHasAlphaAtIndex):
1890 2013-02-08 Andrey Kosyakov <caseq@chromium.org>
1892 Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
1893 https://bugs.webkit.org/show_bug.cgi?id=109192
1895 Reviewed by Pavel Feldman.
1897 - expose frame and compositing insturmentation methods on WebDevToolsAgent;
1898 - temporarily route them from WebViewImpl to WebDevToolsAgent;
1900 * public/WebDevToolsAgent.h:
1902 * src/WebDevToolsAgentImpl.cpp:
1903 (WebKit::WebDevToolsAgentImpl::didBeginFrame):
1905 (WebKit::WebDevToolsAgentImpl::didCancelFrame):
1906 (WebKit::WebDevToolsAgentImpl::willComposite):
1907 (WebKit::WebDevToolsAgentImpl::didComposite):
1908 * src/WebDevToolsAgentImpl.h:
1909 (WebDevToolsAgentImpl):
1910 * src/WebViewImpl.cpp:
1911 (WebKit::WebViewImpl::instrumentBeginFrame):
1912 (WebKit::WebViewImpl::instrumentCancelFrame):
1913 (WebKit::WebViewImpl::didBeginFrame):
1914 (WebKit::WebViewImpl::willCommit):
1916 2013-02-14 Mikhail Naganov <mnaganov@chromium.org>
1918 [Chromium] Add a setting to control scaling content to fit viewport
1919 https://bugs.webkit.org/show_bug.cgi?id=109584
1921 Adds a setting called 'initializeAtMinimumPageScale'. By default,
1922 it is set to 'true' which corresponds to Chrome on Android behavior--
1923 adjust the page scale to make the content fit into the viewport
1924 by width. When set to false, the setting instructs ChromeClientImpl to
1925 set page scale to 1.0, unless the scale value is set by the page
1926 in the viewport meta-tag.
1928 Reviewed by Adam Barth.
1930 * public/WebSettings.h:
1931 * src/ChromeClientImpl.cpp:
1932 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1933 * src/WebSettingsImpl.cpp:
1934 (WebKit::WebSettingsImpl::WebSettingsImpl):
1935 (WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
1937 * src/WebSettingsImpl.h:
1939 (WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
1940 * tests/WebFrameTest.cpp:
1941 * tests/data/viewport-2x-initial-scale.html: Added.
1942 * tests/data/viewport-auto-initial-scale.html: Added.
1944 2013-02-14 Sheriff Bot <webkit.review.bot@gmail.com>
1946 Unreviewed, rolling out r142808.
1947 http://trac.webkit.org/changeset/142808
1948 https://bugs.webkit.org/show_bug.cgi?id=109816
1950 Crashes on chromium webkit canary bots (Requested by atwilson_
1953 * src/WebViewImpl.cpp:
1954 (WebKit::WebViewImpl::handleGestureEvent):
1955 (WebKit::WebViewImpl::bestTouchLinkNode):
1956 (WebKit::WebViewImpl::enableTouchHighlight):
1957 * src/WebViewImpl.h:
1959 * tests/LinkHighlightTest.cpp:
1962 2013-02-14 Sheriff Bot <webkit.review.bot@gmail.com>
1964 Unreviewed, rolling out r142841.
1965 http://trac.webkit.org/changeset/142841
1966 https://bugs.webkit.org/show_bug.cgi?id=109791
1968 Caused webkit_unit_tests to crash on chromium bots. (Requested
1969 by atwilson_ on #webkit).
1971 * tests/GraphicsLayerChromiumTest.cpp:
1972 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1973 * tests/ScrollingCoordinatorChromiumTest.cpp:
1974 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1976 2013-02-13 Max Vujovic <mvujovic@adobe.com>
1978 [CSS Filters] Refactor filter outsets into a class
1979 https://bugs.webkit.org/show_bug.cgi?id=109330
1981 Update FilterOperations unit tests to use new interface for getting filter outsets.
1983 Reviewed by Dean Jackson.
1985 * tests/FilterOperationsTest.cpp:
1988 2013-02-13 Zan Dobersek <zdobersek@igalia.com>
1990 The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
1991 https://bugs.webkit.org/show_bug.cgi?id=109325
1993 Reviewed by Anders Carlsson.
1995 Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
1996 two methods as they're provided by the C++ standard library being used.
1998 * tests/DecimalTest.cpp:
2001 2013-02-13 Alexandre Elias <aelias@chromium.org>
2003 [chromium] Fix scaling in WebViewImpl::handleGestureEvent
2004 https://bugs.webkit.org/show_bug.cgi?id=109671
2006 Reviewed by James Robinson.
2008 My last patch broke a bunch of things in handleGestureEvent that
2009 assumed the event came in scaled, most notably tap highlight and
2010 double-tap zoom. Switch those to PlatformGestureEvent.
2012 * src/WebViewImpl.cpp:
2013 (WebKit::WebViewImpl::handleGestureEvent):
2014 (WebKit::WebViewImpl::bestTapNode):
2015 (WebKit::WebViewImpl::enableTapHighlight):
2016 * src/WebViewImpl.h:
2018 * tests/LinkHighlightTest.cpp:
2021 2013-02-13 Eberhard Graether <egraether@google.com>
2023 chromium: remove CompositorHUDFontAtlas
2024 https://bugs.webkit.org/show_bug.cgi?id=109328
2026 Reviewed by James Robinson.
2028 After switching the HudLayer to use skia's font rendering the
2029 CompositorHUDFontAtlas has become obsolete. This change removes
2030 this class and the related WebLayerTreeView API.
2032 * src/WebViewImpl.cpp:
2033 * src/WebViewImpl.h:
2035 2013-02-13 Sheriff Bot <webkit.review.bot@gmail.com>
2037 Unreviewed. Rolled Chromium DEPS to r182150. Requested by
2038 jamesr_ via sheriffbot.
2042 2013-02-13 Sadrul Habib Chowdhury <sadrul@chromium.org>
2044 [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
2045 https://bugs.webkit.org/show_bug.cgi?id=109611
2047 The deltas in mousewheel events generated by track can be accelerated (e.g. when
2048 scrolling repeatedly). Keep track of the ratio of the acceleration since that is
2049 useful for some tasks (e.g. overflow navigation gesture).
2051 Reviewed by Adam Barth.
2053 * public/WebInputEvent.h:
2054 (WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
2055 * src/WebInputEvent.cpp:
2056 (SameSizeAsWebMouseWheelEvent):
2058 2013-02-12 Yoshifumi Inoue <yosin@chromium.org>
2060 Unreviewed. Build fix for Chromium-Win.
2061 Add #include <functional> for std::bind1st.
2063 * tests/PrerenderingTest.cpp:
2065 2013-02-12 Joshua Bell <jsbell@chromium.org>
2067 [Chromium] IndexedDB/Worker crash during shutdown
2068 https://bugs.webkit.org/show_bug.cgi?id=109467
2070 Reviewed by Tony Chang.
2072 If the message queue has already been terminated, don't bother scheduling
2073 a new error event that will never be delivered. Speculative fix for the
2074 issue, which only repros in multiprocess ports and so far only on some
2077 * src/IDBFactoryBackendProxy.cpp:
2078 (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.
2080 2013-02-12 Zan Dobersek <zdobersek@igalia.com>
2082 Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
2083 https://bugs.webkit.org/show_bug.cgi?id=109481
2085 Reviewed by Daniel Bates.
2087 The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
2088 back in r120574. There are still occurrences of it in various build systems
2089 which should all be removed as they are useless.
2093 2013-02-12 Jochen Eisinger <jochen@chromium.org>
2095 Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
2096 https://bugs.webkit.org/show_bug.cgi?id=109548
2098 Unreviewed gardening.
2100 * tests/WebFrameTest.cpp:
2102 2013-02-11 James Robinson <jamesr@chromium.org>
2104 [Chromium] Get rid of WebAnimationController
2105 https://bugs.webkit.org/show_bug.cgi?id=109235
2107 Reviewed by Benjamin Poulain.
2109 * public/WebAnimationController.h: Removed.
2110 * public/WebFrame.h:
2112 * src/WebAnimationControllerImpl.cpp: Removed.
2113 * src/WebAnimationControllerImpl.h: Removed.
2114 * src/WebFrameImpl.cpp:
2115 * src/WebFrameImpl.h:
2118 2013-02-11 James Robinson <jamesr@chromium.org>
2120 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
2121 https://bugs.webkit.org/show_bug.cgi?id=109403
2123 Reviewed by Adam Barth.
2125 * tests/GraphicsLayerChromiumTest.cpp:
2126 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2127 * tests/ScrollingCoordinatorChromiumTest.cpp:
2128 (WebKit::FakeWebViewClient::initializeLayerTreeView):
2130 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2132 Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
2133 https://bugs.webkit.org/show_bug.cgi?id=109534
2135 Reviewed by Anders Carlsson.
2137 * src/EditorClientImpl.cpp:
2139 * src/EditorClientImpl.h:
2142 2013-02-11 Alexandre Elias <aelias@chromium.org>
2144 [chromium] Apply page scale to all WebInputEvent types
2145 https://bugs.webkit.org/show_bug.cgi?id=109370
2147 Reviewed by James Robinson.
2149 Previously we only adjusted a few common input event types by page
2150 scale, but in fact almost every position and size in WebInputEvents
2153 I also took the opportunity to change some WebGestureEvent members to
2154 floats (which I checked causes no warnings in Chromium-side code with
2157 New WebInputEventConversionTest: InputEventsScaling
2159 * public/WebInputEvent.h:
2160 (WebKit::WebGestureEvent::WebGestureEvent):
2161 * src/WebInputEventConversion.cpp:
2162 (WebKit::widgetScaleFactor):
2164 (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
2165 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
2166 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2167 (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
2168 (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
2169 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
2170 (WebKit::addTouchPoints):
2171 (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
2172 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
2173 * src/WebViewImpl.cpp:
2174 (WebKit::WebViewImpl::handleGestureEvent):
2175 (WebKit::WebViewImpl::hasTouchEventHandlersAt):
2176 (WebKit::WebViewImpl::handleInputEvent):
2177 * tests/WebInputEventConversionTest.cpp:
2181 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2183 Unreviewed, rolling out r142568.
2184 http://trac.webkit.org/changeset/142568
2185 https://bugs.webkit.org/show_bug.cgi?id=109541
2187 Broke the build, won't compile. (Requested by alancutter on
2190 * tests/GraphicsLayerChromiumTest.cpp:
2191 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2192 * tests/ScrollingCoordinatorChromiumTest.cpp:
2193 (WebKit::FakeWebViewClient::initializeLayerTreeView):
2195 2013-02-11 James Robinson <jamesr@chromium.org>
2197 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
2198 https://bugs.webkit.org/show_bug.cgi?id=109403
2200 Reviewed by Adam Barth.
2202 * tests/GraphicsLayerChromiumTest.cpp:
2203 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2204 * tests/ScrollingCoordinatorChromiumTest.cpp:
2205 (WebKit::FakeWebViewClient::initializeLayerTreeView):
2207 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2209 Unreviewed. Rolled Chromium DEPS to r181817. Requested by
2210 "James Robinson" <jamesr@chromium.org> via sheriffbot.
2214 2013-02-11 David Grogan <dgrogan@chromium.org>
2216 IndexedDB: Add UnknownError to WebIDBDatabaseException
2217 https://bugs.webkit.org/show_bug.cgi?id=109519
2219 Reviewed by Adam Barth.
2221 * public/WebIDBDatabaseException.h:
2222 * src/AssertMatchingEnums.cpp:
2224 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2226 Unreviewed. Rolled Chromium DEPS to r181787. Requested by
2227 thakis_ via sheriffbot.
2231 2013-02-11 Nico Weber <thakis@chromium.org>
2233 Remove web intents code
2234 https://bugs.webkit.org/show_bug.cgi?id=109501
2236 Reviewed by Eric Seidel.
2238 See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
2242 * public/WebDeliveredIntentClient.h: Removed.
2243 * public/WebFrame.h:
2246 * public/WebFrameClient.h:
2248 * public/WebIntent.h: Removed.
2249 * public/WebIntentRequest.h: Removed.
2250 * public/WebIntentServiceInfo.h: Removed.
2251 * public/WebRuntimeFeatures.h:
2252 (WebRuntimeFeatures):
2253 * src/DeliveredIntentClientImpl.cpp: Removed.
2254 * src/DeliveredIntentClientImpl.h: Removed.
2255 * src/FrameLoaderClientImpl.cpp:
2256 * src/FrameLoaderClientImpl.h:
2257 (FrameLoaderClientImpl):
2258 * src/WebFrameImpl.cpp:
2259 * src/WebFrameImpl.h:
2262 * src/WebIntent.cpp: Removed.
2263 * src/WebIntentRequest.cpp: Removed.
2264 * src/WebIntentServiceInfo.cpp: Removed.
2265 * src/WebRuntimeFeatures.cpp:
2267 2013-02-11 Florin Malita <fmalita@chromium.org>
2269 Unreviewed. Rolled Chromium DEPS to r181770.
2273 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2275 Unreviewed. Rolled Chromium DEPS to r181742. Requested by
2276 fmalita_ via sheriffbot.
2280 2013-02-11 Rouslan Solomakhin <rouslan@chromium.org>
2282 [Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
2283 https://bugs.webkit.org/show_bug.cgi?id=108513
2285 Reviewed by Tony Chang.
2287 WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
2288 WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
2289 of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
2290 uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
2291 range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
2292 to avoid introducing spaces around misspellings.
2294 * src/WebFrameImpl.cpp:
2295 (WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
2296 * tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
2298 2013-02-11 Alexei Filippov <alph@chromium.org>
2300 Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
2301 https://bugs.webkit.org/show_bug.cgi?id=108653
2303 Reviewed by Yury Semikhatsky.
2305 Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
2306 In fact these two profile types have not too much in common. So put each into its own domain.
2307 It should also help when Profiles panel gets split into several tools.
2308 This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
2309 change the original InspectorProfilerAgent.
2311 * src/WebDevToolsAgentImpl.cpp:
2312 (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
2314 2013-02-11 Abhishek Arya <inferno@chromium.org>
2316 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
2317 https://bugs.webkit.org/show_bug.cgi?id=108981
2319 Reviewed by Eric Seidel.
2321 * src/AutofillPopupMenuClient.cpp:
2322 (WebKit::AutofillPopupMenuClient::getSuggestion):
2323 (WebKit::AutofillPopupMenuClient::getLabel):
2324 (WebKit::AutofillPopupMenuClient::getIcon):
2325 (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
2326 (WebKit::AutofillPopupMenuClient::valueChanged):
2327 (WebKit::AutofillPopupMenuClient::selectionChanged):
2328 * src/ChromeClientImpl.cpp:
2329 (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
2331 2013-02-10 James Robinson <jamesr@chromium.org>
2333 [chromium] Enable more of webkit_unit_tests in component builds
2334 https://bugs.webkit.org/show_bug.cgi?id=109369
2336 Reviewed by Darin Fisher.
2338 Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
2339 calling into webkit_support so they work in component builds.
2342 * tests/AssociatedURLLoaderTest.cpp:
2343 * tests/EventListenerTest.cpp:
2344 * tests/FrameTestHelpers.cpp:
2345 (WebKit::FrameTestHelpers::createWebViewAndLoad):
2347 (WebKit::FrameTestHelpers::QuitTask::run):
2349 (WebKit::FrameTestHelpers::runPendingTasks):
2350 * tests/FrameTestHelpers.h:
2352 * tests/ListenerLeakTest.cpp:
2353 * tests/PopupMenuTest.cpp:
2354 * tests/PrerenderingTest.cpp:
2355 * tests/ScrollingCoordinatorChromiumTest.cpp:
2356 (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
2357 (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
2358 * tests/URLTestHelpers.cpp:
2359 (WebKit::URLTestHelpers::registerMockedURLLoad):
2360 * tests/WebFrameTest.cpp:
2361 * tests/WebImageTest.cpp:
2363 * tests/WebPageNewSerializerTest.cpp:
2364 * tests/WebPageSerializerTest.cpp:
2365 * tests/WebPluginContainerTest.cpp:
2366 (WebKit::WebPluginContainerTest::TearDown):
2368 * tests/WebViewTest.cpp:
2370 2013-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
2372 Unreviewed. Rolled Chromium DEPS to r181645. Requested by
2373 "James Robinson" <jamesr@chromium.org> via sheriffbot.
2377 2013-02-09 Stephen Chenney <schenney@chromium.org>
2379 Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
2383 2013-02-09 Sheriff Bot <webkit.review.bot@gmail.com>
2385 Unreviewed. Rolled Chromium DEPS to last-known good revision.
2386 Requested by "Stephen Chenney" <schenney@chromium.org> via
2391 2013-02-08 Kent Tamura <tkent@chromium.org>
2393 [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
2394 https://bugs.webkit.org/show_bug.cgi?id=109272
2396 Reviewed by Kentaro Hara.
2398 We enabled this flag for desktop Chromium, but disabled the feature by a
2399 runtime flag. We disables the compile flag too because we have no plan
2400 to ship it in near future.
2402 * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
2404 2013-02-08 Stephen Chenney <schenney@chromium.org>
2406 Remove Skia code suppressions
2408 Unreviewed enabling of existing optimizations
2410 Removing all skia_webkit.gyp code suppressions and adding expectations
2415 2013-02-08 Dan Carney <dcarney@google.com>
2417 [v8] isolate parameter added to all v8::peristent calls
2418 https://bugs.webkit.org/show_bug.cgi?id=109268
2420 Reviewed by Kentaro Hara.
2422 * tests/WebFrameTest.cpp:
2424 2013-02-07 Kent Tamura <tkent@chromium.org>
2426 [Chromium-Android] Disable input[type=datetime]
2427 https://bugs.webkit.org/show_bug.cgi?id=107614
2429 Reviewed by Kentaro Hara.
2432 http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
2435 Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
2436 We enable it for non-Android ports but the runtime flag for it is
2437 disabled by default. The runtime flag is enabled only in DumpRenderTree.
2439 2013-02-07 Terry Anderson <tdanderson@chromium.org>
2441 [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
2442 https://bugs.webkit.org/show_bug.cgi?id=108719
2444 Reviewed by Eric Seidel.
2446 In the event of a main-thread touch fling, dispatch a series of
2447 GestureScrollUpdateWithoutPropagation events defined in
2448 https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
2449 GestureScrollUpdate events) so that the fling does not
2450 propagate to enclosing scrollables.
2452 * src/WebViewImpl.cpp:
2453 (WebKit::WebViewImpl::scrollBy):
2455 2013-02-07 Kent Tamura <tkent@chromium.org>
2457 [Chromium] Add a flag to enable native form validation message
2458 https://bugs.webkit.org/show_bug.cgi?id=109134
2460 Reviewed by Adam Barth.
2462 * public/WebRuntimeFeatures.h:
2463 (WebRuntimeFeatures): Add enableNativeValidationMessage and
2464 isNativeValidationMessageEnabled.
2465 * src/WebRuntimeFeatures.cpp:
2466 (WebKit): Add nativeValidationMessageEnabled.
2467 (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
2468 (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
2469 * src/WebViewImpl.cpp:
2470 (WebKit::WebViewImpl::WebViewImpl):
2471 Fill Page::PageClients::validationMessageClient if the flag is true.
2473 2013-02-07 Eberhard Graether <egraether@google.com>
2475 Web Inspector: Add settings checkbox for composited layer borders
2476 https://bugs.webkit.org/show_bug.cgi?id=109096
2478 Reviewed by Pavel Feldman.
2480 This change adds a checkbox to show composited layer borders to the WebInspector's
2481 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
2482 is visible if InspectorClient::canShowDebugBorders() returns true.
2484 * src/InspectorClientImpl.cpp:
2485 (WebKit::InspectorClientImpl::canShowDebugBorders):
2487 (WebKit::InspectorClientImpl::setShowDebugBorders):
2488 * src/InspectorClientImpl.h:
2489 (InspectorClientImpl):
2490 * src/WebViewImpl.cpp:
2491 (WebKit::WebViewImpl::WebViewImpl):
2492 (WebKit::WebViewImpl::setShowDebugBorders):
2494 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2495 * src/WebViewImpl.h:
2497 2013-02-07 Stephen White <senorblanco@chromium.org>
2499 Unreviewed. Rolled DEPS.
2503 2013-02-07 David Trainor <dtrainor@chromium.org>
2505 Add null check to editable in moveCaretSelectionTowardsWindowPoint
2506 https://bugs.webkit.org/show_bug.cgi?id=108962
2508 Reviewed by Eric Seidel.
2510 * src/WebFrameImpl.cpp:
2511 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
2512 * tests/WebFrameTest.cpp:
2514 2013-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
2516 Unreviewed. Rolled Chromium DEPS to r180752. Requested by
2517 thakis_ via sheriffbot.
2521 2013-02-06 Terry Anderson <tdanderson@chromium.org>
2523 Add support for gesture scroll events that do not propagate to enclosing scrollables
2524 https://bugs.webkit.org/show_bug.cgi?id=108849
2526 Reviewed by Antonio Gomes.
2528 Define the new event type GestureScrollUpdateWithoutPropagation.
2530 * public/WebInputEvent.h:
2531 (WebKit::WebInputEvent::isGestureEventType):
2532 * src/PageWidgetDelegate.cpp:
2533 (WebKit::PageWidgetDelegate::handleInputEvent):
2534 * src/WebInputEventConversion.cpp:
2535 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2536 * src/WebPluginContainerImpl.cpp:
2537 * src/WebPopupMenuImpl.cpp:
2538 (WebKit::WebPopupMenuImpl::handleInputEvent):
2539 * src/WebViewImpl.cpp:
2540 (WebKit::WebViewImpl::handleGestureEvent):
2542 2013-02-06 Alexandre Elias <aelias@chromium.org>
2544 Make ScrollView::paint() clip by visibleContentRect
2545 https://bugs.webkit.org/show_bug.cgi?id=108888
2547 Reviewed by Levi Weintraub.
2549 When applyPageScaleFactorInCompositor or fixedVisibleContentRect
2550 are used, frameRect() and visibleContentRect(true).size() are
2551 no longer synonyms, and the latter is the one that should be
2552 used for clipping paints.
2554 New WebFrameTest: pageScaleFactorScalesPaintClip.
2556 * tests/WebFrameTest.cpp:
2558 2013-02-06 Sheriff Bot <webkit.review.bot@gmail.com>
2560 Unreviewed, rolling out r142025.
2561 http://trac.webkit.org/changeset/142025
2562 https://bugs.webkit.org/show_bug.cgi?id=109091
2564 broke the build (Requested by tdanderson on #webkit).
2566 * public/WebInputEvent.h:
2567 (WebKit::WebInputEvent::isGestureEventType):
2568 * src/PageWidgetDelegate.cpp:
2569 (WebKit::PageWidgetDelegate::handleInputEvent):
2570 * src/WebInputEventConversion.cpp:
2571 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2572 * src/WebPluginContainerImpl.cpp:
2573 * src/WebPopupMenuImpl.cpp:
2574 (WebKit::WebPopupMenuImpl::handleInputEvent):
2575 * src/WebViewImpl.cpp:
2576 (WebKit::WebViewImpl::handleGestureEvent):
2578 2013-02-06 Daniel Cheng <dcheng@google.com>
2580 [chromium] Remove "config.h" header from WebUnitTests.cpp
2581 https://bugs.webkit.org/show_bug.cgi?id=108966
2583 Reviewed by Tony Chang.
2585 This file includes headers from base/ in Chromium, and config.h
2586 conflicts with base/logging.h. Rather than teaching certain files in
2587 base/ not to #include base/logging.h, remove the config.h include
2588 here. The ASSERT isn't really necessary, as attempting to run a null
2589 test suite won't go very far anyway.
2591 * tests/WebUnitTests.cpp:
2592 (WebKit::RunAllUnitTests):
2594 2013-02-06 Terry Anderson <tdanderson@chromium.org>
2596 Add support for gesture scroll events that do not propagate to enclosing scrollables
2597 https://bugs.webkit.org/show_bug.cgi?id=108849
2599 Reviewed by Antonio Gomes.
2601 Define the new event type GestureScrollUpdateWithoutPropagation.
2603 * public/WebInputEvent.h:
2604 (WebKit::WebInputEvent::isGestureEventType):
2605 * src/PageWidgetDelegate.cpp:
2606 (WebKit::PageWidgetDelegate::handleInputEvent):
2607 * src/WebInputEventConversion.cpp:
2608 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2609 * src/WebPluginContainerImpl.cpp:
2610 * src/WebPopupMenuImpl.cpp:
2611 (WebKit::WebPopupMenuImpl::handleInputEvent):
2612 * src/WebViewImpl.cpp:
2613 (WebKit::WebViewImpl::handleGestureEvent):
2615 2013-02-06 Chris Hopman <cjhopman@chromium.org>
2617 [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
2618 https://bugs.webkit.org/show_bug.cgi?id=108667
2620 Reviewed by Darin Fisher.
2622 WebWidget::selectionBounds() returns the anchor and focus of the
2623 selection. This matches the arguments to WebFrame::selectRange().
2624 Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
2625 anchor/focus to start/end.
2627 * public/WebWidget.h:
2629 (WebKit::WebWidget::isSelectionAnchorFirst):
2630 * src/WebViewImpl.cpp:
2631 (WebKit::WebViewImpl::isSelectionAnchorFirst):
2633 * src/WebViewImpl.h:
2634 * tests/WebViewTest.cpp:
2636 2013-02-06 Alec Flett <alecflett@chromium.org>
2638 IndexedDB: Stub out SharedBuffer version of put()
2639 https://bugs.webkit.org/show_bug.cgi?id=108986
2641 Reviewed by Darin Fisher.
2643 This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
2645 * public/WebIDBDatabase.h:
2647 (WebKit::WebIDBDatabase::put):
2649 2013-02-06 Stephen Chenney <schenney@chromium.org>
2651 Add Skia code suppression flags to WebKit skia.gyp
2655 This is step one in removing these flags. First we get them into
2656 WebKit, then we can remove them from Chrome.
2660 2013-02-06 Mike West <mkwst@chromium.org>
2662 Add an ENABLE_NOSNIFF feature flag.
2663 https://bugs.webkit.org/show_bug.cgi?id=109029
2665 Reviewed by Jochen Eisinger.
2667 This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
2668 when processing script and other resource types.
2672 2013-02-05 David Dorwin <ddorwin@chromium.org>
2674 [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
2675 https://bugs.webkit.org/show_bug.cgi?id=108989
2677 Reviewed by Kent Tamura.
2679 * src/WebMediaPlayerClientImpl.cpp:
2680 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
2682 2013-02-04 Kentaro Hara <haraken@chromium.org>
2684 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
2685 https://bugs.webkit.org/show_bug.cgi?id=108909
2687 Reviewed by Adam Barth.
2689 No tests. No change in behavior.
2691 * src/WebBindings.cpp:
2692 (WebKit::WebBindings::toV8Value):
2694 2013-02-05 Kentaro Hara <haraken@chromium.org>
2696 [V8] Make an Isolate parameter mandatory in HasInstance()
2697 https://bugs.webkit.org/show_bug.cgi?id=108917
2699 Reviewed by Adam Barth.
2701 Because these methods do not have an Isolate, we have to call
2702 v8::Isolate::GetCurrent().
2704 No tests. No change in behavior.
2706 * src/WebArrayBuffer.cpp:
2707 (WebKit::WebArrayBuffer::createFromV8Value):
2708 * src/WebArrayBufferView.cpp:
2709 (WebKit::WebArrayBufferView::createFromV8Value):
2710 * src/WebBindings.cpp:
2711 (WebKit::getRangeImpl):
2712 (WebKit::getNodeImpl):
2713 (WebKit::getElementImpl):
2714 (WebKit::getArrayBufferImpl):
2715 (WebKit::getArrayBufferViewImpl):
2716 (WebKit::WebBindings::getRange):
2717 (WebKit::WebBindings::getArrayBuffer):
2718 (WebKit::WebBindings::getArrayBufferView):
2719 (WebKit::WebBindings::getNode):
2720 (WebKit::WebBindings::getElement):
2722 2013-02-05 Dana Jansens <danakj@chromium.org>
2724 [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
2725 https://bugs.webkit.org/show_bug.cgi?id=107776
2727 Reviewed by James Robinson.
2730 * src/WebGraphicsContext3D.cpp: Removed.
2732 2013-02-05 Mark Lam <mark.lam@apple.com>
2734 Introduced back-end database classes + a few small fixes.
2735 https://bugs.webkit.org/show_bug.cgi?id=108759.
2737 Reviewed by Brady Eidson.
2739 * src/DatabaseObserver.cpp:
2740 (WebCore::DatabaseObserver::databaseOpened):
2741 (WebCore::DatabaseObserver::databaseModified):
2742 (WebCore::DatabaseObserver::databaseClosed):
2744 2013-02-05 Adam Barth <abarth@webkit.org>
2746 DumpRenderTree should be able to enable the threaded parser
2747 https://bugs.webkit.org/show_bug.cgi?id=108970
2749 Reviewed by Eric Seidel.
2751 * public/WebSettings.h:
2752 * src/WebSettingsImpl.cpp:
2753 (WebKit::WebSettingsImpl::setThreadedHTMLParser):
2755 * src/WebSettingsImpl.h:
2758 2013-02-05 Sami Kyostila <skyostil@chromium.org>
2760 [chromium] Make overlay layers slow-scrolling
2761 https://bugs.webkit.org/show_bug.cgi?id=108957
2763 Reviewed by James Robinson.
2765 Since overlay layers get inserted on top of everything else, we must
2766 mark them slow-scrolling to prevent all scroll input events to the rest
2767 of the page from getting blocked. This is also more correct because
2768 generally the overlay contents need to be repainted whenever the scroll
2769 offset changes, and with this patch the painting happens in sync with
2772 2013-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
2774 Unreviewed, rolling out r141896.
2775 http://trac.webkit.org/changeset/141896
2776 https://bugs.webkit.org/show_bug.cgi?id=108956
2778 crashes indexdb security tests (Requested by gavinp on
2781 * public/platform/WebKitPlatformSupport.h:
2783 (WebKitPlatformSupport):
2784 (WebKit::WebKitPlatformSupport::idbFactory):
2785 * src/IDBFactoryBackendProxy.cpp:
2786 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
2788 2013-02-05 Mark Pilgrim <pilgrim@chromium.org>
2790 [Chromium] Remove idbFactory from WebKitPlatformSupport
2791 https://bugs.webkit.org/show_bug.cgi?id=106457
2793 Reviewed by Adam Barth.
2795 Now that https://codereview.chromium.org/12181010/ has landed, the
2796 idbFactory method is no longer needed. (Embedders must now call
2797 the new setIDBFactory method upon initialization.) Part of a
2798 larger refactoring series; see tracking bug 82948.
2800 * public/platform/WebKitPlatformSupport.h:
2802 * src/IDBFactoryBackendProxy.cpp:
2803 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
2805 2013-02-05 Kentaro Hara <haraken@chromium.org>
2807 Unreviewed, rolling out r141865.
2808 http://trac.webkit.org/changeset/141865
2809 https://bugs.webkit.org/show_bug.cgi?id=108909
2811 webkit unit tests are broken
2813 * src/WebBindings.cpp:
2814 (WebKit::WebBindings::toV8Value):
2816 2013-02-05 Kentaro Hara <haraken@chromium.org>
2818 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
2819 https://bugs.webkit.org/show_bug.cgi?id=108909
2821 Reviewed by Adam Barth.
2823 No tests. No change in behavior.
2825 * src/WebBindings.cpp:
2826 (WebKit::WebBindings::toV8Value):
2828 2013-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
2830 Unreviewed. Rolled Chromium DEPS to r180583. Requested by
2831 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
2835 2013-02-04 James Simonsen <simonjam@chromium.org>
2837 [Chromium] Add a signal for when the body is inserted in the document
2838 https://bugs.webkit.org/show_bug.cgi?id=108725
2840 Reviewed by Adam Barth.
2842 * public/WebFrameClient.h:
2844 (WebKit::WebFrameClient::willInsertBody):
2845 * src/FrameLoaderClientImpl.cpp:
2846 (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
2848 * src/FrameLoaderClientImpl.h:
2849 (FrameLoaderClientImpl):
2850 * tests/WebFrameTest.cpp:
2852 2013-02-04 Chris Hopman <cjhopman@chromium.org>
2854 Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
2855 https://bugs.webkit.org/show_bug.cgi?id=107850
2857 Reviewed by Ojan Vafai.
2859 On Android, EditingBehavior::shouldMoveCaret[...] controls the
2860 behavior of insertion handles. This change adds a new Android specific
2861 editing behavior type so that we can change these settings independent
2862 of behavior for other platforms.
2864 * public/WebSettings.h:
2865 * src/AssertMatchingEnums.cpp:
2866 Just add the corresponding assertion for the new editing behavior.
2868 * public/WebSettings.h:
2869 * src/AssertMatchingEnums.cpp:
2871 * tests/WebFrameTest.cpp:
2872 * tests/data/move_caret.html: Added.
2873 Add a test that moveCaretTowardsWindowPoint works as expected on
2876 2013-01-31 Kentaro Hara <haraken@chromium.org>
2878 Implement WheelEvent::deltaMode
2879 https://bugs.webkit.org/show_bug.cgi?id=108455
2881 Reviewed by Adam Barth.
2883 * src/WebInputEventConversion.cpp:
2884 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
2886 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
2888 [Chromium] Move WorkerContextProxy to WebCore
2889 https://bugs.webkit.org/show_bug.cgi?id=108847
2891 Reviewed by Adam Barth.
2893 Part of a larger refactoring series; see tracking bug 106829.
2897 (WebKit::initializeWithoutV8):
2898 * src/WorkerContextProxy.cpp: Removed.
2900 2013-02-04 Abhishek Arya <inferno@chromium.org>
2902 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
2903 https://bugs.webkit.org/show_bug.cgi?id=108668
2905 Reviewed by Eric Seidel.
2907 * src/ContextFeaturesClientImpl.cpp:
2908 (WebKit::ContextFeaturesCache::entryFor):
2909 * src/WebFrameImpl.cpp:
2910 (WebKit::WebFrameImpl::selectFindMatch):
2912 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
2914 [Chromium] Move IDBFactoryBackendInterface to WebCore
2915 https://bugs.webkit.org/show_bug.cgi?id=108638
2917 Reviewed by Adam Barth.
2919 Part of a larger refactoring series; see tracking bug 106829.
2922 * src/AssertMatchingEnums.cpp:
2923 * src/IDBFactoryBackendInterface.cpp: Removed.
2924 * src/IDBFactoryBackendProxy.h:
2926 (WebKit::initializeWithoutV8):
2928 2013-02-04 Abhishek Arya <inferno@chromium.org>
2930 Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
2931 https://bugs.webkit.org/show_bug.cgi?id=108688
2933 Reviewed by Eric Seidel.
2935 * src/IDBFactoryBackendProxy.cpp:
2936 (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
2937 (WebKit::getWebFrame):
2938 * src/LocalFileSystemChromium.cpp:
2939 (WebCore::LocalFileSystem::deleteFileSystem):
2940 * src/WebSharedWorkerImpl.cpp:
2941 (WebKit::WebSharedWorkerImpl::connectTask):
2942 (WebKit::resumeWorkerContextTask):
2943 (WebKit::connectToWorkerContextInspectorTask):
2944 (WebKit::reconnectToWorkerContextInspectorTask):
2945 (WebKit::disconnectFromWorkerContextInspectorTask):
2946 (WebKit::dispatchOnInspectorBackendTask):
2948 2013-02-04 Sami Kyostila <skyostil@chromium.org>
2950 Disable -webkit-overflow-scrolling CSS attribute on Chromium
2951 https://bugs.webkit.org/show_bug.cgi?id=108020
2953 Reviewed by James Robinson.
2955 Now that we can automatically promote overflow elements to accelerated
2956 scrolling layers there is no use for the -webkit-overflow-scrolling CSS
2957 attribute any longer on Chromium.
2959 This patch enables composited overflow scrolling in
2960 ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
2961 in non-fast-scrollable.html to become composited, we also need to modify that
2962 test to opt it out of composited scrolling.
2965 * tests/ScrollingCoordinatorChromiumTest.cpp:
2966 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
2968 * tests/data/non-fast-scrollable.html:
2969 * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
2971 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
2973 Fix build warning after r141473
2974 https://bugs.webkit.org/show_bug.cgi?id=108782
2976 Reviewed by Kentaro Hara.
2978 Fix -Wunused-parameter build warning.
2980 * src/EditorClientImpl.cpp:
2981 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
2983 2013-02-03 David Dorwin <ddorwin@chromium.org>
2985 [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
2986 https://bugs.webkit.org/show_bug.cgi?id=108740
2988 Reviewed by Kent Tamura.
2990 The calls to m_widgetClient->show() and setFocus() do not appear to be
2991 necessary, and the former causes problems on at least on platform.
2993 * src/WebHelperPluginImpl.cpp:
2994 (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
2995 (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
2997 2013-02-02 Michael Nordman <michaeln@google.com>
2999 [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
3000 This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
3001 sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
3002 in place and in use.
3003 https://bugs.webkit.org/show_bug.cgi?id=108736
3005 Reviewed by Darin Fisher.
3007 * public/WebFileSystemCallbacks.h:
3008 (WebFileSystemCallbacks):
3009 (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
3011 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
3013 Unreviewed. Rolled Chromium DEPS to r180221. Requested by
3014 "Nico Weber" <thakis@chromium.org> via sheriffbot.
3018 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
3020 Unreviewed. Rolled Chromium DEPS to r180186. Requested by
3021 "Nico Weber" <thakis@chromium.org> via sheriffbot.
3025 2013-02-01 Chris Hopman <cjhopman@chromium.org>
3027 [Chromium] WebWidget::selectionBounds should return the bounds in document space
3028 https://bugs.webkit.org/show_bug.cgi?id=108386
3030 Reviewed by James Robinson.
3032 When in applyPageScaleFactorInCompositor mode, selectionBounds needs
3033 to scale the anchor/focus window points by the pageScaleFactor.
3035 * src/WebViewImpl.cpp:
3036 (WebKit::WebViewImpl::selectionBounds):
3037 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
3039 2013-02-01 Dominic Mazzoni <dmazzoni@google.com>
3041 AX: memoize expensive computation during blocks where tree doesn't change
3042 https://bugs.webkit.org/show_bug.cgi?id=106497
3044 Reviewed by Ryosuke Niwa.
3046 Expose two methods to enable and disable caching of
3047 computed WebAccessibilityObject attributes, to speed up
3048 batch read-only operations.
3050 * public/WebAccessibilityObject.h:
3051 (WebAccessibilityObject):
3052 * src/WebAccessibilityObject.cpp:
3053 (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
3055 (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
3057 2013-02-01 Fady Samuel <fsamuel@chromium.org>
3059 [Chromium] Expose WebNode::shadowHost()
3060 https://bugs.webkit.org/show_bug.cgi?id=108681
3062 Reviewed by Dimitri Glazkov.
3064 BrowserPlugin needs to be able to check the event listeners attached to
3065 <webview> and so we expose shadowHost to permit it to poke at the webview
3070 (WebKit::WebNode::shadowHost):
3073 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
3075 [Chromium] Ignore punctuation in spellcheck
3076 https://bugs.webkit.org/show_bug.cgi?id=108511
3078 Reviewed by Tony Chang.
3080 * src/ContextMenuClientImpl.cpp:
3081 (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
3082 (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
3084 2013-02-01 Philip Rogers <pdr@google.com>
3086 Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
3087 https://bugs.webkit.org/show_bug.cgi?id=106966
3089 Reviewed by Stephen White.
3091 * tests/DragImageTest.cpp:
3092 (WebCore::TestImage::currentFrameKnownToBeOpaque):
3094 * tests/ImageLayerChromiumTest.cpp:
3095 (WebCore::TestImage::currentFrameKnownToBeOpaque):
3096 * tests/PlatformContextSkiaTest.cpp:
3099 2013-02-01 Nico Weber <thakis@chromium.org>
3101 [chromium] Build webkit with enable_web_intents set to 0.
3102 https://bugs.webkit.org/show_bug.cgi?id=108408
3104 Reviewed by Tony Chang.
3106 I'll then make chromium build fine with that, then switch
3107 enable_web_intents to 0, roll that into webkit, and then
3108 actually remove the code hidden behind this flag.
3110 The features.gypi bit depends on https://codereview.chromium.org/12143002/
3111 and will disable web intents support on android. Since common.gypi
3112 sets enable_web_intents to 0 explicitly, it seems this is currently on
3115 While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
3116 features.gypi completely, it's still set further down the file if
3117 enable_web_intents is on.
3121 * src/WebFrameImpl.cpp:
3123 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
3125 [Chromium] Ignore whitespace in spellcheck
3126 https://bugs.webkit.org/show_bug.cgi?id=108510
3128 Reviewed by Ryosuke Niwa.
3130 * src/ContextMenuClientImpl.cpp:
3131 (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
3133 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
3135 Unreviewed. Rolled Chromium DEPS to r180131. Requested by
3136 "Florin Malita" <fmalita@chromium.org> via sheriffbot.
3140 2013-02-01 Alexis Menard <alexis@webkit.org>
3142 Enable unprefixed CSS transitions by default.
3143 https://bugs.webkit.org/show_bug.cgi?id=108216
3145 Reviewed by Dean Jackson.
3147 Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
3148 to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
3149 guard the unprefixing work for CSS Transforms and animations.
3153 2013-02-01 Ken Kania <kkania@chromium.org>
3155 Web Inspector: Add support for handling modal dialogs
3156 https://bugs.webkit.org/show_bug.cgi?id=107883
3158 Reviewed by Pavel Feldman.
3160 Introduce support for being notified when a JavaScript modal dialog
3161 is opening and closing, as well as a new command for accepting or
3162 dismissing the dialog.
3164 * public/WebDevToolsAgent.h:
3165 * src/InspectorClientImpl.cpp:
3166 (WebKit::InspectorClientImpl::handleJavaScriptDialog):
3168 * src/InspectorClientImpl.h:
3169 (InspectorClientImpl):
3170 * src/WebDevToolsAgentImpl.cpp:
3171 (BrowserDataHintStringValues):
3172 (WebKit::WebDevToolsAgentImpl::captureScreenshot):
3173 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
3175 (WebKit::browserHintToString):
3176 (WebKit::browserHintFromString):
3177 (WebKit::WebDevToolsAgent::patchWithBrowserData):
3178 * src/WebDevToolsAgentImpl.h:
3179 (WebDevToolsAgentImpl):
3181 2013-02-01 Dan Alcantara <dfalcantara@chromium.org>
3183 Touch disambiguation blacklist is not being queried properly
3184 https://bugs.webkit.org/show_bug.cgi?id=108222
3186 Reviewed by Adam Barth.
3188 TEST=WebFrameTest::DisambiguationPopupBlacklist
3190 Fix the blacklist so that we check it for the right nodes.
3191 Add a test to check that the blacklist is being built and used
3192 correctly. Also update the other DisambiguationPopup tests to
3193 use the new page scale method.
3195 * tests/WebFrameTest.cpp:
3196 * tests/data/disambiguation_popup_blacklist.html: Added.
3198 2013-02-01 Eberhard Graether <egraether@google.com>
3200 [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
3201 https://bugs.webkit.org/show_bug.cgi?id=108236
3203 Reviewed by Pavel Feldman.
3205 This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
3206 This way the checkboxes only show up for users that can make use of these features.
3208 * src/InspectorClientImpl.cpp:
3209 (WebKit::InspectorClientImpl::canShowFPSCounter):
3210 (WebKit::InspectorClientImpl::canContinuouslyPaint):
3212 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3214 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
3215 https://bugs.webkit.org/show_bug.cgi?id=107737
3217 Reviewed by Ryosuke Niwa.
3219 * public/WebViewClient.h:
3220 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
3221 Adding a callback to let the WebViewClient know that the composition has been cancelled.
3222 * src/EditorClientImpl.cpp:
3223 (WebKit::EditorClientImpl::respondToChangedSelection):
3224 Adding a call composition if it is no longer valid.
3226 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3228 [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
3229 https://bugs.webkit.org/show_bug.cgi?id=108543
3231 Reviewed by Ryosuke Niwa.
3233 Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
3235 * src/WebViewImpl.cpp:
3236 (WebKit::WebViewImpl::setCompositionFromExistingText):
3237 * tests/WebViewTest.cpp:
3238 Re-enabling the test
3240 2013-01-31 Hajime Morrita <morrita@google.com>
3242 Unreviewed, followup fix for r141535.
3244 * tests/WebFrameTest.cpp:
3246 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
3248 Unreviewed. Rolled Chromium DEPS to r180023. Requested by
3249 thakis_ via sheriffbot.
3253 2013-01-31 Hajime Morrita <morrita@google.com>
3255 Unreviewed, disabling failing test.
3257 * tests/WebFrameTest.cpp:
3259 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
3261 Unreviewed, rolling out r141479.
3262 http://trac.webkit.org/changeset/141479
3263 https://bugs.webkit.org/show_bug.cgi?id=108564
3265 breaks chromium test (Requested by morrita on #webkit).
3267 * public/WebViewClient.h:
3268 * src/EditorClientImpl.cpp:
3269 (WebKit::EditorClientImpl::respondToChangedSelection):
3271 2013-01-31 Alec Flett <alecflett@chromium.org>
3273 IndexedDB: remove old transaction backend bootstrap code
3274 https://bugs.webkit.org/show_bug.cgi?id=103923
3276 Reviewed by Dimitri Glazkov.
3278 Remove all deprecated WebKit APIs from
3282 * public/WebIDBCallbacks.h:
3284 * public/WebIDBDatabase.h:
3286 * public/WebIDBTransaction.h: Removed.
3287 * public/WebIDBTransactionCallbacks.h: Removed.
3288 * src/AssertMatchingEnums.cpp:
3289 * src/IDBCallbacksProxy.cpp:
3290 * src/IDBDatabaseBackendProxy.cpp:
3291 * src/IDBDatabaseBackendProxy.h:
3292 (IDBDatabaseBackendProxy):
3293 * src/IDBTransactionBackendProxy.cpp: Removed.
3294 * src/IDBTransactionBackendProxy.h: Removed.
3295 * src/IDBTransactionCallbacksProxy.cpp: Removed.
3296 * src/IDBTransactionCallbacksProxy.h: Removed.
3297 * src/WebIDBCallbacksImpl.cpp:
3298 * src/WebIDBDatabaseImpl.cpp:
3300 * src/WebIDBDatabaseImpl.h:
3302 (WebIDBDatabaseImpl):
3303 * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
3304 * src/WebIDBTransactionCallbacksImpl.h: Removed.
3305 * src/WebIDBTransactionImpl.cpp: Removed.
3306 * src/WebIDBTransactionImpl.h: Removed.
3307 * tests/IDBAbortOnCorruptTest.cpp:
3308 * tests/IDBDatabaseBackendTest.cpp:
3310 2013-01-31 Rouslan Solomakhin <rouslan@chromium.org>
3312 [Chromium] Select multi-word misspelling on context click
3313 https://bugs.webkit.org/show_bug.cgi?id=108509
3315 Reviewed by Tony Chang.
3317 * src/ContextMenuClientImpl.cpp:
3319 (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
3320 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
3322 2013-01-31 Florin Malita <fmalita@chromium.org>
3324 [Chromium] Unreviewed gardening.
3326 WebViewTest.SetCompositionFromExistingText failing after r141479.
3328 * tests/WebViewTest.cpp:
3330 2013-01-31 Alexandre Elias <aelias@chromium.org>
3332 [chromium] Rework page scale factor limits initialization
3333 https://bugs.webkit.org/show_bug.cgi?id=108446
3335 Reviewed by James Robinson.
3337 When loading a page with viewportEnabled, both the limits
3338 specified by the viewport tag and the content width need to be
3339 considered before we initialize the minimum page scale (and
3340 pageScaleFactor itself usually to the same value). The timing has
3341 proven tricky to get correct.
3343 This patch simplifies the flow by computing the
3344 limits only at the end of layouts and at no other time. In combination
3345 with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
3346 needsLayout() appropriately, this results in a more robust and easy
3347 to understand sequence.
3349 Fixes FixedLayoutInitializeAtMinimumPageScale test.
3351 * src/ChromeClientImpl.cpp:
3352 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3353 * src/WebViewImpl.cpp:
3354 (WebKit::WebViewImpl::WebViewImpl):
3355 (WebKit::WebViewImpl::resize):
3356 (WebKit::WebViewImpl::setPageScaleFactorLimits):
3357 (WebKit::WebViewImpl::computePageScaleFactorLimits):
3358 (WebKit::WebViewImpl::layoutUpdated):
3359 (WebKit::WebViewImpl::didChangeContentsSize):
3360 * src/WebViewImpl.h:
3361 (WebKit::WebViewImpl::setInitialPageScaleFactor):
3363 * tests/WebFrameTest.cpp:
3365 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3367 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
3368 https://bugs.webkit.org/show_bug.cgi?id=107737
3370 Reviewed by Ryosuke Niwa.
3372 * public/WebViewClient.h:
3373 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
3374 Adding a callback to let the WebViewClient know that the composition has been cancelled.
3375 * src/EditorClientImpl.cpp:
3376 (WebKit::EditorClientImpl::respondToChangedSelection):
3377 Adding a call composition if it is no longer valid.
3379 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
3381 [Chromium] Move LocalizedStrings to WebCore
3382 https://bugs.webkit.org/show_bug.cgi?id=108488
3384 Reviewed by Adam Barth.
3386 Part of a larger refactoring series; see tracking bug 106829.
3389 * src/LocalizedStrings.cpp: Removed.
3391 2013-01-31 Enrica Casucci <enrica@apple.com>
3393 WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
3394 https://bugs.webkit.org/show_bug.cgi?id=108396.
3395 <rdar://problem/12920461>
3397 Reviewed by Alexey Proskuryakov.
3399 Adds stub implementation for WebKit of the new EditorClient methods.
3401 * src/EditorClientImpl.cpp:
3402 (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
3403 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
3404 * src/EditorClientImpl.h:
3406 2013-01-31 Chris Hopman <cjhopman@chromium.org>
3408 [chromium] Make selection handling work in applyPageScaleInCompositor mode
3409 https://bugs.webkit.org/show_bug.cgi?id=107831
3411 Reviewed by Ryosuke Niwa.
3413 These functions expect a window point. When in
3414 applyPageScaleFactorInCompositor mode, the points need to be unscaled
3415 by the page scale factor.
3417 * src/WebFrameImpl.cpp:
3418 (WebKit::WebFrameImpl::selectRange):
3419 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
3421 2013-01-31 Tom Sepez <tsepez@chromium.org>
3423 [v8] Enable binding integrity on mac
3424 https://bugs.webkit.org/show_bug.cgi?id=108500
3426 Reviewed by Adam Barth.
3428 Patch is correct if existing tests pass without new crashes.
3431 Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
3433 2013-01-31 Dan Alcantara <dfalcantara@chromium.org>
3435 WebFrameTest.DisambiguationPopup is failing
3436 https://bugs.webkit.org/show_bug.cgi?id=108160
3438 Reviewed by Adam Barth.
3440 Fix the unit test so that it is using the right HTML file.
3442 * tests/WebFrameTest.cpp:
3444 2013-01-31 Tony Chang <tony@chromium.org>
3446 [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
3447 https://bugs.webkit.org/show_bug.cgi?id=108497
3449 Reviewed by James Robinson.
3451 * WebKitUnitTests.gyp:
3453 2013-01-31 Alexandre Elias <aelias@chromium.org>
3455 Call FrameView::contentsResized() when setting fixed layout size
3456 https://bugs.webkit.org/show_bug.cgi?id=107922
3458 Reviewed by James Robinson.
3460 In fixed layout mode, we should be calling contentsResized() when the
3461 fixed layout size is changed, but not laying out when the visible
3462 content rect changes.
3464 Previously landed as r140869 but was reverted due to a bug in bundled
3465 Chromium-specific code. This patch includes just the minimum needed in
3468 New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
3469 flaky and obsolete tests for the old page scale mode are also deleted.
3471 * tests/WebFrameTest.cpp:
3473 2013-01-31 Tommy Widenflycht <tommyw@google.com>
3475 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
3476 https://bugs.webkit.org/show_bug.cgi?id=108458
3478 Reviewed by Adam Barth.
3480 Only renames, no other code changes.
3482 * public/WebMediaStreamRegistry.h:
3484 (WebMediaStreamRegistry):
3485 * public/WebUserMediaRequest.h:
3487 (WebUserMediaRequest):
3488 * src/WebMediaStreamRegistry.cpp:
3489 (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
3490 * src/WebUserMediaRequest.cpp:
3491 (WebKit::WebUserMediaRequest::requestSucceeded):
3493 2013-01-31 Alec Flett <alecflett@chromium.org>
3495 IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
3496 https://bugs.webkit.org/show_bug.cgi?id=108399
3498 Reviewed by Dimitri Glazkov.
3500 Cleanup now that chromium proxies the new signatures through.
3502 * src/IDBCallbacksProxy.cpp:
3503 (WebKit::IDBCallbacksProxy::onSuccess):
3504 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
3505 * src/IDBCallbacksProxy.h:
3506 (IDBCallbacksProxy):
3507 * src/WebIDBCallbacksImpl.cpp:
3508 * src/WebIDBCallbacksImpl.h:
3509 (WebIDBCallbacksImpl):
3511 2013-01-31 James Robinson <jamesr@chromium.org>
3513 [chromium] Remove dead transitional code from WebViewImpl
3514 https://bugs.webkit.org/show_bug.cgi?id=107889
3516 Reviewed by Adam Barth.
3518 The chromium side of this landed at r178256 and seems stable.
3520 * public/WebWidget.h:
3521 (WebKit::WebWidget::setCompositorSurfaceReady):
3522 * src/WebViewImpl.cpp: