1 2013-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
3 Unreviewed. Rolled Chromium DEPS to r185341. Requested by
4 "James Robinson" <jamesr@chromium.org> via sheriffbot.
8 2013-02-28 Varun Jain <varunjain@chromium.org>
10 Add new webkit API to invoke a context menu.
11 https://bugs.webkit.org/show_bug.cgi?id=111040
13 Reviewed by Adam Barth.
17 * src/WebViewImpl.cpp:
18 (WebKit::WebViewImpl::showContextMenu):
22 2013-02-28 Aaron Colwell <acolwell@chromium.org>
24 Factor SourceBuffer methods out of MediaSourcePrivate & WebMediaSource
25 into SourceBufferPrivate & WebSourceBuffer respectively.
26 https://bugs.webkit.org/show_bug.cgi?id=110798
28 Reviewed by Adam Barth, Jer Noble.
31 * public/WebMediaSourceClient.h:
33 (WebMediaSourceClient):
34 * public/WebSourceBuffer.h:
36 (WebSourceBuffer): Contains SourceBuffer methods extracted from WebMediaSource.
37 (WebKit::WebSourceBuffer::~WebSourceBuffer):
38 * src/AssertMatchingEnums.cpp:
39 * src/MediaSourcePrivateImpl.cpp:
41 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
42 (WebKit::MediaSourcePrivateImpl::addSourceBuffer):
43 (WebKit::MediaSourcePrivateImpl::duration):
44 (WebKit::MediaSourcePrivateImpl::setDuration):
45 (WebKit::MediaSourcePrivateImpl::endOfStream):
46 * src/MediaSourcePrivateImpl.h:
48 (MediaSourcePrivateImpl): Adapts MediaSourcePrivate interface to WebMediaSourceClient.
49 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
50 * src/SourceBufferPrivateImpl.cpp:
52 (WebKit::SourceBufferPrivateImpl::SourceBufferPrivateImpl):
53 (WebKit::SourceBufferPrivateImpl::buffered):
54 (WebKit::SourceBufferPrivateImpl::append):
55 (WebKit::SourceBufferPrivateImpl::abort):
56 (WebKit::SourceBufferPrivateImpl::setTimestampOffset):
57 (WebKit::SourceBufferPrivateImpl::removedFromMediaSource):
58 * src/SourceBufferPrivateImpl.h:
60 (SourceBufferPrivateImpl): Adapts SourceBufferPrivate interface to WebSourceBuffer.
61 (WebKit::SourceBufferPrivateImpl::~SourceBufferPrivateImpl):
62 * src/WebMediaPlayerClientImpl.cpp:
63 (WebMediaSourceClientImpl):
65 (WebSourceBufferImpl): Temporary implementation of WebSourceBuffer to keep things working
66 until the Chromium side changes land.
67 (WebKit::WebMediaSourceClientImpl::addSourceBuffer):
68 (WebKit::WebMediaSourceClientImpl::duration):
69 (WebKit::WebMediaSourceClientImpl::setDuration):
70 (WebKit::WebMediaSourceClientImpl::endOfStream):
71 (WebKit::WebSourceBufferImpl::WebSourceBufferImpl):
72 (WebKit::WebSourceBufferImpl::buffered):
73 (WebKit::WebSourceBufferImpl::append):
74 (WebKit::WebSourceBufferImpl::abort):
75 (WebKit::WebSourceBufferImpl::setTimestampOffset):
76 (WebKit::WebSourceBufferImpl::removedFromMediaSource):
77 * src/WebMediaSourceImpl.cpp:
79 2013-02-28 David Grogan <dgrogan@chromium.org>
81 IndexedDB: IO error when checking schema should destroy LevelDB directory
82 https://bugs.webkit.org/show_bug.cgi?id=110675
84 Reviewed by Adam Barth.
87 This was cargo-culted. The component build wouldn't run otherwise.
90 * tests/IDBCleanupOnIOErrorTest.cpp: Added.
92 2013-02-28 Stephen Chenney <schenney@chromium.org>
94 RenderTableCellDeathTest unit test fails on mac
95 https://bugs.webkit.org/show_bug.cgi?id=110992
97 Unreviewed revert of all changes. The problem seems to have resolved.
99 * tests/RenderTableCellTest.cpp: Remove Mac disable code.
101 2013-02-28 Takashi Toyoshima <toyoshim@chromium.org>
103 Unreviewed, quick test breakage fix for android
104 https://bugs.webkit.org/show_bug.cgi?id=110740
106 Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
108 * src/WebViewImpl.cpp:
109 (WebKit::WebViewImpl::textInputInfo): Reconstruct condition check order
111 2013-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
113 Unreviewed. Rolled Chromium DEPS to r184931. Requested by
114 "Takashi Toyoshima" <toyoshim@chromium.org> via sheriffbot.
118 2013-02-27 Seigo Nonaka <nona@chromium.org>
120 [Chromium] Should not return WebTextInputTypeNone for date input element.
121 https://bugs.webkit.org/show_bug.cgi?id=110740
123 Reviewed by Kent Tamura.
125 In the case of Windows 8, text input state including on-screen keyboard is controlled by the
126 value of WebTextInputType returned from WebViewImpl::textInputType().
127 In past, it returned WebTextInputTypeDate for date text input but now it returns
128 WebTextInputTypeNone.
129 WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
130 the date text input is focused. So there is no way to input on Windows 8 tablet without
131 physical keyboard except tapping small up/down arrow.
133 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
134 * src/WebViewImpl.cpp:
135 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
136 safe because textInputType returns editable type only for known editable element.
137 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
140 2013-02-27 James Simonsen <simonjam@chromium.org>
142 [chromium] Lower priority of preloaded images
143 https://bugs.webkit.org/show_bug.cgi?id=110527
145 Plumb the didChangePriority signal into DRT so it can be tested.
147 Reviewed by Nate Chapin.
149 * public/WebFrameClient.h:
151 (WebKit::WebFrameClient::didChangeResourcePriority):
153 * src/FrameLoaderClientImpl.cpp:
154 (WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
156 * src/FrameLoaderClientImpl.h:
157 (FrameLoaderClientImpl):
159 2013-02-27 Min Qin <qinmin@chromium.org>
161 Unlock partially decoded images after passing them to the ImageDecodingStore
162 https://bugs.webkit.org/show_bug.cgi?id=110778
164 Reviewed by Stephen White.
166 Test for testing that image frames are unlocked after passing to ImageDecodingStore.
168 * tests/ImageFrameGeneratorTest.cpp:
169 (WebCore::ImageFrameGeneratorTest::SetUp):
170 (WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
171 (ImageFrameGeneratorTest):
172 (WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
174 * tests/MockImageDecoder.h:
175 (WebCore::MockImageDecoderClient::frameBuffersLocked):
176 (WebCore::MockImageDecoderClient::frameBuffersUnlocked):
177 (WebCore::MockImageDecoder::unlockFrameBuffers):
178 (WebCore::MockImageDecoder::lockFrameBuffers):
181 2013-02-27 John Bauman <jbauman@chromium.org>
183 Plugin in iframe may not display
184 https://bugs.webkit.org/show_bug.cgi?id=109879
186 Reviewed by Simon Fraser.
188 Use clipRectChanged to update the geometry.
190 * src/WebPluginContainerImpl.cpp:
191 (WebKit::WebPluginContainerImpl::clipRectChanged):
192 * src/WebPluginContainerImpl.h:
194 2013-02-27 Stephen Chenney <schenney@chromium.org>
196 RenderTableCellDeathTest unit test fails on mac
197 https://bugs.webkit.org/show_bug.cgi?id=110992
199 Unreviewed second attempt. Trying to get the right define for the OS.
201 * tests/RenderTableCellTest.cpp:
203 2013-02-27 Stephen Chenney <schenney@chromium.org>
205 RenderTableCellDeathTest unit test fails on mac
206 https://bugs.webkit.org/show_bug.cgi?id=110992
208 Unreviewed disabling of test that is hanging or crashing on Mac.
210 * tests/RenderTableCellTest.cpp:
212 2013-02-27 James Robinson <jamesr@chromium.org>
214 [chromium] Remove suppression invalidation logic from WebViewImpl
215 https://bugs.webkit.org/show_bug.cgi?id=110999
217 Reviewed by Adrienne Walker.
219 This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
222 * src/WebViewImpl.cpp:
223 (WebKit::WebViewImpl::WebViewImpl):
224 (WebKit::WebViewImpl::suppressInvalidations):
225 (WebKit::WebViewImpl::scheduleComposite):
228 2013-02-27 Glenn Adams <glenn@skynav.com>
230 Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
231 https://bugs.webkit.org/show_bug.cgi?id=110944
233 Reviewed by Dean Jackson.
237 2013-02-26 James Robinson <jamesr@chromium.org>
239 [chromium] Remove WebViewImpl::animate shimmy out through compositor
240 https://bugs.webkit.org/show_bug.cgi?id=110935
242 Reviewed by Adrienne Walker.
244 WebViewImpl::animate() and WebViewImpl::updateAnimations() are confusingly similar. ::animate() implements
245 the WebWidget API and is called by content::RenderWidget and WebViewHost. ::updateAnimations() implements
246 the WebLayerTreeViewClient API and is called by content::RenderWidgetCompositor and by ::animate(). The
247 important part of this indirection is that whenever the compositor is active, all animation calls must
248 route through cc::LayerTreeHost before entering into WebCore's animation code so that the compositor
249 can set the appropriate rate limiting state. Animations may originate from
250 content::RenderWidget::AnimateIfNeeded when in software and single threaded mode or from
251 cc::LayerTreeHost::updateAnimations in threaded compositing mode. In the long ago, content::RenderWidget had no
252 idea if compositing was active or not and always called WebWidget::animate(), so WebViewImpl::animate() had to
253 redirect to the compositor when appropriate.
255 Now (as of chromium r180947) RenderWidget calls WebWidget::animate only when in software mode and otherwise
256 calls directly into the compositor. Thus WebViewImpl::animate() no longer needs to do this check. In a
257 follow-up, WebViewImpl::updateAnimations will go away completely in favor of just calling WebWidget::animate in
260 * src/WebViewImpl.cpp:
261 (WebKit::WebViewImpl::animate):
262 (WebKit::WebViewImpl::updateAnimations):
264 2013-02-27 Sheriff Bot <webkit.review.bot@gmail.com>
266 Unreviewed, rolling out r144179.
267 http://trac.webkit.org/changeset/144179
268 https://bugs.webkit.org/show_bug.cgi?id=110980
270 Breaks compilation (Requested by vsevik on #webkit).
272 * public/WebTextInputType.h:
273 * src/WebViewImpl.cpp:
274 (WebKit::WebViewImpl::textInputInfo):
275 (WebKit::WebViewImpl::textInputType):
277 2013-02-27 Stephen Chenney <schenney@chromium.org>
279 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
280 https://bugs.webkit.org/show_bug.cgi?id=110922
282 Unreviewed build fix.
284 * tests/GIFImageDecoderTest.cpp:
286 (WebKit::TEST): Disable the entire test on Android.
288 2013-02-27 Seigo Nonaka <nona@chromium.org>
290 [Chromium] Should not return WebTextInputTypeNone for date input element.
291 https://bugs.webkit.org/show_bug.cgi?id=110740
293 Reviewed by Kent Tamura.
295 In the case of Windows 8, text input state including on-screen keyboard is controlled by the
296 value of WebTextInputType returned from WebViewImpl::textInputType().
297 In past, it returned WebTextInputTypeDate for date text input but now it returns
298 WebTextInputTypeNone.
299 WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
300 the date text input is focused. So there is no way to input on Windows 8 tablet without
301 physical keyboard except tapping small up/down arrow.
303 * public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
304 * src/WebViewImpl.cpp:
305 (WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
306 safe because textInputType returns editable type only for known editable element.
307 (WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
310 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
312 Unreviewed, rolling out r144129.
313 http://trac.webkit.org/changeset/144129
314 https://bugs.webkit.org/show_bug.cgi?id=110947
316 Breaks compilation on chromium mac and win (Requested by
319 * src/WebViewImpl.cpp:
320 (WebKit::WebViewImpl::willBeginFrame):
322 (WebKit::WebViewImpl::didBeginFrame):
324 * tests/WebLayerTreeViewTestCommon.h:
326 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
328 Unreviewed. Rolled Chromium DEPS to r184829. Requested by
329 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
333 2013-02-26 James Robinson <jamesr@chromium.org>
335 [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
336 https://bugs.webkit.org/show_bug.cgi?id=110928
338 Reviewed by Adrienne Walker.
340 * src/WebViewImpl.cpp:
342 * tests/WebLayerTreeViewTestCommon.h:
344 2013-02-26 Alpha Lam <hclam@chromium.org>
346 [chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
347 https://bugs.webkit.org/show_bug.cgi?id=110922
349 Unreviewed. Build fix.
351 * tests/GIFImageDecoderTest.cpp:
354 2013-02-26 James Robinson <jamesr@chromium.org>
356 [chromium] Remove unused WebLayerTreeViewClient calls
357 https://bugs.webkit.org/show_bug.cgi?id=110923
359 Reviewed by Adrienne Walker.
361 These notifications existed for instrumentation, but now the instrumentation routes
362 through WebDevToolsAgent.
364 * src/WebViewImpl.cpp:
366 * tests/WebLayerTreeViewTestCommon.h:
368 2013-02-26 Dirk Pranke <dpranke@chromium.org>
370 Roll Chromium DEPS from r183905 -> r184646.
376 2013-02-26 James Robinson <jamesr@chromium.org>
378 [chromium] Remove unused WebWidget::instrument calls
379 https://bugs.webkit.org/show_bug.cgi?id=110906
381 Reviewed by Jochen Eisinger.
383 These calls are now routed through WebDevToolsAgent.
385 * public/WebWidget.h:
386 * src/WebViewImpl.cpp:
387 (WebKit::WebViewImpl::willBeginFrame):
390 2013-02-20 Alpha Lam <hclam@chromium.org>
392 GIFImageReader to read from source data directly
393 https://bugs.webkit.org/show_bug.cgi?id=109662
395 Reviewed by Stephen White.
397 Added the following unit tests to test new logic in GIFImageDecoder:
399 GIFImageDecoderTest.decodeTwoFrames
400 Test that it can decode a multi-frame GIF image correctly.
402 GIFImageDecoderTest.parseAndDecode
403 First perform a parse operation and then a decode operation. Expect
404 that parse and decode operates correctly.
406 GIFImageDecoderTest.parseByteByByte
407 Test that multi-frame GIF image can be parsed correctly byte by byte.
409 GIFImageDecoderTest.parseAndDecodeByteByByte
410 Run a loop to feed decoder byte by byte, perform a parse and then
411 decode operation and make sure frames are decoded correctly.
413 GIFImageDecoderTest.brokenSecondFrame
414 Decode a GIF image with second frame broken. Expect that the first
415 frame can be decoded correctly.
418 * tests/GIFImageDecoderTest.cpp: Added.
422 * tests/data/broken.gif: Added.
424 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
426 Unreviewed, rolling out r144065.
427 http://trac.webkit.org/changeset/144065
428 https://bugs.webkit.org/show_bug.cgi?id=110896
430 Causing failures and crashes on Chromium Win7 and Win XP
431 (Requested by schenney on #webkit).
435 2013-02-26 Levi Weintraub <leviw@chromium.org>
437 Add support for 8 bit TextRuns for Chromium/HarfBuzz
438 https://bugs.webkit.org/show_bug.cgi?id=99393
440 Reviewed by Eric Seidel.
442 Enabling 8 bit text runs for Chromium.
446 2013-02-26 Dmitry Zvorygin <zvorygin@chromium.org>
448 Merged Tip and Debug log levels for web console.
449 https://bugs.webkit.org/show_bug.cgi?id=109919
451 Reviewed by Pavel Feldman.
453 In every component either TIP or DEBUG level was used for reporting,
454 but not both. This patch is prerequisite for Web Inspector console log filtering.
456 * public/WebConsoleMessage.h:
457 * src/AssertMatchingEnums.cpp:
458 * src/WebFrameImpl.cpp:
459 (WebKit::WebFrameImpl::addMessageToConsole):
461 2013-02-26 Andrey Kosyakov <caseq@chromium.org>
463 Plumbing trace events to Timeline
465 Web Inspector: plumb trace events to Timeline agent
466 https://bugs.webkit.org/show_bug.cgi?id=105796
468 Reviewed by Pavel Feldman.
470 * public/WebDevToolsAgentClient.h:
471 (WebDevToolsAgentClient):
472 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
473 * src/InspectorClientImpl.cpp:
474 (WebKit::InspectorClientImpl::setTraceEventCallback):
476 * src/InspectorClientImpl.h:
477 (InspectorClientImpl):
478 * src/WebDevToolsAgentImpl.cpp:
479 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
481 * src/WebDevToolsAgentImpl.h:
482 (WebDevToolsAgentImpl):
484 2013-02-01 Andrey Kosyakov <caseq@chromium.org>
486 Web Inspector: plumb trace events to Timeline agent
487 https://bugs.webkit.org/show_bug.cgi?id=105796
489 Reviewed by Pavel Feldman.
491 Plumb trace events to Inspector.
493 * public/WebDevToolsAgentClient.h:
494 (WebDevToolsAgentClient):
495 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
496 * src/InspectorClientImpl.cpp:
497 (WebKit::InspectorClientImpl::setTraceEventCallback):
499 * src/InspectorClientImpl.h:
500 (InspectorClientImpl):
501 * src/WebDevToolsAgentImpl.cpp:
502 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
504 * src/WebDevToolsAgentImpl.h:
505 (WebDevToolsAgentImpl):
507 2013-02-26 Andrey Kosyakov <caseq@chromium.org>
509 Unreviewed, rolling out r144041, r144044, and r144048.
510 http://trac.webkit.org/changeset/144041
511 http://trac.webkit.org/changeset/144044
512 http://trac.webkit.org/changeset/144048
513 https://bugs.webkit.org/show_bug.cgi?id=105796
517 * public/WebDevToolsAgentClient.h:
518 * src/InspectorClientImpl.cpp:
519 * src/InspectorClientImpl.h:
520 (InspectorClientImpl):
521 * src/WebDevToolsAgentImpl.cpp:
522 * src/WebDevToolsAgentImpl.h:
523 (WebDevToolsAgentImpl):
525 2013-02-01 Andrey Kosyakov <caseq@chromium.org>
527 Web Inspector: plumb trace events to Timeline agent
528 https://bugs.webkit.org/show_bug.cgi?id=105796
530 Reviewed by Pavel Feldman.
532 Plumb trace events to Inspector.
534 * public/WebDevToolsAgentClient.h:
535 (WebDevToolsAgentClient):
536 (WebKit::WebDevToolsAgentClient::setTraceEventCallback):
537 * src/InspectorClientImpl.cpp:
538 (WebKit::InspectorClientImpl::setTraceEventCallback):
540 * src/InspectorClientImpl.h:
541 (InspectorClientImpl):
542 * src/WebDevToolsAgentImpl.cpp:
543 (WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
545 * src/WebDevToolsAgentImpl.h:
546 (WebDevToolsAgentImpl):
548 2013-02-26 Tien-Ren Chen <trchen@chromium.org>
550 Implement coordinated scrollbar for subframes and overflow:scroll
551 https://bugs.webkit.org/show_bug.cgi?id=109560
553 Reviewed by James Robinson.
555 Added ScrollingCoordinatorChromiumTest.iframeScrolling to verify
556 impl-side scrolling and impl-side scrollbars for frames.
558 Update ScrollingCoordinatorChromiumTest.overflowScrolling to verify
559 impl-side scrollbars.
561 * tests/ScrollingCoordinatorChromiumTest.cpp:
562 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
565 * tests/data/iframe-scrolling-inner.html: Added.
566 * tests/data/iframe-scrolling.html: Added.
568 2013-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
570 Unreviewed, rolling out r144016.
571 http://trac.webkit.org/changeset/144016
572 https://bugs.webkit.org/show_bug.cgi?id=110856
574 Breaks compilation on chromium mac (Requested by vsevik on
578 * tests/KeyCodeConversionTest.cpp: Removed.
580 2013-02-26 James Robinson <jamesr@chromium.org>
582 [chromium] Fix continuous painting mode
583 https://bugs.webkit.org/show_bug.cgi?id=110788
585 Reviewed by Adrienne Walker.
587 Recent instrumentation shuffling caused WebViewImpl::didBeginFrame to no longer be called, which
588 broke continuous painting. Since continuous painting mode is meant to simply invalidate layers
589 on each frame, it's a better fit for the animation system. This moves the invalidation calls
590 into WebViewImpl::updateAnimations along with other animation type things.
592 Tested manually by enabling continuous painting mode in the inspector. There aren't any automated
593 tests in WebKit for this feature.
595 * src/WebViewImpl.cpp:
596 (WebKit::WebViewImpl::setContinuousPaintingEnabled):
597 (WebKit::WebViewImpl::didBeginFrame):
598 (WebKit::WebViewImpl::updateAnimations):
599 * src/painting/ContinuousPainter.cpp:
600 (WebKit::ContinuousPainter::setNeedsDisplayRecursive):
602 2013-02-26 James Weatherall <wez@chromium.org>
604 keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
605 https://bugs.webkit.org/show_bug.cgi?id=85642
607 Add tests to verify that the fixed keys generate the same keyCode values
608 as their equivalents.
610 Reviewed by Ojan Vafai.
613 * tests/KeyCodeConversionTest.cpp: Added.
617 2013-02-25 Rouslan Solomakhin <rouslan@chromium.org>
619 Add expandedToParagraph() method to WebRange
620 https://bugs.webkit.org/show_bug.cgi?id=110618
622 Reviewed by Adam Barth.
624 Add a method expandedToParagraph() to WebRange to return a copy of the
625 range expanded to paragraph boundaries. This method is to be used to
626 query the spelling context around the misspelled word under cursor.
629 (WebRange): Added expandedToParagraph() method declaration.
631 (WebKit::WebRange::expandedToParagraph): Added method to copy range, expand the copied range to paragraph boundaries, and return the resulting range.
632 (WebKit): Added expandedToParagraph() method definition.
634 2013-02-25 James Robinson <jamesr@chromium.org>
636 [chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
637 https://bugs.webkit.org/show_bug.cgi?id=110834
639 Reviewed by Adrienne Walker.
641 * src/WebViewImpl.cpp:
642 (WebKit::WebViewImpl::suppressInvalidations):
643 (WebKit::WebViewImpl::setRootGraphicsLayer):
645 2013-02-25 Ken Kania <kkania@chromium.org>
647 Remove browser patching mechanism for handling javascript dialogs in chromium port
648 https://bugs.webkit.org/show_bug.cgi?id=110531
650 Reviewed by Pavel Feldman.
652 * public/WebDevToolsAgent.h:
653 * src/WebDevToolsAgentImpl.cpp:
654 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
655 (WebKit::browserHintToString):
656 (WebKit::browserHintFromString):
657 (WebKit::WebDevToolsAgent::patchWithBrowserData):
659 2013-02-25 James Robinson <jamesr@chromium.org>
661 [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
662 https://bugs.webkit.org/show_bug.cgi?id=110640
664 Reviewed by Adrienne Walker.
666 This plumbs the WebViewImpl::m_suppressInvalidations logic out to the WebWidgetClient so
667 it can be implemented by the embedder. The existing logic is left in place for now,
668 once the embedder side has landed WebViewImpl will be purely a pass-through.
670 * public/WebWidgetClient.h:
672 (WebKit::WebWidgetClient::suppressCompositorScheduling):
673 * src/WebViewImpl.cpp:
674 (WebKit::WebViewImpl::suppressInvalidations):
675 (WebKit::WebViewImpl::setRootGraphicsLayer):
677 2013-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
679 Unreviewed, rolling out r143936.
680 http://trac.webkit.org/changeset/143936
681 https://bugs.webkit.org/show_bug.cgi?id=110789
683 Causes webkit_unit_tests failures on android dbg (Requested by
688 * tests/GIFImageDecoderTest.cpp: Removed.
689 * tests/data/broken.gif: Removed.
691 2013-02-25 Alpha Lam <hclam@chromium.org>
693 GIFImageReader to read from source data directly
694 https://bugs.webkit.org/show_bug.cgi?id=109662
696 Reviewed by Stephen White.
698 Added the following unit tests to test new logic in GIFImageDecoder:
700 GIFImageDecoderTest.decodeTwoFrames
701 Test that it can decode a multi-frame GIF image correctly.
703 GIFImageDecoderTest.parseAndDecode
704 First perform a parse operation and then a decode operation. Expect
705 that parse and decode operates correctly.
707 GIFImageDecoderTest.parseByteByByte
708 Test that multi-frame GIF image can be parsed correctly byte by byte.
710 GIFImageDecoderTest.parseAndDecodeByteByByte
711 Run a loop to feed decoder byte by byte, perform a parse and then
712 decode operation and make sure frames are decoded correctly.
714 GIFImageDecoderTest.brokenSecondFrame
715 Decode a GIF image with second frame broken. Expect that the first
716 frame can be decoded correctly.
720 * tests/GIFImageDecoderTest.cpp: Added.
724 * tests/data/broken.gif: Added.
726 2013-02-25 Andrey Kosyakov <caseq@chromium.org>
728 Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.
731 (.TestSuite.prototype.testPageOverlayUpdate.step2):
733 2013-02-25 Anton Vayvod <avayvod@chromium.org>
735 [Chromium] Disable registerProtocolHandler on Android
736 https://bugs.webkit.org/show_bug.cgi?id=110481
738 Reviewed by Julien Chaffraix.
740 Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
741 actually wired up internally. Disable the feature to avoid breaking feature detection until
742 we can implement it properly. Previous attempt is at http://trac.webkit.org/changeset/133465
743 See the discussion of the future implementation at http://crbug.com/156386
745 * features.gypi: Disable the flag for Android, enable it only for non-Android platforms.
747 * src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.
749 2013-02-24 Hajime Morrita <morrita@google.com>
751 [Custom Elements] Implement bare-bone document.register()
752 https://bugs.webkit.org/show_bug.cgi?id=100229
754 Reviewed by Adam Barth.
756 Added enableCustomDOMElements flag.
759 * public/WebRuntimeFeatures.h:
760 (WebRuntimeFeatures):
761 * src/WebRuntimeFeatures.cpp:
762 (WebKit::WebRuntimeFeatures::enableCustomDOMElements):
764 (WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):
766 2013-02-23 Mark Pilgrim <pilgrim@chromium.org>
768 [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
769 https://bugs.webkit.org/show_bug.cgi?id=110605
771 Reviewed by Adam Barth.
773 Part of a larger refactoring series; see tracking bug 82948.
778 (WebKit::initialize):
779 (WebKit::initializeWithoutV8):
780 (WebKit::webKitPlatformSupport):
782 2013-02-22 David Dorwin <ddorwin@chromium.org>
784 [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
785 https://bugs.webkit.org/show_bug.cgi?id=110668
787 Reviewed by Adam Barth.
789 This fixes http://crbug.com/172764
791 * src/WebHelperPluginImpl.cpp:
792 (WebKit::WebHelperPluginImpl::destoryPage):
794 2013-02-22 Aaron Colwell <acolwell@chromium.org>
796 Factor MediaSource methods out of MediaPlayer & MediaPlayerPrivate and into a new MediaSourcePrivate interface.
797 https://bugs.webkit.org/show_bug.cgi?id=109857
799 Reviewed by Adam Barth.
801 WebMediaSource and WebMediaSource client were created to replace the MediaSource methods in WebMediaPlayer and
802 WebMediaPlayerClient. This allows the MediaSource implementation to be updated without further polluting the
803 media player interfaces.
806 * public/WebMediaPlayer.h:
808 (WebKit::WebMediaPlayer::load):
809 * public/WebMediaPlayerClient.h:
811 * public/WebMediaSource.h: Added.
814 (WebKit::WebMediaSource::~WebMediaSource):
815 * public/WebMediaSourceClient.h: Added.
817 (WebMediaSourceClient):
818 (WebKit::WebMediaSourceClient::~WebMediaSourceClient):
819 * src/AssertMatchingEnums.cpp:
820 * src/WebMediaPlayerClientImpl.cpp:
822 (WebMediaSourceClientImpl): Temporary WebMediaSourceClient implementation to keep things working until Chromium
824 (WebKit::WebMediaSourceClientImpl::WebMediaSourceClientImpl):
825 (WebKit::WebMediaSourceClientImpl::~WebMediaSourceClientImpl):
826 (WebKit::WebMediaSourceClientImpl::addId):
827 (WebKit::WebMediaSourceClientImpl::removeId):
828 (WebKit::WebMediaSourceClientImpl::buffered):
829 (WebKit::WebMediaSourceClientImpl::append):
830 (WebKit::WebMediaSourceClientImpl::abort):
831 (WebKit::WebMediaSourceClientImpl::duration):
832 (WebKit::WebMediaSourceClientImpl::setDuration):
833 (WebKit::WebMediaSourceClientImpl::endOfStream):
834 (WebKit::WebMediaSourceClientImpl::setTimestampOffset):
835 (WebKit::WebMediaPlayerClientImpl::sourceOpened):
836 (WebKit::WebMediaPlayerClientImpl::sourceURL):
837 (WebKit::WebMediaPlayerClientImpl::load):
838 (WebKit::WebMediaPlayerClientImpl::loadRequested):
839 (WebKit::WebMediaPlayerClientImpl::loadInternal):
840 * src/WebMediaPlayerClientImpl.h:
841 (WebMediaPlayerClientImpl):
842 * src/WebMediaSourceImpl.cpp: Added.
844 (MediaSourcePrivateImpl):
845 (WebKit::MediaSourcePrivateImpl::~MediaSourcePrivateImpl):
846 (WebKit::MediaSourcePrivateImpl::MediaSourcePrivateImpl):
847 (WebKit::MediaSourcePrivateImpl::addId):
848 (WebKit::MediaSourcePrivateImpl::removeId):
849 (WebKit::MediaSourcePrivateImpl::buffered):
850 (WebKit::MediaSourcePrivateImpl::append):
851 (WebKit::MediaSourcePrivateImpl::abort):
852 (WebKit::MediaSourcePrivateImpl::duration):
853 (WebKit::MediaSourcePrivateImpl::setDuration):
854 (WebKit::MediaSourcePrivateImpl::endOfStream):
855 (WebKit::MediaSourcePrivateImpl::setTimestampOffset):
856 (WebKit::WebMediaSourceImpl::WebMediaSourceImpl):
857 (WebKit::WebMediaSourceImpl::~WebMediaSourceImpl):
858 (WebKit::WebMediaSourceImpl::open):
859 * src/WebMediaSourceImpl.h: Added.
861 (WebMediaSourceImpl):
863 2013-02-22 Alec Flett <alecflett@chromium.org>
865 IndexedDB: Remove old SerializedScriptValue-based get() callbacks
866 https://bugs.webkit.org/show_bug.cgi?id=110626
868 Reviewed by James Robinson.
870 Removal now that refactoring is complete.
872 * public/WebIDBCallbacks.h:
875 2013-02-22 Ali Juma <ajuma@chromium.org>
877 [chromium] Register newly-created layers for animation
878 https://bugs.webkit.org/show_bug.cgi?id=106594
880 Reviewed by James Robinson.
883 * src/ChromeClientImpl.cpp:
884 (WebKit::ChromeClientImpl::ChromeClientImpl):
885 (WebKit::ChromeClientImpl::graphicsLayerFactory):
886 * src/ChromeClientImpl.h:
888 * src/GraphicsLayerFactoryChromium.cpp: Added.
890 (WebKit::GraphicsLayerFactoryChromium::GraphicsLayerFactoryChromium):
891 (WebKit::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
892 (WebKit::GraphicsLayerFactoryChromium::createGraphicsLayer):
893 * src/GraphicsLayerFactoryChromium.h: Added.
895 (GraphicsLayerFactoryChromium):
896 * src/WebViewImpl.cpp:
897 (WebKit::WebViewImpl::WebViewImpl):
898 (WebKit::WebViewImpl::graphicsLayerFactory):
900 (WebKit::WebViewImpl::registerForAnimations):
904 2013-02-22 Fady Samuel <fsamuel@chromium.org>
906 [Chromium] Expose shadowRoot to the WebKit API
907 https://bugs.webkit.org/show_bug.cgi?id=110522
909 Reviewed by Dimitri Glazkov.
911 * public/WebElement.h:
913 * src/WebElement.cpp:
914 (WebKit::WebElement::shadowRoot):
917 2013-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
919 Unreviewed, rolling out r143734.
920 http://trac.webkit.org/changeset/143734
921 https://bugs.webkit.org/show_bug.cgi?id=110615
923 Causes linux build failures. (Requested by vollick on
929 (WebKit::initialize):
930 (WebKit::initializeWithoutV8):
931 (WebKit::webKitPlatformSupport):
933 2013-02-22 Mikhail Naganov <mnaganov@chromium.org>
935 [Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method
936 https://bugs.webkit.org/show_bug.cgi?id=109946
938 Adding a WebView method for permanently setting initial page scale.
939 This override has higher priority than any calculated page scale
940 and viewport meta tag value.
942 Also, this patch eliminates a dubious "fixed layout enabled, viewport disabled" mode
943 previously used by Android WebView.
945 Reviewed by Adam Barth.
949 * src/ChromeClientImpl.cpp:
950 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
951 * src/WebViewImpl.cpp:
952 (WebKit::WebViewImpl::WebViewImpl):
953 (WebKit::WebViewImpl::setInitialPageScaleOverride):
955 (WebKit::WebViewImpl::computePageScaleFactorLimits):
957 * tests/WebFrameTest.cpp:
959 2013-02-22 Mark Pilgrim <pilgrim@chromium.org>
961 [Chromium] WebKit::initialize should take a Platform* now that WebKitPlatformSupport is empty
962 https://bugs.webkit.org/show_bug.cgi?id=110605
964 Reviewed by Adam Barth.
966 Part of a larger refactoring series; see tracking bug 82948.
971 (WebKit::initialize):
972 (WebKit::initializeWithoutV8):
973 (WebKit::webKitPlatformSupport):
975 2013-02-22 Andrey Kosyakov <caseq@chromium.org>
977 Web Inspector: [Chromium] add a browser test for frames on timeline
978 https://bugs.webkit.org/show_bug.cgi?id=110592
980 - factor out timeline recording logic from testPageOverlayUpdate for reuse;
981 - record timeline while running a simple DOM-based animation;
982 - assure we have frames and Style Recalc/Layout/Paint events in between.
984 Reviewed by Yury Semikhatsky.
987 (.TestSuite.prototype.assertHasKey):
988 (.TestSuite.prototype.testTimelineFrames.step1):
989 (.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
990 (.TestSuite.prototype.testTimelineFrames):
991 (.TestSuite.prototype.testPageOverlayUpdate.step4):
992 (.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
993 (.TestSuite.prototype.recordTimeline.addRecord):
994 (.TestSuite.prototype.recordTimeline.innerAddRecord):
995 (.TestSuite.prototype.recordTimeline.done):
996 (.TestSuite.prototype.recordTimeline):
997 (.TestSuite.prototype.stopTimeline):
999 2013-02-21 Alec Flett <alecflett@chromium.org>
1001 IndexedDB: Implement SharedBuffer version of put() / onSuccess()
1002 https://bugs.webkit.org/show_bug.cgi?id=110398
1004 Reviewed by Tony Chang.
1006 Proxy new SharedBuffer calls to WebIDBCallbacks through
1007 to the new SharedBuffer-based IDBCallbacks.
1009 * public/WebIDBCursor.h:
1010 * src/IDBCallbacksProxy.cpp:
1011 (WebKit::IDBCallbacksProxy::onSuccess):
1012 (WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):
1013 * src/IDBCallbacksProxy.h:
1014 (IDBCallbacksProxy):
1015 * src/WebIDBCallbacksImpl.cpp:
1016 (WebKit::WebIDBCallbacksImpl::onSuccess):
1017 * src/WebIDBCallbacksImpl.h:
1018 (WebIDBCallbacksImpl):
1019 * tests/IDBAbortOnCorruptTest.cpp:
1020 (WebCore::MockIDBCallbacks::onSuccess):
1021 (WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
1022 * tests/IDBDatabaseBackendTest.cpp:
1023 * tests/IDBRequestTest.cpp:
1026 2013-02-21 Grzegorz Czajkowski <g.czajkowski@samsung.com>
1028 Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
1029 https://bugs.webkit.org/show_bug.cgi?id=110208
1031 Reviewed by Hajime Morrita.
1033 * src/EditorClientImpl.cpp:
1034 (WebKit::EditorClientImpl::requestCheckingOfString):
1035 Extract the request data as it is the member of 'TextCheckingRequest'.
1037 2013-02-21 Mark Pilgrim <pilgrim@chromium.org>
1039 [Chromium] Remove chromium/public/platform directory
1040 https://bugs.webkit.org/show_bug.cgi?id=110471
1042 Reviewed by Adam Barth.
1044 Part of a larger refactoring series; see tracking bug 82948.
1047 * public/platform: Removed.
1048 * public/platform/WebKitPlatformSupport.h: Removed.
1049 * public/platform/android: Removed.
1050 * public/platform/default: Removed.
1051 * public/platform/linux: Removed.
1052 * public/platform/mac: Removed.
1053 * public/platform/win: Removed.
1056 2013-02-21 Dirk Pranke <dpranke@chromium.org>
1058 [chromium] support the lucid version of freetype on precise in DRT
1059 https://bugs.webkit.org/show_bug.cgi?id=107338
1061 Reviewed by Tony Chang.
1063 Add in a linux-only dependency on Freetype2 so that we can
1064 match the version shipped in Ubuntu Lucid.
1068 2013-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
1070 Unreviewed. Rolled Chromium DEPS to r183905. Requested by
1071 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1075 2013-02-21 Alec Flett <alecflett@chromium.org>
1077 IndexedDB: Remove copying WebIDBDatabase::put() stub
1078 https://bugs.webkit.org/show_bug.cgi?id=109967
1080 Reviewed by Darin Fisher.
1082 Now that the chromium call to this method has
1083 been removed, we can remove the stub.
1085 * public/WebIDBDatabase.h:
1087 2013-02-21 Dirk Pranke <dpranke@chromium.org>
1089 Unreviewed, roll chromium deps 183552 -> 183788
1093 2013-02-21 John Mellor <johnme@chromium.org>
1095 [chromium] Simplify computation of screenRect/windowRect.
1096 https://bugs.webkit.org/show_bug.cgi?id=110456
1098 Reviewed by Adam Barth.
1100 This patch removes applyDeviceScaleFactorInCompositor checks
1101 added by http://trac.webkit.org/changeset/139356 because
1102 Chrome for Android now sizes its screen and window in DIP
1103 units (like other platforms), so they are no longer necessary.
1105 * src/ChromeClientImpl.cpp:
1106 (WebKit::ChromeClientImpl::windowRect):
1108 2013-02-21 Vsevolod Vlasov <vsevik@chromium.org>
1110 Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
1111 https://bugs.webkit.org/show_bug.cgi?id=110335
1113 Reviewed by Alexander Pavlov.
1116 (.TestSuite.prototype._scriptsAreParsed):
1118 2013-02-21 Ken Kania <kkania@chromium.org>
1120 Web Inspector: Add command for selecting files for file input element
1121 https://bugs.webkit.org/show_bug.cgi?id=109308
1123 Reviewed by Pavel Feldman.
1125 * src/InspectorClientImpl.cpp:
1126 (WebKit::InspectorClientImpl::canSetFileInputFiles):
1128 * src/InspectorClientImpl.h:
1129 (InspectorClientImpl):
1131 2013-02-20 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
1133 Add gyp option to switch ENABLE(SQL_DATABASE)
1134 https://bugs.webkit.org/show_bug.cgi?id=109303
1135 http://code.google.com/p/chromium/issues/detail?id=22208
1137 Reviewed by Tony Chang.
1139 This will be useful to implement build with system sqlite.
1142 * src/ChromeClientImpl.cpp:
1144 * src/ChromeClientImpl.h:
1147 2013-02-20 Dirk Schulze <krit@webkit.org>
1149 Enable CANVAS_PATH flag
1150 https://bugs.webkit.org/show_bug.cgi?id=108508
1152 Reviewed by Simon Fraser.
1154 Enable CANVAS_PATH flag on trunk.
1158 2013-02-15 Dirk Schulze <krit@webkit.org>
1160 [Chromium] Add runtime flag for CanvasPath
1161 https://bugs.webkit.org/show_bug.cgi?id=109997
1163 Reviewed by Adam Barth.
1165 Add runtime flag for Chromium.
1167 * public/WebRuntimeFeatures.h:
1168 (WebRuntimeFeatures):
1169 * src/WebRuntimeFeatures.cpp:
1170 (WebKit::WebRuntimeFeatures::enableCanvasPath):
1172 (WebKit::WebRuntimeFeatures::isCanvasPathEnabled):
1174 2013-02-20 Mark Pilgrim <pilgrim@chromium.org>
1176 [Chromium] Move WebKitPlatformSupport declaration to Platform.h
1177 https://bugs.webkit.org/show_bug.cgi?id=110262
1179 Reviewed by Adam Barth.
1181 In preparation for removing WebKitPlatformSupport.h entirely (once
1182 downstream references to that file have been updated). Part of a
1183 larger refactoring series; see tracking bug 82948.
1185 * public/platform/WebKitPlatformSupport.h:
1187 2013-02-20 Mark Pilgrim <pilgrim@chromium.org>
1189 [Chromium] Remove idbFactory from WebKitPlatformSupport
1190 https://bugs.webkit.org/show_bug.cgi?id=106457
1192 Reviewed by Adam Barth.
1194 Now that https://codereview.chromium.org/12230054 has landed, the
1195 idbFactory method is no longer needed. (Embedders must now call
1196 the new setIDBFactory method upon initialization.) Part of a
1197 larger refactoring series; see tracking bug 82948.
1199 * public/platform/WebKitPlatformSupport.h:
1201 * src/IDBFactoryBackendProxy.cpp:
1202 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1204 2013-02-20 Mark Lam <mark.lam@apple.com>
1206 Rename DatabaseBackend to DatabaseBackendBase.
1207 https://bugs.webkit.org/show_bug.cgi?id=110303.
1209 Rubber stamped by Alexey Proskuryakov.
1211 * public/WebDatabase.h:
1213 * src/DatabaseObserver.cpp:
1214 (WebCore::DatabaseObserver::databaseOpened):
1215 (WebCore::DatabaseObserver::databaseModified):
1216 (WebCore::DatabaseObserver::databaseClosed):
1217 (WebCore::DatabaseObserver::reportOpenDatabaseResult):
1218 (WebCore::DatabaseObserver::reportChangeVersionResult):
1219 (WebCore::DatabaseObserver::reportStartTransactionResult):
1220 (WebCore::DatabaseObserver::reportCommitTransactionResult):
1221 (WebCore::DatabaseObserver::reportExecuteStatementResult):
1222 (WebCore::DatabaseObserver::reportVacuumDatabaseResult):
1223 * src/WebDatabase.cpp:
1224 (WebKit::WebDatabase::WebDatabase):
1226 2013-02-20 Rouslan Solomakhin <rouslan@chromium.org>
1228 Fix use after free in ContextMenuClientImpl.cpp
1229 https://bugs.webkit.org/show_bug.cgi?id=109220
1231 Reviewed by Tony Chang.
1233 ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
1234 by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
1235 to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
1236 causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
1237 spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
1238 ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
1239 use after free. The fix is to save a copy of the DocumentMarker before changing selection.
1241 * src/ContextMenuClientImpl.cpp:
1242 (WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
1243 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.
1245 2013-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
1247 Unreviewed. Rolled Chromium DEPS to r183552. Requested by
1248 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
1252 2013-02-19 Adrienne Walker <enne@chromium.org>
1254 Unreviewed, rolling out r143382 and r143401.
1255 http://trac.webkit.org/changeset/143382
1256 http://trac.webkit.org/changeset/143401
1257 https://bugs.webkit.org/show_bug.cgi?id=106457
1259 Breaks Chromium win/mac canary compilation
1261 * public/platform/WebKitPlatformSupport.h:
1263 (WebKitPlatformSupport):
1264 (WebKit::WebKitPlatformSupport::idbFactory):
1265 (WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
1266 * src/IDBFactoryBackendProxy.cpp:
1267 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1269 2013-02-19 Mark Pilgrim <pilgrim@chromium.org>
1271 [Chromium] Move WebKitPlatformSupport declaration to Platform.h
1272 https://bugs.webkit.org/show_bug.cgi?id=110262
1274 Reviewed by Adam Barth.
1276 In preparation for removing WebKitPlatformSupport.h entirely (once
1277 downstream references to that file have been updated). Part of a
1278 larger refactoring series; see tracking bug 82948.
1280 * public/platform/WebKitPlatformSupport.h:
1282 2013-02-19 Mark Pilgrim <pilgrim@chromium.org>
1284 [Chromium] Remove idbFactory from WebKitPlatformSupport
1285 https://bugs.webkit.org/show_bug.cgi?id=106457
1287 Reviewed by Kentaro Hara.
1289 Now that https://codereview.chromium.org/12230054 has landed, the
1290 idbFactory method is no longer needed. (Embedders must now call
1291 the new setIDBFactory method upon initialization.) Part of a
1292 larger refactoring series; see tracking bug 82948.
1294 * public/platform/WebKitPlatformSupport.h:
1296 * src/IDBFactoryBackendProxy.cpp:
1297 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
1299 2013-02-19 Alexandre Elias <aelias@chromium.org>
1301 [chromium] Fix races in double-tap zoom minimum scale policy
1302 https://bugs.webkit.org/show_bug.cgi?id=110183
1304 Reviewed by Adam Barth.
1306 Double-tap zoom on Android is supposed to return to minimum scale
1307 if no pinch zoom occurred since the last double-tap. Because both
1308 pinch zoom and the result of double-tap zoom gets passed in from CC
1309 via applyScrollAndScale, this logic was brittle and prone to races
1310 depending on when the animation update was received. This patch
1311 keeps track of what the target double-tap scale is to make it more
1314 I also fixed double-tap zoom test mocking to exercise the entire
1315 page scale animation flow (our previous way of testing was hiding the
1316 raciness), and added a new test case in DivAutoZoomMultipleParamsTest.
1318 * src/WebViewImpl.cpp:
1319 (WebKit::WebViewImpl::WebViewImpl):
1320 (WebKit::WebViewImpl::startPageScaleAnimation):
1322 (WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
1323 (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
1324 (WebKit::WebViewImpl::animateZoomAroundPoint):
1325 (WebKit::WebViewImpl::didCommitLoad):
1326 (WebKit::WebViewImpl::applyScrollAndScale):
1327 * src/WebViewImpl.h:
1329 (WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
1330 (WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
1331 (WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
1332 (WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
1333 * tests/WebFrameTest.cpp:
1335 2013-02-19 Joshua Bell <jsbell@chromium.org>
1337 IndexedDB: additional checks on LevelDB decoding
1338 https://bugs.webkit.org/show_bug.cgi?id=109711
1340 Reviewed by Tony Chang.
1342 * tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
1344 2013-02-19 Jochen Eisinger <jochen@chromium.org>
1346 [chromium] fix ScrollAnimatorNoneTest after r143295
1347 https://bugs.webkit.org/show_bug.cgi?id=110189
1349 Reviewed by Nico Weber.
1351 * tests/ScrollAnimatorNoneTest.cpp:
1352 (MockScrollableArea):
1354 2013-02-18 Simon Fraser <simon.fraser@apple.com>
1356 Clean up the boolean argument to visibleContentRect
1357 https://bugs.webkit.org/show_bug.cgi?id=110167
1359 Reviewed by Simon Fraser.
1361 Replace the boolean argument to visibleContentRect() with
1364 * src/ChromeClientImpl.cpp:
1365 (WebKit::ChromeClientImpl::popupOpened):
1367 2013-02-18 Sheriff Bot <webkit.review.bot@gmail.com>
1369 Unreviewed. Rolled Chromium DEPS to r183105. Requested by
1370 thakis_ via sheriffbot.
1374 2013-02-18 Nico Weber <thakis@chromium.org>
1376 [chromium] Remove ahem_path from WebKit.gyp
1377 https://bugs.webkit.org/show_bug.cgi?id=110111
1379 Reviewed by Jochen Eisinger.
1381 It's only used in DumpRenderTree.gyp, and that file defines its own
1382 copy of this variable.
1386 2013-02-18 Laszlo Gombos <l.gombos@samsung.com>
1388 Move ENABLE macros for WebCore out from Platform.h
1389 https://bugs.webkit.org/show_bug.cgi?id=105735
1391 Move the chromium specific WebCore ENABLE macro definitions
1392 from Platform.h to features.gypi.
1394 Reviewed by Darin Adler and Benjamin Poulain.
1396 * features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1.
1398 2013-02-15 Alec Flett <alecflett@chromium.org>
1400 IndexedDB: Stub out SharedBuffer version of get()
1401 https://bugs.webkit.org/show_bug.cgi?id=108993
1403 Reviewed by Darin Fisher.
1405 All asynchronous get()-like calls go through WebIDBCallbacks,
1406 so this includes both get() and cursor callbacks.
1408 * public/WebIDBCallbacks.h:
1409 (WebKit::WebIDBCallbacks::onSuccess):
1410 (WebKit::WebIDBCallbacks::onSuccessWithPrefetch):
1412 2013-02-15 Alec Flett <alecflett@chromium.org>
1414 IndexedDB: fix chromium windows bustage
1415 https://bugs.webkit.org/show_bug.cgi?id=109970
1417 Unreviewed build fix for Chromium Windows.
1419 * tests/IDBDatabaseBackendTest.cpp:
1421 2013-02-15 Alec Flett <alecflett@chromium.org>
1423 IndexedDB: Implement SharedBuffer version of put()
1424 https://bugs.webkit.org/show_bug.cgi?id=109092
1426 Reviewed by Adam Barth.
1428 Implement SharedBuffer/WebData version of
1429 IDBDatabaseBackendInterface::put, and put
1430 temporary scaffolding in until chrome is ready.
1432 * src/IDBDatabaseBackendProxy.cpp:
1433 (WebKit::IDBDatabaseBackendProxy::put):
1434 * src/IDBDatabaseBackendProxy.h:
1435 (IDBDatabaseBackendProxy):
1436 * src/WebIDBDatabaseImpl.cpp:
1437 (WebKit::WebIDBDatabaseImpl::put):
1439 * src/WebIDBDatabaseImpl.h:
1440 (WebIDBDatabaseImpl):
1441 * tests/IDBDatabaseBackendTest.cpp:
1443 2013-02-15 Alexandre Elias <aelias@chromium.org>
1445 [chromium] WebInputEventBuilders should not reverse page scale
1446 https://bugs.webkit.org/show_bug.cgi?id=109901
1448 Reviewed by James Robinson.
1450 Though in theory logical that if WebInputEvent -> PlatformEvent
1451 conversions divide by page scale, then the reverse builders should
1452 multiply, in reality the only user of the reverse builders is
1453 plugins which expect the same coordinate space as WebCore.
1455 * src/WebInputEventConversion.cpp:
1456 (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
1457 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
1458 (WebKit::addTouchPoints):
1459 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
1460 * tests/WebInputEventConversionTest.cpp:
1463 2013-02-15 Anders Carlsson <andersca@apple.com>
1465 Remove const from a bunch of StorageArea member functions
1466 https://bugs.webkit.org/show_bug.cgi?id=109957
1468 Reviewed by Beth Dakin.
1470 Update for WebCore changes.
1472 * src/StorageAreaProxy.cpp:
1473 (WebCore::StorageAreaProxy::length):
1474 (WebCore::StorageAreaProxy::key):
1475 (WebCore::StorageAreaProxy::getItem):
1476 (WebCore::StorageAreaProxy::contains):
1477 (WebCore::StorageAreaProxy::canAccessStorage):
1478 (WebCore::StorageAreaProxy::memoryBytesUsedByCache):
1479 * src/StorageAreaProxy.h:
1482 2013-02-15 Keishi Hattori <keishi@webkit.org>
1484 PagePopupController.formatMonth should support short month format
1485 https://bugs.webkit.org/show_bug.cgi?id=109530
1487 Reviewed by Kent Tamura.
1489 * tests/LocaleMacTest.cpp:
1490 (LocaleMacTest::formatMonth):
1493 2013-02-15 Keishi Hattori <keishi@webkit.org>
1495 Add setValue and closePopup methods to PagePopupController
1496 https://bugs.webkit.org/show_bug.cgi?id=109897
1498 Reviewed by Kent Tamura.
1500 * src/ColorChooserPopupUIController.cpp:
1501 (WebKit::ColorChooserPopupUIController::setValue):
1503 * src/ColorChooserPopupUIController.h:
1504 (ColorChooserPopupUIController):
1505 * src/DateTimeChooserImpl.cpp:
1506 (WebKit::DateTimeChooserImpl::setValueAndClosePopup): Use setValue and closePopup.
1508 (WebKit::DateTimeChooserImpl::setValue):
1509 (WebKit::DateTimeChooserImpl::closePopup):
1510 * src/DateTimeChooserImpl.h:
1511 (DateTimeChooserImpl):
1513 2013-02-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
1515 Simplify hitTestResultAtPoint and nodesFromRect APIs
1516 https://bugs.webkit.org/show_bug.cgi?id=95720
1518 Reviewed by Julien Chaffraix.
1520 Update calls to new API.
1522 * src/ContextMenuClientImpl.cpp:
1523 (WebKit::selectMisspelledWord):
1524 * src/FrameLoaderClientImpl.cpp:
1525 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
1526 * src/WebFrameImpl.cpp:
1527 (WebKit::WebFrameImpl::characterIndexForPoint):
1528 * src/WebPluginContainerImpl.cpp:
1529 (WebKit::WebPluginContainerImpl::isRectTopmost):
1530 * src/WebViewImpl.cpp:
1531 (WebKit::WebViewImpl::handleMouseDown):
1532 (WebKit::WebViewImpl::computeBlockBounds):
1533 (WebKit::WebViewImpl::bestTouchLinkNode):
1534 (WebKit::WebViewImpl::hitTestResultForWindowPos):
1536 2013-02-14 Vsevolod Vlasov <vsevik@chromium.org>
1538 Unreviewed chromium test fix: incorrect field was used for UISourceCode url.
1541 (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
1542 (.TestSuite.prototype.uiSourceCodesToString_):
1544 2013-02-14 David Trainor <dtrainor@chromium.org>
1546 [chromium] No triggering autofill on unfocus
1547 https://bugs.webkit.org/show_bug.cgi?id=109735
1549 Reviewed by James Robinson.
1551 Need to notify the autofill client to not process text changes when we're setting
1552 focus to false and are trying to commit a composition.
1554 * public/WebAutofillClient.h:
1555 (WebAutofillClient):
1556 (WebKit::WebAutofillClient::setIgnoreTextChanges):
1557 (WebKit::WebAutofillClient::~WebAutofillClient):
1558 * src/WebViewImpl.cpp:
1559 (WebKit::WebViewImpl::setFocus):
1560 * tests/WebViewTest.cpp:
1562 2013-02-14 Alexandre Elias <aelias@chromium.org>
1564 [chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
1565 https://bugs.webkit.org/show_bug.cgi?id=109671
1567 Reviewed by James Robinson.
1569 My patch 142571 broke a bunch of things in handleGestureEvent that
1570 assumed the event came in scaled, most notably tap highlight and
1571 double-tap zoom. Switch those to PlatformGestureEvent.
1573 142808 was an earlier version of this patch that was reverted
1574 due to fling events asserting they can't be converted to
1575 PlatformGestureEvent. This version moves fling earlier in the
1576 function to avoid that.
1578 * src/WebViewImpl.cpp:
1579 (WebKit::WebViewImpl::handleGestureEvent):
1580 (WebKit::WebViewImpl::bestTapNode):
1581 (WebKit::WebViewImpl::enableTapHighlight):
1582 * src/WebViewImpl.h:
1584 * tests/LinkHighlightTest.cpp:
1587 2013-02-14 Dirk Pranke <dpranke@chromium.org>
1589 Unreviewed, rolling out r142901.
1590 http://trac.webkit.org/changeset/142901
1592 r182258 introduces a dependency on chrome.gyp that breaks the win
1593 build. Rolling back to r182150 until I can work up a workaround.
1597 2013-02-14 Dirk Pranke <dpranke@chromium.org>
1599 Unreviewed, chromium roll 182150 -> 182448
1603 2013-02-14 Mark Pilgrim <pilgrim@chromium.org>
1605 [Chromium] Move PlatformMessagePortChannel to WebCore
1606 https://bugs.webkit.org/show_bug.cgi?id=109845
1608 Reviewed by Adam Barth.
1610 Part of a larger refactoring series; see tracking bug 106829.
1613 * src/PlatformMessagePortChannel.cpp: Removed.
1614 * src/PlatformMessagePortChannel.h: Removed.
1615 * src/SharedWorkerRepository.cpp:
1616 * src/WebDOMMessageEvent.cpp:
1617 * src/WebFrameImpl.cpp:
1618 * src/WebSharedWorkerImpl.cpp:
1619 * src/WebWorkerClientImpl.cpp:
1621 2013-02-14 Min Qin <qinmin@chromium.org>
1623 Passing alpha to DeferredImageDecoder once decoding completes
1624 https://bugs.webkit.org/show_bug.cgi?id=108892
1626 Reviewed by Stephen White.
1628 Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.
1630 * tests/ImageFrameGeneratorTest.cpp:
1631 (WebCore::MockImageDecoderFactory::create):
1633 * tests/MockImageDecoder.h:
1634 (WebCore::MockImageDecoder::MockImageDecoder):
1635 (WebCore::MockImageDecoder::setFrameHasAlpha):
1637 (WebCore::MockImageDecoder::frameHasAlphaAtIndex):
1639 2013-02-08 Andrey Kosyakov <caseq@chromium.org>
1641 Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
1642 https://bugs.webkit.org/show_bug.cgi?id=109192
1644 Reviewed by Pavel Feldman.
1646 - expose frame and compositing insturmentation methods on WebDevToolsAgent;
1647 - temporarily route them from WebViewImpl to WebDevToolsAgent;
1649 * public/WebDevToolsAgent.h:
1651 * src/WebDevToolsAgentImpl.cpp:
1652 (WebKit::WebDevToolsAgentImpl::didBeginFrame):
1654 (WebKit::WebDevToolsAgentImpl::didCancelFrame):
1655 (WebKit::WebDevToolsAgentImpl::willComposite):
1656 (WebKit::WebDevToolsAgentImpl::didComposite):
1657 * src/WebDevToolsAgentImpl.h:
1658 (WebDevToolsAgentImpl):
1659 * src/WebViewImpl.cpp:
1660 (WebKit::WebViewImpl::instrumentBeginFrame):
1661 (WebKit::WebViewImpl::instrumentCancelFrame):
1662 (WebKit::WebViewImpl::didBeginFrame):
1663 (WebKit::WebViewImpl::willCommit):
1665 2013-02-14 Mikhail Naganov <mnaganov@chromium.org>
1667 [Chromium] Add a setting to control scaling content to fit viewport
1668 https://bugs.webkit.org/show_bug.cgi?id=109584
1670 Adds a setting called 'initializeAtMinimumPageScale'. By default,
1671 it is set to 'true' which corresponds to Chrome on Android behavior--
1672 adjust the page scale to make the content fit into the viewport
1673 by width. When set to false, the setting instructs ChromeClientImpl to
1674 set page scale to 1.0, unless the scale value is set by the page
1675 in the viewport meta-tag.
1677 Reviewed by Adam Barth.
1679 * public/WebSettings.h:
1680 * src/ChromeClientImpl.cpp:
1681 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1682 * src/WebSettingsImpl.cpp:
1683 (WebKit::WebSettingsImpl::WebSettingsImpl):
1684 (WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
1686 * src/WebSettingsImpl.h:
1688 (WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
1689 * tests/WebFrameTest.cpp:
1690 * tests/data/viewport-2x-initial-scale.html: Added.
1691 * tests/data/viewport-auto-initial-scale.html: Added.
1693 2013-02-14 Sheriff Bot <webkit.review.bot@gmail.com>
1695 Unreviewed, rolling out r142808.
1696 http://trac.webkit.org/changeset/142808
1697 https://bugs.webkit.org/show_bug.cgi?id=109816
1699 Crashes on chromium webkit canary bots (Requested by atwilson_
1702 * src/WebViewImpl.cpp:
1703 (WebKit::WebViewImpl::handleGestureEvent):
1704 (WebKit::WebViewImpl::bestTouchLinkNode):
1705 (WebKit::WebViewImpl::enableTouchHighlight):
1706 * src/WebViewImpl.h:
1708 * tests/LinkHighlightTest.cpp:
1711 2013-02-14 Sheriff Bot <webkit.review.bot@gmail.com>
1713 Unreviewed, rolling out r142841.
1714 http://trac.webkit.org/changeset/142841
1715 https://bugs.webkit.org/show_bug.cgi?id=109791
1717 Caused webkit_unit_tests to crash on chromium bots. (Requested
1718 by atwilson_ on #webkit).
1720 * tests/GraphicsLayerChromiumTest.cpp:
1721 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1722 * tests/ScrollingCoordinatorChromiumTest.cpp:
1723 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1725 2013-02-13 Max Vujovic <mvujovic@adobe.com>
1727 [CSS Filters] Refactor filter outsets into a class
1728 https://bugs.webkit.org/show_bug.cgi?id=109330
1730 Update FilterOperations unit tests to use new interface for getting filter outsets.
1732 Reviewed by Dean Jackson.
1734 * tests/FilterOperationsTest.cpp:
1737 2013-02-13 Zan Dobersek <zdobersek@igalia.com>
1739 The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
1740 https://bugs.webkit.org/show_bug.cgi?id=109325
1742 Reviewed by Anders Carlsson.
1744 Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
1745 two methods as they're provided by the C++ standard library being used.
1747 * tests/DecimalTest.cpp:
1750 2013-02-13 Alexandre Elias <aelias@chromium.org>
1752 [chromium] Fix scaling in WebViewImpl::handleGestureEvent
1753 https://bugs.webkit.org/show_bug.cgi?id=109671
1755 Reviewed by James Robinson.
1757 My last patch broke a bunch of things in handleGestureEvent that
1758 assumed the event came in scaled, most notably tap highlight and
1759 double-tap zoom. Switch those to PlatformGestureEvent.
1761 * src/WebViewImpl.cpp:
1762 (WebKit::WebViewImpl::handleGestureEvent):
1763 (WebKit::WebViewImpl::bestTapNode):
1764 (WebKit::WebViewImpl::enableTapHighlight):
1765 * src/WebViewImpl.h:
1767 * tests/LinkHighlightTest.cpp:
1770 2013-02-13 Eberhard Graether <egraether@google.com>
1772 chromium: remove CompositorHUDFontAtlas
1773 https://bugs.webkit.org/show_bug.cgi?id=109328
1775 Reviewed by James Robinson.
1777 After switching the HudLayer to use skia's font rendering the
1778 CompositorHUDFontAtlas has become obsolete. This change removes
1779 this class and the related WebLayerTreeView API.
1781 * src/WebViewImpl.cpp:
1782 * src/WebViewImpl.h:
1784 2013-02-13 Sheriff Bot <webkit.review.bot@gmail.com>
1786 Unreviewed. Rolled Chromium DEPS to r182150. Requested by
1787 jamesr_ via sheriffbot.
1791 2013-02-13 Sadrul Habib Chowdhury <sadrul@chromium.org>
1793 [chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
1794 https://bugs.webkit.org/show_bug.cgi?id=109611
1796 The deltas in mousewheel events generated by track can be accelerated (e.g. when
1797 scrolling repeatedly). Keep track of the ratio of the acceleration since that is
1798 useful for some tasks (e.g. overflow navigation gesture).
1800 Reviewed by Adam Barth.
1802 * public/WebInputEvent.h:
1803 (WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
1804 * src/WebInputEvent.cpp:
1805 (SameSizeAsWebMouseWheelEvent):
1807 2013-02-12 Yoshifumi Inoue <yosin@chromium.org>
1809 Unreviewed. Build fix for Chromium-Win.
1810 Add #include <functional> for std::bind1st.
1812 * tests/PrerenderingTest.cpp:
1814 2013-02-12 Joshua Bell <jsbell@chromium.org>
1816 [Chromium] IndexedDB/Worker crash during shutdown
1817 https://bugs.webkit.org/show_bug.cgi?id=109467
1819 Reviewed by Tony Chang.
1821 If the message queue has already been terminated, don't bother scheduling
1822 a new error event that will never be delivered. Speculative fix for the
1823 issue, which only repros in multiprocess ports and so far only on some
1826 * src/IDBFactoryBackendProxy.cpp:
1827 (WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.
1829 2013-02-12 Zan Dobersek <zdobersek@igalia.com>
1831 Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
1832 https://bugs.webkit.org/show_bug.cgi?id=109481
1834 Reviewed by Daniel Bates.
1836 The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
1837 back in r120574. There are still occurrences of it in various build systems
1838 which should all be removed as they are useless.
1842 2013-02-12 Jochen Eisinger <jochen@chromium.org>
1844 Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
1845 https://bugs.webkit.org/show_bug.cgi?id=109548
1847 Unreviewed gardening.
1849 * tests/WebFrameTest.cpp:
1851 2013-02-11 James Robinson <jamesr@chromium.org>
1853 [Chromium] Get rid of WebAnimationController
1854 https://bugs.webkit.org/show_bug.cgi?id=109235
1856 Reviewed by Benjamin Poulain.
1858 * public/WebAnimationController.h: Removed.
1859 * public/WebFrame.h:
1861 * src/WebAnimationControllerImpl.cpp: Removed.
1862 * src/WebAnimationControllerImpl.h: Removed.
1863 * src/WebFrameImpl.cpp:
1864 * src/WebFrameImpl.h:
1867 2013-02-11 James Robinson <jamesr@chromium.org>
1869 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
1870 https://bugs.webkit.org/show_bug.cgi?id=109403
1872 Reviewed by Adam Barth.
1874 * tests/GraphicsLayerChromiumTest.cpp:
1875 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1876 * tests/ScrollingCoordinatorChromiumTest.cpp:
1877 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1879 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1881 Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
1882 https://bugs.webkit.org/show_bug.cgi?id=109534
1884 Reviewed by Anders Carlsson.
1886 * src/EditorClientImpl.cpp:
1888 * src/EditorClientImpl.h:
1891 2013-02-11 Alexandre Elias <aelias@chromium.org>
1893 [chromium] Apply page scale to all WebInputEvent types
1894 https://bugs.webkit.org/show_bug.cgi?id=109370
1896 Reviewed by James Robinson.
1898 Previously we only adjusted a few common input event types by page
1899 scale, but in fact almost every position and size in WebInputEvents
1902 I also took the opportunity to change some WebGestureEvent members to
1903 floats (which I checked causes no warnings in Chromium-side code with
1906 New WebInputEventConversionTest: InputEventsScaling
1908 * public/WebInputEvent.h:
1909 (WebKit::WebGestureEvent::WebGestureEvent):
1910 * src/WebInputEventConversion.cpp:
1911 (WebKit::widgetScaleFactor):
1913 (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
1914 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
1915 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1916 (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
1917 (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
1918 (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
1919 (WebKit::addTouchPoints):
1920 (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
1921 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
1922 * src/WebViewImpl.cpp:
1923 (WebKit::WebViewImpl::handleGestureEvent):
1924 (WebKit::WebViewImpl::hasTouchEventHandlersAt):
1925 (WebKit::WebViewImpl::handleInputEvent):
1926 * tests/WebInputEventConversionTest.cpp:
1930 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
1932 Unreviewed, rolling out r142568.
1933 http://trac.webkit.org/changeset/142568
1934 https://bugs.webkit.org/show_bug.cgi?id=109541
1936 Broke the build, won't compile. (Requested by alancutter on
1939 * tests/GraphicsLayerChromiumTest.cpp:
1940 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1941 * tests/ScrollingCoordinatorChromiumTest.cpp:
1942 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1944 2013-02-11 James Robinson <jamesr@chromium.org>
1946 [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
1947 https://bugs.webkit.org/show_bug.cgi?id=109403
1949 Reviewed by Adam Barth.
1951 * tests/GraphicsLayerChromiumTest.cpp:
1952 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1953 * tests/ScrollingCoordinatorChromiumTest.cpp:
1954 (WebKit::FakeWebViewClient::initializeLayerTreeView):
1956 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
1958 Unreviewed. Rolled Chromium DEPS to r181817. Requested by
1959 "James Robinson" <jamesr@chromium.org> via sheriffbot.
1963 2013-02-11 David Grogan <dgrogan@chromium.org>
1965 IndexedDB: Add UnknownError to WebIDBDatabaseException
1966 https://bugs.webkit.org/show_bug.cgi?id=109519
1968 Reviewed by Adam Barth.
1970 * public/WebIDBDatabaseException.h:
1971 * src/AssertMatchingEnums.cpp:
1973 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
1975 Unreviewed. Rolled Chromium DEPS to r181787. Requested by
1976 thakis_ via sheriffbot.
1980 2013-02-11 Nico Weber <thakis@chromium.org>
1982 Remove web intents code
1983 https://bugs.webkit.org/show_bug.cgi?id=109501
1985 Reviewed by Eric Seidel.
1987 See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
1991 * public/WebDeliveredIntentClient.h: Removed.
1992 * public/WebFrame.h:
1995 * public/WebFrameClient.h:
1997 * public/WebIntent.h: Removed.
1998 * public/WebIntentRequest.h: Removed.
1999 * public/WebIntentServiceInfo.h: Removed.
2000 * public/WebRuntimeFeatures.h:
2001 (WebRuntimeFeatures):
2002 * src/DeliveredIntentClientImpl.cpp: Removed.
2003 * src/DeliveredIntentClientImpl.h: Removed.
2004 * src/FrameLoaderClientImpl.cpp:
2005 * src/FrameLoaderClientImpl.h:
2006 (FrameLoaderClientImpl):
2007 * src/WebFrameImpl.cpp:
2008 * src/WebFrameImpl.h:
2011 * src/WebIntent.cpp: Removed.
2012 * src/WebIntentRequest.cpp: Removed.
2013 * src/WebIntentServiceInfo.cpp: Removed.
2014 * src/WebRuntimeFeatures.cpp:
2016 2013-02-11 Florin Malita <fmalita@chromium.org>
2018 Unreviewed. Rolled Chromium DEPS to r181770.
2022 2013-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2024 Unreviewed. Rolled Chromium DEPS to r181742. Requested by
2025 fmalita_ via sheriffbot.
2029 2013-02-11 Rouslan Solomakhin <rouslan@chromium.org>
2031 [Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
2032 https://bugs.webkit.org/show_bug.cgi?id=108513
2034 Reviewed by Tony Chang.
2036 WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
2037 WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
2038 of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
2039 uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
2040 range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
2041 to avoid introducing spaces around misspellings.
2043 * src/WebFrameImpl.cpp:
2044 (WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
2045 * tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
2047 2013-02-11 Alexei Filippov <alph@chromium.org>
2049 Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
2050 https://bugs.webkit.org/show_bug.cgi?id=108653
2052 Reviewed by Yury Semikhatsky.
2054 Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
2055 In fact these two profile types have not too much in common. So put each into its own domain.
2056 It should also help when Profiles panel gets split into several tools.
2057 This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
2058 change the original InspectorProfilerAgent.
2060 * src/WebDevToolsAgentImpl.cpp:
2061 (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
2063 2013-02-11 Abhishek Arya <inferno@chromium.org>
2065 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
2066 https://bugs.webkit.org/show_bug.cgi?id=108981
2068 Reviewed by Eric Seidel.
2070 * src/AutofillPopupMenuClient.cpp:
2071 (WebKit::AutofillPopupMenuClient::getSuggestion):
2072 (WebKit::AutofillPopupMenuClient::getLabel):
2073 (WebKit::AutofillPopupMenuClient::getIcon):
2074 (WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
2075 (WebKit::AutofillPopupMenuClient::valueChanged):
2076 (WebKit::AutofillPopupMenuClient::selectionChanged):
2077 * src/ChromeClientImpl.cpp:
2078 (WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
2080 2013-02-10 James Robinson <jamesr@chromium.org>
2082 [chromium] Enable more of webkit_unit_tests in component builds
2083 https://bugs.webkit.org/show_bug.cgi?id=109369
2085 Reviewed by Darin Fisher.
2087 Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
2088 calling into webkit_support so they work in component builds.
2091 * tests/AssociatedURLLoaderTest.cpp:
2092 * tests/EventListenerTest.cpp:
2093 * tests/FrameTestHelpers.cpp:
2094 (WebKit::FrameTestHelpers::createWebViewAndLoad):
2096 (WebKit::FrameTestHelpers::QuitTask::run):
2098 (WebKit::FrameTestHelpers::runPendingTasks):
2099 * tests/FrameTestHelpers.h:
2101 * tests/ListenerLeakTest.cpp:
2102 * tests/PopupMenuTest.cpp:
2103 * tests/PrerenderingTest.cpp:
2104 * tests/ScrollingCoordinatorChromiumTest.cpp:
2105 (WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
2106 (WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
2107 * tests/URLTestHelpers.cpp:
2108 (WebKit::URLTestHelpers::registerMockedURLLoad):
2109 * tests/WebFrameTest.cpp:
2110 * tests/WebImageTest.cpp:
2112 * tests/WebPageNewSerializerTest.cpp:
2113 * tests/WebPageSerializerTest.cpp:
2114 * tests/WebPluginContainerTest.cpp:
2115 (WebKit::WebPluginContainerTest::TearDown):
2117 * tests/WebViewTest.cpp:
2119 2013-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
2121 Unreviewed. Rolled Chromium DEPS to r181645. Requested by
2122 "James Robinson" <jamesr@chromium.org> via sheriffbot.
2126 2013-02-09 Stephen Chenney <schenney@chromium.org>
2128 Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
2132 2013-02-09 Sheriff Bot <webkit.review.bot@gmail.com>
2134 Unreviewed. Rolled Chromium DEPS to last-known good revision.
2135 Requested by "Stephen Chenney" <schenney@chromium.org> via
2140 2013-02-08 Kent Tamura <tkent@chromium.org>
2142 [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
2143 https://bugs.webkit.org/show_bug.cgi?id=109272
2145 Reviewed by Kentaro Hara.
2147 We enabled this flag for desktop Chromium, but disabled the feature by a
2148 runtime flag. We disables the compile flag too because we have no plan
2149 to ship it in near future.
2151 * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
2153 2013-02-08 Stephen Chenney <schenney@chromium.org>
2155 Remove Skia code suppressions
2157 Unreviewed enabling of existing optimizations
2159 Removing all skia_webkit.gyp code suppressions and adding expectations
2164 2013-02-08 Dan Carney <dcarney@google.com>
2166 [v8] isolate parameter added to all v8::peristent calls
2167 https://bugs.webkit.org/show_bug.cgi?id=109268
2169 Reviewed by Kentaro Hara.
2171 * tests/WebFrameTest.cpp:
2173 2013-02-07 Kent Tamura <tkent@chromium.org>
2175 [Chromium-Android] Disable input[type=datetime]
2176 https://bugs.webkit.org/show_bug.cgi?id=107614
2178 Reviewed by Kentaro Hara.
2181 http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
2184 Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
2185 We enable it for non-Android ports but the runtime flag for it is
2186 disabled by default. The runtime flag is enabled only in DumpRenderTree.
2188 2013-02-07 Terry Anderson <tdanderson@chromium.org>
2190 [chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
2191 https://bugs.webkit.org/show_bug.cgi?id=108719
2193 Reviewed by Eric Seidel.
2195 In the event of a main-thread touch fling, dispatch a series of
2196 GestureScrollUpdateWithoutPropagation events defined in
2197 https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
2198 GestureScrollUpdate events) so that the fling does not
2199 propagate to enclosing scrollables.
2201 * src/WebViewImpl.cpp:
2202 (WebKit::WebViewImpl::scrollBy):
2204 2013-02-07 Kent Tamura <tkent@chromium.org>
2206 [Chromium] Add a flag to enable native form validation message
2207 https://bugs.webkit.org/show_bug.cgi?id=109134
2209 Reviewed by Adam Barth.
2211 * public/WebRuntimeFeatures.h:
2212 (WebRuntimeFeatures): Add enableNativeValidationMessage and
2213 isNativeValidationMessageEnabled.
2214 * src/WebRuntimeFeatures.cpp:
2215 (WebKit): Add nativeValidationMessageEnabled.
2216 (WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
2217 (WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
2218 * src/WebViewImpl.cpp:
2219 (WebKit::WebViewImpl::WebViewImpl):
2220 Fill Page::PageClients::validationMessageClient if the flag is true.
2222 2013-02-07 Eberhard Graether <egraether@google.com>
2224 Web Inspector: Add settings checkbox for composited layer borders
2225 https://bugs.webkit.org/show_bug.cgi?id=109096
2227 Reviewed by Pavel Feldman.
2229 This change adds a checkbox to show composited layer borders to the WebInspector's
2230 rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
2231 is visible if InspectorClient::canShowDebugBorders() returns true.
2233 * src/InspectorClientImpl.cpp:
2234 (WebKit::InspectorClientImpl::canShowDebugBorders):
2236 (WebKit::InspectorClientImpl::setShowDebugBorders):
2237 * src/InspectorClientImpl.h:
2238 (InspectorClientImpl):
2239 * src/WebViewImpl.cpp:
2240 (WebKit::WebViewImpl::WebViewImpl):
2241 (WebKit::WebViewImpl::setShowDebugBorders):
2243 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2244 * src/WebViewImpl.h:
2246 2013-02-07 Stephen White <senorblanco@chromium.org>
2248 Unreviewed. Rolled DEPS.
2252 2013-02-07 David Trainor <dtrainor@chromium.org>
2254 Add null check to editable in moveCaretSelectionTowardsWindowPoint
2255 https://bugs.webkit.org/show_bug.cgi?id=108962
2257 Reviewed by Eric Seidel.
2259 * src/WebFrameImpl.cpp:
2260 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
2261 * tests/WebFrameTest.cpp:
2263 2013-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
2265 Unreviewed. Rolled Chromium DEPS to r180752. Requested by
2266 thakis_ via sheriffbot.
2270 2013-02-06 Terry Anderson <tdanderson@chromium.org>
2272 Add support for gesture scroll events that do not propagate to enclosing scrollables
2273 https://bugs.webkit.org/show_bug.cgi?id=108849
2275 Reviewed by Antonio Gomes.
2277 Define the new event type GestureScrollUpdateWithoutPropagation.
2279 * public/WebInputEvent.h:
2280 (WebKit::WebInputEvent::isGestureEventType):
2281 * src/PageWidgetDelegate.cpp:
2282 (WebKit::PageWidgetDelegate::handleInputEvent):
2283 * src/WebInputEventConversion.cpp:
2284 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2285 * src/WebPluginContainerImpl.cpp:
2286 * src/WebPopupMenuImpl.cpp:
2287 (WebKit::WebPopupMenuImpl::handleInputEvent):
2288 * src/WebViewImpl.cpp:
2289 (WebKit::WebViewImpl::handleGestureEvent):
2291 2013-02-06 Alexandre Elias <aelias@chromium.org>
2293 Make ScrollView::paint() clip by visibleContentRect
2294 https://bugs.webkit.org/show_bug.cgi?id=108888
2296 Reviewed by Levi Weintraub.
2298 When applyPageScaleFactorInCompositor or fixedVisibleContentRect
2299 are used, frameRect() and visibleContentRect(true).size() are
2300 no longer synonyms, and the latter is the one that should be
2301 used for clipping paints.
2303 New WebFrameTest: pageScaleFactorScalesPaintClip.
2305 * tests/WebFrameTest.cpp:
2307 2013-02-06 Sheriff Bot <webkit.review.bot@gmail.com>
2309 Unreviewed, rolling out r142025.
2310 http://trac.webkit.org/changeset/142025
2311 https://bugs.webkit.org/show_bug.cgi?id=109091
2313 broke the build (Requested by tdanderson on #webkit).
2315 * public/WebInputEvent.h:
2316 (WebKit::WebInputEvent::isGestureEventType):
2317 * src/PageWidgetDelegate.cpp:
2318 (WebKit::PageWidgetDelegate::handleInputEvent):
2319 * src/WebInputEventConversion.cpp:
2320 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2321 * src/WebPluginContainerImpl.cpp:
2322 * src/WebPopupMenuImpl.cpp:
2323 (WebKit::WebPopupMenuImpl::handleInputEvent):
2324 * src/WebViewImpl.cpp:
2325 (WebKit::WebViewImpl::handleGestureEvent):
2327 2013-02-06 Daniel Cheng <dcheng@google.com>
2329 [chromium] Remove "config.h" header from WebUnitTests.cpp
2330 https://bugs.webkit.org/show_bug.cgi?id=108966
2332 Reviewed by Tony Chang.
2334 This file includes headers from base/ in Chromium, and config.h
2335 conflicts with base/logging.h. Rather than teaching certain files in
2336 base/ not to #include base/logging.h, remove the config.h include
2337 here. The ASSERT isn't really necessary, as attempting to run a null
2338 test suite won't go very far anyway.
2340 * tests/WebUnitTests.cpp:
2341 (WebKit::RunAllUnitTests):
2343 2013-02-06 Terry Anderson <tdanderson@chromium.org>
2345 Add support for gesture scroll events that do not propagate to enclosing scrollables
2346 https://bugs.webkit.org/show_bug.cgi?id=108849
2348 Reviewed by Antonio Gomes.
2350 Define the new event type GestureScrollUpdateWithoutPropagation.
2352 * public/WebInputEvent.h:
2353 (WebKit::WebInputEvent::isGestureEventType):
2354 * src/PageWidgetDelegate.cpp:
2355 (WebKit::PageWidgetDelegate::handleInputEvent):
2356 * src/WebInputEventConversion.cpp:
2357 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2358 * src/WebPluginContainerImpl.cpp:
2359 * src/WebPopupMenuImpl.cpp:
2360 (WebKit::WebPopupMenuImpl::handleInputEvent):
2361 * src/WebViewImpl.cpp:
2362 (WebKit::WebViewImpl::handleGestureEvent):
2364 2013-02-06 Chris Hopman <cjhopman@chromium.org>
2366 [Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
2367 https://bugs.webkit.org/show_bug.cgi?id=108667
2369 Reviewed by Darin Fisher.
2371 WebWidget::selectionBounds() returns the anchor and focus of the
2372 selection. This matches the arguments to WebFrame::selectRange().
2373 Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
2374 anchor/focus to start/end.
2376 * public/WebWidget.h:
2378 (WebKit::WebWidget::isSelectionAnchorFirst):
2379 * src/WebViewImpl.cpp:
2380 (WebKit::WebViewImpl::isSelectionAnchorFirst):
2382 * src/WebViewImpl.h:
2383 * tests/WebViewTest.cpp:
2385 2013-02-06 Alec Flett <alecflett@chromium.org>
2387 IndexedDB: Stub out SharedBuffer version of put()
2388 https://bugs.webkit.org/show_bug.cgi?id=108986
2390 Reviewed by Darin Fisher.
2392 This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
2394 * public/WebIDBDatabase.h:
2396 (WebKit::WebIDBDatabase::put):
2398 2013-02-06 Stephen Chenney <schenney@chromium.org>
2400 Add Skia code suppression flags to WebKit skia.gyp
2404 This is step one in removing these flags. First we get them into
2405 WebKit, then we can remove them from Chrome.
2409 2013-02-06 Mike West <mkwst@chromium.org>
2411 Add an ENABLE_NOSNIFF feature flag.
2412 https://bugs.webkit.org/show_bug.cgi?id=109029
2414 Reviewed by Jochen Eisinger.
2416 This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
2417 when processing script and other resource types.
2421 2013-02-05 David Dorwin <ddorwin@chromium.org>
2423 [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
2424 https://bugs.webkit.org/show_bug.cgi?id=108989
2426 Reviewed by Kent Tamura.
2428 * src/WebMediaPlayerClientImpl.cpp:
2429 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
2431 2013-02-04 Kentaro Hara <haraken@chromium.org>
2433 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
2434 https://bugs.webkit.org/show_bug.cgi?id=108909
2436 Reviewed by Adam Barth.
2438 No tests. No change in behavior.
2440 * src/WebBindings.cpp:
2441 (WebKit::WebBindings::toV8Value):
2443 2013-02-05 Kentaro Hara <haraken@chromium.org>
2445 [V8] Make an Isolate parameter mandatory in HasInstance()
2446 https://bugs.webkit.org/show_bug.cgi?id=108917
2448 Reviewed by Adam Barth.
2450 Because these methods do not have an Isolate, we have to call
2451 v8::Isolate::GetCurrent().
2453 No tests. No change in behavior.
2455 * src/WebArrayBuffer.cpp:
2456 (WebKit::WebArrayBuffer::createFromV8Value):
2457 * src/WebArrayBufferView.cpp:
2458 (WebKit::WebArrayBufferView::createFromV8Value):
2459 * src/WebBindings.cpp:
2460 (WebKit::getRangeImpl):
2461 (WebKit::getNodeImpl):
2462 (WebKit::getElementImpl):
2463 (WebKit::getArrayBufferImpl):
2464 (WebKit::getArrayBufferViewImpl):
2465 (WebKit::WebBindings::getRange):
2466 (WebKit::WebBindings::getArrayBuffer):
2467 (WebKit::WebBindings::getArrayBufferView):
2468 (WebKit::WebBindings::getNode):
2469 (WebKit::WebBindings::getElement):
2471 2013-02-05 Dana Jansens <danakj@chromium.org>
2473 [chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
2474 https://bugs.webkit.org/show_bug.cgi?id=107776
2476 Reviewed by James Robinson.
2479 * src/WebGraphicsContext3D.cpp: Removed.
2481 2013-02-05 Mark Lam <mark.lam@apple.com>
2483 Introduced back-end database classes + a few small fixes.
2484 https://bugs.webkit.org/show_bug.cgi?id=108759.
2486 Reviewed by Brady Eidson.
2488 * src/DatabaseObserver.cpp:
2489 (WebCore::DatabaseObserver::databaseOpened):
2490 (WebCore::DatabaseObserver::databaseModified):
2491 (WebCore::DatabaseObserver::databaseClosed):
2493 2013-02-05 Adam Barth <abarth@webkit.org>
2495 DumpRenderTree should be able to enable the threaded parser
2496 https://bugs.webkit.org/show_bug.cgi?id=108970
2498 Reviewed by Eric Seidel.
2500 * public/WebSettings.h:
2501 * src/WebSettingsImpl.cpp:
2502 (WebKit::WebSettingsImpl::setThreadedHTMLParser):
2504 * src/WebSettingsImpl.h:
2507 2013-02-05 Sami Kyostila <skyostil@chromium.org>
2509 [chromium] Make overlay layers slow-scrolling
2510 https://bugs.webkit.org/show_bug.cgi?id=108957
2512 Reviewed by James Robinson.
2514 Since overlay layers get inserted on top of everything else, we must
2515 mark them slow-scrolling to prevent all scroll input events to the rest
2516 of the page from getting blocked. This is also more correct because
2517 generally the overlay contents need to be repainted whenever the scroll
2518 offset changes, and with this patch the painting happens in sync with
2521 2013-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
2523 Unreviewed, rolling out r141896.
2524 http://trac.webkit.org/changeset/141896
2525 https://bugs.webkit.org/show_bug.cgi?id=108956
2527 crashes indexdb security tests (Requested by gavinp on
2530 * public/platform/WebKitPlatformSupport.h:
2532 (WebKitPlatformSupport):
2533 (WebKit::WebKitPlatformSupport::idbFactory):
2534 * src/IDBFactoryBackendProxy.cpp:
2535 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
2537 2013-02-05 Mark Pilgrim <pilgrim@chromium.org>
2539 [Chromium] Remove idbFactory from WebKitPlatformSupport
2540 https://bugs.webkit.org/show_bug.cgi?id=106457
2542 Reviewed by Adam Barth.
2544 Now that https://codereview.chromium.org/12181010/ has landed, the
2545 idbFactory method is no longer needed. (Embedders must now call
2546 the new setIDBFactory method upon initialization.) Part of a
2547 larger refactoring series; see tracking bug 82948.
2549 * public/platform/WebKitPlatformSupport.h:
2551 * src/IDBFactoryBackendProxy.cpp:
2552 (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
2554 2013-02-05 Kentaro Hara <haraken@chromium.org>
2556 Unreviewed, rolling out r141865.
2557 http://trac.webkit.org/changeset/141865
2558 https://bugs.webkit.org/show_bug.cgi?id=108909
2560 webkit unit tests are broken
2562 * src/WebBindings.cpp:
2563 (WebKit::WebBindings::toV8Value):
2565 2013-02-05 Kentaro Hara <haraken@chromium.org>
2567 [V8] Reduce usage of deprecatedString() and deprecatedInteger()
2568 https://bugs.webkit.org/show_bug.cgi?id=108909
2570 Reviewed by Adam Barth.
2572 No tests. No change in behavior.
2574 * src/WebBindings.cpp:
2575 (WebKit::WebBindings::toV8Value):
2577 2013-02-04 Sheriff Bot <webkit.review.bot@gmail.com>
2579 Unreviewed. Rolled Chromium DEPS to r180583. Requested by
2580 "Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
2584 2013-02-04 James Simonsen <simonjam@chromium.org>
2586 [Chromium] Add a signal for when the body is inserted in the document
2587 https://bugs.webkit.org/show_bug.cgi?id=108725
2589 Reviewed by Adam Barth.
2591 * public/WebFrameClient.h:
2593 (WebKit::WebFrameClient::willInsertBody):
2594 * src/FrameLoaderClientImpl.cpp:
2595 (WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
2597 * src/FrameLoaderClientImpl.h:
2598 (FrameLoaderClientImpl):
2599 * tests/WebFrameTest.cpp:
2601 2013-02-04 Chris Hopman <cjhopman@chromium.org>
2603 Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
2604 https://bugs.webkit.org/show_bug.cgi?id=107850
2606 Reviewed by Ojan Vafai.
2608 On Android, EditingBehavior::shouldMoveCaret[...] controls the
2609 behavior of insertion handles. This change adds a new Android specific
2610 editing behavior type so that we can change these settings independent
2611 of behavior for other platforms.
2613 * public/WebSettings.h:
2614 * src/AssertMatchingEnums.cpp:
2615 Just add the corresponding assertion for the new editing behavior.
2617 * public/WebSettings.h:
2618 * src/AssertMatchingEnums.cpp:
2620 * tests/WebFrameTest.cpp:
2621 * tests/data/move_caret.html: Added.
2622 Add a test that moveCaretTowardsWindowPoint works as expected on
2625 2013-01-31 Kentaro Hara <haraken@chromium.org>
2627 Implement WheelEvent::deltaMode
2628 https://bugs.webkit.org/show_bug.cgi?id=108455
2630 Reviewed by Adam Barth.
2632 * src/WebInputEventConversion.cpp:
2633 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
2635 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
2637 [Chromium] Move WorkerContextProxy to WebCore
2638 https://bugs.webkit.org/show_bug.cgi?id=108847
2640 Reviewed by Adam Barth.
2642 Part of a larger refactoring series; see tracking bug 106829.
2646 (WebKit::initializeWithoutV8):
2647 * src/WorkerContextProxy.cpp: Removed.
2649 2013-02-04 Abhishek Arya <inferno@chromium.org>
2651 Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
2652 https://bugs.webkit.org/show_bug.cgi?id=108668
2654 Reviewed by Eric Seidel.
2656 * src/ContextFeaturesClientImpl.cpp:
2657 (WebKit::ContextFeaturesCache::entryFor):
2658 * src/WebFrameImpl.cpp:
2659 (WebKit::WebFrameImpl::selectFindMatch):
2661 2013-02-04 Mark Pilgrim <pilgrim@chromium.org>
2663 [Chromium] Move IDBFactoryBackendInterface to WebCore
2664 https://bugs.webkit.org/show_bug.cgi?id=108638
2666 Reviewed by Adam Barth.
2668 Part of a larger refactoring series; see tracking bug 106829.
2671 * src/AssertMatchingEnums.cpp:
2672 * src/IDBFactoryBackendInterface.cpp: Removed.
2673 * src/IDBFactoryBackendProxy.h:
2675 (WebKit::initializeWithoutV8):
2677 2013-02-04 Abhishek Arya <inferno@chromium.org>
2679 Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
2680 https://bugs.webkit.org/show_bug.cgi?id=108688
2682 Reviewed by Eric Seidel.
2684 * src/IDBFactoryBackendProxy.cpp:
2685 (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
2686 (WebKit::getWebFrame):
2687 * src/LocalFileSystemChromium.cpp:
2688 (WebCore::LocalFileSystem::deleteFileSystem):
2689 * src/WebSharedWorkerImpl.cpp:
2690 (WebKit::WebSharedWorkerImpl::connectTask):
2691 (WebKit::resumeWorkerContextTask):
2692 (WebKit::connectToWorkerContextInspectorTask):
2693 (WebKit::reconnectToWorkerContextInspectorTask):
2694 (WebKit::disconnectFromWorkerContextInspectorTask):
2695 (WebKit::dispatchOnInspectorBackendTask):
2697 2013-02-04 Sami Kyostila <skyostil@chromium.org>
2699 Disable -webkit-overflow-scrolling CSS attribute on Chromium
2700 https://bugs.webkit.org/show_bug.cgi?id=108020
2702 Reviewed by James Robinson.
2704 Now that we can automatically promote overflow elements to accelerated
2705 scrolling layers there is no use for the -webkit-overflow-scrolling CSS
2706 attribute any longer on Chromium.
2708 This patch enables composited overflow scrolling in
2709 ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
2710 in non-fast-scrollable.html to become composited, we also need to modify that
2711 test to opt it out of composited scrolling.
2714 * tests/ScrollingCoordinatorChromiumTest.cpp:
2715 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
2717 * tests/data/non-fast-scrollable.html:
2718 * tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
2720 2013-02-03 KwangYong Choi <ky0.choi@samsung.com>
2722 Fix build warning after r141473
2723 https://bugs.webkit.org/show_bug.cgi?id=108782
2725 Reviewed by Kentaro Hara.
2727 Fix -Wunused-parameter build warning.
2729 * src/EditorClientImpl.cpp:
2730 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
2732 2013-02-03 David Dorwin <ddorwin@chromium.org>
2734 [chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
2735 https://bugs.webkit.org/show_bug.cgi?id=108740
2737 Reviewed by Kent Tamura.
2739 The calls to m_widgetClient->show() and setFocus() do not appear to be
2740 necessary, and the former causes problems on at least on platform.
2742 * src/WebHelperPluginImpl.cpp:
2743 (WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
2744 (WebKit::WebHelperPluginImpl::setFocus): Should never be called.
2746 2013-02-02 Michael Nordman <michaeln@google.com>
2748 [chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
2749 This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
2750 sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
2751 in place and in use.
2752 https://bugs.webkit.org/show_bug.cgi?id=108736
2754 Reviewed by Darin Fisher.
2756 * public/WebFileSystemCallbacks.h:
2757 (WebFileSystemCallbacks):
2758 (WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
2760 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
2762 Unreviewed. Rolled Chromium DEPS to r180221. Requested by
2763 "Nico Weber" <thakis@chromium.org> via sheriffbot.
2767 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
2769 Unreviewed. Rolled Chromium DEPS to r180186. Requested by
2770 "Nico Weber" <thakis@chromium.org> via sheriffbot.
2774 2013-02-01 Chris Hopman <cjhopman@chromium.org>
2776 [Chromium] WebWidget::selectionBounds should return the bounds in document space
2777 https://bugs.webkit.org/show_bug.cgi?id=108386
2779 Reviewed by James Robinson.
2781 When in applyPageScaleFactorInCompositor mode, selectionBounds needs
2782 to scale the anchor/focus window points by the pageScaleFactor.
2784 * src/WebViewImpl.cpp:
2785 (WebKit::WebViewImpl::selectionBounds):
2786 (WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
2788 2013-02-01 Dominic Mazzoni <dmazzoni@google.com>
2790 AX: memoize expensive computation during blocks where tree doesn't change
2791 https://bugs.webkit.org/show_bug.cgi?id=106497
2793 Reviewed by Ryosuke Niwa.
2795 Expose two methods to enable and disable caching of
2796 computed WebAccessibilityObject attributes, to speed up
2797 batch read-only operations.
2799 * public/WebAccessibilityObject.h:
2800 (WebAccessibilityObject):
2801 * src/WebAccessibilityObject.cpp:
2802 (WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
2804 (WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
2806 2013-02-01 Fady Samuel <fsamuel@chromium.org>
2808 [Chromium] Expose WebNode::shadowHost()
2809 https://bugs.webkit.org/show_bug.cgi?id=108681
2811 Reviewed by Dimitri Glazkov.
2813 BrowserPlugin needs to be able to check the event listeners attached to
2814 <webview> and so we expose shadowHost to permit it to poke at the webview
2819 (WebKit::WebNode::shadowHost):
2822 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
2824 [Chromium] Ignore punctuation in spellcheck
2825 https://bugs.webkit.org/show_bug.cgi?id=108511
2827 Reviewed by Tony Chang.
2829 * src/ContextMenuClientImpl.cpp:
2830 (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
2831 (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
2833 2013-02-01 Philip Rogers <pdr@google.com>
2835 Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
2836 https://bugs.webkit.org/show_bug.cgi?id=106966
2838 Reviewed by Stephen White.
2840 * tests/DragImageTest.cpp:
2841 (WebCore::TestImage::currentFrameKnownToBeOpaque):
2843 * tests/ImageLayerChromiumTest.cpp:
2844 (WebCore::TestImage::currentFrameKnownToBeOpaque):
2845 * tests/PlatformContextSkiaTest.cpp:
2848 2013-02-01 Nico Weber <thakis@chromium.org>
2850 [chromium] Build webkit with enable_web_intents set to 0.
2851 https://bugs.webkit.org/show_bug.cgi?id=108408
2853 Reviewed by Tony Chang.
2855 I'll then make chromium build fine with that, then switch
2856 enable_web_intents to 0, roll that into webkit, and then
2857 actually remove the code hidden behind this flag.
2859 The features.gypi bit depends on https://codereview.chromium.org/12143002/
2860 and will disable web intents support on android. Since common.gypi
2861 sets enable_web_intents to 0 explicitly, it seems this is currently on
2864 While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
2865 features.gypi completely, it's still set further down the file if
2866 enable_web_intents is on.
2870 * src/WebFrameImpl.cpp:
2872 2013-02-01 Rouslan Solomakhin <rouslan@chromium.org>
2874 [Chromium] Ignore whitespace in spellcheck
2875 https://bugs.webkit.org/show_bug.cgi?id=108510
2877 Reviewed by Ryosuke Niwa.
2879 * src/ContextMenuClientImpl.cpp:
2880 (WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
2882 2013-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
2884 Unreviewed. Rolled Chromium DEPS to r180131. Requested by
2885 "Florin Malita" <fmalita@chromium.org> via sheriffbot.
2889 2013-02-01 Alexis Menard <alexis@webkit.org>
2891 Enable unprefixed CSS transitions by default.
2892 https://bugs.webkit.org/show_bug.cgi?id=108216
2894 Reviewed by Dean Jackson.
2896 Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2897 to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
2898 guard the unprefixing work for CSS Transforms and animations.
2902 2013-02-01 Ken Kania <kkania@chromium.org>
2904 Web Inspector: Add support for handling modal dialogs
2905 https://bugs.webkit.org/show_bug.cgi?id=107883
2907 Reviewed by Pavel Feldman.
2909 Introduce support for being notified when a JavaScript modal dialog
2910 is opening and closing, as well as a new command for accepting or
2911 dismissing the dialog.
2913 * public/WebDevToolsAgent.h:
2914 * src/InspectorClientImpl.cpp:
2915 (WebKit::InspectorClientImpl::handleJavaScriptDialog):
2917 * src/InspectorClientImpl.h:
2918 (InspectorClientImpl):
2919 * src/WebDevToolsAgentImpl.cpp:
2920 (BrowserDataHintStringValues):
2921 (WebKit::WebDevToolsAgentImpl::captureScreenshot):
2922 (WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
2924 (WebKit::browserHintToString):
2925 (WebKit::browserHintFromString):
2926 (WebKit::WebDevToolsAgent::patchWithBrowserData):
2927 * src/WebDevToolsAgentImpl.h:
2928 (WebDevToolsAgentImpl):
2930 2013-02-01 Dan Alcantara <dfalcantara@chromium.org>
2932 Touch disambiguation blacklist is not being queried properly
2933 https://bugs.webkit.org/show_bug.cgi?id=108222
2935 Reviewed by Adam Barth.
2937 TEST=WebFrameTest::DisambiguationPopupBlacklist
2939 Fix the blacklist so that we check it for the right nodes.
2940 Add a test to check that the blacklist is being built and used
2941 correctly. Also update the other DisambiguationPopup tests to
2942 use the new page scale method.
2944 * tests/WebFrameTest.cpp:
2945 * tests/data/disambiguation_popup_blacklist.html: Added.
2947 2013-02-01 Eberhard Graether <egraether@google.com>
2949 [chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
2950 https://bugs.webkit.org/show_bug.cgi?id=108236
2952 Reviewed by Pavel Feldman.
2954 This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
2955 This way the checkboxes only show up for users that can make use of these features.
2957 * src/InspectorClientImpl.cpp:
2958 (WebKit::InspectorClientImpl::canShowFPSCounter):
2959 (WebKit::InspectorClientImpl::canContinuouslyPaint):
2961 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
2963 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
2964 https://bugs.webkit.org/show_bug.cgi?id=107737
2966 Reviewed by Ryosuke Niwa.
2968 * public/WebViewClient.h:
2969 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
2970 Adding a callback to let the WebViewClient know that the composition has been cancelled.
2971 * src/EditorClientImpl.cpp:
2972 (WebKit::EditorClientImpl::respondToChangedSelection):
2973 Adding a call composition if it is no longer valid.
2975 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
2977 [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
2978 https://bugs.webkit.org/show_bug.cgi?id=108543
2980 Reviewed by Ryosuke Niwa.
2982 Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
2984 * src/WebViewImpl.cpp:
2985 (WebKit::WebViewImpl::setCompositionFromExistingText):
2986 * tests/WebViewTest.cpp:
2987 Re-enabling the test
2989 2013-01-31 Hajime Morrita <morrita@google.com>
2991 Unreviewed, followup fix for r141535.
2993 * tests/WebFrameTest.cpp:
2995 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
2997 Unreviewed. Rolled Chromium DEPS to r180023. Requested by
2998 thakis_ via sheriffbot.
3002 2013-01-31 Hajime Morrita <morrita@google.com>
3004 Unreviewed, disabling failing test.
3006 * tests/WebFrameTest.cpp:
3008 2013-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
3010 Unreviewed, rolling out r141479.
3011 http://trac.webkit.org/changeset/141479
3012 https://bugs.webkit.org/show_bug.cgi?id=108564
3014 breaks chromium test (Requested by morrita on #webkit).
3016 * public/WebViewClient.h:
3017 * src/EditorClientImpl.cpp:
3018 (WebKit::EditorClientImpl::respondToChangedSelection):
3020 2013-01-31 Alec Flett <alecflett@chromium.org>
3022 IndexedDB: remove old transaction backend bootstrap code
3023 https://bugs.webkit.org/show_bug.cgi?id=103923
3025 Reviewed by Dimitri Glazkov.
3027 Remove all deprecated WebKit APIs from
3031 * public/WebIDBCallbacks.h:
3033 * public/WebIDBDatabase.h:
3035 * public/WebIDBTransaction.h: Removed.
3036 * public/WebIDBTransactionCallbacks.h: Removed.
3037 * src/AssertMatchingEnums.cpp:
3038 * src/IDBCallbacksProxy.cpp:
3039 * src/IDBDatabaseBackendProxy.cpp:
3040 * src/IDBDatabaseBackendProxy.h:
3041 (IDBDatabaseBackendProxy):
3042 * src/IDBTransactionBackendProxy.cpp: Removed.
3043 * src/IDBTransactionBackendProxy.h: Removed.
3044 * src/IDBTransactionCallbacksProxy.cpp: Removed.
3045 * src/IDBTransactionCallbacksProxy.h: Removed.
3046 * src/WebIDBCallbacksImpl.cpp:
3047 * src/WebIDBDatabaseImpl.cpp:
3049 * src/WebIDBDatabaseImpl.h:
3051 (WebIDBDatabaseImpl):
3052 * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
3053 * src/WebIDBTransactionCallbacksImpl.h: Removed.
3054 * src/WebIDBTransactionImpl.cpp: Removed.
3055 * src/WebIDBTransactionImpl.h: Removed.
3056 * tests/IDBAbortOnCorruptTest.cpp:
3057 * tests/IDBDatabaseBackendTest.cpp:
3059 2013-01-31 Rouslan Solomakhin <rouslan@chromium.org>
3061 [Chromium] Select multi-word misspelling on context click
3062 https://bugs.webkit.org/show_bug.cgi?id=108509
3064 Reviewed by Tony Chang.
3066 * src/ContextMenuClientImpl.cpp:
3068 (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
3069 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
3071 2013-01-31 Florin Malita <fmalita@chromium.org>
3073 [Chromium] Unreviewed gardening.
3075 WebViewTest.SetCompositionFromExistingText failing after r141479.
3077 * tests/WebViewTest.cpp:
3079 2013-01-31 Alexandre Elias <aelias@chromium.org>
3081 [chromium] Rework page scale factor limits initialization
3082 https://bugs.webkit.org/show_bug.cgi?id=108446
3084 Reviewed by James Robinson.
3086 When loading a page with viewportEnabled, both the limits
3087 specified by the viewport tag and the content width need to be
3088 considered before we initialize the minimum page scale (and
3089 pageScaleFactor itself usually to the same value). The timing has
3090 proven tricky to get correct.
3092 This patch simplifies the flow by computing the
3093 limits only at the end of layouts and at no other time. In combination
3094 with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
3095 needsLayout() appropriately, this results in a more robust and easy
3096 to understand sequence.
3098 Fixes FixedLayoutInitializeAtMinimumPageScale test.
3100 * src/ChromeClientImpl.cpp:
3101 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
3102 * src/WebViewImpl.cpp:
3103 (WebKit::WebViewImpl::WebViewImpl):
3104 (WebKit::WebViewImpl::resize):
3105 (WebKit::WebViewImpl::setPageScaleFactorLimits):
3106 (WebKit::WebViewImpl::computePageScaleFactorLimits):
3107 (WebKit::WebViewImpl::layoutUpdated):
3108 (WebKit::WebViewImpl::didChangeContentsSize):
3109 * src/WebViewImpl.h:
3110 (WebKit::WebViewImpl::setInitialPageScaleFactor):
3112 * tests/WebFrameTest.cpp:
3114 2013-01-31 Aurimas Liutikas <aurimas@chromium.org>
3116 Editor::m_compositionNode not updated on HTMLInputElement::setValue()
3117 https://bugs.webkit.org/show_bug.cgi?id=107737
3119 Reviewed by Ryosuke Niwa.
3121 * public/WebViewClient.h:
3122 (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
3123 Adding a callback to let the WebViewClient know that the composition has been cancelled.
3124 * src/EditorClientImpl.cpp:
3125 (WebKit::EditorClientImpl::respondToChangedSelection):
3126 Adding a call composition if it is no longer valid.
3128 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
3130 [Chromium] Move LocalizedStrings to WebCore
3131 https://bugs.webkit.org/show_bug.cgi?id=108488
3133 Reviewed by Adam Barth.
3135 Part of a larger refactoring series; see tracking bug 106829.
3138 * src/LocalizedStrings.cpp: Removed.
3140 2013-01-31 Enrica Casucci <enrica@apple.com>
3142 WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
3143 https://bugs.webkit.org/show_bug.cgi?id=108396.
3144 <rdar://problem/12920461>
3146 Reviewed by Alexey Proskuryakov.
3148 Adds stub implementation for WebKit of the new EditorClient methods.
3150 * src/EditorClientImpl.cpp:
3151 (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
3152 (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
3153 * src/EditorClientImpl.h:
3155 2013-01-31 Chris Hopman <cjhopman@chromium.org>
3157 [chromium] Make selection handling work in applyPageScaleInCompositor mode
3158 https://bugs.webkit.org/show_bug.cgi?id=107831
3160 Reviewed by Ryosuke Niwa.
3162 These functions expect a window point. When in
3163 applyPageScaleFactorInCompositor mode, the points need to be unscaled
3164 by the page scale factor.
3166 * src/WebFrameImpl.cpp:
3167 (WebKit::WebFrameImpl::selectRange):
3168 (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
3170 2013-01-31 Tom Sepez <tsepez@chromium.org>
3172 [v8] Enable binding integrity on mac
3173 https://bugs.webkit.org/show_bug.cgi?id=108500
3175 Reviewed by Adam Barth.
3177 Patch is correct if existing tests pass without new crashes.
3180 Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
3182 2013-01-31 Dan Alcantara <dfalcantara@chromium.org>
3184 WebFrameTest.DisambiguationPopup is failing
3185 https://bugs.webkit.org/show_bug.cgi?id=108160
3187 Reviewed by Adam Barth.
3189 Fix the unit test so that it is using the right HTML file.
3191 * tests/WebFrameTest.cpp:
3193 2013-01-31 Tony Chang <tony@chromium.org>
3195 [Chromium] webkit_unit_tests should depend on base/allocator for ASAN
3196 https://bugs.webkit.org/show_bug.cgi?id=108497
3198 Reviewed by James Robinson.
3200 * WebKitUnitTests.gyp:
3202 2013-01-31 Alexandre Elias <aelias@chromium.org>
3204 Call FrameView::contentsResized() when setting fixed layout size
3205 https://bugs.webkit.org/show_bug.cgi?id=107922
3207 Reviewed by James Robinson.
3209 In fixed layout mode, we should be calling contentsResized() when the
3210 fixed layout size is changed, but not laying out when the visible
3211 content rect changes.
3213 Previously landed as r140869 but was reverted due to a bug in bundled
3214 Chromium-specific code. This patch includes just the minimum needed in
3217 New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
3218 flaky and obsolete tests for the old page scale mode are also deleted.
3220 * tests/WebFrameTest.cpp:
3222 2013-01-31 Tommy Widenflycht <tommyw@google.com>
3224 [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
3225 https://bugs.webkit.org/show_bug.cgi?id=108458
3227 Reviewed by Adam Barth.
3229 Only renames, no other code changes.
3231 * public/WebMediaStreamRegistry.h:
3233 (WebMediaStreamRegistry):
3234 * public/WebUserMediaRequest.h:
3236 (WebUserMediaRequest):
3237 * src/WebMediaStreamRegistry.cpp:
3238 (WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
3239 * src/WebUserMediaRequest.cpp:
3240 (WebKit::WebUserMediaRequest::requestSucceeded):
3242 2013-01-31 Alec Flett <alecflett@chromium.org>
3244 IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
3245 https://bugs.webkit.org/show_bug.cgi?id=108399
3247 Reviewed by Dimitri Glazkov.
3249 Cleanup now that chromium proxies the new signatures through.
3251 * src/IDBCallbacksProxy.cpp:
3252 (WebKit::IDBCallbacksProxy::onSuccess):
3253 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
3254 * src/IDBCallbacksProxy.h:
3255 (IDBCallbacksProxy):
3256 * src/WebIDBCallbacksImpl.cpp:
3257 * src/WebIDBCallbacksImpl.h:
3258 (WebIDBCallbacksImpl):
3260 2013-01-31 James Robinson <jamesr@chromium.org>
3262 [chromium] Remove dead transitional code from WebViewImpl
3263 https://bugs.webkit.org/show_bug.cgi?id=107889
3265 Reviewed by Adam Barth.
3267 The chromium side of this landed at r178256 and seems stable.
3269 * public/WebWidget.h:
3270 (WebKit::WebWidget::setCompositorSurfaceReady):
3271 * src/WebViewImpl.cpp:
3272 (WebKit::WebViewImpl::WebViewImpl):
3273 (WebKit::WebViewImpl::~WebViewImpl):
3275 (WebKit::WebViewImpl::setIsTransparent):
3276 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3277 * src/WebViewImpl.h:
3278 * tests/ScrollingCoordinatorChromiumTest.cpp:
3279 (WebKit::FakeWebViewClient::initializeLayerTreeView):
3280 (FakeWebViewClient):
3281 (WebKit::FakeWebViewClient::layerTreeView):
3282 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
3283 (ScrollingCoordinatorChromiumTest):
3285 2013-01-31 Kentaro Hara <haraken@chromium.org>
3287 Rename WheelEvent::Granularity to WheelEvent::DeltaMode
3288 https://bugs.webkit.org/show_bug.cgi?id=108434
3290 Reviewed by Ryosuke Niwa.
3292 Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.
3294 Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
3295 https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
3297 No tests. No change in behavior.
3299 * src/WebInputEventConversion.cpp:
3300 (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
3301 (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
3303 2013-01-31 Yury Semikhatsky <yurys@chromium.org>
3305 Unreviewed. Bump Chromium dependency to 179332
3309 2013-01-31 Mark Pilgrim <pilgrim@chromium.org>
3311 [Chromium] Move MediaPlayerPrivateChromium to WebCore
3312 https://bugs.webkit.org/show_bug.cgi?id=108415
3314 Reviewed by Adam Barth.
3316 Part of a larger refactoring series; see tracking bug 106829.
3319 * src/MediaPlayerPrivateChromium.cpp: Removed.
3321 (WebKit::initializeWithoutV8): call new setter function in
3322 WebCore::MediaPlayerPrivate
3324 2013-01-30 Sheriff Bot <webkit.review.bot@gmail.com>
3326 Unreviewed, rolling out r141358.
3327 http://trac.webkit.org/changeset/141358
3328 https://bugs.webkit.org/show_bug.cgi?id=108421
3330 breaks android builder (Requested by morrita on #webkit).
3334 * src/WebFrameImpl.cpp:
3336 2013-01-30 Nico Weber <thakis@chromium.org>
3338 [chromium] Build webkit with enable_web_intents set to 0.
3339 https://bugs.webkit.org/show_bug.cgi?id=108408
3341 Reviewed by Kentaro Hara.
3343 I'll then make chromium build fine with that, then switch
3344 enable_web_intents to 0, roll that into webkit, and then
3345 actually remove the code hidden behind this flag.
3349 * src/WebFrameImpl.cpp:
3351 2013-01-30 Levi Weintraub <leviw@chromium.org>
3353 [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
3354 https://bugs.webkit.org/show_bug.cgi?id=108381
3356 Reviewed by James Robinson.
3358 WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
3359 touch events. Some plugins make this request more than once, leading to an imbalance in Document's
3360 touch event handler map, and a stale node pointer when the plugin is destroyed. This change
3361 has WebPluginContainerImpl only add one ref for the plugin at a time.
3363 * src/WebPluginContainerImpl.cpp:
3364 (WebKit::WebPluginContainerImpl::requestTouchEventType):
3366 2013-01-30 Yusuf Ozuysal <yusufo@google.com>
3368 Start sending scrollType as NonBubblingGesture for flings
3369 https://bugs.webkit.org/show_bug.cgi?id=108372
3371 Reviewed by James Robinson.
3373 * src/WebCompositorInputHandlerImpl.cpp:
3374 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
3376 2013-01-30 Tien-Ren Chen <trchen@chromium.org>
3378 [chromium] Add WebFrame::visibleContentRect()
3379 https://bugs.webkit.org/show_bug.cgi?id=108311
3381 Reviewed by James Robinson.
3383 * public/WebFrame.h:
3384 * src/WebFrameImpl.cpp:
3385 (WebKit::WebFrameImpl::visibleContentRect):
3387 * src/WebFrameImpl.h:
3390 2013-01-30 Kentaro Hara <haraken@chromium.org>
3392 Implement KeyboardEvent constructor
3393 https://bugs.webkit.org/show_bug.cgi?id=108320
3395 Reviewed by Adam Barth.
3397 Renamed keyboard event constant variables to avoid style errors.
3399 * src/WebInputEventConversion.cpp:
3400 (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
3401 * tests/WebInputEventConversionTest.cpp:
3402 * tests/WebInputEventFactoryTestGtk.cpp:
3404 2013-01-30 Kentaro Hara <haraken@chromium.org>
3406 Implement WheelEvent constructor
3407 https://bugs.webkit.org/show_bug.cgi?id=108303
3409 Reviewed by Adam Barth.
3411 This patch just renames an enum value to avoid style check error.
3413 * src/WebViewImpl.cpp:
3414 (WebKit::WebViewImpl::scrollBy):
3416 2013-01-30 Dana Jansens <danakj@chromium.org>
3418 [chromium] Add recordRenderingStats to WebSettings
3419 https://bugs.webkit.org/show_bug.cgi?id=108358
3421 Reviewed by James Robinson.
3423 * public/WebSettings.h:
3424 * src/WebSettingsImpl.cpp:
3425 (WebKit::WebSettingsImpl::setRecordRenderingStats):
3427 * src/WebSettingsImpl.h:
3429 (WebKit::WebSettingsImpl::recordRenderingStats):
3430 * src/WebViewImpl.cpp:
3431 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3433 2013-01-30 Tony Gentilcore <tonyg@chromium.org>
3435 Fix compile error in WebFrameTest
3436 https://bugs.webkit.org/show_bug.cgi?id=108360
3438 Unreviewed build fix.
3440 Fixes compile error:
3441 ../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
3443 * tests/WebFrameTest.cpp:
3445 2013-01-30 John Knottenbelt <jknotten@chromium.org>
3447 [Chromium] Fix find in page rects for overflowing content.
3448 https://bugs.webkit.org/show_bug.cgi?id=104924
3450 Reviewed by Julien Chaffraix.
3452 If a div has overflowing content, we should only normalise its
3453 coordinates against the renderview or the containing scrollable block.
3455 TEST=WebFrameTest.FindInPageMatchRects
3457 * src/FindInPageCoordinates.cpp:
3458 (WebKit::enclosingScrollableAncestor):
3459 Helper function to find the enclosing containing block with an overflow clip.
3460 (WebKit::toNormalizedRect):
3461 Pass in the container as an argument.
3462 (WebKit::findInPageRectFromAbsoluteRect):
3463 Compute the container for toNormalizedRect using enclosingScrollableAncestor.
3464 * tests/WebFrameTest.cpp:
3465 Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
3466 * tests/data/find.html:
3467 Add test case for <select> element.
3468 * tests/data/find_in_page_frame.html:
3470 - Result 15, 16 tests that containing <div> with style float:left and
3471 height:0px does not impact coordinate normalization.
3472 - Result 17, 18 tests that matches with absolute positioning are normalized containing
3473 relative positioned block, even if there is a closer parent block with overflow clip.
3474 - Result 19 adds a test case for <select> element.
3476 2013-01-30 Dominik Röttsches <dominik.rottsches@intel.com>
3478 [HarfBuzz] Remove the HarfBuzz-old code
3479 https://bugs.webkit.org/show_bug.cgi?id=108077
3481 Reviewed by Benjamin Poulain.
3483 Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
3484 won't be a distinction between ng and non-ng HarfBuzz after
3485 removing the old code.
3489 2013-01-30 Jochen Eisinger <jochen@chromium.org>
3491 [chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
3492 https://bugs.webkit.org/show_bug.cgi?id=108004
3493 http://code.google.com/p/chromium/issues/detail?id=172416
3495 console.debug triggers a NOTREACHED() assertation in Chromium. This
3496 is because WebCore::MessageLevel contains 5 levels, including debug,
3497 where WebConsoleMessage::Level is missing a "debug" level. Add a
3498 WebConsoleMessage::LevelDebug so that it can get passed up to the
3499 renderer even if it doesn't make use of that now.
3501 Requires another patch to chromium itself to fix chromium bug 172416
3502 but this is a prerequisite.
3504 Also add an enum compile time check to AssertMatchingEnums.cpp,
3506 Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
3507 Reviewed by Jochen Eisinger.
3509 * public/WebConsoleMessage.h:
3510 * src/AssertMatchingEnums.cpp:
3511 * src/WebFrameImpl.cpp:
3512 (WebKit::WebFrameImpl::addMessageToConsole):
3514 2013-01-30 Xianzhu Wang <wangxianzhu@chromium.org>
3516 [Chromium] Correct zoom for focused node when using compositor scaling
3517 https://bugs.webkit.org/show_bug.cgi?id=107599