1 2012-09-24 Tony Chang <tony@chromium.org>
3 Unreviewed. Rolled DEPS.
7 2012-09-24 Dana Jansens <danakj@chromium.org>
9 [chromium] Add setters to WebFilterOperation for IPC pickling
10 https://bugs.webkit.org/show_bug.cgi?id=97147
12 Reviewed by James Robinson.
14 * tests/FilterOperationsTest.cpp:
18 2012-09-24 Patrick Gansterer <paroga@webkit.org>
20 Remove remaining WTF_DEPRECATED_STRING_OPERATORS from cpp files
21 https://bugs.webkit.org/show_bug.cgi?id=97412
23 Reviewed by Adam Barth.
25 * src/WebPageSerializerImpl.cpp:
26 (WebKit::WebPageSerializerImpl::openTagToString): Replaced operator+= with StringBuilder::append().
27 (WebKit::WebPageSerializerImpl::endTagToString): Ditto.
29 2012-09-24 Yury Semikhatsky <yurys@chromium.org>
31 Unreviewed, rolling out r122243.
32 http://trac.webkit.org/changeset/129243
33 https://bugs.webkit.org/show_bug.cgi?id=97441
35 WebFilterOperationsTest.saveAndRestore added in the change is failing.
37 * tests/FilterOperationsTest.cpp:
39 2012-09-23 Keishi Hattori <keishi@webkit.org>
41 Add suggestionPicker to CalendarPicker
42 https://bugs.webkit.org/show_bug.cgi?id=97201
44 Reviewed by Kent Tamura.
46 * src/DateTimeChooserImpl.cpp:
47 (WebKit::DateTimeChooserImpl::writeDocument): Add js/css for SuggestionPicker to page picker. Add highlight color to args.
49 2012-09-21 Kenichi Ishibashi <bashi@chromium.org>
51 [Chromium] Use OpenTypeVerticalData on Linux
52 https://bugs.webkit.org/show_bug.cgi?id=97277
54 Reviewed by Tony Chang.
56 * features.gypi: Enable OPENTYPE_VERTICAL on linux and android.
58 2012-09-21 Dirk Pranke <dpranke@chromium.org>
60 Roll Chromium DEPS to r158095 to pick up typo fix in test_expectations.txt
62 Unreviewed, rolled DEPS.
66 2012-09-21 Dirk Pranke <dpranke@chromium.org>
68 Roll Chromium DEPS to r158060
70 Unreviewed, rolled DEPS.
74 2012-09-21 Chris Rogers <crogers@google.com>
76 Add Web Audio support for deprecated/legacy APIs
77 https://bugs.webkit.org/show_bug.cgi?id=97050
79 Reviewed by Eric Carlson.
83 2012-09-21 Mark Pilgrim <pilgrim@chromium.org>
85 [Chromium] remove getFontFamilyForCharacters from PlatformSupport
86 https://bugs.webkit.org/show_bug.cgi?id=96282
88 Reviewed by Tony Chang.
90 Migrating away from PlatformSupport. getFontFamilyForCharacters is
91 moved to FontCache.h and overridden by the two platforms that
92 need it (Chromium Linux and Blackberry). New files for the overrides.
93 Part of a larger refactoring series. See tracking bug 82948.
95 * src/PlatformSupport.cpp:
98 2012-09-21 Dana Jansens <danakj@chromium.org>
100 [chromium] Add setters to WebFilterOperation for IPC pickling
101 https://bugs.webkit.org/show_bug.cgi?id=97147
103 Reviewed by James Robinson.
105 * tests/FilterOperationsTest.cpp:
109 2012-09-21 Tony Chang <tony@chromium.org>
111 [chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.
115 2012-09-21 Sheriff Bot <webkit.review.bot@gmail.com>
117 Unreviewed. Rolled DEPS.
121 2012-09-21 Sami Kyostila <skyostil@chromium.org>
123 [chromium] Add test for ScrollingCoordinatorChromium
124 https://bugs.webkit.org/show_bug.cgi?id=96657
126 Reviewed by James Robinson.
128 Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
129 fast (non-main thread) scrolling is enabled when necessary and that a proper
130 compositing layer structure is created for fixed position and accelerated
133 Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault
134 ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
135 ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
136 ScrollingCoordinatorChromiumTest.wheelEventHandler
137 ScrollingCoordinatorChromiumTest.touchOverflowScrolling
140 * tests/ScrollingCoordinatorChromiumTest.cpp: Added.
143 (ScrollingCoordinatorChromiumTest):
144 (WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
145 (WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
146 (WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
147 (WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
149 * tests/data/fixed_position.html: Added.
150 * tests/data/non_fast_scrollable.html: Added.
151 * tests/data/touch_overflow_scrolling.html: Added.
152 * tests/data/wheel_event_handler.html: Added.
154 2012-09-20 Peter Beverloo <peter@chromium.org>
156 Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
157 https://bugs.webkit.org/show_bug.cgi?id=97227
159 Reviewed by Tony Chang.
161 Remove all fifo-related code together with the io_stream_forwarder_android
162 target defined in WebKitUnitTests.gyp.
164 * WebKitUnitTests.gyp:
165 * tests/ForwardIOStreamsAndroid.cpp: Removed.
166 * tests/ForwardIOStreamsAndroid.h: Removed.
167 * tests/RunAllTests.cpp:
170 2012-09-21 Peter Beverloo <peter@chromium.org>
172 Unreviewed. Rolled DEPS.
176 2012-09-21 Keishi Hattori <keishi@webkit.org>
178 Add datalist suggestions into DateTimeChooserParameters
179 https://bugs.webkit.org/show_bug.cgi?id=97292
181 Reviewed by Kent Tamura.
183 * src/DateTimeChooserImpl.cpp:
184 (WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.
186 2012-09-20 Tony Chang <tony@chromium.org>
188 [chromium] Unreviewed build fix. webkit_unit_tests have global constructors.
190 * WebKitUnitTests.gyp: Remove -Wglobal-constructors.
192 2012-09-20 Tony Chang <tony@chromium.org>
194 [chromium] Enable more clang warnings
195 https://bugs.webkit.org/show_bug.cgi?id=97257
197 Reviewed by James Robinson.
199 * WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
200 * WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.
202 2012-09-20 David Grogan <dgrogan@chromium.org>
204 Fix IndexedDB unit tests
205 https://bugs.webkit.org/show_bug.cgi?id=97149
207 Reviewed by Tony Chang.
209 * tests/IDBDatabaseBackendTest.cpp:
210 Specify a desired version of -1 so that no version change transaction
213 2012-09-20 Dirk Pranke <dpranke@chromium.org>
215 roll Chromium to r157829.
217 Unreviewed, deps change.
221 2012-09-20 Nate Chapin <japhet@chromium.org>
223 Unreviewed, chromium win build fix.
224 Remove spurious reference to the non-existent
225 tests/LayerPainterChromium.h in WebKit.gypi.
229 2012-09-20 James Robinson <jamesr@chromium.org>
231 [chromium] Remove unused copy of chromium compositor implementation files
232 https://bugs.webkit.org/show_bug.cgi?id=97255
234 Reviewed by Adam Barth.
238 * WebKitUnitTests.gyp:
239 * src/WebAnimationCurveCommon.cpp: Removed.
240 * src/WebAnimationCurveCommon.h: Removed.
241 * src/WebAnimationImpl.cpp: Removed.
242 * src/WebAnimationImpl.h: Removed.
243 * src/WebContentLayerImpl.cpp: Removed.
244 * src/WebContentLayerImpl.h: Removed.
245 * src/WebExternalTextureLayerImpl.cpp: Removed.
246 * src/WebExternalTextureLayerImpl.h: Removed.
247 * src/WebFloatAnimationCurveImpl.cpp: Removed.
248 * src/WebFloatAnimationCurveImpl.h: Removed.
249 * src/WebIOSurfaceLayerImpl.cpp: Removed.
250 * src/WebIOSurfaceLayerImpl.h: Removed.
251 * src/WebImageLayerImpl.cpp: Removed.
252 * src/WebImageLayerImpl.h: Removed.
253 * src/WebLayerImpl.cpp: Removed.
254 * src/WebLayerImpl.h: Removed.
255 * src/WebLayerTreeViewImpl.cpp: Removed.
256 * src/WebLayerTreeViewImpl.h: Removed.
257 * src/WebScrollbarLayerImpl.cpp: Removed.
258 * src/WebScrollbarLayerImpl.h: Removed.
259 * src/WebSolidColorLayerImpl.cpp: Removed.
260 * src/WebSolidColorLayerImpl.h: Removed.
261 * src/WebToCCInputHandlerAdapter.cpp: Removed.
262 * src/WebToCCInputHandlerAdapter.h: Removed.
263 * src/WebTransformAnimationCurveImpl.cpp: Removed.
264 * src/WebTransformAnimationCurveImpl.h: Removed.
265 * src/WebVideoLayerImpl.cpp: Removed.
266 * src/WebVideoLayerImpl.h: Removed.
267 * tests/CCActiveAnimationTest.cpp: Removed.
268 * tests/CCAnimationTestCommon.cpp: Removed.
269 * tests/CCAnimationTestCommon.h: Removed.
270 * tests/CCDamageTrackerTest.cpp: Removed.
271 * tests/CCDelayBasedTimeSourceTest.cpp: Removed.
272 * tests/CCDrawQuadTest.cpp: Removed.
273 * tests/CCFrameRateControllerTest.cpp: Removed.
274 * tests/CCGeometryTestUtils.cpp: Removed.
275 * tests/CCGeometryTestUtils.h: Removed.
276 * tests/CCHeadsUpDisplayTest.cpp: Removed.
277 * tests/CCKeyframedAnimationCurveTest.cpp: Removed.
278 * tests/CCLayerAnimationControllerTest.cpp: Removed.
279 * tests/CCLayerImplTest.cpp: Removed.
280 * tests/CCLayerIteratorTest.cpp: Removed.
281 * tests/CCLayerQuadTest.cpp: Removed.
282 * tests/CCLayerSorterTest.cpp: Removed.
283 * tests/CCLayerTestCommon.cpp: Removed.
284 * tests/CCLayerTestCommon.h: Removed.
285 * tests/CCLayerTreeHostCommonTest.cpp: Removed.
286 * tests/CCLayerTreeHostImplTest.cpp: Removed.
287 * tests/CCLayerTreeHostTest.cpp: Removed.
288 * tests/CCMathUtilTest.cpp: Removed.
289 * tests/CCOcclusionTrackerTest.cpp: Removed.
290 * tests/CCOcclusionTrackerTestCommon.h: Removed.
291 * tests/CCPrioritizedTextureTest.cpp: Removed.
292 * tests/CCQuadCullerTest.cpp: Removed.
293 * tests/CCRenderPassTest.cpp: Removed.
294 * tests/CCRenderSurfaceFiltersTest.cpp: Removed.
295 * tests/CCRenderSurfaceTest.cpp: Removed.
296 * tests/CCRendererGLTest.cpp: Removed.
297 * tests/CCResourceProviderTest.cpp: Removed.
298 * tests/CCSchedulerStateMachineTest.cpp: Removed.
299 * tests/CCSchedulerTest.cpp: Removed.
300 * tests/CCSchedulerTestCommon.h: Removed.
301 * tests/CCScopedTextureTest.cpp: Removed.
302 * tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed.
303 * tests/CCSolidColorLayerImplTest.cpp: Removed.
304 * tests/CCTestCommon.h: Removed.
305 * tests/CCTextureUpdateControllerTest.cpp: Removed.
306 * tests/CCThreadTaskTest.cpp: Removed.
307 * tests/CCThreadedTest.cpp: Removed.
308 * tests/CCThreadedTest.h: Removed.
309 * tests/CCTiledLayerImplTest.cpp: Removed.
310 * tests/CCTiledLayerTestCommon.cpp: Removed.
311 * tests/CCTiledLayerTestCommon.h: Removed.
312 * tests/CCTimerTest.cpp: Removed.
313 * tests/ContentLayerChromiumTest.cpp: Removed.
314 * tests/FakeCCLayerTreeHostClient.h: Removed.
315 * tests/FakeGraphicsContext3DTest.cpp: Removed.
316 * tests/FakeWebScrollbarThemeGeometry.h: Removed.
317 * tests/FloatQuadTest.cpp: Removed.
318 * tests/GraphicsLayerChromiumTest.cpp:
319 * tests/ImageLayerChromiumTest.cpp:
320 * tests/LayerChromiumTest.cpp: Removed.
321 * tests/MockCCQuadCuller.h: Removed.
322 * tests/ScrollbarLayerChromiumTest.cpp: Removed.
323 * tests/TextureCopierTest.cpp: Removed.
324 * tests/TextureLayerChromiumTest.cpp: Removed.
325 * tests/ThrottledTextureUploaderTest.cpp: Removed.
326 * tests/TiledLayerChromiumTest.cpp: Removed.
327 * tests/TreeSynchronizerTest.cpp: Removed.
328 * tests/WebAnimationTest.cpp: Removed.
329 * tests/WebFloatAnimationCurveTest.cpp: Removed.
330 * tests/WebLayerTest.cpp: Removed.
331 * tests/WebLayerTreeViewTest.cpp: Removed.
332 * tests/WebTransformAnimationCurveTest.cpp: Removed.
333 * tests/WebTransformOperationsTest.cpp: Removed.
334 * tests/WebTransformationMatrixTest.cpp: Removed.
336 2012-09-20 Tommy Widenflycht <tommyw@google.com>
338 MediaStream API: Extend UserMediaRequest with a ownerDocument method
339 https://bugs.webkit.org/show_bug.cgi?id=97095
341 Reviewed by Adam Barth.
343 Chromium need to know exactly which frame called getUserMedia so that it can clean
344 away the stream when the frame goes away.
345 Since that information is available in webkit add an accessor method.
347 Also taking the opportunity to remove an unused deprecated method,
348 and adding asserts in case the object is empty.
350 * public/WebUserMediaRequest.h:
352 (WebUserMediaRequest):
353 * src/WebUserMediaRequest.cpp:
354 (WebKit::WebUserMediaRequest::ownerDocument):
356 2012-09-20 Mike West <mkwst@google.com>
358 [chromium] Adding the 'google_apis' directory to .gitignore.
359 https://bugs.webkit.org/show_bug.cgi?id=97187
361 Reviewed by Jochen Eisinger.
363 'chromium/google_apis' should be ignored, as it's not in the git repo.
367 2012-09-19 Adam Barth <abarth@webkit.org>
369 Remove webkitPostMessage
370 https://bugs.webkit.org/show_bug.cgi?id=96577
372 Reviewed by Ojan Vafai.
374 Actually disable webkitPostMessage. See
375 http://trac.webkit.org/changeset/128658 for more information.
379 2012-09-19 Joshua Bell <jsbell@chromium.org>
381 IndexedDB: Remove "current transaction" concept from backing store
382 https://bugs.webkit.org/show_bug.cgi?id=96663
384 Reviewed by Tony Chang.
386 Update fake class with new method signatures.
388 * tests/IDBFakeBackingStore.h:
390 2012-09-19 Terry Anderson <tdanderson@chromium.org>
392 [chromium] Store the contents scale factor in PlatformContextSkia on initialization
393 https://bugs.webkit.org/show_bug.cgi?id=96137
395 Reviewed by Stephen White.
397 Define SK_SUPPORT_HINTING_SCALE_FACTOR by default. This is also used
398 for the skia patch here: https://codereview.appspot.com/6506099/.
399 Also added two new unit tests.
402 * tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
404 (WebCore::HintingScaleCallback::HintingScaleCallback):
405 (HintingScaleCallback):
406 (WebCore::HintingScaleCallback::operator()):
408 * tests/PlatformContextSkiaTest.cpp:
412 2012-09-19 David Grogan <dgrogan@chromium.org>
414 Disable some failing IDB tests
415 https://bugs.webkit.org/show_bug.cgi?id=97135
417 Reviewed by Nate Chapin.
419 They were broken in r129037.
421 * tests/IDBDatabaseBackendTest.cpp:
423 2012-09-19 Alpha Lam <hclam@chromium.org>
425 [chromium] Unreviewed. Build fix.
427 Not building WebImageTest.cpp for component build.
431 2012-09-19 Alpha Lam <hclam@chromium.org>
433 [chromium] WebImage should use ImageDecoder directly
434 https://bugs.webkit.org/show_bug.cgi?id=96135
436 Reviewed by Adam Barth.
438 This patch is for preparation of deferred image decoding.
439 ImageSource will be used as a portal to access deferred image decoder
440 by BitmapImage, it should not be accessible through WebKit APIs.
442 WebImage now calls ImageDecoder directly which is the actual
443 implementation of an image decoder.
445 Tests: WebImageTest.PNGImage
446 WebImageTest.ICOImage
447 WebImageTest.BadImage
450 * src/WebImageSkia.cpp:
451 (WebKit::WebImage::fromData):
452 (WebKit::WebImage::framesFromData):
453 * tests/WebImageTest.cpp: Added.
457 * tests/data/black-and-white.ico: Added.
458 * tests/data/white-1x1.png: Added.
460 2012-09-19 Oli Lan <olilan@chromium.org>
462 [chromium] Add a method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
463 https://bugs.webkit.org/show_bug.cgi?id=96112
465 Reviewed by Adam Barth.
467 Adds a new method didHandleGestureEvent to WebViewClient, called from WebViewImpl::handleGestureEvent.
469 This will be used by the Android port to implement platform-specific gesture behaviour.
471 This is tested by the new test WebViewTest.ClientTapHandlers.
473 * public/WebViewClient.h:
475 (WebKit::WebViewClient::didHandleGestureEvent):
476 * src/WebViewImpl.cpp:
477 (WebKit::WebViewImpl::handleGestureEvent):
478 * tests/WebViewTest.cpp:
480 2012-09-19 Robert Flack <flackr@chromium.org>
482 [chromium] Support high DPI scroll bar on top level web frame.
483 https://bugs.webkit.org/show_bug.cgi?id=95134
485 Reviewed by Adrienne Walker.
487 Calls setAppliesPageScale(true) on root scrollbar layers as these are not scaled.
489 * src/NonCompositedContentHost.cpp:
490 (WebKit::setScrollbarBoundsContainPageScale):
492 (WebKit::NonCompositedContentHost::setViewport):
494 2012-09-19 Mark Pilgrim <pilgrim@chromium.org>
496 [Chromium] Move notifyJSOutOfMemory out of PlatformSupport
497 https://bugs.webkit.org/show_bug.cgi?id=97116
499 Reviewed by Adam Barth.
501 Part of a refactoring series. See tracking bug 82948.
503 * src/FrameLoaderClientImpl.cpp:
504 (WebKit::FrameLoaderClientImpl::didExhaustMemoryAvailableForScript):
506 * src/FrameLoaderClientImpl.h:
507 (FrameLoaderClientImpl):
508 * src/PlatformSupport.cpp:
511 2012-09-19 Mark Pilgrim <pilgrim@chromium.org>
513 [Chromium] Remove unused popupsAllowed function from PlatformSupport
514 https://bugs.webkit.org/show_bug.cgi?id=96521
516 Reviewed by Eric Seidel.
518 Part of a refactoring series. See tracking bug 82948.
520 * src/PlatformSupport.cpp:
523 2012-09-19 Kent Tamura <tkent@chromium.org>
525 [Chromium] Fix crash in WebFrameImpl::loadHistoryItem
526 https://bugs.webkit.org/show_bug.cgi?id=96352
528 Reviewed by Adam Barth.
530 We have some crash reports with the following stack:
531 - HistoryItem::shouldDoSameDocumentNavigationTo.
532 - WebFrameImpl::loadHistoryItem
535 We don't have reproducible steps, and not sure what's the root
536 cause. Anyway we should check nullness of currentItem because
537 HistoryController::m_currentItem can be 0.
539 * src/WebFrameImpl.cpp:
540 (WebKit::WebFrameImpl::loadHistoryItem):
541 Check nullness of currentItem.
543 2012-09-18 Sailesh Agrawal <sail@chromium.org>
545 Chromium: Scrollbar with tickmarks doesn't respond to clicks
546 https://bugs.webkit.org/show_bug.cgi?id=96049
548 Reviewed by Beth Dakin.
550 Pipe isAlphaLocked and setIsAlphaLocked.
552 * src/WebPluginScrollbarImpl.cpp:
553 (WebKit::WebPluginScrollbarImpl::isAlphaLocked):
555 (WebKit::WebPluginScrollbarImpl::setIsAlphaLocked):
556 * src/WebPluginScrollbarImpl.h:
557 (WebPluginScrollbarImpl):
558 * src/WebScrollbarThemeClientImpl.cpp:
559 (WebKit::WebScrollbarThemeClientImpl::isAlphaLocked):
561 (WebKit::WebScrollbarThemeClientImpl::setIsAlphaLocked):
562 * src/WebScrollbarThemeClientImpl.h:
563 (WebScrollbarThemeClientImpl):
564 * tests/ScrollbarLayerChromiumTest.cpp:
566 2012-09-18 Alpha Lam <hclam@chromium.org>
568 Unreviewed, rolling out r128939.
569 http://trac.webkit.org/changeset/128939
570 https://bugs.webkit.org/show_bug.cgi?id=96135
572 Failing test_shell_tests.
575 * src/WebImageSkia.cpp:
576 (WebKit::WebImage::fromData):
577 (WebKit::WebImage::framesFromData):
578 * tests/WebImageTest.cpp: Removed.
579 * tests/data/black-and-white.ico: Removed.
580 * tests/data/white-1x1.png: Removed.
582 2012-09-18 Alpha Lam <hclam@chromium.org>
584 [chromium] WebImage should use ImageDecoder directly
585 https://bugs.webkit.org/show_bug.cgi?id=96135
587 Reviewed by Adam Barth.
589 This patch is for preparation of deferred image decoding.
590 ImageSource will be used as a portal to access deferred image decoder
591 by BitmapImage, it should not be accessible through WebKit APIs.
593 WebImage now calls ImageDecoder directly which is the actual
594 implementation of an image decoder.
596 Tests: WebImageTest.PNGImage
597 WebImageTest.ICOImage
600 * src/WebImageSkia.cpp:
601 (WebKit::WebImage::fromData):
602 (WebKit::WebImage::framesFromData):
603 * tests/WebImageTest.cpp: Added.
607 * tests/data/black-and-white.ico: Added.
608 * tests/data/white-1x1.png: Added.
610 2012-09-18 Tommy Widenflycht <tommyw@google.com>
612 MediaStream API: Create a flag to enable PeerConnection00
613 https://bugs.webkit.org/show_bug.cgi?id=96989
615 Reviewed by Adam Barth.
617 Adding the functionality to separately enable/disable PeerConnection00.
618 For now it is enabled by default.
620 * public/WebRuntimeFeatures.h:
621 (WebRuntimeFeatures):
622 * src/WebRuntimeFeatures.cpp:
623 (WebKit::WebRuntimeFeatures::enableDeprecatedPeerConnection):
625 (WebKit::WebRuntimeFeatures::isDeprecatedPeerConnectionEnabled):
627 2012-09-18 Iain Merrick <husky@google.com>
629 [Chromium] Merge moveSelectionStart, moveSelectionEnd, and moveCaret into selectRange
630 https://bugs.webkit.org/show_bug.cgi?id=96508
632 Reviewed by Ryosuke Niwa.
634 These methods had "start" and "end" parameters, but this is incorrect.
635 selectRange() actually takes base and extent (where the user actually
636 touched), and selectionBounds() returns anchor and focus (base and extent
637 expanded to account for the selection granularity).
639 This patch fixes the parameter names, and updates selectRange, its test
640 and its documentation to reflect the correct usage. It also removes
641 moveSelectionStart/moveSelectionEnd/moveCaret (which aren't being used
642 yet), and updates WebFrameTest to show how these can be implemented via
647 * public/WebWidget.h:
649 (WebKit::WebWidget::selectionBounds):
650 * src/WebFrameImpl.cpp:
651 (WebKit::WebFrameImpl::selectRange):
652 * src/WebFrameImpl.h:
654 * src/WebViewImpl.cpp:
655 (WebKit::WebViewImpl::selectionBounds):
658 * tests/WebFrameTest.cpp:
660 2012-09-18 Terry Anderson <tdanderson@chromium.org>
662 Roll chromium DEPS to r157342
663 https://bugs.webkit.org/show_bug.cgi?id=96963
665 Reviewed by Stephen White.
667 Roll chromium DEPS to r157342. Also include the top-level directory
668 google_apis as a dependency, which was required for r157130.
672 2012-09-17 Brian Anderson <brianderson@chromium.org>
674 [chromium] Add rendering commit statistics
675 https://bugs.webkit.org/show_bug.cgi?id=96938
677 Reviewed by James Robinson.
679 Adds total commit time and total commit count to WebRenderingStats.
680 Allows us to caculate average commit time in performance tests.
682 * src/WebLayerTreeViewImpl.cpp:
683 (WebKit::WebLayerTreeViewImpl::renderingStats):
685 2012-09-17 James Robinson <jamesr@chromium.org>
687 [chromium] Move a FilterOperationsTest and WebInputEventConversionTest back to webkit_unittest_files variable
688 https://bugs.webkit.org/show_bug.cgi?id=96964
690 Reviewed by Adrienne Walker.
692 These targets are really webkit unit tests and shouldn't be guarded by use_libcc_for_compositor.
696 2012-09-17 Rick Byers <rbyers@chromium.org>
698 Send GestureTapDownCancel to WebCore
699 https://bugs.webkit.org/show_bug.cgi?id=96060
701 Reviewed by Antonio Gomes.
703 Plumb WebInputEvent::GetsureTapCancel to
704 PlatformInputEvent::GestureTapDownCancel. After all the chromium code
705 was landed, it was suggested that 'TapDownCancel' was a better name
706 than 'TapCancel' since you can't cancel a Tap. I'm not changing the
707 WebInputEvent definition here because that would be a breaking change
708 to chromium, but I can do that as a series of follow-up CLs.
709 * src/WebInputEventConversion.cpp:
710 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
711 * src/WebPopupMenuImpl.cpp:
712 (WebKit::WebPopupMenuImpl::handleInputEvent):
713 * src/WebViewImpl.cpp:
714 (WebKit::WebViewImpl::handleGestureEvent):
716 2012-09-17 Alec Flett <alecflett@chromium.org>
718 IndexedDB: Use ScriptValue instead of SerializedScriptValue for get/openCursor
719 https://bugs.webkit.org/show_bug.cgi?id=95409
721 Reviewed by Kentaro Hara.
723 This removes a bunch of tests that have been migrated to
724 LayoutTests, in https://bugs.webkit.org/show_bug.cgi?id=96818.
726 * tests/IDBBindingUtilitiesTest.cpp:
727 (WebCore::checkKeyFromValueAndKeyPathInternal):
728 (WebCore::checkKeyPathNullValue):
729 (WebCore::injectKey):
730 (WebCore::checkInjection):
731 (WebCore::checkInjectionFails):
732 (WebCore::checkKeyPathStringValue):
733 (WebCore::checkKeyPathNumberValue):
735 * tests/IDBKeyPathTest.cpp:
737 2012-09-17 Leandro Gracia Gil <leandrogracia@chromium.org>
739 [Chromium] Fix cases where find-in-page doesn't send a final update
740 https://bugs.webkit.org/show_bug.cgi?id=96402
742 Fix some issues in the WebKit implementation that prevented to send a final
743 reportFindInPageMatchCount message.
745 Reviewed by Adam Barth.
747 * src/WebFrameImpl.cpp:
748 (WebKit::WebFrameImpl::scopeStringMatches):
750 (WebKit::WebFrameImpl::finishCurrentScopingEffort):
751 (WebKit::WebFrameImpl::cancelPendingScopingEffort):
752 (WebKit::WebFrameImpl::WebFrameImpl):
753 (WebKit::WebFrameImpl::shouldScopeMatches):
754 * src/WebFrameImpl.h:
756 2012-09-17 Joshua Bell <jsbell@chromium.org>
758 [Chromium] IndexedDB: Remove legacy two-phase open() API members
759 https://bugs.webkit.org/show_bug.cgi?id=96802
761 Reviewed by Tony Chang.
763 Following http://webkit.org/b/90411 and subsequent cleanup on the Chromium side,
764 these entry points are no longer needed.
766 * public/WebIDBDatabase.h: Delete old second-phase open(db-callbacks)
767 * public/WebIDBFactory.h: Delete old first-phase open() w/o db-callbacks
768 * src/WebIDBDatabaseImpl.cpp: No longer need to account for a close between phases.
769 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
770 (WebKit::WebIDBDatabaseImpl::close):
771 (WebKit::WebIDBDatabaseImpl::forceClose):
772 * src/WebIDBDatabaseImpl.h:
773 (WebIDBDatabaseImpl):
775 2012-09-17 Ilya Tikhonovsky <loislo@chromium.org>
777 Unreviewed. Temporary disable visited set counter check.
779 * tests/MemoryInstrumentationTest.cpp:
782 2012-09-17 Ilya Tikhonovsky <loislo@chromium.org>
784 Web Inspector: NMI: now when we can detect instrumented classes we can
785 remove addInstrumentedMember and use addMember for everything.
786 https://bugs.webkit.org/show_bug.cgi?id=96913
788 Reviewed by Yury Semikhatsky.
790 * tests/MemoryInstrumentationTest.cpp:
791 (WebCore::InstrumentedDOM::reportMemoryUsage):
792 (WebCore::NonVirtualInstrumented::reportMemoryUsage):
793 (WebCore::InstrumentedOwner::reportMemoryUsage):
795 2012-09-17 Ilya Tikhonovsky <loislo@chromium.org>
797 Unreviewed single line fix for mac chromium canary bot.
799 * tests/MemoryInstrumentationTest.cpp:
802 2012-09-15 Yury Semikhatsky <yurys@chromium.org>
804 Web Inspector: automatically detect if class has reportMemoryUsage method
805 https://bugs.webkit.org/show_bug.cgi?id=96756
807 Reviewed by Alexander Pavlov.
809 Test that reportMemoryUsage method will be called on the instrumented object
810 even if it is a template.
812 * tests/MemoryInstrumentationTest.cpp:
814 (InstrumentedTemplate):
815 (WebCore::InstrumentedTemplate::InstrumentedTemplate):
816 (WebCore::InstrumentedTemplate::reportMemoryUsage):
819 2012-09-14 Yury Semikhatsky <yurys@chromium.org>
821 Web Inspector: OwnPtr and RefPtr reported by pointer can be double counted by the memory instrumentation
822 https://bugs.webkit.org/show_bug.cgi?id=96791
824 Reviewed by Alexander Pavlov.
826 Test that pointers to RefPtr and OwnPtr won't be double counted by
827 the memory instrumentation.
829 * tests/MemoryInstrumentationTest.cpp:
831 (TwoPointersToRefPtr):
832 (WebCore::TwoPointersToRefPtr::TwoPointersToRefPtr):
833 (WebCore::TwoPointersToRefPtr::reportMemoryUsage):
835 (TwoPointersToOwnPtr):
836 (WebCore::TwoPointersToOwnPtr::TwoPointersToOwnPtr):
837 (WebCore::TwoPointersToOwnPtr::reportMemoryUsage):
839 2012-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
841 Unreviewed. Rolled DEPS.
845 2012-09-14 Julien Chaffraix <jchaffraix@webkit.org>
847 Revert r127457 and following fixes due to several hit-testing regressions
848 https://bugs.webkit.org/show_bug.cgi?id=96830
850 Reviewed by Antonio Gomes.
852 This change reverts r127457, r127863 and r128505.
854 * src/ContextMenuClientImpl.cpp:
855 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
857 2012-09-14 Ojan Vafai <ojan@chromium.org>
859 Provide a runtime setting to disable position:sticky
860 https://bugs.webkit.org/show_bug.cgi?id=96827
862 Reviewed by James Robinson.
864 * public/WebSettings.h:
865 * src/WebSettingsImpl.cpp:
866 (WebKit::WebSettingsImpl::setCSSStickyPositionEnabled):
868 * src/WebSettingsImpl.h:
871 2012-09-14 Adam Barth <abarth@webkit.org>
873 Remove webkitPostMessage
874 https://bugs.webkit.org/show_bug.cgi?id=96577
876 Reviewed by Ojan Vafai.
878 Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
882 2012-09-14 Sheriff Bot <webkit.review.bot@gmail.com>
884 Unreviewed. Rolled DEPS.
888 2012-09-14 Rick Byers <rbyers@chromium.org>
890 [chromium] add touch area to gestureTapDown data
891 https://bugs.webkit.org/show_bug.cgi?id=96806
893 Reviewed by Adam Barth.
895 Add width/height for GestureTapDown as for GestureTap/LongPress so that
896 we can eventually do fuzzing on it.
897 * public/WebInputEvent.h:
898 * src/WebInputEventConversion.cpp:
899 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
901 2012-09-14 Peter Beverloo <peter@chromium.org>
903 [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
904 https://bugs.webkit.org/show_bug.cgi?id=96687
906 Reviewed by Tony Chang.
908 Android's DumpRenderTree currently supports these arguments, implemented
909 as part of TestShellAndroid:
910 http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
912 They're used by the layout test runner to get the STDOUT and STDERR while
913 a layout test run is in process, which is a safer alternative to parsing
914 all the logcat output manually. The implementation can be seen here:
915 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
917 This patch generalizes parsing of and applying the effects of these arguments
918 so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
919 After this patch, this will make it possible to pull out the output-reading
920 code from Android's layout test port and generalize it so it can be re-used
921 in the new test-runner for the other two test suites.
923 This has no effect when compiling and running these tests as part of Chromium
924 code, which has a much more advanced test-runner that does parse complete log
925 output, but also directly depends on code licensed under Apache 2.
928 * tests/ForwardIOStreamsAndroid.cpp: Added.
930 (WebKit::maybeInitIOStreamForwardingForAndroid):
931 * tests/ForwardIOStreamsAndroid.h: Added.
933 * tests/RunAllTests.cpp:
936 2012-09-14 Keishi Hattori <keishi@webkit.org>
938 Make time input lang attribute aware for testing
939 https://bugs.webkit.org/show_bug.cgi?id=96728
941 Reviewed by Kent Tamura.
943 * tests/LocalizedDateICUTest.cpp:
944 (LocalizedDateICUTest::localizedDateFormatText):
945 (LocalizedDateICUTest::localizedShortDateFormatText):
947 2012-09-14 Keishi Hattori <keishi@webkit.org>
949 Refactor time format related methods on LocaleWin/Mac/ICU so that they override Localizer methods
950 https://bugs.webkit.org/show_bug.cgi?id=96726
952 Reviewed by Kent Tamura.
954 * tests/LocaleMacTest.cpp:
955 (LocaleMacTest::timeFormat):
956 (LocaleMacTest::shortTimeFormat):
958 * tests/LocaleWinTest.cpp:
959 (LocaleWinTest::timeFormat):
960 (LocaleWinTest::shortTimeFormat):
962 * tests/LocalizedDateICUTest.cpp:
963 (LocalizedDateICUTest::localizedDateFormatText):
964 (LocalizedDateICUTest::localizedShortDateFormatText):
966 2012-09-14 Keishi Hattori <keishi@webkit.org>
968 LocaleMac should fallback to defaultLanguage for an invalid locale
969 https://bugs.webkit.org/show_bug.cgi?id=96744
971 Reviewed by Kent Tamura.
973 * tests/LocaleMacTest.cpp:
976 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
978 Unreviewed, rolling out r128543.
979 http://trac.webkit.org/changeset/128543
980 https://bugs.webkit.org/show_bug.cgi?id=96722
982 Caused LocaleWinTest.localizedNumberRoundTrip to fail
983 (Requested by keishi on #webkit).
985 * tests/LocaleWinTest.cpp:
986 (testNumberIsReversible):
990 2012-09-13 Keishi Hattori <keishi@webkit.org>
992 Create Localizer factory method for LocaleWin
993 https://bugs.webkit.org/show_bug.cgi?id=96667
995 Reviewed by Kent Tamura.
997 * tests/LocaleWinTest.cpp:
998 (testNumberIsReversible):
1001 2012-09-13 Joshua Bell <jsbell@chromium.org>
1003 IndexedDB: Consolidate two-phase connection to avoid race conditions
1004 https://bugs.webkit.org/show_bug.cgi?id=90411
1006 Reviewed by Tony Chang.
1008 API plumbing for simplified single-phase connection opening, and tests updated
1009 to exercise the new APIs.
1011 * public/WebIDBDatabase.h:
1012 (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
1013 * public/WebIDBFactory.h:
1016 (WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
1017 * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
1018 (WebKit::IDBCallbacksProxy::onSuccess):
1019 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1021 (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
1022 the db-callbacks and hook it up when the onSuccess callback comes through.
1023 * src/IDBCallbacksProxy.h:
1025 (IDBCallbacksProxy):
1026 * src/IDBDatabaseBackendProxy.cpp:
1027 * src/IDBDatabaseBackendProxy.h:
1028 (IDBDatabaseBackendProxy):
1029 * src/IDBFactoryBackendProxy.cpp:
1030 (WebKit::IDBFactoryBackendProxy::open):
1031 * src/IDBFactoryBackendProxy.h:
1032 (IDBFactoryBackendProxy):
1033 * src/WebIDBDatabaseImpl.cpp:
1034 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1035 (WebKit::WebIDBDatabaseImpl::close):
1036 * src/WebIDBDatabaseImpl.h:
1037 (WebIDBDatabaseImpl):
1038 * src/WebIDBFactoryImpl.cpp:
1039 (WebKit::WebIDBFactoryImpl::open):
1040 * src/WebIDBFactoryImpl.h:
1041 (WebIDBFactoryImpl):
1042 * tests/IDBAbortOnCorruptTest.cpp:
1043 (FakeIDBDatabaseCallbacks):
1044 (WebCore::FakeIDBDatabaseCallbacks::create):
1045 (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
1046 (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
1048 (WebCore::TEST): Updated connection sequence.
1049 * tests/IDBDatabaseBackendTest.cpp: Ditto.
1051 2012-09-13 James Robinson <jamesr@chromium.org>
1053 PlatformGestureCurveTest compile fix pt 2
1055 * tests/PlatformGestureCurveTest.cpp:
1057 2012-09-13 James Robinson <jamesr@chromium.org>
1059 Fix compile warning/error on windows - literal that isn't exactly representable as a float needs "f" suffix.
1061 * tests/PlatformGestureCurveTest.cpp:
1063 2012-09-13 Julien Chaffraix <jchaffraix@webkit.org>
1065 [Chromium] REGRESSION(r127457): Context menu on textarea is displayed in the wrong place
1066 https://bugs.webkit.org/show_bug.cgi?id=96593
1068 Reviewed by Adam Barth.
1070 After r127457, the HitTestResult stored in ContextMenuController is in window coordinates.
1071 Trying to convert it again to window coordinates will result in adding the containing frame's
1072 position twice, thus the wrong placing.
1074 Chromium Mac wasn't impacted by the regression and I manually checked that the fix doesn't impact Mac.
1076 Unfortunately, no test as I don't think we have a way of testing context menu position.
1078 * src/ContextMenuClientImpl.cpp:
1079 (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1081 2012-09-13 Robert Kroeger <rjkroege@chromium.org>
1083 [chromium] alter fling animation parameters.
1084 https://bugs.webkit.org/show_bug.cgi?id=96666
1086 Reviewed by Adrienne Walker.
1088 Corrected the test to be non-fragile in the presence of altered fling
1091 * tests/PlatformGestureCurveTest.cpp:
1093 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
1095 Unreviewed, rolling out r128489.
1096 http://trac.webkit.org/changeset/128489
1097 https://bugs.webkit.org/show_bug.cgi?id=96686
1099 Does not compile on windows (Requested by jamesr on #webkit).
1101 * public/WebIDBDatabase.h:
1102 * public/WebIDBFactory.h:
1104 * src/IDBCallbacksProxy.cpp:
1105 (WebKit::IDBCallbacksProxy::onSuccess):
1106 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1107 * src/IDBCallbacksProxy.h:
1109 (IDBCallbacksProxy):
1110 * src/IDBDatabaseBackendProxy.cpp:
1111 (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
1113 * src/IDBDatabaseBackendProxy.h:
1114 (IDBDatabaseBackendProxy):
1115 * src/IDBFactoryBackendProxy.cpp:
1116 (WebKit::IDBFactoryBackendProxy::open):
1117 * src/IDBFactoryBackendProxy.h:
1118 (IDBFactoryBackendProxy):
1119 * src/WebIDBDatabaseImpl.cpp:
1120 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1121 (WebKit::WebIDBDatabaseImpl::close):
1122 (WebKit::WebIDBDatabaseImpl::open):
1124 * src/WebIDBDatabaseImpl.h:
1125 (WebIDBDatabaseImpl):
1126 * src/WebIDBFactoryImpl.cpp:
1127 (WebKit::WebIDBFactoryImpl::open):
1128 * src/WebIDBFactoryImpl.h:
1129 (WebIDBFactoryImpl):
1130 * tests/IDBAbortOnCorruptTest.cpp:
1132 * tests/IDBDatabaseBackendTest.cpp:
1134 2012-09-13 Glenn Hartmann <hartmanng@chromium.org>
1136 Add new accelerated compositing for overflow scroll setting.
1137 https://bugs.webkit.org/show_bug.cgi?id=95885
1139 Reviewed by James Robinson.
1141 wkb.ug/91117 introduces RenderLayer::usesCompositedScrolling(), which
1142 currently returns true if we're overflow scrolling and the element has
1143 been styled with '-webkit-overflow-scrolling: touch'. If this is true,
1144 we get promoted to a composited layer, the associated RenderLayerBacking
1145 gets special scrolling layers and in response to RenderLayer::scrollTo()
1146 we no longer have to invalidate everything to get the scrolled content
1147 in the right spot, thereby avoiding very expensive repaints. It's
1148 unfortunate that we require -webkit-overflow-scrolling: touch, though.
1149 It would be nice if RenderLayer::usesCompositedScrolling() returned true
1150 if the page would continue to behave correctly. This is what
1151 wkb.ug/94743 is intended to do. Unfortunately, when we become a
1152 composited layer, we switch from subpixel to grayscale anti-aliasing. We
1153 only want to auto-opt into composited scrolling if we don't mind the
1154 change in anti-aliasing, so we need a flag to enable/disable this
1157 * public/WebSettings.h:
1158 * src/WebSettingsImpl.cpp:
1159 (WebKit::WebSettingsImpl::setAcceleratedCompositingForOverflowScrollEnabled):
1161 * src/WebSettingsImpl.h:
1164 2012-09-13 Joshua Bell <jsbell@chromium.org>
1166 IndexedDB: Consolidate two-phase connection to avoid race conditions
1167 https://bugs.webkit.org/show_bug.cgi?id=90411
1169 Reviewed by Tony Chang.
1171 API plumbing for simplified single-phase connection opening, and tests updated
1172 to exercise the new APIs.
1174 * public/WebIDBDatabase.h:
1175 (WebIDBDatabase): Just a FIXME to remove the old second-phase hookup API.
1176 * public/WebIDBFactory.h:
1179 (WebKit::WebIDBFactory::open): New overload that takes db-callbacks.
1180 * src/IDBCallbacksProxy.cpp: The db-callbacks plumbing is needed earlier.
1181 (WebKit::IDBCallbacksProxy::onSuccess):
1182 (WebKit::IDBCallbacksProxy::onUpgradeNeeded):
1184 (WebKit::IDBCallbacksProxy::setDatabaseCallbacks): Needs to hold on to
1185 the db-callbacks and hook it up when the onSuccess callback comes through.
1186 * src/IDBCallbacksProxy.h:
1188 (IDBCallbacksProxy):
1189 * src/IDBDatabaseBackendProxy.cpp:
1190 * src/IDBDatabaseBackendProxy.h:
1191 (IDBDatabaseBackendProxy):
1192 * src/IDBFactoryBackendProxy.cpp:
1193 (WebKit::IDBFactoryBackendProxy::open):
1194 * src/IDBFactoryBackendProxy.h:
1195 (IDBFactoryBackendProxy):
1196 * src/WebIDBDatabaseImpl.cpp:
1197 (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1198 (WebKit::WebIDBDatabaseImpl::close):
1199 * src/WebIDBDatabaseImpl.h:
1200 (WebIDBDatabaseImpl):
1201 * src/WebIDBFactoryImpl.cpp:
1202 (WebKit::WebIDBFactoryImpl::open):
1203 * src/WebIDBFactoryImpl.h:
1204 (WebIDBFactoryImpl):
1205 * tests/IDBAbortOnCorruptTest.cpp:
1206 (FakeIDBDatabaseCallbacks):
1207 (WebCore::FakeIDBDatabaseCallbacks::create):
1208 (WebCore::FakeIDBDatabaseCallbacks::~FakeIDBDatabaseCallbacks):
1209 (WebCore::FakeIDBDatabaseCallbacks::FakeIDBDatabaseCallbacks):
1211 (WebCore::TEST): Updated connection sequence.
1212 * tests/IDBDatabaseBackendTest.cpp: Ditto.
1214 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
1216 Unreviewed. Rolled DEPS.
1220 2012-09-13 Ilya Tikhonovsky <loislo@chromium.org>
1222 Web Inspector: NMI: instrument KURL directly.
1223 https://bugs.webkit.org/show_bug.cgi?id=96624
1225 Reviewed by Yury Semikhatsky.
1227 I replaced traits based instrumentation of KURL with reportMemoryUsage functions.
1228 CString* were also instrumented.
1230 Drive by fix: Instrumentation code in QualifiedName was moved to cpp.
1232 * tests/MemoryInstrumentationTest.cpp:
1234 (InstrumentedOwner):
1235 (WebCore::InstrumentedOwner::InstrumentedOwner):
1236 (WebCore::InstrumentedOwner::reportMemoryUsage):
1239 2012-09-13 Sheriff Bot <webkit.review.bot@gmail.com>
1241 Unreviewed, rolling out r128409.
1242 http://trac.webkit.org/changeset/128409
1243 https://bugs.webkit.org/show_bug.cgi?id=96622
1245 It broke Chromium browser_tests (Requested by tkent on
1248 * src/WebFrameImpl.cpp:
1249 (WebKit::WebFrameImpl::scopeStringMatches):
1250 (WebKit::WebFrameImpl::shouldScopeMatches):
1252 2012-09-13 Taiju Tsuiki <tzik@chromium.org>
1254 Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call.
1255 https://bugs.webkit.org/show_bug.cgi?id=96601
1257 Reviewed by Kent Tamura.
1259 m_webFrame might be already deleted after terminateWorkerContext call.
1260 This patch ensure it be NULL and change to avoid using it.
1262 Test: fast/filesystem/workers/detached-frame-crash.html
1264 * src/WebWorkerClientImpl.cpp:
1265 (WebKit::WebWorkerClientImpl::terminateWorkerContext):
1266 (WebKit::WebWorkerClientImpl::openFileSystem):
1268 2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org>
1270 [Chromium] Fix cases where find-in-page doesn't send a final update
1271 https://bugs.webkit.org/show_bug.cgi?id=96402
1273 Fix some issues in the WebKit implementation that prevented to send a final
1274 reportFindInPageMatchCount message.
1276 Reviewed by Adam Barth.
1278 * src/WebFrameImpl.cpp:
1279 (WebKit::WebFrameImpl::scopeStringMatches):
1280 (WebKit::WebFrameImpl::shouldScopeMatches):
1282 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1284 Unreviewed, rolling out r127876.
1285 http://trac.webkit.org/changeset/127876
1286 https://bugs.webkit.org/show_bug.cgi?id=96600
1288 mouse click doesn't work for spin button if spin button in
1289 iframe (Requested by yosin on #webkit).
1291 * src/ContextMenuClientImpl.cpp:
1292 (WebKit::selectMisspelledWord):
1293 * src/FrameLoaderClientImpl.cpp:
1294 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
1295 * src/WebFrameImpl.cpp:
1296 (WebKit::WebFrameImpl::characterIndexForPoint):
1297 * src/WebPluginContainerImpl.cpp:
1298 (WebKit::WebPluginContainerImpl::isRectTopmost):
1299 * src/WebViewImpl.cpp:
1300 (WebKit::WebViewImpl::handleMouseUp):
1301 (WebKit::WebViewImpl::computeBlockBounds):
1303 2012-09-12 Rick Byers <rbyers@chromium.org>
1305 [chromium] Remove unused WebGestureEvent fields
1306 https://bugs.webkit.org/show_bug.cgi?id=95496
1308 Reviewed by Adam Barth.
1310 Remove the no-longer used fields from WebGestureEvent, now that
1311 chromium has been updated to use the per-event-type fields instead.
1312 This depends on crrev.com/156346 in chromium.
1314 * public/WebInputEvent.h:
1315 (WebKit::WebGestureEvent::WebGestureEvent):
1316 * public/android/WebInputEventFactory.h:
1317 * src/WebInputEvent.cpp:
1318 (SameSizeAsWebGestureEvent):
1319 * src/android/WebInputEventFactory.cpp:
1321 (WebKit::WebInputEventFactory::gestureEvent):
1323 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1325 Unreviewed, rolling out r128351.
1326 http://trac.webkit.org/changeset/128351
1327 https://bugs.webkit.org/show_bug.cgi?id=96573
1329 Broke FindInPage browser_tests (Requested by jamesr_ on
1332 * src/WebFrameImpl.cpp:
1333 (WebKit::WebFrameImpl::scopeStringMatches):
1334 (WebKit::WebFrameImpl::cancelPendingScopingEffort):
1335 (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
1336 (WebKit::WebFrameImpl::shouldScopeMatches):
1338 2012-09-12 Adrienne Walker <enne@google.com>
1340 [chromium] Fix search tickmarks not disappearing when compositing is enabled
1341 https://bugs.webkit.org/show_bug.cgi?id=96536
1343 Reviewed by James Robinson.
1345 view->invalidateRect() on the root frame just invalidates the
1346 contents, since WebViewImpl doesn't know anything about scrollbar
1347 layers. This causes an "InvalidateAll" to not actually invalidate the
1350 To fix this, make WebFrameImpl explicitly invalidate the
1351 scrollbars when required.
1353 * src/WebFrameImpl.cpp:
1354 (WebKit::WebFrameImpl::invalidateArea):
1356 2012-09-12 Leandro Gracia Gil <leandrogracia@chromium.org>
1358 [Chromium] Fix cases where find-in-page doesn't send a final update
1359 https://bugs.webkit.org/show_bug.cgi?id=96402
1361 Fix some issues in the WebKit implementation that prevented to send a final
1362 reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
1363 when calling the stopFinding method.
1365 Reviewed by Adam Barth.
1367 * src/WebFrameImpl.cpp:
1368 (WebKit::WebFrameImpl::scopeStringMatches):
1369 (WebKit::WebFrameImpl::cancelPendingScopingEffort):
1370 (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
1371 (WebKit::WebFrameImpl::shouldScopeMatches):
1373 2012-09-12 Sami Kyostila <skyostil@google.com>
1375 Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
1376 https://bugs.webkit.org/show_bug.cgi?id=96251
1378 Reviewed by Simon Fraser.
1380 Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
1381 the feature it controls.
1385 2012-09-12 Christopher Cameron <ccameron@chromium.org>
1387 [chromium] Evict textures through the texture manager instead of the resource provider
1388 https://bugs.webkit.org/show_bug.cgi?id=96463
1390 Reviewed by James Robinson.
1392 Update layer tree host impl test to include the extra interface functions
1393 added to CCLayerTreeHostImplClient.
1395 * tests/CCLayerTreeHostImplTest.cpp:
1397 2012-09-12 Ilya Tikhonovsky <loislo@chromium.org>
1399 Web Inspector: NMI move String* instrumentation to wtf.
1400 https://bugs.webkit.org/show_bug.cgi?id=96405
1402 Reviewed by Yury Semikhatsky.
1404 This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
1406 Tested by webkit_unit_tests.
1408 * tests/MemoryInstrumentationTest.cpp:
1411 2012-09-12 Philippe Liard <pliard@google.com>
1413 Depend on {base,net} GYP targets rather than {base,net}_java.
1414 https://bugs.webkit.org/show_bug.cgi?id=95690
1416 Reviewed by Adam Barth.
1418 {base,net}_java became 'private' targets on the Chromium side that
1419 clients should not depend on (see
1420 https://chromiumcodereview.appspot.com/10913083/).
1421 This also adds the missing 'chromium_net.jar' to |input_jars_paths|
1422 that was magically included in Chrome for Android downstream but not
1423 upstream. It's needed to register JNI for 'net' in webkit_unit_tests.
1426 * WebKitUnitTests.gyp:
1428 2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1430 Unreviewed, rolling out r128279.
1431 http://trac.webkit.org/changeset/128279
1432 https://bugs.webkit.org/show_bug.cgi?id=96487
1434 "Snow Leopard compilation broken" (Requested by yurys on
1437 * tests/MemoryInstrumentationTest.cpp:
1438 (WebCore::InstrumentedUndefined::reportMemoryUsage):
1441 2012-09-12 Ilya Tikhonovsky <loislo@chromium.org>
1443 Web Inspector: NMI move String* instrumentation to wtf.
1444 https://bugs.webkit.org/show_bug.cgi?id=96405
1446 Reviewed by Yury Semikhatsky.
1448 This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
1450 Tested by webkit_unit_tests.
1452 * tests/MemoryInstrumentationTest.cpp:
1453 (WebCore::InstrumentedUndefined::reportMemoryUsage):
1456 2012-09-12 Jochen Eisinger <jochen@chromium.org>
1458 [chromium] consumable user gesture count off for input events
1459 https://bugs.webkit.org/show_bug.cgi?id=96373
1461 Reviewed by Adam Barth.
1463 Don't create a UserGestureIndicator in the chromium layer, as it will
1464 already be created by webcore's event handler. Creating multiple
1465 UserGestureIndicator objects for the same object would allow to execute
1466 multiple user-gesture-gated actions per user gesture such as opening a
1469 * public/WebInputEvent.h:
1470 * src/WebViewImpl.cpp:
1471 (WebKit::WebViewImpl::handleInputEvent):
1473 2012-09-12 Alexandre Elias <aelias@chromium.org>
1475 [chromium] Flip Y and swizzle inside compositeAndReadback implementation
1476 https://bugs.webkit.org/show_bug.cgi?id=96458
1478 Reviewed by James Robinson.
1480 Currently, compositeAndReadback API assumes a GL-style texture
1481 and is converted to the normal software format in WebViewImpl.
1482 For the software implementation, this API would result in two
1483 redundant conversions. This patch makes the conversion inside
1484 CCRendererGL instead. I rolled my own for loop as I didn't find the
1485 appropriate function within raw Skia.
1487 No new tests (covered by existing layout tests).
1489 * src/WebViewImpl.cpp:
1490 (WebKit::WebViewImpl::doPixelReadbackToCanvas):
1492 2012-09-11 Taiju Tsuiki <tzik@chromium.org>
1494 WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem
1495 https://bugs.webkit.org/show_bug.cgi?id=96354
1497 Reviewed by Kent Tamura.
1499 Ensure non-NULL before using WebFrameImpl::client().
1501 Test: fast/filesystem/workers/detached-frame-crash.html
1503 * src/WebWorkerClientImpl.cpp:
1504 (WebKit::WebWorkerClientImpl::openFileSystem):
1506 2012-09-11 Keishi Hattori <keishi@webkit.org>
1508 Create Localizer factory method for LocaleICU
1509 https://bugs.webkit.org/show_bug.cgi?id=96363
1511 Reviewed by Kent Tamura.
1513 * tests/LocalizedNumberICUTest.cpp:
1514 (testNumberIsReversible):
1515 (testDecimalSeparator):
1517 2012-09-11 Christopher Cameron <ccameron@chromium.org>
1519 [chromium] Make prioritized texture manager not touch backings array on the main thread
1520 https://bugs.webkit.org/show_bug.cgi?id=96114
1522 Reviewed by James Robinson.
1524 Take a snapshot of the textures' priorities from the main thread,
1525 and save it in their backings for access by the impl thread.
1526 Update functions that access the sorted backings array to use the
1527 snapshotted values instead of the values that the main thread may
1528 have computed for the next frame.
1530 Make the main thread not touch the m_backings array. Split
1531 prioritizeTextures into a updateBackingsPriorities function.
1532 In places where the main thread would have touched m_backings,
1533 set a flag specifying that m_backings needs to be re-sorted
1534 before any function that requires it be sorted by priority be
1537 Update the two functions that require sorted order (acquireBacking
1538 and reduceMemory) to sort the backings array (if needed) before
1541 Updated tests to set correct thread during asserts. Add a test to
1542 verify that requestLate is correctly incorporated into the backing
1545 * tests/CCPrioritizedTextureTest.cpp:
1546 (WTF::CCPrioritizedTextureTest::validateTexture):
1548 2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com>
1550 Unreviewed. Rolled DEPS.
1554 2012-09-11 Iain Merrick <husky@chromium.org>
1556 [chromium] Fix double call to scrollBegin() when handling scroll gesture
1557 https://bugs.webkit.org/show_bug.cgi?id=95322
1559 Reviewed by James Robinson.
1561 WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its
1562 client, then if the result is ScrollStarted, it creates a PlatformGestureCurve
1563 object to handle the fling animation. This patch adds a matching scrollEnd()
1564 before the animation starts.
1566 Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all
1567 unexpected calls into test failures. This ensures that scrollBegin / scrollEnd
1568 happen exactly when we want and at no other times.
1570 * src/WebCompositorInputHandlerImpl.cpp:
1571 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1572 * tests/WebCompositorInputHandlerImplTest.cpp:
1573 (WebCompositorInputHandlerImplTest):
1576 2012-09-11 Peter Beverloo <peter@chromium.org>
1578 Unreviewed. Rolled DEPS.
1582 2012-09-11 Keishi Hattori <keishi@webkit.org>
1584 Create Localizer factory method for LocaleMac
1585 https://bugs.webkit.org/show_bug.cgi?id=96355
1587 Reviewed by Kent Tamura.
1589 * tests/LocaleMacTest.cpp:
1590 (testNumberIsReversible): Use Localizer::create.
1593 2012-09-11 Sheriff Bot <webkit.review.bot@gmail.com>
1595 Unreviewed, rolling out r128150.
1596 http://trac.webkit.org/changeset/128150
1597 https://bugs.webkit.org/show_bug.cgi?id=96357
1599 it broke chromium compilation (Requested by loislo on
1604 2012-09-10 Sheriff Bot <webkit.review.bot@gmail.com>
1606 Unreviewed. Rolled DEPS.
1610 2012-09-10 Joanmarie Diggs <jdiggs@igalia.com>
1612 Properly expose <legend> elements to ATs
1613 https://bugs.webkit.org/show_bug.cgi?id=84137
1615 Reviewed by Chris Fleizach.
1617 Created a new WebCore Accessibility Role, LegendRole. Used it to map to
1618 the expected platform role, ATK_ROLE_LABEL. Also established the needed
1619 AtkRelation pair, label-for/labelled-by between the legend and fieldset.
1621 * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend
1622 * src/AssertMatchingEnums.cpp: added the assert matching rule for
1623 WebAccessibilityRoleLegend and LegendRole
1625 2012-09-10 Beth Dakin <bdakin@apple.com>
1627 https://bugs.webkit.org/show_bug.cgi?id=96158
1628 Need API to suppress scrollbar animations
1630 <rdar://problem/12210972>
1632 Reviewed by Sam Weinig.
1634 ScrollableArea::isOnActivePage() has been re-named to
1635 ScrollableArea:: scrollbarsCanBeActive().
1636 * src/ScrollbarGroup.cpp:
1637 (WebKit::ScrollbarGroup::scrollbarsCanBeActive):
1638 * src/ScrollbarGroup.h:
1639 * tests/GraphicsLayerChromiumTest.cpp:
1640 * tests/ScrollAnimatorNoneTest.cpp:
1641 (MockScrollableArea):
1643 2012-09-10 Dan Alcantara <dfalcantara@chromium.org>
1645 [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in
1646 https://bugs.webkit.org/show_bug.cgi?id=90222
1648 Reviewed by Adam Barth.
1650 When reloading a page with an overridden URL, the page's scroll and zoom
1651 state will be restored once the reload is complete. This is problematic
1652 in situations when switching between mobile and desktop versions of the
1653 same site because it will zoom back in on a random part of alternate page.
1654 This CL just avoids that situation by resetting the zoom and scale whenever
1655 this type of reload occurs.
1657 Chromium half: https://chromiumcodereview.appspot.com/10889019
1661 * src/WebViewImpl.cpp:
1662 (WebKit::WebViewImpl::resetScrollAndScaleState):
1664 * src/WebViewImpl.h:
1667 2012-09-10 Adam Barth <abarth@chromium.org>
1669 [V8] V8AuxiliaryContext used by IDB leaks memory
1670 https://bugs.webkit.org/show_bug.cgi?id=96317
1672 Reviewed by Tony Chang.
1674 Call the V8 APIs directly instead of using a helper class.
1676 * tests/IDBBindingUtilitiesTest.cpp:
1679 2012-09-10 Adam Barth <abarth@chromium.org>
1681 [V8] Inline firstFrame and currentFrame into their unique callers
1682 https://bugs.webkit.org/show_bug.cgi?id=96309
1684 Reviewed by Eric Seidel.
1686 This patch just lines these WebCore functions because we only call them
1689 * src/WebFrameImpl.cpp:
1690 (WebKit::WebFrame::frameForEnteredContext):
1691 (WebKit::WebFrame::frameForCurrentContext):
1693 2012-09-10 Rick Byers <rbyers@chromium.org>
1695 [chromium] Add unused GestureTapCancel
1696 https://bugs.webkit.org/show_bug.cgi?id=96183
1698 Reviewed by Adam Barth.
1700 This adds a new 'tap cancel' gesture type. This is temporarily unused,
1701 so that we can change chromium to start sending the gesture type
1702 without breaking anything.
1704 * public/WebInputEvent.h:
1705 * src/PageWidgetDelegate.cpp:
1706 (WebKit::PageWidgetDelegate::handleInputEvent):
1707 * src/WebInputEventConversion.cpp:
1708 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1709 * src/WebPopupMenuImpl.cpp:
1710 (WebKit::WebPopupMenuImpl::handleInputEvent):
1711 * src/WebViewImpl.cpp:
1712 (WebKit::WebViewImpl::handleGestureEvent):
1714 2012-09-10 Mark Pilgrim <pilgrim@chromium.org>
1716 [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
1717 https://bugs.webkit.org/show_bug.cgi?id=95861
1719 Reviewed by Adam Barth.
1721 Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport.
1723 * public/WebSharedWorkerRepository.h:
1725 * src/SharedWorkerRepository.cpp:
1727 (WebKit::setSharedWorkerRepository):
1728 (WebKit::sharedWorkerRepository):
1729 (WebCore::SharedWorkerRepository::isAvailable):
1730 (WebCore::SharedWorkerRepository::connect):
1731 (WebCore::SharedWorkerRepository::documentDetached):
1732 (WebCore::SharedWorkerRepository::hasSharedWorkers):
1734 2012-09-10 Catalin Badea <badea@adobe.com>
1736 webkit build for 64-bit Mac chromium
1737 https://bugs.webkit.org/show_bug.cgi?id=95977
1739 Reviewed by Eric Seidel.
1741 Ensure header completeness and use the correct include order. This fixes a compilation issues noticeable when building chromium for 64-bit Mac.
1743 * public/mac/WebSubstringUtil.h:
1744 * src/mac/WebSubstringUtil.mm:
1746 2012-09-10 Adrienne Walker <enne@google.com>
1748 [chromium] Fix deadlock between WebMediaPlayerClientImpl dtor and PutCurrentFrame
1749 https://bugs.webkit.org/show_bug.cgi?id=96010
1751 Reviewed by James Robinson.
1753 The key fix here is that the destructor no longer has a mutex.
1754 The m_compositingMutex was supposedly protecting races between
1755 ~WebMediaPlayerClientImpl and setVideoFrameProviderClient. The
1756 former is only called from the main thread and the latter is called
1757 from the compositor thread only when the main thread is blocked (and
1758 it already asserts that this is the case).
1760 In addition, the m_providerMutex in CCVideoLayerImpl prevents the
1761 destruction of WebMediaPlayerClientImpl, thus keeping the frame
1762 acquired via getCurrentFrame alive until putCurrentFrame is called.
1763 These functions are only called by the client, and comments are added
1764 to the interface to better document this.
1766 To prevent a race between load() and getCurrentFrame/putCurrentFrame
1767 (which are called from different threads) a new m_webMediaPlayerMutex
1768 to replace part of what the old m_compositingMutex was doing.
1770 * src/WebMediaPlayerClientImpl.cpp:
1771 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
1772 (WebKit::WebMediaPlayerClientImpl::load):
1773 (WebKit::WebMediaPlayerClientImpl::loadInternal):
1774 (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
1775 (WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
1776 (WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
1777 * src/WebMediaPlayerClientImpl.h:
1778 (WebMediaPlayerClientImpl):
1780 2012-09-10 Rick Byers <rbyers@chromium.org>
1782 [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment
1783 https://bugs.webkit.org/show_bug.cgi?id=95996
1785 Reviewed by Adam Barth.
1787 Switch from WebGestureEvent.boundingBox to new gesture-type specific
1789 * src/WebViewImpl.cpp:
1790 (WebKit::WebViewImpl::handleGestureEvent):
1792 2012-09-09 Keishi Hattori <keishi@webkit.org>
1794 REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup
1795 https://bugs.webkit.org/show_bug.cgi?id=96222
1797 Reviewed by Kent Tamura.
1799 DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser()
1800 so we shouldn't be changing the members after that.
1802 Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html.
1804 * src/DateTimeChooserImpl.cpp:
1805 (WebKit::DateTimeChooserImpl::didClosePopup):
1807 2012-09-09 Kenichi Ishibashi <bashi@chromium.org>
1809 [Chromium] Unreviewed gardening after r127907
1811 Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads
1813 * tests/CCRenderPassTest.cpp:
1814 (CCRenderPassSize): Changed type of m_id
1816 2012-09-09 Emil A Eklund <eae@chromium.org>
1818 Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
1819 https://bugs.webkit.org/show_bug.cgi?id=81413
1821 Reviewed by David Hyatt.
1823 Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.
1825 * src/WebViewImpl.cpp:
1826 (WebKit::WebViewImpl::computeBlockBounds):
1827 (WebKit::WebViewImpl::applyAutofillSuggestions):
1828 (WebKit::WebViewImpl::refreshAutofillPopup):
1830 2012-09-09 James Robinson <jamesr@chromium.org>
1832 [chromium] webkit_platform should only be linked into the webkit target
1833 https://bugs.webkit.org/show_bug.cgi?id=96213
1835 Reviewed by Adrienne Walker.
1837 The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
1838 makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.
1842 2012-09-09 James Robinson <jamesr@chromium.org>
1844 [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
1845 https://bugs.webkit.org/show_bug.cgi?id=96212
1847 Reviewed by Adrienne Walker.
1849 The static ::create()s the test references currently are going away soon.
1851 * tests/GraphicsLayerChromiumTest.cpp:
1852 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1855 2012-09-07 Benjamin Poulain <benjamin@webkit.org>
1857 Unreviewed prospective build fix.
1859 * tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.
1860 Remove the using directive from r127959.
1862 2012-09-07 Simon Hausmann <simon.hausmann@nokia.com>
1864 Unreviewed prospective build fix.
1866 Use WTF namespace like in other files in the same directory to resolve unqualified
1869 * tests/WebCompositorInputHandlerImplTest.cpp:
1871 2012-09-07 James Robinson <jamesr@chromium.org>
1873 [chromium] Remove transitional WebCompositorSupport fallback code
1874 https://bugs.webkit.org/show_bug.cgi?id=96155
1876 Reviewed by Adrienne Walker.
1878 * src/LinkHighlight.cpp:
1879 (WebKit::LinkHighlight::LinkHighlight):
1880 (WebKit::LinkHighlight::startHighlightAnimation):
1881 * src/WebMediaPlayerClientImpl.cpp:
1882 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
1883 * src/WebPluginContainerImpl.cpp:
1884 (WebKit::WebPluginContainerImpl::setBackingTextureId):
1885 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
1886 * src/WebViewImpl.cpp:
1887 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1890 2012-09-07 James Robinson <jamesr@chromium.org>
1892 [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
1893 https://bugs.webkit.org/show_bug.cgi?id=96151
1895 Reviewed by Adrienne Walker.
1897 Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
1898 WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
1899 provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.
1901 WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
1902 and storing its identifier for the didActivateCompositor call. From this point on the setup is the same as
1905 WCIHI changes covered by unit tests, overall scrolling behavior manually tested.
1908 * src/WebCompositorInputHandlerImpl.cpp:
1909 (WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
1910 (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
1911 (WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
1912 (WebKit::WebCompositorInputHandlerImpl::setClient):
1913 (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
1914 (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
1915 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1916 (WebKit::WebCompositorInputHandlerImpl::bindToClient):
1917 * src/WebCompositorInputHandlerImpl.h:
1918 (WebCompositorInputHandlerImpl):
1919 (WebKit::WebCompositorInputHandlerImpl::identifier):
1920 * src/WebLayerTreeViewImpl.cpp:
1921 (WebKit::WebLayerTreeViewImpl::createInputHandler):
1923 * src/WebLayerTreeViewImpl.h:
1924 (WebLayerTreeViewImpl):
1925 * src/WebToCCInputHandlerAdapter.cpp: Added.
1927 (WebKit::WebToCCInputHandlerAdapter::create):
1928 (WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
1929 (WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
1930 (WebToCCInputHandlerAdapter::ClientAdapter):
1931 (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
1932 (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
1933 (WebKit::WebToCCInputHandlerAdapter::bindToClient):
1934 (WebKit::WebToCCInputHandlerAdapter::animate):
1935 * src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.
1937 (WebToCCInputHandlerAdapter):
1938 * src/WebViewImpl.cpp:
1939 (WebKit::WebViewImpl::WebViewImpl):
1940 (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1942 (WebKit::WebViewImpl::createInputHandler):
1943 * src/WebViewImpl.h:
1945 * tests/CCThreadedTest.cpp:
1946 * tests/FakeCCLayerTreeHostClient.h:
1947 * tests/WebCompositorInputHandlerImplTest.cpp:
1948 (MockWebInputHandlerClient):
1949 (WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
1950 (WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
1951 (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
1952 (WebCompositorInputHandlerImplTest):
1955 2012-09-07 David Reveman <reveman@chromium.org>
1957 [Chromium] Multiple commits without invalidation allowed per redraw.
1958 https://bugs.webkit.org/show_bug.cgi?id=95661
1960 Reviewed by James Robinson.
1962 * tests/CCLayerTreeHostTest.cpp:
1963 (CCLayerTreeHostTestContinuousCommit):
1964 (WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
1966 (WebKitTests::TEST_F):
1967 (CCLayerTreeHostTestContinuousInvalidate):
1968 (WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
1969 (CCLayerTreeHostTestContinuousAnimate):
1970 (WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):
1971 * tests/CCSchedulerStateMachineTest.cpp:
1974 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
1976 AX: WebCore accessibility roles should be cross-platform
1977 https://bugs.webkit.org/show_bug.cgi?id=94870
1979 Reviewed by Chris Fleizach.
1981 Add a new accessibility role.
1983 * public/WebAccessibilityRole.h:
1984 * src/AssertMatchingEnums.cpp:
1986 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
1988 AX: Chromium needs access to canvasHasFallbackContent
1989 https://bugs.webkit.org/show_bug.cgi?id=96124
1991 Reviewed by Chris Fleizach.
1993 Expose canvasHasFallbackContent on Chromium.
1995 * public/WebAccessibilityObject.h:
1996 (WebAccessibilityObject):
1997 * src/WebAccessibilityObject.cpp:
1998 (WebKit::WebAccessibilityObject::canvasHasFallbackContent):
2001 2012-09-07 Robert Kroeger <rjkroege@chromium.org>
2003 [chromium] Add touchscreen specific fling curve parametrization
2004 https://bugs.webkit.org/show_bug.cgi?id=95997
2006 Reviewed by James Robinson.
2008 Added a new set of fling curve parameters with a good feel for touchscreen
2009 initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
2010 TouchFlingPlatformGestureCurve to better reflect that the class
2011 can serve for both touchscreen and touchpad flings when appropriately
2012 parametrized. Updated build files as necessary for the rename.
2014 No new tests - existing tests apply.
2017 * tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.
2019 2012-09-07 Dana Jansens <danakj@chromium.org>
2021 [chromium] Make RenderPass ids hold both generating layer id and an index
2022 https://bugs.webkit.org/show_bug.cgi?id=95500
2024 Reviewed by Adrienne Walker.
2026 * tests/CCLayerTreeHostImplTest.cpp:
2027 * tests/CCLayerTreeHostTest.cpp:
2028 * tests/CCRenderSurfaceTest.cpp:
2029 * tests/CCRendererGLTest.cpp:
2030 (FakeCCRendererClient::FakeCCRendererClient):
2032 2012-09-07 Joshua Bell <jsbell@chromium.org>
2034 [Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
2035 https://bugs.webkit.org/show_bug.cgi?id=96122
2037 Reviewed by Adam Barth.
2039 Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
2040 open() method now takes the "database callbacks", rather than being sent through
2043 Also, delete an obsolete method.
2045 * public/WebIDBFactory.h:
2047 (WebIDBFactory): Delete pre-version overload of open().
2048 (WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.
2050 2012-09-07 Sami Kyostila <skyostil@google.com>
2052 [Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
2053 https://bugs.webkit.org/show_bug.cgi?id=95932
2055 Reviewed by James Robinson.
2057 Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
2060 * tests/GraphicsLayerChromiumTest.cpp:
2061 (WebKit::TEST_F): Re-enable the test.
2063 2012-09-07 James Robinson <jamesr@chromium.org>
2065 [chromium] Move some CC unit tests into correct gyp variable
2066 https://bugs.webkit.org/show_bug.cgi?id=96048
2068 Reviewed by Adrienne Walker.
2070 These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.
2074 2012-09-07 James Robinson <jamesr@chromium.org>
2076 [chromium] Remove dead CCActiveGestureAnimation code and related classes
2077 https://bugs.webkit.org/show_bug.cgi?id=96075
2079 Reviewed by Adrienne Walker.
2081 Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
2082 evaluate the curve itself without intermediate classes.
2084 * src/WebCompositorInputHandlerImpl.cpp:
2085 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
2086 (WebKit::WebCompositorInputHandlerImpl::animate):
2087 (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
2088 * src/WebCompositorInputHandlerImpl.h:
2090 (WebCompositorInputHandlerImpl):
2091 * tests/PlatformGestureCurveTest.cpp:
2092 * tests/WebCompositorInputHandlerImplTest.cpp:
2094 2012-09-07 James Robinson <jamesr@chromium.org>
2096 [chromium] Clean up dependencies in ScrollbarLayerChromiumTest
2097 https://bugs.webkit.org/show_bug.cgi?id=96052
2099 Reviewed by Adrienne Walker.
2101 Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
2102 *) WebScrollbarImpl.h is #included, but not use
2103 *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
2104 WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
2106 * tests/ScrollbarLayerChromiumTest.cpp:
2109 2012-09-07 Dominic Mazzoni <dmazzoni@google.com>
2111 AX: ARIA spin button should support range value attributes
2112 https://bugs.webkit.org/show_bug.cgi?id=96076
2114 Reviewed by Chris Fleizach.
2116 Expose supportsRangeValue to simplify Chromium logic for when to
2117 extract a value from a range.
2119 * public/WebAccessibilityObject.h:
2120 (WebAccessibilityObject):
2121 * src/WebAccessibilityObject.cpp:
2122 (WebKit::WebAccessibilityObject::supportsRangeValue):
2125 2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
2127 Simplify hitTestResultAtPoint and nodesFromRect APIs
2128 https://bugs.webkit.org/show_bug.cgi?id=95720
2130 Reviewed by Antonio Gomes.
2132 Update calls to new API.
2134 * src/ContextMenuClientImpl.cpp:
2135 (WebKit::selectMisspelledWord):
2136 * src/FrameLoaderClientImpl.cpp:
2137 (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
2138 * src/WebFrameImpl.cpp:
2139 (WebKit::WebFrameImpl::characterIndexForPoint):
2140 * src/WebPluginContainerImpl.cpp:
2141 (WebKit::WebPluginContainerImpl::isRectTopmost):
2142 * src/WebViewImpl.cpp:
2143 (WebKit::WebViewImpl::handleMouseUp):
2144 (WebKit::WebViewImpl::computeBlockBounds):
2146 2012-09-07 Ilya Tikhonovsky <loislo@chromium.org>
2148 Web Inspector: NMI: move WebCore specific code to separate header
2149 https://bugs.webkit.org/show_bug.cgi?id=96101
2151 Reviewed by Yury Semikhatsky.
2153 I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h
2155 * tests/MemoryInstrumentationTest.cpp:
2157 2012-09-07 Ian Vollick <vollick@chromium.org>
2159 [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
2160 https://bugs.webkit.org/show_bug.cgi?id=95855
2162 Reviewed by James Robinson.
2164 Added the following unit tests:
2165 AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
2166 AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform
2168 * tests/AnimationTranslationUtilTest.cpp:
2172 2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
2174 X11 Global Selection
2175 https://bugs.webkit.org/show_bug.cgi?id=88238
2177 Reviewed by Tony Chang.
2179 Use new editor command for pasting global selection.
2181 * src/EditorClientImpl.cpp:
2182 (WebKit::EditorClientImpl::supportsGlobalSelection):
2183 * src/EditorClientImpl.h:
2185 * src/WebViewImpl.cpp:
2186 (WebKit::WebViewImpl::handleMouseUp):
2188 2012-09-07 Yoshifumi Inoue <yosin@chromium.org>
2190 We should have a localized string of empty for date time field
2191 https://bugs.webkit.org/show_bug.cgi?id=96081
2193 Reviewed by Kent Tamura.
2195 This patch add a function for getting localized string of empty field
2196 value of date time fields for accessibility inside
2197 ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
2199 These functions will be used by derived classes of DateTimeFieldElement.
2201 Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
2202 to support "date", "datetime", "month" and "week" multiple fields input
2205 * src/LocalizedStrings.cpp:
2206 (WebCore::AXDateTimeFieldEmptyValueText): Added.
2208 2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com>
2210 Unreviewed, rolling out r127822.
2211 http://trac.webkit.org/changeset/127822
2212 https://bugs.webkit.org/show_bug.cgi?id=96073
2214 It broke compilation on chromium debug bots (Requested by
2217 * tests/CCDrawQuadTest.cpp:
2219 * tests/CCLayerTreeHostImplTest.cpp:
2220 * tests/CCLayerTreeHostTest.cpp:
2221 * tests/CCRenderPassTest.cpp:
2223 * tests/CCRenderSurfaceTest.cpp:
2224 * tests/CCRendererGLTest.cpp:
2225 (FakeCCRendererClient::FakeCCRendererClient):
2227 2012-09-06 Dana Jansens <danakj@chromium.org>
2229 [chromium] Make RenderPass ids hold both generating layer id and an index
2230 https://bugs.webkit.org/show_bug.cgi?id=95500
2232 Reviewed by Adrienne Walker.
2234 * tests/CCLayerTreeHostImplTest.cpp:
2235 * tests/CCLayerTreeHostTest.cpp:
2236 * tests/CCRenderSurfaceTest.cpp:
2237 * tests/CCRendererGLTest.cpp:
2238 (FakeCCRendererClient::FakeCCRendererClient):
2240 2012-09-06 Yoshifumi Inoue <yosin@chromium.org>
2242 We should have localized strings of date time fields for accessibility
2243 https://bugs.webkit.org/show_bug.cgi?id=96050
2245 Reviewed by Kent Tamura.
2247 This patch adds functions for getting localized strings of date time
2248 fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
2250 These functions will be used by derived classes of DateTimeFieldElement.
2252 Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
2253 to support "date", "datetime", "month" and "week" multiple fields input
2256 * src/LocalizedStrings.cpp:
2257 (WebCore::AXAMPMFieldText): Added.
2258 (WebCore::AXDayOfMonthFieldText): Added.
2259 (WebCore::AXHourFieldText): Added.
2260 (WebCore::AXMillisecondFieldText): Added.
2261 (WebCore::AXMinuteFieldText): Added.
2262 (WebCore::AXMonthFieldText): Added.
2263 (WebCore::AXSecondFieldText): Added.
2264 (WebCore::AXWeekOfYearFieldText): Added.
2265 (WebCore::AXYearFieldText): Added.
2267 2012-09-06 James Robinson <jamesr@chromium.org>
2269 [chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
2270 https://bugs.webkit.org/show_bug.cgi?id=96024
2272 Reviewed by Adam Barth.
2274 When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
2275 We don't need to link anything in to WebKit.dll.
2279 2012-09-06 James Robinson <jamesr@chromium.org>
2281 [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2282 https://bugs.webkit.org/show_bug.cgi?id=96007
2284 Reviewed by Adrienne Walker.
2286 Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
2287 WebCompositorInitializer RAII class to simplify this somewhat tedious process.
2290 * public/WebCompositorInputHandlerClient.h:
2291 (WebCompositorInputHandlerClient):
2292 * src/WebCompositorInputHandlerImpl.h:
2293 * src/WebViewImpl.cpp:
2294 (WebKit::WebViewImpl::composite):
2295 (WebKit::WebViewImpl::scheduleAnimation):
2296 (WebKit::WebViewImpl::scheduleComposite):
2297 * tests/CCPrioritizedTextureTest.cpp:
2298 (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
2299 (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
2300 (CCPrioritizedTextureTest):
2301 * tests/CCRendererGLTest.cpp:
2302 (CCRendererGLTest::CCRendererGLTest):
2303 (CCRendererGLTest::SetUp):
2305 * tests/CCTextureUpdateControllerTest.cpp:
2306 * tests/CCThreadedTest.cpp:
2307 (WebKitTests::CCThreadedTest::runTest):
2308 * tests/Canvas2DLayerBridgeTest.cpp:
2309 (Canvas2DLayerBridgeTest::fullLifecycleTest):
2310 * tests/GraphicsLayerChromiumTest.cpp:
2311 (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2312 (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
2313 * tests/LayerChromiumTest.cpp:
2314 * tests/LinkHighlightTest.cpp:
2316 * tests/TextureLayerChromiumTest.cpp:
2317 * tests/TiledLayerChromiumTest.cpp:
2318 * tests/WebCompositorInitializer.h: Added.
2321 (WebCompositorInitializer):
2322 (WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
2323 (WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):
2324 * tests/WebCompositorInputHandlerImplTest.cpp:
2326 (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
2327 (WebCompositorInputHandlerImplTest):
2328 * tests/WebLayerTest.cpp:
2329 * tests/WebLayerTreeViewTest.cpp:
2331 2012-09-06 Sheriff Bot <webkit.review.bot@gmail.com>
2333 Unreviewed. Rolled DEPS.
2337 2012-09-06 Alec Flett <alecflett@chromium.org>
2339 IndexedDB: make IDBKeyPath's string and array constructors explicit
2340 https://bugs.webkit.org/show_bug.cgi?id=96004
2342 Reviewed by Tony Chang.
2344 Fix test to use explicit constructor for IDBKeyPath.
2346 * tests/IDBDatabaseBackendTest.cpp:
2348 2012-09-06 Adrienne Walker <enne@google.com>
2350 [chromium] Remove GraphicsContext references from ContentLayerChromiumTest
2351 https://bugs.webkit.org/show_bug.cgi?id=96002
2353 Reviewed by James Robinson.
2355 This is a compositor unit test, so it shouldn't reference things
2356 outside of the compositor like GraphicsContext. The
2357 OpaqueRectTrackingContentLayerDelegateTest already tests opaque
2358 tracking right at the time of paint. This test is about verifying that
2359 transformed canvases work properly, so can just fake the opaque rect
2360 coming back from the paint.
2362 * tests/ContentLayerChromiumTest.cpp:
2363 (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
2366 2012-09-06 Jeff Timanus <twiz@chromium.org>
2368 [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
2369 https://bugs.webkit.org/show_bug.cgi?id=95094
2371 Reviewed by Adrienne Walker.
2373 In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class. This is a first pass to
2374 try to remove the page-scale logic from GraphicsLayerChromium. This change should be a no-op in terms of
2375 contentsScale behaviour.
2376 This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.
2378 * src/NonCompositedContentHost.cpp:
2379 (WebKit::NonCompositedContentHost::NonCompositedContentHost):
2380 Inform the layer associated with the NCCH that it is to disregard the page scale factor.
2381 Also remove now unused m_deviceScaleFactor and associated routines.
2382 (WebKit::NonCompositedContentHost::setViewport):
2383 * src/NonCompositedContentHost.h:
2384 (NonCompositedContentHost):
2385 * src/WebContentLayerImpl.cpp:
2386 (WebKit::WebContentLayerImpl::setBoundsContainPageScale):
2388 (WebKit::WebContentLayerImpl::boundsContainPageScale):
2389 * src/WebContentLayerImpl.h:
2390 (WebContentLayerImpl):
2391 * src/WebViewImpl.cpp:
2392 (WebKit::WebViewImpl::updateLayerTreeViewport):
2393 * tests/CCLayerTreeHostTest.cpp:
2394 (NoScaleContentLayerChromium):
2395 (WebKitTests::NoScaleContentLayerChromium::create):
2396 (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
2398 (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
2399 Rebaselined to correspond to the new behaviour. Because the layers are now assigned a contentsScale, the
2400 scale on the draw transforms remain identity.
2401 * tests/GraphicsLayerChromiumTest.cpp:
2402 (WebKit): Remove now obsolete unit-test.
2404 2012-09-06 Adrienne Walker <enne@google.com>
2406 [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
2407 https://bugs.webkit.org/show_bug.cgi?id=95994
2409 Reviewed by James Robinson.
2411 This compositor test shouldn't depend on code outside the compositor.
2413 * tests/ScrollbarLayerChromiumTest.cpp:
2414 (WebCore::FakeWebScrollbar::create):
2418 2012-09-06 James Robinson <jamesr@chromium.org>
2420 [chromium] Put chromium implementations of WTF symbols in separate static library
2421 https://bugs.webkit.org/show_bug.cgi?id=95933
2423 Reviewed by Adam Barth.
2425 A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
2426 implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
2427 component build is a DLL. This moves these files into a static library that webkit depends on so targets can
2428 statically link in wtf and these support files without depending directly on webkit.
2432 2012-09-06 Iain Merrick <husky@chromium.org>
2434 [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
2435 https://bugs.webkit.org/show_bug.cgi?id=93998
2437 Reviewed by Adam Barth.
2439 These provide the same functionality selectRange(WebPoint, WebPoint),
2440 with finer-grained control needed on the Android platform. By passing
2441 allowCollapsedSelection=false, we can ensure the selection stays at
2442 least one character wide.
2444 I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
2445 calling the new methods. The existing test passes, and I've added new
2446 tests for the new methods.
2448 * public/WebFrame.h:
2450 * src/WebFrameImpl.cpp:
2451 (WebKit::WebFrameImpl::selectRange):
2453 (WebKit::WebFrameImpl::moveSelectionStart):
2454 (WebKit::WebFrameImpl::moveSelectionEnd):
2455 (WebKit::WebFrameImpl::moveCaret):
2456 * src/WebFrameImpl.h:
2458 * tests/WebFrameTest.cpp:
2459 * tests/data/text_selection.html: Added.
2461 2012-09-06 Robert Kroeger <rjkroege@chromium.org>
2463 [chromium] Enable different fling behaviour for touchscreen and touchpad
2464 https://bugs.webkit.org/show_bug.cgi?id=95756
2466 Reviewed by James Robinson.
2468 Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
2469 events by their originating device and pass this flag to a factory that produces
2470 different device specific fling curves based on the value of the flag.
2472 * public/WebActiveWheelFlingParameters.h:
2473 (WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
2474 (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
2475 * public/WebInputEvent.h: Added source device flag to WebGestureEvent.
2476 * src/WebCompositorInputHandlerImpl.cpp:
2477 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling): Use factory to
2478 obtain device-appropriate fling curve.
2479 * src/WebViewImpl.cpp:
2480 (WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
2482 (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
2484 2012-09-05 Sam Weinig <sam@webkit.org>
2486 Part 2 of removing PlatformString.h, remove PlatformString.h
2487 https://bugs.webkit.org/show_bug.cgi?id=95931
2489 Reviewed by Adam Barth.
2491 Remove PlatformString.h
2493 * src/ContextMenuClientImpl.cpp:
2494 * src/EditorClientImpl.cpp:
2495 * src/InspectorFrontendClientImpl.cpp:
2496 * src/LocalFileSystemChromium.cpp:
2497 * src/SpeechInputClientImpl.cpp:
2498 * src/SpeechRecognitionClientProxy.h:
2499 * src/WebDevToolsAgentImpl.cpp:
2500 * src/WebDevToolsFrontendImpl.cpp:
2501 * src/WebDevToolsFrontendImpl.h:
2502 * src/WebEntities.h:
2503 * src/WebFrameImpl.h:
2504 * src/WorkerFileSystemCallbacksBridge.h:
2505 * tests/UniscribeHelperTest.cpp:
2507 2012-09-06 Dana Jansens <danakj@chromium.org>
2509 [chromium] Add a customized copy() method to CCRenderPassDrawQuad
2510 https://bugs.webkit.org/show_bug.cgi?id=95871
2512 Reviewed by Adrienne Walker.
2514 * tests/CCDrawQuadTest.cpp:
2518 2012-09-06 Ilya Tikhonovsky <loislo@chromium.org>
2520 Unreviewed Web Inspector: test fix.
2522 * tests/MemoryInstrumentationTest.cpp:
2523 (StringOwnerInstrumented):
2524 (WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
2525 (WebCore::StringOwnerInstrumented::reportMemoryUsage):
2529 2012-09-06 Ilya Tikhonovsky <loislo@chromium.org>
2531 Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
2532 https://bugs.webkit.org/show_bug.cgi?id=95957
2534 Reviewed by Yury Semikhatsky.
2536 Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
2537 instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
2538 At a later stage, when each memory type is counted in MemoryInstrumentation
2539 we will build the blocks hierarchy for the front-end automatically.
2541 * tests/MemoryInstrumentationTest.cpp:
2542 (WebCore::InstrumentedUndefined::InstrumentedUndefined):
2543 (WebCore::InstrumentedUndefined::reportMemoryUsage):
2544 (WebCore::InstrumentedDOM::InstrumentedDOM):
2545 (WebCore::InstrumentedDOM::reportMemoryUsage):
2549 2012-09-06 Kenichi Ishibashi <bashi@chromium.org>
2551 [Chromium] Win build fix attempt after r127715
2553 * tests/CCRenderPassTest.cpp:
2556 2012-09-06 Peter Beverloo <peter@chromium.org>
2558 Unreviewed. Rolled DEPS.
2562 2012-09-06 Dana Jansens <danakj@chromium.org>
2564 [chromium] Add a copy() method to CCRenderPass
2565 https://bugs.webkit.org/show_bug.cgi?id=95485
2567 Reviewed by Adrienne Walker.
2570 * tests/CCRenderPassTest.cpp: Added.
2572 (CCTestRenderPass::quadList):
2573 (CCTestRenderPass::sharedQuadStateList):
2577 2012-09-06 Peter Beverloo <peter@chromium.org>
2579 [Chromium] Chromium Mac build fix after revision r127711
2580 https://bugs.webkit.org/show_bug.cgi?id=95958
2582 Unreviewed build fix.
2584 This is a clear typo in the source file, so changing the function to
2585 call locationModifiersFromWindowsKeyCode instead.
2587 * src/mac/WebInputEventFactory.mm:
2588 (WebKit::WebInputEventFactory::keyboardEvent):
2590 2012-09-06 Raymes Khoury <raymes@chromium.org>
2592 Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
2593 https://bugs.webkit.org/show_bug.cgi?id=94142
2595 Reviewed by Tony Chang.
2597 Previously we distinguished between left/right Shift/Ctrl/Alt in
2598 WebInputEvents by using the location-specific virtual keycodes (e.g.
2599 VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
2600 always returns the non-locational version (e.g. VK_SHIFT).
2601 Furthermore, KeyboardEvent also returns
2602 non-locational keycodes and separates the location information which
2603 matches the behavior described in the DOM3
2604 spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
2605 should be consistent with this in our representation of key events.
2606 This patch changes WebInputEvents so they always store the
2607 non-locational keycode and location information is stored in
2608 modifiers. Since this only changes internal representation, no new
2611 This patch also ensures that when KeyboardEvents are converted back to
2612 WebInputEvents location information is preserved (which was not
2613 happening before). This is important so that key location information
2614 is passed on to plugins. A unittest is added for this.
2617 * public/WebInputEvent.h:
2619 * src/WebInputEvent.cpp:
2621 (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
2622 (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):
2623 * src/WebInputEventConversion.cpp:
2624 (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
2625 (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
2626 * src/android/WebInputEventFactory.cpp:
2627 (WebKit::WebInputEventFactory::keyboardEvent):
2628 * src/gtk/WebInputEventFactory.cpp:
2629 (WebKit::WebInputEventFactory::keyboardEvent):
2630 * src/mac/WebInputEventFactory.mm:
2631 (WebKit::WebInputEventFactory::keyboardEvent):
2632 * src/win/WebInputEventFactory.cpp:
2633 (WebKit::getLocationModifier):
2634 (WebKit::WebInputEventFactory::keyboardEvent):
2635 * tests/WebInputEventConversionTest.cpp: Added.
2637 2012-09-06 Adam Barth <abarth@webkit.org>
2639 Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
2640 https://bugs.webkit.org/show_bug.cgi?id=91110
2642 Reviewed by Tony Chang.
2644 Prior to this patch, we were ignoring the user-scalable property of
2645 viewport meta tags. This patch enforces the user-scalable property by
2646 claming the minimum-scale and maximum-scale values, effectively
2647 preventing user scaling. This approach isn't perfect, as discussed in
2648 https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
2649 over the status quo.
2651 This approach is also used by EFL, GTK, and Qt.
2653 * src/ChromeClientImpl.cpp:
2654 (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
2656 2012-09-05 Dana Jansens <danakj@chromium.org>
2658 [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
2659 https://bugs.webkit.org/show_bug.cgi?id=95374
2661 Reviewed by Adrienne Walker.
2664 * tests/CCDrawQuadTest.cpp: Added.
2666 (createSharedQuadState):
2669 2012-09-05 Kenichi Ishibashi <bashi@chromium.org>
2671 [Chromium] Unreviewed gardening
2673 * tests/GraphicsLayerChromiumTest.cpp:
2674 (WebKit::TEST_F): Disabled applyScrollToScrollableArea()
2676 2012-09-05 Tony Chang <tony@chromium.org>
2678 [chromium] Remove dependency on webkit_user_agent
2679 https://bugs.webkit.org/show_bug.cgi?id=95886
2681 Reviewed by Adam Barth.
2683 The code isn't used by webkit_unit_tests.
2685 * WebKitUnitTests.gyp:
2687 2012-09-05 Nate Chapin <japhet@chromium.org>
2689 Test for https://bugs.webkit.org/show_bug.cgi?id=91685
2691 Reviewed by Adam Barth.
2693 * tests/WebFrameTest.cpp:
2695 2012-09-05 Rick Byers <rbyers@chromium.org>
2697 Use new type-specific WebGestureEvent fields
2698 https://bugs.webkit.org/show_bug.cgi?id=95573
2700 Reviewed by James Robinson.
2702 Chromium has been updated to store gesture-type specific details in the
2703 new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
2704 crrev.com/154959), so we can now rely on them.
2706 * src/WebCompositorInputHandlerImpl.cpp:
2707 Update the compositor scroll, pinch and fling handling to use these new fields.
2708 (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
2709 (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
2710 * src/WebInputEventConversion.cpp:
2711 Update PlatformGestureEvent/WebGestureEvent conversion to use the new
2712 fields, storing into the existing overloaded PlatformGestureEvent
2713 fields (which will be cleaned up in my next CL).
2714 (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
2715 (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
2716 * src/WebViewImpl.cpp:
2717 (WebKit::WebViewImpl::handleGestureEvent):
2718 Update fling scrolling implementation for correct location of velocity.
2719 * tests/WebCompositorInputHandlerImplTest.cpp:
2721 Update tests to use the new fields.
2724 2012-09-05 James Robinson <jamesr@chromium.org>
2726 [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
2727 https://bugs.webkit.org/show_bug.cgi?id=95819
2729 Reviewed by Adam Barth.
2731 This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
2732 upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
2733 webkit.dll in the component build.
2735 * tests/WebLayerTest.cpp:
2737 2012-09-05 Victoria Kirst <vrk@chromium.org>
2739 Add the duration attribute to MediaSource
2740 https://bugs.webkit.org/show_bug.cgi?id=95149
2742 Reviewed by Eric Carlson.
2744 Add support for the duration attribute recently added to the MediaSource spec.
2745 http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration
2747 * public/WebMediaPlayer.h:
2748 (WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.
2749 * src/WebMediaPlayerClientImpl.cpp:
2750 (WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
2752 * src/WebMediaPlayerClientImpl.h:
2753 (WebMediaPlayerClientImpl):
2755 2012-09-05 Mihai Parparita <mihaip@chromium.org>
2757 [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
2758 https://bugs.webkit.org/show_bug.cgi?id=95865
2760 Reviewed by Darin Fisher.
2762 Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
2765 * public/WebRuntimeFeatures.h:
2766 (WebRuntimeFeatures):
2767 * src/WebRuntimeFeatures.cpp:
2768 (WebKit::WebRuntimeFeatures::enablePushState):
2769 (WebKit::WebRuntimeFeatures::isPushStateEnabled):
2771 2012-09-05 Mark Pilgrim <pilgrim@chromium.org>
2773 [Chromium] Remove getRenderStyleForStrike from PlatformSupport
2774 https://bugs.webkit.org/show_bug.cgi?id=95363
2776 Reviewed by Adam Barth.
2778 Part of a refactoring series. See tracking bug 82948.
2780 * public/linux/WebFontInfo.h:
2781 * public/linux/WebFontRenderStyle.h:
2782 * src/PlatformSupport.cpp:
2785 2012-09-05 Ilya Tikhonovsky <loislo@chromium.org>
2787 Unreviewed: WebInspector: remove accidentally committed speed test.
2789 * tests/MemoryInstrumentationTest.cpp:
2791 2012-09-05 Sami Kyostila <skyostil@chromium.org>
2793 [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
2794 https://bugs.webkit.org/show_bug.cgi?id=95679
2796 Reviewed by James Robinson.
2798 Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
2800 * src/WebLayerImpl.cpp:
2801 (WebKit::WebLayerImpl::setMaxScrollPosition):
2803 (WebKit::WebLayerImpl::setScrollClient):
2804 (WebKit::WebLayerImpl::scrollBy):
2805 * src/WebLayerImpl.h:
2807 * tests/CCLayerTreeHostTest.cpp:
2808 * tests/GraphicsLayerChromiumTest.cpp:
2809 (MockScrollableArea):
2812 * tests/WebLayerTest.cpp:
2814 2012-09-05 Ilya Tikhonovsky <loislo@chromium.org>
2816 Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
2817 https://bugs.webkit.org/show_bug.cgi?id=95850
2819 Reviewed by Yury Semikhatsky.
2821 I'd like to extract MemoryObjectTypes into separate classes.
2822 After that we will be able to move core NMI instrumentation code to WTF.
2824 * tests/MemoryInstrumentationTest.cpp:
2825 (WebCore::Instrumented::reportMemoryUsage):
2826 (WebCore::InstrumentedRefPtr::reportMemoryUsage):
2827 (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
2828 (WebCore::InstrumentedOther::reportMemoryUsage):
2829 (WebCore::InstrumentedDOM::reportMemoryUsage):
2831 (WebCore::NonVirtualInstrumented::reportMemoryUsage):
2833 2012-09-05 Peter Beverloo <peter@chromium.org>
2835 Unreviewed, rolling out r127590.
2836 http://trac.webkit.org/changeset/127590
2838 Broke the Chromium bots because of a compile error in the compositor.
2842 2012-09-05 Peter Beverloo <peter@chromium.org>
2844 Unreviewed. Rolled DEPS.
2848 2012-09-04 Ilya Tikhonovsky <loislo@chromium.org>
2850 Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
2851 https://bugs.webkit.org/show_bug.cgi?id=95739
2853 Reviewed by Yury Semikhatsky.
2855 When we go deeper into different parts of browser like skia, chromium itself etc.
2856 we can't use a single enum for all reported object types.
2857 The current idea is to use plain simple strings as ObjectType identifiers.
2858 In the future patches we will extract these identifiers into separate class or namespace
2859 and and split it between components.
2861 * tests/MemoryInstrumentationTest.cpp:
2865 2012-09-04 Keishi Hattori <keishi@webkit.org>
2867 Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
2868 https://bugs.webkit.org/show_bug.cgi?id=95681
2870 Reviewed by Kent Tamura.
2873 * src/ChromeClientImpl.cpp:
2875 (WebKit::ChromeClientImpl::openDateTimeChooser):
2876 * src/ChromeClientImpl.h:
2879 * src/DateTimeChooserImpl.cpp: Added.
2881 (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
2882 (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
2883 (WebKit::DateTimeChooserImpl::endChooser):
2884 (WebKit::DateTimeChooserImpl::contentSize):
2885 (WebKit::DateTimeChooserImpl::writeDocument):
2886 (WebKit::DateTimeChooserImpl::setValueAndClosePopup):
2887 (WebKit::DateTimeChooserImpl::didClosePopup):
2888 * src/DateTimeChooserImpl.h:
2891 (DateTimeChooserImpl):
2893 2012-09-04 Adam Barth <abarth@chromium.org>
2895 Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
2896 https://bugs.webkit.org/show_bug.cgi?id=95798
2898 Reviewed by Eric Seidel.
2900 * src/WebAccessibilityObject.cpp:
2901 (WebKit::WebAccessibilityObject::keyboardShortcut):
2902 - Remove use of WTF::String::operator+=
2903 * src/WebPageSerializerImpl.cpp:
2904 - Whitelist use of WTF::String::operator+=. Remove this use will take
2905 some more careful thought.
2907 2012-09-04 Alec Flett <alecflett@chromium.org>
2909 IndexedDB: remove final createIndex backend glue
2910 https://bugs.webkit.org/show_bug.cgi?id=95385
2912 Reviewed by Adam Barth.
2914 Remove chromium glue for old key-generation code.
2916 * public/WebIDBKey.h:
2918 * src/WebIDBKey.cpp:
2920 2012-09-04 Tien-Ren Chen <trchen@chromium.org>
2922 [chromium] Rename WebViewClient::handleDisambiguationPopup
2923 https://bugs.webkit.org/show_bug.cgi?id=95529
2925 Reviewed by Adam Barth.
2927 Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
2929 * public/WebViewClient.h:
2930 (WebKit::WebViewClient::didTapMultipleTargets):
2931 * src/WebViewImpl.cpp:
2932 (WebKit::WebViewImpl::handleGestureEvent):
2933 * tests/WebFrameTest.cpp:
2935 2012-09-03 Tao Bai <michaelbai@chromium.org>
2937 Added ANDROID_GDBSERVER definition for Ant
2938 https://bugs.webkit.org/show_bug.cgi?id=95265
2940 Reviewed by Adam Barth.
2942 ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
2943 is only used for finding the gdbserver.
2945 * WebKitUnitTests.gyp:
2947 2012-09-03 Peter Beverloo <peter@chromium.org>
2949 Unreviewed. Rolled DEPS.
2953 2012-09-03 Tommy Widenflycht <tommyw@google.com>
2955 MediaStream API: Add Ice-related functionality to RTCPeerConnection
2956 https://bugs.webkit.org/show_bug.cgi?id=95565
2958 Reviewed by Adam Barth.
2960 * src/AssertMatchingEnums.cpp:
2962 2012-09-01 James Robinson <jamesr@chromium.org>
2964 Unreviewed chromium buildfix when use_libcc_for_compositor=1
2966 This gyp target was renamed downstream.
2970 2012-09-01 Tommy Widenflycht <tommyw@google.com>
2972 MediaStream API: Add MediaStream management to RTCPeerConnection
2973 https://bugs.webkit.org/show_bug.cgi?id=95543
2975 Reviewed by Adam Barth.
2977 * src/AssertMatchingEnums.cpp:
2979 2012-08-31 Koji Ishii <kojiishi@gmail.com>
2981 Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
2982 https://bugs.webkit.org/show_bug.cgi?id=51450
2984 Reviewed by Tony Chang.
2986 When writing-mode is vertical-*, Chromium Win does not render glyphs correctly.
2987 http://dev.w3.org/csswg/css3-writing-modes/#writing-mode
2988 Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name,
2989 and vertical alternate glyphs (OpenType 'vert' feature) is not enabled.
2990 CJK characters drawn at wrong baseline position is also fixed.
2991 In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty
2992 in Chromium Win but they were implemented because they were needed to draw vertical flow correctly.
2994 Note that this patch does not address issues in vertical flow for complex code path.
2995 The issue is under discussion with Google people and it will not be fixed in short term.
2997 Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations.
2999 * features.gypi: ENABLE_OPENTYPE_VERTICAL=1.
3001 2012-08-31 W. James MacLean <wjmaclean@chromium.org>
3003 [chromium] Make link highlighter use same node selection criteria as Chromium for Android.
3004 https://bugs.webkit.org/show_bug.cgi?id=95371
3006 Reviewed by James Robinson.
3008 This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.
3010 * src/WebViewImpl.cpp:
3011 (WebKit::highlightConditions):
3012 (WebKit::WebViewImpl::bestTouchLinkNode):
3013 * tests/data/test_touch_link_highlight.html:
3015 2012-08-31 James Robinson <jamesr@chromium.org>
3017 [chromium] Consolidate geometry unit testing functions for cc
3018 https://bugs.webkit.org/show_bug.cgi?id=95526
3020 Reviewed by Julien Chaffraix.
3022 This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
3023 testing rect equality.
3026 * tests/CCDamageTrackerTest.cpp:
3027 (WebKitTests::TEST_F):
3028 * tests/CCGeometryTestUtils.cpp: Added.
3030 (WebKitTests::ExpectTransformationMatrixEq):
3031 * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
3034 * tests/CCLayerTreeHostTest.cpp:
3035 * tests/CCMathUtilTest.cpp:
3037 * tests/TiledLayerChromiumTest.cpp:
3039 2012-08-31 James Robinson <jamesr@chromium.org>
3041 [chromium] Clean up Web*Layer initialization paths
3042 https://bugs.webkit.org/show_bug.cgi?id=95523
3044 Reviewed by Darin Fisher.
3046 Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
3047 implementation. Also normalizes naming conventions in these files.
3049 * src/WebAnimationImpl.cpp:
3050 (WebKit::WebAnimation::create):
3051 (WebKit::WebAnimationImpl::WebAnimationImpl):
3052 * src/WebAnimationImpl.h:
3054 * src/WebContentLayerImpl.cpp:
3055 (WebKit::WebContentLayerImpl::WebContentLayerImpl):
3056 (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
3057 (WebKit::WebContentLayerImpl::layer):
3058 (WebKit::WebContentLayerImpl::setDoubleSided):
3059 (WebKit::WebContentLayerImpl::setContentsScale):
3060 (WebKit::WebContentLayerImpl::setUseLCDText):
3061 (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
3062 * src/WebContentLayerImpl.h:
3063 (WebContentLayerImpl):
3064 * src/WebFloatAnimationCurveImpl.cpp:
3065 (WebKit::WebFloatAnimationCurve::create):
3066 (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
3067 * src/WebFloatAnimationCurveImpl.h:
3068 (WebFloatAnimationCurveImpl):
3069 * src/WebIOSurfaceLayerImpl.cpp:
3070 (WebKit::WebIOSurfaceLayer::create):
3071 (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
3072 * src/WebIOSurfaceLayerImpl.h:
3073 (WebIOSurfaceLayerImpl):
3074 * src/WebImageLayerImpl.cpp:
3075 (WebKit::WebImageLayer::create):
3076 (WebKit::WebImageLayerImpl::WebImageLayerImpl):
3077 * src/WebImageLayerImpl.h:
3078 (WebImageLayerImpl):
3079 * src/WebLayerImpl.cpp:
3080 (WebKit::WebLayer::create):
3082 (WebKit::WebLayerImpl::WebLayerImpl):
3083 * src/WebLayerImpl.h:
3085 * src/WebScrollbarLayerImpl.cpp:
3086 (WebKit::WebScrollbarLayer::create):
3087 (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
3088 * src/WebScrollbarLayerImpl.h:
3089 (WebScrollbarLayerImpl):
3090 * src/WebSolidColorLayerImpl.cpp:
3091 (WebKit::WebSolidColorLayer::create):
3092 (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
3093 * src/WebSolidColorLayerImpl.h:
3094 (WebSolidColorLayerImpl):
3095 * src/WebTransformAnimationCurveImpl.cpp:
3096 (WebKit::WebTransformAnimationCurve::create):
3097 (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
3098 * src/WebTransformAnimationCurveImpl.h:
3099 (WebTransformAnimationCurveImpl):
3100 * src/WebVideoLayerImpl.cpp:
3101 (WebKit::WebVideoLayer::create):
3102 (WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
3103 * src/WebVideoLayerImpl.h:
3104 (WebVideoLayerImpl):
3106 2012-08-31 Tony Chang <tony@chromium.org>
3108 Remove ENABLE_CSS3_FLEXBOX compile time flag
3109 https://bugs.webkit.org/show_bug.cgi?id=95382
3111 Reviewed by Ojan Vafai.
3113 Everyone is already enabling this by default and the spec has stablized.
3117 2012-08-31 Christopher Cameron <ccameron@chromium.org>
3119 [chromium] Add main versus impl thread asserts
3120 https://bugs.webkit.org/show_bug.cgi?id=95596
3122 Reviewed by James Robinson.
3124 Add asserts to prioritized texture manager that specify that a
3125 function be called on the main or impl thread.
3127 Add debug signs that the main thread is blocked to the threaded
3130 Add a mechanism to simultaneously set the thread to the impl thread
3131 and indicate that the main thread is blocked.
3133 Update tests that hit asserts in the prioritized texture manager to
3134 set their impl thread and main thread blocked state correctly.
3136 * tests/CCPrioritizedTextureTest.cpp:
3137 (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
3138 (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
3139 (WTF::CCPrioritizedTextureTest::validateTexture):
3141 * tests/TiledLayerChromiumTest.cpp:
3143 2012-08-30 James Robinson <jamesr@chromium.org>
3145 [chromium] Put compositor client interfaces in separate headers, normalize naming
3146 https://bugs.webkit.org/show_bug.cgi?id=95522
3148 Reviewed by Adam Barth.
3150 * src/WebContentLayerImpl.cpp:
3151 (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
3152 * src/WebContentLayerImpl.h:
3153 (WebContentLayerImpl):
3154 * src/WebExternalTextureLayerImpl.h:
3155 * src/WebLayerTreeViewImpl.h:
3157 * tests/CCLayerTreeHostCommonTest.cpp:
3158 * tests/CCLayerTreeHostTest.cpp:
3159 (WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
3160 (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
3161 (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
3162 (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
3163 (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
3164 (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
3165 (CCLayerTreeHostTestLostContextWhileUpdatingResources):
3166 * tests/ContentLayerChromiumTest.cpp:
3167 (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
3170 2012-08-31 Gavin Peters <gavinp@chromium.org>
3172 [chromium] DEPS roll with a test skip.
3173 https://bugs.webkit.org/show_bug.cgi?id=95601
3175 Unreviewed gardening & DEPS roll.
3178 fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)
3182 2012-08-31 Gavin Peters <gavinp@chromium.org>
3184 [chromium] Disable WebViewTest.AutoResizeMinimumSize
3185 https://bugs.webkit.org/show_bug.cgi?id=95571
3187 Unreviewed gardening.
3189 Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this.
3191 * tests/WebViewTest.cpp:
3193 2012-08-30 James Robinson <jamesr@chromium.org>
3195 [chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
3196 https://bugs.webkit.org/show_bug.cgi?id=95520
3198 Reviewed by Darin Fisher.
3200 Adopt the return value of WebCompositorSupport explicitly.
3202 * src/LinkHighlight.cpp:
3203 (WebKit::LinkHighlight::LinkHighlight):
3204 (WebKit::LinkHighlight::startHighlightAnimation):
3205 * src/WebMediaPlayerClientImpl.cpp:
3206 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3207 * src/WebPluginContainerImpl.cpp:
3208 (WebKit::WebPluginContainerImpl::setBackingTextureId):
3209 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3211 2012-08-30 James Robinson <jamesr@chromium.org>
3213 [chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
3214 https://bugs.webkit.org/show_bug.cgi?id=95401
3216 Reviewed by Dirk Pranke.
3218 If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere.
3222 * WebKitUnitTests.gyp:
3224 2012-08-27 James Robinson <jamesr@chromium.org>
3226 [chromium] Add CompositorSupport interface for constructing compositor classes
3227 https://bugs.webkit.org/show_bug.cgi?id=95040
3229 Reviewed by Darin Fisher.
3231 * src/LinkHighlight.cpp:
3232 (WebKit::LinkHighlight::LinkHighlight):
3233 (WebKit::LinkHighlight::startHighlightAnimation):
3234 * src/WebMediaPlayerClientImpl.cpp:
3235 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3236 * src/WebMediaPlayerClientImpl.h:
3238 * src/WebPluginContainerImpl.cpp:
3239 (WebKit::WebPluginContainerImpl::setBackingTextureId):
3240 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3241 * src/WebPluginContainerImpl.h:
3244 2012-08-30 Gavin Peters <gavinp@chromium.org>
3246 [chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
3247 https://bugs.webkit.org/show_bug.cgi?id=95472
3249 Unreviewed gardening.
3251 When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue.
3253 * tests/CCLayerTreeHostTest.cpp:
3254 (WebKitTests::TEST_F):
3256 2012-08-30 James Robinson <jamesr@chromium.org>
3258 [chromium] Clean up some webkit compositor unit tests
3259 https://bugs.webkit.org/show_bug.cgi?id=95410
3261 Reviewed by Adrienne Walker.
3263 This adds includes that were implicitly being picked up, removes ones that weren't being used, removes
3264 dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style
3265 plugin is unhappy about.
3267 * tests/CCAnimationTestCommon.cpp:
3268 (WebKitTests::FakeFloatAnimationCurve::duration):
3270 (WebKitTests::FakeFloatAnimationCurve::getValue):
3271 (WebKitTests::FakeTransformTransition::duration):
3272 (WebKitTests::FakeFloatTransition::duration):
3273 (WebKitTests::FakeLayerAnimationControllerClient::id):
3274 (WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
3275 (WebKitTests::FakeLayerAnimationControllerClient::opacity):
3276 (WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):
3277 (WebKitTests::FakeLayerAnimationControllerClient::transform):
3278 * tests/CCAnimationTestCommon.h:
3279 (FakeFloatAnimationCurve):
3280 (FakeTransformTransition):
3281 (FakeFloatTransition):
3282 (FakeLayerAnimationControllerClient):
3283 * tests/CCTiledLayerTestCommon.cpp:
3284 (WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
3286 (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
3287 (WebKitTests::FakeTiledLayerChromium::textureManager):
3288 (WebKitTests::FakeTiledLayerChromium::textureUpdater):
3289 (WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
3290 (WebKitTests::FakeTextureUploader::isBusy):
3291 (WebKitTests::FakeTextureUploader::uploadTexture):
3292 * tests/CCTiledLayerTestCommon.h:
3293 (FakeLayerTextureUpdater):
3294 (FakeTiledLayerChromium):
3295 (FakeTiledLayerWithScaledBounds):
3296 (FakeTextureUploader):
3297 * tests/FakeWebCompositorOutputSurface.h:
3298 * tests/TextureCopierTest.cpp:
3301 * tests/ThrottledTextureUploaderTest.cpp:
3303 * tests/WebLayerTreeViewTest.cpp:
3305 2012-08-29 Hironori Bono <hbono@chromium.org>
3307 Fix Chromium builds (Win and Mac)
3308 https://bugs.webkit.org/show_bug.cgi?id=95421
3310 Reviewed by James Robinson.
3312 This change replaces 'class WebRect' with 'struct WebRect' to fix build breaks
3313 on the "Chromium Mac Release" and the "Chromium Win Release" bot caused by
3316 * public/WebViewClient.h:
3319 2012-08-29 Nat Duca <nduca@chromium.org>
3321 [chromium] setNeedsAnimate should not cause commitRequested to become true
3322 https://bugs.webkit.org/show_bug.cgi?id=95393
3324 Reviewed by James Robinson.
3326 * tests/CCLayerTreeHostTest.cpp:
3327 (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
3328 (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
3330 2012-08-29 Tien-Ren Chen <trchen@chromium.org>
3332 [chromium] Implement disambiguation popup (a.k.a. Link Preview)
3333 https://bugs.webkit.org/show_bug.cgi?id=94182
3335 Reviewed by Adam Barth.
3337 In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate.
3338 The disambiguation sequence will be initiated by the gesture event handler
3339 in WebViewImpl if an ambiguous tap is detected, then
3340 m_client->handleDisambiguationPopup will be called, so the embedder can
3341 decide whether to swallow the touch event and show a popup.
3343 New test: WebFrameTest.DisambiguationPopupTest
3347 * public/WebInputEvent.h:
3349 (WebKit::WebGestureEvent::WebGestureEvent):
3350 * public/WebTouchCandidatesInfo.h: Removed.
3353 * public/WebViewClient.h:
3356 (WebKit::WebViewClient::triggersLinkPreview):
3357 * src/WebInputEvent.cpp:
3358 (SameSizeAsWebGestureEvent):
3359 * src/WebViewImpl.cpp:
3361 (WebKit::WebViewImpl::handleGestureEventWithLinkPreview):
3362 (WebKit::WebViewImpl::handleGestureEvent):
3363 * src/WebViewImpl.h:
3366 2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
3368 AX: Canvas should have a distinct role
3369 https://bugs.webkit.org/show_bug.cgi?id=95248
3371 Reviewed by Chris Fleizach.
3373 Add support for canvas accessibility role.
3375 * public/WebAccessibilityRole.h:
3376 * src/AssertMatchingEnums.cpp:
3378 2012-08-29 Alex Sakhartchouk <alexst@chromium.org>
3380 [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order
3381 https://bugs.webkit.org/show_bug.cgi?id=94828
3383 Reviewed by Adrienne Walker.
3385 Testing that setDeviceScaleFactor properly changes maxScrollPosition
3387 * tests/CCLayerTreeHostImplTest.cpp:
3389 2012-08-29 James Robinson <jamesr@chromium.org>
3391 Unreviewed, rolling out r126956.
3392 http://trac.webkit.org/changeset/126956
3393 https://bugs.webkit.org/show_bug.cgi?id=94721
3395 Breaks several unit tests
3397 * tests/CCSchedulerTest.cpp:
3398 (WebKitTests::FakeCCSchedulerClient::reset):
3399 (WebKitTests::FakeCCSchedulerClient::setHasMoreResourceUpdates):
3400 (WebKitTests::TEST):
3401 * tests/CCTextureUpdateControllerTest.cpp:
3403 2012-08-29 James Robinson <jamesr@chromium.org>
3405 [chromium] Register/unregister contents layers with GraphicsLayerChromium
3406 https://bugs.webkit.org/show_bug.cgi?id=95379
3408 Reviewed by Adrienne Walker.
3410 * src/WebMediaPlayerClientImpl.cpp:
3411 (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
3412 (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
3413 * src/WebPluginContainerImpl.cpp:
3414 (WebKit::WebPluginContainerImpl::setBackingTextureId):
3415 (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
3416 (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
3418 2012-08-29 W. James MacLean <wjmaclean@chromium.org>
3420 [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.
3421 https://bugs.webkit.org/show_bug.cgi?id=95119
3423 Reviewed by Adam Barth.
3425 Add support to WebSettings for flag to enable/disable gesture tap highlights. Relies on existing tests.
3427 * public/WebSettings.h:
3428 * src/WebSettingsImpl.cpp:
3429 (WebKit::WebSettingsImpl::WebSettingsImpl):
3430 (WebKit::WebSettingsImpl::setGestureTapHighlightEnabled):
3432 * src/WebSettingsImpl.h:
3434 (WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
3435 * src/WebViewImpl.cpp:
3436 (WebKit::WebViewImpl::handleGestureEvent):
3438 2012-08-29 Dana Jansens <danakj@chromium.org>
3440 [chromium] Remove HUD layer when rootLayer is set to null
3441 https://bugs.webkit.org/show_bug.cgi?id=95257
3443 Reviewed by James Robinson.
3446 * tests/CCHeadsUpDisplayTest.cpp: Added.
3447 (CCHeadsUpDisplayTest):
3448 (DrawsContentLayerChromium):
3449 (DrawsContentLayerChromium::create):
3450 (DrawsContentLayerChromium::DrawsContentLayerChromium):
3451 (CCHudWithRootLayerChange):
3452 (CCHudWithRootLayerChange::CCHudWithRootLayerChange):
3454 * tests/CCLayerTreeHostTest.cpp:
3455 * tests/CCThreadedTest.cpp:
3456 (WebKitTests::CCThreadedTest::runTest):
3457 * tests/CCThreadedTest.h:
3458 (WebKitTests::CCThreadedTest::initializeSettings):
3461 2012-08-29 Shawn Singh <shawnsingh@chromium.org>
3463 [chromium] Add more unit test coverage for semantics of drawableContentRect and visibleContentRect
3464 https://bugs.webkit.org/show_bug.cgi?id=94542
3466 Reviewed by Adrienne Walker.
3468 To make upcoming refactors safer, it was appropriate to (finally)
3469 add unit tests that check the behavior of drawableContentRect and
3470 visibleContentRect computations in calculateDrawTransforms.
3472 * tests/CCLayerTreeHostCommonTest.cpp:
3474 2012-08-29 W. James MacLean <wjmaclean@chromium.org>
3476 [chromium] Link highlight should clear on page navigation.
3477 https://bugs.webkit.org/show_bug.cgi?id=95129
3479 Reviewed by James Robinson.
3481 Modified WebViewImpl to clear link highlight when navigating to new url.
3483 * src/WebViewImpl.cpp:
3484 (WebKit::WebViewImpl::didCommitLoad):
3486 2012-08-29 James Robinson <jamesr@chromium.org>
3488 [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
3489 https://bugs.webkit.org/show_bug.cgi?id=94995
3491 Reviewed by Adam Barth.
3495 2012-08-28 Shawn Singh <shawnsingh@chromium.org>
3497 [chromium] Do not clip root layer's subtree to viewport
3498 https://bugs.webkit.org/show_bug.cgi?id=95235