Unreviewed, rolling out r128409.
[WebKit-https.git] / Source / WebKit / chromium / ChangeLog
1 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r128409.
4         http://trac.webkit.org/changeset/128409
5         https://bugs.webkit.org/show_bug.cgi?id=96622
6
7         It broke Chromium browser_tests (Requested by tkent on
8         #webkit).
9
10         * src/WebFrameImpl.cpp:
11         (WebKit::WebFrameImpl::scopeStringMatches):
12         (WebKit::WebFrameImpl::shouldScopeMatches):
13
14 2012-09-13  Taiju Tsuiki  <tzik@chromium.org>
15
16         Check if WorkerContext is terminated in WebWorkerClientImple::openFileSystem call.
17         https://bugs.webkit.org/show_bug.cgi?id=96601
18
19         Reviewed by Kent Tamura.
20
21         m_webFrame might be already deleted after terminateWorkerContext call.
22         This patch ensure it be NULL and change to avoid using it.
23
24         Test: fast/filesystem/workers/detached-frame-crash.html
25
26         * src/WebWorkerClientImpl.cpp:
27         (WebKit::WebWorkerClientImpl::terminateWorkerContext):
28         (WebKit::WebWorkerClientImpl::openFileSystem):
29
30 2012-09-12  Leandro Gracia Gil  <leandrogracia@chromium.org>
31
32         [Chromium] Fix cases where find-in-page doesn't send a final update
33         https://bugs.webkit.org/show_bug.cgi?id=96402
34
35         Fix some issues in the WebKit implementation that prevented to send a final
36         reportFindInPageMatchCount message.
37
38         Reviewed by Adam Barth.
39
40         * src/WebFrameImpl.cpp:
41         (WebKit::WebFrameImpl::scopeStringMatches):
42         (WebKit::WebFrameImpl::shouldScopeMatches):
43
44 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
45
46         Unreviewed, rolling out r127876.
47         http://trac.webkit.org/changeset/127876
48         https://bugs.webkit.org/show_bug.cgi?id=96600
49
50         mouse click doesn't work for spin button if spin button in
51         iframe (Requested by yosin on #webkit).
52
53         * src/ContextMenuClientImpl.cpp:
54         (WebKit::selectMisspelledWord):
55         * src/FrameLoaderClientImpl.cpp:
56         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
57         * src/WebFrameImpl.cpp:
58         (WebKit::WebFrameImpl::characterIndexForPoint):
59         * src/WebPluginContainerImpl.cpp:
60         (WebKit::WebPluginContainerImpl::isRectTopmost):
61         * src/WebViewImpl.cpp:
62         (WebKit::WebViewImpl::handleMouseUp):
63         (WebKit::WebViewImpl::computeBlockBounds):
64
65 2012-09-12  Rick Byers  <rbyers@chromium.org>
66
67         [chromium] Remove unused WebGestureEvent fields
68         https://bugs.webkit.org/show_bug.cgi?id=95496
69
70         Reviewed by Adam Barth.
71
72         Remove the no-longer used fields from WebGestureEvent, now that
73         chromium has been updated to use the per-event-type fields instead.
74         This depends on crrev.com/156346 in chromium.
75
76         * public/WebInputEvent.h:
77         (WebKit::WebGestureEvent::WebGestureEvent):
78         * public/android/WebInputEventFactory.h:
79         * src/WebInputEvent.cpp:
80         (SameSizeAsWebGestureEvent):
81         * src/android/WebInputEventFactory.cpp:
82         (WebKit):
83         (WebKit::WebInputEventFactory::gestureEvent):
84
85 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
86
87         Unreviewed, rolling out r128351.
88         http://trac.webkit.org/changeset/128351
89         https://bugs.webkit.org/show_bug.cgi?id=96573
90
91         Broke FindInPage browser_tests (Requested by jamesr_ on
92         #webkit).
93
94         * src/WebFrameImpl.cpp:
95         (WebKit::WebFrameImpl::scopeStringMatches):
96         (WebKit::WebFrameImpl::cancelPendingScopingEffort):
97         (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
98         (WebKit::WebFrameImpl::shouldScopeMatches):
99
100 2012-09-12  Adrienne Walker  <enne@google.com>
101
102         [chromium] Fix search tickmarks not disappearing when compositing is enabled
103         https://bugs.webkit.org/show_bug.cgi?id=96536
104
105         Reviewed by James Robinson.
106
107         view->invalidateRect() on the root frame just invalidates the
108         contents, since WebViewImpl doesn't know anything about scrollbar
109         layers. This causes an "InvalidateAll" to not actually invalidate the
110         scrollbars.
111
112         To fix this, make WebFrameImpl explicitly invalidate the
113         scrollbars when required.
114
115         * src/WebFrameImpl.cpp:
116         (WebKit::WebFrameImpl::invalidateArea):
117
118 2012-09-12  Leandro Gracia Gil  <leandrogracia@chromium.org>
119
120         [Chromium] Fix cases where find-in-page doesn't send a final update
121         https://bugs.webkit.org/show_bug.cgi?id=96402
122
123         Fix some issues in the WebKit implementation that prevented to send a final
124         reportFindInPageMatchCount message. Also, fix a buggy reset of the active match
125         when calling the stopFinding method.
126
127         Reviewed by Adam Barth.
128
129         * src/WebFrameImpl.cpp:
130         (WebKit::WebFrameImpl::scopeStringMatches):
131         (WebKit::WebFrameImpl::cancelPendingScopingEffort):
132         (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
133         (WebKit::WebFrameImpl::shouldScopeMatches):
134
135 2012-09-12  Sami Kyostila  <skyostil@google.com>
136
137         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
138         https://bugs.webkit.org/show_bug.cgi?id=96251
139
140         Reviewed by Simon Fraser.
141
142         Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
143         the feature it controls.
144
145         * features.gypi:
146
147 2012-09-12  Christopher Cameron  <ccameron@chromium.org>
148
149         [chromium] Evict textures through the texture manager instead of the resource provider
150         https://bugs.webkit.org/show_bug.cgi?id=96463
151
152         Reviewed by James Robinson.
153
154         Update layer tree host impl test to include the extra interface functions
155         added to CCLayerTreeHostImplClient.
156
157         * tests/CCLayerTreeHostImplTest.cpp:
158
159 2012-09-12  Ilya Tikhonovsky  <loislo@chromium.org>
160
161         Web Inspector: NMI move String* instrumentation to wtf.
162         https://bugs.webkit.org/show_bug.cgi?id=96405
163
164         Reviewed by Yury Semikhatsky.
165
166         This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
167
168         Tested by webkit_unit_tests.
169
170         * tests/MemoryInstrumentationTest.cpp:
171         (WebCore::TEST):
172
173 2012-09-12  Philippe Liard  <pliard@google.com>
174
175         Depend on {base,net} GYP targets rather than {base,net}_java.
176         https://bugs.webkit.org/show_bug.cgi?id=95690
177
178         Reviewed by Adam Barth.
179
180         {base,net}_java became 'private' targets on the Chromium side that
181         clients should not depend on (see
182         https://chromiumcodereview.appspot.com/10913083/).
183         This also adds the missing 'chromium_net.jar' to |input_jars_paths|
184         that was magically included in Chrome for Android downstream but not
185         upstream. It's needed to register JNI for 'net' in webkit_unit_tests.
186
187
188         * WebKitUnitTests.gyp:
189
190 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
191
192         Unreviewed, rolling out r128279.
193         http://trac.webkit.org/changeset/128279
194         https://bugs.webkit.org/show_bug.cgi?id=96487
195
196         "Snow Leopard compilation broken" (Requested by yurys on
197         #webkit).
198
199         * tests/MemoryInstrumentationTest.cpp:
200         (WebCore::InstrumentedUndefined::reportMemoryUsage):
201         (WebCore::TEST):
202
203 2012-09-12  Ilya Tikhonovsky  <loislo@chromium.org>
204
205         Web Inspector: NMI move String* instrumentation to wtf.
206         https://bugs.webkit.org/show_bug.cgi?id=96405
207
208         Reviewed by Yury Semikhatsky.
209
210         This instrumentation is solving the problem with substrings and removes traits based code which is hard to upstream.
211
212         Tested by webkit_unit_tests.
213
214         * tests/MemoryInstrumentationTest.cpp:
215         (WebCore::InstrumentedUndefined::reportMemoryUsage):
216         (WebCore::TEST):
217
218 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
219
220         [chromium] consumable user gesture count off for input events
221         https://bugs.webkit.org/show_bug.cgi?id=96373
222
223         Reviewed by Adam Barth.
224
225         Don't create a UserGestureIndicator in the chromium layer, as it will
226         already be created by webcore's event handler. Creating multiple
227         UserGestureIndicator objects for the same object would allow to execute
228         multiple user-gesture-gated actions per user gesture such as opening a
229         new window.
230
231         * public/WebInputEvent.h:
232         * src/WebViewImpl.cpp:
233         (WebKit::WebViewImpl::handleInputEvent):
234
235 2012-09-12  Alexandre Elias  <aelias@chromium.org>
236
237         [chromium] Flip Y and swizzle inside compositeAndReadback implementation
238         https://bugs.webkit.org/show_bug.cgi?id=96458
239
240         Reviewed by James Robinson.
241
242         Currently, compositeAndReadback API assumes a GL-style texture
243         and is converted to the normal software format in WebViewImpl.
244         For the software implementation, this API would result in two
245         redundant conversions.  This patch makes the conversion inside
246         CCRendererGL instead.  I rolled my own for loop as I didn't find the
247         appropriate function within raw Skia.
248
249         No new tests (covered by existing layout tests).
250
251         * src/WebViewImpl.cpp:
252         (WebKit::WebViewImpl::doPixelReadbackToCanvas):
253
254 2012-09-11  Taiju Tsuiki  <tzik@chromium.org>
255
256         WebFrameImpl::client() needs NULL check in WebWorkerClientImpl::openFileSystem
257         https://bugs.webkit.org/show_bug.cgi?id=96354
258
259         Reviewed by Kent Tamura.
260
261         Ensure non-NULL before using WebFrameImpl::client().
262
263         Test: fast/filesystem/workers/detached-frame-crash.html
264
265         * src/WebWorkerClientImpl.cpp:
266         (WebKit::WebWorkerClientImpl::openFileSystem):
267
268 2012-09-11  Keishi Hattori  <keishi@webkit.org>
269
270         Create Localizer factory method for LocaleICU
271         https://bugs.webkit.org/show_bug.cgi?id=96363
272
273         Reviewed by Kent Tamura.
274
275         * tests/LocalizedNumberICUTest.cpp:
276         (testNumberIsReversible):
277         (testDecimalSeparator):
278
279 2012-09-11  Christopher Cameron  <ccameron@chromium.org>
280
281         [chromium] Make prioritized texture manager not touch backings array on the main thread
282         https://bugs.webkit.org/show_bug.cgi?id=96114
283
284         Reviewed by James Robinson.
285
286         Take a snapshot of the textures' priorities from the main thread,
287         and save it in their backings for access by the impl thread.
288         Update functions that access the sorted backings array to use the
289         snapshotted values instead of the values that the main thread may
290         have computed for the next frame.
291
292         Make the main thread not touch the m_backings array.  Split
293         prioritizeTextures into a updateBackingsPriorities function.
294         In places where the main thread would have touched m_backings,
295         set a flag specifying that m_backings needs to be re-sorted
296         before any function that requires it be sorted by priority be
297         executed.
298
299         Update the two functions that require sorted order (acquireBacking
300         and reduceMemory) to sort the backings array (if needed) before
301         traversing it.
302
303         Updated tests to set correct thread during asserts. Add a test to
304         verify that requestLate is correctly incorporated into the backing
305         sorting.
306
307         * tests/CCPrioritizedTextureTest.cpp:
308         (WTF::CCPrioritizedTextureTest::validateTexture):
309
310 2012-09-11  Sheriff Bot  <webkit.review.bot@gmail.com>
311
312         Unreviewed.  Rolled DEPS.
313
314         * DEPS:
315
316 2012-09-11  Iain Merrick  <husky@chromium.org>
317
318         [chromium] Fix double call to scrollBegin() when handling scroll gesture
319         https://bugs.webkit.org/show_bug.cgi?id=95322
320
321         Reviewed by James Robinson.
322
323         WebCompositorInputHandlerImpl::handleGestureFling() calls scrollBegin() on its
324         client, then if the result is ScrollStarted, it creates a PlatformGestureCurve
325         object to handle the fling animation. This patch adds a matching scrollEnd()
326         before the animation starts.
327
328         Now using strict mocks in WebCompositorInputHandlerImplTest, which turns all
329         unexpected calls into test failures. This ensures that scrollBegin / scrollEnd
330         happen exactly when we want and at no other times.
331
332         * src/WebCompositorInputHandlerImpl.cpp:
333         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
334         * tests/WebCompositorInputHandlerImplTest.cpp:
335         (WebCompositorInputHandlerImplTest):
336         (WebKit::TEST_F):
337
338 2012-09-11  Peter Beverloo  <peter@chromium.org>
339
340         Unreviewed.  Rolled DEPS.
341
342         * DEPS:
343
344 2012-09-11  Keishi Hattori  <keishi@webkit.org>
345
346         Create Localizer factory method for LocaleMac
347         https://bugs.webkit.org/show_bug.cgi?id=96355
348
349         Reviewed by Kent Tamura.
350
351         * tests/LocaleMacTest.cpp:
352         (testNumberIsReversible): Use Localizer::create.
353         (testNumbers):
354
355 2012-09-11  Sheriff Bot  <webkit.review.bot@gmail.com>
356
357         Unreviewed, rolling out r128150.
358         http://trac.webkit.org/changeset/128150
359         https://bugs.webkit.org/show_bug.cgi?id=96357
360
361         it broke chromium compilation (Requested by loislo on
362         #webkit).
363
364         * DEPS:
365
366 2012-09-10  Sheriff Bot  <webkit.review.bot@gmail.com>
367
368         Unreviewed.  Rolled DEPS.
369
370         * DEPS:
371
372 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
373
374         Properly expose <legend> elements to ATs
375         https://bugs.webkit.org/show_bug.cgi?id=84137
376
377         Reviewed by Chris Fleizach.
378
379         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
380         the expected platform role, ATK_ROLE_LABEL. Also established the needed
381         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
382
383         * public/WebAccessibilityRole.h: added WebAccessibilityRoleLegend
384         * src/AssertMatchingEnums.cpp: added the assert matching rule for
385         WebAccessibilityRoleLegend and LegendRole
386
387 2012-09-10  Beth Dakin  <bdakin@apple.com>
388
389         https://bugs.webkit.org/show_bug.cgi?id=96158
390         Need API to suppress scrollbar animations
391         -and corresponding-
392         <rdar://problem/12210972>
393
394         Reviewed by Sam Weinig.
395
396         ScrollableArea::isOnActivePage() has been re-named to
397         ScrollableArea:: scrollbarsCanBeActive().
398         * src/ScrollbarGroup.cpp:
399         (WebKit::ScrollbarGroup::scrollbarsCanBeActive):
400         * src/ScrollbarGroup.h:
401         * tests/GraphicsLayerChromiumTest.cpp:
402         * tests/ScrollAnimatorNoneTest.cpp:
403         (MockScrollableArea):
404
405 2012-09-10  Dan Alcantara  <dfalcantara@chromium.org>
406
407         [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in
408         https://bugs.webkit.org/show_bug.cgi?id=90222
409
410         Reviewed by Adam Barth.
411
412         When reloading a page with an overridden URL, the page's scroll and zoom
413         state will be restored once the reload is complete.  This is problematic
414         in situations when switching between mobile and desktop versions of the
415         same site because it will zoom back in on a random part of alternate page.
416         This CL just avoids that situation by resetting the zoom and scale whenever
417         this type of reload occurs.
418
419         Chromium half: https://chromiumcodereview.appspot.com/10889019
420
421         * public/WebView.h:
422         (WebView):
423         * src/WebViewImpl.cpp:
424         (WebKit::WebViewImpl::resetScrollAndScaleState):
425         (WebKit):
426         * src/WebViewImpl.h:
427         (WebViewImpl):
428
429 2012-09-10  Adam Barth  <abarth@chromium.org>
430
431         [V8] V8AuxiliaryContext used by IDB leaks memory
432         https://bugs.webkit.org/show_bug.cgi?id=96317
433
434         Reviewed by Tony Chang.
435
436         Call the V8 APIs directly instead of using a helper class.
437
438         * tests/IDBBindingUtilitiesTest.cpp:
439         (WebCore::TEST):
440
441 2012-09-10  Adam Barth  <abarth@chromium.org>
442
443         [V8] Inline firstFrame and currentFrame into their unique callers
444         https://bugs.webkit.org/show_bug.cgi?id=96309
445
446         Reviewed by Eric Seidel.
447
448         This patch just lines these WebCore functions because we only call them
449         from here.
450
451         * src/WebFrameImpl.cpp:
452         (WebKit::WebFrame::frameForEnteredContext):
453         (WebKit::WebFrame::frameForCurrentContext):
454
455 2012-09-10  Rick Byers  <rbyers@chromium.org>
456
457         [chromium] Add unused GestureTapCancel
458         https://bugs.webkit.org/show_bug.cgi?id=96183
459
460         Reviewed by Adam Barth.
461
462         This adds a new 'tap cancel' gesture type.  This is temporarily unused,
463         so that we can change chromium to start sending the gesture type
464         without breaking anything.
465
466         * public/WebInputEvent.h:
467         * src/PageWidgetDelegate.cpp:
468         (WebKit::PageWidgetDelegate::handleInputEvent):
469         * src/WebInputEventConversion.cpp:
470         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
471         * src/WebPopupMenuImpl.cpp:
472         (WebKit::WebPopupMenuImpl::handleInputEvent):
473         * src/WebViewImpl.cpp:
474         (WebKit::WebViewImpl::handleGestureEvent):
475
476 2012-09-10  Mark Pilgrim  <pilgrim@chromium.org>
477
478         [Chromium] Define new setSharedWorkerRepository function in preparation for removing WebKitPlatformSupport::sharedWorkerRepository()
479         https://bugs.webkit.org/show_bug.cgi?id=95861
480
481         Reviewed by Adam Barth.
482
483         Followup patch to Chromium will call this new function, then we can remove all references to the legacy function on WebKitPlatformSupport.
484
485         * public/WebSharedWorkerRepository.h:
486         (WebKit):
487         * src/SharedWorkerRepository.cpp:
488         (WebKit):
489         (WebKit::setSharedWorkerRepository):
490         (WebKit::sharedWorkerRepository):
491         (WebCore::SharedWorkerRepository::isAvailable):
492         (WebCore::SharedWorkerRepository::connect):
493         (WebCore::SharedWorkerRepository::documentDetached):
494         (WebCore::SharedWorkerRepository::hasSharedWorkers):
495
496 2012-09-10  Catalin Badea  <badea@adobe.com>
497
498         webkit build for 64-bit Mac chromium
499         https://bugs.webkit.org/show_bug.cgi?id=95977
500
501         Reviewed by Eric Seidel.
502
503         Ensure header completeness and use the correct include order. This fixes a compilation issues noticeable when building chromium for 64-bit Mac. 
504
505         * public/mac/WebSubstringUtil.h:
506         * src/mac/WebSubstringUtil.mm:
507
508 2012-09-10  Adrienne Walker  <enne@google.com>
509
510         [chromium] Fix deadlock between WebMediaPlayerClientImpl dtor and PutCurrentFrame
511         https://bugs.webkit.org/show_bug.cgi?id=96010
512
513         Reviewed by James Robinson.
514
515         The key fix here is that the destructor no longer has a mutex.
516         The m_compositingMutex was supposedly protecting races between
517         ~WebMediaPlayerClientImpl and setVideoFrameProviderClient. The
518         former is only called from the main thread and the latter is called
519         from the compositor thread only when the main thread is blocked (and
520         it already asserts that this is the case).
521
522         In addition, the m_providerMutex in CCVideoLayerImpl prevents the
523         destruction of WebMediaPlayerClientImpl, thus keeping the frame
524         acquired via getCurrentFrame alive until putCurrentFrame is called.
525         These functions are only called by the client, and comments are added
526         to the interface to better document this.
527
528         To prevent a race between load() and getCurrentFrame/putCurrentFrame
529         (which are called from different threads) a new m_webMediaPlayerMutex
530         to replace part of what the old m_compositingMutex was doing.
531
532         * src/WebMediaPlayerClientImpl.cpp:
533         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
534         (WebKit::WebMediaPlayerClientImpl::load):
535         (WebKit::WebMediaPlayerClientImpl::loadInternal):
536         (WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
537         (WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
538         (WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
539         * src/WebMediaPlayerClientImpl.h:
540         (WebMediaPlayerClientImpl):
541
542 2012-09-10  Rick Byers  <rbyers@chromium.org>
543
544         [chromium] Don't use WebGestureEvent.boundingBox for touch adjustment
545         https://bugs.webkit.org/show_bug.cgi?id=95996
546
547         Reviewed by Adam Barth.
548
549         Switch from WebGestureEvent.boundingBox to new gesture-type specific
550         data fields.
551         * src/WebViewImpl.cpp:
552         (WebKit::WebViewImpl::handleGestureEvent):
553
554 2012-09-09  Keishi Hattori  <keishi@webkit.org>
555
556         REGRESSION(r127558): Fix a crash in DateTimeChooserImpl::didClosePopup
557         https://bugs.webkit.org/show_bug.cgi?id=96222
558
559         Reviewed by Kent Tamura.
560
561         DateTimeChooserClient will delete DateTimeChooserImpl inside didEndChooser()
562         so we shouldn't be changing the members after that.
563
564         Testing covered by fast/forms/date/calendar-picker-appearance-pre-100.html.
565
566         * src/DateTimeChooserImpl.cpp:
567         (WebKit::DateTimeChooserImpl::didClosePopup):
568
569 2012-09-09  Kenichi Ishibashi  <bashi@chromium.org>
570
571         [Chromium] Unreviewed gardening after r127907
572
573         Fix CCRenderPassTest::copyShouldBeIdenticalExceptIdAndQuads
574
575         * tests/CCRenderPassTest.cpp:
576         (CCRenderPassSize): Changed type of m_id
577
578 2012-09-09  Emil A Eklund  <eae@chromium.org>
579
580         Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
581         https://bugs.webkit.org/show_bug.cgi?id=81413
582
583         Reviewed by David Hyatt.
584
585         Update WebViewImpl to call boundingBox/pixelSnappedBoundingBox.
586
587         * src/WebViewImpl.cpp:
588         (WebKit::WebViewImpl::computeBlockBounds):
589         (WebKit::WebViewImpl::applyAutofillSuggestions):
590         (WebKit::WebViewImpl::refreshAutofillPopup):
591
592 2012-09-09  James Robinson  <jamesr@chromium.org>
593
594         [chromium] webkit_platform should only be linked into the webkit target
595         https://bugs.webkit.org/show_bug.cgi?id=96213
596
597         Reviewed by Adrienne Walker.
598
599         The Platform.gyp:webkit_platform target provides the implementation of several WEBKIT_EXPORTed symbols. It only
600         makes sense as a target of WebKit.gyp:webkit, other targets shouldn't directly depend on it.
601
602         * WebKit.gyp:
603
604 2012-09-09  James Robinson  <jamesr@chromium.org>
605
606         [chromium] Use WebCompositorSupport creation functions in GraphicsLayerChromiumTest
607         https://bugs.webkit.org/show_bug.cgi?id=96212
608
609         Reviewed by Adrienne Walker.
610
611         The static ::create()s the test references currently are going away soon.
612
613         * tests/GraphicsLayerChromiumTest.cpp:
614         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
615         (WebKit::TEST_F):
616
617 2012-09-07  Benjamin Poulain  <benjamin@webkit.org>
618
619         Unreviewed prospective build fix.
620
621         * tests/WebCompositorInputHandlerImplTest.cpp: Looks like someone is missing an #include.
622         Remove the using directive from r127959.
623
624 2012-09-07  Simon Hausmann  <simon.hausmann@nokia.com>
625
626         Unreviewed prospective build fix.
627
628         Use WTF namespace like in other files in the same directory to resolve unqualified
629         adoptPtr correctly.
630
631         * tests/WebCompositorInputHandlerImplTest.cpp:
632
633 2012-09-07  James Robinson  <jamesr@chromium.org>
634
635         [chromium] Remove transitional WebCompositorSupport fallback code
636         https://bugs.webkit.org/show_bug.cgi?id=96155
637
638         Reviewed by Adrienne Walker.
639
640         * src/LinkHighlight.cpp:
641         (WebKit::LinkHighlight::LinkHighlight):
642         (WebKit::LinkHighlight::startHighlightAnimation):
643         * src/WebMediaPlayerClientImpl.cpp:
644         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
645         * src/WebPluginContainerImpl.cpp:
646         (WebKit::WebPluginContainerImpl::setBackingTextureId):
647         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
648         * src/WebViewImpl.cpp:
649         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
650         (WebKit):
651
652 2012-09-07  James Robinson  <jamesr@chromium.org>
653
654         [chromium] Implement WebCompositorInputHandlerImpl on top of exposed API instead of CC internals
655         https://bugs.webkit.org/show_bug.cgi?id=96151
656
657         Reviewed by Adrienne Walker.
658
659         Moves input handler setup code up to the WebKit layer instead of reaching in to CC internals.
660         WebLayerTreeViewImpl implements createInputHandler() by asking its embedder for a WebInputHandler. If one is
661         provided, it wraps the WebInputHandler in a CCInputHandler implementation to pass down to CC.
662
663         WebViewImpl implements WebLayerTreeView::createInputHandler() by constructing a WebCompositorInputHandlerImpl
664         and storing its identifier for the didActivateCompositor call.  From this point on the setup is the same as
665         before.
666
667         WCIHI changes covered by unit tests, overall scrolling behavior manually tested.
668
669         * WebKit.gypi:
670         * src/WebCompositorInputHandlerImpl.cpp:
671         (WebKit::WebCompositorInputHandlerImpl::fromIdentifier):
672         (WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
673         (WebKit::WebCompositorInputHandlerImpl::~WebCompositorInputHandlerImpl):
674         (WebKit::WebCompositorInputHandlerImpl::setClient):
675         (WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
676         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
677         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
678         (WebKit::WebCompositorInputHandlerImpl::bindToClient):
679         * src/WebCompositorInputHandlerImpl.h:
680         (WebCompositorInputHandlerImpl):
681         (WebKit::WebCompositorInputHandlerImpl::identifier):
682         * src/WebLayerTreeViewImpl.cpp:
683         (WebKit::WebLayerTreeViewImpl::createInputHandler):
684         (WebKit):
685         * src/WebLayerTreeViewImpl.h:
686         (WebLayerTreeViewImpl):
687         * src/WebToCCInputHandlerAdapter.cpp: Added.
688         (WebKit):
689         (WebKit::WebToCCInputHandlerAdapter::create):
690         (WebKit::WebToCCInputHandlerAdapter::WebToCCInputHandlerAdapter):
691         (WebKit::WebToCCInputHandlerAdapter::~WebToCCInputHandlerAdapter):
692         (WebToCCInputHandlerAdapter::ClientAdapter):
693         (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::ClientAdapter):
694         (WebKit::WebToCCInputHandlerAdapter::ClientAdapter::~ClientAdapter):
695         (WebKit::WebToCCInputHandlerAdapter::bindToClient):
696         (WebKit::WebToCCInputHandlerAdapter::animate):
697         * src/WebToCCInputHandlerAdapter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostClient.h.
698         (WebKit):
699         (WebToCCInputHandlerAdapter):
700         * src/WebViewImpl.cpp:
701         (WebKit::WebViewImpl::WebViewImpl):
702         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
703         (WebKit):
704         (WebKit::WebViewImpl::createInputHandler):
705         * src/WebViewImpl.h:
706         (WebViewImpl):
707         * tests/CCThreadedTest.cpp:
708         * tests/FakeCCLayerTreeHostClient.h:
709         * tests/WebCompositorInputHandlerImplTest.cpp:
710         (MockWebInputHandlerClient):
711         (WebKit::MockWebInputHandlerClient::MockWebInputHandlerClient):
712         (WebKit::MockWebInputHandlerClient::~MockWebInputHandlerClient):
713         (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
714         (WebCompositorInputHandlerImplTest):
715         (WebKit::TEST_F):
716
717 2012-09-07  David Reveman  <reveman@chromium.org>
718
719         [Chromium] Multiple commits without invalidation allowed per redraw.
720         https://bugs.webkit.org/show_bug.cgi?id=95661
721
722         Reviewed by James Robinson.
723
724         * tests/CCLayerTreeHostTest.cpp:
725         (CCLayerTreeHostTestContinuousCommit):
726         (WebKitTests::CCLayerTreeHostTestContinuousCommit::CCLayerTreeHostTestContinuousCommit):
727         (WebKitTests):
728         (WebKitTests::TEST_F):
729         (CCLayerTreeHostTestContinuousInvalidate):
730         (WebKitTests::CCLayerTreeHostTestContinuousInvalidate::CCLayerTreeHostTestContinuousInvalidate):
731         (CCLayerTreeHostTestContinuousAnimate):
732         (WebKitTests::CCLayerTreeHostTestContinuousAnimate::CCLayerTreeHostTestContinuousAnimate):
733         * tests/CCSchedulerStateMachineTest.cpp:
734         (WebCore::TEST):
735
736 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
737
738         AX: WebCore accessibility roles should be cross-platform
739         https://bugs.webkit.org/show_bug.cgi?id=94870
740
741         Reviewed by Chris Fleizach.
742
743         Add a new accessibility role.
744
745         * public/WebAccessibilityRole.h:
746         * src/AssertMatchingEnums.cpp:
747
748 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
749
750         AX: Chromium needs access to canvasHasFallbackContent
751         https://bugs.webkit.org/show_bug.cgi?id=96124
752
753         Reviewed by Chris Fleizach.
754
755         Expose canvasHasFallbackContent on Chromium.
756
757         * public/WebAccessibilityObject.h:
758         (WebAccessibilityObject):
759         * src/WebAccessibilityObject.cpp:
760         (WebKit::WebAccessibilityObject::canvasHasFallbackContent):
761         (WebKit):
762
763 2012-09-07  Robert Kroeger  <rjkroege@chromium.org>
764
765         [chromium] Add touchscreen specific fling curve parametrization
766         https://bugs.webkit.org/show_bug.cgi?id=95997
767
768         Reviewed by James Robinson.
769
770         Added a new set of fling curve parameters with a good feel for touchscreen
771         initiated flings. Renamed TouchpadFlingPlatformGestureCurve to
772         TouchFlingPlatformGestureCurve to better reflect that the class
773         can serve for both touchscreen and touchpad flings when appropriately
774         parametrized. Updated build files as necessary for the rename.
775
776         No new tests - existing tests apply.
777
778
779         * tests/PlatformGestureCurveTest.cpp: To use the renamed curve constructor.
780
781 2012-09-07  Dana Jansens  <danakj@chromium.org>
782
783         [chromium] Make RenderPass ids hold both generating layer id and an index
784         https://bugs.webkit.org/show_bug.cgi?id=95500
785
786         Reviewed by Adrienne Walker.
787
788         * tests/CCLayerTreeHostImplTest.cpp:
789         * tests/CCLayerTreeHostTest.cpp:
790         * tests/CCRenderSurfaceTest.cpp:
791         * tests/CCRendererGLTest.cpp:
792         (FakeCCRendererClient::FakeCCRendererClient):
793
794 2012-09-07  Joshua Bell  <jsbell@chromium.org>
795
796         [Chromium] IndexedDB: public WebKit API changes for consolidating two-phase connect
797         https://bugs.webkit.org/show_bug.cgi?id=96122
798
799         Reviewed by Adam Barth.
800
801         Prep work for landing Chromium side of http://webkit.org/b/90411 - the IDBFactory
802         open() method now takes the "database callbacks", rather than being sent through
803         in a later call.
804
805         Also, delete an obsolete method.
806
807         * public/WebIDBFactory.h:
808         (WebKit):
809         (WebIDBFactory): Delete pre-version overload of open().
810         (WebKit::WebIDBFactory::open): Add overload that takes WebIDBDatabaseCallbacks.
811
812 2012-09-07  Sami Kyostila  <skyostil@google.com>
813
814         [Chromium] GraphicsLayerChromiumTest::applyScrollToScrollableArea() is failing
815         https://bugs.webkit.org/show_bug.cgi?id=95932
816
817         Reviewed by James Robinson.
818
819         Give the FakeScrollableArea valid geometry to allow ScrollAnimatorMac to
820         properly scroll it.
821
822         * tests/GraphicsLayerChromiumTest.cpp:
823         (WebKit::TEST_F): Re-enable the test.
824
825 2012-09-07  James Robinson  <jamesr@chromium.org>
826
827         [chromium] Move some CC unit tests into correct gyp variable
828         https://bugs.webkit.org/show_bug.cgi?id=96048
829
830         Reviewed by Adrienne Walker.
831
832         These tests are testing compositor internals, so they belong in the webkit_compositor_unittest_files variable.
833
834         * WebKit.gypi:
835
836 2012-09-07  James Robinson  <jamesr@chromium.org>
837
838         [chromium] Remove dead CCActiveGestureAnimation code and related classes
839         https://bugs.webkit.org/show_bug.cgi?id=96075
840
841         Reviewed by Adrienne Walker.
842
843         Cuts out unnecessary boilerplate in PlatformGestureCurve evaluation for handling flings. WCIHI can easily
844         evaluate the curve itself without intermediate classes.
845
846         * src/WebCompositorInputHandlerImpl.cpp:
847         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
848         (WebKit::WebCompositorInputHandlerImpl::animate):
849         (WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
850         * src/WebCompositorInputHandlerImpl.h:
851         (WebCore):
852         (WebCompositorInputHandlerImpl):
853         * tests/PlatformGestureCurveTest.cpp:
854         * tests/WebCompositorInputHandlerImplTest.cpp:
855
856 2012-09-07  James Robinson  <jamesr@chromium.org>
857
858         [chromium] Clean up dependencies in ScrollbarLayerChromiumTest
859         https://bugs.webkit.org/show_bug.cgi?id=96052
860
861         Reviewed by Adrienne Walker.
862
863         Fixes two minor but annoying dependencies in ScrollbarLayerChromiumTest:
864         *) WebScrollbarImpl.h is #included, but not use
865         *) The two-arg constructor of WebThemeScrollbarPainter is used, but this is guarded by #if
866             WEBKIT_IMPLEMENTATION. The no-arg c'tor does the right thing for this test.
867
868         * tests/ScrollbarLayerChromiumTest.cpp:
869         (WebCore::TEST):
870
871 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
872
873         AX: ARIA spin button should support range value attributes
874         https://bugs.webkit.org/show_bug.cgi?id=96076
875
876         Reviewed by Chris Fleizach.
877
878         Expose supportsRangeValue to simplify Chromium logic for when to
879         extract a value from a range.
880
881         * public/WebAccessibilityObject.h:
882         (WebAccessibilityObject):
883         * src/WebAccessibilityObject.cpp:
884         (WebKit::WebAccessibilityObject::supportsRangeValue):
885         (WebKit):
886
887 2012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
888
889         Simplify hitTestResultAtPoint and nodesFromRect APIs
890         https://bugs.webkit.org/show_bug.cgi?id=95720
891
892         Reviewed by Antonio Gomes.
893
894         Update calls to new API.
895
896         * src/ContextMenuClientImpl.cpp:
897         (WebKit::selectMisspelledWord):
898         * src/FrameLoaderClientImpl.cpp:
899         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
900         * src/WebFrameImpl.cpp:
901         (WebKit::WebFrameImpl::characterIndexForPoint):
902         * src/WebPluginContainerImpl.cpp:
903         (WebKit::WebPluginContainerImpl::isRectTopmost):
904         * src/WebViewImpl.cpp:
905         (WebKit::WebViewImpl::handleMouseUp):
906         (WebKit::WebViewImpl::computeBlockBounds):
907
908 2012-09-07  Ilya Tikhonovsky  <loislo@chromium.org>
909
910         Web Inspector: NMI: move WebCore specific code to separate header
911         https://bugs.webkit.org/show_bug.cgi?id=96101
912
913         Reviewed by Yury Semikhatsky.
914
915         I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h
916
917         * tests/MemoryInstrumentationTest.cpp:
918
919 2012-09-07  Ian Vollick  <vollick@chromium.org>
920
921         [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
922         https://bugs.webkit.org/show_bug.cgi?id=95855
923
924         Reviewed by James Robinson.
925
926         Added the following unit tests:
927           AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
928           AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform
929
930         * tests/AnimationTranslationUtilTest.cpp:
931         (WebKit::TEST):
932         (WebKit):
933
934 2012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
935
936         X11 Global Selection
937         https://bugs.webkit.org/show_bug.cgi?id=88238
938
939         Reviewed by Tony Chang.
940
941         Use new editor command for pasting global selection.
942
943         * src/EditorClientImpl.cpp:
944         (WebKit::EditorClientImpl::supportsGlobalSelection):
945         * src/EditorClientImpl.h:
946         (EditorClientImpl):
947         * src/WebViewImpl.cpp:
948         (WebKit::WebViewImpl::handleMouseUp):
949
950 2012-09-07  Yoshifumi Inoue  <yosin@chromium.org>
951
952         We should have a localized string of empty for date time field
953         https://bugs.webkit.org/show_bug.cgi?id=96081
954
955         Reviewed by Kent Tamura.
956
957         This patch add a function for getting localized string of empty field
958         value of date time fields for accessibility inside
959         ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
960
961         These functions will be used by derived classes of DateTimeFieldElement.
962
963         Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
964         to support "date", "datetime", "month" and "week" multiple fields input
965         UI.
966
967         * src/LocalizedStrings.cpp:
968         (WebCore::AXDateTimeFieldEmptyValueText): Added.
969
970 2012-09-06  Sheriff Bot  <webkit.review.bot@gmail.com>
971
972         Unreviewed, rolling out r127822.
973         http://trac.webkit.org/changeset/127822
974         https://bugs.webkit.org/show_bug.cgi?id=96073
975
976         It broke compilation on chromium debug bots (Requested by
977         loislo on #webkit).
978
979         * tests/CCDrawQuadTest.cpp:
980         (WebCore::TEST):
981         * tests/CCLayerTreeHostImplTest.cpp:
982         * tests/CCLayerTreeHostTest.cpp:
983         * tests/CCRenderPassTest.cpp:
984         (WebCore::TEST):
985         * tests/CCRenderSurfaceTest.cpp:
986         * tests/CCRendererGLTest.cpp:
987         (FakeCCRendererClient::FakeCCRendererClient):
988
989 2012-09-06  Dana Jansens  <danakj@chromium.org>
990
991         [chromium] Make RenderPass ids hold both generating layer id and an index
992         https://bugs.webkit.org/show_bug.cgi?id=95500
993
994         Reviewed by Adrienne Walker.
995
996         * tests/CCLayerTreeHostImplTest.cpp:
997         * tests/CCLayerTreeHostTest.cpp:
998         * tests/CCRenderSurfaceTest.cpp:
999         * tests/CCRendererGLTest.cpp:
1000         (FakeCCRendererClient::FakeCCRendererClient):
1001
1002 2012-09-06  Yoshifumi Inoue  <yosin@chromium.org>
1003
1004         We should have localized strings of date time fields for accessibility
1005         https://bugs.webkit.org/show_bug.cgi?id=96050
1006
1007         Reviewed by Kent Tamura.
1008
1009         This patch adds functions for getting localized strings of date time
1010         fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
1011
1012         These functions will be used by derived classes of DateTimeFieldElement.
1013
1014         Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
1015         to support "date", "datetime", "month" and "week" multiple fields input
1016         UI.
1017
1018         * src/LocalizedStrings.cpp:
1019         (WebCore::AXAMPMFieldText): Added.
1020         (WebCore::AXDayOfMonthFieldText): Added.
1021         (WebCore::AXHourFieldText): Added.
1022         (WebCore::AXMillisecondFieldText): Added.
1023         (WebCore::AXMinuteFieldText): Added.
1024         (WebCore::AXMonthFieldText): Added.
1025         (WebCore::AXSecondFieldText): Added.
1026         (WebCore::AXWeekOfYearFieldText): Added.
1027         (WebCore::AXYearFieldText): Added.
1028
1029 2012-09-06  James Robinson  <jamesr@chromium.org>
1030
1031         [chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
1032         https://bugs.webkit.org/show_bug.cgi?id=96024
1033
1034         Reviewed by Adam Barth.
1035
1036         When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
1037         We don't need to link anything in to WebKit.dll.
1038
1039         * WebKit.gyp:
1040
1041 2012-09-06  James Robinson  <jamesr@chromium.org>
1042
1043         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
1044         https://bugs.webkit.org/show_bug.cgi?id=96007
1045
1046         Reviewed by Adrienne Walker.
1047
1048         Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
1049         WebCompositorInitializer RAII class to simplify this somewhat tedious process.
1050
1051         * WebKit.gypi:
1052         * public/WebCompositorInputHandlerClient.h:
1053         (WebCompositorInputHandlerClient):
1054         * src/WebCompositorInputHandlerImpl.h:
1055         * src/WebViewImpl.cpp:
1056         (WebKit::WebViewImpl::composite):
1057         (WebKit::WebViewImpl::scheduleAnimation):
1058         (WebKit::WebViewImpl::scheduleComposite):
1059         * tests/CCPrioritizedTextureTest.cpp:
1060         (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
1061         (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
1062         (CCPrioritizedTextureTest):
1063         * tests/CCRendererGLTest.cpp:
1064         (CCRendererGLTest::CCRendererGLTest):
1065         (CCRendererGLTest::SetUp):
1066         (CCRendererGLTest):
1067         * tests/CCTextureUpdateControllerTest.cpp:
1068         * tests/CCThreadedTest.cpp:
1069         (WebKitTests::CCThreadedTest::runTest):
1070         * tests/Canvas2DLayerBridgeTest.cpp:
1071         (Canvas2DLayerBridgeTest::fullLifecycleTest):
1072         * tests/GraphicsLayerChromiumTest.cpp:
1073         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
1074         (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
1075         * tests/LayerChromiumTest.cpp:
1076         * tests/LinkHighlightTest.cpp:
1077         (WebCore::TEST):
1078         * tests/TextureLayerChromiumTest.cpp:
1079         * tests/TiledLayerChromiumTest.cpp:
1080         * tests/WebCompositorInitializer.h: Added.
1081         (WebKit):
1082         (WebKitTests):
1083         (WebCompositorInitializer):
1084         (WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
1085         (WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):
1086         * tests/WebCompositorInputHandlerImplTest.cpp:
1087         (WebKit::TEST):
1088         (WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
1089         (WebCompositorInputHandlerImplTest):
1090         * tests/WebLayerTest.cpp:
1091         * tests/WebLayerTreeViewTest.cpp:
1092
1093 2012-09-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1094
1095         Unreviewed.  Rolled DEPS.
1096
1097         * DEPS:
1098
1099 2012-09-06  Alec Flett  <alecflett@chromium.org>
1100
1101         IndexedDB: make IDBKeyPath's string and array constructors explicit
1102         https://bugs.webkit.org/show_bug.cgi?id=96004
1103
1104         Reviewed by Tony Chang.
1105
1106         Fix test to use explicit constructor for IDBKeyPath.
1107
1108         * tests/IDBDatabaseBackendTest.cpp:
1109
1110 2012-09-06  Adrienne Walker  <enne@google.com>
1111
1112         [chromium] Remove GraphicsContext references from ContentLayerChromiumTest
1113         https://bugs.webkit.org/show_bug.cgi?id=96002
1114
1115         Reviewed by James Robinson.
1116
1117         This is a compositor unit test, so it shouldn't reference things
1118         outside of the compositor like GraphicsContext. The
1119         OpaqueRectTrackingContentLayerDelegateTest already tests opaque
1120         tracking right at the time of paint. This test is about verifying that
1121         transformed canvases work properly, so can just fake the opaque rect
1122         coming back from the paint.
1123
1124         * tests/ContentLayerChromiumTest.cpp:
1125         (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
1126         (WebKit::TEST):
1127
1128 2012-09-06  Jeff Timanus  <twiz@chromium.org>
1129
1130         [Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
1131         https://bugs.webkit.org/show_bug.cgi?id=95094
1132
1133         Reviewed by Adrienne Walker.
1134
1135         In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
1136         try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
1137         contentsScale behaviour.
1138         This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.
1139
1140         * src/NonCompositedContentHost.cpp:
1141         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
1142             Inform the layer associated with the NCCH that it is to disregard the page scale factor.
1143             Also remove now unused m_deviceScaleFactor and associated routines.
1144         (WebKit::NonCompositedContentHost::setViewport):
1145         * src/NonCompositedContentHost.h:
1146         (NonCompositedContentHost):
1147         * src/WebContentLayerImpl.cpp:
1148         (WebKit::WebContentLayerImpl::setBoundsContainPageScale):
1149         (WebKit):
1150         (WebKit::WebContentLayerImpl::boundsContainPageScale):
1151         * src/WebContentLayerImpl.h:
1152         (WebContentLayerImpl):
1153         * src/WebViewImpl.cpp:
1154         (WebKit::WebViewImpl::updateLayerTreeViewport):
1155         * tests/CCLayerTreeHostTest.cpp:
1156         (NoScaleContentLayerChromium):
1157         (WebKitTests::NoScaleContentLayerChromium::create):
1158         (WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
1159         (WebKitTests):
1160         (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
1161             Rebaselined to correspond to the new behaviour.  Because the layers are now assigned a contentsScale, the
1162             scale on the draw transforms remain identity.
1163         * tests/GraphicsLayerChromiumTest.cpp:
1164         (WebKit): Remove now obsolete unit-test.
1165
1166 2012-09-06  Adrienne Walker  <enne@google.com>
1167
1168         [chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
1169         https://bugs.webkit.org/show_bug.cgi?id=95994
1170
1171         Reviewed by James Robinson.
1172
1173         This compositor test shouldn't depend on code outside the compositor.
1174
1175         * tests/ScrollbarLayerChromiumTest.cpp:
1176         (WebCore::FakeWebScrollbar::create):
1177         (FakeWebScrollbar):
1178         (WebCore::TEST):
1179
1180 2012-09-06  James Robinson  <jamesr@chromium.org>
1181
1182         [chromium] Put chromium implementations of WTF symbols in separate static library
1183         https://bugs.webkit.org/show_bug.cgi?id=95933
1184
1185         Reviewed by Adam Barth.
1186
1187         A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
1188         implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
1189         component build is a DLL. This moves these files into a static library that webkit depends on so targets can
1190         statically link in wtf and these support files without depending directly on webkit.
1191
1192         * WebKit.gyp:
1193
1194 2012-09-06  Iain Merrick  <husky@chromium.org>
1195
1196         [chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
1197         https://bugs.webkit.org/show_bug.cgi?id=93998
1198
1199         Reviewed by Adam Barth.
1200
1201         These provide the same functionality selectRange(WebPoint, WebPoint),
1202         with finer-grained control needed on the Android platform. By passing
1203         allowCollapsedSelection=false, we can ensure the selection stays at
1204         least one character wide.
1205
1206         I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
1207         calling the new methods. The existing test passes, and I've added new
1208         tests for the new methods.
1209
1210         * public/WebFrame.h:
1211         (WebFrame):
1212         * src/WebFrameImpl.cpp:
1213         (WebKit::WebFrameImpl::selectRange):
1214         (WebKit):
1215         (WebKit::WebFrameImpl::moveSelectionStart):
1216         (WebKit::WebFrameImpl::moveSelectionEnd):
1217         (WebKit::WebFrameImpl::moveCaret):
1218         * src/WebFrameImpl.h:
1219         (WebFrameImpl):
1220         * tests/WebFrameTest.cpp:
1221         * tests/data/text_selection.html: Added.
1222
1223 2012-09-06  Robert Kroeger  <rjkroege@chromium.org>
1224
1225         [chromium] Enable different fling behaviour for touchscreen and touchpad
1226         https://bugs.webkit.org/show_bug.cgi?id=95756
1227
1228         Reviewed by James Robinson.
1229
1230         Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
1231         events by their originating device and pass this flag to a factory that produces
1232         different device  specific fling curves based on the value of the flag.
1233
1234         * public/WebActiveWheelFlingParameters.h:
1235         (WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
1236         (WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
1237         * public/WebInputEvent.h: Added source device flag to WebGestureEvent.
1238         * src/WebCompositorInputHandlerImpl.cpp:
1239         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):  Use factory to
1240         obtain device-appropriate fling curve.
1241         * src/WebViewImpl.cpp:
1242         (WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
1243         fling curve.
1244         (WebKit::WebViewImpl::transferActiveWheelFlingAnimation):
1245
1246 2012-09-05  Sam Weinig  <sam@webkit.org>
1247
1248         Part 2 of removing PlatformString.h, remove PlatformString.h
1249         https://bugs.webkit.org/show_bug.cgi?id=95931
1250
1251         Reviewed by Adam Barth.
1252
1253         Remove PlatformString.h
1254
1255         * src/ContextMenuClientImpl.cpp:
1256         * src/EditorClientImpl.cpp:
1257         * src/InspectorFrontendClientImpl.cpp:
1258         * src/LocalFileSystemChromium.cpp:
1259         * src/SpeechInputClientImpl.cpp:
1260         * src/SpeechRecognitionClientProxy.h:
1261         * src/WebDevToolsAgentImpl.cpp:
1262         * src/WebDevToolsFrontendImpl.cpp:
1263         * src/WebDevToolsFrontendImpl.h:
1264         * src/WebEntities.h:
1265         * src/WebFrameImpl.h:
1266         * src/WorkerFileSystemCallbacksBridge.h:
1267         * tests/UniscribeHelperTest.cpp:
1268
1269 2012-09-06  Dana Jansens  <danakj@chromium.org>
1270
1271         [chromium] Add a customized copy() method to CCRenderPassDrawQuad
1272         https://bugs.webkit.org/show_bug.cgi?id=95871
1273
1274         Reviewed by Adrienne Walker.
1275
1276         * tests/CCDrawQuadTest.cpp:
1277         (WebCore):
1278         (WebCore::TEST):
1279
1280 2012-09-06  Ilya Tikhonovsky  <loislo@chromium.org>
1281
1282         Unreviewed Web Inspector: test fix.
1283
1284         * tests/MemoryInstrumentationTest.cpp:
1285         (StringOwnerInstrumented):
1286         (WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
1287         (WebCore::StringOwnerInstrumented::reportMemoryUsage):
1288         (WebCore):
1289         (WebCore::TEST):
1290
1291 2012-09-06  Ilya Tikhonovsky  <loislo@chromium.org>
1292
1293         Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
1294         https://bugs.webkit.org/show_bug.cgi?id=95957
1295
1296         Reviewed by Yury Semikhatsky.
1297
1298         Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
1299         instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
1300         At a later stage, when each memory type is counted in MemoryInstrumentation
1301         we will build the blocks hierarchy for the front-end automatically.
1302
1303         * tests/MemoryInstrumentationTest.cpp:
1304         (WebCore::InstrumentedUndefined::InstrumentedUndefined):
1305         (WebCore::InstrumentedUndefined::reportMemoryUsage):
1306         (WebCore::InstrumentedDOM::InstrumentedDOM):
1307         (WebCore::InstrumentedDOM::reportMemoryUsage):
1308         (InstrumentedDOM):
1309         (WebCore::TEST):
1310
1311 2012-09-06  Kenichi Ishibashi  <bashi@chromium.org>
1312
1313         [Chromium] Win build fix attempt after r127715
1314
1315         * tests/CCRenderPassTest.cpp:
1316         (WebCore::TEST):
1317
1318 2012-09-06  Peter Beverloo  <peter@chromium.org>
1319
1320         Unreviewed.  Rolled DEPS.
1321
1322         * DEPS:
1323
1324 2012-09-06  Dana Jansens  <danakj@chromium.org>
1325
1326         [chromium] Add a copy() method to CCRenderPass
1327         https://bugs.webkit.org/show_bug.cgi?id=95485
1328
1329         Reviewed by Adrienne Walker.
1330
1331         * WebKit.gypi:
1332         * tests/CCRenderPassTest.cpp: Added.
1333         (CCTestRenderPass):
1334         (CCTestRenderPass::quadList):
1335         (CCTestRenderPass::sharedQuadStateList):
1336         (CCRenderPassSize):
1337         (TEST):
1338
1339 2012-09-06  Peter Beverloo  <peter@chromium.org>
1340
1341         [Chromium] Chromium Mac build fix after revision r127711
1342         https://bugs.webkit.org/show_bug.cgi?id=95958
1343
1344         Unreviewed build fix.
1345
1346         This is a clear typo in the source file, so changing the function to
1347         call locationModifiersFromWindowsKeyCode instead.
1348
1349         * src/mac/WebInputEventFactory.mm:
1350         (WebKit::WebInputEventFactory::keyboardEvent):
1351
1352 2012-09-06  Raymes Khoury  <raymes@chromium.org>
1353
1354         Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
1355         https://bugs.webkit.org/show_bug.cgi?id=94142
1356
1357         Reviewed by Tony Chang.
1358
1359         Previously we distinguished between left/right Shift/Ctrl/Alt in
1360         WebInputEvents by using the location-specific virtual keycodes (e.g.
1361         VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
1362         always returns the non-locational version (e.g. VK_SHIFT).
1363         Furthermore, KeyboardEvent also returns
1364         non-locational keycodes and separates the location information which
1365         matches the behavior described in the DOM3
1366         spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
1367         should be consistent with this in our representation of key events.
1368         This patch changes WebInputEvents so they always store the
1369         non-locational keycode and location information is stored in
1370         modifiers. Since this only changes internal representation, no new
1371         tests are added.
1372
1373         This patch also ensures that when KeyboardEvents are converted back to
1374         WebInputEvents location information is preserved (which was not
1375         happening before). This is important so that key location information
1376         is passed on to plugins. A unittest is added for this.
1377
1378         * WebKit.gypi:
1379         * public/WebInputEvent.h:
1380         (WebKeyboardEvent):
1381         * src/WebInputEvent.cpp:
1382         (WebKit):
1383         (WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
1384         (WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):
1385         * src/WebInputEventConversion.cpp:
1386         (WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
1387         (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
1388         * src/android/WebInputEventFactory.cpp:
1389         (WebKit::WebInputEventFactory::keyboardEvent):
1390         * src/gtk/WebInputEventFactory.cpp:
1391         (WebKit::WebInputEventFactory::keyboardEvent):
1392         * src/mac/WebInputEventFactory.mm:
1393         (WebKit::WebInputEventFactory::keyboardEvent):
1394         * src/win/WebInputEventFactory.cpp:
1395         (WebKit::getLocationModifier):
1396         (WebKit::WebInputEventFactory::keyboardEvent):
1397         * tests/WebInputEventConversionTest.cpp: Added.
1398
1399 2012-09-06  Adam Barth  <abarth@webkit.org>
1400
1401         Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
1402         https://bugs.webkit.org/show_bug.cgi?id=91110
1403
1404         Reviewed by Tony Chang.
1405
1406         Prior to this patch, we were ignoring the user-scalable property of
1407         viewport meta tags. This patch enforces the user-scalable property by
1408         claming the minimum-scale and maximum-scale values, effectively
1409         preventing user scaling. This approach isn't perfect, as discussed in
1410         https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
1411         over the status quo.
1412
1413         This approach is also used by EFL, GTK, and Qt.
1414
1415         * src/ChromeClientImpl.cpp:
1416         (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
1417
1418 2012-09-05  Dana Jansens  <danakj@chromium.org>
1419
1420         [chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
1421         https://bugs.webkit.org/show_bug.cgi?id=95374
1422
1423         Reviewed by Adrienne Walker.
1424
1425         * WebKit.gypi:
1426         * tests/CCDrawQuadTest.cpp: Added.
1427         (TEST):
1428         (createSharedQuadState):
1429         (compareDrawQuad):
1430
1431 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
1432
1433         [Chromium] Unreviewed gardening
1434
1435         * tests/GraphicsLayerChromiumTest.cpp:
1436         (WebKit::TEST_F): Disabled applyScrollToScrollableArea()
1437
1438 2012-09-05  Tony Chang  <tony@chromium.org>
1439
1440         [chromium] Remove dependency on webkit_user_agent
1441         https://bugs.webkit.org/show_bug.cgi?id=95886
1442
1443         Reviewed by Adam Barth.
1444
1445         The code isn't used by webkit_unit_tests.
1446
1447         * WebKitUnitTests.gyp:
1448
1449 2012-09-05  Nate Chapin  <japhet@chromium.org>
1450
1451         Test for https://bugs.webkit.org/show_bug.cgi?id=91685
1452
1453         Reviewed by Adam Barth.
1454
1455         * tests/WebFrameTest.cpp:
1456
1457 2012-09-05  Rick Byers  <rbyers@chromium.org>
1458
1459         Use new type-specific WebGestureEvent fields
1460         https://bugs.webkit.org/show_bug.cgi?id=95573
1461
1462         Reviewed by James Robinson.
1463
1464         Chromium has been updated to store gesture-type specific details in the
1465         new WebGestureEvent fields (crrev.com/152508, crrev.com/154815 and
1466         crrev.com/154959), so we can now rely on them.
1467
1468         * src/WebCompositorInputHandlerImpl.cpp:
1469         Update the compositor scroll, pinch and fling handling to use these new fields.
1470         (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
1471         (WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
1472         * src/WebInputEventConversion.cpp:
1473         Update PlatformGestureEvent/WebGestureEvent conversion to use the new
1474         fields, storing into the existing overloaded PlatformGestureEvent
1475         fields (which will be cleaned up in my next CL).
1476         (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
1477         (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
1478         * src/WebViewImpl.cpp:
1479         (WebKit::WebViewImpl::handleGestureEvent):
1480         Update fling scrolling implementation for correct location of velocity.
1481         * tests/WebCompositorInputHandlerImplTest.cpp:
1482         (WebKit::TEST_F):
1483         Update tests to use the new fields.
1484
1485
1486 2012-09-05  James Robinson  <jamesr@chromium.org>
1487
1488         [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
1489         https://bugs.webkit.org/show_bug.cgi?id=95819
1490
1491         Reviewed by Adam Barth.
1492
1493         This unit test doesn't do all that much, but it does verify that WebSolidColorLayer doesn't completely explode
1494         upon use and also makes sure that the WebSolidColorLayer::create() symbol is referenced and not dropped from
1495         webkit.dll in the component build.
1496
1497         * tests/WebLayerTest.cpp:
1498
1499 2012-09-05  Victoria Kirst  <vrk@chromium.org>
1500
1501         Add the duration attribute to MediaSource
1502         https://bugs.webkit.org/show_bug.cgi?id=95149
1503
1504         Reviewed by Eric Carlson.
1505
1506         Add support for the duration attribute recently added to the MediaSource spec.
1507         http://dev.w3.org/html5/spec/media-elements.html#dom-media-duration
1508
1509         * public/WebMediaPlayer.h:
1510         (WebKit::WebMediaPlayer::sourceSetDuration): Add empty definition.
1511         * src/WebMediaPlayerClientImpl.cpp:
1512         (WebKit::WebMediaPlayerClientImpl::sourceSetDuration): Forward call to m_webMediaPlayer.
1513         (WebKit):
1514         * src/WebMediaPlayerClientImpl.h:
1515         (WebMediaPlayerClientImpl):
1516
1517 2012-09-05  Mihai Parparita  <mihaip@chromium.org>
1518
1519         [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
1520         https://bugs.webkit.org/show_bug.cgi?id=95865
1521
1522         Reviewed by Darin Fisher.
1523
1524         Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
1525         no-ops.
1526
1527         * public/WebRuntimeFeatures.h:
1528         (WebRuntimeFeatures):
1529         * src/WebRuntimeFeatures.cpp:
1530         (WebKit::WebRuntimeFeatures::enablePushState):
1531         (WebKit::WebRuntimeFeatures::isPushStateEnabled):
1532
1533 2012-09-05  Mark Pilgrim  <pilgrim@chromium.org>
1534
1535         [Chromium] Remove getRenderStyleForStrike from PlatformSupport
1536         https://bugs.webkit.org/show_bug.cgi?id=95363
1537
1538         Reviewed by Adam Barth.
1539
1540         Part of a refactoring series. See tracking bug 82948.
1541
1542         * public/linux/WebFontInfo.h:
1543         * public/linux/WebFontRenderStyle.h:
1544         * src/PlatformSupport.cpp:
1545         (WebCore):
1546
1547 2012-09-05  Ilya Tikhonovsky  <loislo@chromium.org>
1548
1549         Unreviewed: WebInspector: remove accidentally committed speed test.
1550
1551         * tests/MemoryInstrumentationTest.cpp:
1552
1553 2012-09-05  Sami Kyostila  <skyostil@chromium.org>
1554
1555         [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
1556         https://bugs.webkit.org/show_bug.cgi?id=95679
1557
1558         Reviewed by James Robinson.
1559
1560         Introduce WebLayerScrollClient for getting notified about scroll events targeting a WebLayer.
1561
1562         * src/WebLayerImpl.cpp:
1563         (WebKit::WebLayerImpl::setMaxScrollPosition):
1564         (WebKit):
1565         (WebKit::WebLayerImpl::setScrollClient):
1566         (WebKit::WebLayerImpl::scrollBy):
1567         * src/WebLayerImpl.h:
1568         (WebLayerImpl):
1569         * tests/CCLayerTreeHostTest.cpp:
1570         * tests/GraphicsLayerChromiumTest.cpp:
1571         (MockScrollableArea):
1572         (WebKit):
1573         (WebKit::TEST_F):
1574         * tests/WebLayerTest.cpp:
1575
1576 2012-09-05  Ilya Tikhonovsky  <loislo@chromium.org>
1577
1578         Web Inspector: NMI: extract MemoryObjectType constants from MemoryInstrumentation.
1579         https://bugs.webkit.org/show_bug.cgi?id=95850
1580
1581         Reviewed by Yury Semikhatsky.
1582
1583         I'd like to extract MemoryObjectTypes into separate classes.
1584         After that we will be able to move core NMI instrumentation code to WTF.
1585
1586         * tests/MemoryInstrumentationTest.cpp:
1587         (WebCore::Instrumented::reportMemoryUsage):
1588         (WebCore::InstrumentedRefPtr::reportMemoryUsage):
1589         (WebCore::InstrumentedWithOwnPtr::reportMemoryUsage):
1590         (WebCore::InstrumentedOther::reportMemoryUsage):
1591         (WebCore::InstrumentedDOM::reportMemoryUsage):
1592         (WebCore::TEST):
1593         (WebCore::NonVirtualInstrumented::reportMemoryUsage):
1594
1595 2012-09-05  Peter Beverloo  <peter@chromium.org>
1596
1597         Unreviewed, rolling out r127590.
1598         http://trac.webkit.org/changeset/127590
1599
1600         Broke the Chromium bots because of a compile error in the compositor.
1601
1602         * DEPS:
1603
1604 2012-09-05  Peter Beverloo  <peter@chromium.org>
1605
1606         Unreviewed.  Rolled DEPS.
1607
1608         * DEPS:
1609
1610 2012-09-04  Ilya Tikhonovsky  <loislo@chromium.org>
1611
1612         Web Inspector: NMI: replace ObjectType enum with static const char* string identifiers.
1613         https://bugs.webkit.org/show_bug.cgi?id=95739
1614
1615         Reviewed by Yury Semikhatsky.
1616
1617         When we go deeper into different parts of browser like skia, chromium itself etc.
1618         we can't use a single enum for all reported object types.
1619         The current idea is to use plain simple strings as ObjectType identifiers.
1620         In the future patches we will extract these identifiers into separate class or namespace
1621         and and split it between components.
1622
1623         * tests/MemoryInstrumentationTest.cpp:
1624         (WebCore::TEST):
1625         (WebCore):
1626
1627 2012-09-04  Keishi Hattori  <keishi@webkit.org>
1628
1629         Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
1630         https://bugs.webkit.org/show_bug.cgi?id=95681
1631
1632         Reviewed by Kent Tamura.
1633
1634         * WebKit.gyp:
1635         * src/ChromeClientImpl.cpp:
1636         (WebKit):
1637         (WebKit::ChromeClientImpl::openDateTimeChooser):
1638         * src/ChromeClientImpl.h:
1639         (WebCore):
1640         (ChromeClientImpl):
1641         * src/DateTimeChooserImpl.cpp: Added.
1642         (WebKit):
1643         (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
1644         (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
1645         (WebKit::DateTimeChooserImpl::endChooser):
1646         (WebKit::DateTimeChooserImpl::contentSize):
1647         (WebKit::DateTimeChooserImpl::writeDocument):
1648         (WebKit::DateTimeChooserImpl::setValueAndClosePopup):
1649         (WebKit::DateTimeChooserImpl::didClosePopup):
1650         * src/DateTimeChooserImpl.h:
1651         (WebCore):
1652         (WebKit):
1653         (DateTimeChooserImpl):
1654
1655 2012-09-04  Adam Barth  <abarth@chromium.org>
1656
1657         Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
1658         https://bugs.webkit.org/show_bug.cgi?id=95798
1659
1660         Reviewed by Eric Seidel.
1661
1662         * src/WebAccessibilityObject.cpp:
1663         (WebKit::WebAccessibilityObject::keyboardShortcut):
1664           - Remove use of WTF::String::operator+=
1665         * src/WebPageSerializerImpl.cpp:
1666           - Whitelist use of WTF::String::operator+=. Remove this use will take
1667             some more careful thought.
1668
1669 2012-09-04  Alec Flett  <alecflett@chromium.org>
1670
1671         IndexedDB: remove final createIndex backend glue
1672         https://bugs.webkit.org/show_bug.cgi?id=95385
1673
1674         Reviewed by Adam Barth.
1675
1676         Remove chromium glue for old key-generation code.
1677
1678         * public/WebIDBKey.h:
1679         (WebIDBKey):
1680         * src/WebIDBKey.cpp:
1681
1682 2012-09-04  Tien-Ren Chen  <trchen@chromium.org>
1683
1684         [chromium] Rename WebViewClient::handleDisambiguationPopup
1685         https://bugs.webkit.org/show_bug.cgi?id=95529
1686
1687         Reviewed by Adam Barth.
1688
1689         Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.
1690
1691         * public/WebViewClient.h:
1692         (WebKit::WebViewClient::didTapMultipleTargets):
1693         * src/WebViewImpl.cpp:
1694         (WebKit::WebViewImpl::handleGestureEvent):
1695         * tests/WebFrameTest.cpp:
1696
1697 2012-09-03  Tao Bai  <michaelbai@chromium.org>
1698
1699         Added ANDROID_GDBSERVER definition for Ant
1700         https://bugs.webkit.org/show_bug.cgi?id=95265
1701
1702         Reviewed by Adam Barth.
1703
1704         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
1705         is only used for finding the gdbserver.
1706
1707         * WebKitUnitTests.gyp:
1708
1709 2012-09-03  Peter Beverloo  <peter@chromium.org>
1710
1711         Unreviewed.  Rolled DEPS.
1712
1713         * DEPS:
1714
1715 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
1716
1717         MediaStream API: Add Ice-related functionality to RTCPeerConnection
1718         https://bugs.webkit.org/show_bug.cgi?id=95565
1719
1720         Reviewed by Adam Barth.
1721
1722         * src/AssertMatchingEnums.cpp:
1723
1724 2012-09-01  James Robinson  <jamesr@chromium.org>
1725
1726         Unreviewed chromium buildfix when use_libcc_for_compositor=1
1727
1728         This gyp target was renamed downstream.
1729
1730         * WebKit.gyp:
1731
1732 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
1733
1734         MediaStream API: Add MediaStream management to RTCPeerConnection
1735         https://bugs.webkit.org/show_bug.cgi?id=95543
1736
1737         Reviewed by Adam Barth.
1738
1739         * src/AssertMatchingEnums.cpp:
1740
1741 2012-08-31  Koji Ishii  <kojiishi@gmail.com>
1742
1743         Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
1744         https://bugs.webkit.org/show_bug.cgi?id=51450
1745
1746         Reviewed by Tony Chang.
1747
1748         When writing-mode is vertical-*, Chromium Win does not render glyphs correctly.
1749         http://dev.w3.org/csswg/css3-writing-modes/#writing-mode
1750         Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name,
1751         and vertical alternate glyphs (OpenType 'vert' feature) is not enabled.
1752         CJK characters drawn at wrong baseline position is also fixed.
1753         In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty
1754         in Chromium Win but they were implemented because they were needed to draw vertical flow correctly.
1755
1756         Note that this patch does not address issues in vertical flow for complex code path.
1757         The issue is under discussion with Google people and it will not be fixed in short term.
1758
1759         Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations.
1760
1761         * features.gypi: ENABLE_OPENTYPE_VERTICAL=1.
1762
1763 2012-08-31  W. James MacLean  <wjmaclean@chromium.org>
1764
1765         [chromium] Make link highlighter use same node selection criteria as Chromium for Android.
1766         https://bugs.webkit.org/show_bug.cgi?id=95371
1767
1768         Reviewed by James Robinson.
1769
1770         This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.
1771
1772         * src/WebViewImpl.cpp:
1773         (WebKit::highlightConditions):
1774         (WebKit::WebViewImpl::bestTouchLinkNode):
1775         * tests/data/test_touch_link_highlight.html:
1776
1777 2012-08-31  James Robinson  <jamesr@chromium.org>
1778
1779         [chromium] Consolidate geometry unit testing functions for cc
1780         https://bugs.webkit.org/show_bug.cgi?id=95526
1781
1782         Reviewed by Julien Chaffraix.
1783
1784         This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
1785         testing rect equality.
1786
1787         * WebKit.gypi:
1788         * tests/CCDamageTrackerTest.cpp:
1789         (WebKitTests::TEST_F):
1790         * tests/CCGeometryTestUtils.cpp: Added.
1791         (WebKitTests):
1792         (WebKitTests::ExpectTransformationMatrixEq):
1793         * tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.
1794         (WebKit):
1795         (WebKitTests):
1796         * tests/CCLayerTreeHostTest.cpp:
1797         * tests/CCMathUtilTest.cpp:
1798         (WebKit::TEST):
1799         * tests/TiledLayerChromiumTest.cpp:
1800
1801 2012-08-31  James Robinson  <jamesr@chromium.org>
1802
1803         [chromium] Clean up Web*Layer initialization paths
1804         https://bugs.webkit.org/show_bug.cgi?id=95523
1805
1806         Reviewed by Darin Fisher.
1807
1808         Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
1809         implementation. Also normalizes naming conventions in these files.
1810
1811         * src/WebAnimationImpl.cpp:
1812         (WebKit::WebAnimation::create):
1813         (WebKit::WebAnimationImpl::WebAnimationImpl):
1814         * src/WebAnimationImpl.h:
1815         (WebAnimationImpl):
1816         * src/WebContentLayerImpl.cpp:
1817         (WebKit::WebContentLayerImpl::WebContentLayerImpl):
1818         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
1819         (WebKit::WebContentLayerImpl::layer):
1820         (WebKit::WebContentLayerImpl::setDoubleSided):
1821         (WebKit::WebContentLayerImpl::setContentsScale):
1822         (WebKit::WebContentLayerImpl::setUseLCDText):
1823         (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
1824         * src/WebContentLayerImpl.h:
1825         (WebContentLayerImpl):
1826         * src/WebFloatAnimationCurveImpl.cpp:
1827         (WebKit::WebFloatAnimationCurve::create):
1828         (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
1829         * src/WebFloatAnimationCurveImpl.h:
1830         (WebFloatAnimationCurveImpl):
1831         * src/WebIOSurfaceLayerImpl.cpp:
1832         (WebKit::WebIOSurfaceLayer::create):
1833         (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
1834         * src/WebIOSurfaceLayerImpl.h:
1835         (WebIOSurfaceLayerImpl):
1836         * src/WebImageLayerImpl.cpp:
1837         (WebKit::WebImageLayer::create):
1838         (WebKit::WebImageLayerImpl::WebImageLayerImpl):
1839         * src/WebImageLayerImpl.h:
1840         (WebImageLayerImpl):
1841         * src/WebLayerImpl.cpp:
1842         (WebKit::WebLayer::create):
1843         (WebKit):
1844         (WebKit::WebLayerImpl::WebLayerImpl):
1845         * src/WebLayerImpl.h:
1846         (WebLayerImpl):
1847         * src/WebScrollbarLayerImpl.cpp:
1848         (WebKit::WebScrollbarLayer::create):
1849         (WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):
1850         * src/WebScrollbarLayerImpl.h:
1851         (WebScrollbarLayerImpl):
1852         * src/WebSolidColorLayerImpl.cpp:
1853         (WebKit::WebSolidColorLayer::create):
1854         (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
1855         * src/WebSolidColorLayerImpl.h:
1856         (WebSolidColorLayerImpl):
1857         * src/WebTransformAnimationCurveImpl.cpp:
1858         (WebKit::WebTransformAnimationCurve::create):
1859         (WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):
1860         * src/WebTransformAnimationCurveImpl.h:
1861         (WebTransformAnimationCurveImpl):
1862         * src/WebVideoLayerImpl.cpp:
1863         (WebKit::WebVideoLayer::create):
1864         (WebKit::WebVideoLayerImpl::WebVideoLayerImpl):
1865         * src/WebVideoLayerImpl.h:
1866         (WebVideoLayerImpl):
1867
1868 2012-08-31  Tony Chang  <tony@chromium.org>
1869
1870         Remove ENABLE_CSS3_FLEXBOX compile time flag
1871         https://bugs.webkit.org/show_bug.cgi?id=95382
1872
1873         Reviewed by Ojan Vafai.
1874
1875         Everyone is already enabling this by default and the spec has stablized.
1876
1877         * features.gypi:
1878
1879 2012-08-31  Christopher Cameron  <ccameron@chromium.org>
1880
1881         [chromium] Add main versus impl thread asserts
1882         https://bugs.webkit.org/show_bug.cgi?id=95596
1883
1884         Reviewed by James Robinson.
1885
1886         Add asserts to prioritized texture manager that specify that a
1887         function be called on the main or impl thread.
1888
1889         Add debug signs that the main thread is blocked to the threaded
1890         proxy.
1891
1892         Add a mechanism to simultaneously set the thread to the impl thread
1893         and indicate that the main thread is blocked.
1894
1895         Update tests that hit asserts in the prioritized texture manager to
1896         set their impl thread and main thread blocked state correctly.
1897
1898         * tests/CCPrioritizedTextureTest.cpp:
1899         (WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
1900         (WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
1901         (WTF::CCPrioritizedTextureTest::validateTexture):
1902         (WTF::TEST_F):
1903         * tests/TiledLayerChromiumTest.cpp:
1904
1905 2012-08-30  James Robinson  <jamesr@chromium.org>
1906
1907         [chromium] Put compositor client interfaces in separate headers, normalize naming
1908         https://bugs.webkit.org/show_bug.cgi?id=95522
1909
1910         Reviewed by Adam Barth.
1911
1912         * src/WebContentLayerImpl.cpp:
1913         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
1914         * src/WebContentLayerImpl.h:
1915         (WebContentLayerImpl):
1916         * src/WebExternalTextureLayerImpl.h:
1917         * src/WebLayerTreeViewImpl.h:
1918         (WebCore):
1919         * tests/CCLayerTreeHostCommonTest.cpp:
1920         * tests/CCLayerTreeHostTest.cpp:
1921         (WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
1922         (WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
1923         (WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
1924         (WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
1925         (WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
1926         (WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
1927         (CCLayerTreeHostTestLostContextWhileUpdatingResources):
1928         * tests/ContentLayerChromiumTest.cpp:
1929         (WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
1930         (WebKit::TEST):
1931
1932 2012-08-31  Gavin Peters  <gavinp@chromium.org>
1933
1934         [chromium] DEPS roll with a test skip.
1935         https://bugs.webkit.org/show_bug.cgi?id=95601
1936
1937         Unreviewed gardening & DEPS roll.
1938
1939
1940         fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)
1941
1942         * DEPS:
1943
1944 2012-08-31  Gavin Peters  <gavinp@chromium.org>
1945
1946         [chromium] Disable WebViewTest.AutoResizeMinimumSize
1947         https://bugs.webkit.org/show_bug.cgi?id=95571
1948
1949         Unreviewed gardening.
1950
1951         Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this.
1952
1953         * tests/WebViewTest.cpp:
1954
1955 2012-08-30  James Robinson  <jamesr@chromium.org>
1956
1957         [chromium] Revert WebCompositorSupport to raw ptrs, make dtor protected
1958         https://bugs.webkit.org/show_bug.cgi?id=95520
1959
1960         Reviewed by Darin Fisher.
1961
1962         Adopt the return value of WebCompositorSupport explicitly.
1963
1964         * src/LinkHighlight.cpp:
1965         (WebKit::LinkHighlight::LinkHighlight):
1966         (WebKit::LinkHighlight::startHighlightAnimation):
1967         * src/WebMediaPlayerClientImpl.cpp:
1968         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
1969         * src/WebPluginContainerImpl.cpp:
1970         (WebKit::WebPluginContainerImpl::setBackingTextureId):
1971         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
1972
1973 2012-08-30  James Robinson  <jamesr@chromium.org>
1974
1975         [chromium] Make webkit_compositor specific unit test compilation conditional on gyp var
1976         https://bugs.webkit.org/show_bug.cgi?id=95401
1977
1978         Reviewed by Dirk Pranke.
1979
1980         If use_libcc_for_compositor is set, these tests are being compiled and run elsewhere.
1981
1982         * WebKit.gyp:
1983         * WebKit.gypi:
1984         * WebKitUnitTests.gyp:
1985
1986 2012-08-27  James Robinson  <jamesr@chromium.org>
1987
1988         [chromium] Add CompositorSupport interface for constructing compositor classes
1989         https://bugs.webkit.org/show_bug.cgi?id=95040
1990
1991         Reviewed by Darin Fisher.
1992
1993         * src/LinkHighlight.cpp:
1994         (WebKit::LinkHighlight::LinkHighlight):
1995         (WebKit::LinkHighlight::startHighlightAnimation):
1996         * src/WebMediaPlayerClientImpl.cpp:
1997         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
1998         * src/WebMediaPlayerClientImpl.h:
1999         (WebKit):
2000         * src/WebPluginContainerImpl.cpp:
2001         (WebKit::WebPluginContainerImpl::setBackingTextureId):
2002         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
2003         * src/WebPluginContainerImpl.h:
2004         (WebKit):
2005
2006 2012-08-30  Gavin Peters  <gavinp@chromium.org>
2007
2008         [chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
2009         https://bugs.webkit.org/show_bug.cgi?id=95472
2010
2011         Unreviewed gardening.
2012
2013         When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue.
2014
2015         * tests/CCLayerTreeHostTest.cpp:
2016         (WebKitTests::TEST_F):
2017
2018 2012-08-30  James Robinson  <jamesr@chromium.org>
2019
2020         [chromium] Clean up some webkit compositor unit tests
2021         https://bugs.webkit.org/show_bug.cgi?id=95410
2022
2023         Reviewed by Adrienne Walker.
2024
2025         This adds includes that were implicitly being picked up, removes ones that weren't being used, removes
2026         dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style
2027         plugin is unhappy about.
2028
2029         * tests/CCAnimationTestCommon.cpp:
2030         (WebKitTests::FakeFloatAnimationCurve::duration):
2031         (WebKitTests):
2032         (WebKitTests::FakeFloatAnimationCurve::getValue):
2033         (WebKitTests::FakeTransformTransition::duration):
2034         (WebKitTests::FakeFloatTransition::duration):
2035         (WebKitTests::FakeLayerAnimationControllerClient::id):
2036         (WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
2037         (WebKitTests::FakeLayerAnimationControllerClient::opacity):
2038         (WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):
2039         (WebKitTests::FakeLayerAnimationControllerClient::transform):
2040         * tests/CCAnimationTestCommon.h:
2041         (FakeFloatAnimationCurve):
2042         (FakeTransformTransition):
2043         (FakeFloatTransition):
2044         (FakeLayerAnimationControllerClient):
2045         * tests/CCTiledLayerTestCommon.cpp:
2046         (WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
2047         (WebKitTests):
2048         (WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
2049         (WebKitTests::FakeTiledLayerChromium::textureManager):
2050         (WebKitTests::FakeTiledLayerChromium::textureUpdater):
2051         (WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
2052         (WebKitTests::FakeTextureUploader::isBusy):
2053         (WebKitTests::FakeTextureUploader::uploadTexture):
2054         * tests/CCTiledLayerTestCommon.h:
2055         (FakeLayerTextureUpdater):
2056         (FakeTiledLayerChromium):
2057         (FakeTiledLayerWithScaledBounds):
2058         (FakeTextureUploader):
2059         * tests/FakeWebCompositorOutputSurface.h:
2060         * tests/TextureCopierTest.cpp:
2061         (MockContext):
2062         (TEST):
2063         * tests/ThrottledTextureUploaderTest.cpp:
2064         (WebKit::TEST):
2065         * tests/WebLayerTreeViewTest.cpp:
2066
2067 2012-08-29  Hironori Bono  <hbono@chromium.org>
2068
2069         Fix Chromium builds (Win and Mac)
2070         https://bugs.webkit.org/show_bug.cgi?id=95421
2071
2072         Reviewed by James Robinson.
2073
2074         This change replaces 'class WebRect' with 'struct WebRect' to fix build breaks
2075         on the "Chromium Mac Release" and the "Chromium Win Release" bot caused by
2076         r127095.
2077
2078         * public/WebViewClient.h:
2079         (WebKit):
2080
2081 2012-08-29  Nat Duca  <nduca@chromium.org>
2082
2083         [chromium] setNeedsAnimate should not cause commitRequested to become true
2084         https://bugs.webkit.org/show_bug.cgi?id=95393
2085
2086         Reviewed by James Robinson.
2087
2088         * tests/CCLayerTreeHostTest.cpp:
2089         (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
2090         (CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested::CCLayerTreeHostTestSetNeedsAnimateShouldNotSetCommitRequested):
2091
2092 2012-08-29  Tien-Ren Chen  <trchen@chromium.org>
2093
2094         [chromium] Implement disambiguation popup (a.k.a. Link Preview)
2095         https://bugs.webkit.org/show_bug.cgi?id=94182
2096
2097         Reviewed by Adam Barth.
2098
2099         In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate.
2100         The disambiguation sequence will be initiated by the gesture event handler
2101         in WebViewImpl if an ambiguous tap is detected, then
2102         m_client->handleDisambiguationPopup will be called, so the embedder can
2103         decide whether to swallow the touch event and show a popup.
2104
2105         New test: WebFrameTest.DisambiguationPopupTest
2106
2107         * WebKit.gyp:
2108         * features.gypi:
2109         * public/WebInputEvent.h:
2110         (WebGestureEvent):
2111         (WebKit::WebGestureEvent::WebGestureEvent):
2112         * public/WebTouchCandidatesInfo.h: Removed.
2113         * public/WebView.h:
2114         (WebKit):
2115         * public/WebViewClient.h:
2116         (WebKit):
2117         (WebViewClient):
2118         (WebKit::WebViewClient::triggersLinkPreview):
2119         * src/WebInputEvent.cpp:
2120         (SameSizeAsWebGestureEvent):
2121         * src/WebViewImpl.cpp:
2122         (WebKit):
2123         (WebKit::WebViewImpl::handleGestureEventWithLinkPreview):
2124         (WebKit::WebViewImpl::handleGestureEvent):
2125         * src/WebViewImpl.h:
2126         (WebViewImpl):
2127
2128 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2129
2130         AX: Canvas should have a distinct role
2131         https://bugs.webkit.org/show_bug.cgi?id=95248
2132
2133         Reviewed by Chris Fleizach.
2134
2135         Add support for canvas accessibility role.
2136
2137         * public/WebAccessibilityRole.h:
2138         * src/AssertMatchingEnums.cpp:
2139
2140 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
2141
2142         [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order
2143         https://bugs.webkit.org/show_bug.cgi?id=94828
2144
2145         Reviewed by Adrienne Walker.
2146
2147         Testing that setDeviceScaleFactor properly changes maxScrollPosition
2148
2149         * tests/CCLayerTreeHostImplTest.cpp:
2150
2151 2012-08-29  James Robinson  <jamesr@chromium.org>
2152
2153         Unreviewed, rolling out r126956.
2154         http://trac.webkit.org/changeset/126956
2155         https://bugs.webkit.org/show_bug.cgi?id=94721
2156
2157         Breaks several unit tests
2158
2159         * tests/CCSchedulerTest.cpp:
2160         (WebKitTests::FakeCCSchedulerClient::reset):
2161         (WebKitTests::FakeCCSchedulerClient::setHasMoreResourceUpdates):
2162         (WebKitTests::TEST):
2163         * tests/CCTextureUpdateControllerTest.cpp:
2164
2165 2012-08-29  James Robinson  <jamesr@chromium.org>
2166
2167         [chromium] Register/unregister contents layers with GraphicsLayerChromium
2168         https://bugs.webkit.org/show_bug.cgi?id=95379
2169
2170         Reviewed by Adrienne Walker.
2171
2172         * src/WebMediaPlayerClientImpl.cpp:
2173         (WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
2174         (WebKit::WebMediaPlayerClientImpl::readyStateChanged):
2175         * src/WebPluginContainerImpl.cpp:
2176         (WebKit::WebPluginContainerImpl::setBackingTextureId):
2177         (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
2178         (WebKit::WebPluginContainerImpl::~WebPluginContainerImpl):
2179
2180 2012-08-29  W. James MacLean  <wjmaclean@chromium.org>
2181
2182         [chromium] Add WebSettings support for flag to enable/disable gesture tap highlights.
2183         https://bugs.webkit.org/show_bug.cgi?id=95119
2184
2185         Reviewed by Adam Barth.
2186
2187         Add support to WebSettings for flag to enable/disable gesture tap highlights. Relies on existing tests.
2188
2189         * public/WebSettings.h:
2190         * src/WebSettingsImpl.cpp:
2191         (WebKit::WebSettingsImpl::WebSettingsImpl):
2192         (WebKit::WebSettingsImpl::setGestureTapHighlightEnabled):
2193         (WebKit):
2194         * src/WebSettingsImpl.h:
2195         (WebSettingsImpl):
2196         (WebKit::WebSettingsImpl::gestureTapHighlightEnabled):
2197         * src/WebViewImpl.cpp:
2198         (WebKit::WebViewImpl::handleGestureEvent):
2199
2200 2012-08-29  Dana Jansens  <danakj@chromium.org>
2201
2202         [chromium] Remove HUD layer when rootLayer is set to null
2203         https://bugs.webkit.org/show_bug.cgi?id=95257
2204
2205         Reviewed by James Robinson.
2206
2207         * WebKit.gypi:
2208         * tests/CCHeadsUpDisplayTest.cpp: Added.
2209         (CCHeadsUpDisplayTest):
2210         (DrawsContentLayerChromium):
2211         (DrawsContentLayerChromium::create):
2212         (DrawsContentLayerChromium::DrawsContentLayerChromium):
2213         (CCHudWithRootLayerChange):
2214         (CCHudWithRootLayerChange::CCHudWithRootLayerChange):
2215         (TEST_F):
2216         * tests/CCLayerTreeHostTest.cpp:
2217         * tests/CCThreadedTest.cpp:
2218         (WebKitTests::CCThreadedTest::runTest):
2219         * tests/CCThreadedTest.h:
2220         (WebKitTests::CCThreadedTest::initializeSettings):
2221         (CCThreadedTest):
2222
2223 2012-08-29  Shawn Singh  <shawnsingh@chromium.org>
2224
2225         [chromium] Add more unit test coverage for semantics of drawableContentRect and visibleContentRect
2226         https://bugs.webkit.org/show_bug.cgi?id=94542
2227
2228         Reviewed by Adrienne Walker.
2229
2230         To make upcoming refactors safer, it was appropriate to (finally)
2231         add unit tests that check the behavior of drawableContentRect and
2232         visibleContentRect computations in calculateDrawTransforms.
2233
2234         * tests/CCLayerTreeHostCommonTest.cpp:
2235
2236 2012-08-29  W. James MacLean  <wjmaclean@chromium.org>
2237
2238         [chromium] Link highlight should clear on page navigation.
2239         https://bugs.webkit.org/show_bug.cgi?id=95129
2240
2241         Reviewed by James Robinson.
2242
2243         Modified WebViewImpl to clear link highlight when navigating to new url.
2244
2245         * src/WebViewImpl.cpp:
2246         (WebKit::WebViewImpl::didCommitLoad):
2247
2248 2012-08-29  James Robinson  <jamesr@chromium.org>
2249
2250         [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1
2251         https://bugs.webkit.org/show_bug.cgi?id=94995
2252
2253         Reviewed by Adam Barth.
2254
2255         * WebKit.gyp:
2256
2257 2012-08-28  Shawn Singh  <shawnsingh@chromium.org>
2258
2259         [chromium] Do not clip root layer's subtree to viewport
2260         https://bugs.webkit.org/show_bug.cgi?id=95235
2261
2262         Reviewed by Adrienne Walker.
2263
2264         Existing tests updated, and otherwise this change is already
2265         covered by layout and unit tests.
2266
2267         * tests/CCLayerTreeHostCommonTest.cpp:
2268         * tests/CCOcclusionTrackerTest.cpp:
2269         (WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
2270         (WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
2271         (WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
2272         (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
2273         (WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
2274         (WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
2275         (WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
2276         (WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
2277         (WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
2278         (WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
2279
2280 2012-08-29  Julien Chaffraix  <jchaffraix@webkit.org>
2281
2282         [Chromium] CCLayerTreeHostTestScrollChildLayer makes the wrong assumptions
2283         https://bugs.webkit.org/show_bug.cgi?id=95358
2284
2285         Unreviewed gardening.
2286
2287         * tests/CCLayerTreeHostTest.cpp:
2288         Disabled the test until it is fixed.
2289
2290 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2291
2292         Unreviewed, rolling out r126972.
2293         http://trac.webkit.org/changeset/126972
2294         https://bugs.webkit.org/show_bug.cgi?id=95349
2295
2296         accessibility/canvas-description-and-role.html has been
2297         failing consistently on several bots and Dominic needs some
2298         time to investigate why (Requested by jchaffraix on #webkit).
2299
2300         * public/WebAccessibilityRole.h:
2301         * src/AssertMatchingEnums.cpp:
2302
2303 2012-08-29  Peter Beverloo  <peter@chromium.org>
2304
2305         Unreviewed.  Rolled DEPS.
2306
2307         * DEPS:
2308
2309 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
2310
2311         AX: Canvas should have a distinct role
2312         https://bugs.webkit.org/show_bug.cgi?id=95248
2313
2314         Reviewed by Chris Fleizach.
2315
2316         Add support for canvas accessibility role.
2317
2318         * public/WebAccessibilityRole.h:
2319         * src/AssertMatchingEnums.cpp:
2320
2321 2012-08-28  David Reveman  <reveman@chromium.org>
2322
2323         [Chromium] Scheduler will never process a commit until it receives a vsync tick.
2324         https://bugs.webkit.org/show_bug.cgi?id=94721
2325
2326         Reviewed by James Robinson.
2327
2328         * tests/CCSchedulerTest.cpp:
2329         (WebKitTests::FakeCCSchedulerClient::reset):
2330         (WebKitTests::TEST):
2331         * tests/CCTextureUpdateControllerTest.cpp:
2332
2333 2012-08-28  Adam Barth  <abarth@webkit.org>
2334
2335         Fix ASSERT in fast/events/touch/gesture/context-menu-on-two-finger-tap.html
2336
2337         * src/WebViewImpl.cpp:
2338         (WebKit::WebViewImpl::detectContentOnTouch):
2339
2340 2012-08-28  Leandro Gracia Gil  <leandrogracia@chromium.org>
2341
2342         Content detection should not disrupt the page behaviour
2343         https://bugs.webkit.org/show_bug.cgi?id=94727
2344
2345         Reviewed by Adam Barth.
2346
2347         Triggers content detection in the embedder on tap gestures and
2348         add checks for the appropriate event listeners in order to prevent
2349         triggering content detection when it would disrupt the page's behaviour.
2350
2351         * src/WebViewImpl.cpp:
2352         (WebKit::WebViewImpl::handleGestureEvent):
2353         (WebKit::WebViewImpl::detectContentOnTouch):
2354         * tests/WebViewTest.cpp:
2355         * tests/data/content_listeners.html: Added.
2356
2357 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2358
2359         Unreviewed, rolling out r126933.
2360         http://trac.webkit.org/changeset/126933
2361         https://bugs.webkit.org/show_bug.cgi?id=95261
2362
2363         Turns out we do need this! (Requested by abarth on #webkit).
2364
2365         * public/WebWidget.h:
2366         (WebKit::WebWidget::paint):
2367         * src/WebPagePopupImpl.cpp:
2368         (WebKit::WebPagePopupImpl::paint):
2369         * src/WebPagePopupImpl.h:
2370         (WebPagePopupImpl):
2371         * src/WebPopupMenuImpl.cpp:
2372         (WebKit::WebPopupMenuImpl::paint):
2373         * src/WebPopupMenuImpl.h:
2374         * src/WebViewImpl.cpp:
2375         (WebKit::WebViewImpl::paint):
2376         * src/WebViewImpl.h:
2377         (WebViewImpl):
2378
2379 2012-08-28  Mark Pilgrim  <pilgrim@chromium.org>
2380
2381         [Chromium] Remove decodeAudioFileData from PlatformSupport
2382         https://bugs.webkit.org/show_bug.cgi?id=95250
2383
2384         Reviewed by Adam Barth.
2385
2386         Part of a refactoring series. See tracking bug 82948.
2387
2388         * src/PlatformSupport.cpp:
2389         (WebCore):
2390
2391 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2392
2393         Unreviewed, rolling out r126344.
2394         http://trac.webkit.org/changeset/126344
2395         https://bugs.webkit.org/show_bug.cgi?id=95253
2396
2397         This change is no longer needed (Requested by abarth on
2398         #webkit).
2399
2400         * public/WebWidget.h:
2401         (WebKit::WebWidget::paint):
2402         * src/WebPagePopupImpl.cpp:
2403         (WebKit::WebPagePopupImpl::paint):
2404         * src/WebPagePopupImpl.h:
2405         (WebPagePopupImpl):
2406         * src/WebPopupMenuImpl.cpp:
2407         (WebKit::WebPopupMenuImpl::paint):
2408         * src/WebPopupMenuImpl.h:
2409         * src/WebViewImpl.cpp:
2410         (WebKit::WebViewImpl::paint):
2411         * src/WebViewImpl.h:
2412         (WebViewImpl):
2413
2414 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
2415
2416         AX: Crash due to object getting deleted inside updateBackingStore
2417         https://bugs.webkit.org/show_bug.cgi?id=94619
2418
2419         Reviewed by Chris Fleizach.
2420
2421         Chromium now calls updateBackingStoreAndCheckValidity explicitly,
2422         so we can now get rid of calls to updateBackingStore in the
2423         method implementations, and just make sure we're checking isDetached.
2424
2425         * public/WebAccessibilityObject.h:
2426         (WebAccessibilityObject):
2427         * src/WebAccessibilityObject.cpp:
2428         (WebKit::WebAccessibilityObject::axID):
2429         (WebKit::WebAccessibilityObject::accessibilityDescription):
2430         (WebKit::WebAccessibilityObject::actionVerb):
2431         (WebKit::WebAccessibilityObject::canSetFocusAttribute):
2432         (WebKit::WebAccessibilityObject::canSetValueAttribute):
2433         (WebKit::WebAccessibilityObject::childCount):
2434         (WebKit::WebAccessibilityObject::childAt):
2435         (WebKit::WebAccessibilityObject::firstChild):
2436         (WebKit::WebAccessibilityObject::focusedChild):
2437         (WebKit::WebAccessibilityObject::lastChild):
2438         (WebKit::WebAccessibilityObject::nextSibling):
2439         (WebKit::WebAccessibilityObject::parentObject):
2440         (WebKit::WebAccessibilityObject::previousSibling):
2441         (WebKit::WebAccessibilityObject::canSetSelectedAttribute):
2442         (WebKit::WebAccessibilityObject::isAnchor):
2443         (WebKit::WebAccessibilityObject::isAriaReadOnly):
2444         (WebKit::WebAccessibilityObject::isButtonStateMixed):
2445         (WebKit::WebAccessibilityObject::isChecked):
2446         (WebKit::WebAccessibilityObject::isCollapsed):
2447         (WebKit::WebAccessibilityObject::isControl):
2448         (WebKit::WebAccessibilityObject::isEnabled):
2449         (WebKit::WebAccessibilityObject::isFocused):
2450         (WebKit::WebAccessibilityObject::isHovered):
2451         (WebKit::WebAccessibilityObject::isIndeterminate):
2452         (WebKit::WebAccessibilityObject::isLinked):
2453         (WebKit::WebAccessibilityObject::isLoaded):
2454         (WebKit::WebAccessibilityObject::isMultiSelectable):
2455         (WebKit::WebAccessibilityObject::isOffScreen):
2456         (WebKit::WebAccessibilityObject::isPasswordField):
2457         (WebKit::WebAccessibilityObject::isPressed):
2458         (WebKit::WebAccessibilityObject::isReadOnly):
2459         (WebKit::WebAccessibilityObject::isRequired):
2460         (WebKit::WebAccessibilityObject::isSelected):
2461         (WebKit::WebAccessibilityObject::isSelectedOptionActive):
2462         (WebKit::WebAccessibilityObject::isVertical):
2463         (WebKit::WebAccessibilityObject::isVisible):
2464         (WebKit::WebAccessibilityObject::isVisited):
2465         (WebKit::WebAccessibilityObject::accessKey):
2466         (WebKit::WebAccessibilityObject::ariaHasPopup):
2467         (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
2468         (WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
2469         (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
2470         (WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
2471         (WebKit::WebAccessibilityObject::boundingBoxRect):
2472         (WebKit::WebAccessibilityObject::estimatedLoadingProgress):
2473         (WebKit::WebAccessibilityObject::helpText):
2474         (WebKit::WebAccessibilityObject::headingLevel):
2475         (WebKit::WebAccessibilityObject::hierarchicalLevel):
2476         (WebKit::WebAccessibilityObject::hitTest):
2477         (WebKit::WebAccessibilityObject::keyboardShortcut):
2478         (WebKit::WebAccessibilityObject::performDefaultAction):
2479         (WebKit::WebAccessibilityObject::roleValue):
2480         (WebKit::WebAccessibilityObject::selectionEnd):
2481         (WebKit::WebAccessibilityObject::selectionStart):
2482         (WebKit::WebAccessibilityObject::stringValue):
2483         (WebKit::WebAccessibilityObject::title):
2484         (WebKit::WebAccessibilityObject::titleUIElement):
2485         (WebKit::WebAccessibilityObject::url):
2486         (WebKit::WebAccessibilityObject::valueDescription):
2487         (WebKit::WebAccessibilityObject::valueForRange):
2488         (WebKit::WebAccessibilityObject::maxValueForRange):
2489         (WebKit::WebAccessibilityObject::minValueForRange):
2490         (WebKit::WebAccessibilityObject::node):
2491         (WebKit::WebAccessibilityObject::document):
2492         (WebKit::WebAccessibilityObject::accessibilityIsIgnored):
2493         (WebKit::WebAccessibilityObject::lineBreaks):
2494         (WebKit::WebAccessibilityObject::columnCount):
2495         (WebKit::WebAccessibilityObject::rowCount):
2496         (WebKit::WebAccessibilityObject::cellForColumnAndRow):
2497         (WebKit::WebAccessibilityObject::cellColumnIndex):
2498         (WebKit::WebAccessibilityObject::cellColumnSpan):
2499         (WebKit::WebAccessibilityObject::cellRowIndex):
2500         (WebKit::WebAccessibilityObject::cellRowSpan):
2501         (WebKit::WebAccessibilityObject::scrollToMakeVisible):
2502         (WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
2503         (WebKit::WebAccessibilityObject::scrollToGlobalPoint):
2504
2505 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2506
2507         Unreviewed, rolling out r126914.
2508         http://trac.webkit.org/changeset/126914
2509         https://bugs.webkit.org/show_bug.cgi?id=95239
2510
2511         it breaks everything and fixes nothing (Requested by pizlo on
2512         #webkit).
2513
2514         * src/WebGeolocationPermissionRequestManager.cpp:
2515         (WebGeolocationPermissionRequestManager::remove):
2516         * src/WebIDBMetadata.cpp:
2517         (WebKit::WebIDBMetadata::WebIDBMetadata):
2518         * src/WebIntent.cpp:
2519         (WebKit::WebIntent::extrasValue):
2520         * tests/WebSocketExtensionDispatcherTest.cpp:
2521         (WebCore::TEST_F):
2522
2523 2012-08-28  W. James MacLean  <wjmaclean@chromium.org>
2524
2525         [unreviewed] Compile fix: windows compiler expects float but find double.
2526  
2527         Need to specify a float literal when initialising the highlight animation duration.
2528  
2529         * src/LinkHighlight.cpp:
2530         (WebKit::LinkHighlight::startHighlightAnimation):
2531
2532 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2533
2534         Rename first/second to key/value in HashMap iterators
2535         https://bugs.webkit.org/show_bug.cgi?id=82784
2536
2537         Reviewed by Eric Seidel.
2538
2539         * src/WebGeolocationPermissionRequestManager.cpp:
2540         (WebGeolocationPermissionRequestManager::remove):
2541         * src/WebIDBMetadata.cpp:
2542         (WebKit::WebIDBMetadata::WebIDBMetadata):
2543         * src/WebIntent.cpp:
2544         (WebKit::WebIntent::extrasValue):
2545         * tests/WebSocketExtensionDispatcherTest.cpp:
2546         (WebCore::TEST_F):
2547
2548 2012-08-28  W. James MacLean  <wjmaclean@chromium.org>
2549
2550         [chromium] Drastically shorten the link highlight duration.
2551         https://bugs.webkit.org/show_bug.cgi?id=95216
2552
2553         Reviewed by James Robinson.
2554
2555         Parameter change; covered by existing layout tests.
2556
2557         * src/LinkHighlight.cpp:
2558         (WebKit::LinkHighlight::startHighlightAnimation):
2559
2560 2012-08-27  Tien-Ren Chen  <trchen@chromium.org>
2561
2562         [Chromium] Remove stub for WebView::getTouchHighlightQuads()
2563         https://bugs.webkit.org/show_bug.cgi?id=95164
2564
2565         Reviewed by Adam Barth.
2566
2567         Reverts https://bugs.webkit.org/show_bug.cgi?id=92997
2568         We're uploading a new implementation that no longer uses this API.
2569         See https://bugs.webkit.org/show_bug.cgi?id=94182
2570
2571         * WebKit.gyp:
2572         * public/WebTouchCandidatesInfo.h: Removed.
2573         * public/WebView.h:
2574         (WebKit):
2575         * src/WebViewImpl.cpp:
2576         * src/WebViewImpl.h:
2577         (WebViewImpl):
2578
2579 2012-08-27  Ian Vollick  <vollick@chromium.org>
2580
2581         [chromium] Should accelerate rotations of >= 180 degrees
2582         https://bugs.webkit.org/show_bug.cgi?id=94860
2583
2584         Reviewed by James Robinson.
2585
2586         Added new unit tests:
2587           WebTransformOperationTest.transformTypesAreUnique
2588           WebTransformOperationTest.matchTypesSameLength
2589           WebTransformOperationTest.identityAlwaysMatches
2590           WebTransformOperationTest.largeRotationsWithSameAxis
2591           WebTransformOperationTest.largeRotationsWithSameAxisInDifferentDirection
2592           WebTransformOperationTest.largeRotationsWithDifferentAxes
2593           WebTransformOperationTest.blendRotationFromIdentity
2594           WebTransformOperationTest.blendTranslationFromIdentity
2595           WebTransformOperationTest.blendScaleFromIdentity
2596           WebTransformOperationTest.blendSkewFromIdentity
2597           WebTransformOperationTest.blendPerspectiveFromIdentity
2598           WebTransformOperationTest.blendRotationToIdentity
2599           WebTransformOperationTest.blendTranslationToIdentity
2600           WebTransformOperationTest.blendScaleToIdentity
2601           WebTransformOperationTest.blendSkewToIdentity
2602           WebTransformOperationTest.blendPerspectiveToIdentity
2603           AnimationTranslationUtilTest.createTransformAnimationWithBigRotation
2604           AnimationTranslationUtilTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList
2605
2606         * tests/AnimationTranslationUtilTest.cpp:
2607         (WebKit::TEST):
2608         * tests/WebTransformOperationsTest.cpp:
2609         (TEST):
2610         (getIdentityOperations):
2611
2612 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2613
2614         Unreviewed, rolling out r126836.
2615         http://trac.webkit.org/changeset/126836
2616         https://bugs.webkit.org/show_bug.cgi?id=95163
2617
2618         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
2619         #webkit).
2620
2621         * src/WebGeolocationPermissionRequestManager.cpp:
2622         (WebGeolocationPermissionRequestManager::remove):
2623         * src/WebIDBMetadata.cpp:
2624         (WebKit::WebIDBMetadata::WebIDBMetadata):
2625         * src/WebIntent.cpp:
2626         (WebKit::WebIntent::extrasValue):
2627         * tests/WebSocketExtensionDispatcherTest.cpp:
2628         (WebCore::TEST_F):
2629
2630 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2631
2632         Rename first/second to key/value in HashMap iterators
2633         https://bugs.webkit.org/show_bug.cgi?id=82784
2634
2635         Reviewed by Eric Seidel.
2636
2637         * src/WebGeolocationPermissionRequestManager.cpp:
2638         (WebGeolocationPermissionRequestManager::remove):
2639         * src/WebIDBMetadata.cpp:
2640         (WebKit::WebIDBMetadata::WebIDBMetadata):
2641         * src/WebIntent.cpp:
2642         (WebKit::WebIntent::extrasValue):
2643         * tests/WebSocketExtensionDispatcherTest.cpp:
2644         (WebCore::TEST_F):
2645
2646 2012-08-27  David Reveman  <reveman@chromium.org>
2647
2648         [Chromium] Stop texture updates when context is lost.
2649         https://bugs.webkit.org/show_bug.cgi?id=94983
2650
2651         Reviewed by James Robinson.
2652
2653         * tests/CCLayerTreeHostTest.cpp:
2654         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
2655         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::create):
2656         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::setContextLostCallback):
2657         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::isContextLost):
2658         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::beginQueryEXT):
2659         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::endQueryEXT):
2660         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::getQueryObjectuivEXT):
2661         (CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext::CompositorFakeWebGraphicsContext3DWithEndQueryCausingLostContext):
2662         (CCLayerTreeHostTestLostContextWhileUpdatingResources):
2663         (CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
2664         (CCLayerTreeHostTestLostContextWhileUpdatingResources::createOutputSurface):
2665         (CCLayerTreeHostTestLostContextWhileUpdatingResources::beginTest):
2666         (CCLayerTreeHostTestLostContextWhileUpdatingResources::commitCompleteOnCCThread):
2667         (CCLayerTreeHostTestLostContextWhileUpdatingResources::layout):
2668         (CCLayerTreeHostTestLostContextWhileUpdatingResources::afterTest):
2669         (TEST_F):
2670
2671 2012-08-27  Dana Jansens  <danakj@chromium.org>
2672
2673         [chromium] A general mechanism for passing data into and out of appendQuads and quadCuller via CCAppendQuadsData
2674         https://bugs.webkit.org/show_bug.cgi?id=95109
2675
2676         Reviewed by Adrienne Walker.
2677
2678         Update tests to use the new data structure.
2679
2680         * tests/CCLayerTreeHostImplTest.cpp:
2681         * tests/CCLayerTreeHostTest.cpp:
2682         * tests/CCQuadCullerTest.cpp:
2683         * tests/CCRenderSurfaceTest.cpp:
2684         * tests/CCSolidColorLayerImplTest.cpp:
2685         (CCLayerTestCommon::TEST):
2686         * tests/CCTiledLayerImplTest.cpp:
2687         (CCLayerTestCommon::TEST):
2688         (CCLayerTestCommon::getQuads):
2689         * tests/MockCCQuadCuller.h:
2690
2691 2012-08-24  James Robinson  <jamesr@chromium.org>
2692
2693         [chromium] Clean up dependencies of WebScrollbar and WebScrollbarLayer
2694         https://bugs.webkit.org/show_bug.cgi?id=94996
2695
2696         Reviewed by Adrienne Walker.
2697
2698         Fix up tests for API changes.
2699
2700         * WebKit.gyp:
2701         * src/WebScrollbarLayerImpl.cpp:
2702         (WebKit::WebScrollbarLayer::create):
2703         * tests/ScrollbarLayerChromiumTest.cpp:
2704         (WebCore::TEST):
2705
2706 2012-08-27  Adrienne Walker  <enne@google.com>
2707
2708         [chromium] Prevent scrollbar thumb size from changing during compositor zoom
2709         https://bugs.webkit.org/show_bug.cgi?id=94859
2710
2711         Reviewed by James Robinson.
2712
2713         Update test.
2714
2715         * tests/CCLayerTreeHostImplTest.cpp:
2716
2717 2012-08-27  Dana Jansens  <danakj@chromium.org>
2718
2719         [chromium] Have RenderSurface create and add its own generated RenderPass
2720         https://bugs.webkit.org/show_bug.cgi?id=94957
2721
2722         Reviewed by Adrienne Walker.
2723
2724         Test that a RenderSurface generates the RenderPass that we expect.
2725
2726         * tests/CCRenderSurfaceTest.cpp:
2727
2728 2012-08-27  Justin Novosad  <junov@chromium.org>
2729
2730         [Chromium] Fixing infinite recursion in Canvas2DLayerManager
2731         https://bugs.webkit.org/show_bug.cgi?id=95110
2732
2733         Reviewed by Stephen White.
2734
2735         Breaking recursion cycle by not reporting a change in memory allocation
2736         when no memory is freed in FakeCanvas2DLayer::freeMemoryIfPossible.
2737
2738         * tests/Canvas2DLayerManagerTest.cpp:
2739
2740 2012-08-27  Justin Novosad  <junov@chromium.org>
2741
2742         [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
2743         https://bugs.webkit.org/show_bug.cgi?id=94386
2744
2745         Reviewed by Stephen White.
2746
2747         Adding unit tests for WebCore::Canvas2DLayerManager
2748
2749         * WebKit.gypi:
2750
2751 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2752
2753         Unreviewed.  Rolled DEPS.
2754
2755         * DEPS:
2756
2757 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2758
2759         Rename RegisterProtocolHandler API to NavigatorContentUtils
2760         https://bugs.webkit.org/show_bug.cgi?id=94920
2761
2762         Reviewed by Adam Barth.
2763
2764         Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed.
2765         RegisterProtocolHandlerClientImpl is renamed to NavigatorContentUtilsClientImpl.
2766
2767         * features.gypi:
2768         * src/ChromeClientImpl.cpp:
2769         (WebKit):
2770         (WebKit::NavigatorContentUtilsClientImpl::create):
2771         (WebKit::NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl):
2772         (WebKit::NavigatorContentUtilsClientImpl::registerProtocolHandler):
2773         * src/ChromeClientImpl.h:
2774         (NavigatorContentUtilsClientImpl):
2775         (WebKit::NavigatorContentUtilsClientImpl::~NavigatorContentUtilsClientImpl):
2776         * src/WebViewImpl.cpp:
2777         (WebKit::WebViewImpl::WebViewImpl):
2778         * src/WebViewImpl.h:
2779
2780 2012-08-27  Johnny Ding  <jnd@chromium.org>
2781
2782         [Chromium-Android]Move webkit_unit_tests_apk and TestWebKitAPI_apk into a
2783         condition block:['OS=="android" and gtest_target_type == "shared_library"'].
2784         https://bugs.webkit.org/show_bug.cgi?id=95049
2785
2786         Reviewed by Adam Barth.
2787
2788         Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library"
2789
2790         * All.gyp:
2791
2792 2012-08-24  Dominic Mazzoni  <dmazzoni@google.com>
2793
2794         Chromium: WebAccessibilityObject should expose updateBackingStore
2795         https://bugs.webkit.org/show_bug.cgi?id=94611
2796
2797         Reviewed by Chris Fleizach.
2798
2799         This change just exposes a method, with no new tests. Next, Chromium
2800         will be modified to call this new method, and this will be followed
2801         by a change that gets rid of calls to updateBackingStore under the
2802         hood. That last change may add a test or update an existing test.
2803
2804         * public/WebAccessibilityObject.h:
2805         (WebAccessibilityObject):
2806         * src/WebAccessibilityObject.cpp:
2807         (WebKit::WebAccessibilityObject::updateBackingStoreAndCheckValidity):
2808         (WebKit):
2809
2810 2012-08-24  W. James MacLean  <wjmaclean@chromium.org>
2811
2812         [chromium] WebViewImpl::enableTouchHighlight() should always clear any existing highlight when invoked.
2813         https://bugs.webkit.org/show_bug.cgi?id=94978
2814
2815         Reviewed by James Robinson.
2816
2817         Modified WebViewImpl::enableTouchHighlight() so it always clears any existing highlight, even if no new
2818         highlight target is found.
2819
2820         * src/WebViewImpl.cpp:
2821         (WebKit::WebViewImpl::enableTouchHighlight):
2822
2823 2012-08-23  James Robinson  <jamesr@chromium.org>
2824
2825         [chromium] Convert WebLayerTreeView interface into pure virtual
2826         https://bugs.webkit.org/show_bug.cgi?id=94866
2827
2828         Reviewed by Adrienne Walker.
2829
2830         Updates WebLayerTreeView implementation and callers to new interface. The createGraphicsContext3D() wrapper
2831         stuff can just go away now since downstream has updated to createOutputSurface().
2832
2833         * WebKit.gypi:
2834         * src/WebLayerTreeView.cpp: Removed.
2835         * src/WebLayerTreeViewImpl.cpp:
2836         (WebKit::WebLayerTreeView::create):
2837         (WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
2838         (WebKit::WebLayerTreeViewImpl::initialize):
2839         (WebKit):
2840         (WebKit::WebLayerTreeViewImpl::setSurfaceReady):
2841         (WebKit::WebLayerTreeViewImpl::setRootLayer):
2842         (WebKit::WebLayerTreeViewImpl::clearRootLayer):
2843         (WebKit::WebLayerTreeViewImpl::compositorIdentifier):
2844         (WebKit::WebLayerTreeViewImpl::setViewportSize):
2845         (WebKit::WebLayerTreeViewImpl::layoutViewportSize):
2846         (WebKit::WebLayerTreeViewImpl::deviceViewportSize):
2847         (WebKit::WebLayerTreeViewImpl::setDeviceScaleFactor):
2848         (WebKit::WebLayerTreeViewImpl::deviceScaleFactor):
2849         (WebKit::WebLayerTreeViewImpl::setBackgroundColor):
2850         (WebKit::WebLayerTreeViewImpl::setHasTransparentBackground):
2851         (WebKit::WebLayerTreeViewImpl::setVisible):
2852         (WebKit::WebLayerTreeViewImpl::setPageScaleFactorAndLimits):
2853         (WebKit::WebLayerTreeViewImpl::startPageScaleAnimation):
2854         (WebKit::WebLayerTreeViewImpl::setNeedsAnimate):
2855         (WebKit::WebLayerTreeViewImpl::setNeedsRedraw):
2856         (WebKit::WebLayerTreeViewImpl::commitRequested):
2857         (WebKit::WebLayerTreeViewImpl::composite):
2858         (WebKit::WebLayerTreeViewImpl::updateAnimations):
2859         (WebKit::WebLayerTreeViewImpl::compositeAndReadback):
2860         (WebKit::WebLayerTreeViewImpl::finishAllRendering):
2861         (WebKit::WebLayerTreeViewImpl::renderingStats):
2862         (WebKit::WebLayerTreeViewImpl::setFontAtlas):
2863         (WebKit::WebLayerTreeViewImpl::loseCompositorContext):
2864         (WebKit::WebLayerTreeViewImpl::willBeginFrame):
2865         (WebKit::WebLayerTreeViewImpl::didBeginFrame):
2866         (WebKit::WebLayerTreeViewImpl::animate):
2867         (WebKit::WebLayerTreeViewImpl::layout):
2868         (WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
2869         (WebKit::WebLayerTreeViewImpl::createOutputSurface):
2870         (WebKit::WebLayerTreeViewImpl::didRecreateOutputSurface):
2871         (WebKit::WebLayerTreeViewImpl::willCommit):
2872         (WebKit::WebLayerTreeViewImpl::didCommit):
2873         (WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
2874         (WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
2875         (WebKit::WebLayerTreeViewImpl::scheduleComposite):
2876         * src/WebLayerTreeViewImpl.h:
2877         (WebLayerTreeViewImpl):
2878         * src/WebViewImpl.cpp:
2879         (WebKit::WebViewImpl::renderingStats):
2880         (WebKit::WebViewImpl::startPageScaleAnimation):
2881         (WebKit::WebViewImpl::setCompositorSurfaceReady):
2882         (WebKit::WebViewImpl::animate):
2883         (WebKit::WebViewImpl::doPixelReadbackToCanvas):
2884         (WebKit::WebViewImpl::paint):
2885         (WebKit::WebViewImpl::composite):
2886         (WebKit::WebViewImpl::setNeedsRedraw):
2887         (WebKit::WebViewImpl::isInputThrottled):
2888         (WebKit::WebViewImpl::loseCompositorContext):
2889         (WebKit::WebViewImpl::setDeviceScaleFactor):
2890         (WebKit::WebViewImpl::computePageScaleFactorLimits):
2891         (WebKit::WebViewImpl::setIsTransparent):
2892         (WebKit::WebViewImpl::setRootGraphicsLayer):
2893         (WebKit::WebViewImpl::scheduleCompositingLayerSync):
2894         (WebKit::WebViewImpl::invalidateRootLayerRect):
2895         (WebKit::WebViewImpl::setBackgroundColor):
2896         (WebKit::WebViewImpl::scheduleAnimation):
2897         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2898         (WebKit):
2899         (WebKit::WebViewImpl::updateLayerTreeViewport):
2900         (WebKit::WebViewImpl::setVisibilityState):
2901         * src/WebViewImpl.h:
2902         (WebKit):
2903         * tests/CCLayerTreeHostTest.cpp:
2904         * tests/CCThreadedTest.cpp:
2905         * tests/CCThreadedTest.h:
2906         (WebKitTests::TestHooks::animate):
2907         * tests/FakeCCLayerTreeHostClient.h:
2908         * tests/GraphicsLayerChromiumTest.cpp:
2909         (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
2910         (WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
2911         (GraphicsLayerChromiumTest):
2912         * tests/WebLayerTest.cpp:
2913         * tests/WebLayerTreeViewTest.cpp:
2914         * tests/WebLayerTreeViewTestCommon.h:
2915         (MockWebLayerTreeViewClient):
2916
2917 2012-08-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2918
2919         Unreviewed.  Rolled DEPS.
2920
2921         * DEPS:
2922
2923 2012-08-24  James Robinson  <jamesr@chromium.org>
2924
2925         [chromium] Clean up WebAnimation animationId/groupId generation
2926         https://bugs.webkit.org/show_bug.cgi?id=94973
2927
2928         Reviewed by Adrienne Walker.
2929
2930         * src/WebAnimationImpl.cpp:
2931         (WebKit::WebAnimation::create):
2932         (WebKit::WebAnimationImpl::WebAnimationImpl):
2933         (WebKit::WebAnimationImpl::id):
2934         (WebKit):
2935         * src/WebAnimationImpl.h:
2936         (WebAnimationImpl):
2937         * tests/AnimationTranslationUtilTest.cpp:
2938         (WebKit::animationCanBeTranslated):
2939         * tests/GraphicsLayerChromiumTest.cpp:
2940         (WebKit::TEST_F):
2941
2942 2012-08-24  Mark Pilgrim  <pilgrim@chromium.org>
2943
2944         [Chromium] Remove visitedLinkHash from PlatformSupport
2945         https://bugs.webkit.org/show_bug.cgi?id=94965
2946
2947         Reviewed by Adam Barth.
2948
2949         Part of a refactoring series. See tracking bug 82948.
2950
2951         * src/PlatformSupport.cpp:
2952         (WebCore):
2953
2954 2012-08-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2955
2956         Unreviewed, rolling out r126620.
2957         http://trac.webkit.org/changeset/126620
2958         https://bugs.webkit.org/show_bug.cgi?id=94976
2959
2960         ASSERT((intptr_t)m_bytesAllocated + deltaBytes > 0) is
2961         triggering on the bots (Requested by jchaffraix on #webkit).
2962
2963         * WebKit.gypi:
2964         * tests/Canvas2DLayerManagerTest.cpp: Removed.
2965
2966 2012-08-24  Justin Novosad  <junov@chromium.org>
2967
2968         [Chromium] Implementing a global limit on memory consumed by deferred 2D canvases
2969         https://bugs.webkit.org/show_bug.cgi?id=94386
2970
2971         Reviewed by Stephen White.
2972
2973         Adding unit tests for WebCore::Canvas2DLayerManager
2974
2975         * WebKit.gypi:
2976         * tests/Canvas2DLayerManagerTest.cpp: Added.
2977         (FakeCanvas2DLayerBridge):
2978         (FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
2979         (FakeCanvas2DLayerBridge::fakeFreeableBytes):
2980         (Canvas2DLayerManagerTest):
2981         (Canvas2DLayerManagerTest::storageAllocationTrackingTest):
2982         (Canvas2DLayerManagerTest::evictionTest):
2983         (Canvas2DLayerManagerTest::flushEvictionTest):
2984
2985 2012-08-24  Cris Neckar  <cdn@chromium.org>
2986
2987         Plumb consumeUserGesture() to the chromium platform layer.
2988         https://bugs.webkit.org/show_bug.cgi?id=9475294867
2989
2990         Reviewed by Adam Barth.
2991
2992         * public/WebFrame.h:
2993         (WebFrame):
2994         * src/WebFrameImpl.cpp:
2995         (WebKit::WebFrameImpl::consumeUserGesture):
2996         (WebKit):
2997         * src/WebFrameImpl.h:
2998         (WebFrameImpl):
2999
3000 2012-08-24  W. James MacLean  <wjmaclean@chromium.org>
3001
3002         [chromium] gestureTapDown should not select a RenderView node as target.
3003         https://bugs.webkit.org/show_bug.cgi?id=94956
3004
3005         Reviewed by James Robinson.
3006
3007         Add check to prevent selecting a RenderView node as a highlight target.
3008
3009         * src/WebViewImpl.cpp:
3010         (WebKit::WebViewImpl::bestTouchLinkNode):
3011
3012 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
3013
3014         MediaStream API: Add readyState functionality to RTCPeerConnection
3015         https://bugs.webkit.org/show_bug.cgi?id=94813
3016
3017         Reviewed by Adam Barth.
3018
3019         * src/AssertMatchingEnums.cpp:
3020
3021 2012-08-24  Dan Carney  <dcarney@google.com>
3022
3023         [V8] Refactor away IsolatedWorld
3024         https://bugs.webkit.org/show_bug.cgi?id=93971
3025
3026         Reviewed by Kentaro Hara.
3027
3028         Remove IsolatedWorld class as it was 1:1 with DOMWrapperWorld.
3029
3030         * src/WebViewImpl.cpp:
3031         (WebKit::WebView::addUserScript):
3032         (WebKit::WebView::addUserStyleSheet):
3033
3034 2012-08-23  Antoine Labour  <piman@chromium.org>
3035
3036         [chromium] Fix lost context when textures are evicted
3037         https://bugs.webkit.org/show_bug.cgi?id=94892
3038
3039         Reviewed by James Robinson.
3040
3041         After eviction, the CCPrioritizedTextureManager is in a limbo state
3042         where all its resources are invalid. If we try to release them we will
3043         double-destroy them.
3044
3045         New test: CCLayerTreeHostTestLostContextAfterEvictTextures.
3046
3047         * tests/CCLayerTreeHostTest.cpp:
3048         (CCLayerTreeHostTestLostContextAfterEvictTextures):
3049         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::CCLayerTreeHostTestLostContextAfterEvictTextures):
3050         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::beginTest):
3051         (EvictTexturesAndLoseContextTask):
3052         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::EvictTexturesAndLoseContextTask):
3053         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::~EvictTexturesAndLoseContextTask):
3054         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::EvictTexturesAndLoseContextTask::run):
3055         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::postEvictTexturesAndLoseContext):
3056         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didCommitAndDrawFrame):
3057         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::commitCompleteOnCCThread):
3058         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::didRecreateOutputSurface):
3059         (WTF::CCLayerTreeHostTestLostContextAfterEvictTextures::afterTest):
3060         (WTF):
3061         (WTF::TEST_F):
3062
3063 2012-08-23  Antoine Labour  <piman@chromium.org>
3064
3065         [chromium] Add OVERRIDEs in test code
3066         https://bugs.webkit.org/show_bug.cgi?id=94894
3067
3068         Reviewed by James Robinson.
3069
3070         * tests/CCLayerTreeHostTest.cpp:
3071
3072 2012-08-23  Joshua Bell  <jsbell@chromium.org>
3073
3074         IndexedDB: Expose mechanism for database to force a connection to close
3075         https://bugs.webkit.org/show_bug.cgi?id=91010
3076
3077         Reviewed by Tony Chang.
3078
3079         In Chromium, the browsing data deleter has a WebIDBDatabase handle which
3080         it can use to terminate a connection. This handles forcefully closing
3081         the front end connections and the back end, to unblock disk cleanup.
3082
3083         * public/WebIDBDatabase.h:
3084         (WebKit::WebIDBDatabase::forceClose): Entry point.
3085         * public/WebIDBDatabaseCallbacks.h:
3086         (WebKit::WebIDBDatabaseCallbacks::onForcedClose): Plumbing back to front.
3087         * src/IDBDatabaseCallbacksProxy.cpp:
3088         (WebKit::IDBDatabaseCallbacksProxy::onForcedClose): Plumbing back to front.
3089         (WebKit):
3090         * src/IDBDatabaseCallbacksProxy.h:
3091         (IDBDatabaseCallbacksProxy): Plumbing.
3092         * src/WebIDBDatabaseCallbacksImpl.cpp:
3093         (WebKit::WebIDBDatabaseCallbacksImpl::onForcedClose): Plumbing back to front.
3094         (WebKit):
3095         * src/WebIDBDatabaseCallbacksImpl.h:
3096         (WebIDBDatabaseCallbacksImpl): Plumbing back to front.
3097         * src/WebIDBDatabaseImpl.cpp:
3098         (WebKit::WebIDBDatabaseImpl::close): Tidy up dropping the callback reference.
3099         (WebKit):
3100         (WebKit::WebIDBDatabaseImpl::forceClose): Terminate the connection by notifying
3101         the back end and the front end, while avoid re-entrant badness.
3102         * src/WebIDBDatabaseImpl.h: Header tweak for unit test.
3103         (WebIDBDatabaseImpl):
3104         * tests/IDBDatabaseBackendTest.cpp: Added unit test to exercise connections.
3105
3106 2012-08-23  James Robinson  <jamesr@chromium.org>
3107
3108         [chromium] Convert WebAnimationCurve subtypes into pure virtual
3109         https://bugs.webkit.org/show_bug.cgi?id=94068
3110
3111         Reviewed by Adrienne Walker.
3112
3113         Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface.
3114
3115         * WebKit.gyp:
3116         * src/WebAnimation.cpp:
3117         (WebKit::WebAnimation::initialize):
3118         * src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp.
3119         (WebKit):
3120         (WebKit::WebFloatAnimationCurve::create):
3121         (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
3122         (WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl):
3123         (WebKit::WebFloatAnimationCurveImpl::type):
3124         (WebKit::WebFloatAnimationCurveImpl::add):
3125         (WebKit::WebFloatAnimationCurveImpl::getValue):
3126         (WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve):
3127         * src/WebTransformAnimationCurve.cpp: Removed.
3128         * tests/WebAnimationTest.cpp:
3129         (WebKit::TEST):
3130         * tests/WebFloatAnimationCurveTest.cpp:
3131         (WebKit::TEST):
3132         * tests/WebTransformAnimationCurveTest.cpp:
3133         (WebKit::TEST):
3134
3135 2012-08-23  Kentaro Hara  <haraken@chromium.org>
3136
3137         [V8] Remove V8Proxy.{h,cpp}
3138         https://bugs.webkit.org/show_bug.cgi?id=94794
3139
3140         Reviewed by Dimitri Glazkov.
3141
3142         Now V8Proxy is no longer used. We can completely remove V8Proxy from the codebase.
3143
3144         No tests. No change in behavior.
3145
3146         * src/ChromeClientImpl.cpp:
3147         * src/WebBindings.cpp:
3148         * src/WebDOMMessageEvent.cpp:
3149         * src/WebDevToolsAgentImpl.cpp:
3150         * src/WebMediaPlayerClientImpl.cpp:
3151
3152 2012-08-23  Dana Jansens  <danakj@chromium.org>
3153
3154         [chromium] Don't require a RenderSurface* in order to create a RenderPass
3155         https://bugs.webkit.org/show_bug.cgi?id=94862
3156
3157         Reviewed by Adrienne Walker.
3158
3159         * tests/CCLayerTreeHostImplTest.cpp:
3160         * tests/CCRendererGLTest.cpp:
3161         (FakeCCRendererClient::FakeCCRendererClient):
3162
3163 2012-08-22  James Robinson  <jamesr@chromium.org>
3164
3165         [chromium] Remove WebLayer::setChildren API
3166         https://bugs.webkit.org/show_bug.cgi?id=94749
3167
3168         Reviewed by Adrienne Walker.
3169
3170         * src/WebLayer.cpp:
3171
3172 2012-08-23  Dana Jansens  <danakj@chromium.org>
3173
3174         [chromium] Create sharedQuadState at same time as creating quads and give them to the quadSink
3175         https://bugs.webkit.org/show_bug.cgi?id=94752
3176
3177         Reviewed by Adrienne Walker.
3178
3179         * tests/CCLayerTreeHostImplTest.cpp:
3180         * tests/CCLayerTreeHostTest.cpp:
3181         (WTF::EvictionTestLayerImpl::appendQuads):
3182         * tests/CCQuadCullerTest.cpp:
3183         * tests/CCRenderSurfaceTest.cpp:
3184         * tests/CCSolidColorLayerImplTest.cpp:
3185         (CCLayerTestCommon::TEST):
3186         * tests/CCTiledLayerImplTest.cpp:
3187         (CCLayerTestCommon::TEST):
3188         (CCLayerTestCommon::getQuads):
3189         (CCLayerTestCommon::coverageVisibleRectOnTileBoundaries):
3190         (CCLayerTestCommon::coverageVisibleRectIntersectsTiles):
3191         (CCLayerTestCommon::coverageVisibleRectIntersectsBounds):
3192         * tests/MockCCQuadCuller.h:
3193         (WebCore::MockCCQuadCuller::MockCCQuadCuller):
3194         (MockCCQuadCuller):
3195         (WebCore::MockCCQuadCuller::quadList):
3196         (WebCore::MockCCQuadCuller::sharedQuadStateList):
3197
3198 2012-08-23  Pavel Feldman  <pfeldman@chromium.org>
3199
3200         Not reviewed - fixing input list for timeline inspector module.
3201         https://bugs.webkit.org/show_bug.cgi?id=94829
3202
3203         * WebKit.gyp:
3204
3205 2012-08-23  Alexandre Elias  <aelias@chromium.org>
3206
3207         [chromium] Rename LayerRendererChromium to GL-specific name
3208         https://bugs.webkit.org/show_bug.cgi?id=94835
3209
3210         Reviewed by James Robinson.
3211
3212         Over time, LayerRendererChromium has evolved to be a GL-specific
3213         subclass of CCRenderer that has no awareness of layers (as it operates
3214         only with drawQuads).
3215
3216         This patch renames LayerRendererChromium to CCRendererGL, replaces all
3217         instances of "layerRenderer" with just "renderer", and removes a
3218         few unnecessary includes of LayerRendererChromium.h.
3219
3220         * WebKit.gypi:
3221         * tests/CCLayerTreeHostImplTest.cpp:
3222         * tests/CCLayerTreeHostTest.cpp:
3223         (WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
3224         (WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
3225         (WTF::CCLayerTreeHostTestManySurfaces::beginTest):
3226         (WTF::CCLayerTreeHostTestSurfaceNotAllocatedForLayersOutsideMemoryLimit::drawLayersOnCCThread):
3227         * tests/CCRendererGLTest.cpp: Renamed from Source/WebKit/chromium/tests/LayerRendererChromiumTest.cpp.
3228         (FrameCountingMemoryAllocationSettingContext):
3229         (FrameCountingMemoryAllocationSettingContext::FrameCountingMemoryAllocationSettingContext):
3230         (FrameCountingMemoryAllocationSettingContext::prepareTexture):
3231         (FrameCountingMemoryAllocationSettingContext::setMemoryAllocationChangedCallbackCHROMIUM):
3232         (FrameCountingMemoryAllocationSettingContext::getString):
3233         (FrameCountingMemoryAllocationSettingContext::frameCount):
3234         (FrameCountingMemoryAllocationSettingContext::setMemoryAllocation):
3235         (FakeCCRendererClient):
3236         (FakeCCRendererClient::FakeCCRendererClient):
3237         (FakeCCRendererClient::setFullRootLayerDamageCount):
3238         (FakeCCRendererClient::rootRenderPass):
3239         (FakeCCRendererClient::renderPassesInDrawOrder):
3240         (FakeCCRendererClient::renderPasses):
3241         (FakeCCRendererClient::memoryAllocationLimitBytes):
3242         (FakeCCRendererGL):
3243         (FakeCCRendererGL::FakeCCRendererGL):
3244         (CCRendererGLTest):
3245         (CCRendererGLTest::CCRendererGLTest):
3246         (CCRendererGLTest::SetUp):
3247         (CCRendererGLTest::TearDown):
3248         (CCRendererGLTest::swapBuffers):
3249         (CCRendererGLTest::context):
3250         (TEST_F):
3251         (ForbidSynchronousCallContext):
3252         (ForbidSynchronousCallContext::ForbidSynchronousCallContext):
3253         (ForbidSynchronousCallContext::getActiveAttrib):
3254         (ForbidSynchronousCallContext::getActiveUniform):
3255         (ForbidSynchronousCallContext::getAttachedShaders):
3256         (ForbidSynchronousCallContext::getAttribLocation):
3257         (ForbidSynchronousCallContext::getBooleanv):
3258         (ForbidSynchronousCallContext::getBufferParameteriv):
3259         (ForbidSynchronousCallContext::getContextAttributes):
3260         (ForbidSynchronousCallContext::getError):
3261         (ForbidSynchronousCallContext::getFloatv):
3262         (ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
3263         (ForbidSynchronousCallContext::getIntegerv):
3264         (ForbidSynchronousCallContext::getProgramiv):
3265         (ForbidSynchronousCallContext::getShaderiv):
3266         (ForbidSynchronousCallContext::getString):
3267         (ForbidSynchronousCallContext::getProgramInfoLog):
3268         (ForbidSynchronousCallContext::getRenderbufferParameteriv):
3269         (ForbidSynchronousCallContext::getShaderInfoLog):
3270         (ForbidSynchronousCallContext::getShaderPrecisionFormat):
3271         (ForbidSynchronousCallContext::getShaderSource):
3272         (ForbidSynchronousCallContext::getTexParameterfv):
3273         (ForbidSynchronousCallContext::getTexParameteriv):
3274         (ForbidSynchronousCallContext::getUniformfv):
3275         (ForbidSynchronousCallContext::getUniformiv):
3276         (ForbidSynchronousCallContext::getUniformLocation):
3277         (ForbidSynchronousCallContext::getVertexAttribfv):
3278         (ForbidSynchronousCallContext::getVertexAttribiv):
3279         (ForbidSynchronousCallContext::getVertexAttribOffset):
3280         (TEST):
3281         (LoseContextOnFirstGetContext):
3282         (LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
3283         (ContextThatDoesNotSupportMemoryManagmentExtensions):
3284         (ContextThatDoesNotSupportMemoryManagmentExtensions::ContextThatDoesNotSupportMemoryManagmentExtensions):
3285         (ContextThatDoesNotSupportMemoryManagmentExtensions::prepareTexture):
3286         (ContextThatDoesNotSupportMemoryManagmentExtensions::setMemoryAllocationChangedCallbackCHROMIUM):
3287         (ContextThatDoesNotSupportMemoryManagmentExtensions::getString):
3288         (ClearCountingContext):
3289         (ClearCountingContext::ClearCountingContext):
3290         (ClearCountingContext::clear):
3291         (ClearCountingContext::clearCount):
3292         * tests/TiledLayerChromiumTest.cpp:
3293
3294 2012-08-23  Stephen White  <senorblanco@chromium.org>
3295
3296         Unreviewed.  Rolled DEPS.
3297
3298         * DEPS:
3299
3300 2012-08-23  Wei Jia  <wjia@chromium.org>
3301
3302         create different WebKit::WebMediaPlayer based on URL
3303         https://bugs.webkit.org/show_bug.cgi?id=91301
3304
3305         Reviewed by Adam Barth.
3306
3307         Pass URL to WebFrameClient::createMediaPlayer(). This allows creation
3308         of different WebMediaPlayer implementations based on the URL.
3309
3310         * public/WebFrameClient.h:
3311         (WebKit::WebFrameClient::createMediaPlayer): add URL as additional argument.
3312         * src/WebMediaPlayerClientImpl.cpp:
3313         (WebKit::createWebMediaPlayer): add URL as additional argument.
3314         (WebKit::WebMediaPlayerClientImpl::loadInternal):
3315
3316 2012-08-23  Joshua Bell  <jsbell@chromium.org>
3317
3318         IndexedDB: Move onSuccess(IDBDatabaseBackendInterface) to IDBOpenDBRequest
3319         https://bugs.webkit.org/show_bug.cgi?id=94757
3320
3321         Reviewed by Tony Chang.
3322
3323         Drop onSuccess(IDBDatabaseBackendImpl) overload from test, as it is no longer
3324         implemented by IDBRequest.
3325
3326         * tests/IDBRequestTest.cpp:
3327         (WebCore::TEST):
3328
3329 2012-08-23  Kenneth Russell  <kbr@google.com>
3330
3331         Convert ScrollableArea ASSERT_NOT_REACHED virtuals into pure virtuals
3332         https://bugs.webkit.org/show_bug.cgi?id=93306
3333
3334         Unreviewed build fix.
3335
3336         * src/ScrollbarGroup.h:
3337
3338 2012-08-23  Adrienne Walker  <enne@google.com>
3339
3340         Convert ScrollableArea ASSERT_NOT_REACHED virtuals
3341         https://bugs.webkit.org/show_bug.cgi?id=93306
3342
3343         Reviewed by Darin Adler.
3344
3345         Add implementations where necessary to make derived classes concrete.
3346         Add OVERRIDE for ScrollableArea functions.
3347
3348         * src/ScrollbarGroup.h:
3349         (ScrollbarGroup):
3350         (WebKit::ScrollbarGroup::scrollCornerRect):
3351         * tests/ScrollAnimatorNoneTest.cpp:
3352         (MockScrollableArea):
3353
3354 2012-08-23  David Reveman  <reveman@chromium.org>
3355
3356         [Chromium] Unnecessary delay when starting to update resources with an inactive vsync timer.
3357         https://bugs.webkit.org/show_bug.cgi?id=94719
3358
3359         Reviewed by James Robinson.
3360
3361         * tests/CCSchedulerTestCommon.h:
3362
3363 2012-08-23  Peter Beverloo  <peter@chromium.org>
3364
3365         Unreviewed.  Rolled DEPS.
3366
3367         * DEPS:
3368
3369 2012-08-22  Alec Flett  <alecflett@chromium.org>
3370
3371         IndexedDB: tests for injection/extraction of idb keys
3372         https://bugs.webkit.org/show_bug.cgi?id=94653
3373
3374         Reviewed by Tony Chang.
3375
3376         Added unit tests for key injection/extraction using
3377         SerializedScriptValue. These were moved from chromium, now
3378         that all uses of the API are through WebKit.
3379
3380         * tests/IDBKeyPathTest.cpp:
3381         (WebCore):
3382         (WebCore::TEST):
3383
3384 2012-08-22  James Robinson  <jamesr@chromium.org>
3385
3386         [chromium] Change WebLayer from a concrete type to a pure virtual interface
3387         https://bugs.webkit.org/show_bug.cgi?id=94174
3388
3389         Reviewed by Adrienne Walker.
3390
3391         This updates the implementation of the Web*Layer family to the new design and updates callers in WebViewImpl /
3392         NonCompositedContentHost / LinkHighlight.
3393
3394         * WebKit.gypi:
3395         * src/LinkHighlight.cpp:
3396         (WebKit::LinkHighlight::LinkHighlight):
3397         (WebKit::LinkHighlight::contentLayer):
3398         (WebKit::LinkHighlight::clipLayer):
3399         (WebKit::LinkHighlight::releaseResources):
3400         (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition):
3401         (WebKit::LinkHighlight::startHighlightAnimation):
3402         (WebKit::LinkHighlight::updateGeometry):
3403         * src/LinkHighlight.h:
3404         (LinkHighlight):
3405         * src/NonCompositedContentHost.cpp:
3406         (WebKit::NonCompositedContentHost::NonCompositedContentHost):
3407         (WebKit::NonCompositedContentHost::setScrollLayer):
3408         (WebKit::NonCompositedContentHost::setViewport):
3409         (WebKit::NonCompositedContentHost::scrollLayer):
3410         * src/NonCompositedContentHost.h:
3411         * src/WebContentLayer.cpp: Removed.
3412         * src/WebContentLayerImpl.cpp:
3413         (WebKit::WebContentLayer::create):
3414         (WebKit::WebContentLayerImpl::WebContentLayerImpl):
3415         (WebKit::WebContentLayerImpl::~WebContentLayerImpl):
3416         (WebKit::WebContentLayerImpl::layer):
3417         (WebKit):
3418         (WebKit::WebContentLayerImpl::setDoubleSided):
3419         (WebKit::WebContentLayerImpl::setContentsScale):
3420         (WebKit::WebContentLayerImpl::setUseLCDText):
3421         (WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):
3422         (WebKit::WebContentLayerImpl::paintContents):
3423         * src/WebContentLayerImpl.h:
3424         (WebContentLayerImpl):
3425         * src/WebExternalTextureLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.
3426         (WebKit):
3427         (WebKit::WebExternalTextureLayer::create):
3428         (WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
3429         (WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
3430         (WebKit::WebExternalTextureLayerImpl::layer):
3431         (WebKit::WebExternalTextureLayerImpl::setTextureId):
3432         (WebKit::WebExternalTextureLayerImpl::setFlipped):
3433         (WebKit::WebExternalTextureLayerImpl::setUVRect):
3434         (WebKit::WebExternalTextureLayerImpl::setOpaque):
3435         (WebKit::WebExternalTextureLayerImpl::setPremultipliedAlpha):
3436         (WebKit::WebExternalTextureLayerImpl::willModifyTexture):
3437         (WebKit::WebExternalTextureLayerImpl::setRateLimitContext):
3438         (WebTextureUpdaterImpl):
3439         (WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
3440         (WebKit::WebExternalTextureLayerImpl::prepareTexture):
3441         (WebKit::WebExternalTextureLayerImpl::context):
3442         * src/WebExternalTextureLayerImpl.h: Copied from Source/Platform/chromium/public/WebVideoLayer.h.
3443         (WebKit):
3444         (WebExternalTextureLayerImpl):
3445         * src/WebIOSurfaceLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp.
3446         (WebKit):
3447         (WebKit::WebIOSurfaceLayer::create):
3448         (WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):
3449         (WebKit::WebIOSurfaceLayerImpl::~WebIOSurfaceLayerImpl):
3450         (WebKit::WebIOSurfaceLayerImpl::setIOSurfaceProperties):
3451         (WebKit::WebIOSurfaceLayerImpl::layer):
3452         * src/WebIOSurfaceLayerImpl.h: Copied from Source/Platform/chromium/public/WebImageLayer.h.
3453         (WebCore):
3454         (WebKit):
3455         (WebIOSurfaceLayerImpl):
3456         * src/WebImageLayerImpl.cpp: Renamed from Source/WebKit/chromium/src/WebSolidColorLayer.cpp.
3457         (WebKit):
3458         (WebKit::WebImageLayer::create):
3459         (WebKit::WebImageLayerImpl::WebImageLayerImpl):
3460         (WebKit::WebImageLayerImpl::~WebImageLayerImpl):
3461         (WebKit::WebImageLayerImpl::layer):
3462         (WebKit::WebImageLayerImpl::setBitmap):
3463         * src/WebImageLayerImpl.h: Renamed from Source/WebKit/chromium/src/WebImageLayer.cpp.
3464         (WebCore):
3465         (WebKit):
3466         (WebImageLayerImpl):
3467         * src/WebLayer.cpp: Removed.
3468         * src/WebLayerImpl.cpp:
3469         (WebKit::WebLayer::create):
3470         (WebKit::WebLayerImpl::WebLayerImpl):
3471         (WebKit::WebLayerImpl::~WebLayerImpl):
3472         (WebKit):
3473         (WebKit::WebLayerImpl::id):
3474         (WebKit::WebLayerImpl::invalidateRect):
3475         (WebKit::WebLayerImpl::invalidate):
3476         (WebKit::WebLayerImpl::addChild):
3477         (WebKit::WebLayerImpl::insertChild):
3478         (WebKit::WebLayerImpl::replaceChild):
3479         (WebKit::WebLayerImpl::setChildren):
3480         (WebKit::WebLayerImpl::removeFromParent):
3481         (WebKit::WebLayerImpl::removeAllChildren):
3482         (WebKit::WebLayerImpl::setAnchorPoint):
3483         (WebKit::We