[BlackBerry] Use lazily-backed backingstore tiles
[WebKit-https.git] / Source / WebKit / blackberry / ChangeLog
1 2013-05-29  Jakob Petsovits  <jpetsovits@blackberry.com>
2
3         [BlackBerry] Use lazily-backed backingstore tiles
4         https://bugs.webkit.org/show_bug.cgi?id=116879
5         Internal PR 344523
6
7         Reviewed by Carlos Garcia Campos.
8         Informally reviewed by Arvid Nilsson and Mike Lattanzio.
9
10         As a consequence, also don't use fixed-size
11         shared pixmap buffers for these tiles anymore.
12
13         * WebKitSupport/AboutData.cpp:
14         (BlackBerry::WebKit::configPage):
15         * WebKitSupport/BackingStoreTile.cpp:
16         (BlackBerry::WebKit::TileBuffer::nativeBuffer):
17         * WebKitSupport/SurfacePool.cpp:
18         (BlackBerry::WebKit::SurfacePool::initialize):
19         * WebKitSupport/SurfacePool.h:
20         (SurfacePool):
21
22 2013-05-29  Kent Tamura  <tkent@chromium.org>
23
24         Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
25         https://bugs.webkit.org/show_bug.cgi?id=116796
26
27         Reviewed by Ryosuke Niwa.
28
29         * WebCoreSupport/AboutDataEnableFeatures.in:
30
31 2013-05-28  Arvid Nilsson  <anilsson@rim.com>
32
33         [BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
34         https://bugs.webkit.org/show_bug.cgi?id=116604
35
36         Reviewed by Carlos Garcia Campos.
37
38         Adapt to the removal of "get" prefix from getters in the WebKit- and
39         compositing-thread layer classes.
40
41         * Api/WebOverlay.cpp:
42         (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
43         * Api/WebPageCompositor.cpp:
44         (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
45         (BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
46         (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
47
48 2013-05-28  Andreas Kling  <akling@apple.com>
49
50         Document::setFocusedNode() should be setFocusedElement().
51         <http://webkit.org/b/116857>
52
53         Reviewed by Antti Koivisto.
54
55         * Api/WebPage.cpp:
56         (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
57         (BlackBerry::WebKit::WebPagePrivate::contextNode):
58         (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
59         (BlackBerry::WebKit::WebPage::setNodeFocus):
60         * WebCoreSupport/EditorClientBlackBerry.cpp:
61         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
62         (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
63         * WebKitSupport/InputHandler.cpp:
64         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
65         * WebKitSupport/SelectionHandler.cpp:
66         (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
67         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
68         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
69         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
70         (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
71         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
72
73 2013-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
74
75         Unreviewed. Fix BlackBerry debug build after r150756.
76
77         * WebKitSupport/PagePopup.cpp:
78         (BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
79         assert.
80
81 2013-05-27  Nima Ghanavatian  <nghanavatian@blackberry.com>
82
83         [BlackBerry] Clear supression flag when caret changes aren't propogated through
84         https://bugs.webkit.org/show_bug.cgi?id=116840
85
86         Reviewed by Rob Buis.
87
88         Internally reviewed by Mike Fenton.
89
90         PR339965
91         We set and clear the flag upon every use. This leaves us vulnerable if
92         1. midway through processing the selection change event is dismissed and
93         2. we don't receive a TouchRelease event
94         One example of this is while dragging the FCC handle we start typing. To
95         safeguard against this, if the process change guard is set during a
96         selection change event, we send out to clear the flag status before returning.
97
98         * Api/WebPageClient.h:
99         * WebKitSupport/InputHandler.cpp:
100         (BlackBerry::WebKit::InputHandler::selectionChanged):
101
102 2013-05-27  Andy Chen  <andchen@blackberry.com>
103
104         [BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
105         https://bugs.webkit.org/show_bug.cgi?id=116837
106
107         Reviewed by Rob Buis.
108
109         PR 291903
110         Internally reviewed by Mike Fenton.
111
112         * Api/WebPage.cpp:
113         (BlackBerry::WebKit::WebPage::findNextString):
114         * Api/WebPage.h:
115         * WebKitSupport/InPageSearchManager.cpp:
116         (BlackBerry::WebKit::InPageSearchManager::findNextString):
117         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
118         * WebKitSupport/InPageSearchManager.h:
119         (InPageSearchManager):
120
121 2013-05-27  Eli Fidler  <efidler@rim.com>
122
123         [BlackBerry] Fix subframe target added to new requests
124         https://bugs.webkit.org/show_bug.cgi?id=116602
125
126         Reviewed by Rob Buis.
127
128         In some cases we might be adding TargetIsMainFrame to a subframe
129         request causing an isMainFrame assert.
130
131         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
132         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
133         Check we are actually loading the main frame before setting
134         ResourceRequest::TargetIsMainFrame target.
135
136 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
137
138         [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
139         https://bugs.webkit.org/show_bug.cgi?id=116724
140
141         Reviewed by Rob Buis.
142
143         Add another bool variable m_previousFrameDone to make sure we
144         don't start a new frame until the previous one has been done. Also
145         make sure we pass the animation start time to
146         serviceScriptedAnimations().
147
148         * Api/WebPage.cpp:
149         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
150         m_previousFrameDone and m_monotonicAnimationStartTime.
151         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
152         Return early if previous frame is not done. Otherwise set
153         m_previousFrameDone to false and save the animation start time.
154         (BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
155         serviceScriptedAnimations() passing the saved animation start time
156         and reset m_animationScheduled and m_previousFrameDone.
157         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
158         Call WebPagePrivate::serviceAnimations().
159         * Api/WebPage_p.h:
160         (WebPagePrivate):
161
162 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
163
164         [BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
165         https://bugs.webkit.org/show_bug.cgi?id=116598
166
167         Reviewed by Rob Buis.
168
169         It's no longer needed since the encoder now checks the override encoding.
170
171         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
172         (WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
173         receivedData() passing the DocumentLoader instead of the text
174         encoding.
175         (WebCore::FrameLoaderClientBlackBerry::receivedData): Call
176         DocumentLoader::commitData() directly.
177         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
178         (FrameLoaderClientBlackBerry):
179
180 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [BlackBerry] Move PagePopup implementation to WebKitSupport
183         https://bugs.webkit.org/show_bug.cgi?id=116824
184
185         Reviewed by Rob Buis.
186
187         After r150434 PagePopup implementation in BlackBerry port is
188         independent from WebCore. The classes are now in the
189         BlackBerry::WebKit namespace so they can be moved from
190         WebCoresupport to WebKitSupport and renamed to remove the
191         BlackBerry suffix which is now redundant. Also, now that the
192         implementation is not shared, it can be simplified a bit more.
193
194         * Api/WebPage.cpp:
195         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
196         API changes.
197         (BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
198         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
199         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
200         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
201         * Api/WebPage.h:
202         (WebKit): Ditto.
203         * Api/WebPage_p.h:
204         (WebKit): Ditto.
205         (WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
206         can also point to a color picker or date picker page popup. Also
207         use RefPtr instead of raw pointer.
208         * WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
209         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
210         (BlackBerry::WebKit::ColorPickerClient::generateHTML):
211         (BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
212         Return early if popup has been closed already.
213         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
214         * WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
215         * WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
216         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
217         (BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
218         (BlackBerry::WebKit::DatePickerClient::generateHTML):
219         (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
220         Return early if popup has been closed already.
221         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
222         (BlackBerry::WebKit::DatePickerClient::generateDateLabels):
223         * WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
224         * WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
225         (BlackBerry::WebKit::PagePopup::PagePopup):
226         (BlackBerry::WebKit::PagePopup::~PagePopup):
227         (BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
228         and made void, since it always returned true and the callers
229         ignored the return value.
230         (BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
231         generateHTML for consistency with PagePopupClient::writeDocument()
232         and to avoid confusion with generateHTML method in the clients
233         that create the HTML contents but they don't write the document.
234         (BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
235         Make it static member of PagePopup since the JS object now holds a
236         reference of PagePopup instance as private data.
237         (BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
238         of the PagePopup instance saved as private data of the JS object.
239         (BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
240         instance saved as private data of the JS object.
241         (BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
242         saving the client as private data of the JS object using a wrapper
243         refcounted object, save the PagePopup instance that is now
244         refcounted and access the client from the PagePopup instance in
245         the callback.
246         (BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
247         since PagePopup::closePagePopup was a bit redundant.
248         * WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
249         (BlackBerry::WebKit::PagePopup::create): Static member to create
250         instances of PagePopup now that it's refcounted.
251         * WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
252         (BlackBerry::WebKit::PagePopupClient::PagePopupClient):
253         (BlackBerry::WebKit::PagePopupClient::closePopup):
254         (BlackBerry::WebKit::PagePopupClient::didClosePopup):
255         (BlackBerry::WebKit::PagePopupClient::contentSize):
256         (BlackBerry::WebKit::PagePopupClient::writeDocument):
257         * WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
258         * WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
259         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
260         (BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
261         (BlackBerry::WebKit::SelectPopupClient::generateHTML):
262         (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
263         Return early if popup has been closed already.
264         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
265         (BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
266         * WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
267
268 2013-05-26  Jakob Petsovits  <jpetsovits@blackberry.com>
269
270         [BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
271         https://bugs.webkit.org/show_bug.cgi?id=116539
272         Internal PR 330917
273
274         Reviewed by Carlos Garcia Campos.
275         Internally reviewed by Xiaobo Wang and Arvid Nilsson.
276
277         This reduces complexity by relying on the current state,
278         rather than the suspend counter, which in turn makes it
279         possible to simplify the code in setCompositor().
280
281         * Api/BackingStore.cpp:
282         (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
283         (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
284         * Api/WebPage.cpp:
285         (BlackBerry::WebKit::WebPagePrivate::setCompositor):
286
287 2013-05-26  Kent Tamura  <tkent@chromium.org>
288
289         Remove ENABLE_CALENDAR_PICKER
290         https://bugs.webkit.org/show_bug.cgi?id=116795
291
292         Reviewed by Ryosuke Niwa.
293
294         * WebCoreSupport/AboutDataEnableFeatures.in:
295         The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
296
297 2013-05-26  Andreas Kling  <akling@apple.com>
298
299         FocusController::setFocusedNode() should be setFocusedElement().
300         <http://webkit.org/b/116780>
301
302         Reviewed by Antti Koivisto.
303
304         * Api/WebPage.cpp:
305         (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
306         (BlackBerry::WebKit::WebPage::setNodeFocus):
307         * WebKitSupport/SelectionHandler.cpp:
308         (BlackBerry::WebKit::SelectionHandler::selectObject):
309
310 2013-05-24  Anders Carlsson  <andersca@apple.com>
311
312         Remove PagePopup code
313         https://bugs.webkit.org/show_bug.cgi?id=116732
314
315         Reviewed by Andreas Kling.
316
317         * WebCoreSupport/AboutDataEnableFeatures.in:
318         Remove PAGE_POPUP.
319
320 2013-05-24  Mike Fenton  <mifenton@rim.com>
321
322         [BlackBerry] Fix bad type warning in InputHandler log.
323         https://bugs.webkit.org/show_bug.cgi?id=116720
324
325         Reviewed by Carlos Garcia Campos.
326
327         Fix warning in inputLog string.
328
329         * WebKitSupport/InputHandler.cpp:
330         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
331
332 2013-05-24  Mike Fenton  <mifenton@rim.com>
333
334         [BlackBerry] Respect tabindex when using form controls.
335         https://bugs.webkit.org/show_bug.cgi?id=116676
336
337         Reviewed by Xan Lopez.
338
339         PR 337419.
340
341         Update form control navigation tracking to take tabindex
342         order into account when calculating next and previous nodes.
343
344         The order to follow is tab index 1 - N, followed by all items
345         without a tab index or tab index 0 in rendering order to match
346         with standard desktop behavior.
347
348         Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
349
350         * WebKitSupport/InputHandler.cpp:
351         (BlackBerry::WebKit::InputHandler::updateFormState):
352
353 2013-05-24  Jeff Rogers  <jrogers@rim.com>
354
355         [BlackBerry] Remove SKIA leftovers from WebPage.cpp
356         https://bugs.webkit.org/show_bug.cgi?id=116656
357
358         Reviewed by Rob Buis.
359
360         * Api/WebPage.cpp:
361         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
362
363 2013-05-23  Xiaobo Wang  <xiaobwang@blackberry.com>
364
365         [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
366         https://bugs.webkit.org/show_bug.cgi?id=115245
367
368         Reviewed by Rob Buis.
369
370         PR 330917.
371         Internally reviewed by Arvid Nilsson.
372
373         1. Suspend/resumeRootLayerCommit when notified app activation state
374         change.
375         2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
376         start root layer commit timer, so that there's a commit even if
377         BackingStore got disabled/removed.
378
379         * Api/WebPage.cpp:
380         (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
381         (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
382
383 2013-05-23  Andy Chen  <andchen@blackberry.com>
384
385         [BlackBerry] Need to forward the opener frame url to client when creating a new window
386         https://bugs.webkit.org/show_bug.cgi?id=116566
387
388         Reviewed by Rob Buis.
389
390         PR 337935
391         Internally reviewed by Arvid Nilsson.
392         When creating a new window, forward the opener frame url to client.
393
394         * Api/WebPageClient.h:
395         * WebCoreSupport/ChromeClientBlackBerry.cpp:
396         (WebCore::ChromeClientBlackBerry::createWindow):
397         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
398         (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
399
400 2013-05-23  Jakob Petsovits  <jpetsovits@blackberry.com>
401
402         [BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
403         https://bugs.webkit.org/show_bug.cgi?id=116545
404         Internal PR 189775
405
406         Reviewed by Rob Buis.
407
408         Also change the name of the "documentContents" parameter
409         to the more descriptive "documentSrcRect".
410
411         * Api/WebPageCompositor.cpp:
412         (BlackBerry::WebKit::WebPageCompositorPrivate::render):
413         (BlackBerry::WebKit::WebPageCompositor::render):
414         * Api/WebPageCompositor.h:
415         * Api/WebPageCompositor_p.h:
416         (WebPageCompositorPrivate):
417
418 2013-05-23  Ed Baker  <edbaker@blackberry.com>
419
420         [BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
421         https://bugs.webkit.org/show_bug.cgi?id=116627
422
423         Reviewed by Xan Lopez.
424
425         PR #341084
426
427         If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
428
429         Internally Reviewed by Gen Mak.
430
431         * Api/WebPage.cpp:
432         (BlackBerry::WebKit::WebPagePrivate::webContext):
433
434 2013-05-23  Mike Fenton  <mifenton@rim.com>
435
436         [BlackBerry] Validate form data before doing direct submission.
437         https://bugs.webkit.org/show_bug.cgi?id=116674
438
439         Reviewed by Xan Lopez.
440
441         PR 314202.
442
443         Check validation of the input form before triggering direct submission.
444
445         Internally Reviewed by Nima Ghanavatian.
446
447         * WebKitSupport/InputHandler.cpp:
448         (BlackBerry::WebKit::InputHandler::submitForm):
449
450 2013-05-23  Rob Buis  <rbuis@rim.com>
451
452         [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
453         https://bugs.webkit.org/show_bug.cgi?id=116603
454
455         Reviewed by Xan Lopez.
456
457         PR 119789
458         Internally reviewed by Yong Li.
459
460         Provide a domain value for this ResourceError instance. Note that
461         this does not change behavior.
462
463         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
464         (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
465
466 2013-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
467
468         [BlackBerry] Make PagePopup implementation independent from WebCore
469         https://bugs.webkit.org/show_bug.cgi?id=116448
470
471         Reviewed by Anders Carlsson.
472
473         Add our own implementation of PagePopupClient and make all the
474         pickers inherit from it. Unused methods have been removed and
475         common implementation have been moved from the pickers to the
476         parent class.
477
478         * Api/WebPage.cpp:
479         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
480         popup if there's one active.
481         (BlackBerry::WebKit::WebPagePrivate::setVisible): Call
482         closePagePopup() directly.
483         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
484         PagePopupBlackBerry for the given client.
485         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
486         active popup if there's one.
487         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
488         whether there's an active popup.
489         * Api/WebPage.h:
490         * Api/WebPage_p.h:
491         * WebCoreSupport/ChromeClientBlackBerry.cpp:
492         (WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
493         closePagePopup() call since this is now handled by
494         WebPagePrivate.
495         (WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
496         WebPagePrivate::hasOpenedPopup().
497         * WebCoreSupport/ChromeClientBlackBerry.h:
498         (ChromeClientBlackBerry):
499         * WebCoreSupport/ColorPickerClient.cpp:
500         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
501         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
502         * WebCoreSupport/ColorPickerClient.h:
503         (ColorPickerClient):
504         * WebCoreSupport/DatePickerClient.cpp:
505         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
506         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
507         * WebCoreSupport/DatePickerClient.h:
508         (DatePickerClient):
509         * WebCoreSupport/PagePopupBlackBerry.cpp:
510         (BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
511         (BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
512         * WebCoreSupport/PagePopupBlackBerry.h:
513         (PagePopupBlackBerry):
514         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
515         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
516         (SharedClientPointer):
517         * WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
518         (BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
519         (BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
520         (BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
521         (BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
522         (BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
523         * WebCoreSupport/PagePopupBlackBerryClient.h: Added.
524         (PagePopupBlackBerryClient):
525         (BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
526         * WebCoreSupport/SelectPopupClient.cpp:
527         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
528         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
529         * WebCoreSupport/SelectPopupClient.h:
530         (SelectPopupClient):
531         * WebKitSupport/InputHandler.cpp:
532         (BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
533         closePagePopup() since this is already done by openPagePopup() and
534         use openPagePopup() from WebPagePrivate directly.
535         (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
536         (BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
537
538 2013-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
539
540         [BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
541         https://bugs.webkit.org/show_bug.cgi?id=116302
542
543         Reviewed by Rob Buis.
544
545         TiledImage is now the NativeImage of the BlackBerry port.
546
547         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
548         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
549
550 2013-05-19  Anders Carlsson  <andersca@apple.com>
551
552         Remove link prerendering code
553         https://bugs.webkit.org/show_bug.cgi?id=116415
554
555         Reviewed by Darin Adler.
556
557         This code was only used by Chromium and is dead now.
558
559         * WebCoreSupport/AboutDataEnableFeatures.in:
560
561 2013-05-19  Anders Carlsson  <andersca@apple.com>
562
563         Remove ChromeClient::webView()
564         https://bugs.webkit.org/show_bug.cgi?id=116054
565
566         Reviewed by Andreas Kling.
567
568         This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
569
570         * WebCoreSupport/ChromeClientBlackBerry.h:
571         (ChromeClientBlackBerry):
572
573 2013-05-17  Carlos Garcia Campos  <cgarcia@igalia.com>
574
575         [BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
576         https://bugs.webkit.org/show_bug.cgi?id=116305
577
578         Reviewed by Rob Buis.
579
580         PR 340537.
581         Internally reviewed by Arvid Nilsson.
582
583         Use updateLayoutAndStyleIfNeededRecursive() instead of
584         layoutIfNeeded() since we are about to draw in
585         rootLayerCommitTimerFired().
586
587         * Api/WebPage.cpp:
588         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
589
590 2013-05-17  Mike Fenton  <mifenton@rim.com>
591
592         [BlackBerry] Remove stale comment for select mouse handling.
593         https://bugs.webkit.org/show_bug.cgi?id=116309
594
595         Reviewed by Rob Buis.
596
597         PR 135935.
598
599         Remove a FIXME that has been invalidated by a change
600         to our touch -> mouse model.
601
602         Internally Rubberstamped by Genevieve Mak.
603
604         * Api/WebPage.cpp:
605         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
606
607 2013-05-17  Alberto Garcia  <agarcia@igalia.com>
608
609         [BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
610         https://bugs.webkit.org/show_bug.cgi?id=116298
611
612         Reviewed by Carlos Garcia Campos.
613
614         Pass the correct parameter to toDeviceOrientationClientMock()
615
616         * WebKitSupport/DumpRenderTreeSupport.cpp:
617         (DumpRenderTreeSupport::setMockDeviceOrientation):
618
619 2013-05-16  Mike Fenton  <mifenton@rim.com>
620
621         [BlackBerry] Optimize caret bounds calculation when leaving an input field.
622         https://bugs.webkit.org/show_bug.cgi?id=116224
623
624         Reviewed by Rob Buis.
625
626         PR 340132.
627
628         If the caret is no longer active in the field, do not allow it
629         to go into the single line input logic and calculate the node
630         bounding box.
631
632         Internally Reviewed By Gen Mak
633
634         * WebKitSupport/SelectionHandler.cpp:
635         (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
636
637 2013-05-16  Mary Wu  <mary.wu@torchmobile.com.cn>
638
639         [BlackBerry] Unable to download blob resource
640         https://bugs.webkit.org/show_bug.cgi?id=115888
641
642         Reviewed by Benjamin Poulain.
643
644         For blob resource (blob:http....), it's not suitable to go to NetworkStream
645         which don't handle "blob" protocol at all. since blob data already handled
646         in BlobResourceHandle, simply get the data out to download stream.
647
648         RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
649
650         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
651         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
652
653 2013-05-16  Andreas Kling  <akling@apple.com>
654
655         Page::chrome() should return a reference.
656         <http://webkit.org/b/116185>
657
658         Reviewed by Anders Carlsson.
659
660 2013-05-13  Anders Carlsson  <andersca@apple.com>
661
662         Frame::editor() should return a reference
663         https://bugs.webkit.org/show_bug.cgi?id=116037
664
665         Reviewed by Darin Adler.
666
667         * WebCoreSupport/EditorClientBlackBerry.cpp:
668         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
669         (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
670         * WebKitSupport/DOMSupport.cpp:
671         (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
672         * WebKitSupport/InPageSearchManager.cpp:
673         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
674         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
675         * WebKitSupport/SelectionHandler.cpp:
676         (BlackBerry::WebKit::SelectionHandler::selectedText):
677
678 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
679
680         Remove WTF_USE_PLATFORM_STRATEGIES
681         https://bugs.webkit.org/show_bug.cgi?id=114431
682
683         Reviewed by Darin Adler.
684
685         * WebCoreSupport/AboutDataUseFeatures.in:
686
687 2013-05-14  Tiancheng Jiang  <tijiang@rim.com>
688
689         [BlackBerry] Improve Fatfinger phase.
690         https://bugs.webkit.org/show_bug.cgi?id=107403
691
692         Reviewed by Rob Buis.
693
694         Internally reviewed by Genevieve Mak.
695         BlackBerry PR 324965.
696
697         Cache and reuse intersected nodes as long as hit position has not been
698         changed.
699
700         * Api/WebPage.cpp:
701         (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
702         * Api/WebPage_p.h:
703         (WebPagePrivate):
704         * WebKitSupport/FatFingers.cpp:
705         (BlackBerry::WebKit::FatFingers::findBestPoint):
706         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
707         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
708         * WebKitSupport/FatFingers.h:
709
710 2013-05-14  Andrew Lo  <anlo@rim.com>
711
712         [BlackBerry] Hook up frame render begin/end in PerformanceMonitor
713         https://bugs.webkit.org/show_bug.cgi?id=116110
714
715         Reviewed by Rob Buis.
716
717         Internally reviewed by Jeff Rogers, Jonathan Jiang.
718         Internal PR 299155.
719
720         Mark frame render begin & end for BlackBerry performance monitoring
721         in blitVisibleContents.
722
723         * Api/BackingStore.cpp:
724         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
725
726 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
727
728         [BlackBerry] Use requestAnimationFrame for animations
729         https://bugs.webkit.org/show_bug.cgi?id=115896
730
731         Reviewed by Rob Buis.
732
733         Make WebPagePrivate a
734         BlackBerry::Platform::AnimationFrameRateClient and use it to
735         schedule animations.
736
737         * Api/WebPage.cpp:
738         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
739         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
740         (WebKit):
741         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
742         (BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
743         (BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
744         (BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
745         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
746         * Api/WebPage_p.h:
747         (WebPagePrivate):
748         * WebCoreSupport/ChromeClientBlackBerry.cpp:
749         (WebCore):
750         (WebCore::ChromeClientBlackBerry::scheduleAnimation):
751         * WebCoreSupport/ChromeClientBlackBerry.h:
752         (ChromeClientBlackBerry):
753
754 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         [BlackBerry] Implement platform strategies
757         https://bugs.webkit.org/show_bug.cgi?id=112162
758
759         Reviewed by Rob Buis.
760
761         * Api/BlackBerryGlobal.cpp:
762         (BlackBerry::WebKit::globalInitialize): Initialize platform
763         strategies.
764         * WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
765         (PlatformStrategiesBlackBerry::initialize):
766         (PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
767         (PlatformStrategiesBlackBerry::createCookiesStrategy):
768         (PlatformStrategiesBlackBerry::createDatabaseStrategy):
769         (PlatformStrategiesBlackBerry::createLoaderStrategy):
770         (PlatformStrategiesBlackBerry::createPasteboardStrategy):
771         (PlatformStrategiesBlackBerry::createPluginStrategy):
772         (PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
773         (PlatformStrategiesBlackBerry::createStorageStrategy):
774         (PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
775         (PlatformStrategiesBlackBerry::cookiesForDOM):
776         (PlatformStrategiesBlackBerry::setCookiesFromDOM):
777         (PlatformStrategiesBlackBerry::cookiesEnabled):
778         (PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
779         (PlatformStrategiesBlackBerry::getRawCookies):
780         (PlatformStrategiesBlackBerry::deleteCookie):
781         (PlatformStrategiesBlackBerry::refreshPlugins):
782         (PlatformStrategiesBlackBerry::getPluginInfo):
783         (PlatformStrategiesBlackBerry::isLinkVisited):
784         (PlatformStrategiesBlackBerry::addVisitedLink):
785         * WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
786         (PlatformStrategiesBlackBerry):
787
788 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
789
790         [BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
791         https://bugs.webkit.org/show_bug.cgi?id=115412
792
793         Reviewed by Rob Buis.
794
795         PR 115412
796
797         The problem is that we are calling
798         updateLayoutAndStyleIfNeededRecursive() (because of
799         zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
800         callback which is not expected. It's expected to be called right
801         before painting, and not right after painting. Even if a new
802         layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
803         flushDeferredRepaints() and it's possible that this is called in
804         the middle of a beginDeferredRepaints() and endDeferredRepaints()
805         apparently.
806         In general only BackingStore should call
807         updateLayoutAndStyleIfNeededRecursive before painting, and a simple
808         layout is enough in all other cases like resizing. This patch renames
809         requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
810         make more obvious what it does, and adds layoutIfNeeded that calls
811         layout. The former is used by the BackingStore and the latter by
812         WebPage.
813
814         * Api/BackingStore.cpp:
815         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
816         (BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
817         * Api/WebPage.cpp:
818         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
819         (BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
820         (BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
821         (WebKit):
822         (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
823         (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
824         (BlackBerry::WebKit::WebPagePrivate::webContext):
825         (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
826         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
827         (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
828         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
829         * Api/WebPage_p.h:
830         (WebPagePrivate):
831
832 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
833
834         Remove USE(OS_RANDOMNESS)
835         https://bugs.webkit.org/show_bug.cgi?id=108095
836
837         Reviewed by Darin Adler.
838
839         Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
840         ports.
841
842         * WebCoreSupport/AboutDataUseFeatures.in:
843
844 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
845
846         Fix some compiler warnings (miscellaneous)
847         https://bugs.webkit.org/show_bug.cgi?id=80790
848
849         Reviewed by Rob Buis.
850
851         Fix the following warnings for BlackBerry:
852         BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
853         '||' [-Wparentheses].
854         WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
855         as truth value [-Wparentheses].
856         WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
857         as truth value [-Wparentheses]
858
859         * Api/BackingStore.cpp:
860         (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
861         * Api/WebPage.cpp:
862         (BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
863         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
864
865 2013-05-09  Mike Fenton  <mifenton@rim.com>
866
867         [BlackBerry] Style updates required based on new check-webkit-style
868         https://bugs.webkit.org/show_bug.cgi?id=115857
869
870         Reviewed by Rob Buis.
871
872         Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
873         to match check-webkit-style updates.
874
875         * Api/InRegionScroller.cpp:
876         (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
877         * Api/InRegionScroller_p.h:
878         * Api/WebKitTextCodec.cpp:
879         (BlackBerry::WebKit::transcode):
880         * Api/WebPageCompositor.cpp:
881         (BlackBerry::WebKit::WebPageCompositor::render):
882         * Api/WebPageCompositor.h:
883         * Api/WebPageCompositor_p.h:
884         (WebPageCompositorPrivate):
885         * Api/WebSettings_p.h:
886
887 2013-05-09  Max Feil  <mfeil@rim.com>
888
889         shouldUsePluginDocument() needs to be respected when a document is created
890         https://bugs.webkit.org/show_bug.cgi?id=110308
891
892         Reviewed by Rob Buis.
893
894         This patch implements shouldAlwaysUsePluginDocument() in the
895         BlackBerry frame loader client. It is called in several places
896         within WebCore to determine whether a PluginDocument should
897         be created.
898
899         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
900         (WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
901         (WebCore):
902         (WebCore::FrameLoaderClientBlackBerry::createPlugin):
903         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
904         (FrameLoaderClientBlackBerry):
905
906 2013-05-09  Mike Fenton <mifenton@rim.com>
907
908         [BlackBerry] Style updates required based on new check-webkit-style
909         https://bugs.webkit.org/show_bug.cgi?id=115857
910
911         Reviewed by Rob Buis.
912
913         Update SelectionHandler to match check-webkit-style updates.
914
915         * WebKitSupport/SelectionHandler.cpp:
916         (BlackBerry::WebKit::shouldExtendSelectionInDirection):
917         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
918         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
919         (BlackBerry::WebKit::adjustCaretRects):
920         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
921         (BlackBerry::WebKit::regionRectListContainsPoint):
922         * WebKitSupport/SelectionHandler.h:
923         (SelectionHandler):
924
925 2013-05-09  Mike Fenton  <mifenton@rim.com>
926
927         [BlackBerry] Style updates required based on new check-webkit-style
928         https://bugs.webkit.org/show_bug.cgi?id=115857
929
930         Reviewed by Rob Buis.
931
932         Update WebPage and WebPageClient to match check-webkit-style updates.
933
934         * Api/WebPage.cpp:
935         (BlackBerry::WebKit::WebPagePrivate::init):
936         (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
937         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
938         (BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
939         (BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
940         (BlackBerry::WebKit::WebPage::assignFocus):
941         (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
942         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
943         (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
944         (BlackBerry::WebKit::WebPage::addVisitedLink):
945         (BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
946         (BlackBerry::WebKit::WebPage::notifySwipeEvent):
947         (BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
948         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
949         (BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
950         (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
951         * Api/WebPageClient.h:
952         * Api/WebPage_p.h:
953
954 2013-05-09  Mike Fenton  <mifenton@rim.com>
955
956
957         [BlackBerry] Style updates required based on new check-webkit-style
958         https://bugs.webkit.org/show_bug.cgi?id=115857
959
960         Reviewed by Rob Buis.
961
962         Update BackingStore to match check-webkit-style updates.
963
964         Internally reviewed by Jakob Petsovits.
965
966         * Api/BackingStore.cpp:
967         (BlackBerry::WebKit::bestDivisor):
968         (BlackBerry::WebKit::BackingStorePrivate::repaint):
969         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
970         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
971         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
972         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
973         (BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
974         (BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
975         (BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
976         (BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
977         (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
978         (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
979         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
980         (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
981         (BlackBerry::WebKit::BackingStore::repaint):
982         * Api/BackingStore_p.h:
983         (BackingStoreGeometry):
984
985 2013-05-09  Mike Fenton  <mifenton@rim.com>
986
987         [BlackBerry] Style updates required based on new check-webkit-style
988         https://bugs.webkit.org/show_bug.cgi?id=115857
989
990         Reviewed by Rob Buis.
991
992         Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
993         GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
994         match check-webkit-style updates.
995
996         * WebCoreSupport/ChromeClientBlackBerry.h:
997         (ChromeClientBlackBerry):
998         * WebCoreSupport/CredentialManager.h:
999         (CredentialManager):
1000         * WebCoreSupport/CredentialTransformData.cpp:
1001         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
1002         (WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
1003         (FrameLoaderClientBlackBerry):
1004         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
1005         (WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
1006         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
1007         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
1008         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
1009         * WebCoreSupport/GeolocationClientBlackBerry.cpp:
1010         (GeolocationClientBlackBerry::onLocationUpdate):
1011         * WebCoreSupport/GeolocationClientBlackBerry.h:
1012         (GeolocationClientBlackBerry):
1013         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
1014         (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
1015
1016 2013-05-09  Jacky Jiang  <zhajiang@blackberry.com>
1017
1018         Fix some compiler warnings (miscellaneous)
1019         https://bugs.webkit.org/show_bug.cgi?id=80790
1020
1021         Reviewed by Rob Buis.
1022
1023         Fix the following warnings for BlackBerry:
1024         InRegionScroller.cpp:286:39: warning: suggest parentheses around
1025         assignment used as truth value [-Wparentheses].
1026         InRegionScroller.cpp:349:39: warning: suggest parentheses around
1027         assignment used as truth value [-Wparentheses].
1028         InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
1029         within '||' [-Wparentheses].
1030         InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
1031         avoid ambiguous 'else' [-Wparentheses].
1032         SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
1033         within '||' [-Wparentheses].
1034         SelectionOverlay.cpp:56:47: warning: comparison between signed and
1035         unsigned integer expressions [-Wsign-compare].
1036
1037
1038         * Api/InRegionScroller.cpp:
1039         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
1040         (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
1041         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
1042         * WebKitSupport/InRegionScrollableArea.cpp:
1043         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
1044         * WebKitSupport/SelectionHandler.cpp:
1045         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
1046         * WebKitSupport/SelectionOverlay.cpp:
1047         (BlackBerry::WebKit::SelectionOverlay::draw):
1048
1049 2013-05-09  Mike Fenton  <mifenton@rim.com>
1050
1051         [BlackBerry] Style updates required based on new check-webkit-style
1052         https://bugs.webkit.org/show_bug.cgi?id=115857
1053
1054         Reviewed by Rob Buis.
1055
1056         Update ColorPickerClient and PagePopupBlackBerry
1057         to match check-webkit-style updates.
1058
1059         * WebCoreSupport/ColorPickerClient.cpp:
1060         (WebCore::ColorPickerClient::generateHTML):
1061         * WebCoreSupport/PagePopupBlackBerry.cpp:
1062         (WebCore::setValueAndClosePopupCallback):
1063         (WebCore::PagePopupBlackBerry::installDOMFunction):
1064
1065 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
1066
1067         [BlackBerry] Upstream the input popups
1068         https://bugs.webkit.org/show_bug.cgi?id=114608
1069
1070         Reviewed by Rob Buis.
1071
1072         This patch contains contributions from many members of the
1073         BlackBerry WebKit team, including:
1074
1075         Chris Hutten-Czapski
1076         David Hoon
1077         Jessica Cao
1078         Rob Buis
1079         Tiancheng Jiang
1080
1081         * WebCoreSupport/ColorPickerClient.cpp:
1082         (WebCore):
1083         (WebCore::ColorPickerClient::generateHTML):
1084         * WebCoreSupport/DatePickerClient.cpp:
1085         (WebCore):
1086         (WebCore::DatePickerClient::generateHTML):
1087         (WebCore::DatePickerClient::generateDateLabels):
1088         * WebCoreSupport/DatePickerClient.h:
1089         (DatePickerClient):
1090         * WebCoreSupport/SelectPopupClient.cpp:
1091         (WebCore):
1092         (WebCore::SelectPopupClient::generateHTML):
1093
1094 2013-05-09  Mike Fenton  <mifenton@rim.com>
1095
1096         [BlackBerry] Style updates required based on new check-webkit-style
1097         https://bugs.webkit.org/show_bug.cgi?id=115857
1098
1099         Reviewed by Rob Buis.
1100
1101         Update DOMSupport to match check-webkit-style updates.
1102
1103         * WebKitSupport/DOMSupport.cpp:
1104         (BlackBerry::WebKit::DOMSupport::isTextInputElement):
1105         (BlackBerry::WebKit::DOMSupport::isPasswordElement):
1106         (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
1107
1108 2013-05-09  Xuefei Ren  <xren@blackberry.com>
1109
1110         [BLACKBERRY]fix regression in Webpage
1111         and FrameLoaderClientBlackberry
1112         https://bugs.webkit.org/show_bug.cgi?id=115843
1113
1114         Reviewed by Rob Buis.
1115
1116         Internally reviewed by Mary Wu.
1117
1118         * Api/WebPage.cpp:
1119         (BlackBerry::WebKit::WebPage::loadFile):
1120         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1121         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1122
1123 2013-05-09  Mike Fenton  <mifenton@rim.com>
1124
1125         [BlackBerry] Style updates required based on new check-webkit-style
1126         https://bugs.webkit.org/show_bug.cgi?id=115857
1127
1128         Reviewed by Rob Buis.
1129
1130         Update FatFingers to match check-webkit-style updates.
1131
1132         * WebKitSupport/FatFingers.cpp:
1133         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
1134         (BlackBerry::WebKit::FatFingers::checkForClickableElement):
1135         * WebKitSupport/FatFingers.h:
1136         (FatFingersResult):
1137
1138 2013-05-09  Mike Fenton  <mifenton@rim.com>
1139
1140         [BlackBerry] Style updates required based on new check-webkit-style
1141         https://bugs.webkit.org/show_bug.cgi?id=115857
1142
1143         Reviewed by Rob Buis.
1144
1145         Update InRegionScrollableArea, TileIndexHash
1146         and TouchEventHandler to match check-webkit-style updates.
1147
1148         * WebKitSupport/InRegionScrollableArea.cpp:
1149         * WebKitSupport/TileIndexHash.h:
1150         * WebKitSupport/TouchEventHandler.cpp:
1151         (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
1152
1153 2013-05-09  Mike Fenton  <mifenton@rim.com>
1154
1155         [BlackBerry] Style updates required based on new check-webkit-style
1156         https://bugs.webkit.org/show_bug.cgi?id=115857
1157
1158         Reviewed by Rob Buis.
1159
1160         Styles fixes required for InputHandler based on updated
1161         check-webkit-style.
1162
1163         * WebKitSupport/InputHandler.cpp:
1164         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1165         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1166         (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
1167         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
1168         (BlackBerry::WebKit::InputHandler::firstSpanInString):
1169         (BlackBerry::WebKit::InputHandler::setTextAttributes):
1170         * WebKitSupport/InputHandler.h:
1171
1172 2013-05-08  Eli Fidler  <efidler@blackberry.com>
1173
1174         [BlackBerry] Fix usage of BlackBerry::Platform::String
1175         https://bugs.webkit.org/show_bug.cgi?id=115781
1176
1177         Reviewed by Rob Buis.
1178
1179         BlackBerry PRs 304193 and 327181
1180         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
1181
1182         We currently have a problem where we're passing UTF-8 encoded data into
1183         the char* constructors of BlackBerry::Platform::String. This means the string
1184         thinks its data is not UTF-8.
1185
1186         * Api/JavaScriptVariant.cpp:
1187         (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
1188         * Api/WebKitTextCodec.cpp:
1189         (BlackBerry::WebKit::base64Encode):
1190         * Api/WebPage.cpp:
1191         (BlackBerry::WebKit::WebPage::loadFile):
1192         (BlackBerry::WebKit::WebPage::textEncoding):
1193         (BlackBerry::WebKit::WebPage::textHasAttribute):
1194         (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
1195         * Api/WebPage.h:
1196         * Api/WebSettings.cpp:
1197         (BlackBerry::WebKit::WebSettings::standardSettings):
1198         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1199         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
1200         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
1201         * WebKitSupport/DefaultTapHighlight.cpp:
1202         (WebKit):
1203         (BlackBerry::WebKit::DefaultTapHighlight::draw):
1204         (BlackBerry::WebKit::DefaultTapHighlight::hide):
1205
1206 2013-05-08  Rob Buis  <rbuis@rim.com>
1207
1208         Fix some compiler warnings (miscellaneous)
1209         https://bugs.webkit.org/show_bug.cgi?id=80790
1210
1211         Reviewed by Philip Rogers.
1212
1213         Get rid of the following warning for BlackBerry:
1214
1215         BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
1216
1217         by using ASSERT_UNUSED instead of ASSERT.
1218
1219         * WebKitSupport/BackingStoreClient.cpp:
1220         (BlackBerry::WebKit::BackingStoreClient::create):
1221
1222 2013-05-07  Xuefei Ren  <xren@blackberry.com>
1223
1224         Clean up load interface in WebPage
1225         https://bugs.webkit.org/show_bug.cgi?id=115622
1226         Reviewed by Rob Buis.
1227
1228         Internal PR:315535
1229         Internal reviewed by  Mary Wu
1230
1231         * Api/WebPage.cpp:
1232         (BlackBerry::WebKit::WebPagePrivate::load):
1233         (BlackBerry::WebKit::WebPage::loadFile):
1234         (BlackBerry::WebKit::WebPage::load):
1235         * Api/WebPage.h:
1236         * Api/WebPage_p.h:
1237         (WebPagePrivate):
1238         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1239         (WebCore::FrameLoaderClientBlackBerry::startDownload):
1240
1241 2013-05-07  Mike Fenton  <mifenton@rim.com>
1242
1243         [BlackBerry] Increase the padding size for caret based scrolling.
1244         https://bugs.webkit.org/show_bug.cgi?id=115749
1245
1246         Reviewed by Rob Buis.
1247
1248         PR 322670.
1249
1250         Increasing the padding size for scrolling in order to optimize the
1251         number of scrolls required during typing.
1252
1253         * WebKitSupport/InputHandler.cpp:
1254         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
1255
1256 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1257
1258         [BlackBerry] Maintain touch event state throughout processing
1259         https://bugs.webkit.org/show_bug.cgi?id=115663
1260
1261         Reviewed by Rob Buis.
1262
1263         Internally reviewed by Otto Cheung and Genevieve Mak.
1264
1265         PR 297691
1266         By maintaining our touch event state, we can get a better idea
1267         of what triggered an update to selection and respond appropriately.
1268         On touch press we set userTouchTriggered to give the UI thread
1269         some context.
1270
1271         * Api/WebPage.cpp:
1272         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
1273         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
1274         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
1275         * Api/WebPage_p.h:
1276         (WebPagePrivate):
1277         * WebKitSupport/SelectionHandler.cpp:
1278         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1279
1280 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1281
1282         [BlackBerry] Read-only fields should not get keyboard focus
1283         https://bugs.webkit.org/show_bug.cgi?id=115725
1284
1285         Reviewed by Rob Buis.
1286
1287         Internally reviewed by Mike Fenton.
1288
1289         PR332887
1290         Prevent keyboard focus and FCC from displaying when the user taps on a
1291         read-only field. Further, ensure form controls skip over these fields
1292         with the next/previous buttons.
1293
1294         * WebKitSupport/DOMSupport.cpp:
1295         (BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
1296         (DOMSupport):
1297         * WebKitSupport/DOMSupport.h:
1298         * WebKitSupport/InputHandler.cpp:
1299         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
1300         (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
1301         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
1302         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
1303         (WebKit):
1304         * WebKitSupport/InputHandler.h:
1305
1306 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
1307
1308         [BlackBerry] Expand spellcheck logging
1309         https://bugs.webkit.org/show_bug.cgi?id=115482
1310
1311         Reviewed by Rob Buis.
1312
1313         Internally reviewed by Mike Fenton.
1314
1315         Fix some build errors when SpellingLog was turned on and expand on the debug
1316         statements to be more verbose. Set up timers and print the duration of each
1317         iteration as we traverse the text to create a range to send out for checking.
1318
1319         * WebKitSupport/InputHandler.cpp:
1320         (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
1321         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
1322         (BlackBerry::WebKit::InputHandler::setElementFocused):
1323         (WebKit):
1324         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
1325         * WebKitSupport/SpellingHandler.cpp:
1326         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1327         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
1328
1329 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
1330
1331         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
1332         https://bugs.webkit.org/show_bug.cgi?id=113808
1333
1334         Reviewed by Rob Buis.
1335
1336         Create a WebSetting for text autosizing. The default is off.
1337
1338         * Api/WebPage.cpp:
1339         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
1340         * Api/WebSettings.cpp:
1341         (WebKit):
1342         (BlackBerry::WebKit::WebSettings::standardSettings):
1343         (BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
1344         (BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):
1345         * Api/WebSettings.h:
1346
1347 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1348
1349         [BlackBerry] Ensure document is attached before accessing its FrameSelection
1350         https://bugs.webkit.org/show_bug.cgi?id=115565
1351
1352         Reviewed by Rob Buis.
1353
1354         Internally reviewed by Mike Fenton.
1355
1356         PR 312101
1357         We need to make sure that the node and document
1358         are attached before accessing the FrameSelection. This was
1359         handled earlier but not all call paths were covered.
1360
1361         * WebKitSupport/InputHandler.cpp:
1362         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
1363         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
1364         (WebKit):
1365         * WebKitSupport/InputHandler.h:
1366
1367 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1368
1369         [BlackBerry] Do not spellcheck when composition is active.
1370         https://bugs.webkit.org/show_bug.cgi?id=115562
1371
1372         Reviewed by Rob Buis.
1373
1374         Internally reviewed by Mike Fenton.
1375
1376         PR331344
1377         Typing can trigger rechecking since layout changes. Ensure
1378         extra work is only done when we need it, and that it won't
1379         be triggered when composition is active. If the user hasn't
1380         finished a word yet, it is likely future key events will be
1381         arriving, so checking the string at this point is extraneous.
1382
1383         * WebKitSupport/InputHandler.cpp:
1384         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
1385
1386 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1387
1388         [BlackBerry] Reduce the spellcheck checking range
1389         https://bugs.webkit.org/show_bug.cgi?id=115479
1390
1391         Reviewed by Rob Buis.
1392
1393         Internally reviewed by Mike Fenton.
1394
1395         PR332773
1396         Previously we were spellchecking the entire field on focus. If relayouting
1397         occurred we rechecked this region, which is very costly. Switch to check
1398         only a small region around the caret in both cases, which should alleviate
1399         much of the delays experienced in very large contenteditable fields. This
1400         allows for faster key input response and less time processing these requests
1401         on the WebKit thread.
1402
1403         * WebKitSupport/InputHandler.cpp:
1404         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
1405         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
1406         * WebKitSupport/SpellingHandler.cpp:
1407         (WebKit):
1408         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1409         * WebKitSupport/SpellingHandler.h:
1410         (SpellingHandler):
1411
1412 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
1413
1414         [BlackBerry] Use a more descriptive timer name
1415         https://bugs.webkit.org/show_bug.cgi?id=115481
1416
1417         Reviewed by Rob Buis.
1418
1419         Internally reviewed by Mike Fenton.
1420
1421         Changing m_timer to m_iterationDelayTimer.
1422
1423         * WebKitSupport/SpellingHandler.cpp:
1424         (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
1425         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
1426         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
1427         * WebKitSupport/SpellingHandler.h:
1428         (SpellingHandler):
1429
1430 2013-05-04  Nima Ghanavatian  <nghanavatian@blackberry.com>
1431
1432         [BlackBerry] Clean up unused spellcheck code
1433         https://bugs.webkit.org/show_bug.cgi?id=115560
1434
1435         Reviewed by Benjamin Poulain.
1436         Internally reviewed by Mike Lattanzio
1437
1438         * Api/WebPage.cpp:
1439         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
1440         * Api/WebPage.h:
1441         * WebKitSupport/InputHandler.cpp:
1442         * WebKitSupport/InputHandler.h:
1443         (InputHandler):
1444
1445 2013-05-03  Jacky Jiang  <zhajiang@blackberry.com>
1446
1447         [BlackBerry] Page rendering scale is changed after go back and forward
1448         https://bugs.webkit.org/show_bug.cgi?id=115573
1449
1450         Reviewed by Rob Buis.
1451         Internally reviewed by Jeff Rogers.
1452
1453         PR: 326886
1454         When navigating back from page A with viewport to page B without
1455         viewport, we didn't call setViewMode(); therefore, we didn't change
1456         the fixed layout size which was set by page A. In that case, WebCore
1457         would just pick up page A's fixed layout size to layout page B which
1458         caused this issue.
1459         Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
1460         later is not a good way, because zoomToInitialScaleOnLoad() has never
1461         been called in this case. So we should always call setViewMode() to set
1462         fixed layout size when a new page is committed.
1463
1464         * Api/WebPage.cpp:
1465         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
1466
1467 2013-05-02  Genevieve Mak  <gmak@rim.com>
1468
1469         [BlackBerry] Cannot touch scroll readonly text input.
1470         https://bugs.webkit.org/show_bug.cgi?id=115378
1471
1472         Reviewed by Rob Buis.
1473
1474         PR #332902
1475         Reviewed Internally by Mike Fenton.
1476         Forgot half the patch.
1477         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
1478         Check the node type instead.
1479
1480         * Api/InRegionScroller.cpp:
1481         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
1482
1483 2013-05-02  Iris Wu  <shuwu@blackberry.com>
1484
1485         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
1486         https://bugs.webkit.org/show_bug.cgi?id=115178
1487
1488         Reviewed by Rob Buis.
1489
1490         PR 308796
1491         Debug build fix.
1492
1493         * Api/WebPage.cpp:
1494         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
1495
1496 2013-05-01  Iris Wu  <shuwu@blackberry.com>
1497
1498          [BlackBerry] Upstream smart selection
1499          https://bugs.webkit.org/show_bug.cgi?id=111226
1500
1501         Reviewed by Rob Buis.
1502
1503         Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
1504         caused crash.
1505         But viewport from webkitThreadViewportAccessor uses unadjusted size which is
1506         wrong for email.
1507         The solution here is to get actual viewport size on UI thread and then pass it
1508         to WebKit::SelectionHandler.
1509
1510         PR 333763
1511         Reviewed Internally By Jakob Petsovits.
1512
1513         * Api/InRegionScroller.cpp:
1514         (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
1515         * Api/WebPage.cpp:
1516         (BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
1517         (WebKit):
1518         * Api/WebPage.h:
1519         * WebKitSupport/SelectionHandler.cpp:
1520         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
1521         (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
1522         (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
1523         * WebKitSupport/SelectionHandler.h:
1524         (BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
1525         (BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
1526         (SelectionHandler):
1527
1528 2013-04-30  Genevieve Mak  <gmak@rim.com>
1529
1530         [BlackBerry] Cannot touch scroll readonly text input.
1531         https://bugs.webkit.org/show_bug.cgi?id=115378
1532
1533         Reviewed by Rob Buis.
1534
1535         PR #332902
1536         Reviewed Internally by Mike Fenton.
1537         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
1538         Check the node type instead.
1539
1540         * WebKitSupport/DOMSupport.cpp:
1541         (BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
1542         (DOMSupport):
1543         * WebKitSupport/DOMSupport.h:
1544         * WebKitSupport/InRegionScrollableArea.cpp:
1545         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
1546
1547 2013-04-29  Jakob Petsovits  <jpetsovits@blackberry.com>
1548
1549         [BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
1550         https://bugs.webkit.org/show_bug.cgi?id=115360
1551         Internal PR 303048.
1552
1553         Reviewed by Rob Buis.
1554
1555         Instead of using fillBuffer() to draw directly to the
1556         target buffer, we now lock a Drawable on it and fill it
1557         with PlatformGraphicsContext::addPredefinedPattern().
1558
1559         As a bonus, this also includes related clean-ups -
1560         simpler checkerboard painting code, removal of
1561         fillWindow(), clearWindow() and paintDefaultBackground(),
1562         as well as getting rid of the DEBUG_CHECKERBOARD define
1563         which has been useless for performance tracing purposes
1564         for a while now.
1565
1566         * Api/BackingStore.cpp:
1567         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
1568         * Api/BackingStore_p.h:
1569
1570 2013-04-26  Nima Ghanavatian  <nghanavatian@blackberry.com>
1571
1572         [BlackBerry] Check for valid element in elementTouched
1573         https://bugs.webkit.org/show_bug.cgi?id=115205
1574
1575         Reviewed by Rob Buis.
1576
1577         Internally reviewed by Genevieve Mak.
1578
1579         PR 331546
1580         We might receive a null ptr from nodeAsElementIfApplicable which
1581         is passed in here. Check to make sure it's valid before using.
1582
1583         * WebKitSupport/InputHandler.cpp:
1584         (BlackBerry::WebKit::InputHandler::elementTouched):
1585
1586 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
1587
1588         Remove the remaining Skia #ifdefs
1589         https://bugs.webkit.org/show_bug.cgi?id=114886
1590
1591         Reviewed by Benjamin Poulain.
1592
1593         * Api/WebPage.cpp: Remove Skia #ifdef references.
1594         * WebCoreSupport/AboutDataUseFeatures.in: Ditto.
1595
1596 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1597
1598         [BlackBerry] Should check if it's cached resource before download
1599         https://bugs.webkit.org/show_bug.cgi?id=115101
1600
1601         Reviewed by Rob Buis.
1602
1603         Since main resource maybe cached, if user want to save the resource, we first check
1604         if it's cached. If yes, don't need to initiate a fresh load again, but get the
1605         cached resource data out to save.
1606
1607         RIM bug# 324003, internally reviewed by Charles Wei.
1608
1609         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1610         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
1611
1612 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
1613
1614         [BlackBerry] Clean up load interface in WebPage
1615         https://bugs.webkit.org/show_bug.cgi?id=113267
1616
1617         Reviewed by Rob Buis.
1618
1619         Remove unused loadExtended(), combine load() and download() api in WebPage.
1620         RIM Bug# 315535, internally reviewed by Joe Mason.
1621
1622         * Api/WebPage.cpp:
1623         (BlackBerry::WebKit::WebPage::load):
1624         * Api/WebPage.h:
1625
1626 2013-04-25  Andrew Lo  <anlo@rim.com>
1627
1628         [BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
1629         https://bugs.webkit.org/show_bug.cgi?id=115197
1630
1631         Reviewed by Rob Buis.
1632
1633         When drawing the selection overlay, the rects to
1634         paint when selecting text on non-composited sub-frames
1635         need to be adjusted by the frame position.
1636
1637         * WebKitSupport/SelectionOverlay.cpp:
1638         (BlackBerry::WebKit::SelectionOverlay::paintContents):
1639
1640 2013-04-25  Andreas Kling  <akling@apple.com>
1641
1642         Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.
1643
1644         Rubber-stamped by Anders Koivisto.
1645
1646         * WebCoreSupport/AboutDataEnableFeatures.in:
1647
1648 2013-04-25  Iris Wu  <shuwu@blackberry.com>
1649
1650         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
1651         https://bugs.webkit.org/show_bug.cgi?id=115178
1652
1653         Reviewed by Rob Buis.
1654
1655         PR 308796
1656
1657         Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
1658         left point of the viewport.
1659         On the page with fixed position elements, we want it to adjust the position beneath
1660         the fixed elements so it can be always visible.
1661
1662         The basic idea is:
1663         1.  Detect if there are fixed position elements before going through ProximityDetector.
1664         2.  If the fixed element exists, calculate its the size and the actual visible position
1665             beneath it.
1666         3.  Pass the position to ProximityDetector. Then according to the new position we get,
1667             calculate the top left position of the viewport (final scroll position).
1668
1669         * Api/WebPage.cpp:
1670         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
1671         (WebKit):
1672         * Api/WebPage.h:
1673         * Api/WebPageCompositor.cpp:
1674         (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
1675         (WebKit):
1676         * Api/WebPageCompositor_p.h:
1677         (WebPageCompositorPrivate):
1678
1679 2013-04-25  Mike Lattanzio  <mlattanzio@blackberry.com>
1680
1681         [BlackBerry] Enable balanced page group load deferrer behaviour.
1682         https://bugs.webkit.org/show_bug.cgi?id=115189
1683
1684         Reviewed by Rob Buis.
1685
1686         Prevent a possible deadlock by enabling balanced deferrers.
1687         Internally reviewed by: Joe Mason
1688         PR 329986
1689
1690         * Api/WebPage.cpp:
1691         (BlackBerry::WebKit::WebPagePrivate::init):
1692
1693 2013-04-25  Joseph Pecoraro  <pecoraro@apple.com>
1694
1695         Web Inspector: ConsoleMessage should include line and column number where possible
1696         https://bugs.webkit.org/show_bug.cgi?id=114929
1697
1698         Reviewed by Timothy Hatcher.
1699
1700         * Api/DumpRenderTreeClient.h:
1701         * Api/WebPageClient.h:
1702         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1703         (WebCore::ChromeClientBlackBerry::addMessageToConsole):
1704         * WebCoreSupport/ChromeClientBlackBerry.h:
1705         (ChromeClientBlackBerry):
1706
1707 2013-04-25  Konrad Piascik  <kpiascik@blackberry.com>
1708
1709         [BlackBerry] Get rid of return in void method
1710         https://bugs.webkit.org/show_bug.cgi?id=115186
1711
1712         Reviewed by Rob Buis.
1713
1714         * Api/WebPage.cpp:
1715         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
1716
1717 2013-04-24  Nima Ghanavatian  <nghanavatian@blackberry.com>
1718
1719         [BlackBerry] Do not clear focus on a node when tapping on form controls
1720         https://bugs.webkit.org/show_bug.cgi?id=115055
1721
1722         Reviewed by Rob Buis.
1723
1724         Internally reviewed by Genevieve Mak.
1725
1726         PR316069
1727         To allow for rich text editors to apply styles on an input field
1728         or highlighted text, we must maintain focus on the current element
1729         when tapping on form elements. Moving the code that clears this
1730         context to trigger off TouchHold instead of TouchPress.
1731
1732         * WebKitSupport/TouchEventHandler.cpp:
1733         (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
1734
1735 == Rolled over to ChangeLog-2013-04-24 ==