2c07a1c5b3f3d2ee5d32ce96eb91bbeb2a6dcf25
[WebKit-https.git] / Source / WebKit / blackberry / ChangeLog
1 2014-01-06  Seokju Kwon  <seokju@webkit.org>
2
3         Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
4         https://bugs.webkit.org/show_bug.cgi?id=126149
5
6         Reviewed by Joseph Pecoraro.
7
8         * WebCoreSupport/InspectorClientBlackBerry.cpp: Remove dead codes.
9         * WebCoreSupport/InspectorClientBlackBerry.h: Ditto.
10
11 2014-01-02  Gavin Barraclough  <barraclough@apple.com>
12
13         Merge didMoveOnscreen / page visibility to isVisible
14         https://bugs.webkit.org/show_bug.cgi?id=126268
15
16         Reviewed by Tim Horton.
17
18         The onscreen state most closely tracks view visibility (though currently
19         also tracks a mix of in-window state). Make more consistent, simplify,
20         and move all animation suspension logic to Page, so it can be controlled
21         by the PageThrottler.
22
23         * Api/WebPage.cpp:
24         (BlackBerry::WebKit::WebPagePrivate::setPageVisibilityState):
25             - setVisibilityState -> setIsVisible.
26
27 2013-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
28
29         Cleanup static_cast<HTMLFormElement*> by using toHTMLFormElement()
30         https://bugs.webkit.org/show_bug.cgi?id=126309
31
32         Reviewed by Andreas Kling.
33
34         To detect bad type casts, it would be good to use toHTMLFormElement() instead of
35         using manual type cast. Additionally FORM_ASSOCIATED_ELEMENT_TYPE_CASTS is introduced newly
36         to do it.
37
38         * WebCoreSupport/CredentialTransformData.cpp:
39         (WebCore::CredentialTransformData::findPasswordFormFields):
40         * WebKitSupport/DOMSupport.cpp:
41         (BlackBerry::WebKit::DOMSupport::toTextControlElement):
42         * WebKitSupport/InputHandler.cpp:
43         (BlackBerry::WebKit::InputHandler::updateFormState):
44         (BlackBerry::WebKit::InputHandler::submitForm):
45
46 2013-12-16  Peter Szanka  <h868064@stud.u-szeged.hu>
47
48         Delete RVCT related code parts.
49         https://bugs.webkit.org/show_bug.cgi?id=125626
50
51         Reviewed by Darin Adler.
52
53         * WebKitSupport/AboutData.cpp:
54         (BlackBerry::WebKit::configPage):
55
56 2013-12-11  Joseph Pecoraro  <pecoraro@apple.com>
57
58         Web Inspector: Push More Inspector Required Classes Down into JavaScriptCore
59         https://bugs.webkit.org/show_bug.cgi?id=125324
60
61         Reviewed by Timothy Hatcher.
62
63         * Api/WebPage.cpp:
64
65 2013-12-03  Nick Diego Yamane  <nick.yamane@openbossa.org>
66
67         Remove some CSS Variables leftovers
68         https://bugs.webkit.org/show_bug.cgi?id=125167
69
70         Reviewed by Darin Adler.
71
72         * WebCoreSupport/AboutDataEnableFeatures.in:
73
74 2013-11-15  Mark Hahnenberg  <mhahnenberg@apple.com>
75
76         Remove VTableSpectrum
77         https://bugs.webkit.org/show_bug.cgi?id=124427
78
79         Reviewed by Filip Pizlo.
80
81         * WebCoreSupport/AboutDataEnableFeatures.in:
82
83 2013-11-07  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
84
85         Changing MediaStreamDescriptor to MediaStreamPrivate
86         https://bugs.webkit.org/show_bug.cgi?id=123935
87
88         Reviewed by Eric Carlson.
89
90         * WebCoreSupport/UserMediaClientImpl.cpp:
91         (WebCore::toMediaStreamPrivate):
92         (WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
93
94 2013-11-01  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
95
96         Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs
97         https://bugs.webkit.org/show_bug.cgi?id=123648
98
99         Reviewed by Eric Carlson.
100
101         * WebCoreSupport/UserMediaClientImpl.cpp:
102         (WebCore::toMediaStreamDescriptor):
103         (WebCore::UserMediaClientImpl::requestUserMedia):
104         * WebCoreSupport/UserMediaClientImpl.h:
105
106 2013-10-31  Joseph Pecoraro  <pecoraro@apple.com>
107
108         Web Inspector: Remove InspectorState
109         https://bugs.webkit.org/show_bug.cgi?id=123547
110
111         Reviewed by Timothy Hatcher.
112
113         * WebCoreSupport/InspectorClientBlackBerry.cpp:
114         * WebCoreSupport/InspectorClientBlackBerry.h:
115
116 2013-10-17  Jacky Jiang  <zhajiang@blackberry.com>
117
118         [BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
119         https://bugs.webkit.org/show_bug.cgi?id=122995
120
121         Reviewed by George Staikos.
122         Internally reviewed by George Staikos and Eli Fidler.
123
124         JIRA 523949
125         Force to respect the viewport when there is viewport meta tag but width
126         is not specified even though the viewport is broken. By doing that, We
127         want to improve the user experience of some websites that use a reasonable
128         initial-scale, but have some overly-wide contents
129
130         The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
131         should be improved by the contents provider eventually.
132
133         * Api/WebPage.cpp:
134         (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
135
136 2013-10-16  Jochen Eisinger  <jochen@chromium.org>
137
138         A page should exit fullscreen mode if it opens a new popup
139         https://bugs.webkit.org/show_bug.cgi?id=122865
140
141         Reviewed by Jer Noble.
142
143         If a fullscreen page opens a popup, the popup would be hidden and
144         therefore invisible to the user. To avoid this, exit fullscreen mode
145         before opening a new window.
146
147         * WebCoreSupport/ChromeClientBlackBerry.cpp:
148         (WebCore::ChromeClientBlackBerry::createWindow):
149
150 2013-10-13  Darin Adler  <darin@apple.com>
151
152         Deprecate or remove deleteAllValues functions; there are only a few call sites left
153         https://bugs.webkit.org/show_bug.cgi?id=122738
154
155         Reviewed by Anders Carlsson.
156
157         * WebKitSupport/InPageSearchManager.cpp:
158         (BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
159         Renamed deleteAllValues to deprecatedDeleteAllValues.
160
161 2013-10-12  Darin Adler  <darin@apple.com>
162
163         Get rid of the toHTMLElement helper for casting FormAssociatedElement to HTMLElement
164         https://bugs.webkit.org/show_bug.cgi?id=122713
165
166         Reviewed by Sam Weinig.
167
168         * WebKitSupport/InputHandler.cpp:
169         (BlackBerry::WebKit::InputHandler::updateFormState): Use asHTMLElement.
170
171 2013-09-30  Sam Weinig  <sam@webkit.org>
172
173         Remove support for DOMFileSystem
174         https://bugs.webkit.org/show_bug.cgi?id=122137
175
176         Reviewed by Anders Carlsson.
177
178         * Api/WebPage.cpp:
179         (BlackBerry::WebKit::WebPagePrivate::init):
180         (BlackBerry::WebKit::WebPage::clearWebFileSystem):
181         * WebCoreSupport/AboutDataEnableFeatures.in:
182
183 2013-09-28  Darin Adler  <darin@apple.com>
184
185         Add Frame::mainFrame and Frame::isMainFrame
186         https://bugs.webkit.org/show_bug.cgi?id=122064
187
188         Reviewed by Andreas Kling.
189
190         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
191         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
192         Call isMainFrame.
193
194 2013-09-26  Darin Adler  <darin@apple.com>
195
196         rename KURL to URL
197         https://bugs.webkit.org/show_bug.cgi?id=16214
198
199         Reviewed by Andreas Kling.
200
201         * many files: Renamed, using script.
202
203 2013-09-25  Brent Fulgham  <bfulgham@apple.com>
204
205         Refactor RuntimeEnabledFeatures as a Singleton.
206         https://bugs.webkit.org/show_bug.cgi?id=121883.
207
208         Reviewed by Jer Noble.
209
210         * WebKitSupport/DumpRenderTreeSupport.cpp:
211         (DumpRenderTreeSupport::setStyleScopedEnabled): use
212         singleton accessor.
213
214 2013-09-23  Jacky Jiang  <zhajiang@blackberry.com>
215
216         [BlackBerry] Poor rendering opening a Google map short link
217         https://bugs.webkit.org/show_bug.cgi?id=121687
218
219         Reviewed by Yong Li.
220         Internally reviewed by Arvid Nilsson.
221
222         Clean up m_isAcceleratedCompositingActive as it has been deprecated.
223
224         * Api/WebPage_p.h:
225
226 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
227
228         Remove support for QXmlStream as the XML parser.
229         https://bugs.webkit.org/show_bug.cgi?id=121229
230
231         Reviewed by Andreas Kling.
232
233         Removed USE flags.
234
235         * WebCoreSupport/AboutDataUseFeatures.in:
236
237 2013-09-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
238
239         Generate more HTML type checks and casting
240         https://bugs.webkit.org/show_bug.cgi?id=121080
241
242         Reviewed by Andreas Kling.
243
244         Clean-up remained functions of HTML elements using auto-generated isFooElement(),
245         and replace toFooElement() with ELEMENT_TYPE_CASTS() macro.
246
247         Besides this patch clean-up unnecessary checks which are being supported by
248         auto-generated isFooElement().
249
250         * Api/WebPage.cpp:
251         (BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
252         (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
253         (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
254         (BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
255         (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
256         (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
257         * WebCoreSupport/ChromeClientBlackBerry.cpp:
258         (WebCore::ChromeClientBlackBerry::supportsFullscreenForNode):
259         * WebCoreSupport/EditorClientBlackBerry.cpp:
260         (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
261         * WebKitSupport/DOMSupport.cpp:
262         (BlackBerry::WebKit::DOMSupport::isElementTypePlugin):
263         * WebKitSupport/InputHandler.cpp:
264         (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
265         (BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
266         * WebKitSupport/SelectionHandler.cpp:
267         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
268
269 2013-09-08  Anders Carlsson  <andersca@apple.com>
270
271         Move WTF::notFound to Vector.h and delete NotFound.h
272         https://bugs.webkit.org/show_bug.cgi?id=120990
273
274         Reviewed by Sam Weinig.
275
276         * Api/BackingStore.cpp:
277
278 2013-09-07  Anders Carlsson  <andersca@apple.com>
279
280         Remove NonCopyableSort.h from WTF
281         https://bugs.webkit.org/show_bug.cgi?id=120984
282
283         Reviewed by Andreas Kling.
284
285         * WebKitSupport/RenderQueue.cpp:
286         (BlackBerry::WebKit::RenderQueue::quickSort):
287
288 2013-09-06  Ryosuke Niwa  <rniwa@webkit.org>
289
290         Range::ownerDocument should return Document&
291         https://bugs.webkit.org/show_bug.cgi?id=120908
292
293         Reviewed by Andreas Kling.
294
295         * WebKitSupport/InPageSearchManager.cpp:
296         (BlackBerry::WebKit::InPageSearchManager::findNextString):
297         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
298         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
299         (BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
300         (BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
301         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
302
303 2013-08-30  Antti Koivisto  <antti@apple.com>
304
305         Remove code behind ENABLE(DIALOG_ELEMENT)
306         https://bugs.webkit.org/show_bug.cgi?id=120467
307
308         Reviewed by Darin Adler.
309
310         * WebCoreSupport/AboutDataEnableFeatures.in:
311
312 2013-08-29  Jacky Jiang  <zhajiang@blackberry.com>
313
314         [BlackBerry] Scrolling text with FCC does not work while composing an email
315         https://bugs.webkit.org/show_bug.cgi?id=120493
316
317         Reviewed by Rob Buis.
318         Internally reviewed by Gen Mak and Konrad Piascik.
319
320         JIRA 468007
321         m_cannotScrollIfHasFloatLayoutSizeRoundingError was true which prevented
322         FCC scrolling.
323         TransformedActualVisibleSize is quite different in email compose card
324         than browser. In this case, the issue was caused by transformedActualVisibleSize(768, 750)
325         which was not the actual visible size of the webkit part of the Cascades
326         view when keyboard popped up. We usually don't do keyboard adaptation for
327         windowless page clients; therefore, there will be no viewport change of
328         WebKit.
329         To fix the bug, we can ignore the windowless page clients.
330
331         * Api/WebPage.cpp:
332         (BlackBerry::WebKit::WebPagePrivate::hasFloatLayoutSizeRoundingError):
333
334 2013-08-27  Jacky Jiang  <zhajiang@blackberry.com>
335
336         [BlackBerry] Rotate device from landscape to portrait during youtube streaming will cause device screen flash with video list page
337         https://bugs.webkit.org/show_bug.cgi?id=120364
338
339         Reviewed by Rob Buis.
340         Internally reviewed by Arvid Nilsson.
341
342         * Api/WebPage.cpp:
343         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
344         (BlackBerry::WebKit::WebPagePrivate::discardLayerVisibilities):
345         (BlackBerry::WebKit::WebPagePrivate::discardFrontVisibilityCompositingThread):
346         * Api/WebPageCompositor.cpp:
347         (BlackBerry::WebKit::WebPageCompositorPrivate::discardFrontVisibility):
348         * Api/WebPageCompositor_p.h:
349         * Api/WebPage_p.h:
350         * WebKitSupport/FrameLayers.cpp:
351         (BlackBerry::WebKit::FrameLayers::discardBackVisibility):
352         * WebKitSupport/FrameLayers.h:
353
354 2013-08-26  Pratik Solanki  <psolanki@apple.com>
355
356         PageGroup::groupSettings() should return a reference
357         https://bugs.webkit.org/show_bug.cgi?id=120319
358
359         Reviewed by Andreas Kling.
360
361         PageGroup::m_groupSettings is never NULL so we can just return a reference from groupSettings().
362
363         * Api/WebPage.cpp:
364         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
365
366 2013-08-24  Darin Adler  <darin@apple.com>
367
368         Frame::tree should return a reference instead of a pointer
369         https://bugs.webkit.org/show_bug.cgi?id=120259
370
371         Reviewed by Andreas Kling.
372
373         * Api/WebPage.cpp:
374         (BlackBerry::WebKit::closeURLRecursively):
375         (BlackBerry::WebKit::enableCrossSiteXHRRecursively):
376         (BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
377         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
378         (WebCore::FrameLoaderClientBlackBerry::createFrame):
379         * WebKitSupport/DOMSupport.cpp:
380         (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
381         (BlackBerry::WebKit::DOMSupport::incrementFrame):
382         Use tree(). instead of tree()->.
383
384 2013-08-20  Pratik Solanki  <psolanki@apple.com>
385
386         <https://webkit.org/b/120029> Document::markers() should return a reference
387
388         Reviewed by Andreas Kling.
389
390         Document::m_markers is never NULL so return a reference from Document::markers(). Also mark
391         m_markers as const and initialize it in member initialization.
392
393         * WebKitSupport/InPageSearchManager.cpp:
394         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
395         (BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
396         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
397         * WebKitSupport/InputHandler.cpp:
398         (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
399         (BlackBerry::WebKit::InputHandler::addAttributedTextMarker):
400         (BlackBerry::WebKit::InputHandler::removeAttributedTextMarker):
401
402 2013-08-19  Pratik Solanki  <psolanki@apple.com>
403
404         <https://webkit.org/b/119918> Frame::selection() should return a reference
405
406         Reviewed by Darin Adler.
407
408         m_selection is never NULL so return a reference from Frame::selection(). Also removed some
409         unnecessary null checks and assert diff ts exposed as a result.
410
411         * Api/InRegionScroller.cpp:
412         (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
413         * WebKitSupport/DatePickerClient.cpp:
414         (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
415         * WebKitSupport/InPageSearchManager.cpp:
416         (BlackBerry::WebKit::InPageSearchManager::findNextString):
417         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
418         * WebKitSupport/InputHandler.cpp:
419         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
420         (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
421         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
422         (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
423         (BlackBerry::WebKit::InputHandler::setElementFocused):
424         (BlackBerry::WebKit::InputHandler::openDatePopup):
425         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
426         (BlackBerry::WebKit::InputHandler::selectionPosition):
427         (BlackBerry::WebKit::InputHandler::setSelection):
428         (BlackBerry::WebKit::InputHandler::deleteSelection):
429         (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
430         * WebKitSupport/SelectionHandler.cpp:
431         (BlackBerry::WebKit::SelectionHandler::cancelSelection):
432         (BlackBerry::WebKit::SelectionHandler::shouldUpdateSelectionOrCaretForPoint):
433         (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
434         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
435         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
436         (BlackBerry::WebKit::SelectionHandler::setSelection):
437         (BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
438         (BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
439         (BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
440         (BlackBerry::WebKit::SelectionHandler::selectObject):
441         (BlackBerry::WebKit::directionOfEnclosingBlock):
442         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
443         (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
444         (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
445         (BlackBerry::WebKit::SelectionHandler::selectionContains):
446         * WebKitSupport/SpellingHandler.cpp:
447         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
448
449 2013-08-16  Pratik Solanki  <psolanki@apple.com>
450
451         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
452
453         Reviewed by Andreas Kling.
454
455         m_script is never NULL so we can just return a reference. Also remove some pointless null
456         checks as a result of doing this.
457
458         * Api/WebPage.cpp:
459         (BlackBerry::WebKit::WebPagePrivate::load):
460         (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
461         (BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
462         (BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
463         (BlackBerry::WebKit::WebPage::globalContext):
464         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
465         (WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
466
467 2013-08-15  Anders Carlsson  <andersca@apple.com>
468
469         <https://webkit.org/b/119859> Frame::loader() should return a reference
470
471         Reviewed by Andreas Kling.
472
473         * Api/WebPage.cpp:
474         (BlackBerry::WebKit::WebPagePrivate::load):
475         (BlackBerry::WebKit::WebPagePrivate::loadString):
476         (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
477         (BlackBerry::WebKit::closeURLRecursively):
478         (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
479         (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
480         (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
481         (BlackBerry::WebKit::WebPage::reload):
482         (BlackBerry::WebKit::WebPage::reloadFromCache):
483         (BlackBerry::WebKit::WebPage::textEncoding):
484         (BlackBerry::WebKit::WebPage::forcedTextEncoding):
485         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
486         (BlackBerry::WebKit::WebPage::title):
487         * WebCoreSupport/ChromeClientBlackBerry.cpp:
488         (WebCore::ChromeClientBlackBerry::createWindow):
489         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
490         (WebCore::FrameLoaderClientBlackBerry::dispatchDidChangeLocationWithinPage):
491         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
492         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
493         (WebCore::FrameLoaderClientBlackBerry::delayPolicyCheckUntilFragmentExists):
494         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
495         (WebCore::FrameLoaderClientBlackBerry::createPlugin):
496         (WebCore::FrameLoaderClientBlackBerry::receivedData):
497         (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
498         (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
499         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
500         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
501         (WebCore::FrameLoaderClientBlackBerry::createFrame):
502         (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
503         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
504         (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
505         (WebCore::FrameLoaderClientBlackBerry::startDownload):
506         (WebCore::FrameLoaderClientBlackBerry::canCachePage):
507         (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
508         * WebKitSupport/PagePopup.cpp:
509         (BlackBerry::WebKit::PagePopup::initialize):
510
511 2013-08-13  Jacky Jiang  <zhajiang@blackberry.com>
512
513         [BlackBerry] WebPage doesn't zoom to fit viewport after being rotated from landscape to portrait mode
514         https://bugs.webkit.org/show_bug.cgi?id=119754
515
516         Reviewed by Rob Buis.
517         Internally reviewed by Konrad Piascik.
518
519         JIRA 470951
520         In this case, zoomToFitWidthScale(currentScale) = viewportWidth / contentsWidth
521         which was 2.6666666666666665, initialScale = ((viewportWidth / devicePixelRatio)
522         / contentsWidth) * devicePixelRatio which was 2.6666665077209473. When
523         rotating the device from landscape to portrait, m_webPage->isAtInitialZoom()
524         was false in setViewportSize() because of the floating-point rounding error
525         above so that we had to use the scale of the previous rotation WebPage
526         which was too large for the current rotation WebPage.
527         Ignore the floating-point rounding error in isAtInitialZoom() so that we
528         can use initialScale of the current rotation WebPage as the scale and also
529         we should do it for isMaxZoomed() and isMinZoomed() as well. Please note
530         that we can not use FLT_EPSILON here as it's 1E-7 on our platform.
531
532         * Api/WebPage.cpp:
533         (BlackBerry::WebKit::WebPagePrivate::initialScale):
534         (BlackBerry::WebKit::WebPage::isMaxZoomed):
535         (BlackBerry::WebKit::WebPage::isMinZoomed):
536         (BlackBerry::WebKit::WebPage::isAtInitialZoom):
537
538 2013-08-09  Jacky Jiang  <zhajiang@blackberry.com>
539
540         [BlackBerry] Viewport allows scrolling when it shouldn't after rotation to landscape
541         https://bugs.webkit.org/show_bug.cgi?id=119595
542
543         Reviewed by Rob Buis.
544         Internally reviewed by Konrad Piascik, Max Feil, Arvid Nilsson and John Griggs.
545
546         JIRA 466384
547         Initial scales of portrait mode and landscape mode can be different due
548         to different viewport size and contents size. In this case, we restored
549         to the intial scale of portrait mode instead of the initial scale of current
550         landscape mode which zoomed in the WebPage a little bit and made the WebPage
551         scallable as the scale is larger than the initial scale of the current
552         landscape mode WebPage.
553         To fix that, we should restore to the current initial scale instead if
554         the WebPage was at initial scale before fullscreen.
555         Meanwhile, move the FIXME comments to the right place.
556
557         * Api/WebPage.cpp:
558         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
559         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
560         (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
561         * Api/WebPage_p.h:
562
563 2013-08-08  Andreas Kling  <akling@apple.com>
564
565         Element: Modernize attribute storage accessor functions.
566         <http://webkit.org/b/119578>
567
568         Reviewed by Antti Koivisto.
569
570         * Api/WebPage.cpp:
571         (BlackBerry::WebKit::WebPagePrivate::webContext):
572
573 2013-08-07  Jacky Jiang  <zhajiang@blackberry.com>
574
575         [BlackBerry] Remove pointless const in InputHandler
576         https://bugs.webkit.org/show_bug.cgi?id=119550
577
578         Reviewed by Rob Buis.
579         Internally reviewed by Leo Yang and Mike Fenton.
580
581         * Api/WebPageClient.h:
582         * WebKitSupport/InputHandler.cpp:
583         (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
584         (BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
585         * WebKitSupport/InputHandler.h:
586
587 2013-08-04  Sam Weinig  <sam@webkit.org>
588
589         Remove support for HTML5 MicroData
590         https://bugs.webkit.org/show_bug.cgi?id=119480
591
592         Reviewed by Anders Carlsson.
593
594         * WebCoreSupport/AboutDataEnableFeatures.in:
595
596 2013-07-27  Mark Rowe  <mrowe@apple.com>
597
598         Logging should be configurable using human-readable channel names rather than crazy bitmasks
599         <http://webkit.org/b/119031>
600
601         Implement shared logic for initializing logging channels based on human-readable channel names in WTF,
602         and rework the WebCore, WebKit and WebKit2 logging initialization on top of it.
603
604         Logging channels may now be enabled by providing a comma-separated list of channel names, with the special
605         "all" name enabling all channels. Channel names prefixed with a leading "-" will result in the named channel
606         being disabled. For instance, specifying "all,-history,-loading" will result in all logging channels except
607         for history and loading being enabled.
608
609         For OS X developers, this also changes the name of the user defaults used to enable logging. This is done to allow
610         the old user defaults to remain set for those people that need to switch between version of WebKit before and
611         after this change. Where the old user default keys were WebCoreLogLevel, WebKitLogLevel and WebKit2LogLevel,
612         the new user default keys are WebCoreLogging, WebKitLogging and WebKit2Logging.
613
614         For GTK developers, this changes the separator used in the WEBKIT_DEBUG environment variable to a comma for
615         consistency with the other platforms and to enable more code sharing.
616
617         While doing this work I've also taken the opportunity to eliminate the need to touch multiple files when
618         adding a new logging channel. Now only the header in the relevant project needs to be updated.
619
620         Reviewed by Sam Weinig.
621
622         * Api/BlackBerryGlobal.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
623
624 2013-07-31  Jacky Jiang  <zhajiang@blackberry.com>
625
626         [BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92
627         https://bugs.webkit.org/show_bug.cgi?id=119365
628
629         Reviewed by Rob Buis.
630         Internally reviewed by Gen Mak and Konrad Piascik.
631
632         JIRA 445423
633         layoutSize (deviceScreenSize/devicePixelRatio) is FloatSize as devicePixelRatio
634         is float. We have to round that to IntSize as ScrollView needs IntSize
635         fixedLayoutSize. Based on conversion result, zoomToFitWidthScale will
636         hardly equal to zoomToFitHeightScale in this case. And unfortunately
637         zoomToFitHeightScale is a little bit greater than zoomToFitWidthScale
638         in this case so that we have to pick up zoomToFitHeightScale which makes
639         the page scollable horizontally.
640         The way to fix that is to define an accurate contentsSize area which
641         potentially has float layoutSize rounding error and can cause upexpected
642         scroll based on the ideal contentsSize area first, and then don't scroll
643         only if the scale is zoomToFitScale as "contentsSize > visibleViewportSize"
644         still works well if the scale is larger than zoomToFitScale.
645
646         * Api/WebPage.cpp:
647         (BlackBerry::WebKit::WebPagePrivate::hasFloatLayoutSizeRoundingError):
648         * Api/WebPage_p.h:
649         * WebKitSupport/WebKitThreadViewportAccessor.cpp:
650         (BlackBerry::WebKit::WebKitThreadViewportAccessor::cannotScrollIfHasFloatLayoutSizeRoundingError):
651         * WebKitSupport/WebKitThreadViewportAccessor.h:
652
653 2013-07-27  Jacky Jiang  <zhajiang@blackberry.com>
654
655         Replace all uses of GraphicsLayer::create function with the one that takes a GraphicsLayerFactory
656         https://bugs.webkit.org/show_bug.cgi?id=119186
657
658         Reviewed by Anders Carlsson.
659
660         Replace GraphicsLayer::create calls and add a new function WebPagePrivate::graphicsLayerFactory().
661
662         * Api/WebOverlay.cpp:
663         (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):
664         * Api/WebPage.cpp:
665         (BlackBerry::WebKit::WebPagePrivate::graphicsLayerFactory):
666         (BlackBerry::WebKit::WebPagePrivate::overlayLayer):
667         * Api/WebPage_p.h:
668         * WebKitSupport/FrameLayers.cpp:
669         (BlackBerry::WebKit::FrameLayers::addLayer):
670         * WebKitSupport/SelectionOverlay.cpp:
671         (BlackBerry::WebKit::SelectionOverlay::draw):
672
673 2013-07-25  Andreas Kling  <akling@apple.com>
674
675         ChromeClient::focusedNodeChanged() should be focusedElementChanged().
676         <http://webkit.org/b/119110>
677
678         Reviewed by Anders Carlsson.
679
680         * WebCoreSupport/ChromeClientBlackBerry.cpp:
681         (WebCore::ChromeClientBlackBerry::focusedElementChanged):
682         * WebCoreSupport/ChromeClientBlackBerry.h:
683
684 2013-07-17  Kangil Han  <kangil.han@samsung.com>
685
686         Use toHTMLMediaElement
687         https://bugs.webkit.org/show_bug.cgi?id=118727
688
689         Reviewed by Ryosuke Niwa.
690
691         To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.
692
693         * Api/WebPage.cpp:
694         (BlackBerry::WebKit::WebPagePrivate::webContext):
695         (BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
696         (BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
697         (BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
698
699 2013-07-16  Kangil Han  <kangil.han@samsung.com>
700
701         Use toHTMLSelectElement and dismiss isHTMLSelectElement
702         https://bugs.webkit.org/show_bug.cgi?id=118714
703
704         Reviewed by Ryosuke Niwa.
705
706         To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
707         Additionally, this patch removes isHTMLSelectElement because not all element subclasses can be checked by a combination of tag names.
708
709         * WebKitSupport/InputHandler.cpp:
710         (BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
711         (BlackBerry::WebKit::InputHandler::setPopupListIndex):
712         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
713
714 2013-07-08  Jacky Jiang  <zhajiang@blackberry.com>
715
716         [BlackBerry] Block Zoom does not zoom in on narrow paragraphs properly
717         https://bugs.webkit.org/show_bug.cgi?id=118472
718
719         Reviewed by Rob Buis.
720         Internally reviewed Arvid Nilsson and Genevieve Mak.
721
722         JIRA 114653
723         For the narrow paragraphs on www.nytimes.com, the first best node for
724         block zoom under the point is deprecated due to the limits of maximum
725         block zoom scale(3) and default maximum WebPage zoom scale(4) and instead
726         it picks up an ancestor node which is wider so that it looks like doesn't
727         zoom in properly.
728         To fix that, enlarge the default maximum WebPage zoom scale slightly
729         and use maximumScale() instead of maxBlockZoomScale() so that we can
730         accept more nodes. And also we'll still clamp the new scale by
731         maxBlockZoomScale() when we block zoom the WebPage, in which way those
732         nodes can be showed in the center of the viewport and surrounded by a
733         few other nodes within the viewport which shows better user experience.
734
735         * Api/WebPage.cpp:
736         (BlackBerry::WebKit::WebPagePrivate::maximumScale):
737         (BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
738
739 2013-07-01  Jochen Eisinger  <jochen@chromium.org>
740
741         Remove support for consumable user gestures
742         https://bugs.webkit.org/show_bug.cgi?id=118247
743
744         Reviewed by Geoffrey Garen.
745
746         * WebKitSupport/NotificationManager.cpp:
747         (BlackBerry::WebKit::NotificationManager::notificationClicked):
748
749 2013-07-01  Kangil Han  <kangil.han@samsung.com>
750
751         Adopt toHTMLTextAreaElement for code cleanup
752         https://bugs.webkit.org/show_bug.cgi?id=118226
753
754         Reviewed by Andreas Kling.
755
756         To enhance readability, this patch adopts toHTMLTextAreaElement.
757         This also helps out to reduce duplicated use of static_cast.
758
759         * Api/WebPage.cpp:
760         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
761         * WebKitSupport/DOMSupport.cpp:
762         (BlackBerry::WebKit::DOMSupport::isTextInputElement):
763         (BlackBerry::WebKit::DOMSupport::inputElementText):
764         * WebKitSupport/InputHandler.cpp:
765         (BlackBerry::WebKit::InputHandler::elementType):
766         (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
767
768 2013-06-29  Kangil Han  <kangil.han@samsung.com>
769
770         Adopt is/toHTMLOptGroupElement for code cleanup
771         https://bugs.webkit.org/show_bug.cgi?id=118213
772
773         Reviewed by Andreas Kling.
774
775         To enhance readability, this patch adopts is/toHTMLOptGroupElement.
776         This also helps out to reduce duplicated use of static_cast.
777
778         * WebKitSupport/InputHandler.cpp:
779         (BlackBerry::WebKit::InputHandler::openSelectPopup):
780
781 2013-06-29  Kangil Han  <kangil.han@samsung.com>
782
783         Adopt is/toHTMLOptionElement for code cleanup
784         https://bugs.webkit.org/show_bug.cgi?id=118212
785
786         Reviewed by Andreas Kling.
787
788         To enhance readability, this patch adopts is/toHTMLOptionElement.
789         This also helps out to reduce duplicated use of static_cast.
790
791         * WebKitSupport/InputHandler.cpp:
792         (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
793         (BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
794         (BlackBerry::WebKit::InputHandler::openSelectPopup):
795         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
796         * WebKitSupport/SelectPopupClient.cpp:
797         (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
798
799 2013-06-28  Kangil Han  <kangil.han@samsung.com>
800
801         Adopt is/toHTMLImageElement for code cleanup
802         https://bugs.webkit.org/show_bug.cgi?id=118182
803
804         Reviewed by Andreas Kling.
805
806         To enhance readability, this patch adopts is/toHTMLImageElement.
807         This also helps out to reduce duplicated use of static_cast.
808
809         * Api/WebPage.cpp:
810         (BlackBerry::WebKit::WebPagePrivate::webContext):
811         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
812         (BlackBerry::WebKit::WebPage::blockZoom):
813         * WebKitSupport/FatFingers.cpp:
814         (BlackBerry::WebKit::FatFingers::isElementClickable):
815
816 2013-06-27  Kangil Han  <kangil.han@samsung.com>
817
818         Adopt is/toHTMLInputElement for code cleanup
819         https://bugs.webkit.org/show_bug.cgi?id=118130
820
821         Reviewed by Antti Koivisto.
822
823         To enhance readability, this patch adopts is/toHTMLInputElement.
824         This also helps out to reduce duplicated use of static_cast.
825
826         * Api/WebPage.cpp:
827         (BlackBerry::WebKit::WebPagePrivate::webContext):
828         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
829         * WebCoreSupport/CredentialTransformData.cpp:
830         (WebCore::CredentialTransformData::findPasswordFormFields):
831         * WebCoreSupport/EditorClientBlackBerry.cpp:
832         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
833         * WebKitSupport/DOMSupport.cpp:
834         (BlackBerry::WebKit::DOMSupport::isPasswordElement):
835         (BlackBerry::WebKit::DOMSupport::inputElementText):
836         (BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
837         (BlackBerry::WebKit::DOMSupport::isColorInputField):
838         (BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesNoAutocomplete):
839         * WebKitSupport/InputHandler.cpp:
840         (BlackBerry::WebKit::InputHandler::elementType):
841         (BlackBerry::WebKit::InputHandler::setInputValue):
842         (BlackBerry::WebKit::InputHandler::extractedTextRequest):
843         (BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
844
845 2013-06-27  Nima Ghanavatian  <nghanavatian@blackberry.com>
846
847         [BlackBerry] We should clear all markers when input changes a word
848         https://bugs.webkit.org/show_bug.cgi?id=118136
849         JIRA115313.
850
851         For the case where a letter is added to the middle of a misspelled word, we were
852         sending incorrect offsets to clear spelling markers. However, since this
853         expanded the current word, it overlaps entirely the previous spelling marker so
854         no issue is found. However, if the keypress is backspace, the incorrect range
855         is smaller, causing an overlap which recreates the marker over the last character.
856         Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking,
857         which will clear all markers regardless of overlap.
858         This patch also sustains spelling markers after the user taps to move the caret onto
859         the word, which is a nice gain as it was asked for previously.
860
861         Reviewed by Rob Buis.
862
863         Internally Reviewed by Mike Fenton
864
865         * WebCoreSupport/EditorClientBlackBerry.cpp:
866         (WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
867
868 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
869
870         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
871         https://bugs.webkit.org/show_bug.cgi?id=117982
872
873         Reviewed by Rob Buis.
874
875         Take custom policy into account when deciding the policy for
876         navigation actions.
877
878         Fixes test fast/loader/onload-policy-ignore-for-frame.html.
879
880         * Api/DumpRenderTreeClient.h:
881         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
882         (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
883         If custom policy is enabled ignore the navigation action when it's
884         not permissive.
885
886 2013-06-26  Kangil Han  <kangil.han@samsung.com>
887
888         Adopt is/toHTMLAreaElement for code cleanup
889         https://bugs.webkit.org/show_bug.cgi?id=117980
890
891         Reviewed by Antonio Gomes.
892
893         To enhance readibility, this patch adopts is/toHTMLAreaElement.
894         This also helps out to reduce duplicated use of static_cast.
895
896         * Api/WebPage.cpp:
897         (BlackBerry::WebKit::WebPagePrivate::webContext):
898         * WebKitSupport/TouchEventHandler.cpp:
899         (BlackBerry::WebKit::elementForTapHighlight):
900
901 2013-06-26  Jacky Jiang  <zhajiang@blackberry.com>
902
903         [BlackBerry] ASSERT(!m_tileMatrixNeedsUpdate) in BackingStorePrivate::render()
904         https://bugs.webkit.org/show_bug.cgi?id=118062
905
906         Reviewed by Rob Buis.
907         Internally reviewed by Jakob Petsovits.
908
909         JIRA426949
910         requestLayoutIfNeeded() can cause zoomAboutPoint() when the layout
911         is finished and make the tile matrix stale. We need requestLayoutIfNeeded()
912         before we updateTileMatrixIfNeeded() so that we can fix the ASSERT and
913         also pass the valid TileIndexList to render().
914
915         * Api/BackingStore.cpp:
916         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
917         (BlackBerry::WebKit::BackingStorePrivate::render):
918
919 2013-06-25  Kangil Han  <kangil.han@samsung.com>
920
921         Adopt is/toHTMLAnchorElement for code cleanup
922         https://bugs.webkit.org/show_bug.cgi?id=117973
923
924         Reviewed by Andreas Kling.
925
926         To enhance readibility, this patch adopts is/toHTMLAnchorElement.
927         This also helps out to reduce duplicated use of static_cast.
928
929         * WebKitSupport/FatFingers.cpp:
930         (BlackBerry::WebKit::FatFingers::isElementClickable):
931
932 2013-06-24  Kangil Han  <kangil.han@samsung.com>
933
934         Adopt is/toHTMLFormElement for code cleanup
935         https://bugs.webkit.org/show_bug.cgi?id=117937
936
937         Reviewed by Andreas Kling.
938
939         This refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152859
940
941         To enhance readibility, this patch adopts is/toHTMLFormElement.
942         This also helps out to reduce duplicated use of static_cast.
943
944         * WebCoreSupport/CredentialManager.cpp:
945         (WebCore::CredentialManager::autofillPasswordForms):
946
947 2013-06-24  Jakob Petsovits  <jpetsovits@blackberry.com>
948
949         [BlackBerry] Only resume root layer commits for visible WebPages
950         https://bugs.webkit.org/show_bug.cgi?id=117956
951         https://jira.bbqnx.net/browse/BRWSR-12047
952         JIRA428381
953
954         Reviewed by George Staikos.
955
956         In r150629, the code from that change introduced to
957         suspend and resume root layer commits would not take into
958         account whether the page is actually visible.
959
960         Because application activation state is usually conveyed
961         to all or any WebPages, this would mean on transitioning
962         into an active application state, we were resuming
963         root layer commits that might have previously been
964         disabled for visibility reasons.
965
966         Fix this by going through a single function that knows
967         by itself whether to suspend or resume root layer commits,
968         so the calling code doesn't have a chance to get it wrong.
969
970         * Api/WebPage.cpp:
971         (BlackBerry::WebKit::WebPage::setVisible):
972         (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
973         (BlackBerry::WebKit::WebPagePrivate::updateRootLayerCommitEnabled):
974         * Api/WebPage_p.h:
975         (WebPagePrivate):
976
977 2013-06-20  Nima Ghanavatian  <nghanavatian@blackberry.com>
978
979         [BlackBerry] Send the correct offsets for misspelled words.
980         https://bugs.webkit.org/show_bug.cgi?id=117846
981
982         JIRA116916.
983         When the caret is placed after a word, the offsets were calculated around
984         the proceeding space. As such, words that end a sentence worked correctly, but
985         midsentence words did not. The 'startOfWord' was calculated for the space ahead
986         and not for the word before it. Now finding the start of the word correctly and
987         calculating the end from there.
988
989         Reviewed by Rob Buis.
990
991         Internally reviewed by Genevieve Mak.
992
993         * WebKitSupport/InputHandler.cpp:
994         (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
995
996 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
999         https://bugs.webkit.org/show_bug.cgi?id=117827
1000
1001         Reviewed by Rob Buis.
1002
1003         Add DumpRenderTreeClient::willSendRequestForFrame() to handle
1004         dispatchWillSendRequest() in DRT.
1005
1006         Fixes tests
1007         fast/loader/onload-willSendRequest-null-for-script.html and
1008         fast/loader/willSendRequest-null-for-preload.html.
1009
1010         * Api/DumpRenderTreeClient.h:
1011         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1012         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
1013
1014 2013-06-19  Jakob Petsovits  <jpetsovits@blackberry.com>
1015
1016         [BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
1017         https://bugs.webkit.org/show_bug.cgi?id=117799
1018         https://jira.bbqnx.net/browse/BRWSR-11712
1019         JIRA413289
1020
1021         Reviewed by Carlos Garcia Campos.
1022
1023         Discovered by Xuefei Ren.
1024
1025         If, in rare cases, renderContents() returns false,
1026         the for() loop in render() will take a tile buffer from
1027         the surface pool but due to aborting the iteration early,
1028         won't put it into the new tile map. In order to prevent
1029         losing the buffer, we need to put it back into the
1030         surface pool before continuing.
1031
1032         * Api/BackingStore.cpp:
1033         (BlackBerry::WebKit::BackingStorePrivate::render):
1034
1035 2013-06-17  Tiancheng Jiang  <tijiang@rim.com>
1036
1037         Cache FatFinger Text Result.
1038         https://bugs.webkit.org/show_bug.cgi?id=107403.
1039
1040         Reviewed by Rob Buis.
1041
1042         Internally Reviewed by Genevieve Mak.
1043         Cache the FatFinger text result for later use in TouchEventHandler.
1044
1045         * Api/WebPage.cpp:
1046         (BlackBerry::WebKit::WebPagePrivate::contextNode):
1047         * WebKitSupport/SelectionHandler.cpp:
1048         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
1049         * WebKitSupport/TouchEventHandler.h:
1050         (BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
1051         (TouchEventHandler):
1052
1053 2013-06-14  Alberto Garcia  <agarcia@igalia.com>
1054
1055         [BlackBerry] Remove implementation of ContextMenu classes
1056         https://bugs.webkit.org/show_bug.cgi?id=114860
1057
1058         Reviewed by Rob Buis.
1059
1060         This code is not being used so we can safely remove it.
1061
1062         * Api/WebPage.cpp:
1063         (BlackBerry::WebKit::WebPagePrivate::init):
1064         * WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
1065         * WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
1066
1067 2013-06-14  Arvid Nilsson  <anilsson@rim.com>
1068
1069         [BlackBerry] LayerTiler fails to tile really big layers
1070         https://bugs.webkit.org/show_bug.cgi?id=117211
1071
1072         Reviewed by Carlos Garcia Campos.
1073
1074         PR 273550
1075
1076         Adapt to changes in LayerCompositingThreadClient interface.
1077
1078         * Api/WebOverlay.cpp:
1079         (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
1080         * Api/WebOverlay_p.h:
1081         (WebOverlayLayerCompositingThreadClient):
1082
1083 2013-06-12  Leo Yang  <leoyang@rim.com>
1084
1085         [BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
1086         https://bugs.webkit.org/show_bug.cgi?id=117553
1087
1088         Reviewed by Carlos Garcia Campos.
1089
1090         In CredentialTransformData we should use RefPtr for
1091         m_userNameElement, m_passwordElement and m_oldPasswordElement
1092         because otherwise the elements could go away when the form
1093         elements get destroyed.
1094
1095         Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().
1096
1097         No functionalities changed no new tests.
1098
1099         * WebCoreSupport/CredentialTransformData.cpp:
1100         (WebCore::CredentialTransformData::findPasswordFormFields):
1101         (WebCore::CredentialTransformData::locateSpecificPasswords):
1102         * WebCoreSupport/CredentialTransformData.h:
1103
1104 2013-06-12  Alberto Garcia  <agarcia@igalia.com>
1105
1106         [BlackBerry] Remove dead WebDOM code
1107         https://bugs.webkit.org/show_bug.cgi?id=113370
1108
1109         Reviewed by Anders Carlsson.
1110
1111         BlackBerry PR 347565
1112         Internally reviewed by Charles Wei.
1113
1114         * Api/WebPage.cpp:
1115         * Api/WebPage.h:
1116         * WebCoreSupport/AboutDataEnableFeatures.in:
1117         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1118
1119 2013-06-12  Jakob Petsovits  <jpetsovits@blackberry.com>
1120
1121         [BlackBerry] Smarter algorithm to determine the backingstore rect
1122         https://bugs.webkit.org/show_bug.cgi?id=117451
1123
1124         JIRA115644
1125         https://jira.bbqnx.net/browse/BRWSR-7028
1126
1127         Reviewed by Rob Buis.
1128
1129         So far, the backingstore tile geometry allocation was
1130         pretty straightforward: We would start off from the
1131         current viewport and append all available tiles into
1132         the current scrolling direction from there.
1133
1134         This will usually work well enough, but has the downside
1135         of discarding all the tiles in the opposite direction.
1136         Also, tiles very close to the viewport will often get
1137         discarded even if the user only scrolls very slowly.
1138
1139         This patch completely revamps the algorithm for
1140         determining where the backingstore should be positioned.
1141
1142         The general idea is that we construct a "desired rect"
1143         based on the viewport and inflate it into all four
1144         directions according to the current scroll momentum.
1145         This rectangle will be similarly large as a backingstore
1146         tile geometry rectangle might be, by using the
1147         approximate number of pixels that are available in the
1148         given number of tiles.
1149
1150         The proportions for extending the rectangle from the
1151         viewport are influenced by different factors, including
1152         scroll momentum, viewport ratio, available space in the
1153         overall contents rectangle, and natural bias for the
1154         "down" direction.
1155
1156         In practice, this results in a backingstore that is
1157         roughly evenly distributed around the viewport when no
1158         movement is happening, and will gradually narrow down
1159         and extend into the scroll direction at a higher momentum.
1160
1161         The final tile geometry is constructed by trying fit
1162         the tiles into the desired rect in a way that maximizes
1163         the area of its intersection. There are a few parameters
1164         that can be tweaked, the ones in this patch seem to
1165         handle most cases well enough to minimize checkerboarding.
1166
1167         As an additional bonus, a rectangle-based tiling strategy
1168         can more easily be adopted for accelerated compositing,
1169         which currently operates on a simpler algorithm that also
1170         inflates the viewport but does not take scrolling into
1171         account.
1172
1173         * Api/BackingStore.cpp:
1174         (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
1175         (BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
1176         (WebKit):
1177         (BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
1178         (BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
1179         (BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
1180         (BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
1181         (BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
1182         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
1183         (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
1184         * Api/BackingStore_p.h:
1185         (BackingStorePrivate):
1186
1187 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
1188
1189         Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
1190         https://bugs.webkit.org/show_bug.cgi?id=117512
1191
1192         Reviewed by Darin Adler.
1193
1194         * Api/WebPage.cpp:
1195         (BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
1196
1197 2013-06-06  Genevieve Mak  <gmak@rim.com>
1198
1199         [BlackBerry] Crash in InRegionScrollerPrivate::clearDocumentData
1200         https://bugs.webkit.org/show_bug.cgi?id=117317
1201
1202         Reviewed by Rob Buis.
1203
1204         PR #348994
1205         Need to check the scrollableArea instead of asserting because in this case for the
1206         selection subframe it is allowed to be null.
1207
1208         * Api/InRegionScroller.cpp:
1209         (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
1210
1211 2013-06-05  Bear Travis  <betravis@adobe.com>
1212
1213         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
1214         https://bugs.webkit.org/show_bug.cgi?id=117172
1215
1216         Reviewed by Alexandru Chiculita.
1217
1218         Adding the CSS_SHAPES compile flag.
1219
1220         * WebCoreSupport/AboutDataEnableFeatures.in:
1221
1222 2013-06-05  Genevieve Mak  <gmak@rim.com>
1223
1224         [BlackBerry] Deleting the pendingSelectionCandidate on the wrong thread causes an assert.
1225         https://bugs.webkit.org/show_bug.cgi?id=117276
1226
1227         Reviewed by Rob Buis.
1228
1229         Reviewed Internally by Nima Ghanavatian.
1230         PR #342399
1231         Store and delete the selectionScrollView in webkit which is what we already do for
1232         scrolling subframes.
1233
1234         * Api/InRegionScroller.cpp:
1235         (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate):
1236         (BlackBerry::WebKit::InRegionScrollerPrivate::resetSelectionScrollView):
1237         (WebKit):
1238         (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData):
1239         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
1240         (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
1241         (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
1242         * Api/InRegionScroller_p.h:
1243         (InRegionScrollerPrivate):
1244
1245 2013-06-05  Tiancheng Jiang  <tijiang@rim.com>
1246
1247         [BlackBerry] Make image clickable when it has anchor as parent node.
1248         https://bugs.webkit.org/show_bug.cgi?id=117271
1249
1250         Reviewed by Rob Buis.
1251
1252         BlackBerry PR 345995
1253         Internally Reviewed by Genevieve Mak.
1254         * WebKitSupport/FatFingers.cpp:
1255         (BlackBerry::WebKit::FatFingers::isElementClickable):
1256
1257 2013-06-05  Mike Fenton  <mifenton@rim.com>
1258
1259         [BlackBerry] Selection handles are inverted on directional selections
1260         https://bugs.webkit.org/show_bug.cgi?id=117269
1261
1262         Reviewed by Rob Buis.
1263
1264         PR 336178
1265
1266         Don't invert the handles leave them in the visual order.
1267
1268         Internally Reviewed by Nima Ghanavatian.
1269
1270         * WebKitSupport/SelectionHandler.cpp:
1271         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1272
1273 2013-06-03  Andrew Lo  <anlo@rim.com>
1274
1275         [BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
1276         https://bugs.webkit.org/show_bug.cgi?id=117167
1277
1278         Reviewed by Rob Buis.
1279         Internally reviewed by Arvid Nilsson.
1280
1281         Add WebKit::WebPage API for setting whether to show accelerated compositing
1282         debug borders.
1283
1284         * Api/WebPage.cpp:
1285         (BlackBerry::WebKit::WebPage::setShowDebugBorders):
1286         (WebKit):
1287         * Api/WebPage.h:
1288
1289 2013-06-03  Mike Fenton  <mifenton@rim.com>
1290
1291         [BlackBerry] Selection handles are not cleared when displaying error pages.
1292         https://bugs.webkit.org/show_bug.cgi?id=117158
1293
1294         Reviewed by Carlos Garcia Campos.
1295
1296         PR 342159.
1297
1298         Add explicit cancel of selection state when loading an error page
1299         as it is not always cleared.
1300
1301         Internally Reviewed by Nima Ghanavatian.
1302
1303         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1304         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
1305
1306 2013-06-03  Mike Fenton  <mifenton@rim.com>
1307
1308         [BlackBerry] ROI details are not always cleared when using back navigation.
1309         https://bugs.webkit.org/show_bug.cgi?id=117159
1310
1311         Reviewed by Carlos Garcia Campos.
1312
1313         PR 328557.
1314
1315         Secondary change to ensure when restoreViewState is triggered
1316         ROI is reset.
1317
1318         Internally Reviewed by Nima Ghanavatian.
1319
1320         * WebKitSupport/InputHandler.cpp:
1321         (BlackBerry::WebKit::InputHandler::restoreViewState):
1322
1323 2013-05-29  Otto Derek Cheung  <otcheung@rim.com>
1324
1325         [BlackBerry] Add more cellular technologies into the NetworkInfo enum
1326         https://bugs.webkit.org/show_bug.cgi?id=116982
1327
1328         PR 340189
1329         Reviewed by Rob Buis.
1330
1331         Provide more specific bandwidth speeds on different network
1332         services our devices provide.
1333
1334         * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
1335         (WebCore):
1336         (WebCore::NetworkInfoClientBlackBerry::bandwidth):
1337
1338 2013-05-29  Yong Li  <yoli@rim.com>
1339
1340         [BlackBerry] about:memory should use malloc_stats instead of mallinfo
1341         https://bugs.webkit.org/show_bug.cgi?id=96420
1342
1343         Reviewed by Rob Buis.
1344
1345         PR 206297
1346         Use mallopt to get malloc_stats.
1347
1348         * WebKitSupport/AboutData.cpp:
1349         (BlackBerry::WebKit::mallocStats):
1350         (BlackBerry::WebKit::memoryPage):
1351         (BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
1352
1353 2013-05-29  Nima Ghanavatian  <nghanavatian@blackberry.com>
1354
1355         [BlackBerry] Notify client of selection deletion
1356         https://bugs.webkit.org/show_bug.cgi?id=116843
1357
1358         Reviewed by Rob Buis.
1359
1360         Internally reviewed by Mike Fenton.
1361
1362         PR342106
1363         Our change guard was preventing caret change notification to be sent to IMF.
1364         This put us out of state when a selection was deleted because it is not a simple
1365         single character deletion. Ensure that selection deletions always send a caret
1366         update.
1367
1368         * WebKitSupport/InputHandler.cpp:
1369         (BlackBerry::WebKit::InputHandler::deleteSelection):
1370         (BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
1371         (BlackBerry::WebKit::InputHandler::deleteText):
1372
1373 2013-05-29  Rob Buis  <rbuis@rim.com>
1374
1375         [BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
1376         https://bugs.webkit.org/show_bug.cgi?id=116954
1377
1378         Reviewed by Carlos Garcia Campos.
1379
1380         PR 206152
1381         Internally reviewed by Konrad Piascik
1382
1383         * WebKitSupport/AboutData.cpp:
1384         (BlackBerry::WebKit::configPage):
1385         (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
1386         (BlackBerry::WebKit::mallocStats):
1387         (BlackBerry::WebKit::memoryPage):
1388         (BlackBerry::WebKit::memoryPeaksToHtmlTable):
1389         (BlackBerry::WebKit::memoryLivePage):
1390
1391 2013-05-29  Jakob Petsovits  <jpetsovits@blackberry.com>
1392
1393         [BlackBerry] Use lazily-backed backingstore tiles
1394         https://bugs.webkit.org/show_bug.cgi?id=116879
1395         Internal PR 344523
1396
1397         Reviewed by Carlos Garcia Campos.
1398         Informally reviewed by Arvid Nilsson and Mike Lattanzio.
1399
1400         As a consequence, also don't use fixed-size
1401         shared pixmap buffers for these tiles anymore.
1402
1403         * WebKitSupport/AboutData.cpp:
1404         (BlackBerry::WebKit::configPage):
1405         * WebKitSupport/BackingStoreTile.cpp:
1406         (BlackBerry::WebKit::TileBuffer::nativeBuffer):
1407         * WebKitSupport/SurfacePool.cpp:
1408         (BlackBerry::WebKit::SurfacePool::initialize):
1409         * WebKitSupport/SurfacePool.h:
1410         (SurfacePool):
1411
1412 2013-05-29  Kent Tamura  <tkent@chromium.org>
1413
1414         Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
1415         https://bugs.webkit.org/show_bug.cgi?id=116796
1416
1417         Reviewed by Ryosuke Niwa.
1418
1419         * WebCoreSupport/AboutDataEnableFeatures.in:
1420
1421 2013-05-28  Arvid Nilsson  <anilsson@rim.com>
1422
1423         [BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
1424         https://bugs.webkit.org/show_bug.cgi?id=116604
1425
1426         Reviewed by Carlos Garcia Campos.
1427
1428         Adapt to the removal of "get" prefix from getters in the WebKit- and
1429         compositing-thread layer classes.
1430
1431         * Api/WebOverlay.cpp:
1432         (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
1433         * Api/WebPageCompositor.cpp:
1434         (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
1435         (BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
1436         (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
1437
1438 2013-05-28  Andreas Kling  <akling@apple.com>
1439
1440         Document::setFocusedNode() should be setFocusedElement().
1441         <http://webkit.org/b/116857>
1442
1443         Reviewed by Antti Koivisto.
1444
1445         * Api/WebPage.cpp:
1446         (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
1447         (BlackBerry::WebKit::WebPagePrivate::contextNode):
1448         (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
1449         (BlackBerry::WebKit::WebPage::setNodeFocus):
1450         * WebCoreSupport/EditorClientBlackBerry.cpp:
1451         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
1452         (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
1453         * WebKitSupport/InputHandler.cpp:
1454         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
1455         * WebKitSupport/SelectionHandler.cpp:
1456         (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
1457         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
1458         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
1459         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
1460         (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
1461         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
1462
1463 2013-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1464
1465         Unreviewed. Fix BlackBerry debug build after r150756.
1466
1467         * WebKitSupport/PagePopup.cpp:
1468         (BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
1469         assert.
1470
1471 2013-05-27  Nima Ghanavatian  <nghanavatian@blackberry.com>
1472
1473         [BlackBerry] Clear supression flag when caret changes aren't propogated through
1474         https://bugs.webkit.org/show_bug.cgi?id=116840
1475
1476         Reviewed by Rob Buis.
1477
1478         Internally reviewed by Mike Fenton.
1479
1480         PR339965
1481         We set and clear the flag upon every use. This leaves us vulnerable if
1482         1. midway through processing the selection change event is dismissed and
1483         2. we don't receive a TouchRelease event
1484         One example of this is while dragging the FCC handle we start typing. To
1485         safeguard against this, if the process change guard is set during a
1486         selection change event, we send out to clear the flag status before returning.
1487
1488         * Api/WebPageClient.h:
1489         * WebKitSupport/InputHandler.cpp:
1490         (BlackBerry::WebKit::InputHandler::selectionChanged):
1491
1492 2013-05-27  Andy Chen  <andchen@blackberry.com>
1493
1494         [BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
1495         https://bugs.webkit.org/show_bug.cgi?id=116837
1496
1497         Reviewed by Rob Buis.
1498
1499         PR 291903
1500         Internally reviewed by Mike Fenton.
1501
1502         * Api/WebPage.cpp:
1503         (BlackBerry::WebKit::WebPage::findNextString):
1504         * Api/WebPage.h:
1505         * WebKitSupport/InPageSearchManager.cpp:
1506         (BlackBerry::WebKit::InPageSearchManager::findNextString):
1507         (BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
1508         * WebKitSupport/InPageSearchManager.h:
1509         (InPageSearchManager):
1510
1511 2013-05-27  Eli Fidler  <efidler@rim.com>
1512
1513         [BlackBerry] Fix subframe target added to new requests
1514         https://bugs.webkit.org/show_bug.cgi?id=116602
1515
1516         Reviewed by Rob Buis.
1517
1518         In some cases we might be adding TargetIsMainFrame to a subframe
1519         request causing an isMainFrame assert.
1520
1521         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1522         (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
1523         Check we are actually loading the main frame before setting
1524         ResourceRequest::TargetIsMainFrame target.
1525
1526 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1527
1528         [BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
1529         https://bugs.webkit.org/show_bug.cgi?id=116724
1530
1531         Reviewed by Rob Buis.
1532
1533         Add another bool variable m_previousFrameDone to make sure we
1534         don't start a new frame until the previous one has been done. Also
1535         make sure we pass the animation start time to
1536         serviceScriptedAnimations().
1537
1538         * Api/WebPage.cpp:
1539         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
1540         m_previousFrameDone and m_monotonicAnimationStartTime.
1541         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
1542         Return early if previous frame is not done. Otherwise set
1543         m_previousFrameDone to false and save the animation start time.
1544         (BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
1545         serviceScriptedAnimations() passing the saved animation start time
1546         and reset m_animationScheduled and m_previousFrameDone.
1547         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
1548         Call WebPagePrivate::serviceAnimations().
1549         * Api/WebPage_p.h:
1550         (WebPagePrivate):
1551
1552 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1553
1554         [BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
1555         https://bugs.webkit.org/show_bug.cgi?id=116598
1556
1557         Reviewed by Rob Buis.
1558
1559         It's no longer needed since the encoder now checks the override encoding.
1560
1561         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1562         (WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
1563         receivedData() passing the DocumentLoader instead of the text
1564         encoding.
1565         (WebCore::FrameLoaderClientBlackBerry::receivedData): Call
1566         DocumentLoader::commitData() directly.
1567         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
1568         (FrameLoaderClientBlackBerry):
1569
1570 2013-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         [BlackBerry] Move PagePopup implementation to WebKitSupport
1573         https://bugs.webkit.org/show_bug.cgi?id=116824
1574
1575         Reviewed by Rob Buis.
1576
1577         After r150434 PagePopup implementation in BlackBerry port is
1578         independent from WebCore. The classes are now in the
1579         BlackBerry::WebKit namespace so they can be moved from
1580         WebCoresupport to WebKitSupport and renamed to remove the
1581         BlackBerry suffix which is now redundant. Also, now that the
1582         implementation is not shared, it can be simplified a bit more.
1583
1584         * Api/WebPage.cpp:
1585         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
1586         API changes.
1587         (BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
1588         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
1589         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
1590         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
1591         * Api/WebPage.h:
1592         (WebKit): Ditto.
1593         * Api/WebPage_p.h:
1594         (WebKit): Ditto.
1595         (WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
1596         can also point to a color picker or date picker page popup. Also
1597         use RefPtr instead of raw pointer.
1598         * WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
1599         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
1600         (BlackBerry::WebKit::ColorPickerClient::generateHTML):
1601         (BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
1602         Return early if popup has been closed already.
1603         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
1604         * WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
1605         * WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
1606         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
1607         (BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
1608         (BlackBerry::WebKit::DatePickerClient::generateHTML):
1609         (BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
1610         Return early if popup has been closed already.
1611         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
1612         (BlackBerry::WebKit::DatePickerClient::generateDateLabels):
1613         * WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
1614         * WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
1615         (BlackBerry::WebKit::PagePopup::PagePopup):
1616         (BlackBerry::WebKit::PagePopup::~PagePopup):
1617         (BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
1618         and made void, since it always returned true and the callers
1619         ignored the return value.
1620         (BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
1621         generateHTML for consistency with PagePopupClient::writeDocument()
1622         and to avoid confusion with generateHTML method in the clients
1623         that create the HTML contents but they don't write the document.
1624         (BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
1625         Make it static member of PagePopup since the JS object now holds a
1626         reference of PagePopup instance as private data.
1627         (BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
1628         of the PagePopup instance saved as private data of the JS object.
1629         (BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
1630         instance saved as private data of the JS object.
1631         (BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
1632         saving the client as private data of the JS object using a wrapper
1633         refcounted object, save the PagePopup instance that is now
1634         refcounted and access the client from the PagePopup instance in
1635         the callback.
1636         (BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
1637         since PagePopup::closePagePopup was a bit redundant.
1638         * WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
1639         (BlackBerry::WebKit::PagePopup::create): Static member to create
1640         instances of PagePopup now that it's refcounted.
1641         * WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
1642         (BlackBerry::WebKit::PagePopupClient::PagePopupClient):
1643         (BlackBerry::WebKit::PagePopupClient::closePopup):
1644         (BlackBerry::WebKit::PagePopupClient::didClosePopup):
1645         (BlackBerry::WebKit::PagePopupClient::contentSize):
1646         (BlackBerry::WebKit::PagePopupClient::writeDocument):
1647         * WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
1648         * WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
1649         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
1650         (BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
1651         (BlackBerry::WebKit::SelectPopupClient::generateHTML):
1652         (BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
1653         Return early if popup has been closed already.
1654         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
1655         (BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
1656         * WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
1657
1658 2013-05-26  Jakob Petsovits  <jpetsovits@blackberry.com>
1659
1660         [BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
1661         https://bugs.webkit.org/show_bug.cgi?id=116539
1662         Internal PR 330917
1663
1664         Reviewed by Carlos Garcia Campos.
1665         Internally reviewed by Xiaobo Wang and Arvid Nilsson.
1666
1667         This reduces complexity by relying on the current state,
1668         rather than the suspend counter, which in turn makes it
1669         possible to simplify the code in setCompositor().
1670
1671         * Api/BackingStore.cpp:
1672         (BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
1673         (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
1674         * Api/WebPage.cpp:
1675         (BlackBerry::WebKit::WebPagePrivate::setCompositor):
1676
1677 2013-05-26  Kent Tamura  <tkent@chromium.org>
1678
1679         Remove ENABLE_CALENDAR_PICKER
1680         https://bugs.webkit.org/show_bug.cgi?id=116795
1681
1682         Reviewed by Ryosuke Niwa.
1683
1684         * WebCoreSupport/AboutDataEnableFeatures.in:
1685         The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
1686
1687 2013-05-26  Andreas Kling  <akling@apple.com>
1688
1689         FocusController::setFocusedNode() should be setFocusedElement().
1690         <http://webkit.org/b/116780>
1691
1692         Reviewed by Antti Koivisto.
1693
1694         * Api/WebPage.cpp:
1695         (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
1696         (BlackBerry::WebKit::WebPage::setNodeFocus):
1697         * WebKitSupport/SelectionHandler.cpp:
1698         (BlackBerry::WebKit::SelectionHandler::selectObject):
1699
1700 2013-05-24  Anders Carlsson  <andersca@apple.com>
1701
1702         Remove PagePopup code
1703         https://bugs.webkit.org/show_bug.cgi?id=116732
1704
1705         Reviewed by Andreas Kling.
1706
1707         * WebCoreSupport/AboutDataEnableFeatures.in:
1708         Remove PAGE_POPUP.
1709
1710 2013-05-24  Mike Fenton  <mifenton@rim.com>
1711
1712         [BlackBerry] Fix bad type warning in InputHandler log.
1713         https://bugs.webkit.org/show_bug.cgi?id=116720
1714
1715         Reviewed by Carlos Garcia Campos.
1716
1717         Fix warning in inputLog string.
1718
1719         * WebKitSupport/InputHandler.cpp:
1720         (BlackBerry::WebKit::InputHandler::handleKeyboardInput):
1721
1722 2013-05-24  Mike Fenton  <mifenton@rim.com>
1723
1724         [BlackBerry] Respect tabindex when using form controls.
1725         https://bugs.webkit.org/show_bug.cgi?id=116676
1726
1727         Reviewed by Xan Lopez.
1728
1729         PR 337419.
1730
1731         Update form control navigation tracking to take tabindex
1732         order into account when calculating next and previous nodes.
1733
1734         The order to follow is tab index 1 - N, followed by all items
1735         without a tab index or tab index 0 in rendering order to match
1736         with standard desktop behavior.
1737
1738         Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
1739
1740         * WebKitSupport/InputHandler.cpp:
1741         (BlackBerry::WebKit::InputHandler::updateFormState):
1742
1743 2013-05-24  Jeff Rogers  <jrogers@rim.com>
1744
1745         [BlackBerry] Remove SKIA leftovers from WebPage.cpp
1746         https://bugs.webkit.org/show_bug.cgi?id=116656
1747
1748         Reviewed by Rob Buis.
1749
1750         * Api/WebPage.cpp:
1751         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
1752
1753 2013-05-23  Xiaobo Wang  <xiaobwang@blackberry.com>
1754
1755         [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
1756         https://bugs.webkit.org/show_bug.cgi?id=115245
1757
1758         Reviewed by Rob Buis.
1759
1760         PR 330917.
1761         Internally reviewed by Arvid Nilsson.
1762
1763         1. Suspend/resumeRootLayerCommit when notified app activation state
1764         change.
1765         2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
1766         start root layer commit timer, so that there's a commit even if
1767         BackingStore got disabled/removed.
1768
1769         * Api/WebPage.cpp:
1770         (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
1771         (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
1772
1773 2013-05-23  Andy Chen  <andchen@blackberry.com>
1774
1775         [BlackBerry] Need to forward the opener frame url to client when creating a new window
1776         https://bugs.webkit.org/show_bug.cgi?id=116566
1777
1778         Reviewed by Rob Buis.
1779
1780         PR 337935
1781         Internally reviewed by Arvid Nilsson.
1782         When creating a new window, forward the opener frame url to client.
1783
1784         * Api/WebPageClient.h:
1785         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1786         (WebCore::ChromeClientBlackBerry::createWindow):
1787         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1788         (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
1789
1790 2013-05-23  Jakob Petsovits  <jpetsovits@blackberry.com>
1791
1792         [BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
1793         https://bugs.webkit.org/show_bug.cgi?id=116545
1794         Internal PR 189775
1795
1796         Reviewed by Rob Buis.
1797
1798         Also change the name of the "documentContents" parameter
1799         to the more descriptive "documentSrcRect".
1800
1801         * Api/WebPageCompositor.cpp:
1802         (BlackBerry::WebKit::WebPageCompositorPrivate::render):
1803         (BlackBerry::WebKit::WebPageCompositor::render):
1804         * Api/WebPageCompositor.h:
1805         * Api/WebPageCompositor_p.h:
1806         (WebPageCompositorPrivate):
1807
1808 2013-05-23  Ed Baker  <edbaker@blackberry.com>
1809
1810         [BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
1811         https://bugs.webkit.org/show_bug.cgi?id=116627
1812
1813         Reviewed by Xan Lopez.
1814
1815         PR #341084
1816
1817         If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
1818
1819         Internally Reviewed by Gen Mak.
1820
1821         * Api/WebPage.cpp:
1822         (BlackBerry::WebKit::WebPagePrivate::webContext):
1823
1824 2013-05-23  Mike Fenton  <mifenton@rim.com>
1825
1826         [BlackBerry] Validate form data before doing direct submission.
1827         https://bugs.webkit.org/show_bug.cgi?id=116674
1828
1829         Reviewed by Xan Lopez.
1830
1831         PR 314202.
1832
1833         Check validation of the input form before triggering direct submission.
1834
1835         Internally Reviewed by Nima Ghanavatian.
1836
1837         * WebKitSupport/InputHandler.cpp:
1838         (BlackBerry::WebKit::InputHandler::submitForm):
1839
1840 2013-05-23  Rob Buis  <rbuis@rim.com>
1841
1842         [BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
1843         https://bugs.webkit.org/show_bug.cgi?id=116603
1844
1845         Reviewed by Xan Lopez.
1846
1847         PR 119789
1848         Internally reviewed by Yong Li.
1849
1850         Provide a domain value for this ResourceError instance. Note that
1851         this does not change behavior.
1852
1853         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1854         (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
1855
1856 2013-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1857
1858         [BlackBerry] Make PagePopup implementation independent from WebCore
1859         https://bugs.webkit.org/show_bug.cgi?id=116448
1860
1861         Reviewed by Anders Carlsson.
1862
1863         Add our own implementation of PagePopupClient and make all the
1864         pickers inherit from it. Unused methods have been removed and
1865         common implementation have been moved from the pickers to the
1866         parent class.
1867
1868         * Api/WebPage.cpp:
1869         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
1870         popup if there's one active.
1871         (BlackBerry::WebKit::WebPagePrivate::setVisible): Call
1872         closePagePopup() directly.
1873         (BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
1874         PagePopupBlackBerry for the given client.
1875         (BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
1876         active popup if there's one.
1877         (BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
1878         whether there's an active popup.
1879         * Api/WebPage.h:
1880         * Api/WebPage_p.h:
1881         * WebCoreSupport/ChromeClientBlackBerry.cpp:
1882         (WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
1883         closePagePopup() call since this is now handled by
1884         WebPagePrivate.
1885         (WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
1886         WebPagePrivate::hasOpenedPopup().
1887         * WebCoreSupport/ChromeClientBlackBerry.h:
1888         (ChromeClientBlackBerry):
1889         * WebCoreSupport/ColorPickerClient.cpp:
1890         (BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
1891         (BlackBerry::WebKit::ColorPickerClient::didClosePopup):
1892         * WebCoreSupport/ColorPickerClient.h:
1893         (ColorPickerClient):
1894         * WebCoreSupport/DatePickerClient.cpp:
1895         (BlackBerry::WebKit::DatePickerClient::DatePickerClient):
1896         (BlackBerry::WebKit::DatePickerClient::didClosePopup):
1897         * WebCoreSupport/DatePickerClient.h:
1898         (DatePickerClient):
1899         * WebCoreSupport/PagePopupBlackBerry.cpp:
1900         (BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
1901         (BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
1902         * WebCoreSupport/PagePopupBlackBerry.h:
1903         (PagePopupBlackBerry):
1904         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
1905         (BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
1906         (SharedClientPointer):
1907         * WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
1908         (BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
1909         (BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
1910         (BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
1911         (BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
1912         (BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
1913         * WebCoreSupport/PagePopupBlackBerryClient.h: Added.
1914         (PagePopupBlackBerryClient):
1915         (BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
1916         * WebCoreSupport/SelectPopupClient.cpp:
1917         (BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
1918         (BlackBerry::WebKit::SelectPopupClient::didClosePopup):
1919         * WebCoreSupport/SelectPopupClient.h:
1920         (SelectPopupClient):
1921         * WebKitSupport/InputHandler.cpp:
1922         (BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
1923         closePagePopup() since this is already done by openPagePopup() and
1924         use openPagePopup() from WebPagePrivate directly.
1925         (BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
1926         (BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
1927
1928 2013-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1929
1930         [BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
1931         https://bugs.webkit.org/show_bug.cgi?id=116302
1932
1933         Reviewed by Rob Buis.
1934
1935         TiledImage is now the NativeImage of the BlackBerry port.
1936
1937         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
1938         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
1939
1940 2013-05-19  Anders Carlsson  <andersca@apple.com>
1941
1942         Remove link prerendering code
1943         https://bugs.webkit.org/show_bug.cgi?id=116415
1944
1945         Reviewed by Darin Adler.
1946
1947         This code was only used by Chromium and is dead now.
1948
1949         * WebCoreSupport/AboutDataEnableFeatures.in:
1950
1951 2013-05-19  Anders Carlsson  <andersca@apple.com>
1952
1953         Remove ChromeClient::webView()
1954         https://bugs.webkit.org/show_bug.cgi?id=116054
1955
1956         Reviewed by Andreas Kling.
1957
1958         This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
1959
1960         * WebCoreSupport/ChromeClientBlackBerry.h:
1961         (ChromeClientBlackBerry):
1962
1963 2013-05-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1964
1965         [BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
1966         https://bugs.webkit.org/show_bug.cgi?id=116305
1967
1968         Reviewed by Rob Buis.
1969
1970         PR 340537.
1971         Internally reviewed by Arvid Nilsson.
1972
1973         Use updateLayoutAndStyleIfNeededRecursive() instead of
1974         layoutIfNeeded() since we are about to draw in
1975         rootLayerCommitTimerFired().
1976
1977         * Api/WebPage.cpp:
1978         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
1979
1980 2013-05-17  Mike Fenton  <mifenton@rim.com>
1981
1982         [BlackBerry] Remove stale comment for select mouse handling.
1983         https://bugs.webkit.org/show_bug.cgi?id=116309
1984
1985         Reviewed by Rob Buis.
1986
1987         PR 135935.
1988
1989         Remove a FIXME that has been invalidated by a change
1990         to our touch -> mouse model.
1991
1992         Internally Rubberstamped by Genevieve Mak.
1993
1994         * Api/WebPage.cpp:
1995         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
1996
1997 2013-05-17  Alberto Garcia  <agarcia@igalia.com>
1998
1999         [BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
2000         https://bugs.webkit.org/show_bug.cgi?id=116298
2001
2002         Reviewed by Carlos Garcia Campos.
2003
2004         Pass the correct parameter to toDeviceOrientationClientMock()
2005
2006         * WebKitSupport/DumpRenderTreeSupport.cpp:
2007         (DumpRenderTreeSupport::setMockDeviceOrientation):
2008
2009 2013-05-16  Mike Fenton  <mifenton@rim.com>
2010
2011         [BlackBerry] Optimize caret bounds calculation when leaving an input field.
2012         https://bugs.webkit.org/show_bug.cgi?id=116224
2013
2014         Reviewed by Rob Buis.
2015
2016         PR 340132.
2017
2018         If the caret is no longer active in the field, do not allow it
2019         to go into the single line input logic and calculate the node
2020         bounding box.
2021
2022         Internally Reviewed By Gen Mak
2023
2024         * WebKitSupport/SelectionHandler.cpp:
2025         (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
2026
2027 2013-05-16  Mary Wu  <mary.wu@torchmobile.com.cn>
2028
2029         [BlackBerry] Unable to download blob resource
2030         https://bugs.webkit.org/show_bug.cgi?id=115888
2031
2032         Reviewed by Benjamin Poulain.
2033
2034         For blob resource (blob:http....), it's not suitable to go to NetworkStream
2035         which don't handle "blob" protocol at all. since blob data already handled
2036         in BlobResourceHandle, simply get the data out to download stream.
2037
2038         RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
2039
2040         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2041         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
2042
2043 2013-05-16  Andreas Kling  <akling@apple.com>
2044
2045         Page::chrome() should return a reference.
2046         <http://webkit.org/b/116185>
2047
2048         Reviewed by Anders Carlsson.
2049
2050 2013-05-13  Anders Carlsson  <andersca@apple.com>
2051
2052         Frame::editor() should return a reference
2053         https://bugs.webkit.org/show_bug.cgi?id=116037
2054
2055         Reviewed by Darin Adler.
2056
2057         * WebCoreSupport/EditorClientBlackBerry.cpp:
2058         (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
2059         (WebCore::EditorClientBlackBerry::handleKeyboardEvent):
2060         * WebKitSupport/DOMSupport.cpp:
2061         (BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
2062         * WebKitSupport/InPageSearchManager.cpp:
2063         (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
2064         (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
2065         * WebKitSupport/SelectionHandler.cpp:
2066         (BlackBerry::WebKit::SelectionHandler::selectedText):
2067
2068 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2069
2070         Remove WTF_USE_PLATFORM_STRATEGIES
2071         https://bugs.webkit.org/show_bug.cgi?id=114431
2072
2073         Reviewed by Darin Adler.
2074
2075         * WebCoreSupport/AboutDataUseFeatures.in:
2076
2077 2013-05-14  Tiancheng Jiang  <tijiang@rim.com>
2078
2079         [BlackBerry] Improve Fatfinger phase.
2080         https://bugs.webkit.org/show_bug.cgi?id=107403
2081
2082         Reviewed by Rob Buis.
2083
2084         Internally reviewed by Genevieve Mak.
2085         BlackBerry PR 324965.
2086
2087         Cache and reuse intersected nodes as long as hit position has not been
2088         changed.
2089
2090         * Api/WebPage.cpp:
2091         (BlackBerry::WebKit::WebPagePrivate::hitTestResult):
2092         * Api/WebPage_p.h:
2093         (WebPagePrivate):
2094         * WebKitSupport/FatFingers.cpp:
2095         (BlackBerry::WebKit::FatFingers::findBestPoint):
2096         (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
2097         (BlackBerry::WebKit::FatFingers::getNodesFromRect):
2098         * WebKitSupport/FatFingers.h:
2099
2100 2013-05-14  Andrew Lo  <anlo@rim.com>
2101
2102         [BlackBerry] Hook up frame render begin/end in PerformanceMonitor
2103         https://bugs.webkit.org/show_bug.cgi?id=116110
2104
2105         Reviewed by Rob Buis.
2106
2107         Internally reviewed by Jeff Rogers, Jonathan Jiang.
2108         Internal PR 299155.
2109
2110         Mark frame render begin & end for BlackBerry performance monitoring
2111         in blitVisibleContents.
2112
2113         * Api/BackingStore.cpp:
2114         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
2115
2116 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2117
2118         [BlackBerry] Use requestAnimationFrame for animations
2119         https://bugs.webkit.org/show_bug.cgi?id=115896
2120
2121         Reviewed by Rob Buis.
2122
2123         Make WebPagePrivate a
2124         BlackBerry::Platform::AnimationFrameRateClient and use it to
2125         schedule animations.
2126
2127         * Api/WebPage.cpp:
2128         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2129         (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
2130         (WebKit):
2131         (BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
2132         (BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
2133         (BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
2134         (BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
2135         (BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
2136         * Api/WebPage_p.h:
2137         (WebPagePrivate):
2138         * WebCoreSupport/ChromeClientBlackBerry.cpp:
2139         (WebCore):
2140         (WebCore::ChromeClientBlackBerry::scheduleAnimation):
2141         * WebCoreSupport/ChromeClientBlackBerry.h:
2142         (ChromeClientBlackBerry):
2143
2144 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2145
2146         [BlackBerry] Implement platform strategies
2147         https://bugs.webkit.org/show_bug.cgi?id=112162
2148
2149         Reviewed by Rob Buis.
2150
2151         * Api/BlackBerryGlobal.cpp:
2152         (BlackBerry::WebKit::globalInitialize): Initialize platform
2153         strategies.
2154         * WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
2155         (PlatformStrategiesBlackBerry::initialize):
2156         (PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
2157         (PlatformStrategiesBlackBerry::createCookiesStrategy):
2158         (PlatformStrategiesBlackBerry::createDatabaseStrategy):
2159         (PlatformStrategiesBlackBerry::createLoaderStrategy):
2160         (PlatformStrategiesBlackBerry::createPasteboardStrategy):
2161         (PlatformStrategiesBlackBerry::createPluginStrategy):
2162         (PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
2163         (PlatformStrategiesBlackBerry::createStorageStrategy):
2164         (PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
2165         (PlatformStrategiesBlackBerry::cookiesForDOM):
2166         (PlatformStrategiesBlackBerry::setCookiesFromDOM):
2167         (PlatformStrategiesBlackBerry::cookiesEnabled):
2168         (PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
2169         (PlatformStrategiesBlackBerry::getRawCookies):
2170         (PlatformStrategiesBlackBerry::deleteCookie):
2171         (PlatformStrategiesBlackBerry::refreshPlugins):
2172         (PlatformStrategiesBlackBerry::getPluginInfo):
2173         (PlatformStrategiesBlackBerry::isLinkVisited):
2174         (PlatformStrategiesBlackBerry::addVisitedLink):
2175         * WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
2176         (PlatformStrategiesBlackBerry):
2177
2178 2013-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2179
2180         [BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
2181         https://bugs.webkit.org/show_bug.cgi?id=115412
2182
2183         Reviewed by Rob Buis.
2184
2185         PR 115412
2186
2187         The problem is that we are calling
2188         updateLayoutAndStyleIfNeededRecursive() (because of
2189         zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
2190         callback which is not expected. It's expected to be called right
2191         before painting, and not right after painting. Even if a new
2192         layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
2193         flushDeferredRepaints() and it's possible that this is called in
2194         the middle of a beginDeferredRepaints() and endDeferredRepaints()
2195         apparently.
2196         In general only BackingStore should call
2197         updateLayoutAndStyleIfNeededRecursive before painting, and a simple
2198         layout is enough in all other cases like resizing. This patch renames
2199         requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
2200         make more obvious what it does, and adds layoutIfNeeded that calls
2201         layout. The former is used by the BackingStore and the latter by
2202         WebPage.
2203
2204         * Api/BackingStore.cpp:
2205         (BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
2206         (BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
2207         * Api/WebPage.cpp:
2208         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
2209         (BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
2210         (BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
2211         (WebKit):
2212         (BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
2213         (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
2214         (BlackBerry::WebKit::WebPagePrivate::webContext):
2215         (BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
2216         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
2217         (BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
2218         (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
2219         * Api/WebPage_p.h:
2220         (WebPagePrivate):
2221
2222 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
2223
2224         Remove USE(OS_RANDOMNESS)
2225         https://bugs.webkit.org/show_bug.cgi?id=108095
2226
2227         Reviewed by Darin Adler.
2228
2229         Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
2230         ports.
2231
2232         * WebCoreSupport/AboutDataUseFeatures.in:
2233
2234 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2235
2236         Fix some compiler warnings (miscellaneous)
2237         https://bugs.webkit.org/show_bug.cgi?id=80790
2238
2239         Reviewed by Rob Buis.
2240
2241         Fix the following warnings for BlackBerry:
2242         BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
2243         '||' [-Wparentheses].
2244         WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
2245         as truth value [-Wparentheses].
2246         WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
2247         as truth value [-Wparentheses]
2248
2249         * Api/BackingStore.cpp:
2250         (BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
2251         * Api/WebPage.cpp:
2252         (BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
2253         (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
2254
2255 2013-05-09  Mike Fenton  <mifenton@rim.com>
2256
2257         [BlackBerry] Style updates required based on new check-webkit-style
2258         https://bugs.webkit.org/show_bug.cgi?id=115857
2259
2260         Reviewed by Rob Buis.
2261
2262         Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
2263         to match check-webkit-style updates.
2264
2265         * Api/InRegionScroller.cpp:
2266         (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
2267         * Api/InRegionScroller_p.h:
2268         * Api/WebKitTextCodec.cpp:
2269         (BlackBerry::WebKit::transcode):
2270         * Api/WebPageCompositor.cpp:
2271         (BlackBerry::WebKit::WebPageCompositor::render):
2272         * Api/WebPageCompositor.h:
2273         * Api/WebPageCompositor_p.h:
2274         (WebPageCompositorPrivate):
2275         * Api/WebSettings_p.h:
2276
2277 2013-05-09  Max Feil  <mfeil@rim.com>
2278
2279         shouldUsePluginDocument() needs to be respected when a document is created
2280         https://bugs.webkit.org/show_bug.cgi?id=110308
2281
2282         Reviewed by Rob Buis.
2283
2284         This patch implements shouldAlwaysUsePluginDocument() in the
2285         BlackBerry frame loader client. It is called in several places
2286         within WebCore to determine whether a PluginDocument should
2287         be created.
2288
2289         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2290         (WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
2291         (WebCore):
2292         (WebCore::FrameLoaderClientBlackBerry::createPlugin):
2293         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
2294         (FrameLoaderClientBlackBerry):
2295
2296 2013-05-09  Mike Fenton <mifenton@rim.com>
2297
2298         [BlackBerry] Style updates required based on new check-webkit-style
2299         https://bugs.webkit.org/show_bug.cgi?id=115857
2300
2301         Reviewed by Rob Buis.
2302
2303         Update SelectionHandler to match check-webkit-style updates.
2304
2305         * WebKitSupport/SelectionHandler.cpp:
2306         (BlackBerry::WebKit::shouldExtendSelectionInDirection):
2307         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
2308         (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
2309         (BlackBerry::WebKit::adjustCaretRects):
2310         (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
2311         (BlackBerry::WebKit::regionRectListContainsPoint):
2312         * WebKitSupport/SelectionHandler.h:
2313         (SelectionHandler):
2314
2315 2013-05-09  Mike Fenton  <mifenton@rim.com>
2316
2317         [BlackBerry] Style updates required based on new check-webkit-style
2318         https://bugs.webkit.org/show_bug.cgi?id=115857
2319
2320         Reviewed by Rob Buis.
2321
2322         Update WebPage and WebPageClient to match check-webkit-style updates.
2323
2324         * Api/WebPage.cpp:
2325         (BlackBerry::WebKit::WebPagePrivate::init):
2326         (BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
2327         (BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
2328         (BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
2329         (BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
2330         (BlackBerry::WebKit::WebPage::assignFocus):
2331         (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
2332         (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
2333         (BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
2334         (BlackBerry::WebKit::WebPage::addVisitedLink):
2335         (BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
2336         (BlackBerry::WebKit::WebPage::notifySwipeEvent):
2337         (BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
2338         (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
2339         (BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
2340         (BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
2341         * Api/WebPageClient.h:
2342         * Api/WebPage_p.h:
2343
2344 2013-05-09  Mike Fenton  <mifenton@rim.com>
2345
2346
2347         [BlackBerry] Style updates required based on new check-webkit-style
2348         https://bugs.webkit.org/show_bug.cgi?id=115857
2349
2350         Reviewed by Rob Buis.
2351
2352         Update BackingStore to match check-webkit-style updates.
2353
2354         Internally reviewed by Jakob Petsovits.
2355
2356         * Api/BackingStore.cpp:
2357         (BlackBerry::WebKit::bestDivisor):
2358         (BlackBerry::WebKit::BackingStorePrivate::repaint):
2359         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
2360         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
2361         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
2362         (BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
2363         (BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
2364         (BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
2365         (BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
2366         (BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
2367         (BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
2368         (BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
2369         (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
2370         (BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
2371         (BlackBerry::WebKit::BackingStore::repaint):
2372         * Api/BackingStore_p.h:
2373         (BackingStoreGeometry):
2374
2375 2013-05-09  Mike Fenton  <mifenton@rim.com>
2376
2377         [BlackBerry] Style updates required based on new check-webkit-style
2378         https://bugs.webkit.org/show_bug.cgi?id=115857
2379
2380         Reviewed by Rob Buis.
2381
2382         Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
2383         GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
2384         match check-webkit-style updates.
2385
2386         * WebCoreSupport/ChromeClientBlackBerry.h:
2387         (ChromeClientBlackBerry):
2388         * WebCoreSupport/CredentialManager.h:
2389         (CredentialManager):
2390         * WebCoreSupport/CredentialTransformData.cpp:
2391         * WebCoreSupport/FrameLoaderClientBlackBerry.h:
2392         (WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
2393         (FrameLoaderClientBlackBerry):
2394         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
2395         (WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
2396         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
2397         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
2398         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
2399         * WebCoreSupport/GeolocationClientBlackBerry.cpp:
2400         (GeolocationClientBlackBerry::onLocationUpdate):
2401         * WebCoreSupport/GeolocationClientBlackBerry.h:
2402         (GeolocationClientBlackBerry):
2403         * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
2404         (WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
2405
2406 2013-05-09  Jacky Jiang  <zhajiang@blackberry.com>
2407
2408         Fix some compiler warnings (miscellaneous)
2409         https://bugs.webkit.org/show_bug.cgi?id=80790
2410
2411         Reviewed by Rob Buis.
2412
2413         Fix the following warnings for BlackBerry:
2414         InRegionScroller.cpp:286:39: warning: suggest parentheses around
2415         assignment used as truth value [-Wparentheses].
2416         InRegionScroller.cpp:349:39: warning: suggest parentheses around
2417         assignment used as truth value [-Wparentheses].
2418         InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
2419         within '||' [-Wparentheses].
2420         InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
2421         avoid ambiguous 'else' [-Wparentheses].
2422         SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
2423         within '||' [-Wparentheses].
2424         SelectionOverlay.cpp:56:47: warning: comparison between signed and
2425         unsigned integer expressions [-Wsign-compare].
2426
2427
2428         * Api/InRegionScroller.cpp:
2429         (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
2430         (BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
2431         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
2432         * WebKitSupport/InRegionScrollableArea.cpp:
2433         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
2434         * WebKitSupport/SelectionHandler.cpp:
2435         (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
2436         * WebKitSupport/SelectionOverlay.cpp:
2437         (BlackBerry::WebKit::SelectionOverlay::draw):
2438
2439 2013-05-09  Mike Fenton  <mifenton@rim.com>
2440
2441         [BlackBerry] Style updates required based on new check-webkit-style
2442         https://bugs.webkit.org/show_bug.cgi?id=115857
2443
2444         Reviewed by Rob Buis.
2445
2446         Update ColorPickerClient and PagePopupBlackBerry
2447         to match check-webkit-style updates.
2448
2449         * WebCoreSupport/ColorPickerClient.cpp:
2450         (WebCore::ColorPickerClient::generateHTML):
2451         * WebCoreSupport/PagePopupBlackBerry.cpp:
2452         (WebCore::setValueAndClosePopupCallback):
2453         (WebCore::PagePopupBlackBerry::installDOMFunction):
2454
2455 2013-05-09  Alberto Garcia  <agarcia@igalia.com>
2456
2457         [BlackBerry] Upstream the input popups
2458         https://bugs.webkit.org/show_bug.cgi?id=114608
2459
2460         Reviewed by Rob Buis.
2461
2462         This patch contains contributions from many members of the
2463         BlackBerry WebKit team, including:
2464
2465         Chris Hutten-Czapski
2466         David Hoon
2467         Jessica Cao
2468         Rob Buis
2469         Tiancheng Jiang
2470
2471         * WebCoreSupport/ColorPickerClient.cpp:
2472         (WebCore):
2473         (WebCore::ColorPickerClient::generateHTML):
2474         * WebCoreSupport/DatePickerClient.cpp:
2475         (WebCore):
2476         (WebCore::DatePickerClient::generateHTML):
2477         (WebCore::DatePickerClient::generateDateLabels):
2478         * WebCoreSupport/DatePickerClient.h:
2479         (DatePickerClient):
2480         * WebCoreSupport/SelectPopupClient.cpp:
2481         (WebCore):
2482         (WebCore::SelectPopupClient::generateHTML):
2483
2484 2013-05-09  Mike Fenton  <mifenton@rim.com>
2485
2486         [BlackBerry] Style updates required based on new check-webkit-style
2487         https://bugs.webkit.org/show_bug.cgi?id=115857
2488
2489         Reviewed by Rob Buis.
2490
2491         Update DOMSupport to match check-webkit-style updates.
2492
2493         * WebKitSupport/DOMSupport.cpp:
2494         (BlackBerry::WebKit::DOMSupport::isTextInputElement):
2495         (BlackBerry::WebKit::DOMSupport::isPasswordElement):
2496         (BlackBerry::WebKit::DOMSupport::convertPointToFrame):
2497
2498 2013-05-09  Xuefei Ren  <xren@blackberry.com>
2499
2500         [BLACKBERRY]fix regression in Webpage
2501         and FrameLoaderClientBlackberry
2502         https://bugs.webkit.org/show_bug.cgi?id=115843
2503
2504         Reviewed by Rob Buis.
2505
2506         Internally reviewed by Mary Wu.
2507
2508         * Api/WebPage.cpp:
2509         (BlackBerry::WebKit::WebPage::loadFile):
2510         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2511         (WebCore::FrameLoaderClientBlackBerry::startDownload):
2512
2513 2013-05-09  Mike Fenton  <mifenton@rim.com>
2514
2515         [BlackBerry] Style updates required based on new check-webkit-style
2516         https://bugs.webkit.org/show_bug.cgi?id=115857
2517
2518         Reviewed by Rob Buis.
2519
2520         Update FatFingers to match check-webkit-style updates.
2521
2522         * WebKitSupport/FatFingers.cpp:
2523         (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
2524         (BlackBerry::WebKit::FatFingers::checkForClickableElement):
2525         * WebKitSupport/FatFingers.h:
2526         (FatFingersResult):
2527
2528 2013-05-09  Mike Fenton  <mifenton@rim.com>
2529
2530         [BlackBerry] Style updates required based on new check-webkit-style
2531         https://bugs.webkit.org/show_bug.cgi?id=115857
2532
2533         Reviewed by Rob Buis.
2534
2535         Update InRegionScrollableArea, TileIndexHash
2536         and TouchEventHandler to match check-webkit-style updates.
2537
2538         * WebKitSupport/InRegionScrollableArea.cpp:
2539         * WebKitSupport/TileIndexHash.h:
2540         * WebKitSupport/TouchEventHandler.cpp:
2541         (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
2542
2543 2013-05-09  Mike Fenton  <mifenton@rim.com>
2544
2545         [BlackBerry] Style updates required based on new check-webkit-style
2546         https://bugs.webkit.org/show_bug.cgi?id=115857
2547
2548         Reviewed by Rob Buis.
2549
2550         Styles fixes required for InputHandler based on updated
2551         check-webkit-style.
2552
2553         * WebKitSupport/InputHandler.cpp:
2554         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
2555         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2556         (BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
2557         (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
2558         (BlackBerry::WebKit::InputHandler::firstSpanInString):
2559         (BlackBerry::WebKit::InputHandler::setTextAttributes):
2560         * WebKitSupport/InputHandler.h:
2561
2562 2013-05-08  Eli Fidler  <efidler@blackberry.com>
2563
2564         [BlackBerry] Fix usage of BlackBerry::Platform::String
2565         https://bugs.webkit.org/show_bug.cgi?id=115781
2566
2567         Reviewed by Rob Buis.
2568
2569         BlackBerry PRs 304193 and 327181
2570         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
2571
2572         We currently have a problem where we're passing UTF-8 encoded data into
2573         the char* constructors of BlackBerry::Platform::String. This means the string
2574         thinks its data is not UTF-8.
2575
2576         * Api/JavaScriptVariant.cpp:
2577         (BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
2578         * Api/WebKitTextCodec.cpp:
2579         (BlackBerry::WebKit::base64Encode):
2580         * Api/WebPage.cpp:
2581         (BlackBerry::WebKit::WebPage::loadFile):
2582         (BlackBerry::WebKit::WebPage::textEncoding):
2583         (BlackBerry::WebKit::WebPage::textHasAttribute):
2584         (BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
2585         * Api/WebPage.h:
2586         * Api/WebSettings.cpp:
2587         (BlackBerry::WebKit::WebSettings::standardSettings):
2588         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2589         (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
2590         (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
2591         * WebKitSupport/DefaultTapHighlight.cpp:
2592         (WebKit):
2593         (BlackBerry::WebKit::DefaultTapHighlight::draw):
2594         (BlackBerry::WebKit::DefaultTapHighlight::hide):
2595
2596 2013-05-08  Rob Buis  <rbuis@rim.com>
2597
2598         Fix some compiler warnings (miscellaneous)
2599         https://bugs.webkit.org/show_bug.cgi?id=80790
2600
2601         Reviewed by Philip Rogers.
2602
2603         Get rid of the following warning for BlackBerry:
2604
2605         BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
2606
2607         by using ASSERT_UNUSED instead of ASSERT.
2608
2609         * WebKitSupport/BackingStoreClient.cpp:
2610         (BlackBerry::WebKit::BackingStoreClient::create):
2611
2612 2013-05-07  Xuefei Ren  <xren@blackberry.com>
2613
2614         Clean up load interface in WebPage
2615         https://bugs.webkit.org/show_bug.cgi?id=115622
2616         Reviewed by Rob Buis.
2617
2618         Internal PR:315535
2619         Internal reviewed by  Mary Wu
2620
2621         * Api/WebPage.cpp:
2622         (BlackBerry::WebKit::WebPagePrivate::load):
2623         (BlackBerry::WebKit::WebPage::loadFile):
2624         (BlackBerry::WebKit::WebPage::load):
2625         * Api/WebPage.h:
2626         * Api/WebPage_p.h:
2627         (WebPagePrivate):
2628         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
2629         (WebCore::FrameLoaderClientBlackBerry::startDownload):
2630
2631 2013-05-07  Mike Fenton  <mifenton@rim.com>
2632
2633         [BlackBerry] Increase the padding size for caret based scrolling.
2634         https://bugs.webkit.org/show_bug.cgi?id=115749
2635
2636         Reviewed by Rob Buis.
2637
2638         PR 322670.
2639
2640         Increasing the padding size for scrolling in order to optimize the
2641         number of scrolls required during typing.
2642
2643         * WebKitSupport/InputHandler.cpp:
2644         (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
2645
2646 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
2647
2648         [BlackBerry] Maintain touch event state throughout processing
2649         https://bugs.webkit.org/show_bug.cgi?id=115663
2650
2651         Reviewed by Rob Buis.
2652
2653         Internally reviewed by Otto Cheung and Genevieve Mak.
2654
2655         PR 297691
2656         By maintaining our touch event state, we can get a better idea
2657         of what triggered an update to selection and respond appropriately.
2658         On touch press we set userTouchTriggered to give the UI thread
2659         some context.
2660
2661         * Api/WebPage.cpp:
2662         (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
2663         (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
2664         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
2665         * Api/WebPage_p.h:
2666         (WebPagePrivate):
2667         * WebKitSupport/SelectionHandler.cpp:
2668         (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
2669
2670 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
2671
2672         [BlackBerry] Read-only fields should not get keyboard focus
2673         https://bugs.webkit.org/show_bug.cgi?id=115725
2674
2675         Reviewed by Rob Buis.
2676
2677         Internally reviewed by Mike Fenton.
2678
2679         PR332887
2680         Prevent keyboard focus and FCC from displaying when the user taps on a
2681         read-only field. Further, ensure form controls skip over these fields
2682         with the next/previous buttons.
2683
2684         * WebKitSupport/DOMSupport.cpp:
2685         (BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
2686         (DOMSupport):
2687         * WebKitSupport/DOMSupport.h:
2688         * WebKitSupport/InputHandler.cpp:
2689         (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
2690         (BlackBerry::WebKit::InputHandler::setInputModeEnabled):
2691         (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
2692         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
2693         (WebKit):
2694         * WebKitSupport/InputHandler.h:
2695
2696 2013-05-07  Nima Ghanavatian  <nghanavatian@blackberry.com>
2697
2698         [BlackBerry] Expand spellcheck logging
2699         https://bugs.webkit.org/show_bug.cgi?id=115482
2700
2701         Reviewed by Rob Buis.
2702
2703         Internally reviewed by Mike Fenton.
2704
2705         Fix some build errors when SpellingLog was turned on and expand on the debug
2706         statements to be more verbose. Set up timers and print the duration of each
2707         iteration as we traverse the text to create a range to send out for checking.
2708
2709         * WebKitSupport/InputHandler.cpp:
2710         (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
2711         (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
2712         (BlackBerry::WebKit::InputHandler::setElementFocused):
2713         (WebKit):
2714         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
2715         * WebKitSupport/SpellingHandler.cpp:
2716         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
2717         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
2718
2719 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
2720
2721         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
2722         https://bugs.webkit.org/show_bug.cgi?id=113808
2723
2724         Reviewed by Rob Buis.
2725
2726         Create a WebSetting for text autosizing. The default is off.
2727
2728         * Api/WebPage.cpp:
2729         (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
2730         * Api/WebSettings.cpp:
2731         (WebKit):
2732         (BlackBerry::WebKit::WebSettings::standardSettings):
2733         (BlackBerry::WebKit::WebSettings::isTextAutosizingEnabled):
2734         (BlackBerry::WebKit::WebSettings::setTextAutosizingEnabled):
2735         * Api/WebSettings.h:
2736
2737 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
2738
2739         [BlackBerry] Ensure document is attached before accessing its FrameSelection
2740         https://bugs.webkit.org/show_bug.cgi?id=115565
2741
2742         Reviewed by Rob Buis.
2743
2744         Internally reviewed by Mike Fenton.
2745
2746         PR 312101
2747         We need to make sure that the node and document
2748         are attached before accessing the FrameSelection. This was
2749         handled earlier but not all call paths were covered.
2750
2751         * WebKitSupport/InputHandler.cpp:
2752         (BlackBerry::WebKit::InputHandler::setElementUnfocused):
2753         (BlackBerry::WebKit::InputHandler::isActiveTextEdit):
2754         (WebKit):
2755         * WebKitSupport/InputHandler.h:
2756
2757 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
2758
2759         [BlackBerry] Do not spellcheck when composition is active.
2760         https://bugs.webkit.org/show_bug.cgi?id=115562
2761
2762         Reviewed by Rob Buis.
2763
2764         Internally reviewed by Mike Fenton.
2765
2766         PR331344
2767         Typing can trigger rechecking since layout changes. Ensure
2768         extra work is only done when we need it, and that it won't
2769         be triggered when composition is active. If the user hasn't
2770         finished a word yet, it is likely future key events will be
2771         arriving, so checking the string at this point is extraneous.
2772
2773         * WebKitSupport/InputHandler.cpp:
2774         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
2775
2776 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
2777
2778         [BlackBerry] Reduce the spellcheck checking range
2779         https://bugs.webkit.org/show_bug.cgi?id=115479
2780
2781         Reviewed by Rob Buis.
2782
2783         Internally reviewed by Mike Fenton.
2784
2785         PR332773
2786         Previously we were spellchecking the entire field on focus. If relayouting
2787         occurred we rechecked this region, which is very costly. Switch to check
2788         only a small region around the caret in both cases, which should alleviate
2789         much of the delays experienced in very large contenteditable fields. This
2790         allows for faster key input response and less time processing these requests
2791         on the WebKit thread.
2792
2793         * WebKitSupport/InputHandler.cpp:
2794         (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
2795         (BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
2796         * WebKitSupport/SpellingHandler.cpp:
2797         (WebKit):
2798         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
2799         * WebKitSupport/SpellingHandler.h:
2800         (SpellingHandler):
2801
2802 2013-05-06  Nima Ghanavatian  <nghanavatian@blackberry.com>
2803
2804         [BlackBerry] Use a more descriptive timer name
2805         https://bugs.webkit.org/show_bug.cgi?id=115481
2806
2807         Reviewed by Rob Buis.
2808
2809         Internally reviewed by Mike Fenton.
2810
2811         Changing m_timer to m_iterationDelayTimer.
2812
2813         * WebKitSupport/SpellingHandler.cpp:
2814         (BlackBerry::WebKit::SpellingHandler::SpellingHandler):
2815         (BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
2816         (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
2817         * WebKitSupport/SpellingHandler.h:
2818         (SpellingHandler):
2819
2820 2013-05-04  Nima Ghanavatian  <nghanavatian@blackberry.com>
2821
2822         [BlackBerry] Clean up unused spellcheck code
2823         https://bugs.webkit.org/show_bug.cgi?id=115560
2824
2825         Reviewed by Benjamin Poulain.
2826         Internally reviewed by Mike Lattanzio
2827
2828         * Api/WebPage.cpp:
2829         (BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
2830         * Api/WebPage.h:
2831         * WebKitSupport/InputHandler.cpp:
2832         * WebKitSupport/InputHandler.h:
2833         (InputHandler):
2834
2835 2013-05-03  Jacky Jiang  <zhajiang@blackberry.com>
2836
2837         [BlackBerry] Page rendering scale is changed after go back and forward
2838         https://bugs.webkit.org/show_bug.cgi?id=115573
2839
2840         Reviewed by Rob Buis.
2841         Internally reviewed by Jeff Rogers.
2842
2843         PR: 326886
2844         When navigating back from page A with viewport to page B without
2845         viewport, we didn't call setViewMode(); therefore, we didn't change
2846         the fixed layout size which was set by page A. In that case, WebCore
2847         would just pick up page A's fixed layout size to layout page B which
2848         caused this issue.
2849         Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
2850         later is not a good way, because zoomToInitialScaleOnLoad() has never
2851         been called in this case. So we should always call setViewMode() to set
2852         fixed layout size when a new page is committed.
2853
2854         * Api/WebPage.cpp:
2855         (BlackBerry::WebKit::WebPagePrivate::setLoadState):
2856
2857 2013-05-02  Genevieve Mak  <gmak@rim.com>
2858
2859         [BlackBerry] Cannot touch scroll readonly text input.
2860         https://bugs.webkit.org/show_bug.cgi?id=115378
2861
2862         Reviewed by Rob Buis.
2863
2864         PR #332902
2865         Reviewed Internally by Mike Fenton.
2866         Forgot half the patch.
2867         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
2868         Check the node type instead.
2869
2870         * Api/InRegionScroller.cpp:
2871         (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
2872
2873 2013-05-02  Iris Wu  <shuwu@blackberry.com>
2874
2875         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
2876         https://bugs.webkit.org/show_bug.cgi?id=115178
2877
2878         Reviewed by Rob Buis.
2879
2880         PR 308796
2881         Debug build fix.
2882
2883         * Api/WebPage.cpp:
2884         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
2885
2886 2013-05-01  Iris Wu  <shuwu@blackberry.com>
2887
2888          [BlackBerry] Upstream smart selection
2889          https://bugs.webkit.org/show_bug.cgi?id=111226
2890
2891         Reviewed by Rob Buis.
2892
2893         Calling userInterfaceViewportAccessor()->documentViewportRect() on WK thread
2894         caused crash.
2895         But viewport from webkitThreadViewportAccessor uses unadjusted size which is
2896         wrong for email.
2897         The solution here is to get actual viewport size on UI thread and then pass it
2898         to WebKit::SelectionHandler.
2899
2900         PR 333763
2901         Reviewed Internally By Jakob Petsovits.
2902
2903         * Api/InRegionScroller.cpp:
2904         (BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
2905         * Api/WebPage.cpp:
2906         (BlackBerry::WebKit::WebPage::setSelectionDocumentViewportSize):
2907         (WebKit):
2908         * Api/WebPage.h:
2909         * WebKitSupport/SelectionHandler.cpp:
2910         (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
2911         (BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
2912         (BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
2913         * WebKitSupport/SelectionHandler.h:
2914         (BlackBerry::WebKit::SelectionHandler::setSelectionViewportSize):
2915         (BlackBerry::WebKit::SelectionHandler::setSelectionSubframeViewportRect):
2916         (SelectionHandler):
2917
2918 2013-04-30  Genevieve Mak  <gmak@rim.com>
2919
2920         [BlackBerry] Cannot touch scroll readonly text input.
2921         https://bugs.webkit.org/show_bug.cgi?id=115378
2922
2923         Reviewed by Rob Buis.
2924
2925         PR #332902
2926         Reviewed Internally by Mike Fenton.
2927         Node::rendererIsEditable() returns false if the input element has the readonly tag set.
2928         Check the node type instead.
2929
2930         * WebKitSupport/DOMSupport.cpp:
2931         (BlackBerry::WebKit::DOMSupport::isShadowHostTextInputElement):
2932         (DOMSupport):
2933         * WebKitSupport/DOMSupport.h:
2934         * WebKitSupport/InRegionScrollableArea.cpp:
2935         (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
2936
2937 2013-04-29  Jakob Petsovits  <jpetsovits@blackberry.com>
2938
2939         [BlackBerry] Replace disappearing fillBuffer() API with graphics context drawing
2940         https://bugs.webkit.org/show_bug.cgi?id=115360
2941         Internal PR 303048.
2942
2943         Reviewed by Rob Buis.
2944
2945         Instead of using fillBuffer() to draw directly to the
2946         target buffer, we now lock a Drawable on it and fill it
2947         with PlatformGraphicsContext::addPredefinedPattern().
2948
2949         As a bonus, this also includes related clean-ups -
2950         simpler checkerboard painting code, removal of
2951         fillWindow(), clearWindow() and paintDefaultBackground(),
2952         as well as getting rid of the DEBUG_CHECKERBOARD define
2953         which has been useless for performance tracing purposes
2954         for a while now.
2955
2956         * Api/BackingStore.cpp:
2957         (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
2958         * Api/BackingStore_p.h:
2959
2960 2013-04-26  Nima Ghanavatian  <nghanavatian@blackberry.com>
2961
2962         [BlackBerry] Check for valid element in elementTouched
2963         https://bugs.webkit.org/show_bug.cgi?id=115205
2964
2965         Reviewed by Rob Buis.
2966
2967         Internally reviewed by Genevieve Mak.
2968
2969         PR 331546
2970         We might receive a null ptr from nodeAsElementIfApplicable which
2971         is passed in here. Check to make sure it's valid before using.
2972
2973         * WebKitSupport/InputHandler.cpp:
2974         (BlackBerry::WebKit::InputHandler::elementTouched):
2975
2976 2013-04-26  Martin Robinson  <mrobinson@igalia.com>
2977
2978         Remove the remaining Skia #ifdefs
2979         https://bugs.webkit.org/show_bug.cgi?id=114886
2980
2981         Reviewed by Benjamin Poulain.
2982
2983         * Api/WebPage.cpp: Remove Skia #ifdef references.
2984         * WebCoreSupport/AboutDataUseFeatures.in: Ditto.
2985
2986 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
2987
2988         [BlackBerry] Should check if it's cached resource before download
2989         https://bugs.webkit.org/show_bug.cgi?id=115101
2990
2991         Reviewed by Rob Buis.
2992
2993         Since main resource maybe cached, if user want to save the resource, we first check
2994         if it's cached. If yes, don't need to initiate a fresh load again, but get the
2995         cached resource data out to save.
2996
2997         RIM bug# 324003, internally reviewed by Charles Wei.
2998
2999         * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
3000         (WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
3001
3002 2013-04-26  Mary Wu  <mary.wu@torchmobile.com.cn>
3003
3004         [BlackBerry] Clean up load interface in WebPage
3005         https://bugs.webkit.org/show_bug.cgi?id=113267
3006
3007         Reviewed by Rob Buis.
3008
3009         Remove unused loadExtended(), combine load() and download() api in WebPage.
3010         RIM Bug# 315535, internally reviewed by Joe Mason.
3011
3012         * Api/WebPage.cpp:
3013         (BlackBerry::WebKit::WebPage::load):
3014         * Api/WebPage.h:
3015
3016 2013-04-25  Andrew Lo  <anlo@rim.com>
3017
3018         [BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
3019         https://bugs.webkit.org/show_bug.cgi?id=115197
3020
3021         Reviewed by Rob Buis.
3022
3023         When drawing the selection overlay, the rects to
3024         paint when selecting text on non-composited sub-frames
3025         need to be adjusted by the frame position.
3026
3027         * WebKitSupport/SelectionOverlay.cpp:
3028         (BlackBerry::WebKit::SelectionOverlay::paintContents):
3029
3030 2013-04-25  Andreas Kling  <akling@apple.com>
3031
3032         Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.
3033
3034         Rubber-stamped by Anders Koivisto.
3035
3036         * WebCoreSupport/AboutDataEnableFeatures.in:
3037
3038 2013-04-25  Iris Wu  <shuwu@blackberry.com>
3039
3040         [BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
3041         https://bugs.webkit.org/show_bug.cgi?id=115178
3042
3043         Reviewed by Rob Buis.
3044
3045         PR 308796
3046
3047         Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
3048         left point of the viewport.
3049         On the page with fixed position elements, we want it to adjust the position beneath
3050         the fixed elements so it can be always visible.
3051
3052         The basic idea is:
3053         1.  Detect if there are fixed position elements before going through ProximityDetector.
3054         2.  If the fixed element exists, calculate its the size and the actual visible position
3055             beneath it.
3056         3.  Pass the position to ProximityDetector. Then according to the new position we get,
3057             calculate the top left position of the viewport (final scroll position).
3058
3059         * Api/WebPage.cpp:
3060         (BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
3061         (WebKit):
3062         * Api/WebPage.h:
3063         * Api/WebPageCompositor.cpp:
3064         (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
3065         (WebKit):
3066         * Api/WebPageCompositor_p.h:
3067         (WebPageCompositorPrivate):
3068
3069 2013-04-25  Mike Lattanzio  <mlattanzio@blackberry.com>
3070
3071         [BlackBerry] Enable balanced page group load deferrer behaviour.
3072         https://bugs.webkit.org/show_bug.cgi?id=115189
3073
3074         Reviewed by Rob Buis.
3075
3076         Prevent a possible deadlock by enabling balanced deferrers.
3077         Internally reviewed by: Joe Mason
3078         PR 329986
3079
3080         * Api/WebPage.cpp:
3081         (BlackBerry::WebKit::WebPagePrivate::init):
3082
3083 2013-04-25  Joseph Pecoraro  <pecoraro@apple.com>
3084
3085         Web Inspector: ConsoleMessage should include line and column number where possible
3086         https://bugs.webkit.org/show_bug.cgi?id=114929
3087
3088         Reviewed by Timothy Hatcher.
3089
3090         * Api/DumpRenderTreeClient.h:
3091         * Api/WebPageClient.h:
3092         * WebCoreSupport/ChromeClientBlackBerry.cpp:
3093         (WebCore::ChromeClientBlackBerry::addMessageToConsole):
3094         * WebCoreSupport/ChromeClientBlackBerry.h:
3095         (ChromeClientBlackBerry):
3096
3097 2013-04-25  Konrad Piascik  <kpiascik@blackberry.com>
3098
3099         [BlackBerry] Get rid of return in void method
3100         https://bugs.webkit.org/show_bug.cgi?id=115186
3101
3102         Reviewed by Rob Buis.
3103
3104         * Api/WebPage.cpp:
3105         (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
3106
3107 2013-04-24  Nima Ghanavatian  <nghanavatian@blackberry.com>
3108
3109         [BlackBerry] Do not clear focus on a node when tapping on form controls
3110         https://bugs.webkit.org/show_bug.cgi?id=115055
3111
3112         Reviewed by Rob Buis.
3113
3114         Internally reviewed by Genevieve Mak.
3115
3116         PR316069
3117         To allow for rich text editors to apply styles on an input field
3118         or highlighted text, we must maintain focus on the current element
3119         when tapping on form elements. Moving the code that clears this
3120         context to trigger off TouchHold instead of TouchPress.
3121
3122         * WebKitSupport/TouchEventHandler.cpp:
3123         (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
3124
3125 == Rolled over to ChangeLog-2013-04-24 ==