REGRESSION(r226327): [GTK] Plugin process is broken
[WebKit-https.git] / Source / WebKit / ChangeLog
1 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         REGRESSION(r226327): [GTK] Plugin process is broken
4         https://bugs.webkit.org/show_bug.cgi?id=181187
5
6         Unreviewed, fix PluginProcessMainUnix after r226327.
7
8         * PluginProcess/unix/PluginProcessMainUnix.cpp:
9
10 2018-01-02  Tim Horton  <timothy_horton@apple.com>
11
12         Fix the build on platforms where UICurrentUserInterfaceIdiomIsPad is defined to false
13         https://bugs.webkit.org/show_bug.cgi?id=181218
14
15         Reviewed by Alex Christensen.
16
17         * Platform/spi/ios/UIKitSPI.h:
18         (currentUserInterfaceIdiomIsPad):
19         * UIProcess/ios/SmartMagnificationController.mm:
20         (WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
21         * UIProcess/ios/WKContentViewInteraction.mm:
22         (-[WKFormInputSession setAccessoryViewCustomButtonTitle:]):
23         (-[WKContentView _requiresKeyboardWhenFirstResponder]):
24         (-[WKContentView _displayFormNodeInputView]):
25         (-[WKContentView requiresAccessoryView]):
26         (-[WKContentView _updateAccessory]):
27         * UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
28         (-[WKAirPlayRoutePicker show:fromRect:]):
29         * UIProcess/ios/forms/WKFileUploadPanel.mm:
30         (-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
31         (-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):
32         * UIProcess/ios/forms/WKFormInputControl.mm:
33         (-[WKDateTimePicker initWithView:datePickerMode:]):
34         (-[WKFormInputControl initWithView:]):
35         * UIProcess/ios/forms/WKFormSelectControl.mm:
36         (-[WKFormSelectControl initWithView:]):
37         On platforms where UICurrentUserInterfaceIdiomIsPad is defined to false,
38         blocks that conditionally execute based on its value are unreachable.
39         This causes the compiler to complain. Hide it away inside an inline function
40         and make use of that everywhere we used to use the macro.
41
42 2018-01-02  Alex Christensen  <achristensen@webkit.org>
43
44         Remove SVN file accidentally added in r226160
45         https://bugs.webkit.org/show_bug.cgi?id=180934
46
47         * UIProcess/WebPageProxy.cpp.orig: Removed.
48
49 2018-01-02  Alex Christensen  <achristensen@webkit.org>
50
51         Use BlockPtrs and lambdas instead of new/delete to pass parameters to blocks in WebViewImpl::performDragOperation
52         https://bugs.webkit.org/show_bug.cgi?id=180795
53
54         Reviewed by Brent Fulgham.
55
56         * UIProcess/Cocoa/WebViewImpl.mm:
57         (WebKit::WebViewImpl::performDragOperation):
58
59 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
60
61         [WPE][GTK] Implement the assignment of ProcessIdentifiers to child processes
62         https://bugs.webkit.org/show_bug.cgi?id=181187
63
64         Reviewed by Brady Eidson.
65
66         * Shared/ChildProcess.cpp: Make the ProcessIdentifier mandatory.
67         (WebKit::ChildProcess::initialize):
68         * Shared/unix/ChildProcessMain.cpp: Initialize ChildProcessInitializationParameters with the
69         ProcessIdentifier.
70         (WebKit::ChildProcessMainBase::parseCommandLine):
71         * UIProcess/Launcher/glib/ProcessLauncherGLib.cpp: Copy the ProcessIdentifier from
72         LaunchOptions into argv.
73         (WebKit::ProcessLauncher::launchProcess):
74         * WebProcess/wpe/WebProcessMainWPE.cpp: Expect the WPE socket ID later in the command line.
75
76 2018-01-02  Alex Christensen  <achristensen@webkit.org>
77
78         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
79         https://bugs.webkit.org/show_bug.cgi?id=180897
80         <rdar://problem/35535328>
81
82         Reviewed by Brent Fulgham.
83
84         * Shared/WebsitePoliciesData.cpp:
85         (WebKit::WebsitePoliciesData::applyToDocumentLoader):
86         * UIProcess/Cocoa/NavigationState.mm:
87         (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
88         * UIProcess/WebPageProxy.cpp:
89         (WebKit::WebPageProxy::changeWebsiteDataStore):
90         * UIProcess/WebPageProxy.h:
91         * UIProcess/WebProcessPool.cpp:
92         (WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
93         (WebKit::WebProcessPool::pageEndUsingWebsiteDataStore):
94         (WebKit::WebProcessPool::pageAddedToProcess): Deleted.
95         (WebKit::WebProcessPool::pageRemovedFromProcess): Deleted.
96         * UIProcess/WebProcessPool.h:
97         * UIProcess/WebProcessProxy.cpp:
98         (WebKit::WebProcessProxy::addExistingWebPage):
99         (WebKit::WebProcessProxy::removeWebPage):
100         * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
101         (WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
102
103 2018-01-02  Alex Christensen  <achristensen@webkit.org>
104
105         Only use CookieStorageShim when we aren't using NetworkSession
106         https://bugs.webkit.org/show_bug.cgi?id=180766
107
108         Reviewed by Brent Fulgham.
109
110         * Shared/mac/CookieStorageShim.h:
111         * Shared/mac/CookieStorageShim.mm:
112         * WebProcess/WebProcess.cpp:
113         (WebKit::WebProcess::initializeWebProcess):
114
115 2018-01-02  Alex Christensen  <achristensen@webkit.org>
116
117         Clean up context menu code
118         https://bugs.webkit.org/show_bug.cgi?id=181074
119
120         Reviewed by Brent Fulgham.
121
122         Use Ref instead of RefPtr where possible.
123         Use move semantics instead of copying from const references when possible.
124         Remove dead iOS code.  Reduce allocations.  Add stub for WPE.
125
126         * UIProcess/API/APIContextMenuClient.h:
127         (API::ContextMenuClient::getContextMenuFromProposedMenu):
128         (API::ContextMenuClient::getContextMenuFromProposedMenuAsync):
129         (API::ContextMenuClient::showContextMenu):
130         * UIProcess/API/C/WKPage.cpp:
131         (WKPageSetPageContextMenuClient):
132         * UIProcess/API/gtk/PageClientImpl.cpp:
133         (WebKit::PageClientImpl::createContextMenuProxy):
134         * UIProcess/API/gtk/PageClientImpl.h:
135         * UIProcess/PageClient.h:
136         * UIProcess/WebContextMenuListenerProxy.cpp:
137         (WebKit::WebContextMenuListenerProxy::useContextMenuItems):
138         * UIProcess/WebContextMenuProxy.cpp:
139         (WebKit::WebContextMenuProxy::WebContextMenuProxy):
140         * UIProcess/WebContextMenuProxy.h:
141         * UIProcess/WebPageProxy.cpp:
142         (WebKit::WebPageProxy::showContextMenu):
143         (WebKit::WebPageProxy::internalShowContextMenu): Deleted.
144         * UIProcess/WebPageProxy.h:
145         * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
146         (WebKit::WebContextMenuProxyGtk::showContextMenuWithItems):
147         (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
148         * UIProcess/gtk/WebContextMenuProxyGtk.h:
149         (WebKit::WebContextMenuProxyGtk::create):
150         * UIProcess/ios/PageClientImplIOS.h:
151         * UIProcess/ios/PageClientImplIOS.mm:
152         (WebKit::PageClientImpl::createContextMenuProxy): Deleted.
153         * UIProcess/mac/PageClientImplMac.h:
154         * UIProcess/mac/PageClientImplMac.mm:
155         (WebKit::PageClientImpl::createContextMenuProxy):
156         * UIProcess/mac/WebContextMenuProxyMac.h:
157         (WebKit::WebContextMenuProxyMac::create):
158         * UIProcess/mac/WebContextMenuProxyMac.mm:
159         (WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
160         (WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
161         (WebKit::WebContextMenuProxyMac::showContextMenu):
162
163 == Rolled over to ChangeLog-2018-01-01 ==