Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2019-06-20  Devin Rousso  <drousso@apple.com>
2
3         Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
4         https://bugs.webkit.org/show_bug.cgi?id=199022
5
6         Reviewed by Darin Adler.
7
8         * UserInterface/Views/TabBar.css:
9         (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover):
10         (@media not (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon):
11         (@media (prefers-color-scheme: dark) .tab-bar):
12         (@media (prefers-color-scheme: dark) .tab-bar > .item):
13         (@media (prefers-color-scheme: dark) .tab-bar > .item:not(.disabled).selected):
14         (@media (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected):hover):
15         (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar):
16         (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item):
17         (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item.selected):
18
19         * UserInterface/Views/Toolbar.css:
20         (@media (prefers-color-scheme: dark) body .toolbar):
21
22 2019-06-20  Devin Rousso  <drousso@apple.com>
23
24         Web Inspector: Debugger: setting a breakpoint on a non-JavaScript line should immediately show as unresolved
25         https://bugs.webkit.org/show_bug.cgi?id=199033
26
27         Reviewed by Matt Baker.
28
29         Remove the `shouldSpeculativelyResolve` parameter, as it was resolving breakpoints even in
30         the case that there were no resolved locations for the given breakpoint.
31
32         In the case that there are resolved locations, the breakpoint would've already been resolved
33         by the time that `shouldSpeculativelyResolve` would've taken effect, so it's unnecessary.
34
35         This parameter was only used when setting a breakpoint from a `SourceCodeTextEditor` gutter.
36
37         * UserInterface/Controllers/DebuggerManager.js:
38         (WI.DebuggerManager.prototype.addBreakpoint):
39         (WI.DebuggerManager.prototype._setBreakpoint):
40         (WI.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
41
42         * UserInterface/Views/SourceCodeTextEditor.js:
43         (WI.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
44
45 2019-06-20  Devin Rousso  <drousso@apple.com>
46
47         Web Inspector: Edit -> Tag doesn't do anything for html, head, and body elements
48         https://bugs.webkit.org/show_bug.cgi?id=199052
49         <rdar://problem/51923906>
50
51         Reviewed by Matt Baker.
52
53         * UserInterface/Views/DOMTreeElement.js:
54         (WI.DOMTreeElement.prototype.populateDOMNodeContextMenu):
55          - Don't show an "Edit > Tag" for <html>, <head>, and <body> nodes
56          - Disable any "Edit" submenu item if it's target is already being edited
57          - Prevent "Add" submenu items from being shown for text nodes
58
59 2019-06-19  Devin Rousso  <drousso@apple.com>
60
61         Web Inspector: REGRESSION: Debugger: current call frame indicator isn't vertically centered
62         https://bugs.webkit.org/show_bug.cgi?id=199015
63
64         Reviewed by Matt Baker.
65
66         * UserInterface/Views/CallFrameTreeElement.css:
67         (.tree-outline .item.call-frame .status):
68
69 2019-06-19  Nikita Vasilyev  <nvasilyev@apple.com>
70
71         REGRESSION(r240946): Web Inspector: Styles: Pasting multiple properties has issues
72         https://bugs.webkit.org/show_bug.cgi?id=198505
73         <rdar://problem/51374780>
74
75         Reviewed by Matt Baker.
76
77         Since r240946, setting WI.CSSStyleDeclaration.prototype.text updates the text immediately.
78         When WI.CSSStyleDeclaration.prototype.update gets called after setting text, it exits early
79         without firing WI.CSSStyleDeclaration.Event.PropertiesChanged.
80
81         * UserInterface/Models/CSSStyleDeclaration.js:
82         (WI.CSSStyleDeclaration):
83         (WI.CSSStyleDeclaration.prototype.set text):
84
85 2019-06-19  Matt Baker  <mattbaker@apple.com>
86
87         Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
88         https://bugs.webkit.org/show_bug.cgi?id=199026
89
90         Reviewed by Devin Rousso.
91
92         This flag is no longer set as of https://trac.webkit.org/changeset/225895.
93
94         * UserInterface/Views/NetworkTableContentView.js:
95         (WI.NetworkTableContentView):
96         (WI.NetworkTableContentView.prototype._processPendingEntries):
97
98 2019-06-19  Devin Rousso  <drousso@apple.com>
99
100         Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'sourceCodePosition.lineNumber')
101         https://bugs.webkit.org/show_bug.cgi?id=199019
102
103         Reviewed by Matt Baker.
104
105         * UserInterface/Base/Main.js:
106         (WI.linkifyLocation):
107
108 2019-06-19  Zhifei Fang  <zhifei_fang@apple.com>
109
110         Correct the error object link color in dark mode.
111         https://bugs.webkit.org/show_bug.cgi?id=198033
112
113         Reviewed by Devin Rousso.
114
115         * UserInterface/Views/ErrorObjectView.css:
116         (@media (prefers-dark-interface)):
117         (.error-object-link-container):
118
119 2019-06-18  Devin Rousso  <drousso@apple.com>
120
121         Web Inspector: Network: detail view shouldn't stay open when the related entry is removed
122         https://bugs.webkit.org/show_bug.cgi?id=198951
123
124         Reviewed by Joseph Pecoraro.
125
126         * UserInterface/Views/NetworkTableContentView.js:
127         (WI.NetworkTableContentView.prototype._mainResourceDidChange):
128         Hide the detail view if the main resource changes and we aren't preserving the log.
129
130         * UserInterface/Views/Table.js:
131         (WI.Table.prototype.reloadVisibleColumnCells):
132         Only attempt to populate cells for rows that the `_dataSource` actually has. Without this,
133         the `_delegate` may be asked to populate a cell for a row it doesn't have, which would error.
134
135 2019-06-18  Devin Rousso  <drousso@apple.com>
136
137         Web Inspector: parseQueryParameters fails to successfully parse query parameter values that contain "="
138         https://bugs.webkit.org/show_bug.cgi?id=198971
139         <rdar://problem/51852782>
140
141         Reviewed by Joseph Pecoraro.
142
143         * UserInterface/Base/URLUtilities.js:
144         (parseQueryString):
145
146 2019-06-18  Devin Rousso  <drousso@apple.com>
147
148         Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
149         https://bugs.webkit.org/show_bug.cgi?id=198941
150
151         Reviewed by Joseph Pecoraro.
152
153         Since heap snapshot records can be added at any time, including when not actively recording,
154         when the "Entire Recording" range is selected, make sure to set the `filterEndTime` to be an
155         effectively infinite number so that records added later aren't filtered out.
156
157         This isn't done for other timeline views as they may have graphs that don't expect to render
158         from time 0 till infinity, not to mention being unable to add records when not recording.
159
160         * UserInterface/Views/TimelineRecordingContentView.js:
161         (WI.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
162
163 2019-06-18  Devin Rousso  <drousso@apple.com>
164
165         Web Inspector: REGRESSION: Canvas: cannot select saved recordings
166         https://bugs.webkit.org/show_bug.cgi?id=198953
167
168         Reviewed by Joseph Pecoraro.
169
170         * UserInterface/Views/TreeElement.js:
171         (WI.TreeElement.treeElementToggled):
172         Don't early return if the `TreeElement` isn't `selectable` as the owner `TreeOutline` may
173         want to dispatch an event that it was clicked.
174
175 2019-06-18  Devin Rousso  <drousso@apple.com>
176
177         Web Inspector: Canvas: the initial state should be selected when processing a new/imported recording if the navigation sidebar is collapsed
178         https://bugs.webkit.org/show_bug.cgi?id=198952
179
180         Reviewed by Joseph Pecoraro.
181
182         Prevent any content from being generated until `initialLayout` is called, as otherwise it's
183         possible for the `CanvasNavigationSidebar` to update the current action index before the
184         preview element has been created, which would throw an error.
185
186         * UserInterface/Views/RecordingContentView.js:
187         (WI.RecordingContentView.prototype.updateActionIndex):
188         (WI.RecordingContentView.prototype.initialLayout):
189         (WI.RecordingContentView.prototype._updateSliderValue):
190         (WI.RecordingContentView.prototype._handleRecordingProcessedAction):
191         Drive-by: update the slider max each time the selected action index is changed.
192
193 2019-06-18  Devin Rousso  <drousso@apple.com>
194
195         Web Inspector: Canvas: imported recordings aren't selectable from the overview if there are no canvases in the page
196         https://bugs.webkit.org/show_bug.cgi?id=198955
197
198         Reviewed by Joseph Pecoraro.
199
200         * UserInterface/Views/CanvasOverviewContentView.js:
201         (WI.CanvasOverviewContentView.prototype._addSavedRecording):
202         Hide the content placeholder when a recording is imported. It won't be shown again because
203         the `subviews` list will never be empty, as there's no way to remove an imported recording.
204
205         * UserInterface/Views/CollectionContentView.js:
206         (WI.CollectionContentView.prototype.addContentViewForItem):
207         (WI.CollectionContentView.prototype.removeContentViewForItem):
208         (WI.CollectionContentView.prototype.showContentPlaceholder): Added.
209         (WI.CollectionContentView.prototype.hideContentPlaceholder): Added.
210         (WI.CollectionContentView.prototype.initialLayout):
211         (WI.CollectionContentView.prototype._selectItem):
212         (WI.CollectionContentView.prototype._showContentPlaceholder): Deleted.
213         (WI.CollectionContentView.prototype._hideContentPlaceholder): Deleted.
214         Make `showContentPlaceholder`/`hideContentPlaceholder` protected for any subclasses to call.
215
216 2019-06-17  Matt Baker  <mattbaker@apple.com>
217
218         Web Inspector: Elements: remove ellipses from "Break on" context menu item title
219         https://bugs.webkit.org/show_bug.cgi?id=198944
220
221         Reviewed by Devin Rousso.
222
223         Update context menu title to comply with Apple HI guidelines.
224
225         * Localizations/en.lproj/localizedStrings.js:
226         * UserInterface/Views/ContextMenuUtilities.js:
227
228 2019-06-17  Devin Rousso  <drousso@apple.com>
229
230         Web Inspector: Debugger: adding a DOM/Event/URL breakpoint should enable breakpoints
231         https://bugs.webkit.org/show_bug.cgi?id=198932
232
233         Reviewed by Matt Baker.
234
235         Match the behavior of JavaScript breakpoints, which enable breakpoints globally when a new
236         breakpoint is set or an existing breakpoint is enabled.
237
238         This avoids the situation where setting a DOM breakpoint or a specific event listener
239         breakpoint appears to not "work" because breakpoints are globally disabled. There is no
240         "breakpoints disabled" banner in the Elements tab, so the user could be completely unaware
241         of this, and therefore be confused as to why these breakpoints aren't being hit.
242
243         * UserInterface/Controllers/DOMManager.js:
244         (WI.DOMManager.prototype._updateEventBreakpoint):
245
246         * UserInterface/Controllers/DOMDebuggerManager.js:
247         (WI.DOMDebuggerManager.prototype._updateDOMBreakpoint):
248         (WI.DOMDebuggerManager.prototype._updateEventBreakpoint):
249         (WI.DOMDebuggerManager.prototype._updateURLBreakpoint):
250
251 2019-06-17  Devin Rousso  <drousso@apple.com>
252
253         Web Inspector: Sources: remove extra space above Breakpoints section when breakpoints are disabled
254         https://bugs.webkit.org/show_bug.cgi?id=198933
255
256         Reviewed by Matt Baker.
257
258         * UserInterface/Views/DebuggerSidebarPanel.css:
259         (.sidebar > .panel.navigation.debugger .warning-banner):
260         * UserInterface/Views/SourcesNavigationSidebarPanel.css:
261         (.sidebar > .panel.navigation.sources > .content > .warning-banner):
262
263 2019-06-17  Devin Rousso  <drousso@apple.com>
264
265         Web Inspector: Settings: split the General panel into sub panels so it's less crowded
266         https://bugs.webkit.org/show_bug.cgi?id=198803
267
268         Reviewed by Timothy Hatcher.
269
270         * UserInterface/Views/SettingsTabContentView.js:
271         (WI.SettingsTabContentView.prototype.initialLayout):
272         (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
273         Many of the settings in General only affect a specific part of Web Inspector, and therefore
274         aren't really "general".
275
276         (WI.SettingsTabContentView.prototype._createElementsSettingsView): Added.
277          - Element Selection
278          - CSS Changes
279
280         (WI.SettingsTabContentView.prototype._createSourcesSettingsView): Added.
281          - Debugger
282          - Source Maps
283
284         (WI.SettingsTabContentView.prototype._createConsoleSettingsView): Added.
285          - Traces (renamed from "Console")
286          - WebRTC Logging
287          - Media Logging
288          - MSE Logging
289
290         * Localizations/en.lproj/localizedStrings.js:
291
292 2019-06-17  Devin Rousso  <drousso@apple.com>
293
294         Web Inspector: Sources: the Inspector Style Sheet is missing when grouped by path
295         https://bugs.webkit.org/show_bug.cgi?id=198860
296
297         Reviewed by Timothy Hatcher.
298
299         * UserInterface/Controllers/CSSManager.js:
300         (WI.CSSManager.prototype.get styleSheets):
301         (WI.CSSManager.prototype.inspectorStyleSheetsForFrame):
302         (WI.CSSManager.prototype.preferredInspectorStyleSheetForFrame):
303         (WI.CSSManager.prototype._inspectorStyleSheetsForFrame): Deleted.
304         Expose a way to fetch all inspector stylesheets for a given frame.
305         Make sure to associate inspector stylesheets with their frame.
306
307         * UserInterface/Views/SourcesNavigationSidebarPanel.js:
308         (WI.SourcesNavigationSidebarPanel.prototype._compareTreeElements):
309         (WI.SourcesNavigationSidebarPanel.prototype._addResourcesRecursivelyForFrame):
310         (WI.SourcesNavigationSidebarPanel.prototype._handleCSSStyleSheetAdded):
311         Add paths for inspector stylesheet creation/fetching when grouping by path.
312         Sort inspector stylesheets as the first item of an origin/frame when grouping by path.
313
314 2019-06-17  Jamal Nasser  <jamaln@mail.com>
315
316         Web Inspector: Go To Line dialog is white when in Dark Mode
317         https://bugs.webkit.org/show_bug.cgi?id=198596
318
319         Reviewed by Timothy Hatcher.
320
321         * UserInterface/Views/GoToLineDialog.css:
322         (@media (prefers-color-scheme: dark)):
323         (.go-to-line-dialog):
324         (.go-to-line-dialog > div > input):
325         (.go-to-line-dialog > div > input::placeholder):
326         (.go-to-line-dialog > div::before):
327
328 2019-06-17  Devin Rousso  <drousso@apple.com>
329
330         Web Inspector: Sources: searching doesn't use the case sensitive or regex global settings
331         https://bugs.webkit.org/show_bug.cgi?id=198897
332
333         Reviewed by Joseph Pecoraro.
334
335         * UserInterface/Views/SourceCodeTextEditor.js:
336         (WI.SourceCodeTextEditor.prototype.customPerformSearch):
337
338 2019-06-13  Devin Rousso  <drousso@apple.com>
339
340         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
341         https://bugs.webkit.org/show_bug.cgi?id=198806
342
343         Reviewed by Joseph Pecoraro.
344
345         * UserInterface/Workers/Formatter/CSSFormatter.js:
346         (CSSFormatter.prototype._format):
347         Add more specific tests for at-rules, and add/remove whitespace depending on the type of
348         at-rule (e.g. `@supports` vs `@media`), as well as where the scanner is in the parameters of
349         the at at-rule (e.g. `@supports |` vs `@media (|`).
350
351         * UserInterface/Workers/Formatter/FormatterContentBuilder.js:
352         (FormatterContentBuilder):
353         (FormatterContentBuilder.prototype.get lastToken): Added.
354         (FormatterContentBuilder.prototype.get currentLine):
355         (FormatterContentBuilder.prototype.removeLastNewline):
356         (FormatterContentBuilder.prototype.removeLastWhitespace):
357         (FormatterContentBuilder.prototype._popFormattedContent):
358         (FormatterContentBuilder.prototype._append):
359         Update `lastTokenWasNewline` and `lastTokenWasWhitespace` when removing newlines/whitespace.
360         Memoize the `currentLine` so it's less expensive to re-fetch.
361
362 2019-06-13  Devin Rousso  <drousso@apple.com>
363
364         Web Inspector: Settings: indent type and size settings aren't respected everywhere
365         https://bugs.webkit.org/show_bug.cgi?id=198804
366
367         Reviewed by Timothy Hatcher.
368
369         * UserInterface/Views/CodeMirrorEditor.js:
370         (WI.CodeMirrorEditor.create):
371         When creating a `CodeMirror` instance, default to using the global `Setting`s as the options.
372         If an override is specified in `options`, it will take precedence and the `CodeMirror` will
373         ignore any changes to the `Setting` as well.
374
375         * UserInterface/Views/TextEditor.js:
376         (WI.TextEditor):
377         (WI.TextEditor.prototype.close): Deleted.
378
379         * UserInterface/Views/AuditTestCaseContentView.js:
380         (WI.AuditTestCaseContentView.prototype.layout):
381         * UserInterface/Views/BreakpointActionView.js:
382         (WI.BreakpointActionView.prototype._updateBody):
383         * UserInterface/Views/ConsolePrompt.js:
384         (WI.ConsolePrompt):
385         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
386         (WI.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
387         Remove overrides that aren't necessary for `CodeMirror` to fit in the container element:
388          - `showWhitespaceCharacters`
389          - `indentWithTabs`
390          - `indentUnit`
391
392         * UserInterface/Views/SourceCodeTextEditor.js:
393         (WI.SourceCodeTextEditor.prototype.close):
394         * UserInterface/Views/ShaderProgramContentView.js:
395         (WI.ShaderProgramContentView.prototype.closed): Deleted.
396         * UserInterface/Views/TextContentView.js:
397         (WI.TextContentView.prototype.closed): Deleted.
398         * UserInterface/Views/TextResourceContentView.js:
399         (WI.TextResourceContentView.prototype.closed):
400         Delete the logic for removing event listeners from global `Setting`, as it didn't work
401         anyways, since none of the event listeners were added using a `thisObject`.
402
403 2019-06-13  Devin Rousso  <drousso@apple.com>
404
405         Web Inspector: Settings: sticky header disappears when over scrolling
406         https://bugs.webkit.org/show_bug.cgi?id=198833
407
408         Reviewed by Joseph Pecoraro.
409
410         * UserInterface/Views/SettingsTabContentView.css:
411         (.content-view.settings .navigation-bar):
412         (.content-view.settings > .settings-view): Added.
413         (.content-view.settings): Deleted.
414
415 2019-06-10  Devin Rousso  <drousso@apple.com>
416
417         Web Inspector: Timelines: imported recordings do not have JavaScript call trees
418         https://bugs.webkit.org/show_bug.cgi?id=197490
419         <rdar://problem/50589158>
420
421         Reviewed by Joseph Pecoraro.
422
423         * UserInterface/Models/TimelineRecording.js:
424         (WI.TimelineRecording.prototype.initializeCallingContextTrees):
425         Make sure to actually save the provided stack traces and samples in the export data.
426
427         * UserInterface/Models/ScriptTimelineRecord.js:
428         (WI.ScriptTimelineRecord.fromJSON):
429         (WI.ScriptTimelineRecord.prototype.toJSON):
430         Drive-by: include `extraDetails`, which contains useful information like "default prevented".
431
432 2019-06-10  Nikita Vasilyev  <nvasilyev@apple.com>
433
434         REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work
435         https://bugs.webkit.org/show_bug.cgi?id=198508
436         <rdar://problem/51375503>
437
438         Reviewed by Matt Baker.
439
440         It didn't work because the detached sidebar panel tried to access its parent view (this.parentSidebar).
441
442         * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
443         (WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Added.
444         (WI.ComputedStyleDetailsSidebarPanel):
445         * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
446         (WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Deleted.
447         Move computedStyleDetailsPanelShowProperty to ComputedStyleDetailsSidebarPanel since it's the only
448         panel where it's needed.
449
450 2019-06-10  Alexey Shvayka  <shvaikalesh@gmail.com>
451
452         Web Inspector: "Copy Path to Property" doesn't work with multiline keys
453         https://bugs.webkit.org/show_bug.cgi?id=198691
454
455         Reviewed by Matt Baker.
456
457         Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.
458
459         * UserInterface/Base/Utilities.js: Use JSON.stringify.
460
461 2019-06-10  Devin Rousso  <drousso@apple.com>
462
463         Web Inspector: REGRESSION(r246025): prototypes in object previews are visible even when setting `showOnlyJSON`
464         https://bugs.webkit.org/show_bug.cgi?id=198721
465
466         Reviewed by Joseph Pecoraro.
467
468         * UserInterface/Views/ObjectTreeView.css:
469         (.object-tree.properties-only.json-only .object-tree-property.prototype-property): Added.
470         (.object-tree.properties-only.json-only .object-tree-property .prototype-property): Deleted.
471
472 2019-06-07  Nikita Vasilyev  <nvasilyev@apple.com>
473
474         Web Inspector: longhand CSS properties overridden by shorthands miss strikethrough
475         https://bugs.webkit.org/show_bug.cgi?id=198629
476         <rdar://problem/51504160>
477
478         Reviewed by Devin Rousso.
479
480         Longhand CSS properties (e.g. "font-size") overriden by shorthands (e.g. "font") now have strikethroughs.
481
482         * UserInterface/Models/CSSProperty.js:
483         (WI.CSSProperty.prototype.set overridingProperty):
484         (WI.CSSProperty):
485
486         * UserInterface/Models/DOMNodeStyles.js:
487         (WI.DOMNodeStyles.prototype._updateStyleCascade):
488         Call _associateRelatedProperties before _markOverriddenProperties because
489         _associateRelatedProperties sets relatedShorthandProperty property, which
490         is now used by _markOverriddenProperties.
491
492         (WI.DOMNodeStyles.prototype._markOverriddenProperties.isOverriddenBy):
493         (WI.DOMNodeStyles.prototype._markOverriddenProperties):
494
495 2019-06-06  Devin Rousso  <drousso@apple.com>
496
497         Web Inspector: Timelines: remove always disabled details sidebar navigation item
498         https://bugs.webkit.org/show_bug.cgi?id=198393
499
500         Reviewed by Timothy Hatcher.
501
502         * UserInterface/Views/TimelineTabContentView.js:
503         (WI.TimelineTabContentView):
504
505 2019-06-06  Devin Rousso  <drousso@apple.com>
506
507         Web Inspector: REGRESSION(r245833): Timelines: CPU: JavaScript label is missing and JavaScript section of pie chart is black
508         https://bugs.webkit.org/show_bug.cgi?id=198627
509
510         Reviewed by Joseph Pecoraro.
511
512         * UserInterface/Views/CPUTimelineView.js:
513         (WI.CPUTimelineView.displayNameForSampleType):
514         * UserInterface/Views/CPUTimelineView.css:
515         (.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-javascript):
516         (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-javascript): Added.
517         (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-script): Deleted.
518         * UserInterface/Views/CPUUsageCombinedView.css:
519         (.cpu-usage-combined-view > .graph > .range-chart .sample-type-javascript): Added.
520         (.cpu-usage-combined-view > .graph > .range-chart .sample-type-script): Deleted.
521         Use the enum string added in r245833 (`sample-type-javascript`) instead of what was there
522         before (`sample-type-script`).
523
524         * UserInterface/Views/Variables.css:
525         (:root):
526         Rename `--cpu-script-*` to `--cpu-javascript-*`.
527
528 2019-06-06  Devin Rousso  <drousso@apple.com>
529
530         Web Inspector: Formatter: pretty-print CSS using a Worker
531         https://bugs.webkit.org/show_bug.cgi?id=197829
532         <rdar://problem/36891532>
533
534         Reviewed by Timothy Hatcher.
535
536         * UserInterface/Proxies/FormatterWorkerProxy.js:
537         (WI.FormatterWorkerProxy.prototype.formatCSS): Added.
538         * UserInterface/Workers/Formatter/FormatterWorker.js:
539         (FormatterWorker.prototype.formatCSS): Added.
540         * UserInterface/Workers/Formatter/CSSFormatter.js: Added.
541         (CSSFormatter):
542         (CSSFormatter.prototype.get success):
543         (CSSFormatter.prototype.get formattedText):
544         (CSSFormatter.prototype.get sourceMapData):
545         (CSSFormatter.prototype._format):
546
547         * UserInterface/Workers/Formatter/FormatterContentBuilder.js:
548         (FormatterContentBuilder.prototype.get currentLine): Added.
549
550         * UserInterface/Views/TextEditor.js:
551         (WI.TextEditor.prototype._canUseFormatterWorker):
552         (WI.TextEditor.prototype._startWorkerPrettyPrint):
553
554         * .eslintrc:
555
556 2019-06-06  Devin Rousso  <drousso@apple.com>
557
558         Web Inspector: Elements: print/rulers/compositing/paint navigation items shouldn't be visible if the inspected target doesn't have a PageAgent
559         https://bugs.webkit.org/show_bug.cgi?id=198410
560
561         Reviewed by Timothy Hatcher.
562
563         * UserInterface/Views/DOMTreeContentView.js:
564         (WI.DOMTreeContentView):
565         (WI.DOMTreeContentView.prototype.get navigationItems):
566         (WI.DOMTreeContentView.prototype._showRulersChanged):
567
568 == Rolled over to ChangeLog-2019-06-05 ==