Web Inspector: Main.js missing many trailing semicolons
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2014-11-11  Jonathan Wells  <jonowells@apple.com>
2
3         Web Inspector: Main.js missing many trailing semicolons
4         https://bugs.webkit.org/show_bug.cgi?id=138624
5
6         Add semicolons to function variable assignments.
7
8         Reviewed by Timothy Hatcher.
9
10         * UserInterface/Base/Main.js: Added semicolons.
11
12 2014-11-10  Jonathan Wells  <jonowells@apple.com>
13
14         Web Inspector: Update Esprima, remove WebInspector.Esprima global.
15         https://bugs.webkit.org/show_bug.cgi?id=138579
16
17         Reviewed by Timothy Hatcher.
18
19         Update esprima.js file to be unchanged by removing WebInspector.Esprima global object. Move esprima.js include
20         so that all external libraries load before the WebInspector namespace is declared in the combined Main.js.
21
22         * UserInterface/External/Esprima/esprima.js: File updated, no changes made.
23         * UserInterface/Main.html: esprima.js script tag moved up with other externals.
24         * UserInterface/Models/ScriptSyntaxTree.js: WebInspector.Esprima changed to esprima
25         (WebInspector.ScriptSyntaxTree):
26
27 2014-11-10  Jonathan Wells  <jonowells@apple.com>
28
29         Web Inspector: Add infrastructure for eslint based static analyzer
30         https://bugs.webkit.org/show_bug.cgi?id=137890
31
32         Reviewed by Timothy Hatcher.
33
34         Fix to previous patch to add AnalyzerManager and AnalyzerMessage classes. Changed Main.html to include ESLint.js
35         before Main.js in the combined resources.
36
37         * UserInterface/Base/Main.js:
38         * UserInterface/Controllers/AnalyzerManager.js: Added.
39         (WebInspector.AnalyzerManager):
40         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
41         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
42         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
43         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
44         * UserInterface/Main.html:
45         * UserInterface/Models/AnalyzerMessage.js: Added.
46         (WebInspector.AnalyzerMessage):
47         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
48         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
49         (WebInspector.AnalyzerMessage.prototype.get text):
50         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
51         * UserInterface/Models/SourceCode.js:
52
53 2014-11-08  Matt Baker  <mattbaker@apple.com>
54
55         Web Inspector: decouple child element folderization logic from FrameTreeElement
56         https://bugs.webkit.org/show_bug.cgi?id=138364
57
58         Reviewed by Timothy Hatcher.
59
60         Created FolderizedTreeElement base class, which FrameTreeElement now inherits via SourceCodeTreeElement.
61         FolderizedTreeElement uses settings provided by derived classes for labeling subfolders and to determine
62         folder membership for child items.
63
64         * UserInterface/Base/Main.js:
65         (WebInspector.canArchiveMainFrame):
66         * UserInterface/Main.html:
67         * UserInterface/Models/LayoutTimelineRecord.js:
68         (WebInspector.LayoutTimelineRecord.displayNameForEventType):
69         (WebInspector.LayoutTimelineRecord.EventType.displayName): Deleted.
70         * UserInterface/Models/Resource.js:
71         (WebInspector.Resource):
72         (WebInspector.Resource.typeFromMIMEType):
73         (WebInspector.Resource.displayNameForType):
74         (WebInspector.Resource.prototype.get syntheticMIMEType):
75         (WebInspector.Resource.prototype.updateForResponse):
76         (WebInspector.Resource.Type.fromMIMEType): Deleted.
77         (WebInspector.Resource.Type.displayName): Deleted.
78         * UserInterface/Models/SourceMapResource.js:
79         (WebInspector.SourceMapResource):
80         * UserInterface/Views/FolderizedTreeElement.js: Added.
81         (WebInspector.FolderizedTreeElement):
82         (WebInspector.FolderizedTreeElement.prototype.get groupedIntoFolders):
83         (WebInspector.FolderizedTreeElement.prototype.set folderSettingsKey):
84         (WebInspector.FolderizedTreeElement.prototype.registerFolderizeSettings):
85         (WebInspector.FolderizedTreeElement.prototype.set removeChildren):
86         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject):
87         (WebInspector.FolderizedTreeElement.prototype.addRepresentedObjectToNewChildQueue):
88         (WebInspector.FolderizedTreeElement.prototype.removeChildForRepresentedObject):
89         (WebInspector.FolderizedTreeElement.prototype.compareChildTreeElements):
90         (WebInspector.FolderizedTreeElement.prototype.updateParentStatus):
91         (WebInspector.FolderizedTreeElement.prototype._clearNewChildQueue):
92         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
93         (WebInspector.FolderizedTreeElement.prototype._removeRepresentedObjectFromNewChildQueue):
94         (WebInspector.FolderizedTreeElement.prototype._addTreeElement):
95         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
96         (WebInspector.FolderizedTreeElement.prototype._insertFolderTreeElement):
97         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
98         (WebInspector.FolderizedTreeElement.prototype._removeTreeElement):
99         (WebInspector.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
100         (WebInspector.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange):
101         (WebInspector.FolderizedTreeElement.prototype._settingsForRepresentedObject):
102         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
103         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
104         * UserInterface/Views/FrameTreeElement.js:
105         (.this):
106         (WebInspector.FrameTreeElement.prototype.updateSourceMapResources):
107         (WebInspector.FrameTreeElement.prototype.onattach):
108         (WebInspector.FrameTreeElement.prototype.ondetach):
109         (WebInspector.FrameTreeElement.prototype.compareChildTreeElements):
110         (WebInspector.FrameTreeElement.prototype.onpopulate):
111         (WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
112         (WebInspector.FrameTreeElement.prototype._resourceWasAdded):
113         (WebInspector.FrameTreeElement.prototype._resourceWasRemoved):
114         (WebInspector.FrameTreeElement.prototype._childFrameWasAdded):
115         (WebInspector.FrameTreeElement.prototype._childFrameWasRemoved):
116         (WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
117         (WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
118         (WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
119         (WebInspector.FrameTreeElement): Deleted.
120         (WebInspector.FrameTreeElement.prototype.removeChildren): Deleted.
121         (WebInspector.FrameTreeElement.prototype._updateParentStatus): Deleted.
122         (WebInspector.FrameTreeElement.prototype._addRepresentedObjectToNewChildQueue): Deleted.
123         (WebInspector.FrameTreeElement.prototype._removeRepresentedObjectFromNewChildQueue): Deleted.
124         (WebInspector.FrameTreeElement.prototype._populateFromNewChildQueue): Deleted.
125         (WebInspector.FrameTreeElement.prototype._clearNewChildQueue): Deleted.
126         (WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject): Deleted.
127         (WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject): Deleted.
128         (WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject): Deleted.
129         (WebInspector.FrameTreeElement.prototype._addTreeElement): Deleted.
130         (WebInspector.FrameTreeElement.prototype._compareTreeElementsByMainTitle): Deleted.
131         (WebInspector.FrameTreeElement.prototype._insertFolderTreeElement): Deleted.
132         (WebInspector.FrameTreeElement.prototype._compareResourceTreeElements): Deleted.
133         (WebInspector.FrameTreeElement.prototype._insertResourceTreeElement): Deleted.
134         (WebInspector.FrameTreeElement.prototype._removeTreeElement): Deleted.
135         (WebInspector.FrameTreeElement.prototype._folderNameForResourceType): Deleted.
136         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject.createFolderTreeElement): Deleted.
137         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject): Deleted.
138         (WebInspector.FrameTreeElement.prototype._folderTreeElementExpandedStateChange): Deleted.
139         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType): Deleted.
140         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory): Deleted.
141         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders): Deleted.
142         * UserInterface/Views/LayoutTimelineDataGridNode.js:
143         (WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
144         * UserInterface/Views/LayoutTimelineView.js:
145         (WebInspector.LayoutTimelineView): Deleted.
146         * UserInterface/Views/NetworkTimelineView.js:
147         (WebInspector.NetworkTimelineView): Deleted.
148         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
149         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshResourceType):
150         * UserInterface/Views/ResourceTimelineDataGridNode.js:
151         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
152         * UserInterface/Views/SourceCodeTreeElement.js:
153         (WebInspector.SourceCodeTreeElement):
154         * UserInterface/Views/TimelineDataGrid.js:
155         (WebInspector.TimelineDataGrid.createColumnScopeBar):
156         * UserInterface/Views/TimelineRecordTreeElement.js:
157         (WebInspector.TimelineRecordTreeElement):
158         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
159         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
160
161 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
162
163         Web Inspector: Layer summary should be bottom sticky
164         https://bugs.webkit.org/show_bug.cgi?id=138518
165
166         Reviewed by Timothy Hatcher.
167
168         Previously only NavigationSidebars had a content view. Now, give all
169         Sidebars a contentElement section for content.
170
171         Update all Details Sidebars to append content to the contentElement
172         instead of directly to the element. Only two Details sidebars append
173         to the element:
174
175           - CSSStyleDetailsSidebarPanel for the navigation bar at the top
176           - LayerTreeDetailsSidebarPanel for the summary view at the bottom
177
178         Take this opportunity to fix up some naming and styles as well.
179
180         * UserInterface/Views/SidebarPanel.js:
181         (WebInspector.SidebarPanel):
182         (WebInspector.SidebarPanel.prototype.get contentElement):
183         Give every SidebarPanel a content element.
184
185         * UserInterface/Views/DetailsSidebarPanel.css: Removed.
186         (.sidebar > .panel > .content):
187         * UserInterface/Views/SidebarPanel.css: Added.
188         (.sidebar > .panel > .content):
189         And give that content element a default style.
190
191         * UserInterface/Views/NavigationSidebarPanel.css:
192         (.sidebar > .panel.navigation > .content):
193         * UserInterface/Views/NavigationSidebarPanel.js:
194         (WebInspector.NavigationSidebarPanel):
195         (WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
196         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
197         (WebInspector.NavigationSidebarPanel.prototype.get contentElement): Deleted.
198         Navigation sidebar panels now use the parent's contentElement.
199         Also, carry over their default styles, overriding the base.
200
201         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js.
202         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildLayerInfoSection):
203         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
204         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildBottomBar):
205         Rename LayerTreeSidebarPanel to make it clear this is a DetailsSidebarPanel.
206         Add the "bottom bar" to the root element, and sections to the contentElement.
207
208         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css.
209         (.sidebar > .layer-tree.panel > .content):
210         (body.mac-platform.legacy .sidebar > .layer-tree.panel > .content):
211         Style the bottom bar to pin it to the bottom of the sidebar panel.
212
213         (WebInspector.CSSStyleDetailsSidebarPanel):
214         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
215         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
216         Add the navigation bar to the root element, and sections to the contentElement.
217
218         * UserInterface/Base/Main.js:
219         (WebInspector.contentLoaded):
220         * UserInterface/Main.html:
221         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
222         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
223         Update for new names.
224
225         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
226         (WebInspector.ApplicationCacheDetailsSidebarPanel):
227         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
228         * UserInterface/Views/DOMDetailsSidebarPanel.js:
229         (WebInspector.DOMDetailsSidebarPanel):
230         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
231         (WebInspector.DOMNodeDetailsSidebarPanel):
232         * UserInterface/Views/DetailsSidebarPanel.js:
233         (WebInspector.DetailsSidebarPanel):
234         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
235         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
236         (WebInspector.ResourceDetailsSidebarPanel):
237         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
238         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
239         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
240         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
241         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh.delayedWork):
242         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
243         All details sidebar panels now use the contentElement instead of element for content.
244
245 2014-11-07  Timothy Hatcher  <timothy@apple.com>
246
247         Web Inspector: Cursor and scroll view jumps around when modifying styles
248         https://bugs.webkit.org/show_bug.cgi?id=137467
249
250         This merges commit e2962a5b0df56c8ee5a4482899d308decf3d7677 from CodeMirror.
251
252         Reviewed by Joseph Pecoraro.
253
254         * UserInterface/External/CodeMirror/codemirror.js:
255         (maybeScrollWindow): Signal the scrollCursorIntoView event.
256         (signalDOMEvent): Support string events by transforming them to event objects.
257
258         * UserInterface/Views/CodeMirrorAdditions.js:
259         (scrollCursorIntoView): Added. Default event listener that provides our own
260         implementation using WebKit's scrollIntoViewIfNeeded.
261
262         * UserInterface/Views/RulesStyleDetailsPanel.js:
263         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Stop doing an
264         extra scrollIntoViewIfNeeded call, CodeMirror does this.
265
266 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
267
268         Web Inspector: Pseudo element matchedCSSRules do not include matching selector info
269         https://bugs.webkit.org/show_bug.cgi?id=138438
270
271         Reviewed by Benjamin Poulain.
272
273         * UserInterface/Base/Test.js:
274         (WebInspector.loaded):
275         Include a global setting for shadow dom used by DOM model classes.
276         Give it a "test" specific name to not override non-test setting values.
277
278 2014-11-05  Commit Queue  <commit-queue@webkit.org>
279
280         Unreviewed, rolling out r175628.
281         https://bugs.webkit.org/show_bug.cgi?id=138451
282
283         Totally borked the web inspector (Requested by smfr on
284         #webkit).
285
286         Reverted changeset:
287
288         "Web Inspector: Add infrastructure for eslint based static
289         analyzer"
290         https://bugs.webkit.org/show_bug.cgi?id=137890
291         http://trac.webkit.org/changeset/175628
292
293 2014-11-05  Joseph Pecoraro  <pecoraro@apple.com>
294
295         Web Inspector: Specificity not shown for pseudo element styles
296         https://bugs.webkit.org/show_bug.cgi?id=138436
297
298         Reviewed by Benjamin Poulain.
299
300         * UserInterface/Views/CSSStyleDeclarationSection.js:
301         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
302         Previously we were skipping the pre-selector <span>s when we were
303         not getting a listing of matched selector indices, and missing out
304         on the opportunity to give each selector a specificity. Now, always
305         loop over selectors if we have them.
306
307 2014-11-05  Jonathan Wells  <jonowells@apple.com>
308
309         Web Inspector: Add infrastructure for eslint based static analyzer
310         https://bugs.webkit.org/show_bug.cgi?id=137890
311
312         Reviewed by Timothy Hatcher.
313
314         Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.
315
316         * UserInterface/Base/Main.js: Create analyzerManager singleton.
317         * UserInterface/Controllers/AnalyzerManager.js: Added.
318         (WebInspector.AnalyzerManager):
319         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
320         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
321         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
322         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
323         * UserInterface/Main.html: Add new files.
324         * UserInterface/Models/AnalyzerMessage.js: Added.
325         (WebInspector.AnalyzerMessage):
326         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
327         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
328         (WebInspector.AnalyzerMessage.prototype.get text):
329         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
330         * UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().
331
332 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
333
334         Web Inspector: Too much whitespace in resource details sidebar in groups
335         https://bugs.webkit.org/show_bug.cgi?id=138386
336
337         Reviewed by Timothy Hatcher.
338
339         * UserInterface/Views/DetailsSection.css:
340         (.details-section > .content > .group:first-child > .row.simple:first-child > *):
341         (body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *):
342         (body.mac-platform.legacy .details-section > .content > .group > .row.text):
343         (.details-section > .content > .group > .row.properties:not(.empty)):
344         (body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)):
345         Adjust top and bottom padding.
346
347 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
348
349         Web Inspector: Lots of TimelineDataGridNode asserts on reloads
350         https://bugs.webkit.org/show_bug.cgi?id=138387
351
352         Reviewed by Brian Burg.
353
354         The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
355         with a non-0 value and saved in a setting. However the TimelineRuler in
356         the OverviewTimelineView is not initialized with this value, and instead
357         initialized to 0. This patch initializes them to the same non-0 value.
358
359         * UserInterface/Views/OverviewTimelineView.js:
360         (WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):
361         * UserInterface/Views/TimelineContentView.js:
362
363 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
364
365         Web Inspector: Pause on exceptions should show the actual exception
366         https://bugs.webkit.org/show_bug.cgi?id=63096
367
368         Reviewed by Timothy Hatcher.
369
370         * Localizations/en.lproj/localizedStrings.js:
371         * UserInterface/Main.html:
372         New strings / files.
373
374         * UserInterface/Controllers/DebuggerManager.js:
375         (WebInspector.DebuggerManager.prototype.get pauseReason):
376         (WebInspector.DebuggerManager.prototype.get pauseData):
377         (WebInspector.DebuggerManager.prototype.reset):
378         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
379         (WebInspector.DebuggerManager.prototype._pauseReasonFromPayload):
380         Maintain the current pause reason and auxiliary data in the manager.
381
382         * UserInterface/Protocol/DebuggerObserver.js:
383         (WebInspector.DebuggerObserver.prototype.paused):
384         Pass previously unused event parameters on to the manager.
385
386         * UserInterface/Views/ConsoleMessageImpl.js:
387         (WebInspector.ConsoleMessageImpl):
388         Style error objects in the console like Objects. The new description
389         string provides a richer message if you console.log(exception).
390
391         * UserInterface/Views/DebuggerSidebarPanel.js:
392         (WebInspector.DebuggerSidebarPanel):
393         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
394         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
395         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
396         Update the UI when we pause / resume to show / hide a pause reason section.
397
398         * UserInterface/Views/DetailsSectionRow.js:
399         (WebInspector.DetailsSectionRow.prototype.set emptyMessage):
400         Fix a latent bug that would have thrown an exception if the setter was ever used.
401
402         * UserInterface/Views/DetailsSectionTextRow.js: Added.
403         (WebInspector.DetailsSectionTextRow):
404         (WebInspector.DetailsSectionTextRow.prototype.get text):
405         (WebInspector.DetailsSectionTextRow.prototype.set text):
406         * UserInterface/Views/DetailsSection.css:
407         (.details-section > .content > .group > .row.simple.data > .value):
408         (.details-section > .content > .group > .row.text):
409         Simple class for a section of centered text. This is modelled after
410         the empty message text style in other sections.
411
412         * UserInterface/Views/LogContentView.css:
413         (.console-formatted-object, .console-formatted-node, .console-formatted-error):
414         (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-error .section):
415         (.console-formatted-object .properties, .console-formatted-node .properties, .console-formatted-error .properties):
416         Style "error" objects like regular objects. We may wish to treat differently later.
417
418         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
419         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
420         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
421         Regenerate legacy backend commands to get the new enum.
422
423 2014-11-04  Andrei Bucur  <abucur@adobe.com>
424
425         Building WebInspectorUI should not run the clang static analyzer by default
426         https://bugs.webkit.org/show_bug.cgi?id=137652
427
428         Reviewed by Timothy Hatcher.
429
430         There's no need to have the static analyzer enabled at compile time by default for the WebInspectorUI project.
431         It also breaks the ASAN build because the static analyzing step runs using the default compiler not the
432         ASAN clang.
433
434         * Configurations/DebugRelease.xcconfig: Remove the RUN_CLANG_STATIC_ANALYZER variable.
435
436 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
437
438         Web Inspector: Uncaught Exceptions when paused and hovering JavaScript without CallFrames
439         https://bugs.webkit.org/show_bug.cgi?id=138338
440
441         Reviewed by Geoffrey Garen.
442
443         * UserInterface/Views/SourceCodeTextEditor.js:
444         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
445         Fallback to using the main page's context if there is no active call frame we can use.
446
447 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
448
449         Web Inspector: TextEditor search doesn't work after editing contents
450         https://bugs.webkit.org/show_bug.cgi?id=138198
451
452         Reviewed by Timothy Hatcher.
453
454         * UserInterface/Views/SourceCodeTextEditor.js:
455         (WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
456         Fallback to pure TextEditor content searching (CodeMirror) if the editor has edits.
457
458         * UserInterface/Views/TextEditor.js:
459         (WebInspector.TextEditor.prototype.hasEdits):
460         Check the CodeMirror clean state to known if we have edits or not.
461
462 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
463
464         Web Inspector: Show Selector's Specificity
465         https://bugs.webkit.org/show_bug.cgi?id=138189
466
467         Reviewed by Timothy Hatcher.
468
469         * Localizations/en.lproj/localizedStrings.js:
470         * UserInterface/Main.html:
471         * UserInterface/Test.html:
472         Add new files and strings.
473
474         * UserInterface/Models/CSSMedia.js:
475         Constructor functions are not needed, remove unnecessary code.
476
477         * UserInterface/Models/CSSRule.js:
478         (WebInspector.CSSRule.prototype.set selectors): Deleted.
479         This was unused and is no longer correct.
480
481         (WebInspector.CSSRule.prototype.get matchedSelectorText):
482         Update now that selectors are a list of objects, not just strings.
483
484         * UserInterface/Models/CSSSelector.js:
485         (WebInspector.CSSSelector):
486         (WebInspector.CSSSelector.prototype.get specificity):
487         New model object for protocol type CSS.CSSSelector.
488
489         * UserInterface/Models/DOMNodeStyles.js:
490         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
491         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
492         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
493         Handle parsing old and new SelectorLists.
494
495         * UserInterface/Views/CSSStyleDeclarationSection.js:
496         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
497         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelectorText):
498         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
499         Update the code now that the list of selectors are model objects instead
500         of just selector text strings.
501
502 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
503
504         Web Inspector: ALTERNATE_DISPATCHERS Let the frontend know about extra agents
505         https://bugs.webkit.org/show_bug.cgi?id=138236
506
507         Reviewed by Brian Burg.
508
509         * UserInterface/Protocol/InspectorBackend.js:
510         (InspectorBackendClass.prototype.activateDomain):
511         * UserInterface/Protocol/InspectorObserver.js:
512         (WebInspector.InspectorObserver.prototype.activateExtraDomains):
513         * UserInterface/Base/Object.js:
514         * UserInterface/Base/Test.js:
515         * UserInterface/Base/Main.js:
516         (WebInspector.activateExtraDomains):
517         Default state is that there are no extra domains. When extra domains
518         are activated, some agents need to be re-initialized. Dispatch a
519         model event so views also know to re-initialize.
520
521         * UserInterface/Controllers/ApplicationCacheManager.js:
522         (WebInspector.ApplicationCacheManager.prototype._mainResourceDidChange):
523         * UserInterface/Controllers/DOMTreeManager.js:
524         Be more careful about direct agent use during main resource changes.
525         That can happen with a JSContext extended with a Page agent.
526
527         * UserInterface/Controllers/FrameResourceManager.js:
528         (WebInspector.FrameResourceManager):
529         (WebInspector.FrameResourceManager.prototype._mainFrameDidChange):
530         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
531         * UserInterface/Controllers/StorageManager.js:
532         (WebInspector.StorageManager):
533         (WebInspector.StorageManager.prototype._databaseForIdentifier):
534         (WebInspector.StorageManager.prototype._extraDomainsActivated):
535         It is possible new window.FooAgent's are available. Perform expected
536         initialization re-checking if the agents are now available.
537
538         * UserInterface/Models/CSSCompletions.js:
539         Avoid re-initialization if we already did it. This should never
540         happen but this is just to be safe.
541
542         * UserInterface/Views/ResourceSidebarPanel.js:
543         (WebInspector.ResourceSidebarPanel):
544         (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
545         Don't disallow expandable tree elements if this is a JSContext with
546         extra domains. If that JSContext has resources, we would have been
547         unable to see child resources.
548
549 2014-10-30  Dana Burkart  <dburkart@apple.com>
550
551         <rdar://problem/18821260> Prepare for the mysterious future
552
553         Reviewed by Lucas Forschler.
554
555         * Configurations/Base.xcconfig:
556         * Configurations/DebugRelease.xcconfig:
557         * Configurations/Version.xcconfig:
558
559 2014-10-10 Brian J. Burg  <burg@cs.washington.edu>
560
561         Web Inspector: timelines should not count time elapsed while paused in the debugger
562         https://bugs.webkit.org/show_bug.cgi?id=136351
563
564         Reviewed by Timothy Hatcher.
565
566         Don't update the timeline's current time when the debugger is paused.
567
568         Start and end times for timeline records are now in seconds elapsed since timeline
569         recording started, rather than milliseconds since the epoch. Also convert code that
570         tracks page/resource load timings to use elapsed times rather than timestamps.
571
572         Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
573         in multiple agents to elapsed times.
574
575         * UserInterface/Controllers/FrameResourceManager.js:
576         (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
577         (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
578         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
579         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
580         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
581         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
582         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
583         * UserInterface/Controllers/ProbeManager.js:
584         * UserInterface/Controllers/TimelineManager.js:
585         (WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
586         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
587         (WebInspector.TimelineManager.prototype.eventRecorded):
588         (WebInspector.TimelineManager.prototype.pageDidLoad):
589         (WebInspector.TimelineManager.prototype._loadNewRecording):
590         * UserInterface/Models/Probe.js:
591         (WebInspector.ProbeSample):
592         * UserInterface/Models/Resource.js:
593         (WebInspector.Resource.prototype.updateForRedirectResponse):
594         (WebInspector.Resource.prototype.updateForResponse):
595         (WebInspector.Resource.prototype.increaseSize):
596         (WebInspector.Resource.prototype.markAsFinished):
597         (WebInspector.Resource.prototype.markAsFailed):
598         (WebInspector.Resource.prototype.revertMarkAsFinished):
599         * UserInterface/Models/TimelineRecording.js:
600         (WebInspector.TimelineRecording.prototype.computeElapsedTime):
601         * UserInterface/Views/TimelineContentView.js:
602         (WebInspector.TimelineContentView.prototype._debuggerPaused):
603         (WebInspector.TimelineContentView.prototype._debuggerResumed):
604
605
606 2014-10-23  Jono Wells  <jonowells@apple.com>
607
608         Web Inspector: Double border appearing in node sidebar in expanded items in OS X Mavericks.
609         https://bugs.webkit.org/show_bug.cgi?id=138011
610
611         Reviewed by Timothy Hatcher.
612
613         Selector added for OS X Mavericks and earlier versions using .mac-platform.legacy.
614
615         * UserInterface/Views/DetailsSection.css:
616         (body.mac-platform.legacy .details-section .details-section:first-child):
617
618 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
619
620         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
621         https://bugs.webkit.org/show_bug.cgi?id=132044
622
623         Reviewed by Brian Burg.
624
625         Make sure Protocol/InspectorFrontendHostStub.js is loaded before
626         Base/Platform.js, because Platform uses the InspectorFrontendHost
627         object.
628
629         * UserInterface/Main.html:
630
631 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
632
633         Web Inspector: InspectorBackendCommands should include when to activate particular domains
634         https://bugs.webkit.org/show_bug.cgi?id=137753
635
636         Reviewed by Timothy Hatcher.
637
638         * UserInterface/Base/Main.js:
639         * UserInterface/Base/Test.js:
640         (WebInspector.loaded):
641         Activation now happens automatically so remove the hardcoded activations.
642
643         * UserInterface/Protocol/InspectorBackend.js:
644         (InspectorBackendClass.prototype.activateDomain):
645         Given no filter, always activate a domain. Otherwise only activate
646         if the debuggable type matches the provided filter.
647
648         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
649         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
650         Only web debuggables are supported in iOS 6 and 7. The JSON files do not
651         need to change, all agents will auto activate.
652
653         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
654         * Versions/Inspector-iOS-8.0.json:
655         Specify which are web debuggables in iOS 8 since JS inspection is possible.
656
657 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
658
659         Web Inspector: Generate all Inspector domains together in JavaScriptCore
660         https://bugs.webkit.org/show_bug.cgi?id=137748
661
662         Reviewed by Brian Burg.
663
664         Change the frontend to always load all agents, but only activate a subset
665         of the agents depending on the type of the backend.
666
667         * UserInterface/Base/Main.js:
668         (WebInspector.loaded):
669         * UserInterface/Protocol/InspectorBackend.js:
670         (InspectorBackendClass.prototype.activateDomains):
671         (InspectorBackendClass.prototype.activateAllDomains):
672         (InspectorBackendClass.prototype._agentForDomain):
673         (InspectorBackendClass.prototype._dispatchEvent):
674         (InspectorBackend.Agent):
675         (InspectorBackend.Agent.prototype.get active):
676         (InspectorBackend.Agent.prototype.activate):
677         * UserInterface/Base/Test.js:
678         Only expose "window.FooAgent" or allow dispatches in the "Foo" domain
679         when that particular agent is activated. Currently we hardcode the list
680         of agents to activate for a debuggable type. This should be generated.
681
682         * UserInterface/Protocol/LoadInspectorBackendCommands.js:
683         Now there should always be a single "InspectorBackendCommands.js" file to load.
684         We may want to change the RWI path to return a single file instead of an array.
685
686         * Scripts/update-LegacyInspectorBackendCommands.rb:
687         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js.
688         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js.
689         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js.
690         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Removed.
691         * Versions/Inspector-iOS-8.0.json: Renamed from Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json.
692         * Versions/InspectorJS-iOS-8.0.json: Removed.
693         Update Legacy versions to output a single InspectorBackendCommands.js file.
694         Do a straightforward merge of the iOS 8 JS/Web inputs to a single json file.
695
696         * Configurations/Base.xcconfig:
697         * Configurations/DebugRelease.xcconfig:
698         * Configurations/WebInspectorUIFramework.xcconfig:
699         * Scripts/copy-user-interface-resources-dryrun.rb:
700         * Scripts/copy-user-interface-resources.pl:
701         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
702         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
703         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
704         We no longer needed WebCore's Private Headers, so simplify build files
705         and update file names where appropriate.
706
707 2014-10-17  Jono Wells  <jonowells@apple.com>
708
709         Web Inspector: Add ESLint open source library to the inspector
710         https://bugs.webkit.org/show_bug.cgi?id=137714
711
712         Reviewed by Joseph Pecoraro.
713
714         This adds back the eslint.js external library with a correction to Scripts/copy-user-interface-resources.pl
715         to prevent a build failure.
716
717         * Scripts/copy-user-interface-resources.pl: Added copy commands for ESLint.js.
718         * UserInterface/External/ESLint/LICENSE: Added.
719         * UserInterface/External/ESLint/eslint.js: Added.
720
721 2014-10-14  Jono Wells  <jonowells@apple.com>
722
723         Web Inspector: Add ESLint open source library to the inspector
724         https://bugs.webkit.org/show_bug.cgi?id=137714
725
726         Reviewed by Timothy Hatcher.
727
728         This adds the eslint.js external library for static analysis and the necessary license.
729
730         * Scripts/copy-user-interface-resources.pl:
731         * UserInterface/External/ESLint/LICENSE: Added.
732         * UserInterface/External/ESLint/eslint.js: Added.
733
734 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
735
736         Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
737         https://bugs.webkit.org/show_bug.cgi?id=137575
738
739         Reviewed by Simon Fraser.
740
741         Remove setShowPaintRects from the legacy iOS protocol definitions.
742         The methods were unimplemented by the backends, so they should
743         not advertise supporting it.
744
745         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
746         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
747         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
748         * Versions/Inspector-iOS-6.0.json:
749         * Versions/Inspector-iOS-7.0.json:
750         * Versions/InspectorWeb-iOS-8.0.json:
751
752 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
753
754         Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
755         https://bugs.webkit.org/show_bug.cgi?id=137681
756
757         Reviewed by Timothy Hatcher.
758
759         Handle processing instruction node types in more places. The
760         backend sends the contents as a pure string, not as attribute
761         pairs, so just include the string in the UI.
762
763         * UserInterface/Models/DOMSearchMatchObject.js:
764         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
765         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
766         * UserInterface/Views/DOMTreeElement.js:
767         (WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
768         Display the value in the UI.
769
770         * UserInterface/Views/DOMTreeElementPathComponent.js:
771         (WebInspector.DOMTreeElementPathComponent):
772         Include an icon like DOCTYPE.
773
774         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
775         (.syntax-highlighted .html-processing-instruction):
776         Style gray like a DOCTYPE.
777
778 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
779
780         Web Inspector: Paint Flashing button does not match page state after reload
781         https://bugs.webkit.org/show_bug.cgi?id=137680
782
783         Reviewed by Timothy Hatcher.
784
785         * UserInterface/Base/Main.js:
786         (WebInspector.loaded):
787         Make paint flashing a frontend setting. Enable it when the inspector
788         is opened if it was previously enabled.
789
790         * UserInterface/Views/DOMTreeContentView.js:
791         (WebInspector.DOMTreeContentView):
792         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
793         (WebInspector.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
794         Have the paint flashing button always match the global setting.
795
796 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
797
798         Web Inspector: Improve appearance of alpha color swatches
799         https://bugs.webkit.org/show_bug.cgi?id=137627
800
801         Reviewed by Andreas Kling.
802
803         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
804         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
805         * Versions/Inspector-iOS-7.0.json:
806         * Versions/InspectorWeb-iOS-8.0.json:
807
808 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
809
810         Web Inspector: Improve appearance of alpha color swatches
811         https://bugs.webkit.org/show_bug.cgi?id=137627
812
813         Reviewed by Timothy Hatcher.
814
815         This improves the sizes. The color-swatch size is 1em x 1em,
816         which ends up being 11px, and thus there is still an imbalance.
817         However on both 1x and 2x displays this looks more even.
818
819         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
820         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
821
822 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
823
824         Web Inspector: assert always logs undefined instead of the desired string
825         https://bugs.webkit.org/show_bug.cgi?id=137632
826
827         Reviewed by Timothy Hatcher.
828
829         * UserInterface/Protocol/InspectorFrontendAPI.js:
830         (InspectorFrontendAPI.dispatch):
831         Fix the assert log to include the method name.
832
833 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
834
835         Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
836         https://bugs.webkit.org/show_bug.cgi?id=137624
837
838         Reviewed by Timothy Hatcher.
839
840         Be careful when stripping whitespace around "+". We want to strip for
841         selectors "a + b" but not for calc expressions "calc(1px + 2px)".
842
843         This is not a perfect solution, but it does a good job. It may still break
844         with more complex calc expressions, like "calc(1px + calc())" but this
845         handles the basics.
846
847         * Scripts/copy-user-interface-resources-dryrun.rb: Added.
848         * Scripts/cssmin.py:
849         (cssminify):
850
851 2014-10-09  Joseph Pecoraro  <pecoraro@apple.com>
852
853         Web Inspector: DOM Storage Editing is broken in many ways, frustrating
854         https://bugs.webkit.org/show_bug.cgi?id=137547
855
856         Reviewed by Timothy Hatcher.
857
858         * UserInterface/Models/DOMStorageObject.js:
859         (WebInspector.DOMStorageObject.prototype.getEntries): Deleted.
860         When getting entires, populate the model object with these keys/values
861         so we can accurately detect duplicates in editing.
862
863         * UserInterface/Views/DataGrid.js:
864         (WebInspector.DataGrid.prototype.determineNextCell):
865         (WebInspector.DataGrid.prototype.moveToNextCell):
866         When the users uses "Enter" to commit, stop editing.
867
868         (WebInspector.DataGrid.prototype._editingCommitted):
869         Fix title property accessor. This is not a map. This fixes an exception
870         when showing context menus on editable data grid rows.
871
872         * UserInterface/Views/DOMStorageContentView.js:
873         (WebInspector.DOMStorageContentView.prototype.cleanup):
874         (WebInspector.DOMStorageContentView.prototype.restoreOriginalValues):
875         (WebInspector.DOMStorageContentView.prototype._editingCallback):
876         Completely rewrite editing here. As soon as an edit is made, enter
877         an uncommitted state with the original key/value. When a commit is
878         allowed, update as appropriate based on the original values.
879
880 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
881
882         Web Inspector: CSS Pretty Printing fails to put space between value functions around ending parenthesis
883         https://bugs.webkit.org/show_bug.cgi?id=137415
884
885         Reviewed by Timothy Hatcher.
886
887         Add a space after a closing parenthesis if we are still inside a property.
888         This adds space between space separated function lists such as
889         -webkit-transform:foo(...)bar(...). Also add a test for keyframe syntax.
890
891         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
892         * Tools/PrettyPrinting/css-tests/keyframes-expected.css: Added.
893         * Tools/PrettyPrinting/css-tests/keyframes.css: Added.
894         * Tools/PrettyPrinting/index.html:
895         * UserInterface/Views/CodeMirrorFormatters.js:
896
897 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
898
899         Web Inspector: CSS Pretty Printing fails to put space between rgb(...) and numbers in minified gradients
900         https://bugs.webkit.org/show_bug.cgi?id=137414
901
902         Reviewed by Timothy Hatcher.
903
904         Add whitespace between rgb(...) and a number, possible in gradient
905         syntax like "linear-gradient(rgb(...)0%,rgb(...)100%)".
906
907         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
908         * Tools/PrettyPrinting/css-tests/gradient-expected.css: Added.
909         (.dot-nav:nth-child(1n) li a.active):
910         * Tools/PrettyPrinting/css-tests/gradient.css: Added.
911         (.dot-nav:nth-child(1n) li a.active):
912         * Tools/PrettyPrinting/index.html:
913         * UserInterface/Views/CodeMirrorFormatters.js:
914
915 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
916
917         Web Inspector: CSS Pretty Printing fails to wrap long lines of selectors with pseudo classes/elements
918         https://bugs.webkit.org/show_bug.cgi?id=137413
919
920         Reviewed by Timothy Hatcher.
921
922         Long line wrapping was breaking as soon as there was a ':' for a psuedo
923         class or element. Likewise it was counting comment strings as part of
924         the length of the line even though it would get a newline after it.
925
926         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
927         * Tools/PrettyPrinting/css-tests/basic-expected.css:
928         (progress, section, summary, time):
929         * Tools/PrettyPrinting/css-tests/wrapping-expected.css: Added.
930         (a.tryamacs, a.upgradenows):
931         (a.tryamacs:hover, a.upgradenows:hover):
932         * Tools/PrettyPrinting/css-tests/wrapping.css: Added.
933         (a.browsewebappss,a.businessstores,a.buyiphones,a.buynows,a.buynows-arrow,a.comingsoons,p::before,a.descargarahoras,a.downloadituness,a.downloadnows,a.finds,a.freetrials,a.getstarteds,a.gos,a.howtoapplys,a.howtobuys,a.joinnows,a.learnmores,a.nikebuynows,a.notifymes,a.ordernows,a.preordernows,a.preorders,a.reserves,a.startyoursearchs,a.submits,a.tryamacs,a.upgradenows):
934         (a.browsewebappss:hover,a.businessstores:hover,a.buyiphones:hover,a.buynows:hover,a.buynows-arrow:hover,a.comingsoons:hover,p::before,a.descargarahoras:hover,a.downloadituness:hover,a.downloadnows:hover,a.finds:hover,a.freetrials:hover,a.getstarteds:hover,a.gos:hover,a.howtoapplys:hover,a.howtobuys:hover,a.joinnows:hover,a.learnmores:hover,a.nikebuynows:hover,a.notifymes:hover,a.ordernows:hover,a.preordernows:hover,a.preorders:hover,a.reserves:hover,a.startyoursearchs:hover,a.submits:hover,a.tryamacs:hover,a.upgradenows:hover):
935         * Tools/PrettyPrinting/index.html:
936         * UserInterface/Views/CodeMirrorFormatters.js:
937
938 2014-10-04  Joseph Pecoraro  <pecoraro@apple.com>
939
940         Web Inspector: Add PrettyPrinter CSS tests
941         https://bugs.webkit.org/show_bug.cgi?id=134005
942
943         Reviewed by Timothy Hatcher.
944
945         Add CSS pretty printing tests. Improve pretty printing of calc()
946         expressions and media-queries with whitespace around operators
947         and keywords. Also fix the debug output in the tool for CSS.
948
949         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
950         * Tools/PrettyPrinting/FormatterContentBuilder.js:
951         (FormatterContentBuilder.prototype._appendIndent):
952         * Tools/PrettyPrinting/FormatterDebug.js:
953         (.debugToken):
954         (Formatter.prototype.debug):
955         * Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
956         * Tools/PrettyPrinting/css-tests/basic.css: Added.
957         * Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
958         * Tools/PrettyPrinting/css-tests/calc.css: Added.
959         * Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
960         * Tools/PrettyPrinting/css-tests/media-query.css: Added.
961         * Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
962         * Tools/PrettyPrinting/css-tests/selectors.css: Added.
963         * Tools/PrettyPrinting/index.html:
964         * UserInterface/Views/CodeMirrorFormatters.js:
965
966 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
967
968         Unreviewed, rolling out r174319.
969
970         Causes assertions in fast/profiler tests. Needs nontrivial
971         investigation, will take offline.
972
973         Reverted changeset:
974
975         "Web Inspector: timelines should not count time elapsed while
976         paused in the debugger"
977         https://bugs.webkit.org/show_bug.cgi?id=136351
978         http://trac.webkit.org/changeset/174319
979
980 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
981
982         Web Inspector: timelines should not count time elapsed while paused in the debugger
983         https://bugs.webkit.org/show_bug.cgi?id=136351
984
985         Reviewed by Timothy Hatcher.
986
987         Don't update the timeline's current time when the debugger is paused.
988
989         Start and end times for timeline records are now in seconds elapsed since timeline
990         recording started, rather than milliseconds since the epoch. Add a workaround to
991         preserve compatibility with old backends.
992
993         * UserInterface/Controllers/TimelineManager.js:
994         (WebInspector.TimelineManager.prototype.capturingStarted):
995         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
996         (WebInspector.TimelineManager.prototype.eventRecorded):
997         * UserInterface/Views/TimelineContentView.js:
998         (WebInspector.TimelineContentView.prototype._debuggerPaused):
999         (WebInspector.TimelineContentView.prototype._debuggerResumed):
1000
1001 2014-10-03  Saam Barati  <saambarati1@gmail.com>
1002
1003         Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
1004         https://bugs.webkit.org/show_bug.cgi?id=137295
1005
1006         Reviewed by Timothy Hatcher.
1007
1008         The inspector now computes a set of properties that was previously 
1009         computed inside JSC. 
1010
1011         This patch also addresses the weird experience of the 
1012         type of an expression claiming to be both a Number and 
1013         an Integer. This could be a bit confusing because Number 
1014         is supposed to represent Double|Integer and the previous
1015         UI implied that Number was equivalent to Double. The new UI only 
1016         ever shows either the type of Number or Integer when showing
1017         the type information of an expression. It never shows both Number
1018         and Integer simultaneously to describe a single expression.
1019
1020         * UserInterface/Models/TypeSet.js:
1021         (WebInspector.TypeSet):
1022         (WebInspector.TypeSet.prototype.isContainedIn):
1023         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
1024         * UserInterface/Views/TypePropertiesSection.js:
1025         (WebInspector.TypePropertiesSection):
1026         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1027         * UserInterface/Views/TypeTokenView.js:
1028         (WebInspector.TypeTokenView):
1029         (WebInspector.TypeTokenView.prototype.update):
1030         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1031         (WebInspector.TypeTokenView.prototype._displayTypeName):
1032
1033 2014-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1034
1035         Web Inspector: Cannot add a new CSS Rule to elements with 3 or more class names
1036         https://bugs.webkit.org/show_bug.cgi?id=137375
1037
1038         Reviewed by Timothy Hatcher.
1039
1040         Correctly merge all class names with dots instead of just the first two.
1041
1042         * UserInterface/Models/DOMNode.js:
1043
1044 2014-10-02  Mark Lam  <mark.lam@apple.com>
1045
1046         Fixed the Inspector to be able to properly distinguish between scope types.
1047         <https://webkit.org/b/137279>
1048
1049         Reviewed by Geoffrey Garen and Joseph Pecoraro.
1050
1051         * Localizations/en.lproj/localizedStrings.js:
1052         * UserInterface/Controllers/DebuggerManager.js:
1053         * UserInterface/Models/ScopeChainNode.js:
1054         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1055         - Added handling of the FunctionNameScope case.
1056
1057 2014-10-02  Andres Gomez  <agomez@igalia.com>
1058
1059         Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
1060         https://bugs.webkit.org/show_bug.cgi?id=137248
1061
1062         Reviewed by Carlos Garcia Campos.
1063
1064         Add more free icons and removed some unused ones for the Web
1065         Inspector in GTK+.
1066         Also, enhanced the visibility and/or proportion of several of the
1067         icons.
1068
1069         * UserInterface/Images/gtk/AUTHORS:
1070         * UserInterface/Images/gtk/COPYING:
1071         * UserInterface/Images/gtk/Checkers.svg: Added.
1072         * UserInterface/Images/gtk/Circle.svg: Added.
1073         * UserInterface/Images/gtk/CloseLarge.svg: Added.
1074         * UserInterface/Images/gtk/CloseTimeline.png: Removed.
1075         * UserInterface/Images/gtk/CloseTimeline@2x.png: Removed.
1076         * UserInterface/Images/gtk/Crosshair.svg:
1077         * UserInterface/Images/gtk/DOMCharacterData.svg:
1078         * UserInterface/Images/gtk/DOMComment.svg:
1079         * UserInterface/Images/gtk/DOMDocument.svg:
1080         * UserInterface/Images/gtk/DOMDocumentType.svg:
1081         * UserInterface/Images/gtk/DOMElement.svg:
1082         * UserInterface/Images/gtk/DOMNode.svg:
1083         * UserInterface/Images/gtk/DOMTextNode.svg:
1084         * UserInterface/Images/gtk/DOMTree.svg:
1085         * UserInterface/Images/gtk/EventListener.svg:
1086         * UserInterface/Images/gtk/Exception.svg:
1087         * UserInterface/Images/gtk/Function.svg:
1088         * UserInterface/Images/gtk/GradientStop.png: Added.
1089         * UserInterface/Images/gtk/GradientStop@2x.png: Added.
1090         * UserInterface/Images/gtk/GradientStopSelected.png: Added.
1091         * UserInterface/Images/gtk/GradientStopSelected@2x.png: Added.
1092         * UserInterface/Images/gtk/Issues.svg:
1093         * UserInterface/Images/gtk/IssuesEnabled.svg:
1094         * UserInterface/Images/gtk/LessColumns.svg: Removed.
1095         * UserInterface/Images/gtk/Logs.svg:
1096         * UserInterface/Images/gtk/Memory.svg: Removed.
1097         * UserInterface/Images/gtk/MoreColumns.svg: Removed.
1098         * UserInterface/Images/gtk/Native.svg:
1099         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
1100         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
1101         * UserInterface/Images/gtk/NavigationItemBug.svg:
1102         * UserInterface/Images/gtk/NavigationItemFile.svg:
1103         * UserInterface/Images/gtk/NavigationItemLayers.svg:
1104         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
1105         * UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
1106         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
1107         * UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
1108         * UserInterface/Images/gtk/PaintFlashing.svg: Added.
1109         * UserInterface/Images/gtk/PseudoElement.svg:
1110         * UserInterface/Images/gtk/Record.svg: Added.
1111         * UserInterface/Images/gtk/Recording.png: Removed.
1112         * UserInterface/Images/gtk/Recording@2x.png: Removed.
1113         * UserInterface/Images/gtk/RecordingHovered.png: Removed.
1114         * UserInterface/Images/gtk/RecordingHovered@2x.png: Removed.
1115         * UserInterface/Images/gtk/RecordingStopped.png: Removed.
1116         * UserInterface/Images/gtk/RecordingStopped@2x.png: Removed.
1117         * UserInterface/Images/gtk/Reflection.svg:
1118         * UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
1119         * UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
1120         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
1121         * UserInterface/Images/gtk/Request.svg:
1122         * UserInterface/Images/gtk/Resources.svg:
1123         * UserInterface/Images/gtk/Response.svg:
1124         * UserInterface/Images/gtk/ResultLine.svg:
1125         * UserInterface/Images/gtk/SourceCode.svg:
1126         * UserInterface/Images/gtk/Stop.svg: Added.
1127         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
1128         * UserInterface/Images/gtk/StyleRuleInherited.svg:
1129         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
1130         * UserInterface/Images/gtk/StyleRuleInspector.svg:
1131         * UserInterface/Images/gtk/StyleRuleUser.svg:
1132         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
1133         * UserInterface/Images/gtk/Time.svg:
1134         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
1135         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
1136         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
1137         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
1138         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
1139         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
1140         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
1141         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
1142         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
1143         * UserInterface/Images/gtk/Weight.svg:
1144
1145 2014-09-27  Brian J. Burg  <burg@cs.washington.edu>
1146
1147         Web Replay: Playback position updates should be sent before the next event loop input is dispatched
1148         https://bugs.webkit.org/show_bug.cgi?id=137162
1149
1150         Reviewed by Timothy Hatcher.
1151
1152         Pausing playback from the UI was broken because of a typo. Fix this, and rename
1153         stopPlayback to cancelPlayback.
1154
1155         * UserInterface/Controllers/ReplayManager.js:
1156         (WebInspector.ReplayManager.prototype.switchSession.if):
1157
1158 2014-09-26  Joseph Pecoraro  <pecoraro@apple.com>
1159
1160         Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
1161         https://bugs.webkit.org/show_bug.cgi?id=137038
1162
1163         Reviewed by Timothy Hatcher.
1164
1165         * UserInterface/Base/Main.js:
1166         Send the initialized message after we have sent all other setup messages,
1167         such as enabling features and setting breakpoints.
1168
1169 2014-09-26  Saam Barati  <saambarati1@gmail.com>
1170
1171         Web Inspector: Type Token View shows type information on hover when it shouldn't
1172         https://bugs.webkit.org/show_bug.cgi?id=137152
1173
1174         Reviewed by Brian J. Burg.
1175
1176         TypeTokenView should only show type information when there is 
1177         more than one primitive type or more than zero objects types. 
1178         This fixes a bug in checking the length of object types.
1179
1180         * UserInterface/Views/TypeTokenView.js:
1181         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1182
1183 2014-09-25  Timothy Hatcher  <timothy@apple.com>
1184
1185         Web Inspector: Show type info icon is blurry
1186         https://bugs.webkit.org/show_bug.cgi?id=137125
1187
1188         Reviewed by Darin Adler.
1189
1190         * UserInterface/Images/NavigationItemTypes.svg:
1191         * UserInterface/Views/ScriptContentView.js:
1192         (WebInspector.ScriptContentView):
1193         * UserInterface/Views/TextContentView.js:
1194         (WebInspector.TextContentView):
1195         * UserInterface/Views/TextResourceContentView.js:
1196         (WebInspector.TextResourceContentView):
1197
1198 2014-09-25  Saam Barati  <saambarati1@gmail.com>
1199
1200         Web Inspector: console.assert(bitString) TypeSet:50 
1201         https://bugs.webkit.org/show_bug.cgi?id=137051
1202
1203         Reviewed by Joseph Pecoraro.
1204
1205         This fixes TypeSet's isContainedIn method by ensuring that 
1206         the type bit string isn't zero because the test would trivially 
1207         pass if the bit string is zero.
1208
1209         * UserInterface/Models/TypeSet.js:
1210         (WebInspector.TypeSet.prototype.isContainedIn):
1211
1212 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1213
1214         Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
1215         https://bugs.webkit.org/show_bug.cgi?id=136805
1216
1217         Reviewed by Timothy Hatcher.
1218
1219         * UserInterface/Test.html: Add missing include for ScopeChainNode.js.
1220
1221 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1222
1223         Web Inspector: sort probe details sidebar sections by source code location string
1224         https://bugs.webkit.org/show_bug.cgi?id=137080
1225
1226         Reviewed by Timothy Hatcher.
1227
1228         Probe sections should display in the same order as associated breakpoint tree elements.
1229
1230         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1231         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
1232         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
1233
1234 2014-09-25  Andres Gomez  <agomez@igalia.com>
1235
1236         Unreviewed. Add more free icons for the Web Inspector in GTK+.
1237
1238         * UserInterface/Images/gtk/AUTHORS:
1239         * UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
1240         * UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Added.
1241         * UserInterface/Images/gtk/COPYING:
1242         * UserInterface/Images/gtk/COPYING_LGPL2: Added.
1243         * UserInterface/Images/gtk/Cookie.png: Added.
1244         * UserInterface/Images/gtk/Cookie@2x.png: Added.
1245         * UserInterface/Images/gtk/HoverMenuButton.png: Added.
1246         * UserInterface/Images/gtk/HoverMenuButton@2x.png: Added.
1247         * UserInterface/Images/gtk/InstructionPointer.png: Added.
1248         * UserInterface/Images/gtk/InstructionPointer@2x.png: Added.
1249         * UserInterface/Images/gtk/Log.png: Added.
1250         * UserInterface/Images/gtk/Log@2x.png: Added.
1251         * UserInterface/Images/gtk/Profile.png: Added.
1252         * UserInterface/Images/gtk/Profile@2x.png: Added.
1253         * UserInterface/Images/gtk/Recording.png: Added.
1254         * UserInterface/Images/gtk/Recording@2x.png: Added.
1255         * UserInterface/Images/gtk/RecordingHovered.png: Added.
1256         * UserInterface/Images/gtk/RecordingHovered@2x.png: Added.
1257         * UserInterface/Images/gtk/RecordingStopped.png: Added.
1258         * UserInterface/Images/gtk/RecordingStopped@2x.png: Added.
1259         * UserInterface/Images/gtk/Script.png: Added.
1260         * UserInterface/Images/gtk/Script@2x.png: Added.
1261         * UserInterface/Images/gtk/ScriptLarge.png: Added.
1262         * UserInterface/Images/gtk/ScriptLarge@2x.png: Added.
1263         * UserInterface/Images/gtk/SliderThumb.png: Added.
1264         * UserInterface/Images/gtk/SliderThumb@2x.png: Added.
1265         * UserInterface/Images/gtk/SliderThumbPressed.png: Added.
1266         * UserInterface/Images/gtk/SliderThumbPressed@2x.png: Added.
1267         * UserInterface/Images/gtk/Stopwatch.png: Added.
1268         * UserInterface/Images/gtk/Stopwatch@2x.png: Added.
1269
1270 2014-09-21  Timothy Hatcher  <timothy@apple.com>
1271
1272         Make the Web Inspector use a separate web process.
1273
1274         https://bugs.webkit.org/show_bug.cgi?id=135120
1275
1276         Reviewed by Anders Carlsson.
1277
1278         * Localizations/en.lproj/localizedStrings.js: Updated.
1279
1280         * UserInterface/Base/Main.js:
1281         (WebInspector.loaded):
1282         (WebInspector.contentLoaded):
1283         Move InspectorFrontendHost.loaded to later in the load.
1284         Calling it early just shows the window before we have
1285         a user interface to show.
1286
1287         * UserInterface/Base/Test.js:
1288         (WebInspector.loaded):
1289         (WebInspector.contentLoaded):
1290         Match the changes in Main.js.
1291
1292         * UserInterface/Protocol/InspectorFrontendAPI.js:
1293         (InspectorFrontendAPI.savedURL): Change comment.
1294         (InspectorFrontendAPI.appendedToURL): Change comment.
1295         (InspectorFrontendAPI.dispatch): Add an assert and early
1296         return to be safe from unknown commands.
1297         (InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
1298         no need to keep an empty array around a one time use.
1299
1300 2014-09-24  Andres Gomez  <agomez@igalia.com>
1301
1302         Unreviewed. Add more free icons for the Web Inspector in GTK+
1303
1304         * UserInterface/Images/gtk/AUTHORS:
1305         * UserInterface/Images/gtk/ApplicationCache.png: Added.
1306         * UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
1307         * UserInterface/Images/gtk/BottomUpTree.svg: Added.
1308         * UserInterface/Images/gtk/Breakpoint.png: Added.
1309         * UserInterface/Images/gtk/Breakpoint@2x.png: Added.
1310         * UserInterface/Images/gtk/BreakpointButton.svg:
1311         * UserInterface/Images/gtk/BreakpointInactive.png: Added.
1312         * UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
1313         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
1314         * UserInterface/Images/gtk/COPYING:
1315         * UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
1316         * UserInterface/Images/gtk/ClippingCSS.png: Added.
1317         * UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
1318         * UserInterface/Images/gtk/ClippingGeneric.png: Added.
1319         * UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
1320         * UserInterface/Images/gtk/ClippingJS.png: Added.
1321         * UserInterface/Images/gtk/ClippingJS@2x.png: Added.
1322         * UserInterface/Images/gtk/CloseTimeline.png: Added.
1323         * UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
1324         * UserInterface/Images/gtk/ColorIcon.png: Added.
1325         * UserInterface/Images/gtk/ColorIcon@2x.png: Added.
1326         * UserInterface/Images/gtk/Colors.png: Added.
1327         * UserInterface/Images/gtk/Colors@2x.png: Added.
1328         * UserInterface/Images/gtk/ColorsLarge.png: Added.
1329         * UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
1330         * UserInterface/Images/gtk/Database.png: Added.
1331         * UserInterface/Images/gtk/Database@2x.png: Added.
1332         * UserInterface/Images/gtk/DatabaseTable.png: Added.
1333         * UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
1334         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
1335         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
1336         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
1337         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
1338         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
1339         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
1340         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
1341         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
1342         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
1343         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
1344         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
1345         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
1346         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
1347         * UserInterface/Images/gtk/Issues.svg: Added.
1348         * UserInterface/Images/gtk/IssuesEnabled.svg: Added.
1349         * UserInterface/Images/gtk/LayerBorders.svg: Added.
1350         * UserInterface/Images/gtk/LessColumns.svg: Added.
1351         * UserInterface/Images/gtk/LocalStorage.png: Added.
1352         * UserInterface/Images/gtk/LocalStorage@2x.png: Added.
1353         * UserInterface/Images/gtk/Locked.svg: Added.
1354         * UserInterface/Images/gtk/Logs.svg: Added.
1355         * UserInterface/Images/gtk/Memory.svg: Added.
1356         * UserInterface/Images/gtk/MoreColumns.svg: Added.
1357         * UserInterface/Images/gtk/Native.svg: Added.
1358         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
1359         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
1360         * UserInterface/Images/gtk/NavigationItemBug.svg: Added.
1361         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
1362         * UserInterface/Images/gtk/NavigationItemFile.svg: Added.
1363         * UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
1364         * UserInterface/Images/gtk/NavigationItemLog.svg: Added.
1365         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
1366         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
1367         * UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
1368         * UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
1369         * UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
1370         * UserInterface/Images/gtk/Network.png: Added.
1371         * UserInterface/Images/gtk/Network@2x.png: Added.
1372         * UserInterface/Images/gtk/NetworkLarge.png: Added.
1373         * UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
1374         * UserInterface/Images/gtk/Pause.svg: Added.
1375         * UserInterface/Images/gtk/Percent.svg: Added.
1376         * UserInterface/Images/gtk/Plus.svg: Added.
1377         * UserInterface/Images/gtk/PseudoElement.svg: Added.
1378         * UserInterface/Images/gtk/Reflection.svg: Added.
1379         * UserInterface/Images/gtk/Reload.svg: Added.
1380         * UserInterface/Images/gtk/Request.svg: Added.
1381         * UserInterface/Images/gtk/Response.svg: Added.
1382         * UserInterface/Images/gtk/ResultLine.svg: Added.
1383         * UserInterface/Images/gtk/Resume.svg: Added.
1384         * UserInterface/Images/gtk/SessionStorage.png: Added.
1385         * UserInterface/Images/gtk/SessionStorage@2x.png: Added.
1386         * UserInterface/Images/gtk/ShadowDOM.svg: Added.
1387         * UserInterface/Images/gtk/SourceCode.svg: Added.
1388         * UserInterface/Images/gtk/SplitToggleDown.svg: Added.
1389         * UserInterface/Images/gtk/SplitToggleUp.svg: Added.
1390         * UserInterface/Images/gtk/StepInto.svg: Added.
1391         * UserInterface/Images/gtk/StepOut.svg: Added.
1392         * UserInterface/Images/gtk/StepOver.svg: Added.
1393         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
1394         * UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
1395         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
1396         * UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
1397         * UserInterface/Images/gtk/StyleRuleUser.svg: Added.
1398         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
1399         * UserInterface/Images/gtk/Time.svg: Added.
1400         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
1401         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
1402         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
1403         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
1404         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
1405         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
1406         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
1407         * UserInterface/Images/gtk/Undock.svg: Added.
1408         * UserInterface/Images/gtk/UserInputPrompt.svg: Added.
1409         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
1410         * UserInterface/Images/gtk/UserInputResult.svg: Added.
1411         * UserInterface/Images/gtk/Warning.svg: Added.
1412         * UserInterface/Images/gtk/Weight.svg: Added.
1413
1414 2014-09-23  Timothy Hatcher  <timothy@apple.com>
1415
1416         Web Inspector: Remove UserInterface/Images/gtk from Apple builds
1417         https://bugs.webkit.org/show_bug.cgi?id=136955
1418
1419         Reviewed by Joseph Pecoraro.
1420
1421         * Scripts/copy-user-interface-resources.pl:
1422         Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
1423         at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.
1424
1425 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1426
1427         Web Inspector: fix TypeSet hierarchy in TypeTokenView
1428         https://bugs.webkit.org/show_bug.cgi?id=136982
1429
1430         Reviewed by Joseph Pecoraro.
1431
1432         The protocol object representation of TypeSet was being computed 
1433         incorrectly in JSC::TypeSet. This patch fixes that problem
1434         and also asserts that the type information that the Web Inspector
1435         receives is not empty.
1436
1437         * UserInterface/Models/TypeSet.js:
1438         (WebInspector.TypeSet):
1439         * UserInterface/Views/TypeTokenView.js:
1440         (WebInspector.TypeTokenView.prototype._displayTypeName):
1441
1442 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1443
1444         Web Inspector: unlocalized 'many' string in type profiler inline bubble
1445         https://bugs.webkit.org/show_bug.cgi?id=136980
1446
1447         Reviewed by Timothy Hatcher.
1448
1449         Generate the localizable string for the type profiler's "many" inline bubble.
1450
1451         * Localizations/en.lproj/localizedStrings.js:
1452         * UserInterface/Views/TypeTokenView.js:
1453
1454 2014-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1455
1456         Web Inspector: Option+Click on CSS url(...) should jump to resource view
1457         https://bugs.webkit.org/show_bug.cgi?id=136965
1458
1459         Reviewed by Timothy Hatcher.
1460
1461         * UserInterface/Views/CodeMirrorAdditions.js:
1462         When parsing CSS url(...) tokens, the contents of url(...)
1463         are a "string" type, not "atom".
1464
1465 2014-09-19  Daniel Bates  <dabates@apple.com>
1466
1467         Always assume internal SDK when building configuration Production
1468         https://bugs.webkit.org/show_bug.cgi?id=136925
1469         <rdar://problem/18362399>
1470
1471         Reviewed by Dan Bernstein.
1472
1473         * Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig
1474         to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
1475         (e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).
1476
1477 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1478
1479         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1480         https://bugs.webkit.org/show_bug.cgi?id=136632
1481
1482         Reviewed by Gustavo Noronha Silva.
1483
1484         Add free icons for the GTK port. These icons are from the GNOME
1485         project, some of them adapted by Andres Gomez for the inspector.
1486         This is only a subset of the icons, since we still don't have a
1487         free replacement for all of them, but at least it makes the
1488         inspector kind of usable.
1489
1490         * UserInterface/Images/gtk/AUTHORS: Added.
1491         * UserInterface/Images/gtk/BackArrow.svg: Added.
1492         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
1493         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
1494         * UserInterface/Images/gtk/BreakpointButton.svg: Added.
1495         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
1496         * UserInterface/Images/gtk/Breakpoints.svg: Added.
1497         * UserInterface/Images/gtk/COPYING: Added.
1498         * UserInterface/Images/gtk/Close.svg: Added.
1499         * UserInterface/Images/gtk/CloseWhite.svg: Added.
1500         * UserInterface/Images/gtk/ContentFlow.svg: Added.
1501         * UserInterface/Images/gtk/Crosshair.svg: Added.
1502         * UserInterface/Images/gtk/DOMCharacterData.svg: Added.
1503         * UserInterface/Images/gtk/DOMComment.svg: Added.
1504         * UserInterface/Images/gtk/DOMDocument.svg: Added.
1505         * UserInterface/Images/gtk/DOMDocumentType.svg: Added.
1506         * UserInterface/Images/gtk/DOMElement.svg: Added.
1507         * UserInterface/Images/gtk/DOMNode.svg: Added.
1508         * UserInterface/Images/gtk/DOMTextNode.svg: Added.
1509         * UserInterface/Images/gtk/DOMTree.svg: Added.
1510         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
1511         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
1512         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
1513         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
1514         * UserInterface/Images/gtk/DockBottom.svg: Added.
1515         * UserInterface/Images/gtk/DockRight.svg: Added.
1516         * UserInterface/Images/gtk/DocumentCSS.png: Added.
1517         * UserInterface/Images/gtk/DocumentCSS@2x.png: Added.
1518         * UserInterface/Images/gtk/DocumentFont.png: Added.
1519         * UserInterface/Images/gtk/DocumentFont@2x.png: Added.
1520         * UserInterface/Images/gtk/DocumentGeneric.png: Added.
1521         * UserInterface/Images/gtk/DocumentGeneric@2x.png: Added.
1522         * UserInterface/Images/gtk/DocumentImage.png: Added.
1523         * UserInterface/Images/gtk/DocumentImage@2x.png: Added.
1524         * UserInterface/Images/gtk/DocumentJS.png: Added.
1525         * UserInterface/Images/gtk/DocumentJS@2x.png: Added.
1526         * UserInterface/Images/gtk/DocumentMarkup.png: Added.
1527         * UserInterface/Images/gtk/DocumentMarkup@2x.png: Added.
1528         * UserInterface/Images/gtk/DownloadArrow.svg: Added.
1529         * UserInterface/Images/gtk/Error.svg: Added.
1530         * UserInterface/Images/gtk/Errors.svg: Added.
1531         * UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
1532         * UserInterface/Images/gtk/EventListener.svg: Added.
1533         * UserInterface/Images/gtk/Exception.svg: Added.
1534         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
1535         * UserInterface/Images/gtk/FolderGeneric.png: Added.
1536         * UserInterface/Images/gtk/FolderGeneric@2x.png: Added.
1537         * UserInterface/Images/gtk/ForwardArrow.svg: Added.
1538         * UserInterface/Images/gtk/Function.svg: Added.
1539         * UserInterface/Images/gtk/GoToArrow.svg: Added.
1540         * UserInterface/Images/gtk/Resources.svg: Added.
1541         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
1542         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
1543         * UserInterface/Images/gtk/UpDownArrows.svg: Added.
1544
1545 2014-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1546
1547         Web Inspector: Remove unnecessary prefixes in WebInspectorUI CSS
1548         https://bugs.webkit.org/show_bug.cgi?id=136905
1549
1550         Reviewed by Timothy Hatcher.
1551
1552         Removed vendor prefixes from justify-content and a few lingering
1553         occurances with transition, box-shadow, and display.
1554
1555         * UserInterface/Views/BreakpointActionView.css:
1556         * UserInterface/Views/BreakpointTreeElement.css:
1557         * UserInterface/Views/ButtonNavigationItem.css:
1558         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1559         * UserInterface/Views/ControlToolbarItem.css:
1560         * UserInterface/Views/DebuggerDashboardView.css:
1561         * UserInterface/Views/DefaultDashboardView.css:
1562         * UserInterface/Views/FontResourceContentView.css:
1563         * UserInterface/Views/ImageResourceContentView.css:
1564         * UserInterface/Views/LayerTreeSidebarPanel.css:
1565         * UserInterface/Views/Main.css:
1566         * UserInterface/Views/NavigationBar.css:
1567         * UserInterface/Views/NavigationSidebarPanel.css:
1568         * UserInterface/Views/Popover.css:
1569         * UserInterface/Views/ReplayDashboardView.css:
1570         * UserInterface/Views/Toolbar.css:
1571
1572 2014-09-17  Dean Jackson  <dino@apple.com>
1573
1574         WebInpector can use unprefixed flexbox
1575         https://bugs.webkit.org/show_bug.cgi?id=136899
1576
1577         Reviewed by Joseph Pecoraro.
1578
1579         Now the inspector UI itself can use a non-prefixed flexbox. This was
1580         a basic search and replace for the following properties:
1581         - align-content
1582         - align-items
1583         - align-self
1584         - flex-basis
1585         - flex-direction
1586         - flex-wrap
1587         - flex-grow
1588         - flex-shrink
1589         - flex
1590         - flex-flow
1591         - justify
1592
1593         * UserInterface/Views/ButtonToolbarItem.css:
1594         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1595         * UserInterface/Views/ContentBrowser.css:
1596         * UserInterface/Views/ControlToolbarItem.css:
1597         * UserInterface/Views/DebuggerDashboardView.css:
1598         * UserInterface/Views/DefaultDashboardView.css:
1599         * UserInterface/Views/FilterBar.css:
1600         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
1601         * UserInterface/Views/FontResourceContentView.css:
1602         * UserInterface/Views/HierarchicalPathComponent.css:
1603         * UserInterface/Views/ImageResourceContentView.css:
1604         * UserInterface/Views/LayerTreeSidebarPanel.css:
1605         * UserInterface/Views/LogContentView.css:
1606         * UserInterface/Views/Main.css:
1607         * UserInterface/Views/NavigationBar.css:
1608         * UserInterface/Views/NavigationSidebarPanel.css:
1609         * UserInterface/Views/Popover.css:
1610         * UserInterface/Views/QuickConsole.css:
1611         * UserInterface/Views/ReplayDashboardView.css:
1612         * UserInterface/Views/ResourceSidebarPanel.css:
1613         * UserInterface/Views/Toolbar.css:
1614
1615 2014-09-16  Dean Jackson  <dino@apple.com>
1616
1617         Add unprefixed flexbox display values and property names/values
1618         https://bugs.webkit.org/show_bug.cgi?id=136880
1619         <rdar://problem/18361137>
1620
1621         Reviewed by Benjamin Poulain with some extra comments by Joseph Pecoraro.
1622
1623         * UserInterface/Models/CSSKeywordCompletions.js: Switch to all the unprefixed
1624         flex properties.
1625
1626 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1627
1628         Web Inspector: Add Versioned Inspector protocol JSON files for iOS 8.0
1629         https://bugs.webkit.org/show_bug.cgi?id=136873
1630
1631         Reviewed by Timothy Hatcher.
1632
1633         * Scripts/update-LegacyInspectorBackendCommands.rb:
1634         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Added.
1635         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js: Added.
1636         * Versions/InspectorJS-iOS-8.0.json: Added.
1637         * Versions/InspectorWeb-iOS-8.0.json: Added.
1638
1639 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1640
1641         Web Inspector: Fix ESLint no-extra-bind warnings
1642         https://bugs.webkit.org/show_bug.cgi?id=136659
1643
1644         Reviewed by Timothy Hatcher.
1645
1646         * .eslintrc:
1647         * UserInterface/Controllers/LayerTreeManager.js:
1648         (WebInspector.LayerTreeManager.prototype.layersForNode):
1649
1650 2014-09-15  Matt Baker  <mattbaker@apple.com>
1651
1652         Web Inspector: mouse drifts away from resizer when resizing docked inspector
1653         https://bugs.webkit.org/show_bug.cgi?id=22263
1654
1655         Reviewed by Joseph Pecoraro.
1656
1657         Modified the docked resizer dragging logic to record the initial mouse down position relative to the
1658         resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
1659         correctly with respect to the resize direction before updating the attached window dimension.
1660
1661         * UserInterface/Base/Main.js:
1662         (WebInspector._dockedResizerMouseDown.dockedResizerDrag):
1663
1664 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1665
1666         Web Inspector: Fix assert in QuickConsole - main frame execution context path component
1667         https://bugs.webkit.org/show_bug.cgi?id=136748
1668
1669         Reviewed by Timothy Hatcher.
1670
1671         This can get called for the MainFrame on page navigations.
1672         In such cases we can return a better result from this method.
1673
1674         * UserInterface/Views/QuickConsole.js:
1675         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1676
1677 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1678
1679         Web Inspector: Hide DOM search result highlights when find banner is not showing
1680         https://bugs.webkit.org/show_bug.cgi?id=136749
1681
1682         Reviewed by Timothy Hatcher.
1683
1684         Match search highlights in TextEditor by only showing the highlight
1685         when the find banner is showing.
1686
1687         * UserInterface/Views/DOMTreeOutline.css:
1688         (.showing-find-banner .dom-tree-outline .search-result):
1689         (.dom-tree-outline .search-highlight): Deleted.
1690
1691 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1692
1693         Web Inspector: DOM Tree search highlights are not appearing
1694         https://bugs.webkit.org/show_bug.cgi?id=136662
1695
1696         Reviewed by Timothy Hatcher.
1697
1698         When performing a search within the DOMTreeContentView all
1699         search results should immediately highlight. When moving
1700         between search results, emphasize the current with a bouncy.
1701         Remember to remove the highlights when the search is changed
1702         or cleared.
1703
1704         * UserInterface/Views/DOMTreeContentView.js:
1705         (WebInspector.DOMTreeContentView.prototype.performSearch.searchResultsReady):
1706         (WebInspector.DOMTreeContentView.prototype.searchCleared):
1707         Shor or hide highlights when searches change.
1708
1709         (WebInspector.DOMTreeContentView.prototype.revealResult):
1710         (WebInspector.DOMTreeContentView.prototype._revealSearchResult):
1711         Emphasize the highlight when moving to a new current result.
1712
1713         (WebInspector.DOMTreeContentView.prototype._showSearchHighlights):
1714         (WebInspector.DOMTreeContentView.prototype._hideSearchHighlights):
1715         On each affected DOMTreeElement show or hide search highlights.
1716
1717         * UserInterface/Views/DOMTreeElement.js:
1718         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1719         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1720         Give a brief bouncy-highlight when told to emphasize the search highlight.
1721
1722         (WebInspector.DOMTreeElement.prototype.updateTitle):
1723         Remove unused and unnecessary style class on each row.
1724
1725         (WebInspector.DOMTreeElement.prototype._highlightSearchResults):
1726         Update the stale code to use new function names and accessors.
1727
1728         * UserInterface/Views/DOMTreeOutline.css:
1729         (.dom-tree-outline .search-highlight):
1730         Styles for the search highlight match search highlights in the sidebar.
1731
1732         * UserInterface/Views/Main.css:
1733         (.bouncy-highlight):
1734         * UserInterface/Views/TextEditor.css:
1735         Move bouncy-highlight to Main.css.
1736
1737 2014-09-10  Saam Barati  <saambarati1@gmail.com>
1738
1739         Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
1740         https://bugs.webkit.org/show_bug.cgi?id=136500
1741
1742         Reviewed by Joseph Pecoraro.
1743
1744         This patch maintains the same UI in the Web Inspector for displaying
1745         type information, but now accounts for the new protocol for type profiling.
1746         
1747         The Inspector now has a TypeSet class that wraps the TypeDescription 
1748         protocol object and creates a simple interface for asking protocol objects 
1749         about their type.
1750
1751         * UserInterface/Controllers/TypeTokenAnnotator.js:
1752         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
1753         * UserInterface/Main.html:
1754         * UserInterface/Models/TypeSet.js: Added.
1755         (WebInspector.TypeSet):
1756         (WebInspector.TypeSet.fromPayload):
1757         (WebInspector.TypeSet.prototype.isContainedIn):
1758         * UserInterface/Views/SourceCodeTextEditor.js:
1759         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1760         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1761         * UserInterface/Views/TypePropertiesSection.js:
1762         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1763         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
1764         * UserInterface/Views/TypeTokenView.js:
1765         (WebInspector.TypeTokenView.prototype.update):
1766         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1767         (WebInspector.TypeTokenView.prototype._displayTypeName):
1768
1769 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1770
1771         Web Inspector: Eliminate typeof "undefined" checks
1772         https://bugs.webkit.org/show_bug.cgi?id=136691
1773
1774         Reviewed by Alexey Proskuryakov.
1775
1776         * UserInterface/Base/Main.js:
1777         (WebInspector.linkifyURLAsNode):
1778         (WebInspector.linkifyStringAsFragment):
1779         * UserInterface/Protocol/InspectorBackend.js:
1780         (InspectorBackend.Command.prototype._invokeWithArguments):
1781         * UserInterface/Views/DataGrid.js:
1782         (WebInspector.DataGrid.prototype.get resizeMethod):
1783         * UserInterface/Views/NavigationBar.js:
1784         (WebInspector.NavigationBar.prototype.get minimumWidth):
1785
1786 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1787
1788         Web Inspector: Fix obscure ESLint warnings and skip directories
1789         https://bugs.webkit.org/show_bug.cgi?id=136686
1790
1791         Reviewed by Timothy Hatcher.
1792
1793         * .eslintignore: Added.
1794         Skip directories we do not want ESLint to process.
1795
1796         * .eslintrc:
1797         Add rules we've seen and sort sections.
1798
1799         * UserInterface/Controllers/FormatterContentBuilder.js:
1800         (FormatterContentBuilder.prototype._appendIndent):
1801         * UserInterface/Models/Color.js:
1802         * UserInterface/Models/DOMNodeStyles.js:
1803         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1804         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1805         * UserInterface/Views/DOMTreeDataGridNode.js:
1806         * UserInterface/Views/DOMTreeElement.js:
1807         (WebInspector.DOMTreeElement.prototype.ondelete):
1808         (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
1809         (WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
1810         * UserInterface/Views/EditingSupport.js:
1811         (WebInspector.EditingConfig):
1812         * UserInterface/Views/LayerTreeDataGridNode.js:
1813         (WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
1814         * UserInterface/Views/TreeOutline.js:
1815         (TreeOutline.prototype.appendChild):
1816         (TreeOutline.prototype.insertChild):
1817         (TreeOutline.prototype.removeChildAtIndex):
1818         (TreeOutline.prototype.removeChild):
1819         (TreeElement.prototype.expandRecursively):
1820         Fix linter issues.
1821
1822 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1823
1824         Web Inspector: Fix ESLint consistent-return warnings
1825         https://bugs.webkit.org/show_bug.cgi?id=136682
1826
1827         Reviewed by Timothy Hatcher.
1828
1829         * .eslintrc:
1830         * UserInterface/Controllers/BranchManager.js:
1831         (WebInspector.BranchManager.prototype.createBranch):
1832         * UserInterface/Controllers/FrameResourceManager.js:
1833         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
1834         * UserInterface/Models/DOMNodeStyles.js:
1835         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1836         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1837         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
1838         * UserInterface/Views/DOMTreeElement.js:
1839         (WebInspector.DOMTreeElement.prototype.showChild):
1840         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
1841         (WebInspector.DOMTreeElement.prototype._startEditing):
1842         * UserInterface/Views/EditingSupport.js:
1843         * UserInterface/Views/EventListenerSectionGroup.js:
1844         (WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
1845         * UserInterface/Views/FrameContentView.js:
1846         (WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
1847         * UserInterface/Views/NavigationBar.js:
1848         (WebInspector.NavigationBar.prototype.insertNavigationItem):
1849         (WebInspector.NavigationBar.prototype.removeNavigationItem):
1850         * UserInterface/Views/QuickConsole.js:
1851         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1852         * UserInterface/Views/Sidebar.js:
1853         (WebInspector.Sidebar.prototype.addSidebarPanel):
1854         (WebInspector.Sidebar.prototype.removeSidebarPanel):
1855         * UserInterface/Views/TextEditor.js:
1856         (WebInspector.TextEditor.prototype.addStyleClassToLine):
1857         (WebInspector.TextEditor.prototype.removeStyleClassFromLine):
1858         (WebInspector.TextEditor.prototype.toggleStyleClassForLine):
1859
1860 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1861
1862         Web Inspector: Fix ESLint no-undef warnings
1863         https://bugs.webkit.org/show_bug.cgi?id=136660
1864
1865         Reviewed by Timothy Hatcher.
1866
1867         * UserInterface/Models/DOMSearchMatchObject.js:
1868         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
1869         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1870         * UserInterface/Models/Gradient.js:
1871         (WebInspector.Gradient.fromString):
1872         * UserInterface/Views/CodeMirrorAdditions.js:
1873         * UserInterface/Views/ReplayDashboardView.js:
1874         (WebInspector.ReplayDashboardView):
1875
1876 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1877
1878         Web Inspector: Remove unused Console search highlight methods
1879         https://bugs.webkit.org/show_bug.cgi?id=136661
1880
1881         Reviewed by Timothy Hatcher.
1882
1883         ESLint's no-undef warning complained about some undefined references
1884         in these functions that would have thrown exceptions. Turns out this
1885         code is unused, and we do highlighting in the console separately.
1886
1887         * UserInterface/Views/ConsoleCommand.js:
1888         (WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
1889         (WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
1890         (WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
1891         * UserInterface/Views/ConsoleMessageImpl.js:
1892         (WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
1893         (WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
1894         (WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
1895
1896 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1897
1898         Web Inspector: Fix ESLint* no-avoidable-bind warnings
1899         https://bugs.webkit.org/show_bug.cgi?id=136690
1900
1901         Reviewed by Timothy Hatcher.
1902
1903         * UserInterface/Protocol/RemoteObject.js:
1904         (WebInspector.LocalJSONObject.prototype._children):
1905         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1906         (WebInspector.CSSStyleDetailsSidebarPanel):
1907         * UserInterface/Views/LayerTreeSidebarPanel.js:
1908         (WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
1909         * UserInterface/Views/LogContentView.js:
1910         (WebInspector.LogContentView.prototype._filterMessages):
1911         * UserInterface/Views/TextResourceContentView.js:
1912         (WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
1913
1914 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
1915
1916         Disable the "unreachable-code" warning
1917         https://bugs.webkit.org/show_bug.cgi?id=136677
1918
1919         Reviewed by Darin Adler.
1920
1921         * Configurations/Base.xcconfig:
1922
1923 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1924
1925         Web Inspector: Fix ESLint no-trailing-spaces warnings
1926         https://bugs.webkit.org/show_bug.cgi?id=136657
1927
1928         Reviewed by Andy Estes.
1929
1930         * .eslintrc:
1931         * UserInterface/Base/DOMUtilities.js:
1932         * UserInterface/Base/URLUtilities.js:
1933         (relativePath):
1934         * UserInterface/Base/Utilities.js:
1935         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
1936         (WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
1937         * UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
1938         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
1939         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
1940         * UserInterface/Controllers/CodeMirrorEditingController.js:
1941         (WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
1942         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
1943         (WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
1944         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1945         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1946         * UserInterface/Controllers/DragToAdjustController.js:
1947         (WebInspector.DragToAdjustController.prototype.set active):
1948         (WebInspector.DragToAdjustController.prototype._setDragging):
1949         (WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
1950         * UserInterface/External/Esprima/esprima.js:
1951         * UserInterface/Models/ApplicationCacheFrame.js:
1952         (WebInspector.ApplicationCacheFrame):
1953         * UserInterface/Models/ApplicationCacheManifest.js:
1954         (WebInspector.ApplicationCacheManifest):
1955         (WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
1956         * UserInterface/Models/CookieStorageObject.js:
1957         * UserInterface/Models/DOMSearchMatchObject.js:
1958         (WebInspector.DOMSearchMatchObject.prototype.get title):
1959         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1960         * UserInterface/Models/DatabaseObject.js:
1961         (WebInspector.DatabaseObject.prototype.getTableNames):
1962         * UserInterface/Models/DatabaseTableObject.js:
1963         (WebInspector.DatabaseTableObject):
1964         * UserInterface/Models/Gradient.js:
1965         (WebInspector.Gradient.fromString):
1966         (WebInspector.RadialGradient.prototype.toString):
1967         * UserInterface/Models/IssueMessage.js:
1968         (WebInspector.IssueMessage.prototype._formatTextIfNecessary):
1969         * UserInterface/Models/Resource.js:
1970         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
1971         (WebInspector.Resource.prototype.getImageSize):
1972         * UserInterface/Models/Script.js:
1973         (WebInspector.Script.prototype._makeSyntaxTree):
1974         * UserInterface/Models/SourceCodeLocation.js:
1975         (WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
1976         * UserInterface/Models/TextMarker.js:
1977         * UserInterface/Protocol/PageObserver.js:
1978         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
1979         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
1980         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
1981         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
1982         * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
1983         (WebInspector.ApplicationCacheFrameTreeElement):
1984         * UserInterface/Views/ApplicationCacheManifestTreeElement.js:
1985         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
1986         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
1987         * UserInterface/Views/ButtonNavigationItem.js:
1988         (WebInspector.ButtonNavigationItem):
1989         * UserInterface/Views/ColorPicker.js:
1990         * UserInterface/Views/ColorWheel.js:
1991         (WebInspector.ColorWheel.prototype._draw):
1992         * UserInterface/Views/CompletionSuggestionsView.js:
1993         (WebInspector.CompletionSuggestionsView.prototype.show):
1994         * UserInterface/Views/ConsoleCommand.js:
1995         * UserInterface/Views/ConsolePrompt.js:
1996         * UserInterface/Views/ContentFlowTreeElement.js:
1997         * UserInterface/Views/CookieStorageTreeElement.js:
1998         (WebInspector.CookieStorageTreeElement):
1999         * UserInterface/Views/EventListenerSectionGroup.js:
2000         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
2001         * UserInterface/Views/GeneralTreeElementPathComponent.js:
2002         * UserInterface/Views/GoToLineDialog.js:
2003         (WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
2004         * UserInterface/Views/LayerTreeDataGridNode.js:
2005         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
2006         * UserInterface/Views/LayerTreeSidebarPanel.js:
2007         * UserInterface/Views/LogContentView.js:
2008         (WebInspector.LogContentView.prototype._highlightRanges):
2009         * UserInterface/Views/NavigationBar.js:
2010         (WebInspector.NavigationBar):
2011         * UserInterface/Views/NavigationItem.js:
2012         (WebInspector.NavigationItem):
2013         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
2014         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
2015         * UserInterface/Views/ScopeBar.js:
2016         * UserInterface/Views/ScopeBarItem.js:
2017         (WebInspector.ScopeBarItem):
2018         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
2019         (WebInspector.ScopeChainDetailsSidebarPanel):
2020         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2021         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2022         * UserInterface/Views/ScriptTreeElement.js:
2023         (WebInspector.ScriptTreeElement):
2024         * UserInterface/Views/SearchBar.js:
2025         * UserInterface/Views/SearchResultTreeElement.js:
2026         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2027         * UserInterface/Views/Slider.js:
2028
2029 2014-09-09  Joseph Pecoraro  <pecoraro@apple.com>
2030
2031         Web Inspector: Fix ESLint eqeqeq warnings
2032         https://bugs.webkit.org/show_bug.cgi?id=136658
2033
2034         Reviewed by Andy Estes.
2035
2036         * UserInterface/Controllers/DOMTreeManager.js:
2037         (WebInspector.DOMTreeManager.prototype.mycallback):
2038         (WebInspector.DOMTreeManager.prototype.searchResult):
2039         * UserInterface/Models/Breakpoint.js:
2040         (WebInspector.Breakpoint.prototype.clearActions):
2041         * UserInterface/Models/DOMTree.js:
2042         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
2043         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
2044         (WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
2045         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2046         * UserInterface/Models/ProbeSet.js:
2047         (WebInspector.ProbeSet.prototype.removeProbe):
2048         * UserInterface/Models/ProbeSetDataTable.js:
2049         (WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
2050         * UserInterface/Views/CodeMirrorAdditions.js:
2051         * UserInterface/Views/CookieStorageContentView.js:
2052         (WebInspector.CookieStorageContentView.prototype._filterCookies):
2053         (WebInspector.cookieMatchesResourceURL):
2054         * UserInterface/Views/DOMStorageContentView.js:
2055         (WebInspector.DOMStorageContentView.prototype._editingCallback):
2056         * UserInterface/Views/DOMTreeElement.js:
2057         (WebInspector.DOMTreeElement):
2058         (WebInspector.DOMTreeElement.prototype._updateChildren):
2059         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
2060         (WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
2061         * UserInterface/Views/DataGrid.js:
2062         (WebInspector.DataGrid.prototype._resizerDragging):
2063         * UserInterface/Views/DatabaseContentView.js:
2064         (WebInspector.DatabaseContentView.prototype._queryError):
2065         * UserInterface/Views/DetailsSectionSimpleRow.js:
2066         (.valueElementClicked):
2067         (WebInspector.DetailsSectionSimpleRow):
2068         * UserInterface/Views/Slider.js:
2069         (WebInspector.Slider.prototype.get _maxX):
2070         * UserInterface/Views/TreeOutline.js:
2071         (TreeElement.prototype.expand):
2072
2073 2014-09-09  Jono Wells  <jonowells@apple.com>
2074
2075         Web Inspector: Fix ESLint no-extra-semi
2076         https://bugs.webkit.org/show_bug.cgi?id=136666
2077
2078         Reviewed by Andy Estes.
2079
2080         Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
2081         semicolons as identified by ESLint.
2082
2083         * .eslintrc:
2084         * Tools/PrettyPrinting/Formatter.js:
2085         (Formatter):
2086         * UserInterface/Controllers/Formatter.js:
2087         (Formatter):
2088         * UserInterface/Models/Resource.js:
2089         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
2090         (WebInspector.Resource.prototype.getImageSize):
2091         * UserInterface/Views/LayerTreeSidebarPanel.js:
2092         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
2093         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
2094         * UserInterface/Views/ObjectPropertiesSection.js:
2095         (WebInspector.ObjectPropertyTreeElement.prototype.callback):
2096         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
2097
2098 2014-09-09  Jono Wells  <jonowells@apple.com>
2099
2100         Web Inspector: Fix ESLint semi (missing semicolon)
2101         https://bugs.webkit.org/show_bug.cgi?id=136665
2102
2103         Reviewed by Andy Estes.
2104
2105         Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
2106
2107         * .eslintrc:
2108         * Tools/PrettyPrinting/FormatterContentBuilder.js:
2109         * Tools/PrettyPrinting/FormatterDebug.js:
2110         (Formatter.prototype.debug):
2111         * UserInterface/Base/DOMUtilities.js:
2112         * UserInterface/Base/EventListener.js:
2113         (WebInspector.EventListener):
2114         (WebInspector.EventListener.prototype.this._callback):
2115         (WebInspector.EventListener.prototype.connect):
2116         * UserInterface/Base/Object.js:
2117         (WebInspector.Object):
2118         (WebInspector.Object.addConstructorFunctions):
2119         (WebInspector.Event):
2120         * UserInterface/Base/URLUtilities.js:
2121         (WebInspector.displayNameForURL):
2122         (WebInspector.displayNameForHost):
2123         * UserInterface/Base/Utilities.js:
2124         (.):
2125         * UserInterface/Controllers/BranchManager.js:
2126         (WebInspector.BranchManager):
2127         * UserInterface/Controllers/CSSStyleManager.js:
2128         (WebInspector.CSSStyleManager):
2129         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
2130         (WebInspector.CodeMirrorColorEditingController):
2131         * UserInterface/Controllers/CodeMirrorEditingController.js:
2132         (WebInspector.CodeMirrorEditingController):
2133         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
2134         (WebInspector.CodeMirrorGradientEditingController):
2135         (WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
2136         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2137         * UserInterface/Controllers/FormatterContentBuilder.js:
2138         * UserInterface/Controllers/FormatterSourceMap.js:
2139         (WebInspector.FormatterSourceMap.fromBuilder):
2140         * UserInterface/Controllers/IssueManager.js:
2141         (WebInspector.IssueManager):
2142         * UserInterface/Controllers/LogManager.js:
2143         (WebInspector.LogManager):
2144         * UserInterface/Models/BreakpointAction.js:
2145         * UserInterface/Models/CSSCompletions.js:
2146         (WebInspector.CSSCompletions):
2147         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2148         * UserInterface/Models/CSSKeywordCompletions.js:
2149         (WebInspector.CSSKeywordCompletions.forProperty):
2150         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2151         * UserInterface/Models/CSSStyleSheet.js:
2152         (WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
2153         * UserInterface/Models/Color.js:
2154         (WebInspector.Color):
2155         (WebInspector.Color.fromString):
2156         * UserInterface/Models/DOMNode.js:
2157         (WebInspector.DOMNode):
2158         * UserInterface/Models/DOMSearchMatchObject.js:
2159         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
2160         * UserInterface/Models/ExecutionContext.js:
2161         (WebInspector.ExecutionContext.supported):
2162         * UserInterface/Models/Gradient.js:
2163         (WebInspector.LinearGradient):
2164         (WebInspector.LinearGradient.linearGradientWithComponents):
2165         (WebInspector.RadialGradient):
2166         (WebInspector.RadialGradient.radialGradientWithComponents):
2167         * UserInterface/Models/IssueMessage.js:
2168         (WebInspector.IssueMessage):
2169         * UserInterface/Models/ReplaySessionSegment.js:
2170         (WebInspector.IncompleteSessionSegment):
2171         * UserInterface/Models/Resource.js:
2172         (WebInspector.Resource.prototype.associateWithScript):
2173         * UserInterface/Models/Script.js:
2174         (WebInspector.Script.resetUniqueDisplayNameNumbers):
2175         * UserInterface/Models/Setting.js:
2176         (WebInspector.Setting):
2177         * UserInterface/Models/SourceCodePosition.js:
2178         (WebInspector.SourceCodePosition):
2179         * UserInterface/Models/SourceMap.js:
2180         (WebInspector.SourceMap):
2181         (WebInspector.SourceMap.StringCharIterator):
2182         * UserInterface/Models/TextMarker.js:
2183         (WebInspector.TextMarker):
2184         * UserInterface/Models/TextRange.js:
2185         (WebInspector.TextRange):
2186         * UserInterface/Protocol/InspectorFrontendHostStub.js:
2187         (.WebInspector.InspectorFrontendHostStub):
2188         * UserInterface/Protocol/MessageDispatcher.js:
2189         (WebInspector.dispatchNextQueuedMessageFromBackend):
2190         (WebInspector.dispatchMessageFromBackend):
2191         * UserInterface/Protocol/RemoteObject.js:
2192         (WebInspector.RemoteObject):
2193         (WebInspector.RemoteObject.fromPrimitiveValue):
2194         (WebInspector.RemoteObject.fromLocalObject):
2195         (WebInspector.RemoteObject.resolveNode):
2196         (WebInspector.RemoteObject.fromPayload):
2197         (WebInspector.RemoteObject.type):
2198         (WebInspector.RemoteObjectProperty):
2199         (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
2200         (WebInspector.LocalJSONObject):
2201         * UserInterface/Protocol/ReplayObserver.js:
2202         (WebInspector.ReplayPosition.fromProtocol):
2203         * UserInterface/Views/BreakpointActionView.js:
2204         (WebInspector.BreakpointActionView.displayStringForType):
2205         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2206         (WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
2207         * UserInterface/Views/ClusterContentView.js:
2208         (WebInspector.ClusterContentView.prototype.goBack):
2209         (WebInspector.ClusterContentView.prototype.goForward):
2210         * UserInterface/Views/CodeMirrorAdditions.js:
2211         * UserInterface/Views/ColorWheel.js:
2212         (WebInspector.ColorWheel):
2213         * UserInterface/Views/ConsoleMessage.js:
2214         (WebInspector.ConsoleMessage):
2215         (WebInspector.ConsoleMessage.create):
2216         * UserInterface/Views/ConsoleMessageImpl.js:
2217         (WebInspector.ConsoleMessageImpl):
2218         * UserInterface/Views/ContextMenu.js:
2219         (WebInspector.ContextMenuItem):
2220         (WebInspector.ContextSubMenuItem):
2221         (WebInspector.ContextMenu):
2222         (WebInspector.ContextMenu.Provider):
2223         (WebInspector.ContextMenu.registerProvider):
2224         (WebInspector.contextMenuItemSelected):
2225         (WebInspector.contextMenuCleared):
2226         * UserInterface/Views/DOMTreeElement.js:
2227         (WebInspector.DOMTreeElement):
2228         * UserInterface/Views/DOMTreeOutline.js:
2229         (WebInspector.DOMTreeOutline):
2230         * UserInterface/Views/DOMTreeUpdater.js:
2231         (WebInspector.DOMTreeUpdater):
2232         * UserInterface/Views/DatabaseContentView.js:
2233         (WebInspector.DatabaseContentView):
2234         * UserInterface/Views/EditingSupport.js:
2235         (WebInspector.isBeingEdited):
2236         (WebInspector.markBeingEdited):
2237         (WebInspector.isEditingAnyField):
2238         (WebInspector.isEventTargetAnEditableField):
2239         (WebInspector.EditingConfig):
2240         (WebInspector.startEditing):
2241         * UserInterface/Views/EventListenerSection.js:
2242         (WebInspector.EventListenerSection):
2243         * UserInterface/Views/EventListenerSectionGroup.js:
2244         (WebInspector.EventListenerSectionGroup):
2245         * UserInterface/Views/FindBanner.js:
2246         * UserInterface/Views/GeneralTreeElement.js:
2247         (WebInspector.GeneralTreeElement):
2248         * UserInterface/Views/GoToLineDialog.js:
2249         (WebInspector.GoToLineDialog):
2250         * UserInterface/Views/IndeterminateProgressSpinner.js:
2251         (WebInspector.IndeterminateProgressSpinner):
2252         * UserInterface/Views/LayoutTimelineDataGrid.js:
2253         (WebInspector.LayoutTimelineDataGrid):
2254         * UserInterface/Views/LogContentView.js:
2255         (WebInspector.LogContentView):
2256         * UserInterface/Views/NavigationItem.js:
2257         * UserInterface/Views/ObjectPropertiesSection.js:
2258         (WebInspector.ObjectPropertiesSection):
2259         (WebInspector.ObjectPropertiesSection.CompareProperties):
2260         (WebInspector.ObjectPropertyTreeElement):
2261         * UserInterface/Views/ProbeSetDetailsSection.js:
2262         * UserInterface/Views/PropertiesSection.js:
2263         (WebInspector.PropertiesSection):
2264         * UserInterface/Views/ResourceTreeElement.js:
2265         (WebInspector.ResourceTreeElement.compareResourceTreeElements):
2266         (WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
2267         * UserInterface/Views/ScriptTimelineDataGrid.js:
2268         (WebInspector.ScriptTimelineDataGrid):
2269         * UserInterface/Views/SearchResultTreeElement.js:
2270         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2271         * UserInterface/Views/TimelineRuler.js:
2272         (WebInspector.TimelineRuler):
2273         (WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
2274         (WebInspector.TimelineRuler.prototype._handleMouseUp):
2275         * UserInterface/Views/Toolbar.js:
2276         * UserInterface/Views/TreeOutline.js:
2277         (TreeOutline.prototype.appendChild):
2278         (TreeOutline.prototype.insertChild):
2279         (TreeOutline.prototype.removeChildAtIndex):
2280         (TreeOutline.prototype.removeChild):
2281         (TreeOutline.prototype.removeChildren):
2282         (TreeOutline.prototype.removeChildrenRecursive):
2283         (TreeOutline.prototype._rememberTreeElement):
2284         (TreeOutline.prototype._forgetTreeElement):
2285         (TreeOutline.prototype._forgetChildrenRecursive):
2286         (TreeOutline.prototype.getCachedTreeElement):
2287         (TreeOutline.prototype.findTreeElement):
2288         (TreeOutline.prototype._treeElementDidChange):
2289         (TreeOutline.prototype.treeElementFromPoint):
2290         (TreeOutline.prototype._treeKeyDown):
2291         (TreeOutline.prototype.expand):
2292         (TreeOutline.prototype.collapse):
2293         (TreeOutline.prototype.revealed):
2294         (TreeOutline.prototype.reveal):
2295         (TreeOutline.prototype.select):
2296         (TreeOutline.prototype.revealAndSelect):
2297         (TreeElement.prototype._attach):
2298         (TreeElement.prototype._detach):
2299         (TreeElement.treeElementMouseDown):
2300         (TreeElement.treeElementToggled):
2301         (TreeElement.treeElementDoubleClicked):
2302         (TreeElement.prototype.collapse):
2303         (TreeElement.prototype.collapseRecursively):
2304         (TreeElement.prototype.expand):
2305         (TreeElement.prototype.expandRecursively):
2306         (TreeElement.prototype.hasAncestor):
2307         (TreeElement.prototype.reveal):
2308         (TreeElement.prototype.revealed):
2309         (TreeElement.prototype.selectOnMouseDown):
2310         (TreeElement.prototype.select):
2311         (TreeElement.prototype.revealAndSelect):
2312         (TreeElement.prototype.deselect):
2313         (TreeElement.prototype.onpopulate):
2314         (TreeElement.prototype.traverseNextTreeElement):
2315         (TreeElement.prototype.traversePreviousTreeElement):
2316         (TreeElement.prototype.isEventWithinDisclosureTriangle):
2317         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
2318         (WebInspector.TreeOutlineDataGridSynchronizer):
2319
2320 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2321
2322         Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
2323         https://bugs.webkit.org/show_bug.cgi?id=135965
2324
2325         Reviewed by Timothy Hatcher.
2326
2327         There were numerous subtle race conditions in state restoration.
2328         This patch intends to fix a number of them to get what feels
2329         like sane behavior for selected sidebar state restoration.
2330
2331         1. Starting a Timeline recording no longer automatically switches to the TimelineContentView.
2332         This was making every reload switch to Timelines. If you had
2333         a resource selected (e.g. the DOM Tree) we should go back
2334         to showing the DOM tree.
2335
2336         2. Background sidebars should not reveal and select tree elements.
2337         This was making resources get selected in Timelines when reloading the page
2338         because the background Resources sidebar was restoring selection of the resource.
2339         That is an unexpected selection and breaks the experience of Timelines.
2340
2341         3. ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.
2342         If a TimelineContentView was in the ContentBrowser back/forward history,
2343         a reload with a resource selected in the Resources sidebar would end up
2344         showing the Timelines sidebar. This was because when ContentViews are
2345         closed during the navigation, the ContentBrowser would fall back to the
2346         remaining TimelineContentView and switch to its only allowed sidebar
2347         (Timelines). ResourceSidebarPanel, knowing a resource was selected,
2348         would select the MainFrame intending to stay in the Resource sidebar,
2349         but the resource is okay with showing in any sidebar, so we stay on Timelines.
2350
2351         4. Resource sidebar state restoration should propertly restore selection.
2352         On reload, state restoration would know the resource to re-select in the
2353         Resources sidebar. As ResourceTreeElements are added to the sidebar
2354         they are checked against the state restoration cookie. If they match,
2355         they would select the element and delete the cookie. Unfortunately,
2356         if this was the first TreeElement child being added to a FrameTreeElement,
2357         the FrameTreeElement onpopulate would remove all children and re-add
2358         them in a unique way. Unfortunately this means the TreeElement we
2359         selected based on the cookie, immediately got thrown away and recreated,
2360         and we no longer reveal and select it. This is a special case for
2361         FrameTreeElements which use the onpopulate SPI. So, instead of starting
2362         processing the new element queue, if this is the first time just trigger
2363         the onpopulate and elements are made just once.
2364
2365         5. Show Error Console triggering early, could have unexpected sidebar behavior.
2366         Opening Web Inspector directly to the console can run before
2367         WebInspector.contentLoaded (DOMContentLoaded). So in that case
2368         WebInspector.showFullHeightConsole was not handling if the contentBrowser
2369         had no content view yet, and the sidebar might be-reopened later on
2370         in contentLoaded based on the setting value.
2371
2372         6. Improve automatic resource selection for sidebars with multiple tree outlines.
2373         Selecting a call frame tree element was unexpectedly changing the
2374         selection to a Resource where the breakpoint was set. This was
2375         because we were only looking at one of potentially many content
2376         tree outlines in the sidebar to see if there was a user action.
2377         
2378         * UserInterface/Base/Main.js:
2379         (WebInspector.contentLoaded):
2380         (WebInspector.showFullHeightConsole):
2381         (WebInspector.toggleConsoleView):
2382         (WebInspector._mainResourceDidChange):
2383         (WebInspector._provisionalLoadStarted):
2384         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
2385         (WebInspector._updateCookieForInspectorViewState):
2386         (WebInspector._contentBrowserCurrentContentViewDidChange):
2387         * UserInterface/Views/NavigationSidebarPanel.js:
2388         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2389         * UserInterface/Views/ResourceSidebarPanel.js:
2390         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2391         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2392         * UserInterface/Views/TimelineSidebarPanel.js:
2393         (WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
2394
2395 2014-09-08  Matt Baker  <mattbaker@apple.com>
2396
2397         Web Inspector: Add layout test for lowercase CSSProperty names
2398         https://bugs.webkit.org/show_bug.cgi?id=135961
2399
2400         Reviewed by Joseph Pecoraro.
2401
2402         Modified test components to support testing CSSStyleManager and related classes:
2403         - Added required models to Test.html
2404         - Added CSSCompletions initialization to Test.js
2405         - CSSCompletions doesn't assume presence of CodeMirror.
2406
2407         * UserInterface/Base/Test.js:
2408         (WebInspector.loaded):
2409         * UserInterface/Models/CSSCompletions.js:
2410         * UserInterface/Test.html:
2411
2412 2014-09-08  Matt Baker  <mattbaker@apple.com>
2413
2414         Web Inspector: Fixes to layout test infrastructure
2415         https://bugs.webkit.org/show_bug.cgi?id=136360
2416
2417         Reviewed by Joseph Pecoraro.
2418
2419         Added missing includes to Test.html, which was breaking tests that
2420         depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
2421         bug which prevented test results from being resent after reloading the
2422         page under test.
2423
2424         * UserInterface/Base/Test.js:
2425         (InspectorTest.reloadPage):
2426         * UserInterface/Test.html:
2427
2428 2014-09-07  Timothy Hatcher  <timothy@apple.com>
2429
2430         Use a <circle> instead of a <path> in DownloadArrow.svg.
2431         https://bugs.webkit.org/show_bug.cgi?id=136608
2432
2433         Reviewed by Antoine Quint.
2434
2435         * UserInterface/Images/DownloadArrow.svg:
2436         * UserInterface/Views/TreeElementStatusButton.css:
2437         (.item > .status > .status-button > svg .filled):
2438         (body.mac-platform.legacy .item > .status > .status-button > svg .filled):
2439         (:focus .item.selected > .status > .status-button > svg .filled):
2440         (.item > .status > .status-button > svg .stroked):
2441         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
2442         (:focus .item.selected > .status > .status-button > svg .stroked):
2443         Tweak CSS selectors to apply to other shapes, not just path.
2444
2445 2014-09-06  Darin Adler  <darin@apple.com>
2446
2447         Make updates suggested by new version of Xcode
2448         https://bugs.webkit.org/show_bug.cgi?id=136603
2449
2450         Reviewed by Mark Rowe.
2451
2452         * Configurations/Base.xcconfig: Added CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2453         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2454         CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH, ENABLE_STRICT_OBJC_MSGSEND,
2455         GCC_WARN_UNDECLARED_SELECTOR, and GCC_WARN_UNUSED_FUNCTION as suggested by Xcode update check.
2456         Also removed duplicate GCC_WARN_UNUSED_VARIABLE line.
2457
2458         * WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2459
2460 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2461
2462         LegacyProfiler: remove redundant ProfileNode members and other cleanup
2463         https://bugs.webkit.org/show_bug.cgi?id=136380
2464
2465         Reviewed by Timothy Hatcher.
2466
2467         Remove unused Profile.idleTime member.
2468
2469         * UserInterface/Models/Profile.js:
2470         (WebInspector.Profile.prototype.get idleTime): Deleted.
2471         * UserInterface/Models/ScriptTimelineRecord.js:
2472         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
2473
2474 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2475
2476         Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
2477         https://bugs.webkit.org/show_bug.cgi?id=136462
2478
2479         Reviewed by Timothy Hatcher.
2480
2481         The legacy profiler manager didn't do anything, and its views and models
2482         have been superseded by new views and models based on the Timeline classes.
2483
2484         * .eslintrc:
2485         * UserInterface/Base/Main.js:
2486         (WebInspector.loaded):
2487         (WebInspector.openURL): Remove profile URL handling code.
2488         * UserInterface/Controllers/LegacyProfileManager.js: Removed.
2489         * UserInterface/Main.html:
2490         * UserInterface/Protocol/ConsoleObserver.js:
2491         (WebInspector.ConsoleObserver.prototype.messageAdded):
2492         * UserInterface/Protocol/InspectorFrontendAPI.js:
2493         (InspectorFrontendAPI.isProfilingJavaScript): Deleted.
2494         (InspectorFrontendAPI.startProfilingJavaScript): Deleted.
2495         (InspectorFrontendAPI.stopProfilingJavaScript): Deleted.
2496         * UserInterface/Protocol/LegacyProfilerObserver.js: Removed.
2497         * UserInterface/Views/LegacyBottomUpProfileDataGridTree.js: Removed.
2498         * UserInterface/Views/LegacyJavaScriptProfileObject.js: Removed.
2499         * UserInterface/Views/LegacyJavaScriptProfileType.js: Removed.
2500         * UserInterface/Views/LegacyJavaScriptProfileView.css: Removed.
2501         * UserInterface/Views/LegacyJavaScriptProfileView.js: Removed.
2502         * UserInterface/Views/LegacyProfileDataGridTree.js: Removed.
2503         * UserInterface/Views/LegacyProfileObject.js: Removed.
2504         * UserInterface/Views/LegacyProfileType.js: Removed.
2505         * UserInterface/Views/LegacyProfileView.css: Removed.
2506         * UserInterface/Views/LegacyProfileView.js: Removed.
2507         * UserInterface/Views/LegacyTopDownProfileDataGridTree.js: Removed.
2508
2509 2014-08-29  Saam Barati  <saambarati1@gmail.com>
2510
2511         Web Inspector: Create a UI for displaying JavaScript type information
2512         https://bugs.webkit.org/show_bug.cgi?id=135142
2513
2514         Reviewed by Joseph Pecoraro.
2515
2516         JavaScriptCore now has a type profiler. This patch provides a frontend
2517         user interface for displaying this type information in the Web Inspector.
2518         The user interface works by placing inline "type tokens" next to important
2519         JavaScript expressions: function arguments, function return types, and 
2520         variable declarations. Type information can also be seen for almost every
2521         JavaScipt expression just by hovering over it while viewing a JavaScript file.
2522
2523         Currently, turning on the type profiler is expensive, so the inspector
2524         ensures to never turn on type profiling until the user specifically asks 
2525         for type information to be turned on.
2526
2527         * UserInterface/Base/Main.js:
2528         (WebInspector.loaded):
2529         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2530         (WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
2531         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
2532         Added a new type profiling mode.
2533
2534         * UserInterface/Controllers/FormatterSourceMap.js:
2535         (WebInspector.FormatterSourceMap.prototype.originalToFormatted):
2536         (WebInspector.FormatterSourceMap.prototype.originalPositionToFormatted):
2537         (WebInspector.FormatterSourceMap.prototype.formattedToOriginal):
2538         (WebInspector.FormatterSourceMap.prototype.formattedToOriginalOffset):
2539         * UserInterface/Controllers/TypeTokenAnnotator.js: Added.
2540         (WebInspector.TypeTokenAnnotator):
2541         (WebInspector.TypeTokenAnnotator.prototype.get isActive):
2542         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor):
2543         (WebInspector.TypeTokenAnnotator.prototype.pause):
2544         (WebInspector.TypeTokenAnnotator.prototype.resume):
2545         (WebInspector.TypeTokenAnnotator.prototype.refresh):
2546         (WebInspector.TypeTokenAnnotator.prototype.reset):
2547         (WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
2548         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.):
2549         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
2550         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
2551         (WebInspector.TypeTokenAnnotator.prototype.isLineTerminator):
2552         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
2553         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded):
2554         This class is responsible for producing the inline "type token" annotations.
2555
2556         * UserInterface/Images/NavigationItemTypes.svg: Added.
2557         * UserInterface/Main.html:
2558         * UserInterface/Models/Script.js:
2559         (WebInspector.Script.prototype.get scriptSyntaxTree):
2560         * UserInterface/Models/ScriptSyntaxTree.js:
2561         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2562         (WebInspector.ScriptSyntaxTree.prototype.):
2563         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2564         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2565         * UserInterface/Views/ScriptContentView.js:
2566         (WebInspector.ScriptContentView):
2567         (WebInspector.ScriptContentView.prototype.get navigationItems):
2568         (WebInspector.ScriptContentView.prototype._contentDidPopulate):
2569         (WebInspector.ScriptContentView.prototype._toggleTypeAnnotations):
2570         (WebInspector.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2571         * UserInterface/Views/SourceCodeTextEditor.js:
2572         (WebInspector.SourceCodeTextEditor):
2573         (WebInspector.SourceCodeTextEditor.prototype.shown):
2574         (WebInspector.SourceCodeTextEditor.prototype.hidden):
2575         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
2576         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
2577         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
2578         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
2579         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
2580         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
2581         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
2582         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
2583         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
2584         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
2585         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
2586         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2587         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
2588         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2589         (WebInspector.SourceCodeTextEditor.prototype._enableScrollEventsForTypeTokenAnnotator):
2590         (WebInspector.SourceCodeTextEditor.prototype._disableScrollEventsForTypeTokenAnnotator):
2591         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
2592         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
2593         * UserInterface/Views/TextContentView.js:
2594         (WebInspector.TextContentView.prototype.get navigationItems):
2595         * UserInterface/Views/TextEditor.js:
2596         (WebInspector.TextEditor.prototype.set formatted):
2597         (WebInspector.TextEditor.prototype.canShowTypeAnnotations):
2598         (WebInspector.TextEditor.prototype.visibleRangeOffsets):
2599         (WebInspector.TextEditor.prototype.originalOffsetToCurrentPosition):
2600         (WebInspector.TextEditor.prototype.currentOffsetToCurrentPosition):
2601         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
2602         (WebInspector.TextEditor.prototype.currentPositionToCurrentOffset):
2603         (WebInspector.TextEditor.prototype.setInlineWidget):
2604         (WebInspector.TextEditor.prototype.addScrollHandler):
2605         (WebInspector.TextEditor.prototype.removeScrollHandler):
2606         (WebInspector.TextEditor.prototype._scrollIntoViewCentered):
2607         * UserInterface/Views/TextResourceContentView.js:
2608         (WebInspector.TextResourceContentView):
2609         (WebInspector.TextResourceContentView.prototype.get navigationItems):
2610         (WebInspector.TextResourceContentView.prototype._contentDidPopulate):
2611         (WebInspector.TextResourceContentView.prototype._toggleTypeAnnotations):
2612         (WebInspector.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2613         * UserInterface/Views/TypePropertiesSection.js: Added.
2614         (WebInspector.TypePropertiesSection):
2615         (WebInspector.TypePropertiesSection.prototype.onpopulate):
2616         (WebInspector.TypePropertiesSection.PropertyComparator):
2617         (WebInspector.TypePropertyTreeElement):
2618         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
2619         * UserInterface/Views/TypeTokenView.css: Added.
2620         (.type-token):
2621         (.type-token-left-spacing):
2622         (.type-token-right-spacing):
2623         (.type-token-function, .type-token-boolean):
2624         (.type-token-number):
2625         (.type-token-string):
2626         (.type-token-default):
2627         (.type-token-empty):
2628         (.type-token-many):
2629         * UserInterface/Views/TypeTokenView.js: Added.
2630         (WebInspector.TypeTokenView):
2631         (WebInspector.TypeTokenView.titleForPopover):
2632         (WebInspector.TypeTokenView.prototype.update):
2633         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
2634         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
2635         The inline "type token" view.
2636
2637 2014-08-29  Saam Barati  <sbarati@apple.com>
2638
2639         Web Inspector: Fix how Popover animates
2640         https://bugs.webkit.org/show_bug.cgi?id=136353
2641
2642         Reviewed by Timothy Hatcher.
2643
2644         Popovers currently don't animate properly because they use 
2645         window.requestAnimationFrame which won't fire its callback 
2646         while the inspector is paused in the debugger. This patches
2647         switches the callback mechanism to setTimeout and also changes
2648         how a Popover's anchor animates to prevent visual glitches.
2649
2650         Popover also has a new function that allows a new target
2651         frame and new content to be set simultaneously and to
2652         animate to show the new content while changing the 
2653         location of the popover frame.
2654
2655         SourceCodeTextEditor uses Popover's new API for animating
2656         between popovers when paused in the debugger. SourceCodeTextEditor 
2657         also now ensures proper balancing of popover tracking event 
2658         listeners.
2659
2660         * UserInterface/Views/Popover.js:
2661         (WebInspector.Popover.prototype.present):
2662         (WebInspector.Popover.prototype.presentNewContentWithFrame):
2663         (WebInspector.Popover.prototype.dismiss):
2664         (WebInspector.Popover.prototype._update):
2665         (WebInspector.Popover.prototype.drawBackground):
2666         (WebInspector.Popover.prototype._animateFrame):
2667         (WebInspector.Popover.prototype._drawFrame):
2668         (WebInspector.Popover.prototype._addListenersIfNeeded):
2669         (WebInspector.Popover.prototype._animateFrame.drawBackground): Deleted.
2670         * UserInterface/Views/SourceCodeTextEditor.js:
2671         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2672         (WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
2673         (WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
2674
2675 2014-08-28  Saam Barati  <sbarati@apple.com>
2676
2677         Web Inspector: Write tests for ScriptSyntaxTree and fix bugs in the data structure
2678         https://bugs.webkit.org/show_bug.cgi?id=136272
2679
2680         Reviewed by Joseph Pecoraro.
2681
2682         Include the necessary files in Test.html to test ScriptSyntaxTree.
2683         Also, ScriptSyntaxTree had a couple of errors for two of its nodes
2684         where they simply ignored one of the properties on the node.
2685         These errors were found while writing the tests and are fixed
2686         in this patch.
2687
2688         * UserInterface/Models/ScriptSyntaxTree.js:
2689         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2690         * UserInterface/Test.html:
2691
2692 2014-08-27  Saam Barati  <sbarati@apple.com>
2693
2694         Web Inspector: Layout issues for popover on not legacy OS
2695         https://bugs.webkit.org/show_bug.cgi?id=136268
2696
2697         Reviewed by Joseph Pecoraro.
2698
2699         On the latest OS, popovers invade the title bar's space which will
2700         cause layout issues because the title bar will render above
2701         the popover. Fix this by providing some padding for popovers on 
2702         not legacy OSs.
2703
2704         * UserInterface/Views/Popover.js:
2705
2706 2014-08-27  Timothy Hatcher  <timothy@apple.com>
2707
2708         REGRESSION: Web Inspector: Legacy toolbar has two different colors in unfocused windowed mode
2709         https://bugs.webkit.org/show_bug.cgi?id=136289
2710
2711         Reviewed by Darin Adler.
2712
2713         * UserInterface/Views/Toolbar.css:
2714         (body.mac-platform.legacy .toolbar): Override the background-color as transparent. Non-legacy
2715         uses a solid color instead of a gradient for window-inactive.
2716
2717 2014-08-26  Saam Barati  <sbarati@apple.com>
2718
2719         Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
2720         https://bugs.webkit.org/show_bug.cgi?id=136160
2721
2722         Reviewed by Joseph Pecoraro.
2723
2724         Check if '_tracking' is already true before calling '_startTracking'
2725         to prevent the assertion from always firing.
2726
2727         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2728         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
2729
2730 2014-08-25  Brent Fulgham  <bfulgham@apple.com>
2731
2732         [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
2733         https://bugs.webkit.org/show_bug.cgi?id=136229
2734
2735         Reviewed by Dean Jackson.
2736
2737         * WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
2738         flag to build-webinspectorui.pl.
2739         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
2740         the OFFICIAL_BUILD flag.
2741
2742 2014-08-24  Benjamin Poulain  <benjamin@webkit.org>
2743
2744         The inspector should not use the "after" pseudo element with the compatibility syntax
2745         https://bugs.webkit.org/show_bug.cgi?id=136204
2746
2747         Reviewed by Darin Adler.
2748
2749         We should only use hte proper pseudo element syntax inside WebKit.
2750
2751         * Tools/PrettyPrinting/codemirror-additions.css:
2752         * Tools/PrettyPrinting/populate/apple.css:
2753
2754 2014-08-24  Brian J. Burg  <burg@cs.washington.edu>
2755
2756         Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
2757         https://bugs.webkit.org/show_bug.cgi?id=136025
2758
2759         Reviewed by Joseph Pecoraro.
2760
2761         Also rename DOM.RGBA in legacy protocol specifications.
2762
2763         * Versions/Inspector-iOS-6.0.json:
2764         * Versions/Inspector-iOS-7.0.json:
2765
2766 2014-08-21  Simon Fraser  <simon.fraser@apple.com>
2767
2768         Add a button to enable paint flashing in the web inspector
2769         https://bugs.webkit.org/show_bug.cgi?id=136133
2770
2771         Reviewed by Tim Hatcher.
2772         
2773         Add a button to the right of the layer borders button to turn on paint flashing.
2774         Future patches will actually enable this feature.
2775
2776         * Localizations/en.lproj/localizedStrings.js: Tooltip strings.
2777         * UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
2778         * UserInterface/Views/DOMTreeContentView.js:
2779         (WebInspector.DOMTreeContentView):
2780         (WebInspector.DOMTreeContentView.prototype.get navigationItems):
2781         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
2782
2783 2014-08-20  Saam Barati  <sbarati@apple.com>
2784
2785         Rename HighFidelityTypeProfiling variables for more clarity
2786         https://bugs.webkit.org/show_bug.cgi?id=135899
2787
2788         Reviewed by Geoffrey Garen.
2789
2790         Change a reference in a comment to a JavaScriptCore file to its 
2791         newly renamed variant.
2792
2793         * UserInterface/Models/ScriptSyntaxTree.js:
2794
2795 2014-08-18  Saam Barati  <sbarati@apple.com>
2796
2797         Web Inspector: Introduce an inspector Abstract Syntax Tree.
2798         https://bugs.webkit.org/show_bug.cgi?id=135763
2799
2800         Reviewed by Joseph Pecoraro.
2801
2802         This patch adds an Abstract Syntax Tree to the Web inspector. 
2803         This syntax tree is modeled off the Esprima.js syntax tree
2804         which complies with the Mozilla Parser API:
2805         https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
2806         Script is the owner of the Web Inspector syntax tree, and has an API
2807         for accessing its syntax tree property.
2808
2809         * UserInterface/External/Esprima/esprima.js:
2810         * UserInterface/Main.html:
2811         * UserInterface/Models/Script.js:
2812         (WebInspector.Script):
2813         (WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
2814         (WebInspector.Script.prototype._resolveResource):
2815         (WebInspector.Script.prototype._makeSyntaxTree):
2816         * UserInterface/Models/ScriptSyntaxTree.js: Added.
2817         (WebInspector.ScriptSyntaxTree):
2818         (WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
2819         (WebInspector.ScriptSyntaxTree.prototype.forEachNode):
2820         (WebInspector.ScriptSyntaxTree.prototype.):
2821         (WebInspector.ScriptSyntaxTree.prototype.filter):
2822         (WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
2823         (WebInspector.ScriptSyntaxTree.prototype.filterByRange):
2824         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
2825         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2826         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2827         (WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
2828         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2829         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
2830         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2831
2832 2014-08-16  Joseph Pecoraro  <pecoraro@apple.com>
2833
2834         Web Inspector: Improve performance of selection range changes viewing Scripts timeline
2835         https://bugs.webkit.org/show_bug.cgi?id=136015
2836
2837         Reviewed by Timothy Hatcher.
2838
2839         * UserInterface/Base/Utilities.js:
2840         (clamp):
2841         Helper function to clamp a value between a min and max.
2842
2843         * UserInterface/Models/ProfileNode.js:
2844         (WebInspector.ProfileNode.prototype.get startTime):
2845         (WebInspector.ProfileNode.prototype.get endTime):
2846         These can be quickly calculated, so avoid full calculation to grab the values.
2847
2848         * UserInterface/Views/ScriptTimelineView.js:
2849         (WebInspector.ScriptTimelineView.prototype.updateLayout):
2850         Update ranges with a smart helper, instead of blindly doing it and needing refresh.
2851
2852         * UserInterface/Views/ProfileNodeDataGridNode.js:
2853         (WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
2854         (WebInspector.ProfileNodeDataGridNode.prototype.get data):
2855         (WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
2856         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
2857         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.
2858         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2859         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2860         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
2861         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
2862         When updating the range selection, compare to the last range selection
2863         on this DataGridNode. If the visible portion of this node's time range
2864         changes, we need a refresh. Otherwise, we don't need a refresh.
2865
2866 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2867
2868         Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
2869         https://bugs.webkit.org/show_bug.cgi?id=136006
2870
2871         Reviewed by Timothy Hatcher.
2872
2873         * Scripts/update-LegacyInspectorBackendCommands.rb:
2874         Use the new generator and pass the appropriate flags.
2875
2876         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
2877         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
2878         Newly generated files using the new generator.
2879
2880         * Versions/Inspector-iOS-6.0.json:
2881         Remove unsupported features.
2882
2883 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2884
2885         Web Inspector: Remove forced layouts during recording caused by striped background element resizing
2886         https://bugs.webkit.org/show_bug.cgi?id=136009
2887
2888         Reviewed by Timothy Hatcher.
2889
2890         We used to manually resize and a custom striped background behind
2891         the timeline tree outline content area. This can happen frequently
2892         during timeline recordings causing forced layouts. We can eliminate
2893         the hack and instead put the stripe background on the tree outline.
2894
2895         * UserInterface/Views/TimelineSidebarPanel.js:
2896         (WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2897         * UserInterface/Views/TimelineSidebarPanel.css:
2898         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
2899         (.sidebar > .panel.navigation.timeline > .content > .stripe-background): Deleted.
2900         (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background): Deleted.
2901         Eliminate the striped background element.
2902
2903         * UserInterface/Views/TimelineView.css:
2904         (.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline):
2905         (.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
2906         Give the timeline content tree outlines the striped background.
2907
2908         * UserInterface/Views/NavigationSidebarPanel.js:
2909         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2910         (WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2911         Remove the now unused updateCustomContentOverflow method.
2912
2913 2014-08-15  Jono Wells  <jonowells@apple.com>
2914
2915         Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
2916         https://bugs.webkit.org/show_bug.cgi?id=135995
2917
2918         Reviewed by Joseph Pecoraro.
2919
2920         Change so if an element is inspected via the Inspect Element context menu, selected
2921         node restoration is disallowed until the main resource in the main frame changes.
2922         This way an attempt by a sub-frame will not change the highlighted element in the
2923         Main Frame's DOM tree unexpectedly.
2924
2925         * UserInterface/Controllers/DOMTreeManager.js:
2926         (WebInspector.DOMTreeManager):
2927         (WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
2928         (WebInspector.DOMTreeManager.prototype.inspectElement):
2929
2930 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
2931
2932         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2933         https://bugs.webkit.org/show_bug.cgi?id=131596
2934
2935         Reviewed by Joseph Pecoraro.
2936
2937         Also apply type extraction refactorings to old protocol versions for consistency.
2938
2939         * Versions/Inspector-iOS-6.0.json:
2940         * Versions/Inspector-iOS-7.0.json:
2941
2942 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2943
2944         Web Inspector: Probe details sidebar data grids do not show data
2945         https://bugs.webkit.org/show_bug.cgi?id=135992
2946
2947         Reviewed by Joseph Pecoraro.
2948
2949         * UserInterface/Views/ProbeSetDataGrid.js:
2950         (WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.
2951
2952 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2953
2954         Web Inspector: Legacy Mac toolbar appearance looks wrong
2955         https://bugs.webkit.org/show_bug.cgi?id=135962
2956
2957         Reviewed by Joseph Pecoraro.
2958
2959         * UserInterface/Views/Toolbar.css:
2960         (body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
2961         Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
2962         applies all the time as it should have.
2963
2964 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2965
2966         Web Inspector: Dragging Undocked inspector by window title has broken behavior
2967         https://bugs.webkit.org/show_bug.cgi?id=135950
2968
2969         Reviewed by Timothy Hatcher.
2970
2971         * UserInterface/Base/Main.js:
2972         On Mac ports where we the inspector content goes everywhere, window dragging behavior
2973         still exists for the top 22px of the window. So don't do our JavaScript based window
2974         dragging for this special region.
2975
2976         * UserInterface/Models/KeyboardShortcut.js:
2977         (WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
2978         (WebInspector.KeyboardShortcut.prototype.get displayName):
2979         Instead of calling a host function, use the value already in the frontend.
2980
2981 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2982
2983         Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
2984         https://bugs.webkit.org/show_bug.cgi?id=135957
2985
2986         Reviewed by Timothy Hatcher.
2987
2988         * UserInterface/Views/LogContentView.js:
2989         (WebInspector.LogContentView):
2990         Wrong image path passed to platformImagePath.
2991
2992 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2993
2994         Web Inspector: Avoid re-binding the same function over and over
2995         https://bugs.webkit.org/show_bug.cgi?id=135949
2996
2997         Reviewed by Timothy Hatcher.
2998
2999         * UserInterface/Controllers/TimelineManager.js:
3000         (WebInspector.TimelineManager.prototype._startAutoCapturing):
3001         (WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
3002         (WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
3003         Stash a bound copy of the function once, and reuse it.
3004
3005 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3006
3007         Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
3008         https://bugs.webkit.org/show_bug.cgi?id=135946
3009
3010         Reviewed by Timothy Hatcher.
3011
3012         Each TimelineContentView was listening for the TimelineManager's start/stop
3013         capturing events. However, only the active recording could possibly update.
3014         Likewise, if a pre-existing recording started and stopped we did not properly
3015         stop in the case where we were waiting for an event to update the current time,
3016         which would result in an infinite rAF loop of no updates.
3017
3018         * UserInterface/Models/TimelineRecording.js:
3019         (WebInspector.TimelineRecording.prototype.unloaded):
3020         When a timeline recording is unloaded trigger an event.
3021
3022         * UserInterface/Views/TimelineContentView.js:
3023         (WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
3024         Assert we were not already waiting.
3025
3026         (WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
3027         Properly handle the case of starting/stoping an already existing recording
3028         without a new event coming in.
3029
3030         (WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
3031         (WebInspector.TimelineContentView.prototype._recordingReset):
3032         Convert to a boolean instead of deleting state.
3033
3034         (WebInspector.TimelineContentView.prototype._recordingUnloaded):
3035         Stop listening to timeline manager events that no longer affect unloaded recordings.
3036
3037 2014-08-13  Jono Wells  <jonowells@apple.com>
3038
3039         Web Inspector: eslint configuration should be stored as .eslintrc
3040         https://bugs.webkit.org/show_bug.cgi?id=135916
3041
3042         .eslintrc file added to allow for ESLint solutions, within editors and otherwise,
3043         to be automatically configured based on the WebKit JavaScript coding style. The
3044         initial file is incomplete.
3045
3046         Reviewed by Joseph Pecoraro.
3047
3048         * .eslintrc: Added.
3049         * External/.eslintrc: Added.
3050
3051 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3052
3053         Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
3054         https://bugs.webkit.org/show_bug.cgi?id=135917
3055
3056         Reviewed by Joseph Pecoraro.
3057
3058         * UserInterface/Views/TimelineSidebarPanel.js:
3059
3060 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3061
3062         Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
3063         https://bugs.webkit.org/show_bug.cgi?id=135894
3064
3065         Reviewed by Timothy Hatcher.
3066
3067         * UserInterface/Views/DetailsSection.css:
3068         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
3069         In legacy styles the details-section header always has a 1px bottom border.
3070         In all styles, an inline data grid had a 1px border everywhere. So, handle
3071         this specific case by removing the top border of an inline data grid
3072         that is inside an expanded details section.
3073
3074 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3075
3076         Web Inspector: "No Filter Results" view only shows once, does not show again
3077         https://bugs.webkit.org/show_bug.cgi?id=135892
3078
3079         Reviewed by Timothy Hatcher.
3080
3081         * UserInterface/Views/NavigationSidebarPanel.js:
3082         (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
3083         We were checking at the wrong level for a parent. Check if the root
3084         placeholder element has a parent or not.
3085
3086 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3087
3088         Web Inspector: Incorrect border colors in event listeners sections in details sidebar
3089         https://bugs.webkit.org/show_bug.cgi?id=135891
3090
3091         Reviewed by Timothy Hatcher.
3092
3093         * UserInterface/Views/DetailsSection.css:
3094         (.details-section .details-section > .header):
3095         (.details-section .details-section:not(.collapsed) > .header):
3096         Remove box-shadow and replace with a bottom border.
3097
3098         (body.mac-platform.legacy .details-section .details-section.collapsed > .header):
3099         (.details-section .details-section.collaspsed > .header): Deleted.
3100         Collapsed was spelled incorrectly so this was not applying properly before.
3101         But correct this for legacy because legacy still uses a box-shadow.
3102
3103 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3104
3105         Web Inspector: Timeline Close buttons can use polish for new and legacy styles
3106         https://bugs.webkit.org/show_bug.cgi?id=135870
3107
3108         Reviewed by Timothy Hatcher.
3109
3110         * UserInterface/Images/Legacy/Close.svg:
3111         Ensure this has fill colors in tree selections.
3112
3113         * UserInterface/Views/TimelineSidebarPanel.css:
3114         (.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3115         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3116         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
3117         Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).
3118
3119 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3120
3121         Web Inspector: Workaround a NSWindow change to the title bar.
3122         https://bugs.webkit.org/show_bug.cgi?id=135880
3123
3124         Reviewed by Joseph Pecoraro.
3125
3126         * UserInterface/Base/Main.js:
3127         (WebInspector._updateToolbarHeight): Don't call in legacy mode.
3128
3129         * UserInterface/Views/DashboardContainerView.css:
3130         (.toolbar .dashboard-container):
3131         (.toolbar .dashboard):
3132         Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
3133         drop shadow down when it shouldn't. Remove duplicate background and shadow.
3134
3135         * UserInterface/Views/Main.css:
3136         (body): Set the background white, never needs to be transparent now.
3137         (body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
3138         (body.docked.bottom): Update border color.
3139         (body.docked.right): Ditto.
3140         (body.docked.bottom.mac-platform.legacy): Keep old border color.
3141         (body.docked.right.mac-platform.legacy): Ditto.
3142
3143         * UserInterface/Views/Toolbar.css:
3144         (.toolbar): Set a default border and background gradient.
3145         (body.window-inactive .toolbar): No gradient but use a solid color when inactive.
3146         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
3147         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
3148         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
3149         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
3150         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
3151         (body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
3152         (body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
3153         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
3154         (body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.
3155
3156 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3157
3158         Web Inspector: Restore Helvetica as the dashboard font in legacy mode
3159         https://bugs.webkit.org/show_bug.cgi?id=135886
3160
3161         Reviewed by Joseph Pecoraro.
3162
3163         * UserInterface/Views/DefaultDashboardView.css:
3164         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3165
3166 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3167
3168         Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar
3169         https://bugs.webkit.org/show_bug.cgi?id=135863
3170
3171         Reviewed by Timothy Hatcher.
3172
3173         A workaround is to not have position:relative content inside of
3174         scrollable region. Turns out this was only done in two places,
3175         and I do not see any absolutely positioned content in navigation
3176         sidebar content tree outlines. This also fixes clicking on the
3177         reload button if you've scrolled the Resources sidebar. 
3178
3179         * UserInterface/Views/NavigationSidebarPanel.css:
3180         (.navigation-sidebar-panel-content-tree-outline .children): Deleted.
3181         (.navigation-sidebar-panel-content-tree-outline .item): Deleted.
3182
3183 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3184
3185         Web Inspector: Remove unused variable in Platform.js
3186         https://bugs.webkit.org/show_bug.cgi?id=135869
3187
3188         Reviewed by Timothy Hatcher.
3189
3190         * UserInterface/Base/Platform.js:
3191
3192 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3193
3194         Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
3195         https://bugs.webkit.org/show_bug.cgi?id=135849
3196
3197         Reviewed by Timothy Hatcher.
3198
3199         Click events on elements in the graph container (event bubbles) or
3200         in the scroll container (bottom 16px) were becoming the event targets.
3201         As siblings of the ruler, the dispatch would not go through the ruler.
3202         The ruler was supposed to be overlaying everything in the overview,
3203         so give the ruler a z-index so it really is overlaying elements.
3204
3205         * UserInterface/Views/TimelineRuler.css:
3206         (.timeline-ruler):
3207
3208 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3209
3210         Web Inspector: GoToLine dialog clear text button looks poor
3211         https://bugs.webkit.org/show_bug.cgi?id=135828
3212
3213         Reviewed by Timothy Hatcher.
3214
3215         Legacy/CloseWhite.svg was not used, but in the case where the white
3216         close button is needed the thicker bars looks better. Re-use the
3217         Legacy image as the default CloseWhite.svg.
3218
3219         * UserInterface/Images/CloseWhite.svg:
3220         * UserInterface/Images/Legacy/CloseWhite.svg: Removed.
3221
3222 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3223
3224         Web Inspector: Easier Way to go back to the Timeline Overviews
3225         https://bugs.webkit.org/show_bug.cgi?id=135827
3226
3227         Reviewed by Timothy Hatcher.
3228
3229         * Localizations/en.lproj/localizedStrings.js:
3230         Added new tooltip UIString.
3231
3232         * UserInterface/Images/Close.svg:
3233         * UserInterface/Images/CloseLarge.svg:
3234         * UserInterface/Images/Legacy/Close.svg:
3235         Add "stroked" class so the buttons can fill with white on selected rows.
3236         Also re-center the non-legacy images horizontally.
3237
3238         * UserInterface/Views/GeneralTreeElement.js:
3239         (WebInspector.GeneralTreeElement.prototype.set status):
3240         Do not recreate elements if the status did not change.
3241
3242         * UserInterface/Views/LayoutTimelineView.js:
3243         (WebInspector.LayoutTimelineView):
3244         (WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
3245         (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
3246         (WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton):
3247         (WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):
3248         * UserInterface/Views/NetworkTimelineView.js:
3249         (WebInspector.NetworkTimelineView):
3250         (WebInspector.NetworkTimelineView.prototype._treeElementDeselected):
3251         (WebInspector.NetworkTimelineView.prototype._treeElementSelected):
3252         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton):
3253         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):
3254         * UserInterface/Views/OverviewTimelineView.js:
3255         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected):
3256         (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
3257         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton):
3258         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):
3259         * UserInterface/Views/ScriptTimelineView.js:
3260         (WebInspector.ScriptTimelineView):
3261         (WebInspector.ScriptTimelineView.prototype._treeElementDeselected):
3262         (WebInspector.ScriptTimelineView.prototype._treeElementSelected):
3263         (WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton):
3264         (WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
3265         Provide select/deselect handlers to show/hide the close status bar button
3266         when selecting a row that shows a non-Timeline content view. Currently the
3267         only content views the tree elements can show are Resource views, so the
3268         tooltip is the same everywhere.
3269
3270 2014-08-12  Timothy Hatcher  <timothy@apple.com>
3271
3272         Web Inspector: Expect to see top level JavaScript function profiler details for event handlers in timeline
3273         https://bugs.webkit.org/show_bug.cgi?id=132109
3274
3275         Reviewed by Joseph Pecoraro.
3276
3277         * UserInterface/Views/ScriptTimelineView.js:
3278         (WebInspector.ScriptTimelineView.prototype._processPendingRecords): Don't promote root node children if
3279         there is only one child.
3280
3281 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3282
3283         Web Inspector: show a replay dashboard when capturing or replaying
3284         https://bugs.webkit.org/show_bug.cgi?id=135170
3285
3286         Reviewed by Timothy Hatcher.
3287
3288         This patch adds a replay dashboard with record/play/pause buttons. It
3289         is shown automatically when the user starts capturing an execution from
3290         the replay menu in the Timelines sidebar panel.
3291
3292         * UserInterface/Base/Main.js:
3293         (WebInspector.loaded):
3294         (WebInspector._captureDidStart):
3295         * UserInterface/Controllers/DashboardManager.js:
3296         (WebInspector.DashboardManager):
3297         * UserInterface/Images/ReplayPauseButton.svg: Added.
3298         * UserInterface/Images/ReplayPlayButton.svg: Added.
3299         * UserInterface/Images/ReplayRecordingButton.svg: Added.
3300         * UserInterface/Main.html:
3301         * UserInterface/Models/ReplayDashboard.js: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3302         (WebInspector.ReplayDashboard):
3303         * UserInterface/Views/DashboardView.js:
3304         (WebInspector.DashboardView):
3305         * UserInterface/Views/ReplayDashboardView.css: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3306         (.toolbar .dashboard.replay):
3307         (.toolbar .dashboard.replay div.navigation-bar):
3308         (.toolbar .dashboard.replay .item.button > .glyph):
3309         (.toolbar.label-only .dashboard.replay .item.button > .glyph):
3310         * UserInterface/Views/ReplayDashboardView.js: Added.
3311         (WebInspector.ReplayDashboardView):
3312         (WebInspector.ReplayDashboardView.prototype._captureButtonItemClicked):
3313         (WebInspector.ReplayDashboardView.prototype._replayButtonItemClicked):
3314         (WebInspector.ReplayDashboardView.prototype._captureStarted):
3315         (WebInspector.ReplayDashboardView.prototype._captureStopped):
3316         (WebInspector.ReplayDashboardView.prototype._playbackStarted):
3317         (WebInspector.ReplayDashboardView.prototype._playbackPaused):
3318         (WebInspector.ReplayDashboardView.prototype._playbackFinished):
3319
3320 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3321
3322         Web Inspector: DebuggerManager commands should return promises
3323         https://bugs.webkit.org/show_bug.cgi?id=135690
3324
3325         Reviewed by Timothy Hatcher.
3326
3327         Convert the existing debugger commands to return promises. This
3328         requires separately waiting for protocol command's promise to be
3329         fulfilled, as well as waiting for the appropriate DebuggerManager
3330         event. If the protocol command promise is rejected, tear down the
3331         single-fire event listener.
3332
3333         * UserInterface/Controllers/DebuggerManager.js:
3334         (WebInspector.DebuggerManager.prototype.pause):
3335         (WebInspector.DebuggerManager.prototype.resume):
3336         (WebInspector.DebuggerManager.prototype.stepOver):
3337         (WebInspector.DebuggerManager.prototype.stepInto):
3338         (WebInspector.DebuggerManager.prototype.stepOut):
3339         * UserInterface/Controllers/ReplayManager.js: Use the promise-based API.
3340         (WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):
3341
3342 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3343
3344         Web Inspector: Update folder icons
3345         https://bugs.webkit.org/show_bug.cgi?id=135808
3346
3347         Reviewed by Joseph Pecoraro.
3348
3349         * UserInterface/Images/FolderGeneric.png: Updated.
3350         * UserInterface/Images/FolderGeneric@2x.png: Updated.
3351
3352 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3353
3354         Web Inspector: DataGrid and its clients are a cluster-cuss of styles
3355         https://bugs.webkit.org/show_bug.cgi?id=135788
3356
3357         Clean up DataGrid and its subclasses and client styles.
3358
3359         Reviewed by Joseph Pecoraro.
3360
3361         * Localizations/en.lproj/localizedStrings.js:
3362         * UserInterface/Views/ApplicationCacheFrameContentView.css:
3363         (.content-view.application-cache-frame > .data-grid):
3364         * UserInterface/Views/CookieStorageContentView.css:
3365         (.content-view.cookie-storage > .data-grid):
3366         * UserInterface/Views/DOMStorageContentView.css:
3367         (.content-view.dom-storage > .data-grid):
3368         * UserInterface/Views/DOMTreeDataGrid.css:
3369         (.dom-tree-data-grid .data-grid):
3370         (.dom-tree-data-grid .name-column .icon):
3371         * UserInterface/Views/DOMTreeDataGrid.js:
3372         (WebInspector.DOMTreeDataGrid):
3373         * UserInterface/Views/DataGrid.css:
3374         (.data-grid):
3375         (.data-grid table):
3376         (.data-grid .data-container):
3377         (.data-grid.inline):
3378         (.data-grid th):
3379         (.data-grid :-webkit-any(th, td):not(:last-child)):
3380         (.data-grid th.sortable:active):
3381         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
3382         (.data-grid table.data):
3383         (.data-grid td):
3384         (.data-grid:focus tr.selected td:not(:last-child)):
3385         (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
3386         (.data-grid :-webkit-any(th, td) > div):
3387         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
3388         (.data-grid th.sort-ascending > div:first-child::after):
3389         (.data-grid th.sort-descending > div:first-child::after):
3390         (.data-grid td .subtitle):
3391         (.data-grid td .subtitle::before):
3392         (.data-grid:focus tr.selected td .subtitle):
3393         (.data-grid td.error):
3394         (.data-grid tr.selected td.error):
3395         (.data-grid td .icon):
3396         (.data-grid td .go-to-arrow):
3397         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):
3398         * UserInterface/Views/DatabaseContentView.css:
3399         (.storage-view):
3400         * UserInterface/Views/DatabaseTableContentView.css:
3401         (.content-view.database-table > .data-grid):
3402         * UserInterface/Views/DetailsSection.css:
3403         (.details-section > .content .data-grid):
3404         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
3405         (.content-view.indexed-database-object-store > .data-grid):
3406         * UserInterface/Views/LayerTreeDataGridNode.js:
3407         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
3408         (WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):
3409         * UserInterface/Views/LayerTreeSidebarPanel.css:
3410         (.layer-tree.panel .data-grid):
3411         (.layer-tree.panel .name-column .icon):
3412         (.layer-tree.panel tr.reflection .name-column .icon):
3413         (.layer-tree.panel tr.pseudo-element .name-column .icon):
3414         (.layer-tree.panel .name-column .reflection):
3415         (.layer-tree.panel tr.selected .name-column .reflection):
3416         (.layer-tree.panel .bottom-bar):
3417         (body.mac-platform.legacy .layer-tree.panel .bottom-bar):
3418         (.layer-tree.panel .bottom-bar > div):
3419         (body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
3420         (body.mac-platform.legacy .layer-tree-popover):
3421         * UserInterface/Views/LayerTreeSidebarPanel.js:
3422         (WebInspector.LayerTreeSidebarPanel):
3423         (WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
3424         (WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
3425         (WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
3426         (WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):
3427         * UserInterface/Views/LegacyJavaScriptProfileView.css:
3428         (.content-view.profile-view > .data-grid):
3429         * UserInterface/Views/LegacyProfileView.css:
3430         * UserInterface/Views/LogContentView.css:
3431         (.console-message .bubble):
3432         * UserInterface/Views/NetworkTimelineView.css:
3433         (.timeline-view.network > .data-grid):
3434         * UserInterface/Views/OverviewTimelineView.css:
3435         (.timeline-view.overview > .timeline-ruler > .header):
3436         (.timeline-view.overview > .data-grid):
3437         * UserInterface/Views/OverviewTimelineView.js:
3438         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
3439         (.details-section.probe-set .options > .probe-add):
3440         (.popover .probe-popover):
3441         * UserInterface/Views/ProbeSetDataGrid.css:
3442         (.details-section.probe-set .data-grid tr.past-value td):
3443         (.details-section.probe-set .data-grid > td.unknown-value):
3444         (.details-section.probe-set .data-grid tr.revealed.highlighted):
3445         (.details-section.probe-set .data-grid tr.separator):
3446         (.details-section.probe-set .data-grid > tr.data-updated):
3447         (.details-section.probe-set .data-grid .selected .section *):
3448         (.details-section.probe-set .data-grid .selected td.unknown-value):
3449         (.details-section.probe-set .data-grid .section):
3450         * UserInterface/Views/QuickConsole.css:
3451         (.quick-console):
3452         * UserInterface/Views/TimelineDataGrid.css:
3453         (.data-grid.timeline th):
3454         (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
3455         * UserInterface/Views/TimelineRuler.css:
3456         (.timeline-ruler > .header):
3457         (.timeline-ruler > .header > .divider):
3458
3459 2014-08-11  Brent Fulgham  <bfulgham@apple.com>
3460
3461         [Win] Adjust build script for Windows production build.
3462         https://bugs.webkit.org/show_bug.cgi?id=135806
3463         <rdar://problem/17978299>
3464
3465         Reviewed by Timothy Hatcher.
3466
3467         * WebInspectorUI.vcxproj/WebInspectorUI.make: Make sure target for
3468         xcopy operation exists.
3469         * WebInspectorUI.vcxproj/WebInspectorUI.proj: Don't create directories
3470         we don't need, make sure the target location exists before we build.
3471         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Make sure that
3472         production builds get the intermediary command files from the
3473         right place.
3474
3475 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3476
3477         Web Inspector: Add a helper to avoid leaking single-fire event listeners in Promise chains
3478         https://bugs.webkit.org/show_bug.cgi?id=135772
3479
3480         Reviewed by Timothy Hatcher.
3481
3482         A common pattern when working with promise chains is to convert an event
3483         handler into a promise by using a single-fire event listener with the
3484         resolve continuation as the callback. This is fine if the event fires;
3485         if it doesn't fire, then the event emitter permanently keeps a reference to the
3486         this-object and the callback.
3487
3488         This patch adds EventListener, a proxy object for events that can be manipulated
3489         from multiple promise callback functions. If a promise is rejected, the catch
3490         block can disconnect any event listeners set up earlier in the promise chain.
3491
3492         This patch also reimplements EventListenerSet to use multiple EventListeners,
3493         since they share the same logic to uniformly handle Inspector and DOM events.
3494
3495         Test: inspector/event-listener.html
3496         Test: inspector/event-listener-set.html
3497
3498         * UserInterface/Base/EventListener.js: Added.
3499         (WebInspector.EventListener):
3500         (WebInspector.EventListener.prototype.this._callback):
3501         (WebInspector.EventListener.prototype.connect):
3502         (WebInspector.EventListener.prototype.disconnect):
3503         * UserInterface/Base/EventListenerSet.js: Update license block.
3504         (WebInspector.EventListenerSet.prototype.register):
3505         (WebInspector.EventListenerSet.prototype.install):
3506         (WebInspector.EventListenerSet.prototype.uninstall):
3507         * UserInterface/Main.html: Include EventListener.
3508         * UserInterface/Test.html: Include EventListener and EventListenerSet.
3509
3510 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3511
3512         Web Inspector: new glyphs are visible on OS X 10.9 builds
3513         https://bugs.webkit.org/show_bug.cgi?id=135743
3514
3515         Reviewed by Joseph Pecoraro.
3516
3517         * UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
3518         * UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
3519         * UserInterface/Images/Legacy/UserInputResult.svg: Removed.
3520         Removed images that were not used.
3521
3522         * UserInterface/Views/DashboardContainerView.css:
3523         (body.mac-platform.legacy .dashboard-container .advance-arrow):
3524         * UserInterface/Views/DebuggerDashboardView.js:
3525         (WebInspector.DebuggerDashboardView):
3526         * UserInterface/Views/FolderIcon.css:
3527         (body.mac-platform.legacy .folder-icon .icon):
3528         * UserInterface/Views/HierarchicalPathComponent.css:
3529         (body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):
3530         * UserInterface/Views/LogContentView.js:
3531         (WebInspector.LogContentView):
3532         Use legacy images.
3533
3534         * UserInterface/Views/NavigationSidebarPanel.css:
3535         (.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
3536         Fix color for selected subtitle.
3537
3538         * UserInterface/Views/TimelineSidebarPanel.js:
3539         (WebInspector.TimelineSidebarPanel):
3540         Use legacy images.
3541
3542 2014-08-09  Brian J. Burg  <burg@cs.washington.edu>
3543
3544         Web Inspector: TimelineManager should reuse empty recordings
3545         https://bugs.webkit.org/show_bug.cgi?id=135749
3546
3547         Reviewed by Timothy Hatcher.
3548
3549         Check whether the recording is empty before creating a new one.
3550
3551         * UserInterface/Controllers/TimelineManager.js:
3552         (WebInspector.TimelineManager.prototype._loadNewRecording):
3553         * UserInterface/Models/TimelineRecording.js:
3554         (WebInspector.TimelineRecording.prototype.isEmpty):
3555         (WebInspector.TimelineRecording.prototype.unloaded):
3556
3557 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3558
3559         Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
3560         https://bugs.webkit.org/show_bug.cgi?id=135726
3561
3562         Reviewed by Timothy Hatcher.
3563
3564         Added a flag for debugging inspector tests which will synchronously log messages.
3565         This avoids failure modes that prevent logging from being added to the test page.
3566
3567         * UserInterface/Base/Test.js:
3568         (InspectorTest.debugLog):
3569         (InspectorTest.addResult):
3570
3571 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3572
3573         Web Inspector: When Switching Recordings, the UI datagrids do not update to match selection
3574         https://bugs.webkit.org/show_bug.cgi?id=135764
3575
3576         Reviewed by Timothy Hatcher.
3577
3578         * UserInterface/Views/TimelineSidebarPanel.js:
3579         When changing the activeContentView trigger an update of the datagrids by
3580         re-applying the filter, which will be different now that the view is different.
3581
3582 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3583
3584         Web Inspector: Uncaught Exception opening Web Inspector - TypeError: undefined is not a function - candidateObjectCookie.every
3585         https://bugs.webkit.org/show_bug.cgi?id=135762
3586
3587         Reviewed by Timothy Hatcher.
3588
3589         * UserInterface/Views/NavigationSidebarPanel.js:
3590         (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
3591         Fix a typo, the wrong object was being used.
3592
3593 2014-08-07  Brian J. Burg  <burg@cs.washington.edu>
3594
3595         REGRESSION(r172094): timeline views are blank after reloading in some situations
3596         https://bugs.webkit.org/show_bug.cgi?id=135742
3597
3598         Reviewed by Timothy Hatcher.
3599
3600         Address various bugs that cause the wrong timeline content views to appear when
3601         starting a recording by reloading the inspected page. Fix other small oversights
3602         that were encountered in the sidebar-based view state restoration code.
3603
3604         * UserInterface/Models/TimelineRecording.js:
3605         (WebInspector.TimelineRecording.prototype.saveIdentityToCookie): Add a dummy implementation.
3606
3607         * UserInterface/Views/NavigationSidebarPanel.js:
3608         (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
3609         This code erroneously matches any tree element whose represented object's
3610         saveIdentityToCookie function produces an empty cookie.
3611
3612         * UserInterface/Views/TimelineContentView.js:
3613         (WebInspector.TimelineContentView.prototype._showTimelineView): Add an assertion
3614         that will find mismatches between represented objects of the TimelineContentView
3615         and TimelineViews.
3616
3617         * UserInterface/Views/TimelineSidebarPanel.js:
3618         (WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie): Don't call
3619         the superclass's implementation, since we do not want to perform a relaxed match
3620         against any of our tree elements. The only thing that can be restored across reopen
3621         is a selected timeline tree element, which is already handled by this override.
3622
3623 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3624
3625         Web Inspector: Fix accidental always true comparison
3626         https://bugs.webkit.org/show_bug.cgi?id=135741
3627
3628         Reviewed by Timothy Hatcher.
3629
3630         Remove accidental "!" that would always cause this comparison to succeed.
3631
3632         * UserInterface/Views/OverviewTimelineView.js:
3633         (WebInspector.OverviewTimelineView.prototype.updateLayout):
3634
3635 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3636
3637         Web Inspector: Timeline Filter Bars are not appearing at all
3638         https://bugs.webkit.org/show_bug.cgi?id=135740
3639
3640         Reviewed by Timothy Hatcher.
3641
3642         * UserInterface/Views/TimelineDataGrid.css:
3643         (.data-grid.timeline.has-non-default-filter > .navigation-bar-container):
3644         (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
3645         (body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar):
3646         Update the positioning and height for non-legacy because the console is now taller.
3647
3648         * UserInterface/Views/ScopeBar.js:
3649         (WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):
3650         Helper to know if there is a non-default filter.
3651
3652         * UserInterface/Views/TimelineDataGrid.js:
3653         (WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
3654         (WebInspector.TimelineDataGrid.prototype._scopeBarSelectedItemsDidChange):
3655         Update scope bar visibility. If non-default we want to always show it.
3656         
3657         (WebInspector.TimelineDataGrid.prototype._updateScopeBarForcedVisibility):
3658         If there is a non-default filter, force showing the bar.
3659
3660 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3661
3662         Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector
3663         https://bugs.webkit.org/show_bug.cgi?id=135745
3664
3665         Reviewed by Timothy Hatcher.
3666
3667         When restoring breakpoints when the inspector is initializing, do not
3668         let setting these breakpoints automatically enable breakpoints. We should
3669         respect the setting in this case.
3670
3671         * UserInterface/Controllers/DebuggerManager.js:
3672         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
3673         (WebInspector.DebuggerManager):
3674
3675 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3676
3677         Web Inspector: Combine and minify Esprima
3678         https://bugs.webkit.org/show_bug.cgi?id=135728
3679
3680         Reviewed by Joseph Pecoraro.
3681
3682         * Scripts/combine-resources.pl:
3683         * Scripts/copy-user-interface-resources.pl:
3684         * UserInterface/External/Esprima/LICENSE: Added.
3685
3686 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3687
3688         Fix regression where tree outline keyboard navigation is broken.
3689
3690         https://bugs.webkit.org/show_bug.cgi?id=135718
3691
3692         Reviewed by Joseph Pecoraro.
3693
3694         * UserInterface/Views/TreeOutline.js:
3695         (TreeElement.prototype.revealed): Fix the check for currentAncestor.hidden.
3696
3697 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3698
3699         Web Inspector: Filter bar text and icon are positioned too low and tight
3700         https://bugs.webkit.org/show_bug.cgi?id=135723
3701
3702         Reviewed by Joseph Pecoraro.
3703
3704         * UserInterface/Views/FilterBar.css:
3705         (.filter-bar > input[type="search"]):
3706         (.filter-bar > input[type="search"]::-webkit-search-decoration):
3707         * UserInterface/Views/SearchBar.css:
3708         (.search-bar > input[type="search"]):
3709
3710 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3711
3712         Web Inspector: Dashboard error and warning icons should be filled when enabled
3713         https://bugs.webkit.org/show_bug.cgi?id=135725
3714
3715         Reviewed by Joseph Pecoraro.
3716
3717         * UserInterface/Images/ErrorsEnabled.svg:
3718         * UserInterface/Images/IssuesEnabled.svg:
3719
3720 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3721
3722         Web Inspector: Dashboard contents shift when window changes active state
3723         https://bugs.webkit.org/show_bug.cgi?id=135724
3724
3725         Reviewed by Timothy Hatcher.
3726
3727         The container was getting a 1px border when inactive and none when active.
3728         Give it a transparent border when active so contents don't change size.
3729
3730         * UserInterface/Views/DashboardContainerView.css:
3731         (.toolbar .dashboard-container):
3732
3733 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3734
3735         Fix reference to missing CloseTimeline.svg image.
3736
3737         Rubber-stamped by Joseph Pecoraro.
3738
3739         * UserInterface/Views/TimelineSidebarPanel.js:
3740         (WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Use CloseLarge.svg instead.
3741
3742 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
3743
3744         [Win] Unreviewed build fix.
3745
3746         Add a WebInspectorUI.proj file for use with MSBuild utility.
3747
3748         * WebInspectorUI.vcxproj/WebInspectorUI.proj: Added.
3749
3750 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3751
3752         Get rid of INPUT_SPEECH
3753         https://bugs.webkit.org/show_bug.cgi?id=135672
3754
3755         Reviewed by Andreas Kling.
3756
3757         * UserInterface/Models/CSSKeywordCompletions.js:
3758
3759 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3760
3761         Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected
3762         https://bugs.webkit.org/show_bug.cgi?id=135372
3763
3764         Reviewed by Timothy Hatcher.
3765
3766         Constrain move selection window dragging to the ruler bounds
3767         based on the mouse down position on the drag window.
3768
3769         * UserInterface/Views/TimelineRuler.js:
3770         (WebInspector.TimelineRuler.prototype._handleMouseDown):
3771         (WebInspector.TimelineRuler.prototype._handleMouseMove):
3772         (WebInspector.TimelineRuler.prototype._handleMouseUp):
3773
3774 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3775
3776         Web Inspector: Update glyphs to be more like Xcode 6
3777         https://bugs.webkit.org/show_bug.cgi?id=135705
3778
3779         Reviewed by Joseph Pecoraro.
3780
3781         * Localizations/en.lproj/localizedStrings.js: Updated.
3782
3783         * UserInterface/Base/ImageUtilities.js:
3784         (platformImagePath): Added.
3785         (generateEmbossedImages.generateImage):
3786         Bump the base image version. Helper function. Use isLegacyMacOS.
3787
3788         * UserInterface/Base/Main.js:
3789         (WebInspector.contentLoaded):
3790         (WebInspector._updateDockNavigationItems):
3791         (WebInspector._generateDisclosureTriangleImages):
3792         Use new images and add legacy path. Remove the shadow.
3793
3794         * UserInterface/Images: Updated images.
3795         * UserInterface/Images/Legacy: Added. Moved legacy images here.
3796
3797         * UserInterface/Views/CSSStyleDeclarationSection.css:
3798         (.style-declaration-section):
3799         (body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
3800         (.style-declaration-section.last-in-group):
3801         (.style-declaration-section.last-in-group + .style-declaration-section):
3802         Use a consistent gray for borders.
3803
3804         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
3805         (.sidebar > .panel.details.css-style > .content > .pseudo-classes):
3806         Use a consistent gray for borders.
3807
3808         * UserInterface/Views/ContentBrowser.js:
3809         (WebInspector.ContentBrowser):
3810         Use new images and add legacy path.
3811
3812         * UserInterface/Views/ControlToolbarItem.css:
3813         (.toolbar .item.control):
3814         (body.mac-platform.legacy .toolbar .item.control):
3815         (.toolbar .item.control:hover):
3816         (body.mac-platform.legacy .toolbar .item.control:hover):
3817         Adjust the opacity for controls.
3818
3819         * UserInterface/Views/DOMTreeContentView.js:
3820         (WebInspector.DOMTreeContentView):
3821         Use new images and add legacy path.
3822
3823         * UserInterface/Views/DataGrid.css:
3824         (.data-grid tr.selected):
3825         Use a consistent gray for borders.
3826
3827         * UserInterface/Views/DataGrid.js:
3828         (WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
3829         Use new images and add legacy path. Remove the shadow.
3830
3831         * UserInterface/Views/DebuggerSidebarPanel.js:
3832         (WebInspector.DebuggerSidebarPanel):
3833         Use new images and add legacy path.
3834
3835         * UserInterface/Views/DefaultDashboardView.css:
3836         (.toolbar .dashboard.default > .item):
3837         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3838         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img):
3839         (body.mac-platform.legacy .toolbar .dashboard.default > .time > img):
3840         (body.mac-platform.legacy .toolbar .dashboard.default > .logs > img):
3841         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesSize > img):
3842         (body.mac-platform.legacy .toolbar .dashboard.default > .errors > img):
3843         (body.mac-platform.legacy .toolbar .dashboard.default > .errors.enabled > img):
3844         (body.mac-platform.legacy .toolbar .dashboard.default > .issues > img):
3845         (body.mac-platform.legacy .toolbar .dashboard.default > .issues.enabled > img):
3846         Use new images and add legacy path.
3847
3848         * UserInterface/Views/DetailsSection.css:
3849         (.details-section):
3850         (.details-section .details-section:first-child):
3851         (body.mac-platform.legacy .details-section > .header):
3852         (.details-section > .content > .group):
3853         (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *):
3854         (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *):
3855         Use a consistent gray for borders.
3856
3857         * UserInterface/Views/FilterBar.css:
3858         (body.mac-platform.legacy .filter-bar > input[type="search"]::-webkit-search-decoration):
3859         Use new images and add legacy path.
3860
3861         * UserInterface/Views/FindBanner.css:
3862         (.find-banner):