Web Inspector: Reduce work when activating multiple agents sequentially
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2014-11-12  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Reduce work when activating multiple agents sequentially
4         https://bugs.webkit.org/show_bug.cgi?id=138677
5
6         Reviewed by Timothy Hatcher.
7
8         * UserInterface/Base/Main.js:
9         (WebInspector.activateExtraDomains):
10         * UserInterface/Controllers/FrameResourceManager.js:
11         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
12         * UserInterface/Controllers/StorageManager.js:
13         (WebInspector.StorageManager.prototype._extraDomainsActivated):
14
15 2014-11-11  Joseph Pecoraro  <pecoraro@apple.com>
16
17         Web Inspector: Handle activating extra agents properly after inspector has connected
18         https://bugs.webkit.org/show_bug.cgi?id=138639
19
20         Reviewed by Timothy Hatcher.
21
22         * UserInterface/Base/Main.js:
23         (WebInspector.activateExtraDomains):
24
25 2014-11-11  Jonathan Wells  <jonowells@apple.com>
26
27         Web Inspector: Main.js missing many trailing semicolons
28         https://bugs.webkit.org/show_bug.cgi?id=138624
29
30         Add semicolons to function variable assignments.
31
32         Reviewed by Timothy Hatcher.
33
34         * UserInterface/Base/Main.js: Added semicolons.
35
36 2014-11-10  Jonathan Wells  <jonowells@apple.com>
37
38         Web Inspector: Update Esprima, remove WebInspector.Esprima global.
39         https://bugs.webkit.org/show_bug.cgi?id=138579
40
41         Reviewed by Timothy Hatcher.
42
43         Update esprima.js file to be unchanged by removing WebInspector.Esprima global object. Move esprima.js include
44         so that all external libraries load before the WebInspector namespace is declared in the combined Main.js.
45
46         * UserInterface/External/Esprima/esprima.js: File updated, no changes made.
47         * UserInterface/Main.html: esprima.js script tag moved up with other externals.
48         * UserInterface/Models/ScriptSyntaxTree.js: WebInspector.Esprima changed to esprima
49         (WebInspector.ScriptSyntaxTree):
50
51 2014-11-10  Jonathan Wells  <jonowells@apple.com>
52
53         Web Inspector: Add infrastructure for eslint based static analyzer
54         https://bugs.webkit.org/show_bug.cgi?id=137890
55
56         Reviewed by Timothy Hatcher.
57
58         Fix to previous patch to add AnalyzerManager and AnalyzerMessage classes. Changed Main.html to include ESLint.js
59         before Main.js in the combined resources.
60
61         * UserInterface/Base/Main.js:
62         * UserInterface/Controllers/AnalyzerManager.js: Added.
63         (WebInspector.AnalyzerManager):
64         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
65         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
66         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
67         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
68         * UserInterface/Main.html:
69         * UserInterface/Models/AnalyzerMessage.js: Added.
70         (WebInspector.AnalyzerMessage):
71         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
72         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
73         (WebInspector.AnalyzerMessage.prototype.get text):
74         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
75         * UserInterface/Models/SourceCode.js:
76
77 2014-11-08  Matt Baker  <mattbaker@apple.com>
78
79         Web Inspector: decouple child element folderization logic from FrameTreeElement
80         https://bugs.webkit.org/show_bug.cgi?id=138364
81
82         Reviewed by Timothy Hatcher.
83
84         Created FolderizedTreeElement base class, which FrameTreeElement now inherits via SourceCodeTreeElement.
85         FolderizedTreeElement uses settings provided by derived classes for labeling subfolders and to determine
86         folder membership for child items.
87
88         * UserInterface/Base/Main.js:
89         (WebInspector.canArchiveMainFrame):
90         * UserInterface/Main.html:
91         * UserInterface/Models/LayoutTimelineRecord.js:
92         (WebInspector.LayoutTimelineRecord.displayNameForEventType):
93         (WebInspector.LayoutTimelineRecord.EventType.displayName): Deleted.
94         * UserInterface/Models/Resource.js:
95         (WebInspector.Resource):
96         (WebInspector.Resource.typeFromMIMEType):
97         (WebInspector.Resource.displayNameForType):
98         (WebInspector.Resource.prototype.get syntheticMIMEType):
99         (WebInspector.Resource.prototype.updateForResponse):
100         (WebInspector.Resource.Type.fromMIMEType): Deleted.
101         (WebInspector.Resource.Type.displayName): Deleted.
102         * UserInterface/Models/SourceMapResource.js:
103         (WebInspector.SourceMapResource):
104         * UserInterface/Views/FolderizedTreeElement.js: Added.
105         (WebInspector.FolderizedTreeElement):
106         (WebInspector.FolderizedTreeElement.prototype.get groupedIntoFolders):
107         (WebInspector.FolderizedTreeElement.prototype.set folderSettingsKey):
108         (WebInspector.FolderizedTreeElement.prototype.registerFolderizeSettings):
109         (WebInspector.FolderizedTreeElement.prototype.set removeChildren):
110         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject):
111         (WebInspector.FolderizedTreeElement.prototype.addRepresentedObjectToNewChildQueue):
112         (WebInspector.FolderizedTreeElement.prototype.removeChildForRepresentedObject):
113         (WebInspector.FolderizedTreeElement.prototype.compareChildTreeElements):
114         (WebInspector.FolderizedTreeElement.prototype.updateParentStatus):
115         (WebInspector.FolderizedTreeElement.prototype._clearNewChildQueue):
116         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
117         (WebInspector.FolderizedTreeElement.prototype._removeRepresentedObjectFromNewChildQueue):
118         (WebInspector.FolderizedTreeElement.prototype._addTreeElement):
119         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
120         (WebInspector.FolderizedTreeElement.prototype._insertFolderTreeElement):
121         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
122         (WebInspector.FolderizedTreeElement.prototype._removeTreeElement):
123         (WebInspector.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
124         (WebInspector.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange):
125         (WebInspector.FolderizedTreeElement.prototype._settingsForRepresentedObject):
126         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
127         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
128         * UserInterface/Views/FrameTreeElement.js:
129         (.this):
130         (WebInspector.FrameTreeElement.prototype.updateSourceMapResources):
131         (WebInspector.FrameTreeElement.prototype.onattach):
132         (WebInspector.FrameTreeElement.prototype.ondetach):
133         (WebInspector.FrameTreeElement.prototype.compareChildTreeElements):
134         (WebInspector.FrameTreeElement.prototype.onpopulate):
135         (WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
136         (WebInspector.FrameTreeElement.prototype._resourceWasAdded):
137         (WebInspector.FrameTreeElement.prototype._resourceWasRemoved):
138         (WebInspector.FrameTreeElement.prototype._childFrameWasAdded):
139         (WebInspector.FrameTreeElement.prototype._childFrameWasRemoved):
140         (WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
141         (WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
142         (WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
143         (WebInspector.FrameTreeElement): Deleted.
144         (WebInspector.FrameTreeElement.prototype.removeChildren): Deleted.
145         (WebInspector.FrameTreeElement.prototype._updateParentStatus): Deleted.
146         (WebInspector.FrameTreeElement.prototype._addRepresentedObjectToNewChildQueue): Deleted.
147         (WebInspector.FrameTreeElement.prototype._removeRepresentedObjectFromNewChildQueue): Deleted.
148         (WebInspector.FrameTreeElement.prototype._populateFromNewChildQueue): Deleted.
149         (WebInspector.FrameTreeElement.prototype._clearNewChildQueue): Deleted.
150         (WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject): Deleted.
151         (WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject): Deleted.
152         (WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject): Deleted.
153         (WebInspector.FrameTreeElement.prototype._addTreeElement): Deleted.
154         (WebInspector.FrameTreeElement.prototype._compareTreeElementsByMainTitle): Deleted.
155         (WebInspector.FrameTreeElement.prototype._insertFolderTreeElement): Deleted.
156         (WebInspector.FrameTreeElement.prototype._compareResourceTreeElements): Deleted.
157         (WebInspector.FrameTreeElement.prototype._insertResourceTreeElement): Deleted.
158         (WebInspector.FrameTreeElement.prototype._removeTreeElement): Deleted.
159         (WebInspector.FrameTreeElement.prototype._folderNameForResourceType): Deleted.
160         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject.createFolderTreeElement): Deleted.
161         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject): Deleted.
162         (WebInspector.FrameTreeElement.prototype._folderTreeElementExpandedStateChange): Deleted.
163         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType): Deleted.
164         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory): Deleted.
165         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders): Deleted.
166         * UserInterface/Views/LayoutTimelineDataGridNode.js:
167         (WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
168         * UserInterface/Views/LayoutTimelineView.js:
169         (WebInspector.LayoutTimelineView): Deleted.
170         * UserInterface/Views/NetworkTimelineView.js:
171         (WebInspector.NetworkTimelineView): Deleted.
172         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
173         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshResourceType):
174         * UserInterface/Views/ResourceTimelineDataGridNode.js:
175         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
176         * UserInterface/Views/SourceCodeTreeElement.js:
177         (WebInspector.SourceCodeTreeElement):
178         * UserInterface/Views/TimelineDataGrid.js:
179         (WebInspector.TimelineDataGrid.createColumnScopeBar):
180         * UserInterface/Views/TimelineRecordTreeElement.js:
181         (WebInspector.TimelineRecordTreeElement):
182         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
183         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
184
185 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
186
187         Web Inspector: Layer summary should be bottom sticky
188         https://bugs.webkit.org/show_bug.cgi?id=138518
189
190         Reviewed by Timothy Hatcher.
191
192         Previously only NavigationSidebars had a content view. Now, give all
193         Sidebars a contentElement section for content.
194
195         Update all Details Sidebars to append content to the contentElement
196         instead of directly to the element. Only two Details sidebars append
197         to the element:
198
199           - CSSStyleDetailsSidebarPanel for the navigation bar at the top
200           - LayerTreeDetailsSidebarPanel for the summary view at the bottom
201
202         Take this opportunity to fix up some naming and styles as well.
203
204         * UserInterface/Views/SidebarPanel.js:
205         (WebInspector.SidebarPanel):
206         (WebInspector.SidebarPanel.prototype.get contentElement):
207         Give every SidebarPanel a content element.
208
209         * UserInterface/Views/DetailsSidebarPanel.css: Removed.
210         (.sidebar > .panel > .content):
211         * UserInterface/Views/SidebarPanel.css: Added.
212         (.sidebar > .panel > .content):
213         And give that content element a default style.
214
215         * UserInterface/Views/NavigationSidebarPanel.css:
216         (.sidebar > .panel.navigation > .content):
217         * UserInterface/Views/NavigationSidebarPanel.js:
218         (WebInspector.NavigationSidebarPanel):
219         (WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
220         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
221         (WebInspector.NavigationSidebarPanel.prototype.get contentElement): Deleted.
222         Navigation sidebar panels now use the parent's contentElement.
223         Also, carry over their default styles, overriding the base.
224
225         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js.
226         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildLayerInfoSection):
227         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
228         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildBottomBar):
229         Rename LayerTreeSidebarPanel to make it clear this is a DetailsSidebarPanel.
230         Add the "bottom bar" to the root element, and sections to the contentElement.
231
232         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css.
233         (.sidebar > .layer-tree.panel > .content):
234         (body.mac-platform.legacy .sidebar > .layer-tree.panel > .content):
235         Style the bottom bar to pin it to the bottom of the sidebar panel.
236
237         (WebInspector.CSSStyleDetailsSidebarPanel):
238         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
239         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
240         Add the navigation bar to the root element, and sections to the contentElement.
241
242         * UserInterface/Base/Main.js:
243         (WebInspector.contentLoaded):
244         * UserInterface/Main.html:
245         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
246         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
247         Update for new names.
248
249         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
250         (WebInspector.ApplicationCacheDetailsSidebarPanel):
251         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
252         * UserInterface/Views/DOMDetailsSidebarPanel.js:
253         (WebInspector.DOMDetailsSidebarPanel):
254         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
255         (WebInspector.DOMNodeDetailsSidebarPanel):
256         * UserInterface/Views/DetailsSidebarPanel.js:
257         (WebInspector.DetailsSidebarPanel):
258         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
259         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
260         (WebInspector.ResourceDetailsSidebarPanel):
261         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
262         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
263         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
264         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
265         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh.delayedWork):
266         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
267         All details sidebar panels now use the contentElement instead of element for content.
268
269 2014-11-07  Timothy Hatcher  <timothy@apple.com>
270
271         Web Inspector: Cursor and scroll view jumps around when modifying styles
272         https://bugs.webkit.org/show_bug.cgi?id=137467
273
274         This merges commit e2962a5b0df56c8ee5a4482899d308decf3d7677 from CodeMirror.
275
276         Reviewed by Joseph Pecoraro.
277
278         * UserInterface/External/CodeMirror/codemirror.js:
279         (maybeScrollWindow): Signal the scrollCursorIntoView event.
280         (signalDOMEvent): Support string events by transforming them to event objects.
281
282         * UserInterface/Views/CodeMirrorAdditions.js:
283         (scrollCursorIntoView): Added. Default event listener that provides our own
284         implementation using WebKit's scrollIntoViewIfNeeded.
285
286         * UserInterface/Views/RulesStyleDetailsPanel.js:
287         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Stop doing an
288         extra scrollIntoViewIfNeeded call, CodeMirror does this.
289
290 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
291
292         Web Inspector: Pseudo element matchedCSSRules do not include matching selector info
293         https://bugs.webkit.org/show_bug.cgi?id=138438
294
295         Reviewed by Benjamin Poulain.
296
297         * UserInterface/Base/Test.js:
298         (WebInspector.loaded):
299         Include a global setting for shadow dom used by DOM model classes.
300         Give it a "test" specific name to not override non-test setting values.
301
302 2014-11-05  Commit Queue  <commit-queue@webkit.org>
303
304         Unreviewed, rolling out r175628.
305         https://bugs.webkit.org/show_bug.cgi?id=138451
306
307         Totally borked the web inspector (Requested by smfr on
308         #webkit).
309
310         Reverted changeset:
311
312         "Web Inspector: Add infrastructure for eslint based static
313         analyzer"
314         https://bugs.webkit.org/show_bug.cgi?id=137890
315         http://trac.webkit.org/changeset/175628
316
317 2014-11-05  Joseph Pecoraro  <pecoraro@apple.com>
318
319         Web Inspector: Specificity not shown for pseudo element styles
320         https://bugs.webkit.org/show_bug.cgi?id=138436
321
322         Reviewed by Benjamin Poulain.
323
324         * UserInterface/Views/CSSStyleDeclarationSection.js:
325         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
326         Previously we were skipping the pre-selector <span>s when we were
327         not getting a listing of matched selector indices, and missing out
328         on the opportunity to give each selector a specificity. Now, always
329         loop over selectors if we have them.
330
331 2014-11-05  Jonathan Wells  <jonowells@apple.com>
332
333         Web Inspector: Add infrastructure for eslint based static analyzer
334         https://bugs.webkit.org/show_bug.cgi?id=137890
335
336         Reviewed by Timothy Hatcher.
337
338         Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.
339
340         * UserInterface/Base/Main.js: Create analyzerManager singleton.
341         * UserInterface/Controllers/AnalyzerManager.js: Added.
342         (WebInspector.AnalyzerManager):
343         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
344         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
345         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
346         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
347         * UserInterface/Main.html: Add new files.
348         * UserInterface/Models/AnalyzerMessage.js: Added.
349         (WebInspector.AnalyzerMessage):
350         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
351         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
352         (WebInspector.AnalyzerMessage.prototype.get text):
353         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
354         * UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().
355
356 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
357
358         Web Inspector: Too much whitespace in resource details sidebar in groups
359         https://bugs.webkit.org/show_bug.cgi?id=138386
360
361         Reviewed by Timothy Hatcher.
362
363         * UserInterface/Views/DetailsSection.css:
364         (.details-section > .content > .group:first-child > .row.simple:first-child > *):
365         (body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *):
366         (body.mac-platform.legacy .details-section > .content > .group > .row.text):
367         (.details-section > .content > .group > .row.properties:not(.empty)):
368         (body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)):
369         Adjust top and bottom padding.
370
371 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
372
373         Web Inspector: Lots of TimelineDataGridNode asserts on reloads
374         https://bugs.webkit.org/show_bug.cgi?id=138387
375
376         Reviewed by Brian Burg.
377
378         The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
379         with a non-0 value and saved in a setting. However the TimelineRuler in
380         the OverviewTimelineView is not initialized with this value, and instead
381         initialized to 0. This patch initializes them to the same non-0 value.
382
383         * UserInterface/Views/OverviewTimelineView.js:
384         (WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):
385         * UserInterface/Views/TimelineContentView.js:
386
387 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
388
389         Web Inspector: Pause on exceptions should show the actual exception
390         https://bugs.webkit.org/show_bug.cgi?id=63096
391
392         Reviewed by Timothy Hatcher.
393
394         * Localizations/en.lproj/localizedStrings.js:
395         * UserInterface/Main.html:
396         New strings / files.
397
398         * UserInterface/Controllers/DebuggerManager.js:
399         (WebInspector.DebuggerManager.prototype.get pauseReason):
400         (WebInspector.DebuggerManager.prototype.get pauseData):
401         (WebInspector.DebuggerManager.prototype.reset):
402         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
403         (WebInspector.DebuggerManager.prototype._pauseReasonFromPayload):
404         Maintain the current pause reason and auxiliary data in the manager.
405
406         * UserInterface/Protocol/DebuggerObserver.js:
407         (WebInspector.DebuggerObserver.prototype.paused):
408         Pass previously unused event parameters on to the manager.
409
410         * UserInterface/Views/ConsoleMessageImpl.js:
411         (WebInspector.ConsoleMessageImpl):
412         Style error objects in the console like Objects. The new description
413         string provides a richer message if you console.log(exception).
414
415         * UserInterface/Views/DebuggerSidebarPanel.js:
416         (WebInspector.DebuggerSidebarPanel):
417         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
418         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
419         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
420         Update the UI when we pause / resume to show / hide a pause reason section.
421
422         * UserInterface/Views/DetailsSectionRow.js:
423         (WebInspector.DetailsSectionRow.prototype.set emptyMessage):
424         Fix a latent bug that would have thrown an exception if the setter was ever used.
425
426         * UserInterface/Views/DetailsSectionTextRow.js: Added.
427         (WebInspector.DetailsSectionTextRow):
428         (WebInspector.DetailsSectionTextRow.prototype.get text):
429         (WebInspector.DetailsSectionTextRow.prototype.set text):
430         * UserInterface/Views/DetailsSection.css:
431         (.details-section > .content > .group > .row.simple.data > .value):
432         (.details-section > .content > .group > .row.text):
433         Simple class for a section of centered text. This is modelled after
434         the empty message text style in other sections.
435
436         * UserInterface/Views/LogContentView.css:
437         (.console-formatted-object, .console-formatted-node, .console-formatted-error):
438         (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-error .section):
439         (.console-formatted-object .properties, .console-formatted-node .properties, .console-formatted-error .properties):
440         Style "error" objects like regular objects. We may wish to treat differently later.
441
442         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
443         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
444         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
445         Regenerate legacy backend commands to get the new enum.
446
447 2014-11-04  Andrei Bucur  <abucur@adobe.com>
448
449         Building WebInspectorUI should not run the clang static analyzer by default
450         https://bugs.webkit.org/show_bug.cgi?id=137652
451
452         Reviewed by Timothy Hatcher.
453
454         There's no need to have the static analyzer enabled at compile time by default for the WebInspectorUI project.
455         It also breaks the ASAN build because the static analyzing step runs using the default compiler not the
456         ASAN clang.
457
458         * Configurations/DebugRelease.xcconfig: Remove the RUN_CLANG_STATIC_ANALYZER variable.
459
460 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
461
462         Web Inspector: Uncaught Exceptions when paused and hovering JavaScript without CallFrames
463         https://bugs.webkit.org/show_bug.cgi?id=138338
464
465         Reviewed by Geoffrey Garen.
466
467         * UserInterface/Views/SourceCodeTextEditor.js:
468         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
469         Fallback to using the main page's context if there is no active call frame we can use.
470
471 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
472
473         Web Inspector: TextEditor search doesn't work after editing contents
474         https://bugs.webkit.org/show_bug.cgi?id=138198
475
476         Reviewed by Timothy Hatcher.
477
478         * UserInterface/Views/SourceCodeTextEditor.js:
479         (WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
480         Fallback to pure TextEditor content searching (CodeMirror) if the editor has edits.
481
482         * UserInterface/Views/TextEditor.js:
483         (WebInspector.TextEditor.prototype.hasEdits):
484         Check the CodeMirror clean state to known if we have edits or not.
485
486 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
487
488         Web Inspector: Show Selector's Specificity
489         https://bugs.webkit.org/show_bug.cgi?id=138189
490
491         Reviewed by Timothy Hatcher.
492
493         * Localizations/en.lproj/localizedStrings.js:
494         * UserInterface/Main.html:
495         * UserInterface/Test.html:
496         Add new files and strings.
497
498         * UserInterface/Models/CSSMedia.js:
499         Constructor functions are not needed, remove unnecessary code.
500
501         * UserInterface/Models/CSSRule.js:
502         (WebInspector.CSSRule.prototype.set selectors): Deleted.
503         This was unused and is no longer correct.
504
505         (WebInspector.CSSRule.prototype.get matchedSelectorText):
506         Update now that selectors are a list of objects, not just strings.
507
508         * UserInterface/Models/CSSSelector.js:
509         (WebInspector.CSSSelector):
510         (WebInspector.CSSSelector.prototype.get specificity):
511         New model object for protocol type CSS.CSSSelector.
512
513         * UserInterface/Models/DOMNodeStyles.js:
514         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
515         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
516         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
517         Handle parsing old and new SelectorLists.
518
519         * UserInterface/Views/CSSStyleDeclarationSection.js:
520         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
521         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelectorText):
522         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
523         Update the code now that the list of selectors are model objects instead
524         of just selector text strings.
525
526 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
527
528         Web Inspector: ALTERNATE_DISPATCHERS Let the frontend know about extra agents
529         https://bugs.webkit.org/show_bug.cgi?id=138236
530
531         Reviewed by Brian Burg.
532
533         * UserInterface/Protocol/InspectorBackend.js:
534         (InspectorBackendClass.prototype.activateDomain):
535         * UserInterface/Protocol/InspectorObserver.js:
536         (WebInspector.InspectorObserver.prototype.activateExtraDomains):
537         * UserInterface/Base/Object.js:
538         * UserInterface/Base/Test.js:
539         * UserInterface/Base/Main.js:
540         (WebInspector.activateExtraDomains):
541         Default state is that there are no extra domains. When extra domains
542         are activated, some agents need to be re-initialized. Dispatch a
543         model event so views also know to re-initialize.
544
545         * UserInterface/Controllers/ApplicationCacheManager.js:
546         (WebInspector.ApplicationCacheManager.prototype._mainResourceDidChange):
547         * UserInterface/Controllers/DOMTreeManager.js:
548         Be more careful about direct agent use during main resource changes.
549         That can happen with a JSContext extended with a Page agent.
550
551         * UserInterface/Controllers/FrameResourceManager.js:
552         (WebInspector.FrameResourceManager):
553         (WebInspector.FrameResourceManager.prototype._mainFrameDidChange):
554         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
555         * UserInterface/Controllers/StorageManager.js:
556         (WebInspector.StorageManager):
557         (WebInspector.StorageManager.prototype._databaseForIdentifier):
558         (WebInspector.StorageManager.prototype._extraDomainsActivated):
559         It is possible new window.FooAgent's are available. Perform expected
560         initialization re-checking if the agents are now available.
561
562         * UserInterface/Models/CSSCompletions.js:
563         Avoid re-initialization if we already did it. This should never
564         happen but this is just to be safe.
565
566         * UserInterface/Views/ResourceSidebarPanel.js:
567         (WebInspector.ResourceSidebarPanel):
568         (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
569         Don't disallow expandable tree elements if this is a JSContext with
570         extra domains. If that JSContext has resources, we would have been
571         unable to see child resources.
572
573 2014-10-30  Dana Burkart  <dburkart@apple.com>
574
575         <rdar://problem/18821260> Prepare for the mysterious future
576
577         Reviewed by Lucas Forschler.
578
579         * Configurations/Base.xcconfig:
580         * Configurations/DebugRelease.xcconfig:
581         * Configurations/Version.xcconfig:
582
583 2014-10-10 Brian J. Burg  <burg@cs.washington.edu>
584
585         Web Inspector: timelines should not count time elapsed while paused in the debugger
586         https://bugs.webkit.org/show_bug.cgi?id=136351
587
588         Reviewed by Timothy Hatcher.
589
590         Don't update the timeline's current time when the debugger is paused.
591
592         Start and end times for timeline records are now in seconds elapsed since timeline
593         recording started, rather than milliseconds since the epoch. Also convert code that
594         tracks page/resource load timings to use elapsed times rather than timestamps.
595
596         Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
597         in multiple agents to elapsed times.
598
599         * UserInterface/Controllers/FrameResourceManager.js:
600         (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
601         (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
602         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
603         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
604         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
605         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
606         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
607         * UserInterface/Controllers/ProbeManager.js:
608         * UserInterface/Controllers/TimelineManager.js:
609         (WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
610         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
611         (WebInspector.TimelineManager.prototype.eventRecorded):
612         (WebInspector.TimelineManager.prototype.pageDidLoad):
613         (WebInspector.TimelineManager.prototype._loadNewRecording):
614         * UserInterface/Models/Probe.js:
615         (WebInspector.ProbeSample):
616         * UserInterface/Models/Resource.js:
617         (WebInspector.Resource.prototype.updateForRedirectResponse):
618         (WebInspector.Resource.prototype.updateForResponse):
619         (WebInspector.Resource.prototype.increaseSize):
620         (WebInspector.Resource.prototype.markAsFinished):
621         (WebInspector.Resource.prototype.markAsFailed):
622         (WebInspector.Resource.prototype.revertMarkAsFinished):
623         * UserInterface/Models/TimelineRecording.js:
624         (WebInspector.TimelineRecording.prototype.computeElapsedTime):
625         * UserInterface/Views/TimelineContentView.js:
626         (WebInspector.TimelineContentView.prototype._debuggerPaused):
627         (WebInspector.TimelineContentView.prototype._debuggerResumed):
628
629
630 2014-10-23  Jono Wells  <jonowells@apple.com>
631
632         Web Inspector: Double border appearing in node sidebar in expanded items in OS X Mavericks.
633         https://bugs.webkit.org/show_bug.cgi?id=138011
634
635         Reviewed by Timothy Hatcher.
636
637         Selector added for OS X Mavericks and earlier versions using .mac-platform.legacy.
638
639         * UserInterface/Views/DetailsSection.css:
640         (body.mac-platform.legacy .details-section .details-section:first-child):
641
642 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
643
644         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
645         https://bugs.webkit.org/show_bug.cgi?id=132044
646
647         Reviewed by Brian Burg.
648
649         Make sure Protocol/InspectorFrontendHostStub.js is loaded before
650         Base/Platform.js, because Platform uses the InspectorFrontendHost
651         object.
652
653         * UserInterface/Main.html:
654
655 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
656
657         Web Inspector: InspectorBackendCommands should include when to activate particular domains
658         https://bugs.webkit.org/show_bug.cgi?id=137753
659
660         Reviewed by Timothy Hatcher.
661
662         * UserInterface/Base/Main.js:
663         * UserInterface/Base/Test.js:
664         (WebInspector.loaded):
665         Activation now happens automatically so remove the hardcoded activations.
666
667         * UserInterface/Protocol/InspectorBackend.js:
668         (InspectorBackendClass.prototype.activateDomain):
669         Given no filter, always activate a domain. Otherwise only activate
670         if the debuggable type matches the provided filter.
671
672         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
673         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
674         Only web debuggables are supported in iOS 6 and 7. The JSON files do not
675         need to change, all agents will auto activate.
676
677         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
678         * Versions/Inspector-iOS-8.0.json:
679         Specify which are web debuggables in iOS 8 since JS inspection is possible.
680
681 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
682
683         Web Inspector: Generate all Inspector domains together in JavaScriptCore
684         https://bugs.webkit.org/show_bug.cgi?id=137748
685
686         Reviewed by Brian Burg.
687
688         Change the frontend to always load all agents, but only activate a subset
689         of the agents depending on the type of the backend.
690
691         * UserInterface/Base/Main.js:
692         (WebInspector.loaded):
693         * UserInterface/Protocol/InspectorBackend.js:
694         (InspectorBackendClass.prototype.activateDomains):
695         (InspectorBackendClass.prototype.activateAllDomains):
696         (InspectorBackendClass.prototype._agentForDomain):
697         (InspectorBackendClass.prototype._dispatchEvent):
698         (InspectorBackend.Agent):
699         (InspectorBackend.Agent.prototype.get active):
700         (InspectorBackend.Agent.prototype.activate):
701         * UserInterface/Base/Test.js:
702         Only expose "window.FooAgent" or allow dispatches in the "Foo" domain
703         when that particular agent is activated. Currently we hardcode the list
704         of agents to activate for a debuggable type. This should be generated.
705
706         * UserInterface/Protocol/LoadInspectorBackendCommands.js:
707         Now there should always be a single "InspectorBackendCommands.js" file to load.
708         We may want to change the RWI path to return a single file instead of an array.
709
710         * Scripts/update-LegacyInspectorBackendCommands.rb:
711         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js.
712         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js.
713         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js.
714         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Removed.
715         * Versions/Inspector-iOS-8.0.json: Renamed from Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json.
716         * Versions/InspectorJS-iOS-8.0.json: Removed.
717         Update Legacy versions to output a single InspectorBackendCommands.js file.
718         Do a straightforward merge of the iOS 8 JS/Web inputs to a single json file.
719
720         * Configurations/Base.xcconfig:
721         * Configurations/DebugRelease.xcconfig:
722         * Configurations/WebInspectorUIFramework.xcconfig:
723         * Scripts/copy-user-interface-resources-dryrun.rb:
724         * Scripts/copy-user-interface-resources.pl:
725         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
726         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
727         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
728         We no longer needed WebCore's Private Headers, so simplify build files
729         and update file names where appropriate.
730
731 2014-10-17  Jono Wells  <jonowells@apple.com>
732
733         Web Inspector: Add ESLint open source library to the inspector
734         https://bugs.webkit.org/show_bug.cgi?id=137714
735
736         Reviewed by Joseph Pecoraro.
737
738         This adds back the eslint.js external library with a correction to Scripts/copy-user-interface-resources.pl
739         to prevent a build failure.
740
741         * Scripts/copy-user-interface-resources.pl: Added copy commands for ESLint.js.
742         * UserInterface/External/ESLint/LICENSE: Added.
743         * UserInterface/External/ESLint/eslint.js: Added.
744
745 2014-10-14  Jono Wells  <jonowells@apple.com>
746
747         Web Inspector: Add ESLint open source library to the inspector
748         https://bugs.webkit.org/show_bug.cgi?id=137714
749
750         Reviewed by Timothy Hatcher.
751
752         This adds the eslint.js external library for static analysis and the necessary license.
753
754         * Scripts/copy-user-interface-resources.pl:
755         * UserInterface/External/ESLint/LICENSE: Added.
756         * UserInterface/External/ESLint/eslint.js: Added.
757
758 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
759
760         Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
761         https://bugs.webkit.org/show_bug.cgi?id=137575
762
763         Reviewed by Simon Fraser.
764
765         Remove setShowPaintRects from the legacy iOS protocol definitions.
766         The methods were unimplemented by the backends, so they should
767         not advertise supporting it.
768
769         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
770         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
771         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
772         * Versions/Inspector-iOS-6.0.json:
773         * Versions/Inspector-iOS-7.0.json:
774         * Versions/InspectorWeb-iOS-8.0.json:
775
776 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
777
778         Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
779         https://bugs.webkit.org/show_bug.cgi?id=137681
780
781         Reviewed by Timothy Hatcher.
782
783         Handle processing instruction node types in more places. The
784         backend sends the contents as a pure string, not as attribute
785         pairs, so just include the string in the UI.
786
787         * UserInterface/Models/DOMSearchMatchObject.js:
788         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
789         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
790         * UserInterface/Views/DOMTreeElement.js:
791         (WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
792         Display the value in the UI.
793
794         * UserInterface/Views/DOMTreeElementPathComponent.js:
795         (WebInspector.DOMTreeElementPathComponent):
796         Include an icon like DOCTYPE.
797
798         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
799         (.syntax-highlighted .html-processing-instruction):
800         Style gray like a DOCTYPE.
801
802 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
803
804         Web Inspector: Paint Flashing button does not match page state after reload
805         https://bugs.webkit.org/show_bug.cgi?id=137680
806
807         Reviewed by Timothy Hatcher.
808
809         * UserInterface/Base/Main.js:
810         (WebInspector.loaded):
811         Make paint flashing a frontend setting. Enable it when the inspector
812         is opened if it was previously enabled.
813
814         * UserInterface/Views/DOMTreeContentView.js:
815         (WebInspector.DOMTreeContentView):
816         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
817         (WebInspector.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
818         Have the paint flashing button always match the global setting.
819
820 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
821
822         Web Inspector: Improve appearance of alpha color swatches
823         https://bugs.webkit.org/show_bug.cgi?id=137627
824
825         Reviewed by Andreas Kling.
826
827         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
828         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
829         * Versions/Inspector-iOS-7.0.json:
830         * Versions/InspectorWeb-iOS-8.0.json:
831
832 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
833
834         Web Inspector: Improve appearance of alpha color swatches
835         https://bugs.webkit.org/show_bug.cgi?id=137627
836
837         Reviewed by Timothy Hatcher.
838
839         This improves the sizes. The color-swatch size is 1em x 1em,
840         which ends up being 11px, and thus there is still an imbalance.
841         However on both 1x and 2x displays this looks more even.
842
843         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
844         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
845
846 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
847
848         Web Inspector: assert always logs undefined instead of the desired string
849         https://bugs.webkit.org/show_bug.cgi?id=137632
850
851         Reviewed by Timothy Hatcher.
852
853         * UserInterface/Protocol/InspectorFrontendAPI.js:
854         (InspectorFrontendAPI.dispatch):
855         Fix the assert log to include the method name.
856
857 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
858
859         Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
860         https://bugs.webkit.org/show_bug.cgi?id=137624
861
862         Reviewed by Timothy Hatcher.
863
864         Be careful when stripping whitespace around "+". We want to strip for
865         selectors "a + b" but not for calc expressions "calc(1px + 2px)".
866
867         This is not a perfect solution, but it does a good job. It may still break
868         with more complex calc expressions, like "calc(1px + calc())" but this
869         handles the basics.
870
871         * Scripts/copy-user-interface-resources-dryrun.rb: Added.
872         * Scripts/cssmin.py:
873         (cssminify):
874
875 2014-10-09  Joseph Pecoraro  <pecoraro@apple.com>
876
877         Web Inspector: DOM Storage Editing is broken in many ways, frustrating
878         https://bugs.webkit.org/show_bug.cgi?id=137547
879
880         Reviewed by Timothy Hatcher.
881
882         * UserInterface/Models/DOMStorageObject.js:
883         (WebInspector.DOMStorageObject.prototype.getEntries): Deleted.
884         When getting entires, populate the model object with these keys/values
885         so we can accurately detect duplicates in editing.
886
887         * UserInterface/Views/DataGrid.js:
888         (WebInspector.DataGrid.prototype.determineNextCell):
889         (WebInspector.DataGrid.prototype.moveToNextCell):
890         When the users uses "Enter" to commit, stop editing.
891
892         (WebInspector.DataGrid.prototype._editingCommitted):
893         Fix title property accessor. This is not a map. This fixes an exception
894         when showing context menus on editable data grid rows.
895
896         * UserInterface/Views/DOMStorageContentView.js:
897         (WebInspector.DOMStorageContentView.prototype.cleanup):
898         (WebInspector.DOMStorageContentView.prototype.restoreOriginalValues):
899         (WebInspector.DOMStorageContentView.prototype._editingCallback):
900         Completely rewrite editing here. As soon as an edit is made, enter
901         an uncommitted state with the original key/value. When a commit is
902         allowed, update as appropriate based on the original values.
903
904 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
905
906         Web Inspector: CSS Pretty Printing fails to put space between value functions around ending parenthesis
907         https://bugs.webkit.org/show_bug.cgi?id=137415
908
909         Reviewed by Timothy Hatcher.
910
911         Add a space after a closing parenthesis if we are still inside a property.
912         This adds space between space separated function lists such as
913         -webkit-transform:foo(...)bar(...). Also add a test for keyframe syntax.
914
915         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
916         * Tools/PrettyPrinting/css-tests/keyframes-expected.css: Added.
917         * Tools/PrettyPrinting/css-tests/keyframes.css: Added.
918         * Tools/PrettyPrinting/index.html:
919         * UserInterface/Views/CodeMirrorFormatters.js:
920
921 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
922
923         Web Inspector: CSS Pretty Printing fails to put space between rgb(...) and numbers in minified gradients
924         https://bugs.webkit.org/show_bug.cgi?id=137414
925
926         Reviewed by Timothy Hatcher.
927
928         Add whitespace between rgb(...) and a number, possible in gradient
929         syntax like "linear-gradient(rgb(...)0%,rgb(...)100%)".
930
931         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
932         * Tools/PrettyPrinting/css-tests/gradient-expected.css: Added.
933         (.dot-nav:nth-child(1n) li a.active):
934         * Tools/PrettyPrinting/css-tests/gradient.css: Added.
935         (.dot-nav:nth-child(1n) li a.active):
936         * Tools/PrettyPrinting/index.html:
937         * UserInterface/Views/CodeMirrorFormatters.js:
938
939 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
940
941         Web Inspector: CSS Pretty Printing fails to wrap long lines of selectors with pseudo classes/elements
942         https://bugs.webkit.org/show_bug.cgi?id=137413
943
944         Reviewed by Timothy Hatcher.
945
946         Long line wrapping was breaking as soon as there was a ':' for a psuedo
947         class or element. Likewise it was counting comment strings as part of
948         the length of the line even though it would get a newline after it.
949
950         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
951         * Tools/PrettyPrinting/css-tests/basic-expected.css:
952         (progress, section, summary, time):
953         * Tools/PrettyPrinting/css-tests/wrapping-expected.css: Added.
954         (a.tryamacs, a.upgradenows):
955         (a.tryamacs:hover, a.upgradenows:hover):
956         * Tools/PrettyPrinting/css-tests/wrapping.css: Added.
957         (a.browsewebappss,a.businessstores,a.buyiphones,a.buynows,a.buynows-arrow,a.comingsoons,p::before,a.descargarahoras,a.downloadituness,a.downloadnows,a.finds,a.freetrials,a.getstarteds,a.gos,a.howtoapplys,a.howtobuys,a.joinnows,a.learnmores,a.nikebuynows,a.notifymes,a.ordernows,a.preordernows,a.preorders,a.reserves,a.startyoursearchs,a.submits,a.tryamacs,a.upgradenows):
958         (a.browsewebappss:hover,a.businessstores:hover,a.buyiphones:hover,a.buynows:hover,a.buynows-arrow:hover,a.comingsoons:hover,p::before,a.descargarahoras:hover,a.downloadituness:hover,a.downloadnows:hover,a.finds:hover,a.freetrials:hover,a.getstarteds:hover,a.gos:hover,a.howtoapplys:hover,a.howtobuys:hover,a.joinnows:hover,a.learnmores:hover,a.nikebuynows:hover,a.notifymes:hover,a.ordernows:hover,a.preordernows:hover,a.preorders:hover,a.reserves:hover,a.startyoursearchs:hover,a.submits:hover,a.tryamacs:hover,a.upgradenows:hover):
959         * Tools/PrettyPrinting/index.html:
960         * UserInterface/Views/CodeMirrorFormatters.js:
961
962 2014-10-04  Joseph Pecoraro  <pecoraro@apple.com>
963
964         Web Inspector: Add PrettyPrinter CSS tests
965         https://bugs.webkit.org/show_bug.cgi?id=134005
966
967         Reviewed by Timothy Hatcher.
968
969         Add CSS pretty printing tests. Improve pretty printing of calc()
970         expressions and media-queries with whitespace around operators
971         and keywords. Also fix the debug output in the tool for CSS.
972
973         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
974         * Tools/PrettyPrinting/FormatterContentBuilder.js:
975         (FormatterContentBuilder.prototype._appendIndent):
976         * Tools/PrettyPrinting/FormatterDebug.js:
977         (.debugToken):
978         (Formatter.prototype.debug):
979         * Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
980         * Tools/PrettyPrinting/css-tests/basic.css: Added.
981         * Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
982         * Tools/PrettyPrinting/css-tests/calc.css: Added.
983         * Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
984         * Tools/PrettyPrinting/css-tests/media-query.css: Added.
985         * Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
986         * Tools/PrettyPrinting/css-tests/selectors.css: Added.
987         * Tools/PrettyPrinting/index.html:
988         * UserInterface/Views/CodeMirrorFormatters.js:
989
990 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
991
992         Unreviewed, rolling out r174319.
993
994         Causes assertions in fast/profiler tests. Needs nontrivial
995         investigation, will take offline.
996
997         Reverted changeset:
998
999         "Web Inspector: timelines should not count time elapsed while
1000         paused in the debugger"
1001         https://bugs.webkit.org/show_bug.cgi?id=136351
1002         http://trac.webkit.org/changeset/174319
1003
1004 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
1005
1006         Web Inspector: timelines should not count time elapsed while paused in the debugger
1007         https://bugs.webkit.org/show_bug.cgi?id=136351
1008
1009         Reviewed by Timothy Hatcher.
1010
1011         Don't update the timeline's current time when the debugger is paused.
1012
1013         Start and end times for timeline records are now in seconds elapsed since timeline
1014         recording started, rather than milliseconds since the epoch. Add a workaround to
1015         preserve compatibility with old backends.
1016
1017         * UserInterface/Controllers/TimelineManager.js:
1018         (WebInspector.TimelineManager.prototype.capturingStarted):
1019         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
1020         (WebInspector.TimelineManager.prototype.eventRecorded):
1021         * UserInterface/Views/TimelineContentView.js:
1022         (WebInspector.TimelineContentView.prototype._debuggerPaused):
1023         (WebInspector.TimelineContentView.prototype._debuggerResumed):
1024
1025 2014-10-03  Saam Barati  <saambarati1@gmail.com>
1026
1027         Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
1028         https://bugs.webkit.org/show_bug.cgi?id=137295
1029
1030         Reviewed by Timothy Hatcher.
1031
1032         The inspector now computes a set of properties that was previously 
1033         computed inside JSC. 
1034
1035         This patch also addresses the weird experience of the 
1036         type of an expression claiming to be both a Number and 
1037         an Integer. This could be a bit confusing because Number 
1038         is supposed to represent Double|Integer and the previous
1039         UI implied that Number was equivalent to Double. The new UI only 
1040         ever shows either the type of Number or Integer when showing
1041         the type information of an expression. It never shows both Number
1042         and Integer simultaneously to describe a single expression.
1043
1044         * UserInterface/Models/TypeSet.js:
1045         (WebInspector.TypeSet):
1046         (WebInspector.TypeSet.prototype.isContainedIn):
1047         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
1048         * UserInterface/Views/TypePropertiesSection.js:
1049         (WebInspector.TypePropertiesSection):
1050         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1051         * UserInterface/Views/TypeTokenView.js:
1052         (WebInspector.TypeTokenView):
1053         (WebInspector.TypeTokenView.prototype.update):
1054         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1055         (WebInspector.TypeTokenView.prototype._displayTypeName):
1056
1057 2014-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1058
1059         Web Inspector: Cannot add a new CSS Rule to elements with 3 or more class names
1060         https://bugs.webkit.org/show_bug.cgi?id=137375
1061
1062         Reviewed by Timothy Hatcher.
1063
1064         Correctly merge all class names with dots instead of just the first two.
1065
1066         * UserInterface/Models/DOMNode.js:
1067
1068 2014-10-02  Mark Lam  <mark.lam@apple.com>
1069
1070         Fixed the Inspector to be able to properly distinguish between scope types.
1071         <https://webkit.org/b/137279>
1072
1073         Reviewed by Geoffrey Garen and Joseph Pecoraro.
1074
1075         * Localizations/en.lproj/localizedStrings.js:
1076         * UserInterface/Controllers/DebuggerManager.js:
1077         * UserInterface/Models/ScopeChainNode.js:
1078         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1079         - Added handling of the FunctionNameScope case.
1080
1081 2014-10-02  Andres Gomez  <agomez@igalia.com>
1082
1083         Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
1084         https://bugs.webkit.org/show_bug.cgi?id=137248
1085
1086         Reviewed by Carlos Garcia Campos.
1087
1088         Add more free icons and removed some unused ones for the Web
1089         Inspector in GTK+.
1090         Also, enhanced the visibility and/or proportion of several of the
1091         icons.
1092
1093         * UserInterface/Images/gtk/AUTHORS:
1094         * UserInterface/Images/gtk/COPYING:
1095         * UserInterface/Images/gtk/Checkers.svg: Added.
1096         * UserInterface/Images/gtk/Circle.svg: Added.
1097         * UserInterface/Images/gtk/CloseLarge.svg: Added.
1098         * UserInterface/Images/gtk/CloseTimeline.png: Removed.
1099         * UserInterface/Images/gtk/CloseTimeline@2x.png: Removed.
1100         * UserInterface/Images/gtk/Crosshair.svg:
1101         * UserInterface/Images/gtk/DOMCharacterData.svg:
1102         * UserInterface/Images/gtk/DOMComment.svg:
1103         * UserInterface/Images/gtk/DOMDocument.svg:
1104         * UserInterface/Images/gtk/DOMDocumentType.svg:
1105         * UserInterface/Images/gtk/DOMElement.svg:
1106         * UserInterface/Images/gtk/DOMNode.svg:
1107         * UserInterface/Images/gtk/DOMTextNode.svg:
1108         * UserInterface/Images/gtk/DOMTree.svg:
1109         * UserInterface/Images/gtk/EventListener.svg:
1110         * UserInterface/Images/gtk/Exception.svg:
1111         * UserInterface/Images/gtk/Function.svg:
1112         * UserInterface/Images/gtk/GradientStop.png: Added.
1113         * UserInterface/Images/gtk/GradientStop@2x.png: Added.
1114         * UserInterface/Images/gtk/GradientStopSelected.png: Added.
1115         * UserInterface/Images/gtk/GradientStopSelected@2x.png: Added.
1116         * UserInterface/Images/gtk/Issues.svg:
1117         * UserInterface/Images/gtk/IssuesEnabled.svg:
1118         * UserInterface/Images/gtk/LessColumns.svg: Removed.
1119         * UserInterface/Images/gtk/Logs.svg:
1120         * UserInterface/Images/gtk/Memory.svg: Removed.
1121         * UserInterface/Images/gtk/MoreColumns.svg: Removed.
1122         * UserInterface/Images/gtk/Native.svg:
1123         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
1124         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
1125         * UserInterface/Images/gtk/NavigationItemBug.svg:
1126         * UserInterface/Images/gtk/NavigationItemFile.svg:
1127         * UserInterface/Images/gtk/NavigationItemLayers.svg:
1128         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
1129         * UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
1130         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
1131         * UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
1132         * UserInterface/Images/gtk/PaintFlashing.svg: Added.
1133         * UserInterface/Images/gtk/PseudoElement.svg:
1134         * UserInterface/Images/gtk/Record.svg: Added.
1135         * UserInterface/Images/gtk/Recording.png: Removed.
1136         * UserInterface/Images/gtk/Recording@2x.png: Removed.
1137         * UserInterface/Images/gtk/RecordingHovered.png: Removed.
1138         * UserInterface/Images/gtk/RecordingHovered@2x.png: Removed.
1139         * UserInterface/Images/gtk/RecordingStopped.png: Removed.
1140         * UserInterface/Images/gtk/RecordingStopped@2x.png: Removed.
1141         * UserInterface/Images/gtk/Reflection.svg:
1142         * UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
1143         * UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
1144         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
1145         * UserInterface/Images/gtk/Request.svg:
1146         * UserInterface/Images/gtk/Resources.svg:
1147         * UserInterface/Images/gtk/Response.svg:
1148         * UserInterface/Images/gtk/ResultLine.svg:
1149         * UserInterface/Images/gtk/SourceCode.svg:
1150         * UserInterface/Images/gtk/Stop.svg: Added.
1151         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
1152         * UserInterface/Images/gtk/StyleRuleInherited.svg:
1153         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
1154         * UserInterface/Images/gtk/StyleRuleInspector.svg:
1155         * UserInterface/Images/gtk/StyleRuleUser.svg:
1156         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
1157         * UserInterface/Images/gtk/Time.svg:
1158         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
1159         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
1160         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
1161         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
1162         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
1163         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
1164         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
1165         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
1166         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
1167         * UserInterface/Images/gtk/Weight.svg:
1168
1169 2014-09-27  Brian J. Burg  <burg@cs.washington.edu>
1170
1171         Web Replay: Playback position updates should be sent before the next event loop input is dispatched
1172         https://bugs.webkit.org/show_bug.cgi?id=137162
1173
1174         Reviewed by Timothy Hatcher.
1175
1176         Pausing playback from the UI was broken because of a typo. Fix this, and rename
1177         stopPlayback to cancelPlayback.
1178
1179         * UserInterface/Controllers/ReplayManager.js:
1180         (WebInspector.ReplayManager.prototype.switchSession.if):
1181
1182 2014-09-26  Joseph Pecoraro  <pecoraro@apple.com>
1183
1184         Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
1185         https://bugs.webkit.org/show_bug.cgi?id=137038
1186
1187         Reviewed by Timothy Hatcher.
1188
1189         * UserInterface/Base/Main.js:
1190         Send the initialized message after we have sent all other setup messages,
1191         such as enabling features and setting breakpoints.
1192
1193 2014-09-26  Saam Barati  <saambarati1@gmail.com>
1194
1195         Web Inspector: Type Token View shows type information on hover when it shouldn't
1196         https://bugs.webkit.org/show_bug.cgi?id=137152
1197
1198         Reviewed by Brian J. Burg.
1199
1200         TypeTokenView should only show type information when there is 
1201         more than one primitive type or more than zero objects types. 
1202         This fixes a bug in checking the length of object types.
1203
1204         * UserInterface/Views/TypeTokenView.js:
1205         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1206
1207 2014-09-25  Timothy Hatcher  <timothy@apple.com>
1208
1209         Web Inspector: Show type info icon is blurry
1210         https://bugs.webkit.org/show_bug.cgi?id=137125
1211
1212         Reviewed by Darin Adler.
1213
1214         * UserInterface/Images/NavigationItemTypes.svg:
1215         * UserInterface/Views/ScriptContentView.js:
1216         (WebInspector.ScriptContentView):
1217         * UserInterface/Views/TextContentView.js:
1218         (WebInspector.TextContentView):
1219         * UserInterface/Views/TextResourceContentView.js:
1220         (WebInspector.TextResourceContentView):
1221
1222 2014-09-25  Saam Barati  <saambarati1@gmail.com>
1223
1224         Web Inspector: console.assert(bitString) TypeSet:50 
1225         https://bugs.webkit.org/show_bug.cgi?id=137051
1226
1227         Reviewed by Joseph Pecoraro.
1228
1229         This fixes TypeSet's isContainedIn method by ensuring that 
1230         the type bit string isn't zero because the test would trivially 
1231         pass if the bit string is zero.
1232
1233         * UserInterface/Models/TypeSet.js:
1234         (WebInspector.TypeSet.prototype.isContainedIn):
1235
1236 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1237
1238         Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
1239         https://bugs.webkit.org/show_bug.cgi?id=136805
1240
1241         Reviewed by Timothy Hatcher.
1242
1243         * UserInterface/Test.html: Add missing include for ScopeChainNode.js.
1244
1245 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1246
1247         Web Inspector: sort probe details sidebar sections by source code location string
1248         https://bugs.webkit.org/show_bug.cgi?id=137080
1249
1250         Reviewed by Timothy Hatcher.
1251
1252         Probe sections should display in the same order as associated breakpoint tree elements.
1253
1254         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1255         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
1256         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
1257
1258 2014-09-25  Andres Gomez  <agomez@igalia.com>
1259
1260         Unreviewed. Add more free icons for the Web Inspector in GTK+.
1261
1262         * UserInterface/Images/gtk/AUTHORS:
1263         * UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
1264         * UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Added.
1265         * UserInterface/Images/gtk/COPYING:
1266         * UserInterface/Images/gtk/COPYING_LGPL2: Added.
1267         * UserInterface/Images/gtk/Cookie.png: Added.
1268         * UserInterface/Images/gtk/Cookie@2x.png: Added.
1269         * UserInterface/Images/gtk/HoverMenuButton.png: Added.
1270         * UserInterface/Images/gtk/HoverMenuButton@2x.png: Added.
1271         * UserInterface/Images/gtk/InstructionPointer.png: Added.
1272         * UserInterface/Images/gtk/InstructionPointer@2x.png: Added.
1273         * UserInterface/Images/gtk/Log.png: Added.
1274         * UserInterface/Images/gtk/Log@2x.png: Added.
1275         * UserInterface/Images/gtk/Profile.png: Added.
1276         * UserInterface/Images/gtk/Profile@2x.png: Added.
1277         * UserInterface/Images/gtk/Recording.png: Added.
1278         * UserInterface/Images/gtk/Recording@2x.png: Added.
1279         * UserInterface/Images/gtk/RecordingHovered.png: Added.
1280         * UserInterface/Images/gtk/RecordingHovered@2x.png: Added.
1281         * UserInterface/Images/gtk/RecordingStopped.png: Added.
1282         * UserInterface/Images/gtk/RecordingStopped@2x.png: Added.
1283         * UserInterface/Images/gtk/Script.png: Added.
1284         * UserInterface/Images/gtk/Script@2x.png: Added.
1285         * UserInterface/Images/gtk/ScriptLarge.png: Added.
1286         * UserInterface/Images/gtk/ScriptLarge@2x.png: Added.
1287         * UserInterface/Images/gtk/SliderThumb.png: Added.
1288         * UserInterface/Images/gtk/SliderThumb@2x.png: Added.
1289         * UserInterface/Images/gtk/SliderThumbPressed.png: Added.
1290         * UserInterface/Images/gtk/SliderThumbPressed@2x.png: Added.
1291         * UserInterface/Images/gtk/Stopwatch.png: Added.
1292         * UserInterface/Images/gtk/Stopwatch@2x.png: Added.
1293
1294 2014-09-21  Timothy Hatcher  <timothy@apple.com>
1295
1296         Make the Web Inspector use a separate web process.
1297
1298         https://bugs.webkit.org/show_bug.cgi?id=135120
1299
1300         Reviewed by Anders Carlsson.
1301
1302         * Localizations/en.lproj/localizedStrings.js: Updated.
1303
1304         * UserInterface/Base/Main.js:
1305         (WebInspector.loaded):
1306         (WebInspector.contentLoaded):
1307         Move InspectorFrontendHost.loaded to later in the load.
1308         Calling it early just shows the window before we have
1309         a user interface to show.
1310
1311         * UserInterface/Base/Test.js:
1312         (WebInspector.loaded):
1313         (WebInspector.contentLoaded):
1314         Match the changes in Main.js.
1315
1316         * UserInterface/Protocol/InspectorFrontendAPI.js:
1317         (InspectorFrontendAPI.savedURL): Change comment.
1318         (InspectorFrontendAPI.appendedToURL): Change comment.
1319         (InspectorFrontendAPI.dispatch): Add an assert and early
1320         return to be safe from unknown commands.
1321         (InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
1322         no need to keep an empty array around a one time use.
1323
1324 2014-09-24  Andres Gomez  <agomez@igalia.com>
1325
1326         Unreviewed. Add more free icons for the Web Inspector in GTK+
1327
1328         * UserInterface/Images/gtk/AUTHORS:
1329         * UserInterface/Images/gtk/ApplicationCache.png: Added.
1330         * UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
1331         * UserInterface/Images/gtk/BottomUpTree.svg: Added.
1332         * UserInterface/Images/gtk/Breakpoint.png: Added.
1333         * UserInterface/Images/gtk/Breakpoint@2x.png: Added.
1334         * UserInterface/Images/gtk/BreakpointButton.svg:
1335         * UserInterface/Images/gtk/BreakpointInactive.png: Added.
1336         * UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
1337         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
1338         * UserInterface/Images/gtk/COPYING:
1339         * UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
1340         * UserInterface/Images/gtk/ClippingCSS.png: Added.
1341         * UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
1342         * UserInterface/Images/gtk/ClippingGeneric.png: Added.
1343         * UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
1344         * UserInterface/Images/gtk/ClippingJS.png: Added.
1345         * UserInterface/Images/gtk/ClippingJS@2x.png: Added.
1346         * UserInterface/Images/gtk/CloseTimeline.png: Added.
1347         * UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
1348         * UserInterface/Images/gtk/ColorIcon.png: Added.
1349         * UserInterface/Images/gtk/ColorIcon@2x.png: Added.
1350         * UserInterface/Images/gtk/Colors.png: Added.
1351         * UserInterface/Images/gtk/Colors@2x.png: Added.
1352         * UserInterface/Images/gtk/ColorsLarge.png: Added.
1353         * UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
1354         * UserInterface/Images/gtk/Database.png: Added.
1355         * UserInterface/Images/gtk/Database@2x.png: Added.
1356         * UserInterface/Images/gtk/DatabaseTable.png: Added.
1357         * UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
1358         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
1359         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
1360         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
1361         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
1362         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
1363         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
1364         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
1365         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
1366         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
1367         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
1368         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
1369         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
1370         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
1371         * UserInterface/Images/gtk/Issues.svg: Added.
1372         * UserInterface/Images/gtk/IssuesEnabled.svg: Added.
1373         * UserInterface/Images/gtk/LayerBorders.svg: Added.
1374         * UserInterface/Images/gtk/LessColumns.svg: Added.
1375         * UserInterface/Images/gtk/LocalStorage.png: Added.
1376         * UserInterface/Images/gtk/LocalStorage@2x.png: Added.
1377         * UserInterface/Images/gtk/Locked.svg: Added.
1378         * UserInterface/Images/gtk/Logs.svg: Added.
1379         * UserInterface/Images/gtk/Memory.svg: Added.
1380         * UserInterface/Images/gtk/MoreColumns.svg: Added.
1381         * UserInterface/Images/gtk/Native.svg: Added.
1382         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
1383         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
1384         * UserInterface/Images/gtk/NavigationItemBug.svg: Added.
1385         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
1386         * UserInterface/Images/gtk/NavigationItemFile.svg: Added.
1387         * UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
1388         * UserInterface/Images/gtk/NavigationItemLog.svg: Added.
1389         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
1390         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
1391         * UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
1392         * UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
1393         * UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
1394         * UserInterface/Images/gtk/Network.png: Added.
1395         * UserInterface/Images/gtk/Network@2x.png: Added.
1396         * UserInterface/Images/gtk/NetworkLarge.png: Added.
1397         * UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
1398         * UserInterface/Images/gtk/Pause.svg: Added.
1399         * UserInterface/Images/gtk/Percent.svg: Added.
1400         * UserInterface/Images/gtk/Plus.svg: Added.
1401         * UserInterface/Images/gtk/PseudoElement.svg: Added.
1402         * UserInterface/Images/gtk/Reflection.svg: Added.
1403         * UserInterface/Images/gtk/Reload.svg: Added.
1404         * UserInterface/Images/gtk/Request.svg: Added.
1405         * UserInterface/Images/gtk/Response.svg: Added.
1406         * UserInterface/Images/gtk/ResultLine.svg: Added.
1407         * UserInterface/Images/gtk/Resume.svg: Added.
1408         * UserInterface/Images/gtk/SessionStorage.png: Added.
1409         * UserInterface/Images/gtk/SessionStorage@2x.png: Added.
1410         * UserInterface/Images/gtk/ShadowDOM.svg: Added.
1411         * UserInterface/Images/gtk/SourceCode.svg: Added.
1412         * UserInterface/Images/gtk/SplitToggleDown.svg: Added.
1413         * UserInterface/Images/gtk/SplitToggleUp.svg: Added.
1414         * UserInterface/Images/gtk/StepInto.svg: Added.
1415         * UserInterface/Images/gtk/StepOut.svg: Added.
1416         * UserInterface/Images/gtk/StepOver.svg: Added.
1417         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
1418         * UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
1419         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
1420         * UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
1421         * UserInterface/Images/gtk/StyleRuleUser.svg: Added.
1422         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
1423         * UserInterface/Images/gtk/Time.svg: Added.
1424         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
1425         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
1426         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
1427         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
1428         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
1429         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
1430         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
1431         * UserInterface/Images/gtk/Undock.svg: Added.
1432         * UserInterface/Images/gtk/UserInputPrompt.svg: Added.
1433         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
1434         * UserInterface/Images/gtk/UserInputResult.svg: Added.
1435         * UserInterface/Images/gtk/Warning.svg: Added.
1436         * UserInterface/Images/gtk/Weight.svg: Added.
1437
1438 2014-09-23  Timothy Hatcher  <timothy@apple.com>
1439
1440         Web Inspector: Remove UserInterface/Images/gtk from Apple builds
1441         https://bugs.webkit.org/show_bug.cgi?id=136955
1442
1443         Reviewed by Joseph Pecoraro.
1444
1445         * Scripts/copy-user-interface-resources.pl:
1446         Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
1447         at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.
1448
1449 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1450
1451         Web Inspector: fix TypeSet hierarchy in TypeTokenView
1452         https://bugs.webkit.org/show_bug.cgi?id=136982
1453
1454         Reviewed by Joseph Pecoraro.
1455
1456         The protocol object representation of TypeSet was being computed 
1457         incorrectly in JSC::TypeSet. This patch fixes that problem
1458         and also asserts that the type information that the Web Inspector
1459         receives is not empty.
1460
1461         * UserInterface/Models/TypeSet.js:
1462         (WebInspector.TypeSet):
1463         * UserInterface/Views/TypeTokenView.js:
1464         (WebInspector.TypeTokenView.prototype._displayTypeName):
1465
1466 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1467
1468         Web Inspector: unlocalized 'many' string in type profiler inline bubble
1469         https://bugs.webkit.org/show_bug.cgi?id=136980
1470
1471         Reviewed by Timothy Hatcher.
1472
1473         Generate the localizable string for the type profiler's "many" inline bubble.
1474
1475         * Localizations/en.lproj/localizedStrings.js:
1476         * UserInterface/Views/TypeTokenView.js:
1477
1478 2014-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1479
1480         Web Inspector: Option+Click on CSS url(...) should jump to resource view
1481         https://bugs.webkit.org/show_bug.cgi?id=136965
1482
1483         Reviewed by Timothy Hatcher.
1484
1485         * UserInterface/Views/CodeMirrorAdditions.js:
1486         When parsing CSS url(...) tokens, the contents of url(...)
1487         are a "string" type, not "atom".
1488
1489 2014-09-19  Daniel Bates  <dabates@apple.com>
1490
1491         Always assume internal SDK when building configuration Production
1492         https://bugs.webkit.org/show_bug.cgi?id=136925
1493         <rdar://problem/18362399>
1494
1495         Reviewed by Dan Bernstein.
1496
1497         * Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig
1498         to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
1499         (e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).
1500
1501 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1502
1503         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1504         https://bugs.webkit.org/show_bug.cgi?id=136632
1505
1506         Reviewed by Gustavo Noronha Silva.
1507
1508         Add free icons for the GTK port. These icons are from the GNOME
1509         project, some of them adapted by Andres Gomez for the inspector.
1510         This is only a subset of the icons, since we still don't have a
1511         free replacement for all of them, but at least it makes the
1512         inspector kind of usable.
1513
1514         * UserInterface/Images/gtk/AUTHORS: Added.
1515         * UserInterface/Images/gtk/BackArrow.svg: Added.
1516         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
1517         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
1518         * UserInterface/Images/gtk/BreakpointButton.svg: Added.
1519         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
1520         * UserInterface/Images/gtk/Breakpoints.svg: Added.
1521         * UserInterface/Images/gtk/COPYING: Added.
1522         * UserInterface/Images/gtk/Close.svg: Added.
1523         * UserInterface/Images/gtk/CloseWhite.svg: Added.
1524         * UserInterface/Images/gtk/ContentFlow.svg: Added.
1525         * UserInterface/Images/gtk/Crosshair.svg: Added.
1526         * UserInterface/Images/gtk/DOMCharacterData.svg: Added.
1527         * UserInterface/Images/gtk/DOMComment.svg: Added.
1528         * UserInterface/Images/gtk/DOMDocument.svg: Added.
1529         * UserInterface/Images/gtk/DOMDocumentType.svg: Added.
1530         * UserInterface/Images/gtk/DOMElement.svg: Added.
1531         * UserInterface/Images/gtk/DOMNode.svg: Added.
1532         * UserInterface/Images/gtk/DOMTextNode.svg: Added.
1533         * UserInterface/Images/gtk/DOMTree.svg: Added.
1534         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
1535         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
1536         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
1537         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
1538         * UserInterface/Images/gtk/DockBottom.svg: Added.
1539         * UserInterface/Images/gtk/DockRight.svg: Added.
1540         * UserInterface/Images/gtk/DocumentCSS.png: Added.
1541         * UserInterface/Images/gtk/DocumentCSS@2x.png: Added.
1542         * UserInterface/Images/gtk/DocumentFont.png: Added.
1543         * UserInterface/Images/gtk/DocumentFont@2x.png: Added.
1544         * UserInterface/Images/gtk/DocumentGeneric.png: Added.
1545         * UserInterface/Images/gtk/DocumentGeneric@2x.png: Added.
1546         * UserInterface/Images/gtk/DocumentImage.png: Added.
1547         * UserInterface/Images/gtk/DocumentImage@2x.png: Added.
1548         * UserInterface/Images/gtk/DocumentJS.png: Added.
1549         * UserInterface/Images/gtk/DocumentJS@2x.png: Added.
1550         * UserInterface/Images/gtk/DocumentMarkup.png: Added.
1551         * UserInterface/Images/gtk/DocumentMarkup@2x.png: Added.
1552         * UserInterface/Images/gtk/DownloadArrow.svg: Added.
1553         * UserInterface/Images/gtk/Error.svg: Added.
1554         * UserInterface/Images/gtk/Errors.svg: Added.
1555         * UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
1556         * UserInterface/Images/gtk/EventListener.svg: Added.
1557         * UserInterface/Images/gtk/Exception.svg: Added.
1558         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
1559         * UserInterface/Images/gtk/FolderGeneric.png: Added.
1560         * UserInterface/Images/gtk/FolderGeneric@2x.png: Added.
1561         * UserInterface/Images/gtk/ForwardArrow.svg: Added.
1562         * UserInterface/Images/gtk/Function.svg: Added.
1563         * UserInterface/Images/gtk/GoToArrow.svg: Added.
1564         * UserInterface/Images/gtk/Resources.svg: Added.
1565         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
1566         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
1567         * UserInterface/Images/gtk/UpDownArrows.svg: Added.
1568
1569 2014-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1570
1571         Web Inspector: Remove unnecessary prefixes in WebInspectorUI CSS
1572         https://bugs.webkit.org/show_bug.cgi?id=136905
1573
1574         Reviewed by Timothy Hatcher.
1575
1576         Removed vendor prefixes from justify-content and a few lingering
1577         occurances with transition, box-shadow, and display.
1578
1579         * UserInterface/Views/BreakpointActionView.css:
1580         * UserInterface/Views/BreakpointTreeElement.css:
1581         * UserInterface/Views/ButtonNavigationItem.css:
1582         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1583         * UserInterface/Views/ControlToolbarItem.css:
1584         * UserInterface/Views/DebuggerDashboardView.css:
1585         * UserInterface/Views/DefaultDashboardView.css:
1586         * UserInterface/Views/FontResourceContentView.css:
1587         * UserInterface/Views/ImageResourceContentView.css:
1588         * UserInterface/Views/LayerTreeSidebarPanel.css:
1589         * UserInterface/Views/Main.css:
1590         * UserInterface/Views/NavigationBar.css:
1591         * UserInterface/Views/NavigationSidebarPanel.css:
1592         * UserInterface/Views/Popover.css:
1593         * UserInterface/Views/ReplayDashboardView.css:
1594         * UserInterface/Views/Toolbar.css:
1595
1596 2014-09-17  Dean Jackson  <dino@apple.com>
1597
1598         WebInpector can use unprefixed flexbox
1599         https://bugs.webkit.org/show_bug.cgi?id=136899
1600
1601         Reviewed by Joseph Pecoraro.
1602
1603         Now the inspector UI itself can use a non-prefixed flexbox. This was
1604         a basic search and replace for the following properties:
1605         - align-content
1606         - align-items
1607         - align-self
1608         - flex-basis
1609         - flex-direction
1610         - flex-wrap
1611         - flex-grow
1612         - flex-shrink
1613         - flex
1614         - flex-flow
1615         - justify
1616
1617         * UserInterface/Views/ButtonToolbarItem.css:
1618         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1619         * UserInterface/Views/ContentBrowser.css:
1620         * UserInterface/Views/ControlToolbarItem.css:
1621         * UserInterface/Views/DebuggerDashboardView.css:
1622         * UserInterface/Views/DefaultDashboardView.css:
1623         * UserInterface/Views/FilterBar.css:
1624         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
1625         * UserInterface/Views/FontResourceContentView.css:
1626         * UserInterface/Views/HierarchicalPathComponent.css:
1627         * UserInterface/Views/ImageResourceContentView.css:
1628         * UserInterface/Views/LayerTreeSidebarPanel.css:
1629         * UserInterface/Views/LogContentView.css:
1630         * UserInterface/Views/Main.css:
1631         * UserInterface/Views/NavigationBar.css:
1632         * UserInterface/Views/NavigationSidebarPanel.css:
1633         * UserInterface/Views/Popover.css:
1634         * UserInterface/Views/QuickConsole.css:
1635         * UserInterface/Views/ReplayDashboardView.css:
1636         * UserInterface/Views/ResourceSidebarPanel.css:
1637         * UserInterface/Views/Toolbar.css:
1638
1639 2014-09-16  Dean Jackson  <dino@apple.com>
1640
1641         Add unprefixed flexbox display values and property names/values
1642         https://bugs.webkit.org/show_bug.cgi?id=136880
1643         <rdar://problem/18361137>
1644
1645         Reviewed by Benjamin Poulain with some extra comments by Joseph Pecoraro.
1646
1647         * UserInterface/Models/CSSKeywordCompletions.js: Switch to all the unprefixed
1648         flex properties.
1649
1650 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1651
1652         Web Inspector: Add Versioned Inspector protocol JSON files for iOS 8.0
1653         https://bugs.webkit.org/show_bug.cgi?id=136873
1654
1655         Reviewed by Timothy Hatcher.
1656
1657         * Scripts/update-LegacyInspectorBackendCommands.rb:
1658         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Added.
1659         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js: Added.
1660         * Versions/InspectorJS-iOS-8.0.json: Added.
1661         * Versions/InspectorWeb-iOS-8.0.json: Added.
1662
1663 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1664
1665         Web Inspector: Fix ESLint no-extra-bind warnings
1666         https://bugs.webkit.org/show_bug.cgi?id=136659
1667
1668         Reviewed by Timothy Hatcher.
1669
1670         * .eslintrc:
1671         * UserInterface/Controllers/LayerTreeManager.js:
1672         (WebInspector.LayerTreeManager.prototype.layersForNode):
1673
1674 2014-09-15  Matt Baker  <mattbaker@apple.com>
1675
1676         Web Inspector: mouse drifts away from resizer when resizing docked inspector
1677         https://bugs.webkit.org/show_bug.cgi?id=22263
1678
1679         Reviewed by Joseph Pecoraro.
1680
1681         Modified the docked resizer dragging logic to record the initial mouse down position relative to the
1682         resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
1683         correctly with respect to the resize direction before updating the attached window dimension.
1684
1685         * UserInterface/Base/Main.js:
1686         (WebInspector._dockedResizerMouseDown.dockedResizerDrag):
1687
1688 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1689
1690         Web Inspector: Fix assert in QuickConsole - main frame execution context path component
1691         https://bugs.webkit.org/show_bug.cgi?id=136748
1692
1693         Reviewed by Timothy Hatcher.
1694
1695         This can get called for the MainFrame on page navigations.
1696         In such cases we can return a better result from this method.
1697
1698         * UserInterface/Views/QuickConsole.js:
1699         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1700
1701 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1702
1703         Web Inspector: Hide DOM search result highlights when find banner is not showing
1704         https://bugs.webkit.org/show_bug.cgi?id=136749
1705
1706         Reviewed by Timothy Hatcher.
1707
1708         Match search highlights in TextEditor by only showing the highlight
1709         when the find banner is showing.
1710
1711         * UserInterface/Views/DOMTreeOutline.css:
1712         (.showing-find-banner .dom-tree-outline .search-result):
1713         (.dom-tree-outline .search-highlight): Deleted.
1714
1715 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1716
1717         Web Inspector: DOM Tree search highlights are not appearing
1718         https://bugs.webkit.org/show_bug.cgi?id=136662
1719
1720         Reviewed by Timothy Hatcher.
1721
1722         When performing a search within the DOMTreeContentView all
1723         search results should immediately highlight. When moving
1724         between search results, emphasize the current with a bouncy.
1725         Remember to remove the highlights when the search is changed
1726         or cleared.
1727
1728         * UserInterface/Views/DOMTreeContentView.js:
1729         (WebInspector.DOMTreeContentView.prototype.performSearch.searchResultsReady):
1730         (WebInspector.DOMTreeContentView.prototype.searchCleared):
1731         Shor or hide highlights when searches change.
1732
1733         (WebInspector.DOMTreeContentView.prototype.revealResult):
1734         (WebInspector.DOMTreeContentView.prototype._revealSearchResult):
1735         Emphasize the highlight when moving to a new current result.
1736
1737         (WebInspector.DOMTreeContentView.prototype._showSearchHighlights):
1738         (WebInspector.DOMTreeContentView.prototype._hideSearchHighlights):
1739         On each affected DOMTreeElement show or hide search highlights.
1740
1741         * UserInterface/Views/DOMTreeElement.js:
1742         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1743         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1744         Give a brief bouncy-highlight when told to emphasize the search highlight.
1745
1746         (WebInspector.DOMTreeElement.prototype.updateTitle):
1747         Remove unused and unnecessary style class on each row.
1748
1749         (WebInspector.DOMTreeElement.prototype._highlightSearchResults):
1750         Update the stale code to use new function names and accessors.
1751
1752         * UserInterface/Views/DOMTreeOutline.css:
1753         (.dom-tree-outline .search-highlight):
1754         Styles for the search highlight match search highlights in the sidebar.
1755
1756         * UserInterface/Views/Main.css:
1757         (.bouncy-highlight):
1758         * UserInterface/Views/TextEditor.css:
1759         Move bouncy-highlight to Main.css.
1760
1761 2014-09-10  Saam Barati  <saambarati1@gmail.com>
1762
1763         Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
1764         https://bugs.webkit.org/show_bug.cgi?id=136500
1765
1766         Reviewed by Joseph Pecoraro.
1767
1768         This patch maintains the same UI in the Web Inspector for displaying
1769         type information, but now accounts for the new protocol for type profiling.
1770         
1771         The Inspector now has a TypeSet class that wraps the TypeDescription 
1772         protocol object and creates a simple interface for asking protocol objects 
1773         about their type.
1774
1775         * UserInterface/Controllers/TypeTokenAnnotator.js:
1776         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
1777         * UserInterface/Main.html:
1778         * UserInterface/Models/TypeSet.js: Added.
1779         (WebInspector.TypeSet):
1780         (WebInspector.TypeSet.fromPayload):
1781         (WebInspector.TypeSet.prototype.isContainedIn):
1782         * UserInterface/Views/SourceCodeTextEditor.js:
1783         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1784         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1785         * UserInterface/Views/TypePropertiesSection.js:
1786         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1787         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
1788         * UserInterface/Views/TypeTokenView.js:
1789         (WebInspector.TypeTokenView.prototype.update):
1790         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1791         (WebInspector.TypeTokenView.prototype._displayTypeName):
1792
1793 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1794
1795         Web Inspector: Eliminate typeof "undefined" checks
1796         https://bugs.webkit.org/show_bug.cgi?id=136691
1797
1798         Reviewed by Alexey Proskuryakov.
1799
1800         * UserInterface/Base/Main.js:
1801         (WebInspector.linkifyURLAsNode):
1802         (WebInspector.linkifyStringAsFragment):
1803         * UserInterface/Protocol/InspectorBackend.js:
1804         (InspectorBackend.Command.prototype._invokeWithArguments):
1805         * UserInterface/Views/DataGrid.js:
1806         (WebInspector.DataGrid.prototype.get resizeMethod):
1807         * UserInterface/Views/NavigationBar.js:
1808         (WebInspector.NavigationBar.prototype.get minimumWidth):
1809
1810 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1811
1812         Web Inspector: Fix obscure ESLint warnings and skip directories
1813         https://bugs.webkit.org/show_bug.cgi?id=136686
1814
1815         Reviewed by Timothy Hatcher.
1816
1817         * .eslintignore: Added.
1818         Skip directories we do not want ESLint to process.
1819
1820         * .eslintrc:
1821         Add rules we've seen and sort sections.
1822
1823         * UserInterface/Controllers/FormatterContentBuilder.js:
1824         (FormatterContentBuilder.prototype._appendIndent):
1825         * UserInterface/Models/Color.js:
1826         * UserInterface/Models/DOMNodeStyles.js:
1827         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1828         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1829         * UserInterface/Views/DOMTreeDataGridNode.js:
1830         * UserInterface/Views/DOMTreeElement.js:
1831         (WebInspector.DOMTreeElement.prototype.ondelete):
1832         (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
1833         (WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
1834         * UserInterface/Views/EditingSupport.js:
1835         (WebInspector.EditingConfig):
1836         * UserInterface/Views/LayerTreeDataGridNode.js:
1837         (WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
1838         * UserInterface/Views/TreeOutline.js:
1839         (TreeOutline.prototype.appendChild):
1840         (TreeOutline.prototype.insertChild):
1841         (TreeOutline.prototype.removeChildAtIndex):
1842         (TreeOutline.prototype.removeChild):
1843         (TreeElement.prototype.expandRecursively):
1844         Fix linter issues.
1845
1846 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1847
1848         Web Inspector: Fix ESLint consistent-return warnings
1849         https://bugs.webkit.org/show_bug.cgi?id=136682
1850
1851         Reviewed by Timothy Hatcher.
1852
1853         * .eslintrc:
1854         * UserInterface/Controllers/BranchManager.js:
1855         (WebInspector.BranchManager.prototype.createBranch):
1856         * UserInterface/Controllers/FrameResourceManager.js:
1857         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
1858         * UserInterface/Models/DOMNodeStyles.js:
1859         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1860         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1861         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
1862         * UserInterface/Views/DOMTreeElement.js:
1863         (WebInspector.DOMTreeElement.prototype.showChild):
1864         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
1865         (WebInspector.DOMTreeElement.prototype._startEditing):
1866         * UserInterface/Views/EditingSupport.js:
1867         * UserInterface/Views/EventListenerSectionGroup.js:
1868         (WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
1869         * UserInterface/Views/FrameContentView.js:
1870         (WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
1871         * UserInterface/Views/NavigationBar.js:
1872         (WebInspector.NavigationBar.prototype.insertNavigationItem):
1873         (WebInspector.NavigationBar.prototype.removeNavigationItem):
1874         * UserInterface/Views/QuickConsole.js:
1875         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1876         * UserInterface/Views/Sidebar.js:
1877         (WebInspector.Sidebar.prototype.addSidebarPanel):
1878         (WebInspector.Sidebar.prototype.removeSidebarPanel):
1879         * UserInterface/Views/TextEditor.js:
1880         (WebInspector.TextEditor.prototype.addStyleClassToLine):
1881         (WebInspector.TextEditor.prototype.removeStyleClassFromLine):
1882         (WebInspector.TextEditor.prototype.toggleStyleClassForLine):
1883
1884 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1885
1886         Web Inspector: Fix ESLint no-undef warnings
1887         https://bugs.webkit.org/show_bug.cgi?id=136660
1888
1889         Reviewed by Timothy Hatcher.
1890
1891         * UserInterface/Models/DOMSearchMatchObject.js:
1892         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
1893         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1894         * UserInterface/Models/Gradient.js:
1895         (WebInspector.Gradient.fromString):
1896         * UserInterface/Views/CodeMirrorAdditions.js:
1897         * UserInterface/Views/ReplayDashboardView.js:
1898         (WebInspector.ReplayDashboardView):
1899
1900 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1901
1902         Web Inspector: Remove unused Console search highlight methods
1903         https://bugs.webkit.org/show_bug.cgi?id=136661
1904
1905         Reviewed by Timothy Hatcher.
1906
1907         ESLint's no-undef warning complained about some undefined references
1908         in these functions that would have thrown exceptions. Turns out this
1909         code is unused, and we do highlighting in the console separately.
1910
1911         * UserInterface/Views/ConsoleCommand.js:
1912         (WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
1913         (WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
1914         (WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
1915         * UserInterface/Views/ConsoleMessageImpl.js:
1916         (WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
1917         (WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
1918         (WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
1919
1920 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1921
1922         Web Inspector: Fix ESLint* no-avoidable-bind warnings
1923         https://bugs.webkit.org/show_bug.cgi?id=136690
1924
1925         Reviewed by Timothy Hatcher.
1926
1927         * UserInterface/Protocol/RemoteObject.js:
1928         (WebInspector.LocalJSONObject.prototype._children):
1929         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1930         (WebInspector.CSSStyleDetailsSidebarPanel):
1931         * UserInterface/Views/LayerTreeSidebarPanel.js:
1932         (WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
1933         * UserInterface/Views/LogContentView.js:
1934         (WebInspector.LogContentView.prototype._filterMessages):
1935         * UserInterface/Views/TextResourceContentView.js:
1936         (WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
1937
1938 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
1939
1940         Disable the "unreachable-code" warning
1941         https://bugs.webkit.org/show_bug.cgi?id=136677
1942
1943         Reviewed by Darin Adler.
1944
1945         * Configurations/Base.xcconfig:
1946
1947 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1948
1949         Web Inspector: Fix ESLint no-trailing-spaces warnings
1950         https://bugs.webkit.org/show_bug.cgi?id=136657
1951
1952         Reviewed by Andy Estes.
1953
1954         * .eslintrc:
1955         * UserInterface/Base/DOMUtilities.js:
1956         * UserInterface/Base/URLUtilities.js:
1957         (relativePath):
1958         * UserInterface/Base/Utilities.js:
1959         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
1960         (WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
1961         * UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
1962         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
1963         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
1964         * UserInterface/Controllers/CodeMirrorEditingController.js:
1965         (WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
1966         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
1967         (WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
1968         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1969         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1970         * UserInterface/Controllers/DragToAdjustController.js:
1971         (WebInspector.DragToAdjustController.prototype.set active):
1972         (WebInspector.DragToAdjustController.prototype._setDragging):
1973         (WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
1974         * UserInterface/External/Esprima/esprima.js:
1975         * UserInterface/Models/ApplicationCacheFrame.js:
1976         (WebInspector.ApplicationCacheFrame):
1977         * UserInterface/Models/ApplicationCacheManifest.js:
1978         (WebInspector.ApplicationCacheManifest):
1979         (WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
1980         * UserInterface/Models/CookieStorageObject.js:
1981         * UserInterface/Models/DOMSearchMatchObject.js:
1982         (WebInspector.DOMSearchMatchObject.prototype.get title):
1983         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1984         * UserInterface/Models/DatabaseObject.js:
1985         (WebInspector.DatabaseObject.prototype.getTableNames):
1986         * UserInterface/Models/DatabaseTableObject.js:
1987         (WebInspector.DatabaseTableObject):
1988         * UserInterface/Models/Gradient.js:
1989         (WebInspector.Gradient.fromString):
1990         (WebInspector.RadialGradient.prototype.toString):
1991         * UserInterface/Models/IssueMessage.js:
1992         (WebInspector.IssueMessage.prototype._formatTextIfNecessary):
1993         * UserInterface/Models/Resource.js:
1994         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
1995         (WebInspector.Resource.prototype.getImageSize):
1996         * UserInterface/Models/Script.js:
1997         (WebInspector.Script.prototype._makeSyntaxTree):
1998         * UserInterface/Models/SourceCodeLocation.js:
1999         (WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
2000         * UserInterface/Models/TextMarker.js:
2001         * UserInterface/Protocol/PageObserver.js:
2002         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
2003         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
2004         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
2005         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
2006         * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
2007         (WebInspector.ApplicationCacheFrameTreeElement):
2008         * UserInterface/Views/ApplicationCacheManifestTreeElement.js:
2009         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
2010         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
2011         * UserInterface/Views/ButtonNavigationItem.js:
2012         (WebInspector.ButtonNavigationItem):
2013         * UserInterface/Views/ColorPicker.js:
2014         * UserInterface/Views/ColorWheel.js:
2015         (WebInspector.ColorWheel.prototype._draw):
2016         * UserInterface/Views/CompletionSuggestionsView.js:
2017         (WebInspector.CompletionSuggestionsView.prototype.show):
2018         * UserInterface/Views/ConsoleCommand.js:
2019         * UserInterface/Views/ConsolePrompt.js:
2020         * UserInterface/Views/ContentFlowTreeElement.js:
2021         * UserInterface/Views/CookieStorageTreeElement.js:
2022         (WebInspector.CookieStorageTreeElement):
2023         * UserInterface/Views/EventListenerSectionGroup.js:
2024         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
2025         * UserInterface/Views/GeneralTreeElementPathComponent.js:
2026         * UserInterface/Views/GoToLineDialog.js:
2027         (WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
2028         * UserInterface/Views/LayerTreeDataGridNode.js:
2029         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
2030         * UserInterface/Views/LayerTreeSidebarPanel.js:
2031         * UserInterface/Views/LogContentView.js:
2032         (WebInspector.LogContentView.prototype._highlightRanges):
2033         * UserInterface/Views/NavigationBar.js:
2034         (WebInspector.NavigationBar):
2035         * UserInterface/Views/NavigationItem.js:
2036         (WebInspector.NavigationItem):
2037         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
2038         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
2039         * UserInterface/Views/ScopeBar.js:
2040         * UserInterface/Views/ScopeBarItem.js:
2041         (WebInspector.ScopeBarItem):
2042         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
2043         (WebInspector.ScopeChainDetailsSidebarPanel):
2044         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2045         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2046         * UserInterface/Views/ScriptTreeElement.js:
2047         (WebInspector.ScriptTreeElement):
2048         * UserInterface/Views/SearchBar.js:
2049         * UserInterface/Views/SearchResultTreeElement.js:
2050         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2051         * UserInterface/Views/Slider.js:
2052
2053 2014-09-09  Joseph Pecoraro  <pecoraro@apple.com>
2054
2055         Web Inspector: Fix ESLint eqeqeq warnings
2056         https://bugs.webkit.org/show_bug.cgi?id=136658
2057
2058         Reviewed by Andy Estes.
2059
2060         * UserInterface/Controllers/DOMTreeManager.js:
2061         (WebInspector.DOMTreeManager.prototype.mycallback):
2062         (WebInspector.DOMTreeManager.prototype.searchResult):
2063         * UserInterface/Models/Breakpoint.js:
2064         (WebInspector.Breakpoint.prototype.clearActions):
2065         * UserInterface/Models/DOMTree.js:
2066         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
2067         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
2068         (WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
2069         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2070         * UserInterface/Models/ProbeSet.js:
2071         (WebInspector.ProbeSet.prototype.removeProbe):
2072         * UserInterface/Models/ProbeSetDataTable.js:
2073         (WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
2074         * UserInterface/Views/CodeMirrorAdditions.js:
2075         * UserInterface/Views/CookieStorageContentView.js:
2076         (WebInspector.CookieStorageContentView.prototype._filterCookies):
2077         (WebInspector.cookieMatchesResourceURL):
2078         * UserInterface/Views/DOMStorageContentView.js:
2079         (WebInspector.DOMStorageContentView.prototype._editingCallback):
2080         * UserInterface/Views/DOMTreeElement.js:
2081         (WebInspector.DOMTreeElement):
2082         (WebInspector.DOMTreeElement.prototype._updateChildren):
2083         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
2084         (WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
2085         * UserInterface/Views/DataGrid.js:
2086         (WebInspector.DataGrid.prototype._resizerDragging):
2087         * UserInterface/Views/DatabaseContentView.js:
2088         (WebInspector.DatabaseContentView.prototype._queryError):
2089         * UserInterface/Views/DetailsSectionSimpleRow.js:
2090         (.valueElementClicked):
2091         (WebInspector.DetailsSectionSimpleRow):
2092         * UserInterface/Views/Slider.js:
2093         (WebInspector.Slider.prototype.get _maxX):
2094         * UserInterface/Views/TreeOutline.js:
2095         (TreeElement.prototype.expand):
2096
2097 2014-09-09  Jono Wells  <jonowells@apple.com>
2098
2099         Web Inspector: Fix ESLint no-extra-semi
2100         https://bugs.webkit.org/show_bug.cgi?id=136666
2101
2102         Reviewed by Andy Estes.
2103
2104         Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
2105         semicolons as identified by ESLint.
2106
2107         * .eslintrc:
2108         * Tools/PrettyPrinting/Formatter.js:
2109         (Formatter):
2110         * UserInterface/Controllers/Formatter.js:
2111         (Formatter):
2112         * UserInterface/Models/Resource.js:
2113         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
2114         (WebInspector.Resource.prototype.getImageSize):
2115         * UserInterface/Views/LayerTreeSidebarPanel.js:
2116         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
2117         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
2118         * UserInterface/Views/ObjectPropertiesSection.js:
2119         (WebInspector.ObjectPropertyTreeElement.prototype.callback):
2120         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
2121
2122 2014-09-09  Jono Wells  <jonowells@apple.com>
2123
2124         Web Inspector: Fix ESLint semi (missing semicolon)
2125         https://bugs.webkit.org/show_bug.cgi?id=136665
2126
2127         Reviewed by Andy Estes.
2128
2129         Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
2130
2131         * .eslintrc:
2132         * Tools/PrettyPrinting/FormatterContentBuilder.js:
2133         * Tools/PrettyPrinting/FormatterDebug.js:
2134         (Formatter.prototype.debug):
2135         * UserInterface/Base/DOMUtilities.js:
2136         * UserInterface/Base/EventListener.js:
2137         (WebInspector.EventListener):
2138         (WebInspector.EventListener.prototype.this._callback):
2139         (WebInspector.EventListener.prototype.connect):
2140         * UserInterface/Base/Object.js:
2141         (WebInspector.Object):
2142         (WebInspector.Object.addConstructorFunctions):
2143         (WebInspector.Event):
2144         * UserInterface/Base/URLUtilities.js:
2145         (WebInspector.displayNameForURL):
2146         (WebInspector.displayNameForHost):
2147         * UserInterface/Base/Utilities.js:
2148         (.):
2149         * UserInterface/Controllers/BranchManager.js:
2150         (WebInspector.BranchManager):
2151         * UserInterface/Controllers/CSSStyleManager.js:
2152         (WebInspector.CSSStyleManager):
2153         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
2154         (WebInspector.CodeMirrorColorEditingController):
2155         * UserInterface/Controllers/CodeMirrorEditingController.js:
2156         (WebInspector.CodeMirrorEditingController):
2157         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
2158         (WebInspector.CodeMirrorGradientEditingController):
2159         (WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
2160         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2161         * UserInterface/Controllers/FormatterContentBuilder.js:
2162         * UserInterface/Controllers/FormatterSourceMap.js:
2163         (WebInspector.FormatterSourceMap.fromBuilder):
2164         * UserInterface/Controllers/IssueManager.js:
2165         (WebInspector.IssueManager):
2166         * UserInterface/Controllers/LogManager.js:
2167         (WebInspector.LogManager):
2168         * UserInterface/Models/BreakpointAction.js:
2169         * UserInterface/Models/CSSCompletions.js:
2170         (WebInspector.CSSCompletions):
2171         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2172         * UserInterface/Models/CSSKeywordCompletions.js:
2173         (WebInspector.CSSKeywordCompletions.forProperty):
2174         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2175         * UserInterface/Models/CSSStyleSheet.js:
2176         (WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
2177         * UserInterface/Models/Color.js:
2178         (WebInspector.Color):
2179         (WebInspector.Color.fromString):
2180         * UserInterface/Models/DOMNode.js:
2181         (WebInspector.DOMNode):
2182         * UserInterface/Models/DOMSearchMatchObject.js:
2183         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
2184         * UserInterface/Models/ExecutionContext.js:
2185         (WebInspector.ExecutionContext.supported):
2186         * UserInterface/Models/Gradient.js:
2187         (WebInspector.LinearGradient):
2188         (WebInspector.LinearGradient.linearGradientWithComponents):
2189         (WebInspector.RadialGradient):
2190         (WebInspector.RadialGradient.radialGradientWithComponents):
2191         * UserInterface/Models/IssueMessage.js:
2192         (WebInspector.IssueMessage):
2193         * UserInterface/Models/ReplaySessionSegment.js:
2194         (WebInspector.IncompleteSessionSegment):
2195         * UserInterface/Models/Resource.js:
2196         (WebInspector.Resource.prototype.associateWithScript):
2197         * UserInterface/Models/Script.js:
2198         (WebInspector.Script.resetUniqueDisplayNameNumbers):
2199         * UserInterface/Models/Setting.js:
2200         (WebInspector.Setting):
2201         * UserInterface/Models/SourceCodePosition.js:
2202         (WebInspector.SourceCodePosition):
2203         * UserInterface/Models/SourceMap.js:
2204         (WebInspector.SourceMap):
2205         (WebInspector.SourceMap.StringCharIterator):
2206         * UserInterface/Models/TextMarker.js:
2207         (WebInspector.TextMarker):
2208         * UserInterface/Models/TextRange.js:
2209         (WebInspector.TextRange):
2210         * UserInterface/Protocol/InspectorFrontendHostStub.js:
2211         (.WebInspector.InspectorFrontendHostStub):
2212         * UserInterface/Protocol/MessageDispatcher.js:
2213         (WebInspector.dispatchNextQueuedMessageFromBackend):
2214         (WebInspector.dispatchMessageFromBackend):
2215         * UserInterface/Protocol/RemoteObject.js:
2216         (WebInspector.RemoteObject):
2217         (WebInspector.RemoteObject.fromPrimitiveValue):
2218         (WebInspector.RemoteObject.fromLocalObject):
2219         (WebInspector.RemoteObject.resolveNode):
2220         (WebInspector.RemoteObject.fromPayload):
2221         (WebInspector.RemoteObject.type):
2222         (WebInspector.RemoteObjectProperty):
2223         (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
2224         (WebInspector.LocalJSONObject):
2225         * UserInterface/Protocol/ReplayObserver.js:
2226         (WebInspector.ReplayPosition.fromProtocol):
2227         * UserInterface/Views/BreakpointActionView.js:
2228         (WebInspector.BreakpointActionView.displayStringForType):
2229         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2230         (WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
2231         * UserInterface/Views/ClusterContentView.js:
2232         (WebInspector.ClusterContentView.prototype.goBack):
2233         (WebInspector.ClusterContentView.prototype.goForward):
2234         * UserInterface/Views/CodeMirrorAdditions.js:
2235         * UserInterface/Views/ColorWheel.js:
2236         (WebInspector.ColorWheel):
2237         * UserInterface/Views/ConsoleMessage.js:
2238         (WebInspector.ConsoleMessage):
2239         (WebInspector.ConsoleMessage.create):
2240         * UserInterface/Views/ConsoleMessageImpl.js:
2241         (WebInspector.ConsoleMessageImpl):
2242         * UserInterface/Views/ContextMenu.js:
2243         (WebInspector.ContextMenuItem):
2244         (WebInspector.ContextSubMenuItem):
2245         (WebInspector.ContextMenu):
2246         (WebInspector.ContextMenu.Provider):
2247         (WebInspector.ContextMenu.registerProvider):
2248         (WebInspector.contextMenuItemSelected):
2249         (WebInspector.contextMenuCleared):
2250         * UserInterface/Views/DOMTreeElement.js:
2251         (WebInspector.DOMTreeElement):
2252         * UserInterface/Views/DOMTreeOutline.js:
2253         (WebInspector.DOMTreeOutline):
2254         * UserInterface/Views/DOMTreeUpdater.js:
2255         (WebInspector.DOMTreeUpdater):
2256         * UserInterface/Views/DatabaseContentView.js:
2257         (WebInspector.DatabaseContentView):
2258         * UserInterface/Views/EditingSupport.js:
2259         (WebInspector.isBeingEdited):
2260         (WebInspector.markBeingEdited):
2261         (WebInspector.isEditingAnyField):
2262         (WebInspector.isEventTargetAnEditableField):
2263         (WebInspector.EditingConfig):
2264         (WebInspector.startEditing):
2265         * UserInterface/Views/EventListenerSection.js:
2266         (WebInspector.EventListenerSection):
2267         * UserInterface/Views/EventListenerSectionGroup.js:
2268         (WebInspector.EventListenerSectionGroup):
2269         * UserInterface/Views/FindBanner.js:
2270         * UserInterface/Views/GeneralTreeElement.js:
2271         (WebInspector.GeneralTreeElement):
2272         * UserInterface/Views/GoToLineDialog.js:
2273         (WebInspector.GoToLineDialog):
2274         * UserInterface/Views/IndeterminateProgressSpinner.js:
2275         (WebInspector.IndeterminateProgressSpinner):
2276         * UserInterface/Views/LayoutTimelineDataGrid.js:
2277         (WebInspector.LayoutTimelineDataGrid):
2278         * UserInterface/Views/LogContentView.js:
2279         (WebInspector.LogContentView):
2280         * UserInterface/Views/NavigationItem.js:
2281         * UserInterface/Views/ObjectPropertiesSection.js:
2282         (WebInspector.ObjectPropertiesSection):
2283         (WebInspector.ObjectPropertiesSection.CompareProperties):
2284         (WebInspector.ObjectPropertyTreeElement):
2285         * UserInterface/Views/ProbeSetDetailsSection.js:
2286         * UserInterface/Views/PropertiesSection.js:
2287         (WebInspector.PropertiesSection):
2288         * UserInterface/Views/ResourceTreeElement.js:
2289         (WebInspector.ResourceTreeElement.compareResourceTreeElements):
2290         (WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
2291         * UserInterface/Views/ScriptTimelineDataGrid.js:
2292         (WebInspector.ScriptTimelineDataGrid):
2293         * UserInterface/Views/SearchResultTreeElement.js:
2294         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2295         * UserInterface/Views/TimelineRuler.js:
2296         (WebInspector.TimelineRuler):
2297         (WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
2298         (WebInspector.TimelineRuler.prototype._handleMouseUp):
2299         * UserInterface/Views/Toolbar.js:
2300         * UserInterface/Views/TreeOutline.js:
2301         (TreeOutline.prototype.appendChild):
2302         (TreeOutline.prototype.insertChild):
2303         (TreeOutline.prototype.removeChildAtIndex):
2304         (TreeOutline.prototype.removeChild):
2305         (TreeOutline.prototype.removeChildren):
2306         (TreeOutline.prototype.removeChildrenRecursive):
2307         (TreeOutline.prototype._rememberTreeElement):
2308         (TreeOutline.prototype._forgetTreeElement):
2309         (TreeOutline.prototype._forgetChildrenRecursive):
2310         (TreeOutline.prototype.getCachedTreeElement):
2311         (TreeOutline.prototype.findTreeElement):
2312         (TreeOutline.prototype._treeElementDidChange):
2313         (TreeOutline.prototype.treeElementFromPoint):
2314         (TreeOutline.prototype._treeKeyDown):
2315         (TreeOutline.prototype.expand):
2316         (TreeOutline.prototype.collapse):
2317         (TreeOutline.prototype.revealed):
2318         (TreeOutline.prototype.reveal):
2319         (TreeOutline.prototype.select):
2320         (TreeOutline.prototype.revealAndSelect):
2321         (TreeElement.prototype._attach):
2322         (TreeElement.prototype._detach):
2323         (TreeElement.treeElementMouseDown):
2324         (TreeElement.treeElementToggled):
2325         (TreeElement.treeElementDoubleClicked):
2326         (TreeElement.prototype.collapse):
2327         (TreeElement.prototype.collapseRecursively):
2328         (TreeElement.prototype.expand):
2329         (TreeElement.prototype.expandRecursively):
2330         (TreeElement.prototype.hasAncestor):
2331         (TreeElement.prototype.reveal):
2332         (TreeElement.prototype.revealed):
2333         (TreeElement.prototype.selectOnMouseDown):
2334         (TreeElement.prototype.select):
2335         (TreeElement.prototype.revealAndSelect):
2336         (TreeElement.prototype.deselect):
2337         (TreeElement.prototype.onpopulate):
2338         (TreeElement.prototype.traverseNextTreeElement):
2339         (TreeElement.prototype.traversePreviousTreeElement):
2340         (TreeElement.prototype.isEventWithinDisclosureTriangle):
2341         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
2342         (WebInspector.TreeOutlineDataGridSynchronizer):
2343
2344 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2345
2346         Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
2347         https://bugs.webkit.org/show_bug.cgi?id=135965
2348
2349         Reviewed by Timothy Hatcher.
2350
2351         There were numerous subtle race conditions in state restoration.
2352         This patch intends to fix a number of them to get what feels
2353         like sane behavior for selected sidebar state restoration.
2354
2355         1. Starting a Timeline recording no longer automatically switches to the TimelineContentView.
2356         This was making every reload switch to Timelines. If you had
2357         a resource selected (e.g. the DOM Tree) we should go back
2358         to showing the DOM tree.
2359
2360         2. Background sidebars should not reveal and select tree elements.
2361         This was making resources get selected in Timelines when reloading the page
2362         because the background Resources sidebar was restoring selection of the resource.
2363         That is an unexpected selection and breaks the experience of Timelines.
2364
2365         3. ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.
2366         If a TimelineContentView was in the ContentBrowser back/forward history,
2367         a reload with a resource selected in the Resources sidebar would end up
2368         showing the Timelines sidebar. This was because when ContentViews are
2369         closed during the navigation, the ContentBrowser would fall back to the
2370         remaining TimelineContentView and switch to its only allowed sidebar
2371         (Timelines). ResourceSidebarPanel, knowing a resource was selected,
2372         would select the MainFrame intending to stay in the Resource sidebar,
2373         but the resource is okay with showing in any sidebar, so we stay on Timelines.
2374
2375         4. Resource sidebar state restoration should propertly restore selection.
2376         On reload, state restoration would know the resource to re-select in the
2377         Resources sidebar. As ResourceTreeElements are added to the sidebar
2378         they are checked against the state restoration cookie. If they match,
2379         they would select the element and delete the cookie. Unfortunately,
2380         if this was the first TreeElement child being added to a FrameTreeElement,
2381         the FrameTreeElement onpopulate would remove all children and re-add
2382         them in a unique way. Unfortunately this means the TreeElement we
2383         selected based on the cookie, immediately got thrown away and recreated,
2384         and we no longer reveal and select it. This is a special case for
2385         FrameTreeElements which use the onpopulate SPI. So, instead of starting
2386         processing the new element queue, if this is the first time just trigger
2387         the onpopulate and elements are made just once.
2388
2389         5. Show Error Console triggering early, could have unexpected sidebar behavior.
2390         Opening Web Inspector directly to the console can run before
2391         WebInspector.contentLoaded (DOMContentLoaded). So in that case
2392         WebInspector.showFullHeightConsole was not handling if the contentBrowser
2393         had no content view yet, and the sidebar might be-reopened later on
2394         in contentLoaded based on the setting value.
2395
2396         6. Improve automatic resource selection for sidebars with multiple tree outlines.
2397         Selecting a call frame tree element was unexpectedly changing the
2398         selection to a Resource where the breakpoint was set. This was
2399         because we were only looking at one of potentially many content
2400         tree outlines in the sidebar to see if there was a user action.
2401         
2402         * UserInterface/Base/Main.js:
2403         (WebInspector.contentLoaded):
2404         (WebInspector.showFullHeightConsole):
2405         (WebInspector.toggleConsoleView):
2406         (WebInspector._mainResourceDidChange):
2407         (WebInspector._provisionalLoadStarted):
2408         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
2409         (WebInspector._updateCookieForInspectorViewState):
2410         (WebInspector._contentBrowserCurrentContentViewDidChange):
2411         * UserInterface/Views/NavigationSidebarPanel.js:
2412         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2413         * UserInterface/Views/ResourceSidebarPanel.js:
2414         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2415         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2416         * UserInterface/Views/TimelineSidebarPanel.js:
2417         (WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
2418
2419 2014-09-08  Matt Baker  <mattbaker@apple.com>
2420
2421         Web Inspector: Add layout test for lowercase CSSProperty names
2422         https://bugs.webkit.org/show_bug.cgi?id=135961
2423
2424         Reviewed by Joseph Pecoraro.
2425
2426         Modified test components to support testing CSSStyleManager and related classes:
2427         - Added required models to Test.html
2428         - Added CSSCompletions initialization to Test.js
2429         - CSSCompletions doesn't assume presence of CodeMirror.
2430
2431         * UserInterface/Base/Test.js:
2432         (WebInspector.loaded):
2433         * UserInterface/Models/CSSCompletions.js:
2434         * UserInterface/Test.html:
2435
2436 2014-09-08  Matt Baker  <mattbaker@apple.com>
2437
2438         Web Inspector: Fixes to layout test infrastructure
2439         https://bugs.webkit.org/show_bug.cgi?id=136360
2440
2441         Reviewed by Joseph Pecoraro.
2442
2443         Added missing includes to Test.html, which was breaking tests that
2444         depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
2445         bug which prevented test results from being resent after reloading the
2446         page under test.
2447
2448         * UserInterface/Base/Test.js:
2449         (InspectorTest.reloadPage):
2450         * UserInterface/Test.html:
2451
2452 2014-09-07  Timothy Hatcher  <timothy@apple.com>
2453
2454         Use a <circle> instead of a <path> in DownloadArrow.svg.
2455         https://bugs.webkit.org/show_bug.cgi?id=136608
2456
2457         Reviewed by Antoine Quint.
2458
2459         * UserInterface/Images/DownloadArrow.svg:
2460         * UserInterface/Views/TreeElementStatusButton.css:
2461         (.item > .status > .status-button > svg .filled):
2462         (body.mac-platform.legacy .item > .status > .status-button > svg .filled):
2463         (:focus .item.selected > .status > .status-button > svg .filled):
2464         (.item > .status > .status-button > svg .stroked):
2465         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
2466         (:focus .item.selected > .status > .status-button > svg .stroked):
2467         Tweak CSS selectors to apply to other shapes, not just path.
2468
2469 2014-09-06  Darin Adler  <darin@apple.com>
2470
2471         Make updates suggested by new version of Xcode
2472         https://bugs.webkit.org/show_bug.cgi?id=136603
2473
2474         Reviewed by Mark Rowe.
2475
2476         * Configurations/Base.xcconfig: Added CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2477         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2478         CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH, ENABLE_STRICT_OBJC_MSGSEND,
2479         GCC_WARN_UNDECLARED_SELECTOR, and GCC_WARN_UNUSED_FUNCTION as suggested by Xcode update check.
2480         Also removed duplicate GCC_WARN_UNUSED_VARIABLE line.
2481
2482         * WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2483
2484 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2485
2486         LegacyProfiler: remove redundant ProfileNode members and other cleanup
2487         https://bugs.webkit.org/show_bug.cgi?id=136380
2488
2489         Reviewed by Timothy Hatcher.
2490
2491         Remove unused Profile.idleTime member.
2492
2493         * UserInterface/Models/Profile.js:
2494         (WebInspector.Profile.prototype.get idleTime): Deleted.
2495         * UserInterface/Models/ScriptTimelineRecord.js:
2496         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
2497
2498 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2499
2500         Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
2501         https://bugs.webkit.org/show_bug.cgi?id=136462
2502
2503         Reviewed by Timothy Hatcher.
2504
2505         The legacy profiler manager didn't do anything, and its views and models
2506         have been superseded by new views and models based on the Timeline classes.
2507
2508         * .eslintrc:
2509         * UserInterface/Base/Main.js:
2510         (WebInspector.loaded):
2511         (WebInspector.openURL): Remove profile URL handling code.
2512         * UserInterface/Controllers/LegacyProfileManager.js: Removed.
2513         * UserInterface/Main.html:
2514         * UserInterface/Protocol/ConsoleObserver.js:
2515         (WebInspector.ConsoleObserver.prototype.messageAdded):
2516         * UserInterface/Protocol/InspectorFrontendAPI.js:
2517         (InspectorFrontendAPI.isProfilingJavaScript): Deleted.
2518         (InspectorFrontendAPI.startProfilingJavaScript): Deleted.
2519         (InspectorFrontendAPI.stopProfilingJavaScript): Deleted.
2520         * UserInterface/Protocol/LegacyProfilerObserver.js: Removed.
2521         * UserInterface/Views/LegacyBottomUpProfileDataGridTree.js: Removed.
2522         * UserInterface/Views/LegacyJavaScriptProfileObject.js: Removed.
2523         * UserInterface/Views/LegacyJavaScriptProfileType.js: Removed.
2524         * UserInterface/Views/LegacyJavaScriptProfileView.css: Removed.
2525         * UserInterface/Views/LegacyJavaScriptProfileView.js: Removed.
2526         * UserInterface/Views/LegacyProfileDataGridTree.js: Removed.
2527         * UserInterface/Views/LegacyProfileObject.js: Removed.
2528         * UserInterface/Views/LegacyProfileType.js: Removed.
2529         * UserInterface/Views/LegacyProfileView.css: Removed.
2530         * UserInterface/Views/LegacyProfileView.js: Removed.
2531         * UserInterface/Views/LegacyTopDownProfileDataGridTree.js: Removed.
2532
2533 2014-08-29  Saam Barati  <saambarati1@gmail.com>
2534
2535         Web Inspector: Create a UI for displaying JavaScript type information
2536         https://bugs.webkit.org/show_bug.cgi?id=135142
2537
2538         Reviewed by Joseph Pecoraro.
2539
2540         JavaScriptCore now has a type profiler. This patch provides a frontend
2541         user interface for displaying this type information in the Web Inspector.
2542         The user interface works by placing inline "type tokens" next to important
2543         JavaScript expressions: function arguments, function return types, and 
2544         variable declarations. Type information can also be seen for almost every
2545         JavaScipt expression just by hovering over it while viewing a JavaScript file.
2546
2547         Currently, turning on the type profiler is expensive, so the inspector
2548         ensures to never turn on type profiling until the user specifically asks 
2549         for type information to be turned on.
2550
2551         * UserInterface/Base/Main.js:
2552         (WebInspector.loaded):
2553         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2554         (WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
2555         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
2556         Added a new type profiling mode.
2557
2558         * UserInterface/Controllers/FormatterSourceMap.js:
2559         (WebInspector.FormatterSourceMap.prototype.originalToFormatted):
2560         (WebInspector.FormatterSourceMap.prototype.originalPositionToFormatted):
2561         (WebInspector.FormatterSourceMap.prototype.formattedToOriginal):
2562         (WebInspector.FormatterSourceMap.prototype.formattedToOriginalOffset):
2563         * UserInterface/Controllers/TypeTokenAnnotator.js: Added.
2564         (WebInspector.TypeTokenAnnotator):
2565         (WebInspector.TypeTokenAnnotator.prototype.get isActive):
2566         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor):
2567         (WebInspector.TypeTokenAnnotator.prototype.pause):
2568         (WebInspector.TypeTokenAnnotator.prototype.resume):
2569         (WebInspector.TypeTokenAnnotator.prototype.refresh):
2570         (WebInspector.TypeTokenAnnotator.prototype.reset):
2571         (WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
2572         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.):
2573         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
2574         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
2575         (WebInspector.TypeTokenAnnotator.prototype.isLineTerminator):
2576         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
2577         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded):
2578         This class is responsible for producing the inline "type token" annotations.
2579
2580         * UserInterface/Images/NavigationItemTypes.svg: Added.
2581         * UserInterface/Main.html:
2582         * UserInterface/Models/Script.js:
2583         (WebInspector.Script.prototype.get scriptSyntaxTree):
2584         * UserInterface/Models/ScriptSyntaxTree.js:
2585         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2586         (WebInspector.ScriptSyntaxTree.prototype.):
2587         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2588         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2589         * UserInterface/Views/ScriptContentView.js:
2590         (WebInspector.ScriptContentView):
2591         (WebInspector.ScriptContentView.prototype.get navigationItems):
2592         (WebInspector.ScriptContentView.prototype._contentDidPopulate):
2593         (WebInspector.ScriptContentView.prototype._toggleTypeAnnotations):
2594         (WebInspector.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2595         * UserInterface/Views/SourceCodeTextEditor.js:
2596         (WebInspector.SourceCodeTextEditor):
2597         (WebInspector.SourceCodeTextEditor.prototype.shown):
2598         (WebInspector.SourceCodeTextEditor.prototype.hidden):
2599         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
2600         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
2601         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
2602         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
2603         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
2604         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
2605         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
2606         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
2607         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
2608         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
2609         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
2610         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2611         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
2612         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2613         (WebInspector.SourceCodeTextEditor.prototype._enableScrollEventsForTypeTokenAnnotator):
2614         (WebInspector.SourceCodeTextEditor.prototype._disableScrollEventsForTypeTokenAnnotator):
2615         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
2616         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
2617         * UserInterface/Views/TextContentView.js:
2618         (WebInspector.TextContentView.prototype.get navigationItems):
2619         * UserInterface/Views/TextEditor.js:
2620         (WebInspector.TextEditor.prototype.set formatted):
2621         (WebInspector.TextEditor.prototype.canShowTypeAnnotations):
2622         (WebInspector.TextEditor.prototype.visibleRangeOffsets):
2623         (WebInspector.TextEditor.prototype.originalOffsetToCurrentPosition):
2624         (WebInspector.TextEditor.prototype.currentOffsetToCurrentPosition):
2625         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
2626         (WebInspector.TextEditor.prototype.currentPositionToCurrentOffset):
2627         (WebInspector.TextEditor.prototype.setInlineWidget):
2628         (WebInspector.TextEditor.prototype.addScrollHandler):
2629         (WebInspector.TextEditor.prototype.removeScrollHandler):
2630         (WebInspector.TextEditor.prototype._scrollIntoViewCentered):
2631         * UserInterface/Views/TextResourceContentView.js:
2632         (WebInspector.TextResourceContentView):
2633         (WebInspector.TextResourceContentView.prototype.get navigationItems):
2634         (WebInspector.TextResourceContentView.prototype._contentDidPopulate):
2635         (WebInspector.TextResourceContentView.prototype._toggleTypeAnnotations):
2636         (WebInspector.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2637         * UserInterface/Views/TypePropertiesSection.js: Added.
2638         (WebInspector.TypePropertiesSection):
2639         (WebInspector.TypePropertiesSection.prototype.onpopulate):
2640         (WebInspector.TypePropertiesSection.PropertyComparator):
2641         (WebInspector.TypePropertyTreeElement):
2642         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
2643         * UserInterface/Views/TypeTokenView.css: Added.
2644         (.type-token):
2645         (.type-token-left-spacing):
2646         (.type-token-right-spacing):
2647         (.type-token-function, .type-token-boolean):
2648         (.type-token-number):
2649         (.type-token-string):
2650         (.type-token-default):
2651         (.type-token-empty):
2652         (.type-token-many):
2653         * UserInterface/Views/TypeTokenView.js: Added.
2654         (WebInspector.TypeTokenView):
2655         (WebInspector.TypeTokenView.titleForPopover):
2656         (WebInspector.TypeTokenView.prototype.update):
2657         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
2658         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
2659         The inline "type token" view.
2660
2661 2014-08-29  Saam Barati  <sbarati@apple.com>
2662
2663         Web Inspector: Fix how Popover animates
2664         https://bugs.webkit.org/show_bug.cgi?id=136353
2665
2666         Reviewed by Timothy Hatcher.
2667
2668         Popovers currently don't animate properly because they use 
2669         window.requestAnimationFrame which won't fire its callback 
2670         while the inspector is paused in the debugger. This patches
2671         switches the callback mechanism to setTimeout and also changes
2672         how a Popover's anchor animates to prevent visual glitches.
2673
2674         Popover also has a new function that allows a new target
2675         frame and new content to be set simultaneously and to
2676         animate to show the new content while changing the 
2677         location of the popover frame.
2678
2679         SourceCodeTextEditor uses Popover's new API for animating
2680         between popovers when paused in the debugger. SourceCodeTextEditor 
2681         also now ensures proper balancing of popover tracking event 
2682         listeners.
2683
2684         * UserInterface/Views/Popover.js:
2685         (WebInspector.Popover.prototype.present):
2686         (WebInspector.Popover.prototype.presentNewContentWithFrame):
2687         (WebInspector.Popover.prototype.dismiss):
2688         (WebInspector.Popover.prototype._update):
2689         (WebInspector.Popover.prototype.drawBackground):
2690         (WebInspector.Popover.prototype._animateFrame):
2691         (WebInspector.Popover.prototype._drawFrame):
2692         (WebInspector.Popover.prototype._addListenersIfNeeded):
2693         (WebInspector.Popover.prototype._animateFrame.drawBackground): Deleted.
2694         * UserInterface/Views/SourceCodeTextEditor.js:
2695         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2696         (WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
2697         (WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
2698
2699 2014-08-28  Saam Barati  <sbarati@apple.com>
2700
2701         Web Inspector: Write tests for ScriptSyntaxTree and fix bugs in the data structure
2702         https://bugs.webkit.org/show_bug.cgi?id=136272
2703
2704         Reviewed by Joseph Pecoraro.
2705
2706         Include the necessary files in Test.html to test ScriptSyntaxTree.
2707         Also, ScriptSyntaxTree had a couple of errors for two of its nodes
2708         where they simply ignored one of the properties on the node.
2709         These errors were found while writing the tests and are fixed
2710         in this patch.
2711
2712         * UserInterface/Models/ScriptSyntaxTree.js:
2713         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2714         * UserInterface/Test.html:
2715
2716 2014-08-27  Saam Barati  <sbarati@apple.com>
2717
2718         Web Inspector: Layout issues for popover on not legacy OS
2719         https://bugs.webkit.org/show_bug.cgi?id=136268
2720
2721         Reviewed by Joseph Pecoraro.
2722
2723         On the latest OS, popovers invade the title bar's space which will
2724         cause layout issues because the title bar will render above
2725         the popover. Fix this by providing some padding for popovers on 
2726         not legacy OSs.
2727
2728         * UserInterface/Views/Popover.js:
2729
2730 2014-08-27  Timothy Hatcher  <timothy@apple.com>
2731
2732         REGRESSION: Web Inspector: Legacy toolbar has two different colors in unfocused windowed mode
2733         https://bugs.webkit.org/show_bug.cgi?id=136289
2734
2735         Reviewed by Darin Adler.
2736
2737         * UserInterface/Views/Toolbar.css:
2738         (body.mac-platform.legacy .toolbar): Override the background-color as transparent. Non-legacy
2739         uses a solid color instead of a gradient for window-inactive.
2740
2741 2014-08-26  Saam Barati  <sbarati@apple.com>
2742
2743         Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
2744         https://bugs.webkit.org/show_bug.cgi?id=136160
2745
2746         Reviewed by Joseph Pecoraro.
2747
2748         Check if '_tracking' is already true before calling '_startTracking'
2749         to prevent the assertion from always firing.
2750
2751         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2752         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
2753
2754 2014-08-25  Brent Fulgham  <bfulgham@apple.com>
2755
2756         [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
2757         https://bugs.webkit.org/show_bug.cgi?id=136229
2758
2759         Reviewed by Dean Jackson.
2760
2761         * WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
2762         flag to build-webinspectorui.pl.
2763         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
2764         the OFFICIAL_BUILD flag.
2765
2766 2014-08-24  Benjamin Poulain  <benjamin@webkit.org>
2767
2768         The inspector should not use the "after" pseudo element with the compatibility syntax
2769         https://bugs.webkit.org/show_bug.cgi?id=136204
2770
2771         Reviewed by Darin Adler.
2772
2773         We should only use hte proper pseudo element syntax inside WebKit.
2774
2775         * Tools/PrettyPrinting/codemirror-additions.css:
2776         * Tools/PrettyPrinting/populate/apple.css:
2777
2778 2014-08-24  Brian J. Burg  <burg@cs.washington.edu>
2779
2780         Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
2781         https://bugs.webkit.org/show_bug.cgi?id=136025
2782
2783         Reviewed by Joseph Pecoraro.
2784
2785         Also rename DOM.RGBA in legacy protocol specifications.
2786
2787         * Versions/Inspector-iOS-6.0.json:
2788         * Versions/Inspector-iOS-7.0.json:
2789
2790 2014-08-21  Simon Fraser  <simon.fraser@apple.com>
2791
2792         Add a button to enable paint flashing in the web inspector
2793         https://bugs.webkit.org/show_bug.cgi?id=136133
2794
2795         Reviewed by Tim Hatcher.
2796         
2797         Add a button to the right of the layer borders button to turn on paint flashing.
2798         Future patches will actually enable this feature.
2799
2800         * Localizations/en.lproj/localizedStrings.js: Tooltip strings.
2801         * UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
2802         * UserInterface/Views/DOMTreeContentView.js:
2803         (WebInspector.DOMTreeContentView):
2804         (WebInspector.DOMTreeContentView.prototype.get navigationItems):
2805         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
2806
2807 2014-08-20  Saam Barati  <sbarati@apple.com>
2808
2809         Rename HighFidelityTypeProfiling variables for more clarity
2810         https://bugs.webkit.org/show_bug.cgi?id=135899
2811
2812         Reviewed by Geoffrey Garen.
2813
2814         Change a reference in a comment to a JavaScriptCore file to its 
2815         newly renamed variant.
2816
2817         * UserInterface/Models/ScriptSyntaxTree.js:
2818
2819 2014-08-18  Saam Barati  <sbarati@apple.com>
2820
2821         Web Inspector: Introduce an inspector Abstract Syntax Tree.
2822         https://bugs.webkit.org/show_bug.cgi?id=135763
2823
2824         Reviewed by Joseph Pecoraro.
2825
2826         This patch adds an Abstract Syntax Tree to the Web inspector. 
2827         This syntax tree is modeled off the Esprima.js syntax tree
2828         which complies with the Mozilla Parser API:
2829         https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
2830         Script is the owner of the Web Inspector syntax tree, and has an API
2831         for accessing its syntax tree property.
2832
2833         * UserInterface/External/Esprima/esprima.js:
2834         * UserInterface/Main.html:
2835         * UserInterface/Models/Script.js:
2836         (WebInspector.Script):
2837         (WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
2838         (WebInspector.Script.prototype._resolveResource):
2839         (WebInspector.Script.prototype._makeSyntaxTree):
2840         * UserInterface/Models/ScriptSyntaxTree.js: Added.
2841         (WebInspector.ScriptSyntaxTree):
2842         (WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
2843         (WebInspector.ScriptSyntaxTree.prototype.forEachNode):
2844         (WebInspector.ScriptSyntaxTree.prototype.):
2845         (WebInspector.ScriptSyntaxTree.prototype.filter):
2846         (WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
2847         (WebInspector.ScriptSyntaxTree.prototype.filterByRange):
2848         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
2849         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2850         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2851         (WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
2852         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2853         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
2854         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2855
2856 2014-08-16  Joseph Pecoraro  <pecoraro@apple.com>
2857
2858         Web Inspector: Improve performance of selection range changes viewing Scripts timeline
2859         https://bugs.webkit.org/show_bug.cgi?id=136015
2860
2861         Reviewed by Timothy Hatcher.
2862
2863         * UserInterface/Base/Utilities.js:
2864         (clamp):
2865         Helper function to clamp a value between a min and max.
2866
2867         * UserInterface/Models/ProfileNode.js:
2868         (WebInspector.ProfileNode.prototype.get startTime):
2869         (WebInspector.ProfileNode.prototype.get endTime):
2870         These can be quickly calculated, so avoid full calculation to grab the values.
2871
2872         * UserInterface/Views/ScriptTimelineView.js:
2873         (WebInspector.ScriptTimelineView.prototype.updateLayout):
2874         Update ranges with a smart helper, instead of blindly doing it and needing refresh.
2875
2876         * UserInterface/Views/ProfileNodeDataGridNode.js:
2877         (WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
2878         (WebInspector.ProfileNodeDataGridNode.prototype.get data):
2879         (WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
2880         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
2881         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.
2882         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2883         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2884         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
2885         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
2886         When updating the range selection, compare to the last range selection
2887         on this DataGridNode. If the visible portion of this node's time range
2888         changes, we need a refresh. Otherwise, we don't need a refresh.
2889
2890 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2891
2892         Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
2893         https://bugs.webkit.org/show_bug.cgi?id=136006
2894
2895         Reviewed by Timothy Hatcher.
2896
2897         * Scripts/update-LegacyInspectorBackendCommands.rb:
2898         Use the new generator and pass the appropriate flags.
2899
2900         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
2901         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
2902         Newly generated files using the new generator.
2903
2904         * Versions/Inspector-iOS-6.0.json:
2905         Remove unsupported features.
2906
2907 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2908
2909         Web Inspector: Remove forced layouts during recording caused by striped background element resizing
2910         https://bugs.webkit.org/show_bug.cgi?id=136009
2911
2912         Reviewed by Timothy Hatcher.
2913
2914         We used to manually resize and a custom striped background behind
2915         the timeline tree outline content area. This can happen frequently
2916         during timeline recordings causing forced layouts. We can eliminate
2917         the hack and instead put the stripe background on the tree outline.
2918
2919         * UserInterface/Views/TimelineSidebarPanel.js:
2920         (WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2921         * UserInterface/Views/TimelineSidebarPanel.css:
2922         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
2923         (.sidebar > .panel.navigation.timeline > .content > .stripe-background): Deleted.
2924         (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background): Deleted.
2925         Eliminate the striped background element.
2926
2927         * UserInterface/Views/TimelineView.css:
2928         (.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline):
2929         (.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
2930         Give the timeline content tree outlines the striped background.
2931
2932         * UserInterface/Views/NavigationSidebarPanel.js:
2933         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2934         (WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2935         Remove the now unused updateCustomContentOverflow method.
2936
2937 2014-08-15  Jono Wells  <jonowells@apple.com>
2938
2939         Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
2940         https://bugs.webkit.org/show_bug.cgi?id=135995
2941
2942         Reviewed by Joseph Pecoraro.
2943
2944         Change so if an element is inspected via the Inspect Element context menu, selected
2945         node restoration is disallowed until the main resource in the main frame changes.
2946         This way an attempt by a sub-frame will not change the highlighted element in the
2947         Main Frame's DOM tree unexpectedly.
2948
2949         * UserInterface/Controllers/DOMTreeManager.js:
2950         (WebInspector.DOMTreeManager):
2951         (WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
2952         (WebInspector.DOMTreeManager.prototype.inspectElement):
2953
2954 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
2955
2956         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2957         https://bugs.webkit.org/show_bug.cgi?id=131596
2958
2959         Reviewed by Joseph Pecoraro.
2960
2961         Also apply type extraction refactorings to old protocol versions for consistency.
2962
2963         * Versions/Inspector-iOS-6.0.json:
2964         * Versions/Inspector-iOS-7.0.json:
2965
2966 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2967
2968         Web Inspector: Probe details sidebar data grids do not show data
2969         https://bugs.webkit.org/show_bug.cgi?id=135992
2970
2971         Reviewed by Joseph Pecoraro.
2972
2973         * UserInterface/Views/ProbeSetDataGrid.js:
2974         (WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.
2975
2976 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2977
2978         Web Inspector: Legacy Mac toolbar appearance looks wrong
2979         https://bugs.webkit.org/show_bug.cgi?id=135962
2980
2981         Reviewed by Joseph Pecoraro.
2982
2983         * UserInterface/Views/Toolbar.css:
2984         (body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
2985         Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
2986         applies all the time as it should have.
2987
2988 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2989
2990         Web Inspector: Dragging Undocked inspector by window title has broken behavior
2991         https://bugs.webkit.org/show_bug.cgi?id=135950
2992
2993         Reviewed by Timothy Hatcher.
2994
2995         * UserInterface/Base/Main.js:
2996         On Mac ports where we the inspector content goes everywhere, window dragging behavior
2997         still exists for the top 22px of the window. So don't do our JavaScript based window
2998         dragging for this special region.
2999
3000         * UserInterface/Models/KeyboardShortcut.js:
3001         (WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
3002         (WebInspector.KeyboardShortcut.prototype.get displayName):
3003         Instead of calling a host function, use the value already in the frontend.
3004
3005 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3006
3007         Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
3008         https://bugs.webkit.org/show_bug.cgi?id=135957
3009
3010         Reviewed by Timothy Hatcher.
3011
3012         * UserInterface/Views/LogContentView.js:
3013         (WebInspector.LogContentView):
3014         Wrong image path passed to platformImagePath.
3015
3016 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3017
3018         Web Inspector: Avoid re-binding the same function over and over
3019         https://bugs.webkit.org/show_bug.cgi?id=135949
3020
3021         Reviewed by Timothy Hatcher.
3022
3023         * UserInterface/Controllers/TimelineManager.js:
3024         (WebInspector.TimelineManager.prototype._startAutoCapturing):
3025         (WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
3026         (WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
3027         Stash a bound copy of the function once, and reuse it.
3028
3029 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3030
3031         Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
3032         https://bugs.webkit.org/show_bug.cgi?id=135946
3033
3034         Reviewed by Timothy Hatcher.
3035
3036         Each TimelineContentView was listening for the TimelineManager's start/stop
3037         capturing events. However, only the active recording could possibly update.
3038         Likewise, if a pre-existing recording started and stopped we did not properly
3039         stop in the case where we were waiting for an event to update the current time,
3040         which would result in an infinite rAF loop of no updates.
3041
3042         * UserInterface/Models/TimelineRecording.js:
3043         (WebInspector.TimelineRecording.prototype.unloaded):
3044         When a timeline recording is unloaded trigger an event.
3045
3046         * UserInterface/Views/TimelineContentView.js:
3047         (WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
3048         Assert we were not already waiting.
3049
3050         (WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
3051         Properly handle the case of starting/stoping an already existing recording
3052         without a new event coming in.
3053
3054         (WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
3055         (WebInspector.TimelineContentView.prototype._recordingReset):
3056         Convert to a boolean instead of deleting state.
3057
3058         (WebInspector.TimelineContentView.prototype._recordingUnloaded):
3059         Stop listening to timeline manager events that no longer affect unloaded recordings.
3060
3061 2014-08-13  Jono Wells  <jonowells@apple.com>
3062
3063         Web Inspector: eslint configuration should be stored as .eslintrc
3064         https://bugs.webkit.org/show_bug.cgi?id=135916
3065
3066         .eslintrc file added to allow for ESLint solutions, within editors and otherwise,
3067         to be automatically configured based on the WebKit JavaScript coding style. The
3068         initial file is incomplete.
3069
3070         Reviewed by Joseph Pecoraro.
3071
3072         * .eslintrc: Added.
3073         * External/.eslintrc: Added.
3074
3075 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3076
3077         Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
3078         https://bugs.webkit.org/show_bug.cgi?id=135917
3079
3080         Reviewed by Joseph Pecoraro.
3081
3082         * UserInterface/Views/TimelineSidebarPanel.js:
3083
3084 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3085
3086         Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
3087         https://bugs.webkit.org/show_bug.cgi?id=135894
3088
3089         Reviewed by Timothy Hatcher.
3090
3091         * UserInterface/Views/DetailsSection.css:
3092         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
3093         In legacy styles the details-section header always has a 1px bottom border.
3094         In all styles, an inline data grid had a 1px border everywhere. So, handle
3095         this specific case by removing the top border of an inline data grid
3096         that is inside an expanded details section.
3097
3098 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3099
3100         Web Inspector: "No Filter Results" view only shows once, does not show again
3101         https://bugs.webkit.org/show_bug.cgi?id=135892
3102
3103         Reviewed by Timothy Hatcher.
3104
3105         * UserInterface/Views/NavigationSidebarPanel.js:
3106         (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
3107         We were checking at the wrong level for a parent. Check if the root
3108         placeholder element has a parent or not.
3109
3110 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3111
3112         Web Inspector: Incorrect border colors in event listeners sections in details sidebar
3113         https://bugs.webkit.org/show_bug.cgi?id=135891
3114
3115         Reviewed by Timothy Hatcher.
3116
3117         * UserInterface/Views/DetailsSection.css:
3118         (.details-section .details-section > .header):
3119         (.details-section .details-section:not(.collapsed) > .header):
3120         Remove box-shadow and replace with a bottom border.
3121
3122         (body.mac-platform.legacy .details-section .details-section.collapsed > .header):
3123         (.details-section .details-section.collaspsed > .header): Deleted.
3124         Collapsed was spelled incorrectly so this was not applying properly before.
3125         But correct this for legacy because legacy still uses a box-shadow.
3126
3127 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3128
3129         Web Inspector: Timeline Close buttons can use polish for new and legacy styles
3130         https://bugs.webkit.org/show_bug.cgi?id=135870
3131
3132         Reviewed by Timothy Hatcher.
3133
3134         * UserInterface/Images/Legacy/Close.svg:
3135         Ensure this has fill colors in tree selections.
3136
3137         * UserInterface/Views/TimelineSidebarPanel.css:
3138         (.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3139         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3140         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
3141         Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).
3142
3143 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3144
3145         Web Inspector: Workaround a NSWindow change to the title bar.
3146         https://bugs.webkit.org/show_bug.cgi?id=135880
3147
3148         Reviewed by Joseph Pecoraro.
3149
3150         * UserInterface/Base/Main.js:
3151         (WebInspector._updateToolbarHeight): Don't call in legacy mode.
3152
3153         * UserInterface/Views/DashboardContainerView.css:
3154         (.toolbar .dashboard-container):
3155         (.toolbar .dashboard):
3156         Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
3157         drop shadow down when it shouldn't. Remove duplicate background and shadow.
3158
3159         * UserInterface/Views/Main.css:
3160         (body): Set the background white, never needs to be transparent now.
3161         (body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
3162         (body.docked.bottom): Update border color.
3163         (body.docked.right): Ditto.
3164         (body.docked.bottom.mac-platform.legacy): Keep old border color.
3165         (body.docked.right.mac-platform.legacy): Ditto.
3166
3167         * UserInterface/Views/Toolbar.css:
3168         (.toolbar): Set a default border and background gradient.
3169         (body.window-inactive .toolbar): No gradient but use a solid color when inactive.
3170         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
3171         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
3172         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
3173         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
3174         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
3175         (body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
3176         (body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
3177         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
3178         (body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.
3179
3180 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3181
3182         Web Inspector: Restore Helvetica as the dashboard font in legacy mode
3183         https://bugs.webkit.org/show_bug.cgi?id=135886
3184
3185         Reviewed by Joseph Pecoraro.
3186
3187         * UserInterface/Views/DefaultDashboardView.css:
3188         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3189
3190 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3191
3192         Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar
3193         https://bugs.webkit.org/show_bug.cgi?id=135863
3194
3195         Reviewed by Timothy Hatcher.
3196
3197         A workaround is to not have position:relative content inside of
3198         scrollable region. Turns out this was only done in two places,
3199         and I do not see any absolutely positioned content in navigation
3200         sidebar content tree outlines. This also fixes clicking on the
3201         reload button if you've scrolled the Resources sidebar. 
3202
3203         * UserInterface/Views/NavigationSidebarPanel.css:
3204         (.navigation-sidebar-panel-content-tree-outline .children): Deleted.
3205         (.navigation-sidebar-panel-content-tree-outline .item): Deleted.
3206
3207 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3208
3209         Web Inspector: Remove unused variable in Platform.js
3210         https://bugs.webkit.org/show_bug.cgi?id=135869
3211
3212         Reviewed by Timothy Hatcher.
3213
3214         * UserInterface/Base/Platform.js:
3215
3216 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3217
3218         Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
3219         https://bugs.webkit.org/show_bug.cgi?id=135849
3220
3221         Reviewed by Timothy Hatcher.
3222
3223         Click events on elements in the graph container (event bubbles) or
3224         in the scroll container (bottom 16px) were becoming the event targets.
3225         As siblings of the ruler, the dispatch would not go through the ruler.
3226         The ruler was supposed to be overlaying everything in the overview,
3227         so give the ruler a z-index so it really is overlaying elements.
3228
3229         * UserInterface/Views/TimelineRuler.css:
3230         (.timeline-ruler):
3231
3232 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3233
3234         Web Inspector: GoToLine dialog clear text button looks poor
3235         https://bugs.webkit.org/show_bug.cgi?id=135828
3236
3237         Reviewed by Timothy Hatcher.
3238
3239         Legacy/CloseWhite.svg was not used, but in the case where the white
3240         close button is needed the thicker bars looks better. Re-use the
3241         Legacy image as the default CloseWhite.svg.
3242
3243         * UserInterface/Images/CloseWhite.svg:
3244         * UserInterface/Images/Legacy/CloseWhite.svg: Removed.
3245
3246 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3247
3248         Web Inspector: Easier Way to go back to the Timeline Overviews
3249         https://bugs.webkit.org/show_bug.cgi?id=135827
3250
3251         Reviewed by Timothy Hatcher.
3252
3253         * Localizations/en.lproj/localizedStrings.js:
3254         Added new tooltip UIString.
3255
3256         * UserInterface/Images/Close.svg:
3257         * UserInterface/Images/CloseLarge.svg:
3258         * UserInterface/Images/Legacy/Close.svg:
3259         Add "stroked" class so the buttons can fill with white on selected rows.
3260         Also re-center the non-legacy images horizontally.
3261
3262         * UserInterface/Views/GeneralTreeElement.js:
3263         (WebInspector.GeneralTreeElement.prototype.set status):
3264         Do not recreate elements if the status did not change.
3265
3266         * UserInterface/Views/LayoutTimelineView.js:
3267         (WebInspector.LayoutTimelineView):
3268         (WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
3269         (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
3270         (WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton):
3271         (WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):
3272         * UserInterface/Views/NetworkTimelineView.js:
3273         (WebInspector.NetworkTimelineView):
3274         (WebInspector.NetworkTimelineView.prototype._treeElementDeselected):
3275         (WebInspector.NetworkTimelineView.prototype._treeElementSelected):
3276         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton):
3277         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):
3278         * UserInterface/Views/OverviewTimelineView.js:
3279         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected):
3280         (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
3281         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton):
3282         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):
3283         * UserInterface/Views/ScriptTimelineView.js:
3284         (WebInspector.ScriptTimelineView):
3285         (WebInspector.ScriptTimelineView.prototype._treeElementDeselected):
3286         (WebInspector.ScriptTimelineView.prototype._treeElementSelected):
3287         (WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton):
3288         (WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
3289         Provide select/deselect handlers to show/hide the close status bar button
3290         when selecting a row that shows a non-Timeline content view. Currently the
3291         only content views the tree elements can show are Resource views, so the
3292         tooltip is the same everywhere.
3293
3294 2014-08-12  Timothy Hatcher  <timothy@apple.com>
3295
3296         Web Inspector: Expect to see top level JavaScript function profiler details for event handlers in timeline
3297         https://bugs.webkit.org/show_bug.cgi?id=132109
3298
3299         Reviewed by Joseph Pecoraro.
3300
3301         * UserInterface/Views/ScriptTimelineView.js:
3302         (WebInspector.ScriptTimelineView.prototype._processPendingRecords): Don't promote root node children if
3303         there is only one child.
3304
3305 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3306
3307         Web Inspector: show a replay dashboard when capturing or replaying
3308         https://bugs.webkit.org/show_bug.cgi?id=135170
3309
3310         Reviewed by Timothy Hatcher.
3311
3312         This patch adds a replay dashboard with record/play/pause buttons. It
3313         is shown automatically when the user starts capturing an execution from
3314         the replay menu in the Timelines sidebar panel.
3315
3316         * UserInterface/Base/Main.js:
3317         (WebInspector.loaded):
3318         (WebInspector._captureDidStart):
3319         * UserInterface/Controllers/DashboardManager.js:
3320         (WebInspector.DashboardManager):
3321         * UserInterface/Images/ReplayPauseButton.svg: Added.
3322         * UserInterface/Images/ReplayPlayButton.svg: Added.
3323         * UserInterface/Images/ReplayRecordingButton.svg: Added.
3324         * UserInterface/Main.html:
3325         * UserInterface/Models/ReplayDashboard.js: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3326         (WebInspector.ReplayDashboard):
3327         * UserInterface/Views/DashboardView.js:
3328         (WebInspector.DashboardView):
3329         * UserInterface/Views/ReplayDashboardView.css: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3330         (.toolbar .dashboard.replay):
3331         (.toolbar .dashboard.replay div.navigation-bar):
3332         (.toolbar .dashboard.replay .item.button > .glyph):
3333         (.toolbar.label-only .dashboard.replay .item.button > .glyph):
3334         * UserInterface/Views/ReplayDashboardView.js: Added.
3335         (WebInspector.ReplayDashboardView):
3336         (WebInspector.ReplayDashboardView.prototype._captureButtonItemClicked):
3337         (WebInspector.ReplayDashboardView.prototype._replayButtonItemClicked):
3338         (WebInspector.ReplayDashboardView.prototype._captureStarted):
3339         (WebInspector.ReplayDashboardView.prototype._captureStopped):
3340         (WebInspector.ReplayDashboardView.prototype._playbackStarted):
3341         (WebInspector.ReplayDashboardView.prototype._playbackPaused):
3342         (WebInspector.ReplayDashboardView.prototype._playbackFinished):
3343
3344 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3345
3346         Web Inspector: DebuggerManager commands should return promises
3347         https://bugs.webkit.org/show_bug.cgi?id=135690
3348
3349         Reviewed by Timothy Hatcher.
3350
3351         Convert the existing debugger commands to return promises. This
3352         requires separately waiting for protocol command's promise to be
3353         fulfilled, as well as waiting for the appropriate DebuggerManager
3354         event. If the protocol command promise is rejected, tear down the
3355         single-fire event listener.
3356
3357         * UserInterface/Controllers/DebuggerManager.js:
3358         (WebInspector.DebuggerManager.prototype.pause):
3359         (WebInspector.DebuggerManager.prototype.resume):
3360         (WebInspector.DebuggerManager.prototype.stepOver):
3361         (WebInspector.DebuggerManager.prototype.stepInto):
3362         (WebInspector.DebuggerManager.prototype.stepOut):
3363         * UserInterface/Controllers/ReplayManager.js: Use the promise-based API.
3364         (WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):
3365
3366 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3367
3368         Web Inspector: Update folder icons
3369         https://bugs.webkit.org/show_bug.cgi?id=135808
3370
3371         Reviewed by Joseph Pecoraro.
3372
3373         * UserInterface/Images/FolderGeneric.png: Updated.
3374         * UserInterface/Images/FolderGeneric@2x.png: Updated.
3375
3376 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3377
3378         Web Inspector: DataGrid and its clients are a cluster-cuss of styles
3379         https://bugs.webkit.org/show_bug.cgi?id=135788
3380
3381         Clean up DataGrid and its subclasses and client styles.
3382
3383         Reviewed by Joseph Pecoraro.
3384
3385         * Localizations/en.lproj/localizedStrings.js:
3386         * UserInterface/Views/ApplicationCacheFrameContentView.css:
3387         (.content-view.application-cache-frame > .data-grid):
3388         * UserInterface/Views/CookieStorageContentView.css:
3389         (.content-view.cookie-storage > .data-grid):
3390         * UserInterface/Views/DOMStorageContentView.css:
3391         (.content-view.dom-storage > .data-grid):
3392         * UserInterface/Views/DOMTreeDataGrid.css:
3393         (.dom-tree-data-grid .data-grid):
3394         (.dom-tree-data-grid .name-column .icon):
3395         * UserInterface/Views/DOMTreeDataGrid.js:
3396         (WebInspector.DOMTreeDataGrid):
3397         * UserInterface/Views/DataGrid.css:
3398         (.data-grid):
3399         (.data-grid table):
3400         (.data-grid .data-container):
3401         (.data-grid.inline):
3402         (.data-grid th):
3403         (.data-grid :-webkit-any(th, td):not(:last-child)):
3404         (.data-grid th.sortable:active):
3405         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
3406         (.data-grid table.data):
3407         (.data-grid td):
3408         (.data-grid:focus tr.selected td:not(:last-child)):
3409         (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
3410         (.data-grid :-webkit-any(th, td) > div):
3411         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
3412         (.data-grid th.sort-ascending > div:first-child::after):
3413         (.data-grid th.sort-descending > div:first-child::after):
3414         (.data-grid td .subtitle):
3415         (.data-grid td .subtitle::before):
3416         (.data-grid:focus tr.selected td .subtitle):
3417         (.data-grid td.error):
3418         (.data-grid tr.selected td.error):
3419         (.data-grid td .icon):
3420         (.data-grid td .go-to-arrow):
3421         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):
3422         * UserInterface/Views/DatabaseContentView.css:
3423         (.storage-view):
3424         * UserInterface/Views/DatabaseTableContentView.css:
3425         (.content-view.database-table > .data-grid):
3426         * UserInterface/Views/DetailsSection.css:
3427         (.details-section > .content .data-grid):
3428         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
3429         (.content-view.indexed-database-object-store > .data-grid):
3430         * UserInterface/Views/LayerTreeDataGridNode.js:
3431         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
3432         (WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):
3433         * UserInterface/Views/LayerTreeSidebarPanel.css:
3434         (.layer-tree.panel .data-grid):
3435         (.layer-tree.panel .name-column .icon):
3436         (.layer-tree.panel tr.reflection .name-column .icon):
3437         (.layer-tree.panel tr.pseudo-element .name-column .icon):
3438         (.layer-tree.panel .name-column .reflection):
3439         (.layer-tree.panel tr.selected .name-column .reflection):
3440         (.layer-tree.panel .bottom-bar):
3441         (body.mac-platform.legacy .layer-tree.panel .bottom-bar):
3442         (.layer-tree.panel .bottom-bar > div):
3443         (body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
3444         (body.mac-platform.legacy .layer-tree-popover):
3445         * UserInterface/Views/LayerTreeSidebarPanel.js:
3446         (WebInspector.LayerTreeSidebarPanel):
3447         (WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
3448         (WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
3449         (WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
3450         (WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):
3451         * UserInterface/Views/LegacyJavaScriptProfileView.css:
3452         (.content-view.profile-view > .data-grid):
3453         * UserInterface/Views/LegacyProfileView.css:
3454         * UserInterface/Views/LogContentView.css:
3455         (.console-message .bubble):
3456         * UserInterface/Views/NetworkTimelineView.css:
3457         (.timeline-view.network > .data-grid):
3458         * UserInterface/Views/OverviewTimelineView.css:
3459         (.timeline-view.overview > .timeline-ruler > .header):
3460         (.timeline-view.overview > .data-grid):
3461         * UserInterface/Views/OverviewTimelineView.js:
3462         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
3463         (.details-section.probe-set .options > .probe-add):
3464         (.popover .probe-popover):
3465         * UserInterface/Views/ProbeSetDataGrid.css:
3466         (.details-section.probe-set .data-grid tr.past-value td):
3467         (.details-section.probe-set .data-grid > td.unknown-value):
3468         (.details-section.probe-set .data-grid tr.revealed.highlighted):
3469         (.details-section.probe-set .data-grid tr.separator):
3470         (.details-section.probe-set .data-grid > tr.data-updated):
3471         (.details-section.probe-set .data-grid .selected .section *):
3472         (.details-section.probe-set .data-grid .selected td.unknown-value):
3473         (.details-section.probe-set .data-grid .section):
3474         * UserInterface/Views/QuickConsole.css:
3475         (.quick-console):
3476         * UserInterface/Views/TimelineDataGrid.css:
3477         (.data-grid.timeline th):
3478         (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
3479         * UserInterface/Views/TimelineRuler.css:
3480         (.timeline-ruler > .header):
3481         (.timeline-ruler > .header > .divider):
3482
3483 2014-08-11  Brent Fulgham  <bfulgham@apple.com>
3484
3485         [Win] Adjust build script for Windows production build.
3486         https://bugs.webkit.org/show_bug.cgi?id=135806
3487         <rdar://problem/17978299>
3488
3489         Reviewed by Timothy Hatcher.
3490
3491         * WebInspectorUI.vcxproj/WebInspectorUI.make: Make sure target for
3492         xcopy operation exists.
3493         * WebInspectorUI.vcxproj/WebInspectorUI.proj: Don't create directories
3494         we don't need, make sure the target location exists before we build.
3495         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Make sure that
3496         production builds get the intermediary command files from the
3497         right place.
3498
3499 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3500
3501         Web Inspector: Add a helper to avoid leaking single-fire event listeners in Promise chains
3502         https://bugs.webkit.org/show_bug.cgi?id=135772
3503
3504         Reviewed by Timothy Hatcher.
3505
3506         A common pattern when working with promise chains is to convert an event
3507         handler into a promise by using a single-fire event listener with the
3508         resolve continuation as the callback. This is fine if the event fires;
3509         if it doesn't fire, then the event emitter permanently keeps a reference to the
3510         this-object and the callback.
3511
3512         This patch adds EventListener, a proxy object for events that can be manipulated
3513         from multiple promise callback functions. If a promise is rejected, the catch
3514         block can disconnect any event listeners set up earlier in the promise chain.
3515
3516         This patch also reimplements EventListenerSet to use multiple EventListeners,
3517         since they share the same logic to uniformly handle Inspector and DOM events.
3518
3519         Test: inspector/event-listener.html
3520         Test: inspector/event-listener-set.html
3521
3522         * UserInterface/Base/EventListener.js: Added.
3523         (WebInspector.EventListener):
3524         (WebInspector.EventListener.prototype.this._callback):
3525         (WebInspector.EventListener.prototype.connect):
3526         (WebInspector.EventListener.prototype.disconnect):
3527         * UserInterface/Base/EventListenerSet.js: Update license block.
3528         (WebInspector.EventListenerSet.prototype.register):
3529         (WebInspector.EventListenerSet.prototype.install):
3530         (WebInspector.EventListenerSet.prototype.uninstall):
3531         * UserInterface/Main.html: Include EventListener.
3532         * UserInterface/Test.html: Include EventListener and EventListenerSet.
3533
3534 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3535
3536         Web Inspector: new glyphs are visible on OS X 10.9 builds
3537         https://bugs.webkit.org/show_bug.cgi?id=135743
3538
3539         Reviewed by Joseph Pecoraro.
3540
3541         * UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
3542         * UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
3543         * UserInterface/Images/Legacy/UserInputResult.svg: Removed.
3544         Removed images that were not used.
3545
3546         * UserInterface/Views/DashboardContainerView.css:
3547         (body.mac-platform.legacy .dashboard-container .advance-arrow):
3548         * UserInterface/Views/DebuggerDashboardView.js:
3549         (WebInspector.DebuggerDashboardView):
3550         * UserInterface/Views/FolderIcon.css:
3551         (body.mac-platform.legacy .folder-icon .icon):
3552         * UserInterface/Views/HierarchicalPathComponent.css:
3553         (body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):
3554         * UserInterface/Views/LogContentView.js:
3555         (WebInspector.LogContentView):
3556         Use legacy images.
3557
3558         * UserInterface/Views/NavigationSidebarPanel.css:
3559         (.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
3560         Fix color for selected subtitle.
3561
3562         * UserInterface/Views/TimelineSidebarPanel.js:
3563         (WebInspector.TimelineSidebarPanel):
3564         Use legacy images.
3565
3566 2014-08-09  Brian J. Burg  <burg@cs.washington.edu>
3567
3568         Web Inspector: TimelineManager should reuse empty recordings
3569         https://bugs.webkit.org/show_bug.cgi?id=135749
3570
3571         Reviewed by Timothy Hatcher.
3572
3573         Check whether the recording is empty before creating a new one.
3574
3575         * UserInterface/Controllers/TimelineManager.js:
3576         (WebInspector.TimelineManager.prototype._loadNewRecording):
3577         * UserInterface/Models/TimelineRecording.js:
3578         (WebInspector.TimelineRecording.prototype.isEmpty):
3579         (WebInspector.TimelineRecording.prototype.unloaded):
3580
3581 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3582
3583         Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
3584         https://bugs.webkit.org/show_bug.cgi?id=135726
3585
3586         Reviewed by Timothy Hatcher.
3587
3588         Added a flag for debugging inspector tests which will synchronously log messages.
3589         This avoids failure modes that prevent logging from being added to the test page.
3590
3591         * UserInterface/Base/Test.js:
3592         (InspectorTest.debugLog):
3593         (InspectorTest.addResult):
3594
3595 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3596
3597         Web Inspector: When Switching Recordings, the UI datagrids do not update to match selection
3598         https://bugs.webkit.org/show_bug.cgi?id=135764
3599
3600         Reviewed by Timothy Hatcher.
3601
3602         * UserInterface/Views/TimelineSidebarPanel.js:
3603         When changing the activeContentView trigger an update of the datagrids by
3604         re-applying the filter, which will be different now that the view is different.
3605
3606 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3607
3608         Web Inspector: Uncaught Exception opening Web Inspector - TypeError: undefined is not a function - candidateObjectCookie.every
3609         https://bugs.webkit.org/show_bug.cgi?id=135762
3610
3611         Reviewed by Timothy Hatcher.
3612
3613         * UserInterface/Views/NavigationSidebarPanel.js:
3614         (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
3615         Fix a typo, the wrong object was being used.
3616
3617 2014-08-07  Brian J. Burg  <burg@cs.washington.edu>
3618
3619         REGRESSION(r172094): timeline views are blank after reloading in some situations
3620         https://bugs.webkit.org/show_bug.cgi?id=135742
3621
3622         Reviewed by Timothy Hatcher.
3623
3624         Address various bugs that cause the wrong timeline content views to appear when
3625         starting a recording by reloading the inspected page. Fix other small oversights
3626         that were encountered in the sidebar-based view state restoration code.
3627
3628         * UserInterface/Models/TimelineRecording.js:
3629         (WebInspector.TimelineRecording.prototype.saveIdentityToCookie): Add a dummy implementation.
3630
3631         * UserInterface/Views/NavigationSidebarPanel.js:
3632         (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
3633         This code erroneously matches any tree element whose represented object's
3634         saveIdentityToCookie function produces an empty cookie.
3635
3636         * UserInterface/Views/TimelineContentView.js:
3637         (WebInspector.TimelineContentView.prototype._showTimelineView): Add an assertion
3638         that will find mismatches between represented objects of the TimelineContentView
3639         and TimelineViews.
3640
3641         * UserInterface/Views/TimelineSidebarPanel.js:
3642         (WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie): Don't call
3643         the superclass's implementation, since we do not want to perform a relaxed match
3644         against any of our tree elements. The only thing that can be restored across reopen
3645         is a selected timeline tree element, which is already handled by this override.
3646
3647 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3648
3649         Web Inspector: Fix accidental always true comparison
3650         https://bugs.webkit.org/show_bug.cgi?id=135741
3651
3652         Reviewed by Timothy Hatcher.
3653
3654         Remove accidental "!" that would always cause this comparison to succeed.
3655
3656         * UserInterface/Views/OverviewTimelineView.js:
3657         (WebInspector.OverviewTimelineView.prototype.updateLayout):
3658
3659 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3660
3661         Web Inspector: Timeline Filter Bars are not appearing at all
3662         https://bugs.webkit.org/show_bug.cgi?id=135740
3663
3664         Reviewed by Timothy Hatcher.
3665
3666         * UserInterface/Views/TimelineDataGrid.css:
3667         (.data-grid.timeline.has-non-default-filter > .navigation-bar-container):
3668         (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
3669         (body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar):
3670         Update the positioning and height for non-legacy because the console is now taller.
3671
3672         * UserInterface/Views/ScopeBar.js:
3673         (WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):
3674         Helper to know if there is a non-default filter.
3675
3676         * UserInterface/Views/TimelineDataGrid.js:
3677         (WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
3678         (WebInspector.TimelineDataGrid.prototype._scopeBarSelectedItemsDidChange):
3679         Update scope bar visibility. If non-default we want to always show it.
3680         
3681         (WebInspector.TimelineDataGrid.prototype._updateScopeBarForcedVisibility):
3682         If there is a non-default filter, force showing the bar.
3683
3684 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3685
3686         Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector
3687         https://bugs.webkit.org/show_bug.cgi?id=135745
3688
3689         Reviewed by Timothy Hatcher.
3690
3691         When restoring breakpoints when the inspector is initializing, do not
3692         let setting these breakpoints automatically enable breakpoints. We should
3693         respect the setting in this case.
3694
3695         * UserInterface/Controllers/DebuggerManager.js:
3696         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
3697         (WebInspector.DebuggerManager):
3698
3699 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3700
3701         Web Inspector: Combine and minify Esprima
3702         https://bugs.webkit.org/show_bug.cgi?id=135728
3703
3704         Reviewed by Joseph Pecoraro.
3705
3706         * Scripts/combine-resources.pl:
3707         * Scripts/copy-user-interface-resources.pl:
3708         * UserInterface/External/Esprima/LICENSE: Added.
3709
3710 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3711
3712         Fix regression where tree outline keyboard navigation is broken.
3713
3714         https://bugs.webkit.org/show_bug.cgi?id=135718
3715
3716         Reviewed by Joseph Pecoraro.
3717
3718         * UserInterface/Views/TreeOutline.js:
3719         (TreeElement.prototype.revealed): Fix the check for currentAncestor.hidden.
3720
3721 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3722
3723         Web Inspector: Filter bar text and icon are positioned too low and tight
3724         https://bugs.webkit.org/show_bug.cgi?id=135723
3725
3726         Reviewed by Joseph Pecoraro.
3727
3728         * UserInterface/Views/FilterBar.css:
3729         (.filter-bar > input[type="search"]):
3730         (.filter-bar > input[type="search"]::-webkit-search-decoration):
3731         * UserInterface/Views/SearchBar.css:
3732         (.search-bar > input[type="search"]):
3733
3734 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3735
3736         Web Inspector: Dashboard error and warning icons should be filled when enabled
3737         https://bugs.webkit.org/show_bug.cgi?id=135725
3738
3739         Reviewed by Joseph Pecoraro.
3740
3741         * UserInterface/Images/ErrorsEnabled.svg:
3742         * UserInterface/Images/IssuesEnabled.svg:
3743
3744 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3745
3746         Web Inspector: Dashboard contents shift when window changes active state
3747         https://bugs.webkit.org/show_bug.cgi?id=135724
3748
3749         Reviewed by Timothy Hatcher.
3750
3751         The container was getting a 1px border when inactive and none when active.
3752         Give it a transparent border when active so contents don't change size.
3753
3754         * UserInterface/Views/DashboardContainerView.css:
3755         (.toolbar .dashboard-container):
3756
3757 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3758
3759         Fix reference to missing CloseTimeline.svg image.
3760
3761         Rubber-stamped by Joseph Pecoraro.
3762
3763         * UserInterface/Views/TimelineSidebarPanel.js:
3764         (WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Use CloseLarge.svg instead.
3765
3766 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
3767
3768         [Win] Unreviewed build fix.
3769
3770         Add a WebInspectorUI.proj file for use with MSBuild utility.
3771
3772         * WebInspectorUI.vcxproj/WebInspectorUI.proj: Added.
3773
3774 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3775
3776         Get rid of INPUT_SPEECH
3777         https://bugs.webkit.org/show_bug.cgi?id=135672
3778
3779         Reviewed by Andreas Kling.
3780
3781         * UserInterface/Models/CSSKeywordCompletions.js:
3782
3783 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3784
3785         Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected
3786         https://bugs.webkit.org/show_bug.cgi?id=135372
3787
3788         Reviewed by Timothy Hatcher.
3789
3790         Constrain move selection window dragging to the ruler bounds
3791         based on the mouse down position on the drag window.
3792
3793         * UserInterface/Views/TimelineRuler.js:
3794         (WebInspector.TimelineRuler.prototype._handleMouseDown):
3795         (WebInspector.TimelineRuler.prototype._handleMouseMove):
3796         (WebInspector.TimelineRuler.prototype._handleMouseUp):
3797
3798 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3799
3800         Web Inspector: Update glyphs to be more like Xcode 6
3801         https://bugs.webkit.org/show_bug.cgi?id=135705
3802
3803         Reviewed by Joseph Pecoraro.
3804
3805         * Localizations/en.lproj/localizedStrings.js: Updated.
3806
3807         * UserInterface/Base/ImageUtilities.js:
3808         (platformImagePath): Added.
3809         (generateEmbossedImages.generateImage):
3810         Bump the base image version. Helper function. Use isLegacyMacOS.
3811
3812         * UserInterface/Base/Main.js:
3813         (WebInspector.contentLoaded):
3814         (WebInspector._updateDockNavigationItems):
3815         (WebInspector._generateDisclosureTriangleImages):
3816         Use new images and add legacy path. Remove the shadow.
3817
3818         * UserInterface/Images: Updated images.
3819         * UserInterface/Images/Legacy: Added. Moved legacy images here.
3820
3821         * UserInterface/Views/CSSStyleDeclarationSection.css:
3822         (.style-declaration-section):
3823         (body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
3824         (.style-declaration-section.last-in-group):
3825         (.style-declaration-section.last-in-group + .style-declaration-section):
3826         Use a consistent gray for borders.
3827
3828         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
3829         (.sidebar > .panel.details.css-style > .content > .pseudo-classes):
3830         Use a consistent gray for borders.
3831
3832         * UserInterface/Views/ContentBrowser.js:
3833         (WebInspector.ContentBrowser):
3834         Use new images and add legacy path.
3835
3836         * UserInterface/Views/ControlToolbarItem.css:
3837         (.toolbar .item.control):
3838         (body.mac-platform.legacy .toolbar .item.control):
3839         (.toolbar .item.control:hover):
3840         (body.mac-platform.legacy .toolbar .item.control:hover):
3841         Adjust the opacity for controls.
3842
3843         * UserInterface/Views/DOMTreeContentView.js:
3844         (WebInspector.DOMTreeContentView):
3845         Use new images and add legacy path.
3846
3847         * UserInterface/Views/DataGrid.css:
3848         (.data-grid tr.selected):
3849         Use a consistent gray for borders.
3850
3851         * UserInterface/Views/DataGrid.js:
3852         (WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
3853         Use new images and add legacy path. Remove the shadow.
3854
3855         * UserInterface/Views/DebuggerSidebarPanel.js:
3856         (WebInspector.DebuggerSidebarPanel):
3857         Use new images and add legacy path.
3858
3859         * UserInterface/Views/DefaultDashboardView.css:
3860         (.toolbar .dashboard.default > .item):
3861         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3862         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img):
3863         (body.mac-platform.legacy .toolbar .dashboard.default > .time > img):
3864         (body.mac-platform.legacy .toolbar .dashboard.default > .logs > img):
3865         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesSize > img):