Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2016-09-27  Matt Baker  <mattbaker@apple.com>
2
3         Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
4         https://bugs.webkit.org/show_bug.cgi?id=162572
5         <rdar://problem/28479562>
6
7         Reviewed by Brian Burg.
8
9         Improve NavigationSidebarPanel logic for coordinating selection between trees.
10         When tree selection changes, the most recent selection should be restored
11         the next time the tree is focused.
12
13         The sidebar should also handle focusing a tree for the first time, in
14         which no previous selection exists, and focusing a tree that has had its
15         previous selection filtered out (hidden).
16
17         * UserInterface/Views/NavigationSidebarPanel.js:
18         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus):
19         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
20         Restoring the last deselected element, instead of the last selected element
21         only works when the selection is moving from one tree to another. When
22         the elements belong to the same tree the newly selected element won't
23         be saved until the next selection change. If the window loses and regains
24         the focus before then, the tree will restore the previous selection,
25         effectively reverting the last selection change.
26
27 2016-09-27  Tomas Popela  <tpopela@redhat.com>
28
29         [GTK] Mac defaults are used for key shortcuts on Linux
30         https://bugs.webkit.org/show_bug.cgi?id=162564
31
32         Don't set Mac's default keymap as a fallthrough for CodeMirror when we
33         are not on Mac.
34
35         Reviewed by Carlos Garcia Campos.
36
37         * UserInterface/Test.html: Include Platform.js for the
38         WebInspector.Platform definition.
39         * UserInterface/Views/CodeMirrorAdditions.js:
40
41 2016-09-26  Matt Baker  <mattbaker@apple.com>
42
43         Web Inspector: Box Model values not updated when DOM node styles change
44         https://bugs.webkit.org/show_bug.cgi?id=162525
45
46         Reviewed by Brian Burg.
47
48         The Box Model section should refresh itself when the selected node's
49         computed style changes. This is necessary since the Styles sidebar
50         doesn't always refresh its sections on node changes.
51
52         * UserInterface/Views/BoxModelDetailsSectionRow.js:
53         (WebInspector.BoxModelDetailsSectionRow.prototype.set nodeStyles):
54         Refresh metrics whenever the computed style changes.
55
56         (WebInspector.BoxModelDetailsSectionRow.prototype._getBox):
57         (WebInspector.BoxModelDetailsSectionRow.prototype._getComponentSuffix):
58         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createValueElement):
59         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
60         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
61         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):
62         Drive-by cleanup to make this large function easier to read.
63         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement): Deleted.
64         Renamed createValueElement.
65         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaWidthElement): Deleted.
66         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaHeightElement): Deleted.
67         Combined these into a single function taking a property name (width or height).
68
69 == Rolled over to ChangeLog-2016-09-26 ==