be7e506bff6c124d9ffd2e86595153acaf1d7e58
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2019-06-17  Devin Rousso  <drousso@apple.com>
2
3         Web Inspector: Sources: searching doesn't use the case sensitive or regex global settings
4         https://bugs.webkit.org/show_bug.cgi?id=198897
5
6         Reviewed by Joseph Pecoraro.
7
8         * UserInterface/Views/SourceCodeTextEditor.js:
9         (WI.SourceCodeTextEditor.prototype.customPerformSearch):
10
11 2019-06-13  Devin Rousso  <drousso@apple.com>
12
13         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
14         https://bugs.webkit.org/show_bug.cgi?id=198806
15
16         Reviewed by Joseph Pecoraro.
17
18         * UserInterface/Workers/Formatter/CSSFormatter.js:
19         (CSSFormatter.prototype._format):
20         Add more specific tests for at-rules, and add/remove whitespace depending on the type of
21         at-rule (e.g. `@supports` vs `@media`), as well as where the scanner is in the parameters of
22         the at at-rule (e.g. `@supports |` vs `@media (|`).
23
24         * UserInterface/Workers/Formatter/FormatterContentBuilder.js:
25         (FormatterContentBuilder):
26         (FormatterContentBuilder.prototype.get lastToken): Added.
27         (FormatterContentBuilder.prototype.get currentLine):
28         (FormatterContentBuilder.prototype.removeLastNewline):
29         (FormatterContentBuilder.prototype.removeLastWhitespace):
30         (FormatterContentBuilder.prototype._popFormattedContent):
31         (FormatterContentBuilder.prototype._append):
32         Update `lastTokenWasNewline` and `lastTokenWasWhitespace` when removing newlines/whitespace.
33         Memoize the `currentLine` so it's less expensive to re-fetch.
34
35 2019-06-13  Devin Rousso  <drousso@apple.com>
36
37         Web Inspector: Settings: indent type and size settings aren't respected everywhere
38         https://bugs.webkit.org/show_bug.cgi?id=198804
39
40         Reviewed by Timothy Hatcher.
41
42         * UserInterface/Views/CodeMirrorEditor.js:
43         (WI.CodeMirrorEditor.create):
44         When creating a `CodeMirror` instance, default to using the global `Setting`s as the options.
45         If an override is specified in `options`, it will take precedence and the `CodeMirror` will
46         ignore any changes to the `Setting` as well.
47
48         * UserInterface/Views/TextEditor.js:
49         (WI.TextEditor):
50         (WI.TextEditor.prototype.close): Deleted.
51
52         * UserInterface/Views/AuditTestCaseContentView.js:
53         (WI.AuditTestCaseContentView.prototype.layout):
54         * UserInterface/Views/BreakpointActionView.js:
55         (WI.BreakpointActionView.prototype._updateBody):
56         * UserInterface/Views/ConsolePrompt.js:
57         (WI.ConsolePrompt):
58         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
59         (WI.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
60         Remove overrides that aren't necessary for `CodeMirror` to fit in the container element:
61          - `showWhitespaceCharacters`
62          - `indentWithTabs`
63          - `indentUnit`
64
65         * UserInterface/Views/SourceCodeTextEditor.js:
66         (WI.SourceCodeTextEditor.prototype.close):
67         * UserInterface/Views/ShaderProgramContentView.js:
68         (WI.ShaderProgramContentView.prototype.closed): Deleted.
69         * UserInterface/Views/TextContentView.js:
70         (WI.TextContentView.prototype.closed): Deleted.
71         * UserInterface/Views/TextResourceContentView.js:
72         (WI.TextResourceContentView.prototype.closed):
73         Delete the logic for removing event listeners from global `Setting`, as it didn't work
74         anyways, since none of the event listeners were added using a `thisObject`.
75
76 2019-06-13  Devin Rousso  <drousso@apple.com>
77
78         Web Inspector: Settings: sticky header disappears when over scrolling
79         https://bugs.webkit.org/show_bug.cgi?id=198833
80
81         Reviewed by Joseph Pecoraro.
82
83         * UserInterface/Views/SettingsTabContentView.css:
84         (.content-view.settings .navigation-bar):
85         (.content-view.settings > .settings-view): Added.
86         (.content-view.settings): Deleted.
87
88 2019-06-10  Devin Rousso  <drousso@apple.com>
89
90         Web Inspector: Timelines: imported recordings do not have JavaScript call trees
91         https://bugs.webkit.org/show_bug.cgi?id=197490
92         <rdar://problem/50589158>
93
94         Reviewed by Joseph Pecoraro.
95
96         * UserInterface/Models/TimelineRecording.js:
97         (WI.TimelineRecording.prototype.initializeCallingContextTrees):
98         Make sure to actually save the provided stack traces and samples in the export data.
99
100         * UserInterface/Models/ScriptTimelineRecord.js:
101         (WI.ScriptTimelineRecord.fromJSON):
102         (WI.ScriptTimelineRecord.prototype.toJSON):
103         Drive-by: include `extraDetails`, which contains useful information like "default prevented".
104
105 2019-06-10  Nikita Vasilyev  <nvasilyev@apple.com>
106
107         REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work
108         https://bugs.webkit.org/show_bug.cgi?id=198508
109         <rdar://problem/51375503>
110
111         Reviewed by Matt Baker.
112
113         It didn't work because the detached sidebar panel tried to access its parent view (this.parentSidebar).
114
115         * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
116         (WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Added.
117         (WI.ComputedStyleDetailsSidebarPanel):
118         * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
119         (WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Deleted.
120         Move computedStyleDetailsPanelShowProperty to ComputedStyleDetailsSidebarPanel since it's the only
121         panel where it's needed.
122
123 2019-06-10  Alexey Shvayka  <shvaikalesh@gmail.com>
124
125         Web Inspector: "Copy Path to Property" doesn't work with multiline keys
126         https://bugs.webkit.org/show_bug.cgi?id=198691
127
128         Reviewed by Matt Baker.
129
130         Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.
131
132         * UserInterface/Base/Utilities.js: Use JSON.stringify.
133
134 2019-06-10  Devin Rousso  <drousso@apple.com>
135
136         Web Inspector: REGRESSION(r246025): prototypes in object previews are visible even when setting `showOnlyJSON`
137         https://bugs.webkit.org/show_bug.cgi?id=198721
138
139         Reviewed by Joseph Pecoraro.
140
141         * UserInterface/Views/ObjectTreeView.css:
142         (.object-tree.properties-only.json-only .object-tree-property.prototype-property): Added.
143         (.object-tree.properties-only.json-only .object-tree-property .prototype-property): Deleted.
144
145 2019-06-07  Nikita Vasilyev  <nvasilyev@apple.com>
146
147         Web Inspector: longhand CSS properties overridden by shorthands miss strikethrough
148         https://bugs.webkit.org/show_bug.cgi?id=198629
149         <rdar://problem/51504160>
150
151         Reviewed by Devin Rousso.
152
153         Longhand CSS properties (e.g. "font-size") overriden by shorthands (e.g. "font") now have strikethroughs.
154
155         * UserInterface/Models/CSSProperty.js:
156         (WI.CSSProperty.prototype.set overridingProperty):
157         (WI.CSSProperty):
158
159         * UserInterface/Models/DOMNodeStyles.js:
160         (WI.DOMNodeStyles.prototype._updateStyleCascade):
161         Call _associateRelatedProperties before _markOverriddenProperties because
162         _associateRelatedProperties sets relatedShorthandProperty property, which
163         is now used by _markOverriddenProperties.
164
165         (WI.DOMNodeStyles.prototype._markOverriddenProperties.isOverriddenBy):
166         (WI.DOMNodeStyles.prototype._markOverriddenProperties):
167
168 2019-06-06  Devin Rousso  <drousso@apple.com>
169
170         Web Inspector: Timelines: remove always disabled details sidebar navigation item
171         https://bugs.webkit.org/show_bug.cgi?id=198393
172
173         Reviewed by Timothy Hatcher.
174
175         * UserInterface/Views/TimelineTabContentView.js:
176         (WI.TimelineTabContentView):
177
178 2019-06-06  Devin Rousso  <drousso@apple.com>
179
180         Web Inspector: REGRESSION(r245833): Timelines: CPU: JavaScript label is missing and JavaScript section of pie chart is black
181         https://bugs.webkit.org/show_bug.cgi?id=198627
182
183         Reviewed by Joseph Pecoraro.
184
185         * UserInterface/Views/CPUTimelineView.js:
186         (WI.CPUTimelineView.displayNameForSampleType):
187         * UserInterface/Views/CPUTimelineView.css:
188         (.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-javascript):
189         (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-javascript): Added.
190         (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-script): Deleted.
191         * UserInterface/Views/CPUUsageCombinedView.css:
192         (.cpu-usage-combined-view > .graph > .range-chart .sample-type-javascript): Added.
193         (.cpu-usage-combined-view > .graph > .range-chart .sample-type-script): Deleted.
194         Use the enum string added in r245833 (`sample-type-javascript`) instead of what was there
195         before (`sample-type-script`).
196
197         * UserInterface/Views/Variables.css:
198         (:root):
199         Rename `--cpu-script-*` to `--cpu-javascript-*`.
200
201 2019-06-06  Devin Rousso  <drousso@apple.com>
202
203         Web Inspector: Formatter: pretty-print CSS using a Worker
204         https://bugs.webkit.org/show_bug.cgi?id=197829
205         <rdar://problem/36891532>
206
207         Reviewed by Timothy Hatcher.
208
209         * UserInterface/Proxies/FormatterWorkerProxy.js:
210         (WI.FormatterWorkerProxy.prototype.formatCSS): Added.
211         * UserInterface/Workers/Formatter/FormatterWorker.js:
212         (FormatterWorker.prototype.formatCSS): Added.
213         * UserInterface/Workers/Formatter/CSSFormatter.js: Added.
214         (CSSFormatter):
215         (CSSFormatter.prototype.get success):
216         (CSSFormatter.prototype.get formattedText):
217         (CSSFormatter.prototype.get sourceMapData):
218         (CSSFormatter.prototype._format):
219
220         * UserInterface/Workers/Formatter/FormatterContentBuilder.js:
221         (FormatterContentBuilder.prototype.get currentLine): Added.
222
223         * UserInterface/Views/TextEditor.js:
224         (WI.TextEditor.prototype._canUseFormatterWorker):
225         (WI.TextEditor.prototype._startWorkerPrettyPrint):
226
227         * .eslintrc:
228
229 2019-06-06  Devin Rousso  <drousso@apple.com>
230
231         Web Inspector: Elements: print/rulers/compositing/paint navigation items shouldn't be visible if the inspected target doesn't have a PageAgent
232         https://bugs.webkit.org/show_bug.cgi?id=198410
233
234         Reviewed by Timothy Hatcher.
235
236         * UserInterface/Views/DOMTreeContentView.js:
237         (WI.DOMTreeContentView):
238         (WI.DOMTreeContentView.prototype.get navigationItems):
239         (WI.DOMTreeContentView.prototype._showRulersChanged):
240
241 == Rolled over to ChangeLog-2019-06-05 ==