Web Inspector: IndexedDB data not showing for MDN example page
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-06-11  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: IndexedDB data not showing for MDN example page
4         https://bugs.webkit.org/show_bug.cgi?id=145851
5
6         Reviewed by Anders Carlsson.
7
8         * UserInterface/Views/StorageSidebarPanel.js:
9         (WebInspector.StorageSidebarPanel.prototype._indexedDatabaseWasAdded):
10         Fix typo in Storage tab refactoring that was causing an
11         uncaught exception and not showing Indexed DBs.
12
13 2015-06-11  Devin Rousso  <drousso@apple.com>
14
15         Web Inspector: font-family names interpreted as color
16         https://bugs.webkit.org/show_bug.cgi?id=123468
17
18         Reviewed by Timothy Hatcher.
19
20         * UserInterface/Views/CodeMirrorAdditions.js: Added logic to prevent color picker buttons from appearing before colors that come after a quote character (both " and ').
21
22 2015-06-11  Matt Baker  <mattbaker@apple.com>
23
24         Web Inspector: Rendering Frames timeline should distinguish between layout and painting
25         https://bugs.webkit.org/show_bug.cgi?id=145856
26
27         Reviewed by Timothy Hatcher.
28
29         This patch formalizes the runloop task concept in the frontend, adds new Paint task type to the Rendering
30         Frames timeline, and reorders UI elements such as chart sections and frame "segments" to match the order in
31         which tasks are executed within the runloop.
32
33         We will need to make UI changes to the standard Timelines view in a follow up patch, since tree element icons
34         for Paint records now use a different color that those of other Layout records.
35
36         * UserInterface/Images/TimelineRecordPaint.svg:
37         Changed to use green color.
38
39         * UserInterface/Models/RenderingFrameTimelineRecord.js:
40         (WebInspector.RenderingFrameTimelineRecord):
41         (WebInspector.RenderingFrameTimelineRecord.displayNameForTaskType):
42         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
43         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.set return):
44         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask):
45         (WebInspector.RenderingFrameTimelineRecord.prototype.get durationRemainder): Deleted.
46         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForRecords.get var): Deleted.
47         Added TaskType enum to decouple runloop task types from timeline record types, and removed duration remainder
48         support now that "Other" has an associated task type.
49
50         * UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
51         (WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
52         (WebInspector.RenderingFrameTimelineDataGridNode.prototype.createCellContent):
53         * UserInterface/Views/RenderingFrameTimelineView.js:
54         (WebInspector.RenderingFrameTimelineView):
55         Added new grid column for Paint task, reordered columns to be consistent with the rest of the UI.
56
57         * UserInterface/Views/TimelineRecordFrame.css:
58         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-script):
59         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-layout):
60         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-paint):
61         (.timeline-record-frame > .frame > .duration): Deleted.
62         (.timeline-record-frame > .frame > .duration.timeline-record-type-network): Deleted.
63         (.timeline-record-frame > .frame > .duration.timeline-record-type-layout): Deleted.
64         (.timeline-record-frame > .frame > .duration.timeline-record-type-script): Deleted.
65         Updated styles for Render Frame tasks.
66
67         * UserInterface/Views/TimelineRecordFrame.js:
68         (WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
69         Updated to use Render Frame task types. Frame segment insertion order is now consistent with the rest of the UI.
70
71         * UserInterface/Views/TimelineSidebarPanel.js:
72         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.chartData.Object.keys.map):
73         (WebInspector.TimelineSidebarPanel.set this):
74         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.get this):
75         (WebInspector.TimelineSidebarPanel): Deleted.
76         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart.durationForRecordType): Deleted.
77         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart): Deleted.
78         Updated to use Render Frame task types.
79
80 2015-06-11  Matt Baker  <mattbaker@apple.com>
81
82         Web Inspector: Wrong overview graph shown after switching from Frames to Timelines
83         https://bugs.webkit.org/show_bug.cgi?id=145778
84
85         Reviewed by Timothy Hatcher.
86
87         TimelineSidebarPanel stores a reference to the selected timeline before switching to the Rendering Frames view,
88         which is used to restore the tree selection, overview graph, and content views when switching back to the
89         standard Timelines view. However if another recording is created before switching, the previously selected
90         timeline tracked by the sidebar cannot be restored, since it doesn't belong to the active recording.
91
92         This is addressed by storing the previously selected timeline type, rather than the timeline object itself.
93         The type is also updated whenever the selected timeline in the tree outline changes, ensuring that the correct
94         timeline will always be restored.
95
96         * UserInterface/Views/TimelineSidebarPanel.js:
97         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
98         (WebInspector.TimelineSidebarPanel.get else): Deleted.
99         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if): Deleted.
100         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject): Deleted.
101
102 2015-06-08  Matt Baker  <mattbaker@apple.com>
103
104         Web Inspector: Clearing active Timeline recording should stop capturing
105         https://bugs.webkit.org/show_bug.cgi?id=145767
106
107         Reviewed by Joseph Pecoraro.
108
109         * UserInterface/Views/TimelineRecordingContentView.js:
110         (WebInspector.TimelineRecordingContentView.prototype._clearTimeline):
111         Stop capturing if necessary.
112
113 2015-06-07  Tobias Reiss  <tobi+webkit@basecode.de>
114
115         Web Inspector: Add PrettyPrinter CSSRule tests
116         https://bugs.webkit.org/show_bug.cgi?id=145740
117
118         Reviewed by Brian Burg.
119
120         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon-expected.css: Added.
121         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon.css: Added.
122         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma-expected.css: Added.
123         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma.css: Added.
124         * Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon-expected.css: Added.
125         * Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon.css: Added.
126         * Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed-expected.css: Added.
127         * Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed.css: Added.
128         * Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value-expected.css: Added.
129         * Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value.css: Added.
130         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon-expected.css: Added.
131         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon.css: Added.
132         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment-expected.css: Added.
133         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment.css: Added.
134         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property-expected.css: Added.
135         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property.css: Added.
136         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property-expected.css: Added.
137         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property.css: Added.
138         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property-expected.css: Added.
139         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property.css: Added.
140         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon-expected.css: Added.
141         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon.css: Added.
142         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment-expected.css: Added.
143         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment.css: Added.
144         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property-expected.css: Added.
145         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property.css: Added.
146         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property-expected.css: Added.
147         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property.css: Added.
148         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property-expected.css: Added.
149         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property.css: Added.
150         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment-expected.css: Added.
151         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment.css: Added.
152         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property-expected.css: Added.
153         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property.css: Added.
154         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property-expected.css: Added.
155         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property.css: Added.
156         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property-expected.css: Added.
157         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property.css: Added.
158         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment-expected.css: Added.
159         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment.css: Added.
160         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property-expected.css: Added.
161         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property.css: Added.
162         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property-expected.css: Added.
163         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property.css: Added.
164         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property-expected.css: Added.
165         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property.css: Added.
166         * Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property-expected.css: Added.
167         * Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property.css: Added.
168
169 2015-06-05  Devin Rousso  <drousso@apple.com>
170
171         Web Inspector: Fixing code style and adding more limitations for bug 141262
172         https://bugs.webkit.org/show_bug.cgi?id=145668
173
174         Reviewed by Timothy Hatcher.
175
176         * UserInterface/Models/CSSCompletions.js:
177         (WebInspector.CSSCompletions.prototype.isValidPropertyName): Loops through the full property list and returns true only if a property exactly matches the given property name.
178         (WebInspector.CSSCompletions): Added isValidPropertyName function.
179         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
180         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property and to prevent invalid style from being applied incorrectly.
181
182 2015-06-05  Devin Rousso  <drousso@apple.com>
183
184         Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections
185         https://bugs.webkit.org/show_bug.cgi?id=145399
186
187         Reviewed by Timothy Hatcher.
188
189         * UserInterface/Views/CSSStyleDeclarationSection.js:
190         (WebInspector.CSSStyleDeclarationSection): Added delegate variable to constructor.
191         (WebInspector.CSSStyleDeclarationSection.prototype.clearSelection):
192         (WebInspector.CSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorFocused):
193         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
194         (WebInspector.CSSStyleDeclarationTextEditor): Added event listener to codeMirror on "focus".
195         (WebInspector.CSSStyleDeclarationTextEditor.prototype.clearSelection): Sets the cursor of the codeMirror to character 0 on line 0.
196         (WebInspector.CSSStyleDeclarationTextEditor.prototype._editorFocused): Function that calls the delegate function "editorFocused" when the codeMirror is focused
197         * UserInterface/Views/RulesStyleDetailsPanel.js:
198         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
199         (WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorFocused): Loops through all sections except for the ignoredSection (parameter) and clears the selected text in each of them.
200
201 2015-06-05  Joseph Pecoraro  <pecoraro@apple.com>
202
203         REGRESSION (r185213): TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value')
204         https://bugs.webkit.org/show_bug.cgi?id=145695
205
206         Reviewed by Mark Lam.
207
208         Move and rename the clear log on reload setting property from
209         WebInspector (Main.js) to LogManager (shared with tests).
210
211         * UserInterface/Base/Main.js:
212         (WebInspector.loaded): Deleted.
213         * UserInterface/Controllers/LogManager.js:
214         (WebInspector.LogManager):
215         (WebInspector.LogManager.prototype._delayedMessagesCleared):
216         * UserInterface/Views/LogContentView.js:
217         (WebInspector.LogContentView.prototype._sessionStarted):
218         (WebInspector.LogContentView.prototype._handleContextMenuEvent):
219         (WebInspector.LogContentView.prototype._toggleClearLogOnReloadSetting):
220
221 2015-06-05  Nikita Vasilyev  <nvasilyev@apple.com>
222
223         Web Inspector: [REGRESSION] Dashboard's resource count does not reset when main resource navigates
224         https://bugs.webkit.org/show_bug.cgi?id=144553
225
226         Add missing _mainResourceDidChange, which was removed after switching to the tabs UI.
227
228         Reviewed by Timothy Hatcher.
229
230         * UserInterface/Models/DefaultDashboard.js:
231         (WebInspector.DefaultDashboard):
232         _waitingForFirstMainResourceToStartTrackingSize is not used anywhere, remove it.
233
234         (WebInspector.DefaultDashboard.prototype._mainResourceDidChange): Added.
235
236         (WebInspector.DefaultDashboard.prototype._resourceSizeDidChange): Removed.
237         Unused.
238
239 2015-06-05  Matt Baker  <mattbaker@apple.com>
240
241         Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
242         https://bugs.webkit.org/show_bug.cgi?id=145671
243
244         Reviewed by Timothy Hatcher.
245
246         * Localizations/en.lproj/localizedStrings.js:
247         "Idle" string no longer used.
248
249         * UserInterface/Views/TimelineRecordFrame.js:
250         Reduced maximum frame width by 2px.
251
252         * UserInterface/Views/TimelineSidebarPanel.js:
253         (WebInspector.TimelineSidebarPanel):
254         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
255         Added inner radius to chart and removed "Idle" value.
256
257 2015-06-04  Joseph Pecoraro  <pecoraro@apple.com>
258
259         Web Inspector: Class constructor appearing as Object Tree property does not include parameters
260         https://bugs.webkit.org/show_bug.cgi?id=145661
261
262         Reviewed by Timothy Hatcher.
263
264         * UserInterface/Protocol/RemoteObject.js:
265         (WebInspector.RemoteObject):
266         (WebInspector.RemoteObject.fromPrimitiveValue):
267         (WebInspector.RemoteObject.fromPayload):
268         (WebInspector.RemoteObject.prototype.get functionDescription):
269         Include the className as only use it for "class" types to override
270         the normal description string. Stash the actual function description
271         in a property we can access later.
272
273         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
274         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
275         Even if this property is a "class" we want to specifically parse it's
276         function description string. So use functionDescription.
277
278 2015-06-04  Nikita Vasilyev  <nvasilyev@apple.com>
279
280         Web Inspector: Close and open tabs on mouseup, not mousedown
281         https://bugs.webkit.org/show_bug.cgi?id=145656
282
283         Match Safari's behaviour.
284
285         Reviewed by Timothy Hatcher.
286
287         * UserInterface/Views/TabBar.js:
288         (WebInspector.TabBar):
289         (WebInspector.TabBar.prototype.set newTabItem):
290         (WebInspector.TabBar.prototype._handleMouseDown):
291         (WebInspector.TabBar.prototype._handleClick): Added.
292         (WebInspector.TabBar.prototype._handleMouseUp):
293         (WebInspector.TabBar.prototype._handleNewTabClick): Added.
294         (WebInspector.TabBar.prototype._handleMouseMoved):
295
296 2015-06-04  Nikita Vasilyev  <nvasilyev@apple.com>
297
298         Web Inspector: Decrease tabs height to match Safari's tabs height
299         https://bugs.webkit.org/show_bug.cgi?id=145647
300
301         Reviewed by Timothy Hatcher.
302
303         * UserInterface/Views/TabBar.css:
304         (.tab-bar):
305
306 2015-06-04  Tobias Reiss  <tobi+webkit@basecode.de>
307         
308         Web Inspector: Activity Viewer does not update on "Clear Log on reload"
309         https://bugs.webkit.org/show_bug.cgi?id=145466
310         
311         Reviewed by Joseph Pecoraro.
312
313         1. Isolate logic within LogManager and remove hacks/logic from all other files
314         2. Within LogManager: Differentiate "messagesCleared" calls
315          a) that happen as a result of a "requested clear" by Frontend (e.g. Button)
316          b) that happen on page reload and install "clear/keep-on-page-reload" logic
317          c) that happen on frame navigated, console.clear() or clear()
318         3. Unify "ActiveLogCleared" and "Cleared" events to "Cleared"
319         
320         For step 2b and 2c it is important to delay the handling and wait until
321         "_mainResourceDidChange" has determined whether a page reload happened or
322         not.
323         
324         * UserInterface/Base/Main.js:
325         (WebInspector.loaded):
326         Store "clear-log-on-reload" setting globally.
327         
328         * UserInterface/Controllers/IssueManager.js:
329         (WebInspector.IssueManager):
330         * UserInterface/Models/DefaultDashboard.js:
331         (WebInspector.DefaultDashboard): Deleted.
332         * UserInterface/Views/ObjectTreeView.js:
333         (WebInspector.ObjectTreeView.prototype._trackWeakEntries): Deleted.
334         (WebInspector.ObjectTreeView.prototype._untrackWeakEntries): Deleted.
335         (WebInspector.ObjectTreeView): Deleted.
336         Remove deleted events.
337         
338         * UserInterface/Controllers/JavaScriptLogViewController.js:
339         (WebInspector.JavaScriptLogViewController.prototype._handleClearShortcut):
340         (WebInspector.JavaScriptLogViewController.prototype.clear): Deleted.
341         Remove delegate function call and call LogManager directly.
342         
343         * UserInterface/Controllers/LogManager.js:
344         (WebInspector.LogManager):
345         (WebInspector.LogManager.prototype.messagesCleared):
346         (WebInspector.LogManager.prototype._delayedMessagesCleared):
347         (WebInspector.LogManager.prototype.requestClearMessages):
348         (WebInspector.LogManager.prototype._mainResourceDidChange):
349         Isolate "clear log" logic, especially clear/keep-log-on-reload logic.
350         
351         * UserInterface/Views/LogContentView.js:
352         (WebInspector.LogContentView):
353         (WebInspector.LogContentView.prototype._sessionStarted):
354         (WebInspector.LogContentView.prototype._handleContextMenuEvent):
355         (WebInspector.LogContentView.prototype._logCleared):
356         (WebInspector.LogContentView.prototype._toggleClearLogOnReloadSetting):
357         (WebInspector.LogContentView.prototype._clearLog):
358         (WebInspector.LogContentView.prototype.didClearMessages): Deleted.
359         (WebInspector.LogContentView.prototype._sessionsCleared): Deleted.
360         (WebInspector.LogContentView.prototype._activeLogCleared): Deleted.
361         (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages): Deleted.
362         Make it a consumer of LogManager and remove special hacks. Simplify code.
363
364 2015-06-03  Devin Rousso  <drousso@apple.com>
365
366         Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value
367         https://bugs.webkit.org/show_bug.cgi?id=141262
368
369         Reviewed by Timothy Hatcher.
370
371         * UserInterface/Models/CSSCompletions.js:
372         (WebInspector.CSSCompletions.prototype.nameMatchesValidPropertyExactly): Loops through the full property list and returns true only if a property exactly matches the given property name.
373         (WebInspector.CSSCompletions): Added nameMatchesValidPropertyExactly function.
374         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
375         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property.
376
377 2015-06-03  Nikita Vasilyev  <nvasilyev@apple.com>
378
379         Web Inspector: Search field bottom border doesn't match the rest of the toolbar
380         https://bugs.webkit.org/show_bug.cgi?id=145611
381
382         Reviewed by Timothy Hatcher.
383
384         * UserInterface/Views/Toolbar.css:
385         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
386
387 2015-06-03  Joseph Pecoraro  <pecoraro@apple.com>
388
389         Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar
390         https://bugs.webkit.org/show_bug.cgi?id=145589
391
392         Reviewed by Timothy Hatcher.
393
394         * UserInterface/Views/NavigationBar.js:
395         (WebInspector.NavigationBar.prototype._mouseDown):
396         (WebInspector.NavigationBar.prototype._mouseUp):
397         When mouse dragging for navigation bars, only match against navigation
398         bar items inside this navigation bar. Also, fix horizontal detection
399         of navigation bar items by scanning in the middle of the navigation
400         bar instead of the top, which missed the items.
401
402 2015-06-03  Joseph Pecoraro  <pecoraro@apple.com>
403
404         Web Inspector: Debugger Popover for Node object should have go-to-arrow to show the node in DOM tree
405         https://bugs.webkit.org/show_bug.cgi?id=145594
406
407         Reviewed by Timothy Hatcher.
408
409         * UserInterface/Controllers/DOMTreeManager.js:
410         (WebInspector.DOMTreeManager.prototype.inspectElement):
411         Previously we could get an exception later on if we tried to
412         inspect an element that was not in the DOM. Bail if the node
413         is not in the DOM or not.
414
415         * UserInterface/Views/SourceCodeTextEditor.css:
416         (.popover .debugger-popover-content > .title > .go-to-arrow):
417         * UserInterface/Views/SourceCodeTextEditor.js:
418         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject.data.pushNodeToFrontend):
419         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
420         For a node type, add a go-to-arrow in the popover if it is in the DOM or not.
421
422 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
423
424         Web Inspector: Remove uses of delete in Sidebar related code
425         https://bugs.webkit.org/show_bug.cgi?id=145592
426
427         Reviewed by Timothy Hatcher.
428
429         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
430         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
431         Clear value instead of deleting.
432
433         * UserInterface/Views/SearchSidebarPanel.js:
434         (WebInspector.SearchSidebarPanel.prototype.performSearch):
435         Just clear the search identifier. Also assert it (a required string) is always non-falsey.
436
437         * UserInterface/Views/Sidebar.js:
438         (WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
439         This entire callback is unnecessary because whenever we start
440         a drag we save the value.
441
442 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
443
444         Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
445         https://bugs.webkit.org/show_bug.cgi?id=145591
446
447         Reviewed by Timothy Hatcher.
448
449         * UserInterface/Views/Sidebar.js:
450         (WebInspector.Sidebar.prototype.removeSidebarPanel):
451         When removing a sidebar panel, ensure we call hidden if it was the visible panel.
452
453         * UserInterface/Views/SidebarPanel.js:
454         (WebInspector.SidebarPanel):
455         (WebInspector.SidebarPanel.prototype.shown):
456         (WebInspector.SidebarPanel.prototype.hidden):
457         Save and restore content element scroll position when sidebar panels are shown / hidden.
458
459         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
460         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):
461         * UserInterface/Views/ComputedStyleDetailsPanel.js:
462         (WebInspector.ComputedStyleDetailsPanel.prototype.shown):
463         * UserInterface/Views/DetailsSidebarPanel.js:
464         (WebInspector.DetailsSidebarPanel.prototype.shown):
465         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
466         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
467         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.hidden):
468         Cleanup. Since sidebar panels are using ES6 classes, have super class calls use `super`!
469
470 2015-06-02  Nikita Vasilyev  <nvasilyev@apple.com>
471
472         Web Inspector: Use non-monospace font for the frame selector
473         https://bugs.webkit.org/show_bug.cgi?id=145586
474
475         Reviewed by Timothy Hatcher.
476
477         * UserInterface/Views/HierarchicalPathComponent.css:
478         (.hierarchical-path-component):
479
480 2015-06-02  Nikita Vasilyev  <nvasilyev@apple.com>
481
482         Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
483         https://bugs.webkit.org/show_bug.cgi?id=145540
484
485         Also, increase clickable area of the arrow icon.
486
487         Reviewed by Timothy Hatcher.
488
489         * UserInterface/Views/DashboardContainerView.css:
490         (.dashboard-container .advance-arrow):
491         (.dashboard-container .advance-arrow.advance-forward):
492         (.dashboard-container .advance-arrow.advance-backward):
493         * UserInterface/Views/DebuggerDashboardView.css:
494         (.dashboard.debugger > .location):
495         (.toolbar .dashboard.debugger):
496         Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.
497
498 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
499
500         Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
501         https://bugs.webkit.org/show_bug.cgi?id=145562
502
503         Reviewed by Timothy Hatcher.
504
505         * UserInterface/Views/TabBrowser.js:
506         (WebInspector.TabBrowser):
507         Only these keyboard shortcuts should check if we are in an editable field.
508         Remove the implicit prevent default so they can fall back to system behavior
509         if necessary.
510
511         (WebInspector.TabBrowser.prototype._showNextTabCheckingForEditableField):
512         (WebInspector.TabBrowser.prototype._showPreviousTabCheckingForEditableField):
513         Bail if we are in an editable field. Otherwise perform the action and prevent default.
514
515 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
516
517         Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
518         https://bugs.webkit.org/show_bug.cgi?id=145546
519
520         Reviewed by Timothy Hatcher.
521
522         Scope ContentBrowser keyboard events within the ContentBrowser instead
523         of global, where they might conflict between ContentBrowsers. The scoped
524         shortcuts now no longer need to be enabled/disabled.
525
526         * UserInterface/Views/ContentBrowser.js:
527         (WebInspector.ContentBrowser):
528         Scope the keyboard shortcuts.
529
530         (WebInspector.ContentBrowser.prototype.shown):
531         (WebInspector.ContentBrowser.prototype.hidden):
532         No longer need to control enabling / disabling these non-global shortcuts.
533
534 2015-06-01  Jono Wells  <jonowells@apple.com>
535
536         Web Inspector: Type token text descenders touch bottom of container
537         https://bugs.webkit.org/show_bug.cgi?id=145544
538
539         Reviewed by Timothy Hatcher.
540
541         Move 1px padding from top to bottom of token.
542
543         * UserInterface/Views/TypeTokenView.css:
544         (.type-token):
545
546 2015-06-01  Joseph Pecoraro  <pecoraro@apple.com>
547
548         Web Inspector: Better handle keyboard events in the quick console prompt
549         https://bugs.webkit.org/show_bug.cgi?id=145548
550
551         Reviewed by Timothy Hatcher.
552
553         * UserInterface/Base/Main.js:
554         (WebInspector.saveDataToFile):
555         Move generic InspectorFrontendHost code here.
556
557         * UserInterface/Views/ContentBrowser.js:
558         (WebInspector.ContentBrowser.prototype._save):
559         (WebInspector.ContentBrowser.prototype._saveAs):
560         (WebInspector.ContentBrowser.prototype._saveDataToFile): Deleted.
561         Use the generic save code.
562
563         * UserInterface/Controllers/JavaScriptLogViewController.js:
564         (WebInspector.JavaScriptLogViewController):
565         (WebInspector.JavaScriptLogViewController.prototype._save):
566         (WebInspector.JavaScriptLogViewController.prototype._saveAs):
567         Handle save keyboard shortcuts while the prompt is focused.
568
569         * UserInterface/Views/LogContentView.js:
570         (WebInspector.LogContentView.prototype.focusSearchBar):
571         (WebInspector.LogContentView.prototype.save):
572         (WebInspector.LogContentView.prototype.saveAs):
573         Better handle keyboard shortcut cases in the console prompt for cases
574         like a collapsed or split console view.
575
576 2015-06-01  Nikita Vasilyev  <nvasilyev@apple.com>
577
578         Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned
579         https://bugs.webkit.org/show_bug.cgi?id=145534
580
581         Reviewed by Timothy Hatcher.
582
583         * UserInterface/Views/ButtonNavigationItem.css:
584         (.navigation-bar .item.button.suppress-emboss):
585         Never show borders for the pause/resume button.
586
587         * UserInterface/Views/DebuggerDashboardView.css:
588         (.dashboard.debugger .navigation-bar .item.button):
589
590 2015-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
591
592         Web Inspector: Drop forEach from WeakMap / WeakSet native member function maps
593         https://bugs.webkit.org/show_bug.cgi?id=145497
594
595         Reviewed by Sam Weinig.
596
597         WeakMap / WeakSet don't have forEach method.
598         This patch drops it from the native prototype function parameters map.
599
600         * UserInterface/Models/NativeFunctionParameters.js:
601
602 2015-05-29  Timothy Hatcher  <timothy@apple.com>
603
604         Web Inspector: Resources tab navigation sidebar should have a type filter header
605         https://bugs.webkit.org/show_bug.cgi?id=145474
606
607         Reviewed by Joseph Pecoraro.
608
609         * Localizations/en.lproj/localizedStrings.js: Updated.
610
611         * UserInterface/Images/UpDownArrows.svg: Make styleable.
612
613         * UserInterface/Main.html: Added new files.
614
615         * UserInterface/Views/LogContentView.js:
616         (WebInspector.LogContentView): Drive-by fix. Mark All as exclusive.
617
618         * UserInterface/Views/MultipleScopeBarItem.js: Added.
619         (WebInspector.MultipleScopeBarItem):
620         (WebInspector.MultipleScopeBarItem.prototype.get element):
621         (WebInspector.MultipleScopeBarItem.prototype.get exclusive):
622         (WebInspector.MultipleScopeBarItem.prototype.get scopeBarItems):
623         (WebInspector.MultipleScopeBarItem.set scopeBarItems.createOption):
624         (WebInspector.MultipleScopeBarItem.prototype.set scopeBarItems):
625         (WebInspector.MultipleScopeBarItem.prototype.get selected):
626         (WebInspector.MultipleScopeBarItem.prototype.set selected):
627         (WebInspector.MultipleScopeBarItem.prototype.get selectedScopeBarItem):
628         (WebInspector.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
629         (WebInspector.MultipleScopeBarItem.prototype._clicked):
630         (WebInspector.MultipleScopeBarItem.prototype._selectElementSelectionChanged):
631         (WebInspector.MultipleScopeBarItem.prototype._itemSelectionDidChange):
632
633         * UserInterface/Views/NavigationSidebarPanel.js:
634         (WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):
635         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
636         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.makeVisible):
637         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
638         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
639         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
640         Improve filtering so non-text filters can choose to auto-expand the tree.
641
642         * UserInterface/Views/ResourceSidebarPanel.css: Added.
643         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
644         (.sidebar > .panel.navigation.resource > .navigation-bar):
645
646         * UserInterface/Views/ResourceSidebarPanel.js:
647         (WebInspector.ResourceSidebarPanel):
648         (WebInspector.ResourceSidebarPanel.prototype.hasCustomFilters):
649         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
650         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
651         (WebInspector.ResourceSidebarPanel.prototype._scopeBarSelectionDidChange):
652         Make a ScopeBar and make it filter the TreeOutline when needed.
653
654         * UserInterface/Views/ScopeBar.css:
655         (.scope-bar > li.multiple):
656         (.scope-bar > li.multiple > select):
657         (.scope-bar > li.multiple.selected > select):
658         (.scope-bar > li.multiple > .arrows):
659         (.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows svg .filled):
660         (.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows svg .stroked):
661
662         * UserInterface/Views/ScopeBar.js:
663         (WebInspector.ScopeBar): Support shouldGroupNonExclusiveItems which will use MultipleScopeBarItem.
664         (WebInspector.ScopeBar.prototype._populate):
665         (WebInspector.ScopeBar.prototype._itemSelectionDidChange):
666         (WebInspector.ScopeBar.prototype.updateLayout): Deleted. Not needed for our current styles.
667
668         * UserInterface/Views/ScopeBarItem.js:
669         (WebInspector.ScopeBarItem):
670         (WebInspector.ScopeBarItem.prototype.get id):
671         (WebInspector.ScopeBarItem.prototype.get label):
672         (WebInspector.ScopeBarItem.prototype.get exclusive):
673         (WebInspector.ScopeBarItem.prototype.setSelected):
674         (WebInspector.ScopeBarItem.prototype._clicked):
675         (WebInspector.ScopeBarItem.prototype.get element): Deleted.
676         (WebInspector.ScopeBarItem.prototype._markElementSelected): Deleted.
677         Cleaned up and modernized a bit.
678
679 2015-05-29  Tobias Reiss  <tobi+webkit@basecode.de>
680
681         Web Inspector: Activity Viewer does not update on "clear all console messages"
682         https://bugs.webkit.org/show_bug.cgi?id=144681
683
684         Reviewed by Joseph Pecoraro.
685
686         Do not apply "ignoreDidClearMessages" hack on "Clear log" Button and Context menu.
687
688         * UserInterface/Views/LogContentView.js:
689         (WebInspector.LogContentView.prototype._sessionStarted):
690         (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages):
691         (WebInspector.LogContentView.prototype._clearLog): Deleted.
692
693 2015-05-29  Matt Baker  <mattbaker@apple.com>
694
695         Web Inspector: Remove unused expandTreeElementsWhenArrowing property from TreeOutline
696         https://bugs.webkit.org/show_bug.cgi?id=145470
697
698         Reviewed by Joseph Pecoraro.
699
700         * UserInterface/Views/TreeOutline.js:
701         (WebInspector.TreeOutline.prototype._treeKeyDown):
702         Replaced uses of removed property with boolean literal.
703
704 2015-05-29  Joseph Pecoraro  <pecoraro@apple.com>
705
706         Web Inspector: Tabs should have Context Menus
707         https://bugs.webkit.org/show_bug.cgi?id=144208
708
709         Reviewed by Timothy Hatcher.
710
711         Give non-pinned tabs "Close Tab" and "Close Other Tabs" context
712         menu items to affect other non-pinned tabs.
713
714         * Localizations/en.lproj/localizedStrings.js:
715         * UserInterface/Views/TabBarItem.js:
716         (WebInspector.TabBarItem):
717         (WebInspector.TabBarItem.prototype._handleContextMenuEvent.closeTab):
718         (WebInspector.TabBarItem.prototype._handleContextMenuEvent.closeOtherTabs):
719         (WebInspector.TabBarItem.prototype._handleContextMenuEvent):
720
721 2015-05-29  Matt Baker  <mattbaker@apple.com>
722
723         Web Inspector: Restoring the last selected DOM node fails on reload (DOMAgent: No node with given path found)
724         https://bugs.webkit.org/show_bug.cgi?id=144231
725
726         Reviewed by Timothy Hatcher.
727
728         Removed _restoreSelectedNodeIsAllowed flag from DOMTreeContentView. The frontend receives two documentUpdated
729         events from the DOM Agent during page reload, and the flag was preventing DOMTreeContentView from restoring
730         the previous selection in response to the second event.
731
732         * UserInterface/Views/DOMTreeContentView.js:
733         (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
734         (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
735
736 2015-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
737
738         Web Inspector: Update toolbar styles
739         https://bugs.webkit.org/show_bug.cgi?id=145419
740
741         Also, use hairline borders (1 phisical pixel) on retina (DPI >= 2).
742
743         Reviewed by Timothy Hatcher.
744
745         * UserInterface/Views/ButtonToolbarItem.css:
746         (.toolbar .item.button): Deleted.
747         (.toolbar.icon-and-label-vertical .item.button): Deleted.
748         (.toolbar.icon-and-label-horizontal .item.button): Deleted.
749         (.toolbar .item.button > .glyph): Deleted.
750         (.toolbar.small-size .item.button > .glyph): Deleted.
751         * UserInterface/Views/DashboardContainerView.css:
752         (.toolbar .dashboard-container): Deleted.
753         (.toolbar.collapsed .dashboard-container): Deleted.
754         (.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
755         (.toolbar .dashboard.slide-out-down): Deleted.
756         (.toolbar .dashboard.slide-in-up): Deleted.
757         * UserInterface/Views/Toolbar.css:
758         (.toolbar .search-bar > input[type="search"]):
759         (.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
760         (body:not(.unknown-mac) .toolbar .dashboard-container):
761         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
762         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus):
763         (body:not(.unknown-mac) .toolbar .item.button:active):
764         (body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
765         (body.unknown-mac .toolbar .dashboard-container):
766         (body.unknown-mac .toolbar .search-bar > input[type="search"]):
767         (body.unknown-mac .toolbar .search-bar > input[type="search"]:focus):
768         (@media (-webkit-min-device-pixel-ratio: 2)):
769         (body.unknown-mac .toolbar .item.button:active):
770         (body.unknown-mac.window-inactive .toolbar .dashboard-container):
771
772 2015-05-28  Devin Rousso  <drousso@apple.com>
773
774         Web Inspector: Jump from a computed style to the rule it came from
775         https://bugs.webkit.org/show_bug.cgi?id=120640
776
777         Reviewed by Timothy Hatcher.
778
779         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
780         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
781         If the delegate of CSSStyleDeclarationTextEditor has cssStyleDeclarationTextEditorShouldAddPropertyGoToArrows set to true, add a goToArrow to all CSS property entries.
782         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty.propertiesMatch):
783         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty.hasMatchingLonghandProperty):
784         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty):
785         Determines if a given CSS property is in the CSS style section and if so, select that CSS property, focus on the section containing that CSS property, and return true.
786         * UserInterface/Views/CSSStyleDeclarationSection.js:
787         (WebInspector.CSSStyleDeclarationSection.prototype.highlightProperty):
788         Searches through the properties of the section for a given property and scrolls to it if found.
789         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
790         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
791         Switches to the rulesStyleDetailsPanel and scrolls to and hightlights a given property in that panel.
792         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
793         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels):
794         Moved this function out of _navigationItemSelected for better reusablity.
795         * UserInterface/Views/ComputedStyleDetailsPanel.js:
796         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
797         Function that calls the delegate (which should be CSSStyleDetailsSidebarPanel) function computedStyleDetailsPanelShowProperty.
798         * UserInterface/Views/RulesStyleDetailsPanel.js:
799         (WebInspector.RulesStyleDetailsPanel):
800         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
801         (WebInspector.RulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
802         Searches through all the sections of the RulesStyleDetailsPanel for a given CSS property.
803         (WebInspector.RulesStyleDetailsPanel.prototype.shown):
804         (WebInspector.RulesStyleDetailsPanel.prototype.hidden):
805         (WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
806         Added a flag to this function that will highlight and scroll to a given property (_propertyToSelectAndHighlight) if set on load.
807         * UserInterface/Views/StyleDetailsPanel.js:
808         (WebInspector.StyleDetailsPanel.prototype.markAsNeedsRefresh):
809         (WebInspector.StyleDetailsPanel.prototype.nodeStylesRefreshed):
810         Made into protected function to allow it to be overridden.
811         (WebInspector.StyleDetailsPanel.prototype._nodeStylesRefreshed): Deleted.
812
813 2015-05-28  Joseph Pecoraro  <pecoraro@apple.com>
814
815         Web Inspector: Should have a keyboard shortcut to switch between inspector tabs
816         https://bugs.webkit.org/show_bug.cgi?id=144207
817
818         Reviewed by Timothy Hatcher.
819
820         These keyboard shortcuts work well in an undocked inspector window.
821         Be careful that some keyboard shortcuts, when used inside a text
822         editor / text field are just text actions. However, some keyboard
823         shortcuts will work no matter where you trigger them.
824
825         * UserInterface/Models/KeyboardShortcut.js:
826         * UserInterface/Views/TabBar.js:
827         (WebInspector.TabBar.prototype.selectPreviousTab):
828         (WebInspector.TabBar.prototype.selectNextTab):
829         * UserInterface/Views/TabBrowser.js:
830         (WebInspector.TabBrowser):
831         (WebInspector.TabBrowser.prototype._showPreviousTab):
832         (WebInspector.TabBrowser.prototype._showNextTab):
833
834 2015-05-28  Joseph Pecoraro  <pecoraro@apple.com>
835
836         Web Inspector: NewTabContentView should update button disabled state as other tabs are added/removed
837         https://bugs.webkit.org/show_bug.cgi?id=145448
838
839         Reviewed by Timothy Hatcher.
840
841         * UserInterface/Views/NewTabContentView.js:
842         (WebInspector.NewTabContentView):
843         Always add a click listener and add the type as a private property on the element.
844
845         (WebInspector.NewTabContentView.prototype.shown):
846         (WebInspector.NewTabContentView.prototype.hidden):
847         Add / remove event listeners for tab changes. Also update the view when shown.
848         
849         (WebInspector.NewTabContentView.prototype._createNewTab):
850         A disabled button an now be clicked. Do nothing if a new tab of this type is not allowed.
851
852         (WebInspector.NewTabContentView.prototype._updateTabItems):
853         Refresh the disabled state for each of the buttons.
854
855 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
856
857         Web Inspector: Show Page Source does not switch to Resources tab if inspector was closed
858         https://bugs.webkit.org/show_bug.cgi?id=145423
859
860         Reviewed by Timothy Hatcher.
861
862         * UserInterface/Base/Main.js:
863         (WebInspector._frameWasAdded.delayedWork):
864         (WebInspector._frameWasAdded):
865         In the special case where we are holding to show a frame's source code when
866         the frame becomes available (_frameIdentifierToShowSourceCodeWhenAvailable)
867         we should be forcing to show the tab.
868
869 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
870
871         Web Inspector: Toggling an inherited property sometimes stops working
872         https://bugs.webkit.org/show_bug.cgi?id=145416
873
874         Reviewed by Timothy Hatcher.
875
876         * UserInterface/Models/DOMNodeStyles.js:
877         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
878         Ensure we update the existing model objects with the new state information
879         before possibly bailing. This may produce changed events that update
880         parts of the inspector appropriately.
881
882 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
883
884         Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works
885         https://bugs.webkit.org/show_bug.cgi?id=143164
886
887         Reviewed by Brian Burg.
888
889         * UserInterface/Views/BoxModelDetailsSectionRow.js:
890         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
891         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
892         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.didToggle):
893         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode):
894         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
895         Make it so editing in the metrics pane just evaluates elem.style.setProperty
896         on the inspected page. Use "!important" to try and give the maximum priority
897         possible, which is a change from older behavior. Finally, refresh the sidebar
898         to update all values, and update the UI if bad input didn't change styles.
899
900 2015-05-26  Joseph Pecoraro  <pecoraro@apple.com>
901
902         Web Inspector: Function parameter string parsing improperly handles empty parameter list
903         https://bugs.webkit.org/show_bug.cgi?id=145391
904
905         Reviewed by Darin Adler.
906
907         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
908         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
909
910 2015-05-26  Joseph Pecoraro  <pecoraro@apple.com>
911
912         Web Inspector: Add Array.prototype.copyWithin parameter list
913         https://bugs.webkit.org/show_bug.cgi?id=145388
914
915         Reviewed by Darin Adler.
916
917         * UserInterface/Models/NativeFunctionParameters.js:
918
919 2015-05-26  Nikita Vasilyev  <nvasilyev@apple.com>
920
921         Web Inspector: focus outline of a search field should have a radius
922         https://bugs.webkit.org/show_bug.cgi?id=145383
923
924         Add a focus outline animation to roughly mimic the default focus outline of OS X.
925
926         Reviewed by Timothy Hatcher.
927
928         * UserInterface/Views/Toolbar.css:
929         (.toolbar .search-bar > input[type="search"]):
930         -webkit-focus-ring-color doesn't follow element's curvature (e.g. border-radius)
931         and it cannot be animated. Replace it with box-shadow.
932
933         (.toolbar .search-bar > input[type="search"]:focus):
934
935 2015-05-26  Nikita Vasilyev  <nvasilyev@apple.com>
936
937         Web Inspector: The bottom part "debugger" is clipped in the tab’s title
938         https://bugs.webkit.org/show_bug.cgi?id=145381
939
940         Reviewed by Timothy Hatcher.
941
942         * UserInterface/Views/TabBar.css:
943         (.tab-bar > .item):
944         Set line-height to fit "debugger". Setting line-height to 16px, which is the
945         size of the tabs icons, moves the text one pixel up, so set it to 15px.
946
947 2015-05-26  Dan Bernstein  <mitz@apple.com>
948
949         <rdar://problem/21104551> Update build settings
950
951         Reviewed by Anders Carlsson.
952
953         * Configurations/Base.xcconfig:
954         * Configurations/DebugRelease.xcconfig:
955         * Configurations/Version.xcconfig:
956
957 2015-05-23  Dan Bernstein  <mitz@apple.com>
958
959         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
960         https://bugs.webkit.org/show_bug.cgi?id=145345
961
962         Reviewed by Sam Weinig.
963
964         * Configurations/Base.xcconfig:
965
966 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
967
968         Web Inspector: Remove code related with unused style classes
969         https://bugs.webkit.org/show_bug.cgi?id=145332
970
971         Reviewed by Timothy Hatcher.
972
973         * UserInterface/Views/ConsoleMessageView.js:
974         (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
975         (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
976         The "type-string" class has no styles associated with it. So the entire span can be removed.
977
978         * UserInterface/Views/DOMTreeElement.js:
979         Both of these style classes have no styles associated with them. Remove the class names.
980
981 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
982
983         Web Inspector: Improve native parameter lists a bit
984         https://bugs.webkit.org/show_bug.cgi?id=145338
985
986         Reviewed by Timothy Hatcher.
987
988         * UserInterface/Models/NativeFunctionParameters.js:
989         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
990         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
991
992 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
993
994         Web Inspector: Update CSS Autocompletion properties and values
995         https://bugs.webkit.org/show_bug.cgi?id=145341
996
997         Reviewed by Timothy Hatcher.
998
999         * UserInterface/Models/CSSKeywordCompletions.js:
1000
1001 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1002
1003         Web Inspector: Adopt Object.setPrototypeOf
1004         https://bugs.webkit.org/show_bug.cgi?id=145335
1005
1006         Reviewed by Timothy Hatcher.
1007
1008         For a case that won't easily move to ES6 classes use Object.setPrototypeOf.
1009
1010         * UserInterface/Protocol/InspectorBackend.js:
1011         (InspectorBackend.Command.create):
1012
1013 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1014
1015         Web Inspector: Inline use once class names and remove some unused class names
1016         https://bugs.webkit.org/show_bug.cgi?id=145334
1017
1018         Reviewed by Timothy Hatcher.
1019
1020         * UserInterface/Views/ApplicationCacheFrameContentView.js:
1021         (WebInspector.ApplicationCacheFrameContentView):
1022         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1023         (WebInspector.BoxModelDetailsSectionRow):
1024         * UserInterface/Views/CSSStyleDeclarationSection.js:
1025         (WebInspector.CSSStyleDeclarationSection):
1026         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1027         (WebInspector.CSSStyleDetailsSidebarPanel):
1028         * UserInterface/Views/ClusterContentView.js:
1029         (WebInspector.ClusterContentView):
1030         * UserInterface/Views/CompletionSuggestionsView.js:
1031         (WebInspector.CompletionSuggestionsView):
1032         * UserInterface/Views/ConsolePrompt.js:
1033         (WebInspector.ConsolePrompt):
1034         * UserInterface/Views/ContentBrowser.js:
1035         (WebInspector.ContentBrowser):
1036         * UserInterface/Views/ContentFlowTreeElement.js:
1037         (WebInspector.ContentFlowTreeElement):
1038         * UserInterface/Views/ContentView.js:
1039         (WebInspector.ContentView):
1040         * UserInterface/Views/ContentViewContainer.js:
1041         (WebInspector.ContentViewContainer):
1042         * UserInterface/Views/CookieStorageContentView.js:
1043         (WebInspector.CookieStorageContentView):
1044         * UserInterface/Views/CookieStorageTreeElement.js:
1045         (WebInspector.CookieStorageTreeElement):
1046         * UserInterface/Views/DOMStorageContentView.js:
1047         (WebInspector.DOMStorageContentView):
1048         * UserInterface/Views/DOMTreeContentView.js:
1049         (WebInspector.DOMTreeContentView):
1050         * UserInterface/Views/DashboardView.js:
1051         (WebInspector.DashboardView):
1052         * UserInterface/Views/DatabaseTableContentView.js:
1053         (WebInspector.DatabaseTableContentView):
1054         * UserInterface/Views/DebuggerDashboardView.js:
1055         (WebInspector.DebuggerDashboardView):
1056         (WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
1057         * UserInterface/Views/DetailsSection.js:
1058         (WebInspector.DetailsSection):
1059         * UserInterface/Views/DetailsSectionSimpleRow.js:
1060         * UserInterface/Views/FontResourceContentView.js:
1061         (WebInspector.FontResourceContentView):
1062         (WebInspector.FontResourceContentView.prototype.createMetricElement):
1063         (WebInspector.FontResourceContentView.prototype.contentAvailable):
1064         * UserInterface/Views/HierarchicalPathComponent.js:
1065         (WebInspector.HierarchicalPathComponent):
1066         (WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):
1067         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
1068         * UserInterface/Views/LayoutTimelineOverviewGraph.js:
1069         (WebInspector.LayoutTimelineOverviewGraph):
1070         * UserInterface/Views/NetworkTimelineOverviewGraph.js:
1071         (WebInspector.NetworkTimelineOverviewGraph):
1072         * UserInterface/Views/OverviewTimelineView.js:
1073         * UserInterface/Views/ProbeSetDetailsSection.js:
1074         * UserInterface/Views/QuickConsole.js:
1075         * UserInterface/Views/ReplayDashboardView.js:
1076         * UserInterface/Views/ScriptContentView.js:
1077         (WebInspector.ScriptContentView):
1078         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1079         (WebInspector.ScriptTimelineOverviewGraph):
1080         * UserInterface/Views/TextContentView.js:
1081         (WebInspector.TextContentView):
1082         * UserInterface/Views/TimelineOverview.js:
1083         (WebInspector.TimelineOverview):
1084         * UserInterface/Views/TimelineOverviewGraph.js:
1085         (WebInspector.TimelineOverviewGraph):
1086         * UserInterface/Views/TimelineRecordBar.js:
1087         (WebInspector.TimelineRecordBar):
1088         * UserInterface/Views/TimelineRecordFrame.js:
1089         (WebInspector.TimelineRecordFrame):
1090         * UserInterface/Views/TimelineRecordingContentView.js:
1091         (WebInspector.TimelineRecordingContentView):
1092         * UserInterface/Views/TimelineRuler.js:
1093         (WebInspector.TimelineRuler):
1094         (WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):
1095
1096 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1097
1098         Web Inspector: DOMTree Keyboard Shortcut 'H' to toggle element visibility is not working
1099         https://bugs.webkit.org/show_bug.cgi?id=145331
1100
1101         Reviewed by Brian Burg.
1102
1103         We no longer have CSSProperty.value setters. Instead of attempting
1104         to toggle and clobber inline style values on the element we:
1105         
1106           1. inject a <style> on the page like ".WebInspectorHide { visibility:hidden }"
1107           2. toggle the WebInspectorHide class on the selected element
1108
1109         This approach is inspired by the original WebKit change in the
1110         old inspector frontend: <https://webkit.org/b/110641>.
1111
1112         The old approach toggled a few properties (opacity and pointer events)
1113         while the new approach uses visibility, matching other browsers.
1114
1115         * UserInterface/Views/DOMTreeOutline.js:
1116         (WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode.injectStyleAndToggleClass):
1117         (WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode):
1118         (WebInspector.DOMTreeOutline.prototype._hideElement):
1119         (WebInspector.DOMTreeOutline.prototype._hideElement.toggleProperties): Deleted.
1120
1121 2015-05-21  Joseph Pecoraro  <pecoraro@apple.com>
1122
1123         Web Inspector: Give Toolbar buttons an active style
1124         https://bugs.webkit.org/show_bug.cgi?id=145292
1125
1126         Reviewed by Timothy Hatcher.
1127
1128         * UserInterface/Views/ButtonToolbarItem.css:
1129         (.toolbar .item.button:active):
1130
1131 2015-05-21  Nikita Vasilyev  <nvasilyev@apple.com>
1132
1133         Web Inspector: Dashboard debugger information can be clipped
1134         https://bugs.webkit.org/show_bug.cgi?id=144209
1135
1136         Reviewed by Timothy Hatcher.
1137
1138         * UserInterface/Views/DashboardContainerView.css:
1139         (.toolbar .dashboard-container):
1140         Make dashboard flexible by using vw (viewport width units).
1141
1142         * UserInterface/Views/DefaultDashboardView.css:
1143         (.toolbar .dashboard.default):
1144         Center default dashboard icons in the middle, don't spread them along the dashboard.
1145
1146 2015-05-21  Joseph Pecoraro  <pecoraro@apple.com>
1147
1148         Web Inspector: Improve the UI of the type profiler popover
1149         https://bugs.webkit.org/show_bug.cgi?id=140737
1150
1151         Reviewed by Timothy Hatcher.
1152
1153         Display TypeDescriptions in a Tree similiar to ObjectTrees.
1154         Currently the only information we have in a TypeDescription
1155         is the property names, and not their types, so all we can
1156         display in the tree are names.
1157
1158         * Localizations/en.lproj/localizedStrings.js:
1159         * UserInterface/Controllers/TypeTokenAnnotator.js:
1160         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1161         * UserInterface/Main.html:
1162         * UserInterface/Models/ScriptSyntaxTree.js:
1163         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
1164         * UserInterface/Models/StructureDescription.js: Added.
1165         (WebInspector.StructureDescription):
1166         (WebInspector.StructureDescription.fromPayload):
1167         (WebInspector.StructureDescription.prototype.get fields):
1168         (WebInspector.StructureDescription.prototype.get optionalFields):
1169         (WebInspector.StructureDescription.prototype.get constructorName):
1170         (WebInspector.StructureDescription.prototype.get prototypeStructure):
1171         (WebInspector.StructureDescription.prototype.get imprecise):
1172         * UserInterface/Models/TypeDescription.js: Added.
1173         (WebInspector.TypeDescription):
1174         (WebInspector.TypeDescription.fromPayload):
1175         (WebInspector.TypeDescription.prototype.get leastCommonAncestor):
1176         (WebInspector.TypeDescription.prototype.get typeSet):
1177         (WebInspector.TypeDescription.prototype.get structures):
1178         (WebInspector.TypeDescription.prototype.get valid):
1179         (WebInspector.TypeDescription.prototype.get truncated):
1180         * UserInterface/Models/TypeSet.js:
1181         (WebInspector.TypeSet):
1182         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
1183         * UserInterface/Views/ObjectTreeView.js:
1184         (WebInspector.ObjectTreeView.prototype._updateChildren):
1185         * UserInterface/Views/Section.css: Removed.
1186         * UserInterface/Views/Section.js: Removed.
1187         * UserInterface/Views/SourceCodeTextEditor.css:
1188         (.popover .expandable):
1189         * UserInterface/Views/SourceCodeTextEditor.js:
1190         (WebInspector.SourceCodeTextEditor):
1191         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
1192         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
1193         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1194         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1195         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
1196         * UserInterface/Views/TypePropertiesSection.js: Removed.
1197         * UserInterface/Views/TypeTokenView.js:
1198         (WebInspector.TypeTokenView):
1199         (WebInspector.TypeTokenView.titleForPopover):
1200         (WebInspector.TypeTokenView.prototype.update):
1201         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
1202         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1203         (WebInspector.TypeTokenView.prototype._displayTypeName):
1204         * UserInterface/Views/TypeTreeElement.css: Added.
1205         (.type-tree-element):
1206         (.type-tree-element > .titles):
1207         (.type-tree-element > .disclosure-button):
1208         (.type-tree-element.parent > .disclosure-button):
1209         (.type-tree-element.parent.expanded > .disclosure-button):
1210         (.type-tree-element > .icon):
1211         (.type-tree-element.prototype):
1212         (.type-tree-element.prototype:focus):
1213         (.type-tree-element.prototype + ol):
1214         * UserInterface/Views/TypeTreeElement.js: Added.
1215         (WebInspector.TypeTreeElement):
1216         (WebInspector.TypeTreeElement.prototype.get name):
1217         (WebInspector.TypeTreeElement.prototype.get isPrototype):
1218         (WebInspector.TypeTreeElement.prototype.onpopulate):
1219         (WebInspector.TypeTreeElement.prototype.onexpand):
1220         * UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js.
1221         (.type-tree):
1222         (.type-tree-outline):
1223         (.type-tree-outline li):
1224         (.type-tree-outline ol):
1225         (.type-tree-outline ol.expanded):
1226         (.type-tree-outline li .empty-message):
1227         * UserInterface/Views/TypeTreeView.js: Added.
1228         (WebInspector.TypeTreeView):
1229         (WebInspector.TypeTreeView.prototype.get typeDescription):
1230         (WebInspector.TypeTreeView.prototype.get element):
1231         (WebInspector.TypeTreeView.prototype.get treeOutline):
1232         (WebInspector.TypeTreeView.prototype._populate):
1233
1234 2015-05-20  Joseph Pecoraro  <pecoraro@apple.com>
1235
1236         Web Inspector: Fix WebInspector.StackTrace style
1237         https://bugs.webkit.org/show_bug.cgi?id=145240
1238
1239         Reviewed by Timothy Hatcher.
1240
1241         * UserInterface/Models/StackTrace.js:
1242         Reorder and add our usual marker comments.
1243
1244 2015-05-19  Joseph Pecoraro  <pecoraro@apple.com>
1245
1246         Web Inspector: Improve Preview for NodeList / array like collections
1247         https://bugs.webkit.org/show_bug.cgi?id=145177
1248
1249         Reviewed by Timothy Hatcher.
1250
1251         * UserInterface/Views/ObjectPreviewView.js:
1252         (WebInspector.ObjectPreviewView.prototype._appendPreview):
1253         Show the class name for a non-basic-Array, but still hide
1254         it for a basic Array.
1255
1256 2015-05-19  Nikita Vasilyev  <nvasilyev@apple.com>
1257
1258         Web Inspector: Convert stackTrace from raw payload data to an array of CallFrames
1259         https://bugs.webkit.org/show_bug.cgi?id=144982
1260
1261         Reviewed by Joseph Pecoraro.
1262
1263         * UserInterface/Controllers/LogManager.js:
1264         * UserInterface/Main.html:
1265         * UserInterface/Models/CallFrame.js:
1266         (WebInspector.CallFrame.fromPayload):
1267         Consider an empty string url as a native code as it was in 
1268         WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame
1269
1270         * UserInterface/Models/ConsoleMessage.js:
1271         (WebInspector.ConsoleMessage):
1272         Convert _stackTrace from an array of payload objects to WebInspector.StackTrace model.
1273
1274         * UserInterface/Models/StackTrace.js: Added.
1275         (WebInspector.StackTrace):
1276         (WebInspector.StackTrace.prototype.get callFrames):
1277         (WebInspector.StackTrace.prototype.get firstNonNativeCallFrame): Added.
1278         (WebInspector.StackTrace.fromPayload):
1279         * UserInterface/Test.html:
1280         * UserInterface/Views/CallFrameView.js:
1281         (WebInspector.CallFrameView):
1282         Don't show a URL when sourceCodeLocation is missing, fix webkit.org/b/145071.
1283
1284         * UserInterface/Views/ConsoleMessageView.js:
1285         (WebInspector.ConsoleMessageView):
1286         (WebInspector.ConsoleMessageView.prototype.toClipboardString):
1287         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
1288         (WebInspector.ConsoleMessageView.prototype._appendStackTrace):
1289         (WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
1290         (WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
1291         (WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame): Deleted.
1292
1293 2015-05-18  Joseph Pecoraro  <pecoraro@apple.com>
1294
1295         Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
1296         https://bugs.webkit.org/show_bug.cgi?id=145139
1297
1298         Reviewed by Timothy Hatcher.
1299
1300         * UserInterface/Views/DOMTreeElement.js:
1301         (WebInspector.DOMTreeElement.prototype.highlightSearchResults):
1302         (WebInspector.DOMTreeElement.prototype.hideSearchHighlights):
1303         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1304         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1305         (WebInspector.DOMTreeElement.prototype._updateChildren):
1306         (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
1307         (WebInspector.DOMTreeElement.prototype._startEditingAsHTML.dispose):
1308         (WebInspector.DOMTreeElement.prototype._startEditingAsHTML):
1309         (WebInspector.DOMTreeElement.prototype.updateTitle):
1310         Stop using the `delete` operator.
1311
1312         * UserInterface/Views/DOMTreeOutline.js:
1313         (WebInspector.DOMTreeOutline.prototype.setVisible):
1314         Trigger an update when the outline is made visible.
1315
1316         * UserInterface/Views/FrameDOMTreeContentView.js:
1317         (WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
1318         Provide a reasonable default selection if there is no body or document element.
1319         For example in an augmented DOM tree.
1320
1321 2015-05-18  Joseph Pecoraro  <pecoraro@apple.com>
1322
1323         Web Inspector: Tab Restoration incorrectly makes ContentViews "shown" in background tabs
1324         https://bugs.webkit.org/show_bug.cgi?id=145080
1325
1326         Reviewed by Timothy Hatcher.
1327
1328         Many tabs have their own content browser / navigation sidebar. During
1329         state restoration, each tab would immediately try to restore an
1330         appropriate ContentView after the load / navigation. However, in doing
1331         so, we weren't respecting whether or not the Tab the ContentBrowser
1332         was in was hidden or not, so ContentViews in background tags were
1333         still being treated as shown/visible.
1334
1335         This patch changes state restoration to only affect the foreground
1336         tab, and be delayed on all background tabs until that tab is shown.
1337         This reduces the amount of work on load and navigation to just a
1338         single tab instead of all tabs. Most importantly, it avoids having
1339         performing work on ContentBrowsers that are non-visible, so state
1340         restoration only happens for visible ContentBrowsers.
1341
1342         For simplicity, in the case of a delayed tab restoration triggered
1343         by the user switching tabs, we don't try twice (like we occasionally
1344         do on load/reload). We could add back some hueristic here if needed.
1345
1346         * UserInterface/Base/Main.js:
1347         (WebInspector.contentLoaded):
1348         (WebInspector.activateExtraDomains):
1349         (WebInspector._mainResourceDidChange):
1350         (WebInspector._restoreCookieForOpenTabs):
1351         * UserInterface/Views/NavigationSidebarPanel.js:
1352
1353         * UserInterface/Views/TabContentView.js:
1354         (WebInspector.TabContentView.prototype.shown):
1355         (WebInspector.TabContentView.prototype.restoreStateFromCookie):
1356         (WebInspector.TabContentView.prototype.saveStateToCookie):
1357         When asked to restore state, save that logic until the next time the tab is shown.
1358
1359         * UserInterface/Views/TextEditor.js:
1360         (WebInspector.TextEditor.prototype.get visible):
1361         * UserInterface/Views/SourceCodeTextEditor.js:
1362         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidStartEditing):
1363         (WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState): Deleted.
1364         Although this didn't actually catch the issue, it could potentially
1365         catch other issues in the future. We don't want to enable the annotators
1366         in a non-visible text editor, as it could be a performance issue.
1367
1368 2015-05-15  Matt Baker  <mattbaker@apple.com>
1369
1370         Web Inspector: empty timeline should not use previous timeline's zoom interval
1371         https://bugs.webkit.org/show_bug.cgi?id=132754
1372
1373         Reviewed by Joseph Pecoraro.
1374
1375         When a timeline recording is started in response to a provisional load, TimelineManager should check whether
1376         the main resource url is changing before loading a new timeline recording. If the main resource is changing,
1377         set the selection start, selection duration, and duration-per-pixel settings of the TimelineOverview to their
1378         default values.
1379
1380         * UserInterface/Controllers/TimelineManager.js:
1381         (WebInspector.TimelineManager):
1382         (WebInspector.TimelineManager.prototype.isCapturingPageReload):
1383         (WebInspector.TimelineManager.prototype.capturingStopped):
1384         (WebInspector.TimelineManager.prototype.pageDidLoad):
1385         (WebInspector.TimelineManager.prototype._startAutoCapturing):
1386         Added a property for checking whether auto capture was triggered by a page reload.
1387
1388         * UserInterface/Views/LinearTimelineOverview.js:
1389         (WebInspector.LinearTimelineOverview):
1390         Increase default selection time to 15 seconds.
1391
1392         * UserInterface/Views/TimelineOverview.js:
1393         (WebInspector.TimelineOverview):
1394         Reset selection and zoom if TimelineManager isn't capturing in response to a page reload.
1395
1396         (WebInspector.TimelineOverview.prototype.reset):
1397         Reset selection and zoom.
1398
1399         (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
1400         (WebInspector.TimelineOverview.prototype._resetSelection):
1401         Added a helper function for resetting selection and zoom to their default values.
1402
1403 2015-05-15  Matt Baker  <mattbaker@apple.com>
1404
1405         Web Inspector: Timeline data grid displays wrong records after switching between Timelines/Frames mode
1406         https://bugs.webkit.org/show_bug.cgi?id=145084
1407
1408         Reviewed by Timothy Hatcher.
1409
1410         Update timeline sidebar filter whenever the view mode changes.
1411
1412         * UserInterface/Views/TimelineSidebarPanel.js:
1413         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
1414         (WebInspector.TimelineSidebarPanel.get else):
1415         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
1416         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
1417
1418 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1419
1420         Web Inspector: Bump image format number to force image regeneration
1421         https://bugs.webkit.org/show_bug.cgi?id=145074
1422
1423         Reviewed by Timothy Hatcher.
1424
1425         * UserInterface/Base/ImageUtilities.js:
1426
1427 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1428
1429         Web Inspector: Reduce type annotation update frequency
1430         https://bugs.webkit.org/show_bug.cgi?id=145066
1431
1432         Reviewed by Timothy Hatcher.
1433
1434         * UserInterface/Controllers/TypeTokenAnnotator.js:
1435         Reduce the frequency which could commonly be 16-24ms
1436         to a minimum of 100ms and maximum of 2000ms.
1437
1438 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1439
1440         Web Inspector: Fix some possible event listener leakers in content views
1441         https://bugs.webkit.org/show_bug.cgi?id=145068
1442
1443         Reviewed by Timothy Hatcher.
1444
1445         Now that some content views can be closed that weren't closable before, ensure
1446         we clean up after global event listeners that may strongly reference "this".
1447
1448         * UserInterface/Views/DOMTreeContentView.js:
1449         (WebInspector.DOMTreeContentView.prototype.closed):
1450         * UserInterface/Views/DOMTreeOutline.js:
1451         (WebInspector.DOMTreeOutline.prototype.close):
1452         * UserInterface/Views/LayoutTimelineView.js:
1453         (WebInspector.LayoutTimelineView.prototype.closed):
1454         * UserInterface/Views/NetworkTimelineView.js:
1455         (WebInspector.NetworkTimelineView.prototype.closed):
1456         * UserInterface/Views/RenderingFrameTimelineView.js:
1457         (WebInspector.RenderingFrameTimelineView.prototype.closed):
1458         * UserInterface/Views/ScriptContentView.js:
1459         (WebInspector.ScriptContentView.prototype.closed):
1460         * UserInterface/Views/ScriptTimelineView.js:
1461         (WebInspector.ScriptTimelineView.prototype.closed):
1462         * UserInterface/Views/SourceCodeTextEditor.js:
1463         (WebInspector.SourceCodeTextEditor.prototype.close):
1464         * UserInterface/Views/TextResourceContentView.js:
1465         (WebInspector.TextResourceContentView.prototype.closed):
1466         * UserInterface/Views/TimelineDataGrid.js:
1467         (WebInspector.TimelineDataGrid.prototype.closed):
1468         (WebInspector.TimelineDataGrid.prototype.handleEvent):
1469
1470 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1471
1472         Web Inspector: Initiator Popovers no longer work in Layout Timeline
1473         https://bugs.webkit.org/show_bug.cgi?id=145067
1474
1475         Reviewed by Timothy Hatcher.
1476
1477         * UserInterface/Views/LayoutTimelineDataGrid.js:
1478         (WebInspector.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
1479         Update the column name, which changed in r183134.
1480
1481 2015-05-14  Joseph Pecoraro  <pecoraro@apple.com>
1482
1483         Web Inspector: Update the New Tab button disabled state after extra domains are activated
1484         https://bugs.webkit.org/show_bug.cgi?id=145028
1485
1486         Reviewed by Timothy Hatcher.
1487
1488         * UserInterface/Base/Main.js:
1489         (WebInspector.activateExtraDomains):
1490
1491 2015-05-14  Matt Baker  <mattbaker@apple.com>
1492
1493         Web Inspector: Current time marker is always at zero in Rendering Frames ruler
1494         https://bugs.webkit.org/show_bug.cgi?id=144518
1495
1496         Reviewed by Timothy Hatcher.
1497
1498         The current and end time values for the rendering frame timeline overview should always be equal to the frame
1499         number of the last record in the rendering frames timeline.
1500
1501         * UserInterface/Views/TimelineOverview.js:
1502         (WebInspector.TimelineOverview):
1503         (WebInspector.TimelineOverview.prototype.updateLayout):
1504         * UserInterface/Views/TimelineRecordingContentView.js:
1505         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
1506         (WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
1507
1508 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1509
1510         [Win] Move Windows build target to Windows 7 (or newer)
1511         https://bugs.webkit.org/show_bug.cgi?id=144890
1512         <rdar://problem/20707307>
1513
1514         Reviewed by Anders Carlsson.
1515
1516         Update linked SDK and minimal Windows level to be compatible with
1517         Windows 7 or newer.
1518
1519         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
1520
1521 2015-05-11  Timothy Hatcher  <timothy@apple.com>
1522
1523         Web Inspector: REGRESSION (Tabs): Issues reloading a resource with breakpoints
1524         https://bugs.webkit.org/show_bug.cgi?id=144650
1525
1526         Fix a number of issues with Debugger tab and navigation/reloading:
1527         - Close old content views in the Debugger tab when main frame navigates.
1528         - Prune old resource tree elements before attempting to restore a cookie that might match an old resource.
1529         - Allow breakpoint selections to be restored from a saved cookie.
1530         - Fix an assert when closing a content view that isn't the current index, but is the current view.
1531         - Avoid calling closed() multiple times when a ContentView is in the back/forward list more than once.
1532         - Make restoreStateFromCookie properly set and use the causedByNavigation argument for a longer restore delay.
1533         - Create a new cookie object per tab instead of it being cumulative from the previous cookie.
1534
1535         Reviewed by Brian Burg.
1536
1537         * UserInterface/Base/Main.js:
1538         (WebInspector._mainResourceDidChange): Delay calling _restoreCookieForOpenTabs to give time for sidebars
1539         and tabs to respond to the main resource change.
1540         (WebInspector._restoreCookieForOpenTabs): Rename causedByReload to causedByNavigation. Nothing special about
1541         reload since we restore on all navigation.
1542
1543         * UserInterface/Views/ContentView.js:
1544         (WebInspector.ContentView): Support Breakpoint as a represented object, which happens during a cookie restore.
1545         (WebInspector.ContentView.isViewable): Ditto.
1546
1547         * UserInterface/Views/ContentViewContainer.js:
1548         (WebInspector.ContentViewContainer.prototype.closeAllContentViews): Disassociate if the view is current and not just
1549         the current entry index. This matches other close functions. This fixes an assert in _disassociateFromContentView.
1550         (WebInspector.ContentViewContainer.prototype._disassociateFromContentView): Don't disassociate multiple times. This
1551         avoids calling the closed() function on a view more than once.
1552
1553         * UserInterface/Views/DebuggerSidebarPanel.js:
1554         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
1555         (WebInspector.DebuggerSidebarPanel.prototype._mainResourceDidChange): Renamed from _mainResourceChanged.
1556         Close all content views if this is the main frame. Also prune all old resources. Doing this now avoids a flash
1557         of having old and new resources in the tree caused by the default delay in NavigationSidebarPanel's _checkForOldResources.
1558
1559         * UserInterface/Views/NavigationSidebarPanel.js:
1560         (WebInspector.NavigationSidebarPanel): Set _autoPruneOldTopLevelResourceTreeElements for later.
1561         (WebInspector.NavigationSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
1562         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentView): Fix typo.
1563         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentViewForTreeElement): Fix whitespace.
1564         (WebInspector.NavigationSidebarPanel.prototype.pruneOldResourceTreeElements): Added. Broken out from
1565         _checkForOldResources.delayedWork so it can be called manually. Also check all visible tree outlines.
1566         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged): Pass treeElement in an array.
1567         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResourcesIfNeeded): Added.
1568         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResources): Call pruneOldResourceTreeElements on a delay.
1569         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResources.delayedWork): Deleted.
1570         (WebInspector.NavigationSidebarPanel.prototype._checkOutlinesForPendingViewStateCookie): Call _checkForOldResourcesIfNeeded.
1571         (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie): Remove array folding code.
1572
1573         * UserInterface/Views/TabContentView.js:
1574         (WebInspector.TabContentView.prototype.restoreStateFromCookie): Rename causedByReload to causedByNavigation.
1575         (WebInspector.TabContentView.prototype.saveStateToCookie): Don't allow the cookie to build on the old cookie.
1576
1577 2015-05-11  Timothy Hatcher  <timothy@apple.com>
1578
1579         Web Inspector: NavigationSidebarPanel leaks some event listeners
1580         https://bugs.webkit.org/show_bug.cgi?id=144523
1581
1582         Reviewed by Joseph Pecoraro.
1583
1584         * UserInterface/Views/NavigationSidebarPanel.js:
1585         (WebInspector.NavigationSidebarPanel):
1586         (WebInspector.NavigationSidebarPanel.prototype.closed):
1587         * UserInterface/Views/ResourceSidebarPanel.js:
1588         (WebInspector.ResourceSidebarPanel.prototype.closed):
1589         * UserInterface/Views/SearchSidebarPanel.js:
1590         (WebInspector.SearchSidebarPanel.prototype.closed):
1591         * UserInterface/Views/StorageSidebarPanel.js:
1592         (WebInspector.StorageSidebarPanel.prototype.closed):
1593         * UserInterface/Views/TimelineSidebarPanel.js:
1594         (WebInspector.TimelineSidebarPanel.prototype.closed):
1595
1596 2015-05-10  Nikita Vasilyev  <nvasilyev@apple.com>
1597
1598         Web Inspector: In the console, show function name next to the source link
1599         https://bugs.webkit.org/show_bug.cgi?id=144372
1600
1601         Introduce CallFrameView to display counsole message source links. It looks like this:
1602
1603             [f] functionName - filename.js:42
1604
1605         Reviewed by Timothy Hatcher.
1606
1607         * UserInterface/Base/Main.js:
1608         (WebInspector.createSourceCodeLocationLink):
1609         (WebInspector.linkifyLocation):
1610         (.showSourceCodeLocation):
1611         (WebInspector.linkifyElement):
1612         Abstract this out as it's used in WebInspector.CallFrameView and WebInspector.createSourceCodeLocationLink.
1613
1614         (WebInspector.sourceCodeForURL):
1615         Move this code from Timeline to Main.js as it's used by Console too.
1616
1617         (WebInspector.linkifyURLAsNode):
1618         Remove tooltipText argument as it is never used.
1619
1620         * UserInterface/Controllers/TimelineManager.js:
1621         (WebInspector.TimelineManager.prototype._callFramesFromPayload):
1622         * UserInterface/Main.html:
1623         * UserInterface/Models/CallFrame.js:
1624         (WebInspector.CallFrame.fromPayload):
1625         Abstract this out as it's used in WebInspector.TimelineManager.prototype._callFramesFromPayload and
1626         WebInspector.ConsoleMessageView._appendLocationLink.
1627
1628         (WebInspector.CallFrame):
1629         * UserInterface/Views/CallFrameTreeElement.js:
1630         (WebInspector.CallFrameTreeElement):
1631         Move it to WebInspector.CallFrameView.iconForCallFrame.
1632
1633         * UserInterface/Views/CallFrameView.css: Added.
1634         (.call-frame):
1635         (.call-frame .icon):
1636         (.call-frame .titles):
1637         (.call-frame .title):
1638         (.call-frame .source-link):
1639         (.call-frame .title + .subtitle > .source-link):
1640         (.call-frame .subtitle .source-link):
1641         (.call-frame:focus .subtitle .source-link):
1642         (.call-frame .subtitle:empty):
1643         (.call-frame .subtitle):
1644         (.call-frame .colon):
1645         (.call-frame .title + .subtitle::before):
1646         * UserInterface/Views/CallFrameView.js: Added.
1647         (WebInspector.CallFrameView):
1648         (WebInspector.CallFrameView.iconClassNameForCallFrame):
1649         * UserInterface/Views/ConsoleMessageView.css:
1650         (.console-message .console-message-location):
1651         (.console-message .call-frame):
1652         (.console-message .go-to-link):
1653         (.console-message .go-to-link:focus):
1654         (.console-message .console-message-url::before):
1655         (.console-saved-variable): Deleted.
1656         * UserInterface/Views/ConsoleMessageView.js:
1657         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
1658         * UserInterface/Views/DebuggerDashboardView.js:
1659         * UserInterface/Views/Main.css:
1660         (.hidden): Deleted.
1661         * UserInterface/Views/ProfileNodeTreeElement.js:
1662         (WebInspector.ProfileNodeTreeElement):
1663         * UserInterface/Views/TimelineDataGridNode.js:
1664         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
1665
1666 2015-05-08  Tobias Reiss  <tobi+webkit@basecode.de>
1667
1668         Web Inspector: Styles sidebar editing with incomplete property looks poor in UI
1669         https://bugs.webkit.org/show_bug.cgi?id=141692
1670
1671         Reviewed by Timothy Hatcher.
1672
1673         Add "css-rule" Formatter that breaks CSS declarations into multiple lines,
1674         keeps comments and invalid styles and adds whitespace.
1675
1676         * Tools/PrettyPrinting/css-rule-tests/*.css: Added.
1677         Add test cases.
1678
1679         * Tools/PrettyPrinting/index.html:
1680         Enable Test setup to be able to run "css-rule" Formatter tests.
1681
1682         * UserInterface/Controllers/Formatter.js:
1683         (Formatter.prototype._handleToken):
1684         * UserInterface/Controllers/FormatterContentBuilder.js:
1685         (FormatterContentBuilder.prototype.removeLastNewline):
1686         (FormatterContentBuilder.prototype.removeLastWhitespace):
1687         (FormatterContentBuilder.prototype._popFormattedContent):
1688         (FormatterContentBuilder.prototype._popNewLine): Deleted.
1689         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1690         (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):
1691         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.set this):
1692         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.get this):
1693         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
1694         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent):
1695         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.countNewLineCharacters): Deleted.
1696         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.else): Deleted.
1697         * UserInterface/Views/CodeMirrorFormatters.js:
1698
1699 2015-05-07  Joseph Pecoraro  <pecoraro@apple.com>
1700
1701         Web Inspector: Expanding Object with only __proto__ looks poor should have a label
1702         https://bugs.webkit.org/show_bug.cgi?id=144755
1703
1704         Reviewed by Timothy Hatcher.
1705
1706         Better handle cases where expanding an object has only a __proto__
1707         and no other properties.
1708
1709         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
1710         (WebInspector.ObjectTreePropertyTreeElement.mode.prototype.this.children.length):
1711         (WebInspector.ObjectTreePropertyTreeElement):
1712         * UserInterface/Views/ObjectTreeView.css:
1713         (.object-tree-outline li .empty-message):
1714         * UserInterface/Views/ObjectTreeView.js:
1715         (WebInspector.ObjectTreeView.createEmptyMessageElement):
1716         (WebInspector.ObjectTreeView.comparePropertyDescriptors):
1717         (WebInspector.ObjectTreeView.prototype._updateProperties):
1718
1719 2015-05-07  Joseph Pecoraro  <pecoraro@apple.com>
1720
1721         Web Inspector: Fix querySelector in ResourceContentView.js, caught by assertion
1722         https://bugs.webkit.org/show_bug.cgi?id=144756
1723
1724         Reviewed by Timothy Hatcher.
1725
1726         * UserInterface/Views/ResourceContentView.js:
1727         (WebInspector.ResourceContentView.prototype._hasContent):
1728         Ensure querySelector call is using the class name correctly.
1729
1730 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1731
1732         Web Inspector: Docking Toolbar Buttons do not respect Docking Availability
1733         https://bugs.webkit.org/show_bug.cgi?id=144714
1734
1735         Reviewed by Timothy Hatcher.
1736
1737         * UserInterface/Base/Main.js:
1738         (WebInspector.contentLoaded):
1739         (WebInspector.updateDockingAvailability):
1740         (WebInspector._updateDockNavigationItems):
1741         Update the Toolbar UI based on docking availability.
1742         Assume docking is unavailable by default.
1743
1744         * UserInterface/Protocol/InspectorFrontendAPI.js:
1745         (InspectorFrontendAPI.setDockingUnavailable):
1746         Add back this API as the backend may be calling it when
1747         docking availability changes. This just calls out to
1748         global WebInspector functions to update the Toolbar UI.
1749
1750         * UserInterface/Base/Test.js:
1751         (WebInspector.updateDockedState):
1752         (WebInspector.updateDockingAvailability):
1753         Do nothing in tests.
1754
1755 2015-05-06  Matt Baker  <mattbaker@apple.com>
1756
1757         Web Inspector: The text in the left pane overlaps the "Filter Time Events" field in the Timeline after the Web Inspector is resized
1758         https://bugs.webkit.org/show_bug.cgi?id=144720
1759
1760         Reviewed by Timothy Hatcher.
1761
1762         * UserInterface/Views/FilterBar.css:
1763         (.filter-bar):
1764         (.filter-bar > .navigation-bar):
1765         (.filter-bar > input[type="search"]):
1766         (.filter-bar > .navigation-bar > .item): Deleted.
1767         Filter bar now has opaque background and height updated to the ubiquitous 29px.
1768
1769 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1770
1771         Web Inspector: DOMStorage exception and issue with sessionStorage
1772         https://bugs.webkit.org/show_bug.cgi?id=144646
1773
1774         Reviewed by Timothy Hatcher.
1775
1776         * UserInterface/Views/DOMStorageContentView.js:
1777         (WebInspector.DOMStorageContentView):
1778         (WebInspector.DOMStorageContentView.prototype._populate):
1779         (WebInspector.DOMStorageContentView.prototype.reset): Deleted.
1780         Always have the datagrid be available with a default sort.
1781
1782         (WebInspector.DOMStorageContentView.prototype._sortDataGrid.comparator):
1783         (WebInspector.DOMStorageContentView.prototype._sortDataGrid):
1784         Simplify and correct the order.
1785
1786         (WebInspector.DOMStorageContentView.prototype.cleanup):
1787         Cleanup some uses of delete.
1788
1789         * UserInterface/Views/DataGrid.js:
1790         (WebInspector.DataGrid.prototype.sortNodesImmediately):
1791         Provide a way to sort immediately without a visible delay.
1792
1793         (WebInspector.DataGrid.prototype._sortNodesCallback):
1794         Cleanup some dead code to simplify sorting.
1795
1796         (WebInspector.DataGridNode.prototype._attach):
1797         When sorting, the children list does not match the child node list,
1798         so ensure that placeholder nodes are added to the end.
1799
1800         (WebInspector.PlaceholderDataGridNode.prototype.makeNormal):
1801         Cleanup some uses of delete.
1802
1803 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1804
1805         Web Inspector: SourceCodeTextEditor shows "undefined" instead of resource content when pausing during resource load
1806         https://bugs.webkit.org/show_bug.cgi?id=144662
1807
1808         Reviewed by Timothy Hatcher.
1809
1810         * UserInterface/Protocol/InspectorBackend.js:
1811         (InspectorBackend.Command.prototype.promise):
1812         Start standardizing on rejecting Promises with Error objects.
1813
1814         * UserInterface/Views/ResourceContentView.js:
1815         (WebInspector.ResourceContentView):
1816         (WebInspector.ResourceContentView.prototype._protocolError):
1817         When there is a protocol error, show a nice UI string for the error.
1818
1819         (WebInspector.ResourceContentView.prototype._contentAvailable):
1820         (WebInspector.ResourceContentView.prototype._contentError):
1821         (WebInspector.ResourceContentView.prototype._hasContent):
1822         Whenever we hit an error case in ResourceContentView, check to make sure
1823         that a subclass hasn't already populated the content view with content.
1824         This can happen when a TextResourceContentView populates a Resource with
1825         Script content while paused, because the Resource content would be
1826         unavailable. We check that content has loaded by checking that the
1827         indeterminate spinner is no longer showing.
1828
1829 2015-05-05  Andres Gomez  <agomez@igalia.com>
1830
1831         [GTK] Web Inspector: Further optimize SVG images
1832         https://bugs.webkit.org/show_bug.cgi?id=144441
1833
1834         SVG images optimized with a combination of sed replacements, the
1835         usage of the scour tool (http://www.codedread.com/scour/) and a
1836         forked version of the svgo tool (https://github.com/tanty/svgo).
1837
1838         Also, added the class attribute to the shape elements following
1839         the convention used in Apple's images.
1840
1841         Reviewed by Joseph Pecoraro.
1842
1843         * UserInterface/Images/gtk/BackArrow.svg: Optimized.
1844         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Optimized.
1845         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Optimized.
1846         * UserInterface/Images/gtk/BreakpointButton.svg: Optimized.
1847         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Optimized.
1848         * UserInterface/Images/gtk/Breakpoints.svg: Optimized.
1849         * UserInterface/Images/gtk/Checkers.svg: Optimized.
1850         * UserInterface/Images/gtk/Circle.svg: Optimized.
1851         * UserInterface/Images/gtk/Close.svg: Optimized.
1852         * UserInterface/Images/gtk/CloseLarge.svg: Optimized.
1853         * UserInterface/Images/gtk/CloseWhite.svg: Optimized.
1854         * UserInterface/Images/gtk/ContentFlow.svg: Optimized.
1855         * UserInterface/Images/gtk/Crosshair.svg: Optimized.
1856         * UserInterface/Images/gtk/DOMCharacterData.svg: Optimized.
1857         * UserInterface/Images/gtk/DOMComment.svg: Optimized.
1858         * UserInterface/Images/gtk/DOMDocument.svg: Optimized.
1859         * UserInterface/Images/gtk/DOMDocumentType.svg: Optimized.
1860         * UserInterface/Images/gtk/DOMElement.svg: Optimized.
1861         * UserInterface/Images/gtk/DOMNode.svg: Optimized.
1862         * UserInterface/Images/gtk/DOMTextNode.svg: Optimized.
1863         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Optimized.
1864         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Optimized.
1865         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Optimized.
1866         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Optimized.
1867         * UserInterface/Images/gtk/DockBottom.svg: Optimized.
1868         * UserInterface/Images/gtk/DockRight.svg: Optimized.
1869         * UserInterface/Images/gtk/DownloadArrow.svg: Optimized.
1870         * UserInterface/Images/gtk/Error.svg: Optimized.
1871         * UserInterface/Images/gtk/Errors.svg: Optimized.
1872         * UserInterface/Images/gtk/ErrorsEnabled.svg: Optimized.
1873         * UserInterface/Images/gtk/EventListener.svg: Optimized.
1874         * UserInterface/Images/gtk/Exception.svg: Optimized.
1875         * UserInterface/Images/gtk/Eye.svg: Optimized.
1876         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Optimized.
1877         * UserInterface/Images/gtk/ForwardArrow.svg: Optimized.
1878         * UserInterface/Images/gtk/Function.svg: Optimized.
1879         * UserInterface/Images/gtk/GoToArrow.svg: Optimized.
1880         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Optimized.
1881         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Optimized.
1882         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Optimized.
1883         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Optimized.
1884         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Optimized.
1885         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Optimized.
1886         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Optimized.
1887         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Optimized.
1888         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Optimized.
1889         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Optimized.
1890         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Optimized.
1891         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Optimized.
1892         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Optimized.
1893         * UserInterface/Images/gtk/Issues.svg: Optimized.
1894         * UserInterface/Images/gtk/IssuesEnabled.svg: Optimized.
1895         * UserInterface/Images/gtk/LayerBorders.svg: Optimized.
1896         * UserInterface/Images/gtk/Locked.svg: Optimized.
1897         * UserInterface/Images/gtk/Logs.svg: Optimized.
1898         * UserInterface/Images/gtk/Native.svg: Optimized.
1899         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Optimized.
1900         * UserInterface/Images/gtk/NavigationItemTrash.svg: Optimized.
1901         * UserInterface/Images/gtk/NavigationItemTypes.svg: Optimized.
1902         * UserInterface/Images/gtk/PaintFlashing.svg: Optimized.
1903         * UserInterface/Images/gtk/Pause.svg: Optimized.
1904         * UserInterface/Images/gtk/PausedBreakpoint.svg: Optimized.
1905         * UserInterface/Images/gtk/Pencil.svg: Optimized.
1906         * UserInterface/Images/gtk/Plus.svg: Optimized. Text element
1907         converted into a shape.
1908         * UserInterface/Images/gtk/PseudoElement.svg: Optimized.
1909         * UserInterface/Images/gtk/Record.svg: Optimized.
1910         * UserInterface/Images/gtk/Reflection.svg: Optimized.
1911         * UserInterface/Images/gtk/ReloadFull.svg: Optimized.
1912         * UserInterface/Images/gtk/ReplayPauseButton.svg: Optimized.
1913         * UserInterface/Images/gtk/ReplayPlayButton.svg: Optimized.
1914         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Optimized.
1915         * UserInterface/Images/gtk/Request.svg: Optimized.
1916         * UserInterface/Images/gtk/Resources.svg: Optimized.
1917         * UserInterface/Images/gtk/Response.svg: Optimized.
1918         * UserInterface/Images/gtk/ResultLine.svg: Optimized.
1919         * UserInterface/Images/gtk/Resume.svg: Optimized.
1920         * UserInterface/Images/gtk/ShadowDOM.svg: Optimized.
1921         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Optimized.
1922         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Optimized.
1923         * UserInterface/Images/gtk/SplitToggleUp.svg: Optimized.
1924         * UserInterface/Images/gtk/StepInto.svg: Optimized.
1925         * UserInterface/Images/gtk/StepOut.svg: Optimized.
1926         * UserInterface/Images/gtk/StepOver.svg: Optimized.
1927         * UserInterface/Images/gtk/Stop.svg: Optimized.
1928         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Optimized.
1929         * UserInterface/Images/gtk/StyleRuleInherited.svg: Optimized.
1930         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Optimized.
1931         * UserInterface/Images/gtk/StyleRuleInspector.svg: Optimized.
1932         * UserInterface/Images/gtk/StyleRuleUser.svg: Optimized.
1933         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Optimized.
1934         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Optimized.
1935         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Optimized.
1936         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Optimized.
1937         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Optimized.
1938         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Optimized.
1939         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Optimized.
1940         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Optimized.
1941         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Optimized.
1942         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Optimized.
1943         * UserInterface/Images/gtk/TypeBoolean.svg: Optimized.
1944         * UserInterface/Images/gtk/TypeNull.svg: Optimized.
1945         * UserInterface/Images/gtk/TypeNumber.svg: Optimized.
1946         * UserInterface/Images/gtk/TypeObject.svg: Optimized.
1947         * UserInterface/Images/gtk/TypeRegex.svg: Optimized. Removed
1948         mistaken extra shape.
1949         * UserInterface/Images/gtk/TypeString.svg: Optimized.
1950         * UserInterface/Images/gtk/TypeSymbol.svg: Optimized. Removed
1951         mistaken extra shape.
1952         * UserInterface/Images/gtk/TypeUndefined.svg: Optimized.
1953         * UserInterface/Images/gtk/Undock.svg: Optimized.
1954         * UserInterface/Images/gtk/UpDownArrows.svg: Optimized.
1955         * UserInterface/Images/gtk/UserInputPrompt.svg: Optimized.
1956         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Optimized.
1957         * UserInterface/Images/gtk/UserInputResult.svg: Optimized.
1958         * UserInterface/Images/gtk/Warning.svg: Optimized.
1959
1960 2015-05-05  Timothy Hatcher  <timothy@apple.com>
1961
1962         REGRESSION: Web Inspector: no way to navigate to a resource/source location from overview timeline view
1963         https://bugs.webkit.org/show_bug.cgi?id=144539
1964
1965         Reviewed by Brian Burg.
1966
1967         * UserInterface/Views/GeneralTreeElement.js:
1968         (WebInspector.GeneralTreeElement.prototype.set status): Call didChange() so the onchange event fires. This allows
1969         TimelineSidebarPanel to update the status element when it goes from a spinner to empty for ResourceTreeElements.
1970         (WebInspector.GeneralTreeElement.prototype.onattach): Don't call _updateStatusElement, just append it if needed.
1971         Calling _updateStatusElement caused DOMNodeFragments as status elements to be appended a second time and fail.
1972         * UserInterface/Views/NavigationSidebarPanel.js:
1973         (WebInspector.NavigationSidebarPanel.prototype.treeElementAddedOrChanged):
1974         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
1975         * UserInterface/Views/NetworkTimelineView.js:
1976         (WebInspector.NetworkTimelineView.prototype.canShowContentViewForTreeElement):
1977         (WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement):
1978         (WebInspector.NetworkTimelineView.prototype.treeElementSelected):
1979         (WebInspector.NetworkTimelineView.prototype._dataGridNodeSelected):
1980         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
1981         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked): Deleted.
1982         * UserInterface/Views/OverviewTimelineView.js:
1983         (WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement):
1984         (WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement):
1985         (WebInspector.OverviewTimelineView.prototype._dataGridNodeSelected):
1986         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected): Deleted.
1987         (WebInspector.OverviewTimelineView.prototype._treeElementSelected): Deleted.
1988         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
1989         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked): Deleted.
1990         * UserInterface/Views/RenderingFrameTimelineView.js:
1991         (WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement):
1992         (WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement):
1993         * UserInterface/Views/ResourceTimelineDataGridNode.js:
1994         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent): Don't show a go-to arrow in the Domain column.
1995         (WebInspector.ResourceTimelineDataGridNode.prototype._goToResource): Deleted.
1996         * UserInterface/Views/ScriptTimelineView.js:
1997         (WebInspector.ScriptTimelineView.prototype.canShowContentViewForTreeElement):
1998         (WebInspector.ScriptTimelineView.prototype.showContentViewForTreeElement):
1999         (WebInspector.ScriptTimelineView.prototype.treeElementSelected):
2000         * UserInterface/Views/TimelineRecordTreeElement.js:
2001         (WebInspector.TimelineRecordTreeElement.prototype.get sourceCodeLocation):
2002         * UserInterface/Views/TimelineSidebarPanel.css:
2003         (.sidebar > .panel.navigation.timeline .item:hover:not(.selected) .status .close.status-button):
2004         (.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .status .go-to-arrow.status-button):
2005         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .status .close.status-button):
2006         * UserInterface/Views/TimelineSidebarPanel.js:
2007         (WebInspector.TimelineSidebarPanel.prototype.treeElementAddedOrChanged): Added.
2008         (WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
2009         (WebInspector.TimelineSidebarPanel.prototype._treeElementGoToArrowWasClicked): Added.
2010         (WebInspector.TimelineSidebarPanel.prototype._treeElementCloseButtonClicked): Added.
2011         * UserInterface/Views/TimelineView.js:
2012         (WebInspector.TimelineView):
2013         (WebInspector.TimelineView.prototype.canShowContentViewForTreeElement):
2014         (WebInspector.TimelineView.prototype.showContentViewForTreeElement):
2015         (WebInspector.TimelineView.prototype.treeElementDeselected):
2016         (WebInspector.TimelineView.prototype.treeElementSelected):
2017         (WebInspector.TimelineView.prototype.needsLayout):
2018         (WebInspector.TimelineView.prototype._closeStatusButtonClicked): Deleted.
2019         (WebInspector.TimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2020         * UserInterface/Views/TreeElementStatusButton.css:
2021         (.item > .status > .status-button): Fix an alignment issue with close and go-to arrows being side-by-side.
2022         Does not happen in the final patch because they are mutually exclusive, but still good to fix.
2023
2024 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2025
2026         Web Inspector: Fix some issues with Search tabs
2027         https://bugs.webkit.org/show_bug.cgi?id=144531
2028
2029         Reviewed by Darin Adler.
2030
2031         * UserInterface/Views/ContentView.js:
2032         (WebInspector.ContentView):
2033         (WebInspector.ContentView.isViewable):
2034         Support DOMSearchMatchObject and SourceCodeSearchMatchObject representedObjects. These are usually
2035         handled at a higher level, but cookie restoring requires ContentView to handle them.
2036
2037         * UserInterface/Views/DOMTreeContentView.js:
2038         (WebInspector.DOMTreeContentView):
2039         (WebInspector.DOMTreeContentView.prototype.selectAndRevealDOMNode):
2040         (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
2041         (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
2042         Don't allow restoring the previous selected node when another not has already been selected.
2043
2044         * UserInterface/Views/SearchTabContentView.js:
2045         (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
2046         Allow Script objects to be shown in the Search tab.
2047
2048 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2049
2050         Web Inspector: Source/WebInspectorUI/UserInterface/Images/Logs.svg has unknown attribute "fille"
2051         https://bugs.webkit.org/show_bug.cgi?id=144627
2052
2053         Reviewed by Darin Adler.
2054
2055         * UserInterface/Images/Logs.svg: Change "fille" to "fill".
2056
2057 2015-05-05  Andres Gomez  <agomez@igalia.com>
2058
2059         [GTK] Web Inspector: New Images added in r183339, r183338, r183332, r183323, r182660, and r182186
2060         https://bugs.webkit.org/show_bug.cgi?id=144329
2061
2062         Reviewed by Joseph Pecoraro.
2063
2064         * UserInterface/Images/gtk/Console.svg: Added.
2065         * UserInterface/Images/gtk/Debugger.svg: Added.
2066         * UserInterface/Images/gtk/Elements.svg: Added.
2067         * UserInterface/Images/gtk/Gear.svg: Added.
2068         * UserInterface/Images/gtk/NewTab.svg: Added.
2069         * UserInterface/Images/gtk/NewTabPlus.svg: Added.
2070         * UserInterface/Images/gtk/ReloadToolbar.svg: Added.
2071         * UserInterface/Images/gtk/SearchResults.svg: Added.
2072         * UserInterface/Images/gtk/Storage.svg: Added.
2073         * UserInterface/Images/gtk/Timeline.svg: Added.
2074         * UserInterface/Images/gtk/TimelineRecordRenderingFrame.svg: Added.
2075         * UserInterface/Images/gtk/ToggleLeftSidebar.svg: Added.
2076         * UserInterface/Images/gtk/ToggleRightSidebar.svg: Added.
2077
2078 2015-05-05  Andres Gomez  <agomez@igalia.com>
2079
2080         [GTK] Web Inspector: icons for console.info() messages
2081         https://bugs.webkit.org/show_bug.cgi?id=144461
2082
2083         Reviewed by Joseph Pecoraro.
2084
2085         * UserInterface/Images/gtk/Debug.svg: Added.
2086         * UserInterface/Images/gtk/Info.svg: Added.
2087         * UserInterface/Images/gtk/Log.svg: Added.
2088
2089 2015-05-04  Joseph Pecoraro  <pecoraro@apple.com>
2090
2091         Web Inspector: Always expand initial top level DOM tree nodes when not including the root (frame views)
2092         https://bugs.webkit.org/show_bug.cgi?id=144607
2093
2094         Reviewed by Timothy Hatcher.
2095
2096         * UserInterface/Views/DOMTreeOutline.js:
2097         (WebInspector.DOMTreeOutline.prototype.update):
2098
2099 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2100
2101         Web Inspector: Allow closing and reopening the Debugger tab
2102         https://bugs.webkit.org/show_bug.cgi?id=144536
2103
2104         Reviewed by Joseph Pecoraro.
2105
2106         * UserInterface/Base/Main.js:
2107         (WebInspector._updateNewTabButtonState):
2108         * UserInterface/Views/DebuggerSidebarPanel.js:
2109         (WebInspector.DebuggerSidebarPanel):
2110         (WebInspector.DebuggerSidebarPanel.prototype.closed):
2111         (WebInspector.DebuggerSidebarPanel.prototype._addIssuesForSourceCode):
2112         (WebInspector.DebuggerSidebarPanel.prototype._addResourcesRecursivelyForFrame):
2113         (WebInspector.DebuggerSidebarPanel.prototype._resourceAdded):
2114         (WebInspector.DebuggerSidebarPanel.prototype._addResource):
2115         (WebInspector.DebuggerSidebarPanel.prototype._mainResourceChanged):
2116         (WebInspector.DebuggerSidebarPanel.prototype._scriptAdded):
2117         (WebInspector.DebuggerSidebarPanel.prototype._addScript):
2118         * UserInterface/Views/DebuggerTabContentView.js:
2119         (WebInspector.DebuggerTabContentView):
2120         * UserInterface/Views/NewTabContentView.js:
2121         (WebInspector.NewTabContentView):
2122
2123 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2124
2125         REGRESSION: Web Inspector: FrameTreeElement does not folders properly when loading a page
2126         https://bugs.webkit.org/show_bug.cgi?id=144535
2127
2128         Reviewed by Joseph Pecoraro.
2129
2130         * UserInterface/Views/FolderizedTreeElement.js:
2131         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject): Fix an exception if not in a tree.
2132         (WebInspector.FolderizedTreeElement.prototype.prepareToPopulate):
2133         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
2134
2135 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2136
2137         Web Inspector: Allow closing and reopening the Timelines tab
2138         https://bugs.webkit.org/show_bug.cgi?id=144520
2139
2140         Reviewed by Joseph Pecoraro.
2141
2142         * UserInterface/Base/Main.js:
2143         (WebInspector._updateNewTabButtonState):
2144         * UserInterface/Controllers/TimelineManager.js:
2145         (WebInspector.TimelineManager): No need for a delay now. Call reset().
2146         (WebInspector.TimelineManager.prototype.reset):
2147         (WebInspector.TimelineManager.delayedWork): Deleted.
2148         * UserInterface/Views/ContentBrowserTabContentView.js:
2149         (WebInspector.ContentBrowserTabContentView):
2150         (WebInspector.ContentBrowserTabContentView.prototype.closed):
2151         * UserInterface/Views/LayoutTimelineView.js:
2152         (WebInspector.LayoutTimelineView.prototype.closed): Added. Fixed leak.
2153         * UserInterface/Views/NetworkTimelineView.js:
2154         (WebInspector.NetworkTimelineView.prototype.closed): Added. Fixed leak.
2155         * UserInterface/Views/NewTabContentView.js:
2156         (WebInspector.NewTabContentView): Added Timelines.
2157         * UserInterface/Views/OverviewTimelineView.js:
2158         (WebInspector.OverviewTimelineView.prototype.closed): Added. Fixed leak.
2159         * UserInterface/Views/RenderingFrameTimelineView.js:
2160         (WebInspector.RenderingFrameTimelineView.prototype.closed): Added. Fixed leak.
2161         * UserInterface/Views/ScriptTimelineView.js:
2162         (WebInspector.ScriptTimelineView.prototype.closed):
2163         * UserInterface/Views/SearchTabContentView.js:
2164         (WebInspector.SearchTabContentView.prototype.closed): Deleted. Made generic
2165         in ContentBrowserTabContentView.prototype.closed.
2166         * UserInterface/Views/TabBrowser.js:
2167         (WebInspector.TabBrowser.prototype._tabBarItemSelected): Fix a potential exception
2168         when selectedTabBarItem is null.
2169         * UserInterface/Views/TimelineSidebarPanel.js:
2170         (WebInspector.TimelineSidebarPanel):
2171         (WebInspector.TimelineSidebarPanel.prototype.closed):
2172         (WebInspector.TimelineSidebarPanel._recordingCreated): Call _addRecording.
2173         (WebInspector.TimelineSidebarPanel._addRecording): Added.
2174         * UserInterface/Views/TimelineTabContentView.js:
2175         (WebInspector.TimelineTabContentView):
2176
2177 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2178
2179         Web Inspector: Switching recordings in the Timeline navigation bar is broken
2180         https://bugs.webkit.org/show_bug.cgi?id=144519
2181
2182         Reviewed by Joseph Pecoraro.
2183
2184         * UserInterface/Views/ContentBrowser.js:
2185         (WebInspector.ContentBrowser.prototype._hierarchicalPathComponentWasSelected): Use revealAndSelect
2186         on the TreeElement instead of showing the representedObject directly. This fixes an exception in
2187         TimelineRecordingContentView where it wouldn't be initialized with the TimelineSidebarPanel extra argument.
2188         * UserInterface/Views/TimelineOverview.js:
2189         (WebInspector.TimelineOverview.prototype.get visibleDuration): Fix an annoying assert. We show the view
2190         early in construction, before it is in the document. Future updateLayout calls work and fix this.
2191         * UserInterface/Views/TimelineRecordingContentView.js:
2192         (WebInspector.TimelineRecordingContentView.prototype.shown): Call _currentContentViewDidChange
2193         to trigger the sidebar to update when this recording view is shown.
2194         * UserInterface/Views/TimelineSidebarPanel.js:
2195         (WebInspector.TimelineSidebarPanel.prototype._recordingsTreeElementSelected): Moved code from here...
2196         (WebInspector.TimelineSidebarPanel.prototype._recordingSelected): ... to here. Take two different paths
2197         to state restoration here. If the view existed before, use its state. If now, use the current state that
2198         is captured by the cookie logic and explicitly restore it.
2199
2200 2015-05-03  Timothy Hatcher  <timothy@apple.com>
2201
2202         Web Inspector: Exception under ContentViewContainer _disassociateFromContentView
2203         https://bugs.webkit.org/show_bug.cgi?id=144546
2204
2205         Reviewed by Brian Burg.
2206
2207         * UserInterface/Views/ContentViewContainer.js:
2208         (WebInspector.ContentViewContainer.prototype.showContentView):
2209         Make sure to pass the ContentView to _disassociateFromContentView. Also negate the result
2210         of the _backForwardList.some(), since we don't want to dissociate if the content view is
2211         still in the back-forward list.
2212
2213 2015-05-02  Matt Baker  <mattbaker@apple.com>
2214
2215         Web Inspector: Relocate the selected range details in the Rendering Frames timeline UI
2216         https://bugs.webkit.org/show_bug.cgi?id=144346
2217
2218         This patch removes the details sidebar used by the rendering frames view, and relocates the frame selection
2219         chart the Timelines navigation sidebar.
2220
2221         Reviewed by Timothy Hatcher.
2222
2223         * Localizations/en.lproj/localizedStrings.js:
2224         * UserInterface/Base/Main.js:
2225         (WebInspector.contentLoaded):
2226         RenderingFramesDetailsSidebar is no longer used.
2227
2228         * UserInterface/Controllers/TimelineManager.js:
2229         (WebInspector.TimelineManager.prototype._loadNewRecording):
2230         Reordered timelines.
2231
2232         * UserInterface/Main.html:
2233         Removed references to deleted files.
2234
2235         * UserInterface/Views/ChartDetailsSectionLegendRow.js: Removed.
2236         No longer used. The legend is now a child element of the chart.
2237
2238         * UserInterface/Views/ChartDetailsSectionRow.css:
2239         (.details-section > .content > .group > .row.chart > .title):
2240         (.details-section > .content > .group > .row.chart > .chart-content):
2241         (.details-section > .content > .group > .row.chart > .chart-content > .legend):
2242         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item):
2243         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label > .color-swatch):
2244         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label):
2245         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .value):
2246         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > *):
2247         New chart and legend styles.
2248
2249         * UserInterface/Views/ChartDetailsSectionRow.js:
2250         (WebInspector.ChartDetailsSectionRow):
2251         (WebInspector.ChartDetailsSectionRow.prototype.set title):
2252         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2253         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius):
2254         (WebInspector.ChartDetailsSectionRow.prototype.get total):
2255         (WebInspector.ChartDetailsSectionRow.set data):
2256         (WebInspector.ChartDetailsSectionRow.prototype.set data):
2257         (WebInspector.ChartDetailsSectionRow.prototype._createLegendItem):
2258         (WebInspector.ChartDetailsSectionRow.prototype._refresh):
2259
2260         A few changes have been made to the appearance and behavior of the chart. A chart title can now be set,
2261         and the legend appears to the right of the chart rather than in a separate details group.
2262
2263         The chart now has better support for adding empty data points, ensuring that a meaningful legend is shown even
2264         when no rendering frames are selected in the timeline overview graph. This ensures that the task associated
2265         with each colored frame segment is apparent, without having to make a selection or record a timeline.
2266
2267         * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js: Removed.
2268         No longer used.
2269
2270         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
2271         Reduced maximum timeline height to increase the height of short frames.
2272
2273         * UserInterface/Views/RenderingFrameTimelineView.js:
2274         (WebInspector.RenderingFrameTimelineView.prototype.shown):
2275         (WebInspector.RenderingFrameTimelineView.prototype.hidden):
2276         RenderingFramesDetailsSidebar is no longer used.
2277
2278         * UserInterface/Views/TimelineRecordingContentView.js:
2279         (WebInspector.TimelineRecordingContentView):
2280         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
2281         (WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
2282         (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
2283         (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
2284         (WebInspector.TimelineRecordingContentView.prototype._updateFrameSelection):
2285         Improved logic for updating the frame selection.
2286
2287         * UserInterface/Views/TimelineSidebarPanel.css:
2288         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > div.header):
2289         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > .content > .group > .row.chart):
2290         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > .content > .group > .row.chart > .chart-content > .chart):
2291         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content): Deleted.
2292         New chart styles.
2293
2294         * UserInterface/Views/TimelineSidebarPanel.js:
2295         (WebInspector.TimelineSidebarPanel):
2296         (WebInspector.TimelineSidebarPanel.prototype.shown):
2297         (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
2298         (WebInspector.TimelineSidebarPanel.this._timelineTreeElementMap.get select):
2299         (WebInspector.TimelineSidebarPanel.get else):
2300         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.getSelectedRecords.get var):
2301         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.getSelectedRecords):
2302         (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
2303         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
2304         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
2305         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.durationForRecordType):
2306         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
2307         (WebInspector.TimelineSidebarPanel.set contentTreeOutlineLabel): Deleted.
2308         (WebInspector.TimelineSidebarPanel._recordingCreated.set this): Deleted.
2309         (WebInspector.TimelineSidebarPanel.get this): Deleted.
2310         Moved the selected frames chart to the navigation sidebar.
2311
2312         * UserInterface/Views/TimelineTabContentView.js:
2313         (WebInspector.TimelineTabContentView):
2314         RenderingFramesDetailsSidebar is no longer used.
2315
2316         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2317         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2318         Removed references to deleted files.
2319
2320 2015-05-02  Timothy Hatcher  <timothy@apple.com>
2321
2322         Web Inspector: Allow closing and reopening the Resources tab
2323         https://bugs.webkit.org/show_bug.cgi?id=144513
2324
2325         Reviewed by Joseph Pecoraro.
2326
2327         * UserInterface/Base/Main.js:
2328         (WebInspector._updateNewTabButtonState):
2329         * UserInterface/Views/NewTabContentView.js:
2330         (WebInspector.NewTabContentView):
2331         * UserInterface/Views/ResourceSidebarPanel.js:
2332         (WebInspector.ResourceSidebarPanel):
2333         (WebInspector.ResourceSidebarPanel.prototype.closed):
2334         * UserInterface/Views/ResourcesTabContentView.js:
2335         (WebInspector.ResourcesTabContentView):
2336
2337 2015-05-02  Timothy Hatcher  <timothy@apple.com>
2338
2339         Web Inspector: REGRESSION: Resources section doesn't update after changes are made to a local file
2340         https://bugs.webkit.org/show_bug.cgi?id=144512
2341
2342         The content view was being associated with the wrong represented object. This caused the code to use
2343         the old main resource when showing the frame again.
2344
2345         Reviewed by Joseph Pecoraro.
2346
2347         * UserInterface/Base/Main.js:
2348         (WebInspector._frameWasAdded.delayedWork):
2349         (WebInspector._frameWasAdded):
2350         With the changes in ResourceSidebarPanel, we need to delay showing the frame.
2351
2352         * UserInterface/Views/ContentBrowserTabContentView.js:
2353         (WebInspector.ContentBrowserTabContentView.prototype.showRepresentedObject):
2354         Avoid restoring state by calling cancelRestoringState(). Not fully related to this bug,
2355         but it was preventing testing the cases.
2356
2357         * UserInterface/Views/ContentViewContainer.js:
2358         (WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
2359         This fixes the bug. Don't associate the content view with the Frame, associate it with
2360         the Resource that we actually show.
2361
2362         * UserInterface/Views/NavigationSidebarPanel.js:
2363         (WebInspector.NavigationSidebarPanel.prototype.cancelRestoringState): Added.
2364
2365         * UserInterface/Views/ResourceSidebarPanel.js:
2366         (WebInspector.ResourceSidebarPanel): Remove unused _waitingForInitialMainFrame.
2367         (WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
2368         (WebInspector.ResourceSidebarPanel.prototype._mainResourceDidChange):
2369         (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
2370         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2371         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2372         Clean up how we show the main frame in the sidebar. This was a two step mess before.
2373
2374 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2375
2376         Web Inspector: Remove FrameContentView.js
2377         https://bugs.webkit.org/show_bug.cgi?id=144415
2378
2379         Reviewed by Joseph Pecoraro.
2380
2381         * UserInterface/Images/DOMTree.svg: Removed.
2382         * UserInterface/Images/SourceCode.svg: Removed.
2383         * UserInterface/Main.html: Removed FrameContentView.js.
2384         * UserInterface/Views/FrameContentView.js: Removed.
2385         * UserInterface/Views/PathComponentIcons.css:
2386         (.source-code-icon .icon): Deleted.
2387         (.dom-tree-icon .icon): Deleted.
2388
2389         * UserInterface/Views/ResourceSidebarPanel.js:
2390         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2391         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2392         Simplify the code here. We don't need these checks now with tabs and the Storage tab.
2393
2394 2015-04-30  Nikita Vasilyev  <nvasilyev@apple.com>
2395
2396         REGRESSION: Web Inspector: Console message repeat count overlapped by icon
2397         https://bugs.webkit.org/show_bug.cgi?id=144344
2398
2399         Reviewed by Timothy Hatcher.
2400
2401         * UserInterface/Views/ConsoleMessageView.css:
2402         (.console-message .repeat-count):
2403
2404 2015-04-30  Jon Davis  <jond@apple.com>
2405
2406         Web Inspector: console should show an icon for console.info() messages
2407         https://bugs.webkit.org/show_bug.cgi?id=18530
2408
2409         Reviewed by Timothy Hatcher.
2410
2411         Added icons for console.log, console.info and console.debug messages.
2412
2413         Separated console.info from console.log.
2414
2415         * UserInterface/Images/Debug.svg: Added.
2416         * UserInterface/Images/Info.svg: Added.
2417         * UserInterface/Images/Log.svg: Added.
2418         New icon files.
2419
2420         * UserInterface/Models/ConsoleMessage.js:
2421         * UserInterface/Views/ConsoleMessageView.css:
2422         (.console-log-level::before):
2423         (.console-info-level::before):
2424         (.console-debug-level::before):
2425         (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level).console-message):
2426         (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level)::before):
2427         (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message): Deleted.
2428         (:matches(.console-warning-level, .console-error-level, .console-log-level)::before): Deleted.
2429         Include console.info messages in layout adjustments.
2430
2431         * UserInterface/Views/ConsoleMessageView.js:
2432         (WebInspector.ConsoleMessageView):
2433         (WebInspector.ConsoleMessageView.prototype._levelString):
2434
2435 2015-04-30  Timothy Hatcher  <timothy@apple.com>
2436
2437         Web Inspector: Scope Chain sidebar should be selected immediately when paused
2438         https://bugs.webkit.org/show_bug.cgi?id=144352
2439
2440         Reviewed by Joseph Pecoraro.
2441
2442         * UserInterface/Base/Main.js:
2443         (WebInspector.showDebuggerTab): Added showScopeChainDetailsSidebarPanel argument.
2444         (WebInspector._debuggerDidPause): Pass true for showScopeChainDetailsSidebarPanel.
2445         * UserInterface/Views/ContentBrowserTabContentView.js:
2446         (WebInspector.ContentBrowserTabContentView): Wire the event to showDetailsSidebarPanels instead of
2447         _contentBrowserRepresentedObjectsDidChange, allowing subclasses to do work during the event.
2448         (WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels): Moved content of
2449         _contentBrowserRepresentedObjectsDidChange here.
2450         (WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange): Deleted.
2451         * UserInterface/Views/DebuggerTabContentView.js:
2452         (WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels): Added. Show the scope sidebar panel
2453         if it is available and it was requested by showScopeChainDetailsSidebarPanel().
2454         (WebInspector.DebuggerTabContentView.prototype.showScopeChainDetailsSidebarPanel): Added.
2455
2456 2015-04-30  Andres Gomez  <agomez@igalia.com>
2457
2458         [GTK] Web Inspector: New Images for ObjectTreeView - Setter
2459         https://bugs.webkit.org/show_bug.cgi?id=143173
2460
2461         Reviewed by Martin Robinson.
2462
2463         * UserInterface/Images/gtk/Pencil.svg: Added.
2464
2465 2015-04-30  Andres Gomez  <agomez@igalia.com>
2466
2467         [GTK] Web Inspector: Remove some unused Images
2468         https://bugs.webkit.org/show_bug.cgi?id=144445
2469
2470         Reviewed by Carlos Garcia Campos.
2471
2472         * UserInterface/Images/gtk/BottomUpTree.svg: Removed.
2473         * UserInterface/Images/gtk/Log.png: Removed.
2474         * UserInterface/Images/gtk/Log@2x.png: Removed.
2475         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Removed.
2476         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Removed.
2477         * UserInterface/Images/gtk/NavigationItemBug.svg: Removed.
2478         * UserInterface/Images/gtk/NavigationItemFile.svg: Removed.
2479         * UserInterface/Images/gtk/NavigationItemLayers.svg: Removed.
2480         * UserInterface/Images/gtk/NavigationItemLog.svg: Removed.
2481         * UserInterface/Images/gtk/NavigationItemProbes.svg: Removed.
2482         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Removed.
2483         * UserInterface/Images/gtk/NavigationItemStorage.svg: Removed.
2484         * UserInterface/Images/gtk/NavigationItemVariable.svg: Removed.
2485         * UserInterface/Images/gtk/Percent.svg: Removed.
2486         * UserInterface/Images/gtk/Reload.svg: Removed.
2487         * UserInterface/Images/gtk/SplitToggleDown.svg: Removed.
2488         * UserInterface/Images/gtk/Time.svg: Removed.
2489         * UserInterface/Images/gtk/Weight.svg: Removed.
2490
2491 2015-04-30  Joseph Pecoraro  <pecoraro@apple.com>
2492
2493         Web Inspector: Copy not working in Console
2494         https://bugs.webkit.org/show_bug.cgi?id=144354
2495
2496         Reviewed by Timothy Hatcher.
2497
2498         * UserInterface/Base/Main.js:
2499         (WebInspector._focusedContentView):
2500         Select the inner most content view to check if handleCopyEvent exists.
2501         Previously we were stopping at the top level TabContentView.
2502
2503 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2504
2505         Web Inspector: Remove some unused Images
2506         https://bugs.webkit.org/show_bug.cgi?id=144412
2507
2508         Reviewed by Joseph Pecoraro.
2509
2510         * UserInterface/Images/BottomUpTree.svg: Removed.
2511         * UserInterface/Images/Log.png: Removed.
2512         * UserInterface/Images/Log@2x.png: Removed.
2513         * UserInterface/Images/NavigationItemAngleBrackets.svg: Removed.
2514         * UserInterface/Images/NavigationItemBrushAndRuler.svg: Removed.
2515         * UserInterface/Images/NavigationItemBug.svg: Removed.
2516         * UserInterface/Images/NavigationItemDoughnutChart.svg: Removed.
2517         * UserInterface/Images/NavigationItemFile.svg: Removed.
2518         * UserInterface/Images/NavigationItemLayers.svg: Removed.
2519         * UserInterface/Images/NavigationItemLog.svg: Removed.
2520         * UserInterface/Images/NavigationItemProbes.svg: Removed.
2521         * UserInterface/Images/NavigationItemStopwatch.svg: Removed.
2522         * UserInterface/Images/NavigationItemStorage.svg: Removed.
2523         * UserInterface/Images/NavigationItemVariable.svg: Removed.
2524         * UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Removed.
2525         * UserInterface/Images/NetworkBarLabelCalloutRight.svg: Removed.
2526         * UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Removed.
2527         * UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Removed.
2528         * UserInterface/Images/Percent.svg: Removed.
2529         * UserInterface/Images/Reload.svg: Removed.
2530         * UserInterface/Images/SplitToggleDown.svg: Removed.
2531         * UserInterface/Images/Time.svg: Removed.
2532         * UserInterface/Images/Weight.svg: Removed.
2533
2534 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2535
2536         Web Inspector: Split Storage from Resources tab
2537         https://bugs.webkit.org/show_bug.cgi?id=144404
2538
2539         Reviewed by Joseph Pecoraro.
2540
2541         * Localizations/en.lproj/localizedStrings.js:
2542         * UserInterface/Base/Main.js:
2543         (WebInspector.loaded):
2544         (WebInspector.isTabTypeAllowed):
2545         (WebInspector._tabContentViewForType):
2546         (WebInspector._updateNewTabButtonState):
2547         (WebInspector.showStorageTab):
2548         (WebInspector._storageWasInspected):
2549         * UserInterface/Controllers/ApplicationCacheManager.js:
2550         (WebInspector.ApplicationCacheManager.prototype.initialize):
2551         (WebInspector.ApplicationCacheManager.prototype.get applicationCacheObjects):
2552         * UserInterface/Controllers/StorageManager.js:
2553         (WebInspector.StorageManager.prototype.get domStorageObjects):
2554         (WebInspector.StorageManager.prototype.get databases):
2555         (WebInspector.StorageManager.prototype.get indexedDatabases):
2556         (WebInspector.StorageManager.prototype.get cookieStorageObjects):
2557         * UserInterface/Images/Storage.svg: Added.
2558         * UserInterface/Main.html:
2559         * UserInterface/Views/DatabaseTableContentView.js:
2560         (WebInspector.DatabaseTableContentView.prototype._queryFinished): Clear _dataGrid,
2561         since it might have been allocated but still be empty. This avoids an exception in
2562         updateLayout next time layout is updated.
2563         * UserInterface/Views/NewTabContentView.js:
2564         (WebInspector.NewTabContentView):
2565         * UserInterface/Views/ResourceSidebarPanel.js:
2566         (WebInspector.ResourceSidebarPanel):
2567         (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
2568         (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded): Deleted.
2569         (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasInspected): Deleted.
2570         (WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded): Deleted.
2571         (WebInspector.ResourceSidebarPanel.prototype._databaseWasInspected): Deleted.
2572         (WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded): Deleted.
2573         (WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded): Deleted.
2574         (WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded): Deleted.
2575         (WebInspector.ResourceSidebarPanel.prototype._frameManifestRemoved): Deleted.
2576         (WebInspector.ResourceSidebarPanel.prototype._addStorageChild): Deleted.
2577         (WebInspector.ResourceSidebarPanel.prototype._storageCleared): Deleted.
2578         * UserInterface/Views/ResourcesTabContentView.js:
2579         (WebInspector.ResourcesTabContentView):
2580         (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
2581         * UserInterface/Views/StorageSidebarPanel.js: Added.
2582         (WebInspector.StorageSidebarPanel):
2583         (WebInspector.StorageSidebarPanel.prototype.showDefaultContentView):
2584         (WebInspector.StorageSidebarPanel.prototype.closed):
2585         (WebInspector.StorageSidebarPanel.prototype._treeElementSelected):
2586         (WebInspector.StorageSidebarPanel.prototype._domStorageObjectWasAdded):
2587         (WebInspector.StorageSidebarPanel.prototype._addDOMStorageObject):
2588         (WebInspector.StorageSidebarPanel.prototype._domStorageObjectWasInspected):
2589         (WebInspector.StorageSidebarPanel.prototype._databaseWasAdded):
2590         (WebInspector.StorageSidebarPanel.prototype._addDatabase):
2591         (WebInspector.StorageSidebarPanel.prototype._databaseWasInspected):
2592         (WebInspector.StorageSidebarPanel.prototype._indexedDatabaseWasAdded):
2593         (WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
2594         (WebInspector.StorageSidebarPanel.prototype._cookieStorageObjectWasAdded):
2595         (WebInspector.StorageSidebarPanel.prototype._addCookieStorageObject):
2596         (WebInspector.StorageSidebarPanel.prototype._frameManifestAdded):
2597         (WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
2598         (WebInspector.StorageSidebarPanel.prototype._frameManifestRemoved):
2599         (WebInspector.StorageSidebarPanel.prototype._compareTreeElements):
2600         (WebInspector.StorageSidebarPanel.prototype._addStorageChild):
2601         (WebInspector.StorageSidebarPanel.prototype._storageCleared):
2602         * UserInterface/Views/StorageTabContentView.js: Copied from Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js.
2603         (WebInspector.StorageTabContentView):
2604         (WebInspector.StorageTabContentView.prototype.get type):
2605         (WebInspector.StorageTabContentView.prototype.canShowRepresentedObject):
2606
2607 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2608
2609         Web Inspector: Remove Legacy images and styles
2610         https://bugs.webkit.org/show_bug.cgi?id=144390
2611
2612         Reviewed by Joseph Pecoraro.
2613
2614         * UserInterface/Base/ImageUtilities.js:
2615         (.generateImage):
2616         (.generateImage.generateLegacyImage): Deleted.
2617         * UserInterface/Base/Main.js:
2618         (WebInspector.contentLoaded):
2619         (WebInspector._updateToolbarHeight):
2620         * UserInterface/Base/Platform.js:
2621         * UserInterface/Controllers/TimelineManager.js:
2622         (WebInspector.TimelineManager.prototype._loadNewRecording):
2623         * UserInterface/Images/Legacy/BackArrow.svg: Removed.
2624         * UserInterface/Images/Legacy/Breakpoints.svg: Removed.
2625         * UserInterface/Images/Legacy/Close.svg: Removed.
2626         * UserInterface/Images/Legacy/CloseLarge.svg: Removed.
2627         * UserInterface/Images/Legacy/Colors.png: Removed.
2628         * UserInterface/Images/Legacy/Colors@2x.png: Removed.
2629         * UserInterface/Images/Legacy/ColorsLarge.png: Removed.
2630         * UserInterface/Images/Legacy/ColorsLarge@2x.png: Removed.
2631         * UserInterface/Images/Legacy/DockBottom.svg: Removed.
2632         * UserInterface/Images/Legacy/DockRight.svg: Removed.
2633         * UserInterface/Images/Legacy/DownloadArrow.svg: Removed.
2634         * UserInterface/Images/Legacy/Errors.svg: Removed.
2635         * UserInterface/Images/Legacy/ErrorsEnabled.svg: Removed.
2636         * UserInterface/Images/Legacy/FilterFieldGlyph.svg: Removed.
2637         * UserInterface/Images/Legacy/FolderGeneric.png: Removed.
2638         * UserInterface/Images/Legacy/FolderGeneric@2x.png: Removed.
2639         * UserInterface/Images/Legacy/ForwardArrow.svg: Removed.
2640         * UserInterface/Images/Legacy/Issues.svg: Removed.
2641         * UserInterface/Images/Legacy/IssuesEnabled.svg: Removed.
2642         * UserInterface/Images/Legacy/LayerBorders.svg: Removed.
2643         * UserInterface/Images/Legacy/Logs.svg: Removed.
2644         * UserInterface/Images/Legacy/NavigationItemCurleyBraces.svg: Removed.
2645         * UserInterface/Images/Legacy/NavigationItemTrash.svg: Removed.
2646         * UserInterface/Images/Legacy/Network.png: Removed.
2647         * UserInterface/Images/Legacy/Network@2x.png: Removed.
2648         * UserInterface/Images/Legacy/NetworkLarge.png: Removed.
2649         * UserInterface/Images/Legacy/NetworkLarge@2x.png: Removed.
2650         * UserInterface/Images/Legacy/Pause.svg: Removed.
2651         * UserInterface/Images/Legacy/Plus.svg: Removed.
2652         * UserInterface/Images/Legacy/Recording.png: Removed.
2653         * UserInterface/Images/Legacy/Recording@2x.png: Removed.
2654         * UserInterface/Images/Legacy/RecordingHovered.png: Removed.
2655         * UserInterface/Images/Legacy/RecordingHovered@2x.png: Removed.
2656         * UserInterface/Images/Legacy/RecordingStopped.png: Removed.
2657         * UserInterface/Images/Legacy/RecordingStopped@2x.png: Removed.
2658         * UserInterface/Images/Legacy/Reload.svg: Removed.
2659         * UserInterface/Images/Legacy/Resources.svg: Removed.
2660         * UserInterface/Images/Legacy/Resume.svg: Removed.
2661         * UserInterface/Images/Legacy/ShadowDOM.svg: Removed.
2662         * UserInterface/Images/Legacy/SortIndicatorDownArrow.svg: Removed.
2663         * UserInterface/Images/Legacy/SortIndicatorUpArrow.svg: Removed.
2664         * UserInterface/Images/Legacy/SplitToggleDown.svg: Removed.
2665         * UserInterface/Images/Legacy/SplitToggleUp.svg: Removed.
2666         * UserInterface/Images/Legacy/StepInto.svg: Removed.
2667         * UserInterface/Images/Legacy/StepOut.svg: Removed.
2668         * UserInterface/Images/Legacy/StepOver.svg: Removed.
2669         * UserInterface/Images/Legacy/Time.svg: Removed.
2670         * UserInterface/Images/Legacy/Undock.svg: Removed.
2671         * UserInterface/Images/Legacy/UpDownArrows.svg: Removed.
2672         * UserInterface/Images/Legacy/Weight.svg: Removed.
2673         * UserInterface/Views/ButtonNavigationItem.css:
2674         (body.mac-platform.legacy .navigation-bar .item.button.text-only): Deleted.
2675         * UserInterface/Views/ButtonToolbarItem.css:
2676         (body.mac-platform.legacy .toolbar .item.button > .label): Deleted.
2677         * UserInterface/Views/CSSStyleDeclarationSection.css:
2678         (body.mac-platform.legacy .style-declaration-section): Deleted.
2679         (body.mac-platform.legacy .style-declaration-section + .style-declaration-section): Deleted.
2680         (body.mac-platform.legacy .style-declaration-section.last-in-group): Deleted.
2681         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section): Deleted.
2682         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)): Deleted.
2683         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
2684         (body.mac-platform.legacy .sidebar > .panel.details.css-style > .content): Deleted.
2685         * UserInterface/Views/ContentBrowser.js:
2686         (WebInspector.ContentBrowser):
2687         * UserInterface/Views/ControlToolbarItem.css:
2688         (body.mac-platform.legacy .toolbar .item.control): Deleted.
2689         (body.mac-platform.legacy .toolbar .item.control:hover): Deleted.
2690         * UserInterface/Views/DOMTreeContentView.js:
2691         (WebInspector.DOMTreeContentView):
2692         * UserInterface/Views/DOMTreeOutline.css:
2693         (body.mac-platform.legacy .dom-tree-outline li.hovered:not(.selected) .selection): Deleted.
2694         (body.mac-platform.legacy .dom-tree-outline li.elements-drag-over .selection): Deleted.
2695         (body.mac-platform.legacy .dom-tree-outline:focus li.selected .selection): Deleted.
2696         * UserInterface/Views/DashboardContainerView.css:
2697         (body.mac-platform.legacy .toolbar .dashboard-container): Deleted.
2698         (body.mac-platform.legacy.window-inactive .toolbar .dashboard-container): Deleted.
2699         (body.mac-platform.legacy.window-inactive .toolbar .dashboard): Deleted.
2700         (body.mac-platform.legacy .dashboard-container .advance-arrow): Deleted.
2701         * UserInterface/Views/DataGrid.css:
2702         (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)): Deleted.
2703         (body.mac-platform.legacy .data-grid:focus tr.selected): Deleted.
2704         * UserInterface/Views/DataGrid.js:
2705         (WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
2706         * UserInterface/Views/DatabaseTableContentView.js:
2707         (WebInspector.DatabaseTableContentView):
2708         * UserInterface/Views/DebuggerDashboardView.js:
2709         (WebInspector.DebuggerDashboardView):
2710         * UserInterface/Views/DebuggerSidebarPanel.css:
2711         (body.mac-platform.legacy .sidebar > .panel.navigation.debugger > .content): Deleted.
2712         * UserInterface/Views/DebuggerSidebarPanel.js:
2713         * UserInterface/Views/DefaultDashboardView.css:
2714         (body.mac-platform.legacy .toolbar .dashboard.default > .item): Deleted.
2715         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img): Deleted.
2716         (body.mac-platform.legacy .toolbar .dashboard.default > .logs > img): Deleted.
2717         (body.mac-platform.legacy .toolbar .dashboard.default > .errors > img): Deleted.
2718         (body.mac-platform.legacy .toolbar .dashboard.default > .errors.enabled > img): Deleted.
2719         (body.mac-platform.legacy .toolbar .dashboard.default > .issues > img): Deleted.
2720         (body.mac-platform.legacy .toolbar .dashboard.default > .issues.enabled > img): Deleted.
2721         * UserInterface/Views/DetailsSection.css:
2722         (body.mac-platform.legacy .details-section): Deleted.
2723         (body.mac-platform.legacy .details-section .details-section): Deleted.
2724         (body.mac-platform.legacy .details-section .details-section:first-child): Deleted.
2725         (body.mac-platform.legacy .details-section > .header): Deleted.
2726         (body.mac-platform.legacy .details-section .details-section > .header): Deleted.
2727         (body.mac-platform.legacy .details-section .details-section.collapsed > .header): Deleted.
2728         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline): Deleted.
2729         (body.mac-platform.legacy .details-section.computed-style-properties:not(.collapsed) > .header): Deleted.
2730         (body.mac-platform.legacy .details-section > .content > .group): Deleted.
2731         (body.mac-platform.legacy .details-section > .content > .group:nth-child(even)): Deleted.
2732         (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *): Deleted.
2733         (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)): Deleted.
2734         * UserInterface/Views/DividerNavigationItem.css:
2735         (.navigation-bar .item.divider):
2736         (body.mac-platform.legacy .navigation-bar .item.divider): Deleted.
2737         * UserInterface/Views/FilterBar.css:
2738         (.filter-bar > input[type="search"]::-webkit-search-decoration):
2739         (body.mac-platform.legacy .filter-bar): Deleted.
2740         (body.mac-platform.legacy .filter-bar > input[type="search"]): Deleted.
2741         (body.mac-platform.legacy .filter-bar > input[type="search"]::-webkit-search-decoration): Deleted.
2742         * UserInterface/Views/FindBanner.css:
2743         (body.mac-platform.legacy .find-banner > input[type="search"]): Deleted.
2744         (body.mac-platform.legacy .find-banner > button > .glyph): Deleted.
2745         (body.mac-platform.legacy .find-banner > button.segmented.left > .glyph): Deleted.
2746         (body.mac-platform.legacy .find-banner > button.segmented.right > .glyph): Deleted.
2747         (body.mac-platform.legacy .find-banner > button.segmented): Deleted.
2748         * UserInterface/Views/FindBanner.js:
2749         (WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
2750         (WebInspector.FindBanner):
2751         * UserInterface/Views/FolderIcon.css:
2752         (.folder-icon .icon):
2753         (body.mac-platform.legacy .folder-icon .icon): Deleted.
2754         * UserInterface/Views/HierarchicalPathComponent.css:
2755         (body.mac-platform.legacy .hierarchical-path-component > .selector-arrows): Deleted.
2756         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
2757         (WebInspector.IndexedDatabaseObjectStoreContentView):
2758         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
2759         (body.mac-platform.legacy .sidebar > .panel.details.layer-tree > .content): Deleted.
2760         (body.mac-platform.legacy .panel.details.layer-tree .bottom-bar): Deleted.
2761         (body.mac-platform.legacy .panel.details.layer-tree .bottom-bar > div): Deleted.
2762         (body.mac-platform.legacy .layer-tree-popover): Deleted.
2763         * UserInterface/Views/LogContentView.css:
2764         (body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]): Deleted.
2765         * UserInterface/Views/LogContentView.js:
2766         (WebInspector.LogContentView):
2767         * UserInterface/Views/Main.css:
2768         (body.mac-platform.legacy:not(.docked)): Deleted.
2769         (body.docked.bottom.mac-platform.legacy): Deleted.
2770         (body.docked.right.mac-platform.legacy): Deleted.
2771         (body.mac-platform.legacy #split-content-browser > .navigation-bar): Deleted.
2772         * UserInterface/Views/NavigationBar.css:
2773         (.navigation-bar .item):
2774         (body.mac-platform.legacy .navigation-bar): Deleted.
2775         (body.mac-platform.legacy .navigation-bar .item): Deleted.
2776         * UserInterface/Views/NavigationSidebarPanel.css:
2777         (body.mac-platform.legacy .sidebar > .panel.navigation > .content): Deleted.
2778         (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow): Deleted.
2779         (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow.top): Deleted.
2780         (body.mac-platform.legacy .sidebar > .panel.navigation > .empty-content-placeholder): Deleted.
2781         (body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
2782         (body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline:focus .item.selected): Deleted.
2783         (body.mac-platform.legacy.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
2784         * UserInterface/Views/NavigationSidebarPanel.js:
2785         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2786         (WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):
2787         * UserInterface/Views/Popover.js:
2788         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
2789         (body.mac-platform.legacy .details-section.probe-set .options > .probe-clear-samples): Deleted.
2790         (body.mac-platform.legacy .details-section.probe-set .options > .probe-remove): Deleted.
2791         (body.mac-platform.legacy .details-section.probe-set .options > .probe-add): Deleted.
2792         * UserInterface/Views/QuickConsole.css:
2793         (body.mac-platform.legacy .quick-console): Deleted.
2794         * UserInterface/Views/RadioButtonNavigationItem.css:
2795         (.navigation-bar .item.radio.button.text-only.selected:active):
2796         (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:hover): Deleted.
2797         (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected): Deleted.
2798         (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active): Deleted.
2799         * UserInterface/Views/RulesStyleDetailsPanel.css:
2800         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .label + .style-declaration-section): Deleted.
2801         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule): Deleted.
2802         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section): Deleted.
2803         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
2804         * UserInterface/Views/ScopeBar.css:
2805         (.scope-bar > li.selected:active):
2806         (body.mac-platform.legacy .scope-bar > li): Deleted.
2807         (body.mac-platform.legacy .scope-bar > li:hover): Deleted.
2808         (body.mac-platform.legacy .scope-bar > li.selected): Deleted.
2809         (body.mac-platform.legacy .scope-bar > li:active): Deleted.
2810         (body.mac-platform.legacy .scope-bar > li.selected:active): Deleted.
2811         * UserInterface/Views/ScriptContentView.js:
2812         (WebInspector.ScriptContentView):
2813         * UserInterface/Views/SearchBar.css:
2814         (body.mac-platform.legacy .search-bar > input[type="search"]): Deleted.
2815         * UserInterface/Views/SearchSidebarPanel.css:
2816         (.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
2817         (body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)): Deleted.
2818         (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar): Deleted.
2819         (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]): Deleted.
2820         * UserInterface/Views/Sidebar.css:
2821         (body.window-inactive .sidebar.right):
2822         (body.mac-platform.legacy .sidebar): Deleted.
2823         (body.mac-platform.legacy.window-inactive .sidebar): Deleted.
2824         (body.mac-platform.legacy .sidebar.right): Deleted.
2825         * UserInterface/Views/TextContentView.js:
2826         (WebInspector.TextContentView):
2827         * UserInterface/Views/TextResourceContentView.js:
2828         (WebInspector.TextResourceContentView):
2829         * UserInterface/Views/TimelineDataGrid.css:
2830         (body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar): Deleted.
2831         * UserInterface/Views/TimelineIcons.css:
2832         (body.mac-platform.legacy .network-icon .icon): Deleted.
2833         (body.mac-platform.legacy .network-icon.large .icon): Deleted.
2834         (body.mac-platform.legacy .colors-icon .icon): Deleted.
2835         (body.mac-platform.legacy .colors-icon.large .icon): Deleted.
2836         * UserInterface/Views/TimelineRecordingContentView.js:
2837         (WebInspector.TimelineRecordingContentView):
2838         * UserInterface/Views/TimelineRuler.css:
2839         (body.mac-platform.legacy .timeline-ruler > .header): Deleted.
2840         (body.mac-platform.legacy .timeline-ruler > .selection-drag): Deleted.
2841         (body.mac-platform.legacy .timeline-ruler > .selection-handle): Deleted.
2842         * UserInterface/Views/TimelineSidebarPanel.css:
2843         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content):
2844         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar): Deleted.
2845         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph): Deleted.
2846         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording): Deleted.
2847         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover): Deleted.
2848         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover): Deleted.
2849         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced): Deleted.
2850         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced): Deleted.
2851         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status): Deleted.
2852         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar): Deleted.
2853         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines): Deleted.
2854         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events): Deleted.
2855         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content): Deleted.
2856         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button): Deleted.
2857         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
2858         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item): Deleted.
2859         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)): Deleted.
2860         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button): Deleted.
2861         * UserInterface/Views/TimelineSidebarPanel.js:
2862         (WebInspector.TimelineSidebarPanel):
2863         * UserInterface/Views/Toolbar.css:
2864         (body.mac-platform:not(.docked) .toolbar):
2865         (body.mac-platform:not(.legacy, .docked) .toolbar): Deleted.
2866         (body.mac-platform.legacy .toolbar): Deleted.
2867         (body.mac-platform.legacy.docked .toolbar): Deleted.
2868         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Deleted.
2869         (body.mac-platform.legacy.window-inactive .toolbar): Deleted.
2870         * UserInterface/Views/TreeElementStatusButton.css:
2871         (body.mac-platform.legacy .item > .status > .status-button > svg .filled): Deleted.
2872         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked): Deleted.
2873
2874 2015-04-29  Andres Gomez  <agomez@igalia.com>
2875
2876         [GTK] Web Inspector: Optimize SVG images
2877         https://bugs.webkit.org/show_bug.cgi?id=143476
2878
2879         SVG images optimized with a combination of sed replacements and
2880         the usage of the scour tool (http://www.codedread.com/scour/).
2881
2882         Also, modified the spelling of the license word to use the US one
2883         in the copyright files.
2884
2885         Reviewed by Martin Robinson.
2886
2887         * UserInterface/Images/gtk/BackArrow.svg:
2888         * UserInterface/Images/gtk/BottomUpTree.svg:
2889         * UserInterface/Images/gtk/BreakpointActionAdd.svg:
2890         * UserInterface/Images/gtk/BreakpointActionRemove.svg:
2891         * UserInterface/Images/gtk/BreakpointButton.svg:
2892         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
2893         * UserInterface/Images/gtk/Breakpoints.svg:
2894         * UserInterface/Images/gtk/COPYING:
2895         * UserInterface/Images/gtk/COPYING_CCBYSA3:
2896         * UserInterface/Images/gtk/Checkers.svg:
2897         * UserInterface/Images/gtk/Circle.svg:
2898         * UserInterface/Images/gtk/Close.svg:
2899         * UserInterface/Images/gtk/CloseLarge.svg:
2900         * UserInterface/Images/gtk/CloseWhite.svg:
2901         * UserInterface/Images/gtk/ContentFlow.svg:
2902         * UserInterface/Images/gtk/Crosshair.svg:
2903         * UserInterface/Images/gtk/DOMCharacterData.svg:
2904         * UserInterface/Images/gtk/DOMComment.svg:
2905         * UserInterface/Images/gtk/DOMDocument.svg:
2906         * UserInterface/Images/gtk/DOMDocumentType.svg:
2907         * UserInterface/Images/gtk/DOMElement.svg:
2908         * UserInterface/Images/gtk/DOMNode.svg:
2909         * UserInterface/Images/gtk/DOMTextNode.svg:
2910         * UserInterface/Images/gtk/DOMTree.svg:
2911         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg:
2912         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg:
2913         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg:
2914         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg:
2915         * UserInterface/Images/gtk/DockBottom.svg:
2916         * UserInterface/Images/gtk/DockRight.svg:
2917         * UserInterface/Images/gtk/DownloadArrow.svg:
2918         * UserInterface/Images/gtk/Error.svg:
2919         * UserInterface/Images/gtk/Errors.svg:
2920         * UserInterface/Images/gtk/ErrorsEnabled.svg:
2921         * UserInterface/Images/gtk/EventListener.svg:
2922         * UserInterface/Images/gtk/Exception.svg:
2923         * UserInterface/Images/gtk/Eye.svg:
2924         * UserInterface/Images/gtk/FilterFieldGlyph.svg:
2925         * UserInterface/Images/gtk/ForwardArrow.svg:
2926         * UserInterface/Images/gtk/Function.svg:
2927         * UserInterface/Images/gtk/GoToArrow.svg:
2928         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg:
2929         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg:
2930         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg:
2931         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg:
2932         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg:
2933         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg:
2934         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg:
2935         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg:
2936         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg:
2937         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg:
2938         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg:
2939         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg:
2940         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg:
2941         * UserInterface/Images/gtk/Issues.svg:
2942         * UserInterface/Images/gtk/IssuesEnabled.svg:
2943         * UserInterface/Images/gtk/LayerBorders.svg:
2944         * UserInterface/Images/gtk/Locked.svg:
2945         * UserInterface/Images/gtk/Logs.svg:
2946         * UserInterface/Images/gtk/Native.svg:
2947         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
2948         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
2949         * UserInterface/Images/gtk/NavigationItemBug.svg:
2950         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:
2951         * UserInterface/Images/gtk/NavigationItemFile.svg:
2952         * UserInterface/Images/gtk/NavigationItemLayers.svg:
2953         * UserInterface/Images/gtk/NavigationItemLog.svg:
2954         * UserInterface/Images/gtk/NavigationItemProbes.svg:
2955         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
2956         * UserInterface/Images/gtk/NavigationItemStorage.svg:
2957         * UserInterface/Images/gtk/NavigationItemTrash.svg:
2958         * UserInterface/Images/gtk/NavigationItemTypes.svg:
2959         * UserInterface/Images/gtk/NavigationItemVariable.svg:
2960         * UserInterface/Images/gtk/PaintFlashing.svg:
2961         * UserInterface/Images/gtk/Pause.svg:
2962         * UserInterface/Images/gtk/PausedBreakpoint.svg:
2963         * UserInterface/Images/gtk/Percent.svg:
2964         * UserInterface/Images/gtk/Plus.svg:
2965         * UserInterface/Images/gtk/PseudoElement.svg:
2966         * UserInterface/Images/gtk/Record.svg:
2967         * UserInterface/Images/gtk/Reflection.svg:
2968         * UserInterface/Images/gtk/Reload.svg:
2969         * UserInterface/Images/gtk/ReloadFull.svg:
2970         * UserInterface/Images/gtk/ReplayPauseButton.svg:
2971         * UserInterface/Images/gtk/ReplayPlayButton.svg:
2972         * UserInterface/Images/gtk/ReplayRecordingButton.svg:
2973         * UserInterface/Images/gtk/Request.svg:
2974         * UserInterface/Images/gtk/Resources.svg:
2975         * UserInterface/Images/gtk/Response.svg:
2976         * UserInterface/Images/gtk/ResultLine.svg:
2977         * UserInterface/Images/gtk/Resume.svg:
2978         * UserInterface/Images/gtk/ShadowDOM.svg:
2979         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg:
2980         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg:
2981         * UserInterface/Images/gtk/SourceCode.svg:
2982         * UserInterface/Images/gtk/SplitToggleDown.svg:
2983         * UserInterface/Images/gtk/SplitToggleUp.svg:
2984         * UserInterface/Images/gtk/StepInto.svg:
2985         * UserInterface/Images/gtk/StepOut.svg:
2986         * UserInterface/Images/gtk/StepOver.svg:
2987         * UserInterface/Images/gtk/Stop.svg:
2988         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
2989         * UserInterface/Images/gtk/StyleRuleInherited.svg:
2990         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
2991         * UserInterface/Images/gtk/StyleRuleInspector.svg:
2992         * UserInterface/Images/gtk/StyleRuleUser.svg:
2993         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
2994         * UserInterface/Images/gtk/Time.svg:
2995         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
2996         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg:
2997         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
2998         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
2999         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
3000         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg:
3001         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
3002         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
3003         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
3004         * UserInterface/Images/gtk/TypeBoolean.svg:
3005         * UserInterface/Images/gtk/TypeNull.svg:
3006         * UserInterface/Images/gtk/TypeNumber.svg:
3007         * UserInterface/Images/gtk/TypeObject.svg:
3008         * UserInterface/Images/gtk/TypeRegex.svg:
3009         * UserInterface/Images/gtk/TypeString.svg:
3010         * UserInterface/Images/gtk/TypeSymbol.svg:
3011         * UserInterface/Images/gtk/TypeUndefined.svg:
3012         * UserInterface/Images/gtk/Undock.svg:
3013         * UserInterface/Images/gtk/UpDownArrows.svg:
3014         * UserInterface/Images/gtk/UserInputPrompt.svg:
3015         * UserInterface/Images/gtk/UserInputPromptPrevious.svg:
3016         * UserInterface/Images/gtk/UserInputResult.svg:
3017         * UserInterface/Images/gtk/Warning.svg:
3018         * UserInterface/Images/gtk/Weight.svg:
3019
3020 2015-04-29  Timothy Hatcher  <timothy@apple.com>
3021
3022         Web Inspector: Navigation bar often looses last button when full
3023         https://bugs.webkit.org/show_bug.cgi?id=144385
3024
3025         Added helpers to get the subpixel width and height of an element.
3026         Adopt them in the NavigationBar layout methods to get precise widths
3027         that don't accumulate rounding errors which lead to items overflowing.
3028
3029         Reviewed by Joseph Pecoraro.
3030
3031         * UserInterface/Base/Utilities.js:
3032         (Element.prototype.realOffsetWidth): Added.
3033         (Element.prototype.realOffsetHeight): Added.
3034         * UserInterface/Views/HierarchicalPathNavigationItem.js:
3035         (WebInspector.HierarchicalPathNavigationItem.prototype.updateLayout):
3036         * UserInterface/Views/NavigationBar.js:
3037         (WebInspector.NavigationBar.prototype.updateLayout):
3038         (WebInspector.NavigationBar.prototype._calculateMinimumWidth):
3039         * UserInterface/Views/TabBar.js:
3040         (WebInspector.TabBar.prototype._handleMouseMoved):
3041         * UserInterface/Views/Toolbar.js:
3042         (WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
3043         (WebInspector.Toolbar.prototype.customUpdateLayout):
3044
3045 2015-04-28  Matt Baker  <mattbaker@apple.com>
3046
3047         Web Inspector: add a separate overview for the Rendering Frames timeline
3048         https://bugs.webkit.org/show_bug.cgi?id=144245
3049
3050         Reviewed by Timothy Hatcher.
3051
3052         The Timelines tab now supports two view modes, labeled "Timelines" and "Rendering Frames", with each mode
3053         having a seperate timeline overview and selected range. The Timelines mode displays the original time-based
3054         graphs (Network, Layout, and Script), and switching to the Rendering Frames mode displays a frames graph
3055         with a timeline ruler which shows frame indices.
3056
3057         If the rendering frames timeline is supported by the backend, a navigation bar is added to the timelines
3058         sidebar with controls for switching between view modes. In addition to user-triggered view mode changes, the
3059         timelines sidebar will automatically change the current view mode in response to content view changes that
3060         are triggered elsewhere in the UI (for example, when a timeline that does not belong to the current view
3061         mode is selected via the navigation path).
3062
3063         * UserInterface/Controllers/TimelineManager.js:
3064         (WebInspector.TimelineManager.prototype.get activeRecording): Deleted.
3065         (WebInspector.TimelineManager.prototype.get recordings): Deleted.
3066         Removed unused code.
3067
3068         * UserInterface/Main.html:
3069         New files.
3070
3071         * UserInterface/Models/RenderingFrameTimelineRecord.js:
3072         (WebInspector.RenderingFrameTimelineRecord):
3073         (WebInspector.RenderingFrameTimelineRecord.resetFrameIndex):
3074         (WebInspector.RenderingFrameTimelineRecord.prototype.get frameIndex):
3075         (WebInspector.RenderingFrameTimelineRecord.prototype.get frameNumber):
3076         * UserInterface/Models/TimelineRecording.js:
3077         (WebInspector.TimelineRecording.prototype.reset):
3078         Frame number is now derived from frame index.
3079
3080         * UserInterface/Views/LinearTimelineOverview.js:
3081         (WebInspector.LinearTimelineOverview):
3082         (WebInspector.LinearTimelineOverview.prototype.canShowTimeline):
3083         New overview class for time-based timeline graphs.
3084
3085         * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js:
3086         (WebInspector.RenderingFrameDetailsSidebarPanel):
3087         (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.updateRangeSelection):
3088         (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._getSelectedRecords):
3089         Changed type of selected range from time to frame indices.
3090
3091         * UserInterface/Views/RenderingFrameTimelineOverview.js:
3092         (WebInspector.RenderingFrameTimelineOverview.this.timelineRuler.formatLabelCallback):
3093         (WebInspector.RenderingFrameTimelineOverview):
3094         (WebInspector.RenderingFrameTimelineOverview.prototype.canShowTimeline):
3095         New overview class for frame-based timeline graphs.
3096
3097         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
3098         (.timeline-overview > .graphs-container > .timeline-overview-graph.rendering-frame):
3099         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
3100         (WebInspector.RenderingFrameTimelineOverviewGraph):
3101         (WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition.get if):
3102         Updated to use frame index ruler and removed frame combining logic.
3103
3104         * UserInterface/Views/RenderingFrameTimelineView.js:
3105         (WebInspector.RenderingFrameTimelineView):
3106         Increased column widths.
3107
3108         * UserInterface/Views/TimelineOverview.css:
3109         (.timeline-overview > .graphs-container):
3110         (body.mac-platform.legacy .timeline-overview > .graphs-container):
3111         Updated for new ruler height.
3112
3113         * UserInterface/Views/TimelineOverview.js:
3114         (WebInspector.TimelineOverview):
3115         (WebInspector.TimelineOverview.prototype.get secondsPerPixel):
3116         (WebInspector.TimelineOverview.prototype.set secondsPerPixel):
3117         (WebInspector.TimelineOverview.prototype.get visibleDuration):
3118         (WebInspector.TimelineOverview.prototype.set selectionDuration):
3119         (WebInspector.TimelineOverview.prototype.updateLayout):
3120         (WebInspector.TimelineOverview.prototype.get timelineRuler):
3121         (WebInspector.TimelineOverview.prototype.canShowTimeline):
3122         (WebInspector.TimelineOverview.prototype._handleScrollEvent):
3123         (WebInspector.TimelineOverview.prototype._handleWheelEvent):
3124         (WebInspector.TimelineOverview.prototype._timelineRemoved):
3125         (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
3126         (WebInspector.TimelineOverview.prototype.set currentTime): Deleted.
3127         (WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded): Deleted.
3128         (WebInspector.TimelineOverview.prototype._needsLayout): Deleted.
3129         Converted to base class. Derived classes provide settings and permitted timeline types.
3130
3131         * UserInterface/Views/TimelineRecordFrame.css:
3132         (.timeline-record-frame):
3133         (.timeline-record-frame > .frame):
3134         (.timeline-record-frame > .frame > .duration):
3135         (.timeline-record-frame > .frame > .duration.timeline-record-type-network):
3136         (.timeline-record-frame > .frame > .duration.timeline-record-type-layout):
3137         (.timeline-record-frame > .frame > .duration.timeline-record-type-script):
3138         (.timeline-record-frame > .frame > .duration:last-child): Deleted.
3139         New graph frames styles.
3140
3141         * UserInterface/Views/TimelineRecordFrame.js:
3142         (WebInspector.TimelineRecordFrame):
3143         (WebInspector.TimelineRecordFrame.prototype.get record):
3144         (WebInspector.TimelineRecordFrame.prototype.set record):
3145         (WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
3146         (WebInspector.TimelineRecordFrame.prototype.get element): Deleted.
3147         Updated to use frame index ruler.
3148         Removed dropped frames and frame combining logic.
3149
3150         * UserInterface/Views/TimelineRecordingContentView.js:
3151         (WebInspector.TimelineRecordingContentView):
3152         (WebInspector.TimelineRecordingContentView.prototype.shown):
3153         (WebInspector.TimelineRecordingContentView.prototype.hidden):
3154         (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
3155         (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
3156         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
3157         (WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
3158         (WebInspector.TimelineRecordingContentView.prototype._getRenderingFrameTimeline):
3159         (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
3160         (WebInspector.TimelineRecordingContentView.prototype._timelineCountChanged):
3161         (WebInspector.TimelineRecordingContentView.prototype._recordingReset):
3162         (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
3163         (WebInspector.TimelineRecordingContentView.prototype.get currentTimelineView): Deleted.
3164         (WebInspector.TimelineRecordingContentView.prototype.goForward): Deleted.
3165         (WebInspector.TimelineRecordingContentView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
3166         (WebInspector.TimelineRecordingContentView.prototype._contentViewSupplementalRepresentedObjectsDidChange): Deleted.
3167         (WebInspector.TimelineRecordingContentView.prototype._update): Deleted.
3168         (WebInspector.TimelineRecordingContentView.prototype._debuggerPaused): Deleted.
3169         (WebInspector.TimelineRecordingContentView.prototype._debuggerResumed): Deleted.
3170         (WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated): Deleted.
3171         Maintains two timeline overviews, switching between them based on the current content view.
3172         Updated tree element filtering to support both overview rulers.
3173
3174         * UserInterface/Views/TimelineRuler.css:
3175         (.timeline-ruler > .header):
3176         (body.mac-platform.legacy .timeline-ruler > .header):
3177         (.timeline-ruler > .header > .divider > .label):
3178         (.timeline-ruler > .selection-drag):
3179         (body.mac-platform.legacy .timeline-ruler > .selection-drag):
3180         (.timeline-ruler > .selection-handle):
3181         (body.mac-platform.legacy .timeline-ruler > .selection-handle):
3182         (.timeline-ruler > .header > .divider): Deleted.
3183         (.timeline-ruler > .selection-drag:active): Deleted.
3184         Updated for new ruler height.
3185
3186         * UserInterface/Views/TimelineRuler.js:
3187         (WebInspector.TimelineRuler):
3188         (WebInspector.TimelineRuler.prototype.set formatLabelCallback):
3189         (WebInspector.TimelineRuler.prototype.updateLayout):
3190         (WebInspector.TimelineRuler.prototype._formatDividerLabelText):
3191         (WebInspector.TimelineRuler.prototype.set allowsClippedLabels): Deleted.
3192         (WebInspector.TimelineRuler.prototype._updateSelection): Deleted.
3193         Added ability to customize label formatting.
3194
3195         * UserInterface/Views/TimelineSidebarPanel.css:
3196         (.panel.timeline .navigation-bar.timelines-view):
3197         (.sidebar > .panel.navigation.timeline > .title-bar):
3198         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar):
3199         (.sidebar > .panel.navigation.timeline > .title-bar.timelines):
3200         (.sidebar > .panel.navigation.timeline > .navigation-bar-container):
3201         (.sidebar > .panel.navigation.timeline > .navigation-bar-container > .navigation-bar):
3202         (.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
3203         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
3204         (.sidebar > .panel.navigation.timeline > .timelines-content):
3205         (.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
3206         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
3207         (.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
3208         (body.window-inactive .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
3209         Updated for new navigation bar and ruler height.
3210
3211         * UserInterface/Views/TimelineSidebarPanel.js:
3212         (WebInspector.TimelineSidebarPanel):
3213         (WebInspector.TimelineSidebarPanel.prototype.get viewMode):
3214         (WebInspector.TimelineSidebarPanel.prototype.canShowTimeline):
3215         (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
3216         (WebInspector.TimelineSidebarPanel.get this):
3217         (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
3218         Added support for two view modes: Timelines and Rendering Frames.
3219
3220         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
3221         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
3222         New files.
3223
3224 2015-04-27  Timothy Hatcher  <timothy@apple.com>
3225
3226         Web Inspector: Add new tab button to make it easy to bring a closed tab back
3227         https://bugs.webkit.org/show_bug.cgi?id=144297
3228
3229         Reviewed by Joseph Pecoraro.
3230
3231         * Localizations/en.lproj/localizedStrings.js:
3232         * UserInterface/Base/Main.js:
3233         (WebInspector.contentLoaded):
3234         (WebInspector.isTabTypeAllowed):
3235         (WebInspector._tabContentViewForType):
3236         (WebInspector._rememberOpenTabs):
3237         (WebInspector._updateNewTabButtonState):
3238         (WebInspector._newTabItemClicked):
3239         (WebInspector.isNewTabWithTypeAllowed):
3240         (WebInspector.createNewTab):
3241         (WebInspector.activateExtraDomains):
3242         (WebInspector._restoreCookieForOpenTabs):
3243         (WebInspector._saveCookieForOpenTabs):
3244         (WebInspector._isTabTypeAllowed): Deleted.
3245         * UserInterface/Images/NewTab.svg: Added.
3246         * UserInterface/Images/NewTabPlus.svg:
3247         * UserInterface/Main.html:
3248         * UserInterface/Views/NewTabContentView.css: Added.
3249         (.new-tab.tab.content-view):
3250         (.new-tab.tab.content-view > .tab-item):
3251         (.new-tab.tab.content-view > .tab-item.disabled):
3252         (.new-tab.tab.content-view > .tab-item > .box):
3253         (.new-tab.tab.content-view > .tab-item:not(.disabled):active > .box):
3254         (.new-tab.tab.content-view > .tab-item > .box > img):