1 2015-04-29 Timothy Hatcher <timothy@apple.com>
3 Web Inspector: Remove FrameContentView.js
4 https://bugs.webkit.org/show_bug.cgi?id=144415
6 Reviewed by Joseph Pecoraro.
8 * UserInterface/Images/DOMTree.svg: Removed.
9 * UserInterface/Images/SourceCode.svg: Removed.
10 * UserInterface/Main.html: Removed FrameContentView.js.
11 * UserInterface/Views/FrameContentView.js: Removed.
12 * UserInterface/Views/PathComponentIcons.css:
13 (.source-code-icon .icon): Deleted.
14 (.dom-tree-icon .icon): Deleted.
16 * UserInterface/Views/ResourceSidebarPanel.js:
17 (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
18 (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
19 Simplify the code here. We don't need these checks now with tabs and the Storage tab.
21 2015-04-30 Nikita Vasilyev <nvasilyev@apple.com>
23 REGRESSION: Web Inspector: Console message repeat count overlapped by icon
24 https://bugs.webkit.org/show_bug.cgi?id=144344
26 Reviewed by Timothy Hatcher.
28 * UserInterface/Views/ConsoleMessageView.css:
29 (.console-message .repeat-count):
31 2015-04-30 Jon Davis <jond@apple.com>
33 Web Inspector: console should show an icon for console.info() messages
34 https://bugs.webkit.org/show_bug.cgi?id=18530
36 Reviewed by Timothy Hatcher.
38 Added icons for console.log, console.info and console.debug messages.
40 Separated console.info from console.log.
42 * UserInterface/Images/Debug.svg: Added.
43 * UserInterface/Images/Info.svg: Added.
44 * UserInterface/Images/Log.svg: Added.
47 * UserInterface/Models/ConsoleMessage.js:
48 * UserInterface/Views/ConsoleMessageView.css:
49 (.console-log-level::before):
50 (.console-info-level::before):
51 (.console-debug-level::before):
52 (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level).console-message):
53 (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level)::before):
54 (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message): Deleted.
55 (:matches(.console-warning-level, .console-error-level, .console-log-level)::before): Deleted.
56 Include console.info messages in layout adjustments.
58 * UserInterface/Views/ConsoleMessageView.js:
59 (WebInspector.ConsoleMessageView):
60 (WebInspector.ConsoleMessageView.prototype._levelString):
62 2015-04-30 Timothy Hatcher <timothy@apple.com>
64 Web Inspector: Scope Chain sidebar should be selected immediately when paused
65 https://bugs.webkit.org/show_bug.cgi?id=144352
67 Reviewed by Joseph Pecoraro.
69 * UserInterface/Base/Main.js:
70 (WebInspector.showDebuggerTab): Added showScopeChainDetailsSidebarPanel argument.
71 (WebInspector._debuggerDidPause): Pass true for showScopeChainDetailsSidebarPanel.
72 * UserInterface/Views/ContentBrowserTabContentView.js:
73 (WebInspector.ContentBrowserTabContentView): Wire the event to showDetailsSidebarPanels instead of
74 _contentBrowserRepresentedObjectsDidChange, allowing subclasses to do work during the event.
75 (WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels): Moved content of
76 _contentBrowserRepresentedObjectsDidChange here.
77 (WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange): Deleted.
78 * UserInterface/Views/DebuggerTabContentView.js:
79 (WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels): Added. Show the scope sidebar panel
80 if it is available and it was requested by showScopeChainDetailsSidebarPanel().
81 (WebInspector.DebuggerTabContentView.prototype.showScopeChainDetailsSidebarPanel): Added.
83 2015-04-30 Andres Gomez <agomez@igalia.com>
85 [GTK] Web Inspector: New Images for ObjectTreeView - Setter
86 https://bugs.webkit.org/show_bug.cgi?id=143173
88 Reviewed by Martin Robinson.
90 * UserInterface/Images/gtk/Pencil.svg: Added.
92 2015-04-30 Andres Gomez <agomez@igalia.com>
94 [GTK] Web Inspector: Remove some unused Images
95 https://bugs.webkit.org/show_bug.cgi?id=144445
97 Reviewed by Carlos Garcia Campos.
99 * UserInterface/Images/gtk/BottomUpTree.svg: Removed.
100 * UserInterface/Images/gtk/Log.png: Removed.
101 * UserInterface/Images/gtk/Log@2x.png: Removed.
102 * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Removed.
103 * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Removed.
104 * UserInterface/Images/gtk/NavigationItemBug.svg: Removed.
105 * UserInterface/Images/gtk/NavigationItemFile.svg: Removed.
106 * UserInterface/Images/gtk/NavigationItemLayers.svg: Removed.
107 * UserInterface/Images/gtk/NavigationItemLog.svg: Removed.
108 * UserInterface/Images/gtk/NavigationItemProbes.svg: Removed.
109 * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Removed.
110 * UserInterface/Images/gtk/NavigationItemStorage.svg: Removed.
111 * UserInterface/Images/gtk/NavigationItemVariable.svg: Removed.
112 * UserInterface/Images/gtk/Percent.svg: Removed.
113 * UserInterface/Images/gtk/Reload.svg: Removed.
114 * UserInterface/Images/gtk/SplitToggleDown.svg: Removed.
115 * UserInterface/Images/gtk/Time.svg: Removed.
116 * UserInterface/Images/gtk/Weight.svg: Removed.
118 2015-04-30 Joseph Pecoraro <pecoraro@apple.com>
120 Web Inspector: Copy not working in Console
121 https://bugs.webkit.org/show_bug.cgi?id=144354
123 Reviewed by Timothy Hatcher.
125 * UserInterface/Base/Main.js:
126 (WebInspector._focusedContentView):
127 Select the inner most content view to check if handleCopyEvent exists.
128 Previously we were stopping at the top level TabContentView.
130 2015-04-29 Timothy Hatcher <timothy@apple.com>
132 Web Inspector: Remove some unused Images
133 https://bugs.webkit.org/show_bug.cgi?id=144412
135 Reviewed by Joseph Pecoraro.
137 * UserInterface/Images/BottomUpTree.svg: Removed.
138 * UserInterface/Images/Log.png: Removed.
139 * UserInterface/Images/Log@2x.png: Removed.
140 * UserInterface/Images/NavigationItemAngleBrackets.svg: Removed.
141 * UserInterface/Images/NavigationItemBrushAndRuler.svg: Removed.
142 * UserInterface/Images/NavigationItemBug.svg: Removed.
143 * UserInterface/Images/NavigationItemDoughnutChart.svg: Removed.
144 * UserInterface/Images/NavigationItemFile.svg: Removed.
145 * UserInterface/Images/NavigationItemLayers.svg: Removed.
146 * UserInterface/Images/NavigationItemLog.svg: Removed.
147 * UserInterface/Images/NavigationItemProbes.svg: Removed.
148 * UserInterface/Images/NavigationItemStopwatch.svg: Removed.
149 * UserInterface/Images/NavigationItemStorage.svg: Removed.
150 * UserInterface/Images/NavigationItemVariable.svg: Removed.
151 * UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Removed.
152 * UserInterface/Images/NetworkBarLabelCalloutRight.svg: Removed.
153 * UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Removed.
154 * UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Removed.
155 * UserInterface/Images/Percent.svg: Removed.
156 * UserInterface/Images/Reload.svg: Removed.
157 * UserInterface/Images/SplitToggleDown.svg: Removed.
158 * UserInterface/Images/Time.svg: Removed.
159 * UserInterface/Images/Weight.svg: Removed.
161 2015-04-29 Timothy Hatcher <timothy@apple.com>
163 Web Inspector: Split Storage from Resources tab
164 https://bugs.webkit.org/show_bug.cgi?id=144404
166 Reviewed by Joseph Pecoraro.
168 * Localizations/en.lproj/localizedStrings.js:
169 * UserInterface/Base/Main.js:
170 (WebInspector.loaded):
171 (WebInspector.isTabTypeAllowed):
172 (WebInspector._tabContentViewForType):
173 (WebInspector._updateNewTabButtonState):
174 (WebInspector.showStorageTab):
175 (WebInspector._storageWasInspected):
176 * UserInterface/Controllers/ApplicationCacheManager.js:
177 (WebInspector.ApplicationCacheManager.prototype.initialize):
178 (WebInspector.ApplicationCacheManager.prototype.get applicationCacheObjects):
179 * UserInterface/Controllers/StorageManager.js:
180 (WebInspector.StorageManager.prototype.get domStorageObjects):
181 (WebInspector.StorageManager.prototype.get databases):
182 (WebInspector.StorageManager.prototype.get indexedDatabases):
183 (WebInspector.StorageManager.prototype.get cookieStorageObjects):
184 * UserInterface/Images/Storage.svg: Added.
185 * UserInterface/Main.html:
186 * UserInterface/Views/DatabaseTableContentView.js:
187 (WebInspector.DatabaseTableContentView.prototype._queryFinished): Clear _dataGrid,
188 since it might have been allocated but still be empty. This avoids an exception in
189 updateLayout next time layout is updated.
190 * UserInterface/Views/NewTabContentView.js:
191 (WebInspector.NewTabContentView):
192 * UserInterface/Views/ResourceSidebarPanel.js:
193 (WebInspector.ResourceSidebarPanel):
194 (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
195 (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded): Deleted.
196 (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasInspected): Deleted.
197 (WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded): Deleted.
198 (WebInspector.ResourceSidebarPanel.prototype._databaseWasInspected): Deleted.
199 (WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded): Deleted.
200 (WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded): Deleted.
201 (WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded): Deleted.
202 (WebInspector.ResourceSidebarPanel.prototype._frameManifestRemoved): Deleted.
203 (WebInspector.ResourceSidebarPanel.prototype._addStorageChild): Deleted.
204 (WebInspector.ResourceSidebarPanel.prototype._storageCleared): Deleted.
205 * UserInterface/Views/ResourcesTabContentView.js:
206 (WebInspector.ResourcesTabContentView):
207 (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
208 * UserInterface/Views/StorageSidebarPanel.js: Added.
209 (WebInspector.StorageSidebarPanel):
210 (WebInspector.StorageSidebarPanel.prototype.showDefaultContentView):
211 (WebInspector.StorageSidebarPanel.prototype.closed):
212 (WebInspector.StorageSidebarPanel.prototype._treeElementSelected):
213 (WebInspector.StorageSidebarPanel.prototype._domStorageObjectWasAdded):
214 (WebInspector.StorageSidebarPanel.prototype._addDOMStorageObject):
215 (WebInspector.StorageSidebarPanel.prototype._domStorageObjectWasInspected):
216 (WebInspector.StorageSidebarPanel.prototype._databaseWasAdded):
217 (WebInspector.StorageSidebarPanel.prototype._addDatabase):
218 (WebInspector.StorageSidebarPanel.prototype._databaseWasInspected):
219 (WebInspector.StorageSidebarPanel.prototype._indexedDatabaseWasAdded):
220 (WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
221 (WebInspector.StorageSidebarPanel.prototype._cookieStorageObjectWasAdded):
222 (WebInspector.StorageSidebarPanel.prototype._addCookieStorageObject):
223 (WebInspector.StorageSidebarPanel.prototype._frameManifestAdded):
224 (WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
225 (WebInspector.StorageSidebarPanel.prototype._frameManifestRemoved):
226 (WebInspector.StorageSidebarPanel.prototype._compareTreeElements):
227 (WebInspector.StorageSidebarPanel.prototype._addStorageChild):
228 (WebInspector.StorageSidebarPanel.prototype._storageCleared):
229 * UserInterface/Views/StorageTabContentView.js: Copied from Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js.
230 (WebInspector.StorageTabContentView):
231 (WebInspector.StorageTabContentView.prototype.get type):
232 (WebInspector.StorageTabContentView.prototype.canShowRepresentedObject):
234 2015-04-29 Timothy Hatcher <timothy@apple.com>
236 Web Inspector: Remove Legacy images and styles
237 https://bugs.webkit.org/show_bug.cgi?id=144390
239 Reviewed by Joseph Pecoraro.
241 * UserInterface/Base/ImageUtilities.js:
243 (.generateImage.generateLegacyImage): Deleted.
244 * UserInterface/Base/Main.js:
245 (WebInspector.contentLoaded):
246 (WebInspector._updateToolbarHeight):
247 * UserInterface/Base/Platform.js:
248 * UserInterface/Controllers/TimelineManager.js:
249 (WebInspector.TimelineManager.prototype._loadNewRecording):
250 * UserInterface/Images/Legacy/BackArrow.svg: Removed.
251 * UserInterface/Images/Legacy/Breakpoints.svg: Removed.
252 * UserInterface/Images/Legacy/Close.svg: Removed.
253 * UserInterface/Images/Legacy/CloseLarge.svg: Removed.
254 * UserInterface/Images/Legacy/Colors.png: Removed.
255 * UserInterface/Images/Legacy/Colors@2x.png: Removed.
256 * UserInterface/Images/Legacy/ColorsLarge.png: Removed.
257 * UserInterface/Images/Legacy/ColorsLarge@2x.png: Removed.
258 * UserInterface/Images/Legacy/DockBottom.svg: Removed.
259 * UserInterface/Images/Legacy/DockRight.svg: Removed.
260 * UserInterface/Images/Legacy/DownloadArrow.svg: Removed.
261 * UserInterface/Images/Legacy/Errors.svg: Removed.
262 * UserInterface/Images/Legacy/ErrorsEnabled.svg: Removed.
263 * UserInterface/Images/Legacy/FilterFieldGlyph.svg: Removed.
264 * UserInterface/Images/Legacy/FolderGeneric.png: Removed.
265 * UserInterface/Images/Legacy/FolderGeneric@2x.png: Removed.
266 * UserInterface/Images/Legacy/ForwardArrow.svg: Removed.
267 * UserInterface/Images/Legacy/Issues.svg: Removed.
268 * UserInterface/Images/Legacy/IssuesEnabled.svg: Removed.
269 * UserInterface/Images/Legacy/LayerBorders.svg: Removed.
270 * UserInterface/Images/Legacy/Logs.svg: Removed.
271 * UserInterface/Images/Legacy/NavigationItemCurleyBraces.svg: Removed.
272 * UserInterface/Images/Legacy/NavigationItemTrash.svg: Removed.
273 * UserInterface/Images/Legacy/Network.png: Removed.
274 * UserInterface/Images/Legacy/Network@2x.png: Removed.
275 * UserInterface/Images/Legacy/NetworkLarge.png: Removed.
276 * UserInterface/Images/Legacy/NetworkLarge@2x.png: Removed.
277 * UserInterface/Images/Legacy/Pause.svg: Removed.
278 * UserInterface/Images/Legacy/Plus.svg: Removed.
279 * UserInterface/Images/Legacy/Recording.png: Removed.
280 * UserInterface/Images/Legacy/Recording@2x.png: Removed.
281 * UserInterface/Images/Legacy/RecordingHovered.png: Removed.
282 * UserInterface/Images/Legacy/RecordingHovered@2x.png: Removed.
283 * UserInterface/Images/Legacy/RecordingStopped.png: Removed.
284 * UserInterface/Images/Legacy/RecordingStopped@2x.png: Removed.
285 * UserInterface/Images/Legacy/Reload.svg: Removed.
286 * UserInterface/Images/Legacy/Resources.svg: Removed.
287 * UserInterface/Images/Legacy/Resume.svg: Removed.
288 * UserInterface/Images/Legacy/ShadowDOM.svg: Removed.
289 * UserInterface/Images/Legacy/SortIndicatorDownArrow.svg: Removed.
290 * UserInterface/Images/Legacy/SortIndicatorUpArrow.svg: Removed.
291 * UserInterface/Images/Legacy/SplitToggleDown.svg: Removed.
292 * UserInterface/Images/Legacy/SplitToggleUp.svg: Removed.
293 * UserInterface/Images/Legacy/StepInto.svg: Removed.
294 * UserInterface/Images/Legacy/StepOut.svg: Removed.
295 * UserInterface/Images/Legacy/StepOver.svg: Removed.
296 * UserInterface/Images/Legacy/Time.svg: Removed.
297 * UserInterface/Images/Legacy/Undock.svg: Removed.
298 * UserInterface/Images/Legacy/UpDownArrows.svg: Removed.
299 * UserInterface/Images/Legacy/Weight.svg: Removed.
300 * UserInterface/Views/ButtonNavigationItem.css:
301 (body.mac-platform.legacy .navigation-bar .item.button.text-only): Deleted.
302 * UserInterface/Views/ButtonToolbarItem.css:
303 (body.mac-platform.legacy .toolbar .item.button > .label): Deleted.
304 * UserInterface/Views/CSSStyleDeclarationSection.css:
305 (body.mac-platform.legacy .style-declaration-section): Deleted.
306 (body.mac-platform.legacy .style-declaration-section + .style-declaration-section): Deleted.
307 (body.mac-platform.legacy .style-declaration-section.last-in-group): Deleted.
308 (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section): Deleted.
309 (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)): Deleted.
310 * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
311 (body.mac-platform.legacy .sidebar > .panel.details.css-style > .content): Deleted.
312 * UserInterface/Views/ContentBrowser.js:
313 (WebInspector.ContentBrowser):
314 * UserInterface/Views/ControlToolbarItem.css:
315 (body.mac-platform.legacy .toolbar .item.control): Deleted.
316 (body.mac-platform.legacy .toolbar .item.control:hover): Deleted.
317 * UserInterface/Views/DOMTreeContentView.js:
318 (WebInspector.DOMTreeContentView):
319 * UserInterface/Views/DOMTreeOutline.css:
320 (body.mac-platform.legacy .dom-tree-outline li.hovered:not(.selected) .selection): Deleted.
321 (body.mac-platform.legacy .dom-tree-outline li.elements-drag-over .selection): Deleted.
322 (body.mac-platform.legacy .dom-tree-outline:focus li.selected .selection): Deleted.
323 * UserInterface/Views/DashboardContainerView.css:
324 (body.mac-platform.legacy .toolbar .dashboard-container): Deleted.
325 (body.mac-platform.legacy.window-inactive .toolbar .dashboard-container): Deleted.
326 (body.mac-platform.legacy.window-inactive .toolbar .dashboard): Deleted.
327 (body.mac-platform.legacy .dashboard-container .advance-arrow): Deleted.
328 * UserInterface/Views/DataGrid.css:
329 (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)): Deleted.
330 (body.mac-platform.legacy .data-grid:focus tr.selected): Deleted.
331 * UserInterface/Views/DataGrid.js:
332 (WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
333 * UserInterface/Views/DatabaseTableContentView.js:
334 (WebInspector.DatabaseTableContentView):
335 * UserInterface/Views/DebuggerDashboardView.js:
336 (WebInspector.DebuggerDashboardView):
337 * UserInterface/Views/DebuggerSidebarPanel.css:
338 (body.mac-platform.legacy .sidebar > .panel.navigation.debugger > .content): Deleted.
339 * UserInterface/Views/DebuggerSidebarPanel.js:
340 * UserInterface/Views/DefaultDashboardView.css:
341 (body.mac-platform.legacy .toolbar .dashboard.default > .item): Deleted.
342 (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img): Deleted.
343 (body.mac-platform.legacy .toolbar .dashboard.default > .logs > img): Deleted.
344 (body.mac-platform.legacy .toolbar .dashboard.default > .errors > img): Deleted.
345 (body.mac-platform.legacy .toolbar .dashboard.default > .errors.enabled > img): Deleted.
346 (body.mac-platform.legacy .toolbar .dashboard.default > .issues > img): Deleted.
347 (body.mac-platform.legacy .toolbar .dashboard.default > .issues.enabled > img): Deleted.
348 * UserInterface/Views/DetailsSection.css:
349 (body.mac-platform.legacy .details-section): Deleted.
350 (body.mac-platform.legacy .details-section .details-section): Deleted.
351 (body.mac-platform.legacy .details-section .details-section:first-child): Deleted.
352 (body.mac-platform.legacy .details-section > .header): Deleted.
353 (body.mac-platform.legacy .details-section .details-section > .header): Deleted.
354 (body.mac-platform.legacy .details-section .details-section.collapsed > .header): Deleted.
355 (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline): Deleted.
356 (body.mac-platform.legacy .details-section.computed-style-properties:not(.collapsed) > .header): Deleted.
357 (body.mac-platform.legacy .details-section > .content > .group): Deleted.
358 (body.mac-platform.legacy .details-section > .content > .group:nth-child(even)): Deleted.
359 (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *): Deleted.
360 (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)): Deleted.
361 * UserInterface/Views/DividerNavigationItem.css:
362 (.navigation-bar .item.divider):
363 (body.mac-platform.legacy .navigation-bar .item.divider): Deleted.
364 * UserInterface/Views/FilterBar.css:
365 (.filter-bar > input[type="search"]::-webkit-search-decoration):
366 (body.mac-platform.legacy .filter-bar): Deleted.
367 (body.mac-platform.legacy .filter-bar > input[type="search"]): Deleted.
368 (body.mac-platform.legacy .filter-bar > input[type="search"]::-webkit-search-decoration): Deleted.
369 * UserInterface/Views/FindBanner.css:
370 (body.mac-platform.legacy .find-banner > input[type="search"]): Deleted.
371 (body.mac-platform.legacy .find-banner > button > .glyph): Deleted.
372 (body.mac-platform.legacy .find-banner > button.segmented.left > .glyph): Deleted.
373 (body.mac-platform.legacy .find-banner > button.segmented.right > .glyph): Deleted.
374 (body.mac-platform.legacy .find-banner > button.segmented): Deleted.
375 * UserInterface/Views/FindBanner.js:
376 (WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
377 (WebInspector.FindBanner):
378 * UserInterface/Views/FolderIcon.css:
379 (.folder-icon .icon):
380 (body.mac-platform.legacy .folder-icon .icon): Deleted.
381 * UserInterface/Views/HierarchicalPathComponent.css:
382 (body.mac-platform.legacy .hierarchical-path-component > .selector-arrows): Deleted.
383 * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
384 (WebInspector.IndexedDatabaseObjectStoreContentView):
385 * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
386 (body.mac-platform.legacy .sidebar > .panel.details.layer-tree > .content): Deleted.
387 (body.mac-platform.legacy .panel.details.layer-tree .bottom-bar): Deleted.
388 (body.mac-platform.legacy .panel.details.layer-tree .bottom-bar > div): Deleted.
389 (body.mac-platform.legacy .layer-tree-popover): Deleted.
390 * UserInterface/Views/LogContentView.css:
391 (body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]): Deleted.
392 * UserInterface/Views/LogContentView.js:
393 (WebInspector.LogContentView):
394 * UserInterface/Views/Main.css:
395 (body.mac-platform.legacy:not(.docked)): Deleted.
396 (body.docked.bottom.mac-platform.legacy): Deleted.
397 (body.docked.right.mac-platform.legacy): Deleted.
398 (body.mac-platform.legacy #split-content-browser > .navigation-bar): Deleted.
399 * UserInterface/Views/NavigationBar.css:
400 (.navigation-bar .item):
401 (body.mac-platform.legacy .navigation-bar): Deleted.
402 (body.mac-platform.legacy .navigation-bar .item): Deleted.
403 * UserInterface/Views/NavigationSidebarPanel.css:
404 (body.mac-platform.legacy .sidebar > .panel.navigation > .content): Deleted.
405 (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow): Deleted.
406 (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow.top): Deleted.
407 (body.mac-platform.legacy .sidebar > .panel.navigation > .empty-content-placeholder): Deleted.
408 (body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
409 (body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline:focus .item.selected): Deleted.
410 (body.mac-platform.legacy.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
411 * UserInterface/Views/NavigationSidebarPanel.js:
412 (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
413 (WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):
414 * UserInterface/Views/Popover.js:
415 * UserInterface/Views/ProbeDetailsSidebarPanel.css:
416 (body.mac-platform.legacy .details-section.probe-set .options > .probe-clear-samples): Deleted.
417 (body.mac-platform.legacy .details-section.probe-set .options > .probe-remove): Deleted.
418 (body.mac-platform.legacy .details-section.probe-set .options > .probe-add): Deleted.
419 * UserInterface/Views/QuickConsole.css:
420 (body.mac-platform.legacy .quick-console): Deleted.
421 * UserInterface/Views/RadioButtonNavigationItem.css:
422 (.navigation-bar .item.radio.button.text-only.selected:active):
423 (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:hover): Deleted.
424 (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected): Deleted.
425 (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active): Deleted.
426 * UserInterface/Views/RulesStyleDetailsPanel.css:
427 (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .label + .style-declaration-section): Deleted.
428 (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule): Deleted.
429 (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section): Deleted.
430 (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
431 * UserInterface/Views/ScopeBar.css:
432 (.scope-bar > li.selected:active):
433 (body.mac-platform.legacy .scope-bar > li): Deleted.
434 (body.mac-platform.legacy .scope-bar > li:hover): Deleted.
435 (body.mac-platform.legacy .scope-bar > li.selected): Deleted.
436 (body.mac-platform.legacy .scope-bar > li:active): Deleted.
437 (body.mac-platform.legacy .scope-bar > li.selected:active): Deleted.
438 * UserInterface/Views/ScriptContentView.js:
439 (WebInspector.ScriptContentView):
440 * UserInterface/Views/SearchBar.css:
441 (body.mac-platform.legacy .search-bar > input[type="search"]): Deleted.
442 * UserInterface/Views/SearchSidebarPanel.css:
443 (.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
444 (body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)): Deleted.
445 (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar): Deleted.
446 (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]): Deleted.
447 * UserInterface/Views/Sidebar.css:
448 (body.window-inactive .sidebar.right):
449 (body.mac-platform.legacy .sidebar): Deleted.
450 (body.mac-platform.legacy.window-inactive .sidebar): Deleted.
451 (body.mac-platform.legacy .sidebar.right): Deleted.
452 * UserInterface/Views/TextContentView.js:
453 (WebInspector.TextContentView):
454 * UserInterface/Views/TextResourceContentView.js:
455 (WebInspector.TextResourceContentView):
456 * UserInterface/Views/TimelineDataGrid.css:
457 (body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar): Deleted.
458 * UserInterface/Views/TimelineIcons.css:
459 (body.mac-platform.legacy .network-icon .icon): Deleted.
460 (body.mac-platform.legacy .network-icon.large .icon): Deleted.
461 (body.mac-platform.legacy .colors-icon .icon): Deleted.
462 (body.mac-platform.legacy .colors-icon.large .icon): Deleted.
463 * UserInterface/Views/TimelineRecordingContentView.js:
464 (WebInspector.TimelineRecordingContentView):
465 * UserInterface/Views/TimelineRuler.css:
466 (body.mac-platform.legacy .timeline-ruler > .header): Deleted.
467 (body.mac-platform.legacy .timeline-ruler > .selection-drag): Deleted.
468 (body.mac-platform.legacy .timeline-ruler > .selection-handle): Deleted.
469 * UserInterface/Views/TimelineSidebarPanel.css:
470 (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content):
471 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar): Deleted.
472 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph): Deleted.
473 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording): Deleted.
474 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover): Deleted.
475 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover): Deleted.
476 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced): Deleted.
477 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced): Deleted.
478 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status): Deleted.
479 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar): Deleted.
480 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines): Deleted.
481 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events): Deleted.
482 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content): Deleted.
483 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button): Deleted.
484 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
485 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item): Deleted.
486 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)): Deleted.
487 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button): Deleted.
488 * UserInterface/Views/TimelineSidebarPanel.js:
489 (WebInspector.TimelineSidebarPanel):
490 * UserInterface/Views/Toolbar.css:
491 (body.mac-platform:not(.docked) .toolbar):
492 (body.mac-platform:not(.legacy, .docked) .toolbar): Deleted.
493 (body.mac-platform.legacy .toolbar): Deleted.
494 (body.mac-platform.legacy.docked .toolbar): Deleted.
495 (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Deleted.
496 (body.mac-platform.legacy.window-inactive .toolbar): Deleted.
497 * UserInterface/Views/TreeElementStatusButton.css:
498 (body.mac-platform.legacy .item > .status > .status-button > svg .filled): Deleted.
499 (body.mac-platform.legacy .item > .status > .status-button > svg .stroked): Deleted.
501 2015-04-29 Andres Gomez <agomez@igalia.com>
503 [GTK] Web Inspector: Optimize SVG images
504 https://bugs.webkit.org/show_bug.cgi?id=143476
506 SVG images optimized with a combination of sed replacements and
507 the usage of the scour tool (http://www.codedread.com/scour/).
509 Also, modified the spelling of the license word to use the US one
510 in the copyright files.
512 Reviewed by Martin Robinson.
514 * UserInterface/Images/gtk/BackArrow.svg:
515 * UserInterface/Images/gtk/BottomUpTree.svg:
516 * UserInterface/Images/gtk/BreakpointActionAdd.svg:
517 * UserInterface/Images/gtk/BreakpointActionRemove.svg:
518 * UserInterface/Images/gtk/BreakpointButton.svg:
519 * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
520 * UserInterface/Images/gtk/Breakpoints.svg:
521 * UserInterface/Images/gtk/COPYING:
522 * UserInterface/Images/gtk/COPYING_CCBYSA3:
523 * UserInterface/Images/gtk/Checkers.svg:
524 * UserInterface/Images/gtk/Circle.svg:
525 * UserInterface/Images/gtk/Close.svg:
526 * UserInterface/Images/gtk/CloseLarge.svg:
527 * UserInterface/Images/gtk/CloseWhite.svg:
528 * UserInterface/Images/gtk/ContentFlow.svg:
529 * UserInterface/Images/gtk/Crosshair.svg:
530 * UserInterface/Images/gtk/DOMCharacterData.svg:
531 * UserInterface/Images/gtk/DOMComment.svg:
532 * UserInterface/Images/gtk/DOMDocument.svg:
533 * UserInterface/Images/gtk/DOMDocumentType.svg:
534 * UserInterface/Images/gtk/DOMElement.svg:
535 * UserInterface/Images/gtk/DOMNode.svg:
536 * UserInterface/Images/gtk/DOMTextNode.svg:
537 * UserInterface/Images/gtk/DOMTree.svg:
538 * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg:
539 * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg:
540 * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg:
541 * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg:
542 * UserInterface/Images/gtk/DockBottom.svg:
543 * UserInterface/Images/gtk/DockRight.svg:
544 * UserInterface/Images/gtk/DownloadArrow.svg:
545 * UserInterface/Images/gtk/Error.svg:
546 * UserInterface/Images/gtk/Errors.svg:
547 * UserInterface/Images/gtk/ErrorsEnabled.svg:
548 * UserInterface/Images/gtk/EventListener.svg:
549 * UserInterface/Images/gtk/Exception.svg:
550 * UserInterface/Images/gtk/Eye.svg:
551 * UserInterface/Images/gtk/FilterFieldGlyph.svg:
552 * UserInterface/Images/gtk/ForwardArrow.svg:
553 * UserInterface/Images/gtk/Function.svg:
554 * UserInterface/Images/gtk/GoToArrow.svg:
555 * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg:
556 * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg:
557 * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg:
558 * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg:
559 * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg:
560 * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg:
561 * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg:
562 * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg:
563 * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg:
564 * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg:
565 * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg:
566 * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg:
567 * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg:
568 * UserInterface/Images/gtk/Issues.svg:
569 * UserInterface/Images/gtk/IssuesEnabled.svg:
570 * UserInterface/Images/gtk/LayerBorders.svg:
571 * UserInterface/Images/gtk/Locked.svg:
572 * UserInterface/Images/gtk/Logs.svg:
573 * UserInterface/Images/gtk/Native.svg:
574 * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
575 * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
576 * UserInterface/Images/gtk/NavigationItemBug.svg:
577 * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:
578 * UserInterface/Images/gtk/NavigationItemFile.svg:
579 * UserInterface/Images/gtk/NavigationItemLayers.svg:
580 * UserInterface/Images/gtk/NavigationItemLog.svg:
581 * UserInterface/Images/gtk/NavigationItemProbes.svg:
582 * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
583 * UserInterface/Images/gtk/NavigationItemStorage.svg:
584 * UserInterface/Images/gtk/NavigationItemTrash.svg:
585 * UserInterface/Images/gtk/NavigationItemTypes.svg:
586 * UserInterface/Images/gtk/NavigationItemVariable.svg:
587 * UserInterface/Images/gtk/PaintFlashing.svg:
588 * UserInterface/Images/gtk/Pause.svg:
589 * UserInterface/Images/gtk/PausedBreakpoint.svg:
590 * UserInterface/Images/gtk/Percent.svg:
591 * UserInterface/Images/gtk/Plus.svg:
592 * UserInterface/Images/gtk/PseudoElement.svg:
593 * UserInterface/Images/gtk/Record.svg:
594 * UserInterface/Images/gtk/Reflection.svg:
595 * UserInterface/Images/gtk/Reload.svg:
596 * UserInterface/Images/gtk/ReloadFull.svg:
597 * UserInterface/Images/gtk/ReplayPauseButton.svg:
598 * UserInterface/Images/gtk/ReplayPlayButton.svg:
599 * UserInterface/Images/gtk/ReplayRecordingButton.svg:
600 * UserInterface/Images/gtk/Request.svg:
601 * UserInterface/Images/gtk/Resources.svg:
602 * UserInterface/Images/gtk/Response.svg:
603 * UserInterface/Images/gtk/ResultLine.svg:
604 * UserInterface/Images/gtk/Resume.svg:
605 * UserInterface/Images/gtk/ShadowDOM.svg:
606 * UserInterface/Images/gtk/SortIndicatorDownArrow.svg:
607 * UserInterface/Images/gtk/SortIndicatorUpArrow.svg:
608 * UserInterface/Images/gtk/SourceCode.svg:
609 * UserInterface/Images/gtk/SplitToggleDown.svg:
610 * UserInterface/Images/gtk/SplitToggleUp.svg:
611 * UserInterface/Images/gtk/StepInto.svg:
612 * UserInterface/Images/gtk/StepOut.svg:
613 * UserInterface/Images/gtk/StepOver.svg:
614 * UserInterface/Images/gtk/Stop.svg:
615 * UserInterface/Images/gtk/StyleRuleAuthor.svg:
616 * UserInterface/Images/gtk/StyleRuleInherited.svg:
617 * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
618 * UserInterface/Images/gtk/StyleRuleInspector.svg:
619 * UserInterface/Images/gtk/StyleRuleUser.svg:
620 * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
621 * UserInterface/Images/gtk/Time.svg:
622 * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
623 * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg:
624 * UserInterface/Images/gtk/TimelineRecordEvent.svg:
625 * UserInterface/Images/gtk/TimelineRecordLayout.svg:
626 * UserInterface/Images/gtk/TimelineRecordPaint.svg:
627 * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg:
628 * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
629 * UserInterface/Images/gtk/TimelineRecordStyle.svg:
630 * UserInterface/Images/gtk/TimelineRecordTimer.svg:
631 * UserInterface/Images/gtk/TypeBoolean.svg:
632 * UserInterface/Images/gtk/TypeNull.svg:
633 * UserInterface/Images/gtk/TypeNumber.svg:
634 * UserInterface/Images/gtk/TypeObject.svg:
635 * UserInterface/Images/gtk/TypeRegex.svg:
636 * UserInterface/Images/gtk/TypeString.svg:
637 * UserInterface/Images/gtk/TypeSymbol.svg:
638 * UserInterface/Images/gtk/TypeUndefined.svg:
639 * UserInterface/Images/gtk/Undock.svg:
640 * UserInterface/Images/gtk/UpDownArrows.svg:
641 * UserInterface/Images/gtk/UserInputPrompt.svg:
642 * UserInterface/Images/gtk/UserInputPromptPrevious.svg:
643 * UserInterface/Images/gtk/UserInputResult.svg:
644 * UserInterface/Images/gtk/Warning.svg:
645 * UserInterface/Images/gtk/Weight.svg:
647 2015-04-29 Timothy Hatcher <timothy@apple.com>
649 Web Inspector: Navigation bar often looses last button when full
650 https://bugs.webkit.org/show_bug.cgi?id=144385
652 Added helpers to get the subpixel width and height of an element.
653 Adopt them in the NavigationBar layout methods to get precise widths
654 that don't accumulate rounding errors which lead to items overflowing.
656 Reviewed by Joseph Pecoraro.
658 * UserInterface/Base/Utilities.js:
659 (Element.prototype.realOffsetWidth): Added.
660 (Element.prototype.realOffsetHeight): Added.
661 * UserInterface/Views/HierarchicalPathNavigationItem.js:
662 (WebInspector.HierarchicalPathNavigationItem.prototype.updateLayout):
663 * UserInterface/Views/NavigationBar.js:
664 (WebInspector.NavigationBar.prototype.updateLayout):
665 (WebInspector.NavigationBar.prototype._calculateMinimumWidth):
666 * UserInterface/Views/TabBar.js:
667 (WebInspector.TabBar.prototype._handleMouseMoved):
668 * UserInterface/Views/Toolbar.js:
669 (WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
670 (WebInspector.Toolbar.prototype.customUpdateLayout):
672 2015-04-28 Matt Baker <mattbaker@apple.com>
674 Web Inspector: add a separate overview for the Rendering Frames timeline
675 https://bugs.webkit.org/show_bug.cgi?id=144245
677 Reviewed by Timothy Hatcher.
679 The Timelines tab now supports two view modes, labeled "Timelines" and "Rendering Frames", with each mode
680 having a seperate timeline overview and selected range. The Timelines mode displays the original time-based
681 graphs (Network, Layout, and Script), and switching to the Rendering Frames mode displays a frames graph
682 with a timeline ruler which shows frame indices.
684 If the rendering frames timeline is supported by the backend, a navigation bar is added to the timelines
685 sidebar with controls for switching between view modes. In addition to user-triggered view mode changes, the
686 timelines sidebar will automatically change the current view mode in response to content view changes that
687 are triggered elsewhere in the UI (for example, when a timeline that does not belong to the current view
688 mode is selected via the navigation path).
690 * UserInterface/Controllers/TimelineManager.js:
691 (WebInspector.TimelineManager.prototype.get activeRecording): Deleted.
692 (WebInspector.TimelineManager.prototype.get recordings): Deleted.
695 * UserInterface/Main.html:
698 * UserInterface/Models/RenderingFrameTimelineRecord.js:
699 (WebInspector.RenderingFrameTimelineRecord):
700 (WebInspector.RenderingFrameTimelineRecord.resetFrameIndex):
701 (WebInspector.RenderingFrameTimelineRecord.prototype.get frameIndex):
702 (WebInspector.RenderingFrameTimelineRecord.prototype.get frameNumber):
703 * UserInterface/Models/TimelineRecording.js:
704 (WebInspector.TimelineRecording.prototype.reset):
705 Frame number is now derived from frame index.
707 * UserInterface/Views/LinearTimelineOverview.js:
708 (WebInspector.LinearTimelineOverview):
709 (WebInspector.LinearTimelineOverview.prototype.canShowTimeline):
710 New overview class for time-based timeline graphs.
712 * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js:
713 (WebInspector.RenderingFrameDetailsSidebarPanel):
714 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.updateRangeSelection):
715 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._getSelectedRecords):
716 Changed type of selected range from time to frame indices.
718 * UserInterface/Views/RenderingFrameTimelineOverview.js:
719 (WebInspector.RenderingFrameTimelineOverview.this.timelineRuler.formatLabelCallback):
720 (WebInspector.RenderingFrameTimelineOverview):
721 (WebInspector.RenderingFrameTimelineOverview.prototype.canShowTimeline):
722 New overview class for frame-based timeline graphs.
724 * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
725 (.timeline-overview > .graphs-container > .timeline-overview-graph.rendering-frame):
726 * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
727 (WebInspector.RenderingFrameTimelineOverviewGraph):
728 (WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition.get if):
729 Updated to use frame index ruler and removed frame combining logic.
731 * UserInterface/Views/RenderingFrameTimelineView.js:
732 (WebInspector.RenderingFrameTimelineView):
733 Increased column widths.
735 * UserInterface/Views/TimelineOverview.css:
736 (.timeline-overview > .graphs-container):
737 (body.mac-platform.legacy .timeline-overview > .graphs-container):
738 Updated for new ruler height.
740 * UserInterface/Views/TimelineOverview.js:
741 (WebInspector.TimelineOverview):
742 (WebInspector.TimelineOverview.prototype.get secondsPerPixel):
743 (WebInspector.TimelineOverview.prototype.set secondsPerPixel):
744 (WebInspector.TimelineOverview.prototype.get visibleDuration):
745 (WebInspector.TimelineOverview.prototype.set selectionDuration):
746 (WebInspector.TimelineOverview.prototype.updateLayout):
747 (WebInspector.TimelineOverview.prototype.get timelineRuler):
748 (WebInspector.TimelineOverview.prototype.canShowTimeline):
749 (WebInspector.TimelineOverview.prototype._handleScrollEvent):
750 (WebInspector.TimelineOverview.prototype._handleWheelEvent):
751 (WebInspector.TimelineOverview.prototype._timelineRemoved):
752 (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
753 (WebInspector.TimelineOverview.prototype.set currentTime): Deleted.
754 (WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded): Deleted.
755 (WebInspector.TimelineOverview.prototype._needsLayout): Deleted.
756 Converted to base class. Derived classes provide settings and permitted timeline types.
758 * UserInterface/Views/TimelineRecordFrame.css:
759 (.timeline-record-frame):
760 (.timeline-record-frame > .frame):
761 (.timeline-record-frame > .frame > .duration):
762 (.timeline-record-frame > .frame > .duration.timeline-record-type-network):
763 (.timeline-record-frame > .frame > .duration.timeline-record-type-layout):
764 (.timeline-record-frame > .frame > .duration.timeline-record-type-script):
765 (.timeline-record-frame > .frame > .duration:last-child): Deleted.
766 New graph frames styles.
768 * UserInterface/Views/TimelineRecordFrame.js:
769 (WebInspector.TimelineRecordFrame):
770 (WebInspector.TimelineRecordFrame.prototype.get record):
771 (WebInspector.TimelineRecordFrame.prototype.set record):
772 (WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
773 (WebInspector.TimelineRecordFrame.prototype.get element): Deleted.
774 Updated to use frame index ruler.
775 Removed dropped frames and frame combining logic.
777 * UserInterface/Views/TimelineRecordingContentView.js:
778 (WebInspector.TimelineRecordingContentView):
779 (WebInspector.TimelineRecordingContentView.prototype.shown):
780 (WebInspector.TimelineRecordingContentView.prototype.hidden):
781 (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
782 (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
783 (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
784 (WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
785 (WebInspector.TimelineRecordingContentView.prototype._getRenderingFrameTimeline):
786 (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
787 (WebInspector.TimelineRecordingContentView.prototype._timelineCountChanged):
788 (WebInspector.TimelineRecordingContentView.prototype._recordingReset):
789 (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
790 (WebInspector.TimelineRecordingContentView.prototype.get currentTimelineView): Deleted.
791 (WebInspector.TimelineRecordingContentView.prototype.goForward): Deleted.
792 (WebInspector.TimelineRecordingContentView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
793 (WebInspector.TimelineRecordingContentView.prototype._contentViewSupplementalRepresentedObjectsDidChange): Deleted.
794 (WebInspector.TimelineRecordingContentView.prototype._update): Deleted.
795 (WebInspector.TimelineRecordingContentView.prototype._debuggerPaused): Deleted.
796 (WebInspector.TimelineRecordingContentView.prototype._debuggerResumed): Deleted.
797 (WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated): Deleted.
798 Maintains two timeline overviews, switching between them based on the current content view.
799 Updated tree element filtering to support both overview rulers.
801 * UserInterface/Views/TimelineRuler.css:
802 (.timeline-ruler > .header):
803 (body.mac-platform.legacy .timeline-ruler > .header):
804 (.timeline-ruler > .header > .divider > .label):
805 (.timeline-ruler > .selection-drag):
806 (body.mac-platform.legacy .timeline-ruler > .selection-drag):
807 (.timeline-ruler > .selection-handle):
808 (body.mac-platform.legacy .timeline-ruler > .selection-handle):
809 (.timeline-ruler > .header > .divider): Deleted.
810 (.timeline-ruler > .selection-drag:active): Deleted.
811 Updated for new ruler height.
813 * UserInterface/Views/TimelineRuler.js:
814 (WebInspector.TimelineRuler):
815 (WebInspector.TimelineRuler.prototype.set formatLabelCallback):
816 (WebInspector.TimelineRuler.prototype.updateLayout):
817 (WebInspector.TimelineRuler.prototype._formatDividerLabelText):
818 (WebInspector.TimelineRuler.prototype.set allowsClippedLabels): Deleted.
819 (WebInspector.TimelineRuler.prototype._updateSelection): Deleted.
820 Added ability to customize label formatting.
822 * UserInterface/Views/TimelineSidebarPanel.css:
823 (.panel.timeline .navigation-bar.timelines-view):
824 (.sidebar > .panel.navigation.timeline > .title-bar):
825 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar):
826 (.sidebar > .panel.navigation.timeline > .title-bar.timelines):
827 (.sidebar > .panel.navigation.timeline > .navigation-bar-container):
828 (.sidebar > .panel.navigation.timeline > .navigation-bar-container > .navigation-bar):
829 (.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
830 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
831 (.sidebar > .panel.navigation.timeline > .timelines-content):
832 (.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
833 (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
834 (.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
835 (body.window-inactive .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
836 Updated for new navigation bar and ruler height.
838 * UserInterface/Views/TimelineSidebarPanel.js:
839 (WebInspector.TimelineSidebarPanel):
840 (WebInspector.TimelineSidebarPanel.prototype.get viewMode):
841 (WebInspector.TimelineSidebarPanel.prototype.canShowTimeline):
842 (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
843 (WebInspector.TimelineSidebarPanel.get this):
844 (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
845 Added support for two view modes: Timelines and Rendering Frames.
847 * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
848 * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
851 2015-04-27 Timothy Hatcher <timothy@apple.com>
853 Web Inspector: Add new tab button to make it easy to bring a closed tab back
854 https://bugs.webkit.org/show_bug.cgi?id=144297
856 Reviewed by Joseph Pecoraro.
858 * Localizations/en.lproj/localizedStrings.js:
859 * UserInterface/Base/Main.js:
860 (WebInspector.contentLoaded):
861 (WebInspector.isTabTypeAllowed):
862 (WebInspector._tabContentViewForType):
863 (WebInspector._rememberOpenTabs):
864 (WebInspector._updateNewTabButtonState):
865 (WebInspector._newTabItemClicked):
866 (WebInspector.isNewTabWithTypeAllowed):
867 (WebInspector.createNewTab):
868 (WebInspector.activateExtraDomains):
869 (WebInspector._restoreCookieForOpenTabs):
870 (WebInspector._saveCookieForOpenTabs):
871 (WebInspector._isTabTypeAllowed): Deleted.
872 * UserInterface/Images/NewTab.svg: Added.
873 * UserInterface/Images/NewTabPlus.svg:
874 * UserInterface/Main.html:
875 * UserInterface/Views/NewTabContentView.css: Added.
876 (.new-tab.tab.content-view):
877 (.new-tab.tab.content-view > .tab-item):
878 (.new-tab.tab.content-view > .tab-item.disabled):
879 (.new-tab.tab.content-view > .tab-item > .box):
880 (.new-tab.tab.content-view > .tab-item:not(.disabled):active > .box):
881 (.new-tab.tab.content-view > .tab-item > .box > img):
882 (.new-tab.tab.content-view > .tab-item > label):
883 * UserInterface/Views/NewTabContentView.js: Added.
884 (WebInspector.NewTabContentView):
885 (WebInspector.NewTabContentView.prototype.get type):
886 (WebInspector.NewTabContentView.prototype._createNewTab):
887 * UserInterface/Views/TabBar.css:
888 (.tab-bar > .item:not(.disabled).selected):
889 (.tab-bar > .item.new-tab-button:not(.disabled):hover):
890 (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover + .item):
891 (.tab-bar > .item.disabled > .icon):
892 (.tab-bar > .item.new-tab-button:not(.disabled):hover > .icon):
893 (.tab-bar > .item.selected): Deleted.
894 (.tab-bar > .item.new-tab-button:hover): Deleted.
895 (.tab-bar:not(.animating) > .item:not(.selected):hover + .item): Deleted.
896 (.tab-bar > .item.new-tab-button:hover > .icon): Deleted.
897 * UserInterface/Views/TabBar.js:
898 (WebInspector.TabBar.prototype.set selectedTabBarItem):
899 (WebInspector.TabBar.prototype._handleMouseDown):
900 * UserInterface/Views/TabBarItem.js:
901 (WebInspector.TabBarItem.prototype.get disabled):
902 (WebInspector.TabBarItem.prototype.set disabled):
903 * UserInterface/Views/TabBrowser.js:
904 (WebInspector.TabBrowser):
905 (WebInspector.TabBrowser.prototype.addTabForContentView):
906 (WebInspector.TabBrowser.prototype.showTabForContentView):
907 (WebInspector.TabBrowser.prototype.closeTabForContentView):
909 2015-04-27 Joseph Pecoraro <pecoraro@apple.com>
911 Web Inspector: Cannot scroll Timeline Overview horizontally, scrollbar cannot be interacted with
912 https://bugs.webkit.org/show_bug.cgi?id=144302
914 Reviewed by Timothy Hatcher.
916 * UserInterface/Views/TimelineOverview.css:
917 (.timeline-overview > .scroll-container):
918 Increase the z-index of the scroll container over anything in the
919 overview so that it can be interacted with.
921 2015-04-27 Timothy Hatcher <timothy@apple.com>
923 Web Inspector: Attempt to workaround exception in TimelineRuler
924 https://bugs.webkit.org/show_bug.cgi?id=144228
926 Reviewed by Joseph Pecoraro.
928 * UserInterface/Views/TimelineRuler.js:
929 (WebInspector.TimelineRuler.prototype.updateLayout):
930 Use firstChild instead of a custom _labelElement property on the dividerElement.
932 2015-04-27 Timothy Hatcher <timothy@apple.com>
934 Web Inspector: Elements tab details sidebar becomes non-expandable after using Console tab
935 https://bugs.webkit.org/show_bug.cgi?id=144212
937 Show the DOM tree content view again on main resource change. This better matches what we did
938 in the pre tab user interface with the DOM being off the main resource tree element.
940 Reviewed by Joseph Pecoraro.
942 * UserInterface/Views/ElementsTabContentView.js:
943 (WebInspector.ElementsTabContentView): Listen for main resource change. Call _showDOMTreeContentView.
944 (WebInspector.ElementsTabContentView.prototype.closed): Fix a leak and exception.
945 The removeEventListener was wrong. Add a new removeEventListener for WebInspector.Frame.
946 (WebInspector.ElementsTabContentView.prototype._showDOMTreeContentView): Added.
947 (WebInspector.ElementsTabContentView.prototype._mainFrameDidChange): Call _showDOMTreeContentView.
948 (WebInspector.ElementsTabContentView.prototype._mainResourceDidChange): Added.
950 2015-04-27 Timothy Hatcher <timothy@apple.com>
952 Web Inspector: TabContentView closed() isn't being called when a tab is closed / removed
953 https://bugs.webkit.org/show_bug.cgi?id=144229
955 Reviewed by Joseph Pecoraro.
957 * UserInterface/Views/ContentViewContainer.js:
958 (WebInspector.ContentViewContainer.prototype._disassociateFromContentView):
959 TabContentViews don't have a representedObject, so returning early and not
960 calling closed() was not correct.
962 2015-04-26 Matt Baker <mattbaker@apple.com>
964 Web Inspector: Cannot make Timeline time range selection clicking inside Frames Overview
965 https://bugs.webkit.org/show_bug.cgi?id=143744
967 Reviewed by Timothy Hatcher.
969 Fixed frame rate divider element style so that it is no longer a mouse event target.
971 * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
972 (.timeline-overview-graph.rendering-frame > .divider):
974 2015-04-26 Timothy Hatcher <timothy@apple.com>
976 Web Inspector: Allow Timeline tab to show resource when a go-to arrow is clicked in a recording
977 https://bugs.webkit.org/show_bug.cgi?id=144240
979 Only support showing a resource or script if we have that represented object in the Timeline sidebar.
981 Reviewed by Darin Adler.
983 * UserInterface/Views/TimelineTabContentView.js:
984 (WebInspector.TimelineTabContentView.prototype.canShowRepresentedObject):
986 2015-04-26 Timothy Hatcher <timothy@apple.com>
988 Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view
989 https://bugs.webkit.org/show_bug.cgi?id=144239
991 Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad
992 is most cases, but if the select tab supports the same represented object, it can end up showing
993 the content view in the wrong tab.
995 Reviewed by Darin Adler.
997 * UserInterface/Views/ContentBrowserTabContentView.js:
998 (WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObjectInNavigationSidebar):
999 * UserInterface/Views/DebuggerSidebarPanel.js:
1000 (WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):
1001 * UserInterface/Views/NavigationSidebarPanel.js:
1002 (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentViewForTreeElement):
1003 (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
1004 (WebInspector.NavigationSidebarPanel):
1005 (WebInspector.NavigationSidebarPanel.prototype.showContentViewForCurrentSelection): Deleted.
1006 * UserInterface/Views/ResourceSidebarPanel.js:
1007 (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
1008 (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
1009 (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
1010 (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
1012 2015-04-26 Jono Wells <jonowells@apple.com>
1014 Web Inspector: Vertically misaligned text in Object Trees
1015 https://bugs.webkit.org/show_bug.cgi?id=144029
1017 Reviewed by Timothy Hatcher.
1019 Remove top offset for object tree property titles to fix alignment issue since applying -webkit-system-font
1020 font family to these (http://trac.webkit.org/changeset/182982).
1022 * UserInterface/Views/ObjectTreePropertyTreeElement.css:
1023 (.object-tree-property > .titles):
1025 2015-04-25 Joseph Pecoraro <pecoraro@apple.com>
1027 Web Inspector: Uncaught exception ReferenceError: Can't find variable: message LogContentView.js
1028 https://bugs.webkit.org/show_bug.cgi?id=144210
1030 Reviewed by Timothy Hatcher.
1032 * UserInterface/Views/LogContentView.js:
1033 (WebInspector.LogContentView.prototype._reappendProvisionalMessages):
1034 With recent refactorings this change was missed.
1036 2015-04-25 Joseph Pecoraro <pecoraro@apple.com>
1038 Web Inspector: Uncaught exception using WebInspector.contentBrowser
1039 https://bugs.webkit.org/show_bug.cgi?id=144206
1041 Reviewed by Timothy Hatcher.
1043 * UserInterface/Views/TimelineSidebarPanel.js:
1044 (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
1045 Use the current tab's content browser since a global one no longer exists.
1047 2015-04-25 Timothy Hatcher <timothy@apple.com>
1049 Update localized strings.
1051 * Localizations/en.lproj/localizedStrings.js: Updated.
1053 2015-04-25 Timothy Hatcher <timothy@apple.com>
1055 Web Inspector: Make JSContext debugging work with Tabs UI
1056 https://bugs.webkit.org/show_bug.cgi?id=144203
1058 Reviewed by Joseph Pecoraro.
1060 * UserInterface/Base/Main.js:
1061 (WebInspector.contentLoaded):
1062 (WebInspector._isTabTypeAllowed):
1063 (WebInspector.activateExtraDomains):
1064 (WebInspector._updateReloadToolbarButton):
1065 (WebInspector._updateDownloadToolbarButton):
1067 2015-04-25 Timothy Hatcher <timothy@apple.com>
1069 Web Inspector: Save and restore tab state on reload and between sessions
1070 https://bugs.webkit.org/show_bug.cgi?id=144202
1072 Reviewed by Joseph Pecoraro.
1074 * UserInterface/Base/Main.js:
1075 (WebInspector.contentLoaded):
1076 (WebInspector._mainResourceDidChange):
1077 (WebInspector._provisionalLoadStarted):
1078 (WebInspector._restoreCookieForOpenTabs):
1079 (WebInspector._saveCookieForOpenTabs):
1080 (WebInspector._pageHidden):
1081 * UserInterface/Views/TabContentView.js:
1082 (WebInspector.TabContentView):
1083 (WebInspector.TabContentView.prototype.restoreStateFromCookie):
1084 (WebInspector.TabContentView.prototype.saveStateToCookie):
1086 2015-04-25 Timothy Hatcher <timothy@apple.com>
1088 Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar
1089 https://bugs.webkit.org/show_bug.cgi?id=144197
1091 Reviewed by Joseph Pecoraro.
1093 * UserInterface/Base/Main.js:
1094 (WebInspector.contentLoaded):
1095 (WebInspector._tabContentViewForType):
1096 (WebInspector._searchTextDidChange):
1097 (WebInspector._focusSearchField):
1098 (WebInspector._domNodeWasInspected):
1099 * UserInterface/Controllers/DebuggerManager.js:
1100 (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
1101 * UserInterface/Images/SearchResults.svg: Added.
1102 * UserInterface/Main.html:
1103 * UserInterface/Views/ResourceSidebarPanel.js:
1104 (WebInspector.ResourceSidebarPanel):
1105 (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
1106 (WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
1107 (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
1108 (WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
1109 (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
1110 (WebInspector.ResourceSidebarPanel.prototype._addStorageChild):
1111 (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
1112 (WebInspector.ResourceSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
1113 (WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon): Deleted.
1114 (WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder): Deleted.
1115 (WebInspector.ResourceSidebarPanel.prototype.performSearch.forEachMatch): Deleted.
1116 (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback): Deleted.
1117 (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback): Deleted.
1118 (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback): Deleted.
1119 (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts): Deleted.
1120 (WebInspector.ResourceSidebarPanel.prototype.performSearch.domSearchResults): Deleted.
1121 (WebInspector.ResourceSidebarPanel.prototype.performSearch.domCallback): Deleted.
1122 (WebInspector.ResourceSidebarPanel.prototype.performSearch): Deleted.
1123 (WebInspector.ResourceSidebarPanel.prototype._showResourcesContentTreeOutline): Deleted.
1124 (WebInspector.ResourceSidebarPanel.prototype._showSearchContentTreeOutline): Deleted.
1125 (WebInspector.ResourceSidebarPanel.prototype._searchFieldChanged): Deleted.
1126 (WebInspector.ResourceSidebarPanel.prototype._searchFieldInput): Deleted.
1127 (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForResource): Deleted.
1128 (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript): Deleted.
1129 (WebInspector.ResourceSidebarPanel.prototype._focusSearchField): Deleted.
1130 (WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch): Deleted.
1131 * UserInterface/Views/SearchBar.js:
1132 (WebInspector.SearchBar):
1133 * UserInterface/Views/SearchSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css.
1134 (.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
1135 (body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
1136 (.sidebar > .panel.navigation.search > .search-bar):
1137 (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar):
1138 (.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
1139 (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
1140 * UserInterface/Views/SearchSidebarPanel.js: Added.
1141 (WebInspector.SearchSidebarPanel):
1142 (WebInspector.SearchSidebarPanel.prototype.closed):
1143 (WebInspector.SearchSidebarPanel.prototype.focusSearchField):
1144 (WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon):
1145 (WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder):
1146 (WebInspector.SearchSidebarPanel.prototype.performSearch.forEachMatch):
1147 (WebInspector.SearchSidebarPanel.prototype.performSearch.resourceCallback):
1148 (WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
1149 (WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
1150 (WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts):
1151 (WebInspector.SearchSidebarPanel.prototype.performSearch.domSearchResults):
1152 (WebInspector.SearchSidebarPanel.prototype.performSearch.domCallback):
1153 (WebInspector.SearchSidebarPanel.prototype.performSearch):
1154 (WebInspector.SearchSidebarPanel.prototype._searchFieldChanged):
1155 (WebInspector.SearchSidebarPanel.prototype._searchFieldInput):
1156 (WebInspector.SearchSidebarPanel.prototype._searchTreeElementForResource):
1157 (WebInspector.SearchSidebarPanel.prototype._searchTreeElementForScript):
1158 (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange.delayedWork):
1159 (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
1160 (WebInspector.SearchSidebarPanel.prototype._treeElementSelected):
1161 * UserInterface/Views/SearchTabContentView.js: Added.
1162 (WebInspector.SearchTabContentView):
1163 (WebInspector.SearchTabContentView.prototype.get type):
1164 (WebInspector.SearchTabContentView.prototype.shown):
1165 (WebInspector.SearchTabContentView.prototype.closed):
1166 (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
1167 (WebInspector.SearchTabContentView.prototype.focusSearchField):
1168 (WebInspector.SearchTabContentView.prototype.performSearch):
1169 * UserInterface/Views/Toolbar.css:
1170 (.toolbar .item-section.center-right):
1171 (.toolbar .item-section.right):
1172 (.toolbar .search-bar):
1173 (.toolbar .search-bar > input[type="search"]):
1174 (.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
1175 (body.window-inactive .toolbar .search-bar > input[type="search"]):
1176 (.toolbar .item): Deleted.
1178 2015-04-25 Timothy Hatcher <timothy@apple.com>
1180 Web Inspector: New Toolbar UI for tabs
1181 https://bugs.webkit.org/show_bug.cgi?id=144185
1183 Reviewed by Joseph Pecoraro.
1185 * UserInterface/Base/ImageUtilities.js:
1186 * UserInterface/Base/Main.js:
1187 (WebInspector.loaded):
1188 (WebInspector.contentLoaded):
1189 (WebInspector.updateDockedState):
1190 (WebInspector._captureDidStart):
1191 (WebInspector._debuggerDidPause):
1192 (WebInspector._debuggerDidResume):
1193 (WebInspector._mainFrameDidChange):
1194 (WebInspector._mainResourceDidChange):
1195 (WebInspector._windowKeyDown):
1196 (WebInspector._windowKeyUp):
1197 (WebInspector._pageHidden):
1198 (WebInspector._undock):
1199 (WebInspector._dockBottom):
1200 (WebInspector._dockRight):
1201 (WebInspector._updateDockNavigationItems):
1202 (WebInspector._domNodeWasInspected):
1203 (WebInspector._inspectModeStateChanged):
1204 (WebInspector._toggleInspectMode):
1205 (WebInspector._downloadWebArchive):
1206 (WebInspector._reloadPageClicked):
1207 (WebInspector._updateDownloadToolbarButton):
1208 (WebInspector.archiveMainFrame):
1209 (WebInspector.canArchiveMainFrame):
1210 * UserInterface/Images/Crosshair.svg:
1211 * UserInterface/Images/DockBottom.svg:
1212 * UserInterface/Images/DockRight.svg:
1213 * UserInterface/Images/DownloadArrow.svg:
1214 * UserInterface/Images/ReloadToolbar.svg: Added.
1215 * UserInterface/Images/Undock.svg:
1216 * UserInterface/Views/ActivateButtonToolbarItem.js:
1217 (WebInspector.ActivateButtonToolbarItem):
1218 (WebInspector.ActivateButtonToolbarItem.prototype.set label):
1219 * UserInterface/Views/ButtonToolbarItem.css:
1220 (.toolbar .item.button):
1221 (body.window-inactive .toolbar .item.button):
1222 (.toolbar.small-size .item.button > .glyph):
1223 * UserInterface/Views/ButtonToolbarItem.js:
1224 (WebInspector.ButtonToolbarItem):
1225 (WebInspector.ButtonToolbarItem.prototype.set label):
1226 * UserInterface/Views/DashboardContainerView.css:
1227 (.toolbar .dashboard-container):
1228 * UserInterface/Views/Main.css:
1229 (body.docked.bottom):
1230 * UserInterface/Views/Toolbar.css:
1232 (body.mac-platform:not(.legacy, .docked) .toolbar):
1233 (.toolbar .control-section):
1234 (.toolbar .item-section):
1235 (.toolbar .item-section.left):
1236 (.toolbar .item-section.center-left):
1237 (.toolbar .item-section.center-right):
1238 (.toolbar .item-section.right):
1239 * UserInterface/Views/Toolbar.js:
1240 (WebInspector.Toolbar):
1241 (WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
1242 (WebInspector.Toolbar.prototype.customUpdateLayout):
1243 (WebInspector.Toolbar.prototype.addToolbarItem):
1245 2015-04-25 Timothy Hatcher <timothy@apple.com>
1247 Web Inspector: Add NavigationBar to the details sidebar
1248 https://bugs.webkit.org/show_bug.cgi?id=144191
1250 Reviewed by Joseph Pecoraro.
1252 * UserInterface/Base/Main.js:
1253 (WebInspector.contentLoaded):
1255 * UserInterface/Views/DetailsSidebarPanel.js:
1256 (WebInspector.DetailsSidebarPanel):
1257 (WebInspector.DetailsSidebarPanel.prototype.get navigationItem):
1259 * UserInterface/Views/NavigationBar.js:
1260 (WebInspector.NavigationBar.prototype.removeNavigationItem):
1261 Remove unused index argument.
1263 * UserInterface/Views/Sidebar.css:
1264 (.sidebar > .navigation-bar):
1265 (.sidebar.has-navigation-bar > .panel):
1267 * UserInterface/Views/Sidebar.js:
1268 (WebInspector.Sidebar):
1269 (WebInspector.Sidebar.prototype.addSidebarPanel):
1270 (WebInspector.Sidebar.prototype.removeSidebarPanel):
1271 (WebInspector.Sidebar.prototype.set selectedSidebarPanel):
1272 (WebInspector.Sidebar.prototype.get minimumWidth):
1273 (WebInspector.Sidebar.prototype.set width):
1274 (WebInspector.Sidebar.prototype.set collapsed):
1276 2015-04-24 Timothy Hatcher <timothy@apple.com>
1278 Web Inspector: Switch over to a tab based UI
1279 https://bugs.webkit.org/show_bug.cgi?id=144154
1281 Reviewed by Joseph Pecoraro.
1283 * UserInterface/Base/Main.js:
1284 (WebInspector.loaded):
1285 (WebInspector.contentLoaded):
1286 (WebInspector._tabContentViewForType):
1287 (WebInspector._rememberOpenTabs):
1288 (WebInspector._windowResized):
1289 (WebInspector._tabBrowserSizeDidChange):
1290 (WebInspector._quickConsoleDidResize):
1291 (WebInspector._sidebarWidthDidChange):
1292 (WebInspector._tabBrowserSelectedTabContentViewDidChange):
1293 (WebInspector._inspectModeStateChanged):
1294 (WebInspector._focusedContentView):
1295 * UserInterface/Main.html:
1296 * UserInterface/Views/Main.css:
1299 2015-04-23 Timothy Hatcher <timothy@apple.com>
1301 Web Inspector: Remove Main.js code we don't need for Tabs
1302 https://bugs.webkit.org/show_bug.cgi?id=144126
1304 Reviewed by Joseph Pecoraro.
1306 * UserInterface/Base/Main.js:
1307 (WebInspector.loaded):
1308 (WebInspector.contentLoaded):
1310 2015-04-23 Timothy Hatcher <timothy@apple.com>
1312 Web Inspector: Change more places that changed WebInspector.navigationSidebar.selectedSidebarPanel to tabs
1313 https://bugs.webkit.org/show_bug.cgi?id=144125
1315 Reviewed by Joseph Pecoraro.
1317 * UserInterface/Base/Main.js:
1318 (WebInspector.loaded):
1319 (WebInspector.toggleDetailsSidebar):
1320 (WebInspector.tabContentViewClassForRepresentedObject):
1321 (WebInspector._updateModifierKeys):
1322 (WebInspector._consoleResizerMouseDown.dockedResizerDragEnd):
1323 (WebInspector._consoleResizerMouseDown):
1324 (WebInspector.linkifyURLAsNode):
1325 (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
1326 * UserInterface/Protocol/InspectorFrontendAPI.js:
1327 (InspectorFrontendAPI.setTimelineProfilingEnabled):
1328 (InspectorFrontendAPI.showConsole):
1329 (InspectorFrontendAPI.showResources):
1330 * UserInterface/Protocol/InspectorObserver.js:
1331 (WebInspector.InspectorObserver.prototype.inspect):
1332 * UserInterface/Views/DebuggerTabContentView.js:
1333 (WebInspector.DebuggerTabContentView.prototype.canShowRepresentedObject):
1334 (WebInspector.DebuggerTabContentView.prototype.revealAndSelectBreakpoint):
1335 * UserInterface/Views/DefaultDashboardView.js:
1336 (WebInspector.DefaultDashboardView):
1337 (WebInspector.DefaultDashboardView.prototype._resourcesWasClicked):
1338 * UserInterface/Views/SourceCodeTextEditor.js:
1339 (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.revealInSidebar):
1340 * UserInterface/Views/TabBrowser.js:
1341 (WebInspector.TabBrowser.bestTabContentViewForClass):
1343 2015-04-23 Timothy Hatcher <timothy@apple.com>
1345 Web Inspector: Make Console work in a tab world
1346 https://bugs.webkit.org/show_bug.cgi?id=144112
1348 Reviewed by Joseph Pecoraro.
1350 * UserInterface/Base/Main.js:
1351 (WebInspector.contentLoaded):
1352 (WebInspector.isShowingConsoleTab):
1353 (WebInspector.UIString):
1354 (WebInspector.toggleNavigationSidebar):
1355 (WebInspector.toggleDetailsSidebar):
1356 (WebInspector.tabContentViewClassForRepresentedObject):
1357 (WebInspector.linkifyStringAsFragment):
1358 * UserInterface/Images/Console.svg: Added.
1359 * UserInterface/Protocol/InspectorFrontendAPI.js:
1360 (InspectorFrontendAPI.showConsole):
1361 * UserInterface/Views/ConsoleTabContentView.js: Added.
1362 (WebInspector.ConsoleTabContentView):
1363 (WebInspector.ConsoleTabContentView.prototype.shown):
1364 (WebInspector.ConsoleTabContentView.prototype.showRepresentedObject):
1365 (WebInspector.ConsoleTabContentView.prototype.canShowRepresentedObject):
1366 (WebInspector.ConsoleTabContentView.prototype.get supportsSplitContentBrowser):
1367 * UserInterface/Views/DefaultDashboardView.js:
1368 (WebInspector.DefaultDashboardView.prototype._consoleItemWasClicked):
1369 * UserInterface/Views/LogContentView.js:
1370 (WebInspector.LogContentView):
1371 (WebInspector.LogContentView.prototype.get navigationItems):
1372 (WebInspector.LogContentView.prototype.shown):
1373 (WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
1374 (WebInspector.LogContentView.prototype._showConsoleTab):
1375 * UserInterface/Views/LogIcon.css:
1377 * UserInterface/Views/Main.css:
1378 (#split-content-browser .hierarchical-path-component.log-icon .icon):
1379 (#split-content-browser .hierarchical-path-component.log-icon .title):
1380 (#split-content-browser .hierarchical-path-component.log-icon select):
1382 2015-04-23 Timothy Hatcher <timothy@apple.com>
1384 Web Inspector: Make showing a content view work in the tab world
1385 https://bugs.webkit.org/show_bug.cgi?id=144110
1387 Reviewed by Joseph Pecoraro.
1389 * UserInterface/Base/Main.js:
1390 (WebInspector.loaded):
1391 (WebInspector.hideSplitConsole):
1392 (WebInspector.showSourceCodeLocation):
1393 (WebInspector.showOriginalUnformattedSourceCodeLocation):
1394 (WebInspector.showOriginalOrFormattedSourceCodeLocation):
1395 (WebInspector.showOriginalOrFormattedSourceCodeTextRange):
1396 (WebInspector.showResourceRequest):
1397 (WebInspector.debuggerToggleBreakpoints):
1398 (WebInspector.debuggerPauseResumeToggle):
1399 (WebInspector.debuggerStepOver):
1400 (WebInspector.debuggerStepInto):
1401 (WebInspector.debuggerStepOut):
1402 (WebInspector._focusChanged):
1403 (WebInspector._mouseWasClicked):
1404 (WebInspector._dragOver):
1405 (WebInspector._captureDidStart):
1406 (WebInspector._debuggerDidPause):
1407 (WebInspector._debuggerDidResume):
1408 (WebInspector._frameWasAdded):
1409 (WebInspector._undock):
1410 (WebInspector._updateDockNavigationItems):
1411 * UserInterface/Models/Breakpoint.js:
1412 (WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
1413 (WebInspector.Breakpoint.prototype.appendContextMenuItems):
1414 * UserInterface/Protocol/InspectorFrontendAPI.js:
1415 (InspectorFrontendAPI.showMainResourceForFrame):
1416 * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1417 (WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
1418 * UserInterface/Views/ComputedStyleDetailsPanel.js:
1419 (WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
1420 (WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
1421 (WebInspector.ComputedStyleDetailsPanel):
1422 * UserInterface/Views/ContentBrowser.js:
1423 (WebInspector.ContentBrowser.prototype.updateHierarchicalPathForCurrentContentView):
1424 * UserInterface/Views/ContentView.js:
1425 (WebInspector.ContentView):
1426 * UserInterface/Views/DOMTreeContentView.js:
1427 (WebInspector.DOMTreeContentView.prototype.restoreFromCookie):
1428 * UserInterface/Views/DOMTreeDataGridNode.js:
1429 (WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):
1430 * UserInterface/Views/DebuggerSidebarPanel.js:
1431 (WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):
1432 (WebInspector.DebuggerSidebarPanel.prototype._addTreeElementForSourceCodeToContentTreeOutline):
1433 (WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
1434 (WebInspector.DebuggerSidebarPanel.prototype._addIssue):
1435 (WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):
1436 * UserInterface/Views/LayerTreeDataGridNode.js:
1437 (WebInspector.LayerTreeDataGridNode.prototype._goToArrowWasClicked):
1438 * UserInterface/Views/LayoutTimelineView.js:
1439 (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
1440 * UserInterface/Views/NavigationSidebarPanel.js:
1441 (WebInspector.NavigationSidebarPanel.prototype.get contentBrowser):
1442 (WebInspector.NavigationSidebarPanel.prototype.set contentBrowser):
1443 (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
1444 * UserInterface/Views/NetworkTimelineView.js:
1445 (WebInspector.NetworkTimelineView.prototype._treeElementSelected):
1446 * UserInterface/Views/ObjectTreeBaseTreeElement.js:
1447 (WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
1448 (WebInspector.ObjectTreeBaseTreeElement):
1449 * UserInterface/Views/OverviewTimelineView.js:
1450 (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
1451 * UserInterface/Views/ResourceDetailsSidebarPanel.js:
1452 (WebInspector.ResourceDetailsSidebarPanel.prototype._goToRequestDataClicked):
1453 * UserInterface/Views/ResourceSidebarPanel.js:
1454 (WebInspector.ResourceSidebarPanel):
1455 (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
1456 (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
1457 (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
1458 (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
1459 (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
1460 (WebInspector.ResourceSidebarPanel.prototype._storageCleared):
1461 * UserInterface/Views/ResourceTimelineDataGridNode.js:
1462 (WebInspector.ResourceTimelineDataGridNode.prototype._goToResource):
1463 * UserInterface/Views/ScriptTimelineView.js:
1464 (WebInspector.ScriptTimelineView.prototype._treeElementSelected):
1465 * UserInterface/Views/SourceCodeTextEditor.js:
1466 (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
1467 * UserInterface/Views/TimelineDataGrid.js:
1468 (WebInspector.TimelineDataGrid.prototype._popoverCallStackTreeElementSelected):
1469 * UserInterface/Views/TimelineSidebarPanel.js:
1470 (WebInspector.TimelineSidebarPanel):
1471 (WebInspector.TimelineSidebarPanel.prototype.shown):
1472 (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline):
1474 2015-04-22 Timothy Hatcher <timothy@apple.com>
1476 Web Inspector: Make debugger keyboard shortcuts global
1477 https://bugs.webkit.org/show_bug.cgi?id=144068
1479 We wont always have a DebuggerSidebarPanel to listen for the shortcuts.
1481 Reviewed by Joseph Pecoraro.
1483 * UserInterface/Base/Main.js:
1484 (WebInspector.contentLoaded):
1485 (WebInspector.showSourceCodeForFrame):
1486 (WebInspector.showSourceCode):
1487 * UserInterface/Controllers/DebuggerManager.js:
1488 (WebInspector.DebuggerManager.prototype.pause):
1489 * UserInterface/Views/DebuggerSidebarPanel.js:
1490 (WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
1491 (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
1492 (WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):
1493 (WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
1494 (WebInspector.DebuggerSidebarPanel):
1496 2015-04-22 Timothy Hatcher <timothy@apple.com>
1498 Web Inspector: Remove Reload and Download Web Archive buttons from FrameTreeElement
1499 https://bugs.webkit.org/show_bug.cgi?id=144064
1501 The will be global toolbar items soon.
1503 Reviewed by Joseph Pecoraro.
1505 * UserInterface/Views/FrameTreeElement.js:
1506 * UserInterface/Views/ResourceTreeElement.js:
1507 (WebInspector.ResourceTreeElement.prototype._updateStatus):
1509 2015-04-22 Timothy Hatcher <timothy@apple.com>
1511 Web Inspector: Remove time and weight from the dashboard
1512 https://bugs.webkit.org/show_bug.cgi?id=144063
1514 These two items were the odd ones out since they are only available
1515 when recording a timeline. We will need the toolbar space soon, so make
1516 this lets us make the dashboard skinnier.
1518 This also removes the exception catching in DashboardContainerView. It doesn't really
1519 help us and it makes debugging an exception harder.
1521 Reviewed by Joseph Pecoraro.
1523 * UserInterface/Views/DashboardContainerView.css:
1524 (.toolbar .dashboard-container):
1525 * UserInterface/Views/DashboardContainerView.js:
1526 (WebInspector.DashboardContainerView.prototype._dashboardViewForRepresentedObject):
1527 * UserInterface/Views/DefaultDashboardView.css:
1528 (body.web .toolbar.collapsed .dashboard.default > .item.resourcesCount):
1529 (body.javascript .toolbar .dashboard.default > .item.resourcesCount):
1530 * UserInterface/Views/DefaultDashboardView.js:
1531 (WebInspector.DefaultDashboardView):
1532 (WebInspector.DefaultDashboardView.prototype._updateDisplay):
1534 2015-04-22 Timothy Hatcher <timothy@apple.com>
1536 Web Inspector: Remove sidebar panel shortcut and image
1537 https://bugs.webkit.org/show_bug.cgi?id=144061
1539 Sidebar panels no longer need a keyboard shortcut or a toolbar image.
1541 Reviewed by Joseph Pecoraro.
1543 * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
1544 (WebInspector.ApplicationCacheDetailsSidebarPanel):
1545 * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1546 (WebInspector.CSSStyleDetailsSidebarPanel):
1547 * UserInterface/Views/DOMDetailsSidebarPanel.js:
1548 (WebInspector.DOMDetailsSidebarPanel):
1549 * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
1550 (WebInspector.DOMNodeDetailsSidebarPanel):
1551 * UserInterface/Views/DebuggerSidebarPanel.js:
1552 * UserInterface/Views/DetailsSidebarPanel.js:
1553 (WebInspector.DetailsSidebarPanel):
1554 * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
1555 (WebInspector.LayerTreeDetailsSidebarPanel):
1556 * UserInterface/Views/NavigationSidebarPanel.js:
1557 (WebInspector.NavigationSidebarPanel):
1558 (WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie):
1559 (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
1560 (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
1561 (WebInspector.NavigationSidebarPanel.prototype.show):
1562 (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
1563 * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1564 (WebInspector.ProbeDetailsSidebarPanel):
1565 * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js:
1566 * UserInterface/Views/ResourceDetailsSidebarPanel.js:
1567 (WebInspector.ResourceDetailsSidebarPanel):
1568 * UserInterface/Views/ResourceSidebarPanel.js:
1569 (WebInspector.ResourceSidebarPanel):
1570 * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1571 (WebInspector.ScopeChainDetailsSidebarPanel):
1572 * UserInterface/Views/SidebarPanel.js:
1573 (WebInspector.SidebarPanel):
1574 (WebInspector.SidebarPanel.prototype.added):
1575 (WebInspector.SidebarPanel.prototype.removed):
1576 (WebInspector.SidebarPanel.prototype.visibilityDidChange):
1577 * UserInterface/Views/TimelineSidebarPanel.js:
1578 (WebInspector.TimelineSidebarPanel):
1579 (WebInspector.TimelineSidebarPanel.prototype.showTimelineViewForTimeline):
1581 2015-04-22 Timothy Hatcher <timothy@apple.com>
1583 Web Inspector: Remove allowedNavigationSidebarPanels, it isn't needed
1584 https://bugs.webkit.org/show_bug.cgi?id=144056
1586 Reviewed by Joseph Pecoraro.
1588 * UserInterface/Views/ApplicationCacheFrameContentView.js:
1589 * UserInterface/Views/ContentView.js:
1590 * UserInterface/Views/CookieStorageContentView.js:
1591 * UserInterface/Views/DOMStorageContentView.js:
1592 * UserInterface/Views/DOMTreeContentView.js:
1593 * UserInterface/Views/DatabaseContentView.js:
1594 * UserInterface/Views/DatabaseTableContentView.js:
1595 * UserInterface/Views/FontResourceContentView.js:
1596 * UserInterface/Views/FrameDOMTreeContentView.js:
1597 * UserInterface/Views/LogContentView.js:
1598 * UserInterface/Views/ResourceClusterContentView.js:
1599 * UserInterface/Views/TimelineRecordingContentView.js:
1601 2015-04-22 Timothy Hatcher <timothy@apple.com>
1603 Web Inspector: Support passing extra arguments to ContentViews during construction
1604 https://bugs.webkit.org/show_bug.cgi?id=144055
1606 This allows us to pass the TimelineSidebarPanel to Timeline views since in the future
1607 there could be multiple timeline sidebars, one per tab. So the global instance will
1610 This also removes the exception catching in ContentViewContainer. It doesn't really
1611 help us and it makes debugging an exception harder.
1613 Reviewed by Joseph Pecoraro.
1615 * UserInterface/Views/ContentBrowser.js:
1616 (WebInspector.ContentBrowser.prototype.showContentViewForRepresentedObject):
1617 (WebInspector.ContentBrowser.prototype.contentViewForRepresentedObject):
1618 * UserInterface/Views/ContentView.js:
1619 (WebInspector.ContentView):
1620 * UserInterface/Views/ContentViewContainer.js:
1621 (WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
1622 (WebInspector.ContentViewContainer.prototype.showContentViewForRepresentedObject):
1623 * UserInterface/Views/LayoutTimelineView.js:
1624 (WebInspector.LayoutTimelineView.prototype._dataGridFiltersDidChange):
1625 (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
1626 (WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):
1627 * UserInterface/Views/NetworkTimelineView.js:
1628 (WebInspector.NetworkTimelineView.prototype._dataGridFiltersDidChange):
1629 (WebInspector.NetworkTimelineView.prototype._treeElementSelected):
1630 (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):
1631 * UserInterface/Views/OverviewTimelineView.js:
1632 (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
1633 (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):
1634 * UserInterface/Views/RenderingFrameTimelineView.js:
1635 (WebInspector.RenderingFrameTimelineView):
1636 * UserInterface/Views/ScriptTimelineView.js:
1637 (WebInspector.ScriptTimelineView):
1638 (WebInspector.ScriptTimelineView.prototype._dataGridFiltersDidChange):
1639 (WebInspector.ScriptTimelineView.prototype._treeElementSelected):
1640 (WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
1641 * UserInterface/Views/TimelineRecordingContentView.js:
1642 (WebInspector.TimelineRecordingContentView):
1643 (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
1644 (WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
1645 (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
1646 (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
1647 * UserInterface/Views/TimelineSidebarPanel.js:
1648 * UserInterface/Views/TimelineView.js:
1649 (WebInspector.TimelineView):
1650 (WebInspector.TimelineView.prototype.get timelineSidebarPanel):
1652 2015-04-18 Timothy Hatcher <timothy@apple.com>
1654 Web Inspector: Disable global keyboard shortcuts for background tabs
1655 https://bugs.webkit.org/show_bug.cgi?id=143918
1657 Reviewed by Joseph Pecoraro.
1659 * UserInterface/Views/ContentBrowser.js:
1660 (WebInspector.ContentBrowser):
1661 (WebInspector.ContentBrowser.prototype.shown): Added.
1662 (WebInspector.ContentBrowser.prototype.hidden): Added.
1663 Disable shortcuts on the browser and find banner.
1665 * UserInterface/Views/ContentBrowserTabContentView.js:
1666 (WebInspector.ContentBrowserTabContentView.prototype.shown): Added.
1667 (WebInspector.ContentBrowserTabContentView.prototype.hidden): Added.
1668 Tell the content browser we were shown or hidden.
1670 * UserInterface/Views/FindBanner.js:
1671 (WebInspector.FindBanner):
1672 (WebInspector.FindBanner.prototype.show):
1673 (WebInspector.FindBanner.prototype.enableKeyboardShortcuts): Added.
1674 (WebInspector.FindBanner.prototype.disableKeyboardShortcuts): Added.
1675 Support disabling or enabling the keyboard shortcuts.
1677 2015-04-17 Timothy Hatcher <timothy@apple.com>
1679 Web Inspector: Add TabBrowser and TabContentView
1680 https://bugs.webkit.org/show_bug.cgi?id=143886
1682 Reviewed by Joseph Pecoraro.
1684 * UserInterface/Images/Debugger.svg: Added.
1685 * UserInterface/Images/Elements.svg: Added.
1686 * UserInterface/Images/Gear.svg: Added.
1687 * UserInterface/Images/NewTabPlus.svg: Added.
1688 * UserInterface/Images/Resources.svg:
1689 * UserInterface/Images/Timeline.svg: Added.
1690 * UserInterface/Images/ToggleLeftSidebar.svg: Added.
1691 * UserInterface/Images/ToggleRightSidebar.svg: Added.
1693 * UserInterface/Views/ContentBrowserTabContentView.css: Added.
1694 (.content-browser.tab.content-view > .content-browser):
1696 * UserInterface/Views/ContentBrowserTabContentView.js: Added.
1697 (WebInspector.ContentBrowserTabContentView):
1698 (WebInspector.ContentBrowserTabContentView.prototype.get contentBrowser):
1699 (WebInspector.ContentBrowserTabContentView.prototype.shown):
1700 (WebInspector.ContentBrowserTabContentView.prototype.hidden):
1701 (WebInspector.ContentBrowserTabContentView.prototype.closed):
1702 (WebInspector.ContentBrowserTabContentView.prototype.updateLayout):
1703 (WebInspector.ContentBrowserTabContentView.prototype.get managesDetailsSidebarPanels):
1704 (WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels):
1705 (WebInspector.ContentBrowserTabContentView.prototype.contentBrowserTreeElementForRepresentedObject):
1706 (WebInspector.ContentBrowserTabContentView.prototype._navigationSidebarCollapsedStateDidChange):
1707 (WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarCollapsedStateDidChange):
1708 (WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarPanelSelected):
1709 (WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange):
1710 (WebInspector.ContentBrowserTabContentView.prototype._contentBrowserCurrentContentViewDidChange):
1711 (WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObjectInNavigationSidebar):
1713 * UserInterface/Views/DebuggerTabContentView.js: Added.
1714 (WebInspector.DebuggerTabContentView):
1716 * UserInterface/Views/ElementsTabContentView.js: Added.
1717 (WebInspector.ElementsTabContentView):
1718 (WebInspector.ElementsTabContentView.prototype._mainFrameDidChange):
1720 * UserInterface/Views/ResourcesTabContentView.js: Added.
1721 (WebInspector.ResourcesTabContentView):
1723 * UserInterface/Views/SettingsTabContentView.js: Added.
1724 (WebInspector.SettingsTabContentView):
1726 * UserInterface/Views/TabBrowser.css: Added.
1728 (.tab-browser > .tab-bar):
1729 (.tab-browser > .content-view-container):
1730 (.tab-browser > .tab-bar + .content-view-container):
1732 * UserInterface/Views/TabBrowser.js: Added.
1733 (WebInspector.TabBrowser):
1734 (WebInspector.TabBrowser.prototype.get tabBar):
1735 (WebInspector.TabBrowser.prototype.get navigationSidebar):
1736 (WebInspector.TabBrowser.prototype.get detailsSidebar):
1737 (WebInspector.TabBrowser.prototype.get selectedTabContentView):
1738 (WebInspector.TabBrowser.prototype.updateLayout):
1739 (WebInspector.TabBrowser.prototype.bestTabContentViewForRepresentedObject):
1740 (WebInspector.TabBrowser.prototype.addTabForContentView):
1741 (WebInspector.TabBrowser.prototype.showTabForContentView):
1742 (WebInspector.TabBrowser.prototype.closeTabForContentView):
1743 (WebInspector.TabBrowser.prototype._tabBarItemSelected):
1744 (WebInspector.TabBrowser.prototype._sidebarPanelSelected):
1745 (WebInspector.TabBrowser.prototype._sidebarCollapsedStateDidChange):
1746 (WebInspector.TabBrowser.prototype._showNavigationSidebarPanelForTabContentView):
1747 (WebInspector.TabBrowser.prototype._showDetailsSidebarPanelsForTabContentView):
1749 * UserInterface/Views/TabContentView.js: Added.
1750 (WebInspector.TabContentView):
1751 (WebInspector.TabContentView.prototype.get parentTabBrowser):
1752 (WebInspector.TabContentView.prototype.set parentTabBrowser):
1753 (WebInspector.TabContentView.prototype.get tabBarItem):
1754 (WebInspector.TabContentView.prototype.get managesDetailsSidebarPanels):
1755 (WebInspector.TabContentView.prototype.showDetailsSidebarPanels):
1756 (WebInspector.TabContentView.prototype.canShowRepresentedObject):
1757 (WebInspector.TabContentView.prototype.get navigationSidebarPanel):
1758 (WebInspector.TabContentView.prototype.get navigationSidebarCollapsedSetting):
1759 (WebInspector.TabContentView.prototype.get detailsSidebarPanels):
1760 (WebInspector.TabContentView.prototype.get detailsSidebarCollapsedSetting):
1761 (WebInspector.TabContentView.prototype.get detailsSidebarSelectedPanelSetting):
1763 * UserInterface/Views/TimelineTabContentView.js: Added.
1764 (WebInspector.TimelineTabContentView):
1766 2015-04-06 Timothy Hatcher <timothy@apple.com>
1768 Web Inspector: Add a WebInspector.TabBar class
1769 https://bugs.webkit.org/show_bug.cgi?id=143442
1771 Reviewed by Joseph Pecoraro.
1773 * UserInterface/Main.html:
1776 * UserInterface/Protocol/InspectorFrontendHostStub.js:
1778 (WebInspector.InspectorFrontendHostStub.prototype.showContextMenu):
1779 Added some stubs needed to work standalone.
1781 * UserInterface/Views/TabBar.css: Added.
1783 (body.window-inactive .tab-bar):
1784 (.tab-bar > .top-border):
1785 (body.window-inactive .tab-bar > .top-border):
1787 (.tab-bar > :nth-child(n + 2 of .item)):
1788 (.tab-bar > .item.pinned):
1789 (.tab-bar > .item.selected):
1790 (.tab-bar > .item.new-tab-button:hover):
1791 (.tab-bar:not(.animating) > .item:not(.selected):hover + .item):
1792 (body.window-inactive .tab-bar > .item):
1793 (body.window-inactive .tab-bar > .item.selected):
1794 (.tab-bar > .item > .close):
1795 (body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:hover > .close):
1796 (.tab-bar.single-tab > .item > .close):
1797 (.tab-bar > .item > .close:hover):
1798 (.tab-bar > .item > .close:active):
1799 (.tab-bar > .item > .flex-space):
1800 (.tab-bar > .item > .flex-space:last-child):
1801 (.tab-bar > .item > .icon):
1802 (.tab-bar > .item.selected > .icon):
1803 (.tab-bar > .item.new-tab-button:hover > .icon):
1804 (.tab-bar > .item > .title):
1805 (.tab-bar > .item > .title > .content):
1806 (.tab-bar:not(.animating) > .item:not(.selected):hover > .title):
1807 (.tab-bar > .item.selected > .title):
1808 (.tab-bar.collapsed > .item):
1809 (.tab-bar.collapsed > .item > .flex-space):
1810 (.tab-bar.collapsed > .item > .close):
1811 (.tab-bar.hide-titles > .item > .title):
1812 (.tab-bar.hide-titles > .item.selected:hover > .icon):
1813 (.tab-bar.hide-titles > .item.selected:hover > .close):
1814 (.tab-bar.static-layout):
1815 (.tab-bar.static-layout > .item):
1816 (.tab-bar.animating.closing-tab > .item):
1817 (.tab-bar.animating:matches(.expanding-tabs, .inserting-tab) > .item):
1818 (.tab-bar.animating.inserting-tab > .item.being-inserted):
1819 (.tab-bar.animating.closing-tab > .item.selected):
1820 (body.window-inactive .tab-bar.animating.closing-tab > .item.selected):
1821 (.tab-bar.dragging-tab > .item.selected):
1823 * UserInterface/Views/TabBar.js: Added.
1824 (WebInspector.TabBar):
1825 (WebInspector.TabBar.prototype.get newTabItem):
1826 (WebInspector.TabBar.prototype.set newTabItem):
1827 (WebInspector.TabBar.prototype.addTabBarItem):
1828 (WebInspector.TabBar.prototype.insertTabBarItem.animateTabs):
1829 (WebInspector.TabBar.prototype.insertTabBarItem.removeStyles):
1830 (WebInspector.TabBar.prototype.insertTabBarItem):
1831 (WebInspector.TabBar.prototype.insertTabBarItem.set else):
1832 (WebInspector.TabBar.prototype.insertTabBarItem.set this):
1833 (WebInspector.TabBar.animateTabs.get if):
1834 (WebInspector.TabBar.animateTabs):
1835 (WebInspector.TabBar.removeStyles):
1836 (WebInspector.TabBar.prototype.insertTabBarItem):
1837 (WebInspector.TabBar.prototype.updateLayoutSoon.update):
1838 (WebInspector.TabBar.prototype.updateLayoutSoon):
1839 (WebInspector.TabBar.prototype.updateLayout):
1840 (WebInspector.TabBar.prototype.get selectedTabBarItem):
1841 (WebInspector.TabBar.prototype.set selectedTabBarItem):
1842 (WebInspector.TabBar.prototype.get tabBarItems):
1843 (WebInspector.TabBar.prototype.get element):
1844 (WebInspector.TabBar.prototype._findTabBarItem):
1845 (WebInspector.TabBar.prototype._hasMoreThanOneNormalTab):
1846 (WebInspector.TabBar.prototype._recordTabBarItemSizesAndPositions):
1847 (WebInspector.TabBar.prototype._clearTabBarItemSizesAndPositions):
1848 (WebInspector.TabBar.prototype._finishExpandingTabsAfterClose.):
1849 (WebInspector.TabBar.prototype._finishExpandingTabsAfterClose):
1850 (WebInspector.TabBar.prototype._handleMouseDown):
1851 (WebInspector.TabBar.prototype._handleMouseMoved):
1852 (WebInspector.TabBar.prototype._handleMouseUp):
1853 (WebInspector.TabBar.prototype._handleMouseLeave):
1854 (WebInspector.TabBar.prototype._handleNewTabMouseEnter):
1856 * UserInterface/Views/TabBarItem.js: Added.
1857 (WebInspector.TabBarItem):
1858 (WebInspector.TabBarItem.prototype.get identifier):
1859 (WebInspector.TabBarItem.prototype.get element):
1860 (WebInspector.TabBarItem.prototype.get parentTabBar):
1861 (WebInspector.TabBarItem.prototype.set parentTabBar):
1862 (WebInspector.TabBarItem.prototype.get selected):
1863 (WebInspector.TabBarItem.prototype.set selected):
1864 (WebInspector.TabBarItem.prototype.get pinned):
1865 (WebInspector.TabBarItem.prototype.get image):
1866 (WebInspector.TabBarItem.prototype.set image):
1867 (WebInspector.TabBarItem.prototype.get title):
1868 (WebInspector.TabBarItem.prototype.set title):
1869 (WebInspector.TabBarItem.prototype.updateLayout):
1871 2015-04-25 Timothy Hatcher <timothy@apple.com>
1873 Web Inspector: Make closing ContentViews more leak proof
1874 https://bugs.webkit.org/show_bug.cgi?id=144200
1876 Remove all listeners on the target objects in close that match the this object.
1877 This makes things more foolproof when something changes or a new listener is
1878 added to the same object. TimelineRecordingContentView also had a leak where
1879 TimelineManager and DebuggerManager listeners were not being removed.
1881 Reviewed by Joseph Pecoraro.
1883 * UserInterface/Views/ApplicationCacheFrameContentView.js:
1884 (WebInspector.ApplicationCacheFrameContentView.prototype.closed):
1885 * UserInterface/Views/ClusterContentView.js:
1886 (WebInspector.ClusterContentView.prototype.closed):
1887 * UserInterface/Views/ContentFlowDOMTreeContentView.js:
1888 (WebInspector.ContentFlowDOMTreeContentView.prototype.closed):
1889 * UserInterface/Views/FrameDOMTreeContentView.js:
1890 (WebInspector.FrameDOMTreeContentView.prototype.closed):
1891 * UserInterface/Views/ResourceContentView.js:
1892 (WebInspector.ResourceContentView.prototype.closed):
1893 * UserInterface/Views/TextResourceContentView.js:
1894 (WebInspector.TextResourceContentView.prototype.closed):
1895 * UserInterface/Views/TimelineRecordingContentView.js:
1896 (WebInspector.TimelineRecordingContentView.prototype.closed):
1898 2015-04-25 Timothy Hatcher <timothy@apple.com>
1900 Web Inspector: Make closing ContentViews more leak proof
1901 https://bugs.webkit.org/show_bug.cgi?id=144200
1903 Remove all listeners on the target objects in close that match the this object.
1904 This makes things more foolproof when something changes or a new listener is
1905 added to the same object. TimelineRecordingContentView also had a leak where
1906 TimelineManager and DebuggerManager listeners were not being removed.
1908 Reviewed by Darin Adler.
1910 * UserInterface/Views/ApplicationCacheFrameContentView.js:
1911 (WebInspector.ApplicationCacheFrameContentView.prototype.closed):
1912 * UserInterface/Views/ClusterContentView.js:
1913 (WebInspector.ClusterContentView.prototype.closed):
1914 * UserInterface/Views/ContentFlowDOMTreeContentView.js:
1915 (WebInspector.ContentFlowDOMTreeContentView.prototype.closed):
1916 * UserInterface/Views/FrameDOMTreeContentView.js:
1917 (WebInspector.FrameDOMTreeContentView.prototype.closed):
1918 * UserInterface/Views/ResourceContentView.js:
1919 (WebInspector.ResourceContentView.prototype.closed):
1920 * UserInterface/Views/TextResourceContentView.js:
1921 (WebInspector.TextResourceContentView.prototype.closed):
1922 * UserInterface/Views/TimelineRecordingContentView.js:
1923 (WebInspector.TimelineRecordingContentView.prototype.closed):
1925 2015-04-25 Tobias Reiss <tobi+webkit@basecode.de>
1927 Web Inspector: assertion failure when editing inline styles
1928 https://bugs.webkit.org/show_bug.cgi?id=143939
1930 Reviewed by Timothy Hatcher.
1932 Prevent "_updateResourceContent" from being called on inline style changes.
1933 Introduce a flag that marks a CSSStyleSheet as a representation of an
1934 "ElementCSSInlineStyle" (DOM Level 2 spec) and return early.
1936 * UserInterface/Controllers/CSSStyleManager.js:
1937 (WebInspector.CSSStyleManager.prototype.styleSheetChanged):
1938 * UserInterface/Models/CSSStyleSheet.js:
1939 (WebInspector.CSSStyleSheet):
1940 (WebInspector.CSSStyleSheet.isInlineStyle):
1941 (WebInspector.CSSStyleSheet.prototype.markAsInlineStyle):
1942 * UserInterface/Models/DOMNodeStyles.js:
1943 (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1945 2015-04-24 Timothy Hatcher <timothy@apple.com>
1947 REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
1948 https://bugs.webkit.org/show_bug.cgi?id=144150
1950 Reviewed by Brian Burg.
1952 * UserInterface/Protocol/InspectorFrontendAPI.js:
1953 (InspectorFrontendAPI.setTimelineProfilingEnabled): Change !== to === when
1954 checking enabled to isCapturing().
1956 2015-04-23 Brian J. Burg <burg@cs.washington.edu>
1958 Web Inspector: run a customizable bootstrap function after the UI has fully loaded
1959 https://bugs.webkit.org/show_bug.cgi?id=144124
1961 Reviewed by Joseph Pecoraro.
1963 It can be really annoying to click through the Inspector UI dozens of times to debug one
1964 interaction or iterate on a specific widget.
1966 This patch adds a blank "bootstrap" function that can be used to hard-wire commands to
1967 automate repetitive UI state setup. The function is run immediately after the inspector loads.
1968 Setup commands can be shared as bug report reproduction steps.
1970 * UserInterface/Base/Bootstrap.js: Added.
1971 (WebInspector.runBootstrapOperations): Added.
1972 * UserInterface/Base/Main.js:
1973 (WebInspector.contentLoaded): Bootstrap after setting up everything and restoring view state from cookie.
1974 * UserInterface/Main.html:
1976 2015-04-23 Joseph Pecoraro <pecoraro@apple.com>
1978 Web Inspector: Adopt Object.assign and improve its display in Console
1979 https://bugs.webkit.org/show_bug.cgi?id=144135
1981 Reviewed by Darin Adler.
1983 * UserInterface/Models/NativeFunctionParameters.js:
1985 2015-04-23 Timothy Hatcher <timothy@apple.com>
1987 Web Inspector: DebuggerSidebarPanel's _callStackContentTreeOutline should suppress filtering
1988 https://bugs.webkit.org/show_bug.cgi?id=144114
1990 Reviewed by Joseph Pecoraro.
1992 * UserInterface/Views/DebuggerSidebarPanel.js:
1993 (WebInspector.DebuggerSidebarPanel):
1995 2015-04-23 Timothy Hatcher <timothy@apple.com>
1997 Web Inspector: Fix layering issues with ApplicationCacheFrameTreeElement
1998 https://bugs.webkit.org/show_bug.cgi?id=144113
2000 Reviewed by Joseph Pecoraro.
2002 * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
2003 (WebInspector.ApplicationCacheFrameTreeElement.prototype.updateTitles):
2004 (WebInspector.ApplicationCacheFrameTreeElement):
2006 2015-04-22 Matt Baker <mattbaker@apple.com>
2008 Web Inspector: clicking Timelines tree view nodes should not change the current content view
2009 https://bugs.webkit.org/show_bug.cgi?id=132202
2011 Reviewed by Brian Burg.
2013 TimelineSidebarPanel now prevents timeline views from switching to another content view while the content
2014 browser is showing the TimelineRecordingContentView. Code responsible for creating and updating the tree
2015 element close button, which was duplicated in multiple derived TimelineView classes, has been moved to the
2016 TimelineView base class.
2018 * UserInterface/Views/LayoutTimelineView.js:
2019 Updated name of location column, which was broken in a recent patch.
2020 (WebInspector.LayoutTimelineView.prototype.treeElementDeselected):
2021 (WebInspector.LayoutTimelineView.prototype.treeElementSelected):
2022 Added overrides of new base class methods to handle view-specific highlight logic.
2023 (WebInspector.LayoutTimelineView.prototype._treeElementDeselected): Deleted.
2024 (WebInspector.LayoutTimelineView.prototype._treeElementSelected): Deleted.
2025 (WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2026 (WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked): Deleted.
2027 Removed tree element close button logic.
2029 * UserInterface/Views/NetworkTimelineView.js:
2030 (WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement):
2031 (WebInspector.NetworkTimelineView.prototype.treeElementSelected):
2032 Added overrides of new base class methods.
2033 (WebInspector.NetworkTimelineView.prototype._treeElementDeselected): Deleted.
2034 (WebInspector.NetworkTimelineView.prototype._treeElementSelected): Deleted.
2035 Removed tree element close button logic.
2037 * UserInterface/Views/RenderingFrameTimelineView.js:
2038 (WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement):
2039 (WebInspector.RenderingFrameTimelineView.prototype.treeElementSelected):
2040 Added overrides of new base class methods.
2042 * UserInterface/Views/ResourceTimelineDataGridNode.js:
2043 (WebInspector.ResourceTimelineDataGridNode.prototype.get data):
2044 (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
2045 Removed unused Name column and added "go to" button to the Domain column to show the selected resource.
2047 * UserInterface/Views/ScriptTimelineView.js:
2048 (WebInspector.ScriptTimelineView):
2049 (WebInspector.ScriptTimelineView.prototype.showContentViewForTreeElement):
2050 (WebInspector.ScriptTimelineView.prototype.treeElementSelected):
2051 Added overrides of new base class methods.
2052 (WebInspector.ScriptTimelineView.prototype._dataGridNodeSelected):
2053 (WebInspector.ScriptTimelineView.prototype._treeElementDeselected): Deleted.
2054 (WebInspector.ScriptTimelineView.prototype._treeElementSelected): Deleted.
2055 (WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2056 (WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked): Deleted.
2057 Removed tree element close button logic.
2059 * UserInterface/Views/TimelineSidebarPanel.js:
2060 (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
2061 Prevent navigating to a different content view when showing the TimelineRecordingContentView.
2063 * UserInterface/Views/TimelineView.js:
2064 (WebInspector.TimelineView):
2065 (WebInspector.TimelineView.prototype.showContentViewForTreeElement):
2066 (WebInspector.TimelineView.prototype.treeElementDeselected):
2067 (WebInspector.TimelineView.prototype.treeElementSelected):
2068 Tree element selection handlers are now protected methods, which derived classes may override as needed.
2069 (WebInspector.TimelineView.prototype.needsLayout):
2070 (WebInspector.TimelineView.prototype._closeStatusButtonClicked):
2071 (WebInspector.TimelineView.prototype._updateTreeElementWithCloseButton):
2072 Encapsulated logic related to close button creation and behavior.
2074 2015-04-22 Timothy Hatcher <timothy@apple.com>
2076 Web Inspector: Remove an unused index argument from Sidebar.removeSidebarPanel
2077 https://bugs.webkit.org/show_bug.cgi?id=144054
2079 Reviewed by Darin Adler.
2081 * UserInterface/Views/Sidebar.js:
2083 2015-04-22 Timothy Hatcher <timothy@apple.com>
2085 Web Inspector: Fix an exception preventing switching timelines
2086 https://bugs.webkit.org/show_bug.cgi?id=144053
2088 Reviewed by Darin Adler.
2090 * UserInterface/Views/TreeOutline.js:
2091 (WebInspector.TreeElement.prototype.select): Store treeOutline in a local so
2092 we have a reference to it when we go to reset processingSelectionChange.
2093 The calls to onselect was removing the tree element from the outline, causing
2094 "delete this.treeOutline.processingSelectionChange" to throw an exception.
2095 This patch changes the delete to a set to false for good measure too.
2097 2015-04-21 Joseph Pecoraro <pecoraro@apple.com>
2099 Web Inspector: Use String.prototype.startsWith in more places
2100 https://bugs.webkit.org/show_bug.cgi?id=144025
2102 Reviewed by Timothy Hatcher.
2104 * UserInterface/Models/Gradient.js:
2105 * UserInterface/Views/DebuggerSidebarPanel.js:
2106 (WebInspector.DebuggerSidebarPanel.prototype._scriptAdded):
2107 * UserInterface/Views/ResourceSidebarPanel.js:
2108 (WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
2110 2015-04-21 Nikita Vasilyev <nvasilyev@apple.com>
2112 Web Inspector: Make formatted nodes more consistent with formatted objects
2113 https://bugs.webkit.org/show_bug.cgi?id=142159
2115 Reviewed by Timothy Hatcher.
2117 * UserInterface/Views/DOMTreeOutline.css:
2118 (.dom-tree-outline ol):
2119 Keep indentation exactly two spaces of Menlo.
2121 (.dom-tree-outline li):
2122 (.dom-tree-outline li.parent):
2123 (.dom-tree-outline li .html-tag.close):
2124 (.dom-tree-outline li.parent::before):
2125 (.dom-tree-outline:focus li.parent.selected::before):
2126 (.dom-tree-outline li.parent.expanded::before):
2127 (.dom-tree-outline:focus li.parent.expanded.selected::before):
2128 * UserInterface/Views/FormattedValue.css:
2129 (.formatted-node > .dom-tree-outline ol):
2130 Keep indentation exactly two spaces of Menlo.
2132 * UserInterface/Views/ObjectTreePropertyTreeElement.css:
2133 (.object-tree-property > .disclosure-button):
2134 Disclosure triangle is 13 by 13 pixels. Having it in the middle of 16 by 16
2135 pixels block makes it look bloory on non-retina screen, because:
2136 (16 - 13) / 2 = 1.5px. Replacing 16 with 15 fixes the problem.
2138 * UserInterface/Views/ObjectTreeView.css:
2139 (.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):
2141 2015-04-20 Joseph Pecoraro <pecoraro@apple.com>
2143 Web Inspector: Unify PrettyPrinting Tool and UserInterface resources
2144 https://bugs.webkit.org/show_bug.cgi?id=143969
2146 Reviewed by Timothy Hatcher.
2148 Have the PrettyPrinting tool just use the CodeMirror and WebInspector
2149 resources from the relative UserInterface directory. This avoids
2150 having duplicate resources in the tree which offered few advantages.
2152 * Scripts/update-pretty-printer.rb: Removed.
2153 * Tools/PrettyPrinting/CodeMirrorFormatters.js: Removed.
2154 * Tools/PrettyPrinting/Formatter.js: Removed.
2155 * Tools/PrettyPrinting/FormatterContentBuilder.js: Removed.
2156 * Tools/PrettyPrinting/codemirror.css: Removed.
2157 * Tools/PrettyPrinting/codemirror.js: Removed.
2158 * Tools/PrettyPrinting/css.js: Removed.
2159 * Tools/PrettyPrinting/index.html:
2160 * Tools/PrettyPrinting/javascript.js: Removed.
2162 * UserInterface/Views/CodeMirrorFormatters.js:
2165 2015-04-20 Joseph Pecoraro <pecoraro@apple.com>
2167 Web Inspector: Improve Support for WeakSet in Console
2168 https://bugs.webkit.org/show_bug.cgi?id=143951
2170 Reviewed by Darin Adler.
2172 * UserInterface/Models/NativeFunctionParameters.js:
2173 WeakSet has the same APIs and parameters as Set for the functions it implements.
2175 * UserInterface/Protocol/RemoteObject.js:
2176 (WebInspector.RemoteObject.prototype.isCollectionType):
2177 (WebInspector.RemoteObject.prototype.isWeakCollection):
2178 (WebInspector.RemoteObject.prototype.getCollectionEntries):
2179 (WebInspector.RemoteObject.prototype._weakCollectionObjectGroup):
2180 WeakSet is a weak collection.
2182 * UserInterface/Models/ObjectPreview.js:
2183 (WebInspector.ObjectPreview.prototype.hasSize):
2184 * UserInterface/Views/ConsoleMessageView.js:
2185 (WebInspector.ConsoleMessageView.prototype._formatParameter):
2186 * UserInterface/Views/FormattedValue.css:
2187 (.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset):
2188 (:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
2189 (.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap): Deleted.
2190 (:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap) > .size): Deleted.
2191 * UserInterface/Views/FormattedValue.js:
2192 (WebInspector.FormattedValue.createElementForTypesAndValue):
2193 Treat a WeakSet like a set in more places.
2195 2015-04-18 Nikita Vasilyev <nvasilyev@apple.com>
2197 Web Inspector: Pass multiple arguments to classList.add and classList.remove
2198 https://bugs.webkit.org/show_bug.cgi?id=143914
2200 classList.add and classList.remove can accept multiple arguments, use that.
2202 Reviewed by Timothy Hatcher.
2204 * UserInterface/Base/Main.js:
2205 (WebInspector.updateDockedState):
2206 * UserInterface/Views/DOMTreeDataGrid.js:
2207 (WebInspector.DOMTreeDataGrid):
2208 * UserInterface/Views/DOMTreeOutline.js:
2209 (WebInspector.DOMTreeOutline):
2210 * UserInterface/Views/DataGrid.js:
2211 (WebInspector.DataGridNode.prototype.set hasChildren):
2212 * UserInterface/Views/DatabaseContentView.js:
2213 (WebInspector.DatabaseContentView):
2214 * UserInterface/Views/DetailsSection.js:
2215 (WebInspector.DetailsSection):
2216 * UserInterface/Views/DetailsSectionPropertiesRow.js:
2217 (WebInspector.DetailsSectionPropertiesRow):
2218 * UserInterface/Views/GeneralTreeElement.js:
2219 (WebInspector.GeneralTreeElement.prototype.set classNames):
2220 * UserInterface/Views/NavigationItem.js:
2221 (WebInspector.NavigationItem):
2222 * UserInterface/Views/ResourceContentView.js:
2223 (WebInspector.ResourceContentView):
2224 * UserInterface/Views/ResourceTimelineDataGridNode.js:
2225 (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
2226 * UserInterface/Views/Sidebar.js:
2227 (WebInspector.Sidebar):
2228 * UserInterface/Views/SidebarPanel.js:
2229 (WebInspector.SidebarPanel):
2230 * UserInterface/Views/SourceCodeTextEditor.js:
2231 * UserInterface/Views/TextEditor.js:
2232 (WebInspector.TextEditor):
2233 * UserInterface/Views/TimelineRuler.js:
2235 2015-04-18 Nikita Vasilyev <nvasilyev@apple.com>
2237 Web Inspector: Make prototype pill’s background semi-transparent
2238 https://bugs.webkit.org/show_bug.cgi?id=143928
2240 Reviewed by Timothy Hatcher.
2242 * UserInterface/Views/ObjectTreePropertyTreeElement.css:
2243 (.object-tree-property.prototype-property):
2245 (.object-tree-property.prototype-property:hover, .object-tree-property.prototype-property:focus):
2246 Slightly highlight the prototype pill when hovering over.
2248 2015-04-17 Jono Wells <jonowells@apple.com>
2250 Web Inspector: All sans-serif font family rules should be set the same way.
2251 https://bugs.webkit.org/show_bug.cgi?id=143909
2253 Reviewed by Timothy Hatcher.
2255 Update styles so that all uses of sans-serif font use -webkit-system-font consistently.
2257 * UserInterface/Views/DefaultDashboardView.css:
2258 (body.mac-platform.legacy .toolbar .dashboard.default > .item):
2259 * UserInterface/Views/ObjectTreePropertyTreeElement.css:
2260 (.object-tree-property .prototype-name):
2261 * UserInterface/Views/ObjectTreeView.css:
2262 (.object-tree-outline li .empty-message):
2263 * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
2264 (.timeline-overview-graph.rendering-frame > .divider > .label):
2266 2015-04-17 Timothy Hatcher <timothy@apple.com>
2268 Web Inspector: Have better inactive window color for pixel borders
2269 https://bugs.webkit.org/show_bug.cgi?id=143888
2271 Reviewed by Joseph Pecoraro.
2273 * UserInterface/Views/FindBanner.css:
2274 (body.window-inactive .find-banner):
2275 * UserInterface/Views/Main.css:
2276 (body.window-inactive.docked.bottom):
2277 (body.window-inactive.docked.right):
2278 (body.window-inactive #split-content-browser):
2279 * UserInterface/Views/NavigationBar.css:
2280 (body.window-inactive .navigation-bar):
2281 * UserInterface/Views/QuickConsole.css:
2282 (body.window-inactive .quick-console):
2283 (.quick-console.showing-log):
2284 * UserInterface/Views/Sidebar.css:
2285 (body.window-inactive .sidebar.left):
2286 (body.window-inactive .sidebar.right):
2288 2015-04-17 Joseph Pecoraro <pecoraro@apple.com>
2290 Web Inspector: Unexpected background at top of console when rubber-banding with selection
2291 https://bugs.webkit.org/show_bug.cgi?id=140710
2293 Reviewed by Timothy Hatcher.
2295 * UserInterface/Views/LogContentView.css:
2296 (.console-messages):
2297 Remove the focus ring on the console's log view, only visible when rubber-banding.
2299 2015-04-16 Jono Wells <jonowells@apple.com>
2301 Web Inspector: Breakpoint icons should not get pushed off of debugger sidebar due to long resource names
2302 https://bugs.webkit.org/show_bug.cgi?id=142714
2304 Reviewed by Timothy Hatcher.
2306 Modify the styles for content and group containers inside the debugger sidebar panel's detail sections
2307 such that the rules "display: table" and "display: table-row-group" no longer apply. This will make
2308 the file names which use the rule "text-overflow: ellipsis" truncate as expected.
2310 * UserInterface/Views/DebuggerSidebarPanel.css:
2311 (.sidebar > .panel.navigation.debugger .details-section > .content):
2312 (.sidebar > .panel.navigation.debugger .details-section.collapsed > .content):
2313 (.sidebar > .panel.navigation.debugger .details-section > .content > .group):
2314 (.sidebar > .panel.navigation.debugger .details-section.scripts):
2315 (.sidebar > .panel.navigation.debugger .details-section.scripts .header):
2316 (.sidebar > .panel.navigation.debugger .details-section.scripts.collapsed > .content):
2318 2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
2320 Web Inspector: Should include "Log Value" context menu item in Preview and Collapsed ObjectTree
2321 https://bugs.webkit.org/show_bug.cgi?id=143845
2323 Reviewed by Timothy Hatcher.
2325 Give previews the same "Log Value" context menu so that if you just log
2326 a bunch of objects to the console you can quickly turn that entire object
2327 into a $n reference in the console to interact with.
2329 * UserInterface/Views/ObjectPreviewView.js:
2330 (WebInspector.ObjectPreviewView.prototype.setOriginatingObjectInfo):
2331 (WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
2332 Provide API to refer to a RemoteObject and optional PropertyPath
2333 that can be used to give the preview a "Log Value" context menu.
2335 * UserInterface/Views/ConsoleMessageView.js:
2336 (WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
2337 Include the RemoteObject without a path for a preview context menu.
2339 * UserInterface/Views/ObjectTreeView.js:
2340 (WebInspector.ObjectTreeView):
2341 Include the RemoteObject with a path if we knew it for a preview context menu.
2343 * UserInterface/Views/ObjectTreeBaseTreeElement.js:
2344 (WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
2345 The context menu can never be empty, since we always added at least one item above.
2348 2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
2350 Web Inspector: "Log Value" of a value inside of an array, does not log the innermost value
2351 https://bugs.webkit.org/show_bug.cgi?id=143793
2353 Reviewed by Brian Burg.
2355 Context menu handlers were being handled in the capturing event phase, so
2356 the outer most handler, instead of the inner most handler, was getting
2357 first access. Change this so the events happen in the bubbling phase.
2359 DOM Nodes may appear inside of Object Trees, for instance when shown
2360 in a collection like an array or set. In an effort to standardize on
2361 "inner most" behavior, change the DOMTreeOutline context handler
2362 to also be in bubbling.
2364 In the rare instances where a node object is in the console but
2365 not displayed in an outline (console.dir(node)), then include a
2366 Copy as HTML context menu like you would expect in a DOM tree.
2368 * UserInterface/Views/DOMTreeOutline.js:
2369 (WebInspector.DOMTreeOutline):
2370 * UserInterface/Views/GeneralTreeElement.js:
2371 (WebInspector.GeneralTreeElement.prototype.onattach):
2372 (WebInspector.GeneralTreeElement.prototype.ondetach):
2373 * UserInterface/Views/ObjectTreeBaseTreeElement.js:
2374 (WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
2375 (WebInspector.ObjectTreeBaseTreeElement):
2377 2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
2379 Web Inspector: Allow toggling the edibility of a DOMTreeOutline
2380 https://bugs.webkit.org/show_bug.cgi?id=143814
2382 Reviewed by Brian Burg.
2384 By default a DOMTreeOutline will not be editable, but it will
2385 provide a setter to enable editability for DOMTreeContentViews.
2387 * UserInterface/Views/DOMTreeContentView.js:
2388 (WebInspector.DOMTreeContentView):
2389 Content Views always have editable DOM trees.
2391 * UserInterface/Views/DOMTreeElement.js:
2392 (WebInspector.DOMTreeElement.prototype.get editable):
2393 (WebInspector.DOMTreeElement.prototype.onattach):
2394 (WebInspector.DOMTreeElement.prototype.ondelete):
2395 (WebInspector.DOMTreeElement.prototype.onenter):
2396 (WebInspector.DOMTreeElement.prototype.ondblclick):
2397 (WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
2398 (WebInspector.DOMTreeElement.prototype._populateTextContextMenu):
2399 (WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
2400 (WebInspector.DOMTreeElement.prototype._startEditing):
2401 Do not provide editability options for shadow DOM or non-editable DOM tree.
2403 * UserInterface/Views/DOMTreeOutline.js:
2404 (WebInspector.DOMTreeOutline):
2405 (WebInspector.DOMTreeOutline.prototype.get editable):
2406 (WebInspector.DOMTreeOutline.prototype.set editable):
2409 * UserInterface/Views/FormattedValue.css:
2410 (.formatted-node > .dom-tree-outline li):
2411 Nodes inside object trees were showing text selection when you right
2412 clicked them. Normal selection is not possible. So force no selection.
2414 2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
2416 Web Inspector: Give DOM Nodes a Context Menu to Log Element to the console
2417 https://bugs.webkit.org/show_bug.cgi?id=143813
2419 Reviewed by Brian Burg.
2421 Always give DOM Nodes a "Log Element" context menu to log it to the console.
2422 This will give a $n reference, and is a convenient alternative to $0 or
2423 the now removed $1-$9.
2425 * Localizations/en.lproj/localizedStrings.js:
2426 New "Log Element" and "Selected Element" strings.
2428 * UserInterface/Views/DOMTreeOutline.js:
2429 (WebInspector.DOMTreeOutline):
2430 (WebInspector.DOMTreeOutline.prototype._contextMenuEventFired):
2431 (WebInspector.DOMTreeOutline.prototype._updateModifiedNodes):
2432 (WebInspector.DOMTreeOutline.prototype._populateContextMenu.revealElement):
2433 (WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
2434 (WebInspector.DOMTreeOutline.prototype._populateContextMenu):
2435 Always include the "Log Element" context menu/
2437 * UserInterface/Views/FormattedValue.js:
2438 (WebInspector.FormattedValue.createElementForNode):
2439 This uses all the defaults.
2441 * UserInterface/Views/DOMTreeContentView.js:
2442 (WebInspector.DOMTreeContentView):
2443 This enables all the extra behavior.
2445 2015-04-16 Joseph Pecoraro <pecoraro@apple.com>
2447 Web Inspector: Remove unnecessary intermediate object from DOMTreeOutline
2448 https://bugs.webkit.org/show_bug.cgi?id=143811
2450 Reviewed by Brian Burg.
2452 * UserInterface/Views/DOMTreeOutline.js:
2453 (WebInspector.DOMTreeOutline):
2454 (WebInspector.DOMTreeOutline.prototype._selectedNodeChanged):
2455 (WebInspector.DOMTreeOutline.prototype.addEventListener): Deleted.
2456 (WebInspector.DOMTreeOutline.prototype.removeEventListener): Deleted.
2457 This object used to be used to handle event dispatching, but
2458 TreeOutlines themselves are now WebInspector.Objects so we
2459 can remove the intermediary.
2461 2015-04-15 Joseph Pecoraro <pecoraro@apple.com>
2463 Web Inspector: InspectorTest frontend console methods redirected to the frontend are wrong
2464 https://bugs.webkit.org/show_bug.cgi?id=143801
2466 Reviewed by Brian Burg.
2468 * UserInterface/Base/Test.js:
2469 (InspectorTest.evaluateInPage):
2470 Properly if check for the existence of an agent.
2473 Properly hook up console redirect handlers so they
2474 will output the right type and arguments strings.
2476 2015-04-15 Joseph Pecoraro <pecoraro@apple.com>
2478 Web Inspector: Handle all possible Console message Source types in IssueMessage
2479 https://bugs.webkit.org/show_bug.cgi?id=143803
2481 Reviewed by Brian Burg.
2483 * UserInterface/Models/IssueMessage.js:
2484 (WebInspector.IssueMessage):
2485 Update the switch to handle all possible console message sources.
2486 "wml" was legacy and no longer supported.
2488 2015-04-14 Joseph Pecoraro <pecoraro@apple.com>
2490 Web Inspector: Uncaught exception in JSContext inspector when opening
2491 https://bugs.webkit.org/show_bug.cgi?id=143741
2493 Reviewed by Timothy Hatcher.
2495 * UserInterface/Controllers/TimelineManager.js:
2496 (WebInspector.TimelineManager.shouldShowViewForTimeline):
2497 (WebInspector.TimelineManager.prototype._loadNewRecording):
2498 Before using TimelineAgent, check for its existence first. It may
2499 not exist in JSContext inspection.
2501 2015-04-14 Nikita Vasilyev <nvasilyev@apple.com>
2503 Web Inspector: Align array's indices and set's bullet points under the property icon
2504 https://bugs.webkit.org/show_bug.cgi?id=143698
2506 Reviewed by Timothy Hatcher.
2508 * UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
2509 (.object-tree-array-index.object-tree-map-entry > .titles > .title > .index-name):
2510 * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
2511 (.object-tree-array-index .index-name):
2512 Right align array's and set's indices.
2514 (.object-tree-map-entry):
2515 Overwrite left property from .object-tree-array-index.
2517 (.object-tree-property + ol .object-tree-map-entry):
2518 Overwrite left property from .object-tree-property + ol .object-tree-array-index.
2520 2015-04-13 Joseph Pecoraro <pecoraro@apple.com>
2522 Web Inspector: Expanding window.navigator.mimeTypes in ObjectTree shows no native properties
2523 https://bugs.webkit.org/show_bug.cgi?id=143690
2525 Reviewed by Timothy Hatcher.
2527 * UserInterface/Views/ObjectTreePropertyTreeElement.js:
2528 (WebInspector.ObjectTreePropertyTreeElement):
2529 Fix a typo that resulted in hiding properties of native objects
2530 in the Properties section of an Object Tree.
2532 2015-04-13 Joseph Pecoraro <pecoraro@apple.com>
2534 Web Inspector: Remove unnecessary 3 second delay when archiving page
2535 https://bugs.webkit.org/show_bug.cgi?id=143688
2537 Reviewed by Timothy Hatcher.
2539 * UserInterface/Base/Main.js:
2540 (WebInspector.archiveMainFrame):
2541 The delay is unnecessary and was probably just debugging code.
2543 2015-04-11 Matt Baker <mattbaker@apple.com>
2545 Web Inspector: Hide Frames Timeline if the backend doesn't support it
2546 https://bugs.webkit.org/show_bug.cgi?id=142800
2548 Reviewed by Timothy Hatcher.
2550 Fallback to showing the layout timeline if the backend doesn't support the rendering frames timeline.
2552 * UserInterface/Controllers/TimelineManager.js:
2553 (WebInspector.TimelineManager.shouldShowViewForTimeline):
2554 (WebInspector.TimelineManager.prototype._loadNewRecording):
2555 Added iOS 8 compatibility check for RenderingFrame timeline record type.
2557 * UserInterface/Views/LayoutTimelineDataGridNode.js:
2558 (WebInspector.LayoutTimelineDataGridNode.prototype.get data):
2559 Restored fields used by Layout timeline view.
2561 * UserInterface/Views/LayoutTimelineView.js:
2562 Updated to be compatible with both RenderingFrame and Layout timeline views.
2564 2015-04-11 Jono Wells <jonowells@apple.com>
2566 Web Inspector: Debugger sidebar should show errors underneath scripts
2567 https://bugs.webkit.org/show_bug.cgi?id=143464
2569 Reviewed by Timothy Hatcher.
2571 Add a new tree element called IssueTreeElement. This shows warnings and errors in the debugger sidebar. These
2572 can be clicked to jump to the line of source code for which the error was thrown. BreakpointTreeElement and
2573 IssueTreeElement now inherit from DebuggerTreeElement to support any needed commonalities among the interfaces
2574 of elements in the debugger sidebar panel.
2576 * Localizations/en.lproj/localizedStrings.js: Updated.
2577 * UserInterface/Main.html: Add new files.
2579 * UserInterface/Models/IssueMessage.js:
2580 (WebInspector.IssueMessage):
2581 (WebInspector.IssueMessage.prototype.get source):
2582 (WebInspector.IssueMessage.prototype.get lineNumber):
2583 (WebInspector.IssueMessage.prototype.get columnNumber):
2584 (WebInspector.IssueMessage.prototype.get displayLineNumber):
2585 (WebInspector.IssueMessage.prototype.get displayColumnNumber):
2586 (WebInspector.IssueMessage.prototype.get sourceCodeLocation):
2587 (WebInspector.IssueMessage.prototype.saveIdentityToCookie):
2588 (WebInspector.IssueMessage.prototype._sourceCodeLocationDisplayLocationChanged):
2589 Convert to use a backing SourceCodeLocation. Expand API.
2591 * UserInterface/Views/BreakpointTreeElement.js: Inherits now from DebuggerTreeElement.
2593 * UserInterface/Views/DebuggerSidebarPanel.js:
2594 (WebInspector.DebuggerSidebarPanel.showResourcesWithBreakpointsOnlyFilterFunction):
2595 (WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction):
2596 (WebInspector.DebuggerSidebarPanel):
2597 (WebInspector.DebuggerSidebarPanel.prototype._addBreakpoint):
2598 (WebInspector.DebuggerSidebarPanel.prototype._breakpointRemoved):
2599 (WebInspector.DebuggerSidebarPanel.prototype._handleDebuggerObjectDisplayLocationDidChange):
2600 (WebInspector.DebuggerSidebarPanel.prototype._removeDebuggerTreeElement):
2601 (WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
2602 (WebInspector.DebuggerSidebarPanel.prototype._compareDebuggerTreeElements):
2603 (WebInspector.DebuggerSidebarPanel.prototype._addDebuggerObject):
2604 (WebInspector.DebuggerSidebarPanel.prototype._addIssue):
2605 (WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):
2606 (WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
2607 (WebInspector.DebuggerSidebarPanel.prototype._breakpointDisplayLocationDidChange): Deleted.
2608 (WebInspector.DebuggerSidebarPanel.prototype._removeBreakpointTreeElement): Deleted.
2609 (WebInspector.DebuggerSidebarPanel.prototype._compareBreakpointTreeElements): Deleted.
2610 Add IssueTreeElements to the sidebar whenever a warning or error corresponding to a line of code is found.
2611 Add a filter function and button to filter down to just these. Ensure issue and breakpoint elements can be
2614 * UserInterface/Views/DebuggerTreeElement.js: Added.
2615 (WebInspector.DebuggerTreeElement):
2616 (WebInspector.DebuggerTreeElement.prototype.get debuggerObject):
2618 * UserInterface/Views/IssueTreeElement.css: Added.
2620 (.issue.error .icon):
2621 (.navigation-sidebar-panel-content-tree-outline .item.small.issue .icon):
2623 * UserInterface/Views/IssueTreeElement.js: Added.
2624 (WebInspector.IssueTreeElement):
2625 (WebInspector.IssueTreeElement.prototype.get issueMessage):
2626 (WebInspector.IssueTreeElement.prototype._updateTitles):
2628 2015-04-11 Matt Baker <mattbaker@apple.com>
2630 Web Inspector: create content view and details sidebar for Frames timeline
2631 https://bugs.webkit.org/show_bug.cgi?id=143533
2633 Reviewed by Timothy Hatcher.
2635 Added new Rendering Frames timeline content view and details sidebar, and added minor visual tweeks to the
2636 timeline graph such as ensuring 60 FPS budget line is always visible, and large combined frames are split
2637 up once they reach a maximum pixel width.
2639 * Localizations/en.lproj/localizedStrings.js:
2642 * UserInterface/Base/Main.js:
2643 (WebInspector.contentLoaded):
2644 Support for new details sidebar panel.
2646 * UserInterface/Controllers/TimelineManager.js:
2647 (WebInspector.TimelineManager.shouldShowViewForTimeline):
2648 (WebInspector.TimelineManager.prototype._processRecord):
2649 (WebInspector.TimelineManager.prototype._loadNewRecording):
2650 Layout timeline is no longer added to timeline graphs, skip Rendering Frame records that have no child events.
2652 * UserInterface/Images/NavigationItemDoughnutChart.svg: Added.
2653 * UserInterface/Images/TimelineRecordRenderingFrame.svg: Added.
2656 * UserInterface/Main.html:
2657 * UserInterface/Test.html:
2660 * UserInterface/Models/RenderingFrameTimelineRecord.js: Renamed from Source/WebInspectorUI/UserInterface/Models/RunLoopTimelineRecord.js.
2661 (WebInspector.RenderingFrameTimelineRecord):
2662 (WebInspector.RenderingFrameTimelineRecord.resetFrameNumber):
2663 (WebInspector.RenderingFrameTimelineRecord.prototype.get frameNumber):
2664 (WebInspector.RenderingFrameTimelineRecord.prototype.get children):
2665 (WebInspector.RenderingFrameTimelineRecord.prototype.get durationRemainder):
2666 (WebInspector.RenderingFrameTimelineRecord.prototype.durationForRecords.get var):
2667 Added frame numbering and improved the accuracy of sub-frame duratation calculation.
2668 Refactoring: RunLoop prefix changed to RenderingFrame.
2670 * UserInterface/Models/Timeline.js:
2671 (WebInspector.Timeline):
2672 (WebInspector.Timeline.create):
2673 (WebInspector.Timeline.prototype.get recording):
2674 (WebInspector.Timeline.prototype.get displayName):
2675 (WebInspector.Timeline.prototype.get iconClassName):
2676 Added up-pointer to parent recording.
2678 * UserInterface/Models/TimelineRecord.js:
2679 Refactoring: RunLoop prefix changed to RenderingFrame.
2681 * UserInterface/Models/TimelineRecording.js:
2682 (WebInspector.TimelineRecording.prototype.reset):
2683 Support for new timeline type.
2685 * UserInterface/Views/ChartDetailsSectionLegendRow.js: Added.
2686 (WebInspector.ChartDetailsSectionLegendRow):
2687 New details section row type for chart legend items.
2689 * UserInterface/Views/ChartDetailsSectionRow.css: Added.
2690 (.details-section .row.chart):
2691 (.details-section .row.chart canvas):
2692 (.details-section .row.chart.empty canvas):
2693 (.details-section > .content > .group > .row.legend-item > .label > .color-swatch):
2694 * UserInterface/Views/ChartDetailsSectionRow.js: Added.
2695 (WebInspector.ChartDetailsSectionRow):
2696 (WebInspector.ChartDetailsSectionRow.prototype.get legendGroup):
2697 (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2698 (WebInspector.ChartDetailsSectionRow.prototype.addChartValue):
2699 (WebInspector.ChartDetailsSectionRow.prototype.clearChart):
2700 (WebInspector.ChartDetailsSectionRow.prototype._refresh.drawSlice):
2701 (WebInspector.ChartDetailsSectionRow.prototype._refresh):
2702 New details section row type for pie/doughnut charts.
2704 * UserInterface/Views/ContentView.js:
2705 (WebInspector.ContentView):
2706 Support for new timeline view type.
2708 * UserInterface/Views/LayoutTimelineDataGridNode.js:
2709 (WebInspector.LayoutTimelineDataGridNode.prototype.get data):
2710 (WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
2711 Updated for use in rendering frame timeline view.
2713 * UserInterface/Views/LayoutTimelineView.js:
2714 (WebInspector.LayoutTimelineView.prototype._layoutTimelineRecordAdded):
2715 Removed references to old RunLoop objects.
2717 * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js: Added.
2718 (WebInspector.RenderingFrameDetailsSidebarPanel.formatChartValue):
2719 (WebInspector.RenderingFrameDetailsSidebarPanel):
2720 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.inspect):
2721 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.updateRangeSelection):
2722 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.get renderingFrameTimeline):
2723 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.set renderingFrameTimeline):
2724 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.refresh.durationForRecordType):
2725 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.refresh):
2726 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._resetAll):
2727 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._recordAdded):
2728 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._timelineReset):
2729 (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._getSelectedRecords):
2730 New sidebar panel for showing time breakdown for current frame selection.
2732 * UserInterface/Views/RenderingFrameTimelineDataGridNode.js: Added.
2733 (WebInspector.RenderingFrameTimelineDataGridNode):
2734 (WebInspector.RenderingFrameTimelineDataGridNode.prototype.get record):
2735 (WebInspector.RenderingFrameTimelineDataGridNode.prototype.get records):
2736 (WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
2737 (WebInspector.RenderingFrameTimelineDataGridNode.prototype.createCellContent):
2738 New data grid row type.
2740 * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css: Renamed from Source/WebInspectorUI/UserInterface/Views/RunLoopTimelineOverviewGraph.css.
2741 (.timeline-overview-graph.rendering-frame > .divider):
2742 (.timeline-overview-graph.rendering-frame > .divider > .label):
2743 * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js: Renamed from Source/WebInspectorUI/UserInterface/Views/RunLoopTimelineOverviewGraph.js.
2744 (WebInspector.RenderingFrameTimelineOverviewGraph):
2745 (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.get graphHeightSeconds):
2746 (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.updateLayout.createFrame):
2747 (WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition.get if):
2748 * UserInterface/Views/RenderingFrameTimelineView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/RunLoopTimelineOverviewGraph.css.
2749 (.timeline-view.rendering-frame > .data-grid):
2750 (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item .subtitle):
2752 Refactoring: RunLoop prefix changed to RenderingFrame.
2754 * UserInterface/Views/RenderingFrameTimelineView.js: Added.
2755 (WebInspector.RenderingFrameTimelineView):
2756 (WebInspector.RenderingFrameTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
2757 (WebInspector.RenderingFrameTimelineView.prototype.shown):
2758 (WebInspector.RenderingFrameTimelineView.prototype.hidden):
2759 (WebInspector.RenderingFrameTimelineView.prototype.updateLayout):
2760 (WebInspector.RenderingFrameTimelineView.prototype.get selectionPathComponents):
2761 (WebInspector.RenderingFrameTimelineView.prototype.filterDidChange):
2762 (WebInspector.RenderingFrameTimelineView.prototype.matchTreeElementAgainstCustomFilters):
2763 (WebInspector.RenderingFrameTimelineView.prototype.reset):
2764 (WebInspector.RenderingFrameTimelineView.prototype.treeElementPathComponentSelected):
2765 (WebInspector.RenderingFrameTimelineView.prototype.dataGridNodeForTreeElement):
2766 (WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
2767 (WebInspector.RenderingFrameTimelineView.prototype._renderingFrameTimelineRecordAdded):
2768 (WebInspector.RenderingFrameTimelineView.prototype._dataGridNodeSelected):
2769 New content view type.
2771 * UserInterface/Views/TimelineIcons.css:
2772 (.rendering-frame-icon .icon):
2773 (.rendering-frame-icon.large .icon):
2774 (.rendering-frame-record .icon):
2775 (.runloop-record .icon):
2776 (.runloop-icon .icon): Deleted.
2777 (.runloop-icon.large .icon): Deleted.
2778 Refactoring: runloop prefix changed to rendering-frame.
2780 * UserInterface/Views/TimelineOverview.js:
2781 (WebInspector.TimelineOverview.prototype._timelineRemoved):
2782 Support for timelines without associated views.
2784 * UserInterface/Views/TimelineOverviewGraph.js:
2785 (WebInspector.TimelineOverviewGraph):
2786 Refactoring: RunLoop prefix changed to RenderingFrame.
2788 * UserInterface/Views/TimelineRecordFrame.css:
2789 (.timeline-record-frame):
2790 (.timeline-record-frame > .frame):
2791 * UserInterface/Views/TimelineRecordFrame.js:
2792 (WebInspector.TimelineRecordFrame.createCombinedFrames):
2793 Visual tweeks, splitting up large combined frames.
2795 * UserInterface/Views/TimelineRecordTreeElement.js:
2796 (WebInspector.TimelineRecordTreeElement):
2797 Refactoring: runloop prefix changed to rendering-frame.
2799 * UserInterface/Views/TimelineRecordingContentView.js:
2800 (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
2801 (WebInspector.TimelineRecordingContentView.prototype._timelineCountChanged):
2802 (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
2803 Added support for new details sidebar and timelines without associated views.
2805 * UserInterface/Views/TimelineSidebarPanel.js:
2806 (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
2807 Support for timelines without associated views.
2808 Refactoring: runloop prefix changed to rendering-frame.
2810 * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2811 * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2814 2015-04-11 Nikita Vasilyev <nvasilyev@apple.com>
2816 Web Inspector: Use semi-transparent map item dividers
2817 https://bugs.webkit.org/show_bug.cgi?id=143630
2819 Reviewed by Timothy Hatcher.
2821 * UserInterface/Views/ObjectTreeMapEntryTreeElement.css:
2822 (.object-tree-map-entry.key:not(:first-child)):
2823 (.object-tree-map-entry.key): Deleted.
2824 (.object-tree-map-entry.key:first-of-type): Deleted.
2825 Use one selector instead of two.
2827 2015-04-11 Nikita Vasilyev <nvasilyev@apple.com>
2829 Web Inspector: Objects are vertically misaligned by 1px
2830 https://bugs.webkit.org/show_bug.cgi?id=143629
2832 Reviewed by Timothy Hatcher.
2834 * UserInterface/Views/FormattedValue.css:
2835 (.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap):
2837 2015-04-10 Joseph Pecoraro <pecoraro@apple.com>
2839 Web Inspector: Fix Console Message Toggle
2841 Unreviewed. Correct a post-review comment fix that went too far.
2843 * UserInterface/Views/ConsoleMessageView.js:
2844 (WebInspector.ConsoleMessageView.prototype.set expandable):
2845 The handler needed to be bound to the object.
2847 2015-04-10 Joseph Pecoraro <pecoraro@apple.com>
2849 Web Inspector: Fix Console Filter Search, Uncaught Exception
2851 Rubber-stamped by Timothy Hatcher.
2853 * UserInterface/Views/LogContentView.js:
2854 (WebInspector.LogContentView.prototype._performSearch):
2855 This regressed with recent refactoring. Fix up the property and class names.
2857 2015-04-10 Joseph Pecoraro <pecoraro@apple.com>
2859 Web Inspector: Improve Console Message Formatting
2860 https://bugs.webkit.org/show_bug.cgi?id=143623
2862 Reviewed by Timothy Hatcher.
2864 * Localizations/en.lproj/localizedStrings.js:
2865 * UserInterface/Main.html:
2868 * UserInterface/Views/ConsoleMessageView.css: Added.
2869 (.console-message.expandable .console-top-level-message::before):
2870 (.console-message.expandable.expanded .console-top-level-message::before):
2871 (.console-message.expandable.expanded :matches(.console-message-preview, .console-message-preview-divider)):
2872 (.console-message-preview-divider):
2873 (.console-message-enclosed):
2874 (.console-message .console-message-stack-trace-container):
2875 (.console-message.expandable.expanded .console-message-stack-trace-container):
2876 (.console-message .console-message-stack-trace-container > li):
2877 (.console-message .console-message-extra-parameters-container > li::before):
2878 New styles for the new ConsoleMessageView children.
2879 Handle console message expansion, a list of extra parameters
2880 and a potential list of stack frames.
2882 (.console-message, .console-user-command):
2883 (.console-message .repeat-count):
2884 (.console-message-text):
2885 (.console-message-text > span):
2886 (.console-error-level):
2887 (.console-error-level .console-message-text):
2888 (.console-debug-level .console-message-text):
2889 (.console-warning-level):
2890 (.console-warning-level .console-message-text):
2891 (.console-user-command .console-message):
2892 (.console-error-level::before):
2893 (.console-warning-level::before):
2894 (.console-user-command::before):
2895 (.console-debug-level::before):
2896 (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message):
2897 (:matches(.console-warning-level, .console-error-level, .console-log-level)::before):
2898 (.console-user-command > .console-message-text):
2899 (.console-message-url):
2900 (.console-saved-variable):
2901 (.console-user-command-result):
2902 (.console-user-command-result.console-log-level::before):
2903 Moved from LogContentView.css to here where it is more appropriate
2904 since ConsoleMessageView added them.
2906 * UserInterface/Views/ConsoleMessageView.js:
2907 (WebInspector.ConsoleMessageView):
2908 (WebInspector.ConsoleMessageView.prototype.get expandable):
2909 (WebInspector.ConsoleMessageView.set expandable.this._boundExpandClickHandler):
2910 (WebInspector.ConsoleMessageView.prototype.set expandable):
2911 (WebInspector.ConsoleMessageView.prototype.expand):
2912 (WebInspector.ConsoleMessageView.prototype.collapse):
2913 (WebInspector.ConsoleMessageView.prototype.toggle):
2914 Provide high level constructs for making a ConsoleMessageView
2915 expandable, and APIs to expand/collapse.
2917 (WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
2918 Add and style the new list of extra parameters.
2920 (WebInspector.ConsoleMessageView.prototype._appendStackTrace):
2921 Add and style the new list stack frames.
2923 (WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
2924 (WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):
2925 Handling the top level message text line for all the different cases.
2927 * UserInterface/Views/DOMTreeElement.js:
2928 (WebInspector.DOMTreeElement.prototype._startEditingTarget):
2929 (WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
2930 * UserInterface/Views/DOMTreeOutline.css:
2931 (.dom-tree-outline .add-attribute): Deleted.
2932 CSS class .add-attribute was not used. Remove all references.
2934 (.webkit-html-fragment.shadow):
2935 Moved from LogContentView.css to a more appropriate place.
2937 * UserInterface/Views/FormattedValue.js:
2938 (WebInspector.FormattedValue.createObjectPreviewOrFormattedValueForRemoteObject):
2939 Helper to create a preview or a formatted value for a given object.
2941 * UserInterface/Views/LogContentView.js:
2942 (WebInspector.LogContentView):
2943 (WebInspector.LogContentView.prototype._updateMessagesSelection):
2944 (WebInspector.LogContentView.prototype._leftArrowWasPressed):
2945 (WebInspector.LogContentView.prototype._rightArrowWasPressed):
2946 (WebInspector.LogContentView.prototype._rightArrowWasPressed.else.outlineTitle.treeElement.onexpand): Deleted.
2947 (WebInspector.LogContentView.prototype._propertiesSectionDidUpdateContent): Deleted.
2948 Lots of this code no longer makes sense. Delete some and put FIXMEs
2949 where it makes sense to re-add back useful features.
2951 * UserInterface/Views/ObjectPreviewView.css:
2952 (.object-preview > .size):
2953 * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
2954 (.object-tree-array-index .index-value .object-tree): Deleted.
2955 * UserInterface/Views/ObjectTreeView.css:
2957 Tweak styles. Opacity instead of a specific gray to better work
2958 with other colors. Always make objects be inline-block.
2960 * UserInterface/Views/LogContentView.css:
2961 (.console-error-level + .console-item):
2962 (.console-warning-level + .console-item):
2963 (.console-item::before):
2964 (.console-user-command-result): Deleted.
2965 (.console-user-command-result.console-log-level::before): Deleted.
2966 (.console-message, .console-user-command): Deleted.
2967 (.console-message .repeat-count): Deleted.
2968 (.console-message-text): Deleted.
2969 (.console-message-text > span): Deleted.
2970 (.console-error-level): Deleted.
2971 (.console-error-level .section .header .title): Deleted.
2972 (.console-debug-level .console-message-text): Deleted.
2973 (.console-debug-level::before): Deleted.
2974 (.console-error-level::before): Deleted.
2975 (.console-warning-level): Deleted.
2976 (.console-warning-level .console-message-text): Deleted.
2977 (.console-warning-level::before): Deleted.
2978 (.console-user-command .console-message): Deleted.
2979 (.console-user-command::before): Deleted.
2980 (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message): Deleted.
2981 (:matches(.console-warning-level, .console-error-level, .console-log-level)::before): Deleted.
2982 (.console-user-command > .console-message-text): Deleted.
2983 (.console-saved-variable): Deleted.
2984 (.console-message-url): Deleted.
2985 (.console-group-messages .section): Deleted.
2986 (.console-group-messages .section .header): Deleted.
2987 (.console-group-messages .section .header::before): Deleted.
2988 (.console-group-messages .section .header .title): Deleted.
2989 (.console-group-messages .section .properties li .info): Deleted.
2990 (.console-group-messages .outline-disclosure): Deleted.
2991 (.console-group-messages .outline-disclosure > ol): Deleted.
2992 (.console-group-messages .outline-disclosure li .selection): Deleted.
2993 (.console-group-messages .add-attribute): Deleted.
2994 (.error-message): Deleted.
2995 (.auto-complete-text, .editing .auto-complete-text): Deleted.
2996 (.outline-disclosure li.hovered:not(.selected) .selection): Deleted.
2997 (.outline-disclosure li.highlighted .highlight): Deleted.
2998 (.outline-disclosure li.selected.highlighted .highlight): Deleted.
2999 (.outline-disclosure li .selection): Deleted.
3000 (.outline-disclosure li.selected .selection): Deleted.
3001 (.outline-disclosure li.elements-drag-over .selection): Deleted.
3002 (.outline-disclosure ol:focus li.selected .selection): Deleted.
3003 (.outline-disclosure ol.search-match-not-found li.selected .selection): Deleted.
3004 (.outline-disclosure > ol): Deleted.
3005 (.outline-disclosure, .outline-disclosure ol): Deleted.
3006 (.outline-disclosure li): Deleted.
3007 (.outline-disclosure .expanded li): Deleted.
3008 (.outline-disclosure > li.parent): Deleted.
3009 (.outline-disclosure li .webkit-html-tag.close): Deleted.
3010 (.outline-disclosure > li.parent::before): Deleted.
3011 (.outline-disclosure li.parent.expanded::before): Deleted.
3012 (.outline-disclosure ol.children): Deleted.
3013 (.outline-disclosure ol.children.expanded): Deleted.
3014 (.webkit-html-fragment.shadow): Deleted.
3015 Delete now unused styles and move other styles to more appropriate places.
3017 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
3019 Web Inspector: Uncaught exception using console.table with filter argument
3020 https://bugs.webkit.org/show_bug.cgi?id=143579
3022 Reviewed by Timothy Hatcher.
3024 * UserInterface/Views/ConsoleMessageView.js:
3025 (WebInspector.ConsoleMessageView.prototype._userProvidedColumnNames):
3026 Reordering in the refactoring would have already converted this argument
3027 to a RemoteObject. Assert that here instead of trying to convert.
3029 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
3031 Web Inspector: ObjectTree Property Path tooltip has a few issues
3032 https://bugs.webkit.org/show_bug.cgi?id=143587
3034 Reviewed by Timothy Hatcher.
3036 * UserInterface/Models/PropertyPath.js:
3037 (WebInspector.PropertyPath.prototype.appendSymbolProperty):
3038 (WebInspector.PropertyPath.prototype.appendPropertyDescriptor):
3039 Handle Symbol properties. They are treated as an impossible path
3040 because we cannot guarentee a reference to the Symbol right now.
3042 * UserInterface/Views/ConsoleMessageView.js:
3043 (WebInspector.ConsoleMessageView.prototype._rootPropertyPathForObject):
3044 The savedResultIndex is on message.
3046 * UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
3047 (WebInspector.ObjectTreeMapEntryTreeElement):
3048 (WebInspector.ObjectTreeMapKeyTreeElement):
3049 (WebInspector.ObjectTreeMapValueTreeElement):
3050 In order for "key" to be available setup the mainTitle after
3051 the call to the base's constructor.
3053 2015-04-08 Joseph Pecoraro <pecoraro@apple.com>
3055 Web Inspector: Simplify Legacy Tips support
3056 https://bugs.webkit.org/show_bug.cgi?id=143551
3058 Reviewed by Timothy Hatcher.
3060 * UserInterface/Models/ConsoleMessage.js:
3061 * UserInterface/Protocol/ConsoleObserver.js:
3062 (WebInspector.ConsoleObserver.prototype.messageAdded):
3063 * UserInterface/Views/ConsoleMessageView.js:
3064 (WebInspector.ConsoleMessageView):
3065 (WebInspector.ConsoleMessageView.prototype._levelString):
3066 * UserInterface/Views/LogContentView.js:
3067 (WebInspector.LogContentView.prototype._filterMessageElements):
3069 2015-04-08 Joseph Pecoraro <pecoraro@apple.com>
3071 Unreviewed Test Fix after r182579. Add missing include.
3073 * UserInterface/Test.html:
3074 Missing file was causing inspector/page/main-frame-resource.html to fail.
3076 2015-04-08 Joseph Pecoraro <pecoraro@apple.com>
3078 Web Inspector: Split ConsoleMessageImpl into the View and the Model
3079 https://bugs.webkit.org/show_bug.cgi?id=142599
3081 Reviewed by Timothy Hatcher.
3083 * UserInterface/Models/ConsoleMessage.js: Added.
3084 (WebInspector.ConsoleMessage):
3085 (WebInspector.ConsoleMessage.prototype.get source):
3086 (WebInspector.ConsoleMessage.prototype.get level):
3087 (WebInspector.ConsoleMessage.prototype.get messageText):
3088 (WebInspector.ConsoleMessage.prototype.get type):
3089 (WebInspector.ConsoleMessage.prototype.get url):
3090 (WebInspector.ConsoleMessage.prototype.get line):
3091 (WebInspector.ConsoleMessage.prototype.get column):
3092 (WebInspector.ConsoleMessage.prototype.get repeatCount):
3093 (WebInspector.ConsoleMessage.prototype.get parameters):
3094 (WebInspector.ConsoleMessage.prototype.get stackTrace):
3095 (WebInspector.ConsoleMessage.prototype.get request):
3096 New readonly model object for console messages.
3098 * UserInterface/Main.html:
3099 * UserInterface/Test.html:
3100 * UserInterface/Base/Test.js:
3101 (WebInspector.loaded):
3102 Load the new files in the main / test page.
3104 * UserInterface/Views/LegacyConsoleMessage.js: Removed.
3105 * UserInterface/Views/LegacyConsoleMessageImpl.js: Removed.
3106 Remove Legacy versions.
3108 * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
3109 * UserInterface/Controllers/JavaScriptLogViewController.js:
3110 (WebInspector.JavaScriptLogViewController):
3111 (WebInspector.JavaScriptLogViewController.prototype.startNewSession):
3112 (WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
3113 (WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
3114 (WebInspector.JavaScriptLogViewController.prototype.appendConsoleMessage):
3115 (WebInspector.JavaScriptLogViewController.prototype.updatePreviousMessageRepeatCount):
3116 (WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted.printResult):
3117 (WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
3118 (WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):
3119 (WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessage): Deleted.
3120 Update LogViewController to create ConsoleMessageViews from ConsoleMessages when applicable.
3121 Also clarify when we have a view versus model object.
3123 * UserInterface/Protocol/ConsoleObserver.js:
3124 (WebInspector.ConsoleObserver.prototype.messageAdded):
3125 * UserInterface/Controllers/LogManager.js:
3126 (WebInspector.LogManager.prototype.messageWasAdded):
3127 (WebInspector.LogManager.prototype.messagesCleared):
3128 (WebInspector.LogManager.prototype._mainResourceDidChange):
3129 Create model objects and issue events for the model objects.
3131 * UserInterface/Models/DefaultDashboard.js:
3132 (WebInspector.DefaultDashboard.prototype._consoleMessageAdded):
3133 (WebInspector.DefaultDashboard.prototype._incrementConsoleMessageType):
3134 Update now that the event gives us a model object.
3136 * UserInterface/Views/ConsoleMessageView.js: Added.
3137 (WebInspector.ConsoleMessageView):
3138 (WebInspector.ConsoleMessageView.prototype.get element):
3139 (WebInspector.ConsoleMessageView.prototype.get message):
3140 (WebInspector.ConsoleMessageView.prototype.get repeatCount):
3141 (WebInspector.ConsoleMessageView.prototype.set repeatCount):
3142 (WebInspector.ConsoleMessageView.prototype.toClipboardString):
3143 (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
3144 (WebInspector.ConsoleMessageView.prototype._appendSavedResultIndex):
3145 (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
3146 (WebInspector.ConsoleMessageView.prototype._appendParameters):
3147 (WebInspector.ConsoleMessageView.prototype._appendStackTrace):
3148 (WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
3149 (WebInspector.ConsoleMessageView.prototype._formatParameter):
3150 (WebInspector.ConsoleMessageView.prototype._formatParameterAsValue):
3151 (WebInspector.ConsoleMessageView.prototype._formatParameterAsString):
3152 (WebInspector.ConsoleMessageView.prototype._formatParameterAsNode):
3153 (WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
3154 (WebInspector.ConsoleMessageView.prototype._formatParameterAsArray):
3155 (WebInspector.ConsoleMessageView.prototype._rootPropertyPathForObject):
3156 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.parameterFormatter):
3157 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.stringFormatter):
3158 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.floatFormatter):
3159 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.integerFormatter):
3160 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.styleFormatter):
3161 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.isWhitelistedProperty):
3162 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
3163 (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
3164 (WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
3165 (WebInspector.ConsoleMessageView.prototype._shouldHideURL):
3166 (WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame):
3167 (WebInspector.ConsoleMessageView.prototype._linkifyLocation):
3168 (WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
3169 (WebInspector.ConsoleMessageView.prototype._userProvidedColumnNames):
3170 (WebInspector.ConsoleMessageView.prototype._formatParameterAsTable):
3171 (WebInspector.ConsoleMessageView.prototype._levelString):
3172 (WebInspector.ConsoleMessageView.prototype._enforcesClipboardPrefixString):
3173 (WebInspector.ConsoleMessageView.prototype._clipboardPrefixString):
3174 New View class for a ConsoleMessage. This is a near direct port of the old code
3175 to a view class that has a root element.
3177 * UserInterface/Models/ConsoleCommandResultMessage.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleCommandResult.js.
3178 (WebInspector.ConsoleCommandResultMessage):
3179 (WebInspector.ConsoleCommandResultMessage.clearMaximumSavedResultIndex):
3180 (WebInspector.ConsoleCommandResultMessage.prototype.get savedResultIndex):
3181 Rename, as this is a ConsoleMessage subclass with a specific type for console evaluation results.
3183 * UserInterface/Views/ConsoleCommandView.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleCommand.js.
3184 (WebInspector.ConsoleCommandView):
3185 (WebInspector.ConsoleCommandView.prototype.get element):
3186 (WebInspector.ConsoleCommandView.prototype.get commandText):
3187 (WebInspector.ConsoleCommandView.prototype.get message):
3188 (WebInspector.ConsoleCommandView.prototype.toClipboardString):
3189 * UserInterface/Views/ConsoleGroup.js:
3190 (WebInspector.ConsoleGroup):
3191 (WebInspector.ConsoleGroup.prototype.get parentGroup):
3192 (WebInspector.ConsoleGroup.prototype.render):
3193 (WebInspector.ConsoleGroup.prototype.addMessageView):
3194 (WebInspector.ConsoleGroup.prototype.append):
3195 (WebInspector.ConsoleGroup.prototype._titleMouseDown):
3196 (WebInspector.ConsoleGroup.prototype.addMessage): Deleted.
3197 (WebInspector.ConsoleGroup.prototype._titleClicked): Deleted.
3198 * UserInterface/Views/ConsoleSession.js:
3199 (WebInspector.ConsoleSession):
3200 (WebInspector.ConsoleSession.prototype.addMessageView):
3201 (WebInspector.ConsoleSession.prototype.append):
3202 (WebInspector.ConsoleSession.prototype.addMessage): Deleted.
3203 (WebInspector.ConsoleSession.prototype.hasMessages): Deleted.
3204 Convert to classes, and clarify these deal with View objects.
3206 * UserInterface/Views/LogContentView.css:
3207 (.console-message .repeat-count):
3208 (.console-message .bubble): Deleted.
3209 Better class name for the repeat count element.
3211 * UserInterface/Views/LogContentView.js:
3212 (WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
3213 (WebInspector.LogContentView.prototype._formatMessagesAsData):
3214 (WebInspector.LogContentView.prototype._messageAdded):
3215 (WebInspector.LogContentView.prototype._updateMessagesSelection):
3216 (WebInspector.LogContentView.prototype._selectAllMessages):
3217 (WebInspector.LogContentView.prototype._allMessageElements):
3218 (WebInspector.LogContentView.prototype._unfilteredMessageElements):
3219 (WebInspector.LogContentView.prototype._visibleMessageElements):
3220 (WebInspector.LogContentView.prototype._scopeBarSelectionDidChange):
3221 (WebInspector.LogContentView.prototype._filterMessageElements):
3222 (WebInspector.LogContentView.prototype._upArrowWasPressed):
3223 (WebInspector.LogContentView.prototype._downArrowWasPressed):
3224 (WebInspector.LogContentView.prototype._previousMessage):
3225 (WebInspector.LogContentView.prototype._nextMessage):
3226 (WebInspector.LogContentView.prototype._performSearch):
3227 (WebInspector.LogContentView.prototype._highlightRanges):
3228 (WebInspector.LogContentView.prototype._reappendProvisionalMessages):
3229 (WebInspector.LogContentView.prototype.didAppendConsoleMessage): Deleted.
3230 (WebInspector.LogContentView.prototype._allMessages): Deleted.
3231 (WebInspector.LogContentView.prototype._unfilteredMessages): Deleted.
3232 (WebInspector.LogContentView.prototype._visibleMessages): Deleted.
3233 (WebInspector.LogContentView.prototype._filterMessages): Deleted.
3234 Rename lots of things to make it clear when we are dealing with
3235 elements, model objects, or view objects. This class is still heavily
3236 dealing with elements, and needs to be cleaned up later.
3238 2015-04-08 Joseph Pecoraro <pecoraro@apple.com>
3240 Fix uncaught exception seen in Inspector.
3242 Reviewed by Timothy Hatcher.
3244 * UserInterface/Views/TreeOutline.js:
3245 (WebInspector.TreeOutline.prototype.removeChild):
3246 Add a null check. Everywhere else null checks this member variable
3247 which may not exist yet, this case was missing the check.
3249 2015-04-08 Tobias Reiss <tobi+webkit@basecode.de>
3251 Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar
3252 https://bugs.webkit.org/show_bug.cgi?id=143539
3254 Reviewed by Timothy Hatcher.
3256 Fix a regression where due to an ESLint error the whole line instead of just
3257 the variable declaration was removed.
3259 * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
3260 (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update):
3261 (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
3263 2015-04-07 Joseph Pecoraro <pecoraro@apple.com>
3265 Web Inspector: ES6: Show Symbol properties on Objects
3266 https://bugs.webkit.org/show_bug.cgi?id=141279
3268 Reviewed by Timothy Hatcher.
3270 * Localizations/en.lproj/localizedStrings.js:
3271 * UserInterface/Models/PropertyDescriptor.js:
3272 (WebInspector.PropertyDescriptor.get symbol):
3274 * UserInterface/Protocol/RemoteObject.js:
3275 (WebInspector.RemoteObject.wrappedCallback):
3276 Update new PropertyDescriptor call site.
3278 * UserInterface/Views/ObjectTreeBaseTreeElement.js: