Web Inspector: Tabbing over CSS properties prepended by * doesn't move the highlighte...
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-10-22  Devin Rousso  <dcrousso+webkit@gmail.com>
2
3         Web Inspector: Tabbing over CSS properties prepended by * doesn't move the highlighted range
4         https://bugs.webkit.org/show_bug.cgi?id=150294
5
6         Reviewed by Timothy Hatcher.
7
8         Moving the selected text when tabbing and shift-tabbing now relies upon
9         the last index of ";" if it exists instead of whether the line ends with it.
10
11         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
12         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey):
13         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey):
14
15 2015-10-21  Joseph Pecoraro  <pecoraro@apple.com>
16
17         Web Inspector: srcset attributes should have hyperlinks to the resources
18         https://bugs.webkit.org/show_bug.cgi?id=150409
19
20         Reviewed by Timothy Hatcher.
21
22         The "srcset" attribute parsing is a simplification of:
23         https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset
24
25         The "srcset" attribute value is expected to be in comma
26         separated groups. Within each group we always expect a link,
27         and an optional descriptor. We want to linkify the link.
28
29         * UserInterface/Views/CodeMirrorAdditions.js:
30         (tokenizeSrcSetString):
31         (extendedXMLToken):
32         When parsing srcset attribute, parse links as link tokens
33         so that they are linkified in resource content views.
34
35         * UserInterface/Views/DOMTreeElement.js:
36         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
37         When creating the DOMTree DOM for srcset attributes,
38         create link elements for the link values of attribute value.
39
40 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
41
42         Web Inspector: Autocompletion previews in the CSS sidebar do not apply
43         https://bugs.webkit.org/show_bug.cgi?id=147720
44
45         Reviewed by Timothy Hatcher.
46
47         When autocompletion hints are added to styles or the console, the history
48         object used by CodeMirror was edited to remove the last entry. Instead of
49         using this method (which caused glitchy behaviour when undo-ing), call
50         CodeMirror.undo() and adjust accordingly. In addition, a marker was being
51         used as the completion hint instead of applying text, whereas these
52         changes use actual text, ensuring that completions are previewed in the page.
53
54         * UserInterface/Controllers/CodeMirrorCompletionController.js:
55         (WebInspector.CodeMirrorCompletionController):
56         (WebInspector.CodeMirrorCompletionController.prototype.close):
57         (WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
58         (WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
59         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
60         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
61         (WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
62         (WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
63         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.
64
65 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
66
67         Web Inspector: Add forgotten WebInspector.UIString from r190521
68         https://bugs.webkit.org/show_bug.cgi?id=150425
69
70         Reviewed by Timothy Hatcher.
71
72         * Localizations/en.lproj/localizedStrings.js:
73         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
74         (UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)
75
76 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
77
78         Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
79         https://bugs.webkit.org/show_bug.cgi?id=150424
80
81         Reviewed by Timothy Hatcher.
82
83         Adds "!!" in front of force parameters in classList.toggle calls that
84         could possibly be undefined (thereby breaking the UI).
85
86         * UserInterface/Views/ScopeBarItem.js:
87         (WebInspector.ScopeBarItem):
88         * UserInterface/Views/VisualStyleDetailsPanel.js:
89         (WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
90         * UserInterface/Views/VisualStylePropertyEditor.js:
91         (WebInspector.VisualStylePropertyEditor):
92
93 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
94
95         Web Inspector: Option-Up doesn't increment certain attribute values
96         https://bugs.webkit.org/show_bug.cgi?id=149257
97
98         Reviewed by Brian Burg.
99
100         If the user tries to modify a numerical attribute in HTML and the cursor
101         was at the beginning of the attribute value, the range of the selection
102         was within a sibling element instead of the text node containin the value.
103         This patch fixes this issue and ensures that the correct text is selected.
104
105         * UserInterface/Views/EditingSupport.js:
106         (WebInspector.startEditing.handleEditingResult):
107         Replaced var with let.
108
109 2015-10-21  Joseph Pecoraro  <pecoraro@apple.com>
110
111         Web Inspector: Use some CSS Variables in Web Inspector
112         https://bugs.webkit.org/show_bug.cgi?id=150405
113
114         Reviewed by Timothy Hatcher.
115
116         * UserInterface/Main.html:
117         Include the new variables stylesheet.
118
119         * UserInterface/Views/Variables.css: Added.
120         (:root):
121         Introduce new global variables.
122
123         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
124         (.css-style-text-editor > .CodeMirror .cm-link):
125         * UserInterface/Views/ConsoleMessageView.css:
126         (.console-message-preview-divider):
127         (.console-message-enclosed):
128         (.console-message .console-message-extra-parameters-container > li::before):
129         (.console-saved-variable):
130         * UserInterface/Views/DOMTreeOutline.css:
131         (.dom-tree-outline li.selected > span::after):
132         * UserInterface/Views/FormattedValue.css:
133         (:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
134         (.formatted-number):
135         (.formatted-boolean):
136         (.formatted-string):
137         (.formatted-regexp):
138         (.formatted-symbol):
139         * UserInterface/Views/ObjectPreviewView.css:
140         (.object-preview > .size):
141         * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
142         (.object-tree-array-index .index-name):
143         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
144         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
145         (.syntax-highlighted :matches(.css-number, .javascript-number)):
146         (.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
147         (.syntax-highlighted .javascript-regexp):
148         * UserInterface/Views/TypeTokenView.css:
149         (.type-token-symbol):
150         Make use of variables.
151
152 2015-10-21  Nikita Vasilyev  <nvasilyev@apple.com>
153
154         Web Inspector: Typo in a property name: style.inerhited
155         https://bugs.webkit.org/show_bug.cgi?id=150391
156
157         Reviewed by Csaba Osztrogonác.
158
159         * UserInterface/Views/RulesStyleDetailsPanel.js:
160         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
161
162 2015-10-20  Nikita Vasilyev  <nvasilyev@apple.com>
163
164         Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file
165         https://bugs.webkit.org/show_bug.cgi?id=150298
166
167         Reviewed by Timothy Hatcher.
168
169         * UserInterface/Views/CSSStyleDeclarationSection.js:
170         (WebInspector.CSSStyleDeclarationSection):
171         Beep when saving didn't work. Inline CSS and CSS in style attributes aren't curently supported.
172
173 2015-10-20  Joseph Pecoraro  <pecoraro@apple.com>
174
175         Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
176         https://bugs.webkit.org/show_bug.cgi?id=150096
177
178         Reviewed by Geoffrey Garen.
179
180         * UserInterface/Test/InspectorProtocol.js:
181         (InspectorProtocol._sendMessage):
182         (InspectorProtocol.dispatchMessageFromBackend):
183         This is only used for tests, so avoid console.log
184         and just dump directly to the system console.
185
186 2015-10-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
187
188         [Streams API] Add skeleton for initial WritableStream support
189         https://bugs.webkit.org/show_bug.cgi?id=149951
190
191         Reviewed by Darin Adler.
192
193         * UserInterface/Models/NativeFunctionParameters.js: Added support for WritableStream.
194
195 2015-10-19  James Craig  <jcraig@apple.com>
196
197         Web Inspector: AX: console list 'input'/'output' markers are not perceivable
198         https://bugs.webkit.org/show_bug.cgi?id=133045
199
200         Enabling WebKit Web Inspector console pseudo-element labels using the new CSS4 'alt' property.
201
202         Reviewed by Brian Burg.
203
204         * UserInterface/Views/LogContentView.css: 
205         (.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
206         (.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before):
207         (@media reader): Deleted.
208
209 2015-10-18  Joseph Pecoraro  <pecoraro@apple.com>
210
211         Web Inspector: Console Search should update when console is cleared
212         https://bugs.webkit.org/show_bug.cgi?id=150141
213
214         Reviewed by Brian Burg.
215
216         * UserInterface/Views/LogContentView.js:
217         (WebInspector.LogContentView.prototype._logCleared):
218         Reperform the search if there is a search query.
219
220         (WebInspector.LogContentView.prototype._filterMessageElements):
221         Reperform the current search.
222
223 2015-10-16  Joseph Pecoraro  <pecoraro@apple.com>
224
225         Web Inspector: Add "unset" to CSS value autocompletion
226         https://bugs.webkit.org/show_bug.cgi?id=127616
227
228         Reviewed by Brian Burg.
229
230         * UserInterface/Models/CSSCompletions.js:
231         * UserInterface/Models/CSSKeywordCompletions.js:
232         (WebInspector.CSSKeywordCompletions.forProperty):
233         Treat "unset" similiar to "initial". Also, no need for "initial"
234         in an individual property's list. We always include it.
235
236         * UserInterface/Views/VisualStyleDetailsPanel.js:
237         (WebInspector.VisualStyleDetailsPanel):
238         (WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
239         (WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
240         Add "Unset" alongside "Initial".
241
242 2015-10-14  Joseph Pecoraro  <pecoraro@apple.com>
243
244         Web Inspector: Include Garbage Collection Event in Timeline
245         https://bugs.webkit.org/show_bug.cgi?id=142510
246
247         Reviewed by Geoffrey Garen and Brian Burg.
248
249         * UserInterface/Base/Utilities.js:
250         (Array.prototype.partition):
251         Helper to partition an Array into two arrays.
252
253         * Localizations/en.lproj/localizedStrings.js:
254         * UserInterface/Base/Main.js:
255         (WebInspector.loaded):
256         * UserInterface/Test.html:
257         * UserInterface/Test/Test.js:
258         (WebInspector.loaded):
259         * UserInterface/Protocol/HeapObserver.js: Added.
260         (WebInspector.HeapObserver.prototype.garbageCollected):
261         (WebInspector.HeapObserver):
262         Create the new observer and manager.
263
264         * UserInterface/Models/GarbageCollection.js: Added.
265         (WebInspector.GarbageCollection):
266         (WebInspector.GarbageCollection.fromPayload):
267         (WebInspector.GarbageCollection.prototype.get type):
268         (WebInspector.GarbageCollection.prototype.get startTime):
269         (WebInspector.GarbageCollection.prototype.get endTime):
270         (WebInspector.GarbageCollection.prototype.get duration):
271         Model object for Heap.GarbageCollection.
272
273         * UserInterface/Controllers/HeapManager.js: Added.
274         (WebInspector.HeapManager):
275         (WebInspector.HeapManager.prototype.garbageCollected):
276         Dispatch events with the GC object.
277
278         * UserInterface/Controllers/TimelineManager.js:
279         (WebInspector.TimelineManager):
280         (WebInspector.TimelineManager.prototype._garbageCollected):
281         Include new GC Timeline Events as Script events.
282
283         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
284         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
285         For the Script overview, make two sets of bars, one for Scripts and one for GCs.
286         The GCs bar will be overlaid on top of the the Scripts bar. This is particularly
287         useful since a GC can happen during script execution.
288
289         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
290         * UserInterface/Main.html:
291         * UserInterface/Models/ScriptTimelineRecord.js:
292         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
293         (WebInspector.ScriptTimelineRecord.EventType.displayName):
294         * UserInterface/Views/ScriptTimelineDataGridNode.js:
295         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
296         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
297         (WebInspector.ScriptTimelineDataGridNode):
298         * UserInterface/Views/ScriptTimelineView.js:
299         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
300         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
301         (WebInspector.SourceCodeTimelineTreeElement):
302         * UserInterface/Views/TimelineIcons.css:
303         (.garbage-collection-profile-record .icon):
304         * UserInterface/Views/TimelineRecordBar.css:
305         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
306         UI for GC events.
307
308         * UserInterface/Views/TimelineRecordBar.js:
309         (WebInspector.TimelineRecordBar.createCombinedBars):
310         Simplify by storing start time into a variable.
311
312         * UserInterface/Views/TimelineRecordTreeElement.js:
313         (WebInspector.TimelineRecordTreeElement):
314         Icon for GC events.
315
316 2015-10-15  Commit Queue  <commit-queue@webkit.org>
317
318         Unreviewed, rolling out r191135.
319         https://bugs.webkit.org/show_bug.cgi?id=150197
320
321         This patch causes 50+ LayoutTest crashes related to the
322         inspector (Requested by ryanhaddad on #webkit).
323
324         Reverted changeset:
325
326         "Web Inspector: JavaScriptCore should parse sourceURL and
327         sourceMappingURL directives"
328         https://bugs.webkit.org/show_bug.cgi?id=150096
329         http://trac.webkit.org/changeset/191135
330
331 2015-10-15  Joseph Pecoraro  <pecoraro@apple.com>
332
333         Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
334         https://bugs.webkit.org/show_bug.cgi?id=150096
335
336         Reviewed by Geoffrey Garen.
337
338         * UserInterface/Test/InspectorProtocol.js:
339         (InspectorProtocol._sendMessage):
340         (InspectorProtocol.dispatchMessageFromBackend):
341         This is only used for tests, so avoid console.log
342         and just dump directly to the system console.
343
344 2015-10-13  João Oliveira  <hello@jxs.pt>
345
346         Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner
347         https://bugs.webkit.org/show_bug.cgi?id=149505
348
349         Reviewed by Joseph Pecoraro.
350
351         Console tab now uses findBanner, adapted LogContentView to use findBanner,
352         and findBanner to be more agnostic to both usecases, either as fixed, on console tab,
353         and hideable on other inspector tabs.
354
355         * UserInterface/Views/FindBanner.css:
356         (.find-banner.console-find-banner):
357         (.find-banner.console-findbanner input[type="search"]):
358         * UserInterface/Views/FindBanner.js:
359         (WebInspector.FindBanner):
360         (WebInspector.FindBanner.set targetElement.delayedWork):
361         (WebInspector.FindBanner.prototype.set targetElement):
362         (WebInspector.FindBanner.prototype.get showing):
363         (WebInspector.FindBanner.prototype.focus):
364         (WebInspector.FindBanner.prototype._clearAndBlur):
365         (WebInspector.FindBanner.prototype.show.delayedWork):
366         (WebInspector.FindBanner.prototype.show):
367         (WebInspector.FindBanner.prototype.hide):
368         (WebInspector.FindBanner.prototype.get element): Deleted.
369         (WebInspector.FindBanner.prototype._inputFieldSearch): Deleted.
370         * UserInterface/Views/LogContentView.js:
371         (WebInspector.LogContentView):
372         (WebInspector.LogContentView.prototype.get navigationItems):
373         (WebInspector.LogContentView.prototype.handleFindEvent):
374         (WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
375         (WebInspector.LogContentView.prototype.findBannerRevealNextResult):
376         (WebInspector.LogContentView.prototype._filterMessageElements):
377         (WebInspector.LogContentView.prototype.findBannerPerformSearch):
378         (WebInspector.LogContentView.prototype.findBannerSearchCleared):
379         (WebInspector.LogContentView.prototype.revealNextSearchResult):
380         (WebInspector.LogContentView.prototype.revealPreviousSearchResult):
381         (WebInspector.LogContentView.prototype._performSearch):
382         (WebInspector.LogContentView.prototype.searchBarDidActivate): Deleted.
383         (WebInspector.LogContentView.prototype._searchTextDidChange): Deleted.
384
385 2015-10-13  Nikita Vasilyev  <nvasilyev@apple.com>
386
387         REGRESSION(r189567): Web Inspector: Clipped filter icons when debugger sidebar is narrow
388         https://bugs.webkit.org/show_bug.cgi?id=150023
389
390         r189567 changed flexbox items' default min-width from 0 to auto.
391         Explicitly set it to 0 in CSS.
392
393         Reviewed by Brian Burg.
394
395         * UserInterface/Views/FilterBar.css:
396         (.filter-bar > input[type="search"]):
397
398 2015-10-13  Yusuke Suzuki  <utatane.tea@gmail.com>
399
400         Web Inspector: Don't shadow global Object constructor in WebInspector.Object class definition
401         https://bugs.webkit.org/show_bug.cgi?id=150093
402
403         Reviewed by Joseph Pecoraro.
404
405         Currently, class expression does not define any variables. So even in `class Object { }`,
406         we were able to touch the global Object constructor (like `Object.keys`).
407         However, that is a bug. After https://bugs.webkit.org/show_bug.cgi?id=150089 fixes that bug,
408         the global `Object` is shadowed by the user-defined `class Object` name.
409
410         To solve this issue, we changed the `class Object` to `class WebInspectorObject`.
411         And we expose this class as a `WebInspector.Object`.
412
413         * UserInterface/Base/Object.js:
414
415 2015-10-10  Nikita Vasilyev  <nvasilyev@apple.com>
416
417         Web Inspector: Improve error messages for internal Inspector code
418         https://bugs.webkit.org/show_bug.cgi?id=149995
419
420         Don't log "error.stack" since the error view already includes a nicely formatted stacktrace.
421
422         Reviewed by Timothy Hatcher.
423
424         * UserInterface/Protocol/InspectorBackend.js:
425         (InspectorBackendClass.prototype._dispatchResponseToCallback):
426         (InspectorBackendClass.prototype._dispatchEvent):
427
428 2015-10-08  Nikita Vasilyev  <nvasilyev@apple.com>
429
430         Web Inspector: Stack trace view doesn't properly display lines without function names
431         https://bugs.webkit.org/show_bug.cgi?id=149922
432
433         Reviewed by Timothy Hatcher.
434
435         * UserInterface/Models/StackTrace.js:
436         (WebInspector.StackTrace._parseStackTrace):
437         (WebInspector.StackTrace._parseLocation): Added.
438
439 2015-10-08  Nikita Vasilyev  <nvasilyev@apple.com>
440
441         Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
442         https://bugs.webkit.org/show_bug.cgi?id=149917
443
444         Reviewed by Timothy Hatcher.
445
446         * UserInterface/Views/ErrorObjectView.css:
447         (.error-object > .formatted-error::before):
448         (.error-object.expanded > .formatted-error::before):
449         (.error-object::before): Deleted.
450         (.error-object.expanded::before): Deleted.
451
452 2015-10-06  Nikita Vasilyev  <nvasilyev@apple.com>
453
454         Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
455         https://bugs.webkit.org/show_bug.cgi?id=149405
456
457         lineNumber should be a number type but it was a string.
458
459         Reviewed by Timothy Hatcher.
460
461         * UserInterface/Base/Main.js:
462         (WebInspector.openURL):
463         (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
464         Keep lineNumber undefined when it isn't present in the string.
465         WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
466         WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
467         when it wasn't found in the parsed string.
468
469 2015-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
470
471         Web Inspector: Fix spacing of FindBanner prev/next buttons
472         https://bugs.webkit.org/show_bug.cgi?id=149717
473
474         Reviewed by Darin Adler.
475
476         The sizing and spacing of the previous and next buttons in the FindBanner
477         is slightly off and should be readjusted to ensure that both buttons are
478         the same size and have the same spacing.
479
480         * UserInterface/Views/FindBanner.css:
481         (.find-banner > button.segmented.right > .glyph):
482         (.find-banner > button.segmented):
483         (.find-banner > button.segmented > .glyph):
484         (.find-banner > button.segmented.left): Deleted.
485         (.find-banner > button.segmented.left > .glyph): Deleted.
486         (.find-banner > button.segmented.right): Deleted.
487
488 2015-10-06  Joseph Pecoraro  <pecoraro@apple.com>
489
490         Web Inspector: Simplify TimelineRecordBar a bit
491         https://bugs.webkit.org/show_bug.cgi?id=149733
492
493         Reviewed by Timothy Hatcher.
494
495         * UserInterface/Views/TimelineRecordBar.js:
496         (WebInspector.TimelineRecordBar.prototype.set records):
497
498 2015-10-05  Nikita Vasilyev  <nvasilyev@apple.com>
499
500         Web Inspector: Error displayed as an object when passed as a second argument to console.log
501         https://bugs.webkit.org/show_bug.cgi?id=149799
502
503         Reviewed by Joseph Pecoraro.
504
505         * UserInterface/Views/ConsoleMessageView.js:
506         (WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
507         Don't format errors as objects.
508
509         (WebInspector.ConsoleMessageView.prototype._formatParameter):
510         (WebInspector.ConsoleMessageView.prototype._formatParameterAsValue):
511         (WebInspector.ConsoleMessageView.prototype._formatParameterAsString):
512         (WebInspector.ConsoleMessageView.prototype._formatParameterAsNode):
513         (WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
514         (WebInspector.ConsoleMessageView.prototype._formatParameterAsError):
515         (WebInspector.ConsoleMessageView.prototype._formatParameterAsArray):
516         Replace an unnecessary span element with a document fragment.
517
518         * UserInterface/Views/ErrorObjectView.css:
519         (.error-object):
520         Display an error object on the same line as a list bullet.
521
522 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
523
524         Unprefix -webkit-font-feature-settings
525         https://bugs.webkit.org/show_bug.cgi?id=149722
526
527         Reviewed by Sam Weinig.
528
529         * UserInterface/Models/CSSKeywordCompletions.js:
530
531 2015-10-04  Nikita Vasilyev  <nvasilyev@apple.com>
532
533         Web Inspector: Wrong column numbers in error object views
534         https://bugs.webkit.org/show_bug.cgi?id=149795
535
536         Convert columnNumber and lineNumber properties from strings to numbers
537         to prevent accidental string concatenations.
538
539         Reviewed by Timothy Hatcher.
540
541         * UserInterface/Models/StackTrace.js:
542         (WebInspector.StackTrace._parseStackTrace):
543
544 2015-10-02  Matt Baker  <mattbaker@apple.com>
545
546         Web Inspector: Add breakpoint option to ignore n times before stopping
547         https://bugs.webkit.org/show_bug.cgi?id=147664
548
549         Reviewed by Timothy Hatcher.
550
551         * Localizations/en.lproj/localizedStrings.js:
552         New strings for breakpoint popover labels.
553
554         * UserInterface/Controllers/BreakpointPopoverController.js:
555         (WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
556         Add ignoreCount UI to popover, if backend support exists. UI based on same
557         feature in Xcode's breakpoint editing dialog.
558         (WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
559         User input sanity checks on numeric input.
560
561         * UserInterface/Controllers/DebuggerManager.js:
562         Listen for changes to breakpoint ignoreCount property.
563
564         * UserInterface/Models/Breakpoint.js:
565         (WebInspector.Breakpoint):
566         (WebInspector.Breakpoint.prototype.get ignoreCount):
567         (WebInspector.Breakpoint.prototype.set ignoreCount):
568         New property for ignoreCount.
569         (WebInspector.Breakpoint.prototype.get options):
570         Added ignoreCount to options object.
571         (WebInspector.Breakpoint.prototype.get info):
572         Added ignoreCount to info object.
573
574         * UserInterface/Views/BreakpointPopoverController.css:
575         (#edit-breakpoint-popover-ignore):
576         New styles for breakpoint popover.
577
578 2015-10-02  Matt Baker  <mattbaker@apple.com>
579
580         Web Inspector: Cleanup DebuggerManager, reduce `delete` and use Maps instead of objects
581         https://bugs.webkit.org/show_bug.cgi?id=149760
582
583         Reviewed by Joseph Pecoraro.
584
585         Replaced objects used as hashmaps with Map.
586
587         * UserInterface/Controllers/DebuggerManager.js:
588         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
589         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
590         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
591         (WebInspector.DebuggerManager.prototype.scriptsForURL):
592         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
593         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
594         (WebInspector.DebuggerManager.prototype.breakpointResolved):
595         (WebInspector.DebuggerManager.prototype.reset):
596         (WebInspector.DebuggerManager.prototype.scriptDidParse):
597         (WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload):
598         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
599         (WebInspector.DebuggerManager.prototype._setBreakpoint):
600         (WebInspector.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
601         (WebInspector.DebuggerManager.prototype._removeBreakpoint):
602
603 2015-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
604
605         Web Inspector: Copying inline style text puts "undefined" in the pasteboard
606         https://bugs.webkit.org/show_bug.cgi?id=149155
607
608         Reviewed by Brian Burg.
609
610         CSSStyleDeclarations for inline styles do not have a owner CSSRule, which means
611         that they do not have a selector or media list. CSS strings must have a selector
612         and, for inline styles without an owner rule and selector, this was a problem.
613
614         * UserInterface/Models/CSSStyleDeclaration.js:
615         (WebInspector.CSSStyleDeclaration.prototype.get mediaList):
616         (WebInspector.CSSStyleDeclaration.prototype.get selectorText):
617         (WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
618         Added getters for the list of media queries and selector text with fallbacks
619         for CSSStyleDeclarations that do not have an owner CSSRule (inline styles).
620
621         * UserInterface/Test.html:
622         Added CSSMedia include for new inspector/css/generate-css-rule-string.html test.
623
624         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
625         (WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
626         Removed parameter that no longer exists.
627
628 2015-10-02  Joseph Pecoraro  <pecoraro@apple.com>
629
630         Unreviewed, rolling out r190520, some tests assert / crash.
631
632         * Localizations/en.lproj/localizedStrings.js:
633         * UserInterface/Base/Main.js:
634         (WebInspector.loaded): Deleted.
635         * UserInterface/Base/Utilities.js:
636         (value): Deleted.
637         * UserInterface/Controllers/HeapManager.js: Removed.
638         * UserInterface/Controllers/TimelineManager.js:
639         (WebInspector.TimelineManager): Deleted.
640         (WebInspector.TimelineManager.prototype._garbageCollected): Deleted.
641         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
642         * UserInterface/Main.html:
643         * UserInterface/Models/GarbageCollection.js: Removed.
644         * UserInterface/Models/ScriptTimelineRecord.js:
645         (WebInspector.ScriptTimelineRecord.EventType.displayName):
646         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.
647         * UserInterface/Protocol/HeapObserver.js: Removed.
648         * UserInterface/Test.html:
649         * UserInterface/Test/Test.js:
650         (WebInspector.loaded): Deleted.
651         * UserInterface/Views/ScriptTimelineDataGridNode.js:
652         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
653         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
654         (WebInspector.ScriptTimelineDataGridNode): Deleted.
655         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
656         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
657         * UserInterface/Views/ScriptTimelineView.js:
658         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
659         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
660         (WebInspector.SourceCodeTimelineTreeElement):
661         * UserInterface/Views/TimelineIcons.css:
662         (.garbage-collection-profile-record .icon): Deleted.
663         * UserInterface/Views/TimelineRecordBar.css:
664         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.
665         * UserInterface/Views/TimelineRecordBar.js:
666         (WebInspector.TimelineRecordBar.createCombinedBars):
667         * UserInterface/Views/TimelineRecordTreeElement.js:
668         (WebInspector.TimelineRecordTreeElement):
669
670 2015-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
671
672         Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
673         https://bugs.webkit.org/show_bug.cgi?id=149521
674
675         Reviewed by Timothy Hatcher.
676
677         * UserInterface/Models/DOMNodeStyles.js:
678         (WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
679         Now tries to search for a non-canonical property before falling back to
680         the canonical version.
681
682         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
683         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
684         If the user option-clicks the goto arrow, it shows the source for the
685         property instead.
686
687         * UserInterface/Views/ComputedStyleDetailsPanel.js:
688         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
689         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
690         Attempts to show the source of the given property. Will fallback to
691         highlighting the property in the rules panel.
692
693 2015-10-02  Joseph Pecoraro  <pecoraro@apple.com>
694
695         Web Inspector: Include Garbage Collection Event in Timeline
696         https://bugs.webkit.org/show_bug.cgi?id=142510
697
698         Reviewed by Geoffrey Garen.
699
700         * UserInterface/Base/Utilities.js:
701         (Array.prototype.parition):
702         Helper to partition an Array into two arrays.
703
704         * UserInterface/Main.html:
705         * Localizations/en.lproj/localizedStrings.js:
706         * UserInterface/Base/Main.js:
707         (WebInspector.loaded):
708         * UserInterface/Test.html:
709         * UserInterface/Test/Test.js:
710         (WebInspector.loaded):
711         * UserInterface/Protocol/HeapObserver.js:
712         (WebInspector.HeapObserver.prototype.garbageCollected):
713         (WebInspector.HeapObserver):
714         Create the new observer and manager.
715
716         * UserInterface/Models/GarbageCollection.js:
717         (WebInspector.GarbageCollection):
718         (WebInspector.GarbageCollection.fromPayload):
719         (WebInspector.GarbageCollection.prototype.get type):
720         (WebInspector.GarbageCollection.prototype.get startTime):
721         (WebInspector.GarbageCollection.prototype.get endTime):
722         (WebInspector.GarbageCollection.prototype.get duration):
723         Model object for Heap.GarbageCollection.
724
725         * UserInterface/Controllers/HeapManager.js:
726         (WebInspector.HeapManager):
727         (WebInspector.HeapManager.prototype.garbageCollected):
728         Dispatch events with.
729
730         * UserInterface/Controllers/TimelineManager.js:
731         (WebInspector.TimelineManager):
732         (WebInspector.TimelineManager.prototype._garbageCollected):
733         Include new GC Timeline Events as Script events.
734
735         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
736         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
737         For the Script overview, make two sets of bars, one for Scripts and one for GCs.
738         The GCs bar will be on top of the the Scripts bar. This is particularly useful
739         since a GC can happen during script execution.
740
741         * UserInterface/Views/ScriptTimelineDataGridNode.js:
742         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
743         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
744         (WebInspector.ScriptTimelineDataGridNode):
745         Give a NaN call count to top level Script DataGridNodes.
746         In the UI, display the empty placeholder for NaN call counts.
747
748         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
749         * UserInterface/Models/ScriptTimelineRecord.js:
750         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
751         (WebInspector.ScriptTimelineRecord.EventType.displayName):
752         * UserInterface/Views/ScriptTimelineView.js:
753         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
754         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
755         (WebInspector.SourceCodeTimelineTreeElement):
756         * UserInterface/Views/TimelineIcons.css:
757         (.garbage-collection-profile-record .icon):
758         * UserInterface/Views/TimelineRecordBar.css:
759         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
760         UI for GC events.
761
762         * UserInterface/Views/TimelineRecordBar.js:
763         (WebInspector.TimelineRecordBar.createCombinedBars):
764         Simplify by storing start time into a variable.
765
766         * UserInterface/Views/TimelineRecordTreeElement.js:
767         (WebInspector.TimelineRecordTreeElement):
768         Icon for GC events.
769
770 2015-10-02  Nikita Vasilyev  <nvasilyev@apple.com>
771
772         Web Inspector: Fix indentation of console message parameters
773         https://bugs.webkit.org/show_bug.cgi?id=149740
774
775         Reviewed by Darin Adler.
776
777         * UserInterface/Views/ConsoleMessageView.css:
778         (.console-message .console-message-stack-trace-container > li):
779         (.console-message .console-message-extra-parameters-container > li::before):
780
781 2015-10-02  Andres Gomez  <agomez@igalia.com>
782
783         [GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
784         https://bugs.webkit.org/show_bug.cgi?id=149227
785
786         Reviewed by Carlos Garcia Campos.
787
788         * UserInterface/Images/gtk/NewTabPlus.svg: Updated.
789         * UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
790         * UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
791
792 2015-10-01  Joseph Pecoraro  <pecoraro@apple.com>
793
794         Web Inspector: Simplify filterableData processing
795         https://bugs.webkit.org/show_bug.cgi?id=149730
796
797         Reviewed by Timothy Hatcher.
798
799         * UserInterface/Views/BreakpointTreeElement.js:
800         (WebInspector.BreakpointTreeElement.prototype.get filterableData):
801         * UserInterface/Views/NavigationSidebarPanel.js:
802         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
803         * UserInterface/Views/ResourceTreeElement.js:
804         (WebInspector.ResourceTreeElement.prototype.get filterableData):
805         * UserInterface/Views/ScriptTimelineView.js:
806         (WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
807         * UserInterface/Views/SearchResultTreeElement.js:
808         (WebInspector.SearchResultTreeElement.prototype.get filterableData):
809         (WebInspector.SearchResultTreeElement):
810
811 2015-10-01  Joseph Pecoraro  <pecoraro@apple.com>
812
813         Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
814         https://bugs.webkit.org/show_bug.cgi?id=149726
815
816         Reviewed by Timothy Hatcher.
817
818         * UserInterface/Views/NavigationSidebarPanel.js:
819         (WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
820         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
821         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
822         We were populating during filtering if there were any custom filters.
823         However the TimelineSidebarPanel has custom filters (based on time and type)
824         but those don't need to trigger population. Delay population until it
825         would actually be needed (like a text search).
826
827         * UserInterface/Views/TimelineSidebarPanel.js:
828         (WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
829         Do not populate on filter via this custom filters.
830
831 2015-10-01  Matt Baker  <mattbaker@apple.com>
832
833         Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
834         https://bugs.webkit.org/show_bug.cgi?id=149725
835
836         Reviewed by Timothy Hatcher.
837
838         CSS Flexible Box Layout Module Level 1 introduces a new `auto` initial value for the min-{width|height}
839         of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
840         zero for the #main <div>.
841
842         * UserInterface/Views/Main.css:
843         (#main):
844
845 2015-10-01  Nikita Vasilyev  <nvasilyev@apple.com>
846
847         Web Inspector: Clip string previews
848         https://bugs.webkit.org/show_bug.cgi?id=149708
849
850         Only show first 140 characters in strings previews.
851
852         Reviewed by Joseph Pecoraro.
853
854         * UserInterface/Base/Utilities.js:
855         (String.prototype.truncate): Added.
856         A smart trancate function that doesn't split words.
857
858         * UserInterface/Views/ConsoleMessageView.js:
859         (WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):
860         * UserInterface/Views/FormattedValue.js:
861         (WebInspector.FormattedValue.createElementForTypesAndValue):
862
863 2015-09-30  João Oliveira  <hello@jxs.pt>
864
865         Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
866         https://bugs.webkit.org/show_bug.cgi?id=149590
867
868         Reviewed by Joseph Pecoraro.
869
870         Patch by João Oliveira and Brian Burg.
871
872         * UserInterface/Base/Main.js:
873         (WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.
874
875 2015-10-01  Andres Gomez  <agomez@igalia.com>
876
877         [GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
878         https://bugs.webkit.org/show_bug.cgi?id=147847
879
880         Reviewed by Carlos Garcia Campos.
881
882         * UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
883         * UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
884
885 2015-10-01  Andres Gomez  <agomez@igalia.com>
886
887         [GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
888         https://bugs.webkit.org/show_bug.cgi?id=147846
889
890         Reviewed by Carlos Garcia Campos.
891
892         * UserInterface/Images/gtk/AUTHORS: Updated.
893         * UserInterface/Images/gtk/ClearBoth.svg: Added.
894         * UserInterface/Images/gtk/ClearLeft.svg: Added.
895         * UserInterface/Images/gtk/ClearRight.svg: Added.
896         * UserInterface/Images/gtk/CubicBezier.svg: Updated.
897         * UserInterface/Images/gtk/FloatLeft.svg: Added.
898         * UserInterface/Images/gtk/FloatRight.svg: Added.
899         * UserInterface/Images/gtk/FontStyleItalic.svg: Added.
900         * UserInterface/Images/gtk/FontStyleNormal.svg: Added.
901         * UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
902         * UserInterface/Images/gtk/TextAlignCenter.svg: Added.
903         * UserInterface/Images/gtk/TextAlignJustify.svg: Added.
904         * UserInterface/Images/gtk/TextAlignLeft.svg: Added.
905         * UserInterface/Images/gtk/TextAlignRight.svg: Added.
906         * UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
907         * UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
908         * UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
909         * UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
910         * UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
911         * UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
912         * UserInterface/Images/gtk/VisualStyleNone.svg: Added.
913
914 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
915
916         Web Inspector: Reduce `delete` in Timeline related classes
917         https://bugs.webkit.org/show_bug.cgi?id=149686
918
919         Reviewed by Timothy Hatcher.
920
921         * UserInterface/Controllers/TimelineManager.js:
922         (WebInspector.TimelineManager.prototype.capturingStopped):
923         * UserInterface/Views/TimelineDataGrid.js:
924         (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
925         (WebInspector.TimelineDataGrid.prototype._sort):
926         (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
927         * UserInterface/Views/TimelineOverview.js:
928         (WebInspector.TimelineOverview.prototype.updateLayout):
929         (WebInspector.TimelineOverview.prototype._handleScrollEvent):
930         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
931         (WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
932         (WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
933
934         * UserInterface/Views/ProbeSetDataGrid.js:
935         (WebInspector.ProbeSetDataGrid):
936         (WebInspector.ProbeSetDataGrid.prototype._teardownData):
937         Remove an unused member variable as well.
938
939 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
940
941         Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
942         https://bugs.webkit.org/show_bug.cgi?id=149682
943
944         Reviewed by Timothy Hatcher.
945
946         Setting the status element of a GeneralTreeElement was triggering a
947         TreeOutline.onchange event. For TreeOutlines with lots of tree elements
948         (JavaScript & Events with profile nodes) this could result in thousands
949         of onchange events that causes lots of unnecessary work and blocks
950         future timers (like scroll synchronization) from firing.
951
952         This change eliminates TreeOutline change events for tree element
953         changes that are not interesting.
954
955         * UserInterface/Views/GeneralTreeElement.js:
956         (WebInspector.GeneralTreeElement.prototype.set status): Deleted.
957         * UserInterface/Views/TreeOutline.js:
958         (WebInspector.TreeElement.prototype.set tooltip): Deleted.
959
960 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
961
962         Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
963         https://bugs.webkit.org/show_bug.cgi?id=149680
964
965         Reviewed by Timothy Hatcher.
966
967         * UserInterface/Views/BreakpointTreeElement.js:
968         (WebInspector.BreakpointTreeElement):
969         (WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
970         * UserInterface/Views/DataGrid.js:
971         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
972         (WebInspector.DataGrid.prototype._editingCommitted):
973         (WebInspector.DataGrid.prototype._editingCancelled):
974         (WebInspector.DataGrid.prototype.removeColumn):
975         (WebInspector.DataGridNode.prototype.refreshIfNeeded):
976         (WebInspector.DataGridNode.prototype.refresh):
977         (WebInspector.DataGridNode.prototype.expand):
978         (WebInspector.DataGridNode.prototype.restorePosition):
979         (WebInspector.DataGridNode):
980         * UserInterface/Views/GeneralTreeElement.js:
981         (WebInspector.GeneralTreeElement.prototype.ondetach):
982         * UserInterface/Views/ResourceTimelineDataGridNode.js:
983         (WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
984         * UserInterface/Views/TreeOutline.js:
985         (WebInspector.TreeElement.prototype._fireDidChange):
986         (WebInspector.TreeElement.prototype.expand):
987
988 2015-09-30  Andres Gomez  <agomez@igalia.com>
989
990         [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
991         https://bugs.webkit.org/show_bug.cgi?id=147681
992
993         Reviewed by Joseph Pecoraro.
994
995         * UserInterface/Images/gtk/CubicBezier.svg: Added.
996
997 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
998
999         Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
1000         https://bugs.webkit.org/show_bug.cgi?id=149649
1001
1002         Reviewed by Darin Adler.
1003
1004         * UserInterface/Base/Utilities.js:
1005         (value):
1006         Since keySets in this instance are often used as hash maps with the
1007         `in` operator, create a blank object that won't have Object.prototype
1008         functions that would be seen by `in`.
1009
1010         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1011         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
1012         Sort __defineGetter__ and __lookupGetter__ and friends last, since they
1013         are rarely used properties.
1014
1015 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
1016
1017         Web Inspector: Missing completions for Symbol objects, console.error warning
1018         https://bugs.webkit.org/show_bug.cgi?id=149641
1019
1020         Reviewed by Darin Adler.
1021
1022         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1023         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
1024         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
1025         Include completions for symbol types.
1026
1027 2015-09-28  Joseph Pecoraro  <pecoraro@apple.com>
1028
1029         Web Inspector: Hitting ESC while editing element tag name leaves element in bad state
1030         https://bugs.webkit.org/show_bug.cgi?id=149506
1031
1032         Reviewed by Timothy Hatcher.
1033
1034         * UserInterface/Views/DOMTreeElement.js:
1035         (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
1036         (WebInspector.DOMTreeElement.prototype._startEditingTagName):
1037         When cancelling editing of a tag name, revert any changes we had
1038         been making to the closing tag name.
1039
1040 2015-09-28  João Oliveira  <hello@jxs.pt>
1041
1042         Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
1043         https://bugs.webkit.org/show_bug.cgi?id=149223
1044
1045         Reviewed by Timothy Hatcher.
1046
1047         When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
1048         if so text is selected, if the textbox is empty, textbox gains focus.
1049
1050         * UserInterface/Views/SearchBar.js:
1051         (WebInspector.SearchBar.prototype.focus):
1052
1053 2015-09-25  Joseph Pecoraro  <pecoraro@apple.com>
1054
1055         Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
1056         https://bugs.webkit.org/show_bug.cgi?id=148732
1057
1058         Reviewed by Darin Adler.
1059
1060         * UserInterface/Views/ResourceSidebarPanel.js:
1061         (WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
1062         Suppress selection of sibiling tree elements when removing extra folders.
1063
1064 2015-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1065
1066         Ran sort-Xcode-project-file.
1067
1068         * WebInspectorUI.xcodeproj/project.pbxproj:
1069
1070 2015-09-23  Saam barati  <sbarati@apple.com>
1071
1072         Fix broken inspector tests.
1073
1074         Reviewed by Joseph Pecoraro and Brian Burg.
1075
1076         We can't redeclare a "let" variable and "var" variable using the same
1077         identifier at the top-level of a function.
1078
1079         * UserInterface/Test/InspectorProtocol.js:
1080         (InspectorProtocol.sendCommand):
1081         (InspectorProtocol.addEventListener):
1082         (InspectorProtocol.dispatchMessageFromBackend):
1083
1084 2015-09-23  Saam barati  <sbarati@apple.com>
1085
1086         Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
1087         https://bugs.webkit.org/show_bug.cgi?id=149483
1088
1089         Reviewed by Joseph Pecoraro.
1090
1091         * UserInterface/Models/ScriptSyntaxTree.js:
1092         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1093         (WebInspector.ScriptSyntaxTree):
1094
1095 2015-09-23  Saam barati  <sbarati@apple.com>
1096
1097         Web Inspector: Type bubbles missing for computed methods and methods on object literals
1098         https://bugs.webkit.org/show_bug.cgi?id=148562
1099
1100         Reviewed by Joseph Pecoraro.
1101
1102         This patch makes sure that computed methods are working
1103         for both classes and object literals. Also, methods now
1104         work on object literals. This patch also cleans up the
1105         "isGetterOrSetter" and "getterOrSetterRange" fields.
1106         Basically, we used this as a way to ask the type profiler
1107         for the return types of a function. Now, we just have
1108         a field called "typeProfilingReturnDivot" that is set
1109         on all functions so we don't need to conditionally ask
1110         if it's a getter or setter.
1111
1112         * UserInterface/Controllers/TypeTokenAnnotator.js:
1113         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1114         * UserInterface/Models/ScriptSyntaxTree.js:
1115         (WebInspector.ScriptSyntaxTree.functionReturnDivot):
1116         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
1117         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1118         (WebInspector.ScriptSyntaxTree):
1119
1120 2015-09-22  Devin Rousso  <dcrousso+webkit@gmail.com>
1121
1122         Web Inspector: The right sidebar always opens up on breakpoint
1123         https://bugs.webkit.org/show_bug.cgi?id=149261
1124
1125         Reviewed by Timothy Hatcher.
1126
1127         Whenever the debugger was paused, the sidebar was being forced to open.
1128         This has been removed in favor of letting the user decide.
1129
1130         * UserInterface/Base/Main.js:
1131         (WebInspector._debuggerDidPause):
1132
1133 2015-09-22  Saam barati  <sbarati@apple.com>
1134
1135         Web Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
1136         https://bugs.webkit.org/show_bug.cgi?id=143171
1137
1138         Reviewed by Joseph Pecoraro.
1139
1140         Esprima and JSC both support arrow functions. We just
1141         need to support it in our AST and do the right things
1142         to include support in the type profiler bits.
1143
1144         * UserInterface/Controllers/TypeTokenAnnotator.js:
1145         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1146         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList.isLineTerminator):
1147         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
1148         * UserInterface/Models/ScriptSyntaxTree.js:
1149         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
1150         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
1151         (WebInspector.ScriptSyntaxTree.functionReturnDivot):
1152         (WebInspector.ScriptSyntaxTree.prototype._recurse):
1153         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1154         (WebInspector.ScriptSyntaxTree):
1155
1156 2015-09-22  Saam barati  <sbarati@apple.com>
1157
1158         Web Inspector: update Esprima to latest version
1159         https://bugs.webkit.org/show_bug.cgi?id=148960
1160
1161         Reviewed by Joseph Pecoraro.
1162
1163         Esprima version 2.6 further supports ES6. We're
1164         updating to it so we can support more ES6 features
1165         in our script syntax tree.
1166
1167         * UserInterface/External/Esprima/LICENSE:
1168         * UserInterface/External/Esprima/esprima.js:
1169         * UserInterface/Models/ScriptSyntaxTree.js:
1170         (WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
1171         (WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
1172         (WebInspector.ScriptSyntaxTree.prototype._recurse):
1173         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1174         (WebInspector.ScriptSyntaxTree):
1175
1176 2015-09-21  Matt Baker  <mattbaker@apple.com>
1177
1178         Web Inspector: requestAnimationFrame continues to be called after stopping the timeline recording
1179         https://bugs.webkit.org/show_bug.cgi?id=149390
1180
1181         Reviewed by Brian Burg.
1182
1183         * UserInterface/Views/TimelineRecordingContentView.js:
1184         (WebInspector.TimelineRecordingContentView.prototype._update):
1185         Stop calling requestAnimationFrame if this._updating is false and recording end time is NaN.
1186
1187 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1188
1189         Web Inspector: Simplify some functional callbacks
1190         https://bugs.webkit.org/show_bug.cgi?id=149333
1191
1192         Reviewed by Brian Burg.
1193
1194         * UserInterface/Controllers/LogManager.js:
1195         (WebInspector.LogManager.prototype.messageWasAdded):
1196         * UserInterface/Models/Color.js:
1197         (WebInspector.Color):
1198         * UserInterface/Models/Geometry.js:
1199         (WebInspector.CubicBezier.fromCoordinates):
1200         * UserInterface/Models/ObjectPreview.js:
1201         (WebInspector.ObjectPreview.fromPayload):
1202         * UserInterface/Models/TypeDescription.js:
1203         (WebInspector.TypeDescription.fromPayload):
1204         * UserInterface/Protocol/RemoteObject.js:
1205         (WebInspector.RemoteObject.prototype.getCollectionEntries):
1206         (WebInspector.RemoteObject.prototype.getCollectionEntries.): Deleted.
1207         * UserInterface/Views/TextEditor.js:
1208         (WebInspector.TextEditor.prototype.get markers):
1209         (WebInspector.TextEditor.prototype.markersAtPosition):
1210
1211 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1212
1213         Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
1214         https://bugs.webkit.org/show_bug.cgi?id=149307
1215
1216         Reviewed by Brian Burg.
1217
1218         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
1219         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
1220         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
1221         * Versions/Inspector-iOS-7.0.json:
1222         * Versions/Inspector-iOS-8.0.json:
1223         * Versions/Inspector-iOS-9.0.json:
1224         Retroactively remove the protocol methods as they were unused
1225         in these earlier versions as well.
1226
1227 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1228
1229         REGRESSION: Web Inspector: Double clicking on an attribute second time doesn't work
1230         https://bugs.webkit.org/show_bug.cgi?id=149259
1231
1232         Reviewed by Timothy Hatcher.
1233
1234         * UserInterface/Views/DOMTreeElement.js:
1235         Be sure to clear the editing state when committed, even if the value did not change.
1236
1237 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1238
1239         Web Inspector: Make Find / Save keyboard shortcuts work better globally
1240         https://bugs.webkit.org/show_bug.cgi?id=149198
1241
1242         Reviewed by Brian Burg.
1243
1244         Previously find/save keyboard shortcuts required the user have the
1245         ContentView in the ContentBrowser focused. That means nothing would
1246         happen if you clicked / focused in the Sidebars. This change considers
1247         the keyboard shortcuts globally, like Copy.
1248
1249         * UserInterface/Base/Main.js:
1250         (WebInspector.contentLoaded):
1251         Add global find and save keyboard shortcuts.
1252
1253         (WebInspector._focusChanged):
1254         It is often useful to have the currentFocusedElement know if it is
1255         in a TextEditor or other CodeMirror editor. When editable the <textarea>
1256         is selected and not updating focused element. 
1257
1258         (WebInspector._focusedContentBrowser):
1259         (WebInspector._focusedContentView):
1260         Provide helpers for getting a good approximation of the current focused
1261         or visible content view that users would expect to be interacting with.
1262         Since the focus event may not fire when clicking around to elements
1263         like the <body>. Rather than make it explicitly focusable, check the
1264         document.activeElement, and if it is body aim for the main content
1265         browser instead of the currentFocusedElement which may be stale.
1266         Likewise, if the QuickConsole is focused and the split console is
1267         showing, treat it like the split browser is focused.
1268
1269         (WebInspector._focusedOrVisibleContentBrowser):
1270         (WebInspector._focusedOrVisibleContentView):
1271         If nothing is focused, default to the main content browser.
1272
1273         (WebInspector._find):
1274         Pass on to the ContentView which typically handles Find
1275         by showing its find banner.
1276
1277         (WebInspector._save):
1278         (WebInspector._saveAs):
1279         Check and save the current ContentView if supported.
1280
1281         * UserInterface/Views/LogContentView.js:
1282         (WebInspector.LogContentView.prototype.get supportsSearch):
1283         (WebInspector.LogContentView.prototype.handleFindEvent):
1284         Add custom find handling for LogContentView from the routed through the
1285         BrowserController instead of special event handlers in the controller.
1286
1287         (WebInspector.LogContentView.prototype.get supportsSave):
1288         (WebInspector.LogContentView.prototype.save): Deleted.
1289         (WebInspector.LogContentView.prototype.saveAs): Deleted.
1290         * UserInterface/Controllers/JavaScriptLogViewController.js:
1291         (WebInspector.JavaScriptLogViewController): Deleted.
1292         (WebInspector.JavaScriptLogViewController.prototype._handleFindShortcut): Deleted.
1293         (WebInspector.JavaScriptLogViewController.prototype._save): Deleted.
1294         (WebInspector.JavaScriptLogViewController.prototype._saveAs): Deleted.
1295         Special save handling is no longer needed in the log view controller.
1296
1297         * UserInterface/Views/ContentBrowser.js:
1298         (WebInspector.ContentBrowser.prototype.handleFindEvent):
1299         (WebInspector.ContentBrowser): Deleted.
1300         (WebInspector.ContentBrowser.prototype._save): Deleted.
1301         (WebInspector.ContentBrowser.prototype._saveAs): Deleted.
1302         (WebInspector.ContentBrowser.prototype._showFindBanner): Deleted.
1303         Save functionality moved globally, find functionality moved to a
1304         public method called like copy event handling.
1305
1306 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1307
1308         Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
1309         https://bugs.webkit.org/show_bug.cgi?id=149274
1310
1311         Reviewed by Brian Burg.
1312
1313         The dashboard container gets an opacity when the window is inactive. Combined
1314         with the animating debugger continue button this caused a cascade of slightly
1315         overlapping content causing a cascade of a lot of small layers. The simple
1316         approach taken here is to stop the slight pulse animation when the window
1317         is inactive.
1318
1319         * UserInterface/Views/DebuggerDashboardView.css:
1320         (body.window-inactive .dashboard.debugger .navigation-bar .item.button > .glyph):
1321
1322 2015-09-17  Devin Rousso  <dcrousso+webkit@gmail.com>
1323
1324         REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out
1325         https://bugs.webkit.org/show_bug.cgi?id=149197
1326
1327         Reviewed by Timothy Hatcher.
1328
1329         In r188427, logic was added to preserve the leading whitespace of styles in a CSS file.
1330         An unfortunate side effect of this was that extra newlines in between CSS properties
1331         were treated as valid and left where they were.  This is undesired behaviour and often
1332         clutters the styles sidebar.  These changes remove the extra newlines.
1333
1334         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1335         (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContent):
1336
1337 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1338
1339         Web Inspector: Reduce Annotation Update Frequency
1340         https://bugs.webkit.org/show_bug.cgi?id=149250
1341
1342         Reviewed by Saam Barati.
1343
1344         * UserInterface/Controllers/BasicBlockAnnotator.js:
1345         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
1346         * UserInterface/Controllers/TypeTokenAnnotator.js:
1347         (WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
1348         Set a lower bound of 500ms on update frequency for both annotators.
1349
1350 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1351
1352         Web Inspector: Fix common typo "supress" => "suppress"
1353         https://bugs.webkit.org/show_bug.cgi?id=149199
1354
1355         Reviewed by Gyuyoung Kim.
1356
1357         * UserInterface/Views/DataGrid.js:
1358         (WebInspector.DataGridNode.prototype.select):
1359         (WebInspector.DataGridNode.prototype.deselect):
1360         * UserInterface/Views/SearchBar.js:
1361         (WebInspector.SearchBar):
1362
1363 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1364
1365         Web Inspector: Turn off line wrapping in resource text editors
1366         https://bugs.webkit.org/show_bug.cgi?id=149121
1367
1368         Reviewed by Darin Adler.
1369
1370         * UserInterface/Views/TextEditor.js:
1371         (WebInspector.TextEditor):
1372
1373 2015-09-15  Devin Rousso  <dcrousso+webkit@gmail.com>
1374
1375         Web Inspector: Picking unchanged for font-size does not reset back to the unchanged value
1376         https://bugs.webkit.org/show_bug.cgi?id=148351
1377
1378         Reviewed by Brian Burg.
1379
1380         Visual number editors now save any new values in the special placeholder element
1381         to display it whenever the "Unchanged" option is selected by the user.
1382
1383         * UserInterface/Views/VisualStyleNumberInputBox.js:
1384         (WebInspector.VisualStyleNumberInputBox.prototype.set value):
1385         (WebInspector.VisualStyleNumberInputBox.prototype.set units):
1386         (WebInspector.VisualStyleNumberInputBox.prototype._setNumberInputIsEditable):
1387         (WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
1388         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
1389         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
1390
1391 2015-09-15  Brian Burg  <bburg@apple.com>
1392
1393         Web Inspector: command-click in NewTabContentView should open new tab without switching to it
1394         https://bugs.webkit.org/show_bug.cgi?id=149173
1395
1396         Reviewed by Joseph Pecoraro.
1397
1398         To allow a user to quickly restore tabs, it should be possible to command-click
1399         all the tabs that are desired without going back through the [+] tab button.
1400
1401         * UserInterface/Base/Main.js:
1402         (WebInspector.createNewTabWithType): Renamed.
1403
1404             Use an options object and split creating the tab from deleting the
1405             replaced tab and showing the new tab. Add better error checking.
1406
1407         (WebInspector.createNewTab): Deleted.
1408         * UserInterface/Views/NewTabContentView.js:
1409         (WebInspector.NewTabContentView):
1410         (WebInspector.NewTabContentView.prototype._createNewTabWithType): Renamed.
1411
1412             If the meta key is pressed, don't switch to the new tab or remove this view
1413             unless there are no more tabs that can be created beyond the current one.
1414
1415         (WebInspector.NewTabContentView.prototype._allowableTabTypes): Added.
1416         (WebInspector.NewTabContentView.prototype._createNewTab): Deleted.
1417
1418 2015-09-15  Joseph Pecoraro  <pecoraro@apple.com>
1419
1420         Web Inspector: Watch Expressions uncaught exceptions on page reload
1421         https://bugs.webkit.org/show_bug.cgi?id=149150
1422
1423         Reviewed by Brian Burg.
1424
1425         Instead of waiting 50ms to Resume, when the page navigates
1426         Resume immediately. This ensures nobody is using a stale
1427         activeCallFrame after the navigation.
1428
1429         Also clean up the manager a bit by removing some deletes.
1430
1431         * UserInterface/Controllers/DebuggerManager.js:
1432         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
1433         (WebInspector.DebuggerManager.prototype.reset):
1434         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
1435         (WebInspector.DebuggerManager.prototype.debuggerDidResume):
1436         (WebInspector.DebuggerManager.prototype._mainResourceDidChange):
1437         (WebInspector.DebuggerManager.prototype._didResumeInternal):
1438         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
1439         (WebInspector.DebuggerManager.prototype.debuggerDidResume.delayedWork): Deleted.
1440
1441 2015-09-15  Joseph Pecoraro  <pecoraro@apple.com>
1442
1443         Web Inspector: Closing the final inspector tab should be allowed
1444         https://bugs.webkit.org/show_bug.cgi?id=149130
1445
1446         Reviewed by Brian Burg.
1447
1448         Previously we did not allow closing the last inspector tab. Now, we
1449         will allow closing all inspector tabs, and when the last is closed,
1450         present an unclosable New Tab tab, which would then be used to create
1451         a new tab.
1452
1453         * UserInterface/Base/Main.js:
1454         (WebInspector.contentLoaded):
1455         If we have no tabs to restore, show the New Tab tab.
1456
1457         (WebInspector._openDefaultTab):
1458         When the last tab is closed, the tab bar requests we open a default tab.
1459         Open the New Tab tab.
1460
1461         (WebInspector.TabBar.prototype._handleClick):
1462         Disallow closing the single default tab.
1463
1464         (WebInspector._newTabItemClicked):
1465         (WebInspector.showNewTabTab):
1466         Share logic for showing the New Tab tab.
1467
1468         * UserInterface/Views/NewTabContentView.js:
1469         (WebInspector.NewTabContentView):
1470         Mark the new tab's tab bar item as the "default" tab bar item. It gets
1471         special behavior when it is the single normal tab (cannot be closed).
1472
1473         * UserInterface/Views/TabBar.css:
1474         (body:not(.window-inactive) .tab-bar > .item:hover > .close):
1475         (body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .close):
1476         (.tab-bar.single-tab > .item.default-tab > .close):
1477         (body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:not(.hide-close-button):hover > .close): Deleted.
1478         (.tab-bar > .item.hide-close-button > .close): Deleted.
1479         Update styles to only disable the close button on the
1480         "default-tab" when it is the "single-tab" open. Otherwise
1481         always allow closing tabs.
1482
1483         * UserInterface/Views/TabBar.js:
1484         (WebInspector.TabBar.prototype.removeTabBarItem):
1485         (WebInspector.TabBar.prototype.hasNormalTab):
1486         (WebInspector.TabBar.prototype._openDefaultTab):
1487         When removing the last normal tab, send an event to open
1488         the default tab.
1489
1490         * UserInterface/Views/TabBarItem.js:
1491         (WebInspector.TabBarItem.prototype.get default):
1492         (WebInspector.TabBarItem.prototype.get isDefaultTab):
1493         (WebInspector.TabBarItem.prototype.set isDefaultTab):
1494         (WebInspector.TabBarItem.prototype.get hideCloseButton): Deleted.
1495         (WebInspector.TabBarItem.prototype.set hideCloseButton): Deleted.
1496         Switch to marking a tab bar item as the default tab. This tab
1497         will be allowed when it is the single remaining tab. Currently
1498         the default tab is always the "New Tab" tab.
1499
1500 2015-09-15  Brian Burg  <bburg@apple.com>
1501
1502         Web Inspector: new tab content view should disallow split console
1503         https://bugs.webkit.org/show_bug.cgi?id=149164
1504
1505         Reviewed by Joseph Pecoraro.
1506
1507         * UserInterface/Views/NewTabContentView.js:
1508         (WebInspector.NewTabContentView.prototype.get supportsSplitContentBrowser):
1509
1510 2015-09-14  Brian Burg  <bburg@apple.com>
1511
1512         Web Inspector: tab bar stutters when moving mouse after closing tab
1513         https://bugs.webkit.org/show_bug.cgi?id=149138
1514
1515         Reviewed by Joseph Pecoraro.
1516
1517         The tab bar lacked the 'static-layout' class between when the Promise microtask
1518         ran and the beginning of the requestAnimationFrame. This caused a flash of
1519         tabs that are way too wide.
1520
1521         Re-add the static-layout class immediately after measuring the 'after' tab size.
1522         This code should probably just manually compute tab sizes since flexbox
1523         layout is quite slow and our measurement code here forces layout several times.
1524
1525         * UserInterface/Views/TabBar.js:
1526
1527 2015-09-14  Brian Burg  <bburg@apple.com>
1528
1529         Web Inspector: backend command promises are not rejected when a protocol error occurs
1530         https://bugs.webkit.org/show_bug.cgi?id=141403
1531
1532         Reviewed by Joseph Pecoraro.
1533
1534         Fix a few corner cases for how InspectorBackend delivers command failures.
1535
1536         * UserInterface/Protocol/InspectorBackend.js:
1537         (InspectorBackend.Command.prototype.deliverFailure): Added.
1538         (InspectorBackend.Command.prototype._invokeWithArguments):
1539
1540             If argument-checking fails, return a rejected promise or invoke the supplied callback
1541             on a zero-delay setTimeout to ensure that the reply is asynchronous.
1542
1543 2015-09-14  Brian Burg  <bburg@apple.com>
1544
1545         Web Inspector: middle-clicking a tab in the tab bar should close it
1546         https://bugs.webkit.org/show_bug.cgi?id=149135
1547
1548         Reviewed by Joseph Pecoraro.
1549
1550         This matches the behavior of the tab bar in Safari and other browsers.
1551
1552         * UserInterface/Views/TabBar.js:
1553         (WebInspector.TabBar.prototype._handleMouseDown):
1554         (WebInspector.TabBar.prototype._handleClick):
1555
1556 2015-09-14  Nikita Vasilyev  <nvasilyev@apple.com>
1557
1558         Web Inspector: Border under the styles filter field is clipped
1559         https://bugs.webkit.org/show_bug.cgi?id=149115
1560
1561         Reviewed by Darin Adler.
1562
1563         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1564         (.sidebar > .panel.details.css-style > .content + .options-container > .filter-bar):
1565
1566 2015-09-11  Nan Wang  <n_wang@apple.com>
1567
1568         AX: ARIA 1.1 @aria-current
1569         https://bugs.webkit.org/show_bug.cgi?id=146012
1570
1571         Reviewed by Chris Fleizach.
1572
1573         Added support for ARIA 1.1 aria-current.
1574
1575         * Localizations/en.lproj/localizedStrings.js:
1576         * UserInterface/Models/DOMNode.js:
1577         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
1578
1579 2015-09-10  Devin Rousso  <dcrousso+webkit@gmail.com>
1580
1581         Web Inspector: Styles sidebar says Media: all when it should say Media: screen
1582         https://bugs.webkit.org/show_bug.cgi?id=148436
1583
1584         Reviewed by Timothy Hatcher.
1585
1586         Removed filter that prevented "Media: screen" from being displayed.
1587
1588         * UserInterface/Views/RulesStyleDetailsPanel.js:
1589         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
1590         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.filteredMediaList): Deleted.
1591
1592 2015-09-10  Matt Baker  <mattbaker@apple.com>
1593
1594         Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
1595         https://bugs.webkit.org/show_bug.cgi?id=149041
1596
1597         Reviewed by Timothy Hatcher.
1598
1599         Cleaned up two places where a parent view duplicated logic encapsulated by ContentViewContainer.
1600
1601         * UserInterface/Views/ClusterContentView.js:
1602         (WebInspector.ClusterContentView.prototype.updateLayout):
1603         * UserInterface/Views/TimelineRecordingContentView.js:
1604         (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
1605
1606 2015-09-08  Matt Baker  <mattbaker@apple.com>
1607
1608         Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements
1609         https://bugs.webkit.org/show_bug.cgi?id=148651
1610
1611         Reviewed by Timothy Hatcher.
1612
1613         * UserInterface/Base/Main.js:
1614         (WebInspector.contentLoaded):
1615         Create BreakpointPopoverController singleton, expose as public property of global WebInspector object.
1616
1617         * UserInterface/Views/BreakpointTreeElement.js:
1618         (WebInspector.BreakpointTreeElement.prototype.oncontextmenu):
1619         Use BreakpointPopoverController singleton.
1620
1621         * UserInterface/Views/SourceCodeTextEditor.js:
1622         (WebInspector.SourceCodeTextEditor):
1623         Don't create BreakpointPopoverController instance.
1624         (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
1625         Use BreakpointPopoverController singleton.
1626
1627 2015-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1628
1629         Fix inspector/codemirror tests.
1630
1631         Rubber-stamped by Brian Burg.
1632
1633         * UserInterface/Test.html:
1634         Reorder includes to be more like Main.html. This ensures that CodeMirror
1635         resources are loaded before Inspector sources use it, like CodeMirrorAdditions
1636         which gets merged into TestCombined.js.
1637
1638 2015-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1639
1640         Web Inspector: Move PrettyPrinting tests into LayoutTests
1641         https://bugs.webkit.org/show_bug.cgi?id=148698
1642
1643         Reviewed by Timothy Hatcher.
1644
1645         * Tools/PrettyPrinting/index.html:
1646         Modify the relative path to the tests which are now in LayoutTests.
1647
1648         * UserInterface/Test.html:
1649         Load CodeMirror and related resources for Formatting.
1650
1651 2015-09-06  Andy Estes  <aestes@apple.com>
1652
1653         WebKit.xcworkspace should be be able to build iOS platforms
1654         https://bugs.webkit.org/show_bug.cgi?id=148881
1655
1656         Reviewed by Daniel Bates.
1657
1658         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
1659         for all supported platforms.
1660
1661         * Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
1662         * Configurations/WebInspectorUIFramework.xcconfig: Skipped installing on iOS.
1663
1664 2015-09-04  Brian Burg  <bburg@apple.com>
1665
1666         Web Inspector: combine Test.html resources to make tests run faster
1667         https://bugs.webkit.org/show_bug.cgi?id=148726
1668
1669         Reviewed by Timothy Hatcher.
1670
1671         In an attempt to make inspector tests run faster, always combine resources
1672         on the Test.html page. This cuts down from 110+ resource loads to 5 loads.
1673
1674         To avoid name clashes, add the 'Combined' suffix to files that would clash
1675         with uncombined Test resources, and add the 'Test' prefix when combining
1676         or minifying files that would clash with production minification. So, it
1677         would be possible for Main.html and Test.html to have different minified
1678         versions of CodeMirror or other external libraries if they use different
1679         subsets.
1680
1681         Combining is unlikely to make debugging tests more difficult, since almost
1682         all test code is marshalled and eval'd into existence anyway.
1683
1684         * Configurations/WebInspectorUIFramework.xcconfig:
1685         * Scripts/combine-resources.pl: Drive-by spelling.
1686         (concatenateFiles):
1687         (concatinateFiles): Deleted.
1688         * Scripts/copy-user-interface-resources-dryrun.rb:
1689         * Scripts/copy-user-interface-resources.pl:
1690
1691             Drive-by spelling. Add a new code path for combining Test resources, which
1692             doesn't require minification or handling CSS, images, or most externals.
1693
1694         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
1695
1696             Always combine Test.html, but also ditto everything into place for
1697             engineering builds.
1698
1699 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
1700
1701         Web Inspector: Test Runtime.saveResult and $n values
1702         https://bugs.webkit.org/show_bug.cgi?id=148837
1703
1704         Reviewed by Timothy Hatcher.
1705
1706         * UserInterface/Protocol/InspectorBackend.js:
1707         (InspectorBackendClass):
1708         Initialize the dump logging function different if we are in tests or not.
1709         When in tests, using console.log as well as dumping system activity to
1710         the system console results in an infinite loop of logging!
1711
1712         (InspectorBackendClass.prototype.dispatch):
1713         (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
1714         Use the logging function we figured out earlier.
1715
1716 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
1717
1718         Web Inspector: Clean up and modernize DOMTreeManager
1719         https://bugs.webkit.org/show_bug.cgi?id=148821
1720
1721         Reviewed by Timothy Hatcher.
1722
1723         * UserInterface/Controllers/DOMTreeManager.js:
1724         (WebInspector.DOMTreeManager.prototype.requestDocument.onDocumentAvailable):
1725         (WebInspector.DOMTreeManager.prototype.requestDocument):
1726         (WebInspector.DOMTreeManager.prototype.pushNodeByPathToFrontend):
1727         (WebInspector.DOMTreeManager.prototype._wrapClientCallback):
1728         (WebInspector.DOMTreeManager.prototype._attributeModified):
1729         (WebInspector.DOMTreeManager.prototype._attributeRemoved):
1730         (WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
1731         (WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
1732         (WebInspector.DOMTreeManager.prototype.cancelSearch):
1733         (WebInspector.DOMTreeManager.prototype.querySelector):
1734         (WebInspector.DOMTreeManager.prototype.querySelectorAll):
1735         (WebInspector.DOMTreeManager.prototype.highlightDOMNode):
1736         (WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
1737         Cleanup and modernize where appropriate.
1738
1739         * UserInterface/Views/SearchSidebarPanel.js:
1740         (WebInspector.SearchSidebarPanel.prototype.performSearch):
1741         Callback is now required.
1742
1743 2015-09-04  Matt Baker  <mattbaker@apple.com>
1744
1745         Web Inspector: Render Frames "Other" task filter checkbox misaligned with text
1746         https://bugs.webkit.org/show_bug.cgi?id=148788
1747
1748         Reviewed by Timothy Hatcher.
1749
1750         * UserInterface/Views/ChartDetailsSectionRow.css:
1751         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > label > .color-key):
1752         Adjust "fake" checkbox margin to align with label text.
1753
1754 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
1755
1756         Web Inspector: Expand Console domain test coverage
1757         https://bugs.webkit.org/show_bug.cgi?id=148740
1758
1759         Reviewed by Brian Burg.
1760
1761         * UserInterface/Protocol/RemoteObject.js:
1762         Add a few helpers for checking the RemoteObject type.
1763
1764 2015-09-02  Commit Queue  <commit-queue@webkit.org>
1765
1766         Unreviewed, rolling out r189241.
1767         https://bugs.webkit.org/show_bug.cgi?id=148703
1768
1769         These tests crash with assertions (Requested by ap on
1770         #webkit).
1771
1772         Reverted changeset:
1773
1774         "Web Inspector: Move PrettyPrinting tests into LayoutTests"
1775         https://bugs.webkit.org/show_bug.cgi?id=148698
1776         http://trac.webkit.org/changeset/189241
1777
1778 2015-09-01  Joseph Pecoraro  <pecoraro@apple.com>
1779
1780         Web Inspector: Move PrettyPrinting tests into LayoutTests
1781         https://bugs.webkit.org/show_bug.cgi?id=148698
1782
1783         Reviewed by Timothy Hatcher.
1784
1785         * Tools/PrettyPrinting/index.html:
1786         Modify the relative path to the tests which are now in LayoutTests.
1787
1788         * UserInterface/Test.html:
1789         Load CodeMirror and related resources for Formatting.
1790
1791 2015-09-01  Matt Baker  <mattbaker@apple.com>
1792
1793         Web Inspector: REGRESSION (r187873): Location column icon is missing in timeline data grids
1794         https://bugs.webkit.org/show_bug.cgi?id=148691
1795
1796         Reviewed by Timothy Hatcher.
1797
1798         * UserInterface/Views/TimelineDataGridNode.js:
1799         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
1800         Added "icon" class name. Was using removed class variable (class="undefined").
1801
1802 2015-09-01  Matt Baker  <mattbaker@apple.com>
1803
1804         Web Inspector: Show layout/paint pixel area in the Rendering Frames tree outline
1805         https://bugs.webkit.org/show_bug.cgi?id=148674
1806
1807         Reviewed by Brian Burg.
1808
1809         * Localizations/en.lproj/localizedStrings.js:
1810         New UI string.
1811
1812         * UserInterface/Views/RenderingFrameTimelineView.css:
1813         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item:not(.paint-record):not(.layout-record) .subtitle):
1814         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item .subtitle): Deleted.
1815         Show subtitles for layout and paint records only. We still want to hide script record subtitles,
1816         since that information is already in the 'Location' column.
1817
1818         * UserInterface/Views/RenderingFrameTimelineView.js:
1819         (WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
1820         Add tree element subtitle for LayoutTimelineRecords that specify width and height.
1821
1822 2015-09-01  Matt Baker  <mattbaker@apple.com>
1823
1824         Web Inspector: Reorder columns in the Rendering Frames data grid by importance
1825         https://bugs.webkit.org/show_bug.cgi?id=148672
1826
1827         Reviewed by Timothy Hatcher.
1828
1829         * UserInterface/Views/RenderingFrameTimelineView.js:
1830         (WebInspector.RenderingFrameTimelineView):
1831         Updated column order, rearranged the column object setup code to match.
1832
1833 2015-09-01  Brian Burg  <bburg@apple.com>
1834
1835         Web Inspector: rewrite inspector/console/command-line-api.html to use AsyncTestSuite
1836         https://bugs.webkit.org/show_bug.cgi?id=148637
1837
1838         Reviewed by Darin Adler.
1839
1840         * UserInterface/Base/Object.js:
1841         (WebInspector.Object.singleFireEventListener):
1842         (WebInspector.Object.singleFireEventListener.let.wrappedCallback): Arrow.
1843
1844 2015-09-01  Devin Rousso  <drousso@apple.com>
1845
1846         Web Inspector: New rule button in the style sidebar is blurry and too dark
1847         https://bugs.webkit.org/show_bug.cgi?id=148108
1848
1849         Reviewed by Timothy Hatcher.
1850
1851         Added support for Plus and Minus icons on non-retina screens.
1852         Also removed some CSS rules that no longer apply to anything.
1853
1854         * UserInterface/Images/Minus.svg:
1855         * UserInterface/Images/NewTabPlus.svg:
1856         * UserInterface/Images/Plus.svg: Removed.
1857         * UserInterface/Images/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
1858         * UserInterface/Images/Plus15.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
1859
1860         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1861         (.sidebar > .panel.details.css-style > .content + .options-container):
1862         (.sidebar > .panel.details.css-style > .content + .options-container > .new-rule):
1863
1864         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
1865         (.details-section.probe-set .options > .probe-add):
1866
1867         * UserInterface/Views/RulesStyleDetailsPanel.css:
1868         (.sidebar > .panel.details.css-style .rules .new-rule): Deleted.
1869         (.sidebar > .panel.details.css-style .rules > *:first-child:matches(.new-rule)): Deleted.
1870         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
1871         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .style-declaration-section): Deleted.
1872         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label): Deleted.
1873         (.sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
1874         (.sidebar > .panel.details.css-style .rules .new-rule:hover): Deleted.
1875         (.sidebar > .panel.details.css-style .rules .new-rule:active): Deleted.
1876         (@media (-webkit-min-device-pixel-ratio: 2)): Deleted.
1877         Removed CSS rules that no longer apply.  The new rule button was moved to the Styles sidebar.
1878
1879         * UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
1880         (.details-section.watch-expressions .options > .watch-expression-add):
1881
1882         * UserInterface/Views/TabBar.css:
1883         (.tab-bar > .item.new-tab-button > .icon):
1884
1885         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
1886         (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-controls > div):
1887
1888         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
1889         (WebInspector.VisualStyleCommaSeparatedKeywordEditor):
1890
1891         * UserInterface/Views/VisualStyleSelectorSection.js:
1892         (WebInspector.VisualStyleSelectorSection):
1893
1894 2015-09-01  Brian Burg  <bburg@apple.com>
1895
1896         Web Inspector: add TestSuite hooks for per-testcase setup and teardown actions
1897         https://bugs.webkit.org/show_bug.cgi?id=148641
1898
1899         Reviewed by Timothy Hatcher.
1900
1901         It should be possible to run setup and teardown actions for each test case.
1902         The use case here is to add listeners, set up testcase-specific state, etc.
1903         To match how test functions work in each suite, the sync and async implementations
1904         take functions with no arguments and(resolve, reject), respectively.
1905
1906         * UserInterface/Test/TestSuite.js:
1907         (TestSuite.prototype.addTestCase):
1908         (TestSuite.messageFromThrownObject):
1909         (TestSuite):
1910         (AsyncTestSuite.prototype.runTestCases): Stick the extra functions in the chain.
1911         (AsyncTestSuite):
1912         (SyncTestSuite.prototype.runTestCases):
1913         (SyncTestSuite):
1914
1915 2015-09-01  Matt Baker  <mattbaker@apple.com>
1916
1917         Web Inspector: Visual style editor shouldn't allow alpha characters in numeric input fields
1918         https://bugs.webkit.org/show_bug.cgi?id=148580
1919
1920         Reviewed by Brian Burg.
1921
1922         * UserInterface/Views/VisualStyleNumberInputBox.js:
1923         (WebInspector.VisualStyleNumberInputBox):
1924         Added input element "changed" handler, renamed "keyup" handler to match "keydown" handler.
1925         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputChanged):
1926         Validate input in response to changed event.
1927
1928 2015-08-31  Nikita Vasilyev  <nvasilyev@apple.com>
1929
1930         Web Inspector: Command-Enter for selected JS in Debugger/Sources shouldn't change the focus
1931         https://bugs.webkit.org/show_bug.cgi?id=148613
1932
1933         Reviewed by Timothy Hatcher.
1934
1935         * UserInterface/Views/ConsoleTabContentView.js:
1936         (WebInspector.ConsoleTabContentView.prototype.shown):
1937         Always focus on the console prompt when the console tab get selected.
1938
1939         * UserInterface/Views/LogContentView.js:
1940         (WebInspector.LogContentView.prototype.shown): Deleted.
1941
1942 2015-08-31  Joseph Pecoraro  <pecoraro@apple.com>
1943
1944         Web Inspector: Debugger Popovers should work for object literal shorthand variables
1945         https://bugs.webkit.org/show_bug.cgi?id=148603
1946
1947         Reviewed by Timothy Hatcher.
1948
1949         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1950         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1951         Allow debugger popovers for object property shorthands, because they
1952         are actually variables that have values. Previously we ignored property
1953         name literals, because they were just property names until ES6.
1954
1955         * UserInterface/Views/CodeMirrorAdditions.js:
1956         Add a helper for walking through token types from a start position. It may be useful elsewhere.
1957
1958 2015-08-31  Matt Baker  <mattbaker@apple.com>
1959
1960         Web Inspector: Move the Popover code out of the Breakpoint model object
1961         https://bugs.webkit.org/show_bug.cgi?id=127328
1962
1963         Reviewed by Timothy Hatcher.
1964
1965         * UserInterface/Controllers/BreakpointPopoverController.js: Added.
1966         (WebInspector.BreakpointPopoverController):
1967         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.editBreakpoint):
1968         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.removeBreakpoint):
1969         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.toggleBreakpoint):
1970         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.toggleAutoContinue):
1971         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
1972         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems):
1973         (WebInspector.BreakpointPopoverController.prototype.showEditBreakpointPopover):
1974         (WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
1975         (WebInspector.BreakpointPopoverController.prototype._popoverToggleEnabledCheckboxChanged):
1976         (WebInspector.BreakpointPopoverController.prototype._popoverConditionInputChanged):
1977         (WebInspector.BreakpointPopoverController.prototype._popoverToggleAutoContinueCheckboxChanged):
1978         (WebInspector.BreakpointPopoverController.prototype._popoverConditionInputKeyDown):
1979         (WebInspector.BreakpointPopoverController.prototype._popoverActionsCreateAddActionButton):
1980         (WebInspector.BreakpointPopoverController.prototype._popoverActionsAddActionButtonClicked):
1981         (WebInspector.BreakpointPopoverController.prototype._popoverActionsInsertBreakpointActionView):
1982         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewAppendActionView):
1983         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewRemoveActionView):
1984         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewResized):
1985         (WebInspector.BreakpointPopoverController.prototype.willDismissPopover):
1986         (WebInspector.BreakpointPopoverController.prototype.didDismissPopover):
1987         Added controller class to encapsulate view logic previously located in WebInspector.Breakpoint.
1988
1989         * UserInterface/Main.html:
1990         Added and updated file paths.
1991
1992         * UserInterface/Models/Breakpoint.js:
1993         (WebInspector.Breakpoint.prototype.appendContextMenuItems.editBreakpoint): Deleted.
1994         (WebInspector.Breakpoint.prototype.appendContextMenuItems.removeBreakpoint): Deleted.
1995         (WebInspector.Breakpoint.prototype.appendContextMenuItems.toggleBreakpoint): Deleted.
1996         (WebInspector.Breakpoint.prototype.appendContextMenuItems.toggleAutoContinue): Deleted.
1997         (WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation): Deleted.
1998         (WebInspector.Breakpoint.prototype.appendContextMenuItems): Deleted.
1999         (WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged): Deleted.
2000         (WebInspector.Breakpoint.prototype._popoverConditionInputChanged): Deleted.
2001         (WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged): Deleted.
2002         (WebInspector.Breakpoint.prototype._popoverConditionInputKeyDown): Deleted.
2003         (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement): Deleted.
2004         (WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton): Deleted.
2005         (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked): Deleted.
2006         (WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView): Deleted.
2007         (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView): Deleted.
2008         (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView): Deleted.
2009         (WebInspector.Breakpoint.prototype.breakpointActionViewResized): Deleted.
2010         (WebInspector.Breakpoint.prototype.willDismissPopover): Deleted.
2011         (WebInspector.Breakpoint.prototype.didDismissPopover): Deleted.
2012         (WebInspector.Breakpoint.prototype._showEditBreakpointPopover): Deleted.
2013         Removed view logic.
2014
2015         * UserInterface/Views/BreakpointPopoverController.css: Renamed from Source/WebInspectorUI/UserInterface/Views/Breakpoint.css.
2016         (.popover .edit-breakpoint-popover-content):
2017         (.popover .edit-breakpoint-popover-content.wide):
2018         (.popover .edit-breakpoint-popover-content > label.toggle):
2019         (.popover .edit-breakpoint-popover-content > table):
2020         (.popover .edit-breakpoint-popover-content > table > tr > th):
2021         (.popover .edit-breakpoint-popover-content > table > tr > td):
2022         (#edit-breakpoint-popover-condition):
2023         (#edit-breakpoint-popoover-auto-continue):
2024
2025         * UserInterface/Views/SourceCodeTextEditor.js:
2026         (WebInspector.SourceCodeTextEditor):
2027         Creates a BreakpointPopoverController instance. The lifetime of the 'Edit Breakpoint' view is internal to the
2028         controller, and can't be initiated outside of a context menu item click.
2029
2030 2015-08-31  Matt Baker  <mattbaker@apple.com>
2031
2032         Web Inspector: Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart
2033         https://bugs.webkit.org/show_bug.cgi?id=148549
2034
2035         Reviewed by Timothy Hatcher.
2036
2037         Small data points can be invisible or difficult to see in the pie chart. This patch introduces
2038         a minimum slice size of 1.5% (determined by visual inspection) for chart items.
2039
2040         Legend items continue to show the original data point values, not the adjusted values used to
2041         draw the chart slices.
2042
2043         * UserInterface/Views/ChartDetailsSectionRow.js:
2044         (WebInspector.ChartDetailsSectionRow):
2045         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
2046         Adjust display values up or down as needed, so no data point is less than the
2047         minimum and all chart slices still total 100%.
2048
2049 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2050
2051         Web Inspector: "animationEnd" event names should be "animationend" (broken dashboard animation after pause)
2052         https://bugs.webkit.org/show_bug.cgi?id=148604
2053
2054         Reviewed by Timothy Hatcher.
2055
2056         * UserInterface/Views/DOMTreeElement.js:
2057         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
2058         * UserInterface/Views/DashboardContainerView.js:
2059         (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
2060         (WebInspector.DashboardContainerView.prototype._showDashboardView):
2061         (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
2062         (WebInspector.DashboardContainerView.prototype._hideDashboardView):
2063         * UserInterface/Views/DefaultDashboardView.js:
2064         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
2065         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
2066         * UserInterface/Views/TextEditor.js:
2067         (WebInspector.TextEditor.prototype._revealSearchResult):
2068
2069 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2070
2071         Web Inspector: Resource.prototype.associateWithScript assertions firing
2072         https://bugs.webkit.org/show_bug.cgi?id=148601
2073
2074         Reviewed by Timothy Hatcher.
2075
2076         * UserInterface/Models/Resource.js:
2077         (WebInspector.Resource.prototype.associateWithScript):
2078         Restore the code that was here before it was converted to asserts.
2079         It looked as if it was iOS 6 only but it was not.
2080
2081 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2082
2083         Web Inspector: Improve ScriptSyntaxTree a bit
2084         https://bugs.webkit.org/show_bug.cgi?id=148563
2085
2086         Reviewed by Timothy Hatcher.
2087
2088         * UserInterface/Models/ScriptSyntaxTree.js:
2089         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2090         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2091         Share and fix ClassDeclaration and ClassExpression recursion to visit
2092         the identifier (node.id). Include the kind with a VariableDeclaration
2093         ("var", "let", "const").
2094
2095 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2096
2097         Web Inspector: Separate creating a style sheet from adding a new rule in the protocol
2098         https://bugs.webkit.org/show_bug.cgi?id=148502
2099
2100         Reviewed by Timothy Hatcher.
2101
2102         The backend allows creating multiple stylesheets. This patch makes
2103         the frontend have a preferred InspectorStyleSheet per-frame.
2104
2105         * UserInterface/Base/Object.js:
2106         (WebInspector.Object.singleFireEventListener):
2107         Return the wrapped listener so it can be removed if needed.
2108
2109         * UserInterface/Models/CSSStyleSheet.js:
2110         (WebInspector.CSSStyleSheet.prototype.isInspectorStyleSheet):
2111         Helper to check if the current stylesheet is an inspector created stylesheet.
2112
2113         * UserInterface/Controllers/CSSStyleManager.js:
2114         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame):
2115         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.documentNodeAvailable):
2116         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.bodyNodeAvailable):
2117         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.cssRuleAvailable):
2118         (WebInspector.CSSStyleManager.prototype._inspectorStyleSheetsForFrame):
2119         Lookup the inspector stylesheet for a particular frame. If one doesn't exist create it.
2120         For legacy backends, exploit "addRule" to create the inspector stylesheet.
2121
2122         * UserInterface/Models/DOMNode.js:
2123         * UserInterface/Models/DOMNodeStyles.js:
2124         (WebInspector.DOMNodeStyles.prototype.addEmptyRule.inspectorStyleSheetAvailable):
2125         (WebInspector.DOMNodeStyles.prototype.addEmptyRule):
2126         Currently add all new rules to the inspector stylesheet.
2127
2128 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2129
2130         Web Inspector: Type Profiler does not understand Functions within Default Argument Expressions
2131         https://bugs.webkit.org/show_bug.cgi?id=148557
2132
2133         Reviewed by Timothy Hatcher.
2134
2135         * UserInterface/Models/ScriptSyntaxTree.js:
2136         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2137         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2138         (WebInspector.ScriptSyntaxTree):
2139         Add support for abstracting and recursing through the default parameter
2140         expressions Esprima has on function expressions and declarations.
2141
2142 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2143
2144         Web Inspector: Type Profiler does not understand Functions inside Template Strings (ScriptSyntaxTree warnings)
2145         https://bugs.webkit.org/show_bug.cgi?id=148556
2146
2147         Reviewed by Timothy Hatcher.
2148
2149         * UserInterface/Models/ScriptSyntaxTree.js:
2150         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2151         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2152         (WebInspector.ScriptSyntaxTree):
2153         Add support for abstracting and recursing through the Esprima template nodes.
2154
2155 2015-08-27  Joseph Pecoraro  <pecoraro@apple.com>
2156
2157         Web Inspector: Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager
2158         https://bugs.webkit.org/show_bug.cgi?id=148515
2159
2160         Reviewed by Brian Burg.
2161
2162         * UserInterface/Controllers/CSSStyleManager.js:
2163         (WebInspector.CSSStyleManager.protocolStyleSheetOriginToEnum):
2164         (WebInspector.CSSStyleManager.protocolMediaSourceToEnum):
2165         Protocol enum to frontend enum conversion.
2166
2167         * UserInterface/Models/DOMNodeStyles.js:
2168         (WebInspector.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
2169         (WebInspector.DOMNodeStyles.prototype.refresh):
2170         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2171         (WebInspector.DOMNodeStyles.prototype._collectStylesInCascadeOrder):
2172         Use the manager to convert from a protocol payload enum to frontend num for css types.
2173
2174         * UserInterface/Models/CSSRule.js:
2175         (WebInspector.CSSRule.prototype.get editable):
2176         * UserInterface/Views/CSSStyleDeclarationSection.js:
2177         (WebInspector.CSSStyleDeclarationSection):
2178         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
2179         * UserInterface/Views/RulesStyleDetailsPanel.js:
2180         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
2181         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
2182         * UserInterface/Views/VisualStyleSelectorSection.js:
2183         (WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem):
2184         (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules.set return):
2185         (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules):
2186         (WebInspector.VisualStyleSelectorSection.prototype.update):
2187         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
2188         (WebInspector.VisualStyleSelectorTreeItem):
2189         Update enum use.
2190
2191 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2192
2193         Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
2194         https://bugs.webkit.org/show_bug.cgi?id=148510
2195
2196         Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
2197
2198         Reviewed by Timothy Hatcher.
2199
2200         * UserInterface/Base/Main.js:
2201         (WebInspector.contentLoaded):
2202         * UserInterface/Views/Main.css:
2203         (body:not(.mavericks)):
2204         (body): Deleted.
2205         * UserInterface/Views/Toolbar.css:
2206         (body:not(.mavericks) .toolbar):
2207         (body.window-inactive:not(.mavericks) .toolbar):
2208         (body.mac-platform:not(.docked, .mavericks) .toolbar):
2209         (.toolbar): Deleted.
2210         (body.window-inactive .toolbar): Deleted.
2211         (body.mac-platform:not(.docked) .toolbar): Deleted.
2212
2213 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2214
2215         Web Inspector: Uncaught exception in CSS Completion - TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith')
2216         https://bugs.webkit.org/show_bug.cgi?id=148508
2217
2218         Reviewed by Timothy Hatcher.
2219
2220         * UserInterface/Models/CSSCompletions.js:
2221         (WebInspector.CSSCompletions):
2222         Add a comment explaining that the constructor may be called with
2223         a list of strings or a list of objects from the protocol. Add
2224         a fast path for when this is constructed with a list of strings.
2225
2226 2015-08-26  Matt Baker  <mattbaker@apple.com>
2227
2228         Web Inspector: Rendering Frames timeline pie chart should use SVG instead of 2D canvas
2229         https://bugs.webkit.org/show_bug.cgi?id=148457
2230
2231         Reviewed by Timothy Hatcher.
2232
2233         * UserInterface/Views/ChartDetailsSectionRow.css:
2234         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.hidden):
2235         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.chart-segment):
2236         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.empty-chart):
2237         New styles for SVG chart elements.
2238
2239         * UserInterface/Views/ChartDetailsSectionRow.js:
2240         (WebInspector.ChartDetailsSectionRow):
2241         Calculate radii and create SVG chart elements.
2242         (WebInspector.ChartDetailsSectionRow.prototype.clearItems):
2243         Remove chart segment path elements.
2244         (WebInspector.ChartDetailsSectionRow.prototype._needsLayout):
2245         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout.createSegmentPathData):
2246         Helper function that creates path data for a single pie chart segment.
2247         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
2248         Creates path elements as needed, and updates path data for for non-zero data points.
2249         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel): Deleted.
2250         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius): Deleted.
2251         These properties are now set during construction.
2252         (WebInspector.ChartDetailsSectionRow.prototype.updateLayout): Deleted.
2253         Renamed to _updateLayout.
2254
2255         * UserInterface/Views/TimelineSidebarPanel.js:
2256         Chart size and inner radius passed to chart constructor.
2257
2258 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2259
2260         Web Inspector: Implement tracking of active stylesheets in the frontend
2261         https://bugs.webkit.org/show_bug.cgi?id=105828
2262
2263         Reviewed by Timothy Hatcher.
2264
2265         * UserInterface/Models/CSSStyleSheet.js:
2266         (WebInspector.CSSStyleSheet):
2267         (WebInspector.CSSStyleSheet.prototype.get origin):
2268         (WebInspector.CSSStyleSheet.prototype.updateInfo):
2269         Add a new origin attribute that has been sent from the backend for a while.
2270
2271         * UserInterface/Controllers/CSSStyleManager.js:
2272         (WebInspector.CSSStyleManager.prototype.styleSheetAdded):
2273         (WebInspector.CSSStyleManager.prototype.styleSheetRemoved):
2274         Handle the new events by managing the new CSSStyleSheets.
2275         
2276         (WebInspector.CSSStyleManager):
2277         (WebInspector.CSSStyleManager.prototype._mainResourceDidChange):
2278         Reset the legacy fetching flag. Fetching is only needed for legacy backends.
2279
2280         (WebInspector.CSSStyleManager.prototype._fetchInfoForAllStyleSheets):
2281         Include the new origin property in the legacy updateInfo path.
2282
2283         * UserInterface/Protocol/CSSObserver.js:
2284         (WebInspector.CSSObserver.prototype.styleSheetAdded):
2285         (WebInspector.CSSObserver.prototype.styleSheetRemoved):
2286         Forward to the manager.
2287
2288         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
2289         (WebInspector.CSSStyleDetailsSidebarPanel):
2290         Refresh the sidebar when stylesheets are added / removed, as that
2291         may affect the style of the select element.
2292
2293 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2294
2295         Web Inspector: Drop iOS 6 Legacy Remote Inspector Support
2296         https://bugs.webkit.org/show_bug.cgi?id=148456
2297
2298         Reviewed by Timothy Hatcher.
2299
2300         * UserInterface/Base/Main.js:
2301         (WebInspector.loaded):
2302         (WebInspector._updateReloadToolbarButton):
2303         (WebInspector._updateDownloadToolbarButton):
2304         (WebInspector.canArchiveMainFrame):
2305         * UserInterface/Controllers/CSSStyleManager.js:
2306         (WebInspector.CSSStyleManager.prototype._frameURLMapKey):
2307         (WebInspector.CSSStyleManager.prototype._lookupStyleSheet.styleSheetsFetched):
2308         (WebInspector.CSSStyleManager._updateResourceContent.fetchedStyleSheetContent):
2309         (WebInspector.CSSStyleManager.prototype._clearStyleSheetsForResource): Deleted.
2310         * UserInterface/Controllers/DOMTreeManager.js:
2311         (WebInspector.DOMTreeManager.prototype.highlightSelector):
2312         * UserInterface/Controllers/DebuggerManager.js:
2313         (WebInspector.DebuggerManager.prototype._setBreakpoint):
2314         * UserInterface/Controllers/JavaScriptLogViewController.js:
2315         * UserInterface/Controllers/RuntimeManager.js:
2316         (WebInspector.RuntimeManager):
2317         (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
2318         * UserInterface/Controllers/SourceMapManager.js:
2319         (WebInspector.SourceMapManager.prototype._loadAndParseSourceMap):
2320         * UserInterface/Controllers/StorageManager.js:
2321         (WebInspector.StorageManager):
2322         (WebInspector.StorageManager.prototype._addDOMStorageIfNeeded):
2323         (WebInspector.StorageManager.prototype.domStorageWasUpdated): Deleted.
2324         (WebInspector.StorageManager.prototype._domStorageForIdentifier): Deleted.
2325         (WebInspector.StorageManager.prototype._extraDomainsActivated): Deleted.
2326         * UserInterface/Controllers/TimelineManager.js:
2327         (WebInspector.TimelineManager.prototype._processRecord):
2328         * UserInterface/Models/Breakpoint.js:
2329         (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
2330         * UserInterface/Models/CSSCompletions.js:
2331         (WebInspector.CSSCompletions):
2332         (WebInspector.CSSCompletions.requestCSSCompletions):
2333         * UserInterface/Models/CSSKeywordCompletions.js:
2334         (WebInspector.CSSKeywordCompletions.addCustomCompletions): Deleted.
2335         * UserInterface/Models/CSSProperty.js:
2336         (WebInspector.CSSProperty):
2337         (WebInspector.CSSProperty.prototype.update):
2338         * UserInterface/Models/CSSRule.js:
2339         (WebInspector.CSSRule.prototype.get matchedSelectors): Deleted.
2340         (WebInspector.CSSRule.prototype.get matchedSelectorText): Deleted.
2341         * UserInterface/Models/DOMNodeStyles.js:
2342         (WebInspector.DOMNodeStyles.prototype.refresh.parseRuleMatchArrayPayload):
2343         (WebInspector.DOMNodeStyles.prototype.refresh.fetchedMatchedStyles):
2344         (WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
2345         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
2346         (WebInspector.DOMNodeStyles.prototype._parseStylePropertyPayload):
2347         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2348         (WebInspector.DOMNodeStyles.prototype.changeStyleText.attributeChanged): Deleted.
2349         (WebInspector.DOMNodeStyles.prototype.changeStyleText.fetchedStyleSheetContent.contentDidChange): Deleted.
2350         (WebInspector.DOMNodeStyles.prototype.changeStyleText.fetchedStyleSheetContent): Deleted.
2351         (WebInspector.DOMNodeStyles.prototype._parseSourceRangePayload): Deleted.
2352         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload): Deleted.
2353         * UserInterface/Models/DOMStorageObject.js:
2354         * UserInterface/Models/DOMTree.js:
2355         (WebInspector.DOMTree.prototype.requestRootDOMNode):
2356         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2357         * UserInterface/Models/DatabaseObject.js:
2358         (WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
2359         (WebInspector.DatabaseObject.prototype.executeSQL):
2360         (WebInspector.DatabaseObject):
2361         (WebInspector.DatabaseObject.prototype.executeSQL.callback): Deleted.
2362         * UserInterface/Models/ExecutionContext.js:
2363         (WebInspector.ExecutionContext.supported): Deleted.
2364         * UserInterface/Models/IssueMessage.js:
2365         (WebInspector.IssueMessage): Deleted.
2366         * UserInterface/Models/LayoutTimelineRecord.js:
2367         (WebInspector.LayoutTimelineRecord):
2368         (WebInspector.LayoutTimelineRecord.prototype.get width):
2369         (WebInspector.LayoutTimelineRecord.prototype.get height):
2370         (WebInspector.LayoutTimelineRecord.prototype.get area):
2371         (WebInspector.LayoutTimelineRecord.prototype.get x): Deleted.
2372         (WebInspector.LayoutTimelineRecord.prototype.get y): Deleted.
2373         (WebInspector.LayoutTimelineRecord.prototype.get rect): Deleted.
2374         * UserInterface/Models/ProfileNode.js:
2375         * UserInterface/Models/Resource.js:
2376         (WebInspector.Resource.prototype.associateWithScript):
2377         * UserInterface/Models/ScriptTimelineRecord.js:
2378         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
2379         * UserInterface/Models/SourceMapResource.js:
2380         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
2381         * UserInterface/Models/TextRange.js:
2382         (WebInspector.TextRange.prototype.resolveLinesAndColumns.countNewLineCharacters): Deleted.
2383         (WebInspector.TextRange.prototype.resolveLinesAndColumns): Deleted.
2384         * UserInterface/Models/TimelineRecording.js:
2385         * UserInterface/Protocol/ConsoleObserver.js:
2386         (WebInspector.ConsoleObserver.prototype.messageAdded): Deleted.
2387         * UserInterface/Protocol/DOMStorageObserver.js:
2388         (WebInspector.DOMStorageObserver.prototype.addDOMStorage): Deleted.
2389         (WebInspector.DOMStorageObserver.prototype.updateDOMStorage): Deleted.
2390         * UserInterface/Protocol/DatabaseObserver.js:
2391         (WebInspector.DatabaseObserver.prototype.sqlTransactionSucceeded): Deleted.
2392         (WebInspector.DatabaseObserver.prototype.sqlTransactionFailed): Deleted.
2393         (WebInspector.DatabaseObserver): Deleted.
2394         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Removed.
2395         * UserInterface/Views/CookieStorageContentView.js:
2396         (WebInspector.CookieStorageContentView.prototype._deleteCallback):
2397         (WebInspector.CookieStorageContentView):
2398         * UserInterface/Views/DOMTreeContentView.js:
2399         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings): Deleted.
2400         * UserInterface/Views/EventListenerSectionGroup.js:
2401         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
2402         (WebInspector.EventListenerSectionGroup):
2403         * UserInterface/Views/LayoutTimelineView.js:
2404         (WebInspector.LayoutTimelineView.prototype._showHighlightForRecord):
2405         * UserInterface/Views/QuickConsole.js:
2406         (WebInspector.QuickConsole):
2407         (WebInspector.QuickConsole.prototype._createExecutionContextPathComponentFromFrame):
2408         (WebInspector.QuickConsole.prototype._frameAdded): Deleted.
2409         (WebInspector.QuickConsole.prototype._frameRemoved): Deleted.
2410         (WebInspector.QuickConsole.prototype._frameMainResourceChanged): Deleted.
2411         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2412         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
2413         * UserInterface/Views/SourceCodeTextEditor.js:
2414         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2415         (WebInspector.SourceCodeTextEditor.prototype._makeBasicBlockAnnotator):
2416         * Versions/Inspector-iOS-6.0.json: Removed.
2417         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2418         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2419
2420 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2421
2422         Web Inspector: Command-Enter should evaluate selected JS in Debugger/Sources
2423         https://bugs.webkit.org/show_bug.cgi?id=148368
2424
2425         Reviewed by Timothy Hatcher.
2426
2427         * UserInterface/Controllers/CodeMirrorCompletionController.js:
2428         (WebInspector.CodeMirrorCompletionController):
2429         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
2430         Evaluate selected text in the console only for JS and HTML resources. HTML resources
2431         should be allowed because they can have commented out (inside <!-- -->) and
2432         inline (onclick="") JavaScript.
2433
2434 2015-08-25  Brian Burg  <bburg@apple.com>
2435
2436         Web Inspector: no need to allocate protocolErrors array for every dispatched backend command
2437         https://bugs.webkit.org/show_bug.cgi?id=146466
2438
2439         Reviewed by Joseph Pecoraro.
2440
2441         * UserInterface/TestStub.html: Fix a typo, this property exists on ProtocolTest.
2442
2443 2015-08-26  Matt Baker  <mattbaker@apple.com>
2444
2445         Web Inspector: Rendering Frames legend item checkbox colors are too light
2446         https://bugs.webkit.org/show_bug.cgi?id=148465
2447
2448         Reviewed by Timothy Hatcher.
2449
2450         * UserInterface/Views/ChartDetailsSectionRow.js:
2451         (WebInspector.ChartDetailsSectionRow.prototype._addCheckboxColorFilter):
2452         Gamma primitive should use an "exponent" attribute instead of "value".
2453         Increased gamma exponent to 1.4.
2454
2455 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2456
2457         Web Inspector: Make DOM node attribute changes highlighting less obnoxious
2458         https://bugs.webkit.org/show_bug.cgi?id=148050
2459
2460         Reviewed by Timothy Hatcher.
2461
2462         * UserInterface/Views/DOMTreeOutline.css:
2463         (@keyframes node-state-changed): Change color to a light green.
2464         (.node-state-changed): Add a slight ease-in for the animation function.
2465
2466 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2467
2468         Web Inspector: Add Refresh button to Cookie Content View
2469         https://bugs.webkit.org/show_bug.cgi?id=148468
2470
2471         Reviewed by Timothy Hatcher.
2472
2473         * UserInterface/Views/CookieStorageContentView.js:
2474         (WebInspector.CookieStorageContentView):
2475         (WebInspector.CookieStorageContentView.prototype.get navigationItems):
2476         (WebInspector.CookieStorageContentView.prototype._refreshButtonClicked):
2477
2478 2015-08-25  Brian Burg  <bburg@apple.com>
2479
2480         Web Inspector: message dispatch metrics should use high-resolution timing data
2481         https://bugs.webkit.org/show_bug.cgi?id=135467
2482
2483         Reviewed by Timothy Hatcher.
2484
2485         Use performance.now if it's available, otherwise fallback to Date.now().
2486         Format timestamps with fixed decimal point, and sprinkle some ES6.
2487
2488         * UserInterface/Base/Utilities.js:
2489         (timestamp): Added.
2490         * UserInterface/Protocol/InspectorBackend.js:
2491         (InspectorBackendClass):
2492         (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
2493         (InspectorBackendClass.prototype._dispatchEvent):
2494         * UserInterface/Protocol/MessageDispatcher.js:
2495         (WebInspector.dispatchNextQueuedMessageFromBackend):
2496         (WebInspector.dispatchMessageFromBackend): Be consistent about using `this`.
2497
2498 2015-08-25  Matt Baker  <mattbaker@apple.com>
2499
2500         Web Inspector: Rendering Frames pie chart should use the needsLayout/updateLayout idiom
2501         https://bugs.webkit.org/show_bug.cgi?id=148412
2502
2503         Reviewed by Timothy Hatcher.
2504
2505         * UserInterface/Views/ChartDetailsSectionRow.js:
2506         (WebInspector.ChartDetailsSectionRow):
2507         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2508         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius):
2509         Schedule a layout.
2510         (WebInspector.ChartDetailsSectionRow.prototype.set data): Deleted.
2511         Replaced by addItem, setItemValue, and clearItems.
2512         (WebInspector.ChartDetailsSectionRow.prototype.addItem):
2513         (WebInspector.ChartDetailsSectionRow.prototype.setItemValue):
2514         (WebInspector.ChartDetailsSectionRow.prototype.clearItems):
2515         Add/update data points and schedule a layout.
2516         (WebInspector.ChartDetailsSectionRow.prototype._needsLayout):
2517         (WebInspector.ChartDetailsSectionRow.prototype.updateLayout):
2518         Update legend and draw pie chart.
2519         (WebInspector.ChartDetailsSectionRow.prototype._createLegend): Deleted.
2520         Refactored as _updateLegend.
2521         (WebInspector.ChartDetailsSectionRow.prototype._refresh): Deleted.
2522         Refactored as updateLayout.
2523
2524         * UserInterface/Views/TimelineSidebarPanel.js:
2525         (WebInspector.TimelineSidebarPanel):
2526         Add chart data points once.
2527         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
2528         Update chart values.
2529
2530 2015-08-24  Brian Burg  <bburg@apple.com>
2531
2532         Web Inspector: add protocol test for existing error handling performed by the backend
2533         https://bugs.webkit.org/show_bug.cgi?id=147097
2534
2535         Reviewed by Joseph Pecoraro.
2536
2537         Add a way to send raw messages to the backend while still awaiting on responses.
2538         This is necessary to test protocol error handling in the inspector backend.
2539
2540         * UserInterface/Test/InspectorProtocol.js:
2541         (InspectorProtocol.sendCommand):
2542         (InspectorProtocol.awaitCommand): Use awaitMessage internally.
2543         (InspectorProtocol.awaitMessage): Added. Use a dummy requestId if none is supplied.
2544         (InspectorProtocol._sendMessage): Added.
2545         (InspectorProtocol.dispatchMessageFromBackend):
2546         Reject with the error object instead of the error message, so error code/data can be checked.
2547         (InspectorProtocol.sendMessage): Deleted, it is now a private method.
2548
2549 2015-08-24  Timothy Hatcher  <timothy@apple.com>
2550
2551         Web Inspector: Change webkitAnimationEnd use, should be animationEnd
2552         https://bugs.webkit.org/show_bug.cgi?id=148385
2553
2554         Reviewed by Joseph Pecoraro.
2555
2556         * UserInterface/Views/DOMTreeElement.js:
2557         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
2558         * UserInterface/Views/DashboardContainerView.js:
2559         (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
2560         (WebInspector.DashboardContainerView.prototype._showDashboardView):
2561         (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
2562         (WebInspector.DashboardContainerView.prototype._hideDashboardView):
2563         * UserInterface/Views/DefaultDashboardView.js:
2564         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
2565         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
2566         * UserInterface/Views/TextEditor.js:
2567         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
2568         (WebInspector.TextEditor.prototype.revealPosition):
2569         (WebInspector.TextEditor.prototype._revealSearchResult):
2570
2571 2015-08-24  Nikita Vasilyev  <nvasilyev@apple.com>
2572
2573         REGRESSION (r188581): Web Inspector: Console user command isn't visible when it's expected to be
2574         https://bugs.webkit.org/show_bug.cgi?id=148283
2575
2576         One of the improvements of r188581 "Option-Enter should commit console command
2577         without erasing the prompt" was not to show a console user command if it's the
2578         same as the previous one.
2579
2580         However, there could be a lot of other messages between the last two user
2581         commands - console.log, CSS warnings, etc. In that case we should show a console
2582         user command again by resetting _lastCommitted.
2583
2584         Reviewed by Timothy Hatcher.
2585
2586         * UserInterface/Controllers/JavaScriptLogViewController.js:
2587         (WebInspector.JavaScriptLogViewController):
2588         (WebInspector.JavaScriptLogViewController.prototype.startNewSession):
2589         (WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):
2590         Reset _lastCommitted for all messages except for user commands and use command results.
2591
2592 2015-08-24  Matt Baker  <mattbaker@apple.com>
2593
2594         Web Inspector: Rendering Frames filter checkboxes all become checked during recording
2595         https://bugs.webkit.org/show_bug.cgi?id=148375
2596
2597         Reviewed by Timothy Hatcher.
2598
2599         * UserInterface/Views/ChartDetailsSectionRow.js:
2600         (WebInspector.ChartDetailsSectionRow.prototype._createLegend):
2601         Removed incorrect code that forced checked to true.
2602
2603         * UserInterface/Views/TimelineSidebarPanel.js:
2604         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
2605         Persist legend item checkbox state when updating the chart.
2606
2607 2015-08-23  Matt Baker  <mattbaker@apple.com>
2608
2609         Web Inspector: Filtered style not applied to graph elements during timeline recording
2610         https://bugs.webkit.org/show_bug.cgi?id=148339
2611
2612         Reviewed by Brian Burg.
2613
2614         * UserInterface/Views/NavigationSidebarPanel.js:
2615         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2616         Check for hidden state change when applying filters to newly added tree elements.
2617
2618 2015-08-23  Timothy Hatcher  <timothy@apple.com>
2619
2620         Web Inspector: Drop webkit prefixes from animation, keyframes and transform
2621         https://bugs.webkit.org/show_bug.cgi?id=148364
2622
2623         Reviewed by Darin Adler.
2624
2625         * UserInterface/Views/BreakpointTreeElement.css:
2626         (.breakpoint-generic-line-icon .icon > span):
2627         (.data-updated.breakpoint-generic-line-icon .icon > span):
2628         * UserInterface/Views/ColorPicker.css:
2629         (.color-picker > .slider):
2630         * UserInterface/Views/DashboardContainerView.css:
2631         (.toolbar .dashboard):
2632         (.toolbar .dashboard.slide-out-up):
2633         (.toolbar .dashboard.slide-out-down):
2634         (.toolbar .dashboard.slide-in-up):
2635         (.toolbar .dashboard.slide-in-down):
2636         (@keyframes slide-top-edge):
2637         (@keyframes slide-bottom-edge):
2638         (@-webkit-keyframes slide-top-edge): Deleted.
2639         (@-webkit-keyframes slide-bottom-edge): Deleted.
2640         * UserInterface/Views/DebuggerDashboardView.css:
2641         (.dashboard.debugger .navigation-bar .item.button > .glyph):
2642         (@keyframes pulse-pause-button):
2643         (@-webkit-keyframes pulse-pause-button): Deleted.
2644         * UserInterface/Views/DefaultDashboardView.css:
2645         (.toolbar .dashboard.default > .item.pulsing):
2646         (@keyframes console-item-pulse):
2647         (@-webkit-keyframes console-item-pulse): Deleted.
2648         * UserInterface/Views/GoToLineDialog.css:
2649         (.go-to-line-dialog):
2650         * UserInterface/Views/HoverMenu.css:
2651         (.hover-menu):
2652         * UserInterface/Views/IndeterminateProgressSpinner.css:
2653         (@keyframes discrete-spinner):
2654         (.indeterminate-progress-spinner):
2655         (@-webkit-keyframes discrete-spinner): Deleted.
2656         * UserInterface/Views/Main.css:
2657         (.bouncy-highlight):
2658         (@keyframes bouncy-highlight-animation):
2659         (@-webkit-keyframes bouncy-highlight-animation): Deleted.
2660         * UserInterface/Views/ProbeSetDataGrid.css:
2661         (.details-section.probe-set .data-grid tr.revealed.highlighted):
2662         (@keyframes blink-frame-highlight):
2663         (.details-section.probe-set .data-grid > tr.data-updated):
2664         (@keyframes blink-probe-frame):
2665         (@-webkit-keyframes blink-frame-highlight): Deleted.
2666         (@-webkit-keyframes blink-probe-frame): Deleted.
2667         * UserInterface/Views/TextEditor.css:
2668         (.text-editor > .CodeMirror .highlighted):
2669         (@keyframes text-editor-highlight-fadeout):
2670         (.text-editor > .CodeMirror .hovered-expression-highlight):
2671         (@keyframes text-editor-hovered-expression-highlight-fadeout):
2672         (@-webkit-keyframes text-editor-highlight-fadeout): Deleted.
2673         (@-webkit-keyframes text-editor-hovered-expression-highlight-fadeout): Deleted.
2674         * UserInterface/Views/TimelineOverview.css:
2675         (.timeline-overview.frames > .timeline-ruler > .markers > .divider):
2676         (.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right):
2677         (.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right):
2678         * UserInterface/Views/TimelineRuler.css:
2679         (.timeline-ruler > .header > .divider):
2680         (.timeline-ruler > .markers > .divider):
2681         (.timeline-ruler > .markers > .marker):
2682         (.timeline-ruler > .selection-handle.left):
2683         (.timeline-ruler > .selection-handle.right):
2684
2685 2015-08-21  Saam barati  <sbarati@apple.com>
2686
2687         Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements
2688         https://bugs.webkit.org/show_bug.cgi?id=146882
2689
2690         Reviewed by Joseph Pecoraro.
2691
2692         * UserInterface/Controllers/TypeTokenAnnotator.js:
2693         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
2694         * UserInterface/Models/ScriptSyntaxTree.js:
2695         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2696         (WebInspector.ScriptSyntaxTree):
2697
2698 2015-08-21  Joseph Pecoraro  <pecoraro@apple.com>
2699
2700         Web Inspector: WebInspector.domTreeManager.regionLayoutUpdated does not exist
2701         https://bugs.webkit.org/show_bug.cgi?id=148348
2702
2703         Reviewed by Timothy Hatcher.
2704
2705         * UserInterface/Protocol/CSSObserver.js:
2706         (WebInspector.CSSObserver.prototype.regionLayoutUpdated):
2707         Just do the same as the new event name.
2708
2709 2015-08-21  Brian Burg  <bburg@apple.com>
2710
2711         Web Inspector: clean up uses of `new` with zero-argument constructors and factory methods
2712         https://bugs.webkit.org/show_bug.cgi?id=148311
2713
2714         Reviewed by Timothy Hatcher.
2715
2716         * UserInterface/Protocol/InspectorFrontendHostStub.js:
2717         * UserInterface/Views/ClusterContentView.js:
2718         (WebInspector.ClusterContentView):
2719         * UserInterface/Views/ColorPicker.js:
2720         (WebInspector.ColorPicker):
2721         * UserInterface/Views/ContentView.js:
2722         (WebInspector.ContentView.createFromRepresentedObject): This was causing a console assertion
2723         when a breakpoint tree element was selected and the inspector tried to restore the view state
2724         after a reload or back/forward navigation.
2725
2726         * UserInterface/Views/NavigationSidebarPanel.js:
2727         (WebInspector.NavigationSidebarPanel):
2728         * UserInterface/Views/TimelineRecordingContentView.js:
2729         (WebInspector.TimelineRecordingContentView):
2730
2731 2015-08-20  Brian Burg  <bburg@apple.com>
2732
2733         Web Inspector: add a regression test for the fix introduced in r188679
2734         https://bugs.webkit.org/show_bug.cgi?id=148223
2735
2736         Reviewed by Joseph Pecoraro.
2737
2738         Turns out that we were possibly leaking a single DOMTree on reload.
2739         Always clear the main frame's DOMTree as well as those of sub-frames.
2740
2741         * UserInterface/Base/Object.js: Add back single-fire listeners.
2742         (WebInspector.Object.singleFireEventListener.let.wrappedCallback):
2743         (WebInspector.Object.singleFireEventListener):
2744         (WebInspector.Object.retainedObjectsWithPrototype):
2745         (WebInspector.Object.prototype.singleFireEventListener):
2746         (WebInspector.Object.prototype.retainedObjectsWithPrototype):
2747         * UserInterface/Models/Frame.js:
2748         (WebInspector.Frame.prototype.removeAllChildFrames): Clear own tree too.
2749
2750 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
2751
2752         Web Inspector: Better Remember open tab types and order if using JSContext inspector
2753         https://bugs.webkit.org/show_bug.cgi?id=148285
2754
2755         Reviewed by Timothy Hatcher.
2756
2757         * UserInterface/Base/Main.js:
2758         (WebInspector.contentLoaded):
2759         (WebInspector.activateExtraDomains):
2760         Save and restore extra domain related tabs at the expected saved index.
2761
2762         (WebInspector._rememberOpenTabs):
2763         Keep unsupported tab types in the setting so when they are supported they open.
2764
2765         * UserInterface/Base/Utilities.js:
2766         Add a helper for inserting a single object into an array.
2767
2768 2015-08-20  Nikita Vasilyev  <nvasilyev@apple.com>
2769
2770         Web Inspector: inline errors/warnings are taller than the line height
2771         https://bugs.webkit.org/show_bug.cgi?id=148232
2772
2773         Reviewed by Timothy Hatcher.
2774
2775         * UserInterface/Views/SourceCodeTextEditor.css:
2776         (.source-code.text-editor > .CodeMirror .issue-widget.inline):
2777         (.source-code.text-editor > .CodeMirror .issue-widget.inline > .text):
2778
2779 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
2780
2781         JSContext Inspector: Uncaught Exception opening Search Tab
2782         https://bugs.webkit.org/show_bug.cgi?id=148284
2783
2784         Reviewed by Timothy Hatcher.
2785
2786         * UserInterface/Views/SearchSidebarPanel.js:
2787         (WebInspector.SearchSidebarPanel):
2788         This is copied / pasted code that shouldn't apply to the Search tab.
2789         We want to show results under Resources in the Search tab.
2790
2791 2015-08-20  Nikita Vasilyev  <nvasilyev@apple.com>
2792
2793         Web Inspector: Truncate data URIs
2794         https://bugs.webkit.org/show_bug.cgi?id=148212
2795
2796         Reviewed by Timothy Hatcher.
2797
2798         * UserInterface/Base/URLUtilities.js:
2799         (parseURL):
2800         Exit early to avoid an expensive RegExp match on a potentially very large data URI.
2801
2802         (parseQueryString):
2803         Fix typo.
2804
2805         (WebInspector.displayNameForURL):
2806         (WebInspector.truncateURL):
2807         By default, only show first and last 3 characters of data URIs.
2808
2809         * UserInterface/Models/Resource.js:
2810         (WebInspector.Resource.prototype.get displayURL):
2811         For tooltips, show first and last 32 characters of data URIs.
2812
2813         * UserInterface/Models/SourceCodeLocation.js:
2814         (WebInspector.SourceCodeLocation.prototype._locationString):
2815         * UserInterface/Views/ResourceTreeElement.js:
2816         (WebInspector.ResourceTreeElement.prototype._updateToolTip):
2817
2818 2015-08-20  Devin Rousso  <drousso@apple.com>
2819
2820         Web Inspector: Add flex alignment section to Visual sidebar
2821         https://bugs.webkit.org/show_bug.cgi?id=148243
2822
2823         Reviewed by Timothy Hatcher.
2824
2825         Uses select keyword pickers to contain the list of possible values.  Also supports
2826         the upcoming Grid layout keywords in the advanced keyword list.
2827
2828         * Localizations/en.lproj/localizedStrings.js:
2829         * UserInterface/Views/VisualStyleDetailsPanel.js:
2830         (WebInspector.VisualStyleDetailsPanel):
2831         (WebInspector.VisualStyleDetailsPanel.prototype._populateFlexboxSection):
2832         (WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
2833
2834 2015-08-20  Devin Rousso  <drousso@apple.com>
2835
2836         Web Inspector: Labels in the computed panel are shifted when a filter is applieds
2837         https://bugs.webkit.org/show_bug.cgi?id=148250
2838
2839         Reviewed by Timothy Hatcher.
2840
2841         Added to the selectors for filtering to ensure they only apply to the rules panel.
2842
2843         * UserInterface/Views/RulesStyleDetailsPanel.css:
2844         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
2845         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
2846         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
2847         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
2848         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
2849         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
2850         (@media (-webkit-min-device-pixel-ratio: 2)):
2851         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
2852         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
2853         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
2854         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
2855         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
2856         (.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.
2857
2858 2015-08-20  Devin Rousso  <drousso@apple.com>
2859
2860         Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
2861         https://bugs.webkit.org/show_bug.cgi?id=148264
2862
2863         Reviewed by Timothy Hatcher.
2864
2865         * UserInterface/Views/VisualStylePropertyEditorLink.js:
2866         (WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
2867         No longer attempts to set the "hidden" attribute of the link icons before they exist.
2868
2869 2015-08-20  Devin Rousso  <drousso@apple.com>
2870
2871         Web Inspector: Visual editor adds extra spaces to styles with no properties
2872         https://bugs.webkit.org/show_bug.cgi?id=148242
2873
2874         Reviewed by Timothy Hatcher.
2875
2876         * UserInterface/Models/CSSStyleDeclaration.js:
2877         (WebInspector.CSSStyleDeclaration.prototype.set text):
2878         Now trims the text and, if the resulting string has no length or the style is inline,
2879         replaces the text to be set with the trimmed text.
2880
2881         * UserInterface/Views/VisualStylePropertyCombiner.js:
2882         (WebInspector.VisualStylePropertyCombiner.prototype.modifyPropertyText):
2883         Removed unnecessary trim.
2884
2885 2015-08-20  Devin Rousso  <drousso@apple.com>
2886
2887         Web Inspector: Font size between computed and set value is off in visual styles popups
2888         https://bugs.webkit.org/show_bug.cgi?id=148226
2889
2890         Reviewed by Timothy Hatcher.
2891
2892         * UserInterface/Views/VisualStylePropertyEditor.css:
2893         (.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder):
2894         Increased font-size to match the font-size of the overlaid select element.
2895
2896 2015-08-20  Matt Baker  <mattbaker@apple.com>
2897
2898         Web Inspector: Filtered frames shouldn't be selectable in the Rendering Frames overview graph
2899         https://bugs.webkit.org/show_bug.cgi?id=148253
2900
2901         Reviewed by Timothy Hatcher.
2902
2903         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
2904         Check record's filtered state before setting new frame selection.
2905
2906 2015-08-20  Devin Rousso  <drousso@apple.com>
2907
2908         Web Inspector: visual style number inputs don't style the units correctly
2909         https://bugs.webkit.org/show_bug.cgi?id=148222
2910
2911         Reviewed by Timothy Hatcher.
2912
2913         * UserInterface/Views/VisualStyleNumberInputBox.js:
2914         (WebInspector.VisualStyleNumberInputBox.prototype.set value):
2915         Added extra checks to see if the number input has a value when setting the value on the editor.
2916
2917 2015-08-20  Matt Baker  <mattbaker@apple.com>
2918
2919         Web Inspector: Filtered frames should be styled differently in the Rendering Frames overview graph
2920         https://bugs.webkit.org/show_bug.cgi?id=147421
2921
2922         Reviewed by Timothy Hatcher.
2923
2924         * UserInterface/Views/NavigationSidebarPanel.js:
2925         (WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered):
2926         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
2927         Inform derived sidebar of tree element filter state changes.
2928
2929         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
2930         (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.recordWasFiltered):
2931         (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.updateLayout):
2932         Update filtered frame style when a record's state changes, and during layout.
2933
2934         * UserInterface/Views/TimelineOverview.js:
2935         * UserInterface/Views/TimelineOverviewGraph.js:
2936         (WebInspector.TimelineOverviewGraph.prototype.recordWasFiltered):
2937         Allow setting a record's filtered state for a given timeline in the overview.
2938
2939         * UserInterface/Views/TimelineRecordFrame.css:
2940         (.timeline-record-frame.filtered > .frame):
2941         New filtered frame style.
2942
2943         * UserInterface/Views/TimelineRecordFrame.js:
2944         (WebInspector.TimelineRecordFrame.prototype.get filtered):
2945         (WebInspector.TimelineRecordFrame.prototype.set filtered):
2946
2947         * UserInterface/Views/TimelineRecordingContentView.js:
2948         (WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):
2949
2950         * UserInterface/Views/TimelineSidebarPanel.js:
2951         (WebInspector.TimelineSidebarPanel.prototype.representedObjectWasFiltered):
2952         (WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
2953         Apply task filters to RenderingFrameTimelineRecords and their immediate children.
2954
2955 2015-08-20  Brian Burg  <bburg@apple.com>
2956
2957         Web Inspector: console assertion when hitting breakpoint after auto-recording ends
2958         https://bugs.webkit.org/show_bug.cgi?id=148225
2959
2960         Reviewed by Timothy Hatcher.
2961
2962         Add checks for the precondition to starting/stopping time updates.
2963
2964         * UserInterface/Views/TimelineRecordingContentView.js:
2965         (WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
2966         (WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
2967         (WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):
2968
2969 2015-08-19  Brian Burg  <bburg@apple.com>
2970
2971         Web Inspector: add TestHarness option to tee all commands to system console
2972         https://bugs.webkit.org/show_bug.cgi?id=148181
2973
2974         Reviewed by Joseph Pecoraro.
2975
2976         It is currently difficult to trace what's going on when a test times out
2977         on a buildbot instance. The existing option for forcing debug logging can
2978         still drop messages that don't make it from the inspector to the test page.
2979
2980         This patch adds an option which logs all TestHarness commands directly to
2981         stderr in the Inspector instance using InspectorFrontendHost::unbufferedLog.
2982
2983         Clean up how existing harness logging code calls into each other. Extract
2984         the stringifying code that is duplicated everywhere.
2985
2986         * UserInterface/Test.html: Reorganize options and add new option.
2987         * UserInterface/Test/FrontendTestHarness.js:
2988         (FrontendTestHarness.prototype.completeTest):
2989         (FrontendTestHarness.prototype.addResult):
2990         (FrontendTestHarness.prototype.debugLog):
2991         (FrontendTestHarness.prototype.testPageDidLoad):
2992         (FrontendTestHarness.prototype._resendResults):
2993         (FrontendTestHarness):
2994         * UserInterface/Test/ProtocolTestHarness.js:
2995         (ProtocolTestHarness.prototype.completeTest):
2996         (ProtocolTestHarness.prototype.addResult):
2997         (ProtocolTestHarness.prototype.debugLog):
2998         * UserInterface/Test/TestHarness.js:
2999         (TestHarness.prototype.log):
3000         (TestHarness.prototype.assert):
3001         (TestHarness.prototype.expectThat):
3002         (TestHarness.messageAsString):
3003         (TestHarness):
3004         * UserInterface/TestStub.html: Reorganize options and add new option.
3005
3006 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
3007
3008         Web Inspector: Remove unused temporary variable
3009         https://bugs.webkit.org/show_bug.cgi?id=148215
3010
3011         Reviewed by Timothy Hatcher.
3012
3013         * UserInterface/Views/VisualStyleDetailsPanel.js:
3014         (WebInspector.VisualStyleDetailsPanel):
3015
3016 2015-08-19  Devin Rousso  <drousso@apple.com>
3017
3018         Web Inspector: Visual styles panel does not work with pseudo-elements
3019         https://bugs.webkit.org/show_bug.cgi?id=148187
3020
3021         Reviewed by Timothy Hatcher.
3022
3023         If the inline style does not exist, such as for pseudo-elements, default to the first matched rule.
3024
3025         * UserInterface/Views/VisualStyleSelectorSection.js:
3026         (WebInspector.VisualStyleSelectorSection.prototype.update):
3027
3028 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
3029
3030         Web Inspector: DOMTree leaks on main resource changes
3031         https://bugs.webkit.org/show_bug.cgi?id=148158
3032
3033         Reviewed by Timothy Hatcher.
3034
3035         * UserInterface/Models/DOMTree.js:
3036         (WebInspector.DOMTree.prototype.disconnect):
3037         Add a way to disconnect the DOMTree and allow it to get garbage collected.
3038
3039         (WebInspector.DOMTree.prototype.invalidate.performInvalidate):
3040         (WebInspector.DOMTree.prototype.invalidate):
3041         (WebInspector.DOMTree.prototype._requestRootDOMNode):
3042         (WebInspector.DOMTree.prototype._framePageExecutionContextChanged):
3043         Remove some uses of the delete operator.
3044
3045         * UserInterface/Models/Frame.js:
3046         (WebInspector.Frame.prototype.removeChildFrame):
3047         (WebInspector.Frame.prototype.removeAllChildFrames):
3048         (WebInspector.Frame.prototype._detachFromParentFrame):
3049         When a frame gets removed from its parent, disconnect its DOMTree.
3050
3051 2015-08-19  Devin Rousso  <drousso@apple.com>
3052
3053         Web Inspector: The first style in the Rules panel for pseudo-elements needs padding
3054         https://bugs.webkit.org/show_bug.cgi?id=148207
3055
3056         Reviewed by Timothy Hatcher.
3057
3058         * UserInterface/Views/RulesStyleDetailsPanel.css:
3059         (.sidebar > .panel.details.css-style .rules .label:first-child):
3060         If the first element in the Rules panel is a label, add some top padding.
3061
3062 2015-08-19  Devin Rousso  <drousso@apple.com>
3063
3064         Web Inspector: Committing a valid selector in the styles sidebar replaces the new selector with the old one
3065         https://bugs.webkit.org/show_bug.cgi?id=148206
3066
3067         Reviewed by Timothy Hatcher.
3068
3069         * UserInterface/Views/CSSStyleDeclarationSection.js:
3070         (WebInspector.CSSStyleDeclarationSection.prototype._markSelector):
3071         No longer unnecessarily refreshes the section if the selector is valid.
3072
3073 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
3074
3075         Web Inspector: Uncaught Exceptions regarding PseudoElements / TemplateContent
3076         https://bugs.webkit.org/show_bug.cgi?id=148190
3077
3078         Reviewed by Brian Burg.
3079
3080         * UserInterface/Controllers/DOMTreeManager.js:
3081         (WebInspector.DOMTreeManager.prototype._unbind):
3082         Iterate over the values in the map, not the iterator pairs.
3083
3084         * UserInterface/Models/DOMNode.js:
3085         When removing a pseudo element, don't assume this._children
3086         exists, it may be null. So separate the two paths.
3087
3088 2015-08-19  Devin Rousso  <drousso@apple.com>
3089
3090         Web Inspector: long selectors in the visual editor sidebar can overflow
3091         https://bugs.webkit.org/show_bug.cgi?id=148185
3092
3093         Reviewed by Timothy Hatcher.
3094
3095         Selectors in the Visual editor sidebar are now clipped and use ellipses.
3096
3097         * UserInterface/Views/VisualStyleSelectorSection.css:
3098         (.details-section.visual-style-selector-section > .header > .current-selector):
3099         (.details-section.visual-style-selector-section:not(.collapsed) > .content):
3100         (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles):
3101         (.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles > .title): Deleted.
3102
3103         * UserInterface/Views/VisualStyleSelectorTreeItem.css:
3104         (.item.visual-style-selector-item):
3105         (.item.visual-style-selector-item > .titles):
3106         (.item.visual-style-selector-item > input[type="checkbox"]):
3107         (.item.visual-style-selector-item > .icon):
3108
3109 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
3110
3111         Web Inspector: Include Legacy Inspector JSON for iOS 9
3112         https://bugs.webkit.org/show_bug.cgi?id=148200
3113
3114         Reviewed by Timothy Hatcher.
3115
3116         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js: Added.
3117         * Versions/Inspector-iOS-9.0.json: Added.
3118
3119 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
3120
3121         Web Inspector: Update Copyright in minified / combined output
3122         https://bugs.webkit.org/show_bug.cgi?id=148201
3123
3124         Reviewed by Timothy Hatcher.
3125
3126         * Scripts/copy-user-interface-resources.pl:
3127         Include copyright comments from missing 2014 and 2015 contributors
3128         in the comment in the minified / combined Main.js.
3129
3130 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
3131
3132         Web Inspector: Uncaught exception in inspector page while handling event DOMStorage.domStorageItemRemoved
3133         https://bugs.webkit.org/show_bug.cgi?id=148191
3134
3135         Reviewed by Brian Burg.
3136
3137         * UserInterface/Controllers/StorageManager.js:
3138         (WebInspector.StorageManager.prototype.itemsCleared):
3139         (WebInspector.StorageManager.prototype.itemRemoved):
3140         (WebInspector.StorageManager.prototype.itemAdded):
3141         (WebInspector.StorageManager.prototype.itemUpdated):
3142         Check if the DOMStorage for the identifier actually exists.
3143         Due to how the backend emits events, the page may have already
3144         navigated when we get a storage update for the previous page.
3145         In that case, we don't want to create a DOMStorage for the
3146         previous page if it doesn't exist.
3147
3148 2015-08-19  Brian Burg  <bburg@apple.com>
3149
3150         Web Inspector: use unprefixed CSS property 'filter' instead of '-webkit-filter'
3151         https://bugs.webkit.org/show_bug.cgi?id=148186
3152
3153         Reviewed by Dean Jackson.
3154
3155         * UserInterface/Views/BreakpointActionView.css:
3156         (.breakpoint-action-remove-button:active):
3157         * UserInterface/Views/CSSStyleDeclarationSection.css:
3158         (.style-declaration-section:not(.invalid-selector) > .header > .icon.toggle-able:hover):
3159         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
3160         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .invalid-warning-marker.clickable:hover):
3161         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker:hover):
3162         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker:active):
3163         * UserInterface/Views/ChartDetailsSectionRow.css:
3164         (body.window-inactive .details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > label > input[type=checkbox]):
3165         * UserInterface/Views/ChartDetailsSectionRow.js:
3166         (WebInspector.ChartDetailsSectionRow.prototype._addCheckboxColorFilter):
3167         * UserInterface/Views/NewTabContentView.css:
3168         (.new-tab.tab.content-view > .tab-item.disabled):
3169         (.new-tab.tab.content-view > .tab-item:not(.disabled):hover > .box):
3170         (.new-tab.tab.content-view > .tab-item:not(.disabled):active > .box):
3171         * UserInterface/Views/TimelineSidebarPanel.css:
3172         (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
3173         (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
3174         (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:active):
3175         * UserInterface/Views/VisualStyleKeywordIconList.css:
3176         (.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:not(.selected) > div):
3177         * UserInterface/Views/VisualStyleSelectorSection.css:
3178         (.details-section.visual-style-selector-section > .header > .controls > .visual-style-selector-section-add-rule):
3179
3180 2015-08-19  Joseph Pecoraro  <pecoraro@apple.com>
3181
3182         Web Inspector: Uncaught Exception while handling event DOM.pseudoElementRemoved reloading twitter pages
3183         https://bugs.webkit.org/show_bug.cgi?id=148180
3184
3185         Reviewed by Brian Burg.
3186
3187         * UserInterface/Views/DOMTreeElement.js:
3188         (WebInspector.DOMTreeElement.prototype._visibleChildren):
3189         DOMNode.children can be null before it is filled in.
3190
3191 2015-08-19  Brian Burg  <bburg@apple.com>
3192
3193         Web Inspector: InspectorTest should be a subclass of TestHarness
3194         https://bugs.webkit.org/show_bug.cgi?id=148079
3195
3196         Reviewed by Timothy Hatcher.
3197
3198         Extract the frontend test harness into a subclass. Delete some code that
3199         is now redundant. Sprinkle some ES6 syntax where possible.
3200
3201         Rewrite the code that redirects the Inspector page's console messages to
3202         the test page, since it didn't appear to work any more.
3203
3204         * UserInterface/Test.html: Add debug options here, and a wiki link.
3205         * UserInterface/Test/FrontendTestHarness.js: Added.
3206         (FrontendTestHarness):
3207         (FrontendTestHarness.prototype.completeTest):
3208         (FrontendTestHarness.prototype.addResult):
3209         (FrontendTestHarness.prototype.debugLog):
3210         (FrontendTestHarness.prototype.evaluateInPage):
3211         (FrontendTestHarness.prototype.expectNoError):
3212         (FrontendTestHarness.prototype.testPageDidLoad):
3213         (FrontendTestHarness.prototype.reloadPage):
3214         (FrontendTestHarness.prototype.redirectConsoleToTestOutput.createProxyConsoleHandler):
3215         (FrontendTestHarness.prototype.redirectConsoleToTestOutput):
3216         (FrontendTestHarness.prototype.reportUncaughtException):
3217         (FrontendTestHarness.prototype._resendResults):
3218         * UserInterface/Test/Test.js:
3219         (WebInspector.loaded):
3220         (WebInspector.UIString): Arrow it.
3221         (WebInspector.updateDockedState): Arrow it.
3222         (WebInspector.updateDockingAvailability): Arrow it.
3223         (InspectorTest.EventDispatcher.prototype.dispatchEvent): Deleted.
3224         (InspectorTest.EventDispatcher): Deleted.
3225         (InspectorTest.log): Deleted.
3226         (InspectorTest.assert): Deleted.
3227         (InspectorTest.expectThat): Deleted.
3228         (InspectorTest.debugLog): Deleted.
3229         (InspectorTest.expectNoError): Deleted.
3230         (InspectorTest.completeTest): Deleted.
3231         (InspectorTest.evaluateInPage): Deleted.
3232         (InspectorTest.addResult): Deleted.
3233         (InspectorTest._resendResults): Deleted.
3234         (InspectorTest.testPageDidLoad): Deleted.
3235         (InspectorTest.reloadPage): Deleted.
3236         (InspectorTest.reportUncaughtException): Deleted.
3237         * UserInterface/Test/TestSuite.js: Clean an unnecessary self = this.
3238         (SyncTestSuite.prototype.runTestCases):
3239         (SyncTestSuite):
3240         * UserInterface/TestStub.html: Add matching link to wiki.
3241
3242 2015-08-19  Brian Burg  <bburg@apple.com>
3243
3244         Web Inspector: split TestStub.js into multiple files and modernize it
3245         https://bugs.webkit.org/show_bug.cgi?id=148077
3246
3247         Reviewed by Timothy Hatcher.
3248  
3249         Since we want to share files between the two harnesses, split some of the parts
3250         into different files so not everything has to be included at once.
3251
3252         Rename InjectedTestHarness to just TestHarness. Update some code to use
3253         ES6 features where appropriate. Put test classes into Test/ directory.
3254
3255         * UserInterface/Base/TestStub.js: Removed.
3256         * UserInterface/Test.html:
3257         * UserInterface/Test/InspectorProtocol.js: Added.
3258         (InspectorProtocol.sendCommand):
3259         (InspectorProtocol.awaitCommand):
3260         (InspectorProtocol.awaitEvent.):
3261         (InspectorProtocol.awaitEvent):
3262         (InspectorProtocol.addEventListener):
3263         (InspectorProtocol.sendMessage):
3264         (InspectorProtocol.checkForError):
3265         (InspectorProtocol.dispatchMessageFromBackend):
3266         * UserInterface/Test/ProtocolTestHarness.js: Added.
3267         (ProtocolTestHarness.prototype.completeTest):
3268         (ProtocolTestHarness.prototype.addResult):
3269         (ProtocolTestHarness.prototype.debugLog):
3270         (ProtocolTestHarness.prototype.evaluateInPage):
3271         (ProtocolTestHarness):
3272         * UserInterface/Test/Test.js: Renamed from Source/WebInspectorUI/UserInterface/Base/Test.js.
3273         (WebInspector.loaded):
3274         (WebInspector.contentLoaded):
3275         (WebInspector.UIString):
3276         (WebInspector.updateDockedState):
3277         (WebInspector.updateDockingAvailability):
3278         (InspectorTest.EventDispatcher.prototype.dispatchEvent):
3279         (InspectorTest.EventDispatcher):
3280         (InspectorTest.log):
3281         (InspectorTest.assert):
3282         (InspectorTest.expectThat):
3283         (InspectorTest.debugLog):
3284         (InspectorTest.expectNoError):
3285         (InspectorTest.completeTest):
3286         (InspectorTest.evaluateInPage):
3287         (InspectorTest.addResult):
3288         (InspectorTest._resendResults):
3289         (InspectorTest.testPageDidLoad):
3290         (InspectorTest.reloadPage):
3291         (InspectorTest.reportUncaughtException):
3292         * UserInterface/Test/TestHarness.js: Added.
3293         (TestHarness):
3294         (TestHarness.prototype.completeTest):
3295         (TestHarness.prototype.addResult):
3296         (TestHarness.prototype.debugLog):
3297         (TestHarness.prototype.evaluateInPage):
3298         (TestHarness.prototype.createAsyncSuite):
3299         (TestHarness.prototype.createSyncSuite):
3300         (TestHarness.prototype.get logCount):
3301         (TestHarness.prototype.log):
3302         (TestHarness.prototype.assert):
3303         (TestHarness.prototype.expectThat):
3304         * UserInterface/Test/TestStub.js: Added.
3305         * UserInterface/Test/TestSuite.js: Added.
3306         (TestSuite):
3307         (TestSuite.prototype.runTestCasesAndFinish):
3308         (TestSuite.prototype.runTestCases):
3309         (TestSuite.prototype.get passCount):
3310         (TestSuite.prototype.get skipCount):
3311         (TestSuite.prototype.addTestCase):
3312         (AsyncTestSuite.prototype.runTestCasesAndFinish.finish):
3313         (AsyncTestSuite.prototype.runTestCasesAndFinish):
3314         (AsyncTestSuite.prototype.runTestCases):
3315         (AsyncTestSuite):
3316         (SyncTestSuite.prototype.runTestCasesAndFinish):
3317         (SyncTestSuite.prototype.runTestCases):
3318         (SyncTestSuite):
3319         * UserInterface/TestStub.html:
3320
3321 2015-08-19  Nikita Vasilyev  <nvasilyev@apple.com>
3322
3323         Web Inspector: Pressing Command-Enter should re-evaluate selected console user command
3324         https://bugs.webkit.org/show_bug.cgi?id=147918
3325
3326         Reviewed by Timothy Hatcher.
3327
3328         * UserInterface/Views/LogContentView.js:
3329         (WebInspector.LogContentView.prototype._keyDown):
3330         (WebInspector.LogContentView.prototype._commandEnterWasPressed):
3331         Only re-evaluate one selected user command.
3332
3333 2015-08-19  Nikita Vasilyev  <nvasilyev@apple.com>
3334
3335         REGRESSION (r188581): Web Inspector: Console user command isn't visible after reloading the page
3336         https://bugs.webkit.org/show_bug.cgi?id=148166
3337
3338         Reviewed by Timothy Hatcher.
3339
3340         * UserInterface/Controllers/JavaScriptLogViewController.js:
3341         (WebInspector.JavaScriptLogViewController.prototype.startNewSession):
3342
3343 2015-08-19  Nikita Vasilyev  <nvasilyev@apple.com>
3344
3345         REGRESSION (r188581): Web Inspector: Option-Enter no longer inserts a new line in the console
3346         https://bugs.webkit.org/show_bug.cgi?id=148165
3347
3348         Make Option-Enter insert a new line, as it was before r188581.
3349         Make Command-Enter keep executed command in the prompt.
3350
3351         Reviewed by Timothy Hatcher.
3352
3353         * UserInterface/Views/ConsolePrompt.js:
3354         (WebInspector.ConsolePrompt): Deleted.
3355         (WebInspector.ConsolePrompt.prototype._handleCommandEnterKey):
3356         (WebInspector.ConsolePrompt.prototype._handleOptionEnterKey): Deleted.
3357         (WebInspector.ConsolePrompt.prototype._handleCommandOptionEnterKey): Deleted.
3358
3359 2015-08-18  Joseph Pecoraro  <pecoraro@apple.com>
3360
3361         Web Inspector: Links for rules in <style> are incorrect, do not account for <style> offset in the document
3362         https://bugs.webkit.org/show_bug.cgi?id=148141
3363
3364         Reviewed by Brian Burg.
3365
3366         * UserInterface/Controllers/CSSStyleManager.js: