Source/WebInspectorUI/ChangeLog

   1 2015-06-11  Devin Rousso  <drousso@apple.com>
   2
   3         Web Inspector: font-family names interpreted as color
   4         https://bugs.webkit.org/show_bug.cgi?id=123468
   5
   6         Reviewed by Timothy Hatcher.
   7
   8         * UserInterface/Views/CodeMirrorAdditions.js: Added logic to prevent color picker buttons from appearing before colors that come after a quote character (both " and ').
   9
  10 2015-06-11  Matt Baker  <mattbaker@apple.com>
  11
  12         Web Inspector: Rendering Frames timeline should distinguish between layout and painting
  13         https://bugs.webkit.org/show_bug.cgi?id=145856
  14
  15         Reviewed by Timothy Hatcher.
  16
  17         This patch formalizes the runloop task concept in the frontend, adds new Paint task type to the Rendering
  18         Frames timeline, and reorders UI elements such as chart sections and frame "segments" to match the order in
  19         which tasks are executed within the runloop.
  20
  21         We will need to make UI changes to the standard Timelines view in a follow up patch, since tree element icons
  22         for Paint records now use a different color that those of other Layout records.
  23
  24         * UserInterface/Images/TimelineRecordPaint.svg:
  25         Changed to use green color.
  26
  27         * UserInterface/Models/RenderingFrameTimelineRecord.js:
  28         (WebInspector.RenderingFrameTimelineRecord):
  29         (WebInspector.RenderingFrameTimelineRecord.displayNameForTaskType):
  30         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
  31         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.set return):
  32         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask):
  33         (WebInspector.RenderingFrameTimelineRecord.prototype.get durationRemainder): Deleted.
  34         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForRecords.get var): Deleted.
  35         Added TaskType enum to decouple runloop task types from timeline record types, and removed duration remainder
  36         support now that "Other" has an associated task type.
  37
  38         * UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
  39         (WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
  40         (WebInspector.RenderingFrameTimelineDataGridNode.prototype.createCellContent):
  41         * UserInterface/Views/RenderingFrameTimelineView.js:
  42         (WebInspector.RenderingFrameTimelineView):
  43         Added new grid column for Paint task, reordered columns to be consistent with the rest of the UI.
  44
  45         * UserInterface/Views/TimelineRecordFrame.css:
  46         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-script):
  47         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-layout):
  48         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-paint):
  49         (.timeline-record-frame > .frame > .duration): Deleted.
  50         (.timeline-record-frame > .frame > .duration.timeline-record-type-network): Deleted.
  51         (.timeline-record-frame > .frame > .duration.timeline-record-type-layout): Deleted.
  52         (.timeline-record-frame > .frame > .duration.timeline-record-type-script): Deleted.
  53         Updated styles for Render Frame tasks.
  54
  55         * UserInterface/Views/TimelineRecordFrame.js:
  56         (WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
  57         Updated to use Render Frame task types. Frame segment insertion order is now consistent with the rest of the UI.
  58
  59         * UserInterface/Views/TimelineSidebarPanel.js:
  60         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.chartData.Object.keys.map):
  61         (WebInspector.TimelineSidebarPanel.set this):
  62         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.get this):
  63         (WebInspector.TimelineSidebarPanel): Deleted.
  64         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart.durationForRecordType): Deleted.
  65         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart): Deleted.
  66         Updated to use Render Frame task types.
  67
  68 2015-06-11  Matt Baker  <mattbaker@apple.com>
  69
  70         Web Inspector: Wrong overview graph shown after switching from Frames to Timelines
  71         https://bugs.webkit.org/show_bug.cgi?id=145778
  72
  73         Reviewed by Timothy Hatcher.
  74
  75         TimelineSidebarPanel stores a reference to the selected timeline before switching to the Rendering Frames view,
  76         which is used to restore the tree selection, overview graph, and content views when switching back to the
  77         standard Timelines view. However if another recording is created before switching, the previously selected
  78         timeline tracked by the sidebar cannot be restored, since it doesn't belong to the active recording.
  79
  80         This is addressed by storing the previously selected timeline type, rather than the timeline object itself.
  81         The type is also updated whenever the selected timeline in the tree outline changes, ensuring that the correct
  82         timeline will always be restored.
  83
  84         * UserInterface/Views/TimelineSidebarPanel.js:
  85         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
  86         (WebInspector.TimelineSidebarPanel.get else): Deleted.
  87         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if): Deleted.
  88         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject): Deleted.
  89
  90 2015-06-08  Matt Baker  <mattbaker@apple.com>
  91
  92         Web Inspector: Clearing active Timeline recording should stop capturing
  93         https://bugs.webkit.org/show_bug.cgi?id=145767
  94
  95         Reviewed by Joseph Pecoraro.
  96
  97         * UserInterface/Views/TimelineRecordingContentView.js:
  98         (WebInspector.TimelineRecordingContentView.prototype._clearTimeline):
  99         Stop capturing if necessary.
 100
 101 2015-06-07  Tobias Reiss  <tobi+webkit@basecode.de>
 102
 103         Web Inspector: Add PrettyPrinter CSSRule tests
 104         https://bugs.webkit.org/show_bug.cgi?id=145740
 105
 106         Reviewed by Brian Burg.
 107
 108         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon-expected.css: Added.
 109         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon.css: Added.
 110         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma-expected.css: Added.
 111         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma.css: Added.
 112         * Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon-expected.css: Added.
 113         * Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon.css: Added.
 114         * Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed-expected.css: Added.
 115         * Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed.css: Added.
 116         * Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value-expected.css: Added.
 117         * Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value.css: Added.
 118         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon-expected.css: Added.
 119         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon.css: Added.
 120         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment-expected.css: Added.
 121         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment.css: Added.
 122         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property-expected.css: Added.
 123         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property.css: Added.
 124         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property-expected.css: Added.
 125         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property.css: Added.
 126         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property-expected.css: Added.
 127         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property.css: Added.
 128         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon-expected.css: Added.
 129         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon.css: Added.
 130         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment-expected.css: Added.
 131         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment.css: Added.
 132         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property-expected.css: Added.
 133         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property.css: Added.
 134         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property-expected.css: Added.
 135         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property.css: Added.
 136         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property-expected.css: Added.
 137         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property.css: Added.
 138         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment-expected.css: Added.
 139         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment.css: Added.
 140         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property-expected.css: Added.
 141         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property.css: Added.
 142         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property-expected.css: Added.
 143         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property.css: Added.
 144         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property-expected.css: Added.
 145         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property.css: Added.
 146         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment-expected.css: Added.
 147         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment.css: Added.
 148         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property-expected.css: Added.
 149         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property.css: Added.
 150         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property-expected.css: Added.
 151         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property.css: Added.
 152         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property-expected.css: Added.
 153         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property.css: Added.
 154         * Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property-expected.css: Added.
 155         * Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property.css: Added.
 156
 157 2015-06-05  Devin Rousso  <drousso@apple.com>
 158
 159         Web Inspector: Fixing code style and adding more limitations for bug 141262
 160         https://bugs.webkit.org/show_bug.cgi?id=145668
 161
 162         Reviewed by Timothy Hatcher.
 163
 164         * UserInterface/Models/CSSCompletions.js:
 165         (WebInspector.CSSCompletions.prototype.isValidPropertyName): Loops through the full property list and returns true only if a property exactly matches the given property name.
 166         (WebInspector.CSSCompletions): Added isValidPropertyName function.
 167         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
 168         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property and to prevent invalid style from being applied incorrectly.
 169
 170 2015-06-05  Devin Rousso  <drousso@apple.com>
 171
 172         Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections
 173         https://bugs.webkit.org/show_bug.cgi?id=145399
 174
 175         Reviewed by Timothy Hatcher.
 176
 177         * UserInterface/Views/CSSStyleDeclarationSection.js:
 178         (WebInspector.CSSStyleDeclarationSection): Added delegate variable to constructor.
 179         (WebInspector.CSSStyleDeclarationSection.prototype.clearSelection):
 180         (WebInspector.CSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorFocused):
 181         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
 182         (WebInspector.CSSStyleDeclarationTextEditor): Added event listener to codeMirror on "focus".
 183         (WebInspector.CSSStyleDeclarationTextEditor.prototype.clearSelection): Sets the cursor of the codeMirror to character 0 on line 0.
 184         (WebInspector.CSSStyleDeclarationTextEditor.prototype._editorFocused): Function that calls the delegate function "editorFocused" when the codeMirror is focused
 185         * UserInterface/Views/RulesStyleDetailsPanel.js:
 186         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
 187         (WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorFocused): Loops through all sections except for the ignoredSection (parameter) and clears the selected text in each of them.
 188
 189 2015-06-05  Joseph Pecoraro  <pecoraro@apple.com>
 190
 191         REGRESSION (r185213): TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value')
 192         https://bugs.webkit.org/show_bug.cgi?id=145695
 193
 194         Reviewed by Mark Lam.
 195
 196         Move and rename the clear log on reload setting property from
 197         WebInspector (Main.js) to LogManager (shared with tests).
 198
 199         * UserInterface/Base/Main.js:
 200         (WebInspector.loaded): Deleted.
 201         * UserInterface/Controllers/LogManager.js:
 202         (WebInspector.LogManager):
 203         (WebInspector.LogManager.prototype._delayedMessagesCleared):
 204         * UserInterface/Views/LogContentView.js:
 205         (WebInspector.LogContentView.prototype._sessionStarted):
 206         (WebInspector.LogContentView.prototype._handleContextMenuEvent):
 207         (WebInspector.LogContentView.prototype._toggleClearLogOnReloadSetting):
 208
 209 2015-06-05  Nikita Vasilyev  <nvasilyev@apple.com>
 210
 211         Web Inspector: [REGRESSION] Dashboard's resource count does not reset when main resource navigates
 212         https://bugs.webkit.org/show_bug.cgi?id=144553
 213
 214         Add missing _mainResourceDidChange, which was removed after switching to the tabs UI.
 215
 216         Reviewed by Timothy Hatcher.
 217
 218         * UserInterface/Models/DefaultDashboard.js:
 219         (WebInspector.DefaultDashboard):
 220         _waitingForFirstMainResourceToStartTrackingSize is not used anywhere, remove it.
 221
 222         (WebInspector.DefaultDashboard.prototype._mainResourceDidChange): Added.
 223
 224         (WebInspector.DefaultDashboard.prototype._resourceSizeDidChange): Removed.
 225         Unused.
 226
 227 2015-06-05  Matt Baker  <mattbaker@apple.com>
 228
 229         Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
 230         https://bugs.webkit.org/show_bug.cgi?id=145671
 231
 232         Reviewed by Timothy Hatcher.
 233
 234         * Localizations/en.lproj/localizedStrings.js:
 235         "Idle" string no longer used.
 236
 237         * UserInterface/Views/TimelineRecordFrame.js:
 238         Reduced maximum frame width by 2px.
 239
 240         * UserInterface/Views/TimelineSidebarPanel.js:
 241         (WebInspector.TimelineSidebarPanel):
 242         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
 243         Added inner radius to chart and removed "Idle" value.
 244
 245 2015-06-04  Joseph Pecoraro  <pecoraro@apple.com>
 246
 247         Web Inspector: Class constructor appearing as Object Tree property does not include parameters
 248         https://bugs.webkit.org/show_bug.cgi?id=145661
 249
 250         Reviewed by Timothy Hatcher.
 251
 252         * UserInterface/Protocol/RemoteObject.js:
 253         (WebInspector.RemoteObject):
 254         (WebInspector.RemoteObject.fromPrimitiveValue):
 255         (WebInspector.RemoteObject.fromPayload):
 256         (WebInspector.RemoteObject.prototype.get functionDescription):
 257         Include the className as only use it for "class" types to override
 258         the normal description string. Stash the actual function description
 259         in a property we can access later.
 260
 261         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
 262         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
 263         Even if this property is a "class" we want to specifically parse it's
 264         function description string. So use functionDescription.
 265
 266 2015-06-04  Nikita Vasilyev  <nvasilyev@apple.com>
 267
 268         Web Inspector: Close and open tabs on mouseup, not mousedown
 269         https://bugs.webkit.org/show_bug.cgi?id=145656
 270
 271         Match Safari's behaviour.
 272
 273         Reviewed by Timothy Hatcher.
 274
 275         * UserInterface/Views/TabBar.js:
 276         (WebInspector.TabBar):
 277         (WebInspector.TabBar.prototype.set newTabItem):
 278         (WebInspector.TabBar.prototype._handleMouseDown):
 279         (WebInspector.TabBar.prototype._handleClick): Added.
 280         (WebInspector.TabBar.prototype._handleMouseUp):
 281         (WebInspector.TabBar.prototype._handleNewTabClick): Added.
 282         (WebInspector.TabBar.prototype._handleMouseMoved):
 283
 284 2015-06-04  Nikita Vasilyev  <nvasilyev@apple.com>
 285
 286         Web Inspector: Decrease tabs height to match Safari's tabs height
 287         https://bugs.webkit.org/show_bug.cgi?id=145647
 288
 289         Reviewed by Timothy Hatcher.
 290
 291         * UserInterface/Views/TabBar.css:
 292         (.tab-bar):
 293
 294 2015-06-04  Tobias Reiss  <tobi+webkit@basecode.de>
 295
 296         Web Inspector: Activity Viewer does not update on "Clear Log on reload"
 297         https://bugs.webkit.org/show_bug.cgi?id=145466
 298
 299         Reviewed by Joseph Pecoraro.
 300
 301         1. Isolate logic within LogManager and remove hacks/logic from all other files
 302         2. Within LogManager: Differentiate "messagesCleared" calls
 303          a) that happen as a result of a "requested clear" by Frontend (e.g. Button)
 304          b) that happen on page reload and install "clear/keep-on-page-reload" logic
 305          c) that happen on frame navigated, console.clear() or clear()
 306         3. Unify "ActiveLogCleared" and "Cleared" events to "Cleared"
 307
 308         For step 2b and 2c it is important to delay the handling and wait until
 309         "_mainResourceDidChange" has determined whether a page reload happened or
 310         not.
 311
 312         * UserInterface/Base/Main.js:
 313         (WebInspector.loaded):
 314         Store "clear-log-on-reload" setting globally.
 315
 316         * UserInterface/Controllers/IssueManager.js:
 317         (WebInspector.IssueManager):
 318         * UserInterface/Models/DefaultDashboard.js:
 319         (WebInspector.DefaultDashboard): Deleted.
 320         * UserInterface/Views/ObjectTreeView.js:
 321         (WebInspector.ObjectTreeView.prototype._trackWeakEntries): Deleted.
 322         (WebInspector.ObjectTreeView.prototype._untrackWeakEntries): Deleted.
 323         (WebInspector.ObjectTreeView): Deleted.
 324         Remove deleted events.
 325
 326         * UserInterface/Controllers/JavaScriptLogViewController.js:
 327         (WebInspector.JavaScriptLogViewController.prototype._handleClearShortcut):
 328         (WebInspector.JavaScriptLogViewController.prototype.clear): Deleted.
 329         Remove delegate function call and call LogManager directly.
 330
 331         * UserInterface/Controllers/LogManager.js:
 332         (WebInspector.LogManager):
 333         (WebInspector.LogManager.prototype.messagesCleared):
 334         (WebInspector.LogManager.prototype._delayedMessagesCleared):
 335         (WebInspector.LogManager.prototype.requestClearMessages):
 336         (WebInspector.LogManager.prototype._mainResourceDidChange):
 337         Isolate "clear log" logic, especially clear/keep-log-on-reload logic.
 338
 339         * UserInterface/Views/LogContentView.js:
 340         (WebInspector.LogContentView):
 341         (WebInspector.LogContentView.prototype._sessionStarted):
 342         (WebInspector.LogContentView.prototype._handleContextMenuEvent):
 343         (WebInspector.LogContentView.prototype._logCleared):
 344         (WebInspector.LogContentView.prototype._toggleClearLogOnReloadSetting):
 345         (WebInspector.LogContentView.prototype._clearLog):
 346         (WebInspector.LogContentView.prototype.didClearMessages): Deleted.
 347         (WebInspector.LogContentView.prototype._sessionsCleared): Deleted.
 348         (WebInspector.LogContentView.prototype._activeLogCleared): Deleted.
 349         (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages): Deleted.
 350         Make it a consumer of LogManager and remove special hacks. Simplify code.
 351
 352 2015-06-03  Devin Rousso  <drousso@apple.com>
 353
 354         Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value
 355         https://bugs.webkit.org/show_bug.cgi?id=141262
 356
 357         Reviewed by Timothy Hatcher.
 358
 359         * UserInterface/Models/CSSCompletions.js:
 360         (WebInspector.CSSCompletions.prototype.nameMatchesValidPropertyExactly): Loops through the full property list and returns true only if a property exactly matches the given property name.
 361         (WebInspector.CSSCompletions): Added nameMatchesValidPropertyExactly function.
 362         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
 363         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property.
 364
 365 2015-06-03  Nikita Vasilyev  <nvasilyev@apple.com>
 366
 367         Web Inspector: Search field bottom border doesn't match the rest of the toolbar
 368         https://bugs.webkit.org/show_bug.cgi?id=145611
 369
 370         Reviewed by Timothy Hatcher.
 371
 372         * UserInterface/Views/Toolbar.css:
 373         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
 374
 375 2015-06-03  Joseph Pecoraro  <pecoraro@apple.com>
 376
 377         Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar
 378         https://bugs.webkit.org/show_bug.cgi?id=145589
 379
 380         Reviewed by Timothy Hatcher.
 381
 382         * UserInterface/Views/NavigationBar.js:
 383         (WebInspector.NavigationBar.prototype._mouseDown):
 384         (WebInspector.NavigationBar.prototype._mouseUp):
 385         When mouse dragging for navigation bars, only match against navigation
 386         bar items inside this navigation bar. Also, fix horizontal detection
 387         of navigation bar items by scanning in the middle of the navigation
 388         bar instead of the top, which missed the items.
 389
 390 2015-06-03  Joseph Pecoraro  <pecoraro@apple.com>
 391
 392         Web Inspector: Debugger Popover for Node object should have go-to-arrow to show the node in DOM tree
 393         https://bugs.webkit.org/show_bug.cgi?id=145594
 394
 395         Reviewed by Timothy Hatcher.
 396
 397         * UserInterface/Controllers/DOMTreeManager.js:
 398         (WebInspector.DOMTreeManager.prototype.inspectElement):
 399         Previously we could get an exception later on if we tried to
 400         inspect an element that was not in the DOM. Bail if the node
 401         is not in the DOM or not.
 402
 403         * UserInterface/Views/SourceCodeTextEditor.css:
 404         (.popover .debugger-popover-content > .title > .go-to-arrow):
 405         * UserInterface/Views/SourceCodeTextEditor.js:
 406         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject.data.pushNodeToFrontend):
 407         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
 408         For a node type, add a go-to-arrow in the popover if it is in the DOM or not.
 409
 410 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
 411
 412         Web Inspector: Remove uses of delete in Sidebar related code
 413         https://bugs.webkit.org/show_bug.cgi?id=145592
 414
 415         Reviewed by Timothy Hatcher.
 416
 417         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
 418         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
 419         Clear value instead of deleting.
 420
 421         * UserInterface/Views/SearchSidebarPanel.js:
 422         (WebInspector.SearchSidebarPanel.prototype.performSearch):
 423         Just clear the search identifier. Also assert it (a required string) is always non-falsey.
 424
 425         * UserInterface/Views/Sidebar.js:
 426         (WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
 427         This entire callback is unnecessary because whenever we start
 428         a drag we save the value.
 429
 430 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
 431
 432         Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
 433         https://bugs.webkit.org/show_bug.cgi?id=145591
 434
 435         Reviewed by Timothy Hatcher.
 436
 437         * UserInterface/Views/Sidebar.js:
 438         (WebInspector.Sidebar.prototype.removeSidebarPanel):
 439         When removing a sidebar panel, ensure we call hidden if it was the visible panel.
 440
 441         * UserInterface/Views/SidebarPanel.js:
 442         (WebInspector.SidebarPanel):
 443         (WebInspector.SidebarPanel.prototype.shown):
 444         (WebInspector.SidebarPanel.prototype.hidden):
 445         Save and restore content element scroll position when sidebar panels are shown / hidden.
 446
 447         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
 448         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):
 449         * UserInterface/Views/ComputedStyleDetailsPanel.js:
 450         (WebInspector.ComputedStyleDetailsPanel.prototype.shown):
 451         * UserInterface/Views/DetailsSidebarPanel.js:
 452         (WebInspector.DetailsSidebarPanel.prototype.shown):
 453         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
 454         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
 455         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.hidden):
 456         Cleanup. Since sidebar panels are using ES6 classes, have super class calls use `super`!
 457
 458 2015-06-02  Nikita Vasilyev  <nvasilyev@apple.com>
 459
 460         Web Inspector: Use non-monospace font for the frame selector
 461         https://bugs.webkit.org/show_bug.cgi?id=145586
 462
 463         Reviewed by Timothy Hatcher.
 464
 465         * UserInterface/Views/HierarchicalPathComponent.css:
 466         (.hierarchical-path-component):
 467
 468 2015-06-02  Nikita Vasilyev  <nvasilyev@apple.com>
 469
 470         Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
 471         https://bugs.webkit.org/show_bug.cgi?id=145540
 472
 473         Also, increase clickable area of the arrow icon.
 474
 475         Reviewed by Timothy Hatcher.
 476
 477         * UserInterface/Views/DashboardContainerView.css:
 478         (.dashboard-container .advance-arrow):
 479         (.dashboard-container .advance-arrow.advance-forward):
 480         (.dashboard-container .advance-arrow.advance-backward):
 481         * UserInterface/Views/DebuggerDashboardView.css:
 482         (.dashboard.debugger > .location):
 483         (.toolbar .dashboard.debugger):
 484         Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.
 485
 486 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
 487
 488         Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
 489         https://bugs.webkit.org/show_bug.cgi?id=145562
 490
 491         Reviewed by Timothy Hatcher.
 492
 493         * UserInterface/Views/TabBrowser.js:
 494         (WebInspector.TabBrowser):
 495         Only these keyboard shortcuts should check if we are in an editable field.
 496         Remove the implicit prevent default so they can fall back to system behavior
 497         if necessary.
 498
 499         (WebInspector.TabBrowser.prototype._showNextTabCheckingForEditableField):
 500         (WebInspector.TabBrowser.prototype._showPreviousTabCheckingForEditableField):
 501         Bail if we are in an editable field. Otherwise perform the action and prevent default.
 502
 503 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
 504
 505         Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
 506         https://bugs.webkit.org/show_bug.cgi?id=145546
 507
 508         Reviewed by Timothy Hatcher.
 509
 510         Scope ContentBrowser keyboard events within the ContentBrowser instead
 511         of global, where they might conflict between ContentBrowsers. The scoped
 512         shortcuts now no longer need to be enabled/disabled.
 513
 514         * UserInterface/Views/ContentBrowser.js:
 515         (WebInspector.ContentBrowser):
 516         Scope the keyboard shortcuts.
 517
 518         (WebInspector.ContentBrowser.prototype.shown):
 519         (WebInspector.ContentBrowser.prototype.hidden):
 520         No longer need to control enabling / disabling these non-global shortcuts.
 521
 522 2015-06-01  Jono Wells  <jonowells@apple.com>
 523
 524         Web Inspector: Type token text descenders touch bottom of container
 525         https://bugs.webkit.org/show_bug.cgi?id=145544
 526
 527         Reviewed by Timothy Hatcher.
 528
 529         Move 1px padding from top to bottom of token.
 530
 531         * UserInterface/Views/TypeTokenView.css:
 532         (.type-token):
 533
 534 2015-06-01  Joseph Pecoraro  <pecoraro@apple.com>
 535
 536         Web Inspector: Better handle keyboard events in the quick console prompt
 537         https://bugs.webkit.org/show_bug.cgi?id=145548
 538
 539         Reviewed by Timothy Hatcher.
 540
 541         * UserInterface/Base/Main.js:
 542         (WebInspector.saveDataToFile):
 543         Move generic InspectorFrontendHost code here.
 544
 545         * UserInterface/Views/ContentBrowser.js:
 546         (WebInspector.ContentBrowser.prototype._save):
 547         (WebInspector.ContentBrowser.prototype._saveAs):
 548         (WebInspector.ContentBrowser.prototype._saveDataToFile): Deleted.
 549         Use the generic save code.
 550
 551         * UserInterface/Controllers/JavaScriptLogViewController.js:
 552         (WebInspector.JavaScriptLogViewController):
 553         (WebInspector.JavaScriptLogViewController.prototype._save):
 554         (WebInspector.JavaScriptLogViewController.prototype._saveAs):
 555         Handle save keyboard shortcuts while the prompt is focused.
 556
 557         * UserInterface/Views/LogContentView.js:
 558         (WebInspector.LogContentView.prototype.focusSearchBar):
 559         (WebInspector.LogContentView.prototype.save):
 560         (WebInspector.LogContentView.prototype.saveAs):
 561         Better handle keyboard shortcut cases in the console prompt for cases
 562         like a collapsed or split console view.
 563
 564 2015-06-01  Nikita Vasilyev  <nvasilyev@apple.com>
 565
 566         Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned
 567         https://bugs.webkit.org/show_bug.cgi?id=145534
 568
 569         Reviewed by Timothy Hatcher.
 570
 571         * UserInterface/Views/ButtonNavigationItem.css:
 572         (.navigation-bar .item.button.suppress-emboss):
 573         Never show borders for the pause/resume button.
 574
 575         * UserInterface/Views/DebuggerDashboardView.css:
 576         (.dashboard.debugger .navigation-bar .item.button):
 577
 578 2015-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
 579
 580         Web Inspector: Drop forEach from WeakMap / WeakSet native member function maps
 581         https://bugs.webkit.org/show_bug.cgi?id=145497
 582
 583         Reviewed by Sam Weinig.
 584
 585         WeakMap / WeakSet don't have forEach method.
 586         This patch drops it from the native prototype function parameters map.
 587
 588         * UserInterface/Models/NativeFunctionParameters.js:
 589
 590 2015-05-29  Timothy Hatcher  <timothy@apple.com>
 591
 592         Web Inspector: Resources tab navigation sidebar should have a type filter header
 593         https://bugs.webkit.org/show_bug.cgi?id=145474
 594
 595         Reviewed by Joseph Pecoraro.
 596
 597         * Localizations/en.lproj/localizedStrings.js: Updated.
 598
 599         * UserInterface/Images/UpDownArrows.svg: Make styleable.
 600
 601         * UserInterface/Main.html: Added new files.
 602
 603         * UserInterface/Views/LogContentView.js:
 604         (WebInspector.LogContentView): Drive-by fix. Mark All as exclusive.
 605
 606         * UserInterface/Views/MultipleScopeBarItem.js: Added.
 607         (WebInspector.MultipleScopeBarItem):
 608         (WebInspector.MultipleScopeBarItem.prototype.get element):
 609         (WebInspector.MultipleScopeBarItem.prototype.get exclusive):
 610         (WebInspector.MultipleScopeBarItem.prototype.get scopeBarItems):
 611         (WebInspector.MultipleScopeBarItem.set scopeBarItems.createOption):
 612         (WebInspector.MultipleScopeBarItem.prototype.set scopeBarItems):
 613         (WebInspector.MultipleScopeBarItem.prototype.get selected):
 614         (WebInspector.MultipleScopeBarItem.prototype.set selected):
 615         (WebInspector.MultipleScopeBarItem.prototype.get selectedScopeBarItem):
 616         (WebInspector.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
 617         (WebInspector.MultipleScopeBarItem.prototype._clicked):
 618         (WebInspector.MultipleScopeBarItem.prototype._selectElementSelectionChanged):
 619         (WebInspector.MultipleScopeBarItem.prototype._itemSelectionDidChange):
 620
 621         * UserInterface/Views/NavigationSidebarPanel.js:
 622         (WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):
 623         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
 624         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.makeVisible):
 625         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
 626         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
 627         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
 628         Improve filtering so non-text filters can choose to auto-expand the tree.
 629
 630         * UserInterface/Views/ResourceSidebarPanel.css: Added.
 631         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
 632         (.sidebar > .panel.navigation.resource > .navigation-bar):
 633
 634         * UserInterface/Views/ResourceSidebarPanel.js:
 635         (WebInspector.ResourceSidebarPanel):
 636         (WebInspector.ResourceSidebarPanel.prototype.hasCustomFilters):
 637         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
 638         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
 639         (WebInspector.ResourceSidebarPanel.prototype._scopeBarSelectionDidChange):
 640         Make a ScopeBar and make it filter the TreeOutline when needed.
 641
 642         * UserInterface/Views/ScopeBar.css:
 643         (.scope-bar > li.multiple):
 644         (.scope-bar > li.multiple > select):
 645         (.scope-bar > li.multiple.selected > select):
 646         (.scope-bar > li.multiple > .arrows):
 647         (.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows svg .filled):
 648         (.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows svg .stroked):
 649
 650         * UserInterface/Views/ScopeBar.js:
 651         (WebInspector.ScopeBar): Support shouldGroupNonExclusiveItems which will use MultipleScopeBarItem.
 652         (WebInspector.ScopeBar.prototype._populate):
 653         (WebInspector.ScopeBar.prototype._itemSelectionDidChange):
 654         (WebInspector.ScopeBar.prototype.updateLayout): Deleted. Not needed for our current styles.
 655
 656         * UserInterface/Views/ScopeBarItem.js:
 657         (WebInspector.ScopeBarItem):
 658         (WebInspector.ScopeBarItem.prototype.get id):
 659         (WebInspector.ScopeBarItem.prototype.get label):
 660         (WebInspector.ScopeBarItem.prototype.get exclusive):
 661         (WebInspector.ScopeBarItem.prototype.setSelected):
 662         (WebInspector.ScopeBarItem.prototype._clicked):
 663         (WebInspector.ScopeBarItem.prototype.get element): Deleted.
 664         (WebInspector.ScopeBarItem.prototype._markElementSelected): Deleted.
 665         Cleaned up and modernized a bit.
 666
 667 2015-05-29  Tobias Reiss  <tobi+webkit@basecode.de>
 668
 669         Web Inspector: Activity Viewer does not update on "clear all console messages"
 670         https://bugs.webkit.org/show_bug.cgi?id=144681
 671
 672         Reviewed by Joseph Pecoraro.
 673
 674         Do not apply "ignoreDidClearMessages" hack on "Clear log" Button and Context menu.
 675
 676         * UserInterface/Views/LogContentView.js:
 677         (WebInspector.LogContentView.prototype._sessionStarted):
 678         (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages):
 679         (WebInspector.LogContentView.prototype._clearLog): Deleted.
 680
 681 2015-05-29  Matt Baker  <mattbaker@apple.com>
 682
 683         Web Inspector: Remove unused expandTreeElementsWhenArrowing property from TreeOutline
 684         https://bugs.webkit.org/show_bug.cgi?id=145470
 685
 686         Reviewed by Joseph Pecoraro.
 687
 688         * UserInterface/Views/TreeOutline.js:
 689         (WebInspector.TreeOutline.prototype._treeKeyDown):
 690         Replaced uses of removed property with boolean literal.
 691
 692 2015-05-29  Joseph Pecoraro  <pecoraro@apple.com>
 693
 694         Web Inspector: Tabs should have Context Menus
 695         https://bugs.webkit.org/show_bug.cgi?id=144208
 696
 697         Reviewed by Timothy Hatcher.
 698
 699         Give non-pinned tabs "Close Tab" and "Close Other Tabs" context
 700         menu items to affect other non-pinned tabs.
 701
 702         * Localizations/en.lproj/localizedStrings.js:
 703         * UserInterface/Views/TabBarItem.js:
 704         (WebInspector.TabBarItem):
 705         (WebInspector.TabBarItem.prototype._handleContextMenuEvent.closeTab):
 706         (WebInspector.TabBarItem.prototype._handleContextMenuEvent.closeOtherTabs):
 707         (WebInspector.TabBarItem.prototype._handleContextMenuEvent):
 708
 709 2015-05-29  Matt Baker  <mattbaker@apple.com>
 710
 711         Web Inspector: Restoring the last selected DOM node fails on reload (DOMAgent: No node with given path found)
 712         https://bugs.webkit.org/show_bug.cgi?id=144231
 713
 714         Reviewed by Timothy Hatcher.
 715
 716         Removed _restoreSelectedNodeIsAllowed flag from DOMTreeContentView. The frontend receives two documentUpdated
 717         events from the DOM Agent during page reload, and the flag was preventing DOMTreeContentView from restoring
 718         the previous selection in response to the second event.
 719
 720         * UserInterface/Views/DOMTreeContentView.js:
 721         (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
 722         (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
 723
 724 2015-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
 725
 726         Web Inspector: Update toolbar styles
 727         https://bugs.webkit.org/show_bug.cgi?id=145419
 728
 729         Also, use hairline borders (1 phisical pixel) on retina (DPI >= 2).
 730
 731         Reviewed by Timothy Hatcher.
 732
 733         * UserInterface/Views/ButtonToolbarItem.css:
 734         (.toolbar .item.button): Deleted.
 735         (.toolbar.icon-and-label-vertical .item.button): Deleted.
 736         (.toolbar.icon-and-label-horizontal .item.button): Deleted.
 737         (.toolbar .item.button > .glyph): Deleted.
 738         (.toolbar.small-size .item.button > .glyph): Deleted.
 739         * UserInterface/Views/DashboardContainerView.css:
 740         (.toolbar .dashboard-container): Deleted.
 741         (.toolbar.collapsed .dashboard-container): Deleted.
 742         (.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
 743         (.toolbar .dashboard.slide-out-down): Deleted.
 744         (.toolbar .dashboard.slide-in-up): Deleted.
 745         * UserInterface/Views/Toolbar.css:
 746         (.toolbar .search-bar > input[type="search"]):
 747         (.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
 748         (body:not(.unknown-mac) .toolbar .dashboard-container):
 749         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
 750         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus):
 751         (body:not(.unknown-mac) .toolbar .item.button:active):
 752         (body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
 753         (body.unknown-mac .toolbar .dashboard-container):
 754         (body.unknown-mac .toolbar .search-bar > input[type="search"]):
 755         (body.unknown-mac .toolbar .search-bar > input[type="search"]:focus):
 756         (@media (-webkit-min-device-pixel-ratio: 2)):
 757         (body.unknown-mac .toolbar .item.button:active):
 758         (body.unknown-mac.window-inactive .toolbar .dashboard-container):
 759
 760 2015-05-28  Devin Rousso  <drousso@apple.com>
 761
 762         Web Inspector: Jump from a computed style to the rule it came from
 763         https://bugs.webkit.org/show_bug.cgi?id=120640
 764
 765         Reviewed by Timothy Hatcher.
 766
 767         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
 768         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
 769         If the delegate of CSSStyleDeclarationTextEditor has cssStyleDeclarationTextEditorShouldAddPropertyGoToArrows set to true, add a goToArrow to all CSS property entries.
 770         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty.propertiesMatch):
 771         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty.hasMatchingLonghandProperty):
 772         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty):
 773         Determines if a given CSS property is in the CSS style section and if so, select that CSS property, focus on the section containing that CSS property, and return true.
 774         * UserInterface/Views/CSSStyleDeclarationSection.js:
 775         (WebInspector.CSSStyleDeclarationSection.prototype.highlightProperty):
 776         Searches through the properties of the section for a given property and scrolls to it if found.
 777         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
 778         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
 779         Switches to the rulesStyleDetailsPanel and scrolls to and hightlights a given property in that panel.
 780         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
 781         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels):
 782         Moved this function out of _navigationItemSelected for better reusablity.
 783         * UserInterface/Views/ComputedStyleDetailsPanel.js:
 784         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
 785         Function that calls the delegate (which should be CSSStyleDetailsSidebarPanel) function computedStyleDetailsPanelShowProperty.
 786         * UserInterface/Views/RulesStyleDetailsPanel.js:
 787         (WebInspector.RulesStyleDetailsPanel):
 788         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
 789         (WebInspector.RulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
 790         Searches through all the sections of the RulesStyleDetailsPanel for a given CSS property.
 791         (WebInspector.RulesStyleDetailsPanel.prototype.shown):
 792         (WebInspector.RulesStyleDetailsPanel.prototype.hidden):
 793         (WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
 794         Added a flag to this function that will highlight and scroll to a given property (_propertyToSelectAndHighlight) if set on load.
 795         * UserInterface/Views/StyleDetailsPanel.js:
 796         (WebInspector.StyleDetailsPanel.prototype.markAsNeedsRefresh):
 797         (WebInspector.StyleDetailsPanel.prototype.nodeStylesRefreshed):
 798         Made into protected function to allow it to be overridden.
 799         (WebInspector.StyleDetailsPanel.prototype._nodeStylesRefreshed): Deleted.
 800
 801 2015-05-28  Joseph Pecoraro  <pecoraro@apple.com>
 802
 803         Web Inspector: Should have a keyboard shortcut to switch between inspector tabs
 804         https://bugs.webkit.org/show_bug.cgi?id=144207
 805
 806         Reviewed by Timothy Hatcher.
 807
 808         These keyboard shortcuts work well in an undocked inspector window.
 809         Be careful that some keyboard shortcuts, when used inside a text
 810         editor / text field are just text actions. However, some keyboard
 811         shortcuts will work no matter where you trigger them.
 812
 813         * UserInterface/Models/KeyboardShortcut.js:
 814         * UserInterface/Views/TabBar.js:
 815         (WebInspector.TabBar.prototype.selectPreviousTab):
 816         (WebInspector.TabBar.prototype.selectNextTab):
 817         * UserInterface/Views/TabBrowser.js:
 818         (WebInspector.TabBrowser):
 819         (WebInspector.TabBrowser.prototype._showPreviousTab):
 820         (WebInspector.TabBrowser.prototype._showNextTab):
 821
 822 2015-05-28  Joseph Pecoraro  <pecoraro@apple.com>
 823
 824         Web Inspector: NewTabContentView should update button disabled state as other tabs are added/removed
 825         https://bugs.webkit.org/show_bug.cgi?id=145448
 826
 827         Reviewed by Timothy Hatcher.
 828
 829         * UserInterface/Views/NewTabContentView.js:
 830         (WebInspector.NewTabContentView):
 831         Always add a click listener and add the type as a private property on the element.
 832
 833         (WebInspector.NewTabContentView.prototype.shown):
 834         (WebInspector.NewTabContentView.prototype.hidden):
 835         Add / remove event listeners for tab changes. Also update the view when shown.
 836
 837         (WebInspector.NewTabContentView.prototype._createNewTab):
 838         A disabled button an now be clicked. Do nothing if a new tab of this type is not allowed.
 839
 840         (WebInspector.NewTabContentView.prototype._updateTabItems):
 841         Refresh the disabled state for each of the buttons.
 842
 843 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
 844
 845         Web Inspector: Show Page Source does not switch to Resources tab if inspector was closed
 846         https://bugs.webkit.org/show_bug.cgi?id=145423
 847
 848         Reviewed by Timothy Hatcher.
 849
 850         * UserInterface/Base/Main.js:
 851         (WebInspector._frameWasAdded.delayedWork):
 852         (WebInspector._frameWasAdded):
 853         In the special case where we are holding to show a frame's source code when
 854         the frame becomes available (_frameIdentifierToShowSourceCodeWhenAvailable)
 855         we should be forcing to show the tab.
 856
 857 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
 858
 859         Web Inspector: Toggling an inherited property sometimes stops working
 860         https://bugs.webkit.org/show_bug.cgi?id=145416
 861
 862         Reviewed by Timothy Hatcher.
 863
 864         * UserInterface/Models/DOMNodeStyles.js:
 865         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
 866         Ensure we update the existing model objects with the new state information
 867         before possibly bailing. This may produce changed events that update
 868         parts of the inspector appropriately.
 869
 870 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
 871
 872         Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works
 873         https://bugs.webkit.org/show_bug.cgi?id=143164
 874
 875         Reviewed by Brian Burg.
 876
 877         * UserInterface/Views/BoxModelDetailsSectionRow.js:
 878         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
 879         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
 880         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.didToggle):
 881         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode):
 882         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
 883         Make it so editing in the metrics pane just evaluates elem.style.setProperty
 884         on the inspected page. Use "!important" to try and give the maximum priority
 885         possible, which is a change from older behavior. Finally, refresh the sidebar
 886         to update all values, and update the UI if bad input didn't change styles.
 887
 888 2015-05-26  Joseph Pecoraro  <pecoraro@apple.com>
 889
 890         Web Inspector: Function parameter string parsing improperly handles empty parameter list
 891         https://bugs.webkit.org/show_bug.cgi?id=145391
 892
 893         Reviewed by Darin Adler.
 894
 895         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
 896         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
 897
 898 2015-05-26  Joseph Pecoraro  <pecoraro@apple.com>
 899
 900         Web Inspector: Add Array.prototype.copyWithin parameter list
 901         https://bugs.webkit.org/show_bug.cgi?id=145388
 902
 903         Reviewed by Darin Adler.
 904
 905         * UserInterface/Models/NativeFunctionParameters.js:
 906
 907 2015-05-26  Nikita Vasilyev  <nvasilyev@apple.com>
 908
 909         Web Inspector: focus outline of a search field should have a radius
 910         https://bugs.webkit.org/show_bug.cgi?id=145383
 911
 912         Add a focus outline animation to roughly mimic the default focus outline of OS X.
 913
 914         Reviewed by Timothy Hatcher.
 915
 916         * UserInterface/Views/Toolbar.css:
 917         (.toolbar .search-bar > input[type="search"]):
 918         -webkit-focus-ring-color doesn't follow element's curvature (e.g. border-radius)
 919         and it cannot be animated. Replace it with box-shadow.
 920
 921         (.toolbar .search-bar > input[type="search"]:focus):
 922
 923 2015-05-26  Nikita Vasilyev  <nvasilyev@apple.com>
 924
 925         Web Inspector: The bottom part "debugger" is clipped in the tab’s title
 926         https://bugs.webkit.org/show_bug.cgi?id=145381
 927
 928         Reviewed by Timothy Hatcher.
 929
 930         * UserInterface/Views/TabBar.css:
 931         (.tab-bar > .item):
 932         Set line-height to fit "debugger". Setting line-height to 16px, which is the
 933         size of the tabs icons, moves the text one pixel up, so set it to 15px.
 934
 935 2015-05-26  Dan Bernstein  <mitz@apple.com>
 936
 937         <rdar://problem/21104551> Update build settings
 938
 939         Reviewed by Anders Carlsson.
 940
 941         * Configurations/Base.xcconfig:
 942         * Configurations/DebugRelease.xcconfig:
 943         * Configurations/Version.xcconfig:
 944
 945 2015-05-23  Dan Bernstein  <mitz@apple.com>
 946
 947         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
 948         https://bugs.webkit.org/show_bug.cgi?id=145345
 949
 950         Reviewed by Sam Weinig.
 951
 952         * Configurations/Base.xcconfig:
 953
 954 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
 955
 956         Web Inspector: Remove code related with unused style classes
 957         https://bugs.webkit.org/show_bug.cgi?id=145332
 958
 959         Reviewed by Timothy Hatcher.
 960
 961         * UserInterface/Views/ConsoleMessageView.js:
 962         (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
 963         (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
 964         The "type-string" class has no styles associated with it. So the entire span can be removed.
 965
 966         * UserInterface/Views/DOMTreeElement.js:
 967         Both of these style classes have no styles associated with them. Remove the class names.
 968
 969 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
 970
 971         Web Inspector: Improve native parameter lists a bit
 972         https://bugs.webkit.org/show_bug.cgi?id=145338
 973
 974         Reviewed by Timothy Hatcher.
 975
 976         * UserInterface/Models/NativeFunctionParameters.js:
 977         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
 978         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
 979
 980 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
 981
 982         Web Inspector: Update CSS Autocompletion properties and values
 983         https://bugs.webkit.org/show_bug.cgi?id=145341
 984
 985         Reviewed by Timothy Hatcher.
 986
 987         * UserInterface/Models/CSSKeywordCompletions.js:
 988
 989 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
 990
 991         Web Inspector: Adopt Object.setPrototypeOf
 992         https://bugs.webkit.org/show_bug.cgi?id=145335
 993
 994         Reviewed by Timothy Hatcher.
 995
 996         For a case that won't easily move to ES6 classes use Object.setPrototypeOf.
 997
 998         * UserInterface/Protocol/InspectorBackend.js:
 999         (InspectorBackend.Command.create):
1000
1001 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1002
1003         Web Inspector: Inline use once class names and remove some unused class names
1004         https://bugs.webkit.org/show_bug.cgi?id=145334
1005
1006         Reviewed by Timothy Hatcher.
1007
1008         * UserInterface/Views/ApplicationCacheFrameContentView.js:
1009         (WebInspector.ApplicationCacheFrameContentView):
1010         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1011         (WebInspector.BoxModelDetailsSectionRow):
1012         * UserInterface/Views/CSSStyleDeclarationSection.js:
1013         (WebInspector.CSSStyleDeclarationSection):
1014         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1015         (WebInspector.CSSStyleDetailsSidebarPanel):
1016         * UserInterface/Views/ClusterContentView.js:
1017         (WebInspector.ClusterContentView):
1018         * UserInterface/Views/CompletionSuggestionsView.js:
1019         (WebInspector.CompletionSuggestionsView):
1020         * UserInterface/Views/ConsolePrompt.js:
1021         (WebInspector.ConsolePrompt):
1022         * UserInterface/Views/ContentBrowser.js:
1023         (WebInspector.ContentBrowser):
1024         * UserInterface/Views/ContentFlowTreeElement.js:
1025         (WebInspector.ContentFlowTreeElement):
1026         * UserInterface/Views/ContentView.js:
1027         (WebInspector.ContentView):
1028         * UserInterface/Views/ContentViewContainer.js:
1029         (WebInspector.ContentViewContainer):
1030         * UserInterface/Views/CookieStorageContentView.js:
1031         (WebInspector.CookieStorageContentView):
1032         * UserInterface/Views/CookieStorageTreeElement.js:
1033         (WebInspector.CookieStorageTreeElement):
1034         * UserInterface/Views/DOMStorageContentView.js:
1035         (WebInspector.DOMStorageContentView):
1036         * UserInterface/Views/DOMTreeContentView.js:
1037         (WebInspector.DOMTreeContentView):
1038         * UserInterface/Views/DashboardView.js:
1039         (WebInspector.DashboardView):
1040         * UserInterface/Views/DatabaseTableContentView.js:
1041         (WebInspector.DatabaseTableContentView):
1042         * UserInterface/Views/DebuggerDashboardView.js:
1043         (WebInspector.DebuggerDashboardView):
1044         (WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
1045         * UserInterface/Views/DetailsSection.js:
1046         (WebInspector.DetailsSection):
1047         * UserInterface/Views/DetailsSectionSimpleRow.js:
1048         * UserInterface/Views/FontResourceContentView.js:
1049         (WebInspector.FontResourceContentView):
1050         (WebInspector.FontResourceContentView.prototype.createMetricElement):
1051         (WebInspector.FontResourceContentView.prototype.contentAvailable):
1052         * UserInterface/Views/HierarchicalPathComponent.js:
1053         (WebInspector.HierarchicalPathComponent):
1054         (WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):
1055         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
1056         * UserInterface/Views/LayoutTimelineOverviewGraph.js:
1057         (WebInspector.LayoutTimelineOverviewGraph):
1058         * UserInterface/Views/NetworkTimelineOverviewGraph.js:
1059         (WebInspector.NetworkTimelineOverviewGraph):
1060         * UserInterface/Views/OverviewTimelineView.js:
1061         * UserInterface/Views/ProbeSetDetailsSection.js:
1062         * UserInterface/Views/QuickConsole.js:
1063         * UserInterface/Views/ReplayDashboardView.js:
1064         * UserInterface/Views/ScriptContentView.js:
1065         (WebInspector.ScriptContentView):
1066         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1067         (WebInspector.ScriptTimelineOverviewGraph):
1068         * UserInterface/Views/TextContentView.js:
1069         (WebInspector.TextContentView):
1070         * UserInterface/Views/TimelineOverview.js:
1071         (WebInspector.TimelineOverview):
1072         * UserInterface/Views/TimelineOverviewGraph.js:
1073         (WebInspector.TimelineOverviewGraph):
1074         * UserInterface/Views/TimelineRecordBar.js:
1075         (WebInspector.TimelineRecordBar):
1076         * UserInterface/Views/TimelineRecordFrame.js:
1077         (WebInspector.TimelineRecordFrame):
1078         * UserInterface/Views/TimelineRecordingContentView.js:
1079         (WebInspector.TimelineRecordingContentView):
1080         * UserInterface/Views/TimelineRuler.js:
1081         (WebInspector.TimelineRuler):
1082         (WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):
1083
1084 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1085
1086         Web Inspector: DOMTree Keyboard Shortcut 'H' to toggle element visibility is not working
1087         https://bugs.webkit.org/show_bug.cgi?id=145331
1088
1089         Reviewed by Brian Burg.
1090
1091         We no longer have CSSProperty.value setters. Instead of attempting
1092         to toggle and clobber inline style values on the element we:
1093
1094           1. inject a <style> on the page like ".WebInspectorHide { visibility:hidden }"
1095           2. toggle the WebInspectorHide class on the selected element
1096
1097         This approach is inspired by the original WebKit change in the
1098         old inspector frontend: <https://webkit.org/b/110641>.
1099
1100         The old approach toggled a few properties (opacity and pointer events)
1101         while the new approach uses visibility, matching other browsers.
1102
1103         * UserInterface/Views/DOMTreeOutline.js:
1104         (WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode.injectStyleAndToggleClass):
1105         (WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode):
1106         (WebInspector.DOMTreeOutline.prototype._hideElement):
1107         (WebInspector.DOMTreeOutline.prototype._hideElement.toggleProperties): Deleted.
1108
1109 2015-05-21  Joseph Pecoraro  <pecoraro@apple.com>
1110
1111         Web Inspector: Give Toolbar buttons an active style
1112         https://bugs.webkit.org/show_bug.cgi?id=145292
1113
1114         Reviewed by Timothy Hatcher.
1115
1116         * UserInterface/Views/ButtonToolbarItem.css:
1117         (.toolbar .item.button:active):
1118
1119 2015-05-21  Nikita Vasilyev  <nvasilyev@apple.com>
1120
1121         Web Inspector: Dashboard debugger information can be clipped
1122         https://bugs.webkit.org/show_bug.cgi?id=144209
1123
1124         Reviewed by Timothy Hatcher.
1125
1126         * UserInterface/Views/DashboardContainerView.css:
1127         (.toolbar .dashboard-container):
1128         Make dashboard flexible by using vw (viewport width units).
1129
1130         * UserInterface/Views/DefaultDashboardView.css:
1131         (.toolbar .dashboard.default):
1132         Center default dashboard icons in the middle, don't spread them along the dashboard.
1133
1134 2015-05-21  Joseph Pecoraro  <pecoraro@apple.com>
1135
1136         Web Inspector: Improve the UI of the type profiler popover
1137         https://bugs.webkit.org/show_bug.cgi?id=140737
1138
1139         Reviewed by Timothy Hatcher.
1140
1141         Display TypeDescriptions in a Tree similiar to ObjectTrees.
1142         Currently the only information we have in a TypeDescription
1143         is the property names, and not their types, so all we can
1144         display in the tree are names.
1145
1146         * Localizations/en.lproj/localizedStrings.js:
1147         * UserInterface/Controllers/TypeTokenAnnotator.js:
1148         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1149         * UserInterface/Main.html:
1150         * UserInterface/Models/ScriptSyntaxTree.js:
1151         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
1152         * UserInterface/Models/StructureDescription.js: Added.
1153         (WebInspector.StructureDescription):
1154         (WebInspector.StructureDescription.fromPayload):
1155         (WebInspector.StructureDescription.prototype.get fields):
1156         (WebInspector.StructureDescription.prototype.get optionalFields):
1157         (WebInspector.StructureDescription.prototype.get constructorName):
1158         (WebInspector.StructureDescription.prototype.get prototypeStructure):
1159         (WebInspector.StructureDescription.prototype.get imprecise):
1160         * UserInterface/Models/TypeDescription.js: Added.
1161         (WebInspector.TypeDescription):
1162         (WebInspector.TypeDescription.fromPayload):
1163         (WebInspector.TypeDescription.prototype.get leastCommonAncestor):
1164         (WebInspector.TypeDescription.prototype.get typeSet):
1165         (WebInspector.TypeDescription.prototype.get structures):
1166         (WebInspector.TypeDescription.prototype.get valid):
1167         (WebInspector.TypeDescription.prototype.get truncated):
1168         * UserInterface/Models/TypeSet.js:
1169         (WebInspector.TypeSet):
1170         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
1171         * UserInterface/Views/ObjectTreeView.js:
1172         (WebInspector.ObjectTreeView.prototype._updateChildren):
1173         * UserInterface/Views/Section.css: Removed.
1174         * UserInterface/Views/Section.js: Removed.
1175         * UserInterface/Views/SourceCodeTextEditor.css:
1176         (.popover .expandable):
1177         * UserInterface/Views/SourceCodeTextEditor.js:
1178         (WebInspector.SourceCodeTextEditor):
1179         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
1180         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
1181         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1182         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1183         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
1184         * UserInterface/Views/TypePropertiesSection.js: Removed.
1185         * UserInterface/Views/TypeTokenView.js:
1186         (WebInspector.TypeTokenView):
1187         (WebInspector.TypeTokenView.titleForPopover):
1188         (WebInspector.TypeTokenView.prototype.update):
1189         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
1190         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1191         (WebInspector.TypeTokenView.prototype._displayTypeName):
1192         * UserInterface/Views/TypeTreeElement.css: Added.
1193         (.type-tree-element):
1194         (.type-tree-element > .titles):
1195         (.type-tree-element > .disclosure-button):
1196         (.type-tree-element.parent > .disclosure-button):
1197         (.type-tree-element.parent.expanded > .disclosure-button):
1198         (.type-tree-element > .icon):
1199         (.type-tree-element.prototype):
1200         (.type-tree-element.prototype:focus):
1201         (.type-tree-element.prototype + ol):
1202         * UserInterface/Views/TypeTreeElement.js: Added.
1203         (WebInspector.TypeTreeElement):
1204         (WebInspector.TypeTreeElement.prototype.get name):
1205         (WebInspector.TypeTreeElement.prototype.get isPrototype):
1206         (WebInspector.TypeTreeElement.prototype.onpopulate):
1207         (WebInspector.TypeTreeElement.prototype.onexpand):
1208         * UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js.
1209         (.type-tree):
1210         (.type-tree-outline):
1211         (.type-tree-outline li):
1212         (.type-tree-outline ol):
1213         (.type-tree-outline ol.expanded):
1214         (.type-tree-outline li .empty-message):
1215         * UserInterface/Views/TypeTreeView.js: Added.
1216         (WebInspector.TypeTreeView):
1217         (WebInspector.TypeTreeView.prototype.get typeDescription):
1218         (WebInspector.TypeTreeView.prototype.get element):
1219         (WebInspector.TypeTreeView.prototype.get treeOutline):
1220         (WebInspector.TypeTreeView.prototype._populate):
1221
1222 2015-05-20  Joseph Pecoraro  <pecoraro@apple.com>
1223
1224         Web Inspector: Fix WebInspector.StackTrace style
1225         https://bugs.webkit.org/show_bug.cgi?id=145240
1226
1227         Reviewed by Timothy Hatcher.
1228
1229         * UserInterface/Models/StackTrace.js:
1230         Reorder and add our usual marker comments.
1231
1232 2015-05-19  Joseph Pecoraro  <pecoraro@apple.com>
1233
1234         Web Inspector: Improve Preview for NodeList / array like collections
1235         https://bugs.webkit.org/show_bug.cgi?id=145177
1236
1237         Reviewed by Timothy Hatcher.
1238
1239         * UserInterface/Views/ObjectPreviewView.js:
1240         (WebInspector.ObjectPreviewView.prototype._appendPreview):
1241         Show the class name for a non-basic-Array, but still hide
1242         it for a basic Array.
1243
1244 2015-05-19  Nikita Vasilyev  <nvasilyev@apple.com>
1245
1246         Web Inspector: Convert stackTrace from raw payload data to an array of CallFrames
1247         https://bugs.webkit.org/show_bug.cgi?id=144982
1248
1249         Reviewed by Joseph Pecoraro.
1250
1251         * UserInterface/Controllers/LogManager.js:
1252         * UserInterface/Main.html:
1253         * UserInterface/Models/CallFrame.js:
1254         (WebInspector.CallFrame.fromPayload):
1255         Consider an empty string url as a native code as it was in
1256         WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame
1257
1258         * UserInterface/Models/ConsoleMessage.js:
1259         (WebInspector.ConsoleMessage):
1260         Convert _stackTrace from an array of payload objects to WebInspector.StackTrace model.
1261
1262         * UserInterface/Models/StackTrace.js: Added.
1263         (WebInspector.StackTrace):
1264         (WebInspector.StackTrace.prototype.get callFrames):
1265         (WebInspector.StackTrace.prototype.get firstNonNativeCallFrame): Added.
1266         (WebInspector.StackTrace.fromPayload):
1267         * UserInterface/Test.html:
1268         * UserInterface/Views/CallFrameView.js:
1269         (WebInspector.CallFrameView):
1270         Don't show a URL when sourceCodeLocation is missing, fix webkit.org/b/145071.
1271
1272         * UserInterface/Views/ConsoleMessageView.js:
1273         (WebInspector.ConsoleMessageView):
1274         (WebInspector.ConsoleMessageView.prototype.toClipboardString):
1275         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
1276         (WebInspector.ConsoleMessageView.prototype._appendStackTrace):
1277         (WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
1278         (WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
1279         (WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame): Deleted.
1280
1281 2015-05-18  Joseph Pecoraro  <pecoraro@apple.com>
1282
1283         Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
1284         https://bugs.webkit.org/show_bug.cgi?id=145139
1285
1286         Reviewed by Timothy Hatcher.
1287
1288         * UserInterface/Views/DOMTreeElement.js:
1289         (WebInspector.DOMTreeElement.prototype.highlightSearchResults):
1290         (WebInspector.DOMTreeElement.prototype.hideSearchHighlights):
1291         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1292         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1293         (WebInspector.DOMTreeElement.prototype._updateChildren):
1294         (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
1295         (WebInspector.DOMTreeElement.prototype._startEditingAsHTML.dispose):
1296         (WebInspector.DOMTreeElement.prototype._startEditingAsHTML):
1297         (WebInspector.DOMTreeElement.prototype.updateTitle):
1298         Stop using the `delete` operator.
1299
1300         * UserInterface/Views/DOMTreeOutline.js:
1301         (WebInspector.DOMTreeOutline.prototype.setVisible):
1302         Trigger an update when the outline is made visible.
1303
1304         * UserInterface/Views/FrameDOMTreeContentView.js:
1305         (WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
1306         Provide a reasonable default selection if there is no body or document element.
1307         For example in an augmented DOM tree.
1308
1309 2015-05-18  Joseph Pecoraro  <pecoraro@apple.com>
1310
1311         Web Inspector: Tab Restoration incorrectly makes ContentViews "shown" in background tabs
1312         https://bugs.webkit.org/show_bug.cgi?id=145080
1313
1314         Reviewed by Timothy Hatcher.
1315
1316         Many tabs have their own content browser / navigation sidebar. During
1317         state restoration, each tab would immediately try to restore an
1318         appropriate ContentView after the load / navigation. However, in doing
1319         so, we weren't respecting whether or not the Tab the ContentBrowser
1320         was in was hidden or not, so ContentViews in background tags were
1321         still being treated as shown/visible.
1322
1323         This patch changes state restoration to only affect the foreground
1324         tab, and be delayed on all background tabs until that tab is shown.
1325         This reduces the amount of work on load and navigation to just a
1326         single tab instead of all tabs. Most importantly, it avoids having
1327         performing work on ContentBrowsers that are non-visible, so state
1328         restoration only happens for visible ContentBrowsers.
1329
1330         For simplicity, in the case of a delayed tab restoration triggered
1331         by the user switching tabs, we don't try twice (like we occasionally
1332         do on load/reload). We could add back some hueristic here if needed.
1333
1334         * UserInterface/Base/Main.js:
1335         (WebInspector.contentLoaded):
1336         (WebInspector.activateExtraDomains):
1337         (WebInspector._mainResourceDidChange):
1338         (WebInspector._restoreCookieForOpenTabs):
1339         * UserInterface/Views/NavigationSidebarPanel.js:
1340
1341         * UserInterface/Views/TabContentView.js:
1342         (WebInspector.TabContentView.prototype.shown):
1343         (WebInspector.TabContentView.prototype.restoreStateFromCookie):
1344         (WebInspector.TabContentView.prototype.saveStateToCookie):
1345         When asked to restore state, save that logic until the next time the tab is shown.
1346
1347         * UserInterface/Views/TextEditor.js:
1348         (WebInspector.TextEditor.prototype.get visible):
1349         * UserInterface/Views/SourceCodeTextEditor.js:
1350         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidStartEditing):
1351         (WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState): Deleted.
1352         Although this didn't actually catch the issue, it could potentially
1353         catch other issues in the future. We don't want to enable the annotators
1354         in a non-visible text editor, as it could be a performance issue.
1355
1356 2015-05-15  Matt Baker  <mattbaker@apple.com>
1357
1358         Web Inspector: empty timeline should not use previous timeline's zoom interval
1359         https://bugs.webkit.org/show_bug.cgi?id=132754
1360
1361         Reviewed by Joseph Pecoraro.
1362
1363         When a timeline recording is started in response to a provisional load, TimelineManager should check whether
1364         the main resource url is changing before loading a new timeline recording. If the main resource is changing,
1365         set the selection start, selection duration, and duration-per-pixel settings of the TimelineOverview to their
1366         default values.
1367
1368         * UserInterface/Controllers/TimelineManager.js:
1369         (WebInspector.TimelineManager):
1370         (WebInspector.TimelineManager.prototype.isCapturingPageReload):
1371         (WebInspector.TimelineManager.prototype.capturingStopped):
1372         (WebInspector.TimelineManager.prototype.pageDidLoad):
1373         (WebInspector.TimelineManager.prototype._startAutoCapturing):
1374         Added a property for checking whether auto capture was triggered by a page reload.
1375
1376         * UserInterface/Views/LinearTimelineOverview.js:
1377         (WebInspector.LinearTimelineOverview):
1378         Increase default selection time to 15 seconds.
1379
1380         * UserInterface/Views/TimelineOverview.js:
1381         (WebInspector.TimelineOverview):
1382         Reset selection and zoom if TimelineManager isn't capturing in response to a page reload.
1383
1384         (WebInspector.TimelineOverview.prototype.reset):
1385         Reset selection and zoom.
1386
1387         (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
1388         (WebInspector.TimelineOverview.prototype._resetSelection):
1389         Added a helper function for resetting selection and zoom to their default values.
1390
1391 2015-05-15  Matt Baker  <mattbaker@apple.com>
1392
1393         Web Inspector: Timeline data grid displays wrong records after switching between Timelines/Frames mode
1394         https://bugs.webkit.org/show_bug.cgi?id=145084
1395
1396         Reviewed by Timothy Hatcher.
1397
1398         Update timeline sidebar filter whenever the view mode changes.
1399
1400         * UserInterface/Views/TimelineSidebarPanel.js:
1401         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
1402         (WebInspector.TimelineSidebarPanel.get else):
1403         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
1404         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
1405
1406 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1407
1408         Web Inspector: Bump image format number to force image regeneration
1409         https://bugs.webkit.org/show_bug.cgi?id=145074
1410
1411         Reviewed by Timothy Hatcher.
1412
1413         * UserInterface/Base/ImageUtilities.js:
1414
1415 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1416
1417         Web Inspector: Reduce type annotation update frequency
1418         https://bugs.webkit.org/show_bug.cgi?id=145066
1419
1420         Reviewed by Timothy Hatcher.
1421
1422         * UserInterface/Controllers/TypeTokenAnnotator.js:
1423         Reduce the frequency which could commonly be 16-24ms
1424         to a minimum of 100ms and maximum of 2000ms.
1425
1426 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1427
1428         Web Inspector: Fix some possible event listener leakers in content views
1429         https://bugs.webkit.org/show_bug.cgi?id=145068
1430
1431         Reviewed by Timothy Hatcher.
1432
1433         Now that some content views can be closed that weren't closable before, ensure
1434         we clean up after global event listeners that may strongly reference "this".
1435
1436         * UserInterface/Views/DOMTreeContentView.js:
1437         (WebInspector.DOMTreeContentView.prototype.closed):
1438         * UserInterface/Views/DOMTreeOutline.js:
1439         (WebInspector.DOMTreeOutline.prototype.close):
1440         * UserInterface/Views/LayoutTimelineView.js:
1441         (WebInspector.LayoutTimelineView.prototype.closed):
1442         * UserInterface/Views/NetworkTimelineView.js:
1443         (WebInspector.NetworkTimelineView.prototype.closed):
1444         * UserInterface/Views/RenderingFrameTimelineView.js:
1445         (WebInspector.RenderingFrameTimelineView.prototype.closed):
1446         * UserInterface/Views/ScriptContentView.js:
1447         (WebInspector.ScriptContentView.prototype.closed):
1448         * UserInterface/Views/ScriptTimelineView.js:
1449         (WebInspector.ScriptTimelineView.prototype.closed):
1450         * UserInterface/Views/SourceCodeTextEditor.js:
1451         (WebInspector.SourceCodeTextEditor.prototype.close):
1452         * UserInterface/Views/TextResourceContentView.js:
1453         (WebInspector.TextResourceContentView.prototype.closed):
1454         * UserInterface/Views/TimelineDataGrid.js:
1455         (WebInspector.TimelineDataGrid.prototype.closed):
1456         (WebInspector.TimelineDataGrid.prototype.handleEvent):
1457
1458 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
1459
1460         Web Inspector: Initiator Popovers no longer work in Layout Timeline
1461         https://bugs.webkit.org/show_bug.cgi?id=145067
1462
1463         Reviewed by Timothy Hatcher.
1464
1465         * UserInterface/Views/LayoutTimelineDataGrid.js:
1466         (WebInspector.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
1467         Update the column name, which changed in r183134.
1468
1469 2015-05-14  Joseph Pecoraro  <pecoraro@apple.com>
1470
1471         Web Inspector: Update the New Tab button disabled state after extra domains are activated
1472         https://bugs.webkit.org/show_bug.cgi?id=145028
1473
1474         Reviewed by Timothy Hatcher.
1475
1476         * UserInterface/Base/Main.js:
1477         (WebInspector.activateExtraDomains):
1478
1479 2015-05-14  Matt Baker  <mattbaker@apple.com>
1480
1481         Web Inspector: Current time marker is always at zero in Rendering Frames ruler
1482         https://bugs.webkit.org/show_bug.cgi?id=144518
1483
1484         Reviewed by Timothy Hatcher.
1485
1486         The current and end time values for the rendering frame timeline overview should always be equal to the frame
1487         number of the last record in the rendering frames timeline.
1488
1489         * UserInterface/Views/TimelineOverview.js:
1490         (WebInspector.TimelineOverview):
1491         (WebInspector.TimelineOverview.prototype.updateLayout):
1492         * UserInterface/Views/TimelineRecordingContentView.js:
1493         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
1494         (WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
1495
1496 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
1497
1498         [Win] Move Windows build target to Windows 7 (or newer)
1499         https://bugs.webkit.org/show_bug.cgi?id=144890
1500         <rdar://problem/20707307>
1501
1502         Reviewed by Anders Carlsson.
1503
1504         Update linked SDK and minimal Windows level to be compatible with
1505         Windows 7 or newer.
1506
1507         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
1508
1509 2015-05-11  Timothy Hatcher  <timothy@apple.com>
1510
1511         Web Inspector: REGRESSION (Tabs): Issues reloading a resource with breakpoints
1512         https://bugs.webkit.org/show_bug.cgi?id=144650
1513
1514         Fix a number of issues with Debugger tab and navigation/reloading:
1515         - Close old content views in the Debugger tab when main frame navigates.
1516         - Prune old resource tree elements before attempting to restore a cookie that might match an old resource.
1517         - Allow breakpoint selections to be restored from a saved cookie.
1518         - Fix an assert when closing a content view that isn't the current index, but is the current view.
1519         - Avoid calling closed() multiple times when a ContentView is in the back/forward list more than once.
1520         - Make restoreStateFromCookie properly set and use the causedByNavigation argument for a longer restore delay.
1521         - Create a new cookie object per tab instead of it being cumulative from the previous cookie.
1522
1523         Reviewed by Brian Burg.
1524
1525         * UserInterface/Base/Main.js:
1526         (WebInspector._mainResourceDidChange): Delay calling _restoreCookieForOpenTabs to give time for sidebars
1527         and tabs to respond to the main resource change.
1528         (WebInspector._restoreCookieForOpenTabs): Rename causedByReload to causedByNavigation. Nothing special about
1529         reload since we restore on all navigation.
1530
1531         * UserInterface/Views/ContentView.js:
1532         (WebInspector.ContentView): Support Breakpoint as a represented object, which happens during a cookie restore.
1533         (WebInspector.ContentView.isViewable): Ditto.
1534
1535         * UserInterface/Views/ContentViewContainer.js:
1536         (WebInspector.ContentViewContainer.prototype.closeAllContentViews): Disassociate if the view is current and not just
1537         the current entry index. This matches other close functions. This fixes an assert in _disassociateFromContentView.
1538         (WebInspector.ContentViewContainer.prototype._disassociateFromContentView): Don't disassociate multiple times. This
1539         avoids calling the closed() function on a view more than once.
1540
1541         * UserInterface/Views/DebuggerSidebarPanel.js:
1542         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
1543         (WebInspector.DebuggerSidebarPanel.prototype._mainResourceDidChange): Renamed from _mainResourceChanged.
1544         Close all content views if this is the main frame. Also prune all old resources. Doing this now avoids a flash
1545         of having old and new resources in the tree caused by the default delay in NavigationSidebarPanel's _checkForOldResources.
1546
1547         * UserInterface/Views/NavigationSidebarPanel.js:
1548         (WebInspector.NavigationSidebarPanel): Set _autoPruneOldTopLevelResourceTreeElements for later.
1549         (WebInspector.NavigationSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
1550         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentView): Fix typo.
1551         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentViewForTreeElement): Fix whitespace.
1552         (WebInspector.NavigationSidebarPanel.prototype.pruneOldResourceTreeElements): Added. Broken out from
1553         _checkForOldResources.delayedWork so it can be called manually. Also check all visible tree outlines.
1554         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged): Pass treeElement in an array.
1555         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResourcesIfNeeded): Added.
1556         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResources): Call pruneOldResourceTreeElements on a delay.
1557         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResources.delayedWork): Deleted.
1558         (WebInspector.NavigationSidebarPanel.prototype._checkOutlinesForPendingViewStateCookie): Call _checkForOldResourcesIfNeeded.
1559         (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie): Remove array folding code.
1560
1561         * UserInterface/Views/TabContentView.js:
1562         (WebInspector.TabContentView.prototype.restoreStateFromCookie): Rename causedByReload to causedByNavigation.
1563         (WebInspector.TabContentView.prototype.saveStateToCookie): Don't allow the cookie to build on the old cookie.
1564
1565 2015-05-11  Timothy Hatcher  <timothy@apple.com>
1566
1567         Web Inspector: NavigationSidebarPanel leaks some event listeners
1568         https://bugs.webkit.org/show_bug.cgi?id=144523
1569
1570         Reviewed by Joseph Pecoraro.
1571
1572         * UserInterface/Views/NavigationSidebarPanel.js:
1573         (WebInspector.NavigationSidebarPanel):
1574         (WebInspector.NavigationSidebarPanel.prototype.closed):
1575         * UserInterface/Views/ResourceSidebarPanel.js:
1576         (WebInspector.ResourceSidebarPanel.prototype.closed):
1577         * UserInterface/Views/SearchSidebarPanel.js:
1578         (WebInspector.SearchSidebarPanel.prototype.closed):
1579         * UserInterface/Views/StorageSidebarPanel.js:
1580         (WebInspector.StorageSidebarPanel.prototype.closed):
1581         * UserInterface/Views/TimelineSidebarPanel.js:
1582         (WebInspector.TimelineSidebarPanel.prototype.closed):
1583
1584 2015-05-10  Nikita Vasilyev  <nvasilyev@apple.com>
1585
1586         Web Inspector: In the console, show function name next to the source link
1587         https://bugs.webkit.org/show_bug.cgi?id=144372
1588
1589         Introduce CallFrameView to display counsole message source links. It looks like this:
1590
1591             [f] functionName - filename.js:42
1592
1593         Reviewed by Timothy Hatcher.
1594
1595         * UserInterface/Base/Main.js:
1596         (WebInspector.createSourceCodeLocationLink):
1597         (WebInspector.linkifyLocation):
1598         (.showSourceCodeLocation):
1599         (WebInspector.linkifyElement):
1600         Abstract this out as it's used in WebInspector.CallFrameView and WebInspector.createSourceCodeLocationLink.
1601
1602         (WebInspector.sourceCodeForURL):
1603         Move this code from Timeline to Main.js as it's used by Console too.
1604
1605         (WebInspector.linkifyURLAsNode):
1606         Remove tooltipText argument as it is never used.
1607
1608         * UserInterface/Controllers/TimelineManager.js:
1609         (WebInspector.TimelineManager.prototype._callFramesFromPayload):
1610         * UserInterface/Main.html:
1611         * UserInterface/Models/CallFrame.js:
1612         (WebInspector.CallFrame.fromPayload):
1613         Abstract this out as it's used in WebInspector.TimelineManager.prototype._callFramesFromPayload and
1614         WebInspector.ConsoleMessageView._appendLocationLink.
1615
1616         (WebInspector.CallFrame):
1617         * UserInterface/Views/CallFrameTreeElement.js:
1618         (WebInspector.CallFrameTreeElement):
1619         Move it to WebInspector.CallFrameView.iconForCallFrame.
1620
1621         * UserInterface/Views/CallFrameView.css: Added.
1622         (.call-frame):
1623         (.call-frame .icon):
1624         (.call-frame .titles):
1625         (.call-frame .title):
1626         (.call-frame .source-link):
1627         (.call-frame .title + .subtitle > .source-link):
1628         (.call-frame .subtitle .source-link):
1629         (.call-frame:focus .subtitle .source-link):
1630         (.call-frame .subtitle:empty):
1631         (.call-frame .subtitle):
1632         (.call-frame .colon):
1633         (.call-frame .title + .subtitle::before):
1634         * UserInterface/Views/CallFrameView.js: Added.
1635         (WebInspector.CallFrameView):
1636         (WebInspector.CallFrameView.iconClassNameForCallFrame):
1637         * UserInterface/Views/ConsoleMessageView.css:
1638         (.console-message .console-message-location):
1639         (.console-message .call-frame):
1640         (.console-message .go-to-link):
1641         (.console-message .go-to-link:focus):
1642         (.console-message .console-message-url::before):
1643         (.console-saved-variable): Deleted.
1644         * UserInterface/Views/ConsoleMessageView.js:
1645         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
1646         * UserInterface/Views/DebuggerDashboardView.js:
1647         * UserInterface/Views/Main.css:
1648         (.hidden): Deleted.
1649         * UserInterface/Views/ProfileNodeTreeElement.js:
1650         (WebInspector.ProfileNodeTreeElement):
1651         * UserInterface/Views/TimelineDataGridNode.js:
1652         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
1653
1654 2015-05-08  Tobias Reiss  <tobi+webkit@basecode.de>
1655
1656         Web Inspector: Styles sidebar editing with incomplete property looks poor in UI
1657         https://bugs.webkit.org/show_bug.cgi?id=141692
1658
1659         Reviewed by Timothy Hatcher.
1660
1661         Add "css-rule" Formatter that breaks CSS declarations into multiple lines,
1662         keeps comments and invalid styles and adds whitespace.
1663
1664         * Tools/PrettyPrinting/css-rule-tests/*.css: Added.
1665         Add test cases.
1666
1667         * Tools/PrettyPrinting/index.html:
1668         Enable Test setup to be able to run "css-rule" Formatter tests.
1669
1670         * UserInterface/Controllers/Formatter.js:
1671         (Formatter.prototype._handleToken):
1672         * UserInterface/Controllers/FormatterContentBuilder.js:
1673         (FormatterContentBuilder.prototype.removeLastNewline):
1674         (FormatterContentBuilder.prototype.removeLastWhitespace):
1675         (FormatterContentBuilder.prototype._popFormattedContent):
1676         (FormatterContentBuilder.prototype._popNewLine): Deleted.
1677         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1678         (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):
1679         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.set this):
1680         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.get this):
1681         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
1682         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent):
1683         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.countNewLineCharacters): Deleted.
1684         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.else): Deleted.
1685         * UserInterface/Views/CodeMirrorFormatters.js:
1686
1687 2015-05-07  Joseph Pecoraro  <pecoraro@apple.com>
1688
1689         Web Inspector: Expanding Object with only __proto__ looks poor should have a label
1690         https://bugs.webkit.org/show_bug.cgi?id=144755
1691
1692         Reviewed by Timothy Hatcher.
1693
1694         Better handle cases where expanding an object has only a __proto__
1695         and no other properties.
1696
1697         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
1698         (WebInspector.ObjectTreePropertyTreeElement.mode.prototype.this.children.length):
1699         (WebInspector.ObjectTreePropertyTreeElement):
1700         * UserInterface/Views/ObjectTreeView.css:
1701         (.object-tree-outline li .empty-message):
1702         * UserInterface/Views/ObjectTreeView.js:
1703         (WebInspector.ObjectTreeView.createEmptyMessageElement):
1704         (WebInspector.ObjectTreeView.comparePropertyDescriptors):
1705         (WebInspector.ObjectTreeView.prototype._updateProperties):
1706
1707 2015-05-07  Joseph Pecoraro  <pecoraro@apple.com>
1708
1709         Web Inspector: Fix querySelector in ResourceContentView.js, caught by assertion
1710         https://bugs.webkit.org/show_bug.cgi?id=144756
1711
1712         Reviewed by Timothy Hatcher.
1713
1714         * UserInterface/Views/ResourceContentView.js:
1715         (WebInspector.ResourceContentView.prototype._hasContent):
1716         Ensure querySelector call is using the class name correctly.
1717
1718 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1719
1720         Web Inspector: Docking Toolbar Buttons do not respect Docking Availability
1721         https://bugs.webkit.org/show_bug.cgi?id=144714
1722
1723         Reviewed by Timothy Hatcher.
1724
1725         * UserInterface/Base/Main.js:
1726         (WebInspector.contentLoaded):
1727         (WebInspector.updateDockingAvailability):
1728         (WebInspector._updateDockNavigationItems):
1729         Update the Toolbar UI based on docking availability.
1730         Assume docking is unavailable by default.
1731
1732         * UserInterface/Protocol/InspectorFrontendAPI.js:
1733         (InspectorFrontendAPI.setDockingUnavailable):
1734         Add back this API as the backend may be calling it when
1735         docking availability changes. This just calls out to
1736         global WebInspector functions to update the Toolbar UI.
1737
1738         * UserInterface/Base/Test.js:
1739         (WebInspector.updateDockedState):
1740         (WebInspector.updateDockingAvailability):
1741         Do nothing in tests.
1742
1743 2015-05-06  Matt Baker  <mattbaker@apple.com>
1744
1745         Web Inspector: The text in the left pane overlaps the "Filter Time Events" field in the Timeline after the Web Inspector is resized
1746         https://bugs.webkit.org/show_bug.cgi?id=144720
1747
1748         Reviewed by Timothy Hatcher.
1749
1750         * UserInterface/Views/FilterBar.css:
1751         (.filter-bar):
1752         (.filter-bar > .navigation-bar):
1753         (.filter-bar > input[type="search"]):
1754         (.filter-bar > .navigation-bar > .item): Deleted.
1755         Filter bar now has opaque background and height updated to the ubiquitous 29px.
1756
1757 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1758
1759         Web Inspector: DOMStorage exception and issue with sessionStorage
1760         https://bugs.webkit.org/show_bug.cgi?id=144646
1761
1762         Reviewed by Timothy Hatcher.
1763
1764         * UserInterface/Views/DOMStorageContentView.js:
1765         (WebInspector.DOMStorageContentView):
1766         (WebInspector.DOMStorageContentView.prototype._populate):
1767         (WebInspector.DOMStorageContentView.prototype.reset): Deleted.
1768         Always have the datagrid be available with a default sort.
1769
1770         (WebInspector.DOMStorageContentView.prototype._sortDataGrid.comparator):
1771         (WebInspector.DOMStorageContentView.prototype._sortDataGrid):
1772         Simplify and correct the order.
1773
1774         (WebInspector.DOMStorageContentView.prototype.cleanup):
1775         Cleanup some uses of delete.
1776
1777         * UserInterface/Views/DataGrid.js:
1778         (WebInspector.DataGrid.prototype.sortNodesImmediately):
1779         Provide a way to sort immediately without a visible delay.
1780
1781         (WebInspector.DataGrid.prototype._sortNodesCallback):
1782         Cleanup some dead code to simplify sorting.
1783
1784         (WebInspector.DataGridNode.prototype._attach):
1785         When sorting, the children list does not match the child node list,
1786         so ensure that placeholder nodes are added to the end.
1787
1788         (WebInspector.PlaceholderDataGridNode.prototype.makeNormal):
1789         Cleanup some uses of delete.
1790
1791 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
1792
1793         Web Inspector: SourceCodeTextEditor shows "undefined" instead of resource content when pausing during resource load
1794         https://bugs.webkit.org/show_bug.cgi?id=144662
1795
1796         Reviewed by Timothy Hatcher.
1797
1798         * UserInterface/Protocol/InspectorBackend.js:
1799         (InspectorBackend.Command.prototype.promise):
1800         Start standardizing on rejecting Promises with Error objects.
1801
1802         * UserInterface/Views/ResourceContentView.js:
1803         (WebInspector.ResourceContentView):
1804         (WebInspector.ResourceContentView.prototype._protocolError):
1805         When there is a protocol error, show a nice UI string for the error.
1806
1807         (WebInspector.ResourceContentView.prototype._contentAvailable):
1808         (WebInspector.ResourceContentView.prototype._contentError):
1809         (WebInspector.ResourceContentView.prototype._hasContent):
1810         Whenever we hit an error case in ResourceContentView, check to make sure
1811         that a subclass hasn't already populated the content view with content.
1812         This can happen when a TextResourceContentView populates a Resource with
1813         Script content while paused, because the Resource content would be
1814         unavailable. We check that content has loaded by checking that the
1815         indeterminate spinner is no longer showing.
1816
1817 2015-05-05  Andres Gomez  <agomez@igalia.com>
1818
1819         [GTK] Web Inspector: Further optimize SVG images
1820         https://bugs.webkit.org/show_bug.cgi?id=144441
1821
1822         SVG images optimized with a combination of sed replacements, the
1823         usage of the scour tool (http://www.codedread.com/scour/) and a
1824         forked version of the svgo tool (https://github.com/tanty/svgo).
1825
1826         Also, added the class attribute to the shape elements following
1827         the convention used in Apple's images.
1828
1829         Reviewed by Joseph Pecoraro.
1830
1831         * UserInterface/Images/gtk/BackArrow.svg: Optimized.
1832         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Optimized.
1833         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Optimized.
1834         * UserInterface/Images/gtk/BreakpointButton.svg: Optimized.
1835         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Optimized.
1836         * UserInterface/Images/gtk/Breakpoints.svg: Optimized.
1837         * UserInterface/Images/gtk/Checkers.svg: Optimized.
1838         * UserInterface/Images/gtk/Circle.svg: Optimized.
1839         * UserInterface/Images/gtk/Close.svg: Optimized.
1840         * UserInterface/Images/gtk/CloseLarge.svg: Optimized.
1841         * UserInterface/Images/gtk/CloseWhite.svg: Optimized.
1842         * UserInterface/Images/gtk/ContentFlow.svg: Optimized.
1843         * UserInterface/Images/gtk/Crosshair.svg: Optimized.
1844         * UserInterface/Images/gtk/DOMCharacterData.svg: Optimized.
1845         * UserInterface/Images/gtk/DOMComment.svg: Optimized.
1846         * UserInterface/Images/gtk/DOMDocument.svg: Optimized.
1847         * UserInterface/Images/gtk/DOMDocumentType.svg: Optimized.
1848         * UserInterface/Images/gtk/DOMElement.svg: Optimized.
1849         * UserInterface/Images/gtk/DOMNode.svg: Optimized.
1850         * UserInterface/Images/gtk/DOMTextNode.svg: Optimized.
1851         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Optimized.
1852         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Optimized.
1853         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Optimized.
1854         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Optimized.
1855         * UserInterface/Images/gtk/DockBottom.svg: Optimized.
1856         * UserInterface/Images/gtk/DockRight.svg: Optimized.
1857         * UserInterface/Images/gtk/DownloadArrow.svg: Optimized.
1858         * UserInterface/Images/gtk/Error.svg: Optimized.
1859         * UserInterface/Images/gtk/Errors.svg: Optimized.
1860         * UserInterface/Images/gtk/ErrorsEnabled.svg: Optimized.
1861         * UserInterface/Images/gtk/EventListener.svg: Optimized.
1862         * UserInterface/Images/gtk/Exception.svg: Optimized.
1863         * UserInterface/Images/gtk/Eye.svg: Optimized.
1864         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Optimized.
1865         * UserInterface/Images/gtk/ForwardArrow.svg: Optimized.
1866         * UserInterface/Images/gtk/Function.svg: Optimized.
1867         * UserInterface/Images/gtk/GoToArrow.svg: Optimized.
1868         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Optimized.
1869         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Optimized.
1870         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Optimized.
1871         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Optimized.
1872         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Optimized.
1873         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Optimized.
1874         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Optimized.
1875         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Optimized.
1876         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Optimized.
1877         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Optimized.
1878         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Optimized.
1879         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Optimized.
1880         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Optimized.
1881         * UserInterface/Images/gtk/Issues.svg: Optimized.
1882         * UserInterface/Images/gtk/IssuesEnabled.svg: Optimized.
1883         * UserInterface/Images/gtk/LayerBorders.svg: Optimized.
1884         * UserInterface/Images/gtk/Locked.svg: Optimized.
1885         * UserInterface/Images/gtk/Logs.svg: Optimized.
1886         * UserInterface/Images/gtk/Native.svg: Optimized.
1887         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Optimized.
1888         * UserInterface/Images/gtk/NavigationItemTrash.svg: Optimized.
1889         * UserInterface/Images/gtk/NavigationItemTypes.svg: Optimized.
1890         * UserInterface/Images/gtk/PaintFlashing.svg: Optimized.
1891         * UserInterface/Images/gtk/Pause.svg: Optimized.
1892         * UserInterface/Images/gtk/PausedBreakpoint.svg: Optimized.
1893         * UserInterface/Images/gtk/Pencil.svg: Optimized.
1894         * UserInterface/Images/gtk/Plus.svg: Optimized. Text element
1895         converted into a shape.
1896         * UserInterface/Images/gtk/PseudoElement.svg: Optimized.
1897         * UserInterface/Images/gtk/Record.svg: Optimized.
1898         * UserInterface/Images/gtk/Reflection.svg: Optimized.
1899         * UserInterface/Images/gtk/ReloadFull.svg: Optimized.
1900         * UserInterface/Images/gtk/ReplayPauseButton.svg: Optimized.
1901         * UserInterface/Images/gtk/ReplayPlayButton.svg: Optimized.
1902         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Optimized.
1903         * UserInterface/Images/gtk/Request.svg: Optimized.
1904         * UserInterface/Images/gtk/Resources.svg: Optimized.
1905         * UserInterface/Images/gtk/Response.svg: Optimized.
1906         * UserInterface/Images/gtk/ResultLine.svg: Optimized.
1907         * UserInterface/Images/gtk/Resume.svg: Optimized.
1908         * UserInterface/Images/gtk/ShadowDOM.svg: Optimized.
1909         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Optimized.
1910         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Optimized.
1911         * UserInterface/Images/gtk/SplitToggleUp.svg: Optimized.
1912         * UserInterface/Images/gtk/StepInto.svg: Optimized.
1913         * UserInterface/Images/gtk/StepOut.svg: Optimized.
1914         * UserInterface/Images/gtk/StepOver.svg: Optimized.
1915         * UserInterface/Images/gtk/Stop.svg: Optimized.
1916         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Optimized.
1917         * UserInterface/Images/gtk/StyleRuleInherited.svg: Optimized.
1918         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Optimized.
1919         * UserInterface/Images/gtk/StyleRuleInspector.svg: Optimized.
1920         * UserInterface/Images/gtk/StyleRuleUser.svg: Optimized.
1921         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Optimized.
1922         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Optimized.
1923         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Optimized.
1924         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Optimized.
1925         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Optimized.
1926         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Optimized.
1927         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Optimized.
1928         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Optimized.
1929         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Optimized.
1930         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Optimized.
1931         * UserInterface/Images/gtk/TypeBoolean.svg: Optimized.
1932         * UserInterface/Images/gtk/TypeNull.svg: Optimized.
1933         * UserInterface/Images/gtk/TypeNumber.svg: Optimized.
1934         * UserInterface/Images/gtk/TypeObject.svg: Optimized.
1935         * UserInterface/Images/gtk/TypeRegex.svg: Optimized. Removed
1936         mistaken extra shape.
1937         * UserInterface/Images/gtk/TypeString.svg: Optimized.
1938         * UserInterface/Images/gtk/TypeSymbol.svg: Optimized. Removed
1939         mistaken extra shape.
1940         * UserInterface/Images/gtk/TypeUndefined.svg: Optimized.
1941         * UserInterface/Images/gtk/Undock.svg: Optimized.
1942         * UserInterface/Images/gtk/UpDownArrows.svg: Optimized.
1943         * UserInterface/Images/gtk/UserInputPrompt.svg: Optimized.
1944         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Optimized.
1945         * UserInterface/Images/gtk/UserInputResult.svg: Optimized.
1946         * UserInterface/Images/gtk/Warning.svg: Optimized.
1947
1948 2015-05-05  Timothy Hatcher  <timothy@apple.com>
1949
1950         REGRESSION: Web Inspector: no way to navigate to a resource/source location from overview timeline view
1951         https://bugs.webkit.org/show_bug.cgi?id=144539
1952
1953         Reviewed by Brian Burg.
1954
1955         * UserInterface/Views/GeneralTreeElement.js:
1956         (WebInspector.GeneralTreeElement.prototype.set status): Call didChange() so the onchange event fires. This allows
1957         TimelineSidebarPanel to update the status element when it goes from a spinner to empty for ResourceTreeElements.
1958         (WebInspector.GeneralTreeElement.prototype.onattach): Don't call _updateStatusElement, just append it if needed.
1959         Calling _updateStatusElement caused DOMNodeFragments as status elements to be appended a second time and fail.
1960         * UserInterface/Views/NavigationSidebarPanel.js:
1961         (WebInspector.NavigationSidebarPanel.prototype.treeElementAddedOrChanged):
1962         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
1963         * UserInterface/Views/NetworkTimelineView.js:
1964         (WebInspector.NetworkTimelineView.prototype.canShowContentViewForTreeElement):
1965         (WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement):
1966         (WebInspector.NetworkTimelineView.prototype.treeElementSelected):
1967         (WebInspector.NetworkTimelineView.prototype._dataGridNodeSelected):
1968         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
1969         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked): Deleted.
1970         * UserInterface/Views/OverviewTimelineView.js:
1971         (WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement):
1972         (WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement):
1973         (WebInspector.OverviewTimelineView.prototype._dataGridNodeSelected):
1974         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected): Deleted.
1975         (WebInspector.OverviewTimelineView.prototype._treeElementSelected): Deleted.
1976         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
1977         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked): Deleted.
1978         * UserInterface/Views/RenderingFrameTimelineView.js:
1979         (WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement):
1980         (WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement):
1981         * UserInterface/Views/ResourceTimelineDataGridNode.js:
1982         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent): Don't show a go-to arrow in the Domain column.
1983         (WebInspector.ResourceTimelineDataGridNode.prototype._goToResource): Deleted.
1984         * UserInterface/Views/ScriptTimelineView.js:
1985         (WebInspector.ScriptTimelineView.prototype.canShowContentViewForTreeElement):
1986         (WebInspector.ScriptTimelineView.prototype.showContentViewForTreeElement):
1987         (WebInspector.ScriptTimelineView.prototype.treeElementSelected):
1988         * UserInterface/Views/TimelineRecordTreeElement.js:
1989         (WebInspector.TimelineRecordTreeElement.prototype.get sourceCodeLocation):
1990         * UserInterface/Views/TimelineSidebarPanel.css:
1991         (.sidebar > .panel.navigation.timeline .item:hover:not(.selected) .status .close.status-button):
1992         (.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .status .go-to-arrow.status-button):
1993         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .status .close.status-button):
1994         * UserInterface/Views/TimelineSidebarPanel.js:
1995         (WebInspector.TimelineSidebarPanel.prototype.treeElementAddedOrChanged): Added.
1996         (WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
1997         (WebInspector.TimelineSidebarPanel.prototype._treeElementGoToArrowWasClicked): Added.
1998         (WebInspector.TimelineSidebarPanel.prototype._treeElementCloseButtonClicked): Added.
1999         * UserInterface/Views/TimelineView.js:
2000         (WebInspector.TimelineView):
2001         (WebInspector.TimelineView.prototype.canShowContentViewForTreeElement):
2002         (WebInspector.TimelineView.prototype.showContentViewForTreeElement):
2003         (WebInspector.TimelineView.prototype.treeElementDeselected):
2004         (WebInspector.TimelineView.prototype.treeElementSelected):
2005         (WebInspector.TimelineView.prototype.needsLayout):
2006         (WebInspector.TimelineView.prototype._closeStatusButtonClicked): Deleted.
2007         (WebInspector.TimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2008         * UserInterface/Views/TreeElementStatusButton.css:
2009         (.item > .status > .status-button): Fix an alignment issue with close and go-to arrows being side-by-side.
2010         Does not happen in the final patch because they are mutually exclusive, but still good to fix.
2011
2012 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2013
2014         Web Inspector: Fix some issues with Search tabs
2015         https://bugs.webkit.org/show_bug.cgi?id=144531
2016
2017         Reviewed by Darin Adler.
2018
2019         * UserInterface/Views/ContentView.js:
2020         (WebInspector.ContentView):
2021         (WebInspector.ContentView.isViewable):
2022         Support DOMSearchMatchObject and SourceCodeSearchMatchObject representedObjects. These are usually
2023         handled at a higher level, but cookie restoring requires ContentView to handle them.
2024
2025         * UserInterface/Views/DOMTreeContentView.js:
2026         (WebInspector.DOMTreeContentView):
2027         (WebInspector.DOMTreeContentView.prototype.selectAndRevealDOMNode):
2028         (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
2029         (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
2030         Don't allow restoring the previous selected node when another not has already been selected.
2031
2032         * UserInterface/Views/SearchTabContentView.js:
2033         (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
2034         Allow Script objects to be shown in the Search tab.
2035
2036 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2037
2038         Web Inspector: Source/WebInspectorUI/UserInterface/Images/Logs.svg has unknown attribute "fille"
2039         https://bugs.webkit.org/show_bug.cgi?id=144627
2040
2041         Reviewed by Darin Adler.
2042
2043         * UserInterface/Images/Logs.svg: Change "fille" to "fill".
2044
2045 2015-05-05  Andres Gomez  <agomez@igalia.com>
2046
2047         [GTK] Web Inspector: New Images added in r183339, r183338, r183332, r183323, r182660, and r182186
2048         https://bugs.webkit.org/show_bug.cgi?id=144329
2049
2050         Reviewed by Joseph Pecoraro.
2051
2052         * UserInterface/Images/gtk/Console.svg: Added.
2053         * UserInterface/Images/gtk/Debugger.svg: Added.
2054         * UserInterface/Images/gtk/Elements.svg: Added.
2055         * UserInterface/Images/gtk/Gear.svg: Added.
2056         * UserInterface/Images/gtk/NewTab.svg: Added.
2057         * UserInterface/Images/gtk/NewTabPlus.svg: Added.
2058         * UserInterface/Images/gtk/ReloadToolbar.svg: Added.
2059         * UserInterface/Images/gtk/SearchResults.svg: Added.
2060         * UserInterface/Images/gtk/Storage.svg: Added.
2061         * UserInterface/Images/gtk/Timeline.svg: Added.
2062         * UserInterface/Images/gtk/TimelineRecordRenderingFrame.svg: Added.
2063         * UserInterface/Images/gtk/ToggleLeftSidebar.svg: Added.
2064         * UserInterface/Images/gtk/ToggleRightSidebar.svg: Added.
2065
2066 2015-05-05  Andres Gomez  <agomez@igalia.com>
2067
2068         [GTK] Web Inspector: icons for console.info() messages
2069         https://bugs.webkit.org/show_bug.cgi?id=144461
2070
2071         Reviewed by Joseph Pecoraro.
2072
2073         * UserInterface/Images/gtk/Debug.svg: Added.
2074         * UserInterface/Images/gtk/Info.svg: Added.
2075         * UserInterface/Images/gtk/Log.svg: Added.
2076
2077 2015-05-04  Joseph Pecoraro  <pecoraro@apple.com>
2078
2079         Web Inspector: Always expand initial top level DOM tree nodes when not including the root (frame views)
2080         https://bugs.webkit.org/show_bug.cgi?id=144607
2081
2082         Reviewed by Timothy Hatcher.
2083
2084         * UserInterface/Views/DOMTreeOutline.js:
2085         (WebInspector.DOMTreeOutline.prototype.update):
2086
2087 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2088
2089         Web Inspector: Allow closing and reopening the Debugger tab
2090         https://bugs.webkit.org/show_bug.cgi?id=144536
2091
2092         Reviewed by Joseph Pecoraro.
2093
2094         * UserInterface/Base/Main.js:
2095         (WebInspector._updateNewTabButtonState):
2096         * UserInterface/Views/DebuggerSidebarPanel.js:
2097         (WebInspector.DebuggerSidebarPanel):
2098         (WebInspector.DebuggerSidebarPanel.prototype.closed):
2099         (WebInspector.DebuggerSidebarPanel.prototype._addIssuesForSourceCode):
2100         (WebInspector.DebuggerSidebarPanel.prototype._addResourcesRecursivelyForFrame):
2101         (WebInspector.DebuggerSidebarPanel.prototype._resourceAdded):
2102         (WebInspector.DebuggerSidebarPanel.prototype._addResource):
2103         (WebInspector.DebuggerSidebarPanel.prototype._mainResourceChanged):
2104         (WebInspector.DebuggerSidebarPanel.prototype._scriptAdded):
2105         (WebInspector.DebuggerSidebarPanel.prototype._addScript):
2106         * UserInterface/Views/DebuggerTabContentView.js:
2107         (WebInspector.DebuggerTabContentView):
2108         * UserInterface/Views/NewTabContentView.js:
2109         (WebInspector.NewTabContentView):
2110
2111 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2112
2113         REGRESSION: Web Inspector: FrameTreeElement does not folders properly when loading a page
2114         https://bugs.webkit.org/show_bug.cgi?id=144535
2115
2116         Reviewed by Joseph Pecoraro.
2117
2118         * UserInterface/Views/FolderizedTreeElement.js:
2119         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject): Fix an exception if not in a tree.
2120         (WebInspector.FolderizedTreeElement.prototype.prepareToPopulate):
2121         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
2122
2123 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2124
2125         Web Inspector: Allow closing and reopening the Timelines tab
2126         https://bugs.webkit.org/show_bug.cgi?id=144520
2127
2128         Reviewed by Joseph Pecoraro.
2129
2130         * UserInterface/Base/Main.js:
2131         (WebInspector._updateNewTabButtonState):
2132         * UserInterface/Controllers/TimelineManager.js:
2133         (WebInspector.TimelineManager): No need for a delay now. Call reset().
2134         (WebInspector.TimelineManager.prototype.reset):
2135         (WebInspector.TimelineManager.delayedWork): Deleted.
2136         * UserInterface/Views/ContentBrowserTabContentView.js:
2137         (WebInspector.ContentBrowserTabContentView):
2138         (WebInspector.ContentBrowserTabContentView.prototype.closed):
2139         * UserInterface/Views/LayoutTimelineView.js:
2140         (WebInspector.LayoutTimelineView.prototype.closed): Added. Fixed leak.
2141         * UserInterface/Views/NetworkTimelineView.js:
2142         (WebInspector.NetworkTimelineView.prototype.closed): Added. Fixed leak.
2143         * UserInterface/Views/NewTabContentView.js:
2144         (WebInspector.NewTabContentView): Added Timelines.
2145         * UserInterface/Views/OverviewTimelineView.js:
2146         (WebInspector.OverviewTimelineView.prototype.closed): Added. Fixed leak.
2147         * UserInterface/Views/RenderingFrameTimelineView.js:
2148         (WebInspector.RenderingFrameTimelineView.prototype.closed): Added. Fixed leak.
2149         * UserInterface/Views/ScriptTimelineView.js:
2150         (WebInspector.ScriptTimelineView.prototype.closed):
2151         * UserInterface/Views/SearchTabContentView.js:
2152         (WebInspector.SearchTabContentView.prototype.closed): Deleted. Made generic
2153         in ContentBrowserTabContentView.prototype.closed.
2154         * UserInterface/Views/TabBrowser.js:
2155         (WebInspector.TabBrowser.prototype._tabBarItemSelected): Fix a potential exception
2156         when selectedTabBarItem is null.
2157         * UserInterface/Views/TimelineSidebarPanel.js:
2158         (WebInspector.TimelineSidebarPanel):
2159         (WebInspector.TimelineSidebarPanel.prototype.closed):
2160         (WebInspector.TimelineSidebarPanel._recordingCreated): Call _addRecording.
2161         (WebInspector.TimelineSidebarPanel._addRecording): Added.
2162         * UserInterface/Views/TimelineTabContentView.js:
2163         (WebInspector.TimelineTabContentView):
2164
2165 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2166
2167         Web Inspector: Switching recordings in the Timeline navigation bar is broken
2168         https://bugs.webkit.org/show_bug.cgi?id=144519
2169
2170         Reviewed by Joseph Pecoraro.
2171
2172         * UserInterface/Views/ContentBrowser.js:
2173         (WebInspector.ContentBrowser.prototype._hierarchicalPathComponentWasSelected): Use revealAndSelect
2174         on the TreeElement instead of showing the representedObject directly. This fixes an exception in
2175         TimelineRecordingContentView where it wouldn't be initialized with the TimelineSidebarPanel extra argument.
2176         * UserInterface/Views/TimelineOverview.js:
2177         (WebInspector.TimelineOverview.prototype.get visibleDuration): Fix an annoying assert. We show the view
2178         early in construction, before it is in the document. Future updateLayout calls work and fix this.
2179         * UserInterface/Views/TimelineRecordingContentView.js:
2180         (WebInspector.TimelineRecordingContentView.prototype.shown): Call _currentContentViewDidChange
2181         to trigger the sidebar to update when this recording view is shown.
2182         * UserInterface/Views/TimelineSidebarPanel.js:
2183         (WebInspector.TimelineSidebarPanel.prototype._recordingsTreeElementSelected): Moved code from here...
2184         (WebInspector.TimelineSidebarPanel.prototype._recordingSelected): ... to here. Take two different paths
2185         to state restoration here. If the view existed before, use its state. If now, use the current state that
2186         is captured by the cookie logic and explicitly restore it.
2187
2188 2015-05-03  Timothy Hatcher  <timothy@apple.com>
2189
2190         Web Inspector: Exception under ContentViewContainer _disassociateFromContentView
2191         https://bugs.webkit.org/show_bug.cgi?id=144546
2192
2193         Reviewed by Brian Burg.
2194
2195         * UserInterface/Views/ContentViewContainer.js:
2196         (WebInspector.ContentViewContainer.prototype.showContentView):
2197         Make sure to pass the ContentView to _disassociateFromContentView. Also negate the result
2198         of the _backForwardList.some(), since we don't want to dissociate if the content view is
2199         still in the back-forward list.
2200
2201 2015-05-02  Matt Baker  <mattbaker@apple.com>
2202
2203         Web Inspector: Relocate the selected range details in the Rendering Frames timeline UI
2204         https://bugs.webkit.org/show_bug.cgi?id=144346
2205
2206         This patch removes the details sidebar used by the rendering frames view, and relocates the frame selection
2207         chart the Timelines navigation sidebar.
2208
2209         Reviewed by Timothy Hatcher.
2210
2211         * Localizations/en.lproj/localizedStrings.js:
2212         * UserInterface/Base/Main.js:
2213         (WebInspector.contentLoaded):
2214         RenderingFramesDetailsSidebar is no longer used.
2215
2216         * UserInterface/Controllers/TimelineManager.js:
2217         (WebInspector.TimelineManager.prototype._loadNewRecording):
2218         Reordered timelines.
2219
2220         * UserInterface/Main.html:
2221         Removed references to deleted files.
2222
2223         * UserInterface/Views/ChartDetailsSectionLegendRow.js: Removed.
2224         No longer used. The legend is now a child element of the chart.
2225
2226         * UserInterface/Views/ChartDetailsSectionRow.css:
2227         (.details-section > .content > .group > .row.chart > .title):
2228         (.details-section > .content > .group > .row.chart > .chart-content):
2229         (.details-section > .content > .group > .row.chart > .chart-content > .legend):
2230         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item):
2231         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label > .color-swatch):
2232         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label):
2233         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .value):
2234         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > *):
2235         New chart and legend styles.
2236
2237         * UserInterface/Views/ChartDetailsSectionRow.js:
2238         (WebInspector.ChartDetailsSectionRow):
2239         (WebInspector.ChartDetailsSectionRow.prototype.set title):
2240         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2241         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius):
2242         (WebInspector.ChartDetailsSectionRow.prototype.get total):
2243         (WebInspector.ChartDetailsSectionRow.set data):
2244         (WebInspector.ChartDetailsSectionRow.prototype.set data):
2245         (WebInspector.ChartDetailsSectionRow.prototype._createLegendItem):
2246         (WebInspector.ChartDetailsSectionRow.prototype._refresh):
2247
2248         A few changes have been made to the appearance and behavior of the chart. A chart title can now be set,
2249         and the legend appears to the right of the chart rather than in a separate details group.
2250
2251         The chart now has better support for adding empty data points, ensuring that a meaningful legend is shown even
2252         when no rendering frames are selected in the timeline overview graph. This ensures that the task associated
2253         with each colored frame segment is apparent, without having to make a selection or record a timeline.
2254
2255         * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js: Removed.
2256         No longer used.
2257
2258         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
2259         Reduced maximum timeline height to increase the height of short frames.
2260
2261         * UserInterface/Views/RenderingFrameTimelineView.js:
2262         (WebInspector.RenderingFrameTimelineView.prototype.shown):
2263         (WebInspector.RenderingFrameTimelineView.prototype.hidden):
2264         RenderingFramesDetailsSidebar is no longer used.
2265
2266         * UserInterface/Views/TimelineRecordingContentView.js:
2267         (WebInspector.TimelineRecordingContentView):
2268         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
2269         (WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
2270         (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
2271         (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
2272         (WebInspector.TimelineRecordingContentView.prototype._updateFrameSelection):
2273         Improved logic for updating the frame selection.
2274
2275         * UserInterface/Views/TimelineSidebarPanel.css:
2276         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > div.header):
2277         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > .content > .group > .row.chart):
2278         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > .content > .group > .row.chart > .chart-content > .chart):
2279         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content): Deleted.
2280         New chart styles.
2281
2282         * UserInterface/Views/TimelineSidebarPanel.js:
2283         (WebInspector.TimelineSidebarPanel):
2284         (WebInspector.TimelineSidebarPanel.prototype.shown):
2285         (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
2286         (WebInspector.TimelineSidebarPanel.this._timelineTreeElementMap.get select):
2287         (WebInspector.TimelineSidebarPanel.get else):
2288         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.getSelectedRecords.get var):
2289         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.getSelectedRecords):
2290         (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
2291         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
2292         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
2293         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.durationForRecordType):
2294         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
2295         (WebInspector.TimelineSidebarPanel.set contentTreeOutlineLabel): Deleted.
2296         (WebInspector.TimelineSidebarPanel._recordingCreated.set this): Deleted.
2297         (WebInspector.TimelineSidebarPanel.get this): Deleted.
2298         Moved the selected frames chart to the navigation sidebar.
2299
2300         * UserInterface/Views/TimelineTabContentView.js:
2301         (WebInspector.TimelineTabContentView):
2302         RenderingFramesDetailsSidebar is no longer used.
2303
2304         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2305         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2306         Removed references to deleted files.
2307
2308 2015-05-02  Timothy Hatcher  <timothy@apple.com>
2309
2310         Web Inspector: Allow closing and reopening the Resources tab
2311         https://bugs.webkit.org/show_bug.cgi?id=144513
2312
2313         Reviewed by Joseph Pecoraro.
2314
2315         * UserInterface/Base/Main.js:
2316         (WebInspector._updateNewTabButtonState):
2317         * UserInterface/Views/NewTabContentView.js:
2318         (WebInspector.NewTabContentView):
2319         * UserInterface/Views/ResourceSidebarPanel.js:
2320         (WebInspector.ResourceSidebarPanel):
2321         (WebInspector.ResourceSidebarPanel.prototype.closed):
2322         * UserInterface/Views/ResourcesTabContentView.js:
2323         (WebInspector.ResourcesTabContentView):
2324
2325 2015-05-02  Timothy Hatcher  <timothy@apple.com>
2326
2327         Web Inspector: REGRESSION: Resources section doesn't update after changes are made to a local file
2328         https://bugs.webkit.org/show_bug.cgi?id=144512
2329
2330         The content view was being associated with the wrong represented object. This caused the code to use
2331         the old main resource when showing the frame again.
2332
2333         Reviewed by Joseph Pecoraro.
2334
2335         * UserInterface/Base/Main.js:
2336         (WebInspector._frameWasAdded.delayedWork):
2337         (WebInspector._frameWasAdded):
2338         With the changes in ResourceSidebarPanel, we need to delay showing the frame.
2339
2340         * UserInterface/Views/ContentBrowserTabContentView.js:
2341         (WebInspector.ContentBrowserTabContentView.prototype.showRepresentedObject):
2342         Avoid restoring state by calling cancelRestoringState(). Not fully related to this bug,
2343         but it was preventing testing the cases.
2344
2345         * UserInterface/Views/ContentViewContainer.js:
2346         (WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
2347         This fixes the bug. Don't associate the content view with the Frame, associate it with
2348         the Resource that we actually show.
2349
2350         * UserInterface/Views/NavigationSidebarPanel.js:
2351         (WebInspector.NavigationSidebarPanel.prototype.cancelRestoringState): Added.
2352
2353         * UserInterface/Views/ResourceSidebarPanel.js:
2354         (WebInspector.ResourceSidebarPanel): Remove unused _waitingForInitialMainFrame.
2355         (WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
2356         (WebInspector.ResourceSidebarPanel.prototype._mainResourceDidChange):
2357         (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
2358         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2359         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2360         Clean up how we show the main frame in the sidebar. This was a two step mess before.
2361
2362 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2363
2364         Web Inspector: Remove FrameContentView.js
2365         https://bugs.webkit.org/show_bug.cgi?id=144415
2366
2367         Reviewed by Joseph Pecoraro.
2368
2369         * UserInterface/Images/DOMTree.svg: Removed.
2370         * UserInterface/Images/SourceCode.svg: Removed.
2371         * UserInterface/Main.html: Removed FrameContentView.js.
2372         * UserInterface/Views/FrameContentView.js: Removed.
2373         * UserInterface/Views/PathComponentIcons.css:
2374         (.source-code-icon .icon): Deleted.
2375         (.dom-tree-icon .icon): Deleted.
2376
2377         * UserInterface/Views/ResourceSidebarPanel.js:
2378         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2379         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2380         Simplify the code here. We don't need these checks now with tabs and the Storage tab.
2381
2382 2015-04-30  Nikita Vasilyev  <nvasilyev@apple.com>
2383
2384         REGRESSION: Web Inspector: Console message repeat count overlapped by icon
2385         https://bugs.webkit.org/show_bug.cgi?id=144344
2386
2387         Reviewed by Timothy Hatcher.
2388
2389         * UserInterface/Views/ConsoleMessageView.css:
2390         (.console-message .repeat-count):
2391
2392 2015-04-30  Jon Davis  <jond@apple.com>
2393
2394         Web Inspector: console should show an icon for console.info() messages
2395         https://bugs.webkit.org/show_bug.cgi?id=18530
2396
2397         Reviewed by Timothy Hatcher.
2398
2399         Added icons for console.log, console.info and console.debug messages.
2400
2401         Separated console.info from console.log.
2402
2403         * UserInterface/Images/Debug.svg: Added.
2404         * UserInterface/Images/Info.svg: Added.
2405         * UserInterface/Images/Log.svg: Added.
2406         New icon files.
2407
2408         * UserInterface/Models/ConsoleMessage.js:
2409         * UserInterface/Views/ConsoleMessageView.css:
2410         (.console-log-level::before):
2411         (.console-info-level::before):
2412         (.console-debug-level::before):
2413         (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level).console-message):
2414         (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level)::before):
2415         (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message): Deleted.
2416         (:matches(.console-warning-level, .console-error-level, .console-log-level)::before): Deleted.
2417         Include console.info messages in layout adjustments.
2418
2419         * UserInterface/Views/ConsoleMessageView.js:
2420         (WebInspector.ConsoleMessageView):
2421         (WebInspector.ConsoleMessageView.prototype._levelString):
2422
2423 2015-04-30  Timothy Hatcher  <timothy@apple.com>
2424
2425         Web Inspector: Scope Chain sidebar should be selected immediately when paused
2426         https://bugs.webkit.org/show_bug.cgi?id=144352
2427
2428         Reviewed by Joseph Pecoraro.
2429
2430         * UserInterface/Base/Main.js:
2431         (WebInspector.showDebuggerTab): Added showScopeChainDetailsSidebarPanel argument.
2432         (WebInspector._debuggerDidPause): Pass true for showScopeChainDetailsSidebarPanel.
2433         * UserInterface/Views/ContentBrowserTabContentView.js:
2434         (WebInspector.ContentBrowserTabContentView): Wire the event to showDetailsSidebarPanels instead of
2435         _contentBrowserRepresentedObjectsDidChange, allowing subclasses to do work during the event.
2436         (WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels): Moved content of
2437         _contentBrowserRepresentedObjectsDidChange here.
2438         (WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange): Deleted.
2439         * UserInterface/Views/DebuggerTabContentView.js:
2440         (WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels): Added. Show the scope sidebar panel
2441         if it is available and it was requested by showScopeChainDetailsSidebarPanel().
2442         (WebInspector.DebuggerTabContentView.prototype.showScopeChainDetailsSidebarPanel): Added.
2443
2444 2015-04-30  Andres Gomez  <agomez@igalia.com>
2445
2446         [GTK] Web Inspector: New Images for ObjectTreeView - Setter
2447         https://bugs.webkit.org/show_bug.cgi?id=143173
2448
2449         Reviewed by Martin Robinson.
2450
2451         * UserInterface/Images/gtk/Pencil.svg: Added.
2452
2453 2015-04-30  Andres Gomez  <agomez@igalia.com>
2454
2455         [GTK] Web Inspector: Remove some unused Images
2456         https://bugs.webkit.org/show_bug.cgi?id=144445
2457
2458         Reviewed by Carlos Garcia Campos.
2459
2460         * UserInterface/Images/gtk/BottomUpTree.svg: Removed.
2461         * UserInterface/Images/gtk/Log.png: Removed.
2462         * UserInterface/Images/gtk/Log@2x.png: Removed.
2463         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Removed.
2464         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Removed.
2465         * UserInterface/Images/gtk/NavigationItemBug.svg: Removed.
2466         * UserInterface/Images/gtk/NavigationItemFile.svg: Removed.
2467         * UserInterface/Images/gtk/NavigationItemLayers.svg: Removed.
2468         * UserInterface/Images/gtk/NavigationItemLog.svg: Removed.
2469         * UserInterface/Images/gtk/NavigationItemProbes.svg: Removed.
2470         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Removed.
2471         * UserInterface/Images/gtk/NavigationItemStorage.svg: Removed.
2472         * UserInterface/Images/gtk/NavigationItemVariable.svg: Removed.
2473         * UserInterface/Images/gtk/Percent.svg: Removed.
2474         * UserInterface/Images/gtk/Reload.svg: Removed.
2475         * UserInterface/Images/gtk/SplitToggleDown.svg: Removed.
2476         * UserInterface/Images/gtk/Time.svg: Removed.
2477         * UserInterface/Images/gtk/Weight.svg: Removed.
2478
2479 2015-04-30  Joseph Pecoraro  <pecoraro@apple.com>
2480
2481         Web Inspector: Copy not working in Console
2482         https://bugs.webkit.org/show_bug.cgi?id=144354
2483
2484         Reviewed by Timothy Hatcher.
2485
2486         * UserInterface/Base/Main.js:
2487         (WebInspector._focusedContentView):
2488         Select the inner most content view to check if handleCopyEvent exists.
2489         Previously we were stopping at the top level TabContentView.
2490
2491 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2492
2493         Web Inspector: Remove some unused Images
2494         https://bugs.webkit.org/show_bug.cgi?id=144412
2495
2496         Reviewed by Joseph Pecoraro.
2497
2498         * UserInterface/Images/BottomUpTree.svg: Removed.
2499         * UserInterface/Images/Log.png: Removed.
2500         * UserInterface/Images/Log@2x.png: Removed.
2501         * UserInterface/Images/NavigationItemAngleBrackets.svg: Removed.
2502         * UserInterface/Images/NavigationItemBrushAndRuler.svg: Removed.
2503         * UserInterface/Images/NavigationItemBug.svg: Removed.
2504         * UserInterface/Images/NavigationItemDoughnutChart.svg: Removed.
2505         * UserInterface/Images/NavigationItemFile.svg: Removed.
2506         * UserInterface/Images/NavigationItemLayers.svg: Removed.
2507         * UserInterface/Images/NavigationItemLog.svg: Removed.
2508         * UserInterface/Images/NavigationItemProbes.svg: Removed.
2509         * UserInterface/Images/NavigationItemStopwatch.svg: Removed.
2510         * UserInterface/Images/NavigationItemStorage.svg: Removed.
2511         * UserInterface/Images/NavigationItemVariable.svg: Removed.
2512         * UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Removed.
2513         * UserInterface/Images/NetworkBarLabelCalloutRight.svg: Removed.
2514         * UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Removed.
2515         * UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Removed.
2516         * UserInterface/Images/Percent.svg: Removed.
2517         * UserInterface/Images/Reload.svg: Removed.
2518         * UserInterface/Images/SplitToggleDown.svg: Removed.
2519         * UserInterface/Images/Time.svg: Removed.
2520         * UserInterface/Images/Weight.svg: Removed.
2521
2522 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2523
2524         Web Inspector: Split Storage from Resources tab
2525         https://bugs.webkit.org/show_bug.cgi?id=144404
2526
2527         Reviewed by Joseph Pecoraro.
2528
2529         * Localizations/en.lproj/localizedStrings.js:
2530         * UserInterface/Base/Main.js:
2531         (WebInspector.loaded):
2532         (WebInspector.isTabTypeAllowed):
2533         (WebInspector._tabContentViewForType):
2534         (WebInspector._updateNewTabButtonState):
2535         (WebInspector.showStorageTab):
2536         (WebInspector._storageWasInspected):
2537         * UserInterface/Controllers/ApplicationCacheManager.js:
2538         (WebInspector.ApplicationCacheManager.prototype.initialize):
2539         (WebInspector.ApplicationCacheManager.prototype.get applicationCacheObjects):
2540         * UserInterface/Controllers/StorageManager.js:
2541         (WebInspector.StorageManager.prototype.get domStorageObjects):
2542         (WebInspector.StorageManager.prototype.get databases):
2543         (WebInspector.StorageManager.prototype.get indexedDatabases):
2544         (WebInspector.StorageManager.prototype.get cookieStorageObjects):
2545         * UserInterface/Images/Storage.svg: Added.
2546         * UserInterface/Main.html:
2547         * UserInterface/Views/DatabaseTableContentView.js:
2548         (WebInspector.DatabaseTableContentView.prototype._queryFinished): Clear _dataGrid,
2549         since it might have been allocated but still be empty. This avoids an exception in
2550         updateLayout next time layout is updated.
2551         * UserInterface/Views/NewTabContentView.js:
2552         (WebInspector.NewTabContentView):
2553         * UserInterface/Views/ResourceSidebarPanel.js:
2554         (WebInspector.ResourceSidebarPanel):
2555         (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
2556         (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded): Deleted.
2557         (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasInspected): Deleted.
2558         (WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded): Deleted.
2559         (WebInspector.ResourceSidebarPanel.prototype._databaseWasInspected): Deleted.
2560         (WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded): Deleted.
2561         (WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded): Deleted.
2562         (WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded): Deleted.
2563         (WebInspector.ResourceSidebarPanel.prototype._frameManifestRemoved): Deleted.
2564         (WebInspector.ResourceSidebarPanel.prototype._addStorageChild): Deleted.
2565         (WebInspector.ResourceSidebarPanel.prototype._storageCleared): Deleted.
2566         * UserInterface/Views/ResourcesTabContentView.js:
2567         (WebInspector.ResourcesTabContentView):
2568         (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
2569         * UserInterface/Views/StorageSidebarPanel.js: Added.
2570         (WebInspector.StorageSidebarPanel):
2571         (WebInspector.StorageSidebarPanel.prototype.showDefaultContentView):
2572         (WebInspector.StorageSidebarPanel.prototype.closed):
2573         (WebInspector.StorageSidebarPanel.prototype._treeElementSelected):
2574         (WebInspector.StorageSidebarPanel.prototype._domStorageObjectWasAdded):
2575         (WebInspector.StorageSidebarPanel.prototype._addDOMStorageObject):
2576         (WebInspector.StorageSidebarPanel.prototype._domStorageObjectWasInspected):
2577         (WebInspector.StorageSidebarPanel.prototype._databaseWasAdded):
2578         (WebInspector.StorageSidebarPanel.prototype._addDatabase):
2579         (WebInspector.StorageSidebarPanel.prototype._databaseWasInspected):
2580         (WebInspector.StorageSidebarPanel.prototype._indexedDatabaseWasAdded):
2581         (WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
2582         (WebInspector.StorageSidebarPanel.prototype._cookieStorageObjectWasAdded):
2583         (WebInspector.StorageSidebarPanel.prototype._addCookieStorageObject):
2584         (WebInspector.StorageSidebarPanel.prototype._frameManifestAdded):
2585         (WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
2586         (WebInspector.StorageSidebarPanel.prototype._frameManifestRemoved):
2587         (WebInspector.StorageSidebarPanel.prototype._compareTreeElements):
2588         (WebInspector.StorageSidebarPanel.prototype._addStorageChild):
2589         (WebInspector.StorageSidebarPanel.prototype._storageCleared):
2590         * UserInterface/Views/StorageTabContentView.js: Copied from Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js.
2591         (WebInspector.StorageTabContentView):
2592         (WebInspector.StorageTabContentView.prototype.get type):
2593         (WebInspector.StorageTabContentView.prototype.canShowRepresentedObject):
2594
2595 2015-04-29  Timothy Hatcher  <timothy@apple.com>
2596
2597         Web Inspector: Remove Legacy images and styles
2598         https://bugs.webkit.org/show_bug.cgi?id=144390
2599
2600         Reviewed by Joseph Pecoraro.
2601
2602         * UserInterface/Base/ImageUtilities.js:
2603         (.generateImage):
2604         (.generateImage.generateLegacyImage): Deleted.
2605         * UserInterface/Base/Main.js:
2606         (WebInspector.contentLoaded):
2607         (WebInspector._updateToolbarHeight):
2608         * UserInterface/Base/Platform.js:
2609         * UserInterface/Controllers/TimelineManager.js:
2610         (WebInspector.TimelineManager.prototype._loadNewRecording):
2611         * UserInterface/Images/Legacy/BackArrow.svg: Removed.
2612         * UserInterface/Images/Legacy/Breakpoints.svg: Removed.
2613         * UserInterface/Images/Legacy/Close.svg: Removed.
2614         * UserInterface/Images/Legacy/CloseLarge.svg: Removed.
2615         * UserInterface/Images/Legacy/Colors.png: Removed.
2616         * UserInterface/Images/Legacy/Colors@2x.png: Removed.
2617         * UserInterface/Images/Legacy/ColorsLarge.png: Removed.
2618         * UserInterface/Images/Legacy/ColorsLarge@2x.png: Removed.
2619         * UserInterface/Images/Legacy/DockBottom.svg: Removed.
2620         * UserInterface/Images/Legacy/DockRight.svg: Removed.
2621         * UserInterface/Images/Legacy/DownloadArrow.svg: Removed.
2622         * UserInterface/Images/Legacy/Errors.svg: Removed.
2623         * UserInterface/Images/Legacy/ErrorsEnabled.svg: Removed.
2624         * UserInterface/Images/Legacy/FilterFieldGlyph.svg: Removed.
2625         * UserInterface/Images/Legacy/FolderGeneric.png: Removed.
2626         * UserInterface/Images/Legacy/FolderGeneric@2x.png: Removed.
2627         * UserInterface/Images/Legacy/ForwardArrow.svg: Removed.
2628         * UserInterface/Images/Legacy/Issues.svg: Removed.
2629         * UserInterface/Images/Legacy/IssuesEnabled.svg: Removed.
2630         * UserInterface/Images/Legacy/LayerBorders.svg: Removed.
2631         * UserInterface/Images/Legacy/Logs.svg: Removed.
2632         * UserInterface/Images/Legacy/NavigationItemCurleyBraces.svg: Removed.
2633         * UserInterface/Images/Legacy/NavigationItemTrash.svg: Removed.
2634         * UserInterface/Images/Legacy/Network.png: Removed.
2635         * UserInterface/Images/Legacy/Network@2x.png: Removed.
2636         * UserInterface/Images/Legacy/NetworkLarge.png: Removed.
2637         * UserInterface/Images/Legacy/NetworkLarge@2x.png: Removed.
2638         * UserInterface/Images/Legacy/Pause.svg: Removed.
2639         * UserInterface/Images/Legacy/Plus.svg: Removed.
2640         * UserInterface/Images/Legacy/Recording.png: Removed.
2641         * UserInterface/Images/Legacy/Recording@2x.png: Removed.
2642         * UserInterface/Images/Legacy/RecordingHovered.png: Removed.
2643         * UserInterface/Images/Legacy/RecordingHovered@2x.png: Removed.
2644         * UserInterface/Images/Legacy/RecordingStopped.png: Removed.
2645         * UserInterface/Images/Legacy/RecordingStopped@2x.png: Removed.
2646         * UserInterface/Images/Legacy/Reload.svg: Removed.
2647         * UserInterface/Images/Legacy/Resources.svg: Removed.
2648         * UserInterface/Images/Legacy/Resume.svg: Removed.
2649         * UserInterface/Images/Legacy/ShadowDOM.svg: Removed.
2650         * UserInterface/Images/Legacy/SortIndicatorDownArrow.svg: Removed.
2651         * UserInterface/Images/Legacy/SortIndicatorUpArrow.svg: Removed.
2652         * UserInterface/Images/Legacy/SplitToggleDown.svg: Removed.
2653         * UserInterface/Images/Legacy/SplitToggleUp.svg: Removed.
2654         * UserInterface/Images/Legacy/StepInto.svg: Removed.
2655         * UserInterface/Images/Legacy/StepOut.svg: Removed.
2656         * UserInterface/Images/Legacy/StepOver.svg: Removed.
2657         * UserInterface/Images/Legacy/Time.svg: Removed.
2658         * UserInterface/Images/Legacy/Undock.svg: Removed.
2659         * UserInterface/Images/Legacy/UpDownArrows.svg: Removed.
2660         * UserInterface/Images/Legacy/Weight.svg: Removed.
2661         * UserInterface/Views/ButtonNavigationItem.css:
2662         (body.mac-platform.legacy .navigation-bar .item.button.text-only): Deleted.
2663         * UserInterface/Views/ButtonToolbarItem.css:
2664         (body.mac-platform.legacy .toolbar .item.button > .label): Deleted.
2665         * UserInterface/Views/CSSStyleDeclarationSection.css:
2666         (body.mac-platform.legacy .style-declaration-section): Deleted.
2667         (body.mac-platform.legacy .style-declaration-section + .style-declaration-section): Deleted.
2668         (body.mac-platform.legacy .style-declaration-section.last-in-group): Deleted.
2669         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section): Deleted.
2670         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)): Deleted.
2671         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
2672         (body.mac-platform.legacy .sidebar > .panel.details.css-style > .content): Deleted.
2673         * UserInterface/Views/ContentBrowser.js:
2674         (WebInspector.ContentBrowser):
2675         * UserInterface/Views/ControlToolbarItem.css:
2676         (body.mac-platform.legacy .toolbar .item.control): Deleted.
2677         (body.mac-platform.legacy .toolbar .item.control:hover): Deleted.
2678         * UserInterface/Views/DOMTreeContentView.js:
2679         (WebInspector.DOMTreeContentView):
2680         * UserInterface/Views/DOMTreeOutline.css:
2681         (body.mac-platform.legacy .dom-tree-outline li.hovered:not(.selected) .selection): Deleted.
2682         (body.mac-platform.legacy .dom-tree-outline li.elements-drag-over .selection): Deleted.
2683         (body.mac-platform.legacy .dom-tree-outline:focus li.selected .selection): Deleted.
2684         * UserInterface/Views/DashboardContainerView.css:
2685         (body.mac-platform.legacy .toolbar .dashboard-container): Deleted.
2686         (body.mac-platform.legacy.window-inactive .toolbar .dashboard-container): Deleted.
2687         (body.mac-platform.legacy.window-inactive .toolbar .dashboard): Deleted.
2688         (body.mac-platform.legacy .dashboard-container .advance-arrow): Deleted.
2689         * UserInterface/Views/DataGrid.css:
2690         (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)): Deleted.
2691         (body.mac-platform.legacy .data-grid:focus tr.selected): Deleted.
2692         * UserInterface/Views/DataGrid.js:
2693         (WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
2694         * UserInterface/Views/DatabaseTableContentView.js:
2695         (WebInspector.DatabaseTableContentView):
2696         * UserInterface/Views/DebuggerDashboardView.js:
2697         (WebInspector.DebuggerDashboardView):
2698         * UserInterface/Views/DebuggerSidebarPanel.css:
2699         (body.mac-platform.legacy .sidebar > .panel.navigation.debugger > .content): Deleted.
2700         * UserInterface/Views/DebuggerSidebarPanel.js:
2701         * UserInterface/Views/DefaultDashboardView.css:
2702         (body.mac-platform.legacy .toolbar .dashboard.default > .item): Deleted.
2703         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img): Deleted.
2704         (body.mac-platform.legacy .toolbar .dashboard.default > .logs > img): Deleted.
2705         (body.mac-platform.legacy .toolbar .dashboard.default > .errors > img): Deleted.
2706         (body.mac-platform.legacy .toolbar .dashboard.default > .errors.enabled > img): Deleted.
2707         (body.mac-platform.legacy .toolbar .dashboard.default > .issues > img): Deleted.
2708         (body.mac-platform.legacy .toolbar .dashboard.default > .issues.enabled > img): Deleted.
2709         * UserInterface/Views/DetailsSection.css:
2710         (body.mac-platform.legacy .details-section): Deleted.
2711         (body.mac-platform.legacy .details-section .details-section): Deleted.
2712         (body.mac-platform.legacy .details-section .details-section:first-child): Deleted.
2713         (body.mac-platform.legacy .details-section > .header): Deleted.
2714         (body.mac-platform.legacy .details-section .details-section > .header): Deleted.
2715         (body.mac-platform.legacy .details-section .details-section.collapsed > .header): Deleted.
2716         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline): Deleted.
2717         (body.mac-platform.legacy .details-section.computed-style-properties:not(.collapsed) > .header): Deleted.
2718         (body.mac-platform.legacy .details-section > .content > .group): Deleted.
2719         (body.mac-platform.legacy .details-section > .content > .group:nth-child(even)): Deleted.
2720         (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *): Deleted.
2721         (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)): Deleted.
2722         * UserInterface/Views/DividerNavigationItem.css:
2723         (.navigation-bar .item.divider):
2724         (body.mac-platform.legacy .navigation-bar .item.divider): Deleted.
2725         * UserInterface/Views/FilterBar.css:
2726         (.filter-bar > input[type="search"]::-webkit-search-decoration):
2727         (body.mac-platform.legacy .filter-bar): Deleted.
2728         (body.mac-platform.legacy .filter-bar > input[type="search"]): Deleted.
2729         (body.mac-platform.legacy .filter-bar > input[type="search"]::-webkit-search-decoration): Deleted.
2730         * UserInterface/Views/FindBanner.css:
2731         (body.mac-platform.legacy .find-banner > input[type="search"]): Deleted.
2732         (body.mac-platform.legacy .find-banner > button > .glyph): Deleted.
2733         (body.mac-platform.legacy .find-banner > button.segmented.left > .glyph): Deleted.
2734         (body.mac-platform.legacy .find-banner > button.segmented.right > .glyph): Deleted.
2735         (body.mac-platform.legacy .find-banner > button.segmented): Deleted.
2736         * UserInterface/Views/FindBanner.js:
2737         (WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
2738         (WebInspector.FindBanner):
2739         * UserInterface/Views/FolderIcon.css:
2740         (.folder-icon .icon):
2741         (body.mac-platform.legacy .folder-icon .icon): Deleted.
2742         * UserInterface/Views/HierarchicalPathComponent.css:
2743         (body.mac-platform.legacy .hierarchical-path-component > .selector-arrows): Deleted.
2744         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
2745         (WebInspector.IndexedDatabaseObjectStoreContentView):
2746         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
2747         (body.mac-platform.legacy .sidebar > .panel.details.layer-tree > .content): Deleted.
2748         (body.mac-platform.legacy .panel.details.layer-tree .bottom-bar): Deleted.
2749         (body.mac-platform.legacy .panel.details.layer-tree .bottom-bar > div): Deleted.
2750         (body.mac-platform.legacy .layer-tree-popover): Deleted.
2751         * UserInterface/Views/LogContentView.css:
2752         (body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]): Deleted.
2753         * UserInterface/Views/LogContentView.js:
2754         (WebInspector.LogContentView):
2755         * UserInterface/Views/Main.css:
2756         (body.mac-platform.legacy:not(.docked)): Deleted.
2757         (body.docked.bottom.mac-platform.legacy): Deleted.
2758         (body.docked.right.mac-platform.legacy): Deleted.
2759         (body.mac-platform.legacy #split-content-browser > .navigation-bar): Deleted.
2760         * UserInterface/Views/NavigationBar.css:
2761         (.navigation-bar .item):
2762         (body.mac-platform.legacy .navigation-bar): Deleted.
2763         (body.mac-platform.legacy .navigation-bar .item): Deleted.
2764         * UserInterface/Views/NavigationSidebarPanel.css:
2765         (body.mac-platform.legacy .sidebar > .panel.navigation > .content): Deleted.
2766         (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow): Deleted.
2767         (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow.top): Deleted.
2768         (body.mac-platform.legacy .sidebar > .panel.navigation > .empty-content-placeholder): Deleted.
2769         (body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
2770         (body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline:focus .item.selected): Deleted.
2771         (body.mac-platform.legacy.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected): Deleted.
2772         * UserInterface/Views/NavigationSidebarPanel.js:
2773         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2774         (WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):
2775         * UserInterface/Views/Popover.js:
2776         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
2777         (body.mac-platform.legacy .details-section.probe-set .options > .probe-clear-samples): Deleted.
2778         (body.mac-platform.legacy .details-section.probe-set .options > .probe-remove): Deleted.
2779         (body.mac-platform.legacy .details-section.probe-set .options > .probe-add): Deleted.
2780         * UserInterface/Views/QuickConsole.css:
2781         (body.mac-platform.legacy .quick-console): Deleted.
2782         * UserInterface/Views/RadioButtonNavigationItem.css:
2783         (.navigation-bar .item.radio.button.text-only.selected:active):
2784         (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:hover): Deleted.
2785         (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected): Deleted.
2786         (body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active): Deleted.
2787         * UserInterface/Views/RulesStyleDetailsPanel.css:
2788         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .label + .style-declaration-section): Deleted.
2789         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule): Deleted.
2790         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section): Deleted.
2791         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
2792         * UserInterface/Views/ScopeBar.css:
2793         (.scope-bar > li.selected:active):
2794         (body.mac-platform.legacy .scope-bar > li): Deleted.
2795         (body.mac-platform.legacy .scope-bar > li:hover): Deleted.
2796         (body.mac-platform.legacy .scope-bar > li.selected): Deleted.
2797         (body.mac-platform.legacy .scope-bar > li:active): Deleted.
2798         (body.mac-platform.legacy .scope-bar > li.selected:active): Deleted.
2799         * UserInterface/Views/ScriptContentView.js:
2800         (WebInspector.ScriptContentView):
2801         * UserInterface/Views/SearchBar.css:
2802         (body.mac-platform.legacy .search-bar > input[type="search"]): Deleted.
2803         * UserInterface/Views/SearchSidebarPanel.css:
2804         (.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
2805         (body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)): Deleted.
2806         (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar): Deleted.
2807         (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]): Deleted.
2808         * UserInterface/Views/Sidebar.css:
2809         (body.window-inactive .sidebar.right):
2810         (body.mac-platform.legacy .sidebar): Deleted.
2811         (body.mac-platform.legacy.window-inactive .sidebar): Deleted.
2812         (body.mac-platform.legacy .sidebar.right): Deleted.
2813         * UserInterface/Views/TextContentView.js:
2814         (WebInspector.TextContentView):
2815         * UserInterface/Views/TextResourceContentView.js:
2816         (WebInspector.TextResourceContentView):
2817         * UserInterface/Views/TimelineDataGrid.css:
2818         (body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar): Deleted.
2819         * UserInterface/Views/TimelineIcons.css:
2820         (body.mac-platform.legacy .network-icon .icon): Deleted.
2821         (body.mac-platform.legacy .network-icon.large .icon): Deleted.
2822         (body.mac-platform.legacy .colors-icon .icon): Deleted.
2823         (body.mac-platform.legacy .colors-icon.large .icon): Deleted.
2824         * UserInterface/Views/TimelineRecordingContentView.js:
2825         (WebInspector.TimelineRecordingContentView):
2826         * UserInterface/Views/TimelineRuler.css:
2827         (body.mac-platform.legacy .timeline-ruler > .header): Deleted.
2828         (body.mac-platform.legacy .timeline-ruler > .selection-drag): Deleted.
2829         (body.mac-platform.legacy .timeline-ruler > .selection-handle): Deleted.
2830         * UserInterface/Views/TimelineSidebarPanel.css:
2831         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content):
2832         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar): Deleted.
2833         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph): Deleted.
2834         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording): Deleted.
2835         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover): Deleted.
2836         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover): Deleted.
2837         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced): Deleted.
2838         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced): Deleted.
2839         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status): Deleted.
2840         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar): Deleted.
2841         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines): Deleted.
2842         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events): Deleted.
2843         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content): Deleted.
2844         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button): Deleted.
2845         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
2846         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item): Deleted.
2847         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)): Deleted.
2848         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button): Deleted.
2849         * UserInterface/Views/TimelineSidebarPanel.js:
2850         (WebInspector.TimelineSidebarPanel):
2851         * UserInterface/Views/Toolbar.css:
2852         (body.mac-platform:not(.docked) .toolbar):
2853         (body.mac-platform:not(.legacy, .docked) .toolbar): Deleted.
2854         (body.mac-platform.legacy .toolbar): Deleted.
2855         (body.mac-platform.legacy.docked .toolbar): Deleted.
2856         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Deleted.
2857         (body.mac-platform.legacy.window-inactive .toolbar): Deleted.
2858         * UserInterface/Views/TreeElementStatusButton.css:
2859         (body.mac-platform.legacy .item > .status > .status-button > svg .filled): Deleted.
2860         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked): Deleted.
2861
2862 2015-04-29  Andres Gomez  <agomez@igalia.com>
2863
2864         [GTK] Web Inspector: Optimize SVG images
2865         https://bugs.webkit.org/show_bug.cgi?id=143476
2866
2867         SVG images optimized with a combination of sed replacements and
2868         the usage of the scour tool (http://www.codedread.com/scour/).
2869
2870         Also, modified the spelling of the license word to use the US one
2871         in the copyright files.
2872
2873         Reviewed by Martin Robinson.
2874
2875         * UserInterface/Images/gtk/BackArrow.svg:
2876         * UserInterface/Images/gtk/BottomUpTree.svg:
2877         * UserInterface/Images/gtk/BreakpointActionAdd.svg:
2878         * UserInterface/Images/gtk/BreakpointActionRemove.svg:
2879         * UserInterface/Images/gtk/BreakpointButton.svg:
2880         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
2881         * UserInterface/Images/gtk/Breakpoints.svg:
2882         * UserInterface/Images/gtk/COPYING:
2883         * UserInterface/Images/gtk/COPYING_CCBYSA3:
2884         * UserInterface/Images/gtk/Checkers.svg:
2885         * UserInterface/Images/gtk/Circle.svg:
2886         * UserInterface/Images/gtk/Close.svg:
2887         * UserInterface/Images/gtk/CloseLarge.svg:
2888         * UserInterface/Images/gtk/CloseWhite.svg:
2889         * UserInterface/Images/gtk/ContentFlow.svg:
2890         * UserInterface/Images/gtk/Crosshair.svg:
2891         * UserInterface/Images/gtk/DOMCharacterData.svg:
2892         * UserInterface/Images/gtk/DOMComment.svg:
2893         * UserInterface/Images/gtk/DOMDocument.svg:
2894         * UserInterface/Images/gtk/DOMDocumentType.svg:
2895         * UserInterface/Images/gtk/DOMElement.svg:
2896         * UserInterface/Images/gtk/DOMNode.svg:
2897         * UserInterface/Images/gtk/DOMTextNode.svg:
2898         * UserInterface/Images/gtk/DOMTree.svg:
2899         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg:
2900         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg:
2901         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg:
2902         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg:
2903         * UserInterface/Images/gtk/DockBottom.svg:
2904         * UserInterface/Images/gtk/DockRight.svg:
2905         * UserInterface/Images/gtk/DownloadArrow.svg:
2906         * UserInterface/Images/gtk/Error.svg:
2907         * UserInterface/Images/gtk/Errors.svg:
2908         * UserInterface/Images/gtk/ErrorsEnabled.svg:
2909         * UserInterface/Images/gtk/EventListener.svg:
2910         * UserInterface/Images/gtk/Exception.svg:
2911         * UserInterface/Images/gtk/Eye.svg:
2912         * UserInterface/Images/gtk/FilterFieldGlyph.svg:
2913         * UserInterface/Images/gtk/ForwardArrow.svg:
2914         * UserInterface/Images/gtk/Function.svg:
2915         * UserInterface/Images/gtk/GoToArrow.svg:
2916         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg:
2917         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg:
2918         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg:
2919         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg:
2920         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg:
2921         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg:
2922         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg:
2923         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg:
2924         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg:
2925         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg:
2926         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg:
2927         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg:
2928         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg:
2929         * UserInterface/Images/gtk/Issues.svg:
2930         * UserInterface/Images/gtk/IssuesEnabled.svg:
2931         * UserInterface/Images/gtk/LayerBorders.svg:
2932         * UserInterface/Images/gtk/Locked.svg:
2933         * UserInterface/Images/gtk/Logs.svg:
2934         * UserInterface/Images/gtk/Native.svg:
2935         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
2936         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
2937         * UserInterface/Images/gtk/NavigationItemBug.svg:
2938         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:
2939         * UserInterface/Images/gtk/NavigationItemFile.svg:
2940         * UserInterface/Images/gtk/NavigationItemLayers.svg:
2941         * UserInterface/Images/gtk/NavigationItemLog.svg:
2942         * UserInterface/Images/gtk/NavigationItemProbes.svg:
2943         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
2944         * UserInterface/Images/gtk/NavigationItemStorage.svg:
2945         * UserInterface/Images/gtk/NavigationItemTrash.svg:
2946         * UserInterface/Images/gtk/NavigationItemTypes.svg:
2947         * UserInterface/Images/gtk/NavigationItemVariable.svg:
2948         * UserInterface/Images/gtk/PaintFlashing.svg:
2949         * UserInterface/Images/gtk/Pause.svg:
2950         * UserInterface/Images/gtk/PausedBreakpoint.svg:
2951         * UserInterface/Images/gtk/Percent.svg:
2952         * UserInterface/Images/gtk/Plus.svg:
2953         * UserInterface/Images/gtk/PseudoElement.svg:
2954         * UserInterface/Images/gtk/Record.svg:
2955         * UserInterface/Images/gtk/Reflection.svg:
2956         * UserInterface/Images/gtk/Reload.svg:
2957         * UserInterface/Images/gtk/ReloadFull.svg:
2958         * UserInterface/Images/gtk/ReplayPauseButton.svg:
2959         * UserInterface/Images/gtk/ReplayPlayButton.svg:
2960         * UserInterface/Images/gtk/ReplayRecordingButton.svg:
2961         * UserInterface/Images/gtk/Request.svg:
2962         * UserInterface/Images/gtk/Resources.svg:
2963         * UserInterface/Images/gtk/Response.svg:
2964         * UserInterface/Images/gtk/ResultLine.svg:
2965         * UserInterface/Images/gtk/Resume.svg:
2966         * UserInterface/Images/gtk/ShadowDOM.svg:
2967         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg:
2968         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg:
2969         * UserInterface/Images/gtk/SourceCode.svg:
2970         * UserInterface/Images/gtk/SplitToggleDown.svg:
2971         * UserInterface/Images/gtk/SplitToggleUp.svg:
2972         * UserInterface/Images/gtk/StepInto.svg:
2973         * UserInterface/Images/gtk/StepOut.svg:
2974         * UserInterface/Images/gtk/StepOver.svg:
2975         * UserInterface/Images/gtk/Stop.svg:
2976         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
2977         * UserInterface/Images/gtk/StyleRuleInherited.svg:
2978         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
2979         * UserInterface/Images/gtk/StyleRuleInspector.svg:
2980         * UserInterface/Images/gtk/StyleRuleUser.svg:
2981         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
2982         * UserInterface/Images/gtk/Time.svg:
2983         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
2984         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg:
2985         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
2986         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
2987         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
2988         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg:
2989         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
2990         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
2991         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
2992         * UserInterface/Images/gtk/TypeBoolean.svg:
2993         * UserInterface/Images/gtk/TypeNull.svg:
2994         * UserInterface/Images/gtk/TypeNumber.svg:
2995         * UserInterface/Images/gtk/TypeObject.svg:
2996         * UserInterface/Images/gtk/TypeRegex.svg:
2997         * UserInterface/Images/gtk/TypeString.svg:
2998         * UserInterface/Images/gtk/TypeSymbol.svg:
2999         * UserInterface/Images/gtk/TypeUndefined.svg:
3000         * UserInterface/Images/gtk/Undock.svg:
3001         * UserInterface/Images/gtk/UpDownArrows.svg:
3002         * UserInterface/Images/gtk/UserInputPrompt.svg:
3003         * UserInterface/Images/gtk/UserInputPromptPrevious.svg:
3004         * UserInterface/Images/gtk/UserInputResult.svg:
3005         * UserInterface/Images/gtk/Warning.svg:
3006         * UserInterface/Images/gtk/Weight.svg:
3007
3008 2015-04-29  Timothy Hatcher  <timothy@apple.com>
3009
3010         Web Inspector: Navigation bar often looses last button when full
3011         https://bugs.webkit.org/show_bug.cgi?id=144385
3012
3013         Added helpers to get the subpixel width and height of an element.
3014         Adopt them in the NavigationBar layout methods to get precise widths
3015         that don't accumulate rounding errors which lead to items overflowing.
3016
3017         Reviewed by Joseph Pecoraro.
3018
3019         * UserInterface/Base/Utilities.js:
3020         (Element.prototype.realOffsetWidth): Added.
3021         (Element.prototype.realOffsetHeight): Added.
3022         * UserInterface/Views/HierarchicalPathNavigationItem.js:
3023         (WebInspector.HierarchicalPathNavigationItem.prototype.updateLayout):
3024         * UserInterface/Views/NavigationBar.js:
3025         (WebInspector.NavigationBar.prototype.updateLayout):
3026         (WebInspector.NavigationBar.prototype._calculateMinimumWidth):
3027         * UserInterface/Views/TabBar.js:
3028         (WebInspector.TabBar.prototype._handleMouseMoved):
3029         * UserInterface/Views/Toolbar.js:
3030         (WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
3031         (WebInspector.Toolbar.prototype.customUpdateLayout):
3032
3033 2015-04-28  Matt Baker  <mattbaker@apple.com>
3034
3035         Web Inspector: add a separate overview for the Rendering Frames timeline
3036         https://bugs.webkit.org/show_bug.cgi?id=144245
3037
3038         Reviewed by Timothy Hatcher.
3039
3040         The Timelines tab now supports two view modes, labeled "Timelines" and "Rendering Frames", with each mode
3041         having a seperate timeline overview and selected range. The Timelines mode displays the original time-based
3042         graphs (Network, Layout, and Script), and switching to the Rendering Frames mode displays a frames graph
3043         with a timeline ruler which shows frame indices.
3044
3045         If the rendering frames timeline is supported by the backend, a navigation bar is added to the timelines
3046         sidebar with controls for switching between view modes. In addition to user-triggered view mode changes, the
3047         timelines sidebar will automatically change the current view mode in response to content view changes that
3048         are triggered elsewhere in the UI (for example, when a timeline that does not belong to the current view
3049         mode is selected via the navigation path).
3050
3051         * UserInterface/Controllers/TimelineManager.js:
3052         (WebInspector.TimelineManager.prototype.get activeRecording): Deleted.
3053         (WebInspector.TimelineManager.prototype.get recordings): Deleted.
3054         Removed unused code.
3055
3056         * UserInterface/Main.html:
3057         New files.
3058
3059         * UserInterface/Models/RenderingFrameTimelineRecord.js:
3060         (WebInspector.RenderingFrameTimelineRecord):
3061         (WebInspector.RenderingFrameTimelineRecord.resetFrameIndex):
3062         (WebInspector.RenderingFrameTimelineRecord.prototype.get frameIndex):
3063         (WebInspector.RenderingFrameTimelineRecord.prototype.get frameNumber):
3064         * UserInterface/Models/TimelineRecording.js:
3065         (WebInspector.TimelineRecording.prototype.reset):
3066         Frame number is now derived from frame index.
3067
3068         * UserInterface/Views/LinearTimelineOverview.js:
3069         (WebInspector.LinearTimelineOverview):
3070         (WebInspector.LinearTimelineOverview.prototype.canShowTimeline):
3071         New overview class for time-based timeline graphs.
3072
3073         * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js:
3074         (WebInspector.RenderingFrameDetailsSidebarPanel):
3075         (WebInspector.RenderingFrameDetailsSidebarPanel.prototype.updateRangeSelection):
3076         (WebInspector.RenderingFrameDetailsSidebarPanel.prototype._getSelectedRecords):
3077         Changed type of selected range from time to frame indices.
3078
3079         * UserInterface/Views/RenderingFrameTimelineOverview.js:
3080         (WebInspector.RenderingFrameTimelineOverview.this.timelineRuler.formatLabelCallback):
3081         (WebInspector.RenderingFrameTimelineOverview):
3082         (WebInspector.RenderingFrameTimelineOverview.prototype.canShowTimeline):
3083         New overview class for frame-based timeline graphs.
3084
3085         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
3086         (.timeline-overview > .graphs-container > .timeline-overview-graph.rendering-frame):
3087         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
3088         (WebInspector.RenderingFrameTimelineOverviewGraph):
3089         (WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition.get if):
3090         Updated to use frame index ruler and removed frame combining logic.
3091
3092         * UserInterface/Views/RenderingFrameTimelineView.js:
3093         (WebInspector.RenderingFrameTimelineView):
3094         Increased column widths.
3095
3096         * UserInterface/Views/TimelineOverview.css:
3097         (.timeline-overview > .graphs-container):
3098         (body.mac-platform.legacy .timeline-overview > .graphs-container):
3099         Updated for new ruler height.
3100
3101         * UserInterface/Views/TimelineOverview.js:
3102         (WebInspector.TimelineOverview):
3103         (WebInspector.TimelineOverview.prototype.get secondsPerPixel):
3104         (WebInspector.TimelineOverview.prototype.set secondsPerPixel):
3105         (WebInspector.TimelineOverview.prototype.get visibleDuration):
3106         (WebInspector.TimelineOverview.prototype.set selectionDuration):
3107         (WebInspector.TimelineOverview.prototype.updateLayout):
3108         (WebInspector.TimelineOverview.prototype.get timelineRuler):
3109         (WebInspector.TimelineOverview.prototype.canShowTimeline):
3110         (WebInspector.TimelineOverview.prototype._handleScrollEvent):
3111         (WebInspector.TimelineOverview.prototype._handleWheelEvent):
3112         (WebInspector.TimelineOverview.prototype._timelineRemoved):
3113         (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
3114         (WebInspector.TimelineOverview.prototype.set currentTime): Deleted.
3115         (WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded): Deleted.
3116         (WebInspector.TimelineOverview.prototype._needsLayout): Deleted.
3117         Converted to base class. Derived classes provide settings and permitted timeline types.
3118
3119         * UserInterface/Views/TimelineRecordFrame.css:
3120         (.timeline-record-frame):
3121         (.timeline-record-frame > .frame):
3122         (.timeline-record-frame > .frame > .duration):
3123         (.timeline-record-frame > .frame > .duration.timeline-record-type-network):
3124         (.timeline-record-frame > .frame > .duration.timeline-record-type-layout):
3125         (.timeline-record-frame > .frame > .duration.timeline-record-type-script):
3126         (.timeline-record-frame > .frame > .duration:last-child): Deleted.
3127         New graph frames styles.
3128
3129         * UserInterface/Views/TimelineRecordFrame.js:
3130         (WebInspector.TimelineRecordFrame):
3131         (WebInspector.TimelineRecordFrame.prototype.get record):
3132         (WebInspector.TimelineRecordFrame.prototype.set record):
3133         (WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
3134         (WebInspector.TimelineRecordFrame.prototype.get element): Deleted.
3135         Updated to use frame index ruler.
3136         Removed dropped frames and frame combining logic.
3137
3138         * UserInterface/Views/TimelineRecordingContentView.js:
3139         (WebInspector.TimelineRecordingContentView):
3140         (WebInspector.TimelineRecordingContentView.prototype.shown):
3141         (WebInspector.TimelineRecordingContentView.prototype.hidden):
3142         (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
3143         (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
3144         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
3145         (WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
3146         (WebInspector.TimelineRecordingContentView.prototype._getRenderingFrameTimeline):
3147         (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
3148         (WebInspector.TimelineRecordingContentView.prototype._timelineCountChanged):
3149         (WebInspector.TimelineRecordingContentView.prototype._recordingReset):
3150         (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
3151         (WebInspector.TimelineRecordingContentView.prototype.get currentTimelineView): Deleted.
3152         (WebInspector.TimelineRecordingContentView.prototype.goForward): Deleted.
3153         (WebInspector.TimelineRecordingContentView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
3154         (WebInspector.TimelineRecordingContentView.prototype._contentViewSupplementalRepresentedObjectsDidChange): Deleted.
3155         (WebInspector.TimelineRecordingContentView.prototype._update): Deleted.
3156         (WebInspector.TimelineRecordingContentView.prototype._debuggerPaused): Deleted.
3157         (WebInspector.TimelineRecordingContentView.prototype._debuggerResumed): Deleted.
3158         (WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated): Deleted.
3159         Maintains two timeline overviews, switching between them based on the current content view.
3160         Updated tree element filtering to support both overview rulers.
3161
3162         * UserInterface/Views/TimelineRuler.css:
3163         (.timeline-ruler > .header):
3164         (body.mac-platform.legacy .timeline-ruler > .header):
3165         (.timeline-ruler > .header > .divider > .label):
3166         (.timeline-ruler > .selection-drag):
3167         (body.mac-platform.legacy .timeline-ruler > .selection-drag):
3168         (.timeline-ruler > .selection-handle):
3169         (body.mac-platform.legacy .timeline-ruler > .selection-handle):
3170         (.timeline-ruler > .header > .divider): Deleted.
3171         (.timeline-ruler > .selection-drag:active): Deleted.
3172         Updated for new ruler height.
3173
3174         * UserInterface/Views/TimelineRuler.js:
3175         (WebInspector.TimelineRuler):
3176         (WebInspector.TimelineRuler.prototype.set formatLabelCallback):
3177         (WebInspector.TimelineRuler.prototype.updateLayout):
3178         (WebInspector.TimelineRuler.prototype._formatDividerLabelText):
3179         (WebInspector.TimelineRuler.prototype.set allowsClippedLabels): Deleted.
3180         (WebInspector.TimelineRuler.prototype._updateSelection): Deleted.
3181         Added ability to customize label formatting.
3182
3183         * UserInterface/Views/TimelineSidebarPanel.css:
3184         (.panel.timeline .navigation-bar.timelines-view):
3185         (.sidebar > .panel.navigation.timeline > .title-bar):
3186         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar):
3187         (.sidebar > .panel.navigation.timeline > .title-bar.timelines):
3188         (.sidebar > .panel.navigation.timeline > .navigation-bar-container):
3189         (.sidebar > .panel.navigation.timeline > .navigation-bar-container > .navigation-bar):
3190         (.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
3191         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
3192         (.sidebar > .panel.navigation.timeline > .timelines-content):
3193         (.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
3194         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
3195         (.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
3196         (body.window-inactive .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item): Deleted.
3197         Updated for new navigation bar and ruler height.
3198
3199         * UserInterface/Views/TimelineSidebarPanel.js:
3200         (WebInspector.TimelineSidebarPanel):
3201         (WebInspector.TimelineSidebarPanel.prototype.get viewMode):
3202         (WebInspector.TimelineSidebarPanel.prototype.canShowTimeline):
3203         (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
3204         (WebInspector.TimelineSidebarPanel.get this):
3205         (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
3206         Added support for two view modes: Timelines and Rendering Frames.
3207
3208         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
3209         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
3210         New files.
3211
3212 2015-04-27  Timothy Hatcher  <timothy@apple.com>
3213
3214         Web Inspector: Add new tab button to make it easy to bring a closed tab back
3215         https://bugs.webkit.org/show_bug.cgi?id=144297
3216
3217         Reviewed by Joseph Pecoraro.
3218
3219         * Localizations/en.lproj/localizedStrings.js:
3220         * UserInterface/Base/Main.js:
3221         (WebInspector.contentLoaded):
3222         (WebInspector.isTabTypeAllowed):
3223         (WebInspector._tabContentViewForType):
3224         (WebInspector._rememberOpenTabs):
3225         (WebInspector._updateNewTabButtonState):
3226         (WebInspector._newTabItemClicked):
3227         (WebInspector.isNewTabWithTypeAllowed):
3228         (WebInspector.createNewTab):
3229         (WebInspector.activateExtraDomains):
3230         (WebInspector._restoreCookieForOpenTabs):
3231         (WebInspector._saveCookieForOpenTabs):
3232         (WebInspector._isTabTypeAllowed): Deleted.
3233         * UserInterface/Images/NewTab.svg: Added.
3234         * UserInterface/Images/NewTabPlus.svg:
3235         * UserInterface/Main.html:
3236         * UserInterface/Views/NewTabContentView.css: Added.
3237         (.new-tab.tab.content-view):
3238         (.new-tab.tab.content-view > .tab-item):
3239         (.new-tab.tab.content-view > .tab-item.disabled):
3240         (.new-tab.tab.content-view > .tab-item > .box):
3241         (.new-tab.tab.content-view > .tab-item:not(.disabled):active > .box):
3242         (.new-tab.tab.content-view > .tab-item > .box > img):
3243         (.new-tab.tab.content-view > .tab-item > label):
3244         * UserInterface/Views/NewTabContentView.js: Added.
3245         (WebInspector.NewTabContentView):
3246         (WebInspector.NewTabContentView.prototype.get type):
3247         (WebInspector.NewTabContentView.prototype._createNewTab):
3248         * UserInterface/Views/TabBar.css:
3249         (.tab-bar > .item:not(.disabled).selected):
3250         (.tab-bar > .item.new-tab-button:not(.disabled):hover):
3251         (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover + .item):
3252         (.tab-bar > .item.disabled > .icon):
3253         (.tab-bar > .item.new-tab-button:not(.disabled):hover > .icon):
3254         (.tab-bar > .item.selected): Deleted.
3255         (.tab-bar > .item.new-tab-button:hover): Deleted.
3256         (.tab-bar:not(.animating) > .item:not(.selected):hover + .item): Deleted.
3257         (.tab-bar > .item.new-tab-button:hover > .icon): Deleted.
3258         * UserInterface/Views/TabBar.js:
3259         (WebInspector.TabBar.prototype.set selectedTabBarItem):
3260         (WebInspector.TabBar.prototype._handleMouseDown):
3261         * UserInterface/Views/TabBarItem.js:
3262         (WebInspector.TabBarItem.prototype.get disabled):
3263         (WebInspector.TabBarItem.prototype.set disabled):
3264         * UserInterface/Views/TabBrowser.js:
3265         (WebInspector.TabBrowser):
3266         (WebInspector.TabBrowser.prototype.addTabForContentView):
3267         (WebInspector.TabBrowser.prototype.showTabForContentView):
3268         (WebInspector.TabBrowser.prototype.closeTabForContentView):
3269
3270 2015-04-27  Joseph Pecoraro  <pecoraro@apple.com>
3271
3272         Web Inspector: Cannot scroll Timeline Overview horizontally, scrollbar cannot be interacted with
3273         https://bugs.webkit.org/show_bug.cgi?id=144302
3274
3275         Reviewed by Timothy Hatcher.
3276
3277         * UserInterface/Views/TimelineOverview.css:
3278         (.timeline-overview > .scroll-container):
3279         Increase the z-index of the scroll container over anything in the
3280         overview so that it can be interacted with.
3281
3282 2015-04-27  Timothy Hatcher  <timothy@apple.com>
3283
3284         Web Inspector: Attempt to workaround exception in TimelineRuler
3285         https://bugs.webkit.org/show_bug.cgi?id=144228
3286
3287         Reviewed by Joseph Pecoraro.
3288
3289         * UserInterface/Views/TimelineRuler.js:
3290         (WebInspector.TimelineRuler.prototype.updateLayout):
3291         Use firstChild instead of a custom _labelElement property on the dividerElement.
3292
3293 2015-04-27  Timothy Hatcher  <timothy@apple.com>
3294
3295         Web Inspector: Elements tab details sidebar becomes non-expandable after using Console tab
3296         https://bugs.webkit.org/show_bug.cgi?id=144212
3297
3298         Show the DOM tree content view again on main resource change. This better matches what we did
3299         in the pre tab user interface with the DOM being off the main resource tree element.
3300
3301         Reviewed by Joseph Pecoraro.
3302
3303         * UserInterface/Views/ElementsTabContentView.js:
3304         (WebInspector.ElementsTabContentView): Listen for main resource change. Call _showDOMTreeContentView.
3305         (WebInspector.ElementsTabContentView.prototype.closed): Fix a leak and exception.
3306         The removeEventListener was wrong. Add a new removeEventListener for WebInspector.Frame.
3307         (WebInspector.ElementsTabContentView.prototype._showDOMTreeContentView): Added.
3308         (WebInspector.ElementsTabContentView.prototype._mainFrameDidChange): Call _showDOMTreeContentView.
3309         (WebInspector.ElementsTabContentView.prototype._mainResourceDidChange): Added.
3310
3311 2015-04-27  Timothy Hatcher  <timothy@apple.com>
3312
3313         Web Inspector: TabContentView closed() isn't being called when a tab is closed / removed
3314         https://bugs.webkit.org/show_bug.cgi?id=144229
3315
3316         Reviewed by Joseph Pecoraro.
3317
3318         * UserInterface/Views/ContentViewContainer.js:
3319         (WebInspector.ContentViewContainer.prototype._disassociateFromContentView):
3320         TabContentViews don't have a representedObject, so returning early and not
3321         calling closed() was not correct.
3322
3323 2015-04-26  Matt Baker  <mattbaker@apple.com>
3324
3325         Web Inspector: Cannot make Timeline time range selection clicking inside Frames Overview
3326         https://bugs.webkit.org/show_bug.cgi?id=143744
3327
3328         Reviewed by Timothy Hatcher.
3329
3330         Fixed frame rate divider element style so that it is no longer a mouse event target.
3331
3332         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
3333         (.timeline-overview-graph.rendering-frame > .divider):
3334
3335 2015-04-26  Timothy Hatcher  <timothy@apple.com>
3336
3337         Web Inspector: Allow Timeline tab to show resource when a go-to arrow is clicked in a recording
3338         https://bugs.webkit.org/show_bug.cgi?id=144240
3339
3340         Only support showing a resource or script if we have that represented object in the Timeline sidebar.
3341
3342         Reviewed by Darin Adler.
3343
3344         * UserInterface/Views/TimelineTabContentView.js:
3345         (WebInspector.TimelineTabContentView.prototype.canShowRepresentedObject):
3346
3347 2015-04-26  Timothy Hatcher  <timothy@apple.com>
3348
3349         Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view
3350         https://bugs.webkit.org/show_bug.cgi?id=144239
3351
3352         Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad
3353         is most cases, but if the select tab supports the same represented object, it can end up showing
3354         the content view in the wrong tab.
3355
3356         Reviewed by Darin Adler.
3357
3358         * UserInterface/Views/ContentBrowserTabContentView.js:
3359         (WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObjectInNavigationSidebar):
3360         * UserInterface/Views/DebuggerSidebarPanel.js:
3361         (WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):
3362         * UserInterface/Views/NavigationSidebarPanel.js:
3363         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentViewForTreeElement):
3364         (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
3365         (WebInspector.NavigationSidebarPanel):
3366         (WebInspector.NavigationSidebarPanel.prototype.showContentViewForCurrentSelection): Deleted.
3367         * UserInterface/Views/ResourceSidebarPanel.js:
3368         (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
3369         (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
3370         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
3371         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
3372
3373 2015-04-26  Jono Wells  <jonowells@apple.com>
3374
3375         Web Inspector: Vertically misaligned text in Object Trees
3376         https://bugs.webkit.org/show_bug.cgi?id=144029
3377
3378         Reviewed by Timothy Hatcher.
3379
3380         Remove top offset for object tree property titles to fix alignment issue since applying -webkit-system-font
3381         font family to these (http://trac.webkit.org/changeset/182982).
3382
3383         * UserInterface/Views/ObjectTreePropertyTreeElement.css:
3384         (.object-tree-property > .titles):
3385
3386 2015-04-25  Joseph Pecoraro  <pecoraro@apple.com>
3387
3388         Web Inspector: Uncaught exception ReferenceError: Can't find variable: message LogContentView.js
3389         https://bugs.webkit.org/show_bug.cgi?id=144210
3390
3391         Reviewed by Timothy Hatcher.
3392
3393         * UserInterface/Views/LogContentView.js:
3394         (WebInspector.LogContentView.prototype._reappendProvisionalMessages):
3395         With recent refactorings this change was missed.
3396
3397 2015-04-25  Joseph Pecoraro  <pecoraro@apple.com>
3398
3399         Web Inspector: Uncaught exception using WebInspector.contentBrowser
3400         https://bugs.webkit.org/show_bug.cgi?id=144206
3401
3402         Reviewed by Timothy Hatcher.
3403
3404         * UserInterface/Views/TimelineSidebarPanel.js:
3405         (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
3406         Use the current tab's content browser since a global one no longer exists.
3407
3408 2015-04-25  Timothy Hatcher  <timothy@apple.com>
3409
3410         Update localized strings.
3411
3412         * Localizations/en.lproj/localizedStrings.js: Updated.
3413
3414 2015-04-25  Timothy Hatcher  <timothy@apple.com>
3415
3416         Web Inspector: Make JSContext debugging work with Tabs UI
3417         https://bugs.webkit.org/show_bug.cgi?id=144203
3418
3419         Reviewed by Joseph Pecoraro.
3420
3421         * UserInterface/Base/Main.js:
3422         (WebInspector.contentLoaded):
3423         (WebInspector._isTabTypeAllowed):
3424         (WebInspector.activateExtraDomains):
3425         (WebInspector._updateReloadToolbarButton):
3426         (WebInspector._updateDownloadToolbarButton):
3427
3428 2015-04-25  Timothy Hatcher  <timothy@apple.com>
3429
3430         Web Inspector: Save and restore tab state on reload and between sessions
3431         https://bugs.webkit.org/show_bug.cgi?id=144202
3432
3433         Reviewed by Joseph Pecoraro.
3434
3435         * UserInterface/Base/Main.js:
3436         (WebInspector.contentLoaded):
3437         (WebInspector._mainResourceDidChange):
3438         (WebInspector._provisionalLoadStarted):
3439         (WebInspector._restoreCookieForOpenTabs):
3440         (WebInspector._saveCookieForOpenTabs):
3441         (WebInspector._pageHidden):
3442         * UserInterface/Views/TabContentView.js:
3443         (WebInspector.TabContentView):
3444         (WebInspector.TabContentView.prototype.restoreStateFromCookie):
3445         (WebInspector.TabContentView.prototype.saveStateToCookie):
3446
3447 2015-04-25  Timothy Hatcher  <timothy@apple.com>
3448
3449         Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar
3450         https://bugs.webkit.org/show_bug.cgi?id=144197
3451
3452         Reviewed by Joseph Pecoraro.
3453
3454         * UserInterface/Base/Main.js:
3455         (WebInspector.contentLoaded):
3456         (WebInspector._tabContentViewForType):
3457         (WebInspector._searchTextDidChange):
3458         (WebInspector._focusSearchField):
3459         (WebInspector._domNodeWasInspected):
3460         * UserInterface/Controllers/DebuggerManager.js:
3461         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
3462         * UserInterface/Images/SearchResults.svg: Added.
3463         * UserInterface/Main.html:
3464         * UserInterface/Views/ResourceSidebarPanel.js:
3465         (WebInspector.ResourceSidebarPanel):
3466         (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
3467         (WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
3468         (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
3469         (WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
3470         (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
3471         (WebInspector.ResourceSidebarPanel.prototype._addStorageChild):
3472         (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
3473         (WebInspector.ResourceSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
3474         (WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon): Deleted.
3475         (WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder): Deleted.
3476         (WebInspector.ResourceSidebarPanel.prototype.performSearch.forEachMatch): Deleted.
3477         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback): Deleted.
3478         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback): Deleted.
3479         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback): Deleted.
3480         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts): Deleted.
3481         (WebInspector.ResourceSidebarPanel.prototype.performSearch.domSearchResults): Deleted.
3482         (WebInspector.ResourceSidebarPanel.prototype.performSearch.domCallback): Deleted.
3483         (WebInspector.ResourceSidebarPanel.prototype.performSearch): Deleted.
3484         (WebInspector.ResourceSidebarPanel.prototype._showResourcesContentTreeOutline): Deleted.
3485         (WebInspector.ResourceSidebarPanel.prototype._showSearchContentTreeOutline): Deleted.
3486         (WebInspector.ResourceSidebarPanel.prototype._searchFieldChanged): Deleted.
3487         (WebInspector.ResourceSidebarPanel.prototype._searchFieldInput): Deleted.
3488         (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForResource): Deleted.
3489         (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript): Deleted.
3490         (WebInspector.ResourceSidebarPanel.prototype._focusSearchField): Deleted.
3491         (WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch): Deleted.
3492         * UserInterface/Views/SearchBar.js:
3493         (WebInspector.SearchBar):
3494         * UserInterface/Views/SearchSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css.
3495         (.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
3496         (body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
3497         (.sidebar > .panel.navigation.search > .search-bar):
3498         (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar):
3499         (.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
3500         (body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
3501         * UserInterface/Views/SearchSidebarPanel.js: Added.
3502         (WebInspector.SearchSidebarPanel):
3503         (WebInspector.SearchSidebarPanel.prototype.closed):
3504         (WebInspector.SearchSidebarPanel.prototype.focusSearchField):
3505         (WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon):
3506         (WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder):
3507         (WebInspector.SearchSidebarPanel.prototype.performSearch.forEachMatch):
3508         (WebInspector.SearchSidebarPanel.prototype.performSearch.resourceCallback):
3509         (WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
3510         (WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
3511         (WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts):
3512         (WebInspector.SearchSidebarPanel.prototype.performSearch.domSearchResults):
3513         (WebInspector.SearchSidebarPanel.prototype.performSearch.domCallback):
3514         (WebInspector.SearchSidebarPanel.prototype.performSearch):
3515         (WebInspector.SearchSidebarPanel.prototype._searchFieldChanged):
3516         (WebInspector.SearchSidebarPanel.prototype._searchFieldInput):
3517         (WebInspector.SearchSidebarPanel.prototype._searchTreeElementForResource):
3518         (WebInspector.SearchSidebarPanel.prototype._searchTreeElementForScript):
3519         (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange.delayedWork):
3520         (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
3521         (WebInspector.SearchSidebarPanel.prototype._treeElementSelected):
3522         * UserInterface/Views/SearchTabContentView.js: Added.
3523         (WebInspector.SearchTabContentView):
3524         (WebInspector.SearchTabContentView.prototype.get type):
3525         (WebInspector.SearchTabContentView.prototype.shown):
3526         (WebInspector.SearchTabContentView.prototype.closed):
3527         (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
3528         (WebInspector.SearchTabContentView.prototype.focusSearchField):
3529         (WebInspector.SearchTabContentView.prototype.performSearch):
3530         * UserInterface/Views/Toolbar.css:
3531         (.toolbar .item-section.center-right):
3532         (.toolbar .item-section.right):
3533         (.toolbar .search-bar):
3534         (.toolbar .search-bar > input[type="search"]):
3535         (.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
3536         (body.window-inactive .toolbar .search-bar > input[type="search"]):
3537         (.toolbar .item): Deleted.
3538
3539 2015-04-25  Timothy Hatcher  <timothy@apple.com>
3540
3541         Web Inspector: New Toolbar UI for tabs
3542         https://bugs.webkit.org/show_bug.cgi?id=144185
3543
3544         Reviewed by Joseph Pecoraro.
3545
3546         * UserInterface/Base/ImageUtilities.js:
3547         * UserInterface/Base/Main.js:
3548         (WebInspector.loaded):
3549         (WebInspector.contentLoaded):
3550         (WebInspector.updateDockedState):
3551         (WebInspector._captureDidStart):
3552         (WebInspector._debuggerDidPause):
3553         (WebInspector._debuggerDidResume):
3554         (WebInspector._mainFrameDidChange):
3555         (WebInspector._mainResourceDidChange):
3556         (WebInspector._windowKeyDown):
3557         (WebInspector._windowKeyUp):
3558         (WebInspector._pageHidden):
3559         (WebInspector._undock):
3560         (WebInspector._dockBottom):
3561         (WebInspector._dockRight):
3562         (WebInspector._updateDockNavigationItems):
3563         (WebInspector._domNodeWasInspected):
3564         (WebInspector._inspectModeStateChanged):
3565         (WebInspector._toggleInspectMode):
3566         (WebInspector._downloadWebArchive):
3567         (WebInspector._reloadPageClicked):
3568         (WebInspector._updateDownloadToolbarButton):
3569         (WebInspector.archiveMainFrame):
3570         (WebInspector.canArchiveMainFrame):
3571         * UserInterface/Images/Crosshair.svg:
3572         * UserInterface/Images/DockBottom.svg:
3573         * UserInterface/Images/DockRight.svg:
3574         * UserInterface/Images/DownloadArrow.svg:
3575         * UserInterface/Images/ReloadToolbar.svg: Added.
3576         * UserInterface/Images/Undock.svg:
3577         * UserInterface/Views/ActivateButtonToolbarItem.js:
3578         (WebInspector.ActivateButtonToolbarItem):
3579         (WebInspector.ActivateButtonToolbarItem.prototype.set label):
3580         * UserInterface/Views/ButtonToolbarItem.css:
3581         (.toolbar .item.button):
3582         (body.window-inactive .toolbar .item.button):
3583         (.toolbar.small-size .item.button > .glyph):
3584         * UserInterface/Views/ButtonToolbarItem.js:
3585         (WebInspector.ButtonToolbarItem):
3586         (WebInspector.ButtonToolbarItem.prototype.set label):
3587         * UserInterface/Views/DashboardContainerView.css:
3588         (.toolbar .dashboard-container):
3589         * UserInterface/Views/Main.css:
3590         (body.docked.bottom):
3591         * UserInterface/Views/Toolbar.css:
3592         (.toolbar):
3593         (body.mac-platform:not(.legacy, .docked) .toolbar):
3594         (.toolbar .control-section):
3595         (.toolbar .item-section):
3596         (.toolbar .item-section.left):
3597         (.toolbar .item-section.center-left):
3598         (.toolbar .item-section.center-right):
3599         (.toolbar .item-section.right):
3600         * UserInterface/Views/Toolbar.js:
3601         (WebInspector.Toolbar):
3602         (WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
3603         (WebInspector.Toolbar.prototype.customUpdateLayout):
3604         (WebInspector.Toolbar.prototype.addToolbarItem):
3605
3606 2015-04-25  Timothy Hatcher  <timothy@apple.com>
3607
3608         Web Inspector: Add NavigationBar to the details sidebar
3609         https://bugs.webkit.org/show_bug.cgi?id=144191
3610
3611         Reviewed by Joseph Pecoraro.
3612
3613         * UserInterface/Base/Main.js:
3614         (WebInspector.contentLoaded):
3615
3616         * UserInterface/Views/DetailsSidebarPanel.js:
3617         (WebInspector.DetailsSidebarPanel):
3618         (WebInspector.DetailsSidebarPanel.prototype.get navigationItem):
3619
3620         * UserInterface/Views/NavigationBar.js:
3621         (WebInspector.NavigationBar.prototype.removeNavigationItem):
3622         Remove unused index argument.
3623
3624         * UserInterface/Views/Sidebar.css:
3625         (.sidebar > .navigation-bar):
3626         (.sidebar.has-navigation-bar > .panel):
3627
3628         * UserInterface/Views/Sidebar.js:
3629         (WebInspector.Sidebar):
3630         (WebInspector.Sidebar.prototype.addSidebarPanel):
3631         (WebInspector.Sidebar.prototype.removeSidebarPanel):
3632         (WebInspector.Sidebar.prototype.set selectedSidebarPanel):
3633         (WebInspector.Sidebar.prototype.get minimumWidth):
3634         (WebInspector.Sidebar.prototype.set width):
3635         (WebInspector.Sidebar.prototype.set collapsed):
3636
3637 2015-04-24  Timothy Hatcher  <timothy@apple.com>
3638
3639         Web Inspector: Switch over to a tab based UI
3640         https://bugs.webkit.org/show_bug.cgi?id=144154
3641
3642         Reviewed by Joseph Pecoraro.
3643
3644         * UserInterface/Base/Main.js:
3645         (WebInspector.loaded):
3646         (WebInspector.contentLoaded):
3647         (WebInspector._tabContentViewForType):
3648         (WebInspector._rememberOpenTabs):
3649         (WebInspector._windowResized):
3650         (WebInspector._tabBrowserSizeDidChange):
3651         (WebInspector._quickConsoleDidResize):
3652         (WebInspector._sidebarWidthDidChange):
3653         (WebInspector._tabBrowserSelectedTabContentViewDidChange):
3654         (WebInspector._inspectModeStateChanged):
3655         (WebInspector._focusedContentView):
3656         * UserInterface/Main.html:
3657         * UserInterface/Views/Main.css:
3658         (#tab-browser):
3659
3660 2015-04-23  Timothy Hatcher  <timothy@apple.com>
3661
3662         Web Inspector: Remove Main.js code we don't need for Tabs
3663         https://bugs.webkit.org/show_bug.cgi?id=144126
3664
3665         Reviewed by Joseph Pecoraro.
3666
3667         * UserInterface/Base/Main.js:
3668         (WebInspector.loaded):
3669         (WebInspector.contentLoaded):
3670
3671 2015-04-23  Timothy Hatcher  <timothy@apple.com>
3672
3673         Web Inspector: Change more places that changed WebInspector.navigationSidebar.selectedSidebarPanel to tabs
3674         https://bugs.webkit.org/show_bug.cgi?id=144125
3675
3676         Reviewed by Joseph Pecoraro.
3677
3678         * UserInterface/Base/Main.js:
3679         (WebInspector.loaded):
3680         (WebInspector.toggleDetailsSidebar):
3681         (WebInspector.tabContentViewClassForRepresentedObject):
3682         (WebInspector._updateModifierKeys):
3683         (WebInspector._consoleResizerMouseDown.dockedResizerDragEnd):
3684         (WebInspector._consoleResizerMouseDown):
3685         (WebInspector.linkifyURLAsNode):
3686         (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
3687         * UserInterface/Protocol/InspectorFrontendAPI.js:
3688         (InspectorFrontendAPI.setTimelineProfilingEnabled):
3689         (InspectorFrontendAPI.showConsole):
3690         (InspectorFrontendAPI.showResources):
3691         * UserInterface/Protocol/InspectorObserver.js:
3692         (WebInspector.InspectorObserver.prototype.inspect):
3693         * UserInterface/Views/DebuggerTabContentView.js:
3694         (WebInspector.DebuggerTabContentView.prototype.canShowRepresentedObject):
3695         (WebInspector.DebuggerTabContentView.prototype.revealAndSelectBreakpoint):
3696         * UserInterface/Views/DefaultDashboardView.js:
3697         (WebInspector.DefaultDashboardView):
3698         (WebInspector.DefaultDashboardView.prototype._resourcesWasClicked):
3699         * UserInterface/Views/SourceCodeTextEditor.js:
3700         (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.revealInSidebar):
3701         * UserInterface/Views/TabBrowser.js:
3702         (WebInspector.TabBrowser.bestTabContentViewForClass):
3703
3704 2015-04-23  Timothy Hatcher  <timothy@apple.com>
3705
3706         Web Inspector: Make Console work in a tab world
3707         https://bugs.webkit.org/show_bug.cgi?id=144112
3708
3709         Reviewed by Joseph Pecoraro.
3710
3711         * UserInterface/Base/Main.js:
3712         (WebInspector.contentLoaded):
3713         (WebInspector.isShowingConsoleTab):
3714         (WebInspector.UIString):
3715         (WebInspector.toggleNavigationSidebar):
3716         (WebInspector.toggleDetailsSidebar):
3717         (WebInspector.tabContentViewClassForRepresentedObject):
3718         (WebInspector.linkifyStringAsFragment):
3719         * UserInterface/Images/Console.svg: Added.
3720         * UserInterface/Protocol/InspectorFrontendAPI.js:
3721         (InspectorFrontendAPI.showConsole):
3722         * UserInterface/Views/ConsoleTabContentView.js: Added.
3723         (WebInspector.ConsoleTabContentView):
3724         (WebInspector.ConsoleTabContentView.prototype.shown):
3725         (WebInspector.ConsoleTabContentView.prototype.showRepresentedObject):
3726         (WebInspector.ConsoleTabContentView.prototype.canShowRepresentedObject):
3727         (WebInspector.ConsoleTabContentView.prototype.get supportsSplitContentBrowser):
3728         * UserInterface/Views/DefaultDashboardView.js:
3729         (WebInspector.DefaultDashboardView.prototype._consoleItemWasClicked):
3730         * UserInterface/Views/LogContentView.js:
3731         (WebInspector.LogContentView):
3732         (WebInspector.LogContentView.prototype.get navigationItems):
3733         (WebInspector.LogContentView.prototype.shown):
3734         (WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
3735         (WebInspector.LogContentView.prototype._showConsoleTab):
3736         * UserInterface/Views/LogIcon.css:
3737         (.log-icon .icon):
3738         * UserInterface/Views/Main.css:
3739         (#split-content-browser .hierarchical-path-component.log-icon .icon):
3740         (#split-content-browser .hierarchical-path-component.log-icon .title):
3741         (#split-content-browser .hierarchical-path-component.log-icon select):
3742
3743 2015-04-23  Timothy Hatcher  <timothy@apple.com>
3744
3745         Web Inspector: Make showing a content view work in the tab world
3746         https://bugs.webkit.org/show_bug.cgi?id=144110
3747
3748         Reviewed by Joseph Pecoraro.
3749
3750         * UserInterface/Base/Main.js:
3751         (WebInspector.loaded):
3752         (WebInspector.hideSplitConsole):
3753         (WebInspector.showSourceCodeLocation):
3754         (WebInspector.showOriginalUnformattedSourceCodeLocation):
3755         (WebInspector.showOriginalOrFormattedSourceCodeLocation):
3756         (WebInspector.showOriginalOrFormattedSourceCodeTextRange):
3757         (WebInspector.showResourceRequest):
3758         (WebInspector.debuggerToggleBreakpoints):
3759         (WebInspector.debuggerPauseResumeToggle):
3760         (WebInspector.debuggerStepOver):
3761         (WebInspector.debuggerStepInto):
3762         (WebInspector.debuggerStepOut):
3763         (WebInspector._focusChanged):
3764         (WebInspector._mouseWasClicked):
3765         (WebInspector._dragOver):
3766         (WebInspector._captureDidStart):
3767         (WebInspector._debuggerDidPause):
3768         (WebInspector._debuggerDidResume):
3769         (WebInspector._frameWasAdded):
3770         (WebInspector._undock):
3771         (WebInspector._updateDockNavigationItems):
3772         * UserInterface/Models/Breakpoint.js:
3773         (WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
3774         (WebInspector.Breakpoint.prototype.appendContextMenuItems):
3775         * UserInterface/Protocol/InspectorFrontendAPI.js:
3776         (InspectorFrontendAPI.showMainResourceForFrame):
3777         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
3778         (WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
3779         * UserInterface/Views/ComputedStyleDetailsPanel.js:
3780         (WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
3781         (WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
3782         (WebInspector.ComputedStyleDetailsPanel):
3783         * UserInterface/Views/ContentBrowser.js:
3784         (WebInspector.ContentBrowser.prototype.updateHierarchicalPathForCurrentContentView):
3785         * UserInterface/Views/ContentView.js:
3786         (WebInspector.ContentView):
3787         * UserInterface/Views/DOMTreeContentView.js:
3788         (WebInspector.DOMTreeContentView.prototype.restoreFromCookie):
3789         * UserInterface/Views/DOMTreeDataGridNode.js:
3790         (WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):
3791         * UserInterface/Views/DebuggerSidebarPanel.js:
3792         (WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):