Support CSS Shapes Level 1 without a prefix
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2016-10-19  Dean Jackson  <dino@apple.com>
2
3         Support CSS Shapes Level 1 without a prefix
4         https://bugs.webkit.org/show_bug.cgi?id=163709
5         <rdar://problem/28859369>
6
7         Reviewed by Myles Maxfield.
8
9         Replace -webkit-shape-outside with shape-outside.
10
11         * UserInterface/Models/CSSKeywordCompletions.js:
12
13 2016-10-19  Aaron Chu  <aaron_chu@apple.com>
14
15         Web Inspector: AXI: expose computed tree node and heading level
16         https://bugs.webkit.org/show_bug.cgi?id=130825
17         <rdar://problem/16442349>
18
19         Reviewed by Joseph Pecoraro.
20
21         Updating the Web Accessibility Inspector to display Heading Level and Hierarchical Level.
22
23         * Localizations/en.lproj/localizedStrings.js:
24         * UserInterface/Models/DOMNode.js:
25         (WebInspector.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback):
26         (WebInspector.DOMNode.prototype.accessibilityProperties):
27         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
28         (WebInspector.DOMNodeDetailsSidebarPanel):
29         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
30         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):
31
32 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
33
34         Web Inspector: Styles Sidebar highlights "translate" but not "translateX"
35         https://bugs.webkit.org/show_bug.cgi?id=163613
36         <rdar://problem/28829610>
37
38         Reviewed by Timothy Hatcher.
39
40         * UserInterface/Models/CSSCompletions.js:
41         (WebInspector.CSSCompletions.requestCSSCompletions):
42         The hash table objects we pass to CodeMirror expects keys to be lowercased.
43
44 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
45
46         Web Inspector: CSS Autocompletion sometimes adds extra unexpected characters
47         https://bugs.webkit.org/show_bug.cgi?id=163612
48         <rdar://problem/28829557>
49
50         Reviewed by Timothy Hatcher.
51
52         * UserInterface/Controllers/CodeMirrorCompletionController.js:
53         (WebInspector.CodeMirrorCompletionController.prototype._generateCSSCompletions):
54         Better handle completions in cases where we are in the middle of a property
55         to avoid orphaned characters, or at the end of a function name to avoid creating
56         duplicate parenthesis.
57
58 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
59
60         REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
61         https://bugs.webkit.org/show_bug.cgi?id=163583
62         <rdar://problem/28815882>
63
64         Reviewed by Timothy Hatcher.
65
66         * UserInterface/Views/TimelineRecordingContentView.js:
67         (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
68         Revert logic change introduced by r201171 with no explanation.
69         Whenever we get a start time we should use it, regardless of
70         of what the current time is, precisely because the backend is
71         informing us of the start time to use.
72
73 2016-10-17  Joseph Pecoraro  <pecoraro@apple.com>
74
75         Web Inspector: Add toggles for debugger pauses at console.assert failures
76         https://bugs.webkit.org/show_bug.cgi?id=139542
77         <rdar://problem/19281600>
78
79         Reviewed by Timothy Hatcher.
80
81         * UserInterface/Controllers/DebuggerManager.js:
82         (WebInspector.DebuggerManager.prototype.get assertionsBreakpoint):
83         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
84         (WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
85         New breakpoint and toggling behavior.
86
87         * Localizations/en.lproj/localizedStrings.js:
88         * UserInterface/Views/DebuggerSidebarPanel.js:
89         (WebInspector.DebuggerSidebarPanel):
90         (WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineDeleteTreeElement):
91         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint):
92         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):
93         New breakpoint tree element behavior.
94
95         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
96         (WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
97         Sidebar restoration if it was selected.
98
99         * UserInterface/Images/Assertion.svg: Added.
100         * UserInterface/Images/gtk/Assertion.svg: Added.
101         * UserInterface/Views/BreakpointTreeElement.css:
102         (.breakpoint-assertion-icon .icon):
103         New sidebar icon for the global breakpoint.
104
105 2016-10-15  Joseph Pecoraro  <pecoraro@apple.com>
106
107         Web Inspector: Cleanup parts of DebuggerManager
108         https://bugs.webkit.org/show_bug.cgi?id=163400
109
110         Reviewed by Timothy Hatcher.
111
112         * UserInterface/Controllers/DebuggerManager.js:
113         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
114
115         (WebInspector.DebuggerManager.prototype.get paused):
116         (WebInspector.DebuggerManager.prototype.get pauseReason):
117         (WebInspector.DebuggerManager.prototype.get pauseData):
118         (WebInspector.DebuggerManager.prototype.get callFrames):
119         (WebInspector.DebuggerManager.prototype.get activeCallFrame):
120         (WebInspector.DebuggerManager.prototype.set activeCallFrame):
121         Put simple accessors at the top.
122
123         (WebInspector.DebuggerManager.prototype.get allExceptionsBreakpoint):
124         (WebInspector.DebuggerManager.prototype.get allUncaughtExceptionsBreakpoint):
125         (WebInspector.DebuggerManager.prototype.get breakpoints):
126         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
127         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
128         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
129         (WebInspector.DebuggerManager.prototype.isBreakpointEditable):
130         (WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
131         Group public breakpoint state and access methods.
132
133         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
134         (WebInspector.DebuggerManager.prototype.scriptsForURL):
135         (WebInspector.DebuggerManager.prototype.get searchableScripts):
136         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
137         Group public script access methods.
138
139         (WebInspector.DebuggerManager.prototype.pause):
140         (WebInspector.DebuggerManager.prototype.resume):
141         (WebInspector.DebuggerManager.prototype.stepOver):
142         (WebInspector.DebuggerManager.prototype.stepInto):
143         (WebInspector.DebuggerManager.prototype.stepOut):
144         (WebInspector.DebuggerManager.prototype.continueToLocation):
145         (WebInspector.DebuggerManager.prototype.addBreakpoint):
146         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
147         Group and modernize public methods that perform actions.
148
149         (WebInspector.DebuggerManager.prototype.nextBreakpointActionIdentifier):
150         Misc. methods.
151
152         (WebInspector.DebuggerManager.prototype.breakpointResolved):
153         (WebInspector.DebuggerManager.prototype.reset):
154         (WebInspector.DebuggerManager.prototype.playBreakpointActionSound):
155         (WebInspector.DebuggerManager.prototype.scriptDidParse):
156         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
157         (WebInspector.DebuggerManager.prototype._setBreakpoint):
158         (WebInspector.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
159         (WebInspector.DebuggerManager.prototype._updateBreakOnExceptionsState):
160         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
161         Minor cleanup in protected and private methods.
162
163         * UserInterface/Models/BreakpointAction.js:
164         (WebInspector.BreakpointAction):
165         Getting the next identifier is an action so it should be a function call.
166
167         * UserInterface/Views/SourceCodeTextEditor.js:
168         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
169         Remove unused parameter.
170
171 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
172
173         Web Inspector: Dragging to delete a Breakpoint should never trigger a ContentView change
174         https://bugs.webkit.org/show_bug.cgi?id=163403
175         <rdar://problem/28762930>
176
177         Reviewed by Timothy Hatcher.
178
179         * UserInterface/Views/BreakpointTreeElement.js:
180         (WebInspector.BreakpointTreeElement.prototype.ondelete):
181         Signal when a breakpoint tree element will be going away because it was
182         deleted via the keyboard operation within the TreeOutline. This is a dirty
183         way to do the signal but we remove BreakpointTreeElements asynchronously
184         when the Breakpoint actually gets removed from the backend.
185
186         * UserInterface/Views/DebuggerSidebarPanel.js:
187         (WebInspector.DebuggerSidebarPanel.prototype._removeDebuggerTreeElement):
188         Deselect a BreakpointTreeElement if it was deleted in a way other then
189         the delete keyboard shortcut. This ensures another TreeElement selection
190         doesn't force ContentView changes.
191
192 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
193
194         Web Inspector: Improve debugger highlight when inside of getter/setter calls
195         https://bugs.webkit.org/show_bug.cgi?id=163428
196         <rdar://problem/28769061>
197
198         Reviewed by Timothy Hatcher.
199
200         * UserInterface/Views/SourceCodeTextEditor.js:
201         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
202         When in the middle of a member expression at a '.' or '[' get the best member
203         expression range.
204
205         * UserInterface/Views/TextEditor.js:
206         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
207         Include the character at the current position. This is useful since AST Nodes
208         don't give us token info but we would like to know if we are at particular tokens.
209
210 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
211
212         Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
213         https://bugs.webkit.org/show_bug.cgi?id=163395
214
215         Reviewed by Timothy Hatcher.
216
217         * UserInterface/Models/Breakpoint.js:
218         (WebInspector.Breakpoint.prototype.get identifier): Renamed.
219         (WebInspector.Breakpoint.prototype.set identifier): Renamed.
220         The only user is DebuggerManager which sets and gets. Previously
221         it was unexpectedly setting a direct property on the Breakpoint
222         instead of using these methods to set the member variable.
223
224 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
225
226         Web Inspector: Remove uses of delete in SourceCodeTextEditor
227         https://bugs.webkit.org/show_bug.cgi?id=163379
228
229         Reviewed by Timothy Hatcher.
230
231         Remove uses of delete and better group member variables.
232         One of the deletes was deleting an incorrect property.
233
234         * UserInterface/Views/SourceCodeTextEditor.js:
235         (WebInspector.SourceCodeTextEditor):
236         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
237         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointRemoved):
238         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointMoved):
239         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
240         (WebInspector.SourceCodeTextEditor.prototype._dismissEditingController):
241         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
242
243 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
244
245         Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
246         https://bugs.webkit.org/show_bug.cgi?id=163405
247         <rdar://problem/28763953>
248
249         Reviewed by Matt Baker.
250
251         * UserInterface/Views/SourceCodeTextEditor.js:
252         Use correct method name, the old one must have gone away.
253
254 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
255
256         Web Inspector: Improve support for logging Proxy objects in console
257         https://bugs.webkit.org/show_bug.cgi?id=163323
258         <rdar://problem/28432553>
259
260         Reviewed by Timothy Hatcher.
261
262         * UserInterface/Views/ConsoleMessageView.js:
263         (WebInspector.ConsoleMessageView.prototype._formatParameter):
264         Treat a Proxy like any other object.
265
266 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
267
268         Emit DebugHooks uniformly with pause locations instead of having separate pause locations and op_debug emits
269         https://bugs.webkit.org/show_bug.cgi?id=162809
270
271         Reviewed by Geoffrey Garen.
272
273         * UserInterface/Views/SourceCodeTextEditor.js:
274         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
275         When pausing on the variable assignment inside for..of and for..in don't just
276         highlight "var foo" but include the right hand side "var foo in ..." or
277         "var foo of ...".
278
279 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
280
281         Web Inspector: Whole program sometimes highlighted instead of just first statement
282         https://bugs.webkit.org/show_bug.cgi?id=163300
283         <rdar://problem/28723162>
284
285         Reviewed by Timothy Hatcher.
286
287         * UserInterface/Views/SourceCodeTextEditor.js:
288         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
289         Avoid highlighting the entire program by skipping a Program type Node.
290
291         * UserInterface/Views/TextEditor.js:
292         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
293         Avoid unnecessary work before content has loaded.
294
295         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
296         Avoid unnecessary indirection to get the CodeMirror editor.
297
298 2016-10-11  Joseph Pecoraro  <pecoraro@apple.com>
299
300         Web Inspector: Remove line highlight on primary execution line while stepping because it is distracting
301         https://bugs.webkit.org/show_bug.cgi?id=163294
302         <rdar://problem/28721176>
303
304         Reviewed by Timothy Hatcher.
305
306         * UserInterface/Views/TextEditor.js:
307         (WebInspector.TextEditor.prototype._updateExecutionLine):
308         When setting the primary execution line, remove default line highlights.
309
310 2016-10-10  Matt Baker  <mattbaker@apple.com>
311
312         Web Inspector: Revealed line not highlighted in TextEditor while debugger paused
313         https://bugs.webkit.org/show_bug.cgi?id=163197
314
315         Reviewed by Timothy Hatcher.
316
317         * UserInterface/Views/TextEditor.js:
318         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
319         Avoid highlighting the execution line while debugging, but allow
320         other lines to be highlighted.
321
322 2016-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
323
324         Inspector exception in `parseTextForRule()` when pasting into CSS rule selector
325         https://bugs.webkit.org/show_bug.cgi?id=162792
326
327         Reviewed by Matt Baker.
328
329         * UserInterface/Views/CSSStyleDeclarationSection.js:
330         (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
331         Changed regular expression for matching CSS rules to allow newlines in pasted text.
332
333 2016-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
334
335         Web Inspector: Clicking twice on the color swatch square should hide the color picker
336         https://bugs.webkit.org/show_bug.cgi?id=162759
337
338         Reviewed by Matt Baker.
339
340         * UserInterface/Views/InlineSwatch.js:
341         (WebInspector.InlineSwatch):
342         (WebInspector.InlineSwatch.prototype.didDismissPopover):
343         (WebInspector.InlineSwatch.prototype._swatchElementClicked):
344         Remove the "click" event listener when a popover is presented to prevent improper
345         interaction.  Add the event listener back when the popover is dismissed.
346
347 2016-10-02  Matt Baker  <mattbaker@apple.com>
348
349         Web Inspector: Exception thrown when hovering network waterfall graphs during reload
350         https://bugs.webkit.org/show_bug.cgi?id=162850
351         <rdar://problem/28579653>
352
353         Reviewed by Brian Burg.
354
355         * UserInterface/Views/ResourceTimelineDataGridNode.js:
356         (WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
357         Check that the node's data grid reference is valid before use.
358         (WebInspector.ResourceTimelineDataGridNode):
359
360 2016-10-01  Joseph Pecoraro  <pecoraro@apple.com>
361
362         Web Inspector: Selection does not show up over execution highlight ranges
363         https://bugs.webkit.org/show_bug.cgi?id=162844
364         <rdar://problem/28579121>
365
366         Reviewed by Matt Baker.
367
368         * Scripts/update-codemirror-resources.rb:
369         * UserInterface/External/CodeMirror/mark-selection.js: Added.
370         * UserInterface/Main.html:
371         New add-on that makes selection a text marker so it can be styled
372         at the same level as other text markers.
373
374         * UserInterface/Views/TextEditor.css:
375         (.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext)):
376         Don't use execution-range-highlight styles if the text is selected.
377
378         * UserInterface/Views/TextEditor.js:
379         (WebInspector.TextEditor):
380         Enable the text selection as text markers addon.
381
382 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
383
384         Web Inspector: Make debugger stepping highlights work in inline <script>s
385         https://bugs.webkit.org/show_bug.cgi?id=162753
386         <rdar://problem/28551332>
387
388         Reviewed by Brian Burg.
389
390         * UserInterface/Models/TextRange.js:
391         (WebInspector.TextRange.prototype.contains):
392         Check if a given line/column falls within this range.
393
394         * UserInterface/Views/SourceCodeTextEditor.js:
395         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
396         If we are in a Document resource find the associated script at a given position.
397
398         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
399         When comparing offsets to SyntaxTree offsets, the SyntaxTree's offset of 0 is the
400         first character of the Script, which differs from the current SourceCode's offset.
401         Adjust the offset by the Script's startOffset.
402
403         * UserInterface/Views/TextEditor.js:
404         (WebInspector.TextEditor.prototype.currentPositionToOriginalPosition):
405         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
406         Pass both the original offset and original position to the delegate.
407
408 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
409
410         Web Inspector: Stepping through `a(); b(); c();` it is unclear where we are and what is about to execute
411         https://bugs.webkit.org/show_bug.cgi?id=161658
412         <rdar://problem/28181254>
413
414         Reviewed by Geoffrey Garen.
415
416         * UserInterface/Models/Script.js:
417         (WebInspector.Script.prototype.requestScriptSyntaxTree):
418         Fix first calls to requestScriptSyntaxTree. They were getting an uncaught
419         exception because the content argument was missing.
420
421         * UserInterface/Models/ScriptSyntaxTree.js:
422         (WebInspector.ScriptSyntaxTree.prototype.containersOfOffset):
423         Find all AST nodes that contain a particular offset.
424
425         * UserInterface/Views/SourceCodeTextEditor.js:
426         (WebInspector.SourceCodeTextEditor):
427         (WebInspector.SourceCodeTextEditor.prototype.close):
428         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
429         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameSourceCodeLocationChanged):
430         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
431         Provide a good highlight range for a given offset. This is normally the start
432         of a statement/expression, inside a statement/expression, or the closing brace
433         of a function (leaving a function). Provide good ranges for each of these.
434
435         * UserInterface/Views/TextEditor.js:
436         (WebInspector.TextEditor):
437         (WebInspector.TextEditor.set string.update):
438         (WebInspector.TextEditor.prototype.set string):
439         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
440         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
441         (WebInspector.TextEditor.prototype.revealPosition):
442         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
443         (WebInspector.TextEditor.prototype._updateAfterFormatting):
444         (WebInspector.TextEditor.prototype.set executionLineNumber): Deleted.
445         (WebInspector.TextEditor.prototype.set executionColumnNumber): Deleted.
446         (WebInspector.TextEditor.prototype._updateExecutionLine.update): Deleted.
447         Always set the execution line and column together, to simplify how we update highlights.
448
449         (WebInspector.TextEditor.prototype._clearMultilineExecutionLineHighlights):
450         (WebInspector.TextEditor.prototype._updateExecutionLine):
451         When updating the main highlight clear any multi-line highlights.
452
453         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
454         Ask the delegate for a specific highlight range. If provided use that range,
455         otherwise just highlight the end of the line. Once we know the range, if it
456         is multiple lines, give the extra lines the full line highlight as well.
457         Also make adjustments, such as not highlighting trailing whitespace.
458
459         * UserInterface/Views/TextEditor.css:
460         (.text-editor > .CodeMirror .execution-line.primary .CodeMirror-linenumber::after):
461         (.text-editor > .CodeMirror .execution-line):
462         (.text-editor > .CodeMirror .execution-line .CodeMirror-matchingbracket):
463         (.text-editor > .CodeMirror .execution-range-highlight):
464         Styles for execution lines and execution range highlights.
465
466 2016-09-29  Aaron Chu  <aaron_chu@apple.com>
467
468         Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
469         https://bugs.webkit.org/show_bug.cgi?id=130600
470         <rdar://problem/16391333>
471
472         Reviewed by Brian Burg.
473
474         Removing link style for non-navigable nodes by first
475         checking nodeType of the node.
476
477         * UserInterface/Base/DOMUtilities.js:
478         (WebInspector.linkifyNodeReference):
479
480 2016-09-27  Matt Baker  <mattbaker@apple.com>
481
482         Web Inspector: Refreshing while in Timelines-tab causes negative timestamps in Network-tab
483         https://bugs.webkit.org/show_bug.cgi?id=160051
484         <rdar://problem/27480122>
485
486         Reviewed by Brian Burg.
487
488         * UserInterface/Views/NetworkGridContentView.js:
489         (WebInspector.NetworkGridContentView.prototype.get startTime):
490         (WebInspector.NetworkGridContentView.prototype.get zeroTime):
491         Use the cached start time for graph data source properties instead of
492         relying on the ruler, which requires a layout in order to be updated
493         for the first time.
494
495 2016-09-27  Matt Baker  <mattbaker@apple.com>
496
497         Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
498         https://bugs.webkit.org/show_bug.cgi?id=162572
499         <rdar://problem/28479562>
500
501         Reviewed by Brian Burg.
502
503         Improve NavigationSidebarPanel logic for coordinating selection between trees.
504         When tree selection changes, the most recent selection should be restored
505         the next time the tree is focused.
506
507         The sidebar should also handle focusing a tree for the first time, in
508         which no previous selection exists, and focusing a tree that has had its
509         previous selection filtered out (hidden).
510
511         * UserInterface/Views/NavigationSidebarPanel.js:
512         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus):
513         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
514         Restoring the last deselected element, instead of the last selected element
515         only works when the selection is moving from one tree to another. When
516         the elements belong to the same tree the newly selected element won't
517         be saved until the next selection change. If the window loses and regains
518         the focus before then, the tree will restore the previous selection,
519         effectively reverting the last selection change.
520
521 2016-09-27  Tomas Popela  <tpopela@redhat.com>
522
523         [GTK] Mac defaults are used for key shortcuts on Linux
524         https://bugs.webkit.org/show_bug.cgi?id=162564
525
526         Don't set Mac's default keymap as a fallthrough for CodeMirror when we
527         are not on Mac.
528
529         Reviewed by Carlos Garcia Campos.
530
531         * UserInterface/Test.html: Include Platform.js for the
532         WebInspector.Platform definition.
533         * UserInterface/Views/CodeMirrorAdditions.js:
534
535 2016-09-26  Matt Baker  <mattbaker@apple.com>
536
537         Web Inspector: Box Model values not updated when DOM node styles change
538         https://bugs.webkit.org/show_bug.cgi?id=162525
539
540         Reviewed by Brian Burg.
541
542         The Box Model section should refresh itself when the selected node's
543         computed style changes. This is necessary since the Styles sidebar
544         doesn't always refresh its sections on node changes.
545
546         * UserInterface/Views/BoxModelDetailsSectionRow.js:
547         (WebInspector.BoxModelDetailsSectionRow.prototype.set nodeStyles):
548         Refresh metrics whenever the computed style changes.
549
550         (WebInspector.BoxModelDetailsSectionRow.prototype._getBox):
551         (WebInspector.BoxModelDetailsSectionRow.prototype._getComponentSuffix):
552         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createValueElement):
553         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
554         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
555         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):
556         Drive-by cleanup to make this large function easier to read.
557         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement): Deleted.
558         Renamed createValueElement.
559         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaWidthElement): Deleted.
560         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaHeightElement): Deleted.
561         Combined these into a single function taking a property name (width or height).
562
563 == Rolled over to ChangeLog-2016-09-26 ==