Unreviewed, rolling out r152598.
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2013-07-14  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r152598.
4         http://trac.webkit.org/changeset/152598
5         https://bugs.webkit.org/show_bug.cgi?id=118658
6
7         totally broke the web inspector (JS ERROR: SyntaxError:
8         Expected token '}') (Requested by thorton on #webkit).
9
10         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
11         * Tools/PrettyPrinting/Formatter.js:
12         * Tools/PrettyPrinting/FormatterContentBuilder.js:
13         * Tools/PrettyPrinting/codemirror.css:
14         (.CodeMirror-scrollbar-filler):
15         (.CodeMirror-gutters):
16         (.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
17         (.CodeMirror-widget):
18         * Tools/PrettyPrinting/codemirror.js:
19         (window.CodeMirror):
20         (window.CodeMirror.):
21         (.do):
22         (moveVisually):
23         * Tools/PrettyPrinting/css.js:
24         (.):
25         (CodeMirror):
26         * Tools/PrettyPrinting/javascript.js:
27         (.):
28         * UserInterface/External/CodeMirror/codemirror.css:
29         (.CodeMirror-widget):
30         * UserInterface/External/CodeMirror/codemirror.js:
31         (window.CodeMirror):
32         (window.CodeMirror.):
33         * UserInterface/External/CodeMirror/coffeescript.js:
34         * UserInterface/External/CodeMirror/comment.js:
35         (.):
36         * UserInterface/External/CodeMirror/css.js:
37         (.):
38         (CodeMirror):
39         * UserInterface/External/CodeMirror/javascript.js:
40         (.):
41         * UserInterface/External/CodeMirror/matchbrackets.js:
42         (.):
43         * UserInterface/External/CodeMirror/sql.js:
44         * UserInterface/External/CodeMirror/xml.js:
45
46 2013-07-12  Timothy Hatcher  <timothy@apple.com>
47
48         Update CodeMirror to 7f560afa1c (3.14+).
49
50         https://bugs.webkit.org/show_bug.cgi?id=118605
51
52         Reviewed by Sam Weinig.
53
54         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
55         * Tools/PrettyPrinting/Formatter.js:
56         * Tools/PrettyPrinting/FormatterContentBuilder.js:
57         * Tools/PrettyPrinting/codemirror.css:
58         * Tools/PrettyPrinting/codemirror.js:
59         * Tools/PrettyPrinting/css.js:
60         * Tools/PrettyPrinting/javascript.js:
61         * UserInterface/External/CodeMirror/codemirror.css:
62         * UserInterface/External/CodeMirror/codemirror.js:
63         * UserInterface/External/CodeMirror/coffeescript.js:
64         * UserInterface/External/CodeMirror/comment.js:
65         * UserInterface/External/CodeMirror/css.js:
66         * UserInterface/External/CodeMirror/javascript.js:
67         * UserInterface/External/CodeMirror/matchbrackets.js:
68         * UserInterface/External/CodeMirror/sql.js:
69         * UserInterface/External/CodeMirror/xml.js:
70
71 2013-07-12  Seokju Kwon  <seokju.kwon@gmail.com>
72
73         Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
74         https://bugs.webkit.org/show_bug.cgi?id=118589
75
76         Reviewed by Timothy Hatcher.
77
78         sidebarPanels : It is necessary to get correct argument after r152141.
79         Without this, error messages can be displayed.
80         role : Could pass null for it since default value is "group".
81
82         * UserInterface/Main.js:
83         (WebInspector.contentLoaded):
84
85 2013-07-03  Timothy Hatcher  <timothy@apple.com>
86
87         Guard remaining calls to decodeURIComponent with a try/catch.
88
89         https://bugs.webkit.org/show_bug.cgi?id=118371
90
91         Reviewed by Joseph Pecoraro.
92
93         * UserInterface/Main.js:
94         (WebInspector.displayNameForURL):
95         (WebInspector.updateWindowTitle):
96         * UserInterface/Utilities.js:
97         (arrayResult):
98         (queryString):
99
100 2013-07-03  Jessie Berlin  <jberlin@apple.com>
101
102         Ran update-webkit-localizable-strings.
103
104         Rubber-stamped by Joseph Pecoraro.
105
106         * Localizations/en.lproj/localizedStrings.js:
107
108 2013-06-28  Dean Jackson  <dino@apple.com>
109
110         Update Apple System fonts in auto-complete
111         https://bugs.webkit.org/show_bug.cgi?id=118205
112         <rdar://problem/14308488>
113
114         Reviewed by Joseph Pecoraro.
115
116         Update for the new Apple System font names, and remove some invalid entries.
117
118         * UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
119         "apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
120
121 2013-06-28  James Craig  <james@cookiecrook.com>
122
123         Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
124         https://bugs.webkit.org/show_bug.cgi?id=118122
125
126         Reviewed by Timothy Hatcher.
127
128         Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
129         so that screen readers will not indicate a bogus :required/:invalid state to the user.
130         Minor cosmetic difference blocked by http://webkit.org/b/118162
131
132         * UserInterface/FilterBar.css:
133         (.filter-bar > input[type="search"]:focus):
134         (.filter-bar > input[type="search"]:not(:placeholder-shown)):
135         * UserInterface/FilterBar.js:
136         (WebInspector.FilterBar):
137         * UserInterface/ResourceSidebarPanel.js:
138         (WebInspector.ResourceSidebarPanel):
139         * UserInterface/SearchBar.css:
140         (.search-bar > input[type="search"]:focus):
141         (.search-bar > input[type="search"]:not(:placeholder-shown)):
142         * UserInterface/SearchBar.js:
143         (WebInspector.SearchBar):
144
145 2013-06-27  James Craig  <james@cookiecrook.com>
146
147         Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.) 
148         so the layout is more discoverable to screen reader users
149         https://bugs.webkit.org/show_bug.cgi?id=118104
150
151         Reviewed by Timothy Hatcher.
152
153         Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
154         and navigable with VoiceOver.
155
156         * Localizations/en.lproj/localizedStrings.js:
157         * UserInterface/ButtonNavigationItem.js:
158         * UserInterface/CSSStyleDetailsSidebarPanel.js:
159         * UserInterface/DashboardManager.js:
160         * UserInterface/Main.js:
161         * UserInterface/NavigationBar.js:
162         * UserInterface/NavigationItem.js:
163         * UserInterface/NavigationSidebarPanel.js:
164         * UserInterface/RadioButtonNavigationItem.js:
165         * UserInterface/Sidebar.js:
166         * UserInterface/SidebarPanel.js:
167         * UserInterface/Toolbar.js:
168
169 2013-06-27  James Craig  <james@cookiecrook.com>
170
171         Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
172         https://bugs.webkit.org/show_bug.cgi?id=115976
173
174         Reviewed by Timothy Hatcher.
175
176         Main console log area (div.console-messages) is now an ARIA live region (role="log")
177         so screen readers speak plain text updates.
178         
179         Also added contextual labels (e.g. input/output) but speech output verification of
180         those is currently blocked by http://webkit.org/b/118096
181
182         * Localizations/en.lproj/localizedStrings.js:
183         * UserInterface/ConsoleCommand.js:
184         (WebInspector.ConsoleCommand.prototype.toMessageElement):
185         * UserInterface/ConsoleCommandResult.js:
186         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
187         * UserInterface/LogContentView.css:
188         (@media reader):
189         * UserInterface/LogContentView.js:
190         (WebInspector.LogContentView):
191
192
193 2013-06-27  Matthew Holden  <jftholden@yahoo.com>
194
195         Web Inspector: Display color picker in popover on color swatch click
196         https://bugs.webkit.org/show_bug.cgi?id=117919
197
198         Reviewed by Timothy Hatcher.
199
200         Includes fixes from second code review.
201
202         * Localizations/en.lproj/localizedStrings.js:
203         * UserInterface/CSSColorPicker.css: Added.
204         (.colorpicker-container):
205         (.colorpicker-fill-parent):
206         (.colorpicker-top):
207         (.colorpicker-color):
208         (.colorpicker-bottom span):
209         (.colorpicker-text):
210         (.colorpicker-color-text-value):
211         (.colorpicker-hue):
212         (.colorpicker-fill):
213         (.colorpicker-range-container):
214         (.colorpicker-range-container *):
215         (.colorpicker-range-container label):
216         (.colorpicker-range-container input):
217         (.colorpicker-saturation):
218         (.colorpicker-value):
219         (.colorpicker-dragger):
220         (.colorpicker-slider):
221         (.colorpicker-container .swatch):
222         (.colorpicker-container .swatch-inner):
223         * UserInterface/CSSColorPicker.js: Added.
224         (WebInspector.CSSColorPicker.consume):
225         (WebInspector.CSSColorPicker.move):
226         (WebInspector.CSSColorPicker.start):
227         (WebInspector.CSSColorPicker.stop):
228         (WebInspector.CSSColorPicker.makeDraggable):
229         (WebInspector.CSSColorPicker.hueDrag):
230         (WebInspector.CSSColorPicker.colorDragStart):
231         (WebInspector.CSSColorPicker.colorDrag):
232         (WebInspector.CSSColorPicker.alphaDrag):
233         (WebInspector.CSSColorPicker.colorSwatchClicked):
234         (WebInspector.CSSColorPicker):
235         (WebInspector.CSSColorPicker.prototype.get element):
236         (WebInspector.CSSColorPicker.prototype.set color):
237         (WebInspector.CSSColorPicker.prototype.get color):
238         (WebInspector.CSSColorPicker.prototype.get outputColorFormat):
239         (WebInspector.CSSColorPicker.prototype.get colorHueOnly):
240         (WebInspector.CSSColorPicker.prototype.set displayText):
241         (WebInspector.CSSColorPicker.prototype.shown):
242         (WebInspector.CSSColorPicker.prototype._updateHelperLocations):
243         (WebInspector.CSSColorPicker.prototype._updateDisplay):
244         (WebInspector.CSSColorPicker.hsvaToRGBA):
245         (WebInspector.CSSColorPicker.rgbaToHSVA):
246         * UserInterface/CSSStyleDeclarationTextEditor.js:
247         (WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
248         (WebInspector.CSSStyleDeclarationTextEditor.prototype.):
249         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
250         (WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
251         (WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
252         * UserInterface/Main.html:
253
254 2013-06-26  Antoine Quint  <graouts@apple.com>
255
256         Web Inspector: stepping through while paused in debugger makes a popover appear
257         https://bugs.webkit.org/show_bug.cgi?id=117994
258
259         There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
260         active call frame changes and it leads to an extraneous display of the popover.
261
262         Reviewed by Timothy Hatcher.
263
264         * UserInterface/SourceCodeTextEditor.js:
265         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
266
267 2013-06-24  Antoine Quint  <graouts@apple.com>
268
269         Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
270         https://bugs.webkit.org/show_bug.cgi?id=117927
271
272         Handle possible mis-encoded URI fragments passed to decodeURIComponent() which
273         could prevent inspection of the DOM.
274
275         Reviewed by Timothy Hatcher.
276
277         * UserInterface/Main.js:
278         (WebInspector.displayNameForURL):
279
280 2013-06-17  Darin Adler  <darin@apple.com>
281
282         Sort all the Xcode project files
283         https://bugs.webkit.org/show_bug.cgi?id=117696
284
285         Reviewed by Anders Carlsson.
286
287         * WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
288
289 2013-06-21  Joseph Pecoraro  <pecoraro@apple.com>
290
291         Web Inspector: Uncaught exception when pretty printing WebInspector.Script
292         https://bugs.webkit.org/show_bug.cgi?id=117893
293
294         This was an issue with an earlier refactoring. The sourceCode is a Script,
295         so replace the non-existent local variable "script" with "this._sourceCode".
296
297         Reviewed by Timothy Hatcher.
298
299         * UserInterface/SourceCodeTextEditor.js:
300         (WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):
301
302 2013-06-21  Timothy Hatcher  <timothy@apple.com>
303
304         Stop removing and re-adding breakpoints from the backend on reload.
305
306         On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
307         Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
308         don't need to update the backend, since nothing really changed.
309
310         https://bugs.webkit.org/show_bug.cgi?id=117877
311
312         Reviewed by Joseph Pecoraro.
313
314         * UserInterface/DebuggerManager.js:
315         (WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
316         _ignoreBreakpointDisplayLocationDidChangeEvent is true.
317         (WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
318         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.
319
320 2013-06-19  Antoine Quint  <graouts@apple.com>
321
322         Web Inspector: Copying array or object output does not contain values
323         https://bugs.webkit.org/show_bug.cgi?id=117669
324
325         ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
326         in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
327         We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
328         and, additionally, only use that prefix if we're copying more than a single message since it's
329         the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
330         a log level always print the level and when saving the console log using Cmd+S, all messages
331         contain their prefix as well.
332
333         Reviewed by Timothy Hatcher.
334
335         * UserInterface/ConsoleCommand.js:
336         (WebInspector.ConsoleCommand.prototype.toClipboardString):
337         Handle the new isPrefixOptional argument.
338
339         * UserInterface/ConsoleCommandResult.js:
340         (WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
341         Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
342         the prefix isn't printed out in situations when it may not.
343
344         * UserInterface/ConsoleMessageImpl.js:
345         Set "enforcesClipboardPrefixString" to true since we always want to log the log level
346         prefix in all situations.
347
348         (WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
349         Implement this new getter to return our clipboard string such that subclasses may
350         customize it.
351
352         (WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
353         Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
354         to only log the prefix if necessary.
355
356         * UserInterface/LogContentView.js:
357         (WebInspector.LogContentView.prototype._formatMessagesAsData):
358         Make the logging of prefix optional when we have a single message selected and we're
359         not saving via Cmd+S.
360
361 2013-06-18  Joseph Pecoraro  <pecoraro@apple.com>
362
363         Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
364         https://bugs.webkit.org/show_bug.cgi?id=117755
365
366         Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
367         and Rect prototypes, so they get the expected methods. We then need to
368         handle the ZERO_RECT case better, and not attempt to draw a background
369         in a canvas with a 0 size, which would produce an exception.
370
371         Reviewed by Timothy Hatcher.
372
373         * UserInterface/Geometry.js:
374         * UserInterface/Popover.js:
375         (WebInspector.Popover.prototype._update):
376
377 2013-06-18  Timothy Hatcher  <timothy@apple.com>
378
379         If the tree outline is processing a selection currently, then don't change the selection.
380
381         This is needed to allow breakpoints tree elements to be selected without jumping back to
382         selecting the resource tree element.
383
384         https://bugs.webkit.org/show_bug.cgi?id=117746
385
386         Reviewed by Joseph Pecoraro.
387
388         * UserInterface/Main.js:
389         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
390         * UserInterface/TreeOutline.js:
391         (TreeElement.prototype.select):
392
393 2013-06-18  Timothy Hatcher  <timothy@apple.com>
394
395         Update breakpoints to match Xcode 5.
396
397         This updates the breakpoint images, line colors, and moves breakpoints toggle button
398         to the Debugger sidebar navigation bar.
399
400         https://bugs.webkit.org/show_bug.cgi?id=117723
401
402         Reviewed by Joseph Pecoraro.
403
404         * Localizations/en.lproj/localizedStrings.js: Updated.
405         * UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
406         * UserInterface/DebuggerSidebarPanel.js:
407         (WebInspector.DebuggerSidebarPanel):
408         (WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):
409         * UserInterface/Images/Breakpoint.png: Updated.
410         * UserInterface/Images/Breakpoints.pdf: Added.
411         * UserInterface/Images/Breakpoint@2x.png: Updated.
412         * UserInterface/Images/BreakpointButton.pdf: Updated.
413         * UserInterface/Images/BreakpointInactive.png: Updated.
414         * UserInterface/Images/BreakpointInactive@2x.png: Updated.
415         * UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
416         * UserInterface/Images/InstructionPointer.png: Updated.
417         * UserInterface/Images/InstructionPointer@2x.png: Updated.
418         * UserInterface/SourceCodeTextEditor.css:
419         (.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
420         (.source-code.text-editor > .CodeMirror .warning): Ditto.
421         * UserInterface/TextEditor.css:
422         (.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
423         (.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
424         (.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.
425
426 2013-06-13  Joseph Pecoraro  <pecoraro@apple.com>
427
428         <http://webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space between "do" and "{"
429
430         Reviewed by Timothy Hatcher.
431
432         * UserInterface/CodeMirrorFormatters.js:
433
434 2013-06-13  Joseph Pecoraro  <pecoraro@apple.com>
435
436         <http://webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel when I remove all text search text
437
438         Reviewed by Timothy Hatcher.
439
440         * UserInterface/ResourceSidebarPanel.js:
441         (WebInspector.ResourceSidebarPanel):
442         (WebInspector.ResourceSidebarPanel.prototype._searchFieldInput):
443
444 == Rolled over to ChangeLog-2013-06-11 ==