Web Inspector: Cmd-+ doesn't "zoom in" to increase text size in the Web Inspector
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2016-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Cmd-+ doesn't "zoom in" to increase text size in the Web Inspector
4         https://bugs.webkit.org/show_bug.cgi?id=163961
5         <rdar://problem/28895308>
6
7         Reviewed by Brian Burg.
8
9         * UserInterface/Base/Main.js:
10         (WebInspector.contentLoaded):
11         Add a duplicate set of keyboard shortcuts for the Shift variants.
12
13 2016-10-25  Joseph Pecoraro  <pecoraro@apple.com>
14
15         Web Inspector: Remove dead code in FrameTreeElement
16         https://bugs.webkit.org/show_bug.cgi?id=163914
17
18         Reviewed by Brian Burg.
19
20         * UserInterface/Views/FrameTreeElement.js:
21
22 2016-10-24  Devin Rousso  <dcrousso+webkit@gmail.com>
23
24         Web Inspector: Scope chain shouldn't show empty Closure sections
25         https://bugs.webkit.org/show_bug.cgi?id=152348
26
27         Reviewed by Joseph Pecoraro.
28
29         * UserInterface/Controllers/DebuggerManager.js:
30         (WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
31         * UserInterface/Models/ScopeChainNode.js:
32         (WebInspector.ScopeChainNode):
33         (WebInspector.ScopeChainNode.prototype.get empty):
34         Added support for new empty property.
35
36         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
37         (WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
38         Only create and display a DetailsSection if the scope is not empty (via empty).
39
40 2016-10-24  Devin Rousso  <dcrousso+webkit@gmail.com>
41
42         Web Inspector: Improve Quick Open sorting algorithm
43         https://bugs.webkit.org/show_bug.cgi?id=163705
44
45         Reviewed by Joseph Pecoraro.
46
47         * UserInterface/Models/ResourceQueryResult.js:
48         (WebInspector.ResourceQueryResult.prototype._calculateRank.getMultiplier):
49         (WebInspector.ResourceQueryResult.prototype._calculateRank):
50         Added logic to multiply the ranking increment/decrement based on whether the current match
51         is part of a sequence, whether that sequence began with a special character, and the length
52         of the current sequence.
53
54 2016-10-19  Dean Jackson  <dino@apple.com>
55
56         Support CSS Shapes Level 1 without a prefix
57         https://bugs.webkit.org/show_bug.cgi?id=163709
58         <rdar://problem/28859369>
59
60         Reviewed by Myles Maxfield.
61
62         Replace -webkit-shape-outside with shape-outside.
63
64         * UserInterface/Models/CSSKeywordCompletions.js:
65
66 2016-10-19  Aaron Chu  <aaron_chu@apple.com>
67
68         Web Inspector: AXI: expose computed tree node and heading level
69         https://bugs.webkit.org/show_bug.cgi?id=130825
70         <rdar://problem/16442349>
71
72         Reviewed by Joseph Pecoraro.
73
74         Updating the Web Accessibility Inspector to display Heading Level and Hierarchical Level.
75
76         * Localizations/en.lproj/localizedStrings.js:
77         * UserInterface/Models/DOMNode.js:
78         (WebInspector.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback):
79         (WebInspector.DOMNode.prototype.accessibilityProperties):
80         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
81         (WebInspector.DOMNodeDetailsSidebarPanel):
82         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
83         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):
84
85 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
86
87         Web Inspector: Styles Sidebar highlights "translate" but not "translateX"
88         https://bugs.webkit.org/show_bug.cgi?id=163613
89         <rdar://problem/28829610>
90
91         Reviewed by Timothy Hatcher.
92
93         * UserInterface/Models/CSSCompletions.js:
94         (WebInspector.CSSCompletions.requestCSSCompletions):
95         The hash table objects we pass to CodeMirror expects keys to be lowercased.
96
97 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
98
99         Web Inspector: CSS Autocompletion sometimes adds extra unexpected characters
100         https://bugs.webkit.org/show_bug.cgi?id=163612
101         <rdar://problem/28829557>
102
103         Reviewed by Timothy Hatcher.
104
105         * UserInterface/Controllers/CodeMirrorCompletionController.js:
106         (WebInspector.CodeMirrorCompletionController.prototype._generateCSSCompletions):
107         Better handle completions in cases where we are in the middle of a property
108         to avoid orphaned characters, or at the end of a function name to avoid creating
109         duplicate parenthesis.
110
111 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
112
113         REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
114         https://bugs.webkit.org/show_bug.cgi?id=163583
115         <rdar://problem/28815882>
116
117         Reviewed by Timothy Hatcher.
118
119         * UserInterface/Views/TimelineRecordingContentView.js:
120         (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
121         Revert logic change introduced by r201171 with no explanation.
122         Whenever we get a start time we should use it, regardless of
123         of what the current time is, precisely because the backend is
124         informing us of the start time to use.
125
126 2016-10-17  Joseph Pecoraro  <pecoraro@apple.com>
127
128         Web Inspector: Add toggles for debugger pauses at console.assert failures
129         https://bugs.webkit.org/show_bug.cgi?id=139542
130         <rdar://problem/19281600>
131
132         Reviewed by Timothy Hatcher.
133
134         * UserInterface/Controllers/DebuggerManager.js:
135         (WebInspector.DebuggerManager.prototype.get assertionsBreakpoint):
136         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
137         (WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
138         New breakpoint and toggling behavior.
139
140         * Localizations/en.lproj/localizedStrings.js:
141         * UserInterface/Views/DebuggerSidebarPanel.js:
142         (WebInspector.DebuggerSidebarPanel):
143         (WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineDeleteTreeElement):
144         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint):
145         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):
146         New breakpoint tree element behavior.
147
148         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
149         (WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
150         Sidebar restoration if it was selected.
151
152         * UserInterface/Images/Assertion.svg: Added.
153         * UserInterface/Images/gtk/Assertion.svg: Added.
154         * UserInterface/Views/BreakpointTreeElement.css:
155         (.breakpoint-assertion-icon .icon):
156         New sidebar icon for the global breakpoint.
157
158 2016-10-15  Joseph Pecoraro  <pecoraro@apple.com>
159
160         Web Inspector: Cleanup parts of DebuggerManager
161         https://bugs.webkit.org/show_bug.cgi?id=163400
162
163         Reviewed by Timothy Hatcher.
164
165         * UserInterface/Controllers/DebuggerManager.js:
166         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
167
168         (WebInspector.DebuggerManager.prototype.get paused):
169         (WebInspector.DebuggerManager.prototype.get pauseReason):
170         (WebInspector.DebuggerManager.prototype.get pauseData):
171         (WebInspector.DebuggerManager.prototype.get callFrames):
172         (WebInspector.DebuggerManager.prototype.get activeCallFrame):
173         (WebInspector.DebuggerManager.prototype.set activeCallFrame):
174         Put simple accessors at the top.
175
176         (WebInspector.DebuggerManager.prototype.get allExceptionsBreakpoint):
177         (WebInspector.DebuggerManager.prototype.get allUncaughtExceptionsBreakpoint):
178         (WebInspector.DebuggerManager.prototype.get breakpoints):
179         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
180         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
181         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
182         (WebInspector.DebuggerManager.prototype.isBreakpointEditable):
183         (WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
184         Group public breakpoint state and access methods.
185
186         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
187         (WebInspector.DebuggerManager.prototype.scriptsForURL):
188         (WebInspector.DebuggerManager.prototype.get searchableScripts):
189         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
190         Group public script access methods.
191
192         (WebInspector.DebuggerManager.prototype.pause):
193         (WebInspector.DebuggerManager.prototype.resume):
194         (WebInspector.DebuggerManager.prototype.stepOver):
195         (WebInspector.DebuggerManager.prototype.stepInto):
196         (WebInspector.DebuggerManager.prototype.stepOut):
197         (WebInspector.DebuggerManager.prototype.continueToLocation):
198         (WebInspector.DebuggerManager.prototype.addBreakpoint):
199         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
200         Group and modernize public methods that perform actions.
201
202         (WebInspector.DebuggerManager.prototype.nextBreakpointActionIdentifier):
203         Misc. methods.
204
205         (WebInspector.DebuggerManager.prototype.breakpointResolved):
206         (WebInspector.DebuggerManager.prototype.reset):
207         (WebInspector.DebuggerManager.prototype.playBreakpointActionSound):
208         (WebInspector.DebuggerManager.prototype.scriptDidParse):
209         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
210         (WebInspector.DebuggerManager.prototype._setBreakpoint):
211         (WebInspector.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
212         (WebInspector.DebuggerManager.prototype._updateBreakOnExceptionsState):
213         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
214         Minor cleanup in protected and private methods.
215
216         * UserInterface/Models/BreakpointAction.js:
217         (WebInspector.BreakpointAction):
218         Getting the next identifier is an action so it should be a function call.
219
220         * UserInterface/Views/SourceCodeTextEditor.js:
221         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
222         Remove unused parameter.
223
224 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
225
226         Web Inspector: Dragging to delete a Breakpoint should never trigger a ContentView change
227         https://bugs.webkit.org/show_bug.cgi?id=163403
228         <rdar://problem/28762930>
229
230         Reviewed by Timothy Hatcher.
231
232         * UserInterface/Views/BreakpointTreeElement.js:
233         (WebInspector.BreakpointTreeElement.prototype.ondelete):
234         Signal when a breakpoint tree element will be going away because it was
235         deleted via the keyboard operation within the TreeOutline. This is a dirty
236         way to do the signal but we remove BreakpointTreeElements asynchronously
237         when the Breakpoint actually gets removed from the backend.
238
239         * UserInterface/Views/DebuggerSidebarPanel.js:
240         (WebInspector.DebuggerSidebarPanel.prototype._removeDebuggerTreeElement):
241         Deselect a BreakpointTreeElement if it was deleted in a way other then
242         the delete keyboard shortcut. This ensures another TreeElement selection
243         doesn't force ContentView changes.
244
245 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
246
247         Web Inspector: Improve debugger highlight when inside of getter/setter calls
248         https://bugs.webkit.org/show_bug.cgi?id=163428
249         <rdar://problem/28769061>
250
251         Reviewed by Timothy Hatcher.
252
253         * UserInterface/Views/SourceCodeTextEditor.js:
254         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
255         When in the middle of a member expression at a '.' or '[' get the best member
256         expression range.
257
258         * UserInterface/Views/TextEditor.js:
259         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
260         Include the character at the current position. This is useful since AST Nodes
261         don't give us token info but we would like to know if we are at particular tokens.
262
263 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
264
265         Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
266         https://bugs.webkit.org/show_bug.cgi?id=163395
267
268         Reviewed by Timothy Hatcher.
269
270         * UserInterface/Models/Breakpoint.js:
271         (WebInspector.Breakpoint.prototype.get identifier): Renamed.
272         (WebInspector.Breakpoint.prototype.set identifier): Renamed.
273         The only user is DebuggerManager which sets and gets. Previously
274         it was unexpectedly setting a direct property on the Breakpoint
275         instead of using these methods to set the member variable.
276
277 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
278
279         Web Inspector: Remove uses of delete in SourceCodeTextEditor
280         https://bugs.webkit.org/show_bug.cgi?id=163379
281
282         Reviewed by Timothy Hatcher.
283
284         Remove uses of delete and better group member variables.
285         One of the deletes was deleting an incorrect property.
286
287         * UserInterface/Views/SourceCodeTextEditor.js:
288         (WebInspector.SourceCodeTextEditor):
289         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
290         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointRemoved):
291         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointMoved):
292         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
293         (WebInspector.SourceCodeTextEditor.prototype._dismissEditingController):
294         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
295
296 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
297
298         Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
299         https://bugs.webkit.org/show_bug.cgi?id=163405
300         <rdar://problem/28763953>
301
302         Reviewed by Matt Baker.
303
304         * UserInterface/Views/SourceCodeTextEditor.js:
305         Use correct method name, the old one must have gone away.
306
307 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
308
309         Web Inspector: Improve support for logging Proxy objects in console
310         https://bugs.webkit.org/show_bug.cgi?id=163323
311         <rdar://problem/28432553>
312
313         Reviewed by Timothy Hatcher.
314
315         * UserInterface/Views/ConsoleMessageView.js:
316         (WebInspector.ConsoleMessageView.prototype._formatParameter):
317         Treat a Proxy like any other object.
318
319 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
320
321         Emit DebugHooks uniformly with pause locations instead of having separate pause locations and op_debug emits
322         https://bugs.webkit.org/show_bug.cgi?id=162809
323
324         Reviewed by Geoffrey Garen.
325
326         * UserInterface/Views/SourceCodeTextEditor.js:
327         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
328         When pausing on the variable assignment inside for..of and for..in don't just
329         highlight "var foo" but include the right hand side "var foo in ..." or
330         "var foo of ...".
331
332 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
333
334         Web Inspector: Whole program sometimes highlighted instead of just first statement
335         https://bugs.webkit.org/show_bug.cgi?id=163300
336         <rdar://problem/28723162>
337
338         Reviewed by Timothy Hatcher.
339
340         * UserInterface/Views/SourceCodeTextEditor.js:
341         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
342         Avoid highlighting the entire program by skipping a Program type Node.
343
344         * UserInterface/Views/TextEditor.js:
345         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
346         Avoid unnecessary work before content has loaded.
347
348         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
349         Avoid unnecessary indirection to get the CodeMirror editor.
350
351 2016-10-11  Joseph Pecoraro  <pecoraro@apple.com>
352
353         Web Inspector: Remove line highlight on primary execution line while stepping because it is distracting
354         https://bugs.webkit.org/show_bug.cgi?id=163294
355         <rdar://problem/28721176>
356
357         Reviewed by Timothy Hatcher.
358
359         * UserInterface/Views/TextEditor.js:
360         (WebInspector.TextEditor.prototype._updateExecutionLine):
361         When setting the primary execution line, remove default line highlights.
362
363 2016-10-10  Matt Baker  <mattbaker@apple.com>
364
365         Web Inspector: Revealed line not highlighted in TextEditor while debugger paused
366         https://bugs.webkit.org/show_bug.cgi?id=163197
367
368         Reviewed by Timothy Hatcher.
369
370         * UserInterface/Views/TextEditor.js:
371         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
372         Avoid highlighting the execution line while debugging, but allow
373         other lines to be highlighted.
374
375 2016-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
376
377         Inspector exception in `parseTextForRule()` when pasting into CSS rule selector
378         https://bugs.webkit.org/show_bug.cgi?id=162792
379
380         Reviewed by Matt Baker.
381
382         * UserInterface/Views/CSSStyleDeclarationSection.js:
383         (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
384         Changed regular expression for matching CSS rules to allow newlines in pasted text.
385
386 2016-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
387
388         Web Inspector: Clicking twice on the color swatch square should hide the color picker
389         https://bugs.webkit.org/show_bug.cgi?id=162759
390
391         Reviewed by Matt Baker.
392
393         * UserInterface/Views/InlineSwatch.js:
394         (WebInspector.InlineSwatch):
395         (WebInspector.InlineSwatch.prototype.didDismissPopover):
396         (WebInspector.InlineSwatch.prototype._swatchElementClicked):
397         Remove the "click" event listener when a popover is presented to prevent improper
398         interaction.  Add the event listener back when the popover is dismissed.
399
400 2016-10-02  Matt Baker  <mattbaker@apple.com>
401
402         Web Inspector: Exception thrown when hovering network waterfall graphs during reload
403         https://bugs.webkit.org/show_bug.cgi?id=162850
404         <rdar://problem/28579653>
405
406         Reviewed by Brian Burg.
407
408         * UserInterface/Views/ResourceTimelineDataGridNode.js:
409         (WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
410         Check that the node's data grid reference is valid before use.
411         (WebInspector.ResourceTimelineDataGridNode):
412
413 2016-10-01  Joseph Pecoraro  <pecoraro@apple.com>
414
415         Web Inspector: Selection does not show up over execution highlight ranges
416         https://bugs.webkit.org/show_bug.cgi?id=162844
417         <rdar://problem/28579121>
418
419         Reviewed by Matt Baker.
420
421         * Scripts/update-codemirror-resources.rb:
422         * UserInterface/External/CodeMirror/mark-selection.js: Added.
423         * UserInterface/Main.html:
424         New add-on that makes selection a text marker so it can be styled
425         at the same level as other text markers.
426
427         * UserInterface/Views/TextEditor.css:
428         (.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext)):
429         Don't use execution-range-highlight styles if the text is selected.
430
431         * UserInterface/Views/TextEditor.js:
432         (WebInspector.TextEditor):
433         Enable the text selection as text markers addon.
434
435 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
436
437         Web Inspector: Make debugger stepping highlights work in inline <script>s
438         https://bugs.webkit.org/show_bug.cgi?id=162753
439         <rdar://problem/28551332>
440
441         Reviewed by Brian Burg.
442
443         * UserInterface/Models/TextRange.js:
444         (WebInspector.TextRange.prototype.contains):
445         Check if a given line/column falls within this range.
446
447         * UserInterface/Views/SourceCodeTextEditor.js:
448         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
449         If we are in a Document resource find the associated script at a given position.
450
451         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
452         When comparing offsets to SyntaxTree offsets, the SyntaxTree's offset of 0 is the
453         first character of the Script, which differs from the current SourceCode's offset.
454         Adjust the offset by the Script's startOffset.
455
456         * UserInterface/Views/TextEditor.js:
457         (WebInspector.TextEditor.prototype.currentPositionToOriginalPosition):
458         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
459         Pass both the original offset and original position to the delegate.
460
461 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
462
463         Web Inspector: Stepping through `a(); b(); c();` it is unclear where we are and what is about to execute
464         https://bugs.webkit.org/show_bug.cgi?id=161658
465         <rdar://problem/28181254>
466
467         Reviewed by Geoffrey Garen.
468
469         * UserInterface/Models/Script.js:
470         (WebInspector.Script.prototype.requestScriptSyntaxTree):
471         Fix first calls to requestScriptSyntaxTree. They were getting an uncaught
472         exception because the content argument was missing.
473
474         * UserInterface/Models/ScriptSyntaxTree.js:
475         (WebInspector.ScriptSyntaxTree.prototype.containersOfOffset):
476         Find all AST nodes that contain a particular offset.
477
478         * UserInterface/Views/SourceCodeTextEditor.js:
479         (WebInspector.SourceCodeTextEditor):
480         (WebInspector.SourceCodeTextEditor.prototype.close):
481         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
482         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameSourceCodeLocationChanged):
483         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
484         Provide a good highlight range for a given offset. This is normally the start
485         of a statement/expression, inside a statement/expression, or the closing brace
486         of a function (leaving a function). Provide good ranges for each of these.
487
488         * UserInterface/Views/TextEditor.js:
489         (WebInspector.TextEditor):
490         (WebInspector.TextEditor.set string.update):
491         (WebInspector.TextEditor.prototype.set string):
492         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
493         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
494         (WebInspector.TextEditor.prototype.revealPosition):
495         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
496         (WebInspector.TextEditor.prototype._updateAfterFormatting):
497         (WebInspector.TextEditor.prototype.set executionLineNumber): Deleted.
498         (WebInspector.TextEditor.prototype.set executionColumnNumber): Deleted.
499         (WebInspector.TextEditor.prototype._updateExecutionLine.update): Deleted.
500         Always set the execution line and column together, to simplify how we update highlights.
501
502         (WebInspector.TextEditor.prototype._clearMultilineExecutionLineHighlights):
503         (WebInspector.TextEditor.prototype._updateExecutionLine):
504         When updating the main highlight clear any multi-line highlights.
505
506         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
507         Ask the delegate for a specific highlight range. If provided use that range,
508         otherwise just highlight the end of the line. Once we know the range, if it
509         is multiple lines, give the extra lines the full line highlight as well.
510         Also make adjustments, such as not highlighting trailing whitespace.
511
512         * UserInterface/Views/TextEditor.css:
513         (.text-editor > .CodeMirror .execution-line.primary .CodeMirror-linenumber::after):
514         (.text-editor > .CodeMirror .execution-line):
515         (.text-editor > .CodeMirror .execution-line .CodeMirror-matchingbracket):
516         (.text-editor > .CodeMirror .execution-range-highlight):
517         Styles for execution lines and execution range highlights.
518
519 2016-09-29  Aaron Chu  <aaron_chu@apple.com>
520
521         Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
522         https://bugs.webkit.org/show_bug.cgi?id=130600
523         <rdar://problem/16391333>
524
525         Reviewed by Brian Burg.
526
527         Removing link style for non-navigable nodes by first
528         checking nodeType of the node.
529
530         * UserInterface/Base/DOMUtilities.js:
531         (WebInspector.linkifyNodeReference):
532
533 2016-09-27  Matt Baker  <mattbaker@apple.com>
534
535         Web Inspector: Refreshing while in Timelines-tab causes negative timestamps in Network-tab
536         https://bugs.webkit.org/show_bug.cgi?id=160051
537         <rdar://problem/27480122>
538
539         Reviewed by Brian Burg.
540
541         * UserInterface/Views/NetworkGridContentView.js:
542         (WebInspector.NetworkGridContentView.prototype.get startTime):
543         (WebInspector.NetworkGridContentView.prototype.get zeroTime):
544         Use the cached start time for graph data source properties instead of
545         relying on the ruler, which requires a layout in order to be updated
546         for the first time.
547
548 2016-09-27  Matt Baker  <mattbaker@apple.com>
549
550         Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
551         https://bugs.webkit.org/show_bug.cgi?id=162572
552         <rdar://problem/28479562>
553
554         Reviewed by Brian Burg.
555
556         Improve NavigationSidebarPanel logic for coordinating selection between trees.
557         When tree selection changes, the most recent selection should be restored
558         the next time the tree is focused.
559
560         The sidebar should also handle focusing a tree for the first time, in
561         which no previous selection exists, and focusing a tree that has had its
562         previous selection filtered out (hidden).
563
564         * UserInterface/Views/NavigationSidebarPanel.js:
565         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus):
566         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
567         Restoring the last deselected element, instead of the last selected element
568         only works when the selection is moving from one tree to another. When
569         the elements belong to the same tree the newly selected element won't
570         be saved until the next selection change. If the window loses and regains
571         the focus before then, the tree will restore the previous selection,
572         effectively reverting the last selection change.
573
574 2016-09-27  Tomas Popela  <tpopela@redhat.com>
575
576         [GTK] Mac defaults are used for key shortcuts on Linux
577         https://bugs.webkit.org/show_bug.cgi?id=162564
578
579         Don't set Mac's default keymap as a fallthrough for CodeMirror when we
580         are not on Mac.
581
582         Reviewed by Carlos Garcia Campos.
583
584         * UserInterface/Test.html: Include Platform.js for the
585         WebInspector.Platform definition.
586         * UserInterface/Views/CodeMirrorAdditions.js:
587
588 2016-09-26  Matt Baker  <mattbaker@apple.com>
589
590         Web Inspector: Box Model values not updated when DOM node styles change
591         https://bugs.webkit.org/show_bug.cgi?id=162525
592
593         Reviewed by Brian Burg.
594
595         The Box Model section should refresh itself when the selected node's
596         computed style changes. This is necessary since the Styles sidebar
597         doesn't always refresh its sections on node changes.
598
599         * UserInterface/Views/BoxModelDetailsSectionRow.js:
600         (WebInspector.BoxModelDetailsSectionRow.prototype.set nodeStyles):
601         Refresh metrics whenever the computed style changes.
602
603         (WebInspector.BoxModelDetailsSectionRow.prototype._getBox):
604         (WebInspector.BoxModelDetailsSectionRow.prototype._getComponentSuffix):
605         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createValueElement):
606         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
607         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
608         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):
609         Drive-by cleanup to make this large function easier to read.
610         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement): Deleted.
611         Renamed createValueElement.
612         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaWidthElement): Deleted.
613         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaHeightElement): Deleted.
614         Combined these into a single function taking a property name (width or height).
615
616 == Rolled over to ChangeLog-2016-09-26 ==