Web Inspector: Remove harmless error for not getting named flows
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-06-29  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Remove harmless error for not getting named flows
4         https://bugs.webkit.org/show_bug.cgi?id=146417
5
6         Reviewed by Darin Adler.
7
8         * UserInterface/Controllers/DOMTreeManager.js:
9
10 2015-06-29  Joseph Pecoraro  <pecoraro@apple.com>
11
12         Web Inspector: Network errors (404) are missing location link in console messages
13         https://bugs.webkit.org/show_bug.cgi?id=146442
14
15         Reviewed by Darin Adler.
16
17         * UserInterface/Views/ConsoleMessageView.js:
18         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
19         Restore behavior of adding a location link for network messages with urls.
20
21 2015-06-29  Joseph Pecoraro  <pecoraro@apple.com>
22
23         Web Inspector: iOS 8: Resources Timeline Data does not show up
24         https://bugs.webkit.org/show_bug.cgi?id=146433
25
26         Reviewed by Timothy Hatcher.
27
28         There were a couple issues with initializing the legacy base timestamp
29         for attempting to dynamically compute monotonically increasing timestamps
30         for timeline events for legacy backends.
31
32             * Sometimes legacy timestamps were in seconds since epochs,
33               sometimes milliseconds. The frontend did not handle both.
34
35             * On navigations, even while resetting the base timestamp for
36               the first new record received, the main resource still had
37               a will send request time computed from the previous page's
38               time system. This patch re-uses the original timestamp for
39               this main resource as the new base and all future records
40               are computed relative to this.
41
42         * UserInterface/Controllers/FrameResourceManager.js:
43         (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
44         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
45         * UserInterface/Models/Resource.js:
46         (WebInspector.Resource):
47         (WebInspector.Resource.prototype.get originalRequestWillBeSentTimestamp):
48         For legacy timestamp calculations, save the original request will be sent
49         timestamp on the Resource in case it is needed.
50
51         * UserInterface/Controllers/TimelineManager.js:
52         (WebInspector.TimelineManager.prototype._loadNewRecording):
53         When auto-starting a new recording for a navigation / reload, use the
54         main resource's request will be sent timestamp as the new base.
55
56         * UserInterface/Models/TimelineRecording.js:
57         Address legacy timeline timestamps by handling both legacy timestamps
58         that may be seconds / milliseconds.
59
60 2015-06-29  Joseph Pecoraro  <pecoraro@apple.com>
61
62         REGRESSION: Web Inspector: Jump to Definition is broken
63         https://bugs.webkit.org/show_bug.cgi?id=146376
64
65         Reviewed by Timothy Hatcher.
66
67         * UserInterface/Views/ObjectTreeBaseTreeElement.js:
68         (WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
69         Allow changing tabs when jumping to function definition.
70
71 2015-06-28  Nikita Vasilyev  <nvasilyev@apple.com>
72
73         Web Inspector: Wrong border color of console messages when filters are enabled
74         https://bugs.webkit.org/show_bug.cgi?id=146392
75
76         Reviewed by Timothy Hatcher.
77
78         * UserInterface/Views/LogContentView.css:
79         (.console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
80         (.console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
81
82 2015-06-25  Matt Baker  <mattbaker@apple.com>
83
84         Web Inspector: Wrong timeline selected after switching from Rendering Frames to Timelines
85         https://bugs.webkit.org/show_bug.cgi?id=146331
86
87         Reviewed by Timothy Hatcher.
88
89         * UserInterface/Views/TimelineSidebarPanel.js:
90         Set previously selected timeline type to null if no tree element is selected when switching
91         view mode to Rendering Frames.
92
93 2015-06-25  Joseph Pecoraro  <pecoraro@apple.com>
94
95         [Mac] Web Inspector: Window dragging on toolbar should behave more like native window dragging
96         https://bugs.webkit.org/show_bug.cgi?id=146324
97
98         Reviewed by Timothy Hatcher.
99
100         * UserInterface/Base/Main.js:
101         On Mac 10.11 transition to using InspectorFrontendHost.startWindowDrag.
102         For older Macs continue to use InspectorFrontendHost.moveWindowBy.
103         
104         * UserInterface/Protocol/InspectorFrontendHostStub.js:
105         (WebInspector.InspectorFrontendHostStub.prototype.startWindowDrag):
106         Add the stub for InspectorFrontendHostStub.
107
108 2015-06-24  Devin Rousso  <drousso@apple.com>
109
110         Web Inspector: Pressing tab in the styles sidebar shouldn't insert a tab character
111         https://bugs.webkit.org/show_bug.cgi?id=146189
112
113         Reviewed by Timothy Hatcher.
114
115         * UserInterface/Controllers/CodeMirrorCompletionController.js: Added variable to control whether semicolons are added to the end of autocompleted css values.
116         (WebInspector.CodeMirrorCompletionController):
117         (WebInspector.CodeMirrorCompletionController.prototype.set noEndingSemicolon):
118         (WebInspector.CodeMirrorCompletionController.prototype._generateCSSCompletions):
119         * UserInterface/Views/CSSStyleDeclarationSection.js:
120         (WebInspector.CSSStyleDeclarationSection):
121         (WebInspector.CSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorSwitchRule):
122         (WebInspector.CSSStyleDeclarationSection.prototype.focusRuleSelector):
123         (WebInspector.CSSStyleDeclarationSection.prototype.selectLastProperty):
124         (WebInspector.CSSStyleDeclarationSection.prototype.get selectorLocked):
125         (WebInspector.CSSStyleDeclarationSection.prototype.get locked):
126         (WebInspector.CSSStyleDeclarationSection.prototype._handleKeyDown):
127         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
128         (WebInspector.CSSStyleDeclarationTextEditor): Added functions for "Tab", "Shift-Tab", and "Shift-Enter" keypresses to improve usability.
129         (WebInspector.CSSStyleDeclarationTextEditor.prototype.selectFirstProperty): Highlights the first property.
130         (WebInspector.CSSStyleDeclarationTextEditor.prototype.selectLastProperty): Highlights the last property.
131         (WebInspector.CSSStyleDeclarationTextEditor.prototype._insertNewlineAfterCurrentLine): Inserts a newline after the currently selected line.
132         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey.switchRule):
133         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey): Pressing shift-tab will move the cursor to the previous non-word character that is immediately after a word character.
134         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey.switchRule):
135         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey.highlightNextNameOrValue):
136         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey): Pressing tab will move the cursor to each space character until the end of the line is reached, at
137         which point the cursor will move to the beginning of the next line.  Once the cursor is at the last line, pressing tab again will insert a newline.
138         * UserInterface/Views/RulesStyleDetailsPanel.js:
139         (WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorNextRule): Switches the focused rule to the next section.
140         (WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorPrevRule): Switches the focused rule to the previous section.
141
142 2015-06-24  Joseph Pecoraro  <pecoraro@apple.com>
143
144         Web Inspector: console.group looks poor in console
145         https://bugs.webkit.org/show_bug.cgi?id=146295
146
147         Reviewed by Timothy Hatcher.
148
149         * Localizations/en.lproj/localizedStrings.js:
150         String for the default group name if you use console.group() without a name parameter.
151
152         * UserInterface/Views/LogContentView.css:
153         (.console-group-title::before):
154         Tweak the positioning and eliminate the log level ::before image.
155
156         * UserInterface/Views/ConsoleMessageView.js:
157         (WebInspector.ConsoleMessageView):
158         Reorder a bit to reduce a couple branches.
159
160         (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
161         Take a very straightforward approach for group names.
162
163 2015-06-24  Devin Rousso  <drousso@apple.com>
164
165         Web Inspector: Show warning icon for invalid CSS properties and/or values
166         https://bugs.webkit.org/show_bug.cgi?id=145657
167
168         Reviewed by Timothy Hatcher.
169
170         * UserInterface/Models/CSSCompletions.js:
171         (WebInspector.CSSCompletions.prototype.getClosestPropertyName): Calculates the levenshtein distance between a given property and every existing property name.  Returns the property name with the smallest distance or, in the case of multiple properties having the same distance, the first property in alphabetical order.
172         (WebInspector.CSSCompletions.prototype.propertyRequiresWebkitPrefix): Retruns if the property name exists only with a '-webkit-' prefix.
173         (WebInspector.CSSCompletions):
174         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
175         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .invalid-warning-marker):
176         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .invalid-warning-marker.clickable:hover):
177         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
178         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded.duplicatePropertyExistsBelow): Determines if there exists a property below (visually) the given property that has the same name.
179         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded.generateInvalidMarker): Creates a warning icon marker at the given position with the given title.
180         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded.instancesOfProperty): Returns the number of properties in the rule that have the same name.
181         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): A button with a warning icon is now added to the beginning of an invalid property.  If this button is clicked, the property is replaced with the closest matching property and the autocomplete menu is opened.
182
183 2015-06-24  Devin Rousso  <drousso@apple.com>
184
185         Web Inspector: Background of Computed Styles is missing
186         https://bugs.webkit.org/show_bug.cgi?id=146209
187
188         Reviewed by Timothy Hatcher.
189
190         * UserInterface/Views/ComputedStyleDetailsPanel.css:
191         (.computed-style-properties.details-section): Added white background.
192
193 2015-06-24  Joseph Pecoraro  <pecoraro@apple.com>
194
195         Web Inspector: Right/Left arrow no longer works in console to expand/collapse ObjectTrees
196         https://bugs.webkit.org/show_bug.cgi?id=141949
197
198         Reviewed by Timothy Hatcher.
199
200         * UserInterface/Views/ConsoleMessageView.js:
201         (WebInspector.ConsoleMessageView):
202         (WebInspector.ConsoleMessageView.prototype.get expandable):
203         (WebInspector.ConsoleMessageView.prototype.set expandable): Deleted.
204         (WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
205         (WebInspector.ConsoleMessageView.prototype._appendStackTrace):
206         (WebInspector.ConsoleMessageView.prototype._makeExpandable):
207         Clarify what makes a ConsoleMessageView expandable or not.
208
209         (WebInspector.ConsoleMessageView.prototype.expand):
210         (WebInspector.ConsoleMessageView.prototype.collapse):
211         Handle the expand/collapse cases which could apply to the
212         ConsoleMessageView itself or an inner ObjectTreeView if that is all we contain.
213
214         (WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
215         Delete out of date comment. A console.log("message", obj) will want the
216         object tree member variable to handle auto expanding/collapsing of the
217         single object in the message.
218
219         * UserInterface/Views/LogContentView.js:
220         (WebInspector.LogContentView.prototype._leftArrowWasPressed):
221         (WebInspector.LogContentView.prototype._rightArrowWasPressed):
222         Use the higher level ConsoleMessageView objects accessible from the element
223         to call through to expand/collapse.
224
225 2015-06-23  Joseph Pecoraro  <pecoraro@apple.com>
226
227         Web Inspector: Reduce QuickConsole DidResize events if it did not change
228         https://bugs.webkit.org/show_bug.cgi?id=146258
229
230         Reviewed by Timothy Hatcher.
231
232         * UserInterface/Views/QuickConsole.js:
233         (WebInspector.QuickConsole.prototype.consoleLogVisibilityChanged):
234         Do not trigger the event unless there was a change in visibility.
235
236 2015-06-23  Joseph Pecoraro  <pecoraro@apple.com>
237
238         Web Inspector: TextEditor scroll position not correctly restored when switching tabs
239         https://bugs.webkit.org/show_bug.cgi?id=146254
240
241         Reviewed by Timothy Hatcher.
242
243         * UserInterface/Views/TextEditor.js:
244         (WebInspector.TextEditor.prototype.updateLayout):
245         Workaround a larger issue with ContentView restoration so that
246         TextEditors restore their scroll position as expected.
247
248 2015-06-23  Joseph Pecoraro  <pecoraro@apple.com>
249
250         Web Inspector: Some brief previews are incorrectly treated as lossless
251         https://bugs.webkit.org/show_bug.cgi?id=146247
252
253         Reviewed by Timothy Hatcher.
254
255         * UserInterface/Views/ObjectPreviewView.js:
256         (WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
257         (WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
258         When we have a brief preview we may need to override lossless / overflow
259         if the preview view itself shows less properties than were in the preview.
260
261 2015-06-23  Matt Baker  <mattbaker@apple.com>
262
263         Web Inspector: Layout & Rendering timeline should show paint and layout records in separate rows
264         https://bugs.webkit.org/show_bug.cgi?id=146119
265
266         Reviewed by Timothy Hatcher.
267
268         This patch makes the original Layout & Rendering timeline visually consistent with the Rendering Frames
269         timeline, which uses green to distinguish Paint from Layout. In order to support having record bars with
270         different colors in the same overview graph, the timeline has been split into two rows.
271
272         * UserInterface/Views/LayoutTimelineOverviewGraph.css:
273         (.timeline-overview-graph.layout > .graph-row):
274         (.timeline-overview-graph.layout > .graph-row > .timeline-record-bar):
275         (.timeline-overview-graph.layout > .graph-row > .timeline-record-bar > .segment):
276         New row styles.
277
278         * UserInterface/Views/LayoutTimelineOverviewGraph.js:
279         (WebInspector.LayoutTimelineOverviewGraph.prototype.reset.createRecordRow):
280         (WebInspector.LayoutTimelineOverviewGraph.prototype.reset):
281         (WebInspector.LayoutTimelineOverviewGraph.prototype.updateLayout):
282         (WebInspector.LayoutTimelineOverviewGraph.prototype._updateRowLayout.createBar):
283         (WebInspector.LayoutTimelineOverviewGraph.prototype._updateRowLayout):
284         (WebInspector.LayoutTimelineOverviewGraph.prototype._layoutTimelineRecordAdded):
285         (WebInspector.LayoutTimelineOverviewGraph): Deleted.
286         Added bookkeeping objects for timeline row elements and their associated records.
287
288         * UserInterface/Views/TimelineRecordBar.css:
289         (.timeline-record-bar.timeline-record-type-layout.layout-timeline-record-paint > .segment):
290         New style for layout record event types.
291
292         * UserInterface/Views/TimelineRecordBar.js:
293         (WebInspector.TimelineRecordBar.prototype.set records):
294         Add style class for eventType, if present.
295
296 2015-06-22  Devin Rousso  <drousso@apple.com>
297
298         Web Inspector: gaps between sections of the styles sidebar rules tab confusing, should say "Media: all"
299         https://bugs.webkit.org/show_bug.cgi?id=142918
300
301         Reviewed by Timothy Hatcher.
302
303         * UserInterface/Views/RulesStyleDetailsPanel.css:
304         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label):
305         Now properly adds padding to filtered labels.
306         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label ~ .label): Deleted.
307         * UserInterface/Views/RulesStyleDetailsPanel.js:
308         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): If a section of CSS rules has no media or inheritance, add
309         a label that says "Media: all" above the section.
310
311 2015-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
312
313         Web Inspector: Consider making read-only style rules have a darker background
314         https://bugs.webkit.org/show_bug.cgi?id=145983
315
316         Reviewed by Timothy Hatcher.
317
318         * UserInterface/Views/CSSStyleDeclarationSection.css:
319         (.style-declaration-section:not(.locked)):
320         (.style-declaration-section): Deleted.
321         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
322         (.css-style-text-editor.read-only > .CodeMirror):
323
324 2015-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
325
326         Web Inspector: Unable to select text of user input messages in the console
327         https://bugs.webkit.org/show_bug.cgi?id=145888
328
329         Reviewed by Timothy Hatcher.
330
331         * UserInterface/Views/ConsoleMessageView.css:
332         (.console-user-command > .console-message-text):
333
334 2015-06-20  Nikita Vasilyev  <nvasilyev@apple.com>
335
336         Web Inspector: Unable to select parent element in the DOM tree path bar
337         https://bugs.webkit.org/show_bug.cgi?id=145810
338
339         Reviewed by Timothy Hatcher.
340
341         * UserInterface/Views/DOMTreeContentView.js:
342         (WebInspector.DOMTreeContentView.prototype.get selectionPathComponents):
343         * UserInterface/Views/HierarchicalPathComponent.js:
344         (WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
345         (WebInspector.HierarchicalPathComponent.prototype._selectElementMouseUp):
346         (WebInspector.HierarchicalPathComponent.prototype._selectElementSelectionChanged):
347         (WebInspector.HierarchicalPathComponent):
348         (WebInspector.HierarchicalPathComponent.prototype._selectElementMouseDown): Deleted.
349
350 2015-06-19  Joseph Pecoraro  <pecoraro@apple.com>
351
352         Web Inspector: Duplication of style attribute in rules panel for shadow content
353         https://bugs.webkit.org/show_bug.cgi?id=146176
354
355         Reviewed by Timothy Hatcher.
356
357         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
358         The styleText can be non-empty for a readonly editor if the editor is for
359         the style attribute of a shadow dom node. Instead of assuming it is empty
360         we can just clear the editor ourselves and regenerate from properties.
361
362 2015-06-19  Devin Rousso  <drousso@apple.com>
363
364         Web Inspector: Highlight currently edited CSS selector
365         https://bugs.webkit.org/show_bug.cgi?id=145658
366
367         Reviewed by Joseph Pecoraro.
368
369         * UserInterface/Views/CSSStyleDeclarationSection.js:
370         (WebInspector.CSSStyleDeclarationSection): Added event listeners on the selector text for mouseover and mouseout.
371         (WebInspector.CSSStyleDeclarationSection.prototype._highlightNodesWithSelector): Selector text mouseover action that highlights all nodes that match the selector string in the corresponding frame.
372         (WebInspector.CSSStyleDeclarationSection.prototype._hideHighlightOnNodesWithSelector): Selector text mouseout action that clears all highlights on matching nodes.
373         * UserInterface/Views/DOMNode.js:
374         (WebInspector.DOMNode): If the payload contains a frameId, then save it.
375         (WebInspector.DOMNode.frameIdentifier):
376
377 2015-06-19  Joseph Pecoraro  <pecoraro@apple.com>
378
379         Web Inspector: Overlapping dashboard views causing lots of layers in source view
380         https://bugs.webkit.org/show_bug.cgi?id=146153
381
382         Reviewed by Darin Adler.
383
384         * UserInterface/Views/DashboardContainerView.css:
385         (.toolbar .dashboard:not(.visible)):
386         Hide non-visible dashboard views. The !important is used
387         to override more specific toolbar .dashboard.foo styles.
388
389 2015-06-19  Devin Rousso  <drousso@apple.com>
390
391         Web Inspector: Make rule icon toggle all properties for that selector on and off
392         https://bugs.webkit.org/show_bug.cgi?id=146031
393
394         Reviewed by Timothy Hatcher.
395
396         * UserInterface/Views/CSSStyleDeclarationSection.css:
397         (.style-declaration-section > .header > .icon.toggle-able:hover):
398         (.style-declaration-section.rule-disabled > .header > .icon):
399         * UserInterface/Views/CSSStyleDeclarationSection.js:
400         (WebInspector.CSSStyleDeclarationSection): Added event listener to selector icon to toggle commenting of all properties for that rule.
401         (WebInspector.CSSStyleDeclarationSection.prototype._toggleRuleOnOff): Adds or removes comments to all properties for that rule.
402         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
403         (WebInspector.CSSStyleDeclarationTextEditor.prototype.uncommentAllProperties.uncommentProperties):
404         (WebInspector.CSSStyleDeclarationTextEditor.prototype.uncommentAllProperties): Uncomments all properties.
405         (WebInspector.CSSStyleDeclarationTextEditor.prototype.commentAllProperties): Comments out all properties.
406         (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertyCheckboxChanged): Moved comment logic to its own function.
407         (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertyCommentCheckboxChanged): Moved uncomment logic to its own function.
408
409 2015-06-19  Jon Lee  <jonlee@apple.com>
410
411         Update font and font-family keyword completions
412         https://bugs.webkit.org/show_bug.cgi?id=144558
413         <rdar://problem/20795292>
414
415         Reviewed by Timothy Hatcher.
416
417         * UserInterface/Models/CSSKeywordCompletions.js: Replace -webkit-system-font and
418         -apple-system-font with -apple-system, which is the recommended token for getting the
419         system font. Also add -title{1,2,3} for font, as they were missing, but already exist
420         in font-family.
421
422 2015-06-19  Joseph Pecoraro  <pecoraro@apple.com>
423
424         Web Inspector: Avoid getOwnPropertyNames/Symbols on very large lists
425         https://bugs.webkit.org/show_bug.cgi?id=146141
426
427         Reviewed by Timothy Hatcher.
428
429         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
430         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
431         When building completions for a large array, instead of building a list of all the indices
432         just send a single number back to the frontend and let it generate a list for completion.
433         We should do even better and avoid building a lookup table here for completion of an index.
434
435 2015-06-18  Matt Baker  <mattbaker@apple.com>
436
437         Web Inspector: Rendering Frames timeline selection should snap to frame boundaries
438         https://bugs.webkit.org/show_bug.cgi?id=146120
439
440         Reviewed by Timothy Hatcher.
441
442         * UserInterface/Views/RenderingFrameTimelineOverview.js:
443         Enable snapping to frame boundaries.
444
445         * UserInterface/Views/TimelineRecordingContentView.js:
446         (WebInspector.TimelineRecordingContentView.prototype._updateFrameSelection):
447         Updated filtering to account for ruler snapping.
448
449         * UserInterface/Views/TimelineRuler.js:
450         (WebInspector.TimelineRuler.prototype.get snapInterval):
451         (WebInspector.TimelineRuler.prototype.set snapInterval):
452         (WebInspector.TimelineRuler.prototype.set selectionStartTime):
453         (WebInspector.TimelineRuler.prototype.set selectionEndTime):
454         (WebInspector.TimelineRuler.prototype._snapValue):
455         (WebInspector.TimelineRuler.prototype._handleMouseMove):
456         Added support for snapping to a specified interval.
457
458         * UserInterface/Views/TimelineSidebarPanel.js:
459         Removed unnecessary code.
460
461 2015-06-18  Devin Rousso  <drousso@apple.com>
462
463         Web Inspector: Add a filter for CSS properties in the Styles sidebar
464         https://bugs.webkit.org/show_bug.cgi?id=145536
465
466         Reviewed by Timothy Hatcher.
467
468         * UserInterface/Base/Utilities.js: Added function to Strings that returns an array of all matching indexes of a given string.
469         (.value):
470         * UserInterface/Views/CSSStyleDeclarationSection.js:
471         (WebInspector.CSSStyleDeclarationSection):
472         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
473         (WebInspector.CSSStyleDeclarationSection.prototype.findMatchingPropertiesAndSelectors): Loops through the property list and selectors of each section to find matches to the filtered text.
474         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
475         (WebInspector.CSSStyleDeclarationTextEditor.prototype.findMatchingProperties): Searches through the properties list to find and highlight all matching properties.
476         (WebInspector.CSSStyleDeclarationTextEditor.prototype.removeNonMatchingProperties): Removes all properties that do not match and highlights the specific matched text in matching properties.
477         (WebInspector.CSSStyleDeclarationTextEditor.prototype.resetFilteredProperties): Restores all properties to full visibility and removes any highlighting.
478         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Classes are added to selections of the text editor of that partiular selection contains text which matches the filter (see CSSStyleDetailsSidebarPanel.css for different classes).
479         (WebInspector.CSSStyleDeclarationTextEditor.prototype._iterateOverProperties): If a filter is active, find properties matching the filter instead of all properties.
480         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
481         (.sidebar > .panel.details.css-style > .content.has-filter-bar + .filter-bar):
482         (.sidebar > .panel.details.css-style > .content:not(.has-filter-bar) + .filter-bar):
483         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
484         (WebInspector.CSSStyleDetailsSidebarPanel): Added a filter bar to the CSS sidebar.
485         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels): Switching panels preserves and applies filter bar text.
486         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._filterDidChange): Function called when the filter bar text changes that calls the current panel's filterDidChange function if it exists.
487         * UserInterface/Views/FilterBar.js: Added function and variable to check if the text in the filter bar had changed.
488         * UserInterface/Views/MetricsStyleDetailsPanel.js:
489         (WebInspector.MetricsStyleDetailsPanel.prototype.refresh): Now calls superclass refresh.
490         (WebInspector.MetricsStyleDetailsPanel): Added delegate variable to constructor.
491         * UserInterface/Views/RulesStyleDetailsPanel.css:
492         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label):
493         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label ~ .label):
494         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label):
495         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule):
496         (.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
497         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .style-declaration-section):
498         (.sidebar > .panel.details.css-style > .content > .rules:not(.filter-non-matching) > .no-filter-results):
499         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results):
500         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results > .no-filter-results-message):
501         * UserInterface/Views/RulesStyleDetailsPanel.js:
502         (WebInspector.RulesStyleDetailsPanel): Added delegate variable to constructor.
503         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Now calls superclass refresh.
504         (WebInspector.RulesStyleDetailsPanel.prototype.filterDidChange): Function to search through the computed styles list and highlight all matched properties and selectors of the filter bar text, turning all non matching properties slightly opaque (unless a selector for that property is a match).
505         (WebInspector.StyleDetailsPanel): Added delegate variable to constructor.
506         (WebInspector.StyleDetailsPanel.prototype.refresh): Added event dispatch for panel refresh.
507
508 2015-06-18  Devin Rousso  <drousso@apple.com>
509
510         Web Inspector: Ability to Copy entire CSS Rule from Styles Sidebar
511         https://bugs.webkit.org/show_bug.cgi?id=138812
512
513         Reviewed by Timothy Hatcher.
514
515         * Localizations/en.lproj/localizedStrings.js:
516         * UserInterface/Views/CSSStyleDeclarationSection.js:
517         (WebInspector.CSSStyleDeclarationSection): Right clicking on the header of a rule will replcae the default context menu to allow copying of the entire rule to the clipboard.
518         (WebInspector.CSSStyleDeclarationSection.prototype._handleContextMenuEvent): Creates a new context menu to copy the entire CSS rule.
519         (WebInspector.CSSStyleDeclarationSection.prototype._generateCSSRuleString): Generates a string representing the formatted CSS rule.
520
521 2015-06-18  Joseph Pecoraro  <pecoraro@apple.com>
522
523         Web Inspector: Improve a few more node preview types
524         https://bugs.webkit.org/show_bug.cgi?id=146048
525
526         Reviewed by Timothy Hatcher.
527
528         * UserInterface/Views/FormattedValue.js:
529         (WebInspector.FormattedValue.createElementForNodePreview):
530
531 2015-06-18  Devin Rousso  <drousso@apple.com>
532
533         Web Inspector: New Rule button doesn't reveal the newly added rule if not visible upon creation
534         https://bugs.webkit.org/show_bug.cgi?id=117600
535
536         Reviewed by Timothy Hatcher.
537
538         * UserInterface/Views/RulesStyleDetailsPanel.js: Made previousFocusedSection into a member variable of the RulesStyleDetailsPanel.  This way, when the nodeStyles is refreshed (when a new rule is added), the previousFocusedSection will be scrolled into view.
539         (WebInspector.RulesStyleDetailsPanel):
540         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
541         (WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
542         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Deleted.
543
544 2015-06-18  Commit Queue  <commit-queue@webkit.org>
545
546         Unreviewed, rolling out r185671.
547         https://bugs.webkit.org/show_bug.cgi?id=146114
548
549         Caused frequent flaky failures on profiler tests (Requested by
550         ap on #webkit).
551
552         Reverted changeset:
553
554         "Web Inspector: Improve a few more node preview types"
555         https://bugs.webkit.org/show_bug.cgi?id=146048
556         http://trac.webkit.org/changeset/185671
557
558 2015-06-17  Joseph Pecoraro  <pecoraro@apple.com>
559
560         Web Inspector: Improve a few more node preview types
561         https://bugs.webkit.org/show_bug.cgi?id=146048
562
563         Reviewed by Timothy Hatcher.
564
565         * UserInterface/Views/FormattedValue.js:
566         (WebInspector.FormattedValue.createElementForNodePreview):
567
568 2015-06-17  Diego Pino Garcia  <dpino@igalia.com>
569
570         Web Inspector: Show/Hide sidebar buttons have inconsistent highlighted state
571         https://bugs.webkit.org/show_bug.cgi?id=145073
572
573         Reviewed by Joseph Pecoraro.
574
575         * UserInterface/Views/ContentBrowserTabContentView.js:
576         (WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarPanelSelected):
577
578 2015-06-16  Joseph Pecoraro  <pecoraro@apple.com>
579
580         Web Inspector: Inspector Scripts evaluated in the page should not be searchable
581         https://bugs.webkit.org/show_bug.cgi?id=146040
582
583         Reviewed by Darin Adler.
584
585         Any script with a __WebInspector source URL will be hidden by the tools.
586         There were a number of ways the inspector could evaluate script on the page
587         without getting the sourceURL and therefore not getting hidden. Audit
588         all cases of Runtime.evaluate, Runtime.callFunctionOn, and
589         Debugger.evaluateOnCallFrame, to ensure we have an appropriate source URL.
590
591         * UserInterface/Base/Utilities.js:
592         (appendWebInspectorSourceURL):
593         Helper to append a __WebInspectorInternal__ sourceURL to a string that may
594         be evaluated directly on the inspected context.
595
596         * UserInterface/Controllers/DOMTreeManager.js:
597         (WebInspector.DOMTreeManager.domNodeResolved):
598         * UserInterface/Controllers/JavaScriptLogViewController.js:
599         (WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted): Deleted.
600         * UserInterface/Controllers/RuntimeManager.js:
601         * UserInterface/Models/DOMTree.js:
602         (WebInspector.DOMTree.prototype._requestRootDOMNode):
603         * UserInterface/Protocol/RemoteObject.js:
604         (WebInspector.RemoteObject.):
605         * UserInterface/Views/SourceCodeTextEditor.js:
606         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
607         Ensure all cases that evaluate directly on the inspected page / context
608         have the intenral source URL.
609
610 2015-06-16  Matt Baker  <mattbaker@apple.com>
611
612         Web Inspector: REGRESSION (r171645): up/down key navigation of timeline sidebar tree elements is broken when scope bar filters are applied
613         https://bugs.webkit.org/show_bug.cgi?id=142315
614
615         Reviewed by Timothy Hatcher.
616
617         TreeOutline's element traversal algorithms have been rewritten to correctly skip over unrevealed tree elements.
618         Previously traversal would halt after encountering a hidden element. We now use an iterative approach, with
619         each iteration producing the next (or previous) element, with respect to the last candidate element. Iteration
620         begins with the current node, and halts once a valid element is found or candidate elements are exhausted.
621
622         * UserInterface/Views/TreeOutline.js:
623         (WebInspector.TreeElement.prototype.traverseNextTreeElement.shouldSkip):
624         (WebInspector.TreeElement.prototype.traverseNextTreeElement):
625         (WebInspector.TreeElement.prototype.traversePreviousTreeElement.shouldSkip):
626         (WebInspector.TreeElement.prototype.traversePreviousTreeElement):
627
628 2015-06-15  Joseph Pecoraro  <pecoraro@apple.com>
629
630         Web Inspector: Stylize Node Previews
631         https://bugs.webkit.org/show_bug.cgi?id=145990
632
633         Reviewed by Timothy Hatcher.
634
635         * UserInterface/Views/FormattedValue.js:
636         (WebInspector.FormattedValue.createElementForNodePreview):
637         Style a node preview like a DOMNode. It is a simple small snippet.
638
639         * UserInterface/Views/ObjectPreviewView.js:
640         (WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
641         Use node previews in ObjectPreviewViews.
642
643 2015-06-15  Joseph Pecoraro  <pecoraro@apple.com>
644
645         Web Inspector: Improve some cases of "Object?" Type Annotations
646         https://bugs.webkit.org/show_bug.cgi?id=145954
647
648         Reviewed by Timothy Hatcher.
649
650         * UserInterface/Views/TypeTokenView.js:
651         (WebInspector.TypeTokenView.prototype._displayTypeName):
652         The TypeSet inclusions cover all types, so we can use the leastCommonAncestor
653         name as long as the type set is just object or object and null/undefined.
654         If the typeset includes other primitives then it will gracefully go down
655         below to become something like Object or (many). 
656
657 2015-06-14  Andres Gomez  <agomez@igalia.com>
658
659         [GTK] Web Inspector: Update icon so Rendering Frames timeline distinguish between layout and painting
660         https://bugs.webkit.org/show_bug.cgi?id=145956
661
662         Reviewed by Carlos Garcia Campos.
663
664         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
665         Changed to use green color.
666
667 2015-06-13  Joseph Pecoraro  <pecoraro@apple.com>
668
669         Web Inspector: console.table() with a list of objects no longer works
670         https://bugs.webkit.org/show_bug.cgi?id=145952
671
672         Reviewed by Timothy Hatcher.
673
674         * UserInterface/Views/ConsoleMessageView.js:
675         (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
676         (WebInspector.ConsoleMessageView.prototype._formatParameterAsTable):
677         Don't allow expanding a cosole.table message, and don't output the total
678         object even if the table preview was lossless, as the experience is poor.
679
680 2015-06-11  Joseph Pecoraro  <pecoraro@apple.com>
681
682         Web Inspector: CSS Regions not displaying DOM Trees in inspector
683         https://bugs.webkit.org/show_bug.cgi?id=145903
684
685         Reviewed by Timothy Hatcher.
686
687         * UserInterface/Controllers/DOMTreeManager.js:
688         (WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
689         Fix function inside the assertion to actually return a value.
690
691         * UserInterface/Views/DOMTreeOutline.js:
692         (WebInspector.DOMTreeOutline.prototype.update):
693         For DOMTreeOutlines without a root node, don't clear the tree on updates,
694         since that will clear the nodes that have already been added explicitly.
695
696         * UserInterface/Views/ResourceSidebarPanel.js:
697         (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
698         * UserInterface/Views/ResourcesTabContentView.js:
699         (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
700         ResourceTab and sidebar can deal with ContentFlow related views.
701
702 2015-06-11  Joseph Pecoraro  <pecoraro@apple.com>
703
704         Web Inspector: IndexedDB data not showing for MDN example page
705         https://bugs.webkit.org/show_bug.cgi?id=145851
706
707         Reviewed by Anders Carlsson.
708
709         * UserInterface/Views/StorageSidebarPanel.js:
710         (WebInspector.StorageSidebarPanel.prototype._indexedDatabaseWasAdded):
711         Fix typo in Storage tab refactoring that was causing an
712         uncaught exception and not showing Indexed DBs.
713
714 2015-06-11  Devin Rousso  <drousso@apple.com>
715
716         Web Inspector: font-family names interpreted as color
717         https://bugs.webkit.org/show_bug.cgi?id=123468
718
719         Reviewed by Timothy Hatcher.
720
721         * UserInterface/Views/CodeMirrorAdditions.js: Added logic to prevent color picker buttons from appearing before colors that come after a quote character (both " and ').
722
723 2015-06-11  Matt Baker  <mattbaker@apple.com>
724
725         Web Inspector: Rendering Frames timeline should distinguish between layout and painting
726         https://bugs.webkit.org/show_bug.cgi?id=145856
727
728         Reviewed by Timothy Hatcher.
729
730         This patch formalizes the runloop task concept in the frontend, adds new Paint task type to the Rendering
731         Frames timeline, and reorders UI elements such as chart sections and frame "segments" to match the order in
732         which tasks are executed within the runloop.
733
734         We will need to make UI changes to the standard Timelines view in a follow up patch, since tree element icons
735         for Paint records now use a different color that those of other Layout records.
736
737         * UserInterface/Images/TimelineRecordPaint.svg:
738         Changed to use green color.
739
740         * UserInterface/Models/RenderingFrameTimelineRecord.js:
741         (WebInspector.RenderingFrameTimelineRecord):
742         (WebInspector.RenderingFrameTimelineRecord.displayNameForTaskType):
743         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
744         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.set return):
745         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask):
746         (WebInspector.RenderingFrameTimelineRecord.prototype.get durationRemainder): Deleted.
747         (WebInspector.RenderingFrameTimelineRecord.prototype.durationForRecords.get var): Deleted.
748         Added TaskType enum to decouple runloop task types from timeline record types, and removed duration remainder
749         support now that "Other" has an associated task type.
750
751         * UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
752         (WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
753         (WebInspector.RenderingFrameTimelineDataGridNode.prototype.createCellContent):
754         * UserInterface/Views/RenderingFrameTimelineView.js:
755         (WebInspector.RenderingFrameTimelineView):
756         Added new grid column for Paint task, reordered columns to be consistent with the rest of the UI.
757
758         * UserInterface/Views/TimelineRecordFrame.css:
759         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-script):
760         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-layout):
761         (.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-paint):
762         (.timeline-record-frame > .frame > .duration): Deleted.
763         (.timeline-record-frame > .frame > .duration.timeline-record-type-network): Deleted.
764         (.timeline-record-frame > .frame > .duration.timeline-record-type-layout): Deleted.
765         (.timeline-record-frame > .frame > .duration.timeline-record-type-script): Deleted.
766         Updated styles for Render Frame tasks.
767
768         * UserInterface/Views/TimelineRecordFrame.js:
769         (WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
770         Updated to use Render Frame task types. Frame segment insertion order is now consistent with the rest of the UI.
771
772         * UserInterface/Views/TimelineSidebarPanel.js:
773         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.chartData.Object.keys.map):
774         (WebInspector.TimelineSidebarPanel.set this):
775         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.get this):
776         (WebInspector.TimelineSidebarPanel): Deleted.
777         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart.durationForRecordType): Deleted.
778         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart): Deleted.
779         Updated to use Render Frame task types.
780
781 2015-06-11  Matt Baker  <mattbaker@apple.com>
782
783         Web Inspector: Wrong overview graph shown after switching from Frames to Timelines
784         https://bugs.webkit.org/show_bug.cgi?id=145778
785
786         Reviewed by Timothy Hatcher.
787
788         TimelineSidebarPanel stores a reference to the selected timeline before switching to the Rendering Frames view,
789         which is used to restore the tree selection, overview graph, and content views when switching back to the
790         standard Timelines view. However if another recording is created before switching, the previously selected
791         timeline tracked by the sidebar cannot be restored, since it doesn't belong to the active recording.
792
793         This is addressed by storing the previously selected timeline type, rather than the timeline object itself.
794         The type is also updated whenever the selected timeline in the tree outline changes, ensuring that the correct
795         timeline will always be restored.
796
797         * UserInterface/Views/TimelineSidebarPanel.js:
798         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
799         (WebInspector.TimelineSidebarPanel.get else): Deleted.
800         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if): Deleted.
801         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject): Deleted.
802
803 2015-06-08  Matt Baker  <mattbaker@apple.com>
804
805         Web Inspector: Clearing active Timeline recording should stop capturing
806         https://bugs.webkit.org/show_bug.cgi?id=145767
807
808         Reviewed by Joseph Pecoraro.
809
810         * UserInterface/Views/TimelineRecordingContentView.js:
811         (WebInspector.TimelineRecordingContentView.prototype._clearTimeline):
812         Stop capturing if necessary.
813
814 2015-06-07  Tobias Reiss  <tobi+webkit@basecode.de>
815
816         Web Inspector: Add PrettyPrinter CSSRule tests
817         https://bugs.webkit.org/show_bug.cgi?id=145740
818
819         Reviewed by Brian Burg.
820
821         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon-expected.css: Added.
822         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon.css: Added.
823         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma-expected.css: Added.
824         * Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma.css: Added.
825         * Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon-expected.css: Added.
826         * Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon.css: Added.
827         * Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed-expected.css: Added.
828         * Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed.css: Added.
829         * Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value-expected.css: Added.
830         * Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value.css: Added.
831         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon-expected.css: Added.
832         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon.css: Added.
833         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment-expected.css: Added.
834         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment.css: Added.
835         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property-expected.css: Added.
836         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property.css: Added.
837         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property-expected.css: Added.
838         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property.css: Added.
839         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property-expected.css: Added.
840         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property.css: Added.
841         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon-expected.css: Added.
842         * Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon.css: Added.
843         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment-expected.css: Added.
844         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment.css: Added.
845         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property-expected.css: Added.
846         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property.css: Added.
847         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property-expected.css: Added.
848         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property.css: Added.
849         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property-expected.css: Added.
850         * Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property.css: Added.
851         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment-expected.css: Added.
852         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment.css: Added.
853         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property-expected.css: Added.
854         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property.css: Added.
855         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property-expected.css: Added.
856         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property.css: Added.
857         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property-expected.css: Added.
858         * Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property.css: Added.
859         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment-expected.css: Added.
860         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment.css: Added.
861         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property-expected.css: Added.
862         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property.css: Added.
863         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property-expected.css: Added.
864         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property.css: Added.
865         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property-expected.css: Added.
866         * Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property.css: Added.
867         * Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property-expected.css: Added.
868         * Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property.css: Added.
869
870 2015-06-05  Devin Rousso  <drousso@apple.com>
871
872         Web Inspector: Fixing code style and adding more limitations for bug 141262
873         https://bugs.webkit.org/show_bug.cgi?id=145668
874
875         Reviewed by Timothy Hatcher.
876
877         * UserInterface/Models/CSSCompletions.js:
878         (WebInspector.CSSCompletions.prototype.isValidPropertyName): Loops through the full property list and returns true only if a property exactly matches the given property name.
879         (WebInspector.CSSCompletions): Added isValidPropertyName function.
880         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
881         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property and to prevent invalid style from being applied incorrectly.
882
883 2015-06-05  Devin Rousso  <drousso@apple.com>
884
885         Web Inspector: Highlighting a CSS section does not deselect previously highlighted CSS sections
886         https://bugs.webkit.org/show_bug.cgi?id=145399
887
888         Reviewed by Timothy Hatcher.
889
890         * UserInterface/Views/CSSStyleDeclarationSection.js:
891         (WebInspector.CSSStyleDeclarationSection): Added delegate variable to constructor.
892         (WebInspector.CSSStyleDeclarationSection.prototype.clearSelection):
893         (WebInspector.CSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorFocused):
894         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
895         (WebInspector.CSSStyleDeclarationTextEditor): Added event listener to codeMirror on "focus".
896         (WebInspector.CSSStyleDeclarationTextEditor.prototype.clearSelection): Sets the cursor of the codeMirror to character 0 on line 0.
897         (WebInspector.CSSStyleDeclarationTextEditor.prototype._editorFocused): Function that calls the delegate function "editorFocused" when the codeMirror is focused
898         * UserInterface/Views/RulesStyleDetailsPanel.js:
899         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
900         (WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorFocused): Loops through all sections except for the ignoredSection (parameter) and clears the selected text in each of them.
901
902 2015-06-05  Joseph Pecoraro  <pecoraro@apple.com>
903
904         REGRESSION (r185213): TypeError: undefined is not an object (evaluating 'WebInspector.clearLogOnReload.value')
905         https://bugs.webkit.org/show_bug.cgi?id=145695
906
907         Reviewed by Mark Lam.
908
909         Move and rename the clear log on reload setting property from
910         WebInspector (Main.js) to LogManager (shared with tests).
911
912         * UserInterface/Base/Main.js:
913         (WebInspector.loaded): Deleted.
914         * UserInterface/Controllers/LogManager.js:
915         (WebInspector.LogManager):
916         (WebInspector.LogManager.prototype._delayedMessagesCleared):
917         * UserInterface/Views/LogContentView.js:
918         (WebInspector.LogContentView.prototype._sessionStarted):
919         (WebInspector.LogContentView.prototype._handleContextMenuEvent):
920         (WebInspector.LogContentView.prototype._toggleClearLogOnReloadSetting):
921
922 2015-06-05  Nikita Vasilyev  <nvasilyev@apple.com>
923
924         Web Inspector: [REGRESSION] Dashboard's resource count does not reset when main resource navigates
925         https://bugs.webkit.org/show_bug.cgi?id=144553
926
927         Add missing _mainResourceDidChange, which was removed after switching to the tabs UI.
928
929         Reviewed by Timothy Hatcher.
930
931         * UserInterface/Models/DefaultDashboard.js:
932         (WebInspector.DefaultDashboard):
933         _waitingForFirstMainResourceToStartTrackingSize is not used anywhere, remove it.
934
935         (WebInspector.DefaultDashboard.prototype._mainResourceDidChange): Added.
936
937         (WebInspector.DefaultDashboard.prototype._resourceSizeDidChange): Removed.
938         Unused.
939
940 2015-06-05  Matt Baker  <mattbaker@apple.com>
941
942         Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
943         https://bugs.webkit.org/show_bug.cgi?id=145671
944
945         Reviewed by Timothy Hatcher.
946
947         * Localizations/en.lproj/localizedStrings.js:
948         "Idle" string no longer used.
949
950         * UserInterface/Views/TimelineRecordFrame.js:
951         Reduced maximum frame width by 2px.
952
953         * UserInterface/Views/TimelineSidebarPanel.js:
954         (WebInspector.TimelineSidebarPanel):
955         (WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart):
956         Added inner radius to chart and removed "Idle" value.
957
958 2015-06-04  Joseph Pecoraro  <pecoraro@apple.com>
959
960         Web Inspector: Class constructor appearing as Object Tree property does not include parameters
961         https://bugs.webkit.org/show_bug.cgi?id=145661
962
963         Reviewed by Timothy Hatcher.
964
965         * UserInterface/Protocol/RemoteObject.js:
966         (WebInspector.RemoteObject):
967         (WebInspector.RemoteObject.fromPrimitiveValue):
968         (WebInspector.RemoteObject.fromPayload):
969         (WebInspector.RemoteObject.prototype.get functionDescription):
970         Include the className as only use it for "class" types to override
971         the normal description string. Stash the actual function description
972         in a property we can access later.
973
974         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
975         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
976         Even if this property is a "class" we want to specifically parse it's
977         function description string. So use functionDescription.
978
979 2015-06-04  Nikita Vasilyev  <nvasilyev@apple.com>
980
981         Web Inspector: Close and open tabs on mouseup, not mousedown
982         https://bugs.webkit.org/show_bug.cgi?id=145656
983
984         Match Safari's behaviour.
985
986         Reviewed by Timothy Hatcher.
987
988         * UserInterface/Views/TabBar.js:
989         (WebInspector.TabBar):
990         (WebInspector.TabBar.prototype.set newTabItem):
991         (WebInspector.TabBar.prototype._handleMouseDown):
992         (WebInspector.TabBar.prototype._handleClick): Added.
993         (WebInspector.TabBar.prototype._handleMouseUp):
994         (WebInspector.TabBar.prototype._handleNewTabClick): Added.
995         (WebInspector.TabBar.prototype._handleMouseMoved):
996
997 2015-06-04  Nikita Vasilyev  <nvasilyev@apple.com>
998
999         Web Inspector: Decrease tabs height to match Safari's tabs height
1000         https://bugs.webkit.org/show_bug.cgi?id=145647
1001
1002         Reviewed by Timothy Hatcher.
1003
1004         * UserInterface/Views/TabBar.css:
1005         (.tab-bar):
1006
1007 2015-06-04  Tobias Reiss  <tobi+webkit@basecode.de>
1008         
1009         Web Inspector: Activity Viewer does not update on "Clear Log on reload"
1010         https://bugs.webkit.org/show_bug.cgi?id=145466
1011         
1012         Reviewed by Joseph Pecoraro.
1013
1014         1. Isolate logic within LogManager and remove hacks/logic from all other files
1015         2. Within LogManager: Differentiate "messagesCleared" calls
1016          a) that happen as a result of a "requested clear" by Frontend (e.g. Button)
1017          b) that happen on page reload and install "clear/keep-on-page-reload" logic
1018          c) that happen on frame navigated, console.clear() or clear()
1019         3. Unify "ActiveLogCleared" and "Cleared" events to "Cleared"
1020         
1021         For step 2b and 2c it is important to delay the handling and wait until
1022         "_mainResourceDidChange" has determined whether a page reload happened or
1023         not.
1024         
1025         * UserInterface/Base/Main.js:
1026         (WebInspector.loaded):
1027         Store "clear-log-on-reload" setting globally.
1028         
1029         * UserInterface/Controllers/IssueManager.js:
1030         (WebInspector.IssueManager):
1031         * UserInterface/Models/DefaultDashboard.js:
1032         (WebInspector.DefaultDashboard): Deleted.
1033         * UserInterface/Views/ObjectTreeView.js:
1034         (WebInspector.ObjectTreeView.prototype._trackWeakEntries): Deleted.
1035         (WebInspector.ObjectTreeView.prototype._untrackWeakEntries): Deleted.
1036         (WebInspector.ObjectTreeView): Deleted.
1037         Remove deleted events.
1038         
1039         * UserInterface/Controllers/JavaScriptLogViewController.js:
1040         (WebInspector.JavaScriptLogViewController.prototype._handleClearShortcut):
1041         (WebInspector.JavaScriptLogViewController.prototype.clear): Deleted.
1042         Remove delegate function call and call LogManager directly.
1043         
1044         * UserInterface/Controllers/LogManager.js:
1045         (WebInspector.LogManager):
1046         (WebInspector.LogManager.prototype.messagesCleared):
1047         (WebInspector.LogManager.prototype._delayedMessagesCleared):
1048         (WebInspector.LogManager.prototype.requestClearMessages):
1049         (WebInspector.LogManager.prototype._mainResourceDidChange):
1050         Isolate "clear log" logic, especially clear/keep-log-on-reload logic.
1051         
1052         * UserInterface/Views/LogContentView.js:
1053         (WebInspector.LogContentView):
1054         (WebInspector.LogContentView.prototype._sessionStarted):
1055         (WebInspector.LogContentView.prototype._handleContextMenuEvent):
1056         (WebInspector.LogContentView.prototype._logCleared):
1057         (WebInspector.LogContentView.prototype._toggleClearLogOnReloadSetting):
1058         (WebInspector.LogContentView.prototype._clearLog):
1059         (WebInspector.LogContentView.prototype.didClearMessages): Deleted.
1060         (WebInspector.LogContentView.prototype._sessionsCleared): Deleted.
1061         (WebInspector.LogContentView.prototype._activeLogCleared): Deleted.
1062         (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages): Deleted.
1063         Make it a consumer of LogManager and remove special hacks. Simplify code.
1064
1065 2015-06-03  Devin Rousso  <drousso@apple.com>
1066
1067         Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value
1068         https://bugs.webkit.org/show_bug.cgi?id=141262
1069
1070         Reviewed by Timothy Hatcher.
1071
1072         * UserInterface/Models/CSSCompletions.js:
1073         (WebInspector.CSSCompletions.prototype.nameMatchesValidPropertyExactly): Loops through the full property list and returns true only if a property exactly matches the given property name.
1074         (WebInspector.CSSCompletions): Added nameMatchesValidPropertyExactly function.
1075         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1076         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property.
1077
1078 2015-06-03  Nikita Vasilyev  <nvasilyev@apple.com>
1079
1080         Web Inspector: Search field bottom border doesn't match the rest of the toolbar
1081         https://bugs.webkit.org/show_bug.cgi?id=145611
1082
1083         Reviewed by Timothy Hatcher.
1084
1085         * UserInterface/Views/Toolbar.css:
1086         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
1087
1088 2015-06-03  Joseph Pecoraro  <pecoraro@apple.com>
1089
1090         Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar
1091         https://bugs.webkit.org/show_bug.cgi?id=145589
1092
1093         Reviewed by Timothy Hatcher.
1094
1095         * UserInterface/Views/NavigationBar.js:
1096         (WebInspector.NavigationBar.prototype._mouseDown):
1097         (WebInspector.NavigationBar.prototype._mouseUp):
1098         When mouse dragging for navigation bars, only match against navigation
1099         bar items inside this navigation bar. Also, fix horizontal detection
1100         of navigation bar items by scanning in the middle of the navigation
1101         bar instead of the top, which missed the items.
1102
1103 2015-06-03  Joseph Pecoraro  <pecoraro@apple.com>
1104
1105         Web Inspector: Debugger Popover for Node object should have go-to-arrow to show the node in DOM tree
1106         https://bugs.webkit.org/show_bug.cgi?id=145594
1107
1108         Reviewed by Timothy Hatcher.
1109
1110         * UserInterface/Controllers/DOMTreeManager.js:
1111         (WebInspector.DOMTreeManager.prototype.inspectElement):
1112         Previously we could get an exception later on if we tried to
1113         inspect an element that was not in the DOM. Bail if the node
1114         is not in the DOM or not.
1115
1116         * UserInterface/Views/SourceCodeTextEditor.css:
1117         (.popover .debugger-popover-content > .title > .go-to-arrow):
1118         * UserInterface/Views/SourceCodeTextEditor.js:
1119         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject.data.pushNodeToFrontend):
1120         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
1121         For a node type, add a go-to-arrow in the popover if it is in the DOM or not.
1122
1123 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
1124
1125         Web Inspector: Remove uses of delete in Sidebar related code
1126         https://bugs.webkit.org/show_bug.cgi?id=145592
1127
1128         Reviewed by Timothy Hatcher.
1129
1130         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1131         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
1132         Clear value instead of deleting.
1133
1134         * UserInterface/Views/SearchSidebarPanel.js:
1135         (WebInspector.SearchSidebarPanel.prototype.performSearch):
1136         Just clear the search identifier. Also assert it (a required string) is always non-falsey.
1137
1138         * UserInterface/Views/Sidebar.js:
1139         (WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
1140         This entire callback is unnecessary because whenever we start
1141         a drag we save the value.
1142
1143 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
1144
1145         Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
1146         https://bugs.webkit.org/show_bug.cgi?id=145591
1147
1148         Reviewed by Timothy Hatcher.
1149
1150         * UserInterface/Views/Sidebar.js:
1151         (WebInspector.Sidebar.prototype.removeSidebarPanel):
1152         When removing a sidebar panel, ensure we call hidden if it was the visible panel.
1153
1154         * UserInterface/Views/SidebarPanel.js:
1155         (WebInspector.SidebarPanel):
1156         (WebInspector.SidebarPanel.prototype.shown):
1157         (WebInspector.SidebarPanel.prototype.hidden):
1158         Save and restore content element scroll position when sidebar panels are shown / hidden.
1159
1160         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1161         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):
1162         * UserInterface/Views/ComputedStyleDetailsPanel.js:
1163         (WebInspector.ComputedStyleDetailsPanel.prototype.shown):
1164         * UserInterface/Views/DetailsSidebarPanel.js:
1165         (WebInspector.DetailsSidebarPanel.prototype.shown):
1166         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
1167         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
1168         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.hidden):
1169         Cleanup. Since sidebar panels are using ES6 classes, have super class calls use `super`!
1170
1171 2015-06-02  Nikita Vasilyev  <nvasilyev@apple.com>
1172
1173         Web Inspector: Use non-monospace font for the frame selector
1174         https://bugs.webkit.org/show_bug.cgi?id=145586
1175
1176         Reviewed by Timothy Hatcher.
1177
1178         * UserInterface/Views/HierarchicalPathComponent.css:
1179         (.hierarchical-path-component):
1180
1181 2015-06-02  Nikita Vasilyev  <nvasilyev@apple.com>
1182
1183         Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
1184         https://bugs.webkit.org/show_bug.cgi?id=145540
1185
1186         Also, increase clickable area of the arrow icon.
1187
1188         Reviewed by Timothy Hatcher.
1189
1190         * UserInterface/Views/DashboardContainerView.css:
1191         (.dashboard-container .advance-arrow):
1192         (.dashboard-container .advance-arrow.advance-forward):
1193         (.dashboard-container .advance-arrow.advance-backward):
1194         * UserInterface/Views/DebuggerDashboardView.css:
1195         (.dashboard.debugger > .location):
1196         (.toolbar .dashboard.debugger):
1197         Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.
1198
1199 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
1200
1201         Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
1202         https://bugs.webkit.org/show_bug.cgi?id=145562
1203
1204         Reviewed by Timothy Hatcher.
1205
1206         * UserInterface/Views/TabBrowser.js:
1207         (WebInspector.TabBrowser):
1208         Only these keyboard shortcuts should check if we are in an editable field.
1209         Remove the implicit prevent default so they can fall back to system behavior
1210         if necessary.
1211
1212         (WebInspector.TabBrowser.prototype._showNextTabCheckingForEditableField):
1213         (WebInspector.TabBrowser.prototype._showPreviousTabCheckingForEditableField):
1214         Bail if we are in an editable field. Otherwise perform the action and prevent default.
1215
1216 2015-06-02  Joseph Pecoraro  <pecoraro@apple.com>
1217
1218         Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
1219         https://bugs.webkit.org/show_bug.cgi?id=145546
1220
1221         Reviewed by Timothy Hatcher.
1222
1223         Scope ContentBrowser keyboard events within the ContentBrowser instead
1224         of global, where they might conflict between ContentBrowsers. The scoped
1225         shortcuts now no longer need to be enabled/disabled.
1226
1227         * UserInterface/Views/ContentBrowser.js:
1228         (WebInspector.ContentBrowser):
1229         Scope the keyboard shortcuts.
1230
1231         (WebInspector.ContentBrowser.prototype.shown):
1232         (WebInspector.ContentBrowser.prototype.hidden):
1233         No longer need to control enabling / disabling these non-global shortcuts.
1234
1235 2015-06-01  Jono Wells  <jonowells@apple.com>
1236
1237         Web Inspector: Type token text descenders touch bottom of container
1238         https://bugs.webkit.org/show_bug.cgi?id=145544
1239
1240         Reviewed by Timothy Hatcher.
1241
1242         Move 1px padding from top to bottom of token.
1243
1244         * UserInterface/Views/TypeTokenView.css:
1245         (.type-token):
1246
1247 2015-06-01  Joseph Pecoraro  <pecoraro@apple.com>
1248
1249         Web Inspector: Better handle keyboard events in the quick console prompt
1250         https://bugs.webkit.org/show_bug.cgi?id=145548
1251
1252         Reviewed by Timothy Hatcher.
1253
1254         * UserInterface/Base/Main.js:
1255         (WebInspector.saveDataToFile):
1256         Move generic InspectorFrontendHost code here.
1257
1258         * UserInterface/Views/ContentBrowser.js:
1259         (WebInspector.ContentBrowser.prototype._save):
1260         (WebInspector.ContentBrowser.prototype._saveAs):
1261         (WebInspector.ContentBrowser.prototype._saveDataToFile): Deleted.
1262         Use the generic save code.
1263
1264         * UserInterface/Controllers/JavaScriptLogViewController.js:
1265         (WebInspector.JavaScriptLogViewController):
1266         (WebInspector.JavaScriptLogViewController.prototype._save):
1267         (WebInspector.JavaScriptLogViewController.prototype._saveAs):
1268         Handle save keyboard shortcuts while the prompt is focused.
1269
1270         * UserInterface/Views/LogContentView.js:
1271         (WebInspector.LogContentView.prototype.focusSearchBar):
1272         (WebInspector.LogContentView.prototype.save):
1273         (WebInspector.LogContentView.prototype.saveAs):
1274         Better handle keyboard shortcut cases in the console prompt for cases
1275         like a collapsed or split console view.
1276
1277 2015-06-01  Nikita Vasilyev  <nvasilyev@apple.com>
1278
1279         Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned
1280         https://bugs.webkit.org/show_bug.cgi?id=145534
1281
1282         Reviewed by Timothy Hatcher.
1283
1284         * UserInterface/Views/ButtonNavigationItem.css:
1285         (.navigation-bar .item.button.suppress-emboss):
1286         Never show borders for the pause/resume button.
1287
1288         * UserInterface/Views/DebuggerDashboardView.css:
1289         (.dashboard.debugger .navigation-bar .item.button):
1290
1291 2015-05-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1292
1293         Web Inspector: Drop forEach from WeakMap / WeakSet native member function maps
1294         https://bugs.webkit.org/show_bug.cgi?id=145497
1295
1296         Reviewed by Sam Weinig.
1297
1298         WeakMap / WeakSet don't have forEach method.
1299         This patch drops it from the native prototype function parameters map.
1300
1301         * UserInterface/Models/NativeFunctionParameters.js:
1302
1303 2015-05-29  Timothy Hatcher  <timothy@apple.com>
1304
1305         Web Inspector: Resources tab navigation sidebar should have a type filter header
1306         https://bugs.webkit.org/show_bug.cgi?id=145474
1307
1308         Reviewed by Joseph Pecoraro.
1309
1310         * Localizations/en.lproj/localizedStrings.js: Updated.
1311
1312         * UserInterface/Images/UpDownArrows.svg: Make styleable.
1313
1314         * UserInterface/Main.html: Added new files.
1315
1316         * UserInterface/Views/LogContentView.js:
1317         (WebInspector.LogContentView): Drive-by fix. Mark All as exclusive.
1318
1319         * UserInterface/Views/MultipleScopeBarItem.js: Added.
1320         (WebInspector.MultipleScopeBarItem):
1321         (WebInspector.MultipleScopeBarItem.prototype.get element):
1322         (WebInspector.MultipleScopeBarItem.prototype.get exclusive):
1323         (WebInspector.MultipleScopeBarItem.prototype.get scopeBarItems):
1324         (WebInspector.MultipleScopeBarItem.set scopeBarItems.createOption):
1325         (WebInspector.MultipleScopeBarItem.prototype.set scopeBarItems):
1326         (WebInspector.MultipleScopeBarItem.prototype.get selected):
1327         (WebInspector.MultipleScopeBarItem.prototype.set selected):
1328         (WebInspector.MultipleScopeBarItem.prototype.get selectedScopeBarItem):
1329         (WebInspector.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
1330         (WebInspector.MultipleScopeBarItem.prototype._clicked):
1331         (WebInspector.MultipleScopeBarItem.prototype._selectElementSelectionChanged):
1332         (WebInspector.MultipleScopeBarItem.prototype._itemSelectionDidChange):
1333
1334         * UserInterface/Views/NavigationSidebarPanel.js:
1335         (WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):
1336         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
1337         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.makeVisible):
1338         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
1339         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
1340         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
1341         Improve filtering so non-text filters can choose to auto-expand the tree.
1342
1343         * UserInterface/Views/ResourceSidebarPanel.css: Added.
1344         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
1345         (.sidebar > .panel.navigation.resource > .navigation-bar):
1346
1347         * UserInterface/Views/ResourceSidebarPanel.js:
1348         (WebInspector.ResourceSidebarPanel):
1349         (WebInspector.ResourceSidebarPanel.prototype.hasCustomFilters):
1350         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
1351         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
1352         (WebInspector.ResourceSidebarPanel.prototype._scopeBarSelectionDidChange):
1353         Make a ScopeBar and make it filter the TreeOutline when needed.
1354
1355         * UserInterface/Views/ScopeBar.css:
1356         (.scope-bar > li.multiple):
1357         (.scope-bar > li.multiple > select):
1358         (.scope-bar > li.multiple.selected > select):
1359         (.scope-bar > li.multiple > .arrows):
1360         (.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows svg .filled):
1361         (.scope-bar > li.multiple:matches(.selected, :hover, :active) > .arrows svg .stroked):
1362
1363         * UserInterface/Views/ScopeBar.js:
1364         (WebInspector.ScopeBar): Support shouldGroupNonExclusiveItems which will use MultipleScopeBarItem.
1365         (WebInspector.ScopeBar.prototype._populate):
1366         (WebInspector.ScopeBar.prototype._itemSelectionDidChange):
1367         (WebInspector.ScopeBar.prototype.updateLayout): Deleted. Not needed for our current styles.
1368
1369         * UserInterface/Views/ScopeBarItem.js:
1370         (WebInspector.ScopeBarItem):
1371         (WebInspector.ScopeBarItem.prototype.get id):
1372         (WebInspector.ScopeBarItem.prototype.get label):
1373         (WebInspector.ScopeBarItem.prototype.get exclusive):
1374         (WebInspector.ScopeBarItem.prototype.setSelected):
1375         (WebInspector.ScopeBarItem.prototype._clicked):
1376         (WebInspector.ScopeBarItem.prototype.get element): Deleted.
1377         (WebInspector.ScopeBarItem.prototype._markElementSelected): Deleted.
1378         Cleaned up and modernized a bit.
1379
1380 2015-05-29  Tobias Reiss  <tobi+webkit@basecode.de>
1381
1382         Web Inspector: Activity Viewer does not update on "clear all console messages"
1383         https://bugs.webkit.org/show_bug.cgi?id=144681
1384
1385         Reviewed by Joseph Pecoraro.
1386
1387         Do not apply "ignoreDidClearMessages" hack on "Clear log" Button and Context menu.
1388
1389         * UserInterface/Views/LogContentView.js:
1390         (WebInspector.LogContentView.prototype._sessionStarted):
1391         (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages):
1392         (WebInspector.LogContentView.prototype._clearLog): Deleted.
1393
1394 2015-05-29  Matt Baker  <mattbaker@apple.com>
1395
1396         Web Inspector: Remove unused expandTreeElementsWhenArrowing property from TreeOutline
1397         https://bugs.webkit.org/show_bug.cgi?id=145470
1398
1399         Reviewed by Joseph Pecoraro.
1400
1401         * UserInterface/Views/TreeOutline.js:
1402         (WebInspector.TreeOutline.prototype._treeKeyDown):
1403         Replaced uses of removed property with boolean literal.
1404
1405 2015-05-29  Joseph Pecoraro  <pecoraro@apple.com>
1406
1407         Web Inspector: Tabs should have Context Menus
1408         https://bugs.webkit.org/show_bug.cgi?id=144208
1409
1410         Reviewed by Timothy Hatcher.
1411
1412         Give non-pinned tabs "Close Tab" and "Close Other Tabs" context
1413         menu items to affect other non-pinned tabs.
1414
1415         * Localizations/en.lproj/localizedStrings.js:
1416         * UserInterface/Views/TabBarItem.js:
1417         (WebInspector.TabBarItem):
1418         (WebInspector.TabBarItem.prototype._handleContextMenuEvent.closeTab):
1419         (WebInspector.TabBarItem.prototype._handleContextMenuEvent.closeOtherTabs):
1420         (WebInspector.TabBarItem.prototype._handleContextMenuEvent):
1421
1422 2015-05-29  Matt Baker  <mattbaker@apple.com>
1423
1424         Web Inspector: Restoring the last selected DOM node fails on reload (DOMAgent: No node with given path found)
1425         https://bugs.webkit.org/show_bug.cgi?id=144231
1426
1427         Reviewed by Timothy Hatcher.
1428
1429         Removed _restoreSelectedNodeIsAllowed flag from DOMTreeContentView. The frontend receives two documentUpdated
1430         events from the DOM Agent during page reload, and the flag was preventing DOMTreeContentView from restoring
1431         the previous selection in response to the second event.
1432
1433         * UserInterface/Views/DOMTreeContentView.js:
1434         (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
1435         (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
1436
1437 2015-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
1438
1439         Web Inspector: Update toolbar styles
1440         https://bugs.webkit.org/show_bug.cgi?id=145419
1441
1442         Also, use hairline borders (1 phisical pixel) on retina (DPI >= 2).
1443
1444         Reviewed by Timothy Hatcher.
1445
1446         * UserInterface/Views/ButtonToolbarItem.css:
1447         (.toolbar .item.button): Deleted.
1448         (.toolbar.icon-and-label-vertical .item.button): Deleted.
1449         (.toolbar.icon-and-label-horizontal .item.button): Deleted.
1450         (.toolbar .item.button > .glyph): Deleted.
1451         (.toolbar.small-size .item.button > .glyph): Deleted.
1452         * UserInterface/Views/DashboardContainerView.css:
1453         (.toolbar .dashboard-container): Deleted.
1454         (.toolbar.collapsed .dashboard-container): Deleted.
1455         (.toolbar.small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
1456         (.toolbar .dashboard.slide-out-down): Deleted.
1457         (.toolbar .dashboard.slide-in-up): Deleted.
1458         * UserInterface/Views/Toolbar.css:
1459         (.toolbar .search-bar > input[type="search"]):
1460         (.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
1461         (body:not(.unknown-mac) .toolbar .dashboard-container):
1462         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):
1463         (body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus):
1464         (body:not(.unknown-mac) .toolbar .item.button:active):
1465         (body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container):
1466         (body.unknown-mac .toolbar .dashboard-container):
1467         (body.unknown-mac .toolbar .search-bar > input[type="search"]):
1468         (body.unknown-mac .toolbar .search-bar > input[type="search"]:focus):
1469         (@media (-webkit-min-device-pixel-ratio: 2)):
1470         (body.unknown-mac .toolbar .item.button:active):
1471         (body.unknown-mac.window-inactive .toolbar .dashboard-container):
1472
1473 2015-05-28  Devin Rousso  <drousso@apple.com>
1474
1475         Web Inspector: Jump from a computed style to the rule it came from
1476         https://bugs.webkit.org/show_bug.cgi?id=120640
1477
1478         Reviewed by Timothy Hatcher.
1479
1480         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1481         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
1482         If the delegate of CSSStyleDeclarationTextEditor has cssStyleDeclarationTextEditorShouldAddPropertyGoToArrows set to true, add a goToArrow to all CSS property entries.
1483         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty.propertiesMatch):
1484         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty.hasMatchingLonghandProperty):
1485         (WebInspector.CSSStyleDeclarationTextEditor.prototype.highlightProperty):
1486         Determines if a given CSS property is in the CSS style section and if so, select that CSS property, focus on the section containing that CSS property, and return true.
1487         * UserInterface/Views/CSSStyleDeclarationSection.js:
1488         (WebInspector.CSSStyleDeclarationSection.prototype.highlightProperty):
1489         Searches through the properties of the section for a given property and scrolls to it if found.
1490         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1491         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
1492         Switches to the rulesStyleDetailsPanel and scrolls to and hightlights a given property in that panel.
1493         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
1494         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels):
1495         Moved this function out of _navigationItemSelected for better reusablity.
1496         * UserInterface/Views/ComputedStyleDetailsPanel.js:
1497         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
1498         Function that calls the delegate (which should be CSSStyleDetailsSidebarPanel) function computedStyleDetailsPanelShowProperty.
1499         * UserInterface/Views/RulesStyleDetailsPanel.js:
1500         (WebInspector.RulesStyleDetailsPanel):
1501         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
1502         (WebInspector.RulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
1503         Searches through all the sections of the RulesStyleDetailsPanel for a given CSS property.
1504         (WebInspector.RulesStyleDetailsPanel.prototype.shown):
1505         (WebInspector.RulesStyleDetailsPanel.prototype.hidden):
1506         (WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
1507         Added a flag to this function that will highlight and scroll to a given property (_propertyToSelectAndHighlight) if set on load.
1508         * UserInterface/Views/StyleDetailsPanel.js:
1509         (WebInspector.StyleDetailsPanel.prototype.markAsNeedsRefresh):
1510         (WebInspector.StyleDetailsPanel.prototype.nodeStylesRefreshed):
1511         Made into protected function to allow it to be overridden.
1512         (WebInspector.StyleDetailsPanel.prototype._nodeStylesRefreshed): Deleted.
1513
1514 2015-05-28  Joseph Pecoraro  <pecoraro@apple.com>
1515
1516         Web Inspector: Should have a keyboard shortcut to switch between inspector tabs
1517         https://bugs.webkit.org/show_bug.cgi?id=144207
1518
1519         Reviewed by Timothy Hatcher.
1520
1521         These keyboard shortcuts work well in an undocked inspector window.
1522         Be careful that some keyboard shortcuts, when used inside a text
1523         editor / text field are just text actions. However, some keyboard
1524         shortcuts will work no matter where you trigger them.
1525
1526         * UserInterface/Models/KeyboardShortcut.js:
1527         * UserInterface/Views/TabBar.js:
1528         (WebInspector.TabBar.prototype.selectPreviousTab):
1529         (WebInspector.TabBar.prototype.selectNextTab):
1530         * UserInterface/Views/TabBrowser.js:
1531         (WebInspector.TabBrowser):
1532         (WebInspector.TabBrowser.prototype._showPreviousTab):
1533         (WebInspector.TabBrowser.prototype._showNextTab):
1534
1535 2015-05-28  Joseph Pecoraro  <pecoraro@apple.com>
1536
1537         Web Inspector: NewTabContentView should update button disabled state as other tabs are added/removed
1538         https://bugs.webkit.org/show_bug.cgi?id=145448
1539
1540         Reviewed by Timothy Hatcher.
1541
1542         * UserInterface/Views/NewTabContentView.js:
1543         (WebInspector.NewTabContentView):
1544         Always add a click listener and add the type as a private property on the element.
1545
1546         (WebInspector.NewTabContentView.prototype.shown):
1547         (WebInspector.NewTabContentView.prototype.hidden):
1548         Add / remove event listeners for tab changes. Also update the view when shown.
1549         
1550         (WebInspector.NewTabContentView.prototype._createNewTab):
1551         A disabled button an now be clicked. Do nothing if a new tab of this type is not allowed.
1552
1553         (WebInspector.NewTabContentView.prototype._updateTabItems):
1554         Refresh the disabled state for each of the buttons.
1555
1556 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
1557
1558         Web Inspector: Show Page Source does not switch to Resources tab if inspector was closed
1559         https://bugs.webkit.org/show_bug.cgi?id=145423
1560
1561         Reviewed by Timothy Hatcher.
1562
1563         * UserInterface/Base/Main.js:
1564         (WebInspector._frameWasAdded.delayedWork):
1565         (WebInspector._frameWasAdded):
1566         In the special case where we are holding to show a frame's source code when
1567         the frame becomes available (_frameIdentifierToShowSourceCodeWhenAvailable)
1568         we should be forcing to show the tab.
1569
1570 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
1571
1572         Web Inspector: Toggling an inherited property sometimes stops working
1573         https://bugs.webkit.org/show_bug.cgi?id=145416
1574
1575         Reviewed by Timothy Hatcher.
1576
1577         * UserInterface/Models/DOMNodeStyles.js:
1578         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1579         Ensure we update the existing model objects with the new state information
1580         before possibly bailing. This may produce changed events that update
1581         parts of the inspector appropriately.
1582
1583 2015-05-27  Joseph Pecoraro  <pecoraro@apple.com>
1584
1585         Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works
1586         https://bugs.webkit.org/show_bug.cgi?id=143164
1587
1588         Reviewed by Brian Burg.
1589
1590         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1591         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
1592         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
1593         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.didToggle):
1594         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode):
1595         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
1596         Make it so editing in the metrics pane just evaluates elem.style.setProperty
1597         on the inspected page. Use "!important" to try and give the maximum priority
1598         possible, which is a change from older behavior. Finally, refresh the sidebar
1599         to update all values, and update the UI if bad input didn't change styles.
1600
1601 2015-05-26  Joseph Pecoraro  <pecoraro@apple.com>
1602
1603         Web Inspector: Function parameter string parsing improperly handles empty parameter list
1604         https://bugs.webkit.org/show_bug.cgi?id=145391
1605
1606         Reviewed by Darin Adler.
1607
1608         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
1609         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
1610
1611 2015-05-26  Joseph Pecoraro  <pecoraro@apple.com>
1612
1613         Web Inspector: Add Array.prototype.copyWithin parameter list
1614         https://bugs.webkit.org/show_bug.cgi?id=145388
1615
1616         Reviewed by Darin Adler.
1617
1618         * UserInterface/Models/NativeFunctionParameters.js:
1619
1620 2015-05-26  Nikita Vasilyev  <nvasilyev@apple.com>
1621
1622         Web Inspector: focus outline of a search field should have a radius
1623         https://bugs.webkit.org/show_bug.cgi?id=145383
1624
1625         Add a focus outline animation to roughly mimic the default focus outline of OS X.
1626
1627         Reviewed by Timothy Hatcher.
1628
1629         * UserInterface/Views/Toolbar.css:
1630         (.toolbar .search-bar > input[type="search"]):
1631         -webkit-focus-ring-color doesn't follow element's curvature (e.g. border-radius)
1632         and it cannot be animated. Replace it with box-shadow.
1633
1634         (.toolbar .search-bar > input[type="search"]:focus):
1635
1636 2015-05-26  Nikita Vasilyev  <nvasilyev@apple.com>
1637
1638         Web Inspector: The bottom part "debugger" is clipped in the tab’s title
1639         https://bugs.webkit.org/show_bug.cgi?id=145381
1640
1641         Reviewed by Timothy Hatcher.
1642
1643         * UserInterface/Views/TabBar.css:
1644         (.tab-bar > .item):
1645         Set line-height to fit "debugger". Setting line-height to 16px, which is the
1646         size of the tabs icons, moves the text one pixel up, so set it to 15px.
1647
1648 2015-05-26  Dan Bernstein  <mitz@apple.com>
1649
1650         <rdar://problem/21104551> Update build settings
1651
1652         Reviewed by Anders Carlsson.
1653
1654         * Configurations/Base.xcconfig:
1655         * Configurations/DebugRelease.xcconfig:
1656         * Configurations/Version.xcconfig:
1657
1658 2015-05-23  Dan Bernstein  <mitz@apple.com>
1659
1660         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
1661         https://bugs.webkit.org/show_bug.cgi?id=145345
1662
1663         Reviewed by Sam Weinig.
1664
1665         * Configurations/Base.xcconfig:
1666
1667 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
1668
1669         Web Inspector: Remove code related with unused style classes
1670         https://bugs.webkit.org/show_bug.cgi?id=145332
1671
1672         Reviewed by Timothy Hatcher.
1673
1674         * UserInterface/Views/ConsoleMessageView.js:
1675         (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
1676         (WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
1677         The "type-string" class has no styles associated with it. So the entire span can be removed.
1678
1679         * UserInterface/Views/DOMTreeElement.js:
1680         Both of these style classes have no styles associated with them. Remove the class names.
1681
1682 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
1683
1684         Web Inspector: Improve native parameter lists a bit
1685         https://bugs.webkit.org/show_bug.cgi?id=145338
1686
1687         Reviewed by Timothy Hatcher.
1688
1689         * UserInterface/Models/NativeFunctionParameters.js:
1690         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
1691         (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
1692
1693 2015-05-23  Joseph Pecoraro  <pecoraro@apple.com>
1694
1695         Web Inspector: Update CSS Autocompletion properties and values
1696         https://bugs.webkit.org/show_bug.cgi?id=145341
1697
1698         Reviewed by Timothy Hatcher.
1699
1700         * UserInterface/Models/CSSKeywordCompletions.js:
1701
1702 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1703
1704         Web Inspector: Adopt Object.setPrototypeOf
1705         https://bugs.webkit.org/show_bug.cgi?id=145335
1706
1707         Reviewed by Timothy Hatcher.
1708
1709         For a case that won't easily move to ES6 classes use Object.setPrototypeOf.
1710
1711         * UserInterface/Protocol/InspectorBackend.js:
1712         (InspectorBackend.Command.create):
1713
1714 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1715
1716         Web Inspector: Inline use once class names and remove some unused class names
1717         https://bugs.webkit.org/show_bug.cgi?id=145334
1718
1719         Reviewed by Timothy Hatcher.
1720
1721         * UserInterface/Views/ApplicationCacheFrameContentView.js:
1722         (WebInspector.ApplicationCacheFrameContentView):
1723         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1724         (WebInspector.BoxModelDetailsSectionRow):
1725         * UserInterface/Views/CSSStyleDeclarationSection.js:
1726         (WebInspector.CSSStyleDeclarationSection):
1727         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1728         (WebInspector.CSSStyleDetailsSidebarPanel):
1729         * UserInterface/Views/ClusterContentView.js:
1730         (WebInspector.ClusterContentView):
1731         * UserInterface/Views/CompletionSuggestionsView.js:
1732         (WebInspector.CompletionSuggestionsView):
1733         * UserInterface/Views/ConsolePrompt.js:
1734         (WebInspector.ConsolePrompt):
1735         * UserInterface/Views/ContentBrowser.js:
1736         (WebInspector.ContentBrowser):
1737         * UserInterface/Views/ContentFlowTreeElement.js:
1738         (WebInspector.ContentFlowTreeElement):
1739         * UserInterface/Views/ContentView.js:
1740         (WebInspector.ContentView):
1741         * UserInterface/Views/ContentViewContainer.js:
1742         (WebInspector.ContentViewContainer):
1743         * UserInterface/Views/CookieStorageContentView.js:
1744         (WebInspector.CookieStorageContentView):
1745         * UserInterface/Views/CookieStorageTreeElement.js:
1746         (WebInspector.CookieStorageTreeElement):
1747         * UserInterface/Views/DOMStorageContentView.js:
1748         (WebInspector.DOMStorageContentView):
1749         * UserInterface/Views/DOMTreeContentView.js:
1750         (WebInspector.DOMTreeContentView):
1751         * UserInterface/Views/DashboardView.js:
1752         (WebInspector.DashboardView):
1753         * UserInterface/Views/DatabaseTableContentView.js:
1754         (WebInspector.DatabaseTableContentView):
1755         * UserInterface/Views/DebuggerDashboardView.js:
1756         (WebInspector.DebuggerDashboardView):
1757         (WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
1758         * UserInterface/Views/DetailsSection.js:
1759         (WebInspector.DetailsSection):
1760         * UserInterface/Views/DetailsSectionSimpleRow.js:
1761         * UserInterface/Views/FontResourceContentView.js:
1762         (WebInspector.FontResourceContentView):
1763         (WebInspector.FontResourceContentView.prototype.createMetricElement):
1764         (WebInspector.FontResourceContentView.prototype.contentAvailable):
1765         * UserInterface/Views/HierarchicalPathComponent.js:
1766         (WebInspector.HierarchicalPathComponent):
1767         (WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):
1768         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
1769         * UserInterface/Views/LayoutTimelineOverviewGraph.js:
1770         (WebInspector.LayoutTimelineOverviewGraph):
1771         * UserInterface/Views/NetworkTimelineOverviewGraph.js:
1772         (WebInspector.NetworkTimelineOverviewGraph):
1773         * UserInterface/Views/OverviewTimelineView.js:
1774         * UserInterface/Views/ProbeSetDetailsSection.js:
1775         * UserInterface/Views/QuickConsole.js:
1776         * UserInterface/Views/ReplayDashboardView.js:
1777         * UserInterface/Views/ScriptContentView.js:
1778         (WebInspector.ScriptContentView):
1779         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1780         (WebInspector.ScriptTimelineOverviewGraph):
1781         * UserInterface/Views/TextContentView.js:
1782         (WebInspector.TextContentView):
1783         * UserInterface/Views/TimelineOverview.js:
1784         (WebInspector.TimelineOverview):
1785         * UserInterface/Views/TimelineOverviewGraph.js:
1786         (WebInspector.TimelineOverviewGraph):
1787         * UserInterface/Views/TimelineRecordBar.js:
1788         (WebInspector.TimelineRecordBar):
1789         * UserInterface/Views/TimelineRecordFrame.js:
1790         (WebInspector.TimelineRecordFrame):
1791         * UserInterface/Views/TimelineRecordingContentView.js:
1792         (WebInspector.TimelineRecordingContentView):
1793         * UserInterface/Views/TimelineRuler.js:
1794         (WebInspector.TimelineRuler):
1795         (WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):
1796
1797 2015-05-22  Joseph Pecoraro  <pecoraro@apple.com>
1798
1799         Web Inspector: DOMTree Keyboard Shortcut 'H' to toggle element visibility is not working
1800         https://bugs.webkit.org/show_bug.cgi?id=145331
1801
1802         Reviewed by Brian Burg.
1803
1804         We no longer have CSSProperty.value setters. Instead of attempting
1805         to toggle and clobber inline style values on the element we:
1806         
1807           1. inject a <style> on the page like ".WebInspectorHide { visibility:hidden }"
1808           2. toggle the WebInspectorHide class on the selected element
1809
1810         This approach is inspired by the original WebKit change in the
1811         old inspector frontend: <https://webkit.org/b/110641>.
1812
1813         The old approach toggled a few properties (opacity and pointer events)
1814         while the new approach uses visibility, matching other browsers.
1815
1816         * UserInterface/Views/DOMTreeOutline.js:
1817         (WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode.injectStyleAndToggleClass):
1818         (WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode):
1819         (WebInspector.DOMTreeOutline.prototype._hideElement):
1820         (WebInspector.DOMTreeOutline.prototype._hideElement.toggleProperties): Deleted.
1821
1822 2015-05-21  Joseph Pecoraro  <pecoraro@apple.com>
1823
1824         Web Inspector: Give Toolbar buttons an active style
1825         https://bugs.webkit.org/show_bug.cgi?id=145292
1826
1827         Reviewed by Timothy Hatcher.
1828
1829         * UserInterface/Views/ButtonToolbarItem.css:
1830         (.toolbar .item.button:active):
1831
1832 2015-05-21  Nikita Vasilyev  <nvasilyev@apple.com>
1833
1834         Web Inspector: Dashboard debugger information can be clipped
1835         https://bugs.webkit.org/show_bug.cgi?id=144209
1836
1837         Reviewed by Timothy Hatcher.
1838
1839         * UserInterface/Views/DashboardContainerView.css:
1840         (.toolbar .dashboard-container):
1841         Make dashboard flexible by using vw (viewport width units).
1842
1843         * UserInterface/Views/DefaultDashboardView.css:
1844         (.toolbar .dashboard.default):
1845         Center default dashboard icons in the middle, don't spread them along the dashboard.
1846
1847 2015-05-21  Joseph Pecoraro  <pecoraro@apple.com>
1848
1849         Web Inspector: Improve the UI of the type profiler popover
1850         https://bugs.webkit.org/show_bug.cgi?id=140737
1851
1852         Reviewed by Timothy Hatcher.
1853
1854         Display TypeDescriptions in a Tree similiar to ObjectTrees.
1855         Currently the only information we have in a TypeDescription
1856         is the property names, and not their types, so all we can
1857         display in the tree are names.
1858
1859         * Localizations/en.lproj/localizedStrings.js:
1860         * UserInterface/Controllers/TypeTokenAnnotator.js:
1861         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1862         * UserInterface/Main.html:
1863         * UserInterface/Models/ScriptSyntaxTree.js:
1864         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
1865         * UserInterface/Models/StructureDescription.js: Added.
1866         (WebInspector.StructureDescription):
1867         (WebInspector.StructureDescription.fromPayload):
1868         (WebInspector.StructureDescription.prototype.get fields):
1869         (WebInspector.StructureDescription.prototype.get optionalFields):
1870         (WebInspector.StructureDescription.prototype.get constructorName):
1871         (WebInspector.StructureDescription.prototype.get prototypeStructure):
1872         (WebInspector.StructureDescription.prototype.get imprecise):
1873         * UserInterface/Models/TypeDescription.js: Added.
1874         (WebInspector.TypeDescription):
1875         (WebInspector.TypeDescription.fromPayload):
1876         (WebInspector.TypeDescription.prototype.get leastCommonAncestor):
1877         (WebInspector.TypeDescription.prototype.get typeSet):
1878         (WebInspector.TypeDescription.prototype.get structures):
1879         (WebInspector.TypeDescription.prototype.get valid):
1880         (WebInspector.TypeDescription.prototype.get truncated):
1881         * UserInterface/Models/TypeSet.js:
1882         (WebInspector.TypeSet):
1883         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
1884         * UserInterface/Views/ObjectTreeView.js:
1885         (WebInspector.ObjectTreeView.prototype._updateChildren):
1886         * UserInterface/Views/Section.css: Removed.
1887         * UserInterface/Views/Section.js: Removed.
1888         * UserInterface/Views/SourceCodeTextEditor.css:
1889         (.popover .expandable):
1890         * UserInterface/Views/SourceCodeTextEditor.js:
1891         (WebInspector.SourceCodeTextEditor):
1892         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
1893         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
1894         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1895         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1896         (WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
1897         * UserInterface/Views/TypePropertiesSection.js: Removed.
1898         * UserInterface/Views/TypeTokenView.js:
1899         (WebInspector.TypeTokenView):
1900         (WebInspector.TypeTokenView.titleForPopover):
1901         (WebInspector.TypeTokenView.prototype.update):
1902         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
1903         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1904         (WebInspector.TypeTokenView.prototype._displayTypeName):
1905         * UserInterface/Views/TypeTreeElement.css: Added.
1906         (.type-tree-element):
1907         (.type-tree-element > .titles):
1908         (.type-tree-element > .disclosure-button):
1909         (.type-tree-element.parent > .disclosure-button):
1910         (.type-tree-element.parent.expanded > .disclosure-button):
1911         (.type-tree-element > .icon):
1912         (.type-tree-element.prototype):
1913         (.type-tree-element.prototype:focus):
1914         (.type-tree-element.prototype + ol):
1915         * UserInterface/Views/TypeTreeElement.js: Added.
1916         (WebInspector.TypeTreeElement):
1917         (WebInspector.TypeTreeElement.prototype.get name):
1918         (WebInspector.TypeTreeElement.prototype.get isPrototype):
1919         (WebInspector.TypeTreeElement.prototype.onpopulate):
1920         (WebInspector.TypeTreeElement.prototype.onexpand):
1921         * UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js.
1922         (.type-tree):
1923         (.type-tree-outline):
1924         (.type-tree-outline li):
1925         (.type-tree-outline ol):
1926         (.type-tree-outline ol.expanded):
1927         (.type-tree-outline li .empty-message):
1928         * UserInterface/Views/TypeTreeView.js: Added.
1929         (WebInspector.TypeTreeView):
1930         (WebInspector.TypeTreeView.prototype.get typeDescription):
1931         (WebInspector.TypeTreeView.prototype.get element):
1932         (WebInspector.TypeTreeView.prototype.get treeOutline):
1933         (WebInspector.TypeTreeView.prototype._populate):
1934
1935 2015-05-20  Joseph Pecoraro  <pecoraro@apple.com>
1936
1937         Web Inspector: Fix WebInspector.StackTrace style
1938         https://bugs.webkit.org/show_bug.cgi?id=145240
1939
1940         Reviewed by Timothy Hatcher.
1941
1942         * UserInterface/Models/StackTrace.js:
1943         Reorder and add our usual marker comments.
1944
1945 2015-05-19  Joseph Pecoraro  <pecoraro@apple.com>
1946
1947         Web Inspector: Improve Preview for NodeList / array like collections
1948         https://bugs.webkit.org/show_bug.cgi?id=145177
1949
1950         Reviewed by Timothy Hatcher.
1951
1952         * UserInterface/Views/ObjectPreviewView.js:
1953         (WebInspector.ObjectPreviewView.prototype._appendPreview):
1954         Show the class name for a non-basic-Array, but still hide
1955         it for a basic Array.
1956
1957 2015-05-19  Nikita Vasilyev  <nvasilyev@apple.com>
1958
1959         Web Inspector: Convert stackTrace from raw payload data to an array of CallFrames
1960         https://bugs.webkit.org/show_bug.cgi?id=144982
1961
1962         Reviewed by Joseph Pecoraro.
1963
1964         * UserInterface/Controllers/LogManager.js:
1965         * UserInterface/Main.html:
1966         * UserInterface/Models/CallFrame.js:
1967         (WebInspector.CallFrame.fromPayload):
1968         Consider an empty string url as a native code as it was in 
1969         WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame
1970
1971         * UserInterface/Models/ConsoleMessage.js:
1972         (WebInspector.ConsoleMessage):
1973         Convert _stackTrace from an array of payload objects to WebInspector.StackTrace model.
1974
1975         * UserInterface/Models/StackTrace.js: Added.
1976         (WebInspector.StackTrace):
1977         (WebInspector.StackTrace.prototype.get callFrames):
1978         (WebInspector.StackTrace.prototype.get firstNonNativeCallFrame): Added.
1979         (WebInspector.StackTrace.fromPayload):
1980         * UserInterface/Test.html:
1981         * UserInterface/Views/CallFrameView.js:
1982         (WebInspector.CallFrameView):
1983         Don't show a URL when sourceCodeLocation is missing, fix webkit.org/b/145071.
1984
1985         * UserInterface/Views/ConsoleMessageView.js:
1986         (WebInspector.ConsoleMessageView):
1987         (WebInspector.ConsoleMessageView.prototype.toClipboardString):
1988         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
1989         (WebInspector.ConsoleMessageView.prototype._appendStackTrace):
1990         (WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
1991         (WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
1992         (WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame): Deleted.
1993
1994 2015-05-18  Joseph Pecoraro  <pecoraro@apple.com>
1995
1996         Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
1997         https://bugs.webkit.org/show_bug.cgi?id=145139
1998
1999         Reviewed by Timothy Hatcher.
2000
2001         * UserInterface/Views/DOMTreeElement.js:
2002         (WebInspector.DOMTreeElement.prototype.highlightSearchResults):
2003         (WebInspector.DOMTreeElement.prototype.hideSearchHighlights):
2004         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
2005         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
2006         (WebInspector.DOMTreeElement.prototype._updateChildren):
2007         (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
2008         (WebInspector.DOMTreeElement.prototype._startEditingAsHTML.dispose):
2009         (WebInspector.DOMTreeElement.prototype._startEditingAsHTML):
2010         (WebInspector.DOMTreeElement.prototype.updateTitle):
2011         Stop using the `delete` operator.
2012
2013         * UserInterface/Views/DOMTreeOutline.js:
2014         (WebInspector.DOMTreeOutline.prototype.setVisible):
2015         Trigger an update when the outline is made visible.
2016
2017         * UserInterface/Views/FrameDOMTreeContentView.js:
2018         (WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
2019         Provide a reasonable default selection if there is no body or document element.
2020         For example in an augmented DOM tree.
2021
2022 2015-05-18  Joseph Pecoraro  <pecoraro@apple.com>
2023
2024         Web Inspector: Tab Restoration incorrectly makes ContentViews "shown" in background tabs
2025         https://bugs.webkit.org/show_bug.cgi?id=145080
2026
2027         Reviewed by Timothy Hatcher.
2028
2029         Many tabs have their own content browser / navigation sidebar. During
2030         state restoration, each tab would immediately try to restore an
2031         appropriate ContentView after the load / navigation. However, in doing
2032         so, we weren't respecting whether or not the Tab the ContentBrowser
2033         was in was hidden or not, so ContentViews in background tags were
2034         still being treated as shown/visible.
2035
2036         This patch changes state restoration to only affect the foreground
2037         tab, and be delayed on all background tabs until that tab is shown.
2038         This reduces the amount of work on load and navigation to just a
2039         single tab instead of all tabs. Most importantly, it avoids having
2040         performing work on ContentBrowsers that are non-visible, so state
2041         restoration only happens for visible ContentBrowsers.
2042
2043         For simplicity, in the case of a delayed tab restoration triggered
2044         by the user switching tabs, we don't try twice (like we occasionally
2045         do on load/reload). We could add back some hueristic here if needed.
2046
2047         * UserInterface/Base/Main.js:
2048         (WebInspector.contentLoaded):
2049         (WebInspector.activateExtraDomains):
2050         (WebInspector._mainResourceDidChange):
2051         (WebInspector._restoreCookieForOpenTabs):
2052         * UserInterface/Views/NavigationSidebarPanel.js:
2053
2054         * UserInterface/Views/TabContentView.js:
2055         (WebInspector.TabContentView.prototype.shown):
2056         (WebInspector.TabContentView.prototype.restoreStateFromCookie):
2057         (WebInspector.TabContentView.prototype.saveStateToCookie):
2058         When asked to restore state, save that logic until the next time the tab is shown.
2059
2060         * UserInterface/Views/TextEditor.js:
2061         (WebInspector.TextEditor.prototype.get visible):
2062         * UserInterface/Views/SourceCodeTextEditor.js:
2063         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidStartEditing):
2064         (WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState): Deleted.
2065         Although this didn't actually catch the issue, it could potentially
2066         catch other issues in the future. We don't want to enable the annotators
2067         in a non-visible text editor, as it could be a performance issue.
2068
2069 2015-05-15  Matt Baker  <mattbaker@apple.com>
2070
2071         Web Inspector: empty timeline should not use previous timeline's zoom interval
2072         https://bugs.webkit.org/show_bug.cgi?id=132754
2073
2074         Reviewed by Joseph Pecoraro.
2075
2076         When a timeline recording is started in response to a provisional load, TimelineManager should check whether
2077         the main resource url is changing before loading a new timeline recording. If the main resource is changing,
2078         set the selection start, selection duration, and duration-per-pixel settings of the TimelineOverview to their
2079         default values.
2080
2081         * UserInterface/Controllers/TimelineManager.js:
2082         (WebInspector.TimelineManager):
2083         (WebInspector.TimelineManager.prototype.isCapturingPageReload):
2084         (WebInspector.TimelineManager.prototype.capturingStopped):
2085         (WebInspector.TimelineManager.prototype.pageDidLoad):
2086         (WebInspector.TimelineManager.prototype._startAutoCapturing):
2087         Added a property for checking whether auto capture was triggered by a page reload.
2088
2089         * UserInterface/Views/LinearTimelineOverview.js:
2090         (WebInspector.LinearTimelineOverview):
2091         Increase default selection time to 15 seconds.
2092
2093         * UserInterface/Views/TimelineOverview.js:
2094         (WebInspector.TimelineOverview):
2095         Reset selection and zoom if TimelineManager isn't capturing in response to a page reload.
2096
2097         (WebInspector.TimelineOverview.prototype.reset):
2098         Reset selection and zoom.
2099
2100         (WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
2101         (WebInspector.TimelineOverview.prototype._resetSelection):
2102         Added a helper function for resetting selection and zoom to their default values.
2103
2104 2015-05-15  Matt Baker  <mattbaker@apple.com>
2105
2106         Web Inspector: Timeline data grid displays wrong records after switching between Timelines/Frames mode
2107         https://bugs.webkit.org/show_bug.cgi?id=145084
2108
2109         Reviewed by Timothy Hatcher.
2110
2111         Update timeline sidebar filter whenever the view mode changes.
2112
2113         * UserInterface/Views/TimelineSidebarPanel.js:
2114         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
2115         (WebInspector.TimelineSidebarPanel.get else):
2116         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
2117         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
2118
2119 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
2120
2121         Web Inspector: Bump image format number to force image regeneration
2122         https://bugs.webkit.org/show_bug.cgi?id=145074
2123
2124         Reviewed by Timothy Hatcher.
2125
2126         * UserInterface/Base/ImageUtilities.js:
2127
2128 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
2129
2130         Web Inspector: Reduce type annotation update frequency
2131         https://bugs.webkit.org/show_bug.cgi?id=145066
2132
2133         Reviewed by Timothy Hatcher.
2134
2135         * UserInterface/Controllers/TypeTokenAnnotator.js:
2136         Reduce the frequency which could commonly be 16-24ms
2137         to a minimum of 100ms and maximum of 2000ms.
2138
2139 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
2140
2141         Web Inspector: Fix some possible event listener leakers in content views
2142         https://bugs.webkit.org/show_bug.cgi?id=145068
2143
2144         Reviewed by Timothy Hatcher.
2145
2146         Now that some content views can be closed that weren't closable before, ensure
2147         we clean up after global event listeners that may strongly reference "this".
2148
2149         * UserInterface/Views/DOMTreeContentView.js:
2150         (WebInspector.DOMTreeContentView.prototype.closed):
2151         * UserInterface/Views/DOMTreeOutline.js:
2152         (WebInspector.DOMTreeOutline.prototype.close):
2153         * UserInterface/Views/LayoutTimelineView.js:
2154         (WebInspector.LayoutTimelineView.prototype.closed):
2155         * UserInterface/Views/NetworkTimelineView.js:
2156         (WebInspector.NetworkTimelineView.prototype.closed):
2157         * UserInterface/Views/RenderingFrameTimelineView.js:
2158         (WebInspector.RenderingFrameTimelineView.prototype.closed):
2159         * UserInterface/Views/ScriptContentView.js:
2160         (WebInspector.ScriptContentView.prototype.closed):
2161         * UserInterface/Views/ScriptTimelineView.js:
2162         (WebInspector.ScriptTimelineView.prototype.closed):
2163         * UserInterface/Views/SourceCodeTextEditor.js:
2164         (WebInspector.SourceCodeTextEditor.prototype.close):
2165         * UserInterface/Views/TextResourceContentView.js:
2166         (WebInspector.TextResourceContentView.prototype.closed):
2167         * UserInterface/Views/TimelineDataGrid.js:
2168         (WebInspector.TimelineDataGrid.prototype.closed):
2169         (WebInspector.TimelineDataGrid.prototype.handleEvent):
2170
2171 2015-05-15  Joseph Pecoraro  <pecoraro@apple.com>
2172
2173         Web Inspector: Initiator Popovers no longer work in Layout Timeline
2174         https://bugs.webkit.org/show_bug.cgi?id=145067
2175
2176         Reviewed by Timothy Hatcher.
2177
2178         * UserInterface/Views/LayoutTimelineDataGrid.js:
2179         (WebInspector.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
2180         Update the column name, which changed in r183134.
2181
2182 2015-05-14  Joseph Pecoraro  <pecoraro@apple.com>
2183
2184         Web Inspector: Update the New Tab button disabled state after extra domains are activated
2185         https://bugs.webkit.org/show_bug.cgi?id=145028
2186
2187         Reviewed by Timothy Hatcher.
2188
2189         * UserInterface/Base/Main.js:
2190         (WebInspector.activateExtraDomains):
2191
2192 2015-05-14  Matt Baker  <mattbaker@apple.com>
2193
2194         Web Inspector: Current time marker is always at zero in Rendering Frames ruler
2195         https://bugs.webkit.org/show_bug.cgi?id=144518
2196
2197         Reviewed by Timothy Hatcher.
2198
2199         The current and end time values for the rendering frame timeline overview should always be equal to the frame
2200         number of the last record in the rendering frames timeline.
2201
2202         * UserInterface/Views/TimelineOverview.js:
2203         (WebInspector.TimelineOverview):
2204         (WebInspector.TimelineOverview.prototype.updateLayout):
2205         * UserInterface/Views/TimelineRecordingContentView.js:
2206         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
2207         (WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
2208
2209 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2210
2211         [Win] Move Windows build target to Windows 7 (or newer)
2212         https://bugs.webkit.org/show_bug.cgi?id=144890
2213         <rdar://problem/20707307>
2214
2215         Reviewed by Anders Carlsson.
2216
2217         Update linked SDK and minimal Windows level to be compatible with
2218         Windows 7 or newer.
2219
2220         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2221
2222 2015-05-11  Timothy Hatcher  <timothy@apple.com>
2223
2224         Web Inspector: REGRESSION (Tabs): Issues reloading a resource with breakpoints
2225         https://bugs.webkit.org/show_bug.cgi?id=144650
2226
2227         Fix a number of issues with Debugger tab and navigation/reloading:
2228         - Close old content views in the Debugger tab when main frame navigates.
2229         - Prune old resource tree elements before attempting to restore a cookie that might match an old resource.
2230         - Allow breakpoint selections to be restored from a saved cookie.
2231         - Fix an assert when closing a content view that isn't the current index, but is the current view.
2232         - Avoid calling closed() multiple times when a ContentView is in the back/forward list more than once.
2233         - Make restoreStateFromCookie properly set and use the causedByNavigation argument for a longer restore delay.
2234         - Create a new cookie object per tab instead of it being cumulative from the previous cookie.
2235
2236         Reviewed by Brian Burg.
2237
2238         * UserInterface/Base/Main.js:
2239         (WebInspector._mainResourceDidChange): Delay calling _restoreCookieForOpenTabs to give time for sidebars
2240         and tabs to respond to the main resource change.
2241         (WebInspector._restoreCookieForOpenTabs): Rename causedByReload to causedByNavigation. Nothing special about
2242         reload since we restore on all navigation.
2243
2244         * UserInterface/Views/ContentView.js:
2245         (WebInspector.ContentView): Support Breakpoint as a represented object, which happens during a cookie restore.
2246         (WebInspector.ContentView.isViewable): Ditto.
2247
2248         * UserInterface/Views/ContentViewContainer.js:
2249         (WebInspector.ContentViewContainer.prototype.closeAllContentViews): Disassociate if the view is current and not just
2250         the current entry index. This matches other close functions. This fixes an assert in _disassociateFromContentView.
2251         (WebInspector.ContentViewContainer.prototype._disassociateFromContentView): Don't disassociate multiple times. This
2252         avoids calling the closed() function on a view more than once.
2253
2254         * UserInterface/Views/DebuggerSidebarPanel.js:
2255         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
2256         (WebInspector.DebuggerSidebarPanel.prototype._mainResourceDidChange): Renamed from _mainResourceChanged.
2257         Close all content views if this is the main frame. Also prune all old resources. Doing this now avoids a flash
2258         of having old and new resources in the tree caused by the default delay in NavigationSidebarPanel's _checkForOldResources.
2259
2260         * UserInterface/Views/NavigationSidebarPanel.js:
2261         (WebInspector.NavigationSidebarPanel): Set _autoPruneOldTopLevelResourceTreeElements for later.
2262         (WebInspector.NavigationSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
2263         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentView): Fix typo.
2264         (WebInspector.NavigationSidebarPanel.prototype.showDefaultContentViewForTreeElement): Fix whitespace.
2265         (WebInspector.NavigationSidebarPanel.prototype.pruneOldResourceTreeElements): Added. Broken out from
2266         _checkForOldResources.delayedWork so it can be called manually. Also check all visible tree outlines.
2267         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged): Pass treeElement in an array.
2268         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResourcesIfNeeded): Added.
2269         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResources): Call pruneOldResourceTreeElements on a delay.
2270         (WebInspector.NavigationSidebarPanel.prototype._checkForOldResources.delayedWork): Deleted.
2271         (WebInspector.NavigationSidebarPanel.prototype._checkOutlinesForPendingViewStateCookie): Call _checkForOldResourcesIfNeeded.
2272         (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie): Remove array folding code.
2273
2274         * UserInterface/Views/TabContentView.js:
2275         (WebInspector.TabContentView.prototype.restoreStateFromCookie): Rename causedByReload to causedByNavigation.
2276         (WebInspector.TabContentView.prototype.saveStateToCookie): Don't allow the cookie to build on the old cookie.
2277
2278 2015-05-11  Timothy Hatcher  <timothy@apple.com>
2279
2280         Web Inspector: NavigationSidebarPanel leaks some event listeners
2281         https://bugs.webkit.org/show_bug.cgi?id=144523
2282
2283         Reviewed by Joseph Pecoraro.
2284
2285         * UserInterface/Views/NavigationSidebarPanel.js:
2286         (WebInspector.NavigationSidebarPanel):
2287         (WebInspector.NavigationSidebarPanel.prototype.closed):
2288         * UserInterface/Views/ResourceSidebarPanel.js:
2289         (WebInspector.ResourceSidebarPanel.prototype.closed):
2290         * UserInterface/Views/SearchSidebarPanel.js:
2291         (WebInspector.SearchSidebarPanel.prototype.closed):
2292         * UserInterface/Views/StorageSidebarPanel.js:
2293         (WebInspector.StorageSidebarPanel.prototype.closed):
2294         * UserInterface/Views/TimelineSidebarPanel.js:
2295         (WebInspector.TimelineSidebarPanel.prototype.closed):
2296
2297 2015-05-10  Nikita Vasilyev  <nvasilyev@apple.com>
2298
2299         Web Inspector: In the console, show function name next to the source link
2300         https://bugs.webkit.org/show_bug.cgi?id=144372
2301
2302         Introduce CallFrameView to display counsole message source links. It looks like this:
2303
2304             [f] functionName - filename.js:42
2305
2306         Reviewed by Timothy Hatcher.
2307
2308         * UserInterface/Base/Main.js:
2309         (WebInspector.createSourceCodeLocationLink):
2310         (WebInspector.linkifyLocation):
2311         (.showSourceCodeLocation):
2312         (WebInspector.linkifyElement):
2313         Abstract this out as it's used in WebInspector.CallFrameView and WebInspector.createSourceCodeLocationLink.
2314
2315         (WebInspector.sourceCodeForURL):
2316         Move this code from Timeline to Main.js as it's used by Console too.
2317
2318         (WebInspector.linkifyURLAsNode):
2319         Remove tooltipText argument as it is never used.
2320
2321         * UserInterface/Controllers/TimelineManager.js:
2322         (WebInspector.TimelineManager.prototype._callFramesFromPayload):
2323         * UserInterface/Main.html:
2324         * UserInterface/Models/CallFrame.js:
2325         (WebInspector.CallFrame.fromPayload):
2326         Abstract this out as it's used in WebInspector.TimelineManager.prototype._callFramesFromPayload and
2327         WebInspector.ConsoleMessageView._appendLocationLink.
2328
2329         (WebInspector.CallFrame):
2330         * UserInterface/Views/CallFrameTreeElement.js:
2331         (WebInspector.CallFrameTreeElement):
2332         Move it to WebInspector.CallFrameView.iconForCallFrame.
2333
2334         * UserInterface/Views/CallFrameView.css: Added.
2335         (.call-frame):
2336         (.call-frame .icon):
2337         (.call-frame .titles):
2338         (.call-frame .title):
2339         (.call-frame .source-link):
2340         (.call-frame .title + .subtitle > .source-link):
2341         (.call-frame .subtitle .source-link):
2342         (.call-frame:focus .subtitle .source-link):
2343         (.call-frame .subtitle:empty):
2344         (.call-frame .subtitle):
2345         (.call-frame .colon):
2346         (.call-frame .title + .subtitle::before):
2347         * UserInterface/Views/CallFrameView.js: Added.
2348         (WebInspector.CallFrameView):
2349         (WebInspector.CallFrameView.iconClassNameForCallFrame):
2350         * UserInterface/Views/ConsoleMessageView.css:
2351         (.console-message .console-message-location):
2352         (.console-message .call-frame):
2353         (.console-message .go-to-link):
2354         (.console-message .go-to-link:focus):
2355         (.console-message .console-message-url::before):
2356         (.console-saved-variable): Deleted.
2357         * UserInterface/Views/ConsoleMessageView.js:
2358         (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
2359         * UserInterface/Views/DebuggerDashboardView.js:
2360         * UserInterface/Views/Main.css:
2361         (.hidden): Deleted.
2362         * UserInterface/Views/ProfileNodeTreeElement.js:
2363         (WebInspector.ProfileNodeTreeElement):
2364         * UserInterface/Views/TimelineDataGridNode.js:
2365         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
2366
2367 2015-05-08  Tobias Reiss  <tobi+webkit@basecode.de>
2368
2369         Web Inspector: Styles sidebar editing with incomplete property looks poor in UI
2370         https://bugs.webkit.org/show_bug.cgi?id=141692
2371
2372         Reviewed by Timothy Hatcher.
2373
2374         Add "css-rule" Formatter that breaks CSS declarations into multiple lines,
2375         keeps comments and invalid styles and adds whitespace.
2376
2377         * Tools/PrettyPrinting/css-rule-tests/*.css: Added.
2378         Add test cases.
2379
2380         * Tools/PrettyPrinting/index.html:
2381         Enable Test setup to be able to run "css-rule" Formatter tests.
2382
2383         * UserInterface/Controllers/Formatter.js:
2384         (Formatter.prototype._handleToken):
2385         * UserInterface/Controllers/FormatterContentBuilder.js:
2386         (FormatterContentBuilder.prototype.removeLastNewline):
2387         (FormatterContentBuilder.prototype.removeLastWhitespace):
2388         (FormatterContentBuilder.prototype._popFormattedContent):
2389         (FormatterContentBuilder.prototype._popNewLine): Deleted.
2390         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2391         (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):
2392         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.set this):
2393         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.get this):
2394         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
2395         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent):
2396         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.countNewLineCharacters): Deleted.
2397         (WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.else): Deleted.
2398         * UserInterface/Views/CodeMirrorFormatters.js:
2399
2400 2015-05-07  Joseph Pecoraro  <pecoraro@apple.com>
2401
2402         Web Inspector: Expanding Object with only __proto__ looks poor should have a label
2403         https://bugs.webkit.org/show_bug.cgi?id=144755
2404
2405         Reviewed by Timothy Hatcher.
2406
2407         Better handle cases where expanding an object has only a __proto__
2408         and no other properties.
2409
2410         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
2411         (WebInspector.ObjectTreePropertyTreeElement.mode.prototype.this.children.length):
2412         (WebInspector.ObjectTreePropertyTreeElement):
2413         * UserInterface/Views/ObjectTreeView.css:
2414         (.object-tree-outline li .empty-message):
2415         * UserInterface/Views/ObjectTreeView.js:
2416         (WebInspector.ObjectTreeView.createEmptyMessageElement):
2417         (WebInspector.ObjectTreeView.comparePropertyDescriptors):
2418         (WebInspector.ObjectTreeView.prototype._updateProperties):
2419
2420 2015-05-07  Joseph Pecoraro  <pecoraro@apple.com>
2421
2422         Web Inspector: Fix querySelector in ResourceContentView.js, caught by assertion
2423         https://bugs.webkit.org/show_bug.cgi?id=144756
2424
2425         Reviewed by Timothy Hatcher.
2426
2427         * UserInterface/Views/ResourceContentView.js:
2428         (WebInspector.ResourceContentView.prototype._hasContent):
2429         Ensure querySelector call is using the class name correctly.
2430
2431 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
2432
2433         Web Inspector: Docking Toolbar Buttons do not respect Docking Availability
2434         https://bugs.webkit.org/show_bug.cgi?id=144714
2435
2436         Reviewed by Timothy Hatcher.
2437
2438         * UserInterface/Base/Main.js:
2439         (WebInspector.contentLoaded):
2440         (WebInspector.updateDockingAvailability):
2441         (WebInspector._updateDockNavigationItems):
2442         Update the Toolbar UI based on docking availability.
2443         Assume docking is unavailable by default.
2444
2445         * UserInterface/Protocol/InspectorFrontendAPI.js:
2446         (InspectorFrontendAPI.setDockingUnavailable):
2447         Add back this API as the backend may be calling it when
2448         docking availability changes. This just calls out to
2449         global WebInspector functions to update the Toolbar UI.
2450
2451         * UserInterface/Base/Test.js:
2452         (WebInspector.updateDockedState):
2453         (WebInspector.updateDockingAvailability):
2454         Do nothing in tests.
2455
2456 2015-05-06  Matt Baker  <mattbaker@apple.com>
2457
2458         Web Inspector: The text in the left pane overlaps the "Filter Time Events" field in the Timeline after the Web Inspector is resized
2459         https://bugs.webkit.org/show_bug.cgi?id=144720
2460
2461         Reviewed by Timothy Hatcher.
2462
2463         * UserInterface/Views/FilterBar.css:
2464         (.filter-bar):
2465         (.filter-bar > .navigation-bar):
2466         (.filter-bar > input[type="search"]):
2467         (.filter-bar > .navigation-bar > .item): Deleted.
2468         Filter bar now has opaque background and height updated to the ubiquitous 29px.
2469
2470 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
2471
2472         Web Inspector: DOMStorage exception and issue with sessionStorage
2473         https://bugs.webkit.org/show_bug.cgi?id=144646
2474
2475         Reviewed by Timothy Hatcher.
2476
2477         * UserInterface/Views/DOMStorageContentView.js:
2478         (WebInspector.DOMStorageContentView):
2479         (WebInspector.DOMStorageContentView.prototype._populate):
2480         (WebInspector.DOMStorageContentView.prototype.reset): Deleted.
2481         Always have the datagrid be available with a default sort.
2482
2483         (WebInspector.DOMStorageContentView.prototype._sortDataGrid.comparator):
2484         (WebInspector.DOMStorageContentView.prototype._sortDataGrid):
2485         Simplify and correct the order.
2486
2487         (WebInspector.DOMStorageContentView.prototype.cleanup):
2488         Cleanup some uses of delete.
2489
2490         * UserInterface/Views/DataGrid.js:
2491         (WebInspector.DataGrid.prototype.sortNodesImmediately):
2492         Provide a way to sort immediately without a visible delay.
2493
2494         (WebInspector.DataGrid.prototype._sortNodesCallback):
2495         Cleanup some dead code to simplify sorting.
2496
2497         (WebInspector.DataGridNode.prototype._attach):
2498         When sorting, the children list does not match the child node list,
2499         so ensure that placeholder nodes are added to the end.
2500
2501         (WebInspector.PlaceholderDataGridNode.prototype.makeNormal):
2502         Cleanup some uses of delete.
2503
2504 2015-05-06  Joseph Pecoraro  <pecoraro@apple.com>
2505
2506         Web Inspector: SourceCodeTextEditor shows "undefined" instead of resource content when pausing during resource load
2507         https://bugs.webkit.org/show_bug.cgi?id=144662
2508
2509         Reviewed by Timothy Hatcher.
2510
2511         * UserInterface/Protocol/InspectorBackend.js:
2512         (InspectorBackend.Command.prototype.promise):
2513         Start standardizing on rejecting Promises with Error objects.
2514
2515         * UserInterface/Views/ResourceContentView.js:
2516         (WebInspector.ResourceContentView):
2517         (WebInspector.ResourceContentView.prototype._protocolError):
2518         When there is a protocol error, show a nice UI string for the error.
2519
2520         (WebInspector.ResourceContentView.prototype._contentAvailable):
2521         (WebInspector.ResourceContentView.prototype._contentError):
2522         (WebInspector.ResourceContentView.prototype._hasContent):
2523         Whenever we hit an error case in ResourceContentView, check to make sure
2524         that a subclass hasn't already populated the content view with content.
2525         This can happen when a TextResourceContentView populates a Resource with
2526         Script content while paused, because the Resource content would be
2527         unavailable. We check that content has loaded by checking that the
2528         indeterminate spinner is no longer showing.
2529
2530 2015-05-05  Andres Gomez  <agomez@igalia.com>
2531
2532         [GTK] Web Inspector: Further optimize SVG images
2533         https://bugs.webkit.org/show_bug.cgi?id=144441
2534
2535         SVG images optimized with a combination of sed replacements, the
2536         usage of the scour tool (http://www.codedread.com/scour/) and a
2537         forked version of the svgo tool (https://github.com/tanty/svgo).
2538
2539         Also, added the class attribute to the shape elements following
2540         the convention used in Apple's images.
2541
2542         Reviewed by Joseph Pecoraro.
2543
2544         * UserInterface/Images/gtk/BackArrow.svg: Optimized.
2545         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Optimized.
2546         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Optimized.
2547         * UserInterface/Images/gtk/BreakpointButton.svg: Optimized.
2548         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Optimized.
2549         * UserInterface/Images/gtk/Breakpoints.svg: Optimized.
2550         * UserInterface/Images/gtk/Checkers.svg: Optimized.
2551         * UserInterface/Images/gtk/Circle.svg: Optimized.
2552         * UserInterface/Images/gtk/Close.svg: Optimized.
2553         * UserInterface/Images/gtk/CloseLarge.svg: Optimized.
2554         * UserInterface/Images/gtk/CloseWhite.svg: Optimized.
2555         * UserInterface/Images/gtk/ContentFlow.svg: Optimized.
2556         * UserInterface/Images/gtk/Crosshair.svg: Optimized.
2557         * UserInterface/Images/gtk/DOMCharacterData.svg: Optimized.
2558         * UserInterface/Images/gtk/DOMComment.svg: Optimized.
2559         * UserInterface/Images/gtk/DOMDocument.svg: Optimized.
2560         * UserInterface/Images/gtk/DOMDocumentType.svg: Optimized.
2561         * UserInterface/Images/gtk/DOMElement.svg: Optimized.
2562         * UserInterface/Images/gtk/DOMNode.svg: Optimized.
2563         * UserInterface/Images/gtk/DOMTextNode.svg: Optimized.
2564         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Optimized.
2565         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Optimized.
2566         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Optimized.
2567         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Optimized.
2568         * UserInterface/Images/gtk/DockBottom.svg: Optimized.
2569         * UserInterface/Images/gtk/DockRight.svg: Optimized.
2570         * UserInterface/Images/gtk/DownloadArrow.svg: Optimized.
2571         * UserInterface/Images/gtk/Error.svg: Optimized.
2572         * UserInterface/Images/gtk/Errors.svg: Optimized.
2573         * UserInterface/Images/gtk/ErrorsEnabled.svg: Optimized.
2574         * UserInterface/Images/gtk/EventListener.svg: Optimized.
2575         * UserInterface/Images/gtk/Exception.svg: Optimized.
2576         * UserInterface/Images/gtk/Eye.svg: Optimized.
2577         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Optimized.
2578         * UserInterface/Images/gtk/ForwardArrow.svg: Optimized.
2579         * UserInterface/Images/gtk/Function.svg: Optimized.
2580         * UserInterface/Images/gtk/GoToArrow.svg: Optimized.
2581         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Optimized.
2582         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Optimized.
2583         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Optimized.
2584         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Optimized.
2585         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Optimized.
2586         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Optimized.
2587         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Optimized.
2588         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Optimized.
2589         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Optimized.
2590         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Optimized.
2591         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Optimized.
2592         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Optimized.
2593         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Optimized.
2594         * UserInterface/Images/gtk/Issues.svg: Optimized.
2595         * UserInterface/Images/gtk/IssuesEnabled.svg: Optimized.
2596         * UserInterface/Images/gtk/LayerBorders.svg: Optimized.
2597         * UserInterface/Images/gtk/Locked.svg: Optimized.
2598         * UserInterface/Images/gtk/Logs.svg: Optimized.
2599         * UserInterface/Images/gtk/Native.svg: Optimized.
2600         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Optimized.
2601         * UserInterface/Images/gtk/NavigationItemTrash.svg: Optimized.
2602         * UserInterface/Images/gtk/NavigationItemTypes.svg: Optimized.
2603         * UserInterface/Images/gtk/PaintFlashing.svg: Optimized.
2604         * UserInterface/Images/gtk/Pause.svg: Optimized.
2605         * UserInterface/Images/gtk/PausedBreakpoint.svg: Optimized.
2606         * UserInterface/Images/gtk/Pencil.svg: Optimized.
2607         * UserInterface/Images/gtk/Plus.svg: Optimized. Text element
2608         converted into a shape.
2609         * UserInterface/Images/gtk/PseudoElement.svg: Optimized.
2610         * UserInterface/Images/gtk/Record.svg: Optimized.
2611         * UserInterface/Images/gtk/Reflection.svg: Optimized.
2612         * UserInterface/Images/gtk/ReloadFull.svg: Optimized.
2613         * UserInterface/Images/gtk/ReplayPauseButton.svg: Optimized.
2614         * UserInterface/Images/gtk/ReplayPlayButton.svg: Optimized.
2615         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Optimized.
2616         * UserInterface/Images/gtk/Request.svg: Optimized.
2617         * UserInterface/Images/gtk/Resources.svg: Optimized.
2618         * UserInterface/Images/gtk/Response.svg: Optimized.
2619         * UserInterface/Images/gtk/ResultLine.svg: Optimized.
2620         * UserInterface/Images/gtk/Resume.svg: Optimized.
2621         * UserInterface/Images/gtk/ShadowDOM.svg: Optimized.
2622         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Optimized.
2623         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Optimized.
2624         * UserInterface/Images/gtk/SplitToggleUp.svg: Optimized.
2625         * UserInterface/Images/gtk/StepInto.svg: Optimized.
2626         * UserInterface/Images/gtk/StepOut.svg: Optimized.
2627         * UserInterface/Images/gtk/StepOver.svg: Optimized.
2628         * UserInterface/Images/gtk/Stop.svg: Optimized.
2629         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Optimized.
2630         * UserInterface/Images/gtk/StyleRuleInherited.svg: Optimized.
2631         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Optimized.
2632         * UserInterface/Images/gtk/StyleRuleInspector.svg: Optimized.
2633         * UserInterface/Images/gtk/StyleRuleUser.svg: Optimized.
2634         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Optimized.
2635         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Optimized.
2636         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Optimized.
2637         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Optimized.
2638         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Optimized.
2639         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Optimized.
2640         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Optimized.
2641         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Optimized.
2642         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Optimized.
2643         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Optimized.
2644         * UserInterface/Images/gtk/TypeBoolean.svg: Optimized.
2645         * UserInterface/Images/gtk/TypeNull.svg: Optimized.
2646         * UserInterface/Images/gtk/TypeNumber.svg: Optimized.
2647         * UserInterface/Images/gtk/TypeObject.svg: Optimized.
2648         * UserInterface/Images/gtk/TypeRegex.svg: Optimized. Removed
2649         mistaken extra shape.
2650         * UserInterface/Images/gtk/TypeString.svg: Optimized.
2651         * UserInterface/Images/gtk/TypeSymbol.svg: Optimized. Removed
2652         mistaken extra shape.
2653         * UserInterface/Images/gtk/TypeUndefined.svg: Optimized.
2654         * UserInterface/Images/gtk/Undock.svg: Optimized.
2655         * UserInterface/Images/gtk/UpDownArrows.svg: Optimized.
2656         * UserInterface/Images/gtk/UserInputPrompt.svg: Optimized.
2657         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Optimized.
2658         * UserInterface/Images/gtk/UserInputResult.svg: Optimized.
2659         * UserInterface/Images/gtk/Warning.svg: Optimized.
2660
2661 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2662
2663         REGRESSION: Web Inspector: no way to navigate to a resource/source location from overview timeline view
2664         https://bugs.webkit.org/show_bug.cgi?id=144539
2665
2666         Reviewed by Brian Burg.
2667
2668         * UserInterface/Views/GeneralTreeElement.js:
2669         (WebInspector.GeneralTreeElement.prototype.set status): Call didChange() so the onchange event fires. This allows
2670         TimelineSidebarPanel to update the status element when it goes from a spinner to empty for ResourceTreeElements.
2671         (WebInspector.GeneralTreeElement.prototype.onattach): Don't call _updateStatusElement, just append it if needed.
2672         Calling _updateStatusElement caused DOMNodeFragments as status elements to be appended a second time and fail.
2673         * UserInterface/Views/NavigationSidebarPanel.js:
2674         (WebInspector.NavigationSidebarPanel.prototype.treeElementAddedOrChanged):
2675         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2676         * UserInterface/Views/NetworkTimelineView.js:
2677         (WebInspector.NetworkTimelineView.prototype.canShowContentViewForTreeElement):
2678         (WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement):
2679         (WebInspector.NetworkTimelineView.prototype.treeElementSelected):
2680         (WebInspector.NetworkTimelineView.prototype._dataGridNodeSelected):
2681         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2682         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked): Deleted.
2683         * UserInterface/Views/OverviewTimelineView.js:
2684         (WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement):
2685         (WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement):
2686         (WebInspector.OverviewTimelineView.prototype._dataGridNodeSelected):
2687         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected): Deleted.
2688         (WebInspector.OverviewTimelineView.prototype._treeElementSelected): Deleted.
2689         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2690         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked): Deleted.
2691         * UserInterface/Views/RenderingFrameTimelineView.js:
2692         (WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement):
2693         (WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement):
2694         * UserInterface/Views/ResourceTimelineDataGridNode.js:
2695         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent): Don't show a go-to arrow in the Domain column.
2696         (WebInspector.ResourceTimelineDataGridNode.prototype._goToResource): Deleted.
2697         * UserInterface/Views/ScriptTimelineView.js:
2698         (WebInspector.ScriptTimelineView.prototype.canShowContentViewForTreeElement):
2699         (WebInspector.ScriptTimelineView.prototype.showContentViewForTreeElement):
2700         (WebInspector.ScriptTimelineView.prototype.treeElementSelected):
2701         * UserInterface/Views/TimelineRecordTreeElement.js:
2702         (WebInspector.TimelineRecordTreeElement.prototype.get sourceCodeLocation):
2703         * UserInterface/Views/TimelineSidebarPanel.css:
2704         (.sidebar > .panel.navigation.timeline .item:hover:not(.selected) .status .close.status-button):
2705         (.sidebar > .panel.navigation.timeline:not(.timeline-recording-content-view-showing) .status .go-to-arrow.status-button):
2706         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .status .close.status-button):
2707         * UserInterface/Views/TimelineSidebarPanel.js:
2708         (WebInspector.TimelineSidebarPanel.prototype.treeElementAddedOrChanged): Added.
2709         (WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
2710         (WebInspector.TimelineSidebarPanel.prototype._treeElementGoToArrowWasClicked): Added.
2711         (WebInspector.TimelineSidebarPanel.prototype._treeElementCloseButtonClicked): Added.
2712         * UserInterface/Views/TimelineView.js:
2713         (WebInspector.TimelineView):
2714         (WebInspector.TimelineView.prototype.canShowContentViewForTreeElement):
2715         (WebInspector.TimelineView.prototype.showContentViewForTreeElement):
2716         (WebInspector.TimelineView.prototype.treeElementDeselected):
2717         (WebInspector.TimelineView.prototype.treeElementSelected):
2718         (WebInspector.TimelineView.prototype.needsLayout):
2719         (WebInspector.TimelineView.prototype._closeStatusButtonClicked): Deleted.
2720         (WebInspector.TimelineView.prototype._updateTreeElementWithCloseButton): Deleted.
2721         * UserInterface/Views/TreeElementStatusButton.css:
2722         (.item > .status > .status-button): Fix an alignment issue with close and go-to arrows being side-by-side.
2723         Does not happen in the final patch because they are mutually exclusive, but still good to fix.
2724
2725 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2726
2727         Web Inspector: Fix some issues with Search tabs
2728         https://bugs.webkit.org/show_bug.cgi?id=144531
2729
2730         Reviewed by Darin Adler.
2731
2732         * UserInterface/Views/ContentView.js:
2733         (WebInspector.ContentView):
2734         (WebInspector.ContentView.isViewable):
2735         Support DOMSearchMatchObject and SourceCodeSearchMatchObject representedObjects. These are usually
2736         handled at a higher level, but cookie restoring requires ContentView to handle them.
2737
2738         * UserInterface/Views/DOMTreeContentView.js:
2739         (WebInspector.DOMTreeContentView):
2740         (WebInspector.DOMTreeContentView.prototype.selectAndRevealDOMNode):
2741         (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
2742         (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
2743         Don't allow restoring the previous selected node when another not has already been selected.
2744
2745         * UserInterface/Views/SearchTabContentView.js:
2746         (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
2747         Allow Script objects to be shown in the Search tab.
2748
2749 2015-05-05  Timothy Hatcher  <timothy@apple.com>
2750
2751         Web Inspector: Source/WebInspectorUI/UserInterface/Images/Logs.svg has unknown attribute "fille"
2752         https://bugs.webkit.org/show_bug.cgi?id=144627
2753
2754         Reviewed by Darin Adler.
2755
2756         * UserInterface/Images/Logs.svg: Change "fille" to "fill".
2757
2758 2015-05-05  Andres Gomez  <agomez@igalia.com>
2759
2760         [GTK] Web Inspector: New Images added in r183339, r183338, r183332, r183323, r182660, and r182186
2761         https://bugs.webkit.org/show_bug.cgi?id=144329
2762
2763         Reviewed by Joseph Pecoraro.
2764
2765         * UserInterface/Images/gtk/Console.svg: Added.
2766         * UserInterface/Images/gtk/Debugger.svg: Added.
2767         * UserInterface/Images/gtk/Elements.svg: Added.
2768         * UserInterface/Images/gtk/Gear.svg: Added.
2769         * UserInterface/Images/gtk/NewTab.svg: Added.
2770         * UserInterface/Images/gtk/NewTabPlus.svg: Added.
2771         * UserInterface/Images/gtk/ReloadToolbar.svg: Added.
2772         * UserInterface/Images/gtk/SearchResults.svg: Added.
2773         * UserInterface/Images/gtk/Storage.svg: Added.
2774         * UserInterface/Images/gtk/Timeline.svg: Added.
2775         * UserInterface/Images/gtk/TimelineRecordRenderingFrame.svg: Added.
2776         * UserInterface/Images/gtk/ToggleLeftSidebar.svg: Added.
2777         * UserInterface/Images/gtk/ToggleRightSidebar.svg: Added.
2778
2779 2015-05-05  Andres Gomez  <agomez@igalia.com>
2780
2781         [GTK] Web Inspector: icons for console.info() messages
2782         https://bugs.webkit.org/show_bug.cgi?id=144461
2783
2784         Reviewed by Joseph Pecoraro.
2785
2786         * UserInterface/Images/gtk/Debug.svg: Added.
2787         * UserInterface/Images/gtk/Info.svg: Added.
2788         * UserInterface/Images/gtk/Log.svg: Added.
2789
2790 2015-05-04  Joseph Pecoraro  <pecoraro@apple.com>
2791
2792         Web Inspector: Always expand initial top level DOM tree nodes when not including the root (frame views)
2793         https://bugs.webkit.org/show_bug.cgi?id=144607
2794
2795         Reviewed by Timothy Hatcher.
2796
2797         * UserInterface/Views/DOMTreeOutline.js:
2798         (WebInspector.DOMTreeOutline.prototype.update):
2799
2800 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2801
2802         Web Inspector: Allow closing and reopening the Debugger tab
2803         https://bugs.webkit.org/show_bug.cgi?id=144536
2804
2805         Reviewed by Joseph Pecoraro.
2806
2807         * UserInterface/Base/Main.js:
2808         (WebInspector._updateNewTabButtonState):
2809         * UserInterface/Views/DebuggerSidebarPanel.js:
2810         (WebInspector.DebuggerSidebarPanel):
2811         (WebInspector.DebuggerSidebarPanel.prototype.closed):
2812         (WebInspector.DebuggerSidebarPanel.prototype._addIssuesForSourceCode):
2813         (WebInspector.DebuggerSidebarPanel.prototype._addResourcesRecursivelyForFrame):
2814         (WebInspector.DebuggerSidebarPanel.prototype._resourceAdded):
2815         (WebInspector.DebuggerSidebarPanel.prototype._addResource):
2816         (WebInspector.DebuggerSidebarPanel.prototype._mainResourceChanged):
2817         (WebInspector.DebuggerSidebarPanel.prototype._scriptAdded):
2818         (WebInspector.DebuggerSidebarPanel.prototype._addScript):
2819         * UserInterface/Views/DebuggerTabContentView.js:
2820         (WebInspector.DebuggerTabContentView):
2821         * UserInterface/Views/NewTabContentView.js:
2822         (WebInspector.NewTabContentView):
2823
2824 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2825
2826         REGRESSION: Web Inspector: FrameTreeElement does not folders properly when loading a page
2827         https://bugs.webkit.org/show_bug.cgi?id=144535
2828
2829         Reviewed by Joseph Pecoraro.
2830
2831         * UserInterface/Views/FolderizedTreeElement.js:
2832         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject): Fix an exception if not in a tree.
2833         (WebInspector.FolderizedTreeElement.prototype.prepareToPopulate):
2834         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
2835
2836 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2837
2838         Web Inspector: Allow closing and reopening the Timelines tab
2839         https://bugs.webkit.org/show_bug.cgi?id=144520
2840
2841         Reviewed by Joseph Pecoraro.
2842
2843         * UserInterface/Base/Main.js:
2844         (WebInspector._updateNewTabButtonState):
2845         * UserInterface/Controllers/TimelineManager.js:
2846         (WebInspector.TimelineManager): No need for a delay now. Call reset().
2847         (WebInspector.TimelineManager.prototype.reset):
2848         (WebInspector.TimelineManager.delayedWork): Deleted.
2849         * UserInterface/Views/ContentBrowserTabContentView.js:
2850         (WebInspector.ContentBrowserTabContentView):
2851         (WebInspector.ContentBrowserTabContentView.prototype.closed):
2852         * UserInterface/Views/LayoutTimelineView.js:
2853         (WebInspector.LayoutTimelineView.prototype.closed): Added. Fixed leak.
2854         * UserInterface/Views/NetworkTimelineView.js:
2855         (WebInspector.NetworkTimelineView.prototype.closed): Added. Fixed leak.
2856         * UserInterface/Views/NewTabContentView.js:
2857         (WebInspector.NewTabContentView): Added Timelines.
2858         * UserInterface/Views/OverviewTimelineView.js:
2859         (WebInspector.OverviewTimelineView.prototype.closed): Added. Fixed leak.
2860         * UserInterface/Views/RenderingFrameTimelineView.js:
2861         (WebInspector.RenderingFrameTimelineView.prototype.closed): Added. Fixed leak.
2862         * UserInterface/Views/ScriptTimelineView.js:
2863         (WebInspector.ScriptTimelineView.prototype.closed):
2864         * UserInterface/Views/SearchTabContentView.js:
2865         (WebInspector.SearchTabContentView.prototype.closed): Deleted. Made generic
2866         in ContentBrowserTabContentView.prototype.closed.
2867         * UserInterface/Views/TabBrowser.js:
2868         (WebInspector.TabBrowser.prototype._tabBarItemSelected): Fix a potential exception
2869         when selectedTabBarItem is null.
2870         * UserInterface/Views/TimelineSidebarPanel.js:
2871         (WebInspector.TimelineSidebarPanel):
2872         (WebInspector.TimelineSidebarPanel.prototype.closed):
2873         (WebInspector.TimelineSidebarPanel._recordingCreated): Call _addRecording.
2874         (WebInspector.TimelineSidebarPanel._addRecording): Added.
2875         * UserInterface/Views/TimelineTabContentView.js:
2876         (WebInspector.TimelineTabContentView):
2877
2878 2015-05-04  Timothy Hatcher  <timothy@apple.com>
2879
2880         Web Inspector: Switching recordings in the Timeline navigation bar is broken
2881         https://bugs.webkit.org/show_bug.cgi?id=144519
2882
2883         Reviewed by Joseph Pecoraro.
2884
2885         * UserInterface/Views/ContentBrowser.js:
2886         (WebInspector.ContentBrowser.prototype._hierarchicalPathComponentWasSelected): Use revealAndSelect
2887         on the TreeElement instead of showing the representedObject directly. This fixes an exception in
2888         TimelineRecordingContentView where it wouldn't be initialized with the TimelineSidebarPanel extra argument.
2889         * UserInterface/Views/TimelineOverview.js:
2890         (WebInspector.TimelineOverview.prototype.get visibleDuration): Fix an annoying assert. We show the view
2891         early in construction, before it is in the document. Future updateLayout calls work and fix this.
2892         * UserInterface/Views/TimelineRecordingContentView.js:
2893         (WebInspector.TimelineRecordingContentView.prototype.shown): Call _currentContentViewDidChange
2894         to trigger the sidebar to update when this recording view is shown.
2895         * UserInterface/Views/TimelineSidebarPanel.js:
2896         (WebInspector.TimelineSidebarPanel.prototype._recordingsTreeElementSelected): Moved code from here...
2897         (WebInspector.TimelineSidebarPanel.prototype._recordingSelected): ... to here. Take two different paths
2898         to state restoration here. If the view existed before, use its state. If now, use the current state that
2899         is captured by the cookie logic and explicitly restore it.
2900
2901 2015-05-03  Timothy Hatcher  <timothy@apple.com>
2902
2903         Web Inspector: Exception under ContentViewContainer _disassociateFromContentView
2904         https://bugs.webkit.org/show_bug.cgi?id=144546
2905
2906         Reviewed by Brian Burg.
2907
2908         * UserInterface/Views/ContentViewContainer.js:
2909         (WebInspector.ContentViewContainer.prototype.showContentView):
2910         Make sure to pass the ContentView to _disassociateFromContentView. Also negate the result
2911         of the _backForwardList.some(), since we don't want to dissociate if the content view is
2912         still in the back-forward list.
2913
2914 2015-05-02  Matt Baker  <mattbaker@apple.com>
2915
2916         Web Inspector: Relocate the selected range details in the Rendering Frames timeline UI
2917         https://bugs.webkit.org/show_bug.cgi?id=144346
2918
2919         This patch removes the details sidebar used by the rendering frames view, and relocates the frame selection
2920         chart the Timelines navigation sidebar.
2921
2922         Reviewed by Timothy Hatcher.
2923
2924         * Localizations/en.lproj/localizedStrings.js:
2925         * UserInterface/Base/Main.js:
2926         (WebInspector.contentLoaded):
2927         RenderingFramesDetailsSidebar is no longer used.
2928
2929         * UserInterface/Controllers/TimelineManager.js:
2930         (WebInspector.TimelineManager.prototype._loadNewRecording):
2931         Reordered timelines.
2932
2933         * UserInterface/Main.html:
2934         Removed references to deleted files.
2935
2936         * UserInterface/Views/ChartDetailsSectionLegendRow.js: Removed.
2937         No longer used. The legend is now a child element of the chart.
2938
2939         * UserInterface/Views/ChartDetailsSectionRow.css:
2940         (.details-section > .content > .group > .row.chart > .title):
2941         (.details-section > .content > .group > .row.chart > .chart-content):
2942         (.details-section > .content > .group > .row.chart > .chart-content > .legend):
2943         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item):
2944         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label > .color-swatch):
2945         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label):
2946         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .value):
2947         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > *):
2948         New chart and legend styles.
2949
2950         * UserInterface/Views/ChartDetailsSectionRow.js:
2951         (WebInspector.ChartDetailsSectionRow):
2952         (WebInspector.ChartDetailsSectionRow.prototype.set title):
2953         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2954         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius):
2955         (WebInspector.ChartDetailsSectionRow.prototype.get total):
2956         (WebInspector.ChartDetailsSectionRow.set data):
2957         (WebInspector.ChartDetailsSectionRow.prototype.set data):
2958         (WebInspector.ChartDetailsSectionRow.prototype._createLegendItem):
2959         (WebInspector.ChartDetailsSectionRow.prototype._refresh):
2960
2961         A few changes have been made to the appearance and behavior of the chart. A chart title can now be set,
2962         and the legend appears to the right of the chart rather than in a separate details group.
2963
2964         The chart now has better support for adding empty data points, ensuring that a meaningful legend is shown even
2965         when no rendering frames are selected in the timeline overview graph. This ensures that the task associated
2966         with each colored frame segment is apparent, without having to make a selection or record a timeline.
2967
2968         * UserInterface/Views/RenderingFrameDetailsSidebarPanel.js: Removed.
2969         No longer used.
2970
2971         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
2972         Reduced maximum timeline height to increase the height of short frames.
2973
2974         * UserInterface/Views/RenderingFrameTimelineView.js:
2975         (WebInspector.RenderingFrameTimelineView.prototype.shown):
2976         (WebInspector.RenderingFrameTimelineView.prototype.hidden):
2977         RenderingFramesDetailsSidebar is no longer used.
2978
2979         * UserInterface/Views/TimelineRecordingContentView.js:
2980         (WebInspector.TimelineRecordingContentView):
2981         (WebInspector.TimelineRecordingContentView.prototype._updateTimes):
2982         (WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
2983         (WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
2984         (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
2985         (WebInspector.TimelineRecordingContentView.prototype._updateFrameSelection):
2986         Improved logic for updating the frame selection.
2987
2988         * UserInterface/Views/TimelineSidebarPanel.css:
2989         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > div.header):
2990         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > .content > .group > .row.chart):
2991         (.sidebar > .panel.navigation.timeline > .timelines-content > .details-section > .content > .group > .row.chart > .chart-content > .chart):
2992         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content): Deleted.
2993         New chart styles.
2994
2995         * UserInterface/Views/TimelineSidebarPanel.js:
2996         (WebInspector.TimelineSidebarPanel):
2997         (WebInspector.TimelineSidebarPanel.prototype.shown):
2998         (WebInspector.TimelineSidebarPanel._timelineAdded.set this):
2999         (WebInspector.TimelineSidebarPanel.this._timelineTreeElementMap.get select):
3000         (WebInspector.TimelineSidebarPanel.get else):
3001         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.getSelectedRecords.get var):
3002         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.getSelectedRecords):
3003         (WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
3004         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
3005         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
3006         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.durationForRecordType):
3007         (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):
3008         (WebInspector.TimelineSidebarPanel.set contentTreeOutlineLabel): Deleted.
3009         (WebInspector.TimelineSidebarPanel._recordingCreated.set this): Deleted.
3010         (WebInspector.TimelineSidebarPanel.get this): Deleted.
3011         Moved the selected frames chart to the navigation sidebar.
3012
3013         * UserInterface/Views/TimelineTabContentView.js:
3014         (WebInspector.TimelineTabContentView):
3015         RenderingFramesDetailsSidebar is no longer used.
3016
3017         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
3018         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
3019         Removed references to deleted files.
3020
3021 2015-05-02  Timothy Hatcher  <timothy@apple.com>
3022
3023         Web Inspector: Allow closing and reopening the Resources tab
3024         https://bugs.webkit.org/show_bug.cgi?id=144513
3025
3026         Reviewed by Joseph Pecoraro.
3027
3028         * UserInterface/Base/Main.js:
3029         (WebInspector._updateNewTabButtonState):
3030         * UserInterface/Views/NewTabContentView.js:
3031         (WebInspector.NewTabContentView):
3032         * UserInterface/Views/ResourceSidebarPanel.js:
3033         (WebInspector.ResourceSidebarPanel):
3034         (WebInspector.ResourceSidebarPanel.prototype.closed):
3035         * UserInterface/Views/ResourcesTabContentView.js:
3036         (WebInspector.ResourcesTabContentView):
3037
3038 2015-05-02  Timothy Hatcher  <timothy@apple.com>
3039
3040         Web Inspector: REGRESSION: Resources section doesn't update after changes are made to a local file
3041         https://bugs.webkit.org/show_bug.cgi?id=144512
3042
3043         The content view was being associated with the wrong represented object. This caused the code to use
3044         the old main resource when showing the frame again.
3045
3046         Reviewed by Joseph Pecoraro.
3047
3048         * UserInterface/Base/Main.js:
3049         (WebInspector._frameWasAdded.delayedWork):
3050         (WebInspector._frameWasAdded):
3051         With the changes in ResourceSidebarPanel, we need to delay showing the frame.
3052
3053         * UserInterface/Views/ContentBrowserTabContentView.js:
3054         (WebInspector.ContentBrowserTabContentView.prototype.showRepresentedObject):
3055         Avoid restoring state by calling cancelRestoringState(). Not fully related to this bug,
3056         but it was preventing testing the cases.
3057
3058         * UserInterface/Views/ContentViewContainer.js:
3059         (WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
3060         This fixes the bug. Don't associate the content view with the Frame, associate it with
3061         the Resource that we actually show.
3062
3063         * UserInterface/Views/NavigationSidebarPanel.js:
3064         (WebInspector.NavigationSidebarPanel.prototype.cancelRestoringState): Added.
3065
3066         * UserInterface/Views/ResourceSidebarPanel.js:
3067         (WebInspector.ResourceSidebarPanel): Remove unused _waitingForInitialMainFrame.
3068         (WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
3069         (WebInspector.ResourceSidebarPanel.prototype._mainResourceDidChange):
3070         (WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
3071         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
3072         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
3073         Clean up how we show the main frame in the sidebar. This was a two step mess before.
3074
3075 2015-04-29  Timothy Hatcher  <timothy@apple.com>
3076
3077         Web Inspector: Remove FrameContentView.js
3078         https://bugs.webkit.org/show_bug.cgi?id=144415
3079
3080         Reviewed by Joseph Pecoraro.
3081
3082         * UserInterface/Images/DOMTree.svg: Removed.
3083         * UserInterface/Images/SourceCode.svg: Removed.
3084         * UserInterface/Main.html: Removed FrameContentView.js.
3085         * UserInterface/Views/FrameContentView.js: Removed.
3086         * UserInterface/Views/PathComponentIcons.css:
3087         (.source-code-icon .icon): Deleted.
3088         (.dom-tree-icon .icon): Deleted.
3089
3090         * UserInterface/Views/ResourceSidebarPanel.js:
3091         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
3092         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
3093         Simplify the code here. We don't need these checks now with tabs and the Storage tab.
3094
3095 2015-04-30  Nikita Vasilyev  <nvasilyev@apple.com>
3096
3097         REGRESSION: Web Inspector: Console message repeat count overlapped by icon
3098         https://bugs.webkit.org/show_bug.cgi?id=144344
3099
3100         Reviewed by Timothy Hatcher.
3101
3102         * UserInterface/Views/ConsoleMessageView.css:
3103         (.console-message .repeat-count):
3104
3105 2015-04-30  Jon Davis  <jond@apple.com>
3106
3107         Web Inspector: console should show an icon for console.info() messages
3108         https://bugs.webkit.org/show_bug.cgi?id=18530
3109
3110         Reviewed by Timothy Hatcher.
3111
3112         Added icons for console.log, console.info and console.debug messages.
3113
3114         Separated console.info from console.log.
3115
3116         * UserInterface/Images/Debug.svg: Added.
3117         * UserInterface/Images/Info.svg: Added.
3118         * UserInterface/Images/Log.svg: Added.
3119         New icon files.
3120
3121         * UserInterface/Models/ConsoleMessage.js:
3122         * UserInterface/Views/ConsoleMessageView.css:
3123         (.console-log-level::before):
3124         (.console-info-level::before):
3125         (.console-debug-level::before):
3126         (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level).console-message):
3127         (:matches(.console-warning-level, .console-error-level, .console-log-level, .console-info-level, .console-debug-level)::before):
3128         (:matches(.console-warning-level, .console-error-level, .console-log-level).console-message): Deleted.
3129         (:matches(.console-warning-level, .console-error-level, .console-log-level)::before): Deleted.
3130         Include console.info messages in layout adjustments.
3131
3132         * UserInterface/Views/ConsoleMessageView.js:
3133         (WebInspector.ConsoleMessageView):
3134         (WebInspector.ConsoleMessageView.prototype._levelString):
3135
3136 2015-04-30  Timothy Hatcher  <timothy@apple.com>
3137
3138         Web Inspector: Scope Chain sidebar should be selected immediately when paused
3139         https://bugs.webkit.org/show_bug.cgi?id=144352
3140
3141         Reviewed by Joseph Pecoraro.
3142
3143         * UserInterface/Base/Main.js:
3144         (WebInspector.showDebuggerTab): Added showScopeChainDetailsSidebarPanel argument.
3145         (WebInspector._debuggerDidPause): Pass true for showScopeChainDetailsSidebarPanel.
3146         * UserInterface/Views/ContentBrowserTabContentView.js:
3147         (WebInspector.ContentBrowserTabContentView): Wire the event to showDetailsSidebarPanels instead of
3148         _contentBrowserRepresentedObjectsDidChange, allowing subclasses to do work during the event.
3149         (WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels): Moved content of
3150         _contentBrowserRepresentedObjectsDidChange here.
3151         (WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange): Deleted.
3152         * UserInterface/Views/DebuggerTabContentView.js:
3153         (WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels): Added. Show the scope sidebar panel
3154         if it is available and it was requested by showScopeChainDetailsSidebarPanel().
3155         (WebInspector.DebuggerTabContentView.prototype.showScopeChainDetailsSidebarPanel): Added.
3156
3157 2015-04-30  Andres Gomez  <agomez@igalia.com>
3158
3159         [GTK] Web Inspector: New Images for ObjectTreeView - Setter
3160         https://bugs.webkit.org/show_bug.cgi?id=143173
3161
3162         Reviewed by Martin Robinson.
3163
3164         * UserInterface/Images/gtk/Pencil.svg: Added.
3165
3166 2015-04-30  Andres Gomez  <agomez@igalia.com>
3167
3168         [GTK] Web Inspector: Remove some unused Images
3169         https://bugs.webkit.org/show_bug.cgi?id=144445
3170
3171         Reviewed by Carlos Garcia Campos.
3172
3173         * UserInterface/Images/gtk/BottomUpTree.svg: Removed.
3174         * UserInterface/Images/gtk/Log.png: Removed.
3175         * UserInterface/Images/gtk/Log@2x.png: Removed.
3176         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Removed.
3177         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Removed.
3178         * UserInterface/Images/gtk/NavigationItemBug.svg: Removed.
3179         * UserInterface/Images/gtk/NavigationItemFile.svg: Removed.
3180         * UserInterface/Images/gtk/NavigationItemLayers.svg: Removed.
3181         * UserInterface/Images/gtk/NavigationItemLog.svg: Removed.
3182         * UserInterface/Images/gtk/NavigationItemProbes.svg: Removed.
3183         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Removed.
3184         * UserInterface/Images/gtk/NavigationItemStorage.svg: Removed.
3185         * UserInterface/Images/gtk/NavigationItemVariable.svg: Removed.
3186         * UserInterface/Images/gtk/Percent.svg: Removed.
3187         * UserInterface/Images/gtk/Reload.svg: Removed.
3188         * UserInterface/Images/gtk/SplitToggleDown.svg: Removed.
3189         * UserInterface/Images/gtk/Time.svg: Removed.
3190         * UserInterface/Images/gtk/Weight.svg: Removed.
3191
3192 2015-04-30  Joseph Pecoraro  <pecoraro@apple.com>
3193
3194         Web Inspector: Copy not working in Console
3195         https://bugs.webkit.org/show_bug.cgi?id=144354
3196
3197         Reviewed by Timothy Hatcher.
3198
3199         * UserInterface/Base/Main.js:
3200         (WebInspector._focusedContentView):
3201         Select the inner most content view to check if handleCopyEvent exists.
3202         Previously we were stopping at the top level TabContentView.
3203
3204 2015-04-29  Timothy Hatcher  <timothy@apple.com>
3205
3206         Web Inspector: Remove some unused Images
3207         https://bugs.webkit.org/show_bug.cgi?id=144412
3208
3209         Reviewed by Joseph Pecoraro.
3210
3211         * UserInterface/Images/BottomUpTree.svg: Removed.
3212         * UserInterface/Images/Log.png: Removed.
3213         * UserInterface/Images/Log@2x.png: Removed.
3214         * UserInterface/Images/NavigationItemAngleBrackets.svg: Removed.
3215         * UserInterface/Images/NavigationItemBrushAndRuler.svg: Removed.
3216         * UserInterface/Images/NavigationItemBug.svg: Removed.
3217         * UserInterface/Images/NavigationItemDoughnutChart.svg: Removed.
3218         * UserInterface/Images/NavigationItemFile.svg: Removed.
3219         * UserInterface/Images/NavigationItemLayers.svg: Removed.
3220         * UserInterface/Images/NavigationItemLog.svg: Removed.
3221         * UserInterface/Images/NavigationItemProbes.svg: Removed.
3222         * UserInterface/Images/NavigationItemStopwatch.svg: Removed.
3223         * UserInterface/Images/NavigationItemStorage.svg: Removed.
3224         * UserInterface/Images/NavigationItemVariable.svg: Removed.
3225         * UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Removed.
3226         * UserInterface/Images/NetworkBarLabelCalloutRight.svg: Removed.
3227         * UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Removed.
3228         * UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Removed.
3229         * UserInterface/Images/Percent.svg: Removed.
3230         * UserInterface/Images/Reload.svg: Removed.
3231         * UserInterface/Images/SplitToggleDown.svg: Removed.
3232         * UserInterface/Images/Time.svg: Removed.
3233         * UserInterface/Images/Weight.svg: Removed.
3234
3235 2015-04-29  Timothy Hatcher  <timothy@apple.com>
3236
3237         Web Inspector: Split Storage from Resources tab
3238         https://bugs.webkit.org/show_bug.cgi?id=144404
3239
3240         Reviewed by Joseph Pecoraro.
3241
3242         * Localizations/en.lproj/localizedStrings.js:
3243         * UserInterface/Base/Main.js:
3244         (WebInspector.loaded):
3245         (WebInspector.isTabTypeAllowed):
3246         (WebInspector._tabContentViewForType):
3247         (WebInspector._updateNewTabButtonState):
3248         (WebInspector.showStorageTab):
3249         (WebInspector._storageWasInspected):
3250         * UserInterface/Controllers/ApplicationCacheManager.js:
3251         (WebInspector.ApplicationCacheManager.prototype.initialize):
3252         (WebInspector.ApplicationCacheManager.prototype.get applicationCacheObjects):
3253         * UserInterface/Controllers/StorageManager.js:
3254         (WebInspector.StorageManager.prototype.get domStorageObjects):
3255         (WebInspector.StorageManager.prototype.get databases):
3256         (WebInspector.StorageManager.prototype.get indexedDatabases):
3257         (WebInspector.StorageManager.prototype.get cookieStorageObjects):
3258         * UserInterface/Images/Storage.svg: Added.
3259         * UserInterface/Main.html:
3260         * UserInterface/Views/DatabaseTableContentView.js:
3261         (WebInspector.DatabaseTableContentView.prototype._queryFinished): Clear _dataGrid,
3262         since it might have been allocated but still be empty. This avoids an exception in
3263         updateLayout next time layout is updated.
3264         * UserInterface/Views/NewTabContentView.js:
3265         (WebInspector.NewTabContentView):
3266         * UserInterface/Views/ResourceSidebarPanel.js:
3267         (WebInspector.ResourceSidebarPanel):
3268         (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
3269         (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded): Deleted.
3270         (WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasInspected): Deleted.
3271         (WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded): Deleted.
3272         (WebInspector.ResourceSidebarPanel.prototype._databaseWasInspected): Deleted.
3273         (WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded): Deleted.
3274         (WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded): Deleted.
3275         (WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded): Deleted.
3276         (WebInspector.ResourceSidebarPanel.prototype._frameManifestRemoved): Deleted.
3277         (WebInspector.ResourceSidebarPanel.prototype._addStorageChild): Deleted.
3278         (WebInspector.ResourceSidebarPanel.prototype._storageCleared): Deleted.
3279         * UserInterface/Views/ResourcesTabContentView.js:
3280         (WebInspector.ResourcesTabContentView):
3281         (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
<