27f0f8d2f5b2cd0c049a5e46dbecf0cad6ecccb8
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2019-07-24  Devin Rousso  <drousso@apple.com>
2
3         Web Inspector: REGRESSION: no context menu items work when context menu clicking on "Add Breakpoint"
4         https://bugs.webkit.org/show_bug.cgi?id=199953
5
6         Reviewed by Joseph Pecoraro.
7
8         * UserInterface/Views/ContextMenuUtilities.js:
9         (WI.addMouseDownContextMenuHandlers): Added.
10         Create a helper function for managing elements that show a context menu on "mousedown".
11
12         * UserInterface/Base/SearchUtilities.js:
13         (WI.SearchUtilities.createSettingsButton):
14         * UserInterface/Views/CanvasContentView.js:
15         (WI.CanvasContentView.prototype.initialLayout):
16         (WI.CanvasContentView.prototype._populateCanvasElementButtonContextMenu): Added.
17         (WI.CanvasContentView.prototype._populateViewShaderButtonContextMenu): Added.
18         (WI.CanvasContentView.prototype._populateViewRecordingButtonContextMenu): Added.
19         (WI.CanvasContentView.prototype._handleCanvasElementButtonMouseDown): Deleted.
20         (WI.CanvasContentView.prototype._handleViewShaderButtonMouseDown): Deleted.
21         (WI.CanvasContentView.prototype._handleViewRecordingButtonMouseDown): Deleted.
22         * UserInterface/Views/DebuggerSidebarPanel.js:
23         (WI.DebuggerSidebarPanel):
24         (WI.DebuggerSidebarPanel.prototype._populateCreateBreakpointContextMenu): Added.
25         (WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointMouseDown): Deleted.
26         * UserInterface/Views/SourcesNavigationSidebarPanel.js:
27         (WI.SourcesNavigationSidebarPanel):
28         (WI.SourcesNavigationSidebarPanel.prototype._populateResourceGroupingModeContextMenu): Added.
29         (WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu): Added.
30         (WI.SourcesNavigationSidebarPanel.prototype._handleResourceGroupingModeMouseDown): Deleted.
31         (WI.SourcesNavigationSidebarPanel.prototype._handleCreateBreakpointMouseDown): Deleted.
32
33         * UserInterface/Views/TabBar.js:
34         (WI.TabBar):
35         (WI.TabBar.prototype._handleTabPickerTabContextMenu): Deleted.
36         * UserInterface/Views/LegacyTabBar.js:
37         (WI.LegacyTabBar):
38         (WI.LegacyTabBar.prototype._handleTabPickerTabContextMenu): Deleted.
39         Remove the "contextmenu" handler on the tab picker, as that's already used by the entire
40         tab bar to show/hide tabs.
41
42 2019-07-24  Devin Rousso  <drousso@apple.com>
43
44         Web Inspector: print the target of `console.screenshot` last so the target is the closest item to the image
45         https://bugs.webkit.org/show_bug.cgi?id=199308
46
47         Reviewed by Joseph Pecoraro.
48
49         * UserInterface/Views/ConsoleMessageView.js:
50         (WI.ConsoleMessageView.prototype.render):
51         (WI.ConsoleMessageView.prototype._appendMessageTextAndArguments):
52         (WI.ConsoleMessageView.prototype._handleContextMenu):
53         * UserInterface/Views/ConsoleMessageView.css:
54         (.console-image > .console-message-body > :matches(hr, img)): Added.
55         (.console-image > .console-message-body > hr): Added.
56         (.console-image > .console-message-body > img): Added.
57         (.console-log-level.console-image::before): Added.
58         (.console-message-body > .console-image): Deleted.
59         (.console-log-level.console-image-container::before): Deleted.
60         Allow `ConsoleMessage.MessageType.Image` to be an `ConsoleMessage.MessageLevel.Error`, and
61         print the message (and extra parameters) in that case.
62         Drive-by: reorganize the switch-case so all paths have the same `default` case.
63
64         * Localizations/en.lproj/localizedStrings.js:
65
66 2019-07-23  Nikita Vasilyev  <nvasilyev@apple.com>
67
68         Web Inspector: Styles: Command-X should cut selected properties
69         https://bugs.webkit.org/show_bug.cgi?id=199341
70
71         Reviewed by Devin Rousso.
72
73         Implement cutting of selected CSS properties in the style editor.
74         Unify cutting and copying logic wherever possible.
75
76         * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
77         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
78         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.placeTextCaretInFocusedProperty): Added.
79         Cut/copy events could only fire on SpreadsheetCSSStyleDeclarationEditor element if it
80         has selection inside of it. Placing text caret at the beginning of the focused property
81         ensures that.
82
83         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy): Deleted.
84         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):
85         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._copySelectedProperties): Added.
86         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._removeSelectedProperties): Added.
87         * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
88         (WI.SpreadsheetCSSStyleDeclarationSection.prototype._stopSelection):
89         * UserInterface/Views/SpreadsheetStyleProperty.js:
90         Remove old copying logic.
91
92 2019-07-23  Nikita Vasilyev  <nvasilyev@apple.com>
93
94         Web Inspector: Display "Resource has no content" for about:blank iframes instead of an error
95         https://bugs.webkit.org/show_bug.cgi?id=198029
96
97         Reviewed by Devin Rousso.
98
99         Display "about:blank" in the middle of the content view when selecting "about:blank" resources.
100         Previoulsly, we showed a misleading "An error occurred trying to load the resource" error
101         message.
102
103         * UserInterface/Models/CSSStyleSheet.js:
104         (WI.CSSStyleSheet.prototype.requestContentFromBackend):
105         * UserInterface/Models/Resource.js:
106         (WI.Resource.prototype.requestContentFromBackend):
107         * UserInterface/Models/Script.js:
108         (WI.Script.prototype.requestContentFromBackend):
109         * UserInterface/Models/SourceCode.js:
110         (WI.SourceCode.generateSpecialContentForURL):
111         (WI.SourceCode.prototype._processContent):
112         (WI.SourceCode):
113         * UserInterface/Views/ResourceContentView.js:
114         (WI.ResourceContentView.prototype._contentAvailable):
115
116         * UserInterface/Views/SourceCodeTextEditor.js:
117         (WI.SourceCodeTextEditor.prototype._contentAvailable):
118         (WI.SourceCodeTextEditor.prototype._showMessage):
119         * UserInterface/Views/TextResourceContentView.js:
120         (WI.TextResourceContentView.prototype._contentDidPopulate):
121         Display empty text editor when it has no content instead of "Resource has no content" message.
122
123 2019-07-22  Devin Rousso  <drousso@apple.com>
124
125         Web Inspector: Uncaught Exception: Breakpoint at specified location already exists.
126         https://bugs.webkit.org/show_bug.cgi?id=197034
127         <rdar://problem/50049004>
128
129         Reviewed by Joseph Pecoraro.
130
131         When "adjusting" a `WI.Breakpoint` (e.g. removing and then re-adding with a different
132         configuration), make sure to only re-add the `WI.Breakpoint` to the `WI.Target` it was just
133         removed from, rather to all `WI.targets`.
134
135         Since we iterate over `WI.targets` in both `WI.DebuggerManager.prototype._setBreakpoint` and
136         `WI.DebuggerManager.prototype._removeBreakpoint`, we ended up iterating `WI.targets` twice.
137
138         Each time the `WI.Breakpoint` is removed from a `WI.Target`, pass the `WI.Target` to the
139         `callback` given to `WI.DebuggerManager.prototype._removeBreakpoint`, so that the eventual
140         call to `WI.DebuggerManager.prototype._setBreakpoint` can reuse it as the `specificTarget`,
141         instead of iterating `WI.targets` (meaning we only iterate it once).
142
143         * UserInterface/Controllers/DebuggerManager.js:
144         (WI.DebuggerManager.prototype.addBreakpoint):
145         (WI.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
146         (WI.DebuggerManager.prototype._breakpointDisplayLocationDidChange):
147         (WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
148
149 2019-07-22  Devin Rousso  <drousso@apple.com>
150
151         Localization: change fps to FPS
152         <rdar://problem/53342508>
153
154         Rubber-stamped by Joseph Pecoraro.
155
156         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
157         (WI.RenderingFrameTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition):
158
159         * Localizations/en.lproj/localizedStrings.js:
160
161 2019-07-19  Devin Rousso  <drousso@apple.com>
162
163         Web Inspector: Issues toggling multiple breakpoints on one line
164         https://bugs.webkit.org/show_bug.cgi?id=199918
165
166         Reviewed by Joseph Pecoraro.
167
168         * UserInterface/Views/SourceCodeTextEditor.js:
169         (WI.SourceCodeTextEditor):
170         (WI.SourceCodeTextEditor.prototype.close):
171         (WI.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
172         (WI.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):
173         (WI.SourceCodeTextEditor.prototype._handleFormatterDidChange): Added.
174         Listen for `WI.SourceCode.Event.FormatterDidChange` events as there may be multiple content
175         views for the same `WI.SourceCode`. Previously, if there were, only the active one would
176         properly update it's "line -> column -> breakpoint" mapping, causing an error to be thrown
177         when the non-active content views tried to retrieve the breakpoint for the new line/column.
178
179 2019-07-17  Olivier Blin  <olivier.blin@softathome.com>
180
181         Web Inspector: application/xml content not shown
182         https://bugs.webkit.org/show_bug.cgi?id=199861
183
184         Reviewed by Devin Rousso.
185
186         application/xml content from XHR requests was not shown in the
187         inspector, an error message was displayed instead.
188
189         application/xml content should be treated as text, since
190         application/xml is the standard mimetype for XML content.
191         Apache serves XML content with the application/xml mimetype by
192         default.
193
194         * UserInterface/Base/MIMETypeUtilities.js:
195         (WI.fileExtensionForMIMEType):
196         Report "xml" extension for "application/xml" mimetype.
197         (WI.shouldTreatMIMETypeAsText):
198         Treat XML files as text.
199
200 2019-07-16  Nikita Vasilyev  <nvasilyev@apple.com>
201
202         Web Inspector: Changes panel should be strictly LTR
203         https://bugs.webkit.org/show_bug.cgi?id=199767
204
205         Reviewed by Joseph Pecoraro.
206
207         Changes panel is primarily CSS code and CSS is strictly LTR.
208
209         * UserInterface/Views/ChangesDetailsSidebarPanel.js:
210         (WI.ChangesDetailsSidebarPanel):
211
212 2019-07-15  Youenn Fablet  <youenn@apple.com>
213
214         Enable a debug WebRTC mode without any encryption
215         https://bugs.webkit.org/show_bug.cgi?id=199177
216         <rdar://problem/52074986>
217
218         Reviewed by Eric Carlson.
219
220         * Localizations/en.lproj/localizedStrings.js:
221         * UserInterface/Base/Main.js:
222
223 2019-07-15  Greg Doolittle <gr3g@apple.com>
224
225         Web Inspector: AXI: Audit: Typos in Accessibility audits
226         https://bugs.webkit.org/show_bug.cgi?id=199716
227         <rdar://problem/52721711>
228
229         Reviewed by Devin Rousso.
230
231         * UserInterface/Controllers/AuditManager.js:
232
233 2019-07-15  Devin Rousso  <drousso@apple.com>
234
235         Web Inspector: Device Settings: update Safari user agent from 12.2 to 13.0
236         https://bugs.webkit.org/show_bug.cgi?id=199758
237
238         Reviewed by Maciej Stachowiak.
239
240         * UserInterface/Base/Main.js:
241         (WI._handleDeviceSettingsToolbarButtonClicked):
242
243 2019-07-12  Nikita Vasilyev  <nvasilyev@apple.com>
244
245         Web Inspector: Changes: dismissing a blank property makes style rule to show in Changes panel
246         https://bugs.webkit.org/show_bug.cgi?id=199760
247
248         Reviewed by Devin Rousso.
249
250         * UserInterface/Models/CSSProperty.js:
251         (WI.CSSProperty.prototype._updateOwnerStyleText):
252         Call updatePropertiesModifiedState even when _updateOwnerStyleText returns early.
253
254 2019-07-12  Devin Rousso  <drousso@apple.com>
255
256         Web Inspector: Elements: always show all navigation bar items, but disable those that wouldn't work
257         https://bugs.webkit.org/show_bug.cgi?id=199594
258
259         Reviewed by Ross Kirsling.
260
261         Reorder the navigation items of the Elements tab (left to right):
262          - Show rulers
263          - Force print media styles
264          - Force Dark Appearance / Force Light Appearance
265          - Show compositing borders
266          - Enable paint flashing
267          - Show shadow DOM nodes
268         This way, "related" (e.g. print styles and dark/light appearance both relate to CSS media)
269         toggles are grouped closer together.
270
271         * UserInterface/Views/DOMTreeContentView.js:
272         (WI.DOMTreeContentView):
273         (WI.DOMTreeContentView.prototype.get navigationItems):
274         (WI.DOMTreeContentView.prototype._defaultAppearanceDidChange):
275         (WI.DOMTreeContentView.prototype._toggleAppearance):
276
277         * Localizations/en.lproj/localizedStrings.js:
278
279 2019-07-11  Devin Rousso  <drousso@apple.com>
280
281         Web Inspector: Layers: Uncaught Exception: Request with id = 2 failed. {"code":-32601,"message":"'Page' domain was not found","data":[{"code":-32601,"message":"'Page' domain was not found"}]}
282         https://bugs.webkit.org/show_bug.cgi?id=199555
283
284         Reviewed by Joseph Pecoraro.
285
286         Use modern inspected target support checking, and defer agent commands until a target is
287         available.
288
289         * UserInterface/Views/Layers3DContentView.js:
290         (WI.Layers3DContentView):
291         (WI.Layers3DContentView.prototype._showPaintRectsSettingChanged):
292         (WI.Layers3DContentView.prototype._updateCompositingBordersButtonState):
293         (WI.Layers3DContentView.prototype._toggleCompositingBorders):
294
295         * UserInterface/Views/DOMTreeContentView.js:
296         (WI.DOMTreeContentView):
297         (WI.DOMTreeContentView.prototype._toggleCompositingBorders):
298         (WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
299         (WI.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
300         (WI.DOMTreeContentView.prototype._showPrintStylesChanged):
301         (WI.DOMTreeContentView.prototype._showRulersChanged):
302         Drive-by: apply the same changes to the Elements tab for when the Layers tab isn't enabled.
303
304 2019-07-09  Devin Rousso  <drousso@apple.com>
305
306         Web Inspector: Canvas: replace WTF::Vector with std::initializer_list in CallTracer to avoid dynamic allocations
307         https://bugs.webkit.org/show_bug.cgi?id=199611
308
309         Reviewed by Joseph Pecoraro.
310
311         * UserInterface/Models/Recording.js:
312         (WI.Recording.prototype.async swizzle):
313         Drive-by: handle the situation where a parameter is an array of deduplicated strings, which
314                   would otherwise be treated as an array of numbers.
315
316 2019-07-09  Joseph Pecoraro  <pecoraro@apple.com>
317
318         Web Inspector: Add another Protocol Version (iOS 13.0)
319         https://bugs.webkit.org/show_bug.cgi?id=199631
320         <rdar://problem/47538193>
321
322         Reviewed by Devin Rousso.
323
324         * UserInterface/Protocol/Legacy/13.0/InspectorBackendCommands.js: Added.
325         * Versions/Inspector-iOS-13.0.json: Added.
326
327 2019-07-08  Devin Rousso  <drousso@apple.com>
328
329         Web Inspector: Debugger: special breakpoints and event targets should be sorted into separate "areas"
330         https://bugs.webkit.org/show_bug.cgi?id=199554
331
332         Reviewed by Joseph Pecoraro.
333
334         Move the special All Requests breakpoint down to be right above all other URL breakpoints.
335         Move the `window` object tree element below other DOM node tree elements.
336
337         * UserInterface/Views/DebuggerSidebarPanel.js:
338         (WI.DebuggerSidebarPanel.prototype._addTreeElement):
339         * UserInterface/Views/SourcesNavigationSidebarPanel.js:
340         (WI.SourcesNavigationSidebarPanel.prototype._insertDebuggerTreeElement):
341
342 2019-07-08  Devin Rousso  <drousso@apple.com>
343
344         Web Inspector: DOM Debugger: there should be different icons for each type of DOM breakpoint
345         https://bugs.webkit.org/show_bug.cgi?id=199552
346
347         Reviewed by Joseph Pecoraro.
348
349         [S] for Subtree Modified
350         [A] for Attribute Modified
351         [R] for Node Removed
352
353         * UserInterface/Views/DOMBreakpointTreeElement.js:
354         (WI.DOMBreakpointTreeElement):
355         * UserInterface/Views/DOMBreakpointTreeElement.css: Added.
356         (.breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon):
357         (.breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon):
358         (.breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon):
359
360         * UserInterface/Main.html:
361         * UserInterface/Images/DOMBreakpointAttributeModified.svg: Added.
362         * UserInterface/Images/DOMBreakpointNodeRemoved.svg: Added.
363         * UserInterface/Images/DOMBreakpointSubtreeModified.svg: Added.
364
365 2019-07-08  Devin Rousso  <drousso@apple.com>
366
367         Uncaught Exception: Unexpected enum value: CPU
368         https://bugs.webkit.org/show_bug.cgi?id=199564
369
370         Reviewed by Joseph Pecoraro.
371
372         * UserInterface/Controllers/TimelineManager.js:
373         (WI.TimelineManager.prototype._updateAutoCaptureInstruments):
374         Filter the list of auto-capture instruments based on what's actually supported, instead of
375         directly using the saved list from the `WI.Setting`.
376
377 2019-07-08  Devin Rousso  <drousso@apple.com>
378
379         Enabling the Layers tab hides the paint flashing button
380         https://bugs.webkit.org/show_bug.cgi?id=199549
381
382         Reviewed by Joseph Pecoraro.
383
384         Still show the Compositing Borders and Paint Flashing navigation items in the Elements tab
385         even when the Layers tab is enabled (just like the Layers details sidebar).
386
387         * UserInterface/Views/DOMTreeContentView.js:
388         (WI.DOMTreeContentView.prototype.get navigationItems):
389         (WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
390
391 2019-07-08  Devin Rousso  <drousso@apple.com>
392
393         Web Inspector: REGRESSION: Elements: pasting in the Styles sidebar adds a text node to the DOM tree
394         https://bugs.webkit.org/show_bug.cgi?id=199588
395
396         Reviewed by Joseph Pecoraro.
397
398         * UserInterface/Base/Main.js:
399         (WI._paste):
400         Bail if `event.defaultPrevented`, as that means that something else has handled (and likely
401         overrode) this event.
402
403 2019-07-08  Devin Rousso  <drousso@apple.com>
404
405         Web Inspector: the "x" in the Exception icon overlaps the border
406         https://bugs.webkit.org/show_bug.cgi?id=199553
407
408         Reviewed by Joseph Pecoraro.
409
410         * UserInterface/Images/Exception.svg:
411         * UserInterface/Images/Function.svg:
412         * UserInterface/Images/TailDeletedFunction.svg:
413
414 2019-07-08  Devin Rousso  <drousso@apple.com>
415
416         Web Inspector: Debugger: there should be a different icon for URL breakpoints
417         https://bugs.webkit.org/show_bug.cgi?id=199550
418
419         Reviewed by Joseph Pecoraro.
420
421         Use the same (down|up) arrow icon for the Network Tab and the Network timeline.
422
423         * UserInterface/Views/URLBreakpointTreeElement.js:
424         (WI.URLBreakpointTreeElement):
425         * UserInterface/Views/URLBreakpointTreeElement.css:
426         (.breakpoint.url:not(.breakpoint-paused-icon) .icon): Added.
427
428         * UserInterface/Views/DebuggerSidebarPanel.js:
429         (WI.DebuggerSidebarPanel.prototype._addBreakpoint):
430         * UserInterface/Views/SourcesNavigationSidebarPanel.js:
431         (WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
432
433         * UserInterface/Images/URLBreakpoint.svg: Added.
434
435 2019-07-08  Devin Rousso  <drousso@apple.com>
436
437         Web Inspector: Timelines: CPU: the Duration string isn't localized
438         https://bugs.webkit.org/show_bug.cgi?id=199582
439         <rdar://problem/51698165>
440
441         Reviewed by Joseph Pecoraro.
442
443         * UserInterface/Views/CPUTimelineView.js:
444         (WI.CPUTimelineView.prototype._layoutEnergyChart):
445
446         * Localizations/en.lproj/localizedStrings.js:
447
448 2019-07-06  Nikita Vasilyev  <nvasilyev@apple.com>
449
450         Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
451         https://bugs.webkit.org/show_bug.cgi?id=199090
452         <rdar://problem/51965431>
453
454         Reviewed by Devin Rousso.
455
456         `}` gets added by WI.tokenizeCSSValue (called by SpreadsheetStyleProperty.prototype._renderValue)
457         when it encounters unbalanced quotes. Fix unbalanced quotes by re-rendering the value from the model,
458         not the DOM content.
459
460         * UserInterface/Views/SpreadsheetStyleProperty.js:
461         (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
462         For consistency, render property name from the model as well.
463
464 2019-07-05  Devin Rousso  <drousso@apple.com>
465
466         Web Inspector: current call frame indicator not visible in dark mode
467         https://bugs.webkit.org/show_bug.cgi?id=199047
468         <rdar://problem/51922895>
469
470         Reviewed by Timothy Hatcher.
471
472         * UserInterface/Views/CallFrameTreeElement.css:
473         (.tree-outline .item.call-frame .status > .status-image):
474         (.tree-outline .item.call-frame.selected .status > .status-image):
475         Replace the CSS variables used for `fill` with their actual color value (in `light` mode),
476         as the semantic "name" of the variable doesn't really match its usage. As an example, the
477         current call frame shouldn't rely on the value of `--border-color`, as it's not a "border".
478
479 2019-07-05  Matt Baker  <mattbaker@apple.com>
480
481         Web Inspector: Elements: use a CSS transition when showing/hiding DOM breakpoint gutter
482         https://bugs.webkit.org/show_bug.cgi?id=199411
483
484         Reviewed by Devin Rousso.
485
486         * UserInterface/Views/DOMTreeContentView.css:
487         (.content-view.dom-tree .tree-outline.dom):
488
489 2019-07-02  Devin Rousso  <drousso@apple.com>
490
491         Web Inspector: Elements: allow nodes to be copied and pasted
492         https://bugs.webkit.org/show_bug.cgi?id=199182
493
494         Reviewed by Matt Baker.
495
496         Copy is already supported, so there's nothing that needs to be done there.
497
498         Pasting is as simple as calling `insertAdjacentHTML("afterend", ...)` on the selected node.
499
500         * UserInterface/Base/Main.js:
501         (WI.contentLoaded):
502         (WI._paste): Added.
503
504         * UserInterface/Views/DOMTreeContentView.js:
505         (WI.DOMTreeContentView.prototype.handlePasteEvent): Added.
506
507 2019-07-02  Devin Rousso  <drousso@apple.com>
508
509         Web Inspector: DOM Debugger: descendant breakpoints should be able to be enabled/disabled/deleted from a collapsed parent
510         https://bugs.webkit.org/show_bug.cgi?id=199332
511
512         Reviewed by Matt Baker.
513
514         * UserInterface/Controllers/DOMDebuggerManager.js:
515         (WI.DOMDebuggerManager.prototype.get domBreakpoints):
516         (WI.DOMDebuggerManager.prototype.domBreakpointsForNode):
517         (WI.DOMDebuggerManager.prototype.domBreakpointsInSubtree): Added.
518         (WI.DOMDebuggerManager.prototype.removeDOMBreakpoint):
519         (WI.DOMDebuggerManager.prototype._detachDOMBreakpoint):
520         (WI.DOMDebuggerManager.prototype._detachBreakpointsForFrame):
521         (WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpointsForURL):
522         (WI.DOMDebuggerManager.prototype._resolveDOMBreakpoint):
523         Provide a way of getting a "summary" array of `DOMBreakpoint`s for all descendant nodes.
524         Rework the data structure for holding `DOMBreakpoint`s to use a `Multimap` so no duplicates
525         can be added (it uses a `Set` instead of an `Array`).
526
527         * UserInterface/Views/DOMTreeElement.js:
528         (WI.DOMTreeElement):
529         (WI.DOMTreeElement.prototype.get hasBreakpoint):
530         (WI.DOMTreeElement.prototype.set breakpointStatus):
531         (WI.DOMTreeElement.prototype.bindRevealDescendantBreakpointsMenuItemHandler): Added.
532         (WI.DOMTreeElement.prototype._subtreeBreakpointChanged): Added.
533         (WI.DOMTreeElement.prototype._updateBreakpointStatus):
534         (WI.DOMTreeElement.prototype._statusImageContextmenu):
535         (WI.DOMTreeElement.prototype.subtreeBreakpointCountDidChange): Deleted.
536         * UserInterface/Views/DOMTreeOutline.js:
537         (WI.DOMTreeOutline.prototype.populateContextMenu):
538         * UserInterface/Views/ContextMenuUtilities.js:
539         (WI.appendContextMenuItemsForDOMNode):
540         (WI.appendContextMenuItemsForDOMNodeBreakpoints):
541         Keep track of the actual descendant `DOMNodeTreeElement` that have breakpoints, rather than
542         just a count, so that the "Reveal Descendant Breakpoints" action is able to access them.
543         Change "Reveal Descendant Breakpoints" to reveal and select all descendant breakpoints
544         instead of just the first one.
545         Drive-by: don't remove specific (event) listener breakpoints when invoking the
546                   "Delete Descendant Breakpoints" action, as that's not obvious from the UI.
547
548         * UserInterface/Controllers/BreakpointPopoverController.js:
549         (WI.BreakpointPopoverController.prototype.appendContextMenuItems):
550         * UserInterface/Views/DOMBreakpointTreeElement.js:
551         (WI.DOMBreakpointTreeElement.prototype.populateContextMenu):
552         * UserInterface/Views/DOMNodeTreeElement.js:
553         (WI.DOMNodeTreeElement.prototype.populateContextMenu):
554         * UserInterface/Views/EventBreakpointTreeElement.js:
555         (WI.EventBreakpointTreeElement.prototype.populateContextMenu):
556         * UserInterface/Views/URLBreakpointTreeElement.js:
557         (WI.URLBreakpointTreeElement.prototype.populateContextMenu):
558         Remove the separator before "Delete Breakpoint" so all breakpoint actions are in the same section.
559
560         * Localizations/en.lproj/localizedStrings.js:
561         * UserInterface/Base/Multimap.js:
562         (Multimap.prototype.get size): Added.
563
564 2019-07-02  Matt Baker  <mattbaker@apple.com>
565
566         REGRESSION (r238563): Web Inspector: Selection is erratic when holding Up/Down on Network Table
567         https://bugs.webkit.org/show_bug.cgi?id=193841
568         <rdar://problem/47559124>
569
570         Reviewed by Devin Rousso.
571
572         Selecting and revealing a row after reloading Table data, but before the
573         layout that populates visible rows, could cause the Table to always be
574         scrolled so that the revealed row is first.
575
576         This patch fixes `revealRow` by calculating the position of the row being
577         revealed in the absence of its DOM element, so that the Table is only
578         scrolled when necessary.
579
580         * UserInterface/Views/Table.js:
581         (WI.Table.prototype.revealRow):
582         (WI.Table.prototype._resizeColumnsAndFiller):
583         Drive-by fix: use realOffsetWidth for consistency.
584         (WI.Table.prototype._updateVisibleRows):
585         (WI.Table.prototype._calculateOffsetHeight):
586         (WI.Table.prototype._calculateScrollTop):
587
588 2019-07-02  Devin Rousso  <drousso@apple.com>
589
590         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
591         https://bugs.webkit.org/show_bug.cgi?id=198956
592
593         Reviewed by Matt Baker.
594
595         * UserInterface/Base/Main.js:
596         (WI.reset): Added.
597
598         * UserInterface/Views/SettingsTabContentView.js:
599         (WI.SettingsTabContentView.prototype._createDebugSettingsView):
600
601 2019-07-02  Devin Rousso  <drousso@apple.com>
602
603         Web Inspector: Audit: missing demo audits for WebInspectorAudit functions
604         https://bugs.webkit.org/show_bug.cgi?id=198719
605
606         Reviewed by Matt Baker.
607
608         Other than the LayoutTests, there's no way to see an example of the functionality of many of
609         the exposed `WebInspectorAudit` functions. There should be a demo audit for every exposed
610         function so they're more discoverable.
611
612         * UserInterface/Controllers/AuditManager.js:
613         (WI.AuditManager.prototype._addDefaultTests):
614         (WI.AuditManager.prototype._addDefaultTests.removeWhitespace): Added.
615         Move all demo audit test functions to be actual JavaScript functions, which are then
616         stringified and stripped of unnecessary white-space.
617
618         * Localizations/en.lproj/localizedStrings.js:
619
620 2019-07-01  Devin Rousso  <drousso@apple.com>
621
622         Web Inspector: REGRESSION(r245498): Timelines: CPU: discontinuities are filled in by the next record
623         https://bugs.webkit.org/show_bug.cgi?id=198927
624
625         Reviewed by Matt Baker.
626
627         * UserInterface/Controllers/TimelineManager.js:
628         (WI.TimelineManager.prototype.capturingStarted):
629         (WI.TimelineManager.prototype.capturingStopped):
630         * UserInterface/Models/TimelineRecording.js:
631         (WI.TimelineRecording):
632         (WI.TimelineRecording.prototype.start):
633         (WI.TimelineRecording.prototype.capturingStarted): Added.
634         (WI.TimelineRecording.prototype.capturingStopped): Added.
635         (WI.TimelineRecording.prototype.reset):
636         (WI.TimelineRecording.prototype.addRecord):
637         (WI.TimelineRecording.prototype.discontinuitiesInTimeRange):
638         (WI.TimelineRecording.prototype.addDiscontinuity): Deleted.
639         Notify the `TimelineRecording` when capturing has started/stopped.
640         Adjust the first record after a discontinuity to have it's `startTime` match the `endTime`
641         of the most recent discontinuity.
642
643         * UserInterface/Models/Timeline.js:
644         (WI.Timeline.prototype.addRecord):
645         * UserInterface/Models/CPUTimeline.js:
646         (WI.CPUTimeline.prototype.addRecord):
647         * UserInterface/Models/CPUTimelineRecord.js:
648         (WI.CPUTimelineRecord.prototype.adjustStartTime): Added.
649         (WI.CPUTimelineRecord.prototype.adjustStartTimeToLastRecord): Deleted.
650         * UserInterface/Models/MemoryTimeline.js:
651         (WI.MemoryTimeline.prototype.addRecord):
652         * UserInterface/Models/MemoryTimelineRecord.js:
653         (WI.MemoryTimelineRecord.prototype.adjustStartTime): Added.
654         (WI.MemoryTimelineRecord.prototype.adjustStartTimeToLastRecord): Deleted.
655         * UserInterface/Models/NetworkTimeline.js:
656         (WI.NetworkTimeline.prototype.addRecord):
657
658         * UserInterface/Views/CPUTimelineView.js:
659         (WI.CPUTimelineView.prototype.layout):
660         * UserInterface/Views/MemoryTimelineOverviewGraph.js:
661         (WI.MemoryTimelineOverviewGraph.prototype.layout):
662         * UserInterface/Views/MemoryTimelineView.js:
663         (WI.MemoryTimelineView.prototype.layout):
664         Include discontinuities that exactly match the start/end time of the record immediately
665         before/after the discontinuity.
666
667         * UserInterface/Views/TimelineRecordingContentView.js:
668         (WI.TimelineRecordingContentView):
669         (WI.TimelineRecordingContentView.prototype._handleTimelineCapturingStateChanged):
670         (WI.TimelineRecordingContentView.prototype._recordingReset):
671         Move the logic for handling discontinuity start/end times to the `TimelineRecording`.
672
673         * UserInterface/Base/Utilities.js:
674
675 2019-06-29  Nikita Vasilyev  <nvasilyev@apple.com>
676
677         Web Inspector: Remove trailing white-space
678         https://bugs.webkit.org/show_bug.cgi?id=199346
679
680         Reviewed by Matt Baker.
681
682         * UserInterface/Controllers/NetworkManager.js:
683         (WI.NetworkManager.prototype._initiatorCallFramesFromPayload):
684         * UserInterface/Images/Import.svg:
685         * UserInterface/Views/CanvasOverviewContentView.css:
686         (.navigation-bar > .item.canvas-recording-auto-capture > label > input):
687         * UserInterface/Views/DataGrid.css:
688         (.data-grid .resizer):
689         * UserInterface/Views/DatabaseContentView.css:
690         (.storage-view):
691         * UserInterface/Views/GoToLineDialog.css:
692         (@media (prefers-color-scheme: dark)):
693         * UserInterface/Views/GradientSlider.css:
694         (.gradient-slider > .add-area):
695         (.gradient-slider-knob > :matches(img, div)):
696         * UserInterface/Views/ResourceDetailsSection.css:
697         * UserInterface/Views/ScrubberNavigationItem.css:
698         (.navigation-bar .item.scrubber > input[disabled]):
699         * UserInterface/Views/SourceCodeTextEditor.css:
700         (.popover .expandable):
701         * UserInterface/Views/TimelineRecordBar.css:
702         (.timeline-record-bar.timeline-record-type-script.garbage-collected > .segment,):
703         * UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:
704         (HeapSnapshotWorker.prototype.createSnapshot):
705
706 2019-06-29  Nikita Vasilyev  <nvasilyev@apple.com>
707
708         Remove duplicate "Private" section and fix white space
709
710         Unreviewed code style fix.
711
712         * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
713         (WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout):
714
715 2019-06-27  Beth Dakin  <bdakin@apple.com>
716
717         Upstream use of MACCATALYST
718         https://bugs.webkit.org/show_bug.cgi?id=199245
719         rdar://problem/51687723
720
721         Reviewed by Tim Horton.
722
723         * Configurations/Base.xcconfig:
724         * Configurations/SDKVariant.xcconfig:
725
726 2019-06-27  Devin Rousso  <drousso@apple.com>
727
728         Web Inspector: throw an error if console.count/console.countReset is called with an object that throws an error from toString
729         https://bugs.webkit.org/show_bug.cgi?id=199252
730
731         Reviewed by Joseph Pecoraro.
732
733         Add entries for `console.countReset` and `console.timeLog`.
734
735         Rename `title` to `label` for `console.time`, `console.timeLog`, and `console.timeEnd` to
736         better match the spec.
737
738         * UserInterface/Models/NativeFunctionParameters.js:
739
740 2019-06-26  Joseph Pecoraro  <pecoraro@apple.com>
741
742         Web Inspector: Update legacy backend commands after enum name change
743         https://bugs.webkit.org/show_bug.cgi?id=199250
744
745         Reviewed by Devin Rousso.
746
747         * UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
748         * UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:
749         * UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js:
750
751 2019-06-26  Devin Rousso  <drousso@apple.com>
752
753         Web Inspector: REGRESSION: Elements: the forced pseudo-class indicator isn't visible when hovering
754         https://bugs.webkit.org/show_bug.cgi?id=199166
755
756         Reviewed by Matt Baker.
757
758         Make the pseudo-class indicator into its own element instead of being a `::before`.
759
760         * UserInterface/Views/DOMTreeElement.js:
761         (WI.DOMTreeElement):
762         (WI.DOMTreeElement.prototype.updateSelectionArea):
763         (WI.DOMTreeElement.prototype.updateTitle):
764         (WI.DOMTreeElement.prototype._updatePseudoClassIndicator): Added.
765         (WI.DOMTreeElement.prototype.get pseudoClassesEnabled): Deleted.
766         (WI.DOMTreeElement.prototype._nodePseudoClassesDidChange): Deleted.
767
768         * UserInterface/Views/DOMTreeOutline.css:
769         (.tree-outline.dom):
770         (.tree-outline.dom li .pseudo-class-indicator): Added.
771         (body[dir=ltr] .tree-outline.dom li .pseudo-class-indicator): Added.
772         (body[dir=rtl] .tree-outline.dom li .pseudo-class-indicator): Added.
773         (.tree-outline.dom:focus li.selected .pseudo-class-indicator): Added.
774         (.tree-outline.dom li.pseudo-class-enabled > .selection-area::before): Deleted.
775         (body[dir=ltr] .tree-outline.dom li.pseudo-class-enabled > .selection-area::before): Deleted.
776         (body[dir=rtl] .tree-outline.dom li.pseudo-class-enabled > .selection-area::before): Deleted.
777         (.tree-outline.dom:focus li.selected.pseudo-class-enabled > .selection-area::before): Deleted.
778
779         * UserInterface/Views/FormattedValue.css:
780         (.formatted-node > .tree-outline.dom):
781         Adjust the indent of any `DOMTreeOutline` so there's more room for the pseudo-class
782         indicator, such as in the Console.
783
784 2019-06-25  Matt Baker  <mattbaker@apple.com>
785
786         Web Inspector: Elements: show shadow DOM by default
787         https://bugs.webkit.org/show_bug.cgi?id=199128
788
789         Reviewed by Devin Rousso.
790
791         * UserInterface/Base/Setting.js:
792
793         * UserInterface/Test/Test.js:
794         (WI.loaded):
795         Overriding the default value isn't necessary since the default is now true.
796
797 2019-06-25  Nikita Vasilyev  <nvasilyev@apple.com>
798
799         REGRESSION(r246621): Web Inspector: Styles: property may get removed when editing after deleting value
800         https://bugs.webkit.org/show_bug.cgi?id=199143
801         <rdar://problem/52042815>
802
803         Reviewed by Matt Baker.
804
805         r246621 affected when WI.CSSStyleDeclaration.Event.PropertiesChanged event is fired, which caused
806         SpreadsheetCSSStyleDeclarationEditor to possibly enter a state when `focused` property is
807         incorrectly set to false.
808
809         * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
810         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyRemoved): Removed.
811         (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyWillRemove): Added.
812         Renamed from "removed" to "willRemove" since we need to call it before the property DOM element
813         is detached from the document.
814
815         * UserInterface/Views/SpreadsheetStyleProperty.js:
816         (WI.SpreadsheetStyleProperty.prototype.remove):
817         Don't set focused to false when the removed property wasn't focused.
818         This code need to exist because removing focused element from the DOM doesn't trigger blur event.
819
820 2019-06-25  Joseph Pecoraro  <pecoraro@apple.com>
821
822         Web Inspector: Implement console.timeLog
823         https://bugs.webkit.org/show_bug.cgi?id=199184
824
825         Reviewed by Devin Rousso.
826
827         * UserInterface/Views/ConsoleMessageView.js:
828         (WI.ConsoleMessageView.prototype._appendMessageTextAndArguments):
829         Time messages (like timeLog) do not include their messageText
830         in their parameters list. So to behave more like normal logs
831         build a parameter list that includes it at the front.
832
833 2019-06-23  Matt Baker  <mattbaker@apple.com>
834
835         Web Inspector: REGRESSION (r246684): Dark Mode: dashboard buttons should have no background
836         https://bugs.webkit.org/show_bug.cgi?id=199136
837         <rdar://problem/52035798>
838
839         Reviewed by Joseph Pecoraro.
840
841         * UserInterface/Views/DefaultDashboardView.css:
842         (@media (prefers-color-scheme: dark)):
843         (.toolbar .dashboard .item.button,):
844
845 2019-06-23  Nikita Vasilyev  <nvasilyev@apple.com>
846
847         Web Inspector: Styles: show green highlight for newly added properties only when name and value are present
848         https://bugs.webkit.org/show_bug.cgi?id=199131
849
850         Reviewed by Matt Baker.
851
852         * UserInterface/Views/SpreadsheetStyleProperty.js:
853         (WI.SpreadsheetStyleProperty.prototype.updateStatus):
854
855 2019-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
856
857         REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule
858         https://bugs.webkit.org/show_bug.cgi?id=199125
859         <rdar://problem/52011182>
860
861         Reviewed by Matt Baker.
862
863         Since SpreadsheetSelectorField's focus handler was removed in r241980, focusing on the selector element
864         doesn't start editing it.
865
866         * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
867         (WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):
868
869 2019-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
870
871         Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values
872         https://bugs.webkit.org/show_bug.cgi?id=199090
873         <rdar://problem/51965431>
874
875         Reviewed by Matt Baker.
876
877         * UserInterface/Views/SpreadsheetStyleProperty.js:
878         (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
879         Unbalanced quotes and parenthesis are fixed inside of CSSProperty's rawValue setter.
880         Render the value from the model, not the view.
881
882 2019-06-21  Matt Baker  <mattbaker@apple.com>
883
884         Web Inspector: remove unused DataGrid style .force-focus
885         https://bugs.webkit.org/show_bug.cgi?id=199112
886         <rdar://problem/51993412>
887
888         Reviewed by Timothy Hatcher.
889
890         * UserInterface/Views/HeapAllocationsTimelineView.css:
891         (.timeline-view.heap-allocations > .data-grid:not(:focus) tr.selected.invalid):
892         (.timeline-view.heap-allocations > .data-grid:not(:focus, .force-focus) tr.selected.invalid): Deleted.
893
894         * UserInterface/Views/ResourceTreeElement.css:
895         (.item.resource.resource-type-websocket:not(.selected) .status .ready-state.open,):
896         (.item.resource.resource-type-websocket:not(.selected) .status .ready-state.connecting,):
897         Missed in https://bugs.webkit.org/show_bug.cgi?id=190480.
898
899 2019-06-21  Matt Baker  <mattbaker@apple.com>
900
901         Web Inspector: remove .legacy-mac/.latest-mac CSS classes, standardize on .latest-mac UI
902         https://bugs.webkit.org/show_bug.cgi?id=199109
903         <rdar://problem/51991129>
904
905         Reviewed by Timothy Hatcher.
906
907         Drop legacy macOS version support from Web Inspector UI.
908
909         * UserInterface/Base/Main.js:
910
911         * UserInterface/Views/DefaultDashboardView.css:
912         (@media (prefers-color-scheme: dark)):
913         (body.latest-mac .toolbar .dashboard .item.button): Deleted.
914
915         * UserInterface/Views/Toolbar.css:
916         (.toolbar):
917         (.toolbar .item.button,):
918         (.toolbar .search-bar > input[type="search"]):
919         (.toolbar .search-bar > input[type="search"]:focus):
920         (@media (-webkit-min-device-pixel-ratio: 2)):
921         (.toolbar .item.button:active):
922         (body.window-inactive .toolbar .item.button,):
923         (@media (prefers-color-scheme: dark)):
924         (.toolbar .search-bar > input[type="search"]::placeholder):
925         (body.window-inactive .toolbar .search-bar > input[type="search"]::placeholder):
926         (body.window-inactive .toolbar .search-bar > input[type="search"]::-webkit-search-results-button):
927         (.toolbar .dashboard-container):
928         (body .toolbar): Deleted.
929         (body.legacy-mac .toolbar .item.button,): Deleted.
930         (body.legacy-mac .toolbar .search-bar > input[type="search"]): Deleted.
931         (body.legacy-mac .toolbar .search-bar > input[type="search"]:focus): Deleted.
932         (body.legacy-mac .toolbar .item.button:active): Deleted.
933         (body.window-inactive.legacy-mac .toolbar .item.button,): Deleted.
934         (body.latest-mac .toolbar .item.button,): Deleted.
935         (body.latest-mac .toolbar .search-bar > input[type="search"]): Deleted.
936         (body.latest-mac .toolbar .search-bar > input[type="search"]:focus): Deleted.
937         (body.latest-mac .toolbar .item.button:active): Deleted.
938         (body.latest-mac.window-inactive .toolbar .item.button,): Deleted.
939         (body.latest-mac .toolbar .search-bar > input[type="search"]::placeholder): Deleted.
940         (body.latest-mac.window-inactive .toolbar .search-bar > input[type="search"]::placeholder): Deleted.
941         (body.latest-mac.window-inactive .toolbar .search-bar > input[type="search"]::-webkit-search-results-button): Deleted.
942         (body.latest-mac .toolbar .dashboard-container): Deleted.
943
944 2019-06-20  Matt Baker  <mattbaker@apple.com>
945
946         Web Inspector: rename shadowRootPushed parameter to match protocol
947         https://bugs.webkit.org/show_bug.cgi?id=199098
948
949         Reviewed by Devin Rousso.
950
951         * UserInterface/Protocol/DOMObserver.js:
952         (WI.DOMObserver.prototype.shadowRootPushed):
953
954 2019-06-20  Devin Rousso  <drousso@apple.com>
955
956         Web Inspector: Error "null is not an object (evaluating 'syntaxTree.containersOfPosition')" when setting a breakpoint
957         https://bugs.webkit.org/show_bug.cgi?id=199082
958
959         Reviewed by Matt Baker.
960
961         * UserInterface/Views/SourceCodeTextEditor.js:
962         (WI.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
963         The script syntax tree may be fetched even if the resource hasn't finished parsing (or had
964         a syntax error), so it's possible for it to be `null`.
965
966 2019-06-20  Devin Rousso  <drousso@apple.com>
967
968         Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
969         https://bugs.webkit.org/show_bug.cgi?id=199022
970
971         Reviewed by Darin Adler.
972
973         * UserInterface/Views/TabBar.css:
974         (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover):
975         (@media not (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon):
976         (@media (prefers-color-scheme: dark) .tab-bar):
977         (@media (prefers-color-scheme: dark) .tab-bar > .item):
978         (@media (prefers-color-scheme: dark) .tab-bar > .item:not(.disabled).selected):
979         (@media (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected):hover):
980         (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar):
981         (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item):
982         (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item.selected):
983
984         * UserInterface/Views/Toolbar.css:
985         (@media (prefers-color-scheme: dark) body .toolbar):
986
987 2019-06-20  Devin Rousso  <drousso@apple.com>
988
989         Web Inspector: Debugger: setting a breakpoint on a non-JavaScript line should immediately show as unresolved
990         https://bugs.webkit.org/show_bug.cgi?id=199033
991
992         Reviewed by Matt Baker.
993
994         Remove the `shouldSpeculativelyResolve` parameter, as it was resolving breakpoints even in
995         the case that there were no resolved locations for the given breakpoint.
996
997         In the case that there are resolved locations, the breakpoint would've already been resolved
998         by the time that `shouldSpeculativelyResolve` would've taken effect, so it's unnecessary.
999
1000         This parameter was only used when setting a breakpoint from a `SourceCodeTextEditor` gutter.
1001
1002         * UserInterface/Controllers/DebuggerManager.js:
1003         (WI.DebuggerManager.prototype.addBreakpoint):
1004         (WI.DebuggerManager.prototype._setBreakpoint):
1005         (WI.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
1006
1007         * UserInterface/Views/SourceCodeTextEditor.js:
1008         (WI.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
1009
1010 2019-06-20  Devin Rousso  <drousso@apple.com>
1011
1012         Web Inspector: Edit -> Tag doesn't do anything for html, head, and body elements
1013         https://bugs.webkit.org/show_bug.cgi?id=199052
1014         <rdar://problem/51923906>
1015
1016         Reviewed by Matt Baker.
1017
1018         * UserInterface/Views/DOMTreeElement.js:
1019         (WI.DOMTreeElement.prototype.populateDOMNodeContextMenu):
1020          - Don't show an "Edit > Tag" for <html>, <head>, and <body> nodes
1021          - Disable any "Edit" submenu item if it's target is already being edited
1022          - Prevent "Add" submenu items from being shown for text nodes
1023
1024 2019-06-19  Devin Rousso  <drousso@apple.com>
1025
1026         Web Inspector: REGRESSION: Debugger: current call frame indicator isn't vertically centered
1027         https://bugs.webkit.org/show_bug.cgi?id=199015
1028
1029         Reviewed by Matt Baker.
1030
1031         * UserInterface/Views/CallFrameTreeElement.css:
1032         (.tree-outline .item.call-frame .status):
1033
1034 2019-06-19  Nikita Vasilyev  <nvasilyev@apple.com>
1035
1036         REGRESSION(r240946): Web Inspector: Styles: Pasting multiple properties has issues
1037         https://bugs.webkit.org/show_bug.cgi?id=198505
1038         <rdar://problem/51374780>
1039
1040         Reviewed by Matt Baker.
1041
1042         Since r240946, setting WI.CSSStyleDeclaration.prototype.text updates the text immediately.
1043         When WI.CSSStyleDeclaration.prototype.update gets called after setting text, it exits early
1044         without firing WI.CSSStyleDeclaration.Event.PropertiesChanged.
1045
1046         * UserInterface/Models/CSSStyleDeclaration.js:
1047         (WI.CSSStyleDeclaration):
1048         (WI.CSSStyleDeclaration.prototype.set text):
1049
1050 2019-06-19  Matt Baker  <mattbaker@apple.com>
1051
1052         Web Inspector: Remove unused _pendingFilter from NetworkTableContentView
1053         https://bugs.webkit.org/show_bug.cgi?id=199026
1054
1055         Reviewed by Devin Rousso.
1056
1057         This flag is no longer set as of https://trac.webkit.org/changeset/225895.
1058
1059         * UserInterface/Views/NetworkTableContentView.js:
1060         (WI.NetworkTableContentView):
1061         (WI.NetworkTableContentView.prototype._processPendingEntries):
1062
1063 2019-06-19  Devin Rousso  <drousso@apple.com>
1064
1065         Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'sourceCodePosition.lineNumber')
1066         https://bugs.webkit.org/show_bug.cgi?id=199019
1067
1068         Reviewed by Matt Baker.
1069
1070         * UserInterface/Base/Main.js:
1071         (WI.linkifyLocation):
1072
1073 2019-06-19  Zhifei Fang  <zhifei_fang@apple.com>
1074
1075         Correct the error object link color in dark mode.
1076         https://bugs.webkit.org/show_bug.cgi?id=198033
1077
1078         Reviewed by Devin Rousso.
1079
1080         * UserInterface/Views/ErrorObjectView.css:
1081         (@media (prefers-dark-interface)):
1082         (.error-object-link-container):
1083
1084 2019-06-18  Devin Rousso  <drousso@apple.com>
1085
1086         Web Inspector: Network: detail view shouldn't stay open when the related entry is removed
1087         https://bugs.webkit.org/show_bug.cgi?id=198951
1088
1089         Reviewed by Joseph Pecoraro.
1090
1091         * UserInterface/Views/NetworkTableContentView.js:
1092         (WI.NetworkTableContentView.prototype._mainResourceDidChange):
1093         Hide the detail view if the main resource changes and we aren't preserving the log.
1094
1095         * UserInterface/Views/Table.js:
1096         (WI.Table.prototype.reloadVisibleColumnCells):
1097         Only attempt to populate cells for rows that the `_dataSource` actually has. Without this,
1098         the `_delegate` may be asked to populate a cell for a row it doesn't have, which would error.
1099
1100 2019-06-18  Devin Rousso  <drousso@apple.com>
1101
1102         Web Inspector: parseQueryParameters fails to successfully parse query parameter values that contain "="
1103         https://bugs.webkit.org/show_bug.cgi?id=198971
1104         <rdar://problem/51852782>
1105
1106         Reviewed by Joseph Pecoraro.
1107
1108         * UserInterface/Base/URLUtilities.js:
1109         (parseQueryString):
1110
1111 2019-06-18  Devin Rousso  <drousso@apple.com>
1112
1113         Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list
1114         https://bugs.webkit.org/show_bug.cgi?id=198941
1115
1116         Reviewed by Joseph Pecoraro.
1117
1118         Since heap snapshot records can be added at any time, including when not actively recording,
1119         when the "Entire Recording" range is selected, make sure to set the `filterEndTime` to be an
1120         effectively infinite number so that records added later aren't filtered out.
1121
1122         This isn't done for other timeline views as they may have graphs that don't expect to render
1123         from time 0 till infinity, not to mention being unable to add records when not recording.
1124
1125         * UserInterface/Views/TimelineRecordingContentView.js:
1126         (WI.TimelineRecordingContentView.prototype._updateTimelineViewTimes):
1127
1128 2019-06-18  Devin Rousso  <drousso@apple.com>
1129
1130         Web Inspector: REGRESSION: Canvas: cannot select saved recordings
1131         https://bugs.webkit.org/show_bug.cgi?id=198953
1132
1133         Reviewed by Joseph Pecoraro.
1134
1135         * UserInterface/Views/TreeElement.js:
1136         (WI.TreeElement.treeElementToggled):
1137         Don't early return if the `TreeElement` isn't `selectable` as the owner `TreeOutline` may
1138         want to dispatch an event that it was clicked.
1139
1140 2019-06-18  Devin Rousso  <drousso@apple.com>
1141
1142         Web Inspector: Canvas: the initial state should be selected when processing a new/imported recording if the navigation sidebar is collapsed
1143         https://bugs.webkit.org/show_bug.cgi?id=198952
1144
1145         Reviewed by Joseph Pecoraro.
1146
1147         Prevent any content from being generated until `initialLayout` is called, as otherwise it's
1148         possible for the `CanvasNavigationSidebar` to update the current action index before the
1149         preview element has been created, which would throw an error.
1150
1151         * UserInterface/Views/RecordingContentView.js:
1152         (WI.RecordingContentView.prototype.updateActionIndex):
1153         (WI.RecordingContentView.prototype.initialLayout):
1154         (WI.RecordingContentView.prototype._updateSliderValue):
1155         (WI.RecordingContentView.prototype._handleRecordingProcessedAction):
1156         Drive-by: update the slider max each time the selected action index is changed.
1157
1158 2019-06-18  Devin Rousso  <drousso@apple.com>
1159
1160         Web Inspector: Canvas: imported recordings aren't selectable from the overview if there are no canvases in the page
1161         https://bugs.webkit.org/show_bug.cgi?id=198955
1162
1163         Reviewed by Joseph Pecoraro.
1164
1165         * UserInterface/Views/CanvasOverviewContentView.js:
1166         (WI.CanvasOverviewContentView.prototype._addSavedRecording):
1167         Hide the content placeholder when a recording is imported. It won't be shown again because
1168         the `subviews` list will never be empty, as there's no way to remove an imported recording.
1169
1170         * UserInterface/Views/CollectionContentView.js:
1171         (WI.CollectionContentView.prototype.addContentViewForItem):
1172         (WI.CollectionContentView.prototype.removeContentViewForItem):
1173         (WI.CollectionContentView.prototype.showContentPlaceholder): Added.
1174         (WI.CollectionContentView.prototype.hideContentPlaceholder): Added.
1175         (WI.CollectionContentView.prototype.initialLayout):
1176         (WI.CollectionContentView.prototype._selectItem):
1177         (WI.CollectionContentView.prototype._showContentPlaceholder): Deleted.
1178         (WI.CollectionContentView.prototype._hideContentPlaceholder): Deleted.
1179         Make `showContentPlaceholder`/`hideContentPlaceholder` protected for any subclasses to call.
1180
1181 2019-06-17  Matt Baker  <mattbaker@apple.com>
1182
1183         Web Inspector: Elements: remove ellipses from "Break on" context menu item title
1184         https://bugs.webkit.org/show_bug.cgi?id=198944
1185
1186         Reviewed by Devin Rousso.
1187
1188         Update context menu title to comply with Apple HI guidelines.
1189
1190         * Localizations/en.lproj/localizedStrings.js:
1191         * UserInterface/Views/ContextMenuUtilities.js:
1192
1193 2019-06-17  Devin Rousso  <drousso@apple.com>
1194
1195         Web Inspector: Debugger: adding a DOM/Event/URL breakpoint should enable breakpoints
1196         https://bugs.webkit.org/show_bug.cgi?id=198932
1197
1198         Reviewed by Matt Baker.
1199
1200         Match the behavior of JavaScript breakpoints, which enable breakpoints globally when a new
1201         breakpoint is set or an existing breakpoint is enabled.
1202
1203         This avoids the situation where setting a DOM breakpoint or a specific event listener
1204         breakpoint appears to not "work" because breakpoints are globally disabled. There is no
1205         "breakpoints disabled" banner in the Elements tab, so the user could be completely unaware
1206         of this, and therefore be confused as to why these breakpoints aren't being hit.
1207
1208         * UserInterface/Controllers/DOMManager.js:
1209         (WI.DOMManager.prototype._updateEventBreakpoint):
1210
1211         * UserInterface/Controllers/DOMDebuggerManager.js:
1212         (WI.DOMDebuggerManager.prototype._updateDOMBreakpoint):
1213         (WI.DOMDebuggerManager.prototype._updateEventBreakpoint):
1214         (WI.DOMDebuggerManager.prototype._updateURLBreakpoint):
1215
1216 2019-06-17  Devin Rousso  <drousso@apple.com>
1217
1218         Web Inspector: Sources: remove extra space above Breakpoints section when breakpoints are disabled
1219         https://bugs.webkit.org/show_bug.cgi?id=198933
1220
1221         Reviewed by Matt Baker.
1222
1223         * UserInterface/Views/DebuggerSidebarPanel.css:
1224         (.sidebar > .panel.navigation.debugger .warning-banner):
1225         * UserInterface/Views/SourcesNavigationSidebarPanel.css:
1226         (.sidebar > .panel.navigation.sources > .content > .warning-banner):
1227
1228 2019-06-17  Devin Rousso  <drousso@apple.com>
1229
1230         Web Inspector: Settings: split the General panel into sub panels so it's less crowded
1231         https://bugs.webkit.org/show_bug.cgi?id=198803
1232
1233         Reviewed by Timothy Hatcher.
1234
1235         * UserInterface/Views/SettingsTabContentView.js:
1236         (WI.SettingsTabContentView.prototype.initialLayout):
1237         (WI.SettingsTabContentView.prototype._createGeneralSettingsView):
1238         Many of the settings in General only affect a specific part of Web Inspector, and therefore
1239         aren't really "general".
1240
1241         (WI.SettingsTabContentView.prototype._createElementsSettingsView): Added.
1242          - Element Selection
1243          - CSS Changes
1244
1245         (WI.SettingsTabContentView.prototype._createSourcesSettingsView): Added.
1246          - Debugger
1247          - Source Maps
1248
1249         (WI.SettingsTabContentView.prototype._createConsoleSettingsView): Added.
1250          - Traces (renamed from "Console")
1251          - WebRTC Logging
1252          - Media Logging
1253          - MSE Logging
1254
1255         * Localizations/en.lproj/localizedStrings.js:
1256
1257 2019-06-17  Devin Rousso  <drousso@apple.com>
1258
1259         Web Inspector: Sources: the Inspector Style Sheet is missing when grouped by path
1260         https://bugs.webkit.org/show_bug.cgi?id=198860
1261
1262         Reviewed by Timothy Hatcher.
1263
1264         * UserInterface/Controllers/CSSManager.js:
1265         (WI.CSSManager.prototype.get styleSheets):
1266         (WI.CSSManager.prototype.inspectorStyleSheetsForFrame):
1267         (WI.CSSManager.prototype.preferredInspectorStyleSheetForFrame):
1268         (WI.CSSManager.prototype._inspectorStyleSheetsForFrame): Deleted.
1269         Expose a way to fetch all inspector stylesheets for a given frame.
1270         Make sure to associate inspector stylesheets with their frame.
1271
1272         * UserInterface/Views/SourcesNavigationSidebarPanel.js:
1273         (WI.SourcesNavigationSidebarPanel.prototype._compareTreeElements):
1274         (WI.SourcesNavigationSidebarPanel.prototype._addResourcesRecursivelyForFrame):
1275         (WI.SourcesNavigationSidebarPanel.prototype._handleCSSStyleSheetAdded):
1276         Add paths for inspector stylesheet creation/fetching when grouping by path.
1277         Sort inspector stylesheets as the first item of an origin/frame when grouping by path.
1278
1279 2019-06-17  Jamal Nasser  <jamaln@mail.com>
1280
1281         Web Inspector: Go To Line dialog is white when in Dark Mode
1282         https://bugs.webkit.org/show_bug.cgi?id=198596
1283
1284         Reviewed by Timothy Hatcher.
1285
1286         * UserInterface/Views/GoToLineDialog.css:
1287         (@media (prefers-color-scheme: dark)):
1288         (.go-to-line-dialog):
1289         (.go-to-line-dialog > div > input):
1290         (.go-to-line-dialog > div > input::placeholder):
1291         (.go-to-line-dialog > div::before):
1292
1293 2019-06-17  Devin Rousso  <drousso@apple.com>
1294
1295         Web Inspector: Sources: searching doesn't use the case sensitive or regex global settings
1296         https://bugs.webkit.org/show_bug.cgi?id=198897
1297
1298         Reviewed by Joseph Pecoraro.
1299
1300         * UserInterface/Views/SourceCodeTextEditor.js:
1301         (WI.SourceCodeTextEditor.prototype.customPerformSearch):
1302
1303 2019-06-13  Devin Rousso  <drousso@apple.com>
1304
1305         Web Inspector: REGRESSION(r246178): extra spaces added in at-rules when formatting CSS
1306         https://bugs.webkit.org/show_bug.cgi?id=198806
1307
1308         Reviewed by Joseph Pecoraro.
1309
1310         * UserInterface/Workers/Formatter/CSSFormatter.js:
1311         (CSSFormatter.prototype._format):
1312         Add more specific tests for at-rules, and add/remove whitespace depending on the type of
1313         at-rule (e.g. `@supports` vs `@media`), as well as where the scanner is in the parameters of
1314         the at at-rule (e.g. `@supports |` vs `@media (|`).
1315
1316         * UserInterface/Workers/Formatter/FormatterContentBuilder.js:
1317         (FormatterContentBuilder):
1318         (FormatterContentBuilder.prototype.get lastToken): Added.
1319         (FormatterContentBuilder.prototype.get currentLine):
1320         (FormatterContentBuilder.prototype.removeLastNewline):
1321         (FormatterContentBuilder.prototype.removeLastWhitespace):
1322         (FormatterContentBuilder.prototype._popFormattedContent):
1323         (FormatterContentBuilder.prototype._append):
1324         Update `lastTokenWasNewline` and `lastTokenWasWhitespace` when removing newlines/whitespace.
1325         Memoize the `currentLine` so it's less expensive to re-fetch.
1326
1327 2019-06-13  Devin Rousso  <drousso@apple.com>
1328
1329         Web Inspector: Settings: indent type and size settings aren't respected everywhere
1330         https://bugs.webkit.org/show_bug.cgi?id=198804
1331
1332         Reviewed by Timothy Hatcher.
1333
1334         * UserInterface/Views/CodeMirrorEditor.js:
1335         (WI.CodeMirrorEditor.create):
1336         When creating a `CodeMirror` instance, default to using the global `Setting`s as the options.
1337         If an override is specified in `options`, it will take precedence and the `CodeMirror` will
1338         ignore any changes to the `Setting` as well.
1339
1340         * UserInterface/Views/TextEditor.js:
1341         (WI.TextEditor):
1342         (WI.TextEditor.prototype.close): Deleted.
1343
1344         * UserInterface/Views/AuditTestCaseContentView.js:
1345         (WI.AuditTestCaseContentView.prototype.layout):
1346         * UserInterface/Views/BreakpointActionView.js:
1347         (WI.BreakpointActionView.prototype._updateBody):
1348         * UserInterface/Views/ConsolePrompt.js:
1349         (WI.ConsolePrompt):
1350         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1351         (WI.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
1352         Remove overrides that aren't necessary for `CodeMirror` to fit in the container element:
1353          - `showWhitespaceCharacters`
1354          - `indentWithTabs`
1355          - `indentUnit`
1356
1357         * UserInterface/Views/SourceCodeTextEditor.js:
1358         (WI.SourceCodeTextEditor.prototype.close):
1359         * UserInterface/Views/ShaderProgramContentView.js:
1360         (WI.ShaderProgramContentView.prototype.closed): Deleted.
1361         * UserInterface/Views/TextContentView.js:
1362         (WI.TextContentView.prototype.closed): Deleted.
1363         * UserInterface/Views/TextResourceContentView.js:
1364         (WI.TextResourceContentView.prototype.closed):
1365         Delete the logic for removing event listeners from global `Setting`, as it didn't work
1366         anyways, since none of the event listeners were added using a `thisObject`.
1367
1368 2019-06-13  Devin Rousso  <drousso@apple.com>
1369
1370         Web Inspector: Settings: sticky header disappears when over scrolling
1371         https://bugs.webkit.org/show_bug.cgi?id=198833
1372
1373         Reviewed by Joseph Pecoraro.
1374
1375         * UserInterface/Views/SettingsTabContentView.css:
1376         (.content-view.settings .navigation-bar):
1377         (.content-view.settings > .settings-view): Added.
1378         (.content-view.settings): Deleted.
1379
1380 2019-06-10  Devin Rousso  <drousso@apple.com>
1381
1382         Web Inspector: Timelines: imported recordings do not have JavaScript call trees
1383         https://bugs.webkit.org/show_bug.cgi?id=197490
1384         <rdar://problem/50589158>
1385
1386         Reviewed by Joseph Pecoraro.
1387
1388         * UserInterface/Models/TimelineRecording.js:
1389         (WI.TimelineRecording.prototype.initializeCallingContextTrees):
1390         Make sure to actually save the provided stack traces and samples in the export data.
1391
1392         * UserInterface/Models/ScriptTimelineRecord.js:
1393         (WI.ScriptTimelineRecord.fromJSON):
1394         (WI.ScriptTimelineRecord.prototype.toJSON):
1395         Drive-by: include `extraDetails`, which contains useful information like "default prevented".
1396
1397 2019-06-10  Nikita Vasilyev  <nvasilyev@apple.com>
1398
1399         REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work
1400         https://bugs.webkit.org/show_bug.cgi?id=198508
1401         <rdar://problem/51375503>
1402
1403         Reviewed by Matt Baker.
1404
1405         It didn't work because the detached sidebar panel tried to access its parent view (this.parentSidebar).
1406
1407         * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
1408         (WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Added.
1409         (WI.ComputedStyleDetailsSidebarPanel):
1410         * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
1411         (WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty): Deleted.
1412         Move computedStyleDetailsPanelShowProperty to ComputedStyleDetailsSidebarPanel since it's the only
1413         panel where it's needed.
1414
1415 2019-06-10  Alexey Shvayka  <shvaikalesh@gmail.com>
1416
1417         Web Inspector: "Copy Path to Property" doesn't work with multiline keys
1418         https://bugs.webkit.org/show_bug.cgi?id=198691
1419
1420         Reviewed by Matt Baker.
1421
1422         Correctly escape line terminators to prevent doubleQuotedString from returning malformed strings.
1423
1424         * UserInterface/Base/Utilities.js: Use JSON.stringify.
1425
1426 2019-06-10  Devin Rousso  <drousso@apple.com>
1427
1428         Web Inspector: REGRESSION(r246025): prototypes in object previews are visible even when setting `showOnlyJSON`
1429         https://bugs.webkit.org/show_bug.cgi?id=198721
1430
1431         Reviewed by Joseph Pecoraro.
1432
1433         * UserInterface/Views/ObjectTreeView.css:
1434         (.object-tree.properties-only.json-only .object-tree-property.prototype-property): Added.
1435         (.object-tree.properties-only.json-only .object-tree-property .prototype-property): Deleted.
1436
1437 2019-06-07  Nikita Vasilyev  <nvasilyev@apple.com>
1438
1439         Web Inspector: longhand CSS properties overridden by shorthands miss strikethrough
1440         https://bugs.webkit.org/show_bug.cgi?id=198629
1441         <rdar://problem/51504160>
1442
1443         Reviewed by Devin Rousso.
1444
1445         Longhand CSS properties (e.g. "font-size") overriden by shorthands (e.g. "font") now have strikethroughs.
1446
1447         * UserInterface/Models/CSSProperty.js:
1448         (WI.CSSProperty.prototype.set overridingProperty):
1449         (WI.CSSProperty):
1450
1451         * UserInterface/Models/DOMNodeStyles.js:
1452         (WI.DOMNodeStyles.prototype._updateStyleCascade):
1453         Call _associateRelatedProperties before _markOverriddenProperties because
1454         _associateRelatedProperties sets relatedShorthandProperty property, which
1455         is now used by _markOverriddenProperties.
1456
1457         (WI.DOMNodeStyles.prototype._markOverriddenProperties.isOverriddenBy):
1458         (WI.DOMNodeStyles.prototype._markOverriddenProperties):
1459
1460 2019-06-06  Devin Rousso  <drousso@apple.com>
1461
1462         Web Inspector: Timelines: remove always disabled details sidebar navigation item
1463         https://bugs.webkit.org/show_bug.cgi?id=198393
1464
1465         Reviewed by Timothy Hatcher.
1466
1467         * UserInterface/Views/TimelineTabContentView.js:
1468         (WI.TimelineTabContentView):
1469
1470 2019-06-06  Devin Rousso  <drousso@apple.com>
1471
1472         Web Inspector: REGRESSION(r245833): Timelines: CPU: JavaScript label is missing and JavaScript section of pie chart is black
1473         https://bugs.webkit.org/show_bug.cgi?id=198627
1474
1475         Reviewed by Joseph Pecoraro.
1476
1477         * UserInterface/Views/CPUTimelineView.js:
1478         (WI.CPUTimelineView.displayNameForSampleType):
1479         * UserInterface/Views/CPUTimelineView.css:
1480         (.timeline-view.cpu > .content > .overview .legend > .row > .swatch.sample-type-javascript):
1481         (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-javascript): Added.
1482         (.timeline-view.cpu .circle-chart > svg > path.segment.sample-type-script): Deleted.
1483         * UserInterface/Views/CPUUsageCombinedView.css:
1484         (.cpu-usage-combined-view > .graph > .range-chart .sample-type-javascript): Added.
1485         (.cpu-usage-combined-view > .graph > .range-chart .sample-type-script): Deleted.
1486         Use the enum string added in r245833 (`sample-type-javascript`) instead of what was there
1487         before (`sample-type-script`).
1488
1489         * UserInterface/Views/Variables.css:
1490         (:root):
1491         Rename `--cpu-script-*` to `--cpu-javascript-*`.
1492
1493 2019-06-06  Devin Rousso  <drousso@apple.com>
1494
1495         Web Inspector: Formatter: pretty-print CSS using a Worker
1496         https://bugs.webkit.org/show_bug.cgi?id=197829
1497         <rdar://problem/36891532>
1498
1499         Reviewed by Timothy Hatcher.
1500
1501         * UserInterface/Proxies/FormatterWorkerProxy.js:
1502         (WI.FormatterWorkerProxy.prototype.formatCSS): Added.
1503         * UserInterface/Workers/Formatter/FormatterWorker.js:
1504         (FormatterWorker.prototype.formatCSS): Added.
1505         * UserInterface/Workers/Formatter/CSSFormatter.js: Added.
1506         (CSSFormatter):
1507         (CSSFormatter.prototype.get success):
1508         (CSSFormatter.prototype.get formattedText):
1509         (CSSFormatter.prototype.get sourceMapData):
1510         (CSSFormatter.prototype._format):
1511
1512         * UserInterface/Workers/Formatter/FormatterContentBuilder.js:
1513         (FormatterContentBuilder.prototype.get currentLine): Added.
1514
1515         * UserInterface/Views/TextEditor.js:
1516         (WI.TextEditor.prototype._canUseFormatterWorker):
1517         (WI.TextEditor.prototype._startWorkerPrettyPrint):
1518
1519         * .eslintrc:
1520
1521 2019-06-06  Devin Rousso  <drousso@apple.com>
1522
1523         Web Inspector: Elements: print/rulers/compositing/paint navigation items shouldn't be visible if the inspected target doesn't have a PageAgent
1524         https://bugs.webkit.org/show_bug.cgi?id=198410
1525
1526         Reviewed by Timothy Hatcher.
1527
1528         * UserInterface/Views/DOMTreeContentView.js:
1529         (WI.DOMTreeContentView):
1530         (WI.DOMTreeContentView.prototype.get navigationItems):
1531         (WI.DOMTreeContentView.prototype._showRulersChanged):
1532
1533 == Rolled over to ChangeLog-2019-06-05 ==