Update CodeMirror to 3.14.1.
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2013-07-15  Timothy Hatcher  <timothy@apple.com>
2
3         Update CodeMirror to 3.14.1.
4
5         https://bugs.webkit.org/show_bug.cgi?id=118605
6
7         Reviewed by Joseph Pecoraro.
8
9         * Scripts/update-codemirror-resources.rb: Updated the list to add closebrackets.js and sorted the files.
10         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
11         * Tools/PrettyPrinting/Formatter.js:
12         * Tools/PrettyPrinting/FormatterContentBuilder.js:
13         * Tools/PrettyPrinting/codemirror.css:
14         * Tools/PrettyPrinting/codemirror.js:
15         * Tools/PrettyPrinting/css.js:
16         * Tools/PrettyPrinting/javascript.js:
17         * UserInterface/External/CodeMirror/closebrackets.js:
18         * UserInterface/External/CodeMirror/codemirror.css:
19         * UserInterface/External/CodeMirror/codemirror.js:
20         * UserInterface/External/CodeMirror/coffeescript.js:
21         * UserInterface/External/CodeMirror/comment.js:
22         * UserInterface/External/CodeMirror/css.js:
23         * UserInterface/External/CodeMirror/javascript.js:
24         * UserInterface/External/CodeMirror/matchbrackets.js:
25         * UserInterface/External/CodeMirror/sql.js:
26         * UserInterface/External/CodeMirror/xml.js:
27
28 2013-07-15  Timothy Hatcher  <timothy@apple.com>
29
30         Make sure to add main resources for sub-frames to the Network Timeline.
31
32         https://bugs.webkit.org/show_bug.cgi?id=118649
33
34         Reviewed by Joseph Pecoraro.
35
36         * UserInterface/TimelineManager.js:
37         (WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
38         call to _clear() and early return for event.target.isMainFrame(). The _clear()
39         is already handled if needed by the call to _startAutoRecording(), so it was
40         redundant here and caused the erroneous addition of isMainFrame() early return.
41
42 2013-07-15  Timothy Hatcher  <timothy@apple.com>
43
44         Properly handle style text changes while the color popover is open.
45
46         https://bugs.webkit.org/show_bug.cgi?id=118575
47
48         Reviewed by Joseph Pecoraro.
49
50         * UserInterface/CSSStyleDeclarationTextEditor.js:
51         (WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):
52         The original text marker might have been cleared by a style update, in this case we need to
53         find the new color text marker so we know the right range for the new style color text.
54
55 2013-07-14  Commit Queue  <commit-queue@webkit.org>
56
57         Unreviewed, rolling out r152598.
58         http://trac.webkit.org/changeset/152598
59         https://bugs.webkit.org/show_bug.cgi?id=118658
60
61         totally broke the web inspector (JS ERROR: SyntaxError:
62         Expected token '}') (Requested by thorton on #webkit).
63
64         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
65         * Tools/PrettyPrinting/Formatter.js:
66         * Tools/PrettyPrinting/FormatterContentBuilder.js:
67         * Tools/PrettyPrinting/codemirror.css:
68         (.CodeMirror-scrollbar-filler):
69         (.CodeMirror-gutters):
70         (.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
71         (.CodeMirror-widget):
72         * Tools/PrettyPrinting/codemirror.js:
73         (window.CodeMirror):
74         (window.CodeMirror.):
75         (.do):
76         (moveVisually):
77         * Tools/PrettyPrinting/css.js:
78         (.):
79         (CodeMirror):
80         * Tools/PrettyPrinting/javascript.js:
81         (.):
82         * UserInterface/External/CodeMirror/codemirror.css:
83         (.CodeMirror-widget):
84         * UserInterface/External/CodeMirror/codemirror.js:
85         (window.CodeMirror):
86         (window.CodeMirror.):
87         * UserInterface/External/CodeMirror/coffeescript.js:
88         * UserInterface/External/CodeMirror/comment.js:
89         (.):
90         * UserInterface/External/CodeMirror/css.js:
91         (.):
92         (CodeMirror):
93         * UserInterface/External/CodeMirror/javascript.js:
94         (.):
95         * UserInterface/External/CodeMirror/matchbrackets.js:
96         (.):
97         * UserInterface/External/CodeMirror/sql.js:
98         * UserInterface/External/CodeMirror/xml.js:
99
100 2013-07-12  Timothy Hatcher  <timothy@apple.com>
101
102         Update CodeMirror to 7f560afa1c (3.14+).
103
104         https://bugs.webkit.org/show_bug.cgi?id=118605
105
106         Reviewed by Sam Weinig.
107
108         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
109         * Tools/PrettyPrinting/Formatter.js:
110         * Tools/PrettyPrinting/FormatterContentBuilder.js:
111         * Tools/PrettyPrinting/codemirror.css:
112         * Tools/PrettyPrinting/codemirror.js:
113         * Tools/PrettyPrinting/css.js:
114         * Tools/PrettyPrinting/javascript.js:
115         * UserInterface/External/CodeMirror/codemirror.css:
116         * UserInterface/External/CodeMirror/codemirror.js:
117         * UserInterface/External/CodeMirror/coffeescript.js:
118         * UserInterface/External/CodeMirror/comment.js:
119         * UserInterface/External/CodeMirror/css.js:
120         * UserInterface/External/CodeMirror/javascript.js:
121         * UserInterface/External/CodeMirror/matchbrackets.js:
122         * UserInterface/External/CodeMirror/sql.js:
123         * UserInterface/External/CodeMirror/xml.js:
124
125 2013-07-12  Seokju Kwon  <seokju.kwon@gmail.com>
126
127         Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
128         https://bugs.webkit.org/show_bug.cgi?id=118589
129
130         Reviewed by Timothy Hatcher.
131
132         sidebarPanels : It is necessary to get correct argument after r152141.
133         Without this, error messages can be displayed.
134         role : Could pass null for it since default value is "group".
135
136         * UserInterface/Main.js:
137         (WebInspector.contentLoaded):
138
139 2013-07-03  Timothy Hatcher  <timothy@apple.com>
140
141         Guard remaining calls to decodeURIComponent with a try/catch.
142
143         https://bugs.webkit.org/show_bug.cgi?id=118371
144
145         Reviewed by Joseph Pecoraro.
146
147         * UserInterface/Main.js:
148         (WebInspector.displayNameForURL):
149         (WebInspector.updateWindowTitle):
150         * UserInterface/Utilities.js:
151         (arrayResult):
152         (queryString):
153
154 2013-07-03  Jessie Berlin  <jberlin@apple.com>
155
156         Ran update-webkit-localizable-strings.
157
158         Rubber-stamped by Joseph Pecoraro.
159
160         * Localizations/en.lproj/localizedStrings.js:
161
162 2013-06-28  Dean Jackson  <dino@apple.com>
163
164         Update Apple System fonts in auto-complete
165         https://bugs.webkit.org/show_bug.cgi?id=118205
166         <rdar://problem/14308488>
167
168         Reviewed by Joseph Pecoraro.
169
170         Update for the new Apple System font names, and remove some invalid entries.
171
172         * UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
173         "apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
174
175 2013-06-28  James Craig  <james@cookiecrook.com>
176
177         Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
178         https://bugs.webkit.org/show_bug.cgi?id=118122
179
180         Reviewed by Timothy Hatcher.
181
182         Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
183         so that screen readers will not indicate a bogus :required/:invalid state to the user.
184         Minor cosmetic difference blocked by http://webkit.org/b/118162
185
186         * UserInterface/FilterBar.css:
187         (.filter-bar > input[type="search"]:focus):
188         (.filter-bar > input[type="search"]:not(:placeholder-shown)):
189         * UserInterface/FilterBar.js:
190         (WebInspector.FilterBar):
191         * UserInterface/ResourceSidebarPanel.js:
192         (WebInspector.ResourceSidebarPanel):
193         * UserInterface/SearchBar.css:
194         (.search-bar > input[type="search"]:focus):
195         (.search-bar > input[type="search"]:not(:placeholder-shown)):
196         * UserInterface/SearchBar.js:
197         (WebInspector.SearchBar):
198
199 2013-06-27  James Craig  <james@cookiecrook.com>
200
201         Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.) 
202         so the layout is more discoverable to screen reader users
203         https://bugs.webkit.org/show_bug.cgi?id=118104
204
205         Reviewed by Timothy Hatcher.
206
207         Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
208         and navigable with VoiceOver.
209
210         * Localizations/en.lproj/localizedStrings.js:
211         * UserInterface/ButtonNavigationItem.js:
212         * UserInterface/CSSStyleDetailsSidebarPanel.js:
213         * UserInterface/DashboardManager.js:
214         * UserInterface/Main.js:
215         * UserInterface/NavigationBar.js:
216         * UserInterface/NavigationItem.js:
217         * UserInterface/NavigationSidebarPanel.js:
218         * UserInterface/RadioButtonNavigationItem.js:
219         * UserInterface/Sidebar.js:
220         * UserInterface/SidebarPanel.js:
221         * UserInterface/Toolbar.js:
222
223 2013-06-27  James Craig  <james@cookiecrook.com>
224
225         Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
226         https://bugs.webkit.org/show_bug.cgi?id=115976
227
228         Reviewed by Timothy Hatcher.
229
230         Main console log area (div.console-messages) is now an ARIA live region (role="log")
231         so screen readers speak plain text updates.
232         
233         Also added contextual labels (e.g. input/output) but speech output verification of
234         those is currently blocked by http://webkit.org/b/118096
235
236         * Localizations/en.lproj/localizedStrings.js:
237         * UserInterface/ConsoleCommand.js:
238         (WebInspector.ConsoleCommand.prototype.toMessageElement):
239         * UserInterface/ConsoleCommandResult.js:
240         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
241         * UserInterface/LogContentView.css:
242         (@media reader):
243         * UserInterface/LogContentView.js:
244         (WebInspector.LogContentView):
245
246
247 2013-06-27  Matthew Holden  <jftholden@yahoo.com>
248
249         Web Inspector: Display color picker in popover on color swatch click
250         https://bugs.webkit.org/show_bug.cgi?id=117919
251
252         Reviewed by Timothy Hatcher.
253
254         Includes fixes from second code review.
255
256         * Localizations/en.lproj/localizedStrings.js:
257         * UserInterface/CSSColorPicker.css: Added.
258         (.colorpicker-container):
259         (.colorpicker-fill-parent):
260         (.colorpicker-top):
261         (.colorpicker-color):
262         (.colorpicker-bottom span):
263         (.colorpicker-text):
264         (.colorpicker-color-text-value):
265         (.colorpicker-hue):
266         (.colorpicker-fill):
267         (.colorpicker-range-container):
268         (.colorpicker-range-container *):
269         (.colorpicker-range-container label):
270         (.colorpicker-range-container input):
271         (.colorpicker-saturation):
272         (.colorpicker-value):
273         (.colorpicker-dragger):
274         (.colorpicker-slider):
275         (.colorpicker-container .swatch):
276         (.colorpicker-container .swatch-inner):
277         * UserInterface/CSSColorPicker.js: Added.
278         (WebInspector.CSSColorPicker.consume):
279         (WebInspector.CSSColorPicker.move):
280         (WebInspector.CSSColorPicker.start):
281         (WebInspector.CSSColorPicker.stop):
282         (WebInspector.CSSColorPicker.makeDraggable):
283         (WebInspector.CSSColorPicker.hueDrag):
284         (WebInspector.CSSColorPicker.colorDragStart):
285         (WebInspector.CSSColorPicker.colorDrag):
286         (WebInspector.CSSColorPicker.alphaDrag):
287         (WebInspector.CSSColorPicker.colorSwatchClicked):
288         (WebInspector.CSSColorPicker):
289         (WebInspector.CSSColorPicker.prototype.get element):
290         (WebInspector.CSSColorPicker.prototype.set color):
291         (WebInspector.CSSColorPicker.prototype.get color):
292         (WebInspector.CSSColorPicker.prototype.get outputColorFormat):
293         (WebInspector.CSSColorPicker.prototype.get colorHueOnly):
294         (WebInspector.CSSColorPicker.prototype.set displayText):
295         (WebInspector.CSSColorPicker.prototype.shown):
296         (WebInspector.CSSColorPicker.prototype._updateHelperLocations):
297         (WebInspector.CSSColorPicker.prototype._updateDisplay):
298         (WebInspector.CSSColorPicker.hsvaToRGBA):
299         (WebInspector.CSSColorPicker.rgbaToHSVA):
300         * UserInterface/CSSStyleDeclarationTextEditor.js:
301         (WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
302         (WebInspector.CSSStyleDeclarationTextEditor.prototype.):
303         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
304         (WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
305         (WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
306         * UserInterface/Main.html:
307
308 2013-06-26  Antoine Quint  <graouts@apple.com>
309
310         Web Inspector: stepping through while paused in debugger makes a popover appear
311         https://bugs.webkit.org/show_bug.cgi?id=117994
312
313         There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
314         active call frame changes and it leads to an extraneous display of the popover.
315
316         Reviewed by Timothy Hatcher.
317
318         * UserInterface/SourceCodeTextEditor.js:
319         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
320
321 2013-06-24  Antoine Quint  <graouts@apple.com>
322
323         Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
324         https://bugs.webkit.org/show_bug.cgi?id=117927
325
326         Handle possible mis-encoded URI fragments passed to decodeURIComponent() which
327         could prevent inspection of the DOM.
328
329         Reviewed by Timothy Hatcher.
330
331         * UserInterface/Main.js:
332         (WebInspector.displayNameForURL):
333
334 2013-06-17  Darin Adler  <darin@apple.com>
335
336         Sort all the Xcode project files
337         https://bugs.webkit.org/show_bug.cgi?id=117696
338
339         Reviewed by Anders Carlsson.
340
341         * WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
342
343 2013-06-21  Joseph Pecoraro  <pecoraro@apple.com>
344
345         Web Inspector: Uncaught exception when pretty printing WebInspector.Script
346         https://bugs.webkit.org/show_bug.cgi?id=117893
347
348         This was an issue with an earlier refactoring. The sourceCode is a Script,
349         so replace the non-existent local variable "script" with "this._sourceCode".
350
351         Reviewed by Timothy Hatcher.
352
353         * UserInterface/SourceCodeTextEditor.js:
354         (WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):
355
356 2013-06-21  Timothy Hatcher  <timothy@apple.com>
357
358         Stop removing and re-adding breakpoints from the backend on reload.
359
360         On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
361         Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
362         don't need to update the backend, since nothing really changed.
363
364         https://bugs.webkit.org/show_bug.cgi?id=117877
365
366         Reviewed by Joseph Pecoraro.
367
368         * UserInterface/DebuggerManager.js:
369         (WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
370         _ignoreBreakpointDisplayLocationDidChangeEvent is true.
371         (WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
372         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.
373
374 2013-06-19  Antoine Quint  <graouts@apple.com>
375
376         Web Inspector: Copying array or object output does not contain values
377         https://bugs.webkit.org/show_bug.cgi?id=117669
378
379         ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
380         in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
381         We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
382         and, additionally, only use that prefix if we're copying more than a single message since it's
383         the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
384         a log level always print the level and when saving the console log using Cmd+S, all messages
385         contain their prefix as well.
386
387         Reviewed by Timothy Hatcher.
388
389         * UserInterface/ConsoleCommand.js:
390         (WebInspector.ConsoleCommand.prototype.toClipboardString):
391         Handle the new isPrefixOptional argument.
392
393         * UserInterface/ConsoleCommandResult.js:
394         (WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
395         Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
396         the prefix isn't printed out in situations when it may not.
397
398         * UserInterface/ConsoleMessageImpl.js:
399         Set "enforcesClipboardPrefixString" to true since we always want to log the log level
400         prefix in all situations.
401
402         (WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
403         Implement this new getter to return our clipboard string such that subclasses may
404         customize it.
405
406         (WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
407         Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
408         to only log the prefix if necessary.
409
410         * UserInterface/LogContentView.js:
411         (WebInspector.LogContentView.prototype._formatMessagesAsData):
412         Make the logging of prefix optional when we have a single message selected and we're
413         not saving via Cmd+S.
414
415 2013-06-18  Joseph Pecoraro  <pecoraro@apple.com>
416
417         Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
418         https://bugs.webkit.org/show_bug.cgi?id=117755
419
420         Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
421         and Rect prototypes, so they get the expected methods. We then need to
422         handle the ZERO_RECT case better, and not attempt to draw a background
423         in a canvas with a 0 size, which would produce an exception.
424
425         Reviewed by Timothy Hatcher.
426
427         * UserInterface/Geometry.js:
428         * UserInterface/Popover.js:
429         (WebInspector.Popover.prototype._update):
430
431 2013-06-18  Timothy Hatcher  <timothy@apple.com>
432
433         If the tree outline is processing a selection currently, then don't change the selection.
434
435         This is needed to allow breakpoints tree elements to be selected without jumping back to
436         selecting the resource tree element.
437
438         https://bugs.webkit.org/show_bug.cgi?id=117746
439
440         Reviewed by Joseph Pecoraro.
441
442         * UserInterface/Main.js:
443         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
444         * UserInterface/TreeOutline.js:
445         (TreeElement.prototype.select):
446
447 2013-06-18  Timothy Hatcher  <timothy@apple.com>
448
449         Update breakpoints to match Xcode 5.
450
451         This updates the breakpoint images, line colors, and moves breakpoints toggle button
452         to the Debugger sidebar navigation bar.
453
454         https://bugs.webkit.org/show_bug.cgi?id=117723
455
456         Reviewed by Joseph Pecoraro.
457
458         * Localizations/en.lproj/localizedStrings.js: Updated.
459         * UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
460         * UserInterface/DebuggerSidebarPanel.js:
461         (WebInspector.DebuggerSidebarPanel):
462         (WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):
463         * UserInterface/Images/Breakpoint.png: Updated.
464         * UserInterface/Images/Breakpoints.pdf: Added.
465         * UserInterface/Images/Breakpoint@2x.png: Updated.
466         * UserInterface/Images/BreakpointButton.pdf: Updated.
467         * UserInterface/Images/BreakpointInactive.png: Updated.
468         * UserInterface/Images/BreakpointInactive@2x.png: Updated.
469         * UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
470         * UserInterface/Images/InstructionPointer.png: Updated.
471         * UserInterface/Images/InstructionPointer@2x.png: Updated.
472         * UserInterface/SourceCodeTextEditor.css:
473         (.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
474         (.source-code.text-editor > .CodeMirror .warning): Ditto.
475         * UserInterface/TextEditor.css:
476         (.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
477         (.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
478         (.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.
479
480 2013-06-13  Joseph Pecoraro  <pecoraro@apple.com>
481
482         <http://webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space between "do" and "{"
483
484         Reviewed by Timothy Hatcher.
485
486         * UserInterface/CodeMirrorFormatters.js:
487
488 2013-06-13  Joseph Pecoraro  <pecoraro@apple.com>
489
490         <http://webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel when I remove all text search text
491
492         Reviewed by Timothy Hatcher.
493
494         * UserInterface/ResourceSidebarPanel.js:
495         (WebInspector.ResourceSidebarPanel):
496         (WebInspector.ResourceSidebarPanel.prototype._searchFieldInput):
497
498 == Rolled over to ChangeLog-2013-06-11 ==