Web Inspector: Remove dead code in FrameTreeElement
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2016-10-25  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Remove dead code in FrameTreeElement
4         https://bugs.webkit.org/show_bug.cgi?id=163914
5
6         Reviewed by Brian Burg.
7
8         * UserInterface/Views/FrameTreeElement.js:
9
10 2016-10-24  Devin Rousso  <dcrousso+webkit@gmail.com>
11
12         Web Inspector: Scope chain shouldn't show empty Closure sections
13         https://bugs.webkit.org/show_bug.cgi?id=152348
14
15         Reviewed by Joseph Pecoraro.
16
17         * UserInterface/Controllers/DebuggerManager.js:
18         (WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
19         * UserInterface/Models/ScopeChainNode.js:
20         (WebInspector.ScopeChainNode):
21         (WebInspector.ScopeChainNode.prototype.get empty):
22         Added support for new empty property.
23
24         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
25         (WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
26         Only create and display a DetailsSection if the scope is not empty (via empty).
27
28 2016-10-24  Devin Rousso  <dcrousso+webkit@gmail.com>
29
30         Web Inspector: Improve Quick Open sorting algorithm
31         https://bugs.webkit.org/show_bug.cgi?id=163705
32
33         Reviewed by Joseph Pecoraro.
34
35         * UserInterface/Models/ResourceQueryResult.js:
36         (WebInspector.ResourceQueryResult.prototype._calculateRank.getMultiplier):
37         (WebInspector.ResourceQueryResult.prototype._calculateRank):
38         Added logic to multiply the ranking increment/decrement based on whether the current match
39         is part of a sequence, whether that sequence began with a special character, and the length
40         of the current sequence.
41
42 2016-10-19  Dean Jackson  <dino@apple.com>
43
44         Support CSS Shapes Level 1 without a prefix
45         https://bugs.webkit.org/show_bug.cgi?id=163709
46         <rdar://problem/28859369>
47
48         Reviewed by Myles Maxfield.
49
50         Replace -webkit-shape-outside with shape-outside.
51
52         * UserInterface/Models/CSSKeywordCompletions.js:
53
54 2016-10-19  Aaron Chu  <aaron_chu@apple.com>
55
56         Web Inspector: AXI: expose computed tree node and heading level
57         https://bugs.webkit.org/show_bug.cgi?id=130825
58         <rdar://problem/16442349>
59
60         Reviewed by Joseph Pecoraro.
61
62         Updating the Web Accessibility Inspector to display Heading Level and Hierarchical Level.
63
64         * Localizations/en.lproj/localizedStrings.js:
65         * UserInterface/Models/DOMNode.js:
66         (WebInspector.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback):
67         (WebInspector.DOMNode.prototype.accessibilityProperties):
68         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
69         (WebInspector.DOMNodeDetailsSidebarPanel):
70         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
71         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):
72
73 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
74
75         Web Inspector: Styles Sidebar highlights "translate" but not "translateX"
76         https://bugs.webkit.org/show_bug.cgi?id=163613
77         <rdar://problem/28829610>
78
79         Reviewed by Timothy Hatcher.
80
81         * UserInterface/Models/CSSCompletions.js:
82         (WebInspector.CSSCompletions.requestCSSCompletions):
83         The hash table objects we pass to CodeMirror expects keys to be lowercased.
84
85 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
86
87         Web Inspector: CSS Autocompletion sometimes adds extra unexpected characters
88         https://bugs.webkit.org/show_bug.cgi?id=163612
89         <rdar://problem/28829557>
90
91         Reviewed by Timothy Hatcher.
92
93         * UserInterface/Controllers/CodeMirrorCompletionController.js:
94         (WebInspector.CodeMirrorCompletionController.prototype._generateCSSCompletions):
95         Better handle completions in cases where we are in the middle of a property
96         to avoid orphaned characters, or at the end of a function name to avoid creating
97         duplicate parenthesis.
98
99 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
100
101         REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
102         https://bugs.webkit.org/show_bug.cgi?id=163583
103         <rdar://problem/28815882>
104
105         Reviewed by Timothy Hatcher.
106
107         * UserInterface/Views/TimelineRecordingContentView.js:
108         (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
109         Revert logic change introduced by r201171 with no explanation.
110         Whenever we get a start time we should use it, regardless of
111         of what the current time is, precisely because the backend is
112         informing us of the start time to use.
113
114 2016-10-17  Joseph Pecoraro  <pecoraro@apple.com>
115
116         Web Inspector: Add toggles for debugger pauses at console.assert failures
117         https://bugs.webkit.org/show_bug.cgi?id=139542
118         <rdar://problem/19281600>
119
120         Reviewed by Timothy Hatcher.
121
122         * UserInterface/Controllers/DebuggerManager.js:
123         (WebInspector.DebuggerManager.prototype.get assertionsBreakpoint):
124         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
125         (WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
126         New breakpoint and toggling behavior.
127
128         * Localizations/en.lproj/localizedStrings.js:
129         * UserInterface/Views/DebuggerSidebarPanel.js:
130         (WebInspector.DebuggerSidebarPanel):
131         (WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineDeleteTreeElement):
132         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint):
133         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):
134         New breakpoint tree element behavior.
135
136         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
137         (WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
138         Sidebar restoration if it was selected.
139
140         * UserInterface/Images/Assertion.svg: Added.
141         * UserInterface/Images/gtk/Assertion.svg: Added.
142         * UserInterface/Views/BreakpointTreeElement.css:
143         (.breakpoint-assertion-icon .icon):
144         New sidebar icon for the global breakpoint.
145
146 2016-10-15  Joseph Pecoraro  <pecoraro@apple.com>
147
148         Web Inspector: Cleanup parts of DebuggerManager
149         https://bugs.webkit.org/show_bug.cgi?id=163400
150
151         Reviewed by Timothy Hatcher.
152
153         * UserInterface/Controllers/DebuggerManager.js:
154         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
155
156         (WebInspector.DebuggerManager.prototype.get paused):
157         (WebInspector.DebuggerManager.prototype.get pauseReason):
158         (WebInspector.DebuggerManager.prototype.get pauseData):
159         (WebInspector.DebuggerManager.prototype.get callFrames):
160         (WebInspector.DebuggerManager.prototype.get activeCallFrame):
161         (WebInspector.DebuggerManager.prototype.set activeCallFrame):
162         Put simple accessors at the top.
163
164         (WebInspector.DebuggerManager.prototype.get allExceptionsBreakpoint):
165         (WebInspector.DebuggerManager.prototype.get allUncaughtExceptionsBreakpoint):
166         (WebInspector.DebuggerManager.prototype.get breakpoints):
167         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
168         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
169         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
170         (WebInspector.DebuggerManager.prototype.isBreakpointEditable):
171         (WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
172         Group public breakpoint state and access methods.
173
174         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
175         (WebInspector.DebuggerManager.prototype.scriptsForURL):
176         (WebInspector.DebuggerManager.prototype.get searchableScripts):
177         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
178         Group public script access methods.
179
180         (WebInspector.DebuggerManager.prototype.pause):
181         (WebInspector.DebuggerManager.prototype.resume):
182         (WebInspector.DebuggerManager.prototype.stepOver):
183         (WebInspector.DebuggerManager.prototype.stepInto):
184         (WebInspector.DebuggerManager.prototype.stepOut):
185         (WebInspector.DebuggerManager.prototype.continueToLocation):
186         (WebInspector.DebuggerManager.prototype.addBreakpoint):
187         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
188         Group and modernize public methods that perform actions.
189
190         (WebInspector.DebuggerManager.prototype.nextBreakpointActionIdentifier):
191         Misc. methods.
192
193         (WebInspector.DebuggerManager.prototype.breakpointResolved):
194         (WebInspector.DebuggerManager.prototype.reset):
195         (WebInspector.DebuggerManager.prototype.playBreakpointActionSound):
196         (WebInspector.DebuggerManager.prototype.scriptDidParse):
197         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
198         (WebInspector.DebuggerManager.prototype._setBreakpoint):
199         (WebInspector.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
200         (WebInspector.DebuggerManager.prototype._updateBreakOnExceptionsState):
201         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
202         Minor cleanup in protected and private methods.
203
204         * UserInterface/Models/BreakpointAction.js:
205         (WebInspector.BreakpointAction):
206         Getting the next identifier is an action so it should be a function call.
207
208         * UserInterface/Views/SourceCodeTextEditor.js:
209         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
210         Remove unused parameter.
211
212 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
213
214         Web Inspector: Dragging to delete a Breakpoint should never trigger a ContentView change
215         https://bugs.webkit.org/show_bug.cgi?id=163403
216         <rdar://problem/28762930>
217
218         Reviewed by Timothy Hatcher.
219
220         * UserInterface/Views/BreakpointTreeElement.js:
221         (WebInspector.BreakpointTreeElement.prototype.ondelete):
222         Signal when a breakpoint tree element will be going away because it was
223         deleted via the keyboard operation within the TreeOutline. This is a dirty
224         way to do the signal but we remove BreakpointTreeElements asynchronously
225         when the Breakpoint actually gets removed from the backend.
226
227         * UserInterface/Views/DebuggerSidebarPanel.js:
228         (WebInspector.DebuggerSidebarPanel.prototype._removeDebuggerTreeElement):
229         Deselect a BreakpointTreeElement if it was deleted in a way other then
230         the delete keyboard shortcut. This ensures another TreeElement selection
231         doesn't force ContentView changes.
232
233 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
234
235         Web Inspector: Improve debugger highlight when inside of getter/setter calls
236         https://bugs.webkit.org/show_bug.cgi?id=163428
237         <rdar://problem/28769061>
238
239         Reviewed by Timothy Hatcher.
240
241         * UserInterface/Views/SourceCodeTextEditor.js:
242         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
243         When in the middle of a member expression at a '.' or '[' get the best member
244         expression range.
245
246         * UserInterface/Views/TextEditor.js:
247         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
248         Include the character at the current position. This is useful since AST Nodes
249         don't give us token info but we would like to know if we are at particular tokens.
250
251 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
252
253         Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
254         https://bugs.webkit.org/show_bug.cgi?id=163395
255
256         Reviewed by Timothy Hatcher.
257
258         * UserInterface/Models/Breakpoint.js:
259         (WebInspector.Breakpoint.prototype.get identifier): Renamed.
260         (WebInspector.Breakpoint.prototype.set identifier): Renamed.
261         The only user is DebuggerManager which sets and gets. Previously
262         it was unexpectedly setting a direct property on the Breakpoint
263         instead of using these methods to set the member variable.
264
265 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
266
267         Web Inspector: Remove uses of delete in SourceCodeTextEditor
268         https://bugs.webkit.org/show_bug.cgi?id=163379
269
270         Reviewed by Timothy Hatcher.
271
272         Remove uses of delete and better group member variables.
273         One of the deletes was deleting an incorrect property.
274
275         * UserInterface/Views/SourceCodeTextEditor.js:
276         (WebInspector.SourceCodeTextEditor):
277         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
278         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointRemoved):
279         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointMoved):
280         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
281         (WebInspector.SourceCodeTextEditor.prototype._dismissEditingController):
282         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
283
284 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
285
286         Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
287         https://bugs.webkit.org/show_bug.cgi?id=163405
288         <rdar://problem/28763953>
289
290         Reviewed by Matt Baker.
291
292         * UserInterface/Views/SourceCodeTextEditor.js:
293         Use correct method name, the old one must have gone away.
294
295 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
296
297         Web Inspector: Improve support for logging Proxy objects in console
298         https://bugs.webkit.org/show_bug.cgi?id=163323
299         <rdar://problem/28432553>
300
301         Reviewed by Timothy Hatcher.
302
303         * UserInterface/Views/ConsoleMessageView.js:
304         (WebInspector.ConsoleMessageView.prototype._formatParameter):
305         Treat a Proxy like any other object.
306
307 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
308
309         Emit DebugHooks uniformly with pause locations instead of having separate pause locations and op_debug emits
310         https://bugs.webkit.org/show_bug.cgi?id=162809
311
312         Reviewed by Geoffrey Garen.
313
314         * UserInterface/Views/SourceCodeTextEditor.js:
315         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
316         When pausing on the variable assignment inside for..of and for..in don't just
317         highlight "var foo" but include the right hand side "var foo in ..." or
318         "var foo of ...".
319
320 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
321
322         Web Inspector: Whole program sometimes highlighted instead of just first statement
323         https://bugs.webkit.org/show_bug.cgi?id=163300
324         <rdar://problem/28723162>
325
326         Reviewed by Timothy Hatcher.
327
328         * UserInterface/Views/SourceCodeTextEditor.js:
329         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
330         Avoid highlighting the entire program by skipping a Program type Node.
331
332         * UserInterface/Views/TextEditor.js:
333         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
334         Avoid unnecessary work before content has loaded.
335
336         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
337         Avoid unnecessary indirection to get the CodeMirror editor.
338
339 2016-10-11  Joseph Pecoraro  <pecoraro@apple.com>
340
341         Web Inspector: Remove line highlight on primary execution line while stepping because it is distracting
342         https://bugs.webkit.org/show_bug.cgi?id=163294
343         <rdar://problem/28721176>
344
345         Reviewed by Timothy Hatcher.
346
347         * UserInterface/Views/TextEditor.js:
348         (WebInspector.TextEditor.prototype._updateExecutionLine):
349         When setting the primary execution line, remove default line highlights.
350
351 2016-10-10  Matt Baker  <mattbaker@apple.com>
352
353         Web Inspector: Revealed line not highlighted in TextEditor while debugger paused
354         https://bugs.webkit.org/show_bug.cgi?id=163197
355
356         Reviewed by Timothy Hatcher.
357
358         * UserInterface/Views/TextEditor.js:
359         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
360         Avoid highlighting the execution line while debugging, but allow
361         other lines to be highlighted.
362
363 2016-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
364
365         Inspector exception in `parseTextForRule()` when pasting into CSS rule selector
366         https://bugs.webkit.org/show_bug.cgi?id=162792
367
368         Reviewed by Matt Baker.
369
370         * UserInterface/Views/CSSStyleDeclarationSection.js:
371         (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
372         Changed regular expression for matching CSS rules to allow newlines in pasted text.
373
374 2016-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
375
376         Web Inspector: Clicking twice on the color swatch square should hide the color picker
377         https://bugs.webkit.org/show_bug.cgi?id=162759
378
379         Reviewed by Matt Baker.
380
381         * UserInterface/Views/InlineSwatch.js:
382         (WebInspector.InlineSwatch):
383         (WebInspector.InlineSwatch.prototype.didDismissPopover):
384         (WebInspector.InlineSwatch.prototype._swatchElementClicked):
385         Remove the "click" event listener when a popover is presented to prevent improper
386         interaction.  Add the event listener back when the popover is dismissed.
387
388 2016-10-02  Matt Baker  <mattbaker@apple.com>
389
390         Web Inspector: Exception thrown when hovering network waterfall graphs during reload
391         https://bugs.webkit.org/show_bug.cgi?id=162850
392         <rdar://problem/28579653>
393
394         Reviewed by Brian Burg.
395
396         * UserInterface/Views/ResourceTimelineDataGridNode.js:
397         (WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
398         Check that the node's data grid reference is valid before use.
399         (WebInspector.ResourceTimelineDataGridNode):
400
401 2016-10-01  Joseph Pecoraro  <pecoraro@apple.com>
402
403         Web Inspector: Selection does not show up over execution highlight ranges
404         https://bugs.webkit.org/show_bug.cgi?id=162844
405         <rdar://problem/28579121>
406
407         Reviewed by Matt Baker.
408
409         * Scripts/update-codemirror-resources.rb:
410         * UserInterface/External/CodeMirror/mark-selection.js: Added.
411         * UserInterface/Main.html:
412         New add-on that makes selection a text marker so it can be styled
413         at the same level as other text markers.
414
415         * UserInterface/Views/TextEditor.css:
416         (.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext)):
417         Don't use execution-range-highlight styles if the text is selected.
418
419         * UserInterface/Views/TextEditor.js:
420         (WebInspector.TextEditor):
421         Enable the text selection as text markers addon.
422
423 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
424
425         Web Inspector: Make debugger stepping highlights work in inline <script>s
426         https://bugs.webkit.org/show_bug.cgi?id=162753
427         <rdar://problem/28551332>
428
429         Reviewed by Brian Burg.
430
431         * UserInterface/Models/TextRange.js:
432         (WebInspector.TextRange.prototype.contains):
433         Check if a given line/column falls within this range.
434
435         * UserInterface/Views/SourceCodeTextEditor.js:
436         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
437         If we are in a Document resource find the associated script at a given position.
438
439         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
440         When comparing offsets to SyntaxTree offsets, the SyntaxTree's offset of 0 is the
441         first character of the Script, which differs from the current SourceCode's offset.
442         Adjust the offset by the Script's startOffset.
443
444         * UserInterface/Views/TextEditor.js:
445         (WebInspector.TextEditor.prototype.currentPositionToOriginalPosition):
446         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
447         Pass both the original offset and original position to the delegate.
448
449 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
450
451         Web Inspector: Stepping through `a(); b(); c();` it is unclear where we are and what is about to execute
452         https://bugs.webkit.org/show_bug.cgi?id=161658
453         <rdar://problem/28181254>
454
455         Reviewed by Geoffrey Garen.
456
457         * UserInterface/Models/Script.js:
458         (WebInspector.Script.prototype.requestScriptSyntaxTree):
459         Fix first calls to requestScriptSyntaxTree. They were getting an uncaught
460         exception because the content argument was missing.
461
462         * UserInterface/Models/ScriptSyntaxTree.js:
463         (WebInspector.ScriptSyntaxTree.prototype.containersOfOffset):
464         Find all AST nodes that contain a particular offset.
465
466         * UserInterface/Views/SourceCodeTextEditor.js:
467         (WebInspector.SourceCodeTextEditor):
468         (WebInspector.SourceCodeTextEditor.prototype.close):
469         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
470         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameSourceCodeLocationChanged):
471         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
472         Provide a good highlight range for a given offset. This is normally the start
473         of a statement/expression, inside a statement/expression, or the closing brace
474         of a function (leaving a function). Provide good ranges for each of these.
475
476         * UserInterface/Views/TextEditor.js:
477         (WebInspector.TextEditor):
478         (WebInspector.TextEditor.set string.update):
479         (WebInspector.TextEditor.prototype.set string):
480         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
481         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
482         (WebInspector.TextEditor.prototype.revealPosition):
483         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
484         (WebInspector.TextEditor.prototype._updateAfterFormatting):
485         (WebInspector.TextEditor.prototype.set executionLineNumber): Deleted.
486         (WebInspector.TextEditor.prototype.set executionColumnNumber): Deleted.
487         (WebInspector.TextEditor.prototype._updateExecutionLine.update): Deleted.
488         Always set the execution line and column together, to simplify how we update highlights.
489
490         (WebInspector.TextEditor.prototype._clearMultilineExecutionLineHighlights):
491         (WebInspector.TextEditor.prototype._updateExecutionLine):
492         When updating the main highlight clear any multi-line highlights.
493
494         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
495         Ask the delegate for a specific highlight range. If provided use that range,
496         otherwise just highlight the end of the line. Once we know the range, if it
497         is multiple lines, give the extra lines the full line highlight as well.
498         Also make adjustments, such as not highlighting trailing whitespace.
499
500         * UserInterface/Views/TextEditor.css:
501         (.text-editor > .CodeMirror .execution-line.primary .CodeMirror-linenumber::after):
502         (.text-editor > .CodeMirror .execution-line):
503         (.text-editor > .CodeMirror .execution-line .CodeMirror-matchingbracket):
504         (.text-editor > .CodeMirror .execution-range-highlight):
505         Styles for execution lines and execution range highlights.
506
507 2016-09-29  Aaron Chu  <aaron_chu@apple.com>
508
509         Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
510         https://bugs.webkit.org/show_bug.cgi?id=130600
511         <rdar://problem/16391333>
512
513         Reviewed by Brian Burg.
514
515         Removing link style for non-navigable nodes by first
516         checking nodeType of the node.
517
518         * UserInterface/Base/DOMUtilities.js:
519         (WebInspector.linkifyNodeReference):
520
521 2016-09-27  Matt Baker  <mattbaker@apple.com>
522
523         Web Inspector: Refreshing while in Timelines-tab causes negative timestamps in Network-tab
524         https://bugs.webkit.org/show_bug.cgi?id=160051
525         <rdar://problem/27480122>
526
527         Reviewed by Brian Burg.
528
529         * UserInterface/Views/NetworkGridContentView.js:
530         (WebInspector.NetworkGridContentView.prototype.get startTime):
531         (WebInspector.NetworkGridContentView.prototype.get zeroTime):
532         Use the cached start time for graph data source properties instead of
533         relying on the ruler, which requires a layout in order to be updated
534         for the first time.
535
536 2016-09-27  Matt Baker  <mattbaker@apple.com>
537
538         Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
539         https://bugs.webkit.org/show_bug.cgi?id=162572
540         <rdar://problem/28479562>
541
542         Reviewed by Brian Burg.
543
544         Improve NavigationSidebarPanel logic for coordinating selection between trees.
545         When tree selection changes, the most recent selection should be restored
546         the next time the tree is focused.
547
548         The sidebar should also handle focusing a tree for the first time, in
549         which no previous selection exists, and focusing a tree that has had its
550         previous selection filtered out (hidden).
551
552         * UserInterface/Views/NavigationSidebarPanel.js:
553         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus):
554         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
555         Restoring the last deselected element, instead of the last selected element
556         only works when the selection is moving from one tree to another. When
557         the elements belong to the same tree the newly selected element won't
558         be saved until the next selection change. If the window loses and regains
559         the focus before then, the tree will restore the previous selection,
560         effectively reverting the last selection change.
561
562 2016-09-27  Tomas Popela  <tpopela@redhat.com>
563
564         [GTK] Mac defaults are used for key shortcuts on Linux
565         https://bugs.webkit.org/show_bug.cgi?id=162564
566
567         Don't set Mac's default keymap as a fallthrough for CodeMirror when we
568         are not on Mac.
569
570         Reviewed by Carlos Garcia Campos.
571
572         * UserInterface/Test.html: Include Platform.js for the
573         WebInspector.Platform definition.
574         * UserInterface/Views/CodeMirrorAdditions.js:
575
576 2016-09-26  Matt Baker  <mattbaker@apple.com>
577
578         Web Inspector: Box Model values not updated when DOM node styles change
579         https://bugs.webkit.org/show_bug.cgi?id=162525
580
581         Reviewed by Brian Burg.
582
583         The Box Model section should refresh itself when the selected node's
584         computed style changes. This is necessary since the Styles sidebar
585         doesn't always refresh its sections on node changes.
586
587         * UserInterface/Views/BoxModelDetailsSectionRow.js:
588         (WebInspector.BoxModelDetailsSectionRow.prototype.set nodeStyles):
589         Refresh metrics whenever the computed style changes.
590
591         (WebInspector.BoxModelDetailsSectionRow.prototype._getBox):
592         (WebInspector.BoxModelDetailsSectionRow.prototype._getComponentSuffix):
593         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createValueElement):
594         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
595         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
596         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):
597         Drive-by cleanup to make this large function easier to read.
598         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement): Deleted.
599         Renamed createValueElement.
600         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaWidthElement): Deleted.
601         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaHeightElement): Deleted.
602         Combined these into a single function taking a property name (width or height).
603
604 == Rolled over to ChangeLog-2016-09-26 ==