06653232892a9f0299e89bda610c652d36191fcf
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2016-10-24  Devin Rousso  <dcrousso+webkit@gmail.com>
2
3         Web Inspector: Scope chain shouldn't show empty Closure sections
4         https://bugs.webkit.org/show_bug.cgi?id=152348
5
6         Reviewed by Joseph Pecoraro.
7
8         * UserInterface/Controllers/DebuggerManager.js:
9         (WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
10         * UserInterface/Models/ScopeChainNode.js:
11         (WebInspector.ScopeChainNode):
12         (WebInspector.ScopeChainNode.prototype.get empty):
13         Added support for new empty property.
14
15         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
16         (WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
17         Only create and display a DetailsSection if the scope is not empty (via empty).
18
19 2016-10-24  Devin Rousso  <dcrousso+webkit@gmail.com>
20
21         Web Inspector: Improve Quick Open sorting algorithm
22         https://bugs.webkit.org/show_bug.cgi?id=163705
23
24         Reviewed by Joseph Pecoraro.
25
26         * UserInterface/Models/ResourceQueryResult.js:
27         (WebInspector.ResourceQueryResult.prototype._calculateRank.getMultiplier):
28         (WebInspector.ResourceQueryResult.prototype._calculateRank):
29         Added logic to multiply the ranking increment/decrement based on whether the current match
30         is part of a sequence, whether that sequence began with a special character, and the length
31         of the current sequence.
32
33 2016-10-19  Dean Jackson  <dino@apple.com>
34
35         Support CSS Shapes Level 1 without a prefix
36         https://bugs.webkit.org/show_bug.cgi?id=163709
37         <rdar://problem/28859369>
38
39         Reviewed by Myles Maxfield.
40
41         Replace -webkit-shape-outside with shape-outside.
42
43         * UserInterface/Models/CSSKeywordCompletions.js:
44
45 2016-10-19  Aaron Chu  <aaron_chu@apple.com>
46
47         Web Inspector: AXI: expose computed tree node and heading level
48         https://bugs.webkit.org/show_bug.cgi?id=130825
49         <rdar://problem/16442349>
50
51         Reviewed by Joseph Pecoraro.
52
53         Updating the Web Accessibility Inspector to display Heading Level and Hierarchical Level.
54
55         * Localizations/en.lproj/localizedStrings.js:
56         * UserInterface/Models/DOMNode.js:
57         (WebInspector.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback):
58         (WebInspector.DOMNode.prototype.accessibilityProperties):
59         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
60         (WebInspector.DOMNodeDetailsSidebarPanel):
61         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
62         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):
63
64 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
65
66         Web Inspector: Styles Sidebar highlights "translate" but not "translateX"
67         https://bugs.webkit.org/show_bug.cgi?id=163613
68         <rdar://problem/28829610>
69
70         Reviewed by Timothy Hatcher.
71
72         * UserInterface/Models/CSSCompletions.js:
73         (WebInspector.CSSCompletions.requestCSSCompletions):
74         The hash table objects we pass to CodeMirror expects keys to be lowercased.
75
76 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
77
78         Web Inspector: CSS Autocompletion sometimes adds extra unexpected characters
79         https://bugs.webkit.org/show_bug.cgi?id=163612
80         <rdar://problem/28829557>
81
82         Reviewed by Timothy Hatcher.
83
84         * UserInterface/Controllers/CodeMirrorCompletionController.js:
85         (WebInspector.CodeMirrorCompletionController.prototype._generateCSSCompletions):
86         Better handle completions in cases where we are in the middle of a property
87         to avoid orphaned characters, or at the end of a function name to avoid creating
88         duplicate parenthesis.
89
90 2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
91
92         REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
93         https://bugs.webkit.org/show_bug.cgi?id=163583
94         <rdar://problem/28815882>
95
96         Reviewed by Timothy Hatcher.
97
98         * UserInterface/Views/TimelineRecordingContentView.js:
99         (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
100         Revert logic change introduced by r201171 with no explanation.
101         Whenever we get a start time we should use it, regardless of
102         of what the current time is, precisely because the backend is
103         informing us of the start time to use.
104
105 2016-10-17  Joseph Pecoraro  <pecoraro@apple.com>
106
107         Web Inspector: Add toggles for debugger pauses at console.assert failures
108         https://bugs.webkit.org/show_bug.cgi?id=139542
109         <rdar://problem/19281600>
110
111         Reviewed by Timothy Hatcher.
112
113         * UserInterface/Controllers/DebuggerManager.js:
114         (WebInspector.DebuggerManager.prototype.get assertionsBreakpoint):
115         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
116         (WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):
117         New breakpoint and toggling behavior.
118
119         * Localizations/en.lproj/localizedStrings.js:
120         * UserInterface/Views/DebuggerSidebarPanel.js:
121         (WebInspector.DebuggerSidebarPanel):
122         (WebInspector.DebuggerSidebarPanel.prototype._breakpointTreeOutlineDeleteTreeElement):
123         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements.isSpecialBreakpoint):
124         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):
125         New breakpoint tree element behavior.
126
127         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
128         (WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
129         Sidebar restoration if it was selected.
130
131         * UserInterface/Images/Assertion.svg: Added.
132         * UserInterface/Images/gtk/Assertion.svg: Added.
133         * UserInterface/Views/BreakpointTreeElement.css:
134         (.breakpoint-assertion-icon .icon):
135         New sidebar icon for the global breakpoint.
136
137 2016-10-15  Joseph Pecoraro  <pecoraro@apple.com>
138
139         Web Inspector: Cleanup parts of DebuggerManager
140         https://bugs.webkit.org/show_bug.cgi?id=163400
141
142         Reviewed by Timothy Hatcher.
143
144         * UserInterface/Controllers/DebuggerManager.js:
145         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
146
147         (WebInspector.DebuggerManager.prototype.get paused):
148         (WebInspector.DebuggerManager.prototype.get pauseReason):
149         (WebInspector.DebuggerManager.prototype.get pauseData):
150         (WebInspector.DebuggerManager.prototype.get callFrames):
151         (WebInspector.DebuggerManager.prototype.get activeCallFrame):
152         (WebInspector.DebuggerManager.prototype.set activeCallFrame):
153         Put simple accessors at the top.
154
155         (WebInspector.DebuggerManager.prototype.get allExceptionsBreakpoint):
156         (WebInspector.DebuggerManager.prototype.get allUncaughtExceptionsBreakpoint):
157         (WebInspector.DebuggerManager.prototype.get breakpoints):
158         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
159         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
160         (WebInspector.DebuggerManager.prototype.isBreakpointRemovable):
161         (WebInspector.DebuggerManager.prototype.isBreakpointEditable):
162         (WebInspector.DebuggerManager.prototype.get breakpointsDisabledTemporarily):
163         Group public breakpoint state and access methods.
164
165         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
166         (WebInspector.DebuggerManager.prototype.scriptsForURL):
167         (WebInspector.DebuggerManager.prototype.get searchableScripts):
168         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
169         Group public script access methods.
170
171         (WebInspector.DebuggerManager.prototype.pause):
172         (WebInspector.DebuggerManager.prototype.resume):
173         (WebInspector.DebuggerManager.prototype.stepOver):
174         (WebInspector.DebuggerManager.prototype.stepInto):
175         (WebInspector.DebuggerManager.prototype.stepOut):
176         (WebInspector.DebuggerManager.prototype.continueToLocation):
177         (WebInspector.DebuggerManager.prototype.addBreakpoint):
178         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
179         Group and modernize public methods that perform actions.
180
181         (WebInspector.DebuggerManager.prototype.nextBreakpointActionIdentifier):
182         Misc. methods.
183
184         (WebInspector.DebuggerManager.prototype.breakpointResolved):
185         (WebInspector.DebuggerManager.prototype.reset):
186         (WebInspector.DebuggerManager.prototype.playBreakpointActionSound):
187         (WebInspector.DebuggerManager.prototype.scriptDidParse):
188         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
189         (WebInspector.DebuggerManager.prototype._setBreakpoint):
190         (WebInspector.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
191         (WebInspector.DebuggerManager.prototype._updateBreakOnExceptionsState):
192         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
193         Minor cleanup in protected and private methods.
194
195         * UserInterface/Models/BreakpointAction.js:
196         (WebInspector.BreakpointAction):
197         Getting the next identifier is an action so it should be a function call.
198
199         * UserInterface/Views/SourceCodeTextEditor.js:
200         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
201         Remove unused parameter.
202
203 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
204
205         Web Inspector: Dragging to delete a Breakpoint should never trigger a ContentView change
206         https://bugs.webkit.org/show_bug.cgi?id=163403
207         <rdar://problem/28762930>
208
209         Reviewed by Timothy Hatcher.
210
211         * UserInterface/Views/BreakpointTreeElement.js:
212         (WebInspector.BreakpointTreeElement.prototype.ondelete):
213         Signal when a breakpoint tree element will be going away because it was
214         deleted via the keyboard operation within the TreeOutline. This is a dirty
215         way to do the signal but we remove BreakpointTreeElements asynchronously
216         when the Breakpoint actually gets removed from the backend.
217
218         * UserInterface/Views/DebuggerSidebarPanel.js:
219         (WebInspector.DebuggerSidebarPanel.prototype._removeDebuggerTreeElement):
220         Deselect a BreakpointTreeElement if it was deleted in a way other then
221         the delete keyboard shortcut. This ensures another TreeElement selection
222         doesn't force ContentView changes.
223
224 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
225
226         Web Inspector: Improve debugger highlight when inside of getter/setter calls
227         https://bugs.webkit.org/show_bug.cgi?id=163428
228         <rdar://problem/28769061>
229
230         Reviewed by Timothy Hatcher.
231
232         * UserInterface/Views/SourceCodeTextEditor.js:
233         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
234         When in the middle of a member expression at a '.' or '[' get the best member
235         expression range.
236
237         * UserInterface/Views/TextEditor.js:
238         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
239         Include the character at the current position. This is useful since AST Nodes
240         don't give us token info but we would like to know if we are at particular tokens.
241
242 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
243
244         Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
245         https://bugs.webkit.org/show_bug.cgi?id=163395
246
247         Reviewed by Timothy Hatcher.
248
249         * UserInterface/Models/Breakpoint.js:
250         (WebInspector.Breakpoint.prototype.get identifier): Renamed.
251         (WebInspector.Breakpoint.prototype.set identifier): Renamed.
252         The only user is DebuggerManager which sets and gets. Previously
253         it was unexpectedly setting a direct property on the Breakpoint
254         instead of using these methods to set the member variable.
255
256 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
257
258         Web Inspector: Remove uses of delete in SourceCodeTextEditor
259         https://bugs.webkit.org/show_bug.cgi?id=163379
260
261         Reviewed by Timothy Hatcher.
262
263         Remove uses of delete and better group member variables.
264         One of the deletes was deleting an incorrect property.
265
266         * UserInterface/Views/SourceCodeTextEditor.js:
267         (WebInspector.SourceCodeTextEditor):
268         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):
269         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointRemoved):
270         (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointMoved):
271         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
272         (WebInspector.SourceCodeTextEditor.prototype._dismissEditingController):
273         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
274
275 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
276
277         Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
278         https://bugs.webkit.org/show_bug.cgi?id=163405
279         <rdar://problem/28763953>
280
281         Reviewed by Matt Baker.
282
283         * UserInterface/Views/SourceCodeTextEditor.js:
284         Use correct method name, the old one must have gone away.
285
286 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
287
288         Web Inspector: Improve support for logging Proxy objects in console
289         https://bugs.webkit.org/show_bug.cgi?id=163323
290         <rdar://problem/28432553>
291
292         Reviewed by Timothy Hatcher.
293
294         * UserInterface/Views/ConsoleMessageView.js:
295         (WebInspector.ConsoleMessageView.prototype._formatParameter):
296         Treat a Proxy like any other object.
297
298 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
299
300         Emit DebugHooks uniformly with pause locations instead of having separate pause locations and op_debug emits
301         https://bugs.webkit.org/show_bug.cgi?id=162809
302
303         Reviewed by Geoffrey Garen.
304
305         * UserInterface/Views/SourceCodeTextEditor.js:
306         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
307         When pausing on the variable assignment inside for..of and for..in don't just
308         highlight "var foo" but include the right hand side "var foo in ..." or
309         "var foo of ...".
310
311 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
312
313         Web Inspector: Whole program sometimes highlighted instead of just first statement
314         https://bugs.webkit.org/show_bug.cgi?id=163300
315         <rdar://problem/28723162>
316
317         Reviewed by Timothy Hatcher.
318
319         * UserInterface/Views/SourceCodeTextEditor.js:
320         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
321         Avoid highlighting the entire program by skipping a Program type Node.
322
323         * UserInterface/Views/TextEditor.js:
324         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
325         Avoid unnecessary work before content has loaded.
326
327         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
328         Avoid unnecessary indirection to get the CodeMirror editor.
329
330 2016-10-11  Joseph Pecoraro  <pecoraro@apple.com>
331
332         Web Inspector: Remove line highlight on primary execution line while stepping because it is distracting
333         https://bugs.webkit.org/show_bug.cgi?id=163294
334         <rdar://problem/28721176>
335
336         Reviewed by Timothy Hatcher.
337
338         * UserInterface/Views/TextEditor.js:
339         (WebInspector.TextEditor.prototype._updateExecutionLine):
340         When setting the primary execution line, remove default line highlights.
341
342 2016-10-10  Matt Baker  <mattbaker@apple.com>
343
344         Web Inspector: Revealed line not highlighted in TextEditor while debugger paused
345         https://bugs.webkit.org/show_bug.cgi?id=163197
346
347         Reviewed by Timothy Hatcher.
348
349         * UserInterface/Views/TextEditor.js:
350         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
351         Avoid highlighting the execution line while debugging, but allow
352         other lines to be highlighted.
353
354 2016-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
355
356         Inspector exception in `parseTextForRule()` when pasting into CSS rule selector
357         https://bugs.webkit.org/show_bug.cgi?id=162792
358
359         Reviewed by Matt Baker.
360
361         * UserInterface/Views/CSSStyleDeclarationSection.js:
362         (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
363         Changed regular expression for matching CSS rules to allow newlines in pasted text.
364
365 2016-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
366
367         Web Inspector: Clicking twice on the color swatch square should hide the color picker
368         https://bugs.webkit.org/show_bug.cgi?id=162759
369
370         Reviewed by Matt Baker.
371
372         * UserInterface/Views/InlineSwatch.js:
373         (WebInspector.InlineSwatch):
374         (WebInspector.InlineSwatch.prototype.didDismissPopover):
375         (WebInspector.InlineSwatch.prototype._swatchElementClicked):
376         Remove the "click" event listener when a popover is presented to prevent improper
377         interaction.  Add the event listener back when the popover is dismissed.
378
379 2016-10-02  Matt Baker  <mattbaker@apple.com>
380
381         Web Inspector: Exception thrown when hovering network waterfall graphs during reload
382         https://bugs.webkit.org/show_bug.cgi?id=162850
383         <rdar://problem/28579653>
384
385         Reviewed by Brian Burg.
386
387         * UserInterface/Views/ResourceTimelineDataGridNode.js:
388         (WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
389         Check that the node's data grid reference is valid before use.
390         (WebInspector.ResourceTimelineDataGridNode):
391
392 2016-10-01  Joseph Pecoraro  <pecoraro@apple.com>
393
394         Web Inspector: Selection does not show up over execution highlight ranges
395         https://bugs.webkit.org/show_bug.cgi?id=162844
396         <rdar://problem/28579121>
397
398         Reviewed by Matt Baker.
399
400         * Scripts/update-codemirror-resources.rb:
401         * UserInterface/External/CodeMirror/mark-selection.js: Added.
402         * UserInterface/Main.html:
403         New add-on that makes selection a text marker so it can be styled
404         at the same level as other text markers.
405
406         * UserInterface/Views/TextEditor.css:
407         (.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext)):
408         Don't use execution-range-highlight styles if the text is selected.
409
410         * UserInterface/Views/TextEditor.js:
411         (WebInspector.TextEditor):
412         Enable the text selection as text markers addon.
413
414 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
415
416         Web Inspector: Make debugger stepping highlights work in inline <script>s
417         https://bugs.webkit.org/show_bug.cgi?id=162753
418         <rdar://problem/28551332>
419
420         Reviewed by Brian Burg.
421
422         * UserInterface/Models/TextRange.js:
423         (WebInspector.TextRange.prototype.contains):
424         Check if a given line/column falls within this range.
425
426         * UserInterface/Views/SourceCodeTextEditor.js:
427         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
428         If we are in a Document resource find the associated script at a given position.
429
430         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
431         When comparing offsets to SyntaxTree offsets, the SyntaxTree's offset of 0 is the
432         first character of the Script, which differs from the current SourceCode's offset.
433         Adjust the offset by the Script's startOffset.
434
435         * UserInterface/Views/TextEditor.js:
436         (WebInspector.TextEditor.prototype.currentPositionToOriginalPosition):
437         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
438         Pass both the original offset and original position to the delegate.
439
440 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
441
442         Web Inspector: Stepping through `a(); b(); c();` it is unclear where we are and what is about to execute
443         https://bugs.webkit.org/show_bug.cgi?id=161658
444         <rdar://problem/28181254>
445
446         Reviewed by Geoffrey Garen.
447
448         * UserInterface/Models/Script.js:
449         (WebInspector.Script.prototype.requestScriptSyntaxTree):
450         Fix first calls to requestScriptSyntaxTree. They were getting an uncaught
451         exception because the content argument was missing.
452
453         * UserInterface/Models/ScriptSyntaxTree.js:
454         (WebInspector.ScriptSyntaxTree.prototype.containersOfOffset):
455         Find all AST nodes that contain a particular offset.
456
457         * UserInterface/Views/SourceCodeTextEditor.js:
458         (WebInspector.SourceCodeTextEditor):
459         (WebInspector.SourceCodeTextEditor.prototype.close):
460         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):
461         (WebInspector.SourceCodeTextEditor.prototype._activeCallFrameSourceCodeLocationChanged):
462         (WebInspector.SourceCodeTextEditor.prototype.textEditorExecutionHighlightRange):
463         Provide a good highlight range for a given offset. This is normally the start
464         of a statement/expression, inside a statement/expression, or the closing brace
465         of a function (leaving a function). Provide good ranges for each of these.
466
467         * UserInterface/Views/TextEditor.js:
468         (WebInspector.TextEditor):
469         (WebInspector.TextEditor.set string.update):
470         (WebInspector.TextEditor.prototype.set string):
471         (WebInspector.TextEditor.prototype.setExecutionLineAndColumn):
472         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
473         (WebInspector.TextEditor.prototype.revealPosition):
474         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
475         (WebInspector.TextEditor.prototype._updateAfterFormatting):
476         (WebInspector.TextEditor.prototype.set executionLineNumber): Deleted.
477         (WebInspector.TextEditor.prototype.set executionColumnNumber): Deleted.
478         (WebInspector.TextEditor.prototype._updateExecutionLine.update): Deleted.
479         Always set the execution line and column together, to simplify how we update highlights.
480
481         (WebInspector.TextEditor.prototype._clearMultilineExecutionLineHighlights):
482         (WebInspector.TextEditor.prototype._updateExecutionLine):
483         When updating the main highlight clear any multi-line highlights.
484
485         (WebInspector.TextEditor.prototype._updateExecutionRangeHighlight):
486         Ask the delegate for a specific highlight range. If provided use that range,
487         otherwise just highlight the end of the line. Once we know the range, if it
488         is multiple lines, give the extra lines the full line highlight as well.
489         Also make adjustments, such as not highlighting trailing whitespace.
490
491         * UserInterface/Views/TextEditor.css:
492         (.text-editor > .CodeMirror .execution-line.primary .CodeMirror-linenumber::after):
493         (.text-editor > .CodeMirror .execution-line):
494         (.text-editor > .CodeMirror .execution-line .CodeMirror-matchingbracket):
495         (.text-editor > .CodeMirror .execution-range-highlight):
496         Styles for execution lines and execution range highlights.
497
498 2016-09-29  Aaron Chu  <aaron_chu@apple.com>
499
500         Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
501         https://bugs.webkit.org/show_bug.cgi?id=130600
502         <rdar://problem/16391333>
503
504         Reviewed by Brian Burg.
505
506         Removing link style for non-navigable nodes by first
507         checking nodeType of the node.
508
509         * UserInterface/Base/DOMUtilities.js:
510         (WebInspector.linkifyNodeReference):
511
512 2016-09-27  Matt Baker  <mattbaker@apple.com>
513
514         Web Inspector: Refreshing while in Timelines-tab causes negative timestamps in Network-tab
515         https://bugs.webkit.org/show_bug.cgi?id=160051
516         <rdar://problem/27480122>
517
518         Reviewed by Brian Burg.
519
520         * UserInterface/Views/NetworkGridContentView.js:
521         (WebInspector.NetworkGridContentView.prototype.get startTime):
522         (WebInspector.NetworkGridContentView.prototype.get zeroTime):
523         Use the cached start time for graph data source properties instead of
524         relying on the ruler, which requires a layout in order to be updated
525         for the first time.
526
527 2016-09-27  Matt Baker  <mattbaker@apple.com>
528
529         Web Inspector: Unfocusing / Focusing inspector window should not change ContentView
530         https://bugs.webkit.org/show_bug.cgi?id=162572
531         <rdar://problem/28479562>
532
533         Reviewed by Brian Burg.
534
535         Improve NavigationSidebarPanel logic for coordinating selection between trees.
536         When tree selection changes, the most recent selection should be restored
537         the next time the tree is focused.
538
539         The sidebar should also handle focusing a tree for the first time, in
540         which no previous selection exists, and focusing a tree that has had its
541         previous selection filtered out (hidden).
542
543         * UserInterface/Views/NavigationSidebarPanel.js:
544         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineDidFocus):
545         (WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
546         Restoring the last deselected element, instead of the last selected element
547         only works when the selection is moving from one tree to another. When
548         the elements belong to the same tree the newly selected element won't
549         be saved until the next selection change. If the window loses and regains
550         the focus before then, the tree will restore the previous selection,
551         effectively reverting the last selection change.
552
553 2016-09-27  Tomas Popela  <tpopela@redhat.com>
554
555         [GTK] Mac defaults are used for key shortcuts on Linux
556         https://bugs.webkit.org/show_bug.cgi?id=162564
557
558         Don't set Mac's default keymap as a fallthrough for CodeMirror when we
559         are not on Mac.
560
561         Reviewed by Carlos Garcia Campos.
562
563         * UserInterface/Test.html: Include Platform.js for the
564         WebInspector.Platform definition.
565         * UserInterface/Views/CodeMirrorAdditions.js:
566
567 2016-09-26  Matt Baker  <mattbaker@apple.com>
568
569         Web Inspector: Box Model values not updated when DOM node styles change
570         https://bugs.webkit.org/show_bug.cgi?id=162525
571
572         Reviewed by Brian Burg.
573
574         The Box Model section should refresh itself when the selected node's
575         computed style changes. This is necessary since the Styles sidebar
576         doesn't always refresh its sections on node changes.
577
578         * UserInterface/Views/BoxModelDetailsSectionRow.js:
579         (WebInspector.BoxModelDetailsSectionRow.prototype.set nodeStyles):
580         Refresh metrics whenever the computed style changes.
581
582         (WebInspector.BoxModelDetailsSectionRow.prototype._getBox):
583         (WebInspector.BoxModelDetailsSectionRow.prototype._getComponentSuffix):
584         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createValueElement):
585         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
586         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
587         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):
588         Drive-by cleanup to make this large function easier to read.
589         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement): Deleted.
590         Renamed createValueElement.
591         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaWidthElement): Deleted.
592         (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaHeightElement): Deleted.
593         Combined these into a single function taking a property name (width or height).
594
595 == Rolled over to ChangeLog-2016-09-26 ==