Web Inspector: RTL: go-to arrows and expand triangles in Computed panel should match...
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog-2014-11-19
1 2014-11-13  Andres Gomez  <agomez@igalia.com>
2
3         Web Inspector: Replace PDF icon with SVG version
4         https://bugs.webkit.org/show_bug.cgi?id=137296
5
6         Reviewed by Timothy Hatcher.
7
8         Add another free icon for the Web Inspector in GTK+.
9
10         * UserInterface/Images/gtk/NavigationItemProbes.svg: Added.
11
12 2014-11-13  Timothy Hatcher  <timothy@apple.com>
13
14         Web Inspector: Replace PDF Probes icon with SVG version
15         https://bugs.webkit.org/show_bug.cgi?id=137296
16
17         Reviewed by Joseph Pecoraro.
18
19         * UserInterface/Images/NavigationItemProbes.pdf: Removed.
20         * UserInterface/Images/NavigationItemProbes.svg: Added.
21         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
22         (WebInspector.ProbeDetailsSidebarPanel): Use NavigationItemProbes.svg.
23
24 2014-11-12  Joseph Pecoraro  <pecoraro@apple.com>
25
26         Web Inspector: Reduce work when activating multiple agents sequentially
27         https://bugs.webkit.org/show_bug.cgi?id=138677
28
29         Reviewed by Timothy Hatcher.
30
31         * UserInterface/Base/Main.js:
32         (WebInspector.activateExtraDomains):
33         * UserInterface/Controllers/FrameResourceManager.js:
34         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
35         * UserInterface/Controllers/StorageManager.js:
36         (WebInspector.StorageManager.prototype._extraDomainsActivated):
37
38 2014-11-11  Joseph Pecoraro  <pecoraro@apple.com>
39
40         Web Inspector: Handle activating extra agents properly after inspector has connected
41         https://bugs.webkit.org/show_bug.cgi?id=138639
42
43         Reviewed by Timothy Hatcher.
44
45         * UserInterface/Base/Main.js:
46         (WebInspector.activateExtraDomains):
47
48 2014-11-11  Jonathan Wells  <jonowells@apple.com>
49
50         Web Inspector: Main.js missing many trailing semicolons
51         https://bugs.webkit.org/show_bug.cgi?id=138624
52
53         Add semicolons to function variable assignments.
54
55         Reviewed by Timothy Hatcher.
56
57         * UserInterface/Base/Main.js: Added semicolons.
58
59 2014-11-10  Jonathan Wells  <jonowells@apple.com>
60
61         Web Inspector: Update Esprima, remove WebInspector.Esprima global.
62         https://bugs.webkit.org/show_bug.cgi?id=138579
63
64         Reviewed by Timothy Hatcher.
65
66         Update esprima.js file to be unchanged by removing WebInspector.Esprima global object. Move esprima.js include
67         so that all external libraries load before the WebInspector namespace is declared in the combined Main.js.
68
69         * UserInterface/External/Esprima/esprima.js: File updated, no changes made.
70         * UserInterface/Main.html: esprima.js script tag moved up with other externals.
71         * UserInterface/Models/ScriptSyntaxTree.js: WebInspector.Esprima changed to esprima
72         (WebInspector.ScriptSyntaxTree):
73
74 2014-11-10  Jonathan Wells  <jonowells@apple.com>
75
76         Web Inspector: Add infrastructure for eslint based static analyzer
77         https://bugs.webkit.org/show_bug.cgi?id=137890
78
79         Reviewed by Timothy Hatcher.
80
81         Fix to previous patch to add AnalyzerManager and AnalyzerMessage classes. Changed Main.html to include ESLint.js
82         before Main.js in the combined resources.
83
84         * UserInterface/Base/Main.js:
85         * UserInterface/Controllers/AnalyzerManager.js: Added.
86         (WebInspector.AnalyzerManager):
87         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
88         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
89         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
90         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
91         * UserInterface/Main.html:
92         * UserInterface/Models/AnalyzerMessage.js: Added.
93         (WebInspector.AnalyzerMessage):
94         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
95         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
96         (WebInspector.AnalyzerMessage.prototype.get text):
97         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
98         * UserInterface/Models/SourceCode.js:
99
100 2014-11-08  Matt Baker  <mattbaker@apple.com>
101
102         Web Inspector: decouple child element folderization logic from FrameTreeElement
103         https://bugs.webkit.org/show_bug.cgi?id=138364
104
105         Reviewed by Timothy Hatcher.
106
107         Created FolderizedTreeElement base class, which FrameTreeElement now inherits via SourceCodeTreeElement.
108         FolderizedTreeElement uses settings provided by derived classes for labeling subfolders and to determine
109         folder membership for child items.
110
111         * UserInterface/Base/Main.js:
112         (WebInspector.canArchiveMainFrame):
113         * UserInterface/Main.html:
114         * UserInterface/Models/LayoutTimelineRecord.js:
115         (WebInspector.LayoutTimelineRecord.displayNameForEventType):
116         (WebInspector.LayoutTimelineRecord.EventType.displayName): Deleted.
117         * UserInterface/Models/Resource.js:
118         (WebInspector.Resource):
119         (WebInspector.Resource.typeFromMIMEType):
120         (WebInspector.Resource.displayNameForType):
121         (WebInspector.Resource.prototype.get syntheticMIMEType):
122         (WebInspector.Resource.prototype.updateForResponse):
123         (WebInspector.Resource.Type.fromMIMEType): Deleted.
124         (WebInspector.Resource.Type.displayName): Deleted.
125         * UserInterface/Models/SourceMapResource.js:
126         (WebInspector.SourceMapResource):
127         * UserInterface/Views/FolderizedTreeElement.js: Added.
128         (WebInspector.FolderizedTreeElement):
129         (WebInspector.FolderizedTreeElement.prototype.get groupedIntoFolders):
130         (WebInspector.FolderizedTreeElement.prototype.set folderSettingsKey):
131         (WebInspector.FolderizedTreeElement.prototype.registerFolderizeSettings):
132         (WebInspector.FolderizedTreeElement.prototype.set removeChildren):
133         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject):
134         (WebInspector.FolderizedTreeElement.prototype.addRepresentedObjectToNewChildQueue):
135         (WebInspector.FolderizedTreeElement.prototype.removeChildForRepresentedObject):
136         (WebInspector.FolderizedTreeElement.prototype.compareChildTreeElements):
137         (WebInspector.FolderizedTreeElement.prototype.updateParentStatus):
138         (WebInspector.FolderizedTreeElement.prototype._clearNewChildQueue):
139         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
140         (WebInspector.FolderizedTreeElement.prototype._removeRepresentedObjectFromNewChildQueue):
141         (WebInspector.FolderizedTreeElement.prototype._addTreeElement):
142         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
143         (WebInspector.FolderizedTreeElement.prototype._insertFolderTreeElement):
144         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
145         (WebInspector.FolderizedTreeElement.prototype._removeTreeElement):
146         (WebInspector.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
147         (WebInspector.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange):
148         (WebInspector.FolderizedTreeElement.prototype._settingsForRepresentedObject):
149         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
150         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
151         * UserInterface/Views/FrameTreeElement.js:
152         (.this):
153         (WebInspector.FrameTreeElement.prototype.updateSourceMapResources):
154         (WebInspector.FrameTreeElement.prototype.onattach):
155         (WebInspector.FrameTreeElement.prototype.ondetach):
156         (WebInspector.FrameTreeElement.prototype.compareChildTreeElements):
157         (WebInspector.FrameTreeElement.prototype.onpopulate):
158         (WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
159         (WebInspector.FrameTreeElement.prototype._resourceWasAdded):
160         (WebInspector.FrameTreeElement.prototype._resourceWasRemoved):
161         (WebInspector.FrameTreeElement.prototype._childFrameWasAdded):
162         (WebInspector.FrameTreeElement.prototype._childFrameWasRemoved):
163         (WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
164         (WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
165         (WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
166         (WebInspector.FrameTreeElement): Deleted.
167         (WebInspector.FrameTreeElement.prototype.removeChildren): Deleted.
168         (WebInspector.FrameTreeElement.prototype._updateParentStatus): Deleted.
169         (WebInspector.FrameTreeElement.prototype._addRepresentedObjectToNewChildQueue): Deleted.
170         (WebInspector.FrameTreeElement.prototype._removeRepresentedObjectFromNewChildQueue): Deleted.
171         (WebInspector.FrameTreeElement.prototype._populateFromNewChildQueue): Deleted.
172         (WebInspector.FrameTreeElement.prototype._clearNewChildQueue): Deleted.
173         (WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject): Deleted.
174         (WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject): Deleted.
175         (WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject): Deleted.
176         (WebInspector.FrameTreeElement.prototype._addTreeElement): Deleted.
177         (WebInspector.FrameTreeElement.prototype._compareTreeElementsByMainTitle): Deleted.
178         (WebInspector.FrameTreeElement.prototype._insertFolderTreeElement): Deleted.
179         (WebInspector.FrameTreeElement.prototype._compareResourceTreeElements): Deleted.
180         (WebInspector.FrameTreeElement.prototype._insertResourceTreeElement): Deleted.
181         (WebInspector.FrameTreeElement.prototype._removeTreeElement): Deleted.
182         (WebInspector.FrameTreeElement.prototype._folderNameForResourceType): Deleted.
183         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject.createFolderTreeElement): Deleted.
184         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject): Deleted.
185         (WebInspector.FrameTreeElement.prototype._folderTreeElementExpandedStateChange): Deleted.
186         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType): Deleted.
187         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory): Deleted.
188         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders): Deleted.
189         * UserInterface/Views/LayoutTimelineDataGridNode.js:
190         (WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
191         * UserInterface/Views/LayoutTimelineView.js:
192         (WebInspector.LayoutTimelineView): Deleted.
193         * UserInterface/Views/NetworkTimelineView.js:
194         (WebInspector.NetworkTimelineView): Deleted.
195         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
196         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshResourceType):
197         * UserInterface/Views/ResourceTimelineDataGridNode.js:
198         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
199         * UserInterface/Views/SourceCodeTreeElement.js:
200         (WebInspector.SourceCodeTreeElement):
201         * UserInterface/Views/TimelineDataGrid.js:
202         (WebInspector.TimelineDataGrid.createColumnScopeBar):
203         * UserInterface/Views/TimelineRecordTreeElement.js:
204         (WebInspector.TimelineRecordTreeElement):
205         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
206         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
207
208 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
209
210         Web Inspector: Layer summary should be bottom sticky
211         https://bugs.webkit.org/show_bug.cgi?id=138518
212
213         Reviewed by Timothy Hatcher.
214
215         Previously only NavigationSidebars had a content view. Now, give all
216         Sidebars a contentElement section for content.
217
218         Update all Details Sidebars to append content to the contentElement
219         instead of directly to the element. Only two Details sidebars append
220         to the element:
221
222           - CSSStyleDetailsSidebarPanel for the navigation bar at the top
223           - LayerTreeDetailsSidebarPanel for the summary view at the bottom
224
225         Take this opportunity to fix up some naming and styles as well.
226
227         * UserInterface/Views/SidebarPanel.js:
228         (WebInspector.SidebarPanel):
229         (WebInspector.SidebarPanel.prototype.get contentElement):
230         Give every SidebarPanel a content element.
231
232         * UserInterface/Views/DetailsSidebarPanel.css: Removed.
233         (.sidebar > .panel > .content):
234         * UserInterface/Views/SidebarPanel.css: Added.
235         (.sidebar > .panel > .content):
236         And give that content element a default style.
237
238         * UserInterface/Views/NavigationSidebarPanel.css:
239         (.sidebar > .panel.navigation > .content):
240         * UserInterface/Views/NavigationSidebarPanel.js:
241         (WebInspector.NavigationSidebarPanel):
242         (WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
243         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
244         (WebInspector.NavigationSidebarPanel.prototype.get contentElement): Deleted.
245         Navigation sidebar panels now use the parent's contentElement.
246         Also, carry over their default styles, overriding the base.
247
248         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js.
249         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildLayerInfoSection):
250         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
251         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildBottomBar):
252         Rename LayerTreeSidebarPanel to make it clear this is a DetailsSidebarPanel.
253         Add the "bottom bar" to the root element, and sections to the contentElement.
254
255         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css.
256         (.sidebar > .layer-tree.panel > .content):
257         (body.mac-platform.legacy .sidebar > .layer-tree.panel > .content):
258         Style the bottom bar to pin it to the bottom of the sidebar panel.
259
260         (WebInspector.CSSStyleDetailsSidebarPanel):
261         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
262         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
263         Add the navigation bar to the root element, and sections to the contentElement.
264
265         * UserInterface/Base/Main.js:
266         (WebInspector.contentLoaded):
267         * UserInterface/Main.html:
268         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
269         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
270         Update for new names.
271
272         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
273         (WebInspector.ApplicationCacheDetailsSidebarPanel):
274         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
275         * UserInterface/Views/DOMDetailsSidebarPanel.js:
276         (WebInspector.DOMDetailsSidebarPanel):
277         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
278         (WebInspector.DOMNodeDetailsSidebarPanel):
279         * UserInterface/Views/DetailsSidebarPanel.js:
280         (WebInspector.DetailsSidebarPanel):
281         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
282         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
283         (WebInspector.ResourceDetailsSidebarPanel):
284         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
285         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
286         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
287         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
288         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh.delayedWork):
289         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
290         All details sidebar panels now use the contentElement instead of element for content.
291
292 2014-11-07  Timothy Hatcher  <timothy@apple.com>
293
294         Web Inspector: Cursor and scroll view jumps around when modifying styles
295         https://bugs.webkit.org/show_bug.cgi?id=137467
296
297         This merges commit e2962a5b0df56c8ee5a4482899d308decf3d7677 from CodeMirror.
298
299         Reviewed by Joseph Pecoraro.
300
301         * UserInterface/External/CodeMirror/codemirror.js:
302         (maybeScrollWindow): Signal the scrollCursorIntoView event.
303         (signalDOMEvent): Support string events by transforming them to event objects.
304
305         * UserInterface/Views/CodeMirrorAdditions.js:
306         (scrollCursorIntoView): Added. Default event listener that provides our own
307         implementation using WebKit's scrollIntoViewIfNeeded.
308
309         * UserInterface/Views/RulesStyleDetailsPanel.js:
310         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Stop doing an
311         extra scrollIntoViewIfNeeded call, CodeMirror does this.
312
313 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
314
315         Web Inspector: Pseudo element matchedCSSRules do not include matching selector info
316         https://bugs.webkit.org/show_bug.cgi?id=138438
317
318         Reviewed by Benjamin Poulain.
319
320         * UserInterface/Base/Test.js:
321         (WebInspector.loaded):
322         Include a global setting for shadow dom used by DOM model classes.
323         Give it a "test" specific name to not override non-test setting values.
324
325 2014-11-05  Commit Queue  <commit-queue@webkit.org>
326
327         Unreviewed, rolling out r175628.
328         https://bugs.webkit.org/show_bug.cgi?id=138451
329
330         Totally borked the web inspector (Requested by smfr on
331         #webkit).
332
333         Reverted changeset:
334
335         "Web Inspector: Add infrastructure for eslint based static
336         analyzer"
337         https://bugs.webkit.org/show_bug.cgi?id=137890
338         http://trac.webkit.org/changeset/175628
339
340 2014-11-05  Joseph Pecoraro  <pecoraro@apple.com>
341
342         Web Inspector: Specificity not shown for pseudo element styles
343         https://bugs.webkit.org/show_bug.cgi?id=138436
344
345         Reviewed by Benjamin Poulain.
346
347         * UserInterface/Views/CSSStyleDeclarationSection.js:
348         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
349         Previously we were skipping the pre-selector <span>s when we were
350         not getting a listing of matched selector indices, and missing out
351         on the opportunity to give each selector a specificity. Now, always
352         loop over selectors if we have them.
353
354 2014-11-05  Jonathan Wells  <jonowells@apple.com>
355
356         Web Inspector: Add infrastructure for eslint based static analyzer
357         https://bugs.webkit.org/show_bug.cgi?id=137890
358
359         Reviewed by Timothy Hatcher.
360
361         Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.
362
363         * UserInterface/Base/Main.js: Create analyzerManager singleton.
364         * UserInterface/Controllers/AnalyzerManager.js: Added.
365         (WebInspector.AnalyzerManager):
366         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
367         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
368         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
369         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
370         * UserInterface/Main.html: Add new files.
371         * UserInterface/Models/AnalyzerMessage.js: Added.
372         (WebInspector.AnalyzerMessage):
373         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
374         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
375         (WebInspector.AnalyzerMessage.prototype.get text):
376         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
377         * UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().
378
379 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
380
381         Web Inspector: Too much whitespace in resource details sidebar in groups
382         https://bugs.webkit.org/show_bug.cgi?id=138386
383
384         Reviewed by Timothy Hatcher.
385
386         * UserInterface/Views/DetailsSection.css:
387         (.details-section > .content > .group:first-child > .row.simple:first-child > *):
388         (body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *):
389         (body.mac-platform.legacy .details-section > .content > .group > .row.text):
390         (.details-section > .content > .group > .row.properties:not(.empty)):
391         (body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)):
392         Adjust top and bottom padding.
393
394 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
395
396         Web Inspector: Lots of TimelineDataGridNode asserts on reloads
397         https://bugs.webkit.org/show_bug.cgi?id=138387
398
399         Reviewed by Brian Burg.
400
401         The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
402         with a non-0 value and saved in a setting. However the TimelineRuler in
403         the OverviewTimelineView is not initialized with this value, and instead
404         initialized to 0. This patch initializes them to the same non-0 value.
405
406         * UserInterface/Views/OverviewTimelineView.js:
407         (WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):
408         * UserInterface/Views/TimelineContentView.js:
409
410 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
411
412         Web Inspector: Pause on exceptions should show the actual exception
413         https://bugs.webkit.org/show_bug.cgi?id=63096
414
415         Reviewed by Timothy Hatcher.
416
417         * Localizations/en.lproj/localizedStrings.js:
418         * UserInterface/Main.html:
419         New strings / files.
420
421         * UserInterface/Controllers/DebuggerManager.js:
422         (WebInspector.DebuggerManager.prototype.get pauseReason):
423         (WebInspector.DebuggerManager.prototype.get pauseData):
424         (WebInspector.DebuggerManager.prototype.reset):
425         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
426         (WebInspector.DebuggerManager.prototype._pauseReasonFromPayload):
427         Maintain the current pause reason and auxiliary data in the manager.
428
429         * UserInterface/Protocol/DebuggerObserver.js:
430         (WebInspector.DebuggerObserver.prototype.paused):
431         Pass previously unused event parameters on to the manager.
432
433         * UserInterface/Views/ConsoleMessageImpl.js:
434         (WebInspector.ConsoleMessageImpl):
435         Style error objects in the console like Objects. The new description
436         string provides a richer message if you console.log(exception).
437
438         * UserInterface/Views/DebuggerSidebarPanel.js:
439         (WebInspector.DebuggerSidebarPanel):
440         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
441         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
442         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
443         Update the UI when we pause / resume to show / hide a pause reason section.
444
445         * UserInterface/Views/DetailsSectionRow.js:
446         (WebInspector.DetailsSectionRow.prototype.set emptyMessage):
447         Fix a latent bug that would have thrown an exception if the setter was ever used.
448
449         * UserInterface/Views/DetailsSectionTextRow.js: Added.
450         (WebInspector.DetailsSectionTextRow):
451         (WebInspector.DetailsSectionTextRow.prototype.get text):
452         (WebInspector.DetailsSectionTextRow.prototype.set text):
453         * UserInterface/Views/DetailsSection.css:
454         (.details-section > .content > .group > .row.simple.data > .value):
455         (.details-section > .content > .group > .row.text):
456         Simple class for a section of centered text. This is modelled after
457         the empty message text style in other sections.
458
459         * UserInterface/Views/LogContentView.css:
460         (.console-formatted-object, .console-formatted-node, .console-formatted-error):
461         (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-error .section):
462         (.console-formatted-object .properties, .console-formatted-node .properties, .console-formatted-error .properties):
463         Style "error" objects like regular objects. We may wish to treat differently later.
464
465         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
466         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
467         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
468         Regenerate legacy backend commands to get the new enum.
469
470 2014-11-04  Andrei Bucur  <abucur@adobe.com>
471
472         Building WebInspectorUI should not run the clang static analyzer by default
473         https://bugs.webkit.org/show_bug.cgi?id=137652
474
475         Reviewed by Timothy Hatcher.
476
477         There's no need to have the static analyzer enabled at compile time by default for the WebInspectorUI project.
478         It also breaks the ASAN build because the static analyzing step runs using the default compiler not the
479         ASAN clang.
480
481         * Configurations/DebugRelease.xcconfig: Remove the RUN_CLANG_STATIC_ANALYZER variable.
482
483 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
484
485         Web Inspector: Uncaught Exceptions when paused and hovering JavaScript without CallFrames
486         https://bugs.webkit.org/show_bug.cgi?id=138338
487
488         Reviewed by Geoffrey Garen.
489
490         * UserInterface/Views/SourceCodeTextEditor.js:
491         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
492         Fallback to using the main page's context if there is no active call frame we can use.
493
494 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
495
496         Web Inspector: TextEditor search doesn't work after editing contents
497         https://bugs.webkit.org/show_bug.cgi?id=138198
498
499         Reviewed by Timothy Hatcher.
500
501         * UserInterface/Views/SourceCodeTextEditor.js:
502         (WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
503         Fallback to pure TextEditor content searching (CodeMirror) if the editor has edits.
504
505         * UserInterface/Views/TextEditor.js:
506         (WebInspector.TextEditor.prototype.hasEdits):
507         Check the CodeMirror clean state to known if we have edits or not.
508
509 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
510
511         Web Inspector: Show Selector's Specificity
512         https://bugs.webkit.org/show_bug.cgi?id=138189
513
514         Reviewed by Timothy Hatcher.
515
516         * Localizations/en.lproj/localizedStrings.js:
517         * UserInterface/Main.html:
518         * UserInterface/Test.html:
519         Add new files and strings.
520
521         * UserInterface/Models/CSSMedia.js:
522         Constructor functions are not needed, remove unnecessary code.
523
524         * UserInterface/Models/CSSRule.js:
525         (WebInspector.CSSRule.prototype.set selectors): Deleted.
526         This was unused and is no longer correct.
527
528         (WebInspector.CSSRule.prototype.get matchedSelectorText):
529         Update now that selectors are a list of objects, not just strings.
530
531         * UserInterface/Models/CSSSelector.js:
532         (WebInspector.CSSSelector):
533         (WebInspector.CSSSelector.prototype.get specificity):
534         New model object for protocol type CSS.CSSSelector.
535
536         * UserInterface/Models/DOMNodeStyles.js:
537         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
538         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
539         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
540         Handle parsing old and new SelectorLists.
541
542         * UserInterface/Views/CSSStyleDeclarationSection.js:
543         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
544         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelectorText):
545         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
546         Update the code now that the list of selectors are model objects instead
547         of just selector text strings.
548
549 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
550
551         Web Inspector: ALTERNATE_DISPATCHERS Let the frontend know about extra agents
552         https://bugs.webkit.org/show_bug.cgi?id=138236
553
554         Reviewed by Brian Burg.
555
556         * UserInterface/Protocol/InspectorBackend.js:
557         (InspectorBackendClass.prototype.activateDomain):
558         * UserInterface/Protocol/InspectorObserver.js:
559         (WebInspector.InspectorObserver.prototype.activateExtraDomains):
560         * UserInterface/Base/Object.js:
561         * UserInterface/Base/Test.js:
562         * UserInterface/Base/Main.js:
563         (WebInspector.activateExtraDomains):
564         Default state is that there are no extra domains. When extra domains
565         are activated, some agents need to be re-initialized. Dispatch a
566         model event so views also know to re-initialize.
567
568         * UserInterface/Controllers/ApplicationCacheManager.js:
569         (WebInspector.ApplicationCacheManager.prototype._mainResourceDidChange):
570         * UserInterface/Controllers/DOMTreeManager.js:
571         Be more careful about direct agent use during main resource changes.
572         That can happen with a JSContext extended with a Page agent.
573
574         * UserInterface/Controllers/FrameResourceManager.js:
575         (WebInspector.FrameResourceManager):
576         (WebInspector.FrameResourceManager.prototype._mainFrameDidChange):
577         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
578         * UserInterface/Controllers/StorageManager.js:
579         (WebInspector.StorageManager):
580         (WebInspector.StorageManager.prototype._databaseForIdentifier):
581         (WebInspector.StorageManager.prototype._extraDomainsActivated):
582         It is possible new window.FooAgent's are available. Perform expected
583         initialization re-checking if the agents are now available.
584
585         * UserInterface/Models/CSSCompletions.js:
586         Avoid re-initialization if we already did it. This should never
587         happen but this is just to be safe.
588
589         * UserInterface/Views/ResourceSidebarPanel.js:
590         (WebInspector.ResourceSidebarPanel):
591         (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
592         Don't disallow expandable tree elements if this is a JSContext with
593         extra domains. If that JSContext has resources, we would have been
594         unable to see child resources.
595
596 2014-10-30  Dana Burkart  <dburkart@apple.com>
597
598         <rdar://problem/18821260> Prepare for the mysterious future
599
600         Reviewed by Lucas Forschler.
601
602         * Configurations/Base.xcconfig:
603         * Configurations/DebugRelease.xcconfig:
604         * Configurations/Version.xcconfig:
605
606 2014-10-10 Brian J. Burg  <burg@cs.washington.edu>
607
608         Web Inspector: timelines should not count time elapsed while paused in the debugger
609         https://bugs.webkit.org/show_bug.cgi?id=136351
610
611         Reviewed by Timothy Hatcher.
612
613         Don't update the timeline's current time when the debugger is paused.
614
615         Start and end times for timeline records are now in seconds elapsed since timeline
616         recording started, rather than milliseconds since the epoch. Also convert code that
617         tracks page/resource load timings to use elapsed times rather than timestamps.
618
619         Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
620         in multiple agents to elapsed times.
621
622         * UserInterface/Controllers/FrameResourceManager.js:
623         (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
624         (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
625         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
626         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
627         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
628         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
629         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
630         * UserInterface/Controllers/ProbeManager.js:
631         * UserInterface/Controllers/TimelineManager.js:
632         (WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
633         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
634         (WebInspector.TimelineManager.prototype.eventRecorded):
635         (WebInspector.TimelineManager.prototype.pageDidLoad):
636         (WebInspector.TimelineManager.prototype._loadNewRecording):
637         * UserInterface/Models/Probe.js:
638         (WebInspector.ProbeSample):
639         * UserInterface/Models/Resource.js:
640         (WebInspector.Resource.prototype.updateForRedirectResponse):
641         (WebInspector.Resource.prototype.updateForResponse):
642         (WebInspector.Resource.prototype.increaseSize):
643         (WebInspector.Resource.prototype.markAsFinished):
644         (WebInspector.Resource.prototype.markAsFailed):
645         (WebInspector.Resource.prototype.revertMarkAsFinished):
646         * UserInterface/Models/TimelineRecording.js:
647         (WebInspector.TimelineRecording.prototype.computeElapsedTime):
648         * UserInterface/Views/TimelineContentView.js:
649         (WebInspector.TimelineContentView.prototype._debuggerPaused):
650         (WebInspector.TimelineContentView.prototype._debuggerResumed):
651
652
653 2014-10-23  Jono Wells  <jonowells@apple.com>
654
655         Web Inspector: Double border appearing in node sidebar in expanded items in OS X Mavericks.
656         https://bugs.webkit.org/show_bug.cgi?id=138011
657
658         Reviewed by Timothy Hatcher.
659
660         Selector added for OS X Mavericks and earlier versions using .mac-platform.legacy.
661
662         * UserInterface/Views/DetailsSection.css:
663         (body.mac-platform.legacy .details-section .details-section:first-child):
664
665 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
666
667         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
668         https://bugs.webkit.org/show_bug.cgi?id=132044
669
670         Reviewed by Brian Burg.
671
672         Make sure Protocol/InspectorFrontendHostStub.js is loaded before
673         Base/Platform.js, because Platform uses the InspectorFrontendHost
674         object.
675
676         * UserInterface/Main.html:
677
678 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
679
680         Web Inspector: InspectorBackendCommands should include when to activate particular domains
681         https://bugs.webkit.org/show_bug.cgi?id=137753
682
683         Reviewed by Timothy Hatcher.
684
685         * UserInterface/Base/Main.js:
686         * UserInterface/Base/Test.js:
687         (WebInspector.loaded):
688         Activation now happens automatically so remove the hardcoded activations.
689
690         * UserInterface/Protocol/InspectorBackend.js:
691         (InspectorBackendClass.prototype.activateDomain):
692         Given no filter, always activate a domain. Otherwise only activate
693         if the debuggable type matches the provided filter.
694
695         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
696         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
697         Only web debuggables are supported in iOS 6 and 7. The JSON files do not
698         need to change, all agents will auto activate.
699
700         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
701         * Versions/Inspector-iOS-8.0.json:
702         Specify which are web debuggables in iOS 8 since JS inspection is possible.
703
704 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
705
706         Web Inspector: Generate all Inspector domains together in JavaScriptCore
707         https://bugs.webkit.org/show_bug.cgi?id=137748
708
709         Reviewed by Brian Burg.
710
711         Change the frontend to always load all agents, but only activate a subset
712         of the agents depending on the type of the backend.
713
714         * UserInterface/Base/Main.js:
715         (WebInspector.loaded):
716         * UserInterface/Protocol/InspectorBackend.js:
717         (InspectorBackendClass.prototype.activateDomains):
718         (InspectorBackendClass.prototype.activateAllDomains):
719         (InspectorBackendClass.prototype._agentForDomain):
720         (InspectorBackendClass.prototype._dispatchEvent):
721         (InspectorBackend.Agent):
722         (InspectorBackend.Agent.prototype.get active):
723         (InspectorBackend.Agent.prototype.activate):
724         * UserInterface/Base/Test.js:
725         Only expose "window.FooAgent" or allow dispatches in the "Foo" domain
726         when that particular agent is activated. Currently we hardcode the list
727         of agents to activate for a debuggable type. This should be generated.
728
729         * UserInterface/Protocol/LoadInspectorBackendCommands.js:
730         Now there should always be a single "InspectorBackendCommands.js" file to load.
731         We may want to change the RWI path to return a single file instead of an array.
732
733         * Scripts/update-LegacyInspectorBackendCommands.rb:
734         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js.
735         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js.
736         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js.
737         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Removed.
738         * Versions/Inspector-iOS-8.0.json: Renamed from Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json.
739         * Versions/InspectorJS-iOS-8.0.json: Removed.
740         Update Legacy versions to output a single InspectorBackendCommands.js file.
741         Do a straightforward merge of the iOS 8 JS/Web inputs to a single json file.
742
743         * Configurations/Base.xcconfig:
744         * Configurations/DebugRelease.xcconfig:
745         * Configurations/WebInspectorUIFramework.xcconfig:
746         * Scripts/copy-user-interface-resources-dryrun.rb:
747         * Scripts/copy-user-interface-resources.pl:
748         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
749         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
750         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
751         We no longer needed WebCore's Private Headers, so simplify build files
752         and update file names where appropriate.
753
754 2014-10-17  Jono Wells  <jonowells@apple.com>
755
756         Web Inspector: Add ESLint open source library to the inspector
757         https://bugs.webkit.org/show_bug.cgi?id=137714
758
759         Reviewed by Joseph Pecoraro.
760
761         This adds back the eslint.js external library with a correction to Scripts/copy-user-interface-resources.pl
762         to prevent a build failure.
763
764         * Scripts/copy-user-interface-resources.pl: Added copy commands for ESLint.js.
765         * UserInterface/External/ESLint/LICENSE: Added.
766         * UserInterface/External/ESLint/eslint.js: Added.
767
768 2014-10-14  Jono Wells  <jonowells@apple.com>
769
770         Web Inspector: Add ESLint open source library to the inspector
771         https://bugs.webkit.org/show_bug.cgi?id=137714
772
773         Reviewed by Timothy Hatcher.
774
775         This adds the eslint.js external library for static analysis and the necessary license.
776
777         * Scripts/copy-user-interface-resources.pl:
778         * UserInterface/External/ESLint/LICENSE: Added.
779         * UserInterface/External/ESLint/eslint.js: Added.
780
781 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
782
783         Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
784         https://bugs.webkit.org/show_bug.cgi?id=137575
785
786         Reviewed by Simon Fraser.
787
788         Remove setShowPaintRects from the legacy iOS protocol definitions.
789         The methods were unimplemented by the backends, so they should
790         not advertise supporting it.
791
792         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
793         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
794         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
795         * Versions/Inspector-iOS-6.0.json:
796         * Versions/Inspector-iOS-7.0.json:
797         * Versions/InspectorWeb-iOS-8.0.json:
798
799 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
800
801         Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
802         https://bugs.webkit.org/show_bug.cgi?id=137681
803
804         Reviewed by Timothy Hatcher.
805
806         Handle processing instruction node types in more places. The
807         backend sends the contents as a pure string, not as attribute
808         pairs, so just include the string in the UI.
809
810         * UserInterface/Models/DOMSearchMatchObject.js:
811         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
812         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
813         * UserInterface/Views/DOMTreeElement.js:
814         (WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
815         Display the value in the UI.
816
817         * UserInterface/Views/DOMTreeElementPathComponent.js:
818         (WebInspector.DOMTreeElementPathComponent):
819         Include an icon like DOCTYPE.
820
821         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
822         (.syntax-highlighted .html-processing-instruction):
823         Style gray like a DOCTYPE.
824
825 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
826
827         Web Inspector: Paint Flashing button does not match page state after reload
828         https://bugs.webkit.org/show_bug.cgi?id=137680
829
830         Reviewed by Timothy Hatcher.
831
832         * UserInterface/Base/Main.js:
833         (WebInspector.loaded):
834         Make paint flashing a frontend setting. Enable it when the inspector
835         is opened if it was previously enabled.
836
837         * UserInterface/Views/DOMTreeContentView.js:
838         (WebInspector.DOMTreeContentView):
839         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
840         (WebInspector.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
841         Have the paint flashing button always match the global setting.
842
843 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
844
845         Web Inspector: Improve appearance of alpha color swatches
846         https://bugs.webkit.org/show_bug.cgi?id=137627
847
848         Reviewed by Andreas Kling.
849
850         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
851         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
852         * Versions/Inspector-iOS-7.0.json:
853         * Versions/InspectorWeb-iOS-8.0.json:
854
855 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
856
857         Web Inspector: Improve appearance of alpha color swatches
858         https://bugs.webkit.org/show_bug.cgi?id=137627
859
860         Reviewed by Timothy Hatcher.
861
862         This improves the sizes. The color-swatch size is 1em x 1em,
863         which ends up being 11px, and thus there is still an imbalance.
864         However on both 1x and 2x displays this looks more even.
865
866         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
867         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
868
869 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
870
871         Web Inspector: assert always logs undefined instead of the desired string
872         https://bugs.webkit.org/show_bug.cgi?id=137632
873
874         Reviewed by Timothy Hatcher.
875
876         * UserInterface/Protocol/InspectorFrontendAPI.js:
877         (InspectorFrontendAPI.dispatch):
878         Fix the assert log to include the method name.
879
880 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
881
882         Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
883         https://bugs.webkit.org/show_bug.cgi?id=137624
884
885         Reviewed by Timothy Hatcher.
886
887         Be careful when stripping whitespace around "+". We want to strip for
888         selectors "a + b" but not for calc expressions "calc(1px + 2px)".
889
890         This is not a perfect solution, but it does a good job. It may still break
891         with more complex calc expressions, like "calc(1px + calc())" but this
892         handles the basics.
893
894         * Scripts/copy-user-interface-resources-dryrun.rb: Added.
895         * Scripts/cssmin.py:
896         (cssminify):
897
898 2014-10-09  Joseph Pecoraro  <pecoraro@apple.com>
899
900         Web Inspector: DOM Storage Editing is broken in many ways, frustrating
901         https://bugs.webkit.org/show_bug.cgi?id=137547
902
903         Reviewed by Timothy Hatcher.
904
905         * UserInterface/Models/DOMStorageObject.js:
906         (WebInspector.DOMStorageObject.prototype.getEntries): Deleted.
907         When getting entires, populate the model object with these keys/values
908         so we can accurately detect duplicates in editing.
909
910         * UserInterface/Views/DataGrid.js:
911         (WebInspector.DataGrid.prototype.determineNextCell):
912         (WebInspector.DataGrid.prototype.moveToNextCell):
913         When the users uses "Enter" to commit, stop editing.
914
915         (WebInspector.DataGrid.prototype._editingCommitted):
916         Fix title property accessor. This is not a map. This fixes an exception
917         when showing context menus on editable data grid rows.
918
919         * UserInterface/Views/DOMStorageContentView.js:
920         (WebInspector.DOMStorageContentView.prototype.cleanup):
921         (WebInspector.DOMStorageContentView.prototype.restoreOriginalValues):
922         (WebInspector.DOMStorageContentView.prototype._editingCallback):
923         Completely rewrite editing here. As soon as an edit is made, enter
924         an uncommitted state with the original key/value. When a commit is
925         allowed, update as appropriate based on the original values.
926
927 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
928
929         Web Inspector: CSS Pretty Printing fails to put space between value functions around ending parenthesis
930         https://bugs.webkit.org/show_bug.cgi?id=137415
931
932         Reviewed by Timothy Hatcher.
933
934         Add a space after a closing parenthesis if we are still inside a property.
935         This adds space between space separated function lists such as
936         -webkit-transform:foo(...)bar(...). Also add a test for keyframe syntax.
937
938         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
939         * Tools/PrettyPrinting/css-tests/keyframes-expected.css: Added.
940         * Tools/PrettyPrinting/css-tests/keyframes.css: Added.
941         * Tools/PrettyPrinting/index.html:
942         * UserInterface/Views/CodeMirrorFormatters.js:
943
944 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
945
946         Web Inspector: CSS Pretty Printing fails to put space between rgb(...) and numbers in minified gradients
947         https://bugs.webkit.org/show_bug.cgi?id=137414
948
949         Reviewed by Timothy Hatcher.
950
951         Add whitespace between rgb(...) and a number, possible in gradient
952         syntax like "linear-gradient(rgb(...)0%,rgb(...)100%)".
953
954         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
955         * Tools/PrettyPrinting/css-tests/gradient-expected.css: Added.
956         (.dot-nav:nth-child(1n) li a.active):
957         * Tools/PrettyPrinting/css-tests/gradient.css: Added.
958         (.dot-nav:nth-child(1n) li a.active):
959         * Tools/PrettyPrinting/index.html:
960         * UserInterface/Views/CodeMirrorFormatters.js:
961
962 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
963
964         Web Inspector: CSS Pretty Printing fails to wrap long lines of selectors with pseudo classes/elements
965         https://bugs.webkit.org/show_bug.cgi?id=137413
966
967         Reviewed by Timothy Hatcher.
968
969         Long line wrapping was breaking as soon as there was a ':' for a psuedo
970         class or element. Likewise it was counting comment strings as part of
971         the length of the line even though it would get a newline after it.
972
973         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
974         * Tools/PrettyPrinting/css-tests/basic-expected.css:
975         (progress, section, summary, time):
976         * Tools/PrettyPrinting/css-tests/wrapping-expected.css: Added.
977         (a.tryamacs, a.upgradenows):
978         (a.tryamacs:hover, a.upgradenows:hover):
979         * Tools/PrettyPrinting/css-tests/wrapping.css: Added.
980         (a.browsewebappss,a.businessstores,a.buyiphones,a.buynows,a.buynows-arrow,a.comingsoons,p::before,a.descargarahoras,a.downloadituness,a.downloadnows,a.finds,a.freetrials,a.getstarteds,a.gos,a.howtoapplys,a.howtobuys,a.joinnows,a.learnmores,a.nikebuynows,a.notifymes,a.ordernows,a.preordernows,a.preorders,a.reserves,a.startyoursearchs,a.submits,a.tryamacs,a.upgradenows):
981         (a.browsewebappss:hover,a.businessstores:hover,a.buyiphones:hover,a.buynows:hover,a.buynows-arrow:hover,a.comingsoons:hover,p::before,a.descargarahoras:hover,a.downloadituness:hover,a.downloadnows:hover,a.finds:hover,a.freetrials:hover,a.getstarteds:hover,a.gos:hover,a.howtoapplys:hover,a.howtobuys:hover,a.joinnows:hover,a.learnmores:hover,a.nikebuynows:hover,a.notifymes:hover,a.ordernows:hover,a.preordernows:hover,a.preorders:hover,a.reserves:hover,a.startyoursearchs:hover,a.submits:hover,a.tryamacs:hover,a.upgradenows:hover):
982         * Tools/PrettyPrinting/index.html:
983         * UserInterface/Views/CodeMirrorFormatters.js:
984
985 2014-10-04  Joseph Pecoraro  <pecoraro@apple.com>
986
987         Web Inspector: Add PrettyPrinter CSS tests
988         https://bugs.webkit.org/show_bug.cgi?id=134005
989
990         Reviewed by Timothy Hatcher.
991
992         Add CSS pretty printing tests. Improve pretty printing of calc()
993         expressions and media-queries with whitespace around operators
994         and keywords. Also fix the debug output in the tool for CSS.
995
996         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
997         * Tools/PrettyPrinting/FormatterContentBuilder.js:
998         (FormatterContentBuilder.prototype._appendIndent):
999         * Tools/PrettyPrinting/FormatterDebug.js:
1000         (.debugToken):
1001         (Formatter.prototype.debug):
1002         * Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
1003         * Tools/PrettyPrinting/css-tests/basic.css: Added.
1004         * Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
1005         * Tools/PrettyPrinting/css-tests/calc.css: Added.
1006         * Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
1007         * Tools/PrettyPrinting/css-tests/media-query.css: Added.
1008         * Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
1009         * Tools/PrettyPrinting/css-tests/selectors.css: Added.
1010         * Tools/PrettyPrinting/index.html:
1011         * UserInterface/Views/CodeMirrorFormatters.js:
1012
1013 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
1014
1015         Unreviewed, rolling out r174319.
1016
1017         Causes assertions in fast/profiler tests. Needs nontrivial
1018         investigation, will take offline.
1019
1020         Reverted changeset:
1021
1022         "Web Inspector: timelines should not count time elapsed while
1023         paused in the debugger"
1024         https://bugs.webkit.org/show_bug.cgi?id=136351
1025         http://trac.webkit.org/changeset/174319
1026
1027 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
1028
1029         Web Inspector: timelines should not count time elapsed while paused in the debugger
1030         https://bugs.webkit.org/show_bug.cgi?id=136351
1031
1032         Reviewed by Timothy Hatcher.
1033
1034         Don't update the timeline's current time when the debugger is paused.
1035
1036         Start and end times for timeline records are now in seconds elapsed since timeline
1037         recording started, rather than milliseconds since the epoch. Add a workaround to
1038         preserve compatibility with old backends.
1039
1040         * UserInterface/Controllers/TimelineManager.js:
1041         (WebInspector.TimelineManager.prototype.capturingStarted):
1042         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
1043         (WebInspector.TimelineManager.prototype.eventRecorded):
1044         * UserInterface/Views/TimelineContentView.js:
1045         (WebInspector.TimelineContentView.prototype._debuggerPaused):
1046         (WebInspector.TimelineContentView.prototype._debuggerResumed):
1047
1048 2014-10-03  Saam Barati  <saambarati1@gmail.com>
1049
1050         Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
1051         https://bugs.webkit.org/show_bug.cgi?id=137295
1052
1053         Reviewed by Timothy Hatcher.
1054
1055         The inspector now computes a set of properties that was previously 
1056         computed inside JSC. 
1057
1058         This patch also addresses the weird experience of the 
1059         type of an expression claiming to be both a Number and 
1060         an Integer. This could be a bit confusing because Number 
1061         is supposed to represent Double|Integer and the previous
1062         UI implied that Number was equivalent to Double. The new UI only 
1063         ever shows either the type of Number or Integer when showing
1064         the type information of an expression. It never shows both Number
1065         and Integer simultaneously to describe a single expression.
1066
1067         * UserInterface/Models/TypeSet.js:
1068         (WebInspector.TypeSet):
1069         (WebInspector.TypeSet.prototype.isContainedIn):
1070         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
1071         * UserInterface/Views/TypePropertiesSection.js:
1072         (WebInspector.TypePropertiesSection):
1073         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1074         * UserInterface/Views/TypeTokenView.js:
1075         (WebInspector.TypeTokenView):
1076         (WebInspector.TypeTokenView.prototype.update):
1077         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1078         (WebInspector.TypeTokenView.prototype._displayTypeName):
1079
1080 2014-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1081
1082         Web Inspector: Cannot add a new CSS Rule to elements with 3 or more class names
1083         https://bugs.webkit.org/show_bug.cgi?id=137375
1084
1085         Reviewed by Timothy Hatcher.
1086
1087         Correctly merge all class names with dots instead of just the first two.
1088
1089         * UserInterface/Models/DOMNode.js:
1090
1091 2014-10-02  Mark Lam  <mark.lam@apple.com>
1092
1093         Fixed the Inspector to be able to properly distinguish between scope types.
1094         <https://webkit.org/b/137279>
1095
1096         Reviewed by Geoffrey Garen and Joseph Pecoraro.
1097
1098         * Localizations/en.lproj/localizedStrings.js:
1099         * UserInterface/Controllers/DebuggerManager.js:
1100         * UserInterface/Models/ScopeChainNode.js:
1101         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1102         - Added handling of the FunctionNameScope case.
1103
1104 2014-10-02  Andres Gomez  <agomez@igalia.com>
1105
1106         Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
1107         https://bugs.webkit.org/show_bug.cgi?id=137248
1108
1109         Reviewed by Carlos Garcia Campos.
1110
1111         Add more free icons and removed some unused ones for the Web
1112         Inspector in GTK+.
1113         Also, enhanced the visibility and/or proportion of several of the
1114         icons.
1115
1116         * UserInterface/Images/gtk/AUTHORS:
1117         * UserInterface/Images/gtk/COPYING:
1118         * UserInterface/Images/gtk/Checkers.svg: Added.
1119         * UserInterface/Images/gtk/Circle.svg: Added.
1120         * UserInterface/Images/gtk/CloseLarge.svg: Added.
1121         * UserInterface/Images/gtk/CloseTimeline.png: Removed.
1122         * UserInterface/Images/gtk/CloseTimeline@2x.png: Removed.
1123         * UserInterface/Images/gtk/Crosshair.svg:
1124         * UserInterface/Images/gtk/DOMCharacterData.svg:
1125         * UserInterface/Images/gtk/DOMComment.svg:
1126         * UserInterface/Images/gtk/DOMDocument.svg:
1127         * UserInterface/Images/gtk/DOMDocumentType.svg:
1128         * UserInterface/Images/gtk/DOMElement.svg:
1129         * UserInterface/Images/gtk/DOMNode.svg:
1130         * UserInterface/Images/gtk/DOMTextNode.svg:
1131         * UserInterface/Images/gtk/DOMTree.svg:
1132         * UserInterface/Images/gtk/EventListener.svg:
1133         * UserInterface/Images/gtk/Exception.svg:
1134         * UserInterface/Images/gtk/Function.svg:
1135         * UserInterface/Images/gtk/GradientStop.png: Added.
1136         * UserInterface/Images/gtk/GradientStop@2x.png: Added.
1137         * UserInterface/Images/gtk/GradientStopSelected.png: Added.
1138         * UserInterface/Images/gtk/GradientStopSelected@2x.png: Added.
1139         * UserInterface/Images/gtk/Issues.svg:
1140         * UserInterface/Images/gtk/IssuesEnabled.svg:
1141         * UserInterface/Images/gtk/LessColumns.svg: Removed.
1142         * UserInterface/Images/gtk/Logs.svg:
1143         * UserInterface/Images/gtk/Memory.svg: Removed.
1144         * UserInterface/Images/gtk/MoreColumns.svg: Removed.
1145         * UserInterface/Images/gtk/Native.svg:
1146         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
1147         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
1148         * UserInterface/Images/gtk/NavigationItemBug.svg:
1149         * UserInterface/Images/gtk/NavigationItemFile.svg:
1150         * UserInterface/Images/gtk/NavigationItemLayers.svg:
1151         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
1152         * UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
1153         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
1154         * UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
1155         * UserInterface/Images/gtk/PaintFlashing.svg: Added.
1156         * UserInterface/Images/gtk/PseudoElement.svg:
1157         * UserInterface/Images/gtk/Record.svg: Added.
1158         * UserInterface/Images/gtk/Recording.png: Removed.
1159         * UserInterface/Images/gtk/Recording@2x.png: Removed.
1160         * UserInterface/Images/gtk/RecordingHovered.png: Removed.
1161         * UserInterface/Images/gtk/RecordingHovered@2x.png: Removed.
1162         * UserInterface/Images/gtk/RecordingStopped.png: Removed.
1163         * UserInterface/Images/gtk/RecordingStopped@2x.png: Removed.
1164         * UserInterface/Images/gtk/Reflection.svg:
1165         * UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
1166         * UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
1167         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
1168         * UserInterface/Images/gtk/Request.svg:
1169         * UserInterface/Images/gtk/Resources.svg:
1170         * UserInterface/Images/gtk/Response.svg:
1171         * UserInterface/Images/gtk/ResultLine.svg:
1172         * UserInterface/Images/gtk/SourceCode.svg:
1173         * UserInterface/Images/gtk/Stop.svg: Added.
1174         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
1175         * UserInterface/Images/gtk/StyleRuleInherited.svg:
1176         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
1177         * UserInterface/Images/gtk/StyleRuleInspector.svg:
1178         * UserInterface/Images/gtk/StyleRuleUser.svg:
1179         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
1180         * UserInterface/Images/gtk/Time.svg:
1181         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
1182         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
1183         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
1184         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
1185         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
1186         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
1187         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
1188         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
1189         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
1190         * UserInterface/Images/gtk/Weight.svg:
1191
1192 2014-09-27  Brian J. Burg  <burg@cs.washington.edu>
1193
1194         Web Replay: Playback position updates should be sent before the next event loop input is dispatched
1195         https://bugs.webkit.org/show_bug.cgi?id=137162
1196
1197         Reviewed by Timothy Hatcher.
1198
1199         Pausing playback from the UI was broken because of a typo. Fix this, and rename
1200         stopPlayback to cancelPlayback.
1201
1202         * UserInterface/Controllers/ReplayManager.js:
1203         (WebInspector.ReplayManager.prototype.switchSession.if):
1204
1205 2014-09-26  Joseph Pecoraro  <pecoraro@apple.com>
1206
1207         Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
1208         https://bugs.webkit.org/show_bug.cgi?id=137038
1209
1210         Reviewed by Timothy Hatcher.
1211
1212         * UserInterface/Base/Main.js:
1213         Send the initialized message after we have sent all other setup messages,
1214         such as enabling features and setting breakpoints.
1215
1216 2014-09-26  Saam Barati  <saambarati1@gmail.com>
1217
1218         Web Inspector: Type Token View shows type information on hover when it shouldn't
1219         https://bugs.webkit.org/show_bug.cgi?id=137152
1220
1221         Reviewed by Brian J. Burg.
1222
1223         TypeTokenView should only show type information when there is 
1224         more than one primitive type or more than zero objects types. 
1225         This fixes a bug in checking the length of object types.
1226
1227         * UserInterface/Views/TypeTokenView.js:
1228         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1229
1230 2014-09-25  Timothy Hatcher  <timothy@apple.com>
1231
1232         Web Inspector: Show type info icon is blurry
1233         https://bugs.webkit.org/show_bug.cgi?id=137125
1234
1235         Reviewed by Darin Adler.
1236
1237         * UserInterface/Images/NavigationItemTypes.svg:
1238         * UserInterface/Views/ScriptContentView.js:
1239         (WebInspector.ScriptContentView):
1240         * UserInterface/Views/TextContentView.js:
1241         (WebInspector.TextContentView):
1242         * UserInterface/Views/TextResourceContentView.js:
1243         (WebInspector.TextResourceContentView):
1244
1245 2014-09-25  Saam Barati  <saambarati1@gmail.com>
1246
1247         Web Inspector: console.assert(bitString) TypeSet:50 
1248         https://bugs.webkit.org/show_bug.cgi?id=137051
1249
1250         Reviewed by Joseph Pecoraro.
1251
1252         This fixes TypeSet's isContainedIn method by ensuring that 
1253         the type bit string isn't zero because the test would trivially 
1254         pass if the bit string is zero.
1255
1256         * UserInterface/Models/TypeSet.js:
1257         (WebInspector.TypeSet.prototype.isContainedIn):
1258
1259 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1260
1261         Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
1262         https://bugs.webkit.org/show_bug.cgi?id=136805
1263
1264         Reviewed by Timothy Hatcher.
1265
1266         * UserInterface/Test.html: Add missing include for ScopeChainNode.js.
1267
1268 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1269
1270         Web Inspector: sort probe details sidebar sections by source code location string
1271         https://bugs.webkit.org/show_bug.cgi?id=137080
1272
1273         Reviewed by Timothy Hatcher.
1274
1275         Probe sections should display in the same order as associated breakpoint tree elements.
1276
1277         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1278         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
1279         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
1280
1281 2014-09-25  Andres Gomez  <agomez@igalia.com>
1282
1283         Unreviewed. Add more free icons for the Web Inspector in GTK+.
1284
1285         * UserInterface/Images/gtk/AUTHORS:
1286         * UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
1287         * UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Added.
1288         * UserInterface/Images/gtk/COPYING:
1289         * UserInterface/Images/gtk/COPYING_LGPL2: Added.
1290         * UserInterface/Images/gtk/Cookie.png: Added.
1291         * UserInterface/Images/gtk/Cookie@2x.png: Added.
1292         * UserInterface/Images/gtk/HoverMenuButton.png: Added.
1293         * UserInterface/Images/gtk/HoverMenuButton@2x.png: Added.
1294         * UserInterface/Images/gtk/InstructionPointer.png: Added.
1295         * UserInterface/Images/gtk/InstructionPointer@2x.png: Added.
1296         * UserInterface/Images/gtk/Log.png: Added.
1297         * UserInterface/Images/gtk/Log@2x.png: Added.
1298         * UserInterface/Images/gtk/Profile.png: Added.
1299         * UserInterface/Images/gtk/Profile@2x.png: Added.
1300         * UserInterface/Images/gtk/Recording.png: Added.
1301         * UserInterface/Images/gtk/Recording@2x.png: Added.
1302         * UserInterface/Images/gtk/RecordingHovered.png: Added.
1303         * UserInterface/Images/gtk/RecordingHovered@2x.png: Added.
1304         * UserInterface/Images/gtk/RecordingStopped.png: Added.
1305         * UserInterface/Images/gtk/RecordingStopped@2x.png: Added.
1306         * UserInterface/Images/gtk/Script.png: Added.
1307         * UserInterface/Images/gtk/Script@2x.png: Added.
1308         * UserInterface/Images/gtk/ScriptLarge.png: Added.
1309         * UserInterface/Images/gtk/ScriptLarge@2x.png: Added.
1310         * UserInterface/Images/gtk/SliderThumb.png: Added.
1311         * UserInterface/Images/gtk/SliderThumb@2x.png: Added.
1312         * UserInterface/Images/gtk/SliderThumbPressed.png: Added.
1313         * UserInterface/Images/gtk/SliderThumbPressed@2x.png: Added.
1314         * UserInterface/Images/gtk/Stopwatch.png: Added.
1315         * UserInterface/Images/gtk/Stopwatch@2x.png: Added.
1316
1317 2014-09-21  Timothy Hatcher  <timothy@apple.com>
1318
1319         Make the Web Inspector use a separate web process.
1320
1321         https://bugs.webkit.org/show_bug.cgi?id=135120
1322
1323         Reviewed by Anders Carlsson.
1324
1325         * Localizations/en.lproj/localizedStrings.js: Updated.
1326
1327         * UserInterface/Base/Main.js:
1328         (WebInspector.loaded):
1329         (WebInspector.contentLoaded):
1330         Move InspectorFrontendHost.loaded to later in the load.
1331         Calling it early just shows the window before we have
1332         a user interface to show.
1333
1334         * UserInterface/Base/Test.js:
1335         (WebInspector.loaded):
1336         (WebInspector.contentLoaded):
1337         Match the changes in Main.js.
1338
1339         * UserInterface/Protocol/InspectorFrontendAPI.js:
1340         (InspectorFrontendAPI.savedURL): Change comment.
1341         (InspectorFrontendAPI.appendedToURL): Change comment.
1342         (InspectorFrontendAPI.dispatch): Add an assert and early
1343         return to be safe from unknown commands.
1344         (InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
1345         no need to keep an empty array around a one time use.
1346
1347 2014-09-24  Andres Gomez  <agomez@igalia.com>
1348
1349         Unreviewed. Add more free icons for the Web Inspector in GTK+
1350
1351         * UserInterface/Images/gtk/AUTHORS:
1352         * UserInterface/Images/gtk/ApplicationCache.png: Added.
1353         * UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
1354         * UserInterface/Images/gtk/BottomUpTree.svg: Added.
1355         * UserInterface/Images/gtk/Breakpoint.png: Added.
1356         * UserInterface/Images/gtk/Breakpoint@2x.png: Added.
1357         * UserInterface/Images/gtk/BreakpointButton.svg:
1358         * UserInterface/Images/gtk/BreakpointInactive.png: Added.
1359         * UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
1360         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
1361         * UserInterface/Images/gtk/COPYING:
1362         * UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
1363         * UserInterface/Images/gtk/ClippingCSS.png: Added.
1364         * UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
1365         * UserInterface/Images/gtk/ClippingGeneric.png: Added.
1366         * UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
1367         * UserInterface/Images/gtk/ClippingJS.png: Added.
1368         * UserInterface/Images/gtk/ClippingJS@2x.png: Added.
1369         * UserInterface/Images/gtk/CloseTimeline.png: Added.
1370         * UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
1371         * UserInterface/Images/gtk/ColorIcon.png: Added.
1372         * UserInterface/Images/gtk/ColorIcon@2x.png: Added.
1373         * UserInterface/Images/gtk/Colors.png: Added.
1374         * UserInterface/Images/gtk/Colors@2x.png: Added.
1375         * UserInterface/Images/gtk/ColorsLarge.png: Added.
1376         * UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
1377         * UserInterface/Images/gtk/Database.png: Added.
1378         * UserInterface/Images/gtk/Database@2x.png: Added.
1379         * UserInterface/Images/gtk/DatabaseTable.png: Added.
1380         * UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
1381         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
1382         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
1383         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
1384         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
1385         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
1386         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
1387         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
1388         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
1389         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
1390         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
1391         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
1392         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
1393         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
1394         * UserInterface/Images/gtk/Issues.svg: Added.
1395         * UserInterface/Images/gtk/IssuesEnabled.svg: Added.
1396         * UserInterface/Images/gtk/LayerBorders.svg: Added.
1397         * UserInterface/Images/gtk/LessColumns.svg: Added.
1398         * UserInterface/Images/gtk/LocalStorage.png: Added.
1399         * UserInterface/Images/gtk/LocalStorage@2x.png: Added.
1400         * UserInterface/Images/gtk/Locked.svg: Added.
1401         * UserInterface/Images/gtk/Logs.svg: Added.
1402         * UserInterface/Images/gtk/Memory.svg: Added.
1403         * UserInterface/Images/gtk/MoreColumns.svg: Added.
1404         * UserInterface/Images/gtk/Native.svg: Added.
1405         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
1406         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
1407         * UserInterface/Images/gtk/NavigationItemBug.svg: Added.
1408         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
1409         * UserInterface/Images/gtk/NavigationItemFile.svg: Added.
1410         * UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
1411         * UserInterface/Images/gtk/NavigationItemLog.svg: Added.
1412         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
1413         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
1414         * UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
1415         * UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
1416         * UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
1417         * UserInterface/Images/gtk/Network.png: Added.
1418         * UserInterface/Images/gtk/Network@2x.png: Added.
1419         * UserInterface/Images/gtk/NetworkLarge.png: Added.
1420         * UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
1421         * UserInterface/Images/gtk/Pause.svg: Added.
1422         * UserInterface/Images/gtk/Percent.svg: Added.
1423         * UserInterface/Images/gtk/Plus.svg: Added.
1424         * UserInterface/Images/gtk/PseudoElement.svg: Added.
1425         * UserInterface/Images/gtk/Reflection.svg: Added.
1426         * UserInterface/Images/gtk/Reload.svg: Added.
1427         * UserInterface/Images/gtk/Request.svg: Added.
1428         * UserInterface/Images/gtk/Response.svg: Added.
1429         * UserInterface/Images/gtk/ResultLine.svg: Added.
1430         * UserInterface/Images/gtk/Resume.svg: Added.
1431         * UserInterface/Images/gtk/SessionStorage.png: Added.
1432         * UserInterface/Images/gtk/SessionStorage@2x.png: Added.
1433         * UserInterface/Images/gtk/ShadowDOM.svg: Added.
1434         * UserInterface/Images/gtk/SourceCode.svg: Added.
1435         * UserInterface/Images/gtk/SplitToggleDown.svg: Added.
1436         * UserInterface/Images/gtk/SplitToggleUp.svg: Added.
1437         * UserInterface/Images/gtk/StepInto.svg: Added.
1438         * UserInterface/Images/gtk/StepOut.svg: Added.
1439         * UserInterface/Images/gtk/StepOver.svg: Added.
1440         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
1441         * UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
1442         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
1443         * UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
1444         * UserInterface/Images/gtk/StyleRuleUser.svg: Added.
1445         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
1446         * UserInterface/Images/gtk/Time.svg: Added.
1447         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
1448         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
1449         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
1450         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
1451         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
1452         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
1453         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
1454         * UserInterface/Images/gtk/Undock.svg: Added.
1455         * UserInterface/Images/gtk/UserInputPrompt.svg: Added.
1456         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
1457         * UserInterface/Images/gtk/UserInputResult.svg: Added.
1458         * UserInterface/Images/gtk/Warning.svg: Added.
1459         * UserInterface/Images/gtk/Weight.svg: Added.
1460
1461 2014-09-23  Timothy Hatcher  <timothy@apple.com>
1462
1463         Web Inspector: Remove UserInterface/Images/gtk from Apple builds
1464         https://bugs.webkit.org/show_bug.cgi?id=136955
1465
1466         Reviewed by Joseph Pecoraro.
1467
1468         * Scripts/copy-user-interface-resources.pl:
1469         Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
1470         at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.
1471
1472 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1473
1474         Web Inspector: fix TypeSet hierarchy in TypeTokenView
1475         https://bugs.webkit.org/show_bug.cgi?id=136982
1476
1477         Reviewed by Joseph Pecoraro.
1478
1479         The protocol object representation of TypeSet was being computed 
1480         incorrectly in JSC::TypeSet. This patch fixes that problem
1481         and also asserts that the type information that the Web Inspector
1482         receives is not empty.
1483
1484         * UserInterface/Models/TypeSet.js:
1485         (WebInspector.TypeSet):
1486         * UserInterface/Views/TypeTokenView.js:
1487         (WebInspector.TypeTokenView.prototype._displayTypeName):
1488
1489 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1490
1491         Web Inspector: unlocalized 'many' string in type profiler inline bubble
1492         https://bugs.webkit.org/show_bug.cgi?id=136980
1493
1494         Reviewed by Timothy Hatcher.
1495
1496         Generate the localizable string for the type profiler's "many" inline bubble.
1497
1498         * Localizations/en.lproj/localizedStrings.js:
1499         * UserInterface/Views/TypeTokenView.js:
1500
1501 2014-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1502
1503         Web Inspector: Option+Click on CSS url(...) should jump to resource view
1504         https://bugs.webkit.org/show_bug.cgi?id=136965
1505
1506         Reviewed by Timothy Hatcher.
1507
1508         * UserInterface/Views/CodeMirrorAdditions.js:
1509         When parsing CSS url(...) tokens, the contents of url(...)
1510         are a "string" type, not "atom".
1511
1512 2014-09-19  Daniel Bates  <dabates@apple.com>
1513
1514         Always assume internal SDK when building configuration Production
1515         https://bugs.webkit.org/show_bug.cgi?id=136925
1516         <rdar://problem/18362399>
1517
1518         Reviewed by Dan Bernstein.
1519
1520         * Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig
1521         to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
1522         (e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).
1523
1524 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1525
1526         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1527         https://bugs.webkit.org/show_bug.cgi?id=136632
1528
1529         Reviewed by Gustavo Noronha Silva.
1530
1531         Add free icons for the GTK port. These icons are from the GNOME
1532         project, some of them adapted by Andres Gomez for the inspector.
1533         This is only a subset of the icons, since we still don't have a
1534         free replacement for all of them, but at least it makes the
1535         inspector kind of usable.
1536
1537         * UserInterface/Images/gtk/AUTHORS: Added.
1538         * UserInterface/Images/gtk/BackArrow.svg: Added.
1539         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
1540         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
1541         * UserInterface/Images/gtk/BreakpointButton.svg: Added.
1542         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
1543         * UserInterface/Images/gtk/Breakpoints.svg: Added.
1544         * UserInterface/Images/gtk/COPYING: Added.
1545         * UserInterface/Images/gtk/Close.svg: Added.
1546         * UserInterface/Images/gtk/CloseWhite.svg: Added.
1547         * UserInterface/Images/gtk/ContentFlow.svg: Added.
1548         * UserInterface/Images/gtk/Crosshair.svg: Added.
1549         * UserInterface/Images/gtk/DOMCharacterData.svg: Added.
1550         * UserInterface/Images/gtk/DOMComment.svg: Added.
1551         * UserInterface/Images/gtk/DOMDocument.svg: Added.
1552         * UserInterface/Images/gtk/DOMDocumentType.svg: Added.
1553         * UserInterface/Images/gtk/DOMElement.svg: Added.
1554         * UserInterface/Images/gtk/DOMNode.svg: Added.
1555         * UserInterface/Images/gtk/DOMTextNode.svg: Added.
1556         * UserInterface/Images/gtk/DOMTree.svg: Added.
1557         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
1558         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
1559         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
1560         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
1561         * UserInterface/Images/gtk/DockBottom.svg: Added.
1562         * UserInterface/Images/gtk/DockRight.svg: Added.
1563         * UserInterface/Images/gtk/DocumentCSS.png: Added.
1564         * UserInterface/Images/gtk/DocumentCSS@2x.png: Added.
1565         * UserInterface/Images/gtk/DocumentFont.png: Added.
1566         * UserInterface/Images/gtk/DocumentFont@2x.png: Added.
1567         * UserInterface/Images/gtk/DocumentGeneric.png: Added.
1568         * UserInterface/Images/gtk/DocumentGeneric@2x.png: Added.
1569         * UserInterface/Images/gtk/DocumentImage.png: Added.
1570         * UserInterface/Images/gtk/DocumentImage@2x.png: Added.
1571         * UserInterface/Images/gtk/DocumentJS.png: Added.
1572         * UserInterface/Images/gtk/DocumentJS@2x.png: Added.
1573         * UserInterface/Images/gtk/DocumentMarkup.png: Added.
1574         * UserInterface/Images/gtk/DocumentMarkup@2x.png: Added.
1575         * UserInterface/Images/gtk/DownloadArrow.svg: Added.
1576         * UserInterface/Images/gtk/Error.svg: Added.
1577         * UserInterface/Images/gtk/Errors.svg: Added.
1578         * UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
1579         * UserInterface/Images/gtk/EventListener.svg: Added.
1580         * UserInterface/Images/gtk/Exception.svg: Added.
1581         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
1582         * UserInterface/Images/gtk/FolderGeneric.png: Added.
1583         * UserInterface/Images/gtk/FolderGeneric@2x.png: Added.
1584         * UserInterface/Images/gtk/ForwardArrow.svg: Added.
1585         * UserInterface/Images/gtk/Function.svg: Added.
1586         * UserInterface/Images/gtk/GoToArrow.svg: Added.
1587         * UserInterface/Images/gtk/Resources.svg: Added.
1588         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
1589         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
1590         * UserInterface/Images/gtk/UpDownArrows.svg: Added.
1591
1592 2014-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1593
1594         Web Inspector: Remove unnecessary prefixes in WebInspectorUI CSS
1595         https://bugs.webkit.org/show_bug.cgi?id=136905
1596
1597         Reviewed by Timothy Hatcher.
1598
1599         Removed vendor prefixes from justify-content and a few lingering
1600         occurances with transition, box-shadow, and display.
1601
1602         * UserInterface/Views/BreakpointActionView.css:
1603         * UserInterface/Views/BreakpointTreeElement.css:
1604         * UserInterface/Views/ButtonNavigationItem.css:
1605         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1606         * UserInterface/Views/ControlToolbarItem.css:
1607         * UserInterface/Views/DebuggerDashboardView.css:
1608         * UserInterface/Views/DefaultDashboardView.css:
1609         * UserInterface/Views/FontResourceContentView.css:
1610         * UserInterface/Views/ImageResourceContentView.css:
1611         * UserInterface/Views/LayerTreeSidebarPanel.css:
1612         * UserInterface/Views/Main.css:
1613         * UserInterface/Views/NavigationBar.css:
1614         * UserInterface/Views/NavigationSidebarPanel.css:
1615         * UserInterface/Views/Popover.css:
1616         * UserInterface/Views/ReplayDashboardView.css:
1617         * UserInterface/Views/Toolbar.css:
1618
1619 2014-09-17  Dean Jackson  <dino@apple.com>
1620
1621         WebInpector can use unprefixed flexbox
1622         https://bugs.webkit.org/show_bug.cgi?id=136899
1623
1624         Reviewed by Joseph Pecoraro.
1625
1626         Now the inspector UI itself can use a non-prefixed flexbox. This was
1627         a basic search and replace for the following properties:
1628         - align-content
1629         - align-items
1630         - align-self
1631         - flex-basis
1632         - flex-direction
1633         - flex-wrap
1634         - flex-grow
1635         - flex-shrink
1636         - flex
1637         - flex-flow
1638         - justify
1639
1640         * UserInterface/Views/ButtonToolbarItem.css:
1641         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1642         * UserInterface/Views/ContentBrowser.css:
1643         * UserInterface/Views/ControlToolbarItem.css:
1644         * UserInterface/Views/DebuggerDashboardView.css:
1645         * UserInterface/Views/DefaultDashboardView.css:
1646         * UserInterface/Views/FilterBar.css:
1647         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
1648         * UserInterface/Views/FontResourceContentView.css:
1649         * UserInterface/Views/HierarchicalPathComponent.css:
1650         * UserInterface/Views/ImageResourceContentView.css:
1651         * UserInterface/Views/LayerTreeSidebarPanel.css:
1652         * UserInterface/Views/LogContentView.css:
1653         * UserInterface/Views/Main.css:
1654         * UserInterface/Views/NavigationBar.css:
1655         * UserInterface/Views/NavigationSidebarPanel.css:
1656         * UserInterface/Views/Popover.css:
1657         * UserInterface/Views/QuickConsole.css:
1658         * UserInterface/Views/ReplayDashboardView.css:
1659         * UserInterface/Views/ResourceSidebarPanel.css:
1660         * UserInterface/Views/Toolbar.css:
1661
1662 2014-09-16  Dean Jackson  <dino@apple.com>
1663
1664         Add unprefixed flexbox display values and property names/values
1665         https://bugs.webkit.org/show_bug.cgi?id=136880
1666         <rdar://problem/18361137>
1667
1668         Reviewed by Benjamin Poulain with some extra comments by Joseph Pecoraro.
1669
1670         * UserInterface/Models/CSSKeywordCompletions.js: Switch to all the unprefixed
1671         flex properties.
1672
1673 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1674
1675         Web Inspector: Add Versioned Inspector protocol JSON files for iOS 8.0
1676         https://bugs.webkit.org/show_bug.cgi?id=136873
1677
1678         Reviewed by Timothy Hatcher.
1679
1680         * Scripts/update-LegacyInspectorBackendCommands.rb:
1681         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Added.
1682         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js: Added.
1683         * Versions/InspectorJS-iOS-8.0.json: Added.
1684         * Versions/InspectorWeb-iOS-8.0.json: Added.
1685
1686 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1687
1688         Web Inspector: Fix ESLint no-extra-bind warnings
1689         https://bugs.webkit.org/show_bug.cgi?id=136659
1690
1691         Reviewed by Timothy Hatcher.
1692
1693         * .eslintrc:
1694         * UserInterface/Controllers/LayerTreeManager.js:
1695         (WebInspector.LayerTreeManager.prototype.layersForNode):
1696
1697 2014-09-15  Matt Baker  <mattbaker@apple.com>
1698
1699         Web Inspector: mouse drifts away from resizer when resizing docked inspector
1700         https://bugs.webkit.org/show_bug.cgi?id=22263
1701
1702         Reviewed by Joseph Pecoraro.
1703
1704         Modified the docked resizer dragging logic to record the initial mouse down position relative to the
1705         resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
1706         correctly with respect to the resize direction before updating the attached window dimension.
1707
1708         * UserInterface/Base/Main.js:
1709         (WebInspector._dockedResizerMouseDown.dockedResizerDrag):
1710
1711 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1712
1713         Web Inspector: Fix assert in QuickConsole - main frame execution context path component
1714         https://bugs.webkit.org/show_bug.cgi?id=136748
1715
1716         Reviewed by Timothy Hatcher.
1717
1718         This can get called for the MainFrame on page navigations.
1719         In such cases we can return a better result from this method.
1720
1721         * UserInterface/Views/QuickConsole.js:
1722         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1723
1724 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1725
1726         Web Inspector: Hide DOM search result highlights when find banner is not showing
1727         https://bugs.webkit.org/show_bug.cgi?id=136749
1728
1729         Reviewed by Timothy Hatcher.
1730
1731         Match search highlights in TextEditor by only showing the highlight
1732         when the find banner is showing.
1733
1734         * UserInterface/Views/DOMTreeOutline.css:
1735         (.showing-find-banner .dom-tree-outline .search-result):
1736         (.dom-tree-outline .search-highlight): Deleted.
1737
1738 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1739
1740         Web Inspector: DOM Tree search highlights are not appearing
1741         https://bugs.webkit.org/show_bug.cgi?id=136662
1742
1743         Reviewed by Timothy Hatcher.
1744
1745         When performing a search within the DOMTreeContentView all
1746         search results should immediately highlight. When moving
1747         between search results, emphasize the current with a bouncy.
1748         Remember to remove the highlights when the search is changed
1749         or cleared.
1750
1751         * UserInterface/Views/DOMTreeContentView.js:
1752         (WebInspector.DOMTreeContentView.prototype.performSearch.searchResultsReady):
1753         (WebInspector.DOMTreeContentView.prototype.searchCleared):
1754         Shor or hide highlights when searches change.
1755
1756         (WebInspector.DOMTreeContentView.prototype.revealResult):
1757         (WebInspector.DOMTreeContentView.prototype._revealSearchResult):
1758         Emphasize the highlight when moving to a new current result.
1759
1760         (WebInspector.DOMTreeContentView.prototype._showSearchHighlights):
1761         (WebInspector.DOMTreeContentView.prototype._hideSearchHighlights):
1762         On each affected DOMTreeElement show or hide search highlights.
1763
1764         * UserInterface/Views/DOMTreeElement.js:
1765         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1766         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1767         Give a brief bouncy-highlight when told to emphasize the search highlight.
1768
1769         (WebInspector.DOMTreeElement.prototype.updateTitle):
1770         Remove unused and unnecessary style class on each row.
1771
1772         (WebInspector.DOMTreeElement.prototype._highlightSearchResults):
1773         Update the stale code to use new function names and accessors.
1774
1775         * UserInterface/Views/DOMTreeOutline.css:
1776         (.dom-tree-outline .search-highlight):
1777         Styles for the search highlight match search highlights in the sidebar.
1778
1779         * UserInterface/Views/Main.css:
1780         (.bouncy-highlight):
1781         * UserInterface/Views/TextEditor.css:
1782         Move bouncy-highlight to Main.css.
1783
1784 2014-09-10  Saam Barati  <saambarati1@gmail.com>
1785
1786         Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
1787         https://bugs.webkit.org/show_bug.cgi?id=136500
1788
1789         Reviewed by Joseph Pecoraro.
1790
1791         This patch maintains the same UI in the Web Inspector for displaying
1792         type information, but now accounts for the new protocol for type profiling.
1793         
1794         The Inspector now has a TypeSet class that wraps the TypeDescription 
1795         protocol object and creates a simple interface for asking protocol objects 
1796         about their type.
1797
1798         * UserInterface/Controllers/TypeTokenAnnotator.js:
1799         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
1800         * UserInterface/Main.html:
1801         * UserInterface/Models/TypeSet.js: Added.
1802         (WebInspector.TypeSet):
1803         (WebInspector.TypeSet.fromPayload):
1804         (WebInspector.TypeSet.prototype.isContainedIn):
1805         * UserInterface/Views/SourceCodeTextEditor.js:
1806         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1807         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1808         * UserInterface/Views/TypePropertiesSection.js:
1809         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1810         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
1811         * UserInterface/Views/TypeTokenView.js:
1812         (WebInspector.TypeTokenView.prototype.update):
1813         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1814         (WebInspector.TypeTokenView.prototype._displayTypeName):
1815
1816 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1817
1818         Web Inspector: Eliminate typeof "undefined" checks
1819         https://bugs.webkit.org/show_bug.cgi?id=136691
1820
1821         Reviewed by Alexey Proskuryakov.
1822
1823         * UserInterface/Base/Main.js:
1824         (WebInspector.linkifyURLAsNode):
1825         (WebInspector.linkifyStringAsFragment):
1826         * UserInterface/Protocol/InspectorBackend.js:
1827         (InspectorBackend.Command.prototype._invokeWithArguments):
1828         * UserInterface/Views/DataGrid.js:
1829         (WebInspector.DataGrid.prototype.get resizeMethod):
1830         * UserInterface/Views/NavigationBar.js:
1831         (WebInspector.NavigationBar.prototype.get minimumWidth):
1832
1833 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1834
1835         Web Inspector: Fix obscure ESLint warnings and skip directories
1836         https://bugs.webkit.org/show_bug.cgi?id=136686
1837
1838         Reviewed by Timothy Hatcher.
1839
1840         * .eslintignore: Added.
1841         Skip directories we do not want ESLint to process.
1842
1843         * .eslintrc:
1844         Add rules we've seen and sort sections.
1845
1846         * UserInterface/Controllers/FormatterContentBuilder.js:
1847         (FormatterContentBuilder.prototype._appendIndent):
1848         * UserInterface/Models/Color.js:
1849         * UserInterface/Models/DOMNodeStyles.js:
1850         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1851         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1852         * UserInterface/Views/DOMTreeDataGridNode.js:
1853         * UserInterface/Views/DOMTreeElement.js:
1854         (WebInspector.DOMTreeElement.prototype.ondelete):
1855         (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
1856         (WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
1857         * UserInterface/Views/EditingSupport.js:
1858         (WebInspector.EditingConfig):
1859         * UserInterface/Views/LayerTreeDataGridNode.js:
1860         (WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
1861         * UserInterface/Views/TreeOutline.js:
1862         (TreeOutline.prototype.appendChild):
1863         (TreeOutline.prototype.insertChild):
1864         (TreeOutline.prototype.removeChildAtIndex):
1865         (TreeOutline.prototype.removeChild):
1866         (TreeElement.prototype.expandRecursively):
1867         Fix linter issues.
1868
1869 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1870
1871         Web Inspector: Fix ESLint consistent-return warnings
1872         https://bugs.webkit.org/show_bug.cgi?id=136682
1873
1874         Reviewed by Timothy Hatcher.
1875
1876         * .eslintrc:
1877         * UserInterface/Controllers/BranchManager.js:
1878         (WebInspector.BranchManager.prototype.createBranch):
1879         * UserInterface/Controllers/FrameResourceManager.js:
1880         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
1881         * UserInterface/Models/DOMNodeStyles.js:
1882         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1883         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1884         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
1885         * UserInterface/Views/DOMTreeElement.js:
1886         (WebInspector.DOMTreeElement.prototype.showChild):
1887         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
1888         (WebInspector.DOMTreeElement.prototype._startEditing):
1889         * UserInterface/Views/EditingSupport.js:
1890         * UserInterface/Views/EventListenerSectionGroup.js:
1891         (WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
1892         * UserInterface/Views/FrameContentView.js:
1893         (WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
1894         * UserInterface/Views/NavigationBar.js:
1895         (WebInspector.NavigationBar.prototype.insertNavigationItem):
1896         (WebInspector.NavigationBar.prototype.removeNavigationItem):
1897         * UserInterface/Views/QuickConsole.js:
1898         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1899         * UserInterface/Views/Sidebar.js:
1900         (WebInspector.Sidebar.prototype.addSidebarPanel):
1901         (WebInspector.Sidebar.prototype.removeSidebarPanel):
1902         * UserInterface/Views/TextEditor.js:
1903         (WebInspector.TextEditor.prototype.addStyleClassToLine):
1904         (WebInspector.TextEditor.prototype.removeStyleClassFromLine):
1905         (WebInspector.TextEditor.prototype.toggleStyleClassForLine):
1906
1907 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1908
1909         Web Inspector: Fix ESLint no-undef warnings
1910         https://bugs.webkit.org/show_bug.cgi?id=136660
1911
1912         Reviewed by Timothy Hatcher.
1913
1914         * UserInterface/Models/DOMSearchMatchObject.js:
1915         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
1916         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1917         * UserInterface/Models/Gradient.js:
1918         (WebInspector.Gradient.fromString):
1919         * UserInterface/Views/CodeMirrorAdditions.js:
1920         * UserInterface/Views/ReplayDashboardView.js:
1921         (WebInspector.ReplayDashboardView):
1922
1923 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1924
1925         Web Inspector: Remove unused Console search highlight methods
1926         https://bugs.webkit.org/show_bug.cgi?id=136661
1927
1928         Reviewed by Timothy Hatcher.
1929
1930         ESLint's no-undef warning complained about some undefined references
1931         in these functions that would have thrown exceptions. Turns out this
1932         code is unused, and we do highlighting in the console separately.
1933
1934         * UserInterface/Views/ConsoleCommand.js:
1935         (WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
1936         (WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
1937         (WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
1938         * UserInterface/Views/ConsoleMessageImpl.js:
1939         (WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
1940         (WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
1941         (WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
1942
1943 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1944
1945         Web Inspector: Fix ESLint* no-avoidable-bind warnings
1946         https://bugs.webkit.org/show_bug.cgi?id=136690
1947
1948         Reviewed by Timothy Hatcher.
1949
1950         * UserInterface/Protocol/RemoteObject.js:
1951         (WebInspector.LocalJSONObject.prototype._children):
1952         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1953         (WebInspector.CSSStyleDetailsSidebarPanel):
1954         * UserInterface/Views/LayerTreeSidebarPanel.js:
1955         (WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
1956         * UserInterface/Views/LogContentView.js:
1957         (WebInspector.LogContentView.prototype._filterMessages):
1958         * UserInterface/Views/TextResourceContentView.js:
1959         (WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
1960
1961 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
1962
1963         Disable the "unreachable-code" warning
1964         https://bugs.webkit.org/show_bug.cgi?id=136677
1965
1966         Reviewed by Darin Adler.
1967
1968         * Configurations/Base.xcconfig:
1969
1970 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1971
1972         Web Inspector: Fix ESLint no-trailing-spaces warnings
1973         https://bugs.webkit.org/show_bug.cgi?id=136657
1974
1975         Reviewed by Andy Estes.
1976
1977         * .eslintrc:
1978         * UserInterface/Base/DOMUtilities.js:
1979         * UserInterface/Base/URLUtilities.js:
1980         (relativePath):
1981         * UserInterface/Base/Utilities.js:
1982         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
1983         (WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
1984         * UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
1985         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
1986         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
1987         * UserInterface/Controllers/CodeMirrorEditingController.js:
1988         (WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
1989         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
1990         (WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
1991         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1992         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1993         * UserInterface/Controllers/DragToAdjustController.js:
1994         (WebInspector.DragToAdjustController.prototype.set active):
1995         (WebInspector.DragToAdjustController.prototype._setDragging):
1996         (WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
1997         * UserInterface/External/Esprima/esprima.js:
1998         * UserInterface/Models/ApplicationCacheFrame.js:
1999         (WebInspector.ApplicationCacheFrame):
2000         * UserInterface/Models/ApplicationCacheManifest.js:
2001         (WebInspector.ApplicationCacheManifest):
2002         (WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
2003         * UserInterface/Models/CookieStorageObject.js:
2004         * UserInterface/Models/DOMSearchMatchObject.js:
2005         (WebInspector.DOMSearchMatchObject.prototype.get title):
2006         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
2007         * UserInterface/Models/DatabaseObject.js:
2008         (WebInspector.DatabaseObject.prototype.getTableNames):
2009         * UserInterface/Models/DatabaseTableObject.js:
2010         (WebInspector.DatabaseTableObject):
2011         * UserInterface/Models/Gradient.js:
2012         (WebInspector.Gradient.fromString):
2013         (WebInspector.RadialGradient.prototype.toString):
2014         * UserInterface/Models/IssueMessage.js:
2015         (WebInspector.IssueMessage.prototype._formatTextIfNecessary):
2016         * UserInterface/Models/Resource.js:
2017         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
2018         (WebInspector.Resource.prototype.getImageSize):
2019         * UserInterface/Models/Script.js:
2020         (WebInspector.Script.prototype._makeSyntaxTree):
2021         * UserInterface/Models/SourceCodeLocation.js:
2022         (WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
2023         * UserInterface/Models/TextMarker.js:
2024         * UserInterface/Protocol/PageObserver.js:
2025         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
2026         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
2027         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
2028         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
2029         * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
2030         (WebInspector.ApplicationCacheFrameTreeElement):
2031         * UserInterface/Views/ApplicationCacheManifestTreeElement.js:
2032         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
2033         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
2034         * UserInterface/Views/ButtonNavigationItem.js:
2035         (WebInspector.ButtonNavigationItem):
2036         * UserInterface/Views/ColorPicker.js:
2037         * UserInterface/Views/ColorWheel.js:
2038         (WebInspector.ColorWheel.prototype._draw):
2039         * UserInterface/Views/CompletionSuggestionsView.js:
2040         (WebInspector.CompletionSuggestionsView.prototype.show):
2041         * UserInterface/Views/ConsoleCommand.js:
2042         * UserInterface/Views/ConsolePrompt.js:
2043         * UserInterface/Views/ContentFlowTreeElement.js:
2044         * UserInterface/Views/CookieStorageTreeElement.js:
2045         (WebInspector.CookieStorageTreeElement):
2046         * UserInterface/Views/EventListenerSectionGroup.js:
2047         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
2048         * UserInterface/Views/GeneralTreeElementPathComponent.js:
2049         * UserInterface/Views/GoToLineDialog.js:
2050         (WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
2051         * UserInterface/Views/LayerTreeDataGridNode.js:
2052         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
2053         * UserInterface/Views/LayerTreeSidebarPanel.js:
2054         * UserInterface/Views/LogContentView.js:
2055         (WebInspector.LogContentView.prototype._highlightRanges):
2056         * UserInterface/Views/NavigationBar.js:
2057         (WebInspector.NavigationBar):
2058         * UserInterface/Views/NavigationItem.js:
2059         (WebInspector.NavigationItem):
2060         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
2061         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
2062         * UserInterface/Views/ScopeBar.js:
2063         * UserInterface/Views/ScopeBarItem.js:
2064         (WebInspector.ScopeBarItem):
2065         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
2066         (WebInspector.ScopeChainDetailsSidebarPanel):
2067         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2068         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2069         * UserInterface/Views/ScriptTreeElement.js:
2070         (WebInspector.ScriptTreeElement):
2071         * UserInterface/Views/SearchBar.js:
2072         * UserInterface/Views/SearchResultTreeElement.js:
2073         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2074         * UserInterface/Views/Slider.js:
2075
2076 2014-09-09  Joseph Pecoraro  <pecoraro@apple.com>
2077
2078         Web Inspector: Fix ESLint eqeqeq warnings
2079         https://bugs.webkit.org/show_bug.cgi?id=136658
2080
2081         Reviewed by Andy Estes.
2082
2083         * UserInterface/Controllers/DOMTreeManager.js:
2084         (WebInspector.DOMTreeManager.prototype.mycallback):
2085         (WebInspector.DOMTreeManager.prototype.searchResult):
2086         * UserInterface/Models/Breakpoint.js:
2087         (WebInspector.Breakpoint.prototype.clearActions):
2088         * UserInterface/Models/DOMTree.js:
2089         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
2090         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
2091         (WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
2092         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2093         * UserInterface/Models/ProbeSet.js:
2094         (WebInspector.ProbeSet.prototype.removeProbe):
2095         * UserInterface/Models/ProbeSetDataTable.js:
2096         (WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
2097         * UserInterface/Views/CodeMirrorAdditions.js:
2098         * UserInterface/Views/CookieStorageContentView.js:
2099         (WebInspector.CookieStorageContentView.prototype._filterCookies):
2100         (WebInspector.cookieMatchesResourceURL):
2101         * UserInterface/Views/DOMStorageContentView.js:
2102         (WebInspector.DOMStorageContentView.prototype._editingCallback):
2103         * UserInterface/Views/DOMTreeElement.js:
2104         (WebInspector.DOMTreeElement):
2105         (WebInspector.DOMTreeElement.prototype._updateChildren):
2106         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
2107         (WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
2108         * UserInterface/Views/DataGrid.js:
2109         (WebInspector.DataGrid.prototype._resizerDragging):
2110         * UserInterface/Views/DatabaseContentView.js:
2111         (WebInspector.DatabaseContentView.prototype._queryError):
2112         * UserInterface/Views/DetailsSectionSimpleRow.js:
2113         (.valueElementClicked):
2114         (WebInspector.DetailsSectionSimpleRow):
2115         * UserInterface/Views/Slider.js:
2116         (WebInspector.Slider.prototype.get _maxX):
2117         * UserInterface/Views/TreeOutline.js:
2118         (TreeElement.prototype.expand):
2119
2120 2014-09-09  Jono Wells  <jonowells@apple.com>
2121
2122         Web Inspector: Fix ESLint no-extra-semi
2123         https://bugs.webkit.org/show_bug.cgi?id=136666
2124
2125         Reviewed by Andy Estes.
2126
2127         Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
2128         semicolons as identified by ESLint.
2129
2130         * .eslintrc:
2131         * Tools/PrettyPrinting/Formatter.js:
2132         (Formatter):
2133         * UserInterface/Controllers/Formatter.js:
2134         (Formatter):
2135         * UserInterface/Models/Resource.js:
2136         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
2137         (WebInspector.Resource.prototype.getImageSize):
2138         * UserInterface/Views/LayerTreeSidebarPanel.js:
2139         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
2140         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
2141         * UserInterface/Views/ObjectPropertiesSection.js:
2142         (WebInspector.ObjectPropertyTreeElement.prototype.callback):
2143         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
2144
2145 2014-09-09  Jono Wells  <jonowells@apple.com>
2146
2147         Web Inspector: Fix ESLint semi (missing semicolon)
2148         https://bugs.webkit.org/show_bug.cgi?id=136665
2149
2150         Reviewed by Andy Estes.
2151
2152         Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
2153
2154         * .eslintrc:
2155         * Tools/PrettyPrinting/FormatterContentBuilder.js:
2156         * Tools/PrettyPrinting/FormatterDebug.js:
2157         (Formatter.prototype.debug):
2158         * UserInterface/Base/DOMUtilities.js:
2159         * UserInterface/Base/EventListener.js:
2160         (WebInspector.EventListener):
2161         (WebInspector.EventListener.prototype.this._callback):
2162         (WebInspector.EventListener.prototype.connect):
2163         * UserInterface/Base/Object.js:
2164         (WebInspector.Object):
2165         (WebInspector.Object.addConstructorFunctions):
2166         (WebInspector.Event):
2167         * UserInterface/Base/URLUtilities.js:
2168         (WebInspector.displayNameForURL):
2169         (WebInspector.displayNameForHost):
2170         * UserInterface/Base/Utilities.js:
2171         (.):
2172         * UserInterface/Controllers/BranchManager.js:
2173         (WebInspector.BranchManager):
2174         * UserInterface/Controllers/CSSStyleManager.js:
2175         (WebInspector.CSSStyleManager):
2176         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
2177         (WebInspector.CodeMirrorColorEditingController):
2178         * UserInterface/Controllers/CodeMirrorEditingController.js:
2179         (WebInspector.CodeMirrorEditingController):
2180         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
2181         (WebInspector.CodeMirrorGradientEditingController):
2182         (WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
2183         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2184         * UserInterface/Controllers/FormatterContentBuilder.js:
2185         * UserInterface/Controllers/FormatterSourceMap.js:
2186         (WebInspector.FormatterSourceMap.fromBuilder):
2187         * UserInterface/Controllers/IssueManager.js:
2188         (WebInspector.IssueManager):
2189         * UserInterface/Controllers/LogManager.js:
2190         (WebInspector.LogManager):
2191         * UserInterface/Models/BreakpointAction.js:
2192         * UserInterface/Models/CSSCompletions.js:
2193         (WebInspector.CSSCompletions):
2194         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2195         * UserInterface/Models/CSSKeywordCompletions.js:
2196         (WebInspector.CSSKeywordCompletions.forProperty):
2197         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2198         * UserInterface/Models/CSSStyleSheet.js:
2199         (WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
2200         * UserInterface/Models/Color.js:
2201         (WebInspector.Color):
2202         (WebInspector.Color.fromString):
2203         * UserInterface/Models/DOMNode.js:
2204         (WebInspector.DOMNode):
2205         * UserInterface/Models/DOMSearchMatchObject.js:
2206         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
2207         * UserInterface/Models/ExecutionContext.js:
2208         (WebInspector.ExecutionContext.supported):
2209         * UserInterface/Models/Gradient.js:
2210         (WebInspector.LinearGradient):
2211         (WebInspector.LinearGradient.linearGradientWithComponents):
2212         (WebInspector.RadialGradient):
2213         (WebInspector.RadialGradient.radialGradientWithComponents):
2214         * UserInterface/Models/IssueMessage.js:
2215         (WebInspector.IssueMessage):
2216         * UserInterface/Models/ReplaySessionSegment.js:
2217         (WebInspector.IncompleteSessionSegment):
2218         * UserInterface/Models/Resource.js:
2219         (WebInspector.Resource.prototype.associateWithScript):
2220         * UserInterface/Models/Script.js:
2221         (WebInspector.Script.resetUniqueDisplayNameNumbers):
2222         * UserInterface/Models/Setting.js:
2223         (WebInspector.Setting):
2224         * UserInterface/Models/SourceCodePosition.js:
2225         (WebInspector.SourceCodePosition):
2226         * UserInterface/Models/SourceMap.js:
2227         (WebInspector.SourceMap):
2228         (WebInspector.SourceMap.StringCharIterator):
2229         * UserInterface/Models/TextMarker.js:
2230         (WebInspector.TextMarker):
2231         * UserInterface/Models/TextRange.js:
2232         (WebInspector.TextRange):
2233         * UserInterface/Protocol/InspectorFrontendHostStub.js:
2234         (.WebInspector.InspectorFrontendHostStub):
2235         * UserInterface/Protocol/MessageDispatcher.js:
2236         (WebInspector.dispatchNextQueuedMessageFromBackend):
2237         (WebInspector.dispatchMessageFromBackend):
2238         * UserInterface/Protocol/RemoteObject.js:
2239         (WebInspector.RemoteObject):
2240         (WebInspector.RemoteObject.fromPrimitiveValue):
2241         (WebInspector.RemoteObject.fromLocalObject):
2242         (WebInspector.RemoteObject.resolveNode):
2243         (WebInspector.RemoteObject.fromPayload):
2244         (WebInspector.RemoteObject.type):
2245         (WebInspector.RemoteObjectProperty):
2246         (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
2247         (WebInspector.LocalJSONObject):
2248         * UserInterface/Protocol/ReplayObserver.js:
2249         (WebInspector.ReplayPosition.fromProtocol):
2250         * UserInterface/Views/BreakpointActionView.js:
2251         (WebInspector.BreakpointActionView.displayStringForType):
2252         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2253         (WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
2254         * UserInterface/Views/ClusterContentView.js:
2255         (WebInspector.ClusterContentView.prototype.goBack):
2256         (WebInspector.ClusterContentView.prototype.goForward):
2257         * UserInterface/Views/CodeMirrorAdditions.js:
2258         * UserInterface/Views/ColorWheel.js:
2259         (WebInspector.ColorWheel):
2260         * UserInterface/Views/ConsoleMessage.js:
2261         (WebInspector.ConsoleMessage):
2262         (WebInspector.ConsoleMessage.create):
2263         * UserInterface/Views/ConsoleMessageImpl.js:
2264         (WebInspector.ConsoleMessageImpl):
2265         * UserInterface/Views/ContextMenu.js:
2266         (WebInspector.ContextMenuItem):
2267         (WebInspector.ContextSubMenuItem):
2268         (WebInspector.ContextMenu):
2269         (WebInspector.ContextMenu.Provider):
2270         (WebInspector.ContextMenu.registerProvider):
2271         (WebInspector.contextMenuItemSelected):
2272         (WebInspector.contextMenuCleared):
2273         * UserInterface/Views/DOMTreeElement.js:
2274         (WebInspector.DOMTreeElement):
2275         * UserInterface/Views/DOMTreeOutline.js:
2276         (WebInspector.DOMTreeOutline):
2277         * UserInterface/Views/DOMTreeUpdater.js:
2278         (WebInspector.DOMTreeUpdater):
2279         * UserInterface/Views/DatabaseContentView.js:
2280         (WebInspector.DatabaseContentView):
2281         * UserInterface/Views/EditingSupport.js:
2282         (WebInspector.isBeingEdited):
2283         (WebInspector.markBeingEdited):
2284         (WebInspector.isEditingAnyField):
2285         (WebInspector.isEventTargetAnEditableField):
2286         (WebInspector.EditingConfig):
2287         (WebInspector.startEditing):
2288         * UserInterface/Views/EventListenerSection.js:
2289         (WebInspector.EventListenerSection):
2290         * UserInterface/Views/EventListenerSectionGroup.js:
2291         (WebInspector.EventListenerSectionGroup):
2292         * UserInterface/Views/FindBanner.js:
2293         * UserInterface/Views/GeneralTreeElement.js:
2294         (WebInspector.GeneralTreeElement):
2295         * UserInterface/Views/GoToLineDialog.js:
2296         (WebInspector.GoToLineDialog):
2297         * UserInterface/Views/IndeterminateProgressSpinner.js:
2298         (WebInspector.IndeterminateProgressSpinner):
2299         * UserInterface/Views/LayoutTimelineDataGrid.js:
2300         (WebInspector.LayoutTimelineDataGrid):
2301         * UserInterface/Views/LogContentView.js:
2302         (WebInspector.LogContentView):
2303         * UserInterface/Views/NavigationItem.js:
2304         * UserInterface/Views/ObjectPropertiesSection.js:
2305         (WebInspector.ObjectPropertiesSection):
2306         (WebInspector.ObjectPropertiesSection.CompareProperties):
2307         (WebInspector.ObjectPropertyTreeElement):
2308         * UserInterface/Views/ProbeSetDetailsSection.js:
2309         * UserInterface/Views/PropertiesSection.js:
2310         (WebInspector.PropertiesSection):
2311         * UserInterface/Views/ResourceTreeElement.js:
2312         (WebInspector.ResourceTreeElement.compareResourceTreeElements):
2313         (WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
2314         * UserInterface/Views/ScriptTimelineDataGrid.js:
2315         (WebInspector.ScriptTimelineDataGrid):
2316         * UserInterface/Views/SearchResultTreeElement.js:
2317         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2318         * UserInterface/Views/TimelineRuler.js:
2319         (WebInspector.TimelineRuler):
2320         (WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
2321         (WebInspector.TimelineRuler.prototype._handleMouseUp):
2322         * UserInterface/Views/Toolbar.js:
2323         * UserInterface/Views/TreeOutline.js:
2324         (TreeOutline.prototype.appendChild):
2325         (TreeOutline.prototype.insertChild):
2326         (TreeOutline.prototype.removeChildAtIndex):
2327         (TreeOutline.prototype.removeChild):
2328         (TreeOutline.prototype.removeChildren):
2329         (TreeOutline.prototype.removeChildrenRecursive):
2330         (TreeOutline.prototype._rememberTreeElement):
2331         (TreeOutline.prototype._forgetTreeElement):
2332         (TreeOutline.prototype._forgetChildrenRecursive):
2333         (TreeOutline.prototype.getCachedTreeElement):
2334         (TreeOutline.prototype.findTreeElement):
2335         (TreeOutline.prototype._treeElementDidChange):
2336         (TreeOutline.prototype.treeElementFromPoint):
2337         (TreeOutline.prototype._treeKeyDown):
2338         (TreeOutline.prototype.expand):
2339         (TreeOutline.prototype.collapse):
2340         (TreeOutline.prototype.revealed):
2341         (TreeOutline.prototype.reveal):
2342         (TreeOutline.prototype.select):
2343         (TreeOutline.prototype.revealAndSelect):
2344         (TreeElement.prototype._attach):
2345         (TreeElement.prototype._detach):
2346         (TreeElement.treeElementMouseDown):
2347         (TreeElement.treeElementToggled):
2348         (TreeElement.treeElementDoubleClicked):
2349         (TreeElement.prototype.collapse):
2350         (TreeElement.prototype.collapseRecursively):
2351         (TreeElement.prototype.expand):
2352         (TreeElement.prototype.expandRecursively):
2353         (TreeElement.prototype.hasAncestor):
2354         (TreeElement.prototype.reveal):
2355         (TreeElement.prototype.revealed):
2356         (TreeElement.prototype.selectOnMouseDown):
2357         (TreeElement.prototype.select):
2358         (TreeElement.prototype.revealAndSelect):
2359         (TreeElement.prototype.deselect):
2360         (TreeElement.prototype.onpopulate):
2361         (TreeElement.prototype.traverseNextTreeElement):
2362         (TreeElement.prototype.traversePreviousTreeElement):
2363         (TreeElement.prototype.isEventWithinDisclosureTriangle):
2364         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
2365         (WebInspector.TreeOutlineDataGridSynchronizer):
2366
2367 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2368
2369         Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
2370         https://bugs.webkit.org/show_bug.cgi?id=135965
2371
2372         Reviewed by Timothy Hatcher.
2373
2374         There were numerous subtle race conditions in state restoration.
2375         This patch intends to fix a number of them to get what feels
2376         like sane behavior for selected sidebar state restoration.
2377
2378         1. Starting a Timeline recording no longer automatically switches to the TimelineContentView.
2379         This was making every reload switch to Timelines. If you had
2380         a resource selected (e.g. the DOM Tree) we should go back
2381         to showing the DOM tree.
2382
2383         2. Background sidebars should not reveal and select tree elements.
2384         This was making resources get selected in Timelines when reloading the page
2385         because the background Resources sidebar was restoring selection of the resource.
2386         That is an unexpected selection and breaks the experience of Timelines.
2387
2388         3. ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.
2389         If a TimelineContentView was in the ContentBrowser back/forward history,
2390         a reload with a resource selected in the Resources sidebar would end up
2391         showing the Timelines sidebar. This was because when ContentViews are
2392         closed during the navigation, the ContentBrowser would fall back to the
2393         remaining TimelineContentView and switch to its only allowed sidebar
2394         (Timelines). ResourceSidebarPanel, knowing a resource was selected,
2395         would select the MainFrame intending to stay in the Resource sidebar,
2396         but the resource is okay with showing in any sidebar, so we stay on Timelines.
2397
2398         4. Resource sidebar state restoration should propertly restore selection.
2399         On reload, state restoration would know the resource to re-select in the
2400         Resources sidebar. As ResourceTreeElements are added to the sidebar
2401         they are checked against the state restoration cookie. If they match,
2402         they would select the element and delete the cookie. Unfortunately,
2403         if this was the first TreeElement child being added to a FrameTreeElement,
2404         the FrameTreeElement onpopulate would remove all children and re-add
2405         them in a unique way. Unfortunately this means the TreeElement we
2406         selected based on the cookie, immediately got thrown away and recreated,
2407         and we no longer reveal and select it. This is a special case for
2408         FrameTreeElements which use the onpopulate SPI. So, instead of starting
2409         processing the new element queue, if this is the first time just trigger
2410         the onpopulate and elements are made just once.
2411
2412         5. Show Error Console triggering early, could have unexpected sidebar behavior.
2413         Opening Web Inspector directly to the console can run before
2414         WebInspector.contentLoaded (DOMContentLoaded). So in that case
2415         WebInspector.showFullHeightConsole was not handling if the contentBrowser
2416         had no content view yet, and the sidebar might be-reopened later on
2417         in contentLoaded based on the setting value.
2418
2419         6. Improve automatic resource selection for sidebars with multiple tree outlines.
2420         Selecting a call frame tree element was unexpectedly changing the
2421         selection to a Resource where the breakpoint was set. This was
2422         because we were only looking at one of potentially many content
2423         tree outlines in the sidebar to see if there was a user action.
2424         
2425         * UserInterface/Base/Main.js:
2426         (WebInspector.contentLoaded):
2427         (WebInspector.showFullHeightConsole):
2428         (WebInspector.toggleConsoleView):
2429         (WebInspector._mainResourceDidChange):
2430         (WebInspector._provisionalLoadStarted):
2431         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
2432         (WebInspector._updateCookieForInspectorViewState):
2433         (WebInspector._contentBrowserCurrentContentViewDidChange):
2434         * UserInterface/Views/NavigationSidebarPanel.js:
2435         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2436         * UserInterface/Views/ResourceSidebarPanel.js:
2437         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2438         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2439         * UserInterface/Views/TimelineSidebarPanel.js:
2440         (WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
2441
2442 2014-09-08  Matt Baker  <mattbaker@apple.com>
2443
2444         Web Inspector: Add layout test for lowercase CSSProperty names
2445         https://bugs.webkit.org/show_bug.cgi?id=135961
2446
2447         Reviewed by Joseph Pecoraro.
2448
2449         Modified test components to support testing CSSStyleManager and related classes:
2450         - Added required models to Test.html
2451         - Added CSSCompletions initialization to Test.js
2452         - CSSCompletions doesn't assume presence of CodeMirror.
2453
2454         * UserInterface/Base/Test.js:
2455         (WebInspector.loaded):
2456         * UserInterface/Models/CSSCompletions.js:
2457         * UserInterface/Test.html:
2458
2459 2014-09-08  Matt Baker  <mattbaker@apple.com>
2460
2461         Web Inspector: Fixes to layout test infrastructure
2462         https://bugs.webkit.org/show_bug.cgi?id=136360
2463
2464         Reviewed by Joseph Pecoraro.
2465
2466         Added missing includes to Test.html, which was breaking tests that
2467         depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
2468         bug which prevented test results from being resent after reloading the
2469         page under test.
2470
2471         * UserInterface/Base/Test.js:
2472         (InspectorTest.reloadPage):
2473         * UserInterface/Test.html:
2474
2475 2014-09-07  Timothy Hatcher  <timothy@apple.com>
2476
2477         Use a <circle> instead of a <path> in DownloadArrow.svg.
2478         https://bugs.webkit.org/show_bug.cgi?id=136608
2479
2480         Reviewed by Antoine Quint.
2481
2482         * UserInterface/Images/DownloadArrow.svg:
2483         * UserInterface/Views/TreeElementStatusButton.css:
2484         (.item > .status > .status-button > svg .filled):
2485         (body.mac-platform.legacy .item > .status > .status-button > svg .filled):
2486         (:focus .item.selected > .status > .status-button > svg .filled):
2487         (.item > .status > .status-button > svg .stroked):
2488         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
2489         (:focus .item.selected > .status > .status-button > svg .stroked):
2490         Tweak CSS selectors to apply to other shapes, not just path.
2491
2492 2014-09-06  Darin Adler  <darin@apple.com>
2493
2494         Make updates suggested by new version of Xcode
2495         https://bugs.webkit.org/show_bug.cgi?id=136603
2496
2497         Reviewed by Mark Rowe.
2498
2499         * Configurations/Base.xcconfig: Added CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2500         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2501         CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH, ENABLE_STRICT_OBJC_MSGSEND,
2502         GCC_WARN_UNDECLARED_SELECTOR, and GCC_WARN_UNUSED_FUNCTION as suggested by Xcode update check.
2503         Also removed duplicate GCC_WARN_UNUSED_VARIABLE line.
2504
2505         * WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2506
2507 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2508
2509         LegacyProfiler: remove redundant ProfileNode members and other cleanup
2510         https://bugs.webkit.org/show_bug.cgi?id=136380
2511
2512         Reviewed by Timothy Hatcher.
2513
2514         Remove unused Profile.idleTime member.
2515
2516         * UserInterface/Models/Profile.js:
2517         (WebInspector.Profile.prototype.get idleTime): Deleted.
2518         * UserInterface/Models/ScriptTimelineRecord.js:
2519         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
2520
2521 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2522
2523         Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
2524         https://bugs.webkit.org/show_bug.cgi?id=136462
2525
2526         Reviewed by Timothy Hatcher.
2527
2528         The legacy profiler manager didn't do anything, and its views and models
2529         have been superseded by new views and models based on the Timeline classes.
2530
2531         * .eslintrc:
2532         * UserInterface/Base/Main.js:
2533         (WebInspector.loaded):
2534         (WebInspector.openURL): Remove profile URL handling code.
2535         * UserInterface/Controllers/LegacyProfileManager.js: Removed.
2536         * UserInterface/Main.html:
2537         * UserInterface/Protocol/ConsoleObserver.js:
2538         (WebInspector.ConsoleObserver.prototype.messageAdded):
2539         * UserInterface/Protocol/InspectorFrontendAPI.js:
2540         (InspectorFrontendAPI.isProfilingJavaScript): Deleted.
2541         (InspectorFrontendAPI.startProfilingJavaScript): Deleted.
2542         (InspectorFrontendAPI.stopProfilingJavaScript): Deleted.
2543         * UserInterface/Protocol/LegacyProfilerObserver.js: Removed.
2544         * UserInterface/Views/LegacyBottomUpProfileDataGridTree.js: Removed.
2545         * UserInterface/Views/LegacyJavaScriptProfileObject.js: Removed.
2546         * UserInterface/Views/LegacyJavaScriptProfileType.js: Removed.
2547         * UserInterface/Views/LegacyJavaScriptProfileView.css: Removed.
2548         * UserInterface/Views/LegacyJavaScriptProfileView.js: Removed.
2549         * UserInterface/Views/LegacyProfileDataGridTree.js: Removed.
2550         * UserInterface/Views/LegacyProfileObject.js: Removed.
2551         * UserInterface/Views/LegacyProfileType.js: Removed.
2552         * UserInterface/Views/LegacyProfileView.css: Removed.
2553         * UserInterface/Views/LegacyProfileView.js: Removed.
2554         * UserInterface/Views/LegacyTopDownProfileDataGridTree.js: Removed.
2555
2556 2014-08-29  Saam Barati  <saambarati1@gmail.com>
2557
2558         Web Inspector: Create a UI for displaying JavaScript type information
2559         https://bugs.webkit.org/show_bug.cgi?id=135142
2560
2561         Reviewed by Joseph Pecoraro.
2562
2563         JavaScriptCore now has a type profiler. This patch provides a frontend
2564         user interface for displaying this type information in the Web Inspector.
2565         The user interface works by placing inline "type tokens" next to important
2566         JavaScript expressions: function arguments, function return types, and 
2567         variable declarations. Type information can also be seen for almost every
2568         JavaScipt expression just by hovering over it while viewing a JavaScript file.
2569
2570         Currently, turning on the type profiler is expensive, so the inspector
2571         ensures to never turn on type profiling until the user specifically asks 
2572         for type information to be turned on.
2573
2574         * UserInterface/Base/Main.js:
2575         (WebInspector.loaded):
2576         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2577         (WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
2578         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
2579         Added a new type profiling mode.
2580
2581         * UserInterface/Controllers/FormatterSourceMap.js:
2582         (WebInspector.FormatterSourceMap.prototype.originalToFormatted):
2583         (WebInspector.FormatterSourceMap.prototype.originalPositionToFormatted):
2584         (WebInspector.FormatterSourceMap.prototype.formattedToOriginal):
2585         (WebInspector.FormatterSourceMap.prototype.formattedToOriginalOffset):
2586         * UserInterface/Controllers/TypeTokenAnnotator.js: Added.
2587         (WebInspector.TypeTokenAnnotator):
2588         (WebInspector.TypeTokenAnnotator.prototype.get isActive):
2589         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor):
2590         (WebInspector.TypeTokenAnnotator.prototype.pause):
2591         (WebInspector.TypeTokenAnnotator.prototype.resume):
2592         (WebInspector.TypeTokenAnnotator.prototype.refresh):
2593         (WebInspector.TypeTokenAnnotator.prototype.reset):
2594         (WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
2595         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.):
2596         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
2597         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
2598         (WebInspector.TypeTokenAnnotator.prototype.isLineTerminator):
2599         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
2600         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded):
2601         This class is responsible for producing the inline "type token" annotations.
2602
2603         * UserInterface/Images/NavigationItemTypes.svg: Added.
2604         * UserInterface/Main.html:
2605         * UserInterface/Models/Script.js:
2606         (WebInspector.Script.prototype.get scriptSyntaxTree):
2607         * UserInterface/Models/ScriptSyntaxTree.js:
2608         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2609         (WebInspector.ScriptSyntaxTree.prototype.):
2610         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2611         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2612         * UserInterface/Views/ScriptContentView.js:
2613         (WebInspector.ScriptContentView):
2614         (WebInspector.ScriptContentView.prototype.get navigationItems):
2615         (WebInspector.ScriptContentView.prototype._contentDidPopulate):
2616         (WebInspector.ScriptContentView.prototype._toggleTypeAnnotations):
2617         (WebInspector.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2618         * UserInterface/Views/SourceCodeTextEditor.js:
2619         (WebInspector.SourceCodeTextEditor):
2620         (WebInspector.SourceCodeTextEditor.prototype.shown):
2621         (WebInspector.SourceCodeTextEditor.prototype.hidden):
2622         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
2623         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
2624         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
2625         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
2626         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
2627         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
2628         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
2629         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
2630         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
2631         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
2632         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
2633         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2634         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
2635         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2636         (WebInspector.SourceCodeTextEditor.prototype._enableScrollEventsForTypeTokenAnnotator):
2637         (WebInspector.SourceCodeTextEditor.prototype._disableScrollEventsForTypeTokenAnnotator):
2638         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
2639         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
2640         * UserInterface/Views/TextContentView.js:
2641         (WebInspector.TextContentView.prototype.get navigationItems):
2642         * UserInterface/Views/TextEditor.js:
2643         (WebInspector.TextEditor.prototype.set formatted):
2644         (WebInspector.TextEditor.prototype.canShowTypeAnnotations):
2645         (WebInspector.TextEditor.prototype.visibleRangeOffsets):
2646         (WebInspector.TextEditor.prototype.originalOffsetToCurrentPosition):
2647         (WebInspector.TextEditor.prototype.currentOffsetToCurrentPosition):
2648         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
2649         (WebInspector.TextEditor.prototype.currentPositionToCurrentOffset):
2650         (WebInspector.TextEditor.prototype.setInlineWidget):
2651         (WebInspector.TextEditor.prototype.addScrollHandler):
2652         (WebInspector.TextEditor.prototype.removeScrollHandler):
2653         (WebInspector.TextEditor.prototype._scrollIntoViewCentered):
2654         * UserInterface/Views/TextResourceContentView.js:
2655         (WebInspector.TextResourceContentView):
2656         (WebInspector.TextResourceContentView.prototype.get navigationItems):
2657         (WebInspector.TextResourceContentView.prototype._contentDidPopulate):
2658         (WebInspector.TextResourceContentView.prototype._toggleTypeAnnotations):
2659         (WebInspector.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2660         * UserInterface/Views/TypePropertiesSection.js: Added.
2661         (WebInspector.TypePropertiesSection):
2662         (WebInspector.TypePropertiesSection.prototype.onpopulate):
2663         (WebInspector.TypePropertiesSection.PropertyComparator):
2664         (WebInspector.TypePropertyTreeElement):
2665         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
2666         * UserInterface/Views/TypeTokenView.css: Added.
2667         (.type-token):
2668         (.type-token-left-spacing):
2669         (.type-token-right-spacing):
2670         (.type-token-function, .type-token-boolean):
2671         (.type-token-number):
2672         (.type-token-string):
2673         (.type-token-default):
2674         (.type-token-empty):
2675         (.type-token-many):
2676         * UserInterface/Views/TypeTokenView.js: Added.
2677         (WebInspector.TypeTokenView):
2678         (WebInspector.TypeTokenView.titleForPopover):
2679         (WebInspector.TypeTokenView.prototype.update):
2680         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
2681         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
2682         The inline "type token" view.
2683
2684 2014-08-29  Saam Barati  <sbarati@apple.com>
2685
2686         Web Inspector: Fix how Popover animates
2687         https://bugs.webkit.org/show_bug.cgi?id=136353
2688
2689         Reviewed by Timothy Hatcher.
2690
2691         Popovers currently don't animate properly because they use 
2692         window.requestAnimationFrame which won't fire its callback 
2693         while the inspector is paused in the debugger. This patches
2694         switches the callback mechanism to setTimeout and also changes
2695         how a Popover's anchor animates to prevent visual glitches.
2696
2697         Popover also has a new function that allows a new target
2698         frame and new content to be set simultaneously and to
2699         animate to show the new content while changing the 
2700         location of the popover frame.
2701
2702         SourceCodeTextEditor uses Popover's new API for animating
2703         between popovers when paused in the debugger. SourceCodeTextEditor 
2704         also now ensures proper balancing of popover tracking event 
2705         listeners.
2706
2707         * UserInterface/Views/Popover.js:
2708         (WebInspector.Popover.prototype.present):
2709         (WebInspector.Popover.prototype.presentNewContentWithFrame):
2710         (WebInspector.Popover.prototype.dismiss):
2711         (WebInspector.Popover.prototype._update):
2712         (WebInspector.Popover.prototype.drawBackground):
2713         (WebInspector.Popover.prototype._animateFrame):
2714         (WebInspector.Popover.prototype._drawFrame):
2715         (WebInspector.Popover.prototype._addListenersIfNeeded):
2716         (WebInspector.Popover.prototype._animateFrame.drawBackground): Deleted.
2717         * UserInterface/Views/SourceCodeTextEditor.js:
2718         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2719         (WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
2720         (WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
2721
2722 2014-08-28  Saam Barati  <sbarati@apple.com>
2723
2724         Web Inspector: Write tests for ScriptSyntaxTree and fix bugs in the data structure
2725         https://bugs.webkit.org/show_bug.cgi?id=136272
2726
2727         Reviewed by Joseph Pecoraro.
2728
2729         Include the necessary files in Test.html to test ScriptSyntaxTree.
2730         Also, ScriptSyntaxTree had a couple of errors for two of its nodes
2731         where they simply ignored one of the properties on the node.
2732         These errors were found while writing the tests and are fixed
2733         in this patch.
2734
2735         * UserInterface/Models/ScriptSyntaxTree.js:
2736         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2737         * UserInterface/Test.html:
2738
2739 2014-08-27  Saam Barati  <sbarati@apple.com>
2740
2741         Web Inspector: Layout issues for popover on not legacy OS
2742         https://bugs.webkit.org/show_bug.cgi?id=136268
2743
2744         Reviewed by Joseph Pecoraro.
2745
2746         On the latest OS, popovers invade the title bar's space which will
2747         cause layout issues because the title bar will render above
2748         the popover. Fix this by providing some padding for popovers on 
2749         not legacy OSs.
2750
2751         * UserInterface/Views/Popover.js:
2752
2753 2014-08-27  Timothy Hatcher  <timothy@apple.com>
2754
2755         REGRESSION: Web Inspector: Legacy toolbar has two different colors in unfocused windowed mode
2756         https://bugs.webkit.org/show_bug.cgi?id=136289
2757
2758         Reviewed by Darin Adler.
2759
2760         * UserInterface/Views/Toolbar.css:
2761         (body.mac-platform.legacy .toolbar): Override the background-color as transparent. Non-legacy
2762         uses a solid color instead of a gradient for window-inactive.
2763
2764 2014-08-26  Saam Barati  <sbarati@apple.com>
2765
2766         Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
2767         https://bugs.webkit.org/show_bug.cgi?id=136160
2768
2769         Reviewed by Joseph Pecoraro.
2770
2771         Check if '_tracking' is already true before calling '_startTracking'
2772         to prevent the assertion from always firing.
2773
2774         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2775         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
2776
2777 2014-08-25  Brent Fulgham  <bfulgham@apple.com>
2778
2779         [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
2780         https://bugs.webkit.org/show_bug.cgi?id=136229
2781
2782         Reviewed by Dean Jackson.
2783
2784         * WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
2785         flag to build-webinspectorui.pl.
2786         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
2787         the OFFICIAL_BUILD flag.
2788
2789 2014-08-24  Benjamin Poulain  <benjamin@webkit.org>
2790
2791         The inspector should not use the "after" pseudo element with the compatibility syntax
2792         https://bugs.webkit.org/show_bug.cgi?id=136204
2793
2794         Reviewed by Darin Adler.
2795
2796         We should only use hte proper pseudo element syntax inside WebKit.
2797
2798         * Tools/PrettyPrinting/codemirror-additions.css:
2799         * Tools/PrettyPrinting/populate/apple.css:
2800
2801 2014-08-24  Brian J. Burg  <burg@cs.washington.edu>
2802
2803         Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
2804         https://bugs.webkit.org/show_bug.cgi?id=136025
2805
2806         Reviewed by Joseph Pecoraro.
2807
2808         Also rename DOM.RGBA in legacy protocol specifications.
2809
2810         * Versions/Inspector-iOS-6.0.json:
2811         * Versions/Inspector-iOS-7.0.json:
2812
2813 2014-08-21  Simon Fraser  <simon.fraser@apple.com>
2814
2815         Add a button to enable paint flashing in the web inspector
2816         https://bugs.webkit.org/show_bug.cgi?id=136133
2817
2818         Reviewed by Tim Hatcher.
2819         
2820         Add a button to the right of the layer borders button to turn on paint flashing.
2821         Future patches will actually enable this feature.
2822
2823         * Localizations/en.lproj/localizedStrings.js: Tooltip strings.
2824         * UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
2825         * UserInterface/Views/DOMTreeContentView.js:
2826         (WebInspector.DOMTreeContentView):
2827         (WebInspector.DOMTreeContentView.prototype.get navigationItems):
2828         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
2829
2830 2014-08-20  Saam Barati  <sbarati@apple.com>
2831
2832         Rename HighFidelityTypeProfiling variables for more clarity
2833         https://bugs.webkit.org/show_bug.cgi?id=135899
2834
2835         Reviewed by Geoffrey Garen.
2836
2837         Change a reference in a comment to a JavaScriptCore file to its 
2838         newly renamed variant.
2839
2840         * UserInterface/Models/ScriptSyntaxTree.js:
2841
2842 2014-08-18  Saam Barati  <sbarati@apple.com>
2843
2844         Web Inspector: Introduce an inspector Abstract Syntax Tree.
2845         https://bugs.webkit.org/show_bug.cgi?id=135763
2846
2847         Reviewed by Joseph Pecoraro.
2848
2849         This patch adds an Abstract Syntax Tree to the Web inspector. 
2850         This syntax tree is modeled off the Esprima.js syntax tree
2851         which complies with the Mozilla Parser API:
2852         https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
2853         Script is the owner of the Web Inspector syntax tree, and has an API
2854         for accessing its syntax tree property.
2855
2856         * UserInterface/External/Esprima/esprima.js:
2857         * UserInterface/Main.html:
2858         * UserInterface/Models/Script.js:
2859         (WebInspector.Script):
2860         (WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
2861         (WebInspector.Script.prototype._resolveResource):
2862         (WebInspector.Script.prototype._makeSyntaxTree):
2863         * UserInterface/Models/ScriptSyntaxTree.js: Added.
2864         (WebInspector.ScriptSyntaxTree):
2865         (WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
2866         (WebInspector.ScriptSyntaxTree.prototype.forEachNode):
2867         (WebInspector.ScriptSyntaxTree.prototype.):
2868         (WebInspector.ScriptSyntaxTree.prototype.filter):
2869         (WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
2870         (WebInspector.ScriptSyntaxTree.prototype.filterByRange):
2871         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
2872         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2873         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2874         (WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
2875         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2876         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
2877         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2878
2879 2014-08-16  Joseph Pecoraro  <pecoraro@apple.com>
2880
2881         Web Inspector: Improve performance of selection range changes viewing Scripts timeline
2882         https://bugs.webkit.org/show_bug.cgi?id=136015
2883
2884         Reviewed by Timothy Hatcher.
2885
2886         * UserInterface/Base/Utilities.js:
2887         (clamp):
2888         Helper function to clamp a value between a min and max.
2889
2890         * UserInterface/Models/ProfileNode.js:
2891         (WebInspector.ProfileNode.prototype.get startTime):
2892         (WebInspector.ProfileNode.prototype.get endTime):
2893         These can be quickly calculated, so avoid full calculation to grab the values.
2894
2895         * UserInterface/Views/ScriptTimelineView.js:
2896         (WebInspector.ScriptTimelineView.prototype.updateLayout):
2897         Update ranges with a smart helper, instead of blindly doing it and needing refresh.
2898
2899         * UserInterface/Views/ProfileNodeDataGridNode.js:
2900         (WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
2901         (WebInspector.ProfileNodeDataGridNode.prototype.get data):
2902         (WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
2903         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
2904         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.
2905         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2906         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2907         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
2908         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
2909         When updating the range selection, compare to the last range selection
2910         on this DataGridNode. If the visible portion of this node's time range
2911         changes, we need a refresh. Otherwise, we don't need a refresh.
2912
2913 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2914
2915         Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
2916         https://bugs.webkit.org/show_bug.cgi?id=136006
2917
2918         Reviewed by Timothy Hatcher.
2919
2920         * Scripts/update-LegacyInspectorBackendCommands.rb:
2921         Use the new generator and pass the appropriate flags.
2922
2923         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
2924         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
2925         Newly generated files using the new generator.
2926
2927         * Versions/Inspector-iOS-6.0.json:
2928         Remove unsupported features.
2929
2930 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2931
2932         Web Inspector: Remove forced layouts during recording caused by striped background element resizing
2933         https://bugs.webkit.org/show_bug.cgi?id=136009
2934
2935         Reviewed by Timothy Hatcher.
2936
2937         We used to manually resize and a custom striped background behind
2938         the timeline tree outline content area. This can happen frequently
2939         during timeline recordings causing forced layouts. We can eliminate
2940         the hack and instead put the stripe background on the tree outline.
2941
2942         * UserInterface/Views/TimelineSidebarPanel.js:
2943         (WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2944         * UserInterface/Views/TimelineSidebarPanel.css:
2945         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
2946         (.sidebar > .panel.navigation.timeline > .content > .stripe-background): Deleted.
2947         (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background): Deleted.
2948         Eliminate the striped background element.
2949
2950         * UserInterface/Views/TimelineView.css:
2951         (.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline):
2952         (.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
2953         Give the timeline content tree outlines the striped background.
2954
2955         * UserInterface/Views/NavigationSidebarPanel.js:
2956         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2957         (WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2958         Remove the now unused updateCustomContentOverflow method.
2959
2960 2014-08-15  Jono Wells  <jonowells@apple.com>
2961
2962         Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
2963         https://bugs.webkit.org/show_bug.cgi?id=135995
2964
2965         Reviewed by Joseph Pecoraro.
2966
2967         Change so if an element is inspected via the Inspect Element context menu, selected
2968         node restoration is disallowed until the main resource in the main frame changes.
2969         This way an attempt by a sub-frame will not change the highlighted element in the
2970         Main Frame's DOM tree unexpectedly.
2971
2972         * UserInterface/Controllers/DOMTreeManager.js:
2973         (WebInspector.DOMTreeManager):
2974         (WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
2975         (WebInspector.DOMTreeManager.prototype.inspectElement):
2976
2977 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
2978
2979         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2980         https://bugs.webkit.org/show_bug.cgi?id=131596
2981
2982         Reviewed by Joseph Pecoraro.
2983
2984         Also apply type extraction refactorings to old protocol versions for consistency.
2985
2986         * Versions/Inspector-iOS-6.0.json:
2987         * Versions/Inspector-iOS-7.0.json:
2988
2989 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2990
2991         Web Inspector: Probe details sidebar data grids do not show data
2992         https://bugs.webkit.org/show_bug.cgi?id=135992
2993
2994         Reviewed by Joseph Pecoraro.
2995
2996         * UserInterface/Views/ProbeSetDataGrid.js:
2997         (WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.
2998
2999 2014-08-15  Timothy Hatcher  <timothy@apple.com>
3000
3001         Web Inspector: Legacy Mac toolbar appearance looks wrong
3002         https://bugs.webkit.org/show_bug.cgi?id=135962
3003
3004         Reviewed by Joseph Pecoraro.
3005
3006         * UserInterface/Views/Toolbar.css:
3007         (body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
3008         Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
3009         applies all the time as it should have.
3010
3011 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3012
3013         Web Inspector: Dragging Undocked inspector by window title has broken behavior
3014         https://bugs.webkit.org/show_bug.cgi?id=135950
3015
3016         Reviewed by Timothy Hatcher.
3017
3018         * UserInterface/Base/Main.js:
3019         On Mac ports where we the inspector content goes everywhere, window dragging behavior
3020         still exists for the top 22px of the window. So don't do our JavaScript based window
3021         dragging for this special region.
3022
3023         * UserInterface/Models/KeyboardShortcut.js:
3024         (WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
3025         (WebInspector.KeyboardShortcut.prototype.get displayName):
3026         Instead of calling a host function, use the value already in the frontend.
3027
3028 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3029
3030         Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
3031         https://bugs.webkit.org/show_bug.cgi?id=135957
3032
3033         Reviewed by Timothy Hatcher.
3034
3035         * UserInterface/Views/LogContentView.js:
3036         (WebInspector.LogContentView):
3037         Wrong image path passed to platformImagePath.
3038
3039 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3040
3041         Web Inspector: Avoid re-binding the same function over and over
3042         https://bugs.webkit.org/show_bug.cgi?id=135949
3043
3044         Reviewed by Timothy Hatcher.
3045
3046         * UserInterface/Controllers/TimelineManager.js:
3047         (WebInspector.TimelineManager.prototype._startAutoCapturing):
3048         (WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
3049         (WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
3050         Stash a bound copy of the function once, and reuse it.
3051
3052 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
3053
3054         Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
3055         https://bugs.webkit.org/show_bug.cgi?id=135946
3056
3057         Reviewed by Timothy Hatcher.
3058
3059         Each TimelineContentView was listening for the TimelineManager's start/stop
3060         capturing events. However, only the active recording could possibly update.
3061         Likewise, if a pre-existing recording started and stopped we did not properly
3062         stop in the case where we were waiting for an event to update the current time,
3063         which would result in an infinite rAF loop of no updates.
3064
3065         * UserInterface/Models/TimelineRecording.js:
3066         (WebInspector.TimelineRecording.prototype.unloaded):
3067         When a timeline recording is unloaded trigger an event.
3068
3069         * UserInterface/Views/TimelineContentView.js:
3070         (WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
3071         Assert we were not already waiting.
3072
3073         (WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
3074         Properly handle the case of starting/stoping an already existing recording
3075         without a new event coming in.
3076
3077         (WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
3078         (WebInspector.TimelineContentView.prototype._recordingReset):
3079         Convert to a boolean instead of deleting state.
3080
3081         (WebInspector.TimelineContentView.prototype._recordingUnloaded):
3082         Stop listening to timeline manager events that no longer affect unloaded recordings.
3083
3084 2014-08-13  Jono Wells  <jonowells@apple.com>
3085
3086         Web Inspector: eslint configuration should be stored as .eslintrc
3087         https://bugs.webkit.org/show_bug.cgi?id=135916
3088
3089         .eslintrc file added to allow for ESLint solutions, within editors and otherwise,
3090         to be automatically configured based on the WebKit JavaScript coding style. The
3091         initial file is incomplete.
3092
3093         Reviewed by Joseph Pecoraro.
3094
3095         * .eslintrc: Added.
3096         * External/.eslintrc: Added.
3097
3098 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3099
3100         Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
3101         https://bugs.webkit.org/show_bug.cgi?id=135917
3102
3103         Reviewed by Joseph Pecoraro.
3104
3105         * UserInterface/Views/TimelineSidebarPanel.js:
3106
3107 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3108
3109         Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
3110         https://bugs.webkit.org/show_bug.cgi?id=135894
3111
3112         Reviewed by Timothy Hatcher.
3113
3114         * UserInterface/Views/DetailsSection.css:
3115         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
3116         In legacy styles the details-section header always has a 1px bottom border.
3117         In all styles, an inline data grid had a 1px border everywhere. So, handle
3118         this specific case by removing the top border of an inline data grid
3119         that is inside an expanded details section.
3120
3121 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3122
3123         Web Inspector: "No Filter Results" view only shows once, does not show again
3124         https://bugs.webkit.org/show_bug.cgi?id=135892
3125
3126         Reviewed by Timothy Hatcher.
3127
3128         * UserInterface/Views/NavigationSidebarPanel.js:
3129         (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
3130         We were checking at the wrong level for a parent. Check if the root
3131         placeholder element has a parent or not.
3132
3133 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3134
3135         Web Inspector: Incorrect border colors in event listeners sections in details sidebar
3136         https://bugs.webkit.org/show_bug.cgi?id=135891
3137
3138         Reviewed by Timothy Hatcher.
3139
3140         * UserInterface/Views/DetailsSection.css:
3141         (.details-section .details-section > .header):
3142         (.details-section .details-section:not(.collapsed) > .header):
3143         Remove box-shadow and replace with a bottom border.
3144
3145         (body.mac-platform.legacy .details-section .details-section.collapsed > .header):
3146         (.details-section .details-section.collaspsed > .header): Deleted.
3147         Collapsed was spelled incorrectly so this was not applying properly before.
3148         But correct this for legacy because legacy still uses a box-shadow.
3149
3150 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3151
3152         Web Inspector: Timeline Close buttons can use polish for new and legacy styles
3153         https://bugs.webkit.org/show_bug.cgi?id=135870
3154
3155         Reviewed by Timothy Hatcher.
3156
3157         * UserInterface/Images/Legacy/Close.svg:
3158         Ensure this has fill colors in tree selections.
3159
3160         * UserInterface/Views/TimelineSidebarPanel.css:
3161         (.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3162         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3163         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
3164         Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).
3165
3166 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3167
3168         Web Inspector: Workaround a NSWindow change to the title bar.
3169         https://bugs.webkit.org/show_bug.cgi?id=135880
3170
3171         Reviewed by Joseph Pecoraro.
3172
3173         * UserInterface/Base/Main.js:
3174         (WebInspector._updateToolbarHeight): Don't call in legacy mode.
3175
3176         * UserInterface/Views/DashboardContainerView.css:
3177         (.toolbar .dashboard-container):
3178         (.toolbar .dashboard):
3179         Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
3180         drop shadow down when it shouldn't. Remove duplicate background and shadow.
3181
3182         * UserInterface/Views/Main.css:
3183         (body): Set the background white, never needs to be transparent now.
3184         (body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
3185         (body.docked.bottom): Update border color.
3186         (body.docked.right): Ditto.
3187         (body.docked.bottom.mac-platform.legacy): Keep old border color.
3188         (body.docked.right.mac-platform.legacy): Ditto.
3189
3190         * UserInterface/Views/Toolbar.css:
3191         (.toolbar): Set a default border and background gradient.
3192         (body.window-inactive .toolbar): No gradient but use a solid color when inactive.
3193         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
3194         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
3195         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
3196         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
3197         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
3198         (body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
3199         (body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
3200         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
3201         (body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.
3202
3203 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3204
3205         Web Inspector: Restore Helvetica as the dashboard font in legacy mode
3206         https://bugs.webkit.org/show_bug.cgi?id=135886
3207
3208         Reviewed by Joseph Pecoraro.
3209
3210         * UserInterface/Views/DefaultDashboardView.css:
3211         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3212
3213 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3214
3215         Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar