Delete WebMetal implementation in favor of WebGPU
[WebKit-https.git] / Source / WebCore / PAL / ChangeLog
1 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Delete WebMetal implementation in favor of WebGPU
4         https://bugs.webkit.org/show_bug.cgi?id=195418
5
6         Reviewed by Dean Jackson.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
11
12         Implement ResizeObserver.
13         https://bugs.webkit.org/show_bug.cgi?id=157743
14
15         Reviewed by Simon Fraser.
16
17         Add ENABLE_RESIZE_OBSERVER.
18
19         * Configurations/FeatureDefines.xcconfig:
20
21 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
22
23         Remove NavigatorContentUtils in WebCore/Modules
24         https://bugs.webkit.org/show_bug.cgi?id=196070
25
26         Reviewed by Alex Christensen.
27
28         NavigatorContentUtils was to support the custom scheme spec [1].
29         However, in WebKit side, no port has supported the feature in
30         WebKit layer after EFL port was removed. So there has been the
31         only IDL implementation of the NavigatorContentUtils in WebCore.
32         So we don't need to keep the implementation in WebCore anymore.
33
34         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
35
36         * Configurations/FeatureDefines.xcconfig:
37
38 2019-03-23  Andy Estes  <aestes@apple.com>
39
40         [Apple Pay] Stop calling PKPaymentAuthorizationViewController class methods on iOS
41         https://bugs.webkit.org/show_bug.cgi?id=196163
42         <rdar://problem/48787564>
43
44         Reviewed by Anders Carlsson.
45
46         * pal/spi/cocoa/PassKitSPI.h:
47
48 2019-03-22  Keith Rollin  <krollin@apple.com>
49
50         Enable ThinLTO support in Production builds
51         https://bugs.webkit.org/show_bug.cgi?id=190758
52         <rdar://problem/45413233>
53
54         Reviewed by Daniel Bates.
55
56         Enable building with Thin LTO in Production when using Xcode 10.2 or
57         later. This change results in a 1.45% progression in PLT5. Full
58         Production build times increase about 2-3%. Incremental build times
59         are more severely affected, and so LTO is not enabled for local
60         engineering builds.
61
62         LTO is enabled only on macOS for now, until rdar://problem/49013399,
63         which affects ARM builds, is fixed.
64
65         Removed the conditionals that disabled LTO on 32-bit systems since we
66         no longer build for those.
67
68         To change the LTO setting when building locally:
69
70         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
71           command line.
72         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
73           on the command line.
74         - If building with `build-root`, specify --lto={none,thin,full} on the
75           command line.
76         - If building with Xcode, create a LocalOverrides.xcconfig file at the
77           top level of your repository directory (if needed) and define
78           WK_LTO_MODE to full, thin, or none.
79
80         * Configurations/Base.xcconfig:
81
82 2019-03-22  Timothy Hatcher  <timothy@apple.com>
83
84         Change macosx() to macos() in WK_API... and JSC_API... macros.
85         https://bugs.webkit.org/show_bug.cgi?id=196106
86
87         Reviewed by Brian Burg.
88
89         * pal/spi/cocoa/NSTouchBarSPI.h:
90
91 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
92
93         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
94         https://bugs.webkit.org/show_bug.cgi?id=196049
95
96         Reviewed by Tim Horton.
97
98         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
99         overflow scrolling in general, so rename it.
100
101         * Configurations/FeatureDefines.xcconfig:
102
103 2019-03-19  Ross Kirsling  <ross.kirsling@sony.com>
104
105         Unreviewed adjustment to r242842 per Darin's request.
106
107         * pal/win/LoggingWin.cpp:
108         (PAL::logLevelString):
109
110 2019-03-14  Brent Fulgham  <bfulgham@apple.com>
111
112         Move CoreCrypto SPI declarations to an appropriate PAL/spi header
113         https://bugs.webkit.org/show_bug.cgi?id=195754
114         <rdar://problem/48591957>
115
116         Reviewed by Jiewen Tan.
117
118         Move the forward declarations of various CoreCrypto SPI to an appropriate PAL/spi header.
119         Update the const correctness of one function call to match new SDK declaration.
120
121         No tests because there are no changes in behavior.
122
123         * PAL.xcodeproj/project.pbxproj:
124         * pal/spi/cocoa/CommonCryptoSPI.h: Copied from Source/WebCore/crypto/CommonCryptoUtilities.h.
125
126 2019-03-14  Shawn Roberts  <sroberts@apple.com>
127
128         Unreviewed, rolling out r242981.
129
130         Causing internal build failures on watch/tv OS
131
132         Reverted changeset:
133
134         "Move CoreCrypto SPI declarations to an appropriate PAL/spi
135         header"
136         https://bugs.webkit.org/show_bug.cgi?id=195754
137         https://trac.webkit.org/changeset/242981
138
139 2019-03-14  Brent Fulgham  <bfulgham@apple.com>
140
141         Move CoreCrypto SPI declarations to an appropriate PAL/spi header
142         https://bugs.webkit.org/show_bug.cgi?id=195754
143         <rdar://problem/48591957>
144
145         Reviewed by Jiewen Tan.
146
147         Move the forward declarations of various CoreCrypto SPI to an appropriate PAL/spi header.
148         Update the const correctness of one function call to match new SDK declaration.
149
150         No tests because there are no changes in behavior.
151
152         * PAL.xcodeproj/project.pbxproj:
153         * pal/spi/cocoa/CommonCryptoSPI.h: Copied from Source/WebCore/crypto/CommonCryptoUtilities.h.
154
155 2019-03-14  Ryan Haddad  <ryanhaddad@apple.com>
156
157         Unreviewed, rolling out r242963.
158
159         Breaks watchOS build.
160
161         Reverted changeset:
162
163         "Move CommonCrypto SPI declarations to an appropriate PAL/spi
164         header"
165         https://bugs.webkit.org/show_bug.cgi?id=195754
166         https://trac.webkit.org/changeset/242963
167
168 2019-03-14  Brent Fulgham  <bfulgham@apple.com>
169
170         Move CommonCrypto SPI declarations to an appropriate PAL/spi header
171         https://bugs.webkit.org/show_bug.cgi?id=195754
172         <rdar://problem/48591957>
173
174         Reviewed by Jiewen Tan.
175
176         Move the forward declarations of various CommonCrypto SPI to an appropriate PAL/spi header.
177         Update the const correctness of one function call to match new SDK declaration.
178
179         No tests because there are no changes in behavior.
180
181         * PAL.xcodeproj/project.pbxproj:
182         * pal/spi/cocoa/CommonCryptoSPI.h: Copied from Source/WebCore/crypto/CommonCryptoUtilities.h.
183
184 2019-03-13  Keith Rollin  <krollin@apple.com>
185
186         Add support for new StagedFrameworks layout
187         https://bugs.webkit.org/show_bug.cgi?id=195543
188
189         Reviewed by Alexey Proskuryakov.
190
191         When creating the WebKit layout for out-of-band Safari/WebKit updates,
192         use an optional path prefix when called for.
193
194         * Configurations/PAL.xcconfig:
195
196 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
197
198         [Win] Fix a slew of simple clang-cl warnings.
199         https://bugs.webkit.org/show_bug.cgi?id=195652
200
201         Reviewed by Don Olmstead.
202
203         * pal/win/LoggingWin.cpp:
204         (PAL::logLevelString): -Wwritable-strings
205
206 2019-03-12  Timothy Hatcher  <timothy@apple.com>
207
208         Expose document attributes and body background color through HTMLConverter.
209         https://bugs.webkit.org/show_bug.cgi?id=195636
210         rdar://problem/45055697
211
212         Reviewed by Tim Horton.
213
214         * pal/spi/cocoa/NSAttributedStringSPI.h:
215         (NSBackgroundColorDocumentAttribute): Added.
216
217 2019-03-12  Jennifer Moore  <jennifer.moore@apple.com>
218
219         Check whether to launch a default action instead of action sheet
220         https://bugs.webkit.org/show_bug.cgi?id=195225
221         <rdar://problem/47715544>
222
223         Reviewed by Daniel Bates.
224
225         Add new SPI declarations.
226
227         * pal/spi/ios/DataDetectorsUISPI.h:
228
229 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
230
231         Add Optional to Forward.h.
232         https://bugs.webkit.org/show_bug.cgi?id=195586
233
234         Reviewed by Darin Adler.
235
236         * pal/crypto/tasn1/Utilities.cpp:
237         * pal/crypto/tasn1/Utilities.h:
238         Remove unnecessary includes from headers.
239
240 2019-03-11  Andy Estes  <aestes@apple.com>
241
242         [Apple Pay] Use PKPaymentAuthorizationController to present the Apple Pay UI remotely from the Networking service on iOS
243         https://bugs.webkit.org/show_bug.cgi?id=195530
244         <rdar://problem/48747164>
245
246         Reviewed by Alex Christensen.
247
248         * pal/cocoa/PassKitSoftLink.h: Soft-linked PKPaymentAuthorizationController on iOS.
249         * pal/cocoa/PassKitSoftLink.mm: Ditto.
250         * pal/spi/cocoa/PassKitSPI.h: Declared PKPaymentAuthorizationControllerPrivateDelegate and
251         related SPI.
252
253 2019-03-11  Alex Christensen  <achristensen@webkit.org>
254
255         Soft linking to Reveal framework should be optional
256         https://bugs.webkit.org/show_bug.cgi?id=195576
257         <rdar://problem/46822452>
258
259         Reviewed by Megan Gardner.
260
261         * pal/spi/cocoa/RevealSPI.h:
262
263 2019-03-07  Andy Estes  <aestes@apple.com>
264
265         [Apple Pay] Untangle PKPaymentAuthorizationViewController from WebPaymentCoordinatorProxy
266         https://bugs.webkit.org/show_bug.cgi?id=195349
267         <rdar://problem/48625510>
268
269         Reviewed by Alex Christensen.
270
271         Moved soft-linking of PKPaymentErrorDomain from WebPaymentCoordinatorProxy to here and used
272         a more descriptive platform macro.
273
274         * pal/cocoa/PassKitSoftLink.h:
275         * pal/cocoa/PassKitSoftLink.mm:
276
277 2019-03-01  Conrad Shultz  <conrad_shultz@apple.com>
278
279         Improper use of PLATFORM(TVOS) in PAL
280         https://bugs.webkit.org/show_bug.cgi?id=195215
281
282         Reviewed by Darin Adler.
283
284         There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is
285         PLATFORM(APPLETV).
286
287         * pal/spi/cocoa/NSKeyedArchiverSPI.h:
288         * pal/spi/cocoa/NSProgressSPI.h:
289
290 2019-03-03  Tim Horton  <timothy_horton@apple.com>
291
292         Remove some more unused 32-bit code
293         https://bugs.webkit.org/show_bug.cgi?id=195255
294
295         Reviewed by Darin Adler.
296
297         * PAL.xcodeproj/project.pbxproj:
298         * pal/PlatformMac.cmake:
299         * pal/spi/cocoa/IOKitSPI.h:
300         * pal/spi/mac/QuickDrawSPI.h: Removed.
301
302 2019-03-01  Justin Fan  <justin_fan@apple.com>
303
304         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
305         https://bugs.webkit.org/show_bug.cgi?id=195191
306
307         Rubber-stamped by Dean Jackson.
308
309         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
310
311         * Configurations/FeatureDefines.xcconfig:
312
313 2019-02-28  Justin Fan  <justin_fan@apple.com>
314
315         [Web GPU] Enable Web GPU only on 64-bit
316         https://bugs.webkit.org/show_bug.cgi?id=195139
317
318         Because Metal is only supported on 64 bit apps.
319
320         Unreviewed build fix.
321
322         * Configurations/FeatureDefines.xcconfig:
323
324 2019-02-27  Antoine Quint  <graouts@apple.com>
325
326         Support Pointer Events on macOS
327         https://bugs.webkit.org/show_bug.cgi?id=195008
328         <rdar://problem/47454419>
329
330         Reviewed by Dean Jackson.
331
332         * Configurations/FeatureDefines.xcconfig:
333
334 2019-02-23  Keith Miller  <keith_miller@apple.com>
335
336         Add new mac target numbers
337         https://bugs.webkit.org/show_bug.cgi?id=194955
338
339         Reviewed by Tim Horton.
340
341         * Configurations/Base.xcconfig:
342         * Configurations/DebugRelease.xcconfig:
343
344 2019-02-20  Daniel Bates  <dabates@apple.com>
345
346         Attempt to fix the Apple Internal build following r241828
347         (https://trac.webkit.org/changeset/241828/webkit)
348
349         Conditionally include a private header.
350
351         * pal/spi/ios/UIKitSPI.h:
352
353 2019-02-20  Daniel Bates  <dabates@apple.com>
354
355         [iOS] Tweak UI for focus rings
356         https://bugs.webkit.org/show_bug.cgi?id=194864
357         <rdar://problem/47831886>
358
359         Reviewed by Brent Fulgham.
360
361         Expose more SPI.
362
363         * pal/ios/UIKitSoftLink.h:
364         * pal/ios/UIKitSoftLink.mm:
365         * pal/spi/ios/UIKitSPI.h:
366
367 2019-02-20  Timothy Hatcher  <timothy@apple.com>
368
369         RenderThemeIOS should use RenderTheme's color cache instead of its own.
370         https://bugs.webkit.org/show_bug.cgi?id=194822
371         rdar://problem/48208296
372
373         Reviewed by Tim Horton.
374
375         * pal/ios/UIKitSoftLink.h:
376         * pal/ios/UIKitSoftLink.mm:
377         * pal/spi/ios/UIKitSPI.h:
378
379 2019-02-16  Darin Adler  <darin@apple.com>
380
381         Continue reducing use of String::format, now focusing on hex: "%p", "%x", etc.
382         https://bugs.webkit.org/show_bug.cgi?id=194752
383
384         Reviewed by Daniel Bates.
385
386         * pal/FileSizeFormatter.cpp:
387         (fileSizeDescription): Use makeString instead of String::format.
388
389 2019-02-18  Daniel Bates  <dabates@apple.com>
390
391         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
392         https://bugs.webkit.org/show_bug.cgi?id=192824
393         <rdar://problem/47100332>
394
395         Reviewed by Wenson Hsieh.
396
397         Expose more enumerators.
398
399         * pal/spi/cocoa/IOKitSPI.h:
400
401 2019-02-17  David Kilzer  <ddkilzer@apple.com>
402
403         Unreviewed, rolling out r241620.
404
405         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
406         (Requested by ddkilzer on #webkit.)
407
408         Reverted changeset:
409
410         "[WTF] Add environment variable helpers"
411         https://bugs.webkit.org/show_bug.cgi?id=192405
412         https://trac.webkit.org/changeset/241620
413
414 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
415
416         [WTF] Add environment variable helpers
417         https://bugs.webkit.org/show_bug.cgi?id=192405
418
419         Reviewed by Michael Catanzaro.
420
421         * pal/unix/LoggingUnix.cpp:
422         (PAL::logLevelString):
423         * pal/win/LoggingWin.cpp:
424         (PAL::logLevelString):
425         Utilize WTF::Environment where possible.
426
427 2019-02-15  Commit Queue  <commit-queue@webkit.org>
428
429         Unreviewed, rolling out r241559 and r241566.
430         https://bugs.webkit.org/show_bug.cgi?id=194710
431
432         Causes layout test crashes under GuardMalloc (Requested by
433         ryanhaddad on #webkit).
434
435         Reverted changesets:
436
437         "[WTF] Add environment variable helpers"
438         https://bugs.webkit.org/show_bug.cgi?id=192405
439         https://trac.webkit.org/changeset/241559
440
441         "Unreviewed build fix for WinCairo Debug after r241559."
442         https://trac.webkit.org/changeset/241566
443
444 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
445
446         [WTF] Add environment variable helpers
447         https://bugs.webkit.org/show_bug.cgi?id=192405
448
449         Reviewed by Michael Catanzaro.
450
451         * pal/unix/LoggingUnix.cpp:
452         (PAL::logLevelString):
453         * pal/win/LoggingWin.cpp:
454         (PAL::logLevelString):
455         Utilize WTF::Environment where possible.
456
457 2019-02-12  Chris Fleizach  <cfleizach@apple.com>
458
459         AX: IsolatedTree: Implement more attributes
460         https://bugs.webkit.org/show_bug.cgi?id=193911
461         <rdar://problem/47599217>
462
463         Reviewed by Daniel Bates.
464
465         * pal/spi/mac/HIServicesSPI.h:
466
467 2019-02-12  Andy Estes  <aestes@apple.com>
468
469         [iOSMac] Enable Parental Controls Content Filtering
470         https://bugs.webkit.org/show_bug.cgi?id=194521
471         <rdar://39732376>
472
473         Reviewed by Tim Horton.
474
475         * Configurations/FeatureDefines.xcconfig:
476
477 2019-02-11  Jer Noble  <jer.noble@apple.com>
478
479         Unreviewed build fix; add a HAVE_CELESTIAL guard around the CelestialSPI.h contents.
480
481         * pal/spi/ios/CelestialSPI.h:
482
483 2019-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
484
485         [WPE][GTK] Sleep disabler code should inhibit idle when a "System" sleep disabler is requested
486         https://bugs.webkit.org/show_bug.cgi?id=194500
487
488         Reviewed by Carlos Garcia Campos.
489
490         There are three things wrong with the comment at the top of SleepDisablerGLib's constructor:
491
492         (1) Nowadays, GNOME suspends the computer automatically on inactivity, and we actually do
493             want to prevent that.
494
495         (2) Inhibiting idle does affect the autosuspend countdown. So the current code should
496             prevent automatic suspend, just not manual suspend. (I think I stand by my comment that
497             we do not want to inhibit normal suspend, since that would just be annoying.)
498
499         (3) I don't know why I thought HTMLMediaElement::shouldDisableSleep was suspicious.
500
501         Anyway, the behavior we want is to ignore the Type argument and just always inhibit idle.
502         That is, treat type=System the same way we current treat type=Display.
503
504         * pal/system/glib/SleepDisablerGLib.cpp:
505         (PAL::SleepDisablerGLib::SleepDisablerGLib):
506
507 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
508
509         [Cocoa] Ask platform for generic font family mappings
510         https://bugs.webkit.org/show_bug.cgi?id=187723
511         <rdar://problem/41892438>
512
513         Reviewed by Brent Fulgham.
514
515         * pal/spi/cocoa/CoreTextSPI.h:
516
517 2019-02-11  Jer Noble  <jer.noble@apple.com>
518
519         [Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
520         https://bugs.webkit.org/show_bug.cgi?id=194504
521
522         Reviewed by Eric Carlson.
523
524         * PAL.xcodeproj/project.pbxproj:
525         * pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h.
526
527 2019-02-11  Truitt Savell  <tsavell@apple.com>
528
529         Unreviewed, rolling out r241229.
530
531         Revision broke internal builds for watchOS.
532
533         Reverted changeset:
534
535         "[Cocoa] Ask platform for generic font family mappings"
536         https://bugs.webkit.org/show_bug.cgi?id=187723
537         https://trac.webkit.org/changeset/241229
538
539 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
540
541         [Cocoa] Ask platform for generic font family mappings
542         https://bugs.webkit.org/show_bug.cgi?id=187723
543         <rdar://problem/41892438>
544
545         Reviewed by Brent Fulgham.
546
547         * pal/spi/cocoa/CoreTextSPI.h:
548
549 2019-02-07  Chris Dumez  <cdumez@apple.com>
550
551         Mark more heap-allocated classes as fast allocated
552         https://bugs.webkit.org/show_bug.cgi?id=194422
553
554         Reviewed by Ryosuke Niwa.
555
556         * pal/crypto/openssl/CryptoDigestOpenSSL.cpp:
557         * pal/system/Clock.h:
558
559 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
560
561         Unreviewed, rolling out r240742.
562
563         Causes crashes on iOS simulator.
564
565         Reverted changeset:
566
567         "[iOS] Keyups for non-modifier keys identified as "Dead" when
568         not focused in a content-editable element"
569         https://bugs.webkit.org/show_bug.cgi?id=192824
570         https://trac.webkit.org/changeset/240742
571
572 2018-12-16  Darin Adler  <darin@apple.com>
573
574         Convert additional String::format clients to alternative approaches
575         https://bugs.webkit.org/show_bug.cgi?id=192746
576
577         Reviewed by Alexey Proskuryakov.
578
579         * pal/FileSizeFormatter.cpp:
580         (fileSizeDescription): Use makeString and FormattedNumber.
581
582 2019-02-01  David Kilzer  <ddkilzer@apple.com>
583
584         Move soft-linking of TelephonyUtilities.framework out of TUCallSPI.h
585         <https://webkit.org/b/193866>
586
587         Reviewed by Alex Christensen.
588
589         * PAL.xcodeproj/project.pbxproj:
590         * pal/PlatformMac.cmake:
591         - Update for rename of TUCallSPI.h to TelephonyUtilitiesSPI.h.
592
593         * pal/spi/mac/TelephonyUtilitiesSPI.h: Rename from Source/WebCore/PAL/pal/spi/mac/TUCallSPI.h.
594         - Remove soft-linking code from header.
595
596 2019-01-30  Daniel Bates  <dabates@apple.com>
597
598         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
599         https://bugs.webkit.org/show_bug.cgi?id=192824
600         <rdar://problem/47100332>
601
602         Reviewed by Wenson Hsieh.
603
604         Expose more enumerators.
605
606         * pal/spi/cocoa/IOKitSPI.h:
607
608 2019-01-28  Andy Estes  <aestes@apple.com>
609
610         [watchOS] Enable Parental Controls content filtering
611         https://bugs.webkit.org/show_bug.cgi?id=193939
612         <rdar://problem/46641912>
613
614         Reviewed by Ryosuke Niwa.
615
616         * Configurations/FeatureDefines.xcconfig:
617
618 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
619
620         AX: Introduce isolated accessibility tree
621         https://bugs.webkit.org/show_bug.cgi?id=193348
622         <rdar://problem/47203295>
623
624         Reviewed by Ryosuke Niwa.
625
626         * Configurations/FeatureDefines.xcconfig:
627
628 2019-01-25  Alex Christensen  <achristensen@webkit.org>
629
630         Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
631         https://bugs.webkit.org/show_bug.cgi?id=193844
632
633         Reviewed by Andy Estes.
634
635         * pal/spi/mac/HIServicesSPI.h:
636
637 2019-01-25  David Kilzer  <ddkilzer@apple.com>
638
639         Move soft-linking of Lookup.framework out of LookupSPI.h
640         <https://webkit.org/b/193815>
641
642         Reviewed by Tim Horton.
643
644         * PAL.xcodeproj/project.pbxproj:
645         * pal/PlatformMac.cmake:
646         - Add LookupSoftLink.{h,mm} files to the project.
647
648         * pal/ios/UIKitSoftLink.h:
649         * pal/ios/UIKitSoftLink.mm:
650         - Change SOFT_LINK_VARIABLE_FOR_HEADER() to
651           SOFT_LINK_CONSTANT_FOR_HEADER() for
652           UIAccessibilityAnnouncementNotification constant.
653
654         * pal/mac/LookupSoftLink.h: Copied from Source/WebCore/PAL/pal/spi/mac/LookupSPI.h.
655         * pal/mac/LookupSoftLink.mm: Copied from Source/WebCore/PAL/pal/spi/mac/LookupSPI.h.
656         - Migrate soft-linking from LookupSPI.h to here.
657
658         * pal/spi/mac/LookupSPI.h:
659         - Replace soft-linking of Lookup.framework with
660           LookupSoftLink.h.
661
662 2019-01-24  Eric Carlson  <eric.carlson@apple.com>
663
664         [iOS] Silence MediaPlayer compile warnings
665         https://bugs.webkit.org/show_bug.cgi?id=193780
666         <rdar://problem/47518428>
667
668         Reviewed by Jer Noble.
669
670         * pal/spi/ios/MediaPlayerSPI.h:
671
672 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
673
674         Move FileSystem to WTF
675         https://bugs.webkit.org/show_bug.cgi?id=193602
676
677         Reviewed by Yusuke Suzuki.
678
679         * PAL.xcodeproj/project.pbxproj:
680         * pal/PlatformMac.cmake:
681
682 2019-01-24  David Kilzer  <ddkilzer@apple.com>
683
684         Follow-up #2: Override the session configuration for cookieAcceptPolicy
685         <https://bugs.webkit.org/show_bug.cgi?id=190925>
686         <rdar://problem/45497382>
687
688         * pal/spi/cf/CFNetworkSPI.h: Protect Objective-C code using
689         defined(__OBJC__) macro.
690
691 2019-01-23  David Kilzer  <ddkilzer@apple.com>
692
693         Switch remaining CoreMedia soft-linking in WebKit over to CoreMediaSoftLink.{cpp,h}
694         <https://webkit.org/b/193694>
695         <rdar://problem/47464025>
696
697         Reviewed by Tim Horton.
698
699         * pal/cf/CoreMediaSoftLink.cpp:
700         - Export kCMTimeZero soft-link.
701         * pal/cf/CoreMediaSoftLink.h:
702         - Update kCMTimeZero macro to use PAL namespace for use in
703           WebKit.framework.
704
705 2019-01-22  David Kilzer  <ddkilzer@apple.com>
706
707         Switch remaining QuickLook soft-linking in WebCore, WebKit over to QuickLookSoftLink.{cpp,h}
708         <https://webkit.org/b/193654>
709         <rdar://problem/47430290>
710
711         Reviewed by Alex Christensen.
712
713         - Moves QuickLookSoftLink.{h,mm} to PAL.
714         - Adds soft-link to 3 classes to consolidate QuickLook.framework
715           soft-linking.
716         - Updates existing source to work with above changes.
717
718         * PAL.xcodeproj/project.pbxproj:
719         - Add QuickLookSoftLink.{h,mm} due to move from WebCore.
720
721         * pal/ios/QuickLookSoftLink.h: Renamed from Source/WebCore/platform/ios/QuickLookSoftLink.h.
722         * pal/ios/QuickLookSoftLink.mm: Renamed from Source/WebCore/platform/ios/QuickLookSoftLink.mm.
723         - Add 3 classes for soft-linking.
724         - Change namespace from WebCore to PAL.
725
726 2019-01-21  David Kilzer  <ddkilzer@apple.com>
727
728         Sort PAL Xcode project file
729
730         * PAL.xcodeproj/project.pbxproj:
731
732 2019-01-12  Dan Bernstein  <mitz@apple.com>
733
734         [Cocoa] Avoid importing directly from subumbrella frameworks
735         https://bugs.webkit.org/show_bug.cgi?id=186016
736         <rdar://problem/40591038>
737
738         Reviewed by Sam Weinig.
739
740         * Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and
741           OTHER_CPLUSPLUSFLAGS.
742         * pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h
743           when using SDKs earlier than 10.13.
744         * pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h.
745         * pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header.
746
747 2019-01-20  Antoine Quint  <graouts@apple.com>
748
749         Add a POINTER_EVENTS feature flag
750         https://bugs.webkit.org/show_bug.cgi?id=193577
751         <rdar://problem/47408511>
752
753         Unreviewed. Also enable Pointer Events for iosmac.
754
755         * Configurations/FeatureDefines.xcconfig:
756
757 2019-01-19  Antoine Quint  <graouts@apple.com>
758
759         Add a POINTER_EVENTS feature flag
760         https://bugs.webkit.org/show_bug.cgi?id=193577
761
762         Reviewed by Dean Jackson.
763
764         * Configurations/FeatureDefines.xcconfig:
765
766 2019-01-18  David Kilzer  <ddkilzer@apple.com>
767
768         [PAL] Change Xcode folders to map to folders on disk
769
770         Found by tidy-Xcode-project-file script (see Bug 188754).
771
772         * PAL.xcodeproj/project.pbxproj: Update these folders:
773         - pal/avfoundation
774         - pal/crypto/commoncrypto
775         - pal/ios
776
777 2019-01-18  David Kilzer  <ddkilzer@apple.com>
778
779         Follow-up: Override the session configuration for cookieAcceptPolicy
780         <https://bugs.webkit.org/show_bug.cgi?id=190925>
781         <rdar://problem/45497382>
782
783         Discussed with John Wilander.
784
785         * pal/spi/cf/CFNetworkSPI.h: Declare new SPI for the internal
786         macOS 10.12 Sierra SDK since it will never appear in those
787         headers.  This fixes the build for trunk WebKit on Sierra.
788
789 2019-01-18  Tim Horton  <timothy_horton@apple.com>
790
791         Get rid of ADVANCED_SPELL_CHECKING
792         https://bugs.webkit.org/show_bug.cgi?id=193592
793
794         Reviewed by Wenson Hsieh.
795
796         * pal/spi/mac/NSSpellCheckerSPI.h:
797         It's always true on macOS, and all but one use of it is already inside PLATFORM(MAC)
798
799 2019-01-18  Jer Noble  <jer.noble@apple.com>
800
801         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
802         https://bugs.webkit.org/show_bug.cgi?id=189553
803
804         Reviewed by Tim Horton.
805
806         * Configurations/Base.xcconfig:
807         * Configurations/PAL.xcconfig:
808         * Configurations/SDKVariant.xcconfig: Added.
809
810 2019-01-18  Daniel Bates  <dabates@apple.com>
811
812         CSS auto focus-ring outlines don't render on iOS
813         https://bugs.webkit.org/show_bug.cgi?id=193583
814         <rdar://problem/6508697>
815
816         Reviewed by Simon Fraser.
817
818         Forward declare some IPI.
819
820         * pal/spi/ios/UIKitSPI.h:
821
822 2019-01-18  David Kilzer  <ddkilzer@apple.com>
823
824         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
825         <https://webkit.org/b/193568>
826         <rdar://problem/47381130>
827
828         Reviewed by Alex Christensen.
829
830         * pal/ios/UIKitSoftLink.h:
831         * pal/ios/UIKitSoftLink.mm:
832         - Add constants, classes and functions that were previously
833           soft-linked in separate source files.
834         - UIAccessibilityAnnouncementNotification is declared as a
835           variable because this constant is not marked as `const` in
836           UIKit.
837         * pal/spi/ios/UIKitSPI.h:
838         - Move SPI declarations from HTMLConverter.mm to here.
839
840 2019-01-17  Truitt Savell  <tsavell@apple.com>
841
842         Unreviewed, rolling out r240124.
843
844         This commit broke an internal build.
845
846         Reverted changeset:
847
848         "SDK_VARIANT build destinations should be separate from non-
849         SDK_VARIANT builds"
850         https://bugs.webkit.org/show_bug.cgi?id=189553
851         https://trac.webkit.org/changeset/240124
852
853 2019-01-17  Tim Horton  <timothy_horton@apple.com>
854
855         Adopt NSTextCheckingSuppressInitialCapitalizationKey
856         https://bugs.webkit.org/show_bug.cgi?id=193545
857
858         Reviewed by Dean Jackson.
859
860         * pal/spi/mac/NSSpellCheckerSPI.h:
861
862 2019-01-17  Jer Noble  <jer.noble@apple.com>
863
864         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
865         https://bugs.webkit.org/show_bug.cgi?id=189553
866
867         Reviewed by Tim Horton.
868
869         * Configurations/Base.xcconfig:
870         * Configurations/PAL.xcconfig:
871         * Configurations/SDKVariant.xcconfig: Added.
872
873 2019-01-16  Tim Horton  <timothy_horton@apple.com>
874
875         Unreviewed build fix.
876
877         * pal/spi/ios/UIKitSPI.h:
878         I don't even.
879
880 2019-01-16  Megan Gardner  <megan_gardner@apple.com>
881
882         Build fix for iOSMac Reveal
883         https://bugs.webkit.org/show_bug.cgi?id=193503
884
885         Unreviewed build fix.
886
887         * pal/spi/ios/UIKitSPI.h:
888
889 2019-01-15  Megan Gardner  <megan_gardner@apple.com>
890
891         Add Reveal support in iOSMac
892         https://bugs.webkit.org/show_bug.cgi?id=193408
893         <rdar://problem/47300699>
894
895         Reviewed by Tim Horton.
896
897         Add additional needed SPI.
898
899         * pal/spi/cocoa/RevealSPI.h:
900
901 2019-01-15  Tim Horton  <timothy_horton@apple.com>
902
903         Cannot tab out of WKWebView on macOS
904         https://bugs.webkit.org/show_bug.cgi?id=161448
905         <rdar://problem/28100085>
906
907         Reviewed by Dean Jackson.
908
909         * pal/spi/mac/NSViewSPI.h:
910         * pal/spi/mac/NSWindowSPI.h:
911         Move some SPI declarations in here from WebKitLegacy.
912
913 2019-01-14  Commit Queue  <commit-queue@webkit.org>
914
915         Unreviewed, rolling out r239901, r239909, r239910, r239912,
916         r239913, and r239914.
917         https://bugs.webkit.org/show_bug.cgi?id=193407
918
919         These revisions caused an internal failure (Requested by
920         Truitt on #webkit).
921
922         Reverted changesets:
923
924         "[Cocoa] Avoid importing directly from subumbrella frameworks"
925         https://bugs.webkit.org/show_bug.cgi?id=186016
926         https://trac.webkit.org/changeset/239901
927
928         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
929         https://trac.webkit.org/changeset/239909
930
931         "Tried to fix the build."
932         https://trac.webkit.org/changeset/239910
933
934         "Fixed iOS builds after r239910."
935         https://trac.webkit.org/changeset/239912
936
937         "More build fixing."
938         https://trac.webkit.org/changeset/239913
939
940         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
941         https://trac.webkit.org/changeset/239914
942
943 2019-01-14  Mark Lam  <mark.lam@apple.com>
944
945         Re-enable ability to build --cloop builds.
946         https://bugs.webkit.org/show_bug.cgi?id=192955
947         <rdar://problem/46882363>
948
949         Reviewed by Saam barati and Keith Miller.
950
951         * Configurations/FeatureDefines.xcconfig:
952
953 2019-01-13  Dan Bernstein  <mitz@apple.com>
954
955         Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds.
956
957         * pal/spi/mac/QuickDrawSPI.h:
958
959 2019-01-13  Dan Bernstein  <mitz@apple.com>
960
961         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
962
963         Patch by Keith Rollin.
964
965         * pal/spi/cocoa/LaunchServicesSPI.h:
966         * pal/spi/mac/HIServicesSPI.h:
967         * pal/spi/mac/MetadataSPI.h:
968         * pal/spi/mac/SpeechSynthesisSPI.h:
969
970 2019-01-12  Timothy Hatcher  <timothy@apple.com>
971
972         Have prefers-color-scheme: light always match on macOS versions before Mojave.
973         https://bugs.webkit.org/show_bug.cgi?id=191655
974         rdar://problem/46074680
975
976         Reviewed by Megan Gardner.
977
978         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
979
980 2019-01-12  Dan Bernstein  <mitz@apple.com>
981
982         [Cocoa] Avoid importing directly from subumbrella frameworks
983         https://bugs.webkit.org/show_bug.cgi?id=186016
984         <rdar://problem/40591038>
985
986         Reviewed by Sam Weinig.
987
988         * Configurations/PAL.xcconfig: Removed -iframework options from OTHER_CFLAGS and
989           OTHER_CPLUSPLUSFLAGS.
990         * pal/spi/cg/CoreGraphicsSPI.h: Import ApplicationServices.h instead of ColorSync.h
991           when using SDKs earlier than 10.13.
992         * pal/spi/mac/HIToolboxSPI.h: Import CarbonPriv.h instead of HIToolboxPriv.h.
993         * pal/spi/mac/QuickLookMacSPI.h: Import Quartz.h instead of a QuickLookUI header.
994
995 2019-01-11  John Wilander  <wilander@apple.com>
996
997         Compile out Web API Statistics Collection
998         https://bugs.webkit.org/show_bug.cgi?id=193370
999         <rdar://problem/45388584>
1000
1001         Reviewed by Brent Fulgham.
1002
1003         * Configurations/FeatureDefines.xcconfig:
1004             Defined ENABLE_WEB_API_STATISTICS, off by default.
1005
1006 2019-01-11  Devin Rousso  <drousso@apple.com>
1007
1008         Fix style CFNetworkSPI style checker warnings from r239698
1009         https://bugs.webkit.org/show_bug.cgi?id=193369
1010
1011         Reviewed by Joseph Pecoraro.
1012
1013         * pal/spi/cf/CFNetworkSPI.h:
1014
1015 2019-01-10  John Wilander  <wilander@apple.com>
1016
1017         Override the session configuration for cookieAcceptPolicy
1018         https://bugs.webkit.org/show_bug.cgi?id=190925
1019         <rdar://problem/45497382>
1020
1021         Reviewed by Alexey Proskuryakov and Alex Christensen.
1022
1023         * pal/spi/cf/CFNetworkSPI.h:
1024             Declaration of _overrideSessionCookieAcceptPolicy on NSHTTPCookieStorage.
1025
1026 2019-01-07  Devin Rousso  <drousso@apple.com>
1027
1028         Web Inspector: Network: show secure connection details per-request
1029         https://bugs.webkit.org/show_bug.cgi?id=191539
1030         <rdar://problem/45979891>
1031
1032         Reviewed by Joseph Pecoraro.
1033
1034         * pal/spi/cf/CFNetworkSPI.h:
1035
1036 2019-01-04  Jer Noble  <jer.noble@apple.com>
1037
1038         Web Content process main thread blocked beneath ImageDecoderAVFObjC::readSamples for many seconds on imgur.com
1039         https://bugs.webkit.org/show_bug.cgi?id=191806
1040         <rdar://problem/46151477>
1041
1042         Reviewed by Dean Jackson.
1043
1044         * pal/cf/CoreMediaSoftLink.cpp:
1045         * pal/cf/CoreMediaSoftLink.h:
1046
1047 2018-12-27  Alex Christensen  <achristensen@webkit.org>
1048
1049         Resurrect Mac CMake build
1050         https://bugs.webkit.org/show_bug.cgi?id=192658
1051
1052         Reviewed by Yusuke Suzuki.
1053
1054         * pal/PlatformMac.cmake:
1055
1056 2018-12-21  Eric Carlson  <eric.carlson@apple.com>
1057
1058         'ended' Event doesn't fire on MediaStreamTrack when a USB camera is unplugged
1059         https://bugs.webkit.org/show_bug.cgi?id=187896
1060         <rdar://problem/42681445>
1061
1062         Reviewed by Jer Noble.
1063
1064         * pal/spi/cf/CoreAudioSPI.h:
1065
1066 2018-12-19  Chris Dumez  <cdumez@apple.com>
1067
1068         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1069         https://bugs.webkit.org/show_bug.cgi?id=192728
1070         <rdar://problem/46746779>
1071
1072         Reviewed by Geoff Garen.
1073
1074         * pal/*:
1075
1076 2018-12-17  Saam barati  <sbarati@apple.com>
1077
1078         Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession
1079         https://bugs.webkit.org/show_bug.cgi?id=192374
1080         <rdar://problem/46506286>
1081
1082         Reviewed by Alex Christensen.
1083
1084         * pal/spi/cf/CFNetworkSPI.h:
1085         Remove the now-unused SPI declaration.
1086
1087 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
1088
1089         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
1090         https://bugs.webkit.org/show_bug.cgi?id=192780
1091         rdar://problem/43394387
1092
1093         Reviewed by Tim Horton.
1094
1095         Add CGFontRenderingGetFontSmoothingDisabled().
1096
1097         * pal/spi/cg/CoreGraphicsSPI.h:
1098
1099 2018-12-17  Daniel Bates  <dabates@apple.com>
1100
1101         Implement UIScriptController::toggleCapsLock() for iOS
1102         https://bugs.webkit.org/show_bug.cgi?id=191815
1103
1104         Reviewed by Andy Estes.
1105
1106         Add HID usage enumerator for the Caps Lock key.
1107
1108         * pal/spi/cocoa/IOKitSPI.h:
1109
1110 2018-12-17  Matt Lewis  <jlewis3@apple.com>
1111
1112         Unreviewed, rolling out r239254.
1113
1114         This broke the Windows 10 Debug build
1115
1116         Reverted changeset:
1117
1118         "Replace many uses of String::format with more type-safe
1119         alternatives"
1120         https://bugs.webkit.org/show_bug.cgi?id=192742
1121         https://trac.webkit.org/changeset/239254
1122
1123 2018-12-15  Darin Adler  <darin@apple.com>
1124
1125         Use warning-ignoring macros more consistently and simply
1126         https://bugs.webkit.org/show_bug.cgi?id=192743
1127
1128         Reviewed by Mark Lam.
1129
1130         * pal/spi/cocoa/AVKitSPI.h: Use IGNORE_WARNINGS_BEGIN instead of
1131         IGNORE_CLANG_WARNINGS_BEGIN; there is no special need to accomodate
1132         non-clang compilers here.
1133
1134 2018-12-15  Darin Adler  <darin@apple.com>
1135
1136         Replace many uses of String::format with more type-safe alternatives
1137         https://bugs.webkit.org/show_bug.cgi?id=192742
1138
1139         Reviewed by Mark Lam.
1140
1141         * pal/FileSizeFormatter.cpp:
1142         (fileSizeDescription): Use makeString.
1143
1144 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1145
1146         Implement feature flag for CSS Typed OM
1147         https://bugs.webkit.org/show_bug.cgi?id=192610
1148
1149         Reviewed by Ryosuke Niwa.
1150
1151         * Configurations/FeatureDefines.xcconfig:
1152
1153 2018-12-11  Andy Estes  <aestes@apple.com>
1154
1155         Introduce makeBlockPtr for lambdas
1156         https://bugs.webkit.org/show_bug.cgi?id=192594
1157
1158         Reviewed by Alex Christensen.
1159
1160         Adopted makeBlockPtr.
1161
1162         * pal/Logging.cpp:
1163         (PAL::registerNotifyCallback):
1164
1165 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1166
1167         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1168         https://bugs.webkit.org/show_bug.cgi?id=192573
1169
1170         Reviewed by Simon Fraser.
1171
1172         * Configurations/FeatureDefines.xcconfig:
1173
1174 2018-12-10  Commit Queue  <commit-queue@webkit.org>
1175
1176         Unreviewed, rolling out r239023.
1177         https://bugs.webkit.org/show_bug.cgi?id=192571
1178
1179         Speculative rollout due to broken perf test (Requested by
1180         deanj on #webkit).
1181
1182         Reverted changeset:
1183
1184         "Enable HTTP and HTTPS proxies on iOS and make it a property
1185         of the NSURLSession"
1186         https://bugs.webkit.org/show_bug.cgi?id=192374
1187         https://trac.webkit.org/changeset/239023
1188
1189 2018-12-10  Darin Adler  <darin@apple.com>
1190
1191         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1192         https://bugs.webkit.org/show_bug.cgi?id=192533
1193         rdar://problem/45732710
1194
1195         Reviewed by Anders Carlsson.
1196
1197         * pal/spi/mac/HIServicesSPI.h: Added kMSHDoNotCreateSendRightOption.
1198
1199 2018-12-09  Saam barati  <sbarati@apple.com>
1200
1201         Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession
1202         https://bugs.webkit.org/show_bug.cgi?id=192374
1203         <rdar://problem/46506286>
1204
1205         Reviewed by Alex Christensen.
1206
1207         * pal/spi/cf/CFNetworkSPI.h:
1208         Remove the now-unused SPI declaration.
1209
1210 2018-12-05  Don Olmstead  <don.olmstead@sony.com>
1211
1212         [PlayStation] Enable WebCore
1213         https://bugs.webkit.org/show_bug.cgi?id=192384
1214
1215         Reviewed by Brent Fulgham.
1216
1217         Implements PAL for the PlayStation platform.
1218
1219         * pal/PlatformPlayStation.cmake: Added.
1220
1221 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1222
1223         Add a runtime feature flag for LayoutFormattingContext.
1224         https://bugs.webkit.org/show_bug.cgi?id=192280
1225
1226         Reviewed by Simon Fraser.
1227
1228         * Configurations/FeatureDefines.xcconfig:
1229
1230 2018-12-01  Alexey Proskuryakov  <ap@apple.com>
1231
1232         Modernize version check for _suppressedAutoAddedHTTPHeaders
1233         https://bugs.webkit.org/show_bug.cgi?id=192175
1234
1235         Reviewed by Tim Horton.
1236
1237         * pal/spi/cf/CFNetworkSPI.h: Curiously, it was forward declared twice, for no
1238         apparent reason.
1239
1240 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1241
1242         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1243         https://bugs.webkit.org/show_bug.cgi?id=192197
1244
1245         Reviewed by Jiewen Tan.
1246
1247         * Configurations/FeatureDefines.xcconfig:
1248         * pal/PlatformGTK.cmake:
1249         * pal/PlatformWPE.cmake:
1250
1251 2018-11-30  Alexey Proskuryakov  <ap@apple.com>
1252
1253         Move USE_CFNETWORK_IGNORE_HSTS to its proper place
1254         https://bugs.webkit.org/show_bug.cgi?id=192173
1255
1256         Reviewed by Tim Horton.
1257
1258         * pal/spi/cf/CFNetworkSPI.h:
1259
1260 2018-11-29  David Quesada  <david_quesada@apple.com>
1261
1262         Add SPI to publish NSProgress on active downloads
1263         https://bugs.webkit.org/show_bug.cgi?id=192021
1264         rdar://problem/44405661
1265
1266         Reviewed by Alex Christensen.
1267
1268         Add an SPI header for NSProgress's publishing and unpublishing methods. In older
1269         SDKs, these methods are explicitly unavailable on platforms other than macOS,
1270         with underscore-prefixed versions available as SPI. In newer SDKs, the unprefixed
1271         versions are SPI and the prefixed versions are deprecated.
1272
1273         * PAL.xcodeproj/project.pbxproj:
1274         * pal/spi/cocoa/NSProgressSPI.h:
1275
1276 2018-11-29  Megan Gardner  <megan_gardner@apple.com>
1277
1278         Move Lookup Code for better cross platform usage
1279         https://bugs.webkit.org/show_bug.cgi?id=191732
1280
1281         Reviewed by Alex Christensen.
1282
1283         * pal/spi/mac/LookupSPI.h:
1284         * pal/spi/mac/RevealSPI.h:
1285
1286 2018-11-29  Eric Carlson  <eric.carlson@apple.com>
1287
1288         [iOS] Tell AirPlay picker when a file has video
1289         https://bugs.webkit.org/show_bug.cgi?id=192155
1290
1291         Reviewed by Jer Noble.
1292
1293         * pal/spi/ios/MediaPlayerSPI.h:
1294
1295 2018-11-29  Alexey Proskuryakov  <ap@apple.com>
1296
1297         Modernize the check for kCFURLRequestContentDecoderSkipURLCheck existence
1298         https://bugs.webkit.org/show_bug.cgi?id=192041
1299
1300         Reviewed by Tim Horton.
1301
1302         * pal/spi/cf/CFNetworkSPI.h:
1303
1304 2018-11-29  Ryan Haddad  <ryanhaddad@apple.com>
1305
1306         Unreviewed, rolling out r238678.
1307
1308         Breaks internal builds.
1309
1310         Reverted changeset:
1311
1312         "Move Lookup Code for better cross platform usage"
1313         https://bugs.webkit.org/show_bug.cgi?id=191732
1314         https://trac.webkit.org/changeset/238678
1315
1316 2018-11-29  Megan Gardner  <megan_gardner@apple.com>
1317
1318         Move Lookup Code for better cross platform usage
1319         https://bugs.webkit.org/show_bug.cgi?id=191732
1320
1321         Reviewed by Alex Christensen.
1322
1323         * pal/spi/mac/LookupSPI.h:
1324         * pal/spi/mac/RevealSPI.h:
1325
1326 2018-11-28  Commit Queue  <commit-queue@webkit.org>
1327
1328         Unreviewed, rolling out r238653 and r238656.
1329         https://bugs.webkit.org/show_bug.cgi?id=192130
1330
1331         Breaks iOS build (Requested by smfr on #webkit).
1332
1333         Reverted changesets:
1334
1335         "Move Lookup Code for better cross platform usage"
1336         https://bugs.webkit.org/show_bug.cgi?id=191732
1337         https://trac.webkit.org/changeset/238653
1338
1339         "Attempt to fix the iOS build by only including RevealSPI.h
1340         when it's needed."
1341         https://trac.webkit.org/changeset/238656
1342
1343 2018-11-15  Megan Gardner  <megan_gardner@apple.com>
1344
1345         Move Lookup Code for better cross platform usage
1346         https://bugs.webkit.org/show_bug.cgi?id=191732
1347
1348         Reviewed by Alex Christensen.
1349
1350         * pal/spi/mac/LookupSPI.h:
1351         * pal/spi/mac/RevealSPI.h:
1352
1353 2018-11-28  Alexey Proskuryakov  <ap@apple.com>
1354
1355         Modernize version checks for same site cookie support
1356         https://bugs.webkit.org/show_bug.cgi?id=192054
1357
1358         Reviewed by Tim Horton.
1359
1360         * pal/spi/cf/CFNetworkSPI.h:
1361
1362 2018-11-27  Mark Lam  <mark.lam@apple.com>
1363
1364         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1365         https://bugs.webkit.org/show_bug.cgi?id=192055
1366         <rdar://problem/46288783>
1367
1368         Reviewed by Saam Barati.
1369
1370         * Configurations/FeatureDefines.xcconfig:
1371
1372 2018-11-27  Alexey Proskuryakov  <ap@apple.com>
1373
1374         Modernize the check for async _saveCookies existence
1375         https://bugs.webkit.org/show_bug.cgi?id=191987
1376
1377         Reviewed by Dean Jackson.
1378
1379         * pal/spi/cf/CFNetworkSPI.h: Also removed a check around _socketStreamProperties,
1380         which exists everywhere.
1381
1382 2018-11-27  Jer Noble  <jer.noble@apple.com>
1383
1384         Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
1385         https://bugs.webkit.org/show_bug.cgi?id=190951
1386         <rdar://problem/45213065>
1387
1388         Further follow-up build fix; add ASSUME_NONNULL macros to SPI declaration.
1389
1390         * pal/spi/cocoa/AVKitSPI.h:
1391
1392 2018-11-27  Jer Noble  <jer.noble@apple.com>
1393
1394         Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
1395         https://bugs.webkit.org/show_bug.cgi?id=190951
1396         <rdar://problem/45213065>
1397
1398         Follow-up build fix when building against older SDKs.
1399
1400         * pal/spi/cocoa/AVKitSPI.h:
1401
1402 2018-11-26  Jer Noble  <jer.noble@apple.com>
1403
1404         Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
1405         https://bugs.webkit.org/show_bug.cgi?id=190951
1406         <rdar://problem/45213065>
1407
1408         Reviewed by Alex Christensen.
1409
1410         * pal/spi/cocoa/AVKitSPI.h:
1411
1412 2018-11-26  Andy Estes  <aestes@apple.com>
1413
1414         [Cocoa] Make it easier to encode NSObjects
1415         https://bugs.webkit.org/show_bug.cgi?id=191948
1416
1417         Reviewed by Dean Jackson.
1418
1419         * pal/spi/cocoa/PassKitSPI.h: Declared some classes that secretly conform to NSSecureCoding.
1420
1421 2018-11-24  Andy Estes  <aestes@apple.com>
1422
1423         [Cocoa] SOFT_LINK_CLASS_FOR_{HEADER,SOURCE} should generate a more concise getter function
1424         https://bugs.webkit.org/show_bug.cgi?id=191899
1425
1426         Reviewed by Dean Jackson.
1427
1428         * pal/cocoa/PassKitSoftLink.h:
1429         * pal/ios/UIKitSoftLink.h:
1430
1431 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1432
1433         Enable drag and drop support for iOSMac
1434         https://bugs.webkit.org/show_bug.cgi?id=191818
1435         <rdar://problem/43907454>
1436
1437         Reviewed by Dean Jackson.
1438
1439         * Configurations/FeatureDefines.xcconfig:
1440
1441 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1442
1443         [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
1444         https://bugs.webkit.org/show_bug.cgi?id=191786
1445         <rdar://problem/45813871>
1446
1447         Reviewed by Ryosuke Niwa.
1448
1449         Add `-replaceMatches:withString:inSelectionOnly:resultCollector:`.
1450
1451         * pal/spi/mac/NSTextFinderSPI.h:
1452
1453 2018-11-21  Andy Estes  <aestes@apple.com>
1454
1455         [Cocoa] Create a soft-linking file for PassKit
1456         https://bugs.webkit.org/show_bug.cgi?id=191875
1457         <rdar://problem/46203215>
1458
1459         Reviewed by Myles Maxfield.
1460
1461         * PAL.xcodeproj/project.pbxproj:
1462         * pal/PlatformMac.cmake:
1463         * pal/cocoa/PassKitSoftLink.h: Added.
1464         * pal/cocoa/PassKitSoftLink.mm: Added. Used _WITH_EXPORT soft-linking macros in order to
1465         make the PAL soft-linking symbols visible to WebKit.
1466         * pal/spi/cocoa/PassKitSPI.h:
1467
1468 2018-11-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
1471         https://bugs.webkit.org/show_bug.cgi?id=191819
1472
1473         Reviewed by Dan Bernstein.
1474
1475         Replace UIItemProvider (and related classes) with NSItemProvider.
1476
1477         * pal/spi/ios/UIKitSPI.h:
1478
1479 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1480
1481         [Win] Reduce the use of WKSI library calls: CFNetwork
1482         https://bugs.webkit.org/show_bug.cgi?id=191718
1483         <rdar://problem/46108732>
1484
1485         Reviewed by Alex Christensen.
1486
1487         Add necessary declarations for CFNetwork SPI needed by the Apple Windows build.
1488
1489         * pal/PlatformAppleWin.cmake:
1490         * pal/spi/cf/CFNetworkSPI.h:
1491         * pal/spi/cf/CFNetworkSPIWin.cpp: Added.
1492
1493 2018-11-16  Chris Dumez  <cdumez@apple.com>
1494
1495         [Mac] Regression: WebContent process's display name is no longer set
1496         https://bugs.webkit.org/show_bug.cgi?id=191722
1497         <rdar://problem/45960550>
1498
1499         Reviewed by Per Arne Vollan.
1500
1501         * pal/spi/cocoa/LaunchServicesSPI.h:
1502
1503 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1504
1505         Additional Windows build fix after r238253.
1506
1507         * pal/spi/cg/CoreGraphicsSPI.h:
1508
1509 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1510
1511         Unreviewed build fix after removing some WKSI calls on Windows.
1512
1513         * pal/spi/cg/CoreGraphicsSPI.h:
1514
1515 2018-11-11  Daniel Bates  <dabates@apple.com>
1516
1517         [iOS] Draw caps lock indicator in password fields
1518         https://bugs.webkit.org/show_bug.cgi?id=190565
1519         <rdar://problem/45262343>
1520
1521         Reviewed by Dean Jackson.
1522
1523         Forward declare some more SPI.
1524
1525         * pal/spi/ios/GraphicsServicesSPI.h:
1526         * pal/spi/ios/UIKitSPI.h:
1527
1528 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1529
1530         Unreviewed, rolling out r238047.
1531
1532         Introduced layout test failures on iOS simulator.
1533
1534         Reverted changeset:
1535
1536         "[iOS] Draw caps lock indicator in password fields"
1537         https://bugs.webkit.org/show_bug.cgi?id=190565
1538         https://trac.webkit.org/changeset/238047
1539
1540 2018-11-09  Daniel Bates  <dabates@apple.com>
1541
1542         [iOS] Draw caps lock indicator in password fields
1543         https://bugs.webkit.org/show_bug.cgi?id=190565
1544         <rdar://problem/45262343>
1545
1546         Reviewed by Dean Jackson.
1547
1548         Forward declare some more SPI.
1549
1550         * pal/spi/ios/GraphicsServicesSPI.h:
1551         * pal/spi/ios/UIKitSPI.h:
1552
1553 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1554
1555         Adopt Reveal Framework to replace Lookup
1556         https://bugs.webkit.org/show_bug.cgi?id=191097
1557         <rdar://problem/45924508>
1558
1559         Reviewed by Tim Horton.
1560
1561         Add in reveal SPI so WebKit will continue to build without the internal SDK.
1562
1563         * PAL.xcodeproj/project.pbxproj:
1564         * pal/spi/mac/RevealSPI.h: Added.
1565
1566 2018-11-06  Justin Fan  <justin_fan@apple.com>
1567
1568         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1569         https://bugs.webkit.org/show_bug.cgi?id=191291
1570
1571         Reviewed by Myles Maxfield.
1572
1573         Properly disable WEBGPU on all non-Metal platforms for now.
1574
1575         * Configurations/FeatureDefines.xcconfig:
1576
1577 2018-11-02  Daniel Bates  <dabates@apple.com>
1578
1579         [iOS] Normalize character string based on key code
1580         https://bugs.webkit.org/show_bug.cgi?id=191120
1581
1582         Reviewed by Tim Horton.
1583
1584         Remove forward declarations that are no longer needed now that we check key code.
1585
1586         * pal/spi/ios/UIKitSPI.h:
1587
1588 2018-11-01  Said Abou-Hallawa  <sabouhallawa@apple.com>
1589
1590         [CG] Adopt CG SPI for non-even cornered rounded rects
1591         https://bugs.webkit.org/show_bug.cgi?id=190155
1592
1593         Reviewed by Simon Fraser.
1594
1595         * pal/spi/cg/CoreGraphicsSPI.h:
1596
1597 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1598
1599         Clean up some obsolete MAX_ALLOWED macros
1600         https://bugs.webkit.org/show_bug.cgi?id=190916
1601
1602         Reviewed by Tim Horton.
1603
1604         * pal/cf/CoreMediaSoftLink.cpp:
1605         * pal/cf/CoreMediaSoftLink.h:
1606         Behavior change here. The check didn't really make sense, pretty sure we would
1607         just crash when hitting this code path on iOS.
1608
1609         * pal/spi/cf/CFNetworkSPI.h:
1610         * pal/spi/cocoa/PassKitSPI.h:
1611         * pal/spi/mac/AVFoundationSPI.h:
1612
1613 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1614
1615         Modernize WebKit nibs and lprojs for localization's sake
1616         https://bugs.webkit.org/show_bug.cgi?id=190911
1617         <rdar://problem/45349466>
1618
1619         Reviewed by Dan Bernstein.
1620
1621         * PAL.xcodeproj/project.pbxproj:
1622         English->en
1623
1624 2018-10-26  Commit Queue  <commit-queue@webkit.org>
1625
1626         Unreviewed, rolling out r237458.
1627         https://bugs.webkit.org/show_bug.cgi?id=190973
1628
1629         broke internal iOS builds (Requested by zalan on #webkit).
1630
1631         Reverted changeset:
1632
1633         "Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI"
1634         https://bugs.webkit.org/show_bug.cgi?id=190951
1635         https://trac.webkit.org/changeset/237458
1636
1637 2018-10-26  Timothy Hatcher  <timothy@apple.com>
1638
1639         Use dark appearance scrollbar when page background is dark or document supports dark mode.
1640         https://bugs.webkit.org/show_bug.cgi?id=190937
1641         rdar://problem/41225839
1642
1643         Reviewed by Beth Dakin.
1644
1645         * pal/spi/mac/NSScrollerImpSPI.h: Added effectiveAppearanceForScrollerImp:.
1646
1647 2018-10-26  Jer Noble  <jer.noble@apple.com>
1648
1649         Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
1650         https://bugs.webkit.org/show_bug.cgi?id=190951
1651         <rdar://problem/45213065>
1652
1653         Reviewed by Alex Christensen.
1654
1655         * pal/spi/cocoa/AVKitSPI.h:
1656
1657 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1658
1659         Clean up some obsolete macOS version guards
1660         https://bugs.webkit.org/show_bug.cgi?id=190887
1661
1662         Reviewed by Dan Bernstein.
1663
1664         * pal/spi/mac/TUCallSPI.h:
1665
1666 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1667
1668         Turn on Conic Gradients
1669         https://bugs.webkit.org/show_bug.cgi?id=190810
1670
1671         Reviewed by Tim Horton.
1672
1673         * Configurations/FeatureDefines.xcconfig:
1674
1675 2018-10-23  Ryan Haddad  <ryanhaddad@apple.com>
1676
1677         Unreviewed, rolling out r237280.
1678
1679         Causes fast/box-shadow/box-shadow-with-zero-radius.html to
1680         fail on iOS Simulator.
1681
1682         Reverted changeset:
1683
1684         "[CG] Adopt CG SPI for non-even cornered rounded rects"
1685         https://bugs.webkit.org/show_bug.cgi?id=190155
1686         https://trac.webkit.org/changeset/237280
1687
1688 2018-10-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
1689
1690         [CG] Adopt CG SPI for non-even cornered rounded rects
1691         https://bugs.webkit.org/show_bug.cgi?id=190155
1692
1693         Reviewed by Simon Fraser.
1694
1695         * pal/spi/cg/CoreGraphicsSPI.h:
1696
1697 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1698
1699         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1700         https://bugs.webkit.org/show_bug.cgi?id=190729
1701
1702         Reviewed by Tim Horton.
1703
1704         * pal/cf/CoreMediaSoftLink.cpp:
1705         * pal/cf/CoreMediaSoftLink.h:
1706         * pal/ios/UIKitSoftLink.h:
1707         * pal/ios/UIKitSoftLink.mm:
1708         * pal/spi/cf/CFNetworkSPI.h:
1709         * pal/spi/cocoa/AVKitSPI.h:
1710         * pal/spi/cocoa/CFNSURLConnectionSPI.h:
1711         * pal/spi/cocoa/CoreTextSPI.h:
1712         * pal/spi/cocoa/DataDetectorsCoreSPI.h:
1713         * pal/spi/cocoa/IOSurfaceSPI.h:
1714         * pal/spi/cocoa/LaunchServicesSPI.h:
1715         * pal/spi/cocoa/NEFilterSourceSPI.h:
1716         * pal/spi/cocoa/NSAttributedStringSPI.h:
1717         * pal/spi/cocoa/NSKeyedArchiverSPI.h:
1718         * pal/spi/cocoa/PassKitSPI.h:
1719         * pal/spi/cocoa/QuartzCoreSPI.h:
1720         * pal/spi/ios/DataDetectorsUISPI.h:
1721         * pal/spi/ios/GraphicsServicesSPI.h:
1722         * pal/spi/ios/MediaPlayerSPI.h:
1723         * pal/spi/ios/MobileGestaltSPI.h:
1724         * pal/spi/mac/AVFoundationSPI.h:
1725         * pal/system/mac/ClockCM.mm:
1726         (ClockCM::ClockCM):
1727
1728 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1729
1730         Enable the datalist element by default on iOS and macOS
1731         https://bugs.webkit.org/show_bug.cgi?id=190594
1732         <rdar://problem/45281159>
1733
1734         Reviewed by Ryosuke Niwa and Tim Horton.
1735
1736         * Configurations/FeatureDefines.xcconfig:
1737
1738 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1739
1740         Unreviewed, rolling out r237163.
1741
1742         Introduced layout test failures on iOS Simulator.
1743
1744         Reverted changeset:
1745
1746         "[CG] Adopt CG SPI for non-even cornered rounded rects"
1747         https://bugs.webkit.org/show_bug.cgi?id=190155
1748         https://trac.webkit.org/changeset/237163
1749
1750 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1751
1752         Implement feature flag and bindings for CSS Painting API
1753         https://bugs.webkit.org/show_bug.cgi?id=190237
1754
1755         Reviewed by Ryosuke Niwa.
1756
1757         * Configurations/FeatureDefines.xcconfig:
1758
1759 2018-10-15  Justin Fan  <justin_fan@apple.com>
1760
1761         Add WebGPU 2018 feature flag and experimental feature flag
1762         https://bugs.webkit.org/show_bug.cgi?id=190509
1763
1764         Reviewed by Dean Jackson.
1765
1766         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1767         for the 2018 WebGPU prototype.
1768
1769         * Configurations/FeatureDefines.xcconfig:
1770
1771 2018-10-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
1772
1773         [CG] Adopt CG SPI for non-even cornered rounded rects
1774         https://bugs.webkit.org/show_bug.cgi?id=190155
1775
1776         Reviewed by Simon Fraser.
1777
1778         * pal/spi/cg/CoreGraphicsSPI.h:
1779
1780 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1781
1782         Add support for prefers-color-scheme media query
1783         https://bugs.webkit.org/show_bug.cgi?id=190499
1784         rdar://problem/45212025
1785
1786         Reviewed by Dean Jackson.
1787
1788         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1789
1790 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1791
1792         [JSC] Remove Option::useAsyncIterator
1793         https://bugs.webkit.org/show_bug.cgi?id=190567
1794
1795         Reviewed by Saam Barati.
1796
1797         * Configurations/FeatureDefines.xcconfig:
1798
1799 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1800
1801         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
1802         https://bugs.webkit.org/show_bug.cgi?id=190342
1803         <rdar://problem/44767118>
1804
1805         Reviewed by Tim Horton.
1806
1807         * pal/ios/UIKitSoftLink.h:
1808         * pal/ios/UIKitSoftLink.mm:
1809
1810         Add NSParagraphStyle and NSTextList to the UIKit soft link header.
1811
1812         * pal/spi/cocoa/NSAttributedStringSPI.h:
1813         * pal/spi/ios/UIKitSPI.h:
1814
1815         Add some SPI declarations for NSMutableParagraphStyle and NSTextList when building with a non-internal iOS SDK,
1816         and import <UIKit/NSParagraphStyle_Private.h> and <UIKit/NSTextList.h> when building with an internal iOS SDK.
1817         Additionally, define some internal UIFoundation string constants that denote NSTextList marker formats. These
1818         constants are API on macOS, but are neither exposed as API nor SPI on iOS.
1819
1820 2018-10-08  Justin Fan  <justin_fan@apple.com>
1821
1822         WebGPU: Rename old WebGPU prototype to WebMetal
1823         https://bugs.webkit.org/show_bug.cgi?id=190325
1824         <rdar://problem/44990443>
1825
1826         Reviewed by Dean Jackson.
1827
1828         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1829
1830         * Configurations/FeatureDefines.xcconfig:
1831
1832 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1833
1834         Make <input type=color> a runtime enabled (on-by-default) feature
1835         https://bugs.webkit.org/show_bug.cgi?id=189162
1836
1837         Reviewed by Wenson Hsieh and Tim Horton.
1838
1839         * Configurations/FeatureDefines.xcconfig:
1840
1841 2018-10-05  Jer Noble  <jer.noble@apple.com>
1842
1843         Unreviewed build fix: internal builds can't find AVVideoPerformanceMetrics.
1844
1845         * pal/spi/mac/AVFoundationSPI.h:
1846
1847 2018-10-03  Jer Noble  <jer.noble@apple.com>
1848
1849         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
1850         https://bugs.webkit.org/show_bug.cgi?id=190266
1851
1852         Reviewed by Eric Carlson.
1853
1854         * pal/spi/mac/AVFoundationSPI.h:
1855
1856 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
1857
1858         Unreviewed, rolling out r236866.
1859
1860         Breaks internal builds.
1861
1862         Reverted changeset:
1863
1864         "Add support for reporting "display composited video frames"
1865         through the VideoPlaybackQuality object."
1866         https://bugs.webkit.org/show_bug.cgi?id=190266
1867         https://trac.webkit.org/changeset/236866
1868
1869 2018-10-04  Jer Noble  <jer.noble@apple.com>
1870
1871         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
1872         https://bugs.webkit.org/show_bug.cgi?id=190266
1873
1874         Reviewed by Eric Carlson.
1875
1876         * pal/spi/mac/AVFoundationSPI.h:
1877
1878 2018-10-04  Dan Bernstein  <mitz@apple.com>
1879
1880         PAL change for the WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1881         https://bugs.webkit.org/show_bug.cgi?id=190250
1882
1883         Reviewed by Andy Estes.
1884
1885         * pal/spi/mac/NSWindowSPI.h: Added a private API declaration.
1886
1887 2018-10-04  Dan Bernstein  <mitz@apple.com>
1888
1889         PAL part of [Xcode] Update some build settings as recommended by Xcode 10
1890         https://bugs.webkit.org/show_bug.cgi?id=190250
1891
1892         Reviewed by Andy Estes.
1893
1894         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1895           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS.
1896
1897         * PAL.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
1898
1899 2018-10-01  Dean Jackson  <dino@apple.com>
1900
1901         Remove CSS Animation Triggers
1902         https://bugs.webkit.org/show_bug.cgi?id=190175
1903         <rdar://problem/44925626>
1904
1905         Reviewed by Simon Fraser.
1906
1907         * Configurations/FeatureDefines.xcconfig:
1908
1909 2018-10-01  Andy Estes  <aestes@apple.com>
1910
1911         [watchOS] Adopt NSURLSessionCompanionProxyPreference
1912         https://bugs.webkit.org/show_bug.cgi?id=190177
1913         <rdar://problem/43402114>
1914
1915         Reviewed by Wenson Hsieh.
1916
1917         * pal/spi/cf/CFNetworkSPI.h:
1918
1919 2018-10-01  Daniel Bates  <dabates@apple.com>
1920
1921         [iOS] Special keys are misidentified in DOM keyboard events
1922         https://bugs.webkit.org/show_bug.cgi?id=189974
1923
1924         Reviewed by Wenson Hsieh.
1925
1926         Forward declare or define more SPI.
1927
1928         * pal/spi/cocoa/IOKitSPI.h:
1929         * pal/spi/ios/UIKitSPI.h:
1930
1931 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
1932
1933         [WebAuthN] Make AuthenticatorManager
1934         https://bugs.webkit.org/show_bug.cgi?id=189279
1935         <rdar://problem/44116792>
1936
1937         Reviewed by Chris Dumez.
1938
1939         It moves linking to DeviceIdentity.framework to WebKit.
1940
1941         * PAL.xcodeproj/project.pbxproj:
1942
1943 2018-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1944
1945         [iOS] Fix the open source iOS 12 build after r236445
1946         https://bugs.webkit.org/show_bug.cgi?id=189953
1947
1948         Reviewed by Alex Christensen.
1949
1950         Introduce a single UIKit soft-linking header in PAL.
1951
1952         * PAL.xcodeproj/project.pbxproj:
1953         * pal/ios/UIKitSoftLink.h: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm.
1954         * pal/ios/UIKitSoftLink.mm: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm.
1955
1956 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1957
1958         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1959         https://bugs.webkit.org/show_bug.cgi?id=189918
1960         Work towards <rdar://problem/44648705>
1961
1962         Reviewed by Tim Horton.
1963
1964         Add `+_disambiguated_due_to_CIImage_colorWithCGColor:` as a UIColor SPI definition. Also, import
1965         `UIColor_Private.h` directly when the Apple internal SDK is used.
1966
1967         * pal/spi/ios/UIKitSPI.h:
1968
1969 2018-09-21  Jer Noble  <jer.noble@apple.com>
1970
1971         Unreviewed Sierra Build Fix; ensure AVVideoPerformanceMetrics are defined on Sierra.
1972
1973         * pal/spi/mac/AVFoundationSPI.h:
1974
1975 2018-09-21  Jer Noble  <jer.noble@apple.com>
1976
1977         Move AVVideoPerformanceMetrics into AVFoundationSPI.h
1978         https://bugs.webkit.org/show_bug.cgi?id=189842
1979
1980         Reviewed by Jon Lee.
1981
1982         * pal/spi/mac/AVFoundationSPI.h:
1983
1984 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
1985
1986         Bring up queues for iOS 12 (Build fix)
1987         https://bugs.webkit.org/show_bug.cgi?id=189683
1988
1989         Unreviewed build fix.
1990
1991         * pal/spi/cocoa/QuartzCoreSPI.h: Declare setCornerRadius and continuousCorner.
1992
1993 2018-09-20  Daniel Bates  <dabates@apple.com>
1994
1995         Move IOKitSPI.h from TestRunnerShared to PAL
1996         https://bugs.webkit.org/show_bug.cgi?id=189804
1997
1998         Reviewed by Wenson Hsieh.
1999
2000         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
2001         declarations to PAL so that they can be shared by both WebKit, DumpRenderTree, and WebKitTestRunner.
2002
2003         No functionality changed. So, no new tests.
2004
2005         * PAL.xcodeproj/project.pbxproj:
2006         * pal/spi/cocoa/IOKitSPI.h: Renamed from Tools/TestRunnerShared/spi/IOKitSPI.h.
2007
2008 2018-09-14  Eric Carlson  <eric.carlson@apple.com>
2009
2010         Support arbitrary video resolution in getUserMedia API
2011         https://bugs.webkit.org/show_bug.cgi?id=178109
2012         <rdar://problem/35083128>
2013
2014         Reviewed by Youenn Fablet.
2015
2016         * pal/cf/CoreMediaSoftLink.cpp:
2017         * pal/cf/CoreMediaSoftLink.h:
2018
2019 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2020
2021         Add IGNORE_WARNING_.* macros
2022         https://bugs.webkit.org/show_bug.cgi?id=188996
2023
2024         Reviewed by Michael Catanzaro.
2025
2026         * pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
2027         (PAL::CryptoDigest::create):
2028         (PAL::CryptoDigest::addBytes):
2029         (PAL::CryptoDigest::computeHash):
2030         * pal/spi/cocoa/AVKitSPI.h:
2031         * pal/spi/cocoa/NSKeyedArchiverSPI.h:
2032         (insecurelyUnarchiveObjectFromData):
2033         * pal/spi/ios/MediaPlayerSPI.h:
2034         * pal/system/mac/PopupMenu.mm:
2035         (PAL::popUpMenu):
2036         * pal/system/mac/WebPanel.mm:
2037         (-[WebPanel init]):
2038
2039 2018-09-10  James Savage  <james.savage@apple.com>
2040
2041         Expose -apple-system-container-border color to internal web views.
2042         https://bugs.webkit.org/show_bug.cgi?id=189178.
2043
2044         Reviewed by Timothy Hatcher.
2045
2046         * pal/spi/cocoa/NSColorSPI.h: Declare SPI.
2047
2048 2018-09-06  Megan Gardner  <megan_gardner@apple.com>
2049
2050         Add Support for Conic Gradients
2051         https://bugs.webkit.org/show_bug.cgi?id=189329
2052         <rdar://problem/21444701>
2053
2054         Reviewed by Simon Fraser.
2055
2056         Define the CG functionality for conic gradients. 
2057
2058         * pal/spi/cg/CoreGraphicsSPI.h:
2059
2060 2018-09-04  Ryan Haddad  <ryanhaddad@apple.com>
2061
2062         Unreviewed, attempt to fix an internal build after r235585.
2063
2064         * pal/spi/cf/CFNetworkSPI.h:
2065
2066 2018-09-01  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
2067
2068         [WinCairo] Add CryptoDigestOpenSSL
2069         https://bugs.webkit.org/show_bug.cgi?id=188978
2070
2071         Reviewed by Darin Adler.
2072
2073         Add a CryptoDigest implementation with OpenSSL/LibreSSL and let the
2074         WinCairo port use it.
2075
2076         * pal/PlatformAppleWin.cmake: Add CryptoDigestWin.cpp to PAL_SOURCES
2077         * pal/PlatformWin.cmake: Remove CryptoDigestWin.cpp from PAL_SOURCES
2078         * pal/PlatformWinCairo.cmake: Add CryptoDigestOpenSSL to PAL_SOURCES
2079         * pal/crypto/openssl/CryptoDigestOpenSSL.cpp: Added.
2080         (PAL::toSHA1Context):
2081         (PAL::toSHA224Context):
2082         (PAL::toSHA256Context):
2083         (PAL::toSHA384Context):
2084         (PAL::toSHA512Context):
2085         (PAL::CryptoDigest::CryptoDigest):
2086         (PAL::CryptoDigest::~CryptoDigest):
2087         (PAL::CryptoDigest::create):
2088         (PAL::CryptoDigest::addBytes):
2089         (PAL::CryptoDigest::computeHash):
2090
2091 2018-09-01  Darin Adler  <darin@apple.com>
2092
2093         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2094         https://bugs.webkit.org/show_bug.cgi?id=189072
2095
2096         Reviewed by Dan Bernstein.
2097
2098         * pal/spi/cf/CFNetworkSPI.h: Added a FIXME about USE(CFNETWORK_IGNORE_HSTS).
2099         Sorted Objective-C class interfaces alphabetically instead of having them
2100         relatively randomly ordered in the file. Reduced the platform #if statements
2101         since it's not critical to have these SPIs declared only where they are
2102         present, as long as they are used only when they are present. Moved some
2103         additional declarations into this file.
2104
2105         * pal/spi/cocoa/NSURLDownloadSPI.h: Added more NSURLDownload methods.
2106
2107 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
2108
2109         [CMake] Replace AVFoundationSupport.py using CMake
2110         https://bugs.webkit.org/show_bug.cgi?id=182891
2111
2112         Reviewed by Per Arne Vollan.
2113
2114         Remove AVFoundationSupport.py file and its invocation.
2115
2116         * AVFoundationSupport.py: Removed.
2117         * config.h:
2118         * pal/PlatformWin.cmake:
2119
2120 2018-08-29  Jer Noble  <jer.noble@apple.com>
2121
2122         Muted elements do not have their Now Playing status updated when unmuted.
2123         https://bugs.webkit.org/show_bug.cgi?id=189069
2124
2125         Reviewed by Eric Carlson.
2126
2127         * pal/spi/mac/MediaRemoteSPI.h:
2128
2129 2018-08-27  Keith Rollin  <krollin@apple.com>
2130
2131         Unreviewed build fix -- disable LTO for production builds
2132
2133         * Configurations/Base.xcconfig:
2134
2135 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2136
2137         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2138         https://bugs.webkit.org/show_bug.cgi?id=188931
2139
2140         Reviewed by Wenson Hsieh.
2141
2142         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2143
2144 2018-08-27  Keith Rollin  <krollin@apple.com>
2145
2146         Build system support for LTO
2147         https://bugs.webkit.org/show_bug.cgi?id=187785
2148         <rdar://problem/42353132>
2149
2150         Reviewed by Dan Bernstein.
2151
2152         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2153         LTO.
2154
2155         * Configurations/Base.xcconfig:
2156         * Configurations/DebugRelease.xcconfig:
2157
2158 2018-08-26  Andy Estes  <aestes@apple.com>
2159
2160         [Apple Pay] Introduce new values for -apple-pay-button-type
2161         https://bugs.webkit.org/show_bug.cgi?id=188949
2162         <rdar://problem/39992228>
2163
2164         Reviewed by Anders Carlsson.
2165
2166         * pal/spi/cocoa/PassKitSPI.h:
2167
2168 2018-08-23  Andy Estes  <aestes@apple.com>
2169
2170         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2171         https://bugs.webkit.org/show_bug.cgi?id=188829
2172
2173         Reviewed by Tim Horton.
2174
2175         * Configurations/FeatureDefines.xcconfig:
2176
2177 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2178
2179         Unreviewed macOS Mojave build fix after r235125.
2180
2181         * pal/spi/cg/CoreGraphicsSPI.h:
2182
2183 2018-08-15  Ansh Shukla  <ansh_shukla@apple.com>
2184
2185         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
2186         https://bugs.webkit.org/show_bug.cgi?id=186870
2187         <rdar://problem/41314410>
2188
2189         Reviewed by Alex Christensen.
2190
2191         * pal/spi/cf/CFNetworkSPI.h: Declare OAuth string when not building against the
2192         internal SDK.
2193
2194 2018-08-15  Aditya Keerthi  <akeerthi@apple.com>
2195
2196         [Datalist] Add button to TextFieldInputs with a datalist
2197         https://bugs.webkit.org/show_bug.cgi?id=187741
2198
2199         Reviewed by Tim Horton.
2200
2201         * pal/spi/cocoa/NSColorSPI.h: Added NSColorGetUserAccentColor().
2202
2203 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
2204
2205         Unreviewed, rolling out r234870.
2206
2207         The test introduced with this change is a flaky failure.
2208
2209         Reverted changeset:
2210
2211         "NSURLAuthenticationMethodOAuth challenges are surfaced to
2212         clients in -didReceiveAuthenticationChallenge as
2213         NSURLAuthenticationMethodDefault"
2214         https://bugs.webkit.org/show_bug.cgi?id=186870
2215         https://trac.webkit.org/changeset/234870
2216
2217 2018-08-14  Ansh Shukla  <ansh_shukla@apple.com>
2218
2219         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
2220         https://bugs.webkit.org/show_bug.cgi?id=186870
2221         <rdar://problem/41314410>
2222
2223         Reviewed by Alex Christensen.
2224
2225         * pal/spi/cf/CFNetworkSPI.h: Declare OAuth string when not building against the
2226         internal SDK.
2227
2228 2018-08-07  Ryan Haddad  <ryanhaddad@apple.com>
2229
2230         Unreviewed, suppress warnings to fix the build.
2231
2232         * pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
2233         (PAL::CryptoDigest::create):
2234         (PAL::CryptoDigest::addBytes):
2235         (PAL::CryptoDigest::computeHash):
2236
2237 2018-08-07  Per Arne Vollan  <pvollan@apple.com>
2238
2239         [macOS] Scrollbars are not visible when using 3rd party mouse
2240         https://bugs.webkit.org/show_bug.cgi?id=188372
2241
2242         Reviewed by Simon Fraser.
2243
2244         Added declaration of NSScrollerImpPair class method. This method updates all NSScrollerImpPairs
2245         with a new recommended scroller style.
2246
2247         * pal/spi/mac/NSScrollerImpSPI.h:
2248
2249 2018-08-02  David Fenton  <david_fenton@apple.com>
2250
2251         Unreviewed, rolling out r234489.
2252
2253         Caused 50+ crashes and 60+ API failures on iOS
2254
2255         Reverted changeset:
2256
2257         "[WTF] Rename String::format to String::deprecatedFormat"
2258         https://bugs.webkit.org/show_bug.cgi?id=188191
2259         https://trac.webkit.org/changeset/234489
2260
2261 2018-08-01  Tomas Popela  <tpopela@redhat.com>
2262
2263         [WTF] Rename String::format to String::deprecatedFormat
2264         https://bugs.webkit.org/show_bug.cgi?id=188191
2265
2266         Reviewed by Darin Adler.
2267
2268         It should be replaced with string concatenation.
2269
2270         * pal/FileSizeFormatter.cpp:
2271         (fileSizeDescription):
2272
2273 2018-08-01  Tim Horton  <timothy_horton@apple.com>
2274
2275         Using the keyboard arrow keys to scroll a webpage is very slow, not smooth, takes too long
2276         https://bugs.webkit.org/show_bug.cgi?id=188239
2277         <rdar://problem/22997654>
2278
2279         Reviewed by Simon Fraser.
2280
2281         * pal/spi/cocoa/QuartzCoreSPI.h:
2282         Add a piece of SPI.
2283
2284 2018-07-30  Sihui Liu  <sihui_liu@apple.com>
2285
2286         Add support for fetching and remove type  _WKWebsiteDataTypeHSTSCache
2287         https://bugs.webkit.org/show_bug.cgi?id=187379
2288         <rdar://problem/41879559>
2289
2290         Reviewed by Geoffrey Garen.
2291
2292         * pal/spi/cf/CFNetworkSPI.h:
2293
2294 2018-07-30  Devin Rousso  <webkit@devinrousso.com>
2295
2296         Add missing CoreGraphics SPI
2297         https://bugs.webkit.org/show_bug.cgi?id=188177
2298
2299         Reviewed by Joseph Pecoraro.
2300
2301         * pal/spi/cg/CoreGraphicsSPI.h:
2302
2303 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2304
2305         [INTL] Remove INTL sub-feature compile flags
2306         https://bugs.webkit.org/show_bug.cgi?id=188081
2307
2308         Reviewed by Michael Catanzaro.
2309
2310         * Configurations/FeatureDefines.xcconfig:
2311
2312 2018-07-26  Ryan Haddad  <ryanhaddad@apple.com>
2313
2314         Unreviewed, rolling out r234281.
2315
2316         Broke internal builds.
2317
2318         Reverted changeset:
2319
2320         "[Datalist] Add button to TextFieldInputs with a datalist"
2321         https://bugs.webkit.org/show_bug.cgi?id=187741
2322         https://trac.webkit.org/changeset/234281
2323
2324 2018-07-26  Aditya Keerthi  <akeerthi@apple.com>
2325
2326         [Datalist] Add button to TextFieldInputs with a datalist
2327         https://bugs.webkit.org/show_bug.cgi?id=187741
2328
2329         Reviewed by Tim Horton.
2330
2331         * pal/spi/cocoa/NSColorSPI.h: Added NSColorGetUserAccentColor().
2332
2333 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2334
2335         Unreviewed, rolling out r234181 and r234189.
2336         https://bugs.webkit.org/show_bug.cgi?id=188075
2337
2338         These are not needed right now (Requested by thorton on
2339         #webkit).
2340
2341         Reverted changesets:
2342
2343         "Enable Web Content Filtering on watchOS"
2344         https://bugs.webkit.org/show_bug.cgi?id=187979
2345         https://trac.webkit.org/changeset/234181
2346
2347         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2348         https://bugs.webkit.org/show_bug.cgi?id=187985
2349         https://trac.webkit.org/changeset/234189
2350
2351 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2352
2353         Enable Web Content Filtering on watchOS
2354         https://bugs.webkit.org/show_bug.cgi?id=187979
2355         <rdar://problem/42559346>
2356
2357         Reviewed by Wenson Hsieh.
2358
2359         * Configurations/FeatureDefines.xcconfig:
2360
2361 2018-07-24  Aditya Keerthi  <akeerthi@apple.com>
2362
2363         [Datalist][macOS] Display suggestions for input[type=color]
2364         https://bugs.webkit.org/show_bug.cgi?id=187794
2365
2366         Reviewed by Tim Horton.
2367
2368         Added methods to enable customization of NSPopoverColorWell.
2369
2370         * PAL.xcodeproj/project.pbxproj:
2371         * pal/spi/mac/NSColorWellSPI.h: Added.
2372         * pal/spi/mac/NSPopoverColorWellSPI.h: Added.
2373         * pal/spi/mac/NSPopoverSPI.h:
2374
2375 2018-07-23  Tim Horton  <timothy_horton@apple.com>
2376
2377         Creating and loading content in a WKWebView triggers Main Thread Checker warnings under ServicesController
2378         https://bugs.webkit.org/show_bug.cgi?id=186963
2379         <rdar://problem/41393682>
2380
2381         Reviewed by Timothy Hatcher.
2382
2383         * pal/spi/mac/NSSharingServiceSPI.h:
2384         Add the new SPI.
2385
2386 2018-07-18  Per Arne Vollan  <pvollan@apple.com>
2387
2388         The WebContent process does not suspend when MiniBrowser is minimized.
2389         https://bugs.webkit.org/show_bug.cgi?id=187708
2390
2391         Reviewed by Chris Dumez.
2392
2393         Add function for enabling App nap.
2394
2395         * pal/spi/cf/CFUtilitiesSPI.h:
2396
2397 2018-07-18  Jer Noble  <jer.noble@apple.com>
2398
2399         PiP from Element Fullscreen should match AVKit's behavior
2400         https://bugs.webkit.org/show_bug.cgi?id=187623
2401
2402         Reviewed by Jon Lee.
2403
2404         * pal/spi/mac/PIPSPI.h:
2405
2406 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2407
2408         Ensure WebKit stack is ad-hoc signed
2409         https://bugs.webkit.org/show_bug.cgi?id=187667
2410
2411         Reviewed by Alexey Proskuryakov.
2412
2413         * Configurations/Base.xcconfig:
2414
2415 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2416
2417         Introduce PLATFORM(IOSMAC)
2418         https://bugs.webkit.org/show_bug.cgi?id=187315
2419
2420         Reviewed by Dan Bernstein.
2421
2422         * Configurations/Base.xcconfig:
2423         * Configurations/FeatureDefines.xcconfig:
2424         * pal/cf/CoreMediaSoftLink.cpp:
2425         * pal/cf/CoreMediaSoftLink.h:
2426         * pal/spi/mac/AVFoundationSPI.h:
2427
2428 2018-06-28  Jonathan Bedard  <jbedard@apple.com>
2429
2430         Build fix (2) after r233266 
2431         https://bugs.webkit.org/show_bug.cgi?id=187024
2432         <rdar://problem/39759057>
2433
2434         Unreviewed build fix.
2435
2436         * pal/cf/CoreMediaSoftLink.cpp: Distinguish between IOS and MINIMAL_SIMULATOR.
2437         * pal/cf/CoreMediaSoftLink.h: Ditto.
2438         * pal/spi/cocoa/LaunchServicesSPI.h: LSApplicationProxy should be conditionalized on HAVE(APP_LINKS).
2439
2440 2018-06-27  Jonathan Bedard  <jbedard@apple.com>
2441
2442         Build fix after r233266 
2443         https://bugs.webkit.org/show_bug.cgi?id=187024
2444         <rdar://problem/39759057>
2445
2446         Unreviewed build fix.
2447
2448         * pal/cf/CoreMediaSoftLink.cpp: Do not soft-link CMSampleBufferCallForEachSample for
2449         iOS 12 and up on iPhone device and simulator.
2450         * pal/cf/CoreMediaSoftLink.h: Ditto.
2451
2452 2018-06-27  Jonathan Bedard  <jbedard@apple.com>
2453
2454         Enable WebKit iOS 12 build
2455         https://bugs.webkit.org/show_bug.cgi?id=187024
2456         <rdar://problem/39759057>
2457
2458         Reviewed by David Kilzer.
2459
2460         * pal/cf/CoreMediaSoftLink.cpp: Condition some CoreMedia functions on version.
2461         * pal/cf/CoreMediaSoftLink.h: Ditto.
2462         * pal/spi/cocoa/NSXPCConnectionSPI.h: Use XPCSPI.h instead of xpc.h.
2463         * pal/spi/ios/QuickLookSPI.h: QLItem adopts QLPreviewItem.
2464         * pal/spi/ios/SystemPreviewSPI.h: Fix compiler errors.
2465
2466 2018-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2467
2468         [iPad apps on macOS] Unable to interact with video elements that have started playing
2469         https://bugs.webkit.org/show_bug.cgi?id=187073
2470         <rdar://problem/40591107>
2471
2472         Reviewed by Tim Horton.
2473
2474         Define an SPI method on CALayer. See WebKit ChangeLog for more detail.
2475
2476         * pal/spi/cocoa/QuartzCoreSPI.h:
2477
2478 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2479
2480         [WTF] Add user-defined literal for ASCIILiteral
2481         https://bugs.webkit.org/show_bug.cgi?id=186839
2482
2483         Reviewed by Darin Adler.
2484
2485         * pal/unix/LoggingUnix.cpp:
2486         (PAL::logLevelString):
2487
2488 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2489
2490         Corner of two scroll bars is white with dark mode enabled.
2491         https://bugs.webkit.org/show_bug.cgi?id=186819
2492         rdar://problem/40434350
2493
2494         Reviewed by Tim Horton.
2495
2496         * PAL.xcodeproj/project.pbxproj:
2497         * pal/spi/mac/CoreUISPI.h: Added.
2498         * pal/spi/mac/NSAppearanceSPI.h: Added.
2499
2500 2018-06-21  Ryan Haddad  <ryanhaddad@apple.com>
2501
2502         Unreviewed attempt to fix the build after r233052.
2503
2504         * pal/spi/cocoa/AVKitSPI.h:
2505
2506 2018-06-21  Jer Noble  <jer.noble@apple.com>
2507
2508         [Fullscreen] Use secondary glyph style for fullscreen controls
2509         https://bugs.webkit.org/show_bug.cgi?id=186862
2510         <rdar://problem/41212210>
2511
2512         Reviewed by Tim Horton.
2513
2514         * pal/spi/cocoa/AVKitSPI.h:
2515
2516 2018-06-15  Jonathan Bedard  <jbedard@apple.com>
2517
2518         Complex text handling should opt out of bounded text layout (follow-up fix)
2519         https://bugs.webkit.org/show_bug.cgi?id=186571
2520         <rdar://problem/40801429>
2521
2522         Reviewed by Zalan Bujtas.
2523
2524         * pal/spi/cocoa/CoreTextSPI.h: Add declaration for OpenSource Mojave builds.
2525
2526 2018-06-14  Timothy Hatcher  <timothy@apple.com>
2527
2528         Expose more semantic system colors.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=186609
2531         rdar://problem/39287277
2532
2533         Reviewed by Tim Horton.
2534
2535         * pal/spi/cocoa/NSColorSPI.h: Added findHighlightColor and placeholderTextColor.
2536
2537 2018-06-09  Dan Bernstein  <mitz@apple.com>
2538
2539         [Xcode] Clean up and modernize some build setting definitions
2540         https://bugs.webkit.org/show_bug.cgi?id=186463
2541
2542         Reviewed by Sam Weinig.
2543
2544         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
2545         * Configurations/DebugRelease.xcconfig: Ditto.
2546         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
2547           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
2548         * Configurations/PAL.xcconfig: Removed WK_PRIVATE_FRAMEWORKS_DIR, because the private
2549           framework stubs aren’t used when linking PAL.
2550         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
2551         * Configurations/WebKitTargetConditionals.xcconfig: Ditto.
2552
2553 2018-06-09  Dan Bernstein  <mitz@apple.com>
2554
2555         Added missing file references to the Configuration group.
2556
2557         * PAL.xcodeproj/project.pbxproj:
2558
2559 2018-06-08  Darin Adler  <darin@apple.com>
2560
2561         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
2562         https://bugs.webkit.org/show_bug.cgi?id=186436
2563
2564         Reviewed by Anders Carlsson.
2565
2566         * PAL.xcodeproj/project.pbxproj: Removed FoundationSPI.h.
2567         * pal/PlatformMac.cmake: Ditto.
2568         * pal/spi/cocoa/FoundationSPI.h: Moved into WTF project.
2569
2570 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2571
2572         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2573         https://bugs.webkit.org/show_bug.cgi?id=186442
2574         <rdar://problem/40879364>
2575
2576         Reviewed by Tim Horton.
2577
2578         * Configurations/FeatureDefines.xcconfig:
2579
2580 2018-06-08  Darin Adler  <darin@apple.com>
2581
2582         [Cocoa] Make more of our soft linking ARC-compatible
2583         https://bugs.webkit.org/show_bug.cgi?id=186437
2584
2585         Reviewed by Daniel Bates.
2586
2587         * pal/spi/cocoa/DataDetectorsCoreSPI.h: Removed unused DDURLScheme.
2588
2589 2018-06-08  Jonathan Bedard  <jbedard@apple.com>
2590
2591         [Mojave] Enable build
2592         https://bugs.webkit.org/show_bug.cgi?id=186401
2593         <rdar://problem/39759031>
2594
2595         Reviewed by Dan Bernstein.
2596
2597         * pal/spi/cg/CoreGraphicsSPI.h: Declare CGSShutdownServerConnections().
2598         * pal/spi/cocoa/QuartzCoreSPI.h: Declare [CAContext setAllowsCGSConnections] in Mojave + builds.
2599         * pal/spi/mac/DataDetectorsSPI.h: Declare DDResultGetCFTypeID in Mojave+ builds.
2600
2601 2018-06-08  Brent Fulgham  <bfulgham@apple.com>
2602
2603         REGRESSION (r230930): Link drag image is very blurry
2604         https://bugs.webkit.org/show_bug.cgi?id=186435
2605         <rdar://problem/40797202>
2606
2607         Reviewed by Tim Horton.
2608
2609         Add the necessary NSImage SPI to our SPI headers.
2610
2611         * PAL.xcodeproj/project.pbxproj:
2612         * pal/spi/mac/NSImageSPI.h: Added.
2613
2614 2018-06-07  Chris Dumez  <cdumez@apple.com>
2615
2616         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2617         https://bugs.webkit.org/show_bug.cgi?id=186407
2618
2619         Reviewed by Brent Fulgham.
2620
2621         186407_CanMakeWeakPtr
2622
2623         * pal/system/mac/SystemSleepListenerMac.h:
2624         * pal/system/mac/SystemSleepListenerMac.mm:
2625         (PAL::SystemSleepListenerMac::SystemSleepListenerMac):
2626
2627 2018-06-06  Simon Fraser  <simon.fraser@apple.com>
2628
2629         Logging macros are sensitive to pal/Logging.h vs Logging.h include order
2630         https://bugs.webkit.org/show_bug.cgi?id=185893
2631
2632         Reviewed by Zalan Bujtas.
2633         
2634         Remove unused functionality from pal/Logging code until we need it. Primarily this removes the
2635         #define LOG_CHANNEL_PREFIX from pal/Logging.h, which caused include-order problems with unified sources.
2636         
2637         Future work should move shared logging code up to WTF (or into PAL).
2638
2639         * PAL.xcodeproj/project.pbxproj:
2640         * pal/CMakeLists.txt:
2641         * pal/LogInitialization.h: Removed.
2642         * pal/Logging.cpp:
2643         (PAL::isLogChannelEnabled): Deleted.
2644         (PAL::setLogChannelToAccumulate): Deleted.
2645         (PAL::initializeLogChannelsIfNecessary): Deleted.
2646         * pal/Logging.h:
2647         * pal/cocoa/LoggingCocoa.mm: Removed.
2648
2649 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2650
2651         Adjust compile and runtime flags to match shippable state of features
2652         https://bugs.webkit.org/show_bug.cgi?id=186319
2653         <rdar://problem/40352045>
2654
2655         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2656
2657         * Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
2658         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2659         Cocoa builds.
2660         * Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2661         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2662
2663 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2664
2665         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2666         https://bugs.webkit.org/show_bug.cgi?id=186286
2667         <rdar://problem/40782992>
2668
2669         Reviewed by Dan Bernstein.
2670
2671         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2672         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
2673         change this flag when preparing for a production release.
2674
2675         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
2676         whether experimental features should be enabled, and use it to properly define the
2677         feature flag.
2678
2679 2018-06-04  Dan Bernstein  <mitz@apple.com>
2680
2681         Made PAL build with the macOS Mojave SDK.
2682
2683         * pal/cf/CoreMediaSoftLink.cpp:
2684         * pal/cf/CoreMediaSoftLink.h:
2685
2686 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2687
2688         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
2689         https://bugs.webkit.org/show_bug.cgi?id=186279
2690
2691         Reviewed by Tim Horton.
2692
2693         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
2694
2695         * pal/cf/CoreMediaSoftLink.h:
2696         * pal/spi/cocoa/AVKitSPI.h:
2697
2698 2018-05-30  Andy Estes  <aestes@apple.com>
2699
2700         [Cocoa] Add an SPI to suppress connection termination errors from CFNetwork when network interfaces change
2701         https://bugs.webkit.org/show_bug.cgi?id=186107
2702         <rdar://problem/39338957>
2703
2704         Reviewed by Brady Eidson.
2705
2706         * pal/spi/cf/CFNetworkSPI.h: Declared new SPI.
2707
2708 2018-05-27  Dan Bernstein  <mitz@apple.com>
2709
2710         Reverted the changes made for https://webkit.org/b/186016
2711
2712         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2713
2714 2018-05-25  Chris Dumez  <cdumez@apple.com>
2715
2716         Drop support for NSURLCache in WebKit2
2717         https://bugs.webkit.org/show_bug.cgi?id=185990
2718
2719         Reviewed by Geoffrey Garen.
2720
2721         Drop support for NSURLCache in WebKit2 now that the WebKit network cache is stable.
2722
2723         * pal/spi/cf/CFNetworkSPI.h:
2724
2725 2018-05-24  Jiewen Tan  <jiewen_tan@apple.com>
2726
2727         Adopt SecKeyProxy SPI in certificate based challenge response code
2728         https://bugs.webkit.org/show_bug.cgi?id=185848
2729         <rdar://problem/34586181>
2730
2731         Reviewed by Alex Christensen.
2732
2733         Add SPIs to support SecKeyProxy and convert xpc_endpoint_t to NSXPCListenerEndpoint vice versa.
2734
2735         * PAL.xcodeproj/project.pbxproj:
2736         * pal/spi/cocoa/NSXPCConnectionSPI.h: Added.
2737         * pal/spi/cocoa/SecKeyProxySPI.h: Added.
2738
2739 2018-05-24  Chris Dumez  <cdumez@apple.com>
2740
2741         Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds
2742         https://bugs.webkit.org/show_bug.cgi?id=185951
2743
2744         Reviewed by Geoffrey Garen.
2745
2746         Some of the work in initializeLogChannelsIfNecessary() is unnecessary for release builds and slows down
2747         launch time. In particular, it is unnecessary to read NSDefaults to figure out which logging channels
2748         should be enabled.
2749
2750         * pal/cocoa/LoggingCocoa.mm:
2751         (PAL::logLevelString):
2752         * pal/unix/LoggingUnix.cpp:
2753         (PAL::logLevelString):
2754         * pal/win/LoggingWin.cpp:
2755         (PAL::logLevelString):
2756
2757 2018-05-22  Simon Fraser  <simon.fraser@apple.com>
2758
2759         Add notifyutil callbacks to dump the memory cache, and the list of live Pages and Documents
2760         https://bugs.webkit.org/show_bug.cgi?id=185853
2761
2762         Reviewed by Keith Miller.
2763         
2764         Compile registerNotifyCallback in release builds.
2765
2766         * pal/Logging.cpp:
2767         (PAL::registerNotifyCallback):
2768         * pal/Logging.h:
2769
2770 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2771
2772         Unreviewed, rolling out r232052.
2773
2774         Breaks internal builds.
2775
2776         Reverted changeset:
2777
2778         "Use more C++17"
2779         https://bugs.webkit.org/show_bug.cgi?id=185176
2780         https://trac.webkit.org/changeset/232052
2781
2782 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2783
2784         Use more C++17
2785         https://bugs.webkit.org/show_bug.cgi?id=185176
2786
2787         Reviewed by JF Bastien.
2788
2789         * Configurations/Base.xcconfig:
2790
2791 2018-05-21  Jer Noble  <jer.noble@apple.com>
2792
2793         Complete fix for enabling modern EME by default
2794         https://bugs.webkit.org/show_bug.cgi?id=185770
2795         <rdar://problem/40368220>
2796
2797         Reviewed by Eric Carlson.
2798
2799         * Configurations/FeatureDefines.xcconfig:
2800
2801 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2802
2803         Unreviewed, rolling out r231982.
2804         https://bugs.webkit.org/show_bug.cgi?id=185793
2805
2806         Caused layout test failures (Requested by realdawei on
2807         #webkit).
2808
2809         Reverted changeset:
2810
2811         "Complete fix for enabling modern EME by default"
2812         https://bugs.webkit.org/show_bug.cgi?id=185770
2813         https://trac.webkit.org/changeset/231982
2814
2815 2018-05-18  Jer Noble  <jer.noble@apple.com>
2816
2817         Complete fix for enabling modern EME by default
2818         https://bugs.webkit.org/show_bug.cgi?id=185770
2819         <rdar://problem/40368220>
2820
2821         Reviewed by Eric Carlson.
2822
2823         * Configurations/FeatureDefines.xcconfig:
2824
2825 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2826
2827         Add support for Intl NumberFormat formatToParts
2828         https://bugs.webkit.org/show_bug.cgi?id=185375
2829
2830         Reviewed by Yusuke Suzuki.
2831
2832         Add flag for NumberFormat formatToParts.
2833
2834         * Configurations/FeatureDefines.xcconfig:
2835
2836 2018-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2837
2838         PasteboardWebContent's dataInAttributedStringFormat fails to deserialize in the UI process when copying a selection
2839         https://bugs.webkit.org/show_bug.cgi?id=185667
2840         <rdar://problem/40135132>
2841
2842         Reviewed by Tim Horton.
2843
2844         Fixes error logging emitted when copying a text selection due to the secure archiver on iOS being unable to
2845         handle NSAttributedString in the builds where the errors manifest. USE_SECURE_ARCHIVER_FOR_ATTRIBUTED_STRING is
2846         defined to be 1, despite not having the fix for <rdar://problem/31376830>.
2847
2848         * pal/spi/cocoa/NSKeyedArchiverSPI.h:
2849
2850 2018-05-11  Dan Bernstein  <mitz@apple.com>
2851
2852         Follow-up build fix to r231721.
2853
2854         * pal/cf/CoreMediaSoftLink.cpp:
2855         * pal/cf/CoreMediaSoftLink.h:
2856           Unify the conditions between the header and the implementation files, and have watchOS and
2857           tvOS keyed off iOS.
2858
2859 2018-05-11  Jer Noble  <jer.noble@apple.com>
2860
2861         Add CF_NOESCAPE decorators for tvOS and watchOS
2862         https://bugs.webkit.org/show_bug.cgi?id=185560
2863
2864         Reviewed by Dan Bernstein.
2865
2866         * pal/cf/CoreMediaSoftLink.h:
2867
2868 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
2869
2870         Adopt new async _savecookies SPI for keeping networking process active during flushing cookies
2871         https://bugs.webkit.org/show_bug.cgi?id=185261
2872         <rdar://problem/37214391>
2873
2874         Reviewed by Chris Dumez.
2875
2876         * pal/spi/cf/CFNetworkSPI.h:
2877
2878 2018-05-08  Dean Jackson  <dino@apple.com>
2879
2880         Use thumbnails in System Previews
2881         https://bugs.webkit.org/show_bug.cgi?id=185397
2882         <rdar://problem/40039376>
2883
2884         Reviewed by Jon Lee.
2885
2886         * PAL.xcodeproj/project.pbxproj:
2887         * pal/spi/ios/SystemPreviewSPI.h: New file holding the non-public parts of System Preview.
2888
2889 2018-05-04  Tim Horton  <timothy_horton@apple.com>
2890
2891         Shift to a lower-level framework for simplifying URLs
2892         https://bugs.webkit.org/show_bug.cgi?id=185334
2893
2894         Reviewed by Dan Bernstein.
2895
2896         * PAL.xcodeproj/project.pbxproj:
2897         * pal/PlatformMac.cmake:
2898         * pal/spi/cocoa/URLFormattingSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/LinkPresentationSPI.h.
2899
2900 2018-05-03  Eric Carlson  <eric.carlson@apple.com>
2901
2902         [iOS] Provide audio route information when invoking AirPlay picker
2903         https://bugs.webkit.org/show_bug.cgi?id=185199
2904         <rdar://problem/39853103>
2905
2906         Another attempt at an unreviewed build fix.
2907
2908         * pal/spi/mac/AVFoundationSPI.h:
2909
2910 2018-05-02  Eric Carlson  <eric.carlson@apple.com>
2911
2912         [iOS] Provide audio route information when invoking AirPlay picker
2913         https://bugs.webkit.org/show_bug.cgi?id=185199
2914         <rdar://problem/39853103>
2915
2916         Unreviewed, another attempted build fix.
2917
2918         * pal/spi/mac/AVFoundationSPI.h:
2919
2920 2018-05-02  Alex Christensen  <achristensen@webkit.org>
2921
2922         Add WKWebsiteDataStorePrivate._proxyConfiguration SPI
2923         https://bugs.webkit.org/show_bug.cgi?id=185179
2924
2925         Reviewed by Andy Estes.
2926
2927         * pal/spi/cf/CFNetworkSPI.h:
2928
2929 2018-05-02  Eric Carlson  <eric.carlson@apple.com>
2930
2931         [iOS] Provide audio route information when invoking AirPlay picker
2932         https://bugs.webkit.org/show_bug.cgi?id=185199
2933         <rdar://problem/39853103>
2934
2935         Unreviewed build fix.
2936
2937         * pal/spi/mac/AVFoundationSPI.h:
2938
2939 2018-05-02  Eric Carlson  <eric.carlson@apple.com>
2940
2941         [iOS] Provide audio route information when invoking AirPlay picker
2942         https://bugs.webkit.org/show_bug.cgi?id=185199
2943         <rdar://problem/39853103>
2944
2945         Reviewed by Jer Noble.
2946
2947         * pal/spi/mac/AVFoundationSPI.h: Add additional AVAudioSession SPI.
2948
2949 2018-05-01  Jer Noble  <jer.noble@apple.com>
2950
2951         Protect against changes to CoreMedia function signatures
2952         https://bugs.webkit.org/show_bug.cgi?id=185167
2953
2954         Reviewed by Eric Carlson.
2955
2956         * pal/cf/CoreMediaSoftLink.cpp:
2957         * pal/cf/CoreMediaSoftLink.h:
2958
2959 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2960
2961         WebAssembly: add support for stream APIs - JavaScript API
2962         https://bugs.webkit.org/show_bug.cgi?id=183442
2963
2964         Reviewed by Yusuke Suzuki and JF Bastien.
2965
2966         Add WEBASSEMBLY_STREAMING_API feature flag
2967
2968         * Configurations/FeatureDefines.xcconfig:
2969
2970 2018-04-26  Jer Noble  <jer.noble@apple.com>
2971
2972         WK_COCOA_TOUCH all the things.
2973         https://bugs.webkit.org/show_bug.cgi?id=185006
2974
2975         Reviewed by Tim Horton.
2976
2977         * Configurations/PAL.xcconfig:
2978
2979 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2980
2981         Disable content filtering in minimal simulator mode
2982         https://bugs.webkit.org/show_bug.cgi?id=185027
2983         <rdar://problem/39736091>
2984
2985         Reviewed by Jer Noble.
2986
2987         * Configurations/FeatureDefines.xcconfig:
2988
2989 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2990
2991         [INTL] Implement Intl.PluralRules
2992         https://bugs.webkit.org/show_bug.cgi?id=184312
2993
2994         Reviewed by JF Bastien.
2995
2996         Added Intl.PluralRules feature flag.
2997
2998         * Configurations/FeatureDefines.xcconfig:
2999
3000 2018-04-24  Jer Noble  <jer.noble@apple.com>
3001
3002         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
3003         https://bugs.webkit.org/show_bug.cgi?id=184786
3004
3005         Reviewed by Tim Horton.
3006
3007         * Configurations/PAL.xcconfig:
3008
3009 2018-04-23  Daniel Bates  <dabates@apple.com>
3010
3011         Implement Same-Site cookies
3012         https://bugs.webkit.org/show_bug.cgi?id=159464
3013         <rdar://problem/27196358>
3014
3015         Reviewed by Brent Fulgham.
3016
3017         Forward declare some SPI.
3018
3019         * pal/spi/cf/CFNetworkSPI.h:
3020
3021 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3022
3023         [LayoutFormattingContext] Initial commit.
3024         https://bugs.webkit.org/show_bug.cgi?id=184896
3025
3026         Reviewed by Antti Koivisto.
3027
3028         * Configurations/FeatureDefines.xcconfig:
3029
3030 2018-04-23  Daniel Bates  <dabates@apple.com>
3031
3032         Implement Same-Site cookies
3033         https://bugs.webkit.org/show_bug.cgi?id=159464
3034         <rdar://problem/27196358>
3035
3036         Reviewed by Brent Fulgham.
3037
3038         Forward declare some SPI.
3039
3040         * pal/spi/cf/CFNetworkSPI.h:
3041
3042 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3043
3044         Adjust geolocation feature flag
3045         https://bugs.webkit.org/show_bug.cgi?id=184856
3046
3047         Reviewed by Wenson Hsieh.
3048
3049         * Configurations/FeatureDefines.xcconfig:
3050
3051 2018-04-18  Jer Noble  <jer.noble@apple.com>
3052
3053         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
3054         https://bugs.webkit.org/show_bug.cgi?id=184762
3055
3056         Reviewed by Dan Bernstein.
3057
3058         * Configurations/CopyPALHeaders.xcconfig:
3059         * Configurations/PAL.xcconfig:
3060
3061 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3062
3063         Enable Objective-C weak references
3064         <https://webkit.org/b/184789>
3065         <rdar://problem/39571716>
3066
3067         Reviewed by Dan Bernstein.
3068
3069         * Configurations/Base.xcconfig:
3070         (CLANG_ENABLE_OBJC_WEAK): Enable.
3071
3072 2018-04-17  Eric Carlson  <eric.carlson@apple.com>
3073
3074         [iOS] AirPlay device name is sometimes wrong
3075         https://bugs.webkit.org/show_bug.cgi?id=184543
3076         <rdar://problem/39105498>
3077
3078         Reviewed by Jer Noble.
3079
3080         * pal/spi/mac/AVFoundationSPI.h: Declare more AVOutputContext SPI.
3081
3082 2018-04-16  Brent Fulgham  <bfulgham@apple.com>
3083
3084         [macOS] Don't establish unneeded Dock connections
3085         https://bugs.webkit.org/show_bug.cgi?id=184664
3086         <rdar://problem/16863698>
3087
3088         Reviewed by Simon Fraser.
3089
3090         There is no reason for the WebContent or Plugin processes to interact with
3091         the Dock. We should tell AppKit that we don't want this connection, and to
3092         avoid creating such connections.
3093
3094         * pal/spi/mac/NSApplicationSPI.h: Add Dock connection declaration.
3095
3096 2018-04-09  John Wilander  <wilander@apple.com>
3097
3098         Refactor Ignore HSTS code
3099         https://bugs.webkit.org/show_bug.cgi?id=184433
3100         <rdar://problem/39298238>
3101
3102         Reviewed by Darin Adler.
3103
3104         This patch refactors our ignore HSTS code. The convenience functions are moved
3105         out of CFNetwork SPI in PAL, and into where they are used. It also switches
3106         from performSelector: calls to straight function calls, after checking that
3107         there is a responder.
3108
3109         * pal/spi/cf/CFNetworkSPI.h:
3110         (schemeWasUpgradedDueToDynamicHSTS): Deleted.
3111         (setIgnoreHSTS): Deleted.
3112         (ignoreHSTS): Deleted.
3113
3114 2018-04-07  Timothy Hatcher  <timothy@apple.com>
3115
3116         Use the system's link color when system appearance is desired for a WebView.
3117
3118         https://bugs.webkit.org/show_bug.cgi?id=184353
3119         rdar://problem/9420053
3120
3121         Reviewed by Wenson Hsieh.
3122
3123         * pal/spi/cocoa/NSColorSPI.h: Added linkColor.
3124
3125 2018-04-05  John Wilander  <wilander@apple.com>
3126
3127         Add necessary colon to CFNetwork selector
3128         https://bugs.webkit.org/show_bug.cgi?id=184335
3129         <rdar://problem/39213124>
3130
3131         Reviewed by Brent Fulgham.
3132
3133         * pal/spi/cf/CFNetworkSPI.h:
3134         (setIgnoreHSTS):
3135
3136 2018-04-04  Per Arne Vollan  <pvollan@apple.com>
3137
3138         The layout test fast/canvas/canvas-blending-global-alpha.html is failing when the WebContent process does not have WindowServer access.
3139         https://bugs.webkit.org/show_bug.cgi?id=183752
3140
3141         Reviewed by Brent Fulgham.
3142
3143         * pal/spi/cg/CoreGraphicsSPI.h:
3144
3145 2018-04-02  Eric Carlson  <eric.carlson@apple.com>
3146
3147         Define AVKit softlink macro
3148         https://bugs.webkit.org/show_bug.cgi?id=184241
3149
3150         Reviewed by Jer Noble.
3151
3152         * pal/cf/CoreMediaSoftLink.h:
3153
3154 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3155
3156         Fix the !HAVE(APP_LINKS) build
3157         https://bugs.webkit.org/show_bug.cgi?id=183974
3158
3159         Reviewed by Dan Bernstein.
3160
3161         * pal/spi/cocoa/LaunchServicesSPI.h:
3162         This header is not very !HAVE(APP_LINKS) friendly.
3163
3164 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3165
3166         Fix the build with no pasteboard
3167         https://bugs.webkit.org/show_bug.cgi?id=183973
3168
3169         Reviewed by Dan Bernstein.
3170
3171         * Configurations/FeatureDefines.xcconfig:
3172
3173 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3174
3175         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
3176         https://bugs.webkit.org/show_bug.cgi?id=183930
3177         <rdar://problem/38782249>
3178
3179         Reviewed by Dan Bernstein.
3180
3181         * Configurations/Base.xcconfig:
3182         * Configurations/CopyPALHeaders.xcconfig:
3183         * Configurations/PAL.xcconfig:
3184
3185 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3186
3187         Improve readability of WebCore's OTHER_LDFLAGS
3188         https://bugs.webkit.org/show_bug.cgi?id=183909
3189         <rdar://problem/38760992>
3190
3191         Reviewed by Dan Bernstein.
3192
3193         * Configurations/Base.xcconfig:
3194         * Configurations/FeatureDefines.xcconfig:
3195
3196 2018-03-21  Brent Fulgham  <bfulgham@apple.com>
3197
3198         Remove temporary build fix now that underlying issue is resolved
3199         https://bugs.webkit.org/show_bug.cgi?id=183854
3200         <rdar://problem/37198715>
3201
3202         Reviewed by Eric Carlson.
3203
3204         The build environment issues that forced us to disable this setting
3205         have been corrected, so this should be turned on for all builds.
3206
3207         * pal/spi/cf/CFNetworkSPI.h:
3208
3209 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3210
3211         Enable the minimal simulator feature flag when appropriate
3212         https://bugs.webkit.org/show_bug.cgi?id=183807
3213
3214         Reviewed by Dan Bernstein.
3215
3216         * Configurations/FeatureDefines.xcconfig:
3217
3218 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3219
3220         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3221         https://bugs.webkit.org/show_bug.cgi?id=183758
3222         <rdar://problem/38017644>
3223
3224         Reviewed by Dan Bernstein.
3225
3226         * Configurations/FeatureDefines.xcconfig:
3227
3228 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3229
3230         Unreviewed, another quick fix for r229699
3231
3232         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3233
3234         * Configurations/FeatureDefines.xcconfig:
3235
3236 2018-03-19  Eric Carlson  <eric.carlson@apple.com>
3237
3238         [Extra zoom mode] Require fullscreen for video playback
3239         https://bugs.webkit.org/show_bug.cgi?id=183742
3240         <rdar://problem/38235862>
3241
3242         Reviewed by Jer Noble.
3243
3244         * pal/spi/cocoa/AVKitSPI.h:
3245
3246 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3247
3248         Unreviewed, a quick fix for r229699
3249
3250         * pal/spi/cocoa/DeviceIdentitySPI.h:
3251
3252 2018-03-17  Jiewen Tan  <jiewen_tan@apple.com>
3253
3254         [WebAuthN] Implement authenticatorMakeCredential
3255         https://bugs.webkit.org/show_bug.cgi?id=183527
3256         <rdar://problem/35275886>
3257
3258         Reviewed by Brent Fulgham.
3259
3260         * PAL.xcodeproj/project.pbxproj:
3261         * pal/spi/cocoa/DeviceIdentitySPI.h: Copied from Source/WebKit/UIProcess/CredentialManagement/WebCredentialsMessengerProxy.h.
3262
3263 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3264
3265         Fix the build after r229567
3266
3267         * Configurations/FeatureDefines.xcconfig:
3268
3269 2018-03-13  Dean Jackson  <dino@apple.com>
3270
3271         Fix some build errors and cleanup QuickLookSPI.h
3272         https://bugs.webkit.org/show_bug.cgi?id=183599
3273
3274         Reviewed by Ryan Haddad.
3275
3276         * pal/spi/ios/QuickLookSPI.h:
3277
3278 2018-03-12  Dean Jackson  <dino@apple.com>
3279
3280         Add a WKWebViewContentProvider for system previews
3281         https://bugs.webkit.org/show_bug.cgi?id=183582
3282         <rdar://problem/38393569>
3283
3284         Reviewed by Tim Horton.
3285
3286         Add some QuickLook SPI.
3287
3288         * pal/spi/ios/QuickLookSPI.h:
3289
3290 2018-03-12  Don Olmstead  <don.olmstead@sony.com>
3291
3292         [CMake][Win] Forwarding headers of WTF and PAL are copied twice in Visual Studio builds
3293         https://bugs.webkit.org/show_bug.cgi?id=183240
3294
3295         Reviewed by Alex Christensen.
3296
3297         * pal/CMakeLists.txt:
3298         * pal/PlatformAppleWin.cmake:
3299         * pal/PlatformGTK.cmake:
3300         * pal/PlatformMac.cmake:
3301         * pal/PlatformWPE.cmake:
3302         * pal/PlatformWinCairo.cmake:
3303
3304 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3305
3306         Stop using SDK conditionals to control feature definitions
3307         https://bugs.webkit.org/show_bug.cgi?id=183430
3308         <rdar://problem/38251619>
3309
3310         Reviewed by Dan Bernstein.
3311
3312         * Configurations/FeatureDefines.xcconfig:
3313         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3314
3315 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3316
3317         Runtime flag for link prefetch and remove link subresource.
3318         https://bugs.webkit.org/show_bug.cgi?id=183540
3319
3320         Reviewed by Chris Dumez.
3321
3322         Remove the LINK_PREFETCH build time flag.
3323
3324         * Configurations/FeatureDefines.xcconfig:
3325
3326 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3327
3328         Use a different SPI header for some AudioToolbox enums
3329         https://bugs.webkit.org/show_bug.cgi?id=183574
3330         <rdar://problem/38385889>
3331
3332         Reviewed by Anders Carlsson.
3333
3334         * PAL.xcodeproj/project.pbxproj:
3335         * pal/spi/cocoa/AudioToolboxSPI.h: Added.
3336
3337 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3338
3339         Sort and separate FeatureDefines.xcconfig
3340         https://bugs.webkit.org/show_bug.cgi?id=183427
3341
3342         Reviewed by Dan Bernstein.
3343
3344         * Configurations/FeatureDefines.xcconfig:
3345         Sort and split FeatureDefines into paragraphs
3346         (to make it easier to sort later).
3347
3348 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3349
3350         Fix std::make_unique / new[] using system malloc
3351         https://bugs.webkit.org/show_bug.cgi?id=182975
3352
3353         Reviewed by JF Bastien.
3354
3355         Use Vector instead.
3356
3357         * pal/win/LoggingWin.cpp:
3358         (PAL::logLevelString):
3359
3360 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3361
3362         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3363         https://bugs.webkit.org/show_bug.cgi?id=183312
3364
3365         Reviewed by Mark Lam.
3366
3367         Remove wtf/CurrentTime.h include pragma.
3368
3369         * pal/system/ClockGeneric.cpp:
3370
3371 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3372
3373         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3374         https://bugs.webkit.org/show_bug.cgi?id=183283
3375         <rdar://problem/38062148>
3376
3377         Reviewed by Sam Weinig.
3378
3379         * Configurations/FeatureDefines.xcconfig:
3380
3381 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3382
3383         Remove monotonicallyIncreasingTime
3384         https://bugs.webkit.org/show_bug.cgi?id=182911
3385
3386         Reviewed by Michael Catanzaro.
3387
3388         * pal/system/ClockGeneric.cpp:
3389         (PAL::ClockGeneric::currentTime const):
3390         (PAL::ClockGeneric::now const):
3391         * pal/system/ClockGeneric.h:
3392
3393 2018-02-27  Tim Horton  <timothy_horton@apple.com>
3394
3395         Stop using deprecated CADisplay SPI
3396         https://bugs.webkit.org/show_bug.cgi?id=183150
3397         <rdar://problem/37918297>
3398
3399         Reviewed by Simon Fraser.
3400
3401         * pal/spi/cocoa/QuartzCoreSPI.h:
3402         Switch to the more modern way of getting the display name.
3403
3404 2018-02-27  Ryan Haddad  <ryanhaddad@apple.com>
3405
3406         Unreviewed, rolling out r229055.
3407
3408         Breaks internal builds.
3409
3410         Reverted changeset:
3411
3412         "Stop using deprecated CADisplay SPI"
3413         https://bugs.webkit.org/show_bug.cgi?id=183150
3414         https://trac.webkit.org/changeset/229055
3415
3416 2018-02-27  Tim Horton  <timothy_horton@apple.com>
3417
3418         Stop using deprecated CADisplay SPI
3419         https://bugs.webkit.org/show_bug.cgi?id=183150
3420         <rdar://problem/37918297>
3421
3422         Reviewed by Simon Fraser.
3423
3424         * pal/spi/cocoa/QuartzCoreSPI.h:
3425         Switch to the more modern way of getting the display name.
3426
3427 2018-02-20  Tim Horton  <timothy_horton@apple.com>
3428
3429         Introduce HAVE(IOSURFACE_ACCELERATOR)
3430         https://bugs.webkit.org/show_bug.cgi?id=182955
3431         <rdar://problem/37699510>
3432
3433         Reviewed by Sam Weinig.
3434
3435         * pal/spi/cg/CoreGraphicsSPI.h:
3436         * pal/spi/cocoa/IOSurfaceSPI.h:
3437         * pal/spi/cocoa/QuartzCoreSPI.h:
3438
3439 2018-02-15  Tim Horton  <timothy_horton@apple.com>
3440
3441         Stop using EXCLUDED_SOURCE_FILE_NAMES for actual source files in WebCore
3442         https://bugs.webkit.org/show_bug.cgi?id=182822
3443
3444         Reviewed by Dan Bernstein.
3445
3446         * Configurations/PAL.xcconfig:
3447         * pal/system/Sound.cpp:
3448         * pal/system/mac/SoundMac.mm:
3449         * pal/text/KillRing.cpp:
3450         * pal/text/mac/KillRingMac.mm:
3451
3452 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
3453
3454         [CMake] Make PAL headers copies
3455         https://bugs.webkit.org/show_bug.cgi?id=182645
3456
3457         Reviewed by Alex Christensen.
3458
3459         * pal/CMakeLists.txt:
3460         * pal/PlatformAppleWin.cmake:
3461         * pal/PlatformGTK.cmake:
3462         * pal/PlatformMac.cmake:
3463         * pal/PlatformWPE.cmake:
3464         * pal/PlatformWin.cmake:
3465         * pal/PlatformWinCairo.cmake:
3466
3467 2018-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
3468
3469         A disallowed user-installed font may be used if its PostScript name is specified
3470         https://bugs.webkit.org/show_bug.cgi?id=180951
3471
3472         Reviewed by Brent Fulgham.
3473
3474         * pal/spi/cocoa/CoreTextSPI.h:
3475
3476 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3477
3478         [WebAuthN] Add a compile-time feature flag
3479         https://bugs.webkit.org/show_bug.cgi?id=182211
3480         <rdar://problem/36936365>
3481
3482         Reviewed by Brent Fulgham.
3483
3484         * Configurations/FeatureDefines.xcconfig:
3485
3486 2018-01-27  Dan Bernstein  <mitz@apple.com>
3487
3488         HaveInternalSDK includes should be "#include?"
3489         https://bugs.webkit.org/show_bug.cgi?id=179670
3490
3491         * Configurations/Base.xcconfig:
3492
3493 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3494
3495         Fix Windows build after r227552
3496         https://bugs.webkit.org/show_bug.cgi?id=182026
3497
3498         * pal/spi/cg/CoreGraphicsSPI.h:
3499
3500 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3501
3502         Remove pre-Sierra-OS-specific code in WebCore
3503         https://bugs.webkit.org/show_bug.cgi?id=182026
3504
3505         Reviewed by Tim Horton.
3506
3507         * pal/spi/cf/CFNetworkSPI.h:
3508         * pal/spi/cg/CoreGraphicsSPI.h:
3509         * pal/spi/cocoa/DataDetectorsCoreSPI.h:
3510         * pal/spi/cocoa/QuartzCoreSPI.h:
3511         * pal/spi/mac/AVFoundationSPI.h:
3512         * pal/spi/mac/NSMenuSPI.h:
3513         * pal/spi/mac/NSScrollingMomentumCalculatorSPI.h:
3514         * pal/spi/mac/PIPSPI.h:
3515
3516 2018-01-23  Dean Jackson  <dino@apple.com>
3517
3518         REGRESSION (r222961?): sRGB images shown in WebGL are over-saturated on a wide gamut monitor
3519         https://bugs.webkit.org/show_bug.cgi?id=182033
3520         <rdar://problem/36377780>
3521
3522         Reviewed by Antoine Quint.
3523
3524         Expose an IOSurface colorspace property name, and a function to serialize a CGColorSpace.
3525
3526         * pal/spi/cg/CoreGraphicsSPI.h:
3527         * pal/spi/cocoa/IOSurfaceSPI.h:
3528
3529 2018-01-23  Michael Catanzaro  <mcatanzaro@igalia.com>
3530
3531         [WPE][GTK] Sleep inhibitors do not work under Flatpak
3532         https://bugs.webkit.org/show_bug.cgi?id=180812
3533
3534         Reviewed by Carlos Garcia Campos.
3535
3536         Ensure SleepDisablerGLib works even when running inside a Flatpak sandbox by using the
3537         Freedesktop inhibit portal D-Bus API.
3538
3539         Unfortunately this has to be tested manually.
3540
3541         * pal/system/glib/SleepDisablerGLib.cpp:
3542         (PAL::SleepDisablerGLib::SleepDisablerGLib):
3543         (PAL::SleepDisablerGLib::~SleepDisablerGLib):
3544         (PAL::SleepDisablerGLib::acquireInhibitor):
3545         (PAL::SleepDisablerGLib::acquireInhibitorViaScreenSaverProxy):
3546         (PAL::SleepDisablerGLib::acquireInhibitorViaInhibitPortalProxy):
3547         (PAL::SleepDisablerGLib::releaseInhibitor):
3548         (PAL::SleepDisablerGLib::releaseInhibitorViaScreenSaverProxy):
3549         (PAL::SleepDisablerGLib::releaseInhibitorViaInhibitPortalProxy):
3550
3551 2018-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
3552
3553         [Cocoa] Support font collections
3554         https://bugs.webkit.org/show_bug.cgi?id=181826
3555         <rdar://problem/36455137>
3556
3557         Reviewed by Dean Jackson.
3558
3559         * pal/spi/cocoa/CoreTextSPI.h:
3560
3561 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3562
3563         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3564         https://bugs.webkit.org/show_bug.cgi?id=181918
3565
3566         Reviewed by Tim Horton.
3567
3568         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3569
3570         * Configurations/FeatureDefines.xcconfig:
3571
3572 2018-01-18  Dan Bernstein  <mitz@apple.com>
3573
3574         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3575         https://bugs.webkit.org/show_bug.cgi?id=181803
3576
3577         Reviewed by Tim Horton.
3578
3579         * Configurations/Base.xcconfig: Updated.
3580         * Configurations/DebugRelease.xcconfig: Ditto.
3581         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
3582         * Configurations/Version.xcconfig: Updated.
3583         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
3584           useful for defining settings that depend on the target macOS version.
3585
3586 2018-01-17  John Wilander  <wilander@apple.com>
3587
3588         Resource Load Statistics: Block cookies for prevalent resources without user interaction
3589         https://bugs.webkit.org/show_bug.cgi?id=177394
3590         <rdar://problem/34613960>
3591
3592         Reviewed by Alex Christensen.
3593
3594         * pal/spi/cf/CFNetworkSPI.h:
3595             Declaration of _initWithIdentifier() on NSHTTPCookieStorage.
3596
3597 2018-01-17  Matt Lewis  <jlewis3@apple.com>
3598
3599         Unreviewed, rolling out r227098.
3600
3601         This broke the build.
3602
3603         Reverted changeset:
3604
3605         "Remove linked-on test for Snow Leopard"
3606         https://bugs.webkit.org/show_bug.cgi?id=181770
3607         https://trac.webkit.org/changeset/227098
3608
3609 2018-01-17  Dean Jackson  <dino@apple.com>
3610
3611         Remove linked-on test for Snow Leopard
3612         https://bugs.webkit.org/show_bug.cgi?id=181770
3613
3614         Reviewed by Eric Carlson.
3615
3616         No need for _CFExecutableLinkedOnOrAfter any more.
3617
3618         * pal/spi/cf/CFUtilitiesSPI.h:
3619
3620 2018-01-17  Matt Lewis  <jlewis3@apple.com>
3621
3622         Unreviewed, rolling out r227076.
3623
3624         This breaks internal builds
3625
3626         Reverted changeset:
3627
3628         "Resource Load Statistics: Block cookies for prevalent
3629         resources without user interaction"
3630         https://bugs.webkit.org/show_bug.cgi?id=177394
3631         https://trac.webkit.org/changeset/227076
3632
3633 2018-01-17  John Wilander  <wilander@apple.com>
3634
3635         Resource Load Statistics: Block cookies for prevalent resources without user interaction
3636         https://bugs.webkit.org/show_bug.cgi?id=177394
3637         <rdar://problem/34613960>
3638
3639         Reviewed by Alex Christensen.
3640
3641         * pal/spi/cf/CFNetworkSPI.h:
3642             Declaration of _initWithIdentifier() on NSHTTPCookieStorage.
3643
3644 2018-01-16  Michael Catanzaro  <mcatanzaro@igalia.com>
3645
3646         PAL should link to JavaScriptCore rather than WTF
3647         https://bugs.webkit.org/show_bug.cgi?id=181683
3648
3649         Reviewed by Konstantin Tokarev.
3650
3651         Currently we are accidentally linking WTF into both libjavascriptcoregtk and libwebkit2gtk,
3652         which could in theory cause problems similar to bug #179914. There are only two possible
3653         solutions:
3654
3655          - Ensure WTF always built as a shared library if JavaScriptCore is built as a shared
3656            library
3657          - Change PAL to link to JavaScriptCore instead of WTF
3658
3659         The problem here is caused by layer hopping. It can never be a problem if each library only
3660         links to the next lowest-layered library.
3661
3662         The downside is this allows PAL to use JavaScriptCore symbols, which is not super desirable.
3663         I came up with a hack yesterday for PAL to link to WTF usually, but link to JavaScriptCore
3664         instead if ${JavaScriptCore_LIBRARY_TYPE} MATCHES "SHARED" AND ${WTF_LIBRARY_TYPE} MATCHES
3665         "STATIC". But that is getting too complex and introduces more possibility for platform-
3666         dependent build failures. Better to just accept that PAL will depend on JavaScriptCore.
3667
3668         Note: I'm not brave enough to update the XCode build. We can use that to enforce that no
3669         JavaScriptCore symbols actually get used, I guess....
3670
3671         * pal/CMakeLists.txt:
3672
3673 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3674
3675         Improve use of ExportMacros
3676         https://bugs.webkit.org/show_bug.cgi?id=181652
3677
3678         Reviewed by Konstantin Tokarev.
3679
3680         Remove a comment.
3681
3682         * pal/ExportMacros.h: