2011-04-29 Ryosuke Niwa <rniwa@webkit.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-29  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Extract a function to obtain VisiblePosition from RenderText::positionForPoint
6         https://bugs.webkit.org/show_bug.cgi?id=59811
7
8         Extracted lineDirectionPointFitsInBox from positionForPoint.
9
10         * rendering/RenderText.cpp:
11         (WebCore::lineDirectionPointFitsInBox):
12         (WebCore::RenderText::positionForPoint):
13
14 2011-04-29  Geoffrey Garen  <ggaren@apple.com>
15
16         Reviewed by Alexey Proskuryakov.
17
18         REGRESSION: r83938 abandons GC memory
19         https://bugs.webkit.org/show_bug.cgi?id=59604
20
21         This bug was caused by script and image elements waiting indefinitely
22         for their loads to finish.
23
24         * bindings/js/JSNodeCustom.cpp:
25         (WebCore::isReachableFromDOM): Don't test for the load event firing,
26         since the load event doesn't fire in cases of canceled or errored loads.
27         Instead, test hasPendingActivity().
28         
29         Don't do this test at all for script elements because script elements
30         can't load while outside the document. (fast/dom/script-element-gc.html
31         verifies that this is correct.)
32
33         * html/HTMLImageElement.cpp:
34         (WebCore::HTMLImageElement::hasPendingActivity):
35         * html/HTMLImageElement.h:
36         * loader/ImageLoader.cpp:
37         (WebCore::ImageEventSender::hasPendingEvents):
38         (WebCore::ImageLoader::hasPendingLoadEvent):
39         * loader/ImageLoader.h: Added API for finding out if an image element
40         has pending activity.
41
42         * loader/cache/CachedResource.cpp:
43         (WebCore::CachedResource::setRequest): All loads are supposed to end in
44         data(allDataReceived = true) or error(), but in the edge case of a
45         canceled load, all we get is a call to setRequest(0). Be sure to
46         record that we're no longer loading in that case, otherwise our element
47         will leak forever, waiting for its load to complete.
48
49 2011-04-29  Emil Eklund  <eae@chromium.org>
50
51         Reviewed by Tony Chang.
52
53         Setting outerHTML should merge text nodes
54         https://bugs.webkit.org/show_bug.cgi?id=52686
55
56         When setting outerHTML adjacent text nodes should be merged. This matches
57         the behavior of outerText and the IE implementation of outerHTML.       
58
59         Test: fast/dom/set-outer-html.html
60
61         * html/HTMLElement.cpp:
62         (WebCore::mergeWithNextTextNode): Move function to before setOuterHTML.
63         (WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
64
65 2011-04-29  Emil A Eklund  <eae@chromium.org>
66
67         Reviewed by Dimitri Glazkov.
68
69         Onchange on text fields has an incoherent behavior
70         https://bugs.webkit.org/show_bug.cgi?id=57330
71
72         * html/HTMLFormControlElement.cpp:
73         (WebCore::HTMLTextFormControlElement::insertedIntoDocument):
74         Initialize m_textAsOfLastFormControlChangeEvent to empty string rather
75         than null for empty fields.
76
77 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
78
79         [Qt] Unreviewed buildfix after r85343.
80
81         Enable strict OwnPtr for Qt
82         https://bugs.webkit.org/show_bug.cgi?id=59667
83
84         * plugins/mac/PluginViewMac.mm:
85         (WebCore::PluginView::platformStart):
86
87 2011-04-29  Jon Lee  <jonlee@apple.com>
88
89         Reviewed by mitzpettel.
90
91         REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
92         <rdar://problem/9327332>
93         https://bugs.webkit.org/show_bug.cgi?id=59721
94
95         Removing shouldClearSelectionWhenLosingWebPageFocus().  Reverting changelist 83814.
96
97         * WebCore.exp.in:
98         * editing/EditingBehavior.h:
99
100 2011-04-29  Abhishek Arya  <inferno@chromium.org>
101
102         Reviewed by Dave Hyatt.
103
104         Allow only first table caption and destroy the remaining ones.
105         https://bugs.webkit.org/show_bug.cgi?id=58249
106
107         Previously, we were only laying out the first table caption.
108         However Table::layout didn't mark the other ones as not needing
109         layout. So after table layout completes, table is marked as not
110         needing layout with its other table caption still needing layout.
111         This causes incorrect layout root calculations and set it to a
112         node which is already getting deleted.
113
114         Tests: fast/table/dynamic-caption-add-before-child.xhtml
115                fast/table/dynamic-caption-add-remove-before-child.xhtml
116                fast/table/multiple-captions-crash.xhtml
117                fast/table/multiple-captions-crash2.xhtml
118                fast/table/multiple-captions-display.xhtml
119
120         * rendering/RenderTable.cpp:
121         (WebCore::RenderTable::addChild): when new caption or a before
122         child caption is added, we need to explicitly trigger section
123         recalc or otherwise layout won't catch it.
124         (WebCore::RenderTable::removeChild): when child to be removed is
125         m_caption, make sure to trigger style recalc on the table.
126         (WebCore::RenderTable::recalcCaption): code to destroy captions
127         other than the first one.
128         (WebCore::RenderTable::recalcSections): call recalcCaption
129         helper. Store the next sibling early since child can get destroyed
130         in recalcCaption.
131         * rendering/RenderTable.h:
132
133 2011-04-29  David Kilzer  <ddkilzer@apple.com>
134
135         Remove WML
136         https://bugs.webkit.org/show_bug.cgi?id=59678
137
138         * DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
139
140 2011-04-29  James Robinson  <jamesr@chromium.org>
141
142         Unreviewed, rolling out r85330.
143         http://trac.webkit.org/changeset/85330
144         https://bugs.webkit.org/show_bug.cgi?id=41311
145
146         Caused unexpected border rendering change on 500 tests on chromium linux.
147
148         * platform/graphics/skia/GraphicsContextSkia.cpp:
149         (WebCore::GraphicsContext::drawConvexPolygon):
150         (WebCore::GraphicsContext::clipConvexPolygon):
151
152 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
153
154         [Qt] Unreviewed buildfix after r85343.
155
156         Enable strict OwnPtr for Qt
157         https://bugs.webkit.org/show_bug.cgi?id=59667
158
159         * plugins/win/PluginViewWin.cpp:
160         (WebCore::PluginView::wndProc):
161         (WebCore::PluginView::snapshot):
162
163 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
164
165         Reviewed by Adam Barth.
166
167         Enable strict OwnPtr for Qt
168         https://bugs.webkit.org/show_bug.cgi?id=59667
169
170         * platform/graphics/qt/ImageBufferQt.cpp:
171         (WebCore::ImageBufferData::ImageBufferData):
172         (WebCore::ImageBuffer::ImageBuffer):
173         * platform/graphics/qt/ImageDecoderQt.cpp:
174         (WebCore::ImageDecoderQt::setData):
175         * platform/graphics/qt/ImageDecoderQt.h:
176         * platform/network/qt/QNetworkReplyHandler.cpp:
177         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
178         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
179
180 2011-04-29  Dean Jackson  <dino@apple.com>
181
182         Reviewed by Simon Fraser.
183
184         Add ENABLE macro for WebKitAnimation
185         https://bugs.webkit.org/show_bug.cgi?id=59729
186
187         Add new feature to toggle WebKit Animation API.
188
189         * Configurations/FeatureDefines.xcconfig:
190         * GNUmakefile.am:
191         * dom/Element.idl:
192         * features.pri:
193         * page/DOMWindow.idl:
194
195 2011-04-29  Dean Jackson  <dino@apple.com>
196
197         Reviewed by Simon Fraser.
198
199         https://bugs.webkit.org/show_bug.cgi?id=59149
200         (Regression) Existing animations are not replaced when filling.
201
202         Hardware animations that fill forwards were not being correctly
203         replaced when the animation was removed. The actual animation
204         logic was working correctly, but it wasn't deleting the
205         CoreAnimation animation from the PlatformLayer. The fix was
206         to explicitly call endAnimation when disconnecting the animation
207         from its RenderObject.
208
209         Test: animations/3d/replace-filling-transform.html
210
211         * page/animation/AnimationBase.h:
212         (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
213
214 2011-04-29  Abhishek Arya  <inferno@chromium.org>
215
216         Reviewed by Nikolas Zimmermann.
217
218         When svg inline text is getting destroyed, make sure to mark
219         its svg text ancestor as needing a positioning values update.
220         This helps to recalculate layout attributes and makes sure
221         that svg inline text is not used again.
222         https://bugs.webkit.org/show_bug.cgi?id=59161
223
224         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
225
226         * rendering/svg/RenderSVGInlineText.cpp:
227         (WebCore::RenderSVGInlineText::destroy):
228         * rendering/svg/RenderSVGInlineText.h:
229
230 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
231
232         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
233
234         * platform/graphics/wx/GraphicsContextWx.cpp:
235
236 2011-04-29  Mike Reed  <reed@google.com>
237
238         Reviewed by Ojan Vafai.
239
240         Skia: Need to implement GraphicsContext::clipConvexPolygon()
241         https://bugs.webkit.org/show_bug.cgi?id=41311
242
243         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
244         as that shows other issues/question unrelated to clipping.
245         https://bugs.webkit.org/show_bug.cgi?id=41311
246
247         No new tests. covered by existing layout tests
248
249         * platform/graphics/skia/GraphicsContextSkia.cpp:
250         (WebCore::setPathFromConvexPoints):
251         (WebCore::GraphicsContext::drawConvexPolygon):
252         (WebCore::GraphicsContext::clipConvexPolygon):
253
254 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
255
256         Reviewed by Ojan Vafai.
257
258         Fix IR->SR typo in enum value (and resulting style fails)
259         https://bugs.webkit.org/show_bug.cgi?id=59779
260
261         No functionality change, so no new tests
262
263         * css/CSSPrimitiveValueMappings.h:
264         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
265         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
266
267 2011-04-29  Pavel Feldman  <pfeldman@google.com>
268
269         Reviewed by Yury Semikhatsky.
270
271         Web Inspector: CSS editing breaks when entering "color: rgb(1"
272         https://bugs.webkit.org/show_bug.cgi?id=59789
273
274         Tests: inspector/styles/styles-add-invalid-property.html
275                inspector/styles/styles-cancel-editing.html
276                inspector/styles/styles-commit-editing.html
277
278         * inspector/front-end/CSSStyleModel.js:
279         (WebInspector.CSSProperty.prototype.setText.callback):
280         (WebInspector.CSSProperty.prototype.setText):
281         * inspector/front-end/StylesSidebarPane.js:
282         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
283         (WebInspector.StylePropertyTreeElement.prototype):
284         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
285         * inspector/front-end/inspector.js:
286         (WebInspector.startEditing.defaultFinishHandler):
287         (WebInspector.startEditing.keyDownEventListener):
288         (WebInspector.startEditing):
289
290 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
291
292         Reviewed by Simon Hausmann.
293
294         ENABLE(QT_BEARER) -> USE(QT_BEARER)
295
296         * WebCore.pri:
297         * WebCore.pro:
298         * features.pri:
299         * platform/network/NetworkStateNotifier.h:
300         * platform/network/qt/NetworkStateNotifierQt.cpp:
301
302 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
303
304         Reviewed by Simon Hausmann.
305
306         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
307
308         * WebCore.pri:
309         * features.pri:
310
311 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
312
313         Reviewed by Pavel Feldman.
314
315         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
316         https://bugs.webkit.org/show_bug.cgi?id=59476
317
318         * inspector/front-end/DebuggerPresentationModel.js:
319         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
320         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
321         (WebInspector.PresentationBreakpoint.prototype.serialize):
322         * inspector/front-end/ScriptsPanel.js:
323         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
324         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
325         (WebInspector.ScriptsPanel.prototype.reset):
326
327 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
328
329         Reviewed by Yury Semikhatsky.
330
331         Web Inspector: include script end line:column in scriptParsed parameters.
332         https://bugs.webkit.org/show_bug.cgi?id=59717
333
334         * bindings/js/ScriptDebugServer.cpp:
335         (WebCore::ScriptDebugServer::dispatchDidParseSource):
336         * bindings/v8/DebuggerScript.js:
337         ():
338         * bindings/v8/ScriptDebugServer.cpp:
339         (WebCore::ScriptDebugServer::dispatchDidParseSource):
340         * inspector/Inspector.json:
341         * inspector/InspectorDebuggerAgent.cpp:
342         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
343         (WebCore::InspectorDebuggerAgent::didParseSource):
344         * inspector/InspectorDebuggerAgent.h:
345         (WebCore::InspectorDebuggerAgent::Script::Script):
346         * inspector/ScriptDebugListener.h:
347         * inspector/front-end/DebuggerModel.js:
348         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
349         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
350         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
351         * inspector/front-end/Script.js:
352         (WebInspector.Script):
353
354 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
355
356         Reviewed by Pavel Feldman.
357
358         Web Inspector: [protocol] Evaluate should expose thrown exception value
359         https://bugs.webkit.org/show_bug.cgi?id=59000
360
361         Each evaluation command may have either thrown or returned result. This is indicated
362         by wasThrown property in the protocol.
363
364         * inspector/InjectedScript.cpp:
365         (WebCore::InjectedScript::evaluate):
366         (WebCore::InjectedScript::evaluateOn):
367         (WebCore::InjectedScript::evaluateOnCallFrame):
368         (WebCore::InjectedScript::getProperties):
369         (WebCore::InjectedScript::makeEvalCall):
370         * inspector/InjectedScript.h:
371         * inspector/InjectedScriptSource.js:
372         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
373         the evaluation results.
374         * inspector/InspectorDebuggerAgent.cpp:
375         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
376         * inspector/InspectorDebuggerAgent.h:
377         * inspector/InspectorRuntimeAgent.cpp:
378         (WebCore::InspectorRuntimeAgent::evaluate):
379         (WebCore::InspectorRuntimeAgent::evaluateOn):
380         (WebCore::InspectorRuntimeAgent::getProperties):
381         * inspector/InspectorRuntimeAgent.h:
382         * inspector/front-end/ConsoleView.js:
383         (WebInspector.ConsoleView.prototype.completions.evaluated):
384         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
385         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
386         (WebInspector.ConsoleView.prototype._enterKeyPressed):
387         (WebInspector.ConsoleCommandResult):
388         * inspector/front-end/DebuggerPresentationModel.js:
389         (WebInspector.PresenationCallFrame.prototype.evaluate):
390         * inspector/front-end/ElementsTreeOutline.js:
391         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
392         * inspector/front-end/ExtensionPanel.js:
393         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
394         * inspector/front-end/ExtensionServer.js:
395         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
396         * inspector/front-end/ObjectPropertiesSection.js:
397         (WebInspector.ObjectPropertyTreeElement.prototype.update):
398         * inspector/front-end/PropertiesSidebarPane.js:
399         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
400         * inspector/front-end/SourceFrame.js:
401         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
402         (WebInspector.SourceFrame.prototype._showPopup):
403
404 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
405
406         Unreviewed, rolling out r85315.
407         http://trac.webkit.org/changeset/85315
408         https://bugs.webkit.org/show_bug.cgi?id=59792
409
410         Broke script-formatter.html test (Requested by podivilov on
411         #webkit).
412
413         * inspector/front-end/DebuggerPresentationModel.js:
414         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
415         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
416         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
417         (WebInspector.PresentationBreakpoint.prototype.serialize):
418         * inspector/front-end/ScriptsPanel.js:
419         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
420         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
421         (WebInspector.ScriptsPanel.prototype.reset):
422
423 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
424
425         Reviewed by Pavel Feldman.
426
427         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
428         https://bugs.webkit.org/show_bug.cgi?id=58794
429
430         Added ping requests to network panel.
431
432         Test: http/tests/inspector/network/ping.html
433
434         * English.lproj/localizedStrings.js:
435         * inspector/InspectorInstrumentation.cpp:
436         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
437         * inspector/InspectorInstrumentation.h:
438         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
439         * inspector/front-end/NetworkPanel.js:
440         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
441         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
442         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
443         * inspector/front-end/Resource.js:
444         (WebInspector.Resource.prototype.get formParameters):
445         (WebInspector.Resource.prototype.requestContentType):
446         (WebInspector.Resource.prototype.isPingRequest):
447         * loader/PingLoader.cpp:
448         (WebCore::PingLoader::PingLoader):
449         * loader/PingLoader.h:
450
451 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
452
453         Reviewed by Pavel Feldman.
454
455         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
456         https://bugs.webkit.org/show_bug.cgi?id=59476
457
458         * inspector/front-end/DebuggerPresentationModel.js:
459         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
460         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
461         (WebInspector.PresentationBreakpoint.prototype.serialize):
462         * inspector/front-end/ScriptsPanel.js:
463         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
464         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
465         (WebInspector.ScriptsPanel.prototype.reset):
466
467 2011-04-29  Pavel Feldman  <pfeldman@google.com>
468
469         Reviewed by Yury Semikhatsky.
470
471         Web Inspector: add "open link in new tab" action into the network and resources panels.
472         https://bugs.webkit.org/show_bug.cgi?id=59788
473
474         This change also distinguishes context menu items case between platforms.
475
476         * English.lproj/localizedStrings.js:
477         * inspector/front-end/ConsoleView.js:
478         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
479         * inspector/front-end/DOMBreakpointsSidebarPane.js:
480         (WebInspector.DOMBreakpointsSidebarPane):
481         * inspector/front-end/ElementsPanel.js:
482         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
483         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
484         * inspector/front-end/ElementsTreeOutline.js:
485         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
486         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
487         * inspector/front-end/NetworkPanel.js:
488         (WebInspector.NetworkPanel.prototype._contextMenu):
489         * inspector/front-end/ResourcesPanel.js:
490         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
491         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
492         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
493         * inspector/front-end/Settings.js:
494         * inspector/front-end/SourceFrame.js:
495         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
496         * inspector/front-end/TextViewer.js:
497         (WebInspector.TextViewer.prototype._contextMenu):
498         * inspector/front-end/inspector.js:
499         (WebInspector.openLinkExternallyLabel):
500         (WebInspector.openResource):
501         (WebInspector.useLowerCaseMenuTitles):
502
503 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
504
505         Reviewed by Dan Bernstein.
506
507         Mask placement on composited layer is incorrect sometimes
508         https://bugs.webkit.org/show_bug.cgi?id=59775
509         
510         The mask layer always has the same size as its owning GraphicsLayer,
511         so it needs to share the same offsetFromRenderer as well. This fixes
512         the offset at which the mask layer contents are painted in cases where
513         that offset is non-zero, for example when outline style bloats all of
514         the layer sizes.
515
516         Test: compositing/masks/layer-mask-placement.html
517
518         * rendering/RenderLayerBacking.cpp:
519         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
520
521 2011-04-28  Dan Bernstein  <mitz@apple.com>
522
523         Rubber-stamped by Mark Rowe.
524
525         Reverted r81319.
526
527         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
528
529         * page/NavigatorBase.cpp:
530
531 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
532
533         Reviewed by Dirk Schulze.
534
535         1px box-shadow looks ugly
536         https://bugs.webkit.org/show_bug.cgi?id=58100
537         and
538         ShadowBlur incorrectly handles zero-sized blur radius in one axis
539         https://bugs.webkit.org/show_bug.cgi?id=59710
540         
541         blurLayerImage() has issues at the edges if the blur radius
542         is one, so in that case bump the buffer size out by a pixel.
543         This results in a correct, symmetrical blur.
544         
545         Also fix an issue noticed during testing where a zero
546         height or width radius would still blur on that axis,
547         because we clamp the kernel size to a minimum of two.
548
549         Test: fast/box-shadow/single-pixel-shadow.html
550
551         * platform/graphics/ShadowBlur.h:
552         * platform/graphics/ShadowBlur.cpp:
553         (WebCore::ShadowBlur::blurLayerImage):
554         Skip horizontal or vertial passes if the radius on that axis is zero.
555         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
556         clause to the end of the loop, since it only needs to execute once
557         after the first pass.        
558         (WebCore::ShadowBlur::blurredEdgeSize):
559         New method to compute the width of the blurred edge (radius + extra
560         pixel when necessary).
561         (WebCore::ShadowBlur::calculateLayerBoundingRect):
562         (WebCore::ShadowBlur::templateSize):
563         (WebCore::ShadowBlur::drawRectShadow):
564         (WebCore::ShadowBlur::drawInsetShadow):
565         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
566         (WebCore::ShadowBlur::drawRectShadowWithTiling):
567         (WebCore::ShadowBlur::drawLayerPieces):
568         Use the result of blurredEdgeSize() rather than recomputing.
569
570 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
571
572         Reviewed by Beth Dakin.
573
574         CSS sibling selector (~) does not work with :target pseudo class
575         https://bugs.webkit.org/show_bug.cgi?id=26539
576
577         Allow style recalculation of forward siblings of elements with
578         forward positional rules.
579
580         Tests: fast/css/pseudo-target-indirect-sibling-001.html
581                fast/css/pseudo-target-indirect-sibling-002.html
582
583         * dom/Element.cpp:
584         (WebCore::Element::recalcStyle):
585
586 2011-04-28  Nat Duca  <nduca@chromium.org>
587
588         Reviewed by Kenneth Russell.
589
590         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
591         https://bugs.webkit.org/show_bug.cgi?id=59626
592
593         * platform/graphics/chromium/Extensions3DChromium.h:
594         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
595
596 2011-04-28  Steve Lacey  <sjl@chromium.org>
597
598         Reviewed by Eric Carlson.
599
600         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
601         https://bugs.webkit.org/show_bug.cgi?id=59732
602
603         * css/mediaControlsChromium.css:
604         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
605         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
606
607 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
608
609         Reviewed by Eric Seidel.
610
611         Implement CSS border width and related properties in CSSStyleApplyProperty.
612         https://bugs.webkit.org/show_bug.cgi?id=59414
613
614         No new tests as no functionality added.
615
616         * css/CSSStyleApplyProperty.cpp:
617         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
618         the applyInheritValue and applyInitialValue methods only.
619         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
620         
621         Added ApplyPropertyWidth class for handling width based CSS properties.
622         * css/CSSStyleSelector.cpp:
623         Removed no-longer-required code for handling width based CSS properties.
624         * css/CSSStyleSelector.h:
625         Added a getter for m_rootElementStyle.
626
627 2011-04-28  Kent Tamura  <tkent@chromium.org>
628
629         Run sort-Xcode-project-file.
630
631         * WebCore.xcodeproj/project.pbxproj:
632
633 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
634
635         Reviewed by Dirk Schulze.
636
637         [Cairo] Text underline is not shadowed when text-shadow is enabled
638         https://bugs.webkit.org/show_bug.cgi?id=48074
639
640         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
641         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
642         originally copied from the CG GraphicsContext.
643
644         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
645           can call it from a static helper function.
646         * platform/graphics/cairo/GraphicsContextCairo.cpp:
647         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
648         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
649         call it multiple times when shadowing text underlines.
650         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
651         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
652         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
653
654 2011-04-28  Sam Weinig  <sam@webkit.org>
655
656         Rubber-stamped by Mark Rowe.
657
658         Cleanup WebCore.xcodeproj a bit.
659
660         * WebCore.xcodeproj/project.pbxproj:
661         Added CompilerVersion.xcconfig and moved some JS bindings files into the
662         correct sub groups.
663
664 2011-04-28  David Levin  <levin@chromium.org>
665
666         Reviewed by Adam Barth.
667
668         Remove IMAGE_RESIZER related code.
669         https://bugs.webkit.org/show_bug.cgi?id=59735
670
671         * CMakeLists.txt:
672         * Configurations/FeatureDefines.xcconfig:
673         * GNUmakefile.am:
674         * GNUmakefile.list.am:
675         * WebCore.gypi:
676         * WebCore.pro:
677         * WebCore.vcproj/WebCore.vcproj:
678         * WebCore.xcodeproj/project.pbxproj:
679         * features.pri:
680         * html/AsyncImageResizer.cpp: Removed.
681         * html/AsyncImageResizer.h: Removed.
682         * html/ImageResizerThread.cpp: Removed.
683         * html/ImageResizerThread.h: Removed.
684
685 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
686
687         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
688
689         * inspector/front-end/Settings.js:
690         (WebInspector.Settings):
691
692 2011-04-28  Beth Dakin  <bdakin@apple.com>
693
694         Rubber-stamped by Sam Weinig.
695
696         Rolling out revision 85258! I want to fix that bug a different way.
697         * platform/mac/ScrollbarThemeMac.mm:
698         (WebCore::ScrollbarThemeMac::paint):
699
700 2011-04-28  Chang Shu  <cshu@webkit.org>
701
702         Reviewed by Eric Seidel.
703
704         isContentEditable is not working properly with document.designMode
705         https://bugs.webkit.org/show_bug.cgi?id=53031
706
707         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
708         indicates that the element.isContentEditable relies on document.designMode if its
709         and its ancestors' contenteditable attributes are set to inherit.
710
711         1. Sync document render style after document.designMode is changed.
712         2. Removed the code that does unnecessary and incorrect handling for contenteditable
713         attribute with "inherit" value.
714         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
715
716         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
717                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
718                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
719                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
720
721         * css/CSSStyleSelector.cpp:
722         (WebCore::CSSStyleSelector::styleForDocument):
723         * dom/Document.cpp:
724         (WebCore::Document::setDesignMode):
725         * dom/Node.cpp:
726         (WebCore::Node::rendererIsEditable):
727         * editing/ApplyStyleCommand.cpp:
728         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
729         * html/HTMLElement.cpp:
730         (WebCore::HTMLElement::setContentEditable):
731
732 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
733
734         Unreviewed, rolling out r85101.
735         http://trac.webkit.org/changeset/85101
736         https://bugs.webkit.org/show_bug.cgi?id=59757
737
738          it'd be better to rollout the patch and do another one with
739         another property name. Current one will bring us to a problem
740         at first run after upgrade because it's type was changed from
741         int to string. (Requested by loislo on #webkit).
742
743         * inspector/front-end/ScriptsPanel.js:
744         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
745         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
746         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
747
748 2011-04-28  Mike Reed  <reed@google.com>
749
750         Reviewed by Eric Seidel.
751
752         fix shadw behavior for both CSS and Canvas -- skia only
753         https://bugs.webkit.org/show_bug.cgi?id=59700
754
755         Test:
756         canvas/philip/tests/2d.shadow.alpha.3.html
757         canvas/philip/tests/2d.shadow.alpha.4.html
758         canvas/philip/tests/2d.shadow.alpha.5.html
759         fast/canvas/canvas-fillPath-alpha-shadow.html
760         fast/canvas/canvas-strokePath-alpha-shadow.html
761         fast/canvas/canvas-strokeRect-alpha-shadow.html
762         fast/css/text-input-with-webkit-border-radius.html
763         fast/repaint/shadow-multiple-horizontal.html
764         fast/repaint/shadow-multiple-strict-horizontal.html
765         fast/repaint/shadow-multiple-strict-vertical.html
766         fast/repaint/shadow-multiple-vertical.html
767         fast/canvas/canvas-getImageData.html
768
769         * platform/graphics/chromium/FontChromiumWin.cpp:
770         (WebCore::Font::drawGlyphs):
771         * platform/graphics/skia/GraphicsContextSkia.cpp:
772         (WebCore::GraphicsContext::setPlatformShadow):
773
774 2011-04-28  David Kilzer  <ddkilzer@apple.com>
775
776         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
777
778         Reviewed by Chris Fleizach.
779
780         Previously, AXObjectCache::attachWrapper over-retained each
781         AccessibilityObjectWrapper it created, which is why
782         AXObjectCache::detachWrapper() contained an extra -release.
783
784         * accessibility/mac/AXObjectCacheMac.mm:
785         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
786         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
787         assigns to a RetainPtr<> instance variable, it doesn't need a +1
788         retained object passed in.  Fix the leak by using a RetainPtr<>
789         for the AccessibilityObjectWrapper.
790
791 2011-04-28  Nat Duca  <nduca@chromium.org>
792
793         Reviewed by Darin Fisher.
794
795         [chromium] Compute compositor fps value and history using the frameBegin timestamp
796         https://bugs.webkit.org/show_bug.cgi?id=59668
797
798         This change switches the compositor FPS meter to use the timestamp
799         of the beginning of the frame rather than the time we call
800         swapBuffers. When scheduling is correctly tied to vsync, we can
801         have highly variable times when we finish vsync and still have
802         stable frame rates.
803
804         * platform/graphics/chromium/LayerRendererChromium.cpp:
805         (WebCore::LayerRendererChromium::updateAndDrawLayers):
806         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
807         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
808         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
809         (WebCore::CCHeadsUpDisplay::onFrameBegin):
810         (WebCore::CCHeadsUpDisplay::onPresent):
811         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
812
813 2011-04-28  Beth Dakin  <bdakin@apple.com>
814
815         Reviewed by Darin Adler.
816
817         https://bugs.webkit.org/show_bug.cgi?id=59759
818         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
819         track when there is nothing to scroll to
820         <rdar://problem/9282066>
821
822         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
823         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
824         is not right. Set the proportion to 0 in this case instead.
825         * platform/mac/ScrollbarThemeMac.mm:
826         (WebCore::ScrollbarThemeMac::paint):
827
828 2011-04-28  Dan Bernstein  <mitz@apple.com>
829
830         Reviewed by Simon Fraser.
831
832         <rdar://problem/9291132> Add support for -epub-prefixed properties
833
834         Test: fast/css/epub-properties.html
835
836         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
837         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
838         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
839         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
840         text-transform, text-transform, word-break, and -webkit-writing-mode.
841
842 2011-04-28  Adam Barth  <abarth@webkit.org>
843
844         Reviewed by Eric Seidel.
845
846         Remove WML
847         https://bugs.webkit.org/show_bug.cgi?id=59678
848
849         This patch removes WML from WebCore.  After removing WML, there's a
850         bunch of twisted code that could be untwisted, but this patch contains
851         only the purely mechanical part of removing the feature.
852
853         There's been a lot of discussion on webkit-dev about whether we should
854         remove WML.  In addition to those threads, we've had an informal poll
855         of the reviewers as well as an in-person discussion at the WebKit
856         contributor's meeting.  Removing any feature is likely to make some
857         folks unhappy, but, on balance, removing WML appears to be the right
858         thing for the project to do at this time.
859
860         * CMakeLists.txt:
861         * CodeGenerators.pri:
862         * Configurations/FeatureDefines.xcconfig:
863         * DerivedSources.cpp:
864         * DerivedSources.make:
865         * GNUmakefile.am:
866         * GNUmakefile.list.am:
867         * WebCore.gyp/WebCore.gyp:
868         * WebCore.gypi:
869         * WebCore.pro:
870         * WebCore.vcproj/WebCore.vcproj:
871         * WebCore.xcodeproj/project.pbxproj:
872         * css/CSSStyleSelector.cpp:
873         (WebCore::linkAttribute):
874         (WebCore::CSSStyleSelector::styleForElement):
875         (WebCore::CSSStyleSelector::adjustRenderStyle):
876         * css/wml.css: Removed.
877         * dom/DOMImplementation.cpp:
878         (WebCore::DOMImplementation::createDocument):
879         * dom/Document.cpp:
880         (WebCore::Document::Document):
881         (WebCore::Document::createElement):
882         * dom/Document.h:
883         (WebCore::Document::isMediaDocument):
884         * dom/Document.idl:
885         * dom/InputElement.h:
886         * dom/Node.cpp:
887         (WebCore::Node::toInputElement):
888         * dom/Node.h:
889         * dom/OptionElement.cpp:
890         (WebCore::toOptionElement):
891         (WebCore::isOptionElement):
892         * dom/OptionElement.h:
893         * dom/OptionGroupElement.cpp:
894         (WebCore::toOptionGroupElement):
895         (WebCore::isOptionGroupElement):
896         * dom/SelectElement.cpp:
897         (WebCore::toSelectElement):
898         * dom/SelectElement.h:
899         * dom/Text.cpp:
900         (WebCore::Text::attach):
901         * dom/XMLDocumentParser.cpp:
902         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
903         * dom/XMLDocumentParser.h:
904         * dom/XMLDocumentParserLibxml2.cpp:
905         (WebCore::XMLDocumentParser::internalSubset):
906         (WebCore::getEntityHandler):
907         * dom/XMLDocumentParserQt.cpp:
908         (WebCore::XMLDocumentParser::parse):
909         (WebCore::XMLDocumentParser::parseDtd):
910         * editing/htmlediting.cpp:
911         (WebCore::canHaveChildrenForEditing):
912         * features.pri:
913         * history/BackForwardList.h:
914         * history/BackForwardListImpl.cpp:
915         * history/BackForwardListImpl.h:
916         * history/PageCache.cpp:
917         (WebCore::PageCache::canCachePageContainingThisFrame):
918         * html/HTMLAnchorElement.h:
919         * inspector/ConsoleMessage.cpp:
920         (WebCore::messageSourceValue):
921         * inspector/front-end/ConsoleView.js:
922         (WebInspector.ConsoleMessage.prototype.toString):
923         * loader/FrameLoader.cpp:
924         (WebCore::isBackForwardLoadType):
925         (WebCore::FrameLoader::transitionToCommitted):
926         (WebCore::FrameLoader::shouldReload):
927         (WebCore::FrameLoader::loadDifferentDocumentItem):
928         (WebCore::FrameLoader::loadItem):
929         * loader/FrameLoaderTypes.h:
930         * loader/HistoryController.cpp:
931         (WebCore::HistoryController::restoreDocumentState):
932         * manual-tests/wml: Removed.
933         * manual-tests/wml/StartTests.wml: Removed.
934         * manual-tests/wml/a-br-element.wml: Removed.
935         * manual-tests/wml/a-element.wml: Removed.
936         * manual-tests/wml/a-img-element.wml: Removed.
937         * manual-tests/wml/access-target.wml: Removed.
938         * manual-tests/wml/anchor-br-element.wml: Removed.
939         * manual-tests/wml/anchor-element.wml: Removed.
940         * manual-tests/wml/anchor-img-element.wml: Removed.
941         * manual-tests/wml/card-newcontext-attr.wml: Removed.
942         * manual-tests/wml/card-onenterbackward.wml: Removed.
943         * manual-tests/wml/card-onenterforward.wml: Removed.
944         * manual-tests/wml/card-ontimer.wml: Removed.
945         * manual-tests/wml/deck-access-control.wml: Removed.
946         * manual-tests/wml/input-format.wml: Removed.
947         * manual-tests/wml/onevent-go.wml: Removed.
948         * manual-tests/wml/onevent-noop.wml: Removed.
949         * manual-tests/wml/onevent-prev.wml: Removed.
950         * manual-tests/wml/onevent-refresh.wml: Removed.
951         * manual-tests/wml/onevent-shadow.wml: Removed.
952         * manual-tests/wml/resources: Removed.
953         * manual-tests/wml/resources/smiley.png: Removed.
954         * manual-tests/wml/select-element.wml: Removed.
955         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
956         * manual-tests/wml/select-onpick-event.wml: Removed.
957         * manual-tests/wml/setvar-element.wml: Removed.
958         * manual-tests/wml/targetdeck.wml: Removed.
959         * manual-tests/wml/task-go-in-anchor.wml: Removed.
960         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
961         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
962         * manual-tests/wml/template-go.wml: Removed.
963         * manual-tests/wml/template-ontimer.wml: Removed.
964         * manual-tests/wml/timer.wml: Removed.
965         * manual-tests/wml/variable-substitution.wml: Removed.
966         * page/Console.cpp:
967         (WebCore::printMessageSourceAndLevelPrefix):
968         * page/Console.h:
969         * page/Frame.cpp:
970         (WebCore::Frame::Frame):
971         * page/Page.cpp:
972         * page/Page.h:
973         * platform/MIMETypeRegistry.cpp:
974         (WebCore::initializeSupportedNonImageMimeTypes):
975         * platform/network/FormDataBuilder.h:
976         * platform/network/mac/ResourceHandleMac.mm:
977         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
978         * platform/wince/MIMETypeRegistryWinCE.cpp:
979         (WebCore::initMIMETypeEntensionMap):
980         * rendering/HitTestResult.cpp:
981         (WebCore::HitTestResult::altDisplayString):
982         (WebCore::HitTestResult::absoluteImageURL):
983         (WebCore::HitTestResult::absoluteLinkURL):
984         (WebCore::HitTestResult::isLiveLink):
985         * rendering/RenderBox.cpp:
986         * rendering/RenderButton.cpp:
987         (WebCore::RenderButton::updateFromElement):
988         * rendering/RenderFieldset.cpp:
989         (WebCore::RenderFieldset::findLegend):
990         * rendering/RenderImage.cpp:
991         (WebCore::RenderImage::updateAltText):
992         * rendering/RenderObject.cpp:
993         (WebCore::RenderObject::isLegend):
994         (WebCore::RenderObject::offsetParent):
995         * wml: Removed.
996         * wml/WMLAElement.cpp: Removed.
997         * wml/WMLAElement.h: Removed.
998         * wml/WMLAccessElement.cpp: Removed.
999         * wml/WMLAccessElement.h: Removed.
1000         * wml/WMLAnchorElement.cpp: Removed.
1001         * wml/WMLAnchorElement.h: Removed.
1002         * wml/WMLAttributeNames.in: Removed.
1003         * wml/WMLBRElement.cpp: Removed.
1004         * wml/WMLBRElement.h: Removed.
1005         * wml/WMLCardElement.cpp: Removed.
1006         * wml/WMLCardElement.h: Removed.
1007         * wml/WMLDoElement.cpp: Removed.
1008         * wml/WMLDoElement.h: Removed.
1009         * wml/WMLDocument.cpp: Removed.
1010         * wml/WMLDocument.h: Removed.
1011         * wml/WMLElement.cpp: Removed.
1012         * wml/WMLElement.h: Removed.
1013         * wml/WMLErrorHandling.cpp: Removed.
1014         * wml/WMLErrorHandling.h: Removed.
1015         * wml/WMLEventHandlingElement.cpp: Removed.
1016         * wml/WMLEventHandlingElement.h: Removed.
1017         * wml/WMLFieldSetElement.cpp: Removed.
1018         * wml/WMLFieldSetElement.h: Removed.
1019         * wml/WMLFormControlElement.cpp: Removed.
1020         * wml/WMLFormControlElement.h: Removed.
1021         * wml/WMLGoElement.cpp: Removed.
1022         * wml/WMLGoElement.h: Removed.
1023         * wml/WMLImageElement.cpp: Removed.
1024         * wml/WMLImageElement.h: Removed.
1025         * wml/WMLImageLoader.cpp: Removed.
1026         * wml/WMLImageLoader.h: Removed.
1027         * wml/WMLInputElement.cpp: Removed.
1028         * wml/WMLInputElement.h: Removed.
1029         * wml/WMLInsertedLegendElement.cpp: Removed.
1030         * wml/WMLInsertedLegendElement.h: Removed.
1031         * wml/WMLIntrinsicEvent.cpp: Removed.
1032         * wml/WMLIntrinsicEvent.h: Removed.
1033         * wml/WMLIntrinsicEventHandler.cpp: Removed.
1034         * wml/WMLIntrinsicEventHandler.h: Removed.
1035         * wml/WMLMetaElement.cpp: Removed.
1036         * wml/WMLMetaElement.h: Removed.
1037         * wml/WMLNoopElement.cpp: Removed.
1038         * wml/WMLNoopElement.h: Removed.
1039         * wml/WMLOnEventElement.cpp: Removed.
1040         * wml/WMLOnEventElement.h: Removed.
1041         * wml/WMLOptGroupElement.cpp: Removed.
1042         * wml/WMLOptGroupElement.h: Removed.
1043         * wml/WMLOptionElement.cpp: Removed.
1044         * wml/WMLOptionElement.h: Removed.
1045         * wml/WMLPElement.cpp: Removed.
1046         * wml/WMLPElement.h: Removed.
1047         * wml/WMLPageState.cpp: Removed.
1048         * wml/WMLPageState.h: Removed.
1049         * wml/WMLPostfieldElement.cpp: Removed.
1050         * wml/WMLPostfieldElement.h: Removed.
1051         * wml/WMLPrevElement.cpp: Removed.
1052         * wml/WMLPrevElement.h: Removed.
1053         * wml/WMLRefreshElement.cpp: Removed.
1054         * wml/WMLRefreshElement.h: Removed.
1055         * wml/WMLSelectElement.cpp: Removed.
1056         * wml/WMLSelectElement.h: Removed.
1057         * wml/WMLSetvarElement.cpp: Removed.
1058         * wml/WMLSetvarElement.h: Removed.
1059         * wml/WMLTableElement.cpp: Removed.
1060         * wml/WMLTableElement.h: Removed.
1061         * wml/WMLTagNames.in: Removed.
1062         * wml/WMLTaskElement.cpp: Removed.
1063         * wml/WMLTaskElement.h: Removed.
1064         * wml/WMLTemplateElement.cpp: Removed.
1065         * wml/WMLTemplateElement.h: Removed.
1066         * wml/WMLTimerElement.cpp: Removed.
1067         * wml/WMLTimerElement.h: Removed.
1068         * wml/WMLVariables.cpp: Removed.
1069         * wml/WMLVariables.h: Removed.
1070
1071 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1072
1073         Unreviewed, rolling out r85233 and r85235.
1074         http://trac.webkit.org/changeset/85233
1075         http://trac.webkit.org/changeset/85235
1076         https://bugs.webkit.org/show_bug.cgi?id=59754
1077
1078         Causes issues with jsc. (Requested by dave_levin on #webkit).
1079
1080         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
1081         * loader/icon/IconDatabase.cpp:
1082         (WebCore::IconDatabase::defaultIcon):
1083         (WebCore::IconDatabase::setIconDataForIconURL):
1084         (WebCore::IconDatabase::getOrCreateIconRecord):
1085         (WebCore::IconDatabase::readFromDatabase):
1086
1087 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
1088
1089         Reviewed by Adam Barth.
1090
1091         Introducing a new class that allows serialization of a page back
1092         to HTML/XML with all its sub-frames and also retrieves the page's
1093         resources.
1094         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
1095         https://bugs.webkit.org/show_bug.cgi?id=58947
1096
1097         * Android.mk:
1098         * CMakeLists.txt:
1099         * GNUmakefile.list.am:
1100         * WebCore.gypi:
1101         * WebCore.pro:
1102         * WebCore.vcproj/WebCore.vcproj:
1103         * dom/Document.cpp:
1104         (WebCore::Document::suggestedMIMEType):
1105         * dom/Document.h:
1106         * editing/MarkupAccumulator.cpp:
1107         (WebCore::MarkupAccumulator::appendCustomAttributes):
1108         (WebCore::MarkupAccumulator::appendElement):
1109         * editing/MarkupAccumulator.h:
1110         * html/parser/HTMLMetaCharsetParser.cpp:
1111         (WebCore::HTMLMetaCharsetParser::processMeta):
1112         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
1113         * html/parser/HTMLMetaCharsetParser.h:
1114         * page/PageSerializer.cpp: Added.
1115         * page/PageSerializer.h: Added.
1116
1117 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
1118
1119         Reviewed by Tony Chang.
1120
1121         IndexedDB createIndex should fail if name arg is null
1122         https://bugs.webkit.org/show_bug.cgi?id=58365
1123
1124         Test: storage/indexeddb/mozilla/create-index-null-name.html
1125
1126         * storage/IDBObjectStore.idl:
1127         * storage/IDBObjectStoreBackendImpl.cpp:
1128         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1129
1130 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
1131
1132         Reviewed by Tony Chang.
1133
1134         IndexedDB put() should fail if second (key) parameter is null
1135         https://bugs.webkit.org/show_bug.cgi?id=58613
1136
1137         If key arg is not specified, prpKey ends up as a null pointer in ::put().
1138         However, if the key arg is specified but is null, prpKey ends up as a
1139         valid IDBKey which has a null key type. As it happens, we need to be able
1140         to detect the difference between these cases (the key arg is optional but
1141         if specified must not be null).
1142
1143         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
1144
1145         * storage/IDBObjectStoreBackendImpl.cpp:
1146         (WebCore::IDBObjectStoreBackendImpl::put):
1147
1148 2011-04-07  David Levin  <levin@chromium.org>
1149
1150         Reviewed by Darin Adler.
1151
1152         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
1153         https://bugs.webkit.org/show_bug.cgi?id=31639
1154
1155         No new functionality exposed so no new tests. (The change is basically adding
1156         more testing.)
1157
1158         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
1159         * loader/icon/IconDatabase.cpp:
1160         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
1161         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
1162         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
1163         (WebCore::IconDatabase::readFromDatabase): Ditto.
1164
1165 2011-04-28  Kenneth Russell  <kbr@google.com>
1166
1167         Unreviewed build fix for Web Audio with strict OwnPtr.
1168
1169         * platform/audio/HRTFDatabaseLoader.cpp:
1170         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
1171
1172 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
1173
1174         Reviewed by Geoffrey Garen.
1175
1176         Walk shadow hosts as well as parent nodes when finding opaque roots.
1177         https://bugs.webkit.org/show_bug.cgi?id=59571
1178
1179         Test: fast/dom/shadow/gc-shadow.html
1180
1181         * bindings/js/JSDOMBinding.h:
1182         (WebCore::root):
1183
1184 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
1185
1186         Reviewed by Xan Lopez.
1187
1188         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
1189         https://bugs.webkit.org/show_bug.cgi?id=59715
1190
1191         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
1192         into WebCore so that WebKit1 and WebKit2 can share the code.
1193
1194         No new tests. This is covered by fast/events/click-count.html.
1195
1196         * GNUmakefile.list.am: Added new files.
1197         * platform/gtk/GtkClickCounter.cpp: Added.
1198         (WebCore::GtkClickCounter::GtkClickCounter): Added.
1199         (WebCore::GtkClickCounter::reset): Added.
1200         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
1201         (WebCore::getEventTime): Added.
1202         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
1203         * platform/gtk/GtkClickCounter.h: Added.
1204
1205 2011-04-28  Dan Bernstein  <mitz@apple.com>
1206
1207         Build fix.
1208
1209         * css/CSSParser.cpp:
1210         (WebCore::cssPropertyID):
1211
1212 2011-04-28  Dan Bernstein  <mitz@apple.com>
1213
1214         Reviewed by Simon Fraser.
1215
1216         Allow specifying CSS property aliases in CSSPropertyNames.in files
1217         https://bugs.webkit.org/show_bug.cgi?id=59712
1218
1219         * css/CSSParser.cpp:
1220         (WebCore::cssPropertyID): Removed code to handle some aliases
1221         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
1222         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
1223         defining an alias, and add an appropriate entry to the gperf file.
1224
1225 2011-04-28  Arno Renevier  <arno@renevier.net>
1226
1227         Reviewed by Gustavo Noronha Silva.
1228
1229         [Soup] does not load css stylesheets without content-type
1230         https://bugs.webkit.org/show_bug.cgi?id=59697
1231
1232         When sniffing content type, do not replace http Content-Type header in
1233         soup message anymore, but keep sniffed content type in a separate
1234         variable.
1235
1236         * platform/network/soup/ResourceHandleSoup.cpp:
1237         (WebCore::contentSniffedCallback):
1238         * platform/network/soup/ResourceResponse.h:
1239         (WebCore::ResourceResponse::sniffedContentType):
1240         (WebCore::ResourceResponse::setSniffedContentType):
1241         * platform/network/soup/ResourceResponseSoup.cpp:
1242         (WebCore::ResourceResponse::updateFromSoupMessage):
1243
1244 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
1245
1246         Reviewed by Andreas Kling.
1247
1248         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
1249         https://bugs.webkit.org/show_bug.cgi?id=59704
1250
1251         No new tests, just code cleanup.
1252
1253         * WebCore.pri:
1254
1255 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1256
1257         Reviewed by Pavel Feldman.
1258
1259         Web Inspector: remove "Pretty print" source frame context menu item.
1260         https://bugs.webkit.org/show_bug.cgi?id=59709
1261
1262         * inspector/front-end/DebuggerPresentationModel.js:
1263         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1264         * inspector/front-end/ScriptsPanel.js:
1265         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1266         * inspector/front-end/SourceFrame.js:
1267         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
1268
1269 2011-04-28  Satish Sampath  <satish@chromium.org>
1270
1271         Reviewed by Tony Gentilcore.
1272
1273         Speech input button layout issues with padding and border.
1274         https://bugs.webkit.org/show_bug.cgi?id=59613
1275
1276         * rendering/RenderTextControlSingleLine.cpp:
1277         (WebCore::RenderTextControlSingleLine::layout):
1278         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1279         (WebCore::RenderTextControlSingleLine::forwardEvent):
1280
1281 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1282
1283         Reviewed by Martin Robinson.
1284
1285         [GTK] Check whether to use native scrollbars at run time
1286         https://bugs.webkit.org/show_bug.cgi?id=59694
1287
1288         It's currently decided at build time depending on whether webkit2
1289         build is enabled or not. That makes imposible to build both
1290         webkit1 and webkit2 using the same libWebCore.
1291
1292         * GNUmakefile.am:
1293         * platform/ScrollView.cpp:
1294         (WebCore::ScrollView::wheelEvent):
1295         * platform/gtk/ScrollViewGtk.cpp:
1296         (WebCore::ScrollView::createScrollbar):
1297
1298 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1299
1300         Reviewed by Yury Semikhatsky.
1301
1302         Web Inspector: add status bar button for pretty print.
1303         https://bugs.webkit.org/show_bug.cgi?id=59467
1304
1305         * WebCore.gypi:
1306         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
1307         * inspector/front-end/ScriptsPanel.js:
1308         (WebInspector.ScriptsPanel):
1309         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
1310         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
1311         * inspector/front-end/WebKit.qrc:
1312         * inspector/front-end/inspector.css:
1313         (.scripts-toggle-pretty-print-status-bar-item .glyph):
1314         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
1315
1316 2011-04-28  Pavel Feldman  <pfeldman@google.com>
1317
1318         Reviewed by Yury Semikhatsky.
1319
1320         Web Inspector: add ResourceTreeModel tests.
1321         https://bugs.webkit.org/show_bug.cgi?id=59616
1322
1323         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
1324                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
1325                http/tests/inspector/resource-tree/resource-tree-reload.html
1326
1327         * inspector/front-end/ResourceTreeModel.js:
1328         (WebInspector.ResourceTreeModel.prototype.frontendReused):
1329         (WebInspector.ResourceTreeModel.prototype._addFrame):
1330         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1331         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1332         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1333         (WebInspector.ResourceTreeModel.prototype.forAllResources):
1334         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1335         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
1336         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1337         * inspector/front-end/ResourcesPanel.js:
1338         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1339         (WebInspector.ResourcesPanel.prototype._frameAdded):
1340         (WebInspector.ResourcesPanel.prototype._frameDetached):
1341         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1342         (WebInspector.FrameTreeElement):
1343         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1344
1345 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1346
1347         Reviewed by Yury Semikhatsky.
1348
1349         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
1350         https://bugs.webkit.org/show_bug.cgi?id=59592
1351
1352         * inspector/front-end/DetailedHeapshotGridNodes.js:
1353         (WebInspector.HeapSnapshotGridNode.prototype._populate):
1354         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
1355         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
1356         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
1357         * inspector/front-end/DetailedHeapshotView.js:
1358         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
1359         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
1360         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
1361         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
1362         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
1363         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
1364         (WebInspector.DetailedHeapshotView.prototype.changeView):
1365         * inspector/front-end/HeapSnapshot.js:
1366         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
1367         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
1368         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
1369         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
1370         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
1371         * inspector/front-end/heapProfiler.css:
1372         (div.retaining-paths-view td.path-column div:hover):
1373
1374 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
1375
1376         Reviewed by Yury Semikhatsky.
1377
1378         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
1379         https://bugs.webkit.org/show_bug.cgi?id=59454
1380
1381         Test: inspector/profiler/heap-snapshot-loader.html
1382
1383         * inspector/front-end/HeapSnapshot.js:
1384         (WebInspector.HeapSnapshotLoader):
1385         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
1386         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
1387         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
1388         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
1389         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
1390         * inspector/front-end/HeapSnapshotProxy.js:
1391         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
1392
1393 2011-04-28  ojab  <ojab@ojab.ru>
1394
1395         Reviewed by David Levin.
1396
1397         Fix build with libpng-1.5.1
1398         https://bugs.webkit.org/show_bug.cgi?id=59607
1399
1400         * platform/image-decoders/png/PNGImageDecoder.cpp:
1401         (WebCore::readColorProfile):
1402
1403 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
1404
1405         Reviewed by Nikolas Zimmermann.
1406
1407         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
1408         https://bugs.webkit.org/show_bug.cgi?id=59447
1409
1410         This patch contains two sub-routines, one for speeding up
1411         alpha channel only gaussian blur (by 2.5 times) and one
1412         for speeding up all channel blur (by 4 times).
1413
1414         The common code is also redesigned to better fit for platform
1415         specific code. This means large chunks of code was moved to
1416         different files, and all platform specific files are added to
1417         all build systems.
1418
1419         * CMakeLists.txt:
1420         * GNUmakefile.am:
1421         * GNUmakefile.list.am:
1422         * WebCore.gypi:
1423         * WebCore.pro:
1424         * WebCore.vcproj/WebCore.vcproj:
1425         * WebCore.vcproj/WebCoreCommon.vsprops:
1426         * WebCore.xcodeproj/project.pbxproj:
1427         * platform/graphics/filters/FEGaussianBlur.cpp:
1428         (WebCore::FEGaussianBlur::platformApplyGeneric):
1429         (WebCore::FEGaussianBlur::apply):
1430         * platform/graphics/filters/FEGaussianBlur.h:
1431         (WebCore::FEGaussianBlur::kernelPosition):
1432         (WebCore::FEGaussianBlur::platformApply):
1433         * platform/graphics/filters/FELighting.cpp:
1434         (WebCore::FELighting::platformApplyGeneric):
1435         (WebCore::FELighting::drawLighting):
1436         * platform/graphics/filters/FELighting.h:
1437         (WebCore::FELighting::platformApply):
1438         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
1439         (WebCore::WTF_ALIGNED):
1440         (WebCore::feGaussianBlurConstantsForNeon):
1441         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
1442         (WebCore::FEGaussianBlur::platformApplyNeon):
1443         * platform/graphics/filters/arm/FELightingNEON.cpp:
1444         (WebCore::WTF_ALIGNED):
1445         (WebCore::FELighting::getPowerCoefficients):
1446         * platform/graphics/filters/arm/FELightingNEON.h:
1447         (WebCore::FELighting::platformApplyNeon):
1448
1449 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
1450
1451         Reviewed by Yury Semikhatsky.
1452
1453         Web Inspector: provide a hotkey for script pause
1454         https://bugs.webkit.org/show_bug.cgi?id=59593
1455
1456         In fact, F8 works as a hotkey, but this fact was not reflected
1457         in the shortcut help popup.
1458
1459         * English.lproj/localizedStrings.js:
1460         * inspector/front-end/ScriptsPanel.js:
1461         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
1462
1463 2011-04-28  Adam Barth  <abarth@webkit.org>
1464
1465         Reviewed by Eric Seidel.
1466
1467         PluginStream should play nice with strict OwnPtr
1468         https://bugs.webkit.org/show_bug.cgi?id=59675
1469
1470         These failures appear when enabling strict OwnPtr on Qt.
1471
1472         * plugins/PluginStream.cpp:
1473         (WebCore::PluginStream::PluginStream):
1474         (WebCore::PluginStream::didReceiveData):
1475
1476 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
1477
1478         Reviewed by Pavel Feldman.
1479
1480         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
1481         https://bugs.webkit.org/show_bug.cgi?id=59326
1482
1483         Concrete CachedResource successors for stylesheets and scripts
1484         can decode their content better than the generic approach we use.
1485
1486         * inspector/InspectorPageAgent.cpp:
1487         (WebCore::decodeSharedBuffer):
1488         (WebCore::prepareCachedResourceBuffer):
1489         (WebCore::cachedResourceDecoded):
1490         (WebCore::InspectorPageAgent::resourceContent):
1491         (WebCore::InspectorPageAgent::resourceData):
1492         * inspector/InspectorStyleSheet.cpp:
1493         (WebCore::InspectorStyleSheet::originalStyleSheetText):
1494
1495 2011-04-28  Jon Lee  <jonlee@apple.com>
1496
1497         Reviewed by Simon Fraser.
1498
1499         REGRESSION: white overlay scrollbars on apple.com/startpage
1500         https://bugs.webkit.org/show_bug.cgi?id=59540
1501         <rdar://problem/9338653>
1502
1503         Now we look at the document background in addition to the <body> element,
1504         and blend those colors in with the base background of the frame view to
1505         arrive at our aggregate color. This provides a better result to determine
1506         overlay scrollbar style.
1507
1508         * page/Frame.cpp:
1509         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
1510         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
1511
1512 2011-04-27  Adam Barth  <abarth@webkit.org>
1513
1514         Reviewed by Maciej Stachowiak.
1515
1516         Fix OwnPtr issues in IndexedDB
1517         https://bugs.webkit.org/show_bug.cgi?id=59656
1518
1519         This patch is an attempt to fix the clang build.  Clang can't seem to
1520         cope with OwnPtrs to classes declared in an anonymous namespace because
1521         OwnPtr's copy constructor isn't defined (but would need to be defined
1522         in this translation unit).
1523
1524         * platform/leveldb/LevelDBDatabase.cpp:
1525
1526 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
1527
1528         Reviewed by Antonio Gomes.
1529
1530         [EFL] Change cursor to LAZY_NATIVE_CURSOR
1531         https://bugs.webkit.org/show_bug.cgi?id=59411
1532
1533         Enable LAZY_NATIVE_CURSOR on EFL build.
1534
1535         No test added because functionality is unchanged.
1536
1537         * CMakeListsEfl.txt: Add Cursor.cpp
1538         * platform/Cursor.h:
1539         (WebCore::Cursor::Cursor):
1540         * platform/efl/CursorEfl.cpp:
1541         (WebCore::Cursor::Cursor):
1542         (WebCore::Cursor::~Cursor):
1543         (WebCore::getCursorString):
1544         (WebCore::Cursor::ensurePlatformCursor):
1545         * platform/efl/WidgetEfl.cpp:
1546         (WebCore::Widget::setCursor):
1547
1548 2011-04-27  Adam Barth  <abarth@webkit.org>
1549
1550         Build fix from the future.  Another trival strict OwnPtr fixes.  This
1551         is the last futuristic build fix I can detect with my time traveling
1552         abilities.
1553
1554         * platform/graphics/chromium/TransparencyWin.cpp:
1555         (WebCore::TransparencyWin::initializeNewContext):
1556
1557 2011-04-27  Dmitry Lomov  <dslomov@google.com>
1558
1559         Reviewed by David Levin.
1560
1561         CrossThreadCopier should not have a default specialization for raw pointers
1562         https://bugs.webkit.org/show_bug.cgi?id=59234
1563         Removed the ablity to pass raw pointers cross-thread
1564         Added and applied annotations for doing that
1565
1566         * fileapi/FileReader.cpp:
1567         (WebCore::FileReader::readInternal):
1568         (WebCore::FileReader::abort):
1569         * fileapi/FileStreamProxy.cpp:
1570         (WebCore::FileStreamProxy::startOnFileThread):
1571         (WebCore::FileStreamProxy::stopOnFileThread):
1572         (WebCore::FileStreamProxy::getSize):
1573         (WebCore::FileStreamProxy::getSizeOnFileThread):
1574         (WebCore::FileStreamProxy::openForRead):
1575         (WebCore::FileStreamProxy::openForReadOnFileThread):
1576         (WebCore::FileStreamProxy::openForWrite):
1577         (WebCore::FileStreamProxy::openForWriteOnFileThread):
1578         (WebCore::FileStreamProxy::close):
1579         (WebCore::FileStreamProxy::read):
1580         (WebCore::FileStreamProxy::readOnFileThread):
1581         (WebCore::FileStreamProxy::write):
1582         (WebCore::FileStreamProxy::writeOnFileThread):
1583         (WebCore::FileStreamProxy::truncate):
1584         (WebCore::FileStreamProxy::truncateOnFileThread):
1585         * loader/WorkerThreadableLoader.cpp:
1586         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
1587         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
1588         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
1589         * page/GeolocationPositionCache.cpp:
1590         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
1591         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
1592         * platform/CrossThreadCopier.h:
1593         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
1594         (WebCore::AllowCrossThreadAccessWrapper::value):
1595         (WebCore::AllowCrossThreadAccess):
1596         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
1597         (WebCore::AllowExtendedLifetimeWrapper::value):
1598         (WebCore::AllowExtendedLifetime):
1599         * platform/graphics/chromium/cc/CCCompletionEvent.h:
1600         * storage/IDBObjectStoreBackendImpl.cpp:
1601         (WebCore::IDBObjectStoreBackendImpl::get):
1602         (WebCore::IDBObjectStoreBackendImpl::put):
1603         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1604         (WebCore::IDBObjectStoreBackendImpl::clear):
1605         (WebCore::IDBObjectStoreBackendImpl::createIndex):
1606         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
1607         (WebCore::IDBObjectStoreBackendImpl::openCursor):
1608         * storage/SQLCallbackWrapper.h:
1609         (WebCore::SQLCallbackWrapper::clear):
1610         * websockets/WorkerThreadableWebSocketChannel.cpp:
1611         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
1612         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
1613         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
1614         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
1615         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
1616         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
1617         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
1618         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
1619         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
1620         * workers/WorkerMessagingProxy.cpp:
1621         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
1622
1623 2011-04-27  Adam Barth  <abarth@webkit.org>
1624
1625         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
1626
1627         * page/Frame.cpp:
1628         (WebCore::Frame::setTiledBackingStoreEnabled):
1629         * platform/audio/ReverbConvolver.cpp:
1630         (WebCore::ReverbConvolver::ReverbConvolver):
1631
1632 2011-04-27  Adam Barth  <abarth@webkit.org>
1633
1634         Reviewed by David Levin.
1635
1636         Fix five strict PassOwnPtr violations in WebCore
1637         https://bugs.webkit.org/show_bug.cgi?id=59640
1638
1639         * css/MediaList.cpp:
1640         (WebCore::MediaList::deleteMedium):
1641         (WebCore::MediaList::setMediaText):
1642         (WebCore::MediaList::appendMedium):
1643         * css/MediaQuery.h:
1644         * dom/MessagePort.cpp:
1645         (WebCore::MessagePort::disentanglePorts):
1646         (WebCore::MessagePort::entanglePorts):
1647         * inspector/InspectorStyleSheet.cpp:
1648         (ParsedStyleSheet::setText):
1649         * rendering/RenderTheme.cpp:
1650         (WebCore::RenderTheme::adjustStyle):
1651         (WebCore::RenderTheme::adjustMeterStyle):
1652         * rendering/RenderThemeMac.mm:
1653         (WebCore::RenderThemeMac::adjustMenuListStyle):
1654         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1655         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1656         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1657         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1658         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1659         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1660         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1661
1662 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
1663
1664         Reviewed by Beth Dakin.
1665
1666         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
1667         https://bugs.webkit.org/show_bug.cgi?id=59648
1668
1669         Test: accessibility/aria-fallback-roles.html
1670
1671         * accessibility/AccessibilityObject.cpp:
1672         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
1673
1674 2011-04-27  Beth Dakin  <bdakin@apple.com>
1675
1676         Reviewed by Dan Bernstein.
1677
1678         https://bugs.webkit.org/show_bug.cgi?id=59671
1679         Race condition with scrollbar animations and closing a page can cause a crash in 
1680         WebCore::FrameView::setVisibleScrollerThumbRect + 15
1681         -and corresponding-
1682         <rdar://problem/9329253>
1683
1684         It is definitely possible for Page to be null here. So we should null-check it! 
1685         And we should not ASSERT.
1686         * page/FrameView.cpp:
1687         (WebCore::FrameView::didCompleteRubberBand):
1688         (WebCore::FrameView::scrollbarStyleChanged):
1689         (WebCore::FrameView::setVisibleScrollerThumbRect):
1690
1691 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1692
1693         WinCE build fix after r85143.
1694
1695         * platform/graphics/wince/FontWinCE.cpp:
1696         (WebCore::TextRunComponent::TextRunComponent):
1697
1698 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1699
1700         Reviewed by Tony Chang.
1701
1702         IndexedDB object store delete should fail if key is null
1703         https://bugs.webkit.org/show_bug.cgi?id=58614
1704
1705         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1706
1707         * storage/IDBObjectStoreBackendImpl.cpp:
1708         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1709
1710 2011-04-27  Eric Seidel  <eric@webkit.org>
1711
1712         Reviewed by Ryosuke Niwa.
1713
1714         Should have an easy way to construct starting BidiStatus for a paragraph root
1715         https://bugs.webkit.org/show_bug.cgi?id=59226
1716
1717         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1718         I've made this a constructor for BidiStatus instead.
1719
1720         As part of this effort I added a direction() accessor for TextRun and got
1721         rid of the old m_rtl bool.  This is part of the generic effort in the
1722         Bidi code to replace old bool usage with the superior TextDirection enum
1723         (this generally makes the code cleaner).
1724
1725         As part of this replacement effort I found several places which were
1726         assuming LTR (by passing rtl=false) when they probably want to use
1727         the current text direction.  I suspect that LTR vs. RTL may affect
1728         string width in the case of ligatures.  It's unclear.
1729
1730         This is almost entirely a mechanical change.
1731
1732         * html/canvas/CanvasRenderingContext2D.cpp:
1733         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1734         * platform/graphics/GraphicsContext.cpp:
1735         (WebCore::GraphicsContext::drawBidiText):
1736         * platform/graphics/TextRun.h:
1737         (WebCore::TextRun::TextRun):
1738         (WebCore::TextRun::direction):
1739         (WebCore::TextRun::rtl):
1740         (WebCore::TextRun::ltr):
1741         (WebCore::TextRun::setDirection):
1742         * platform/text/BidiResolver.h:
1743         (WebCore::BidiStatus::BidiStatus):
1744         * rendering/EllipsisBox.cpp:
1745         (WebCore::EllipsisBox::paint):
1746         (WebCore::EllipsisBox::selectionRect):
1747         (WebCore::EllipsisBox::paintSelection):
1748         * rendering/InlineTextBox.cpp:
1749         (WebCore::InlineTextBox::selectionRect):
1750         (WebCore::InlineTextBox::paint):
1751         (WebCore::InlineTextBox::paintSelection):
1752         (WebCore::InlineTextBox::paintCompositionBackground):
1753         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1754         (WebCore::InlineTextBox::paintTextMatchMarker):
1755         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1756         (WebCore::InlineTextBox::offsetForPosition):
1757         (WebCore::InlineTextBox::positionForOffset):
1758         * rendering/RenderBlockLineLayout.cpp:
1759         (WebCore::RenderBlock::determineStartPosition):
1760         * rendering/RenderFileUploadControl.cpp:
1761         (WebCore::RenderFileUploadControl::paintObject):
1762         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1763         * rendering/RenderListBox.cpp:
1764         (WebCore::RenderListBox::updateFromElement):
1765         (WebCore::RenderListBox::paintItemForeground):
1766         * rendering/RenderTextControl.cpp:
1767         (WebCore::RenderTextControl::getAvgCharWidth):
1768         (WebCore::RenderTextControl::paintPlaceholder):
1769         * rendering/svg/SVGInlineTextBox.cpp:
1770         (WebCore::SVGInlineTextBox::constructTextRun):
1771         * rendering/svg/SVGTextMetrics.cpp:
1772         (WebCore::constructTextRun):
1773
1774 2011-04-27  Robert Hogan  <robert@webkit.org>
1775
1776         Reviewed by Adam Barth.
1777
1778         Allow shadowing of history object
1779         https://bugs.webkit.org/show_bug.cgi?id=55965
1780
1781         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1782                http/tests/history/cross-origin-replace-history-object.html
1783
1784         * page/DOMWindow.idl:
1785
1786 2011-04-27  James Robinson  <jamesr@chromium.org>
1787
1788         Reviewed by Kenneth Russell.
1789
1790         [chromium] Ensure compositing layers are up to date before entering doComposite
1791         https://bugs.webkit.org/show_bug.cgi?id=59159
1792
1793         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1794         GraphicsLayerClient::paintContents() implementations).
1795
1796         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1797         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1798         * platform/graphics/chromium/LayerChromium.cpp:
1799         (WebCore::LayerChromium::LayerChromium):
1800         (WebCore::LayerChromium::~LayerChromium):
1801         * platform/graphics/chromium/LayerRendererChromium.cpp:
1802         (WebCore::LayerRendererChromium::updateLayers):
1803         * platform/graphics/chromium/LayerRendererChromium.h:
1804           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1805
1806 2011-04-27  James Robinson  <jamesr@chromium.org>
1807
1808         Reviewed by Adam Barth.
1809
1810         Fix OwnPtr strict issues in chromium linux build
1811         https://bugs.webkit.org/show_bug.cgi?id=59664
1812
1813         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1814         (WebCore::ComplexTextController::getNormalizedTextRun):
1815         * platform/graphics/skia/ImageBufferSkia.cpp:
1816         (WebCore::ImageBuffer::ImageBuffer):
1817         * platform/graphics/skia/PlatformContextSkia.cpp:
1818         (WebCore::PlatformContextSkia::PlatformContextSkia):
1819
1820 2011-04-27  Chris Rogers  <crogers@google.com>
1821
1822         Reviewed by Kenneth Russell.
1823
1824         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1825         https://bugs.webkit.org/show_bug.cgi?id=59641
1826
1827         No new tests since audio API is not yet implemented.
1828
1829         * platform/audio/AudioBus.cpp:
1830         (WebCore::AudioBus::createBySampleRateConverting):
1831         (WebCore::AudioBus::createByMixingToMono):
1832
1833 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1834
1835         Motivated by Alexey Proskuryakov.
1836
1837         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1838         informative, since it confused Alexey and me.
1839
1840 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1841
1842         Reviewed by Sam Weinig.
1843
1844         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1845         https://bugs.webkit.org/show_bug.cgi?id=59646
1846
1847         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1848         a world, we need to clear all entries in the map for that world, since
1849         the finalizers that would otherwise clear those entries don't run. The
1850         simplest way to do this is just to make the world own the map.
1851         
1852         * bindings/js/DOMWrapperWorld.h:
1853         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1854         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1855         * bindings/js/JSCSSValueCustom.cpp:
1856         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1857         (WebCore::JSCSSValueOwner::finalize):
1858         * bindings/js/JSDOMBinding.h:
1859
1860 2011-04-27  Adam Barth  <abarth@webkit.org>
1861
1862         Reviewed by David Levin.
1863
1864         Fix OwnPtr issues in IndexedDB
1865         https://bugs.webkit.org/show_bug.cgi?id=59656
1866
1867         I didn't do an exhaustive review of this code, but I fixed the problems
1868         caught by turning on strict OwnPtr and all their antecedents.  This
1869         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1870         behavior change.
1871
1872         * platform/leveldb/LevelDBDatabase.cpp:
1873         (WebCore::LevelDBDatabase::LevelDBDatabase):
1874         (WebCore::LevelDBDatabase::open):
1875         (WebCore::LevelDBDatabase::createIterator):
1876         * platform/leveldb/LevelDBDatabase.h:
1877         * platform/leveldb/LevelDBIterator.cpp:
1878         (WebCore::LevelDBIterator::LevelDBIterator):
1879         * platform/leveldb/LevelDBIterator.h:
1880         * storage/IDBLevelDBBackingStore.cpp:
1881         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1882         (WebCore::IDBLevelDBBackingStore::open):
1883         (WebCore::getNewDatabaseId):
1884         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1885         (WebCore::getNewObjectStoreId):
1886         (WebCore::deleteRange):
1887         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1888         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1889         (WebCore::IDBLevelDBBackingStore::getIndexes):
1890         (WebCore::getNewIndexId):
1891         (WebCore::findGreatestKeyLessThan):
1892         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1893         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1894         (WebCore::findLastIndexKeyEqualTo):
1895         * storage/IDBLevelDBBackingStore.h:
1896
1897 2011-04-19  MORITA Hajime  <morrita@google.com>
1898
1899         Reviewed by Tony Chang.
1900
1901         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1902         https://bugs.webkit.org/show_bug.cgi?id=58113
1903
1904         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1905         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1906         * Now MarkerMapVectorPair is no longer used.
1907         
1908         No new tests, No behavior change.
1909
1910         * GNUmakefile.list.am:
1911         * WebCore.gypi:
1912         * WebCore.pro:
1913         * WebCore.vcproj/WebCore.vcproj:
1914         * WebCore.xcodeproj/project.pbxproj:
1915         * dom/DocumentMarker.h:
1916         * dom/DocumentMarkerController.cpp:
1917         (WebCore::DocumentMarkerController::addMarker):
1918         (WebCore::DocumentMarkerController::copyMarkers):
1919         (WebCore::DocumentMarkerController::removeMarkers):
1920         (WebCore::DocumentMarkerController::markerContainingPoint):
1921         (WebCore::DocumentMarkerController::markersForNode):
1922         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1923         (WebCore::DocumentMarkerController::removeMarkersFromList):
1924         (WebCore::DocumentMarkerController::repaintMarkers):
1925         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1926         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1927         (WebCore::DocumentMarkerController::shiftMarkers):
1928         (WebCore::DocumentMarkerController::setMarkersActive):
1929         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1930         (WebCore::DocumentMarkerController::showMarkers):
1931         * dom/DocumentMarkerController.h:
1932         * dom/RenderedDocumentMarker.h: Added.
1933         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1934         (WebCore::RenderedDocumentMarker::isRendered):
1935         (WebCore::RenderedDocumentMarker::contains):
1936         (WebCore::RenderedDocumentMarker::setRenderedRect):
1937         (WebCore::RenderedDocumentMarker::renderedRect):
1938         (WebCore::RenderedDocumentMarker::invalidate):
1939         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1940
1941 2011-04-27  James Robinson  <jamesr@chromium.org>
1942
1943         Unreviewed, rolling out r85112.
1944         http://trac.webkit.org/changeset/85112
1945         https://bugs.webkit.org/show_bug.cgi?id=59159
1946
1947         Broke mac compile
1948
1949         * page/FrameView.cpp:
1950         (WebCore::FrameView::updateCompositingLayers):
1951         * page/FrameView.h:
1952         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1953         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1954         * platform/graphics/chromium/LayerChromium.cpp:
1955         (WebCore::LayerChromium::LayerChromium):
1956         (WebCore::LayerChromium::~LayerChromium):
1957         * platform/graphics/chromium/LayerRendererChromium.cpp:
1958         (WebCore::LayerRendererChromium::updateLayers):
1959         * platform/graphics/chromium/LayerRendererChromium.h:
1960
1961 2011-04-27  Mark Rowe  <mrowe@apple.com>
1962
1963         Build fix.
1964
1965         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1966
1967 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1968
1969         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1970
1971         * platform/network/ResourceHandleClient.h:
1972
1973 2011-04-27  James Robinson  <jamesr@chromium.org>
1974
1975         Reviewed by Kenneth Russell.
1976
1977         [chromium] Ensure compositing layers are up to date before entering doComposite
1978         https://bugs.webkit.org/show_bug.cgi?id=59159
1979
1980         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1981         GraphicsLayerClient::paintContents() implementations).
1982
1983         * page/FrameView.cpp:
1984         (WebCore::FrameView::updateCompositingLayers):
1985             Add an optional CompositingUpdateType parameter.
1986         * page/FrameView.h:
1987         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1988         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1989         * platform/graphics/chromium/LayerChromium.cpp:
1990         (WebCore::LayerChromium::LayerChromium):
1991         (WebCore::LayerChromium::~LayerChromium):
1992         * platform/graphics/chromium/LayerRendererChromium.cpp:
1993         (WebCore::LayerRendererChromium::updateLayers):
1994         * platform/graphics/chromium/LayerRendererChromium.h:
1995           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1996         * rendering/RenderLayer.cpp:
1997         (WebCore::RenderLayer::dirtyZOrderLists):
1998         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1999         * rendering/RenderLayerCompositor.cpp:
2000         (WebCore::RenderLayerCompositor::updateCompositingLayers):
2001         * rendering/RenderLayerCompositor.h:
2002           Fix a typo in CompositingUpdateType Pait->Paint
2003
2004 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2005
2006         Reviewed by Antti Koivisto.
2007
2008         Part of WebCore should use CFNetwork-based loader on Mac
2009         https://bugs.webkit.org/show_bug.cgi?id=51836
2010
2011         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
2012         willCacheResponse/shouldCacheResponse.
2013
2014         * loader/EmptyClients.h:
2015         * loader/FrameLoaderClient.h:
2016         * loader/ResourceLoader.h:
2017         * loader/cf/ResourceLoaderCFNet.cpp:
2018         * loader/mac/ResourceLoaderMac.mm:
2019         (WebCore::ResourceLoader::willCacheResponse):
2020         * platform/network/ResourceHandleClient.h:
2021         (WebCore::ResourceHandleClient::willCacheResponse):
2022         (WebCore::ResourceHandleClient::shouldCacheResponse):
2023         * platform/network/cf/ResourceHandleCFNet.cpp:
2024         (WebCore::willCacheResponse):
2025
2026 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
2027
2028         Reviewed by Brian Weinstein.
2029
2030         Web Inspector: Stop on Exception state does not persist.
2031
2032         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
2033         https://bugs.webkit.org/show_bug.cgi?id=59630
2034
2035         * inspector/front-end/ScriptsPanel.js:
2036         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
2037         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
2038         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2039
2040 2011-04-27  Adrienne Walker  <enne@google.com>
2041
2042         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
2043         https://bugs.webkit.org/show_bug.cgi?id=59020
2044
2045         * platform/graphics/chromium/LayerRendererChromium.cpp:
2046         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2047
2048 2011-04-27  Darin Adler  <darin@apple.com>
2049
2050         Reviewed by David Levin.
2051
2052         Fix strict OwnPtr issues seen in about 30 more files
2053         https://bugs.webkit.org/show_bug.cgi?id=59615
2054
2055         * bindings/js/JSCallbackData.h:
2056         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
2057         * bindings/js/JSMessageEventCustom.cpp:
2058         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
2059         * css/CSSParser.cpp:
2060         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
2061         adoptPtr, and release.
2062         * dom/MessageEvent.cpp:
2063         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
2064         and release.
2065         * dom/MessagePortChannel.cpp:
2066         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
2067         * dom/ScriptExecutionContext.cpp:
2068         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
2069         * dom/XMLDocumentParserLibxml2.cpp:
2070         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
2071         * dom/default/PlatformMessagePortChannel.cpp:
2072         (WebCore::MessagePortChannel::create): Use adoptPtr.
2073         * html/HTMLFormControlElement.cpp:
2074         (WebCore::HTMLFormControlElement::detach): Use nullptr.
2075         * inspector/InspectorAgent.cpp:
2076         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
2077         * inspector/InspectorConsoleAgent.cpp:
2078         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
2079         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
2080         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
2081         * inspector/InspectorController.cpp:
2082         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
2083         * inspector/InspectorDOMAgent.cpp:
2084         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
2085         * inspector/InspectorResourceAgent.cpp:
2086         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
2087         * page/FrameActionScheduler.cpp:
2088         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
2089         * platform/graphics/ShadowBlur.cpp:
2090         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
2091         * platform/graphics/ca/GraphicsLayerCA.cpp:
2092         (WebCore::GraphicsLayer::create): Use adoptPtr.
2093         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
2094         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
2095         * rendering/RenderBlock.cpp:
2096         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
2097         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
2098         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
2099         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
2100         * rendering/RenderLayerBacking.cpp:
2101         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
2102         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
2103         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
2104         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
2105         * rendering/RenderLayerCompositor.cpp:
2106         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
2107         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
2108         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
2109         * rendering/style/StyleRareNonInheritedData.cpp:
2110         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
2111         explicit initializations of OwnPtr members to 0. Use adoptPtr.
2112         * workers/SharedWorkerContext.cpp:
2113         (WebCore::createConnectEvent): Use adoptPtr.
2114         * workers/Worker.cpp:
2115         (WebCore::Worker::notifyFinished): Use nullptr.
2116
2117 2011-04-27  Enrica Casucci  <enrica@apple.com>
2118
2119         Reviewed by Darin Adler.
2120
2121         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
2122         https://bugs.webkit.org/show_bug.cgi?id=59251
2123         <rdar://problem/9327044>
2124
2125         When we are looking for wrapping elements that are presentational, we should
2126         include elements that have a non transparent background color only if they
2127         are not blocks.
2128
2129         Test: editing/pasteboard/do-not-copy-body-color.html
2130
2131         * editing/markup.cpp:
2132         (WebCore::isElementPresentational):
2133
2134 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
2135
2136         Reviewed by Antti Koivisto.
2137
2138         Teach sub-selector chains about shadow descendants
2139         https://bugs.webkit.org/show_bug.cgi?id=58342
2140
2141         The primary change is to the logic of parsing specifiers:
2142         1) The shadow descendant selectors (those specifiers that are unknown
2143         pseudo element selectors) are always kept at the top of the chain.
2144         2) The sub-selectors after shadow descendant selectors are stashed right
2145         behind the sub-selector, but not at the end of the chain.
2146         3) Other sub-selectors are appended at the end of the chain.
2147
2148         * css/CSSGrammar.y: Changed specifier_list collection to use new
2149             CSSParser::updateSpecifier helper.
2150         * css/CSSParser.cpp:
2151         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
2152             look for the last ShadowDescendant relation in the chain of selectors,
2153             because the next selector after it is the one that should get the
2154             element name.
2155         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
2156             CSSGrammar.y. The new logic adjusts the selector chain to allow
2157             shadow descendant selectors have sub-selectors (and have multiple shadow
2158             descendants in the chain).
2159         * css/CSSParser.h: Added decl.
2160         * css/CSSParserValues.cpp:
2161         (WebCore::CSSParserSelector::insertTagHistory): Added.
2162         (WebCore::CSSParserSelector::appendTagHistory): Aded.
2163         * css/CSSParserValues.h: Added decls.
2164         * css/CSSStyleSelector.cpp:
2165         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
2166             shadow descendant selector match check, since now there could be many
2167             of them in the selector chain.
2168
2169 2011-04-20  Adrienne Walker  <enne@google.com>
2170
2171         Reviewed by Kenneth Russell.
2172
2173         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
2174         https://bugs.webkit.org/show_bug.cgi?id=59020
2175
2176         mapRect is the incorrect transform here.  The parent scissor rect
2177         needs to be projected into layer space instead.
2178
2179         Test: compositing/flat-with-transformed-child.html
2180
2181         * platform/graphics/chromium/LayerRendererChromium.cpp:
2182         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2183
2184 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2185
2186         Reviewed by Antti Koivisto.
2187
2188         Part of WebCore should use CFNetwork-based loader on Mac
2189         https://bugs.webkit.org/show_bug.cgi?id=51836
2190
2191         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
2192         * platform/mac/SoftLinking.h:
2193         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
2194
2195 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
2196
2197         Reviewed by Antti Koivisto.
2198
2199         Cleanup CSSStyleApplyProperty.cpp
2200         https://bugs.webkit.org/show_bug.cgi?id=59623
2201
2202         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
2203         Use typedefs instead of repating the function pointer declarations in a few places.
2204
2205         * css/CSSStyleApplyProperty.cpp:
2206         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
2207         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
2208         (WebCore::ApplyPropertyColor::applyInheritValue):
2209         (WebCore::ApplyPropertyColor::applyInitialValue):
2210         (WebCore::ApplyPropertyColor::applyValue):
2211         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2212
2213 2011-04-27  Dan Bernstein  <mitz@apple.com>
2214
2215         Reviewed by Anders Carlsson.
2216
2217         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
2218         https://bugs.webkit.org/show_bug.cgi?id=59622
2219
2220         Test: fast/borders/border-image-trumps-radius.html
2221
2222         * rendering/RenderBox.cpp:
2223         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
2224         image, then border radius is ignored, so no bleed avoidance is needed.
2225         * rendering/RenderObject.cpp:
2226         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
2227         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
2228         * rendering/RenderObject.h:
2229
2230 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2231
2232         Reviewed by Xan Lopez.
2233
2234         [GTK] editing/pasteboard/copy-standalone-image.html fails
2235         https://bugs.webkit.org/show_bug.cgi?id=53645
2236
2237         When writing an image to the clipboard, also write the URL and title
2238         into the markup and URL portion. This change also abstracts a helper
2239         imageToMarkup into markup.{cpp/h} from several different locations
2240         throughout the platform layer.
2241
2242         * editing/markup.h: Added new function definition.
2243         * editing/markup.cpp:
2244         (WebCore::imageToMarkup): Add this function which turns an image URL 
2245         and element into some markup representing that image, while preserving
2246         non-src attributes.
2247         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
2248         to markup.cpp.
2249         * platform/gtk/PasteboardGtk.cpp:
2250         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
2251         image URL for a variety of image tag types.
2252         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
2253         markup and URL portions of the clipboard. This will ensure that images
2254         paste properly back into WebKit.
2255         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
2256         one from markup.h
2257
2258 2011-04-27  Steve Block  <steveblock@google.com>
2259
2260         Reviewed by David Levin.
2261
2262         Remove Android build system
2263         https://bugs.webkit.org/show_bug.cgi?id=48111
2264
2265         This is to avoid the maintenance burden until the Android port is
2266         fully upstreamed.
2267
2268         No new tests, build change only.
2269
2270         * Android.derived.jscbindings.mk: Removed.
2271         * Android.derived.mk: Removed.
2272         * Android.derived.v8bindings.mk: Removed.
2273         * Android.jscbindings.mk: Removed.
2274         * Android.mk: Removed.
2275         * Android.v8bindings.mk: Removed.
2276
2277 2011-04-27  Darin Adler  <darin@apple.com>
2278
2279         Reviewed by Sam Weinig.
2280
2281         Somehow about:blank gets into the icon database
2282         https://bugs.webkit.org/show_bug.cgi?id=58067
2283         rdar://problem/6751446
2284
2285         Implemented the policy Brady suggested, where only http and https URLs can
2286         be associated with and icon, guarding both on the way in to the database,
2287         and on the way out.
2288
2289         * loader/icon/IconDatabase.cpp:
2290         (WebCore::pageCanHaveIcon): Added.
2291         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
2292         instead of just checking for an empty URL.
2293         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
2294         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
2295         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
2296         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
2297         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
2298         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
2299         two separate assertions and added a third.
2300         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
2301
2302         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
2303         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
2304         overloaded it to work on both UChar and char, and added an assertion to it.
2305         Also moved this to the top of the file and made the UChar version usable
2306         in the shared code used even by Google.
2307         (WebCore::KURL::invalidate): Updated for name change.
2308         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
2309         toASCIILower since it's faster.
2310         (WebCore::KURL::parse): Updated for name changes.
2311         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
2312         since it's faster.
2313         (WebCore::protocolIsInHTTPFamily): Added.
2314
2315         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
2316         to protocolIsInHTTPFamily and added a version that works on a string.
2317         Kept the old name as an inline function so we don't have to rename
2318         all the cal sites now.
2319
2320         * platform/KURLGoogle.cpp: Renamed as above.
2321         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
2322         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
2323         (WebCore::KURLGooglePrivate::setAscii): Ditto.
2324         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
2325         (WebCore::KURLGooglePrivate::copyTo): Ditto.
2326         (WebCore::KURL::KURL): Ditto.
2327         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
2328         (WebCore::KURL::invalidate): Ditto.
2329         * platform/KURLGooglePrivate.h: Ditto.
2330
2331         * WebCore.exp.in: Updated for above changes.
2332
2333 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2334
2335         Reviewed by Pavel Feldman.
2336
2337         Web Inspector: browser crash on evaluation of 'throw undefined'
2338         https://bugs.webkit.org/show_bug.cgi?id=59611
2339
2340         Test: inspector/console/console-eval-throw-undefined.html
2341
2342         * inspector/InjectedScriptSource.js: use try/catch to protect from
2343         exception during conversion of another exception to string.
2344
2345 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2346
2347         Reviewed by Yury Semikhatsky.
2348
2349         Web Inspector: clicking bookmarklet multiplies resources panel entries.
2350         https://bugs.webkit.org/show_bug.cgi?id=59590
2351
2352         * inspector/front-end/ResourceTreeModel.js:
2353         (WebInspector.ResourceTreeModel):
2354         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2355         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2356         * inspector/front-end/ResourcesPanel.js:
2357         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2358         (WebInspector.FrameTreeElement):
2359         (WebInspector.FrameTreeElement.prototype.appendResource):
2360         * inspector/front-end/inspector.js:
2361         (WebInspector.frontendReused):
2362
2363 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2364
2365         Reviewed by Yury Semikhatsky.
2366
2367         Web Inspector: opening bookmarklet disconnects DOM agent.
2368         https://bugs.webkit.org/show_bug.cgi?id=59588
2369
2370         * inspector/InspectorDOMAgent.cpp:
2371         (WebCore::InspectorDOMAgent::setDocument):
2372
2373 2011-04-27  Hans Wennborg  <hans@chromium.org>
2374
2375         Reviewed by Tony Gentilcore.
2376
2377         IndexedDB: Fix compiler warnings about uninitialized variables
2378         https://bugs.webkit.org/show_bug.cgi?id=59599
2379
2380         Build fix. No new tests.
2381
2382         * storage/IDBLevelDBBackingStore.cpp:
2383         (WebCore::getNewObjectStoreId):
2384         (WebCore::getNewIndexId):
2385
2386 2011-04-26  Hans Wennborg  <hans@chromium.org>
2387
2388         Reviewed by Tony Gentilcore.
2389
2390         IndexedDB: Move LevelDB key coding routines to separate file
2391         https://bugs.webkit.org/show_bug.cgi?id=59452
2392
2393         Move all routines concerned with encoding, decoding and comparison of
2394         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
2395         IDBLevelDBCoding.cpp.
2396
2397         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
2398         allow for unit testing of the coding routines.
2399
2400         No new functionality, no new tests.
2401
2402         * WebCore.gypi:
2403         * storage/IDBLevelDBBackingStore.cpp:
2404         (WebCore::getInt):
2405         (WebCore::putInt):
2406         (WebCore::getString):
2407         (WebCore::putString):
2408         (WebCore::compareKeys):
2409         (WebCore::compareIndexKeys):
2410         (WebCore::Comparator::compare):
2411         (WebCore::setUpMetadata):
2412         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
2413         (WebCore::getNewDatabaseId):
2414         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
2415         (WebCore::IDBLevelDBBackingStore::getObjectStores):
2416         (WebCore::getNewObjectStoreId):
2417         (WebCore::IDBLevelDBBackingStore::createObjectStore):
2418         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
2419         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
2420         (WebCore::getNewVersionNumber):
2421         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
2422         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
2423         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
2424         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
2425         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
2426         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
2427         (WebCore::IDBLevelDBBackingStore::getIndexes):
2428         (WebCore::getNewIndexId):
2429         (WebCore::IDBLevelDBBackingStore::createIndex):
2430         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
2431         (WebCore::versionExists):
2432         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
2433         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
2434         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
2435         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
2436         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
2437         * storage/IDBLevelDBCoding.cpp: Added.
2438         (WebCore::IDBLevelDBCoding::encodeByte):
2439         (WebCore::IDBLevelDBCoding::maxIDBKey):
2440         (WebCore::IDBLevelDBCoding::minIDBKey):
2441         (WebCore::IDBLevelDBCoding::encodeInt):
2442         (WebCore::IDBLevelDBCoding::decodeInt):
2443         (WebCore::IDBLevelDBCoding::encodeVarInt):
2444         (WebCore::IDBLevelDBCoding::decodeVarInt):
2445         (WebCore::IDBLevelDBCoding::encodeString):
2446         (WebCore::IDBLevelDBCoding::decodeString):
2447         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
2448         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
2449         (WebCore::IDBLevelDBCoding::encodeDouble):
2450         (WebCore::IDBLevelDBCoding::decodeDouble):
2451         (WebCore::IDBLevelDBCoding::encodeIDBKey):
2452         (WebCore::IDBLevelDBCoding::decodeIDBKey):
2453         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
2454         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
2455         (WebCore::IDBLevelDBCoding::compare):
2456         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
2457         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
2458         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
2459         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
2460         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
2461         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
2462         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
2463         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
2464         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
2465         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
2466         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
2467         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
2468         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
2469         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
2470         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
2471         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
2472         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
2473         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
2474         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
2475         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
2476         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
2477         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
2478         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
2479         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
2480         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
2481         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
2482         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
2483         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
2484         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
2485         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
2486         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
2487         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
2488         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
2489         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
2490         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
2491         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
2492         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
2493         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
2494         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
2495         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
2496         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
2497         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
2498         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
2499         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
2500         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
2501         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
2502         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
2503         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
2504         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
2505         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
2506         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
2507         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
2508         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
2509         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
2510         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
2511         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
2512         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
2513         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
2514         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
2515         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
2516         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
2517         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
2518         * storage/IDBLevelDBCoding.h: Added.
2519         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
2520         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
2521         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
2522         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
2523         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
2524
2525 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
2526
2527         Reviewed by Pavel Feldman.
2528
2529         Web Inspector: expose exception details when script is paused on exception
2530         https://bugs.webkit.org/show_bug.cgi?id=59591
2531
2532         When script is paused on an exception, the exception value is added as <exception>
2533         property in the local scope and the breakpoint details message says
2534         "Paused on excepion: '<exception to strin value>'."
2535
2536         * English.lproj/localizedStrings.js:
2537         * inspector/front-end/ScopeChainSidebarPane.js:
2538         (WebInspector.ScopeChainSidebarPane.prototype.update):
2539         * inspector/front-end/ScriptsPanel.js:
2540         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
2541         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
2542
2543 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
2544
2545         Reviewed by Pavel Feldman.
2546
2547         Web Inspector: [protocol] Paused event should expose exception value that caused it
2548         https://bugs.webkit.org/show_bug.cgi?id=58996
2549
2550         Debug.pause event now contains an optional reference to the exception
2551         object in case script execution is paused on a JavaScript exception.
2552
2553         Also JavaScript call frames are passed directly into the injected script when
2554         we need to wrap them for passing to the front-end. This change breaks cyclic
2555         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
2556
2557         * bindings/js/JSInjectedScriptHostCustom.cpp:
2558         * bindings/js/ScriptDebugServer.cpp:
2559         (WebCore::ScriptDebugServer::dispatchDidPause):
2560         * bindings/js/ScriptDebugServer.h:
2561         * bindings/v8/ScriptDebugServer.cpp:
2562         (WebCore::ScriptDebugServer::breakProgram):
2563         (WebCore::ScriptDebugServer::editScriptSource):
2564         (WebCore::ScriptDebugServer::breakProgramCallback):
2565         (WebCore::ScriptDebugServer::handleV8DebugEvent):
2566         * bindings/v8/ScriptDebugServer.h:
2567         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2568         * inspector/InjectedScript.cpp:
2569         (WebCore::InjectedScript::evaluateOnCallFrame):
2570         (WebCore::InjectedScript::wrapCallFrames):
2571         * inspector/InjectedScript.h:
2572         * inspector/InjectedScriptHost.cpp:
2573         * inspector/InjectedScriptHost.h:
2574         (WebCore::InjectedScriptHost::init):
2575         * inspector/InjectedScriptHost.idl:
2576         * inspector/InjectedScriptSource.js:
2577         (.):
2578         * inspector/Inspector.json:
2579         * inspector/InspectorAgent.cpp:
2580         (WebCore::InspectorAgent::InspectorAgent):
2581         * inspector/InspectorDebuggerAgent.cpp:
2582         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2583         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2584         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
2585         (WebCore::InspectorDebuggerAgent::didPause):
2586         (WebCore::InspectorDebuggerAgent::didContinue):
2587         (WebCore::InspectorDebuggerAgent::clear):
2588         * inspector/InspectorDebuggerAgent.h:
2589         * inspector/ScriptDebugListener.h:
2590         * inspector/WorkerInspectorController.cpp:
2591         (WebCore::WorkerInspectorController::WorkerInspectorController):
2592
2593 2011-04-27  Pavel Feldman  <pfeldman@google.com>
2594
2595         Reviewed by Yury Semikhatsky.
2596
2597         Web Inspector: implement incremental CSS editing in the structure view.
2598         https://bugs.webkit.org/show_bug.cgi?id=59455
2599
2600         * inspector/front-end/StylesSidebarPane.js:
2601         (WebInspector.StylePropertyTreeElement.prototype):
2602
2603 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
2604
2605         Reviewed by Eric Seidel.
2606
2607         Frame.h shouldn't include Document.h
2608         https://bugs.webkit.org/show_bug.cgi?id=59560
2609
2610         Frame can use a forward-declared Document if we move
2611         Frame::displayStringModifiedByEncoding's implementation out of the
2612         header.
2613                                 Size  #includes  Size * #includes
2614         Before: page/Frame.h:   0.746       653           487.138
2615                 dom/Document.h: 0.220      1306           287.320
2616         
2617         After:  page/Frame.h:   0.646       653           421.838
2618                 dom/Document.h: 0.220      1189           261.580
2619
2620         * WebCore.exp.in:
2621         * bindings/ScriptControllerBase.cpp:
2622         * bindings/generic/BindingSecurityBase.cpp:
2623         * bindings/v8/V8Proxy.cpp:
2624         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
2625         * dom/CharacterData.cpp:
2626         * dom/UserTypingGestureIndicator.cpp:
2627         * editing/chromium/SelectionControllerChromium.cpp:
2628         * inspector/InspectorDOMStorageResource.cpp:
2629         * inspector/InspectorInstrumentation.h:
2630         * loader/PingLoader.cpp:
2631         * loader/SubresourceLoader.cpp:
2632         * loader/appcache/DOMApplicationCache.cpp:
2633         * loader/cache/CachedResourceRequest.cpp:
2634         * page/Frame.cpp:
2635         (WebCore::Frame::displayStringModifiedByEncoding):
2636         * page/Frame.h:
2637         * page/Geolocation.cpp:
2638         * page/Location.cpp:
2639         * page/Navigator.cpp:
2640         * page/PageGroupLoadDeferrer.cpp:
2641         * page/PerformanceTiming.cpp:
2642         * xml/XSLTProcessorLibxslt.cpp:
2643
2644 2011-04-27  James Robinson  <jamesr@chromium.org>
2645
2646         Reviewed by Eric Seidel.
2647
2648         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2649         https://bugs.webkit.org/show_bug.cgi?id=59377
2650
2651         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
2652         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
2653
2654         * css/CSSStyleSelector.cpp:
2655         (WebCore::CSSStyleSelector::applyProperty):
2656         * page/animation/AnimationBase.cpp:
2657         (WebCore::blendFunc):
2658         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2659         (WebCore::PropertyWrapperShadow::blend):
2660         * rendering/style/RenderStyle.cpp:
2661         (WebCore::RenderStyle::setTextShadow):
2662         (WebCore::RenderStyle::setBoxShadow):
2663         * rendering/style/RenderStyle.h:
2664         (WebCore::InheritedFlags::textShadow):
2665         * rendering/style/ShadowData.cpp:
2666         (WebCore::ShadowData::ShadowData):
2667         * rendering/style/ShadowData.h:
2668         (WebCore::ShadowData::ShadowData):
2669         (WebCore::ShadowData::next):
2670         (WebCore::ShadowData::setNext):
2671         * rendering/style/StyleRareInheritedData.cpp:
2672         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2673         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2674         * rendering/style/StyleRareInheritedData.h:
2675         * rendering/style/StyleRareNonInheritedData.cpp:
2676         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2677
2678 2011-04-26  David Levin  <levin@chromium.org>
2679
2680         Reviewed by Eric Seidel.
2681
2682         Fix some strict PassOwnPtr issues in WebCore.
2683         https://bugs.webkit.org/show_bug.cgi?id=59563
2684
2685         * css/SVGCSSStyleSelector.cpp:
2686         (WebCore::CSSStyleSelector::applySVGProperty):
2687         * html/canvas/WebGLRenderingContext.cpp:
2688         (WebCore::WebGLRenderingContext::create):
2689         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2690         * platform/text/TextCodecLatin1.cpp:
2691         (WebCore::newStreamingTextDecoderWindowsLatin1):
2692         * platform/text/TextCodecUTF16.cpp:
2693         (WebCore::newStreamingTextDecoderUTF16LE):
2694         (WebCore::newStreamingTextDecoderUTF16BE):
2695         * platform/text/TextCodecUserDefined.cpp:
2696         (WebCore::newStreamingTextDecoderUserDefined):
2697         * platform/text/mac/TextCodecMac.cpp:
2698         (WebCore::newTextCodecMac):
2699         * workers/Worker.cpp:
2700         (WebCore::Worker::notifyFinished):
2701
2702 2011-04-26  Justin Novosad  <junov@chromium.org>
2703
2704         Reviewed by Kenneth Russell.
2705
2706         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2707         https://bugs.webkit.org/show_bug.cgi?id=58683
2708         Replace the SKIA_GPU compile flag by the pre-existing
2709         acceleratedDrawingEnabled flag. Most code changes are trivial:
2710         compile-time conditionals on SKIA_GPU were either replaced with
2711         a run-time check, or a compile time check on USE(SKIA) 
2712
2713         No new tests. Covered by existing tests.
2714
2715         * html/canvas/CanvasRenderingContext2D.cpp:
2716         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2717         * page/Page.cpp:
2718         (WebCore::Page::sharedGraphicsContext3D):
2719         Added check for the acceleratedDrawing flag.
2720         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2721         (WebCore::DrawingBuffer::DrawingBuffer):
2722         (WebCore::DrawingBuffer::publishToPlatformLayer):
2723         * platform/graphics/gpu/DrawingBuffer.h:
2724         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2725         (WebCore::SharedGraphicsContext3D::create):
2726         On Skia builds, this methos now receives a bool arg to turn on
2727         GPU-accelerated skia rendering
2728         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2729         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2730         (WebCore::SharedGraphicsContext3D::grContext):
2731         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2732         * platform/graphics/skia/ImageSkia.cpp:
2733         (WebCore::computeResamplingMode):
2734         (WebCore::paintSkBitmap):
2735         (WebCore::Image::drawPattern):
2736         * platform/graphics/skia/PlatformContextSkia.cpp:
2737         (WebCore::PlatformContextSkia::PlatformContextSkia):
2738         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2739         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2740         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2741         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2742         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2743         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2744         (WebCore::PlatformContextSkia::markDirtyRect):
2745         * platform/graphics/skia/PlatformContextSkia.h:
2746         (WebCore::PlatformContextSkia::accelerationMode):
2747         (WebCore::PlatformContextSkia::useGPU):
2748         (WebCore::PlatformContextSkia::useSkiaGPU):
2749
2750 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2751
2752         Not reviewed: restore inspector test disabled in r84913.
2753
2754         Test: http/tests/inspector-enabled/dom-storage-open.html
2755
2756         * inspector/InspectorDOMStorageAgent.cpp:
2757         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2758
2759 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2760
2761         Reviewed by Tony Chang.
2762
2763         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2764         https://bugs.webkit.org/show_bug.cgi?id=59182
2765
2766         Use vertical offsets of the shaping results.
2767
2768         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2769
2770         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2771         (WebCore::ComplexTextController::ComplexTextController):
2772         Added initialization of m_startingY.
2773         (WebCore::ComplexTextController::nextScriptRun):
2774         Followed the change in handling positions.
2775         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2776         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2777         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2778         (WebCore::ComplexTextController::setGlyphPositions):
2779         Changed to use vertical offsets as same as horizontal offsets.
2780         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2781         Removed m_xPositions and Added m_positions and m_startingY.
2782         (WebCore::ComplexTextController::positions): Added.
2783         * platform/graphics/chromium/FontLinux.cpp:
2784         Followed the change in ComplexTextController.
2785         (WebCore::Font::drawComplexText): Ditto.
2786         (WebCore::Font::floatWidthForComplexText): Ditto.
2787         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2788         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2789         (WebCore::Font::selectionRectForComplexText): Ditto.
2790
2791 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2792
2793         Reviewed by Eric Seidel.
2794
2795         Root element should establish a new block formatting context
2796         https://bugs.webkit.org/show_bug.cgi?id=54573
2797
2798         Always expanding the root renderer to include overhanging floats.
2799
2800         Test: fast/block/float/float-overhangs-root.html
2801
2802         * rendering/RenderBlock.cpp:
2803         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2804
2805 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2806
2807         Reviewed by Andreas Kling.
2808
2809         [Qt] Improper rendering of <button> tag when it contains a <br>
2810         https://bugs.webkit.org/show_bug.cgi?id=50521
2811
2812         Test: platform/qt/fast/forms/button-line-break.html
2813
2814         * platform/qt/RenderThemeQt.cpp:
2815         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2816         (WebCore::RenderThemeQt::setButtonPadding):
2817
2818 2011-04-26  James Robinson  <jamesr@chromium.org>
2819
2820         Reviewed by Kenneth Russell.
2821
2822         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2823         https://bugs.webkit.org/show_bug.cgi?id=59572
2824
2825         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2826         when LayerRendererChromium was set.  We set this pointer every frame
2827         and should only reset the tiles if the new LayerRendererChromium is
2828         different from the old one (indicating a context loss), not just reset
2829         on every frame.
2830
2831         * platform/graphics/chromium/LayerTilerChromium.cpp:
2832         (WebCore::LayerTilerChromium::setLayerRenderer):
2833         * platform/graphics/chromium/LayerTilerChromium.h:
2834
2835 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2836
2837         Reviewed by Eric Seidel.
2838
2839         beginElement broken by setAttribute
2840         https://bugs.webkit.org/show_bug.cgi?id=26019
2841
2842         Test: svg/animations/animate-beginElementAt.svg
2843
2844         * svg/SVGAnimationElement.cpp:
2845         (WebCore::SVGAnimationElement::attributeChanged):
2846         Reset the animation state here as the rest of the code reads it and would still
2847         think we are animating when we are not.
2848
2849         * svg/animation/SVGSMILElement.h:
2850         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2851
2852 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2853
2854         Unreviewed, rolling out r84989.
2855         http://trac.webkit.org/changeset/84989
2856         https://bugs.webkit.org/show_bug.cgi?id=59566
2857
2858         REGRESSION (r84989): Lots of vertical text tests failing on
2859         windows (Requested by weinig on #webkit).
2860
2861         * platform/graphics/FontPlatformData.h:
2862         * platform/graphics/win/FontCacheWin.cpp:
2863         (WebCore::FontCache::getFontDataForCharacters):
2864         (WebCore::FontCache::createFontPlatformData):
2865         * platform/graphics/win/FontCustomPlatformData.cpp:
2866         (WebCore::FontCustomPlatformData::fontPlatformData):
2867         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2868         (WebCore::FontPlatformData::FontPlatformData):
2869         * platform/graphics/win/FontPlatformDataWin.cpp:
2870         (WebCore::FontPlatformData::FontPlatformData):
2871
2872 2011-04-26  Sam Weinig  <sam@webkit.org>
2873
2874         Reviewed by Eric Seidel.
2875
2876         Try again:
2877             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2878             https://bugs.webkit.org/show_bug.cgi?id=59310
2879
2880         * bindings/js/JSDOMBinding.h:
2881         (WebCore::DOMConstructorObject::DOMConstructorObject):
2882         * bindings/js/JSDOMWrapper.h:
2883         (WebCore::JSDOMWrapper::globalObject):
2884         (WebCore::JSDOMWrapper::scriptExecutionContext):
2885         (WebCore::JSDOMWrapper::createStructure):
2886         (WebCore::JSDOMWrapper::JSDOMWrapper):
2887         * bindings/scripts/CodeGeneratorJS.pm:
2888
2889 2011-04-26  Sam Weinig  <sam@webkit.org>
2890
2891         Reviewed by David Hyatt.
2892
2893         Remove Datagrid from the tree
2894         https://bugs.webkit.org/show_bug.cgi?id=59543
2895
2896         * Android.derived.jscbindings.mk:
2897         * Android.derived.v8bindings.mk:
2898         * Android.jscbindings.mk:
2899         * Android.v8bindings.mk:
2900         * CMakeLists.txt:
2901         * CodeGenerators.pri:
2902         * Configurations/FeatureDefines.xcconfig:
2903         * DerivedSources.cpp:
2904         * DerivedSources.make:
2905         * GNUmakefile.am:
2906         * GNUmakefile.list.am:
2907         * UseJSC.cmake:
2908         * WebCore.gypi:
2909         * WebCore.pro:
2910         * WebCore.vcproj/WebCore.vcproj:
2911         * WebCore.xcodeproj/project.pbxproj:
2912         * bindings/js/JSBindingsAllInOne.cpp:
2913         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2914         * bindings/js/JSDataGridDataSource.cpp: Removed.
2915         * bindings/js/JSDataGridDataSource.h: Removed.
2916         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2917         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2918         * bindings/v8/V8DataGridDataSource.h: Removed.
2919         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2920         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2921         * css/CSSStyleSelector.cpp:
2922         * css/CSSStyleSelector.h:
2923         * css/html.css:
2924         (input, textarea, keygen, select, button, isindex):
2925         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2926         * editing/htmlediting.cpp:
2927         (WebCore::canHaveChildrenForEditing):
2928         * features.pri:
2929         * html/DOMDataGridDataSource.cpp: Removed.
2930         * html/DOMDataGridDataSource.h: Removed.
2931         * html/DataGridColumn.cpp: Removed.
2932         * html/DataGridColumn.h: Removed.
2933         * html/DataGridColumn.idl: Removed.
2934         * html/DataGridColumnList.cpp: Removed.
2935         * html/DataGridColumnList.h: Removed.
2936         * html/DataGridColumnList.idl: Removed.
2937         * html/DataGridDataSource.h: Removed.
2938         * html/HTMLDataGridCellElement.cpp: Removed.
2939         * html/HTMLDataGridCellElement.h: Removed.
2940         * html/HTMLDataGridCellElement.idl: Removed.
2941         * html/HTMLDataGridColElement.cpp: Removed.
2942         * html/HTMLDataGridColElement.h: Removed.
2943         * html/HTMLDataGridColElement.idl: Removed.
2944         * html/HTMLDataGridElement.cpp: Removed.
2945         * html/HTMLDataGridElement.h: Removed.
2946         * html/HTMLDataGridElement.idl: Removed.
2947         * html/HTMLDataGridRowElement.cpp: Removed.
2948         * html/HTMLDataGridRowElement.h: Removed.
2949         * html/HTMLDataGridRowElement.idl: Removed.
2950         * html/HTMLElement.cpp:
2951         (WebCore::HTMLElement::ieForbidsInsertHTML):
2952         * html/HTMLElementsAllInOne.cpp:
2953         * html/HTMLTagNames.in:
2954         * page/DOMWindow.idl:
2955         * rendering/RenderBox.cpp:
2956         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2957         * rendering/RenderDataGrid.cpp: Removed.
2958         * rendering/RenderDataGrid.h: Removed.
2959         * rendering/RenderingAllInOne.cpp:
2960
2961 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2962
2963         Reviewed by Adele Peterson.
2964
2965         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2966         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2967
2968         This platform dependent patch makes WebKit (Windows) show the
2969         vertical writing text correctly.  Job was done by adding a prefix '@'
2970         in front of the font family name (Windows Only). No new tests added.
2971         Some layout tests images:
2972         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2973
2974         * platform/graphics/FontPlatformData.h:
2975         * platform/graphics/win/FontCacheWin.cpp:
2976         (WebCore::FontCache::getFontDataForCharacters):
2977         (WebCore::FontCache::createFontPlatformData):
2978         * platform/graphics/win/FontCustomPlatformData.cpp:
2979         (WebCore::FontCustomPlatformData::fontPlatformData):
2980         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2981         (WebCore::FontPlatformData::FontPlatformData):
2982         * platform/graphics/win/FontPlatformDataWin.cpp:
2983         (WebCore::FontPlatformData::FontPlatformData):
2984
2985 2011-04-26  Jer Noble  <jer.noble@apple.com>
2986
2987         Reviewed by Brady Eidson.
2988
2989         HTML5 video fullscreen transition causes an audio stutter
2990         https://bugs.webkit.org/show_bug.cgi?id=59544
2991
2992         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2993         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2994         layer to render it invisible, instead just set the layer as hidden.
2995
2996         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2997         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2998         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2999         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
3000         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
3001         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
3002
3003 2011-04-26  Christian Dywan  <christian@lanedo.com>
3004
3005         Reviewed by Eric Seidel.
3006
3007         Extra separator after Select All in context menu
3008         https://bugs.webkit.org/show_bug.cgi?id=54092
3009
3010         * page/ContextMenuController.cpp: Move separator to non-GTK+
3011             port guards since it is for the spelling options menu
3012             which the GTK+ port doesn't use.
3013
3014 2011-04-26  James Robinson  <jamesr@chromium.org>
3015
3016         Reviewed by Kenneth Russell.
3017
3018         [chromium] Clear out LayerTilerChromium's tiles on lost context
3019         https://bugs.webkit.org/show_bug.cgi?id=59233
3020
3021         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
3022         no longer valid since they exist in the previous LayerRendererChromium.
3023
3024         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
3025
3026         * platform/graphics/chromium/LayerTilerChromium.h:
3027         (WebCore::LayerTilerChromium::setLayerRenderer):
3028
3029 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
3030
3031         Reviewed by Dirk Schulze.
3032
3033         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
3034         https://bugs.webkit.org/show_bug.cgi?id=57644
3035
3036         Manual test: plugins/windowed-in-iframe-2.html
3037
3038         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
3039         * platform/gtk/WidgetGtk.cpp:
3040         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
3041         * plugins/PluginView.h: Added helper method to set the allocation and clip.
3042         * plugins/gtk/PluginViewGtk.cpp:
3043         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
3044         the allocation immediately. Bring this method into sync with the implementation in
3045         the Qt port.
3046         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
3047         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
3048
3049 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
3050
3051         Reviewed by Eric Seidel.
3052
3053         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
3054         https://bugs.webkit.org/show_bug.cgi?id=58818
3055
3056         Prevent allocating scratch buffers larger than the target GdkDrawable
3057         when creating a WidgetRenderingContext. This prevents incredibly large
3058         widgets from crashing the X Server. This change also allowed greatly
3059         simplifying the way that the painting offset is calculated.
3060
3061         * platform/gtk/WidgetRenderingContext.cpp:
3062         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
3063         larger than the target GdkDrawable.
3064         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
3065         blit by looking at the location of the target rect itself, rather than delaying the
3066         calculation up to this point.
3067         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
3068         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
3069         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
3070         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
3071         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
3072         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
3073         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
3074         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
3075         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
3076         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
3077         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
3078         a member to store the IntSize mapping from the coordinates of the target to the coordinates
3079         of the scratch buffer.
3080
3081 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
3082
3083         Reviewed by Adam Barth.
3084
3085         Respect charset in handleDataURL
3086         https://bugs.webkit.org/show_bug.cgi?id=47746
3087
3088         Original patch by Kwang Yul Seo <skyul@company100.net>
3089
3090         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
3091         returns an empty string because encoding name is not specified.
3092
3093         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
3094
3095         This change fixes over 130 layout tests when running GTK port with cURL network backend.
3096
3097         * platform/network/DataURL.cpp:
3098         (WebCore::handleDataURL):
3099
3100 2011-04-26  Anders Carlsson  <andersca@apple.com>
3101
3102         Fix clang++ build.
3103
3104         You can never have too many casts!
3105
3106         * accessibility/mac/AccessibilityObjectWrapper.mm:
3107         (-[AccessibilityObjectWrapper position]):
3108         * editing/mac/SelectionControllerMac.mm:
3109         (WebCore::accessibilityConvertScreenRect):
3110
3111 2011-04-26  Chris Rogers  <crogers@google.com>
3112
3113         Reviewed by Kenneth Russell.
3114
3115         Fix web audio build on mac port
3116         https://bugs.webkit.org/show_bug.cgi?id=59355
3117
3118         No new tests since audio API is not yet implemented.
3119
3120         * WebCore.xcodeproj/project.pbxproj:
3121         * bindings/js/JSAudioContextCustom.cpp:
3122         (WebCore::JSAudioContext::visitChildren):
3123         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
3124         (WebCore::JSJavaScriptAudioNode::visitChildren):
3125         * webaudio/AudioContext.idl:
3126
3127 2011-04-26  Chris Rogers  <crogers@google.com>
3128
3129         Reviewed by Kenneth Russell.
3130
3131         Add FFTFrame implementation for FFmpeg
3132         https://bugs.webkit.org/show_bug.cgi?id=59408
3133
3134         No new tests since audio API is not yet implemented.
3135
3136         * WebCore.gyp/WebCore.gyp:
3137         * WebCore.gypi:
3138         * platform/audio/FFTFrame.h:
3139         * platform/audio/FFTFrameStub.cpp:
3140         * platform/audio/ffmpeg: Added.
3141         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
3142         (WebCore::FFTFrame::FFTFrame):
3143         (WebCore::FFTFrame::initialize):
3144         (WebCore::FFTFrame::cleanup):
3145         (WebCore::FFTFrame::~FFTFrame):
3146         (WebCore::FFTFrame::multiply):
3147         (WebCore::FFTFrame::doFFT):
3148         (WebCore::FFTFrame::doInverseFFT):
3149         (WebCore::FFTFrame::realData):
3150         (WebCore::FFTFrame::imagData):
3151         (WebCore::FFTFrame::getUpToDateComplexData):
3152         (WebCore::FFTFrame::contextForSize):
3153         * platform/audio/mac/FFTFrameMac.cpp:
3154         * webaudio/ConvolverNode.cpp:
3155
3156 2011-04-26  Jeff Miller  <jeffm@apple.com>
3157
3158         Add a newline at the end of SVGFEDropShadowElement.idl.
3159
3160         * svg/SVGFEDropShadowElement.idl:
3161
3162 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3163
3164         Reviewed by Eric Seidel.
3165
3166         InlineBox.h shouldn't include RenderBR.h
3167         https://bugs.webkit.org/show_bug.cgi?id=59480
3168
3169         Per bug 59348 RenderBR.h is a "top header" by include * size, because
3170         InlineBox.h includes it. There's no reason why it has to.
3171
3172         * rendering/InlineBox.h:
3173         * rendering/InlineTextBox.cpp:
3174         * rendering/RenderBlock.h:
3175
3176 2011-04-26  Sam Weinig  <sam@webkit.org>
3177
3178         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
3179         I should do.
3180
3181         * bindings/js/JSDOMBinding.h:
3182         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3183         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3184         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3185         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3186         (WebCore::DOMConstructorObject::DOMConstructorObject):
3187         * bindings/js/JSDOMWrapper.h:
3188         (WebCore::JSDOMWrapper::JSDOMWrapper):
3189         * bindings/scripts/CodeGeneratorJS.pm:
3190
3191 2011-04-26  Sam Weinig  <sam@webkit.org>
3192
3193         Fix build.
3194
3195         * bindings/js/JSDOMWrapper.h:
3196         (WebCore::JSDOMWrapper::globalObject):
3197
3198 2011-04-26  Sam Weinig  <sam@webkit.org>
3199
3200         Roll r84945 back in with infinite recursion removed.
3201
3202         * bindings/js/JSDOMBinding.h:
3203         (WebCore::DOMConstructorObject::DOMConstructorObject):
3204         * bindings/js/JSDOMWrapper.h:
3205         (WebCore::JSDOMWrapper::globalObject):
3206         (WebCore::JSDOMWrapper::scriptExecutionContext):
3207         (WebCore::JSDOMWrapper::createStructure):
3208         (WebCore::JSDOMWrapper::JSDOMWrapper):
3209         * bindings/scripts/CodeGeneratorJS.pm:
3210
3211 2011-04-26  Sam Weinig  <sam@webkit.org>
3212
3213         Rollout previous patch. It broke stuff.
3214
3215         * bindings/js/JSDOMBinding.h:
3216         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
3217         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
3218         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
3219         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
3220         (WebCore::DOMConstructorObject::DOMConstructorObject):
3221         * bindings/js/JSDOMWrapper.h:
3222         (WebCore::JSDOMWrapper::JSDOMWrapper):
3223         * bindings/scripts/CodeGeneratorJS.pm:
3224
3225 2011-04-26  Sam Weinig  <sam@webkit.org>
3226
3227         Reviewed by Maciej Stachowiak.
3228
3229         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
3230         https://bugs.webkit.org/show_bug.cgi?id=59310
3231
3232         * bindings/js/JSDOMBinding.h:
3233         (WebCore::DOMConstructorObject::DOMConstructorObject):
3234         * bindings/js/JSDOMWrapper.h:
3235         (WebCore::JSDOMWrapper::globalObject):
3236         (WebCore::JSDOMWrapper::scriptExecutionContext):
3237         (WebCore::JSDOMWrapper::createStructure):
3238         (WebCore::JSDOMWrapper::JSDOMWrapper):
3239         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
3240
3241         * bindings/scripts/CodeGeneratorJS.pm:
3242         Make JSDOMWrapper the base class.
3243
3244 2011-04-26  Dan Bernstein  <mitz@apple.com>
3245
3246         Reviewed by Mark Rowe.
3247
3248         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
3249
3250         * Configurations/Base.xcconfig:
3251         * Configurations/CompilerVersion.xcconfig: Added.
3252
3253 2011-04-26  Adrienne Walker  <enne@google.com>
3254
3255         Reviewed by Geoffrey Garen.
3256
3257         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
3258         https://bugs.webkit.org/show_bug.cgi?id=59469
3259
3260         * platform/chromium/TraceEvent.h:
3261         (WebCore::internal::ScopeTracer::ScopeTracer):
3262
3263 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3264
3265         Reviewed by Oliver Hunt.
3266
3267         Nixed special finalizer handling for WebCore strings
3268         https://bugs.webkit.org/show_bug.cgi?id=59425
3269
3270         Not needed anymore, since weak handles have finalizers.
3271
3272         * WebCore.exp.in: Exports!
3273
3274         * bindings/js/DOMWrapperWorld.cpp:
3275         (WebCore::JSStringOwner::finalize):
3276         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
3277         so we don't need special treatment anymore.
3278
3279         * bindings/js/DOMWrapperWorld.h:
3280         (WebCore::JSStringOwner::JSStringOwner):
3281         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
3282         instead of a WeakGCMap, so we can specify a custom finalizer.
3283
3284         * bindings/js/JSDOMBinding.cpp:
3285         (WebCore::jsStringSlowCase):
3286         * bindings/js/JSDOMBinding.h:
3287         (WebCore::jsString): Updated for string map change.
3288
3289 2011-04-26  David Kilzer  <ddkilzer@apple.com>
3290
3291         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
3292
3293         Reviewed by Antti Koivisto.
3294
3295         To enable HTTP pipelining post-SnowLeopard, use this command:
3296
3297             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
3298
3299         * platform/network/cf/ResourceRequestCFNet.cpp:
3300         (WebCore::readBooleanPreference): Re-added.  Originally added in
3301         r76756 and removed in r84120.
3302         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
3303         HTTP pipelining if use default is set to true.  Added macro
3304         guards to match those in ResourceRequestMac.mm.
3305
3306 2011-04-26  Antti Koivisto  <antti@apple.com>
3307
3308         Reviewed by Adele Peterson.
3309
3310         Don't strip fragments from file: urls in memory cache
3311         https://bugs.webkit.org/show_bug.cgi?id=59463
3312         <rdar://problem/9231130>
3313
3314         Some clients expect file: resources to be unique based on fragment identifier. 
3315         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
3316
3317         Test: fast/loader/file-protocol-fragment.html
3318
3319         * loader/cache/MemoryCache.cpp:
3320         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
3321
3322 2011-04-26  David Levin  <levin@chromium.org>
3323
3324         Reviewed by Darin Adler.
3325
3326         Fix more strict OwnPtr in WebCore (round N).
3327         https://bugs.webkit.org/show_bug.cgi?id=59464
3328
3329         * dom/Document.cpp:
3330         (WebCore::Document::Document):
3331         (WebCore::Document::attach):
3332         * fileapi/FileReader.cpp:
3333         (WebCore::FileReader::terminate):
3334         * loader/DocumentThreadableLoader.cpp:
3335         (WebCore::DocumentThreadableLoader::preflightFailure):
3336         * workers/DefaultSharedWorkerRepository.cpp:
3337         (WebCore::SharedWorkerConnectTask::create):
3338         (WebCore::SharedWorkerScriptLoader::load):
3339
3340 2011-04-26  Ruben  <chromium@hybridsource.org>
3341
3342         Reviewed by Tony Chang.
3343
3344         Change linux ifdefs for Chromium to Unix instead, allowing
3345         new Unix ports to be enabled by default
3346         https://bugs.webkit.org/show_bug.cgi?id=59297
3347
3348         No new tests, just changing preprocessor defines.
3349
3350         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3351         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3352         * dom/SelectElement.cpp:
3353         * loader/cache/CachedFont.cpp:
3354         * page/EventHandler.cpp:
3355         * page/chromium/EventHandlerChromium.cpp:
3356         * platform/Scrollbar.cpp:
3357         * platform/chromium/PlatformBridge.h:
3358         * platform/graphics/chromium/FontPlatformData.h:
3359         * platform/graphics/skia/FontCustomPlatformData.cpp:
3360         * platform/graphics/skia/FontCustomPlatformData.h:
3361
3362 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
3363
3364         Reviewed by Dan Bernstein.
3365
3366         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
3367         https://bugs.webkit.org/show_bug.cgi?id=49111
3368
3369         Even when the offset corresponds to a position visually left of the box
3370         and there aren't any inline boxes on the left, the previous/next position
3371         may still correspond to some position in the same line.
3372
3373         The bug was caused by our ignoring such cases. Fixed the bug by comparing
3374         previous/next position's inline box to the current box. If they match,
3375         then we stay on the same position because moving to the left visually at
3376         the left edge should not result in a position on the same line.
3377
3378         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
3379         the left edge or to the right edge, and a bug that WebKit could not move to
3380         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
3381
3382         Test cases are added to editing/selection/move-left-right.html
3383
3384         * editing/VisiblePosition.cpp:
3385         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
3386         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
3387
3388 2011-04-26  Gabor Loki  <loki@webkit.org>
3389
3390         Reviewed by Csaba Osztrogonác.
3391
3392         Speeding up SVG filters with multicore (SMP) support
3393         https://bugs.webkit.org/show_bug.cgi?id=43903
3394
3395         Some SVG filters execute a huge number of pixel manipulations, which
3396         cannot be sped up by graphics accelerators, since their algorithm is
3397         too complex. Using the power of Symmetric Multi Processing (SMP) we
3398         can split up a task to smaller (data independent) tasks, which can be
3399         executed independently.
3400
3401         The ParallelJobs framework provides a simple way for distributed
3402         programming. The framework is based on WebKit's threading infrastructure,
3403         Open Multi-Processing's (OpenMP) API, and libdispatch API.
3404
3405         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
3406         * platform/graphics/filters/FETurbulence.cpp:
3407         (WebCore::FETurbulence::PaintingData::PaintingData):
3408         (WebCore::FETurbulence::noise2D):
3409         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
3410         (WebCore::FETurbulence::fillRegion):
3411         (WebCore::FETurbulence::fillRegionWorker):
3412         (WebCore::FETurbulence::apply):
3413         * platform/graphics/filters/FETurbulence.h:
3414
3415 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3416
3417         Reviewed by Yury Semikhatsky.
3418
3419         Web Inspector: close button is off in docked mode on a mac.
3420         https://bugs.webkit.org/show_bug.cgi?id=59453
3421
3422         * inspector/front-end/inspector.css:
3423         (.toolbar-item.close-left):
3424
3425 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3426
3427         Reviewed by Yury Semikhatsky.
3428
3429         Web Inspector: New Style is not working (UI glitch)
3430         https://bugs.webkit.org/show_bug.cgi?id=59451
3431
3432         * inspector/InspectorDOMStorageAgent.cpp:
3433         (WebCore::InspectorDOMStorageAgent::setFrontend):
3434         * inspector/front-end/AuditRules.js:
3435         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
3436         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
3437         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
3438         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
3439         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
3440         * inspector/front-end/CSSStyleModel.js:
3441         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
3442         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
3443         (WebInspector.CSSStyleModel.prototype.addRule):
3444         (WebInspector.CSSStyleModel.prototype.addRule.callback):
3445         (WebInspector.CSSStyleModel.prototype._documentElementId):
3446         * inspector/front-end/DOMAgent.js:
3447         (WebInspector.DOMNode.prototype._addAttribute):
3448         (WebInspector.DOMNode.prototype.documentElement):
3449         * inspector/front-end/ResourceTreeModel.js:
3450         (WebInspector.PageDispatcher.prototype.frameDetached):
3451         * inspector/front-end/StylesSidebarPane.js:
3452         (WebInspector.StylesSidebarPane.prototype._createNewRule):
3453
3454 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3455
3456         Reviewed by Yury Semikhatsky.
3457
3458         Web Inspector: introduce DOMStorage::enable and disable.
3459         https://bugs.webkit.org/show_bug.cgi?id=59445
3460
3461         * inspector/Inspector.json:
3462         * inspector/InspectorAgent.cpp:
3463         (WebCore::InspectorAgent::InspectorAgent):
3464         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3465         * inspector/InspectorDOMStorageAgent.cpp:
3466         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
3467         (WebCore::InspectorDOMStorageAgent::restore):
3468         (WebCore::InspectorDOMStorageAgent::enable):
3469         (WebCore::InspectorDOMStorageAgent::disable):
3470         * inspector/InspectorDOMStorageAgent.h:
3471         (WebCore::InspectorDOMStorageAgent::create):
3472         * inspector/front-end/DOMStorage.js:
3473         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3474         * inspector/front-end/ResourcesPanel.js:
3475         (WebInspector.ResourcesPanel.prototype._reset):
3476         * inspector/front-end/inspector.js:
3477
3478 2011-04-26  Pavel Feldman  <pfeldman@google.com>
3479
3480         Reviewed by Yury Semikhatsky.
3481
3482         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
3483         https://bugs.webkit.org/show_bug.cgi?id=59440
3484
3485         * inspector/Inspector.json:
3486         * inspector/InspectorAgent.cpp:
3487         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3488         * inspector/InspectorPageAgent.cpp:
3489         (WebCore::InspectorPageAgent::setFrontend):
3490         (WebCore::InspectorPageAgent::frameNavigated):
3491         * inspector/InspectorPageAgent.h:
3492         * inspector/front-end/AuditsPanel.js:
3493         (WebInspector.AuditsPanel):
3494         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
3495         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
3496         * inspector/front-end/CSSStyleModel.js:
3497         (WebInspector.CSSStyleModelResourceBinding):
3498         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
3499         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3500         (WebInspector.DOMBreakpointsSidebarPane):
3501         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
3502         * inspector/front-end/DOMStorage.js:
3503         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
3504         * inspector/front-end/ExtensionServer.js:
3505         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
3506         (WebInspector.ExtensionServer.prototype.initExtensions):
3507         * inspector/front-end/NetworkPanel.js:
3508         (WebInspector.NetworkPanel):
3509         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
3510         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
3511         (WebInspector.NetworkPanel.prototype._frameNavigated):
3512         * inspector/front-end/ResourceTreeModel.js:
3513         (WebInspector.ResourceTreeModel):
3514         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3515         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
3516         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3517         (WebInspector.ResourceTreeModel.prototype._frameDetached):
3518         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
3519         (WebInspector.PageDispatcher):
3520         (WebInspector.PageDispatcher.prototype.domContentEventFired):
3521         (WebInspector.PageDispatcher.prototype.loadEventFired):
3522         (WebInspector.PageDispatcher.prototype.frameNavigated):
3523         (WebInspector.PageDispatcher.prototype.frameDetached):
3524         * inspector/front-end/ResourcesPanel.js:
3525         (WebInspector.ResourcesPanel):
3526         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
3527         (WebInspector.ResourcesPanel.prototype._frameNavigated):
3528         * inspector/front-end/inspector.js:
3529
3530 2011-04-26  Csaba Osztrogonác  <ossy@webkit.org>
3531
3532         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
3533         because it broke transitions/multiple-text-shadow-transition.html
3534
3535         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3536         https://bugs.webkit.org/show_bug.cgi?id=59377
3537
3538         * css/CSSStyleSelector.cpp:
3539         (WebCore::CSSStyleSelector::applyProperty):
3540         * page/animation/AnimationBase.cpp:
3541         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3542         (WebCore::PropertyWrapperShadow::blend):
3543         * rendering/style/RenderStyle.cpp:
3544         (WebCore::RenderStyle::setTextShadow):
3545         (WebCore::RenderStyle::setBoxShadow):
3546         * rendering/style/RenderStyle.h:
3547         (WebCore::InheritedFlags::textShadow):
3548         * rendering/style/StyleRareInheritedData.cpp:
3549         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3550         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3551         * rendering/style/StyleRareInheritedData.h:
3552         * rendering/style/StyleRareNonInheritedData.cpp:
3553         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3554
3555 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
3556
3557         Reviewed by Adam Barth.
3558
3559         Turn off make built-in implicit rules for derived sources makefile
3560         https://bugs.webkit.org/show_bug.cgi?id=59418
3561
3562         We don't use any of make's built-in implicit rules, turning them off
3563         speeds up parsing of the makefile.
3564
3565         * WebCore.xcodeproj/project.pbxproj:
3566         * gyp/generate-derived-sources.sh:
3567
3568 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
3569
3570         Reviewed by Nikolas Zimmermann.
3571
3572         ASSERT failure in SVGUseElement
3573         https://bugs.webkit.org/show_bug.cgi?id=59313
3574
3575         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3576         was wrong because the document may not be well-formed.
3577
3578         This patch asserts the element is not pending on resource or the
3579         document is not well-formed.
3580
3581         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3582
3583         * svg/SVGUseElement.cpp:
3584         (WebCore::isWellFormedDocument):
3585         (WebCore::SVGUseElement::insertedIntoDocument):
3586
3587 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
3588
3589         Reviewed by Pavel Feldman.
3590
3591         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
3592         https://bugs.webkit.org/show_bug.cgi?id=59438
3593
3594         * inspector/front-end/DetailedHeapshotView.js:
3595         (WebInspector.DetailedHeapshotView.prototype._changeView):
3596
3597 2011-04-26  David Levin  <levin@chromium.org>
3598
3599         Reviewed by Adam Barth.
3600
3601         Fix a few OwnPtr strict errors in WebCore headers.
3602         https://bugs.webkit.org/show_bug.cgi?id=59431
3603
3604         * bindings/js/ScheduledAction.cpp:
3605         (WebCore::ScheduledAction::create):
3606         * css/MediaQueryMatcher.cpp:
3607         (WebCore::MediaQueryMatcher::prepareEvaluator):
3608         * dom/NodeRareData.h:
3609         (WebCore::NodeListsNodeData::create):
3610         * dom/ScriptRunner.h:
3611         (WebCore::ScriptRunner::create):
3612         * inspector/WorkerInspectorController.cpp:
3613         (WebCore::WorkerInspectorController::connectFrontend):
3614         * loader/icon/IconDatabase.h:
3615         (WebCore::IconDatabase::create):
3616         * platform/graphics/SimpleFontData.cpp:
3617         (WebCore::SimpleFontData::verticalRightOrientationFontData):
3618         (WebCore::SimpleFontData::uprightOrientationFontData):
3619         (WebCore::SimpleFontData::brokenIdeographFontData):
3620         * rendering/style/StyleRareInheritedData.cpp:
3621         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3622         * rendering/svg/SVGResources.h:
3623         (WebCore::SVGResources::ClipperFilterMaskerData::create):
3624         (WebCore::SVGResources::MarkerData::create):
3625         (WebCore::SVGResources::FillStrokeData::create):
3626         * storage/StorageSyncManager.cpp:
3627         (WebCore::StorageSyncManager::close):
3628         * workers/WorkerContext.cpp:
3629         (WebCore::CloseWorkerContextTask::create):
3630         * workers/WorkerMessagingProxy.cpp:
3631         (WebCore::MessageWorkerContextTask::create):
3632         (WebCore::MessageWorkerTask::create):
3633         (WebCore::WorkerExceptionTask::create):
3634         (WebCore::WorkerContextDestroyedTask::create):
3635         (WebCore::WorkerTerminateTask::create):
3636         (WebCore::WorkerThreadActivityReportTask::create):
3637         * workers/WorkerRunLoop.cpp:
3638         (WebCore::WorkerRunLoop::Task::create):
3639         * workers/WorkerThread.cpp:
3640         (WebCore::WorkerThreadStartupData::create):
3641         (WebCore::WorkerThreadShutdownFinishTask::create):
3642         (WebCore::WorkerThreadShutdownStartTask::create):
3643
3644 2011-04-26  Adam Klein  <adamk@chromium.org>
3645
3646         Reviewed by Adam Barth.
3647
3648         Fix last strict OwnPtr violation under svg/...
3649         https://bugs.webkit.org/show_bug.cgi?id=59429
3650
3651         * svg/SVGDocumentExtensions.cpp:
3652         (WebCore::SVGDocumentExtensions::removePendingResource):
3653
3654 2011-04-26  Adam Barth  <abarth@webkit.org>
3655
3656         Reviewed by David Levin.
3657
3658         Fix more strict OwnPtr violations in WebCore
3659         https://bugs.webkit.org/show_bug.cgi?id=59433
3660
3661         These manifest in the Chromium build.
3662
3663         * bindings/v8/ScriptController.cpp:
3664         (WebCore::ScriptController::ScriptController):
3665         * bindings/v8/ScriptDebugServer.cpp:
3666         (WebCore::ScriptDebugServer::editScriptSource):
3667         * bindings/v8/V8DOMMap.cpp:
3668         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
3669         * bindings/v8/V8Proxy.cpp:
3670         (WebCore::V8Proxy::precompileScript):
3671         * bindings/v8/WorkerScriptController.cpp:
3672         (WebCore::WorkerScriptController::WorkerScriptController):
3673         * page/Page.cpp:
3674         (WebCore::Page::Page):
3675         (WebCore::Page::speechInput):
3676         * platform/PlatformGestureRecognizer.cpp:
3677         (WebCore::PlatformGestureRecognizer::create):
3678         * platform/PlatformGestureRecognizer.h:
3679         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3680         (WebCore::DrawingBuffer::DrawingBuffer):
3681         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3682         (WebCore::CCLayerImpl::CCLayerImpl):
3683         * platform/graphics/gpu/Texture.cpp:
3684         (WebCore::Texture::create):
3685         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
3686         (WebCore::BMPImageDecoder::decodeHelper):
3687         * platform/image-decoders/gif/GIFImageDecoder.cpp:
3688         (WebCore::GIFImageDecoder::decode):
3689         * platform/image-decoders/ico/ICOImageDecoder.cpp:
3690         (WebCore::ICOImageDecoder::decodeAtIndex):
3691         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3692         (WebCore::JPEGImageDecoder::decode):
3693         * platform/image-decoders/png/PNGImageDecoder.cpp:
3694         (WebCore::PNGImageDecoder::decode):
3695         * storage/chromium/DatabaseTrackerChromium.cpp:
3696         (WebCore::DatabaseTracker::addOpenDatabase):
3697
3698 2011-04-25  David Levin  <levin@chromium.org>
3699
3700         Reviewed by Adam Barth.
3701
3702         Fix OwnPtr strict errors in CrossThreadTask.h
3703         https://bugs.webkit.org/show_bug.cgi?id=59427
3704
3705         * dom/CrossThreadTask.h:
3706         (WebCore::CrossThreadTask1::create):
3707         (WebCore::CrossThreadTask2::create):
3708         (WebCore::CrossThreadTask3::create):
3709         (WebCore::CrossThreadTask4::create):
3710         (WebCore::CrossThreadTask5::create):
3711         (WebCore::CrossThreadTask6::create):
3712         (WebCore::CrossThreadTask7::create):
3713         (WebCore::CrossThreadTask8::create):
3714
3715 2011-04-25  Mark Rowe  <mrowe@apple.com>
3716
3717         Reviewed by Dan Bernstein.
3718
3719         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3720
3721         * css/CSSStyleApplyProperty.cpp:
3722         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3723         * css/CSSStyleApplyProperty.h:
3724         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3725
3726 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3727
3728         Reviewed by Ryosuke Niwa.
3729
3730         REGRESSION: a character appears after tab span when typing immediately before the tab span
3731         https://bugs.webkit.org/show_bug.cgi?id=58132
3732
3733         Correcting the order of operations we use to avoid inserting into invalid positions in
3734         ReplaceSelectionCommand to avoid inserting into tab-spans.
3735
3736         Test: editing/pasteboard/paste-before-tab-span.html
3737
3738         * editing/ReplaceSelectionCommand.cpp:
3739         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3740         positionAvoidingPrecedingNodes, since that function could once again put our position
3741         inside a tab span.
3742
3743 2011-04-25  David Levin  <levin@chromium.org>
3744
3745         Reviewed by Adam Barth.
3746
3747         Fix OwnPtr strict error in ImageBuffer.h
3748         https://bugs.webkit.org/show_bug.cgi?id=59422
3749
3750         * platform/graphics/ImageBuffer.h:
3751         (WebCore::ImageBuffer::create):
3752
3753 2011-04-25  Adam Barth  <abarth@webkit.org>
3754
3755         Reviewed by David Levin.
3756
3757         Fix strict OwnPtr violations and whitelist known-tricky files
3758         https://bugs.webkit.org/show_bug.cgi?id=59421
3759
3760         With this patch, WebCore builds cleanly with strict OwnPtrs.
3761
3762         * dom/MessagePort.cpp:
3763         (WebCore::MessagePort::MessagePort):
3764         * dom/XMLDocumentParserLibxml2.cpp:
3765         * page/ContextMenuController.cpp:
3766         (WebCore::ContextMenuController::ContextMenuController):
3767         (WebCore::ContextMenuController::clearContextMenu):
3768         * page/PluginHalter.cpp:
3769         * platform/graphics/MediaPlayer.cpp:
3770         * platform/network/ResourceRequestBase.cpp:
3771         (WebCore::ResourceRequestBase::adopt):
3772         (WebCore::ResourceRequestBase::copyData):
3773         * svg/SVGDocumentExtensions.cpp:
3774
3775 2011-04-25  David Levin  <levin@chromium.org>
3776
3777         Reviewed by Adam Barth.
3778
3779         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3780         https://bugs.webkit.org/show_bug.cgi?id=59419
3781
3782         * dom/DatasetDOMStringMap.h:
3783         (WebCore::DatasetDOMStringMap::create):
3784
3785 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3786
3787         Reviewed by Eric Seidel.
3788
3789         KeyboardEvent.cpp should work with strict OwnPtrs.
3790         https://bugs.webkit.org/show_bug.cgi?id=59403
3791
3792         * dom/KeyboardEvent.cpp:
3793         (WebCore::KeyboardEvent::KeyboardEvent):
3794
3795 2011-04-25  James Robinson  <jamesr@chromium.org>
3796
3797         Reviewed by Eric Seidel.
3798
3799         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3800         https://bugs.webkit.org/show_bug.cgi?id=59377
3801
3802         * css/CSSStyleSelector.cpp:
3803         (WebCore::CSSStyleSelector::applyProperty):
3804         * page/animation/AnimationBase.cpp:
3805         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3806         (WebCore::PropertyWrapperShadow::blend):
3807         * rendering/style/RenderStyle.cpp:
3808         (WebCore::RenderStyle::setTextShadow):
3809         (WebCore::RenderStyle::setBoxShadow):
3810         * rendering/style/RenderStyle.h:
3811         (WebCore::InheritedFlags::textShadow):
3812         * rendering/style/StyleRareInheritedData.cpp:
3813         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3814         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3815         * rendering/style/StyleRareInheritedData.h:
3816         * rendering/style/StyleRareNonInheritedData.cpp:
3817         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3818
3819 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3820
3821         Unreviewed, rolling out r84864.
3822         http://trac.webkit.org/changeset/84864
3823         https://bugs.webkit.org/show_bug.cgi?id=59413
3824
3825         Expect result of use-crash-in-non-wellformed-document.svg is
3826         platform dependent (Requested by leoyang on #webkit).
3827
3828         * svg/SVGUseElement.cpp:
3829         (WebCore::SVGUseElement::insertedIntoDocument):
3830
3831 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3832
3833         Reviewed by Nikolas Zimmermann.
3834
3835         ASSERT failure in SVGUseElement
3836         https://bugs.webkit.org/show_bug.cgi?id=59313
3837
3838         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3839         was wrong because the document may not be well-formed.
3840
3841         This patch asserts the element is not pending on resource or the
3842         document is not well-formed.
3843
3844         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3845
3846         * svg/SVGUseElement.cpp:
3847         (WebCore::isWellFormedDocument):
3848         (WebCore::SVGUseElement::insertedIntoDocument):
3849
3850 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3851
3852         Reviewed by Tony Chang.
3853
3854         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3855         https://bugs.webkit.org/show_bug.cgi?id=59028
3856
3857         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3858         Moving the code for base class we can reduce the efforts to support DataTransferItems
3859         element in different platforms.
3860
3861         * Android.mk:
3862         * CMakeLists.txt:
3863         * GNUmakefile.list.am:
3864         * WebCore.gypi:
3865         * WebCore.pro:
3866         * WebCore.vcproj/WebCore.vcproj:
3867         * WebCore.xcodeproj/project.pbxproj:
3868         * dom/DataTransferItem.cpp:
3869         (WebCore::DataTransferItem::DataTransferItem):
3870         (WebCore::DataTransferItem::owner):
3871         (WebCore::DataTransferItem::kind):
3872         (WebCore::DataTransferItem::type):
3873         * dom/DataTransferItem.h:
3874         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3875         (WebCore::DataTransferItems::DataTransferItems):
3876         (WebCore::DataTransferItems::length):
3877         (WebCore::DataTransferItems::item):
3878         (WebCore::DataTransferItems::deleteItem):
3879         (WebCore::DataTransferItems::clear):
3880         (WebCore::DataTransferItems::add):
3881         * dom/DataTransferItems.h:
3882         * platform/chromium/DataTransferItemChromium.cpp:
3883         (WebCore::DataTransferItem::create):
3884         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3885         (WebCore::DataTransferItemChromium::getAsString):
3886         (WebCore::DataTransferItemChromium::getAsFile):
3887         * platform/chromium/DataTransferItemChromium.h:
3888         * platform/chromium/DataTransferItemsChromium.cpp:
3889         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3890         * platform/chromium/DataTransferItemsChromium.h:
3891
3892 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3893
3894         Reviewed by Simon Fraser.
3895
3896         REGRESSION(75137): directly composited images are double-drawn sometimes
3897         https://bugs.webkit.org/show_bug.cgi?id=58632
3898
3899         Depending on the order of operations (layout, creating compositing 
3900         layers and creating simple image layers) a layer can have both image
3901         content and have m_drawsContent=true. In this case 2 copies of the image
3902         are drawn in the layer. If the image has alpha, it looks wrong.
3903
3904         I added an updateDrawsContent() call after setting the image contents
3905         to make sure it's correct.
3906
3907         I couldn't create a test case that shows the problem because layerTreeAsText()
3908         doesn't emit enough info to show this level of detail. I've opened
3909         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3910
3911         * rendering/RenderLayerBacking.cpp:
3912         (WebCore::RenderLayerBacking::updateImageContents):
3913
3914 2011-04-25  Kenneth Russell  <kbr@google.com>
3915
3916         Reviewed by David Levin.
3917
3918         Fix OwnPtr strict errors in InlineFlowBox.cpp
3919         https://bugs.webkit.org/show_bug.cgi?id=59392
3920
3921         * rendering/InlineFlowBox.cpp:
3922         (WebCore::InlineFlowBox::setLayoutOverflow):
3923         (WebCore::InlineFlowBox::setVisualOverflow):
3924
3925 2011-04-25  Kenneth Russell  <kbr@google.com>
3926
3927         Reviewed by David Levin.
3928
3929         Fix OwnPtr strict errors in TransformState.cpp
3930         https://bugs.webkit.org/show_bug.cgi?id=59380
3931
3932         * rendering/TransformState.cpp:
3933         (WebCore::TransformState::applyTransform):
3934
3935 2011-04-25  Adam Barth  <abarth@webkit.org>
3936
3937         Reviewed by James Robinson.
3938
3939         DOMWindow.cpp should work with strict OwnPtrs
3940         https://bugs.webkit.org/show_bug.cgi?id=59356
3941
3942         * page/DOMWindow.cpp:
3943         (WebCore::PostMessageTimer::fired):
3944         (WebCore::DOMWindow::postMessageTimerFired):
3945         * page/DOMWindow.h:
3946
3947 2011-04-25  Adam Klein  <adamk@chromium.org>
3948
3949         Reviewed by James Robinson.
3950
3951         Fix OwnPtr strict errors in some SVG classes.
3952         https://bugs.webkit.org/show_bug.cgi?id=59395
3953
3954         * rendering/style/SVGRenderStyleDefs.cpp:
3955         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3956         * svg/SVGSVGElement.cpp:
3957         (WebCore::SVGSVGElement::SVGSVGElement):
3958         * svg/SVGStyledTransformableElement.cpp:
3959         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3960         * svg/SVGTextElement.cpp:
3961         (WebCore::SVGTextElement::supplementalTransform):
3962         * svg/graphics/SVGImage.cpp:
3963         (WebCore::SVGImage::dataChanged):
3964
3965 2011-04-25  Adam Barth  <abarth@webkit.org>
3966
3967         Re-land changes to ValidationMessage.
3968
3969         * html/ValidationMessage.cpp:
3970         (WebCore::ValidationMessage::setMessage):
3971         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3972         (WebCore::ValidationMessage::requestToHideMessage):
3973
3974 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3975
3976         Reviewed by James Robinson.
3977
3978         fix OwnPtr strict error in FrameView.cpp
3979         https://bugs.webkit.org/show_bug.cgi?id=59402
3980
3981         * page/FrameView.cpp:
3982         (WebCore::FrameView::FrameView):
3983         (WebCore::FrameView::addWidgetToUpdate):
3984
3985 2011-04-25  Adam Klein  <adamk@chromium.org>
3986
3987         Unreviewed, rolling out r84844.
3988         http://trac.webkit.org/changeset/84844
3989         https://bugs.webkit.org/show_bug.cgi?id=59395
3990
3991         Checked in too much.
3992
3993         * rendering/style/SVGRenderStyleDefs.cpp:
3994         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3995         * svg/SVGDocumentExtensions.cpp:
3996         (WebCore::SVGDocumentExtensions::removePendingResource):
3997         * svg/SVGSVGElement.cpp:
3998         (WebCore::SVGSVGElement::SVGSVGElement):
3999         * svg/SVGStyledTransformableElement.cpp:
4000         (WebCore::SVGStyledTransformableElement::supplementalTransform):
4001         * svg/SVGTextElement.cpp:
4002         (WebCore::SVGTextElement::supplementalTransform):
4003         * svg/graphics/SVGImage.cpp:
4004         (WebCore::SVGImage::dataChanged):
4005
4006 2011-04-25  Adrienne Walker  <enne@google.com>
4007
4008         Reviewed by David Levin.
4009
4010         Make ActiveDOMCallback play nice with OwnPtr strict mode
4011         https://bugs.webkit.org/show_bug.cgi?id=59398
4012
4013         * bindings/generic/ActiveDOMCallback.cpp:
4014         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
4015
4016 2011-04-25  Adam Klein  <adamk@chromium.org>
4017
4018         Reviewed by James Robinson.
4019
4020         Fix OwnPtr strict errors in some SVG classes.
4021         https://bugs.webkit.org/show_bug.cgi?id=59395
4022
4023         * rendering/style/SVGRenderStyleDefs.cpp:
4024         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
4025         * svg/SVGSVGElement.cpp:
4026         (WebCore::SVGSVGElement::SVGSVGElement):
4027         * svg/SVGStyledTransformableElement.cpp:
4028         (WebCore::SVGStyledTransformableElement::supplementalTransform):
4029         * svg/SVGTextElement.cpp:
4030         (WebCore::SVGTextElement::supplementalTransform):
4031         * svg/graphics/SVGImage.cpp:
4032         (WebCore::SVGImage::dataChanged):
4033
4034 2011-04-25  James Robinson  <jamesr@chromium.org>
4035
4036         Unreviewed, rolling out r84835.
4037         http://trac.webkit.org/changeset/84835
4038         https://bugs.webkit.org/show_bug.cgi?id=59394
4039
4040         Breaks compile because Deque<OwnPtr> doesn't work
4041
4042         * dom/XMLDocumentParserLibxml2.cpp:
4043         (WebCore::PendingCallbacks::~PendingCallbacks):
4044         (WebCore::PendingCallbacks::appendStartElementNSCallback):
4045         (WebCore::PendingCallbacks::appendEndElementNSCallback):
4046         (WebCore::PendingCallbacks::appendCharactersCallback):
4047         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
4048         (WebCore::PendingCallbacks::appendCDATABlockCallback):
4049         (WebCore::PendingCallbacks::appendCommentCallback):
4050         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
4051         (WebCore::PendingCallbacks::appendErrorCallback):
4052         (WebCore::XMLDocumentParser::XMLDocumentParser):
4053         * html/ValidationMessage.cpp:
4054         (WebCore::ValidationMessage::setMessage):
4055         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
4056         (WebCore::ValidationMessage::requestToHideMessage):
4057
4058 2011-04-25  James Robinson  <jamesr@chromium.org>
4059
4060         Reviewed by Sam Weinig.
4061
4062         Fix OwnPtr strict mode violation in ImageBufferCG
4063         https://bugs.webkit.org/show_bug.cgi?id=59396
4064
4065         * platform/graphics/cg/ImageBufferCG.cpp:
4066         (WebCore::ImageBuffer::ImageBuffer):
4067
4068 2011-04-25  Huang Dongsung  <luxtella@company100.net>
4069
4070         Reviewed by Dirk Schulze.
4071
4072         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
4073         https://bugs.webkit.org/show_bug.cgi?id=59308
4074
4075         An unused local variable is created and even allocates heap memory.
4076
4077         * platform/graphics/skia/PlatformContextSkia.cpp:
4078         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
4079
4080 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
4081
4082         Qt build fix: Updated files not used by other ports for rename.
4083
4084         * bindings/js/JSTouchCustom.cpp:
4085         (WebCore::toJSNewlyCreated):
4086         * bindings/js/JSTouchListCustom.cpp:
4087         (WebCore::toJSNewlyCreated):
4088
4089 2011-04-25  Adrienne Walker  <enne@google.com>
4090
4091         Reviewed by David Levin.
4092
4093         WebCore/css/CSS* files should play nice with strict OwnPtrs
4094         https://bugs.webkit.org/show_bug.cgi?id=59382
4095
4096         * css/CSSFontFaceSource.cpp:
4097         (WebCore::CSSFontFaceSource::getFontData):
4098         * css/CSSParser.cpp:
4099         (WebCore::CSSParser::addProperty):
4100         (WebCore::CSSParser::parseValue):
4101
4102 2011-04-25  Adam Barth  <abarth@webkit.org>